[jira] [Work logged] (BEAM-9326) JsonToRow transform should not use bounded Wildcards for its input
[ https://issues.apache.org/jira/browse/BEAM-9326?focusedWorklogId=389661=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389661 ] ASF GitHub Bot logged work on BEAM-9326: Author: ASF GitHub Bot Created on: 19/Feb/20 22:25 Start Date: 19/Feb/20 22:25 Worklog Time Spent: 10m Work Description: iemejia commented on issue #10879: [BEAM-9326] Make JsonToRow transform input instead of URL: https://github.com/apache/beam/pull/10879#issuecomment-588504481 Yes it is already reverted, for the `PipelineTest` class, for `JsonToRow` we are good to go. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 389661) Time Spent: 1h 10m (was: 1h) > JsonToRow transform should not use bounded Wildcards for its input > -- > > Key: BEAM-9326 > URL: https://issues.apache.org/jira/browse/BEAM-9326 > Project: Beam > Issue Type: Improvement > Components: sdk-java-core >Reporter: Ismaël Mejía >Assignee: Ismaël Mejía >Priority: Minor > Fix For: 2.20.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > The JsonToRow PTransform input is a String (a final class in Java) so no > reason > to define a bounded wildcard as its argument. > We should use in Beam's codebase only when required by Java > Generics constraints. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9326) JsonToRow transform should not use bounded Wildcards for its input
[ https://issues.apache.org/jira/browse/BEAM-9326?focusedWorklogId=389658=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389658 ] ASF GitHub Bot logged work on BEAM-9326: Author: ASF GitHub Bot Created on: 19/Feb/20 22:14 Start Date: 19/Feb/20 22:14 Worklog Time Spent: 10m Work Description: kennknowles commented on issue #10879: [BEAM-9326] Make JsonToRow transform input instead of URL: https://github.com/apache/beam/pull/10879#issuecomment-588499498 Yikes! If removing `` makes it impossible to treat this class as a `PTransform` then I think this change should be reverted. Indeed I wondered if there was something funky going to happy in Java's type checking. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 389658) Time Spent: 1h (was: 50m) > JsonToRow transform should not use bounded Wildcards for its input > -- > > Key: BEAM-9326 > URL: https://issues.apache.org/jira/browse/BEAM-9326 > Project: Beam > Issue Type: Improvement > Components: sdk-java-core >Reporter: Ismaël Mejía >Assignee: Ismaël Mejía >Priority: Minor > Fix For: 2.20.0 > > Time Spent: 1h > Remaining Estimate: 0h > > The JsonToRow PTransform input is a String (a final class in Java) so no > reason > to define a bounded wildcard as its argument. > We should use in Beam's codebase only when required by Java > Generics constraints. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9326) JsonToRow transform should not use bounded Wildcards for its input
[ https://issues.apache.org/jira/browse/BEAM-9326?focusedWorklogId=389617=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389617 ] ASF GitHub Bot logged work on BEAM-9326: Author: ASF GitHub Bot Created on: 19/Feb/20 21:07 Start Date: 19/Feb/20 21:07 Worklog Time Spent: 10m Work Description: iemejia commented on issue #10879: [BEAM-9326] Make JsonToRow transform input instead of URL: https://github.com/apache/beam/pull/10879#issuecomment-588470766 Merged manually with the fixes This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 389617) Time Spent: 40m (was: 0.5h) > JsonToRow transform should not use bounded Wildcards for its input > -- > > Key: BEAM-9326 > URL: https://issues.apache.org/jira/browse/BEAM-9326 > Project: Beam > Issue Type: Improvement > Components: sdk-java-core >Reporter: Ismaël Mejía >Assignee: Ismaël Mejía >Priority: Minor > Fix For: 2.20.0 > > Time Spent: 40m > Remaining Estimate: 0h > > The JsonToRow PTransform input is a String (a final class in Java) so no > reason > to define a bounded wildcard as its argument. > We should use in Beam's codebase only when required by Java > Generics constraints. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9326) JsonToRow transform should not use bounded Wildcards for its input
[ https://issues.apache.org/jira/browse/BEAM-9326?focusedWorklogId=389618=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389618 ] ASF GitHub Bot logged work on BEAM-9326: Author: ASF GitHub Bot Created on: 19/Feb/20 21:07 Start Date: 19/Feb/20 21:07 Worklog Time Spent: 10m Work Description: iemejia commented on pull request #10879: [BEAM-9326] Make JsonToRow transform input instead of URL: https://github.com/apache/beam/pull/10879 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 389618) Time Spent: 50m (was: 40m) > JsonToRow transform should not use bounded Wildcards for its input > -- > > Key: BEAM-9326 > URL: https://issues.apache.org/jira/browse/BEAM-9326 > Project: Beam > Issue Type: Improvement > Components: sdk-java-core >Reporter: Ismaël Mejía >Assignee: Ismaël Mejía >Priority: Minor > Fix For: 2.20.0 > > Time Spent: 50m > Remaining Estimate: 0h > > The JsonToRow PTransform input is a String (a final class in Java) so no > reason > to define a bounded wildcard as its argument. > We should use in Beam's codebase only when required by Java > Generics constraints. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9326) JsonToRow transform should not use bounded Wildcards for its input
[
https://issues.apache.org/jira/browse/BEAM-9326?focusedWorklogId=389616=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389616
]
ASF GitHub Bot logged work on BEAM-9326:
Author: ASF GitHub Bot
Created on: 19/Feb/20 21:05
Start Date: 19/Feb/20 21:05
Worklog Time Spent: 10m
Work Description: iemejia commented on pull request #10879: [BEAM-9326]
Make JsonToRow transform input instead of
URL: https://github.com/apache/beam/pull/10879#discussion_r381544015
##
File path: sdks/java/core/src/test/java/org/apache/beam/sdk/PipelineTest.java
##
@@ -225,7 +225,7 @@ public void testPipelineSDKExceptionHandling() {
@Test
@Category(ValidatesRunner.class)
public void testMultipleApply() {
-PTransform, PCollection> myTransform
= addSuffix("+");
+MapElements myTransform = addSuffix("+");
Review comment:
Yes I agree that the PTransform form is more abstract so better, but because
of the capricious Java bounds checking this is not possible without doing the
`` so I prefer to revert this change and let only the
JsonToRow one, which is the one I care about (and the real goal of this PR).
Thanks for the review Kenn.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 389616)
Time Spent: 0.5h (was: 20m)
> JsonToRow transform should not use bounded Wildcards for its input
> --
>
> Key: BEAM-9326
> URL: https://issues.apache.org/jira/browse/BEAM-9326
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
>Reporter: Ismaël Mejía
>Assignee: Ismaël Mejía
>Priority: Minor
> Fix For: 2.20.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The JsonToRow PTransform input is a String (a final class in Java) so no
> reason
> to define a bounded wildcard as its argument.
> We should use in Beam's codebase only when required by Java
> Generics constraints.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-9326) JsonToRow transform should not use bounded Wildcards for its input
[
https://issues.apache.org/jira/browse/BEAM-9326?focusedWorklogId=389543=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389543
]
ASF GitHub Bot logged work on BEAM-9326:
Author: ASF GitHub Bot
Created on: 19/Feb/20 18:17
Start Date: 19/Feb/20 18:17
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #10879:
[BEAM-9326] Make JsonToRow transform input instead of
URL: https://github.com/apache/beam/pull/10879#discussion_r381455475
##
File path: sdks/java/core/src/test/java/org/apache/beam/sdk/PipelineTest.java
##
@@ -239,8 +239,7 @@ public void testMultipleApply() {
pipeline.run();
}
- private static PTransform,
PCollection> addSuffix(
- final String suffix) {
+ private static MapElements addSuffix(final String suffix) {
Review comment:
Here, too.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 389543)
Time Spent: 20m (was: 10m)
> JsonToRow transform should not use bounded Wildcards for its input
> --
>
> Key: BEAM-9326
> URL: https://issues.apache.org/jira/browse/BEAM-9326
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
>Reporter: Ismaël Mejía
>Assignee: Ismaël Mejía
>Priority: Minor
> Fix For: 2.20.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The JsonToRow PTransform input is a String (a final class in Java) so no
> reason
> to define a bounded wildcard as its argument.
> We should use in Beam's codebase only when required by Java
> Generics constraints.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-9326) JsonToRow transform should not use bounded Wildcards for its input
[
https://issues.apache.org/jira/browse/BEAM-9326?focusedWorklogId=389544=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389544
]
ASF GitHub Bot logged work on BEAM-9326:
Author: ASF GitHub Bot
Created on: 19/Feb/20 18:17
Start Date: 19/Feb/20 18:17
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #10879:
[BEAM-9326] Make JsonToRow transform input instead of
URL: https://github.com/apache/beam/pull/10879#discussion_r381455388
##
File path: sdks/java/core/src/test/java/org/apache/beam/sdk/PipelineTest.java
##
@@ -225,7 +225,7 @@ public void testPipelineSDKExceptionHandling() {
@Test
@Category(ValidatesRunner.class)
public void testMultipleApply() {
-PTransform, PCollection> myTransform
= addSuffix("+");
+MapElements myTransform = addSuffix("+");
Review comment:
Suggest changing `? extends String` to just `String` but otherwise leaving
the type as `PTransform`. This is a good way to indicate that you don't intend
to use any other facts about the transform.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 389544)
Time Spent: 20m (was: 10m)
> JsonToRow transform should not use bounded Wildcards for its input
> --
>
> Key: BEAM-9326
> URL: https://issues.apache.org/jira/browse/BEAM-9326
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
>Reporter: Ismaël Mejía
>Assignee: Ismaël Mejía
>Priority: Minor
> Fix For: 2.20.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The JsonToRow PTransform input is a String (a final class in Java) so no
> reason
> to define a bounded wildcard as its argument.
> We should use in Beam's codebase only when required by Java
> Generics constraints.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (BEAM-9326) JsonToRow transform should not use bounded Wildcards for its input
[ https://issues.apache.org/jira/browse/BEAM-9326?focusedWorklogId=388245=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-388245 ] ASF GitHub Bot logged work on BEAM-9326: Author: ASF GitHub Bot Created on: 17/Feb/20 08:29 Start Date: 17/Feb/20 08:29 Worklog Time Spent: 10m Work Description: iemejia commented on pull request #10879: [BEAM-9326] Make JsonToRow transform input instead of URL: https://github.com/apache/beam/pull/10879 R: @kennknowles This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 388245) Remaining Estimate: 0h Time Spent: 10m > JsonToRow transform should not use bounded Wildcards for its input > -- > > Key: BEAM-9326 > URL: https://issues.apache.org/jira/browse/BEAM-9326 > Project: Beam > Issue Type: Improvement > Components: sdk-java-core >Reporter: Ismaël Mejía >Assignee: Ismaël Mejía >Priority: Minor > Fix For: 2.20.0 > > Time Spent: 10m > Remaining Estimate: 0h > > The JsonToRow PTransform input is a String (a final class in Java) so no > reason > to define a bounded wildcard as its argument. > We should use in Beam's codebase only when required by Java > Generics constraints. -- This message was sent by Atlassian Jira (v8.3.4#803005)
