[GitHub] sijie opened a new pull request #1324: Remove WriteFlags from public API

[GitBox]

sijie opened a new pull request #1324: Remove WriteFlags from public API
URL: https://github.com/apache/bookkeeper/pull/1324
 
 
   
   Descriptions of the changes in this PR:
   
   `DeferredSync` is not implemented at server side. So remove `withWriteFlags` 
from builder API.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sijie closed pull request #1323: Improve "Failed to resolve network location" logging

[GitBox]

sijie closed pull request #1323: Improve "Failed to resolve network location" 
logging
URL: https://github.com/apache/bookkeeper/pull/1323
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/net/BookieSocketAddress.java
 
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/net/BookieSocketAddress.java
index e7f980477..4e8f3246c 100644
--- 
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/net/BookieSocketAddress.java
+++ 
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/net/BookieSocketAddress.java
@@ -81,7 +81,8 @@ public InetSocketAddress getSocketAddress() {
  * Maps the socketAddress to a "local" address.
  */
 public LocalAddress getLocalAddress() {
-return new LocalAddress(socketAddress.toString());
+// for local address, we just need "port" to differentiate different 
addresses.
+return new LocalAddress("" + port);
 }
 
 // Return the String "serialized" version of this object.
diff --git 
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/net/ScriptBasedMapping.java
 
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/net/ScriptBasedMapping.java
index 49f3c9a70..8c8350c3f 100644
--- 
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/net/ScriptBasedMapping.java
+++ 
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/net/ScriptBasedMapping.java
@@ -145,6 +145,10 @@ public void setConf(Configuration conf) {
 scriptName = null;
 maxArgs = 0;
 }
+
+if (null == scriptName) {
+throw new RuntimeException("No network topology script is 
found when using script based DNS resolver.");
+}
 }
 
 /**


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sijie commented on issue #1323: Improve "Failed to resolve network location" logging

[GitBox]

sijie commented on issue #1323: Improve "Failed to resolve network location" 
logging
URL: https://github.com/apache/bookkeeper/pull/1323#issuecomment-379856172
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Jenkins build became unstable: bookkeeper_postcommit_master_java8 #96

[Apache Jenkins Server]

See 

Jenkins build became unstable: bookkeeper_release_branch #114

[Apache Jenkins Server]

See 

[GitHub] sijie commented on a change in pull request #1323: Improve "Failed to resolve network location" logging

[GitBox]

sijie commented on a change in pull request #1323: Improve "Failed to resolve 
network location" logging
URL: https://github.com/apache/bookkeeper/pull/1323#discussion_r180026757
 
 

 ##
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/net/BookieSocketAddress.java
 ##
 @@ -81,7 +81,8 @@ public InetSocketAddress getSocketAddress() {
  * Maps the socketAddress to a "local" address.
  */
 public LocalAddress getLocalAddress() {
-return new LocalAddress(socketAddress.toString());
+// for local address, we just need "port" to differentiate different 
addresses.
+return new LocalAddress("" + port);
 
 Review comment:
   because this change triggers different sequence on registering bookie 
address to LocalBookieRegistry, it fails NetworkLessTest. 
   
   "localhost/127.0.0.1" vs "127.0.0.1". (after DNS resolution vs before DNS 
resolution)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] eolivelli commented on a change in pull request #1323: Improve "Failed to resolve network location" logging

[GitBox]

eolivelli commented on a change in pull request #1323: Improve "Failed to 
resolve network location" logging
URL: https://github.com/apache/bookkeeper/pull/1323#discussion_r180024928
 
 

 ##
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/net/BookieSocketAddress.java
 ##
 @@ -81,7 +81,8 @@ public InetSocketAddress getSocketAddress() {
  * Maps the socketAddress to a "local" address.
  */
 public LocalAddress getLocalAddress() {
-return new LocalAddress(socketAddress.toString());
+// for local address, we just need "port" to differentiate different 
addresses.
+return new LocalAddress("" + port);
 
 Review comment:
   @sijie This change seems unrelated. Could you please tell why you need this 
change ?
   I am fine with it, but I am curious as I am an user of LocalAddresses.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] reddycharan commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

[GitBox]

reddycharan commented on a change in pull request #1281: Issue #570: 
Introducing EntryLogManager.
URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r180011787
 
 

 ##
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
 ##
 @@ -802,88 +881,230 @@ private long readLastLogId(File f) {
 }
 }
 
+interface EntryLogManager {
+/*
+ * acquire lock for this ledger.
+ */
+void acquireLock(Long ledgerId);
+
+/*
+ * acquire lock for this ledger if it is not already available for this
+ * ledger then it will create a new one and then acquire lock.
+ */
+void acquireLockByCreatingIfRequired(Long ledgerId);
+
+/*
+ * release lock for this ledger
+ */
+void releaseLock(Long ledgerId);
+
+/*
+ * sets the logChannel for the given ledgerId. The previous one will be
+ * removed from replicaOfCurrentLogChannels. Previous logChannel will 
be
+ * added to rotatedLogChannels.
+ */
+void setCurrentLogForLedger(Long ledgerId, BufferedLogChannel 
logChannel);
+
+/*
+ * gets the logChannel for the given ledgerId.
+ */
+BufferedLogChannel getCurrentLogForLedger(Long ledgerId);
+
+/*
+ * gets the copy of rotatedLogChannels
+ */
+Set getCopyOfRotatedLogChannels();
+
+/*
+ * gets the copy of replicaOfCurrentLogChannels
+ */
+Set getCopyOfCurrentLogs();
+
+/*
+ * gets the active logChannel with the given entryLogId. null if it is
+ * not existing.
+ */
+BufferedLogChannel getCurrentLogIfPresent(long entryLogId);
+
+/*
+ * removes the logChannel from rotatedLogChannels collection
+ */
+void removeFromRotatedLogChannels(BufferedLogChannel 
rotatedLogChannelToRemove);
+
+/*
+ * Returns eligible writable ledger dir for the creation next entrylog
+ */
+File getDirForNextEntryLog(List writableLedgerDirs);
+
+/*
+ * Do the operations required for checkpoint.
+ */
+void checkpoint() throws IOException;
+
+/*
+ * roll entryLogs.
+ */
+void rollLogs() throws IOException;
+
+/*
+ * gets the log id of the current activeEntryLog. for
+ * EntryLogManagerForSingleEntryLog it returns logid of current
+ * activelog, for EntryLogManagerForEntryLogPerLedger it would return
+ * some constant value.
+ */
+long getCurrentLogId();
+}
+
+class EntryLogManagerForSingleEntryLog implements EntryLogManager {
+
+private volatile BufferedLogChannel activeLogChannel;
+private Lock lockForActiveLogChannel;
+private final Set rotatedLogChannels;
+
+EntryLogManagerForSingleEntryLog() {
+rotatedLogChannels = ConcurrentHashMap.newKeySet();
+lockForActiveLogChannel = new ReentrantLock();
+}
+
+/*
+ * since entryLogPerLedger is not enabled, it is just one lock for all
+ * ledgers.
+ */
+@Override
+public void acquireLock(Long ledgerId) {
+lockForActiveLogChannel.lock();
+}
+
+@Override
+public void acquireLockByCreatingIfRequired(Long ledgerId) {
+acquireLock(ledgerId);
+}
+
+@Override
+public void releaseLock(Long ledgerId) {
+lockForActiveLogChannel.unlock();
+}
+
+@Override
+public void setCurrentLogForLedger(Long ledgerId, BufferedLogChannel 
logChannel) {
+acquireLock(ledgerId);
+try {
+BufferedLogChannel hasToRotateLogChannel = activeLogChannel;
+activeLogChannel = logChannel;
+if (hasToRotateLogChannel != null) {
+rotatedLogChannels.add(hasToRotateLogChannel);
+}
+} finally {
+releaseLock(ledgerId);
+}
+}
+
+@Override
+public BufferedLogChannel getCurrentLogForLedger(Long ledgerId) {
+return activeLogChannel;
+}
+
+@Override
+public Set getCopyOfRotatedLogChannels() {
+return new HashSet(rotatedLogChannels);
+}
+
+@Override
+public Set getCopyOfCurrentLogs() {
+HashSet copyOfCurrentLogs = new 
HashSet();
+copyOfCurrentLogs.add(activeLogChannel);
+return copyOfCurrentLogs;
+}
+
+@Override
+public BufferedLogChannel getCurrentLogIfPresent(long entryLogId) {
+BufferedLogChannel activeLogChannelTemp = activeLogChannel;
+if ((activeLogChannelTemp != null) && 
(activeLogChannelTemp.getLogId() == entryLogId)) {
+return activeLogChannelTemp;
+}
+   

[GitHub] reddycharan commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

[GitBox]

reddycharan commented on a change in pull request #1281: Issue #570: 
Introducing EntryLogManager.
URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r180010928
 
 

 ##
 File path: 
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/CreateNewLogTest.java
 ##
 @@ -100,9 +104,9 @@ public void testCreateNewLog() throws Exception {
 EntryLogger el = new EntryLogger(conf, ledgerDirsManager);
 // Calls createNewLog, and with the number of directories we
 // are using, if it picks one at random it will fail.
-el.createNewLog();
-LOG.info("This is the current log id: " + el.getCurrentLogId());
-assertTrue("Wrong log id", el.getCurrentLogId() > 1);
+el.createNewLog(0L);
+LOG.info("This is the current log id: " + 
el.getPreviousAllocatedEntryLogId());
 
 Review comment:
   in all these places i considered whether preallocation is enabled or not 
appropriately and  getPrevisousAllocatedEntryLogId is the appropriate one to 
validate the cases here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] reddycharan commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

[GitBox]

reddycharan commented on a change in pull request #1281: Issue #570: 
Introducing EntryLogManager.
URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r180010398
 
 

 ##
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ReadOnlyEntryLogger.java
 ##
 @@ -54,7 +49,7 @@ protected boolean removeEntryLog(long entryLogId) {
 }
 
 @Override
-public synchronized long addEntry(long ledger, ByteBuffer entry) throws 
IOException {
+public synchronized long addEntry(Long ledgerId, ByteBuffer entry) throws 
IOException {
 
 Review comment:
   in EntryLogManagerForEntryLogPerLedger I maintain couple of datastructures, 
where key for HashMap is ledgerId and hence Long wrapper class is needed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sijie closed pull request #1322: Improve logging on ledger dirs monitor to avoid log flooding

[GitBox]

sijie closed pull request #1322: Improve logging on ledger dirs monitor to 
avoid log flooding
URL: https://github.com/apache/bookkeeper/pull/1322
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStateManager.java
 
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStateManager.java
index 1689b11f5..de2c797a8 100644
--- 
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStateManager.java
+++ 
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieStateManager.java
@@ -31,6 +31,7 @@
 import java.util.concurrent.Executors;
 import java.util.concurrent.Future;
 import java.util.concurrent.atomic.AtomicBoolean;
+import lombok.extern.slf4j.Slf4j;
 import org.apache.bookkeeper.conf.ServerConfiguration;
 import org.apache.bookkeeper.meta.MetadataBookieDriver;
 import org.apache.bookkeeper.stats.Gauge;
@@ -43,6 +44,7 @@
 /**
  * An implementation of StateManager.
  */
+@Slf4j
 public class BookieStateManager implements StateManager {
 private static final Logger LOG = 
LoggerFactory.getLogger(BookieStateManager.class);
 private final ServerConfiguration conf;
@@ -142,6 +144,11 @@ public boolean isAvailableForHighPriorityWrites() {
 
 @Override
 public void setHighPriorityWritesAvailability(boolean available) {
+if (this.availableForHighPriorityWrites && !available) {
+log.info("Disable high priority writes on readonly bookie.");
+} else if (!this.availableForHighPriorityWrites && available) {
+log.info("Enable high priority writes on readonly bookie.");
+}
 this.availableForHighPriorityWrites = available;
 }
 
diff --git 
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDirsManager.java
 
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDirsManager.java
index a615cfaf4..7b632a21b 100644
--- 
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDirsManager.java
+++ 
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerDirsManager.java
@@ -179,10 +179,11 @@ public boolean hasWritableLedgerDirs() {
 // We don't have writable Ledger Dirs. But we are still okay to create 
new entry log files if we have enough
 // disk spaces. This allows bookie can still function at readonly 
mode. Because compaction, journal replays
 // can still write data to disks.
-return 
getDirsAboveUsableThresholdSize(minUsableSizeForEntryLogCreation);
+return 
getDirsAboveUsableThresholdSize(minUsableSizeForEntryLogCreation, true);
 }
 
-List getDirsAboveUsableThresholdSize(long thresholdSize) throws 
NoWritableLedgerDirException {
+List getDirsAboveUsableThresholdSize(long thresholdSize, boolean 
loggingNoWritable)
+throws NoWritableLedgerDirException {
 List fullLedgerDirsToAccomodate = new ArrayList();
 for (File dir: this.ledgerDirectories) {
 // Pick dirs which can accommodate little more than thresholdSize
@@ -192,8 +193,10 @@ public boolean hasWritableLedgerDirs() {
 }
 
 if (!fullLedgerDirsToAccomodate.isEmpty()) {
-LOG.info("No writable ledger dirs below diskUsageThreshold. "
+if (loggingNoWritable) {
+LOG.info("No writable ledger dirs below diskUsageThreshold. "
 + "But Dirs that can accommodate {} are: {}", 
thresholdSize, fullLedgerDirsToAccomodate);
+}
 return fullLedgerDirsToAccomodate;
 }
 
@@ -201,7 +204,9 @@ public boolean hasWritableLedgerDirs() {
 // thresholdSize usable space
 String errMsg = "All ledger directories are non writable and no 
reserved space (" + thresholdSize + ") left.";
 NoWritableLedgerDirException e = new 
NoWritableLedgerDirException(errMsg);
-LOG.error(errMsg, e);
+if (loggingNoWritable) {
+LOG.error(errMsg, e);
+}
 throw e;
 }
 
@@ -307,7 +312,7 @@ File pickRandomWritableDirForNewIndexFile(File excludedDir) 
throws NoWritableLed
 // That means we must have turned readonly. But
 // during the Bookie restart, while replaying the journal there 
might be a need
 // to create new Index file and it should proceed.
-writableDirsForNewIndexFile = 
getDirsAboveUsableThresholdSize(minUsableSizeForIndexFileCreation);
+writableDirsForNewIndexFile = 
getDirsAboveUsableThresholdSize(minUsableSizeForIndexFileCreation, true);
 }
 return pickRandomDir(writableDirsForNewIndexFile, excludedDir);
 }
diff --git 

[GitHub] reddycharan commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

[GitBox]

reddycharan commented on a change in pull request #1281: Issue #570: 
Introducing EntryLogManager.
URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r180007829
 
 

 ##
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
 ##
 @@ -393,12 +513,37 @@ public BufferedReadChannel getFromChannels(long logId) {
  *
  * @return least unflushed log id.
  */
-synchronized long getLeastUnflushedLogId() {
-return leastUnflushedLogId;
+long getLeastUnflushedLogId() {
+return recentlyCreatedEntryLogsStatus.getLeastUnflushedLogId();
 }
 
-synchronized long getCurrentLogId() {
-return logChannel.getLogId();
+long getPreviousAllocatedEntryLogId() {
+return entryLoggerAllocator.getPreallocatedLogId();
+}
+
+boolean rollLogsIfEntryLogLimitReached() throws IOException {
 
 Review comment:
   changed EntryLogManager API as we discussed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] reddycharan commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

[GitBox]

reddycharan commented on a change in pull request #1281: Issue #570: 
Introducing EntryLogManager.
URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r180007729
 
 

 ##
 File path: 
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/CreateNewLogTest.java
 ##
 @@ -100,9 +104,9 @@ public void testCreateNewLog() throws Exception {
 EntryLogger el = new EntryLogger(conf, ledgerDirsManager);
 // Calls createNewLog, and with the number of directories we
 // are using, if it picks one at random it will fail.
-el.createNewLog();
-LOG.info("This is the current log id: " + el.getCurrentLogId());
-assertTrue("Wrong log id", el.getCurrentLogId() > 1);
+el.createNewLog(0L);
+LOG.info("This is the current log id: " + 
el.getPreviousAllocatedEntryLogId());
 
 Review comment:
   done


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] reddycharan commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

[GitBox]

reddycharan commented on a change in pull request #1281: Issue #570: 
Introducing EntryLogManager.
URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r180006729
 
 

 ##
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
 ##
 @@ -116,21 +121,103 @@ public ConcurrentLongLongHashMap getLedgersMap() {
 return entryLogMetadata.getLedgersMap();
 }
 
+public Long getLedgerId() {
+return ledgerId;
+}
+
+public void setLedgerId(Long ledgerId) {
+this.ledgerId = ledgerId;
+}
+
 @Override
 public String toString() {
 return MoreObjects.toStringHelper(BufferedChannel.class)
 
 Review comment:
   changed


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] reddycharan commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

[GitBox]

reddycharan commented on a change in pull request #1281: Issue #570: 
Introducing EntryLogManager.
URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r180006501
 
 

 ##
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
 ##
 @@ -116,21 +121,103 @@ public ConcurrentLongLongHashMap getLedgersMap() {
 return entryLogMetadata.getLedgersMap();
 }
 
+public Long getLedgerId() {
+return ledgerId;
+}
+
+public void setLedgerId(Long ledgerId) {
 
 Review comment:
   its true that ledgerId is assigned in the case of entrylogperledger and it 
wont be changed. But it wouldn't be possible to assign the ledgerId during the 
creation of BufferedLogChannel because of preallocation optimization. So there 
has to be setter for ledgerIdAssigned in BufferedLogChannel.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] reddycharan commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

[GitBox]

reddycharan commented on a change in pull request #1281: Issue #570: 
Introducing EntryLogManager.
URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r180004935
 
 

 ##
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
 ##
 @@ -83,18 +88,18 @@
  */
 public class EntryLogger {
 private static final Logger LOG = 
LoggerFactory.getLogger(EntryLogger.class);
+private static final Long INVALID_LEDGERID = Long.valueOf(-1);
+// log file suffix
+private static final String LOG_FILE_SUFFIX = ".log";
 
 static class BufferedLogChannel extends BufferedChannel {
 private final long logId;
 private final EntryLogMetadata entryLogMetadata;
 private final File logFile;
+private Long ledgerId = INVALID_LEDGERID;
 
 Review comment:
   changed it to 'ledgerIdAssigned'


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] reddycharan commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

[GitBox]

reddycharan commented on a change in pull request #1281: Issue #570: 
Introducing EntryLogManager.
URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r180004899
 
 

 ##
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
 ##
 @@ -83,18 +88,18 @@
  */
 public class EntryLogger {
 private static final Logger LOG = 
LoggerFactory.getLogger(EntryLogger.class);
+private static final Long INVALID_LEDGERID = Long.valueOf(-1);
 
 Review comment:
   changed it to UNASSIGNED_LEDGERID


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] eolivelli closed pull request #1297: Release notes for 4.6.2 version

[GitBox]

eolivelli closed pull request #1297: Release notes for 4.6.2 version
URL: https://github.com/apache/bookkeeper/pull/1297
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/site/_config.yml b/site/_config.yml
index 1300a3f1d..dfdc267e2 100644
--- a/site/_config.yml
+++ b/site/_config.yml
@@ -8,8 +8,9 @@ destination: local-generated
 twitter_url: https://twitter.com/asfbookkeeper
 
 versions:
-- "4.6.1"
+- "4.6.2"
 # [next_version_placeholder]
+- "4.6.1"
 - "4.6.0"
 - "4.5.1"
 - "4.5.0"
@@ -27,7 +28,7 @@ archived_versions:
 - "4.1.0"
 - "4.0.0"
 latest_version: "4.7.0-SNAPSHOT"
-latest_release: "4.6.1"
+latest_release: "4.6.2"
 stable_release: "4.5.0"
 distributedlog_version: "0.5.0"
 
diff --git a/site/docs/4.6.2/overview/releaseNotes.md 
b/site/docs/4.6.2/overview/releaseNotes.md
index 96a4f6131..4f7cb7a52 100644
--- a/site/docs/4.6.2/overview/releaseNotes.md
+++ b/site/docs/4.6.2/overview/releaseNotes.md
@@ -2,16 +2,28 @@
 title: Apache BookKeeper 4.6.2 Release Notes
 ---
 
-TODO
+This is the ninth release of BookKeeper as an Apache Top Level Project!
+
+The 4.6.2 release is a bugfix release which fixes a bunch of issues reported 
from users of 4.6.1.
+
+Apache BookKeeper users are encouraged to upgrade to 4.6.2. The technical 
details of this release are summarized
+below.
 
 ## Highlights
 
+- Fix performance regression is using Netty > 4.1.12, see 
[https://github.com/apache/bookkeeper/pull/1108](https://github.com/apache/bookkeeper/pull/1108)
+
+- Enhance performances on Prometheus stats provider, see 
[https://github.com/apache/bookkeeper/pull/1081](https://github.com/apache/bookkeeper/pull/1081)
+
+- Save memory resources on client by retaining for less time references to 
data to write, see 
[https://github.com/apache/bookkeeper/issues/1063](https://github.com/apache/bookkeeper/issues/1063)
+
+- Fix a problem on Java 9/10 with the 'shaded' artifacts, due to a bug in 
Maven Shade Plugin, see 
[https://github.com/apache/bookkeeper/pull/1144](https://github.com/apache/bookkeeper/pull/1144)
 
-TODO
+- Fix Journal stats names, see 
[https://github.com/apache/bookkeeper/pull/1250](https://github.com/apache/bookkeeper/pull/1250)
 
 ### Dependencies Upgrade
 
-There is no dependency upgrade since 4.6.0, but now we distribute a 'shaded' 
version of main artifacts, see [Ledger API](../ledger-api)
+There is no dependency upgrade since 4.6.0, and since 4.6.1 we distribute a 
'shaded' version of main artifacts, see [Ledger API](../ledger-api)
 
 ## Full list of changes
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services