[GitHub] dlg99 opened a new pull request #1741: Issue #1740: IOUtils.close() only accepts Closeable as a vararg which results in unnecessary Object[] created if only one Closeable passed there

[GitBox]

dlg99 opened a new pull request #1741: Issue #1740: IOUtils.close() only 
accepts Closeable as a vararg which results in unnecessary Object[] created if 
only one Closeable passed there
URL: https://github.com/apache/bookkeeper/pull/1741
 
 
   Descriptions of the changes in this PR:
   
   added close() variant that takes one Closeable.
   
   ### Motivation
   
   100% of close() usage is with one Closeable.
   
   ### Changes
   
   light refactoring.
   
   Master Issue: #1740 
   
   > ---
   > In order to uphold a high standard for quality for code contributions, 
Apache BookKeeper runs various precommit
   > checks for pull requests. A pull request can only be merged when it passes 
precommit checks. However running all
   > the precommit checks can take a long time, some trivial changes don't need 
to run all the precommit checks. You
   > can check following list to skip the tests that don't need to run for your 
pull request. Leave them unchecked if
   > you are not sure, committers will help you:
   >
   > - [ ] [skip bookkeeper-server bookie tests]: skip testing 
`org.apache.bookkeeper.bookie` in bookkeeper-server module.
   > - [ ] [skip bookkeeper-server client tests]: skip testing 
`org.apache.bookkeeper.client` in bookkeeper-server module.
   > - [ ] [skip bookkeeper-server replication tests]: skip testing 
`org.apache.bookkeeper.replication` in bookkeeper-server module.
   > - [ ] [skip bookkeeper-server tls tests]: skip testing 
`org.apache.bookkeeper.tls` in bookkeeper-server module.
   > - [ ] [skip bookkeeper-server remaining tests]: skip testing all other 
tests in bookkeeper-server module.
   > - [ ] [skip integration tests]: skip docker based integration tests. if 
you make java code changes, you shouldn't skip integration tests.
   > - [ ] [skip build java8]: skip build on java8. *ONLY* skip this when 
*ONLY* changing files under documentation under `site`.
   > - [ ] [skip build java9]: skip build on java9. *ONLY* skip this when 
*ONLY* changing files under documentation under `site`.
   > ---
   
   > ---
   > Be sure to do all of the following to help us incorporate your contribution
   > quickly and easily:
   >
   > If this PR is a BookKeeper Proposal (BP):
   >
   > - [ ] Make sure the PR title is formatted like:
   > `: Description of bookkeeper proposal`
   > `e.g. BP-1: 64 bits ledger is support`
   > - [ ] Attach the master issue link in the description of this PR.
   > - [ ] Attach the google doc link if the BP is written in Google Doc.
   >
   > Otherwise:
   > 
   > - [ ] Make sure the PR title is formatted like:
   > `: Description of pull request`
   > `e.g. Issue 123: Description ...`
   > - [ ] Make sure tests pass via `mvn clean apache-rat:check install 
spotbugs:check`.
   > - [ ] Replace `` in the title with the actual Issue number.
   > 
   > ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dlg99 opened a new issue #1740: IOUtils.close() only accepts Closeable as a vararg which results in unnecessary Object[] created if only one Closeable passed there

[GitBox]

dlg99 opened a new issue #1740: IOUtils.close() only accepts Closeable as a 
vararg which results in unnecessary Object[] created if only one Closeable 
passed there
URL: https://github.com/apache/bookkeeper/issues/1740
 
 
   
   **BUG REPORT**
   
   1. Please describe the issue you observed:
   
   IOUtils.close() only accepts Closeable as a vararg which results in 
unnecessary Object[] created if only one Closeable passed there
   100% of close() usage is with only one Closeable.
   While it is not very often used (log rotation, shutdown etc) we can still 
avoid this extra allocation.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] athanatos opened a new issue #1737: EntryMemTable.newEntry retains reference to passed ByteBuffer array, can cause corruption on journal replay

[GitBox]

athanatos opened a new issue #1737: EntryMemTable.newEntry retains reference to 
passed ByteBuffer array, can cause corruption on journal replay
URL: https://github.com/apache/bookkeeper/issues/1737
 
 
   Journal.scanJournal reuses the same ByteBuffers for each entry, but (if the 
entry is large enough) EntryMemTable retains a reference.  The result is that 
if any entry is large enough, the bytes that get written to the entryLog upon 
flush will be a prefix of the last entry replayed from that journal file.  This 
will in general corrupt any such entries.  Fix seems relatively simple, PR will 
follow.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] reddycharan commented on issue #1736: ReadEntryCallback in ReadLedgerEntriesCmd shouldn't release buffer.

[GitBox]

reddycharan commented on issue #1736: ReadEntryCallback in ReadLedgerEntriesCmd 
shouldn't release buffer.
URL: https://github.com/apache/bookkeeper/pull/1736#issuecomment-427145793
 
 
   @ivankelly related to your change 8d048abce486c63d428041f77ee9a506756f4d1e


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] reddycharan opened a new pull request #1736: ReadEntryCallback in ReadLedgerEntriesCmd shouldn't release buffer.

[GitBox]

reddycharan opened a new pull request #1736: ReadEntryCallback in 
ReadLedgerEntriesCmd shouldn't release buffer.
URL: https://github.com/apache/bookkeeper/pull/1736
 
 
   
   
   Descriptions of the changes in this PR:
   
   - ReadEntryCallback in ReadLedgerEntriesCmd shouldn't release buffer,
   which is not owned by the callback.
   
   ### Motivation
   
   with the following change, Per channel bookie clients owns the buffer for 
read responses. So it is not correct for ReadEntryCallback in 
ReadLedgerEntriesCmd to release buffer
   
https://github.com/apache/bookkeeper/commit/8d048abce486c63d428041f77ee9a506756f4d1e#diff-e50ee2c1aec1539ea185a94605b0e550R1611
   
   because of this issue I'm seeing following error with ReadLedgerEntriesCmd
   ```
   /Workspace/SFStorage/bookkeeper/bookkeeper-server/bin$ ./bookkeeper shell 
-localbookie readledger -bookie   -ledgerid 
----0003 -firstentryid 1 -lastentryid 3
   JAVA_HOME not set, using java from PATH. (/usr/bin/java)
   
   - Lid=----0003, Eid=1 -
   18:32:03,724 ERROR Unexpected throwable caught 
   io.netty.util.IllegalReferenceCountException: refCnt: 0, increment: 1
at 
io.netty.buffer.AbstractReferenceCountedByteBuf.release0(AbstractReferenceCountedByteBuf.java:100)
 ~[netty-all-4.1.22.Final.jar:4.1.22.Final]
at 
io.netty.buffer.AbstractReferenceCountedByteBuf.release(AbstractReferenceCountedByteBuf.java:84)
 ~[netty-all-4.1.22.Final.jar:4.1.22.Final]
at 
org.apache.bookkeeper.proto.PerChannelBookieClient$ReadCompletion.handleV3Response(PerChannelBookieClient.java:1699)
 ~[bookkeeper-server-4.7.0-SNAPSHOT.jar:4.7.0-SNAPSHOT]
at 
org.apache.bookkeeper.proto.PerChannelBookieClient$3.safeRun(PerChannelBookieClient.java:1286)
 ~[bookkeeper-server-4.7.0-SNAPSHOT.jar:4.7.0-SNAPSHOT]
at 
org.apache.bookkeeper.common.util.SafeRunnable.run(SafeRunnable.java:36) 
[bookkeeper-common-4.7.0-SNAPSHOT.jar:4.7.0-SNAPSHOT]
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) 
[?:1.8.0_172]
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) 
[?:1.8.0_172]
at 
io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
 [netty-all-4.1.22.Final.jar:4.1.22.Final]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_172]
   
   - Lid=----0003, Eid=2 -
   
   18:32:03,733 ERROR Unexpected throwable caught 
   io.netty.util.IllegalReferenceCountException: refCnt: 0, increment: 1
at 
io.netty.buffer.AbstractReferenceCountedByteBuf.release0(AbstractReferenceCountedByteBuf.java:100)
 ~[netty-all-4.1.22.Final.jar:4.1.22.Final]
at 
io.netty.buffer.AbstractReferenceCountedByteBuf.release(AbstractReferenceCountedByteBuf.java:84)
 ~[netty-all-4.1.22.Final.jar:4.1.22.Final]
at 
org.apache.bookkeeper.proto.PerChannelBookieClient$ReadCompletion.handleV3Response(PerChannelBookieClient.java:1699)
 ~[bookkeeper-server-4.7.0-SNAPSHOT.jar:4.7.0-SNAPSHOT]
at 
org.apache.bookkeeper.proto.PerChannelBookieClient$3.safeRun(PerChannelBookieClient.java:1286)
 ~[bookkeeper-server-4.7.0-SNAPSHOT.jar:4.7.0-SNAPSHOT]
at 
org.apache.bookkeeper.common.util.SafeRunnable.run(SafeRunnable.java:36) 
[bookkeeper-common-4.7.0-SNAPSHOT.jar:4.7.0-SNAPSHOT]
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) 
[?:1.8.0_172]
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) 
[?:1.8.0_172]
at 
io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
 [netty-all-4.1.22.Final.jar:4.1.22.Final]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_172]
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dlg99 commented on a change in pull request #1735: Issue 1703: IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog

[GitBox]

dlg99 commented on a change in pull request #1735: Issue 1703: 
IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog
URL: https://github.com/apache/bookkeeper/pull/1735#discussion_r222780654
 
 

 ##
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BufferedChannel.java
 ##
 @@ -88,8 +90,12 @@ public BufferedChannel(FileChannel fc, int writeCapacity, 
int readCapacity, long
 
 @Override
 public synchronized void close() throws IOException {
+if (closed) {
 
 Review comment:
   ok, accepted.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] eolivelli commented on a change in pull request #1735: Issue 1703: IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog

[GitBox]

eolivelli commented on a change in pull request #1735: Issue 1703: 
IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog
URL: https://github.com/apache/bookkeeper/pull/1735#discussion_r222774605
 
 

 ##
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BufferedChannel.java
 ##
 @@ -88,8 +90,12 @@ public BufferedChannel(FileChannel fc, int writeCapacity, 
int readCapacity, long
 
 @Override
 public synchronized void close() throws IOException {
+if (closed) {
 
 Review comment:
   I agree with Sikie


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sijie commented on a change in pull request #1735: Issue 1703: IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog

[GitBox]

sijie commented on a change in pull request #1735: Issue 1703: 
IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog
URL: https://github.com/apache/bookkeeper/pull/1735#discussion_r222769081
 
 

 ##
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogManagerForSingleEntryLog.java
 ##
 @@ -211,9 +211,7 @@ void flushRotatedLogs() throws IOException {
 
 @Override
 public void close() throws IOException {
-if (activeLogChannel != null) {
-activeLogChannel.close();
-}
+IOUtils.close(log, activeLogChannel);
 
 Review comment:
   > java will create new Object[] for single closeable that is passed to the 
method.
   
   yes, but it is probably okay since we use this method at shutdown phase.
   
   > We'll benefit from a variant that takes only one parameter.
   
   definitely we will benefit from it. +1
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sijie commented on a change in pull request #1735: Issue 1703: IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog

[GitBox]

sijie commented on a change in pull request #1735: Issue 1703: 
IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog
URL: https://github.com/apache/bookkeeper/pull/1735#discussion_r222768959
 
 

 ##
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogManagerForSingleEntryLog.java
 ##
 @@ -211,9 +211,7 @@ void flushRotatedLogs() throws IOException {
 
 @Override
 public void close() throws IOException {
-if (activeLogChannel != null) {
-activeLogChannel.close();
-}
+IOUtils.close(log, activeLogChannel);
 
 Review comment:
   you are right. will revert it back


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sijie commented on a change in pull request #1735: Issue 1703: IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog

[GitBox]

sijie commented on a change in pull request #1735: Issue 1703: 
IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog
URL: https://github.com/apache/bookkeeper/pull/1735#discussion_r222770031
 
 

 ##
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BufferedChannel.java
 ##
 @@ -88,8 +90,12 @@ public BufferedChannel(FileChannel fc, int writeCapacity, 
int readCapacity, long
 
 @Override
 public synchronized void close() throws IOException {
+if (closed) {
 
 Review comment:
   it can probably double closed because the way we managed `try() finally {}` 
at shutting down entry log manager. we can fix the logic there. however I don't 
think that is a redirection to go, because if close() is being called twice in 
different places, the problem still exists. so I went down to this path to make 
close idempotent in the base class, which it will address the problem of now 
and any potentially problems in future.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dlg99 commented on a change in pull request #1735: Issue 1703: IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog

[GitBox]

dlg99 commented on a change in pull request #1735: Issue 1703: 
IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog
URL: https://github.com/apache/bookkeeper/pull/1735#discussion_r222754629
 
 

 ##
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BufferedChannel.java
 ##
 @@ -88,8 +90,12 @@ public BufferedChannel(FileChannel fc, int writeCapacity, 
int readCapacity, long
 
 @Override
 public synchronized void close() throws IOException {
+if (closed) {
 
 Review comment:
   @reddycharan safeRelease() is not idempotent.
   All it does is suppresses exception and logs it:
   
   ```
   public static void safeRelease(Object msg) {
   try {
   release(msg);
   } catch (Throwable t) {
   logger.warn("Failed to release a message: {}", msg, t);
   }
   }
   ```
   
   The only "benefit" we are getting form it (vs .release()) is that it hides 
the problem.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] reddycharan commented on a change in pull request #1735: Issue 1703: IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog

[GitBox]

reddycharan commented on a change in pull request #1735: Issue 1703: 
IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog
URL: https://github.com/apache/bookkeeper/pull/1735#discussion_r222750446
 
 

 ##
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BufferedChannel.java
 ##
 @@ -88,8 +90,12 @@ public BufferedChannel(FileChannel fc, int writeCapacity, 
int readCapacity, long
 
 @Override
 public synchronized void close() throws IOException {
+if (closed) {
 
 Review comment:
   hmm..not sure why it is needed. Following calls are supposed to be 
idempotent right?
   
   ```
   ReferenceCountUtil.safeRelease(writeBuffer);
   fileChannel.close();
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] reddycharan edited a comment on issue #1735: Issue 1703: IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog

[GitBox]

reddycharan edited a comment on issue #1735: Issue 1703: 
IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog
URL: https://github.com/apache/bookkeeper/pull/1735#issuecomment-427089980
 
 
   i vaguely remember raising concern about this issue in this fix in @merlimat 
fix - https://github.com/apache/bookkeeper/pull/1414
   
   comment by Matteo
   https://github.com/apache/bookkeeper/pull/1414#discussion_r210760416


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] reddycharan commented on a change in pull request #1735: Issue 1703: IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog

[GitBox]

reddycharan commented on a change in pull request #1735: Issue 1703: 
IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog
URL: https://github.com/apache/bookkeeper/pull/1735#discussion_r222747824
 
 

 ##
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogManagerForSingleEntryLog.java
 ##
 @@ -211,9 +211,7 @@ void flushRotatedLogs() throws IOException {
 
 @Override
 public void close() throws IOException {
-if (activeLogChannel != null) {
-activeLogChannel.close();
-}
+IOUtils.close(log, activeLogChannel);
 
 Review comment:
   why did you change this? now there is no difference between close() and 
forceClose() method


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dlg99 commented on a change in pull request #1735: Issue 1703: IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog

[GitBox]

dlg99 commented on a change in pull request #1735: Issue 1703: 
IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog
URL: https://github.com/apache/bookkeeper/pull/1735#discussion_r222747394
 
 

 ##
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BufferedChannel.java
 ##
 @@ -88,8 +90,12 @@ public BufferedChannel(FileChannel fc, int writeCapacity, 
int readCapacity, long
 
 @Override
 public synchronized void close() throws IOException {
+if (closed) {
 
 Review comment:
   why is it being called more than one time in the first place?
   Can we address that issue (root cause) instead of providing work around?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] reddycharan commented on issue #1735: Issue 1703: IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog

[GitBox]

reddycharan commented on issue #1735: Issue 1703: 
IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog
URL: https://github.com/apache/bookkeeper/pull/1735#issuecomment-427089980
 
 
   i vaguely remember raising concern about this issue in this fix in @merlimat 
fix - https://github.com/apache/bookkeeper/pull/1414
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dlg99 commented on a change in pull request #1735: Issue 1703: IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog

[GitBox]

dlg99 commented on a change in pull request #1735: Issue 1703: 
IllegalReferenceCountException at closing EntryLogManagerForSingleEntryLog
URL: https://github.com/apache/bookkeeper/pull/1735#discussion_r222746532
 
 

 ##
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogManagerForSingleEntryLog.java
 ##
 @@ -211,9 +211,7 @@ void flushRotatedLogs() throws IOException {
 
 @Override
 public void close() throws IOException {
-if (activeLogChannel != null) {
-activeLogChannel.close();
-}
+IOUtils.close(log, activeLogChannel);
 
 Review comment:
   unrelated note.
   With current method definition
   ```java
   public static void close(Logger log, java.io.Closeable... closeables) {
   ```
   
   java will create new Object[] for single closeable that is passed to the 
method.
   We'll benefit from a variant that takes only one parameter. Do we ever use 
this method with more than one closeable?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Jenkins build is still unstable: bookkeeper_codecoverage #228

[Apache Jenkins Server]

See 

Jenkins build is still unstable: bookkeeper_postcommit_master_java9 #278

[Apache Jenkins Server]

See 

Jenkins build is unstable: bookkeeper_postcommit_master_java8 #277

[Apache Jenkins Server]

See 

Build failed in Jenkins: bookkeeper_release_branch_48_integrationtests #50

[Apache Jenkins Server]

See 


--
[...truncated 1.35 MB...]

---
 T E S T S
---
Running org.apache.bookkeeper.tests.backwardcompat.TestCompatRecoveryNoPassword
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 24.101 sec

Results :

Tests run: 1, Failures: 0, Errors: 0, Skipped: 0

2018-10-04\T\13:21:52.332 [INFO] 
2018-10-04\T\13:21:52.332 [INFO] 

2018-10-04\T\13:21:52.332 [INFO] Building Apache BookKeeper :: Tests :: 
Backward Compatibility :: Test upgrade 4.1.0 to current in cluster with cookies 
4.8.0-SNAPSHOT
2018-10-04\T\13:21:52.332 [INFO] 

2018-10-04\T\13:21:52.361 [INFO] 
2018-10-04\T\13:21:52.361 [INFO] --- 
groovy-eclipse-compiler:2.9.2-04:add-groovy-build-paths 
(default-add-groovy-build-paths) @ old-cookie-new-cluster ---
2018-10-04\T\13:21:52.362 [INFO] Adding /src/main/groovy to the list of source 
folders
2018-10-04\T\13:21:52.362 [INFO] Adding /src/test/groovy to the list of test 
source folders
2018-10-04\T\13:21:52.362 [INFO] 
2018-10-04\T\13:21:52.362 [INFO] --- maven-remote-resources-plugin:1.5:process 
(process-resource-bundles) @ old-cookie-new-cluster ---
2018-10-04\T\13:21:54.067 [INFO] 
2018-10-04\T\13:21:54.067 [INFO] --- maven-resources-plugin:2.7:resources 
(default-resources) @ old-cookie-new-cluster ---
2018-10-04\T\13:21:54.068 [INFO] Using 'UTF-8' encoding to copy filtered 
resources.
2018-10-04\T\13:21:54.069 [INFO] skip non existing resourceDirectory 

2018-10-04\T\13:21:54.069 [INFO] Copying 3 resources
2018-10-04\T\13:21:54.070 [INFO] 
2018-10-04\T\13:21:54.070 [INFO] --- maven-compiler-plugin:3.7.0:compile 
(default-compile) @ old-cookie-new-cluster ---
2018-10-04\T\13:21:54.071 [INFO] No sources to compile
2018-10-04\T\13:21:54.071 [INFO] 
2018-10-04\T\13:21:54.071 [INFO] --- maven-resources-plugin:2.7:testResources 
(default-testResources) @ old-cookie-new-cluster ---
2018-10-04\T\13:21:54.072 [INFO] Using 'UTF-8' encoding to copy filtered 
resources.
2018-10-04\T\13:21:54.072 [INFO] Copying 1 resource
2018-10-04\T\13:21:54.073 [INFO] Copying 3 resources
2018-10-04\T\13:21:54.074 [INFO] 
2018-10-04\T\13:21:54.074 [INFO] --- maven-compiler-plugin:3.7.0:testCompile 
(default-testCompile) @ old-cookie-new-cluster ---
2018-10-04\T\13:21:54.078 [INFO] Changes detected - recompiling the module!
2018-10-04\T\13:21:54.080 [INFO] Using Groovy-Eclipse compiler to compile both 
Java and Groovy files
2018-10-04\T\13:21:54.353 [INFO] 
2018-10-04\T\13:21:54.353 [INFO] --- maven-surefire-plugin:2.8.1:test 
(default-test) @ old-cookie-new-cluster ---
2018-10-04\T\13:21:54.356 [INFO] Surefire report directory: 


---
 T E S T S
---
Running 
org.apache.bookkeeper.tests.backwardcompat.TestCompatUpgradeOldServerInClusterWithCookies
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 69.954 sec

Results :

Tests run: 1, Failures: 0, Errors: 0, Skipped: 0

2018-10-04\T\13:23:39.775 [INFO] 
2018-10-04\T\13:23:39.775 [INFO] 

2018-10-04\T\13:23:39.775 [INFO] Building Apache BookKeeper :: Tests :: 
Backward Compatibility :: Test old clients working on current server 
4.8.0-SNAPSHOT
2018-10-04\T\13:23:39.775 [INFO] 

2018-10-04\T\13:23:39.807 [INFO] 
2018-10-04\T\13:23:39.807 [INFO] --- 
groovy-eclipse-compiler:2.9.2-04:add-groovy-build-paths 
(default-add-groovy-build-paths) @ backward-compat-current-server-old-clients 
---
2018-10-04\T\13:23:39.807 [INFO] Adding /src/main/groovy to the list of source 
folders
2018-10-04\T\13:23:39.807 [INFO] Adding /src/test/groovy to the list of test 
source folders
2018-10-04\T\13:23:39.807 [INFO] 
2018-10-04\T\13:23:39.807 [INFO] --- maven-remote-resources-plugin:1.5:process 
(process-resource-bundles) @ backward-compat-current-server-old-clients ---
2018-10-04\T\13:23:41.433 [INFO] 
2018-10-04\T\13:23:41.433 [INFO] --- maven-resources-plugin:2.7:resources 
(default-resources) @ backward-compat-current-server-old-clients ---
2018-10-04\T\13:23:41.435 [INFO] Using 'UTF-8' encoding to copy filtered 
resources.
2018-10-04\T\13:23:41.435 [INFO] skip non existing resourceDirectory 

Build failed in Jenkins: bookkeeper_release_branch_47_java9 #177

[Apache Jenkins Server]

See 


--
[...truncated 504.08 KB...]
2018-10-04T12:38:55.128 [INFO] Downloaded: 
https://repo.maven.apache.org/maven2/org/apache/directory/api/api-ldap-extras-trigger/1.0.0-M20/api-ldap-extras-trigger-1.0.0-M20.jar
 (49 kB at 95 kB/s)
2018-10-04T12:38:55.128 [INFO] Downloading: 
https://repo.maven.apache.org/maven2/org/apache/directory/server/apacheds-core-shared/2.0.0-M15/apacheds-core-shared-2.0.0-M15.jar
2018-10-04T12:38:55.137 [INFO] Downloaded: 
https://repo.maven.apache.org/maven2/org/apache/directory/server/apacheds-protocol-shared/2.0.0-M15/apacheds-protocol-shared-2.0.0-M15.jar
 (32 kB at 62 kB/s)
2018-10-04T12:38:55.137 [INFO] Downloading: 
https://repo.maven.apache.org/maven2/org/apache/directory/server/apacheds-ldif-partition/2.0.0-M15/apacheds-ldif-partition-2.0.0-M15.jar
2018-10-04T12:38:55.143 [INFO] Downloaded: 
https://repo.maven.apache.org/maven2/org/apache/directory/server/apacheds-core-shared/2.0.0-M15/apacheds-core-shared-2.0.0-M15.jar
 (38 kB at 72 kB/s)
2018-10-04T12:38:55.143 [INFO] Downloading: 
https://repo.maven.apache.org/maven2/org/apache/directory/server/apacheds-xdbm-partition/2.0.0-M15/apacheds-xdbm-partition-2.0.0-M15.jar
2018-10-04T12:38:55.144 [INFO] Downloaded: 
https://repo.maven.apache.org/maven2/org/apache/directory/server/apacheds-protocol-kerberos/2.0.0-M15/apacheds-protocol-kerberos-2.0.0-M15.jar
 (85 kB at 160 kB/s)
2018-10-04T12:38:55.144 [INFO] Downloading: 
https://repo.maven.apache.org/maven2/org/apache/directory/server/apacheds-mavibot-partition/2.0.0-M15/apacheds-mavibot-partition-2.0.0-M15.jar
2018-10-04T12:38:55.152 [INFO] Downloaded: 
https://repo.maven.apache.org/maven2/org/apache/directory/server/apacheds-ldif-partition/2.0.0-M15/apacheds-ldif-partition-2.0.0-M15.jar
 (29 kB at 54 kB/s)
2018-10-04T12:38:55.152 [INFO] Downloading: 
https://repo.maven.apache.org/maven2/org/apache/directory/mavibot/mavibot/1.0.0-M1/mavibot-1.0.0-M1.jar
2018-10-04T12:38:55.161 [INFO] Downloaded: 
https://repo.maven.apache.org/maven2/org/apache/directory/server/apacheds-mavibot-partition/2.0.0-M15/apacheds-mavibot-partition-2.0.0-M15.jar
 (48 kB at 88 kB/s)
2018-10-04T12:38:55.161 [INFO] Downloading: 
https://repo.maven.apache.org/maven2/org/apache/directory/server/apacheds-core-avl/2.0.0-M15/apacheds-core-avl-2.0.0-M15.jar
2018-10-04T12:38:55.176 [INFO] Downloaded: 
https://repo.maven.apache.org/maven2/org/apache/directory/server/apacheds-xdbm-partition/2.0.0-M15/apacheds-xdbm-partition-2.0.0-M15.jar
 (177 kB at 316 kB/s)
2018-10-04T12:38:55.176 [INFO] Downloading: 
https://repo.maven.apache.org/maven2/org/apache/directory/api/api-all/1.0.0-M20/api-all-1.0.0-M20.jar
2018-10-04T12:38:55.180 [INFO] Downloaded: 
https://repo.maven.apache.org/maven2/org/apache/directory/mavibot/mavibot/1.0.0-M1/mavibot-1.0.0-M1.jar
 (149 kB at 264 kB/s)
2018-10-04T12:38:55.180 [INFO] Downloading: 
https://repo.maven.apache.org/maven2/commons-pool/commons-pool/1.6/commons-pool-1.6.jar
2018-10-04T12:38:55.182 [INFO] Downloaded: 
https://repo.maven.apache.org/maven2/org/apache/directory/server/apacheds-core-avl/2.0.0-M15/apacheds-core-avl-2.0.0-M15.jar
 (61 kB at 108 kB/s)
2018-10-04T12:38:55.182 [INFO] Downloading: 
https://repo.maven.apache.org/maven2/org/apache/directory/server/apacheds-jdbm-partition/2.0.0-M15/apacheds-jdbm-partition-2.0.0-M15.jar
2018-10-04T12:38:55.201 [INFO] Downloaded: 
https://repo.maven.apache.org/maven2/org/apache/directory/server/apacheds-jdbm-partition/2.0.0-M15/apacheds-jdbm-partition-2.0.0-M15.jar
 (72 kB at 124 kB/s)
2018-10-04T12:38:55.201 [INFO] Downloading: 
https://repo.maven.apache.org/maven2/org/apache/directory/jdbm/apacheds-jdbm1/2.0.0-M2/apacheds-jdbm1-2.0.0-M2.jar
2018-10-04T12:38:55.203 [INFO] Downloaded: 
https://repo.maven.apache.org/maven2/commons-pool/commons-pool/1.6/commons-pool-1.6.jar
 (111 kB at 189 kB/s)
2018-10-04T12:38:55.203 [INFO] Downloading: 
https://repo.maven.apache.org/maven2/org/apache/directory/server/apacheds-protocol-ldap/2.0.0-M15/apacheds-protocol-ldap-2.0.0-M15.jar
2018-10-04T12:38:55.210 [INFO] Downloaded: 
https://repo.maven.apache.org/maven2/org/apache/directory/server/apacheds-kerberos-codec/2.0.0-M15/apacheds-kerberos-codec-2.0.0-M15.jar
 (691 kB at 1.2 MB/s)
2018-10-04T12:38:55.210 [INFO] Downloading: 
https://repo.maven.apache.org/maven2/org/apache/directory/api/api-asn1-ber/1.0.0-M20/api-asn1-ber-1.0.0-M20.jar
2018-10-04T12:38:55.223 [INFO] Downloaded: 
https://repo.maven.apache.org/maven2/org/apache/directory/jdbm/apacheds-jdbm1/2.0.0-M2/apacheds-jdbm1-2.0.0-M2.jar
 (105 kB at 173 kB/s)
2018-10-04T12:38:55.223 [INFO] Downloading: 
https://repo.maven.apache.org/maven2/org/apache/directory/api/api-ldap-extras-codec-api/1.0.0-M20/api-ldap-extras-codec-api-1.0.0-M20.jar
2018-10-04T12:38:55.226 [INFO] Downloaded: 

Build failed in Jenkins: bookkeeper_release_branch_47_integrationtests #165

[Apache Jenkins Server]

See 


--
[...truncated 516.45 KB...]
2018-10-04\T\12:41:26.496 [INFO] Downloading: 
https://repo.maven.apache.org/maven2/bouncycastle/bcprov-jdk15/140/bcprov-jdk15-140.pom
2018-10-04\T\12:41:26.507 [INFO] Downloaded: 
https://repo.maven.apache.org/maven2/bouncycastle/bcprov-jdk15/140/bcprov-jdk15-140.pom
 (1.0 kB at 94 kB/s)
2018-10-04\T\12:41:26.509 [INFO] Downloading: 
https://repo.maven.apache.org/maven2/org/apache/directory/server/apacheds-kerberos-codec/2.0.0-M15/apacheds-kerberos-codec-2.0.0-M15.pom
2018-10-04\T\12:41:26.520 [INFO] Downloaded: 
https://repo.maven.apache.org/maven2/org/apache/directory/server/apacheds-kerberos-codec/2.0.0-M15/apacheds-kerberos-codec-2.0.0-M15.pom
 (3.9 kB at 356 kB/s)
2018-10-04\T\12:41:26.527 [INFO] Downloading: 
https://repo.maven.apache.org/maven2/org/apache/directory/server/apacheds-protocol-shared/2.0.0-M15/apacheds-protocol-shared-2.0.0-M15.pom
2018-10-04\T\12:41:26.540 [INFO] Downloaded: 
https://repo.maven.apache.org/maven2/org/apache/directory/server/apacheds-protocol-shared/2.0.0-M15/apacheds-protocol-shared-2.0.0-M15.pom
 (3.5 kB at 270 kB/s)
2018-10-04\T\12:41:26.547 [INFO] Downloading: 
https://repo.maven.apache.org/maven2/org/apache/directory/api/api-ldap-schema-data/1.0.0-M20/api-ldap-schema-data-1.0.0-M20.pom
2018-10-04\T\12:41:26.559 [INFO] Downloaded: 
https://repo.maven.apache.org/maven2/org/apache/directory/api/api-ldap-schema-data/1.0.0-M20/api-ldap-schema-data-1.0.0-M20.pom
 (6.8 kB at 563 kB/s)
2018-10-04\T\12:41:26.560 [INFO] Downloading: 
https://repo.maven.apache.org/maven2/org/apache/directory/api/api-ldap-schema-parent/1.0.0-M20/api-ldap-schema-parent-1.0.0-M20.pom
2018-10-04\T\12:41:26.573 [INFO] Downloaded: 
https://repo.maven.apache.org/maven2/org/apache/directory/api/api-ldap-schema-parent/1.0.0-M20/api-ldap-schema-parent-1.0.0-M20.pom
 (1.5 kB at 116 kB/s)
2018-10-04\T\12:41:26.579 [INFO] Downloading: 
https://repo.maven.apache.org/maven2/org/apache/directory/server/apacheds-protocol-kerberos/2.0.0-M15/apacheds-protocol-kerberos-2.0.0-M15.pom
2018-10-04\T\12:41:26.591 [INFO] Downloaded: 
https://repo.maven.apache.org/maven2/org/apache/directory/server/apacheds-protocol-kerberos/2.0.0-M15/apacheds-protocol-kerberos-2.0.0-M15.pom
 (4.2 kB at 352 kB/s)
2018-10-04\T\12:41:26.598 [INFO] Downloading: 
https://repo.maven.apache.org/maven2/org/apache/directory/server/apacheds-ldif-partition/2.0.0-M15/apacheds-ldif-partition-2.0.0-M15.pom
2018-10-04\T\12:41:26.609 [INFO] Downloaded: 
https://repo.maven.apache.org/maven2/org/apache/directory/server/apacheds-ldif-partition/2.0.0-M15/apacheds-ldif-partition-2.0.0-M15.pom
 (4.0 kB at 360 kB/s)
2018-10-04\T\12:41:26.616 [INFO] Downloading: 
https://repo.maven.apache.org/maven2/org/apache/directory/server/apacheds-xdbm-partition/2.0.0-M15/apacheds-xdbm-partition-2.0.0-M15.pom
2018-10-04\T\12:41:26.635 [INFO] Downloaded: 
https://repo.maven.apache.org/maven2/org/apache/directory/server/apacheds-xdbm-partition/2.0.0-M15/apacheds-xdbm-partition-2.0.0-M15.pom
 (4.6 kB at 244 kB/s)
2018-10-04\T\12:41:26.642 [INFO] Downloading: 
https://repo.maven.apache.org/maven2/org/apache/directory/server/apacheds-core-avl/2.0.0-M15/apacheds-core-avl-2.0.0-M15.pom
2018-10-04\T\12:41:26.653 [INFO] Downloaded: 
https://repo.maven.apache.org/maven2/org/apache/directory/server/apacheds-core-avl/2.0.0-M15/apacheds-core-avl-2.0.0-M15.pom
 (3.1 kB at 286 kB/s)
2018-10-04\T\12:41:26.660 [INFO] Downloading: 
https://repo.maven.apache.org/maven2/org/apache/directory/server/apacheds-mavibot-partition/2.0.0-M15/apacheds-mavibot-partition-2.0.0-M15.pom
2018-10-04\T\12:41:26.672 [INFO] Downloaded: 
https://repo.maven.apache.org/maven2/org/apache/directory/server/apacheds-mavibot-partition/2.0.0-M15/apacheds-mavibot-partition-2.0.0-M15.pom
 (3.3 kB at 275 kB/s)
2018-10-04\T\12:41:26.679 [INFO] Downloading: 
https://repo.maven.apache.org/maven2/org/apache/directory/mavibot/mavibot/1.0.0-M1/mavibot-1.0.0-M1.pom
2018-10-04\T\12:41:26.690 [INFO] Downloaded: 
https://repo.maven.apache.org/maven2/org/apache/directory/mavibot/mavibot/1.0.0-M1/mavibot-1.0.0-M1.pom
 (2.8 kB at 234 kB/s)
2018-10-04\T\12:41:26.691 [INFO] Downloading: 
https://repo.maven.apache.org/maven2/org/apache/directory/mavibot/mavibot-parent/1.0.0-M1/mavibot-parent-1.0.0-M1.pom
2018-10-04\T\12:41:26.703 [INFO] Downloaded: 
https://repo.maven.apache.org/maven2/org/apache/directory/mavibot/mavibot-parent/1.0.0-M1/mavibot-parent-1.0.0-M1.pom
 (9.2 kB at 767 kB/s)
2018-10-04\T\12:41:26.706 [INFO] Downloading: 
https://repo.maven.apache.org/maven2/org/apache/directory/api/api-all/1.0.0-M20/api-all-1.0.0-M20.pom
2018-10-04\T\12:41:26.724 [INFO] Downloaded: 
https://repo.maven.apache.org/maven2/org/apache/directory/api/api-all/1.0.0-M20/api-all-1.0.0-M20.pom
 (3.1 kB at 170 kB/s)
2018-10-04\T\12:41:26.729 [INFO] Downloading: 

Build failed in Jenkins: bookkeeper_release_branch_48_java9 #50

[Apache Jenkins Server]

See 


--
Started by timer
[EnvInject] - Loading node environment variables.
Building remotely on H32 (ubuntu xenial) in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/apache/bookkeeper.git # 
 > timeout=10
Fetching upstream changes from https://github.com/apache/bookkeeper.git
 > git --version # timeout=10
 > git fetch --tags --progress https://github.com/apache/bookkeeper.git 
 > +refs/heads/*:refs/remotes/origin/* 
 > +refs/pull/${ghprbPullId}/*:refs/remotes/origin/pr/${ghprbPullId}/*
ERROR: Error fetching remote repo 'origin'
hudson.plugins.git.GitException: Failed to fetch from 
https://github.com/apache/bookkeeper.git
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:888)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1155)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1186)
at hudson.scm.SCM.checkout(SCM.java:504)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1208)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1794)
at hudson.maven.MavenModuleSetBuild.run(MavenModuleSetBuild.java:543)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Caused by: hudson.plugins.git.GitException: Command "git fetch --tags 
--progress https://github.com/apache/bookkeeper.git 
+refs/heads/*:refs/remotes/origin/* 
+refs/pull/${ghprbPullId}/*:refs/remotes/origin/pr/${ghprbPullId}/*" returned 
status code 128:
stdout: 
stderr: error: Could not read 7aff86455368d5a6b27819d3c125290f35e899ad
error: Could not read 082358e77f03ce477ea6695926237d732f7269f4
remote: Enumerating objects: 2436, done.
remote: Counting objects:   0% (1/2436)   remote: Counting objects:   
1% (25/2436)   remote: Counting objects:   2% (49/2436)   
remote: Counting objects:   3% (74/2436)   remote: Counting objects:   
4% (98/2436)   remote: Counting objects:   5% (122/2436)   
remote: Counting objects:   6% (147/2436)   remote: Counting objects:   
7% (171/2436)   remote: Counting objects:   8% (195/2436)   
remote: Counting objects:   9% (220/2436)   remote: Counting objects:  
10% (244/2436)   remote: Counting objects:  11% (268/2436)   
remote: Counting objects:  12% (293/2436)   remote: Counting objects:  
13% (317/2436)   remote: Counting objects:  14% (342/2436)   
remote: Counting objects:  15% (366/2436)   remote: Counting objects:  
16% (390/2436)   remote: Counting objects:  17% (415/2436)   
remote: Counting objects:  18% (439/2436)   remote: Counting objects:  
19% (463/2436)   remote: Counting objects:  20% (488/2436)   
remote: Counting objects:  21% (512/2436)   remote: Counting objects:  
22% (536/2436)   remote: Counting objects:  23% (561/2436)   
remote: Counting objects:  24% (585/2436)   remote: Counting objects:  
25% (609/2436)   remote: Counting objects:  26% (634/2436)   
remote: Counting objects:  27% (658/2436)   remote: Counting objects:  
28% (683/2436)   remote: Counting objects:  29% (707/2436)   
remote: Counting objects:  30% (731/2436)   remote: Counting objects:  
31% (756/2436)   remote: Counting objects:  32% (780/2436)   
remote: Counting objects:  33% (804/2436)   remote: Counting objects:  
34% (829/2436)   remote: Counting objects:  35% (853/2436)   
remote: Counting objects:  36% (877/2436)   remote: Counting objects:  
37% (902/2436)   remote: Counting objects:  38% (926/2436)   
remote: Counting objects:  39% (951/2436)   remote: Counting objects:  
40% (975/2436)   remote: Counting objects:  41% (999/2436)   
remote: Counting objects:  42% (1024/2436)   remote: Counting objects:  
43% (1048/2436)   remote: Counting objects:  44% (1072/2436)   
remote: Counting objects:  45% (1097/2436)   remote: Counting objects:  
46% (1121/2436)   remote: Counting objects:  47% (1145/2436)   
remote: Counting objects:  48% (1170/2436)   remote: Counting objects:  
49% (1194/2436)   remote: Counting objects:  50% (1218/2436)   
remote: Counting objects:  51% (1243/2436)   

Build failed in Jenkins: bookkeeper_release_branch_47_java8 #177

[Apache Jenkins Server]

See 


--
Started by timer
[EnvInject] - Loading node environment variables.
Building remotely on H29 (ubuntu xenial) in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/apache/bookkeeper.git # 
 > timeout=10
Fetching upstream changes from https://github.com/apache/bookkeeper.git
 > git --version # timeout=10
 > git fetch --tags --progress https://github.com/apache/bookkeeper.git 
 > +refs/heads/*:refs/remotes/origin/* 
 > +refs/pull/${ghprbPullId}/*:refs/remotes/origin/pr/${ghprbPullId}/*
ERROR: Error fetching remote repo 'origin'
hudson.plugins.git.GitException: Failed to fetch from 
https://github.com/apache/bookkeeper.git
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:888)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1155)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1186)
at hudson.scm.SCM.checkout(SCM.java:504)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1208)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1794)
at hudson.maven.MavenModuleSetBuild.run(MavenModuleSetBuild.java:543)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Caused by: hudson.plugins.git.GitException: Command "git fetch --tags 
--progress https://github.com/apache/bookkeeper.git 
+refs/heads/*:refs/remotes/origin/* 
+refs/pull/${ghprbPullId}/*:refs/remotes/origin/pr/${ghprbPullId}/*" returned 
status code 128:
stdout: 
stderr: remote: Enumerating objects: 2438, done.
remote: Counting objects:   0% (1/2438)   remote: Counting objects:   
1% (25/2438)   remote: Counting objects:   2% (49/2438)   
remote: Counting objects:   3% (74/2438)   remote: Counting objects:   
4% (98/2438)   remote: Counting objects:   5% (122/2438)   
remote: Counting objects:   6% (147/2438)   remote: Counting objects:   
7% (171/2438)   remote: Counting objects:   8% (196/2438)   
remote: Counting objects:   9% (220/2438)   remote: Counting objects:  
10% (244/2438)   remote: Counting objects:  11% (269/2438)   
remote: Counting objects:  12% (293/2438)   remote: Counting objects:  
13% (317/2438)   remote: Counting objects:  14% (342/2438)   
remote: Counting objects:  15% (366/2438)   remote: Counting objects:  
16% (391/2438)   remote: Counting objects:  17% (415/2438)   
remote: Counting objects:  18% (439/2438)   remote: Counting objects:  
19% (464/2438)   remote: Counting objects:  20% (488/2438)   
remote: Counting objects:  21% (512/2438)   remote: Counting objects:  
22% (537/2438)   remote: Counting objects:  23% (561/2438)   
remote: Counting objects:  24% (586/2438)   remote: Counting objects:  
25% (610/2438)   remote: Counting objects:  26% (634/2438)   
remote: Counting objects:  27% (659/2438)   remote: Counting objects:  
28% (683/2438)   remote: Counting objects:  29% (708/2438)   
remote: Counting objects:  30% (732/2438)   remote: Counting objects:  
31% (756/2438)   remote: Counting objects:  32% (781/2438)   
remote: Counting objects:  33% (805/2438)   remote: Counting objects:  
34% (829/2438)   remote: Counting objects:  35% (854/2438)   
remote: Counting objects:  36% (878/2438)   remote: Counting objects:  
37% (903/2438)   remote: Counting objects:  38% (927/2438)   
remote: Counting objects:  39% (951/2438)   remote: Counting objects:  
40% (976/2438)   remote: Counting objects:  41% (1000/2438)   
remote: Counting objects:  42% (1024/2438)   remote: Counting objects:  
43% (1049/2438)   remote: Counting objects:  44% (1073/2438)   
remote: Counting objects:  45% (1098/2438)   remote: Counting objects:  
46% (1122/2438)   remote: Counting objects:  47% (1146/2438)   
remote: Counting objects:  48% (1171/2438)   remote: Counting objects:  
49% (1195/2438)   remote: Counting objects:  50% (1219/2438)   
remote: Counting objects:  51% (1244/2438)   remote: Counting objects:  
52% (1268/2438)   remote: Counting objects:  53% (1293/2438)   
remote: Counting 

[GitHub] sijie closed pull request #1734: [table service][client] provide scripts for uploading python clients to pypi

[GitBox]

sijie closed pull request #1734:  [table service][client] provide scripts for 
uploading python clients to pypi
URL: https://github.com/apache/bookkeeper/pull/1734
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/pom.xml b/pom.xml
index 418e9a4f5d..ecac42afce 100644
--- a/pom.xml
+++ b/pom.xml
@@ -854,6 +854,7 @@
 
 
 **/README.md
+**/README.rst
 **/apidocs/*
 **/src/main/resources/deps/**
 **/META-INF/**
diff --git a/stream/clients/python/.gitignore b/stream/clients/python/.gitignore
index a520e657a9..5d2d92bef5 100644
--- a/stream/clients/python/.gitignore
+++ b/stream/clients/python/.gitignore
@@ -20,3 +20,6 @@ bookkeeper.egg-info/
 
 # pip
 pip-selfcheck.json
+
+# egg-info
+**egg-info/
diff --git a/stream/clients/python/README.md b/stream/clients/python/README.md
deleted file mode 100644
index df1b7efd24..00
--- a/stream/clients/python/README.md
+++ /dev/null
@@ -1,4 +0,0 @@
-Python Client for Apache BookKeeper
-===
-
-|pypi| |versions|
diff --git a/stream/clients/python/README.rst b/stream/clients/python/README.rst
new file mode 100644
index 00..65afe63d77
--- /dev/null
+++ b/stream/clients/python/README.rst
@@ -0,0 +1,4 @@
+Python Client for Apache BookKeeper
+===
+
+Apache BookKeeper is a scalable, fault tolerant and low latency storage 
service optimized for append-only workloads.
diff --git a/stream/clients/python/scripts/publish.sh 
b/stream/clients/python/scripts/publish.sh
new file mode 100755
index 00..caa2a3b5b4
--- /dev/null
+++ b/stream/clients/python/scripts/publish.sh
@@ -0,0 +1,30 @@
+#!/usr/bin/env bash
+#
+#/**
+# * Licensed to the Apache Software Foundation (ASF) under one
+# * or more contributor license agreements.  See the NOTICE file
+# * distributed with this work for additional information
+# * regarding copyright ownership.  The ASF licenses this file
+# * to you under the Apache License, Version 2.0 (the
+# * "License"); you may not use this file except in compliance
+# * with the License.  You may obtain a copy of the License at
+# *
+# * http://www.apache.org/licenses/LICENSE-2.0
+# *
+# * Unless required by applicable law or agreed to in writing, software
+# * distributed under the License is distributed on an "AS IS" BASIS,
+# * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# * See the License for the specific language governing permissions and
+# * limitations under the License.
+# */
+
+# Upload python client to pypi staging
+
+BINDIR=`dirname "$0"`
+BK_HOME=`cd ${BINDIR}/..;pwd`
+
+python -m pip install --user --upgrade setuptools wheel twine
+
+rm ${BK_HOME}/dist/*
+python setup.py sdist bdist_wheel
+twine upload dist/*
diff --git a/stream/clients/python/scripts/publish_staging.sh 
b/stream/clients/python/scripts/publish_staging.sh
new file mode 100755
index 00..363a768e07
--- /dev/null
+++ b/stream/clients/python/scripts/publish_staging.sh
@@ -0,0 +1,30 @@
+#!/usr/bin/env bash
+#
+#/**
+# * Licensed to the Apache Software Foundation (ASF) under one
+# * or more contributor license agreements.  See the NOTICE file
+# * distributed with this work for additional information
+# * regarding copyright ownership.  The ASF licenses this file
+# * to you under the Apache License, Version 2.0 (the
+# * "License"); you may not use this file except in compliance
+# * with the License.  You may obtain a copy of the License at
+# *
+# * http://www.apache.org/licenses/LICENSE-2.0
+# *
+# * Unless required by applicable law or agreed to in writing, software
+# * distributed under the License is distributed on an "AS IS" BASIS,
+# * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# * See the License for the specific language governing permissions and
+# * limitations under the License.
+# */
+
+# Upload python client to pypi staging
+
+BINDIR=`dirname "$0"`
+BK_HOME=`cd ${BINDIR}/..;pwd`
+
+python -m pip install --user --upgrade setuptools wheel twine
+
+rm ${BK_HOME}/dist/*
+python setup.py sdist bdist_wheel
+twine upload --repository-url https://test.pypi.org/legacy/ dist/*
diff --git a/stream/clients/python/setup.py b/stream/clients/python/setup.py
index 49afd7a424..74a8b0ca07 100644
--- a/stream/clients/python/setup.py
+++ b/stream/clients/python/setup.py
@@ -17,9 +17,9 @@
 
 # Package metadata.
 
-name = 'bookkeeper'
+name = 'apache-bookkeeper-client'
 description = 'Apache BookKeeper client library'
-version = '4.9.0'
+version = '4.9.0-alpha-0'
 # Should be one of:
 # 'Development Status :: 3 - Alpha'
 # 'Development Status :: 4 - Beta'
@@ -42,7 +42,7 @@
 
 package_root = os.path.abspath(os.path.dirname(__file__))
 

[GitHub] sijie closed pull request #1726: Introduce lifecycle components for managing components in AutoRecovery

[GitBox]

sijie closed pull request #1726: Introduce lifecycle components for managing 
components in AutoRecovery
URL: https://github.com/apache/bookkeeper/pull/1726
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/bookkeeper-server/pom.xml b/bookkeeper-server/pom.xml
index 90dcf0a5c4..89e696357f 100644
--- a/bookkeeper-server/pom.xml
+++ b/bookkeeper-server/pom.xml
@@ -131,6 +131,18 @@
   test-jar
   test
 
+
+  org.apache.bookkeeper.stats
+  prometheus-metrics-provider
+  ${project.parent.version}
+  test
+
+
+  org.apache.bookkeeper.http
+  vertx-http-server
+  ${project.parent.version}
+  test
+
   
   
 
diff --git 
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/AutoRecoveryMain.java
 
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/AutoRecoveryMain.java
index d63e19eac3..cd4aee2ce0 100644
--- 
a/bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/AutoRecoveryMain.java
+++ 
b/bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/AutoRecoveryMain.java
@@ -27,19 +27,26 @@
 
 import java.io.File;
 import java.io.IOException;
+import java.lang.Thread.UncaughtExceptionHandler;
 import java.net.MalformedURLException;
+import java.util.concurrent.ExecutionException;
 
 import org.apache.bookkeeper.bookie.Bookie;
 import org.apache.bookkeeper.bookie.BookieCriticalThread;
 import org.apache.bookkeeper.bookie.ExitCode;
 import org.apache.bookkeeper.client.BKException;
 import org.apache.bookkeeper.client.BookKeeper;
+import org.apache.bookkeeper.common.component.ComponentStarter;
+import org.apache.bookkeeper.common.component.LifecycleComponent;
+import org.apache.bookkeeper.common.component.LifecycleComponentStack;
 import org.apache.bookkeeper.conf.ServerConfiguration;
-import org.apache.bookkeeper.http.HttpServer;
-import org.apache.bookkeeper.http.HttpServerLoader;
 import 
org.apache.bookkeeper.replication.ReplicationException.CompatibilityException;
 import 
org.apache.bookkeeper.replication.ReplicationException.UnavailableException;
+import org.apache.bookkeeper.server.conf.BookieConfiguration;
 import org.apache.bookkeeper.server.http.BKHttpServiceProvider;
+import org.apache.bookkeeper.server.service.AutoRecoveryService;
+import org.apache.bookkeeper.server.service.HttpService;
+import org.apache.bookkeeper.server.service.StatsProviderService;
 import org.apache.bookkeeper.stats.NullStatsLogger;
 import org.apache.bookkeeper.stats.StatsLogger;
 import org.apache.commons.cli.BasicParser;
@@ -70,6 +77,9 @@
 private volatile boolean shuttingDown = false;
 private volatile boolean running = false;
 
+// Exception handler
+private volatile UncaughtExceptionHandler uncaughtExceptionHandler = null;
+
 public AutoRecoveryMain(ServerConfiguration conf) throws IOException,
 InterruptedException, KeeperException, UnavailableException,
 CompatibilityException {
@@ -102,6 +112,9 @@ public AutoRecoveryMain(ServerConfiguration conf, 
StatsLogger statsLogger)
 public void start() throws UnavailableException {
 auditorElector.start();
 replicationWorker.start();
+if (null != uncaughtExceptionHandler) {
+deathWatcher.setUncaughtExceptionHandler(uncaughtExceptionHandler);
+}
 deathWatcher.start();
 running = true;
 }
@@ -129,13 +142,6 @@ private void shutdown(int exitCode) {
 shuttingDown = true;
 running = false;
 this.exitCode = exitCode;
-try {
-deathWatcher.interrupt();
-deathWatcher.join();
-} catch (InterruptedException e) {
-Thread.currentThread().interrupt();
-LOG.warn("Interrupted shutting down auto recovery", e);
-}
 
 try {
 auditorElector.shutdown();
@@ -158,6 +164,18 @@ private int getExitCode() {
 return exitCode;
 }
 
+/**
+ * Currently the uncaught exception handler is used for DeathWatcher to 
notify
+ * lifecycle management that a bookie is dead for some reasons.
+ *
+ * in future, we can register this exceptionHandler to 
critical threads
+ * so when those threads are dead, it will automatically trigger lifecycle 
management
+ * to shutdown the process.
+ */
+public void setExceptionHandler(UncaughtExceptionHandler exceptionHandler) 
{
+this.uncaughtExceptionHandler = exceptionHandler;
+}
+
 @VisibleForTesting
 public Auditor getAuditor() {
 return auditorElector.getAuditor();
@@ -171,7 +189,7 @@ public boolean isAutoRecoveryRunning() {
 /*
  * DeathWatcher for AutoRecovery daemons.
  */
-private static class 

Jenkins build is back to normal : bookkeeper-seed #334

[Apache Jenkins Server]

See 

[GitHub] sijie commented on issue #1734: [table service][client] provide scripts for uploading python clients to pypi

[GitBox]

sijie commented on issue #1734:  [table service][client] provide scripts for 
uploading python clients to pypi
URL: https://github.com/apache/bookkeeper/pull/1734#issuecomment-426907859
 
 
   > I wonder if it better to send an explicit email to dev list.
   
   we can have a CI job to upload to pypi and send the email. 
   
   > We should also start providing docs about these features
   
   yes. that would be the blocker for 4.9


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: bookkeeper-seed #332

[Apache Jenkins Server]

See 

--
Started by timer
[EnvInject] - Loading node environment variables.
Building remotely on H28 (ubuntu xenial) in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/apache/bookkeeper.git # 
 > timeout=10
Fetching upstream changes from https://github.com/apache/bookkeeper.git
 > git --version # timeout=10
 > git fetch --tags --progress https://github.com/apache/bookkeeper.git 
 > +refs/heads/*:refs/remotes/origin/* 
 > +refs/pull/${ghprbPullId}/*:refs/remotes/origin/pr/${ghprbPullId}/*
ERROR: Error fetching remote repo 'origin'
hudson.plugins.git.GitException: Failed to fetch from 
https://github.com/apache/bookkeeper.git
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:888)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1155)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1186)
at hudson.scm.SCM.checkout(SCM.java:504)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1208)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1794)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Caused by: hudson.plugins.git.GitException: Command "git fetch --tags 
--progress https://github.com/apache/bookkeeper.git 
+refs/heads/*:refs/remotes/origin/* 
+refs/pull/${ghprbPullId}/*:refs/remotes/origin/pr/${ghprbPullId}/*" returned 
status code 128:
stdout: 
stderr: error: Could not read 626abbf4b867b1c2c8eb35b6ead0596d493c2b1b
error: Could not read d47bd12b701fae6e76b34e88d240888c1263
error: Could not read e04c791499e51f2d5b4f288c5f349777103c555d
remote: Enumerating objects: 3250, done.
remote: Counting objects:   0% (1/3250)   remote: Counting objects:   
1% (33/3250)   remote: Counting objects:   2% (65/3250)   
remote: Counting objects:   3% (98/3250)   remote: Counting objects:   
4% (130/3250)   remote: Counting objects:   5% (163/3250)   
remote: Counting objects:   6% (195/3250)   remote: Counting objects:   
7% (228/3250)   remote: Counting objects:   8% (260/3250)   
remote: Counting objects:   9% (293/3250)   remote: Counting objects:  
10% (325/3250)   remote: Counting objects:  11% (358/3250)   
remote: Counting objects:  12% (390/3250)   remote: Counting objects:  
13% (423/3250)   remote: Counting objects:  14% (455/3250)   
remote: Counting objects:  15% (488/3250)   remote: Counting objects:  
16% (520/3250)   remote: Counting objects:  17% (553/3250)   
remote: Counting objects:  18% (585/3250)   remote: Counting objects:  
19% (618/3250)   remote: Counting objects:  20% (650/3250)   
remote: Counting objects:  21% (683/3250)   remote: Counting objects:  
22% (715/3250)   remote: Counting objects:  23% (748/3250)   
remote: Counting objects:  24% (780/3250)   remote: Counting objects:  
25% (813/3250)   remote: Counting objects:  26% (845/3250)   
remote: Counting objects:  27% (878/3250)   remote: Counting objects:  
28% (910/3250)   remote: Counting objects:  29% (943/3250)   
remote: Counting objects:  30% (975/3250)   remote: Counting objects:  
31% (1008/3250)   remote: Counting objects:  32% (1040/3250)   
remote: Counting objects:  33% (1073/3250)   remote: Counting objects:  
34% (1105/3250)   remote: Counting objects:  35% (1138/3250)   
remote: Counting objects:  36% (1170/3250)   remote: Counting objects:  
37% (1203/3250)   remote: Counting objects:  38% (1235/3250)   
remote: Counting objects:  39% (1268/3250)   remote: Counting objects:  
40% (1300/3250)   remote: Counting objects:  41% (1333/3250)   
remote: Counting objects:  42% (1365/3250)   remote: Counting objects:  
43% (1398/3250)   remote: Counting objects:  44% (1430/3250)   
remote: Counting objects:  45% (1463/3250)   remote: Counting objects:  
46% (1495/3250)   remote: Counting objects:  47% (1528/3250)   
remote: Counting objects:  48% (1560/3250)   remote: Counting objects:  
49% (1593/3250)   remote: Counting objects:  50% (1625/3250)   
remote: Counting objects: