[GitHub] carbondata issue #2291: [CARBONDATA-2460] [CARBONDATA-2461] [CARBONDATA-2462...
Github user kunal642 commented on the issue: https://github.com/apache/carbondata/pull/2291 retest this please ---
[GitHub] carbondata issue #2262: [CARBONDATA-2431] Incremental data added after exter...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2262 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5828/ ---
[GitHub] carbondata issue #2262: [CARBONDATA-2431] Incremental data added after exter...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2262 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4672/ ---
[GitHub] carbondata issue #984: [CARBONDATA-1008] Make Carbon table schema compatible...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/984 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4876/ ---
[GitHub] carbondata issue #2262: [CARBONDATA-2431] Incremental data added after exter...
Github user rahulforallp commented on the issue: https://github.com/apache/carbondata/pull/2262 retest this please ---
[GitHub] carbondata issue #2291: [CARBONDATA-2460] [CARBONDATA-2461] [CARBONDATA-2462...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2291 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4875/ ---
[GitHub] carbondata issue #2278: [CARBONDATA-2452] [CARBONDATA-2451] [CARBONDATA-2450...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2278 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4874/ ---
[GitHub] carbondata issue #2298: [HOTFIX]Fixed checkstyle issue
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2298 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4873/ ---
[GitHub] carbondata issue #2262: [CARBONDATA-2431] Incremental data added after exter...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2262 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4872/ ---
[jira] [Resolved] (CARBONDATA-2455) Fix _System Folder creation and lucene AND,OR,NOT Filter fix
[ https://issues.apache.org/jira/browse/CARBONDATA-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacky Li resolved CARBONDATA-2455. -- Resolution: Fixed Fix Version/s: 1.4.0 > Fix _System Folder creation and lucene AND,OR,NOT Filter fix > > > Key: CARBONDATA-2455 > URL: https://issues.apache.org/jira/browse/CARBONDATA-2455 > Project: CarbonData > Issue Type: Improvement >Reporter: Indhumathi Muthumurugesh >Assignee: Indhumathi Muthumurugesh >Priority: Minor > Fix For: 1.4.0 > > Time Spent: 4.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] carbondata pull request #2281: [CARBONDATA-2455]Fix _System Folder creation ...
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/2281 ---
[GitHub] carbondata issue #2281: [CARBONDATA-2455]Fix _System Folder creation and luc...
Github user jackylk commented on the issue: https://github.com/apache/carbondata/pull/2281 LGTM ---
[GitHub] carbondata issue #2262: [CARBONDATA-2431] Incremental data added after exter...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2262 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4871/ ---
[GitHub] carbondata issue #2278: [CARBONDATA-2452] [CARBONDATA-2451] [CARBONDATA-2450...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2278 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4870/ ---
[GitHub] carbondata issue #2297: [CARBONDATA-2471]Added support for No Dictionary Com...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2297 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4869/ ---
[GitHub] carbondata issue #2273: [CARBONDATA-2442] and [CARBONDATA-2469] Fixed: multi...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2273 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4868/ ---
[GitHub] carbondata issue #2262: [CARBONDATA-2431] Incremental data added after exter...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2262 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4867/ ---
[GitHub] carbondata issue #2291: [CARBONDATA-2460] [CARBONDATA-2461] [CARBONDATA-2462...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2291 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4671/ ---
[GitHub] carbondata issue #2291: [CARBONDATA-2460] [CARBONDATA-2461] [CARBONDATA-2462...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2291 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5827/ ---
[GitHub] carbondata issue #2296: [CARBONDATA-2369] updated the document about AVRO to...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2296 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4866/ ---
[GitHub] carbondata pull request #2278: [CARBONDATA-2452] [CARBONDATA-2451] [CARBONDA...
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/2278 ---
[GitHub] carbondata issue #2278: [CARBONDATA-2452] [CARBONDATA-2451] [CARBONDATA-2450...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2278 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4670/ ---
[GitHub] carbondata issue #2278: [CARBONDATA-2452] [CARBONDATA-2451] [CARBONDATA-2450...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2278 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5826/ ---
[GitHub] carbondata issue #2278: [CARBONDATA-2452] [CARBONDATA-2451] [CARBONDATA-2450...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2278 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4865/ ---
[GitHub] carbondata issue #2273: [CARBONDATA-2442] and [CARBONDATA-2469] Fixed: multi...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2273 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4864/ ---
[GitHub] carbondata issue #2297: [CARBONDATA-2471]Added support for No Dictionary Com...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2297 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4668/ ---
[GitHub] carbondata issue #2297: [CARBONDATA-2471]Added support for No Dictionary Com...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2297 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5824/ ---
[GitHub] carbondata issue #2262: [CARBONDATA-2431] Incremental data added after exter...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2262 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5821/ ---
[GitHub] carbondata issue #2278: [CARBONDATA-2452] [CARBONDATA-2451] [CARBONDATA-2450...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2278 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5822/ ---
[GitHub] carbondata issue #2262: [CARBONDATA-2431] Incremental data added after exter...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2262 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4863/ ---
[GitHub] carbondata issue #2297: [CARBONDATA-2471]Added support for No Dictionary Com...
Github user kumarvishal09 commented on the issue: https://github.com/apache/carbondata/pull/2297 retest this please ---
[GitHub] carbondata issue #2278: [CARBONDATA-2452] [CARBONDATA-2451] [CARBONDATA-2450...
Github user kunal642 commented on the issue: https://github.com/apache/carbondata/pull/2278 retest this please ---
[GitHub] carbondata issue #2295: [CARBONDATA-2470] Refactor AlterTableCompactionPostS...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2295 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4862/ ---
[GitHub] carbondata issue #2278: [CARBONDATA-2452] [CARBONDATA-2451] [CARBONDATA-2450...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2278 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4667/ ---
[GitHub] carbondata issue #2298: [HOTFIX]Fixed checkstyle issue
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2298 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4666/ ---
[GitHub] carbondata issue #2298: [HOTFIX]Fixed checkstyle issue
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2298 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5819/ ---
[GitHub] carbondata issue #2278: [CARBONDATA-2452] [CARBONDATA-2451] [CARBONDATA-2450...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2278 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4861/ ---
[GitHub] carbondata issue #2296: [CARBONDATA-2369] updated the document about AVRO to...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2296 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5814/ ---
[GitHub] carbondata issue #2273: [CARBONDATA-2442] and [CARBONDATA-2469] Fixed: multi...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2273 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4860/ ---
[GitHub] carbondata issue #2278: [CARBONDATA-2452] [CARBONDATA-2451] [CARBONDATA-2450...
Github user kunal642 commented on the issue: https://github.com/apache/carbondata/pull/2278 retest this please ---
[GitHub] carbondata pull request #2298: [HOTFIX]Fixed checkstyle issue
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/2298 ---
[GitHub] carbondata issue #2296: [CARBONDATA-2369] updated the document about AVRO to...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2296 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4659/ ---
[GitHub] carbondata issue #2297: [CARBONDATA-2471]Added support for No Dictionary Com...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2297 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5818/ ---
[GitHub] carbondata issue #2273: [CARBONDATA-2442] and [CARBONDATA-2469] Fixed: multi...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2273 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5817/ ---
[GitHub] carbondata issue #2278: [CARBONDATA-2452] [CARBONDATA-2451] [CARBONDATA-2450...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2278 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5816/ ---
[GitHub] carbondata pull request #2298: [HOTFIX]Fixed checkstyle issue
GitHub user kumarvishal09 opened a pull request: https://github.com/apache/carbondata/pull/2298 [HOTFIX]Fixed checkstyle issue Fixed checkstyle issue - [ ] Any interfaces changed? - [ ] Any backward compatibility impacted? - [ ] Document update required? - [ ] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? - How it is tested? Please attach test report. - Is it a performance related change? Please attach the performance test report. - Any additional information to help reviewers in testing this change. - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kumarvishal09/incubator-carbondata complation Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/2298.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2298 commit 716d7cc28804336157ea7563448e145f14b8c5a8 Author: kumarvishal09Date: 2018-05-10T18:04:36Z Fixed checkstyle issue ---
[GitHub] carbondata issue #2262: [CARBONDATA-2431] Incremental data added after exter...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2262 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4665/ ---
[GitHub] carbondata issue #2278: [CARBONDATA-2452] [CARBONDATA-2451] [CARBONDATA-2450...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2278 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4663/ ---
[GitHub] carbondata issue #2297: [CARBONDATA-2471]Added support for No Dictionary Com...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2297 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4662/ ---
[GitHub] carbondata issue #2262: [CARBONDATA-2431] Incremental data added after exter...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2262 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4661/ ---
[GitHub] carbondata issue #2273: [CARBONDATA-2442] and [CARBONDATA-2469] Fixed: multi...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2273 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4657/ ---
[GitHub] carbondata issue #2278: [CARBONDATA-2452] [CARBONDATA-2451] [CARBONDATA-2450...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2278 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4660/ ---
[GitHub] carbondata issue #2290: [CARBONDATA-2389] Search mode support lucene datamap
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2290 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4859/ ---
[GitHub] carbondata issue #2286: [CARBONDATA-2417] [SDK Writer] SDK writer goes to in...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2286 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4857/ ---
[GitHub] carbondata issue #2294: [CARBONDATA-2443][SDK] Multi level complex type supp...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2294 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4858/ ---
[GitHub] carbondata pull request #2297: [CARBONDATA-2471]Added support for No Diction...
GitHub user kumarvishal09 opened a pull request: https://github.com/apache/carbondata/pull/2297 [CARBONDATA-2471]Added support for No Dictionary Complex type for Double, Decimal, Date type in SDK Added support for No Dictionary Complex type for Double, Decimal, Date type in SDK - [ ] Any interfaces changed? - [ ] Any backward compatibility impacted? - [ ] Document update required? - [ ] Testing done Added UT for each data type - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kumarvishal09/incubator-carbondata nodicdouble Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/2297.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2297 commit 46a37226356d3cc619317b633d13d396016a4a6d Author: kunal642Date: 2018-05-07T15:28:21Z fixed issues related to complex types commit 57b7ad8f8ac55cd2b027a26de9cf6df9ca855301 Author: kumarvishal09 Date: 2018-05-10T17:22:09Z added support for Double, Decimal, date data type in No Dictionary Complex type ---
[jira] [Resolved] (CARBONDATA-2469) External Table must show its location instead of default store path in describe formatted
[ https://issues.apache.org/jira/browse/CARBONDATA-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kunal Kapoor resolved CARBONDATA-2469. -- Resolution: Fixed Fix Version/s: 1.4.0 > External Table must show its location instead of default store path in > describe formatted > - > > Key: CARBONDATA-2469 > URL: https://issues.apache.org/jira/browse/CARBONDATA-2469 > Project: CarbonData > Issue Type: Bug >Reporter: Ajantha Bhat >Assignee: Ajantha Bhat >Priority: Major > Fix For: 1.4.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (CARBONDATA-2471) []Added support for No Dictionary Complex type for Double, Decimal, Date type in SDK
kumar vishal created CARBONDATA-2471: Summary: []Added support for No Dictionary Complex type for Double, Decimal, Date type in SDK Key: CARBONDATA-2471 URL: https://issues.apache.org/jira/browse/CARBONDATA-2471 Project: CarbonData Issue Type: Improvement Reporter: kumar vishal Assignee: kumar vishal Support No Dictionary Complex type for Double, Decimal, Date type in SDK -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (CARBONDATA-2469) External Table must show its location instead of default store path in describe formatted
[ https://issues.apache.org/jira/browse/CARBONDATA-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kunal Kapoor reassigned CARBONDATA-2469: Assignee: Ajantha Bhat > External Table must show its location instead of default store path in > describe formatted > - > > Key: CARBONDATA-2469 > URL: https://issues.apache.org/jira/browse/CARBONDATA-2469 > Project: CarbonData > Issue Type: Bug >Reporter: Ajantha Bhat >Assignee: Ajantha Bhat >Priority: Major > Fix For: 1.4.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (CARBONDATA-2442) Reading two sdk writer output with differnt schema should prompt exception
[ https://issues.apache.org/jira/browse/CARBONDATA-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kunal Kapoor resolved CARBONDATA-2442. -- Resolution: Fixed Fix Version/s: 1.4.0 > Reading two sdk writer output with differnt schema should prompt exception > -- > > Key: CARBONDATA-2442 > URL: https://issues.apache.org/jira/browse/CARBONDATA-2442 > Project: CarbonData > Issue Type: Bug >Reporter: Ajantha Bhat >Assignee: Ajantha Bhat >Priority: Major > Fix For: 1.4.0 > > Time Spent: 6h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (CARBONDATA-2442) Reading two sdk writer output with differnt schema should prompt exception
[ https://issues.apache.org/jira/browse/CARBONDATA-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kunal Kapoor reassigned CARBONDATA-2442: Assignee: Ajantha Bhat > Reading two sdk writer output with differnt schema should prompt exception > -- > > Key: CARBONDATA-2442 > URL: https://issues.apache.org/jira/browse/CARBONDATA-2442 > Project: CarbonData > Issue Type: Bug >Reporter: Ajantha Bhat >Assignee: Ajantha Bhat >Priority: Major > Fix For: 1.4.0 > > Time Spent: 6h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] carbondata pull request #2273: [CARBONDATA-2442] and [CARBONDATA-2469] Fixed...
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/2273 ---
[GitHub] carbondata issue #2273: [CARBONDATA-2442] and [CARBONDATA-2469] Fixed: multi...
Github user kumarvishal09 commented on the issue: https://github.com/apache/carbondata/pull/2273 LGTM ---
[GitHub] carbondata issue #2273: [CARBONDATA-2442] and [CARBONDATA-2469] Fixed: multi...
Github user kunal642 commented on the issue: https://github.com/apache/carbondata/pull/2273 LGTM ---
[GitHub] carbondata pull request #2273: [CARBONDATA-2442] and [CARBONDATA-2469] Fixed...
Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2273#discussion_r187397546 --- Diff: core/src/main/java/org/apache/carbondata/core/readcommitter/LatestFilesReadCommittedScope.java --- @@ -122,6 +122,11 @@ private String getSegmentID(String carbonIndexFileName, String indexFilePath) { @Override public void takeCarbonIndexFileSnapShot() throws IOException { // Read the current file Path get the list of indexes from the path. CarbonFile file = FileFactory.getCarbonFile(carbonFilePath); +if (file == null) { + // For nonTransactional table, files can be removed at any point of time. + // So cannot assume files will be present + throw new IOException("No files are present in the table location"); --- End diff -- append File path in exception message ---
[GitHub] carbondata issue #2262: [CARBONDATA-2431] Incremental data added after exter...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2262 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4658/ ---
[GitHub] carbondata issue #2278: [CARBONDATA-2452] [CARBONDATA-2451] [CARBONDATA-2450...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2278 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4656/ ---
[GitHub] carbondata issue #2278: [CARBONDATA-2452] [CARBONDATA-2451] [CARBONDATA-2450...
Github user kunal642 commented on the issue: https://github.com/apache/carbondata/pull/2278 Retest this please ---
[GitHub] carbondata issue #2262: [CARBONDATA-2431] Incremental data added after exter...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2262 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5815/ ---
[GitHub] carbondata issue #2278: [CARBONDATA-2452] [CARBONDATA-2451] [CARBONDATA-2450...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2278 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5813/ ---
[GitHub] carbondata issue #2262: [CARBONDATA-2431] Incremental data added after exter...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2262 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5812/ ---
[GitHub] carbondata issue #2295: [CARBONDATA-2470] Refactor AlterTableCompactionPostS...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2295 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4655/ ---
[GitHub] carbondata issue #2273: [CARBONDATA-2442] and [CARBONDATA-2469] Fixed: multi...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2273 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4654/ ---
[GitHub] carbondata issue #2278: [CARBONDATA-2452] [CARBONDATA-2451] [CARBONDATA-2450...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2278 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4856/ ---
[GitHub] carbondata pull request #2262: [CARBONDATA-2431] Incremental data added afte...
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2262#discussion_r187376048 --- Diff: core/src/main/java/org/apache/carbondata/core/readcommitter/TableStatusReadCommittedScope.java --- @@ -77,6 +78,12 @@ public TableStatusReadCommittedScope(AbsoluteTableIdentifier identifier, return indexFiles; } + public MapgetCommitedSegmentTimestampUpdaterMap( + Segment segment) throws IOException { +Map indexFiles = new HashMap<>(); +return indexFiles; --- End diff -- It should return only SegmentRefreshInfo object not Map. And it should be fillied with updateVo timestamp. ---
[GitHub] carbondata issue #2273: [CARBONDATA-2442] and [CARBONDATA-2469] Fixed: multi...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2273 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5811/ ---
[GitHub] carbondata issue #2290: [CARBONDATA-2389] Search mode support lucene datamap
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2290 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4652/ ---
[GitHub] carbondata issue #2295: [CARBONDATA-2470] Refactor AlterTableCompactionPostS...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2295 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5810/ ---
[GitHub] carbondata pull request #2274: [CARBONDATA-2440] default value of ENABLE_OFF...
Github user rahulforallp commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2274#discussion_r187368858 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java --- @@ -340,7 +342,13 @@ private CarbonLoadModel createLoadModel() throws IOException, InvalidLoadOptionE // we are still using the traditional carbon table folder structure persistSchemaFile(table, CarbonTablePath.getSchemaFilePath(path)); } - +if (!table.isTransactionalTable()) { + CarbonProperties.getInstance() + .addProperty(CarbonCommonConstants.ENABLE_OFFHEAP_SORT, "false"); --- End diff -- Intention was to prevent 'unsafe' property from being used by SDK user by default. Otherwise they have to configure memory for unsafe also. So making it simple to use. Any way we will update the doc how SDK user can set the property by following code: CarbonProperties.getInstance() .addProperty("property", "value"); ---
[GitHub] carbondata pull request #2296: [CARBONDATA-2369] updated the document about ...
GitHub user ajantha-bhat opened a pull request: https://github.com/apache/carbondata/pull/2296 [CARBONDATA-2369] updated the document about AVRO to carbon schema converter [CARBONDATA-2369] updated the document about AVRO to carbon schema converter Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any interfaces changed? Added new interface. - [ ] Any backward compatibility impacted? NA - [ ] Document update required? updated - [ ] Testing done. NA You can merge this pull request into a Git repository by running: $ git pull https://github.com/ajantha-bhat/carbondata master_doc Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/2296.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2296 commit 3b6ab9f1875e1effe6da604d480355458df8d20c Author: ajantha-bhatDate: 2018-05-10T15:33:28Z [CARBONDATA-2369] updated the document about AVRO to carbon schema converter ---
[GitHub] carbondata issue #2290: [CARBONDATA-2389] Search mode support lucene datamap
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2290 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4855/ ---
[GitHub] carbondata issue #2278: [CARBONDATA-2452] [CARBONDATA-2451] [CARBONDATA-2450...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2278 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4653/ ---
[GitHub] carbondata pull request #2286: [CARBONDATA-2417] [SDK Writer] SDK writer goe...
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/2286 ---
[GitHub] carbondata issue #2293: [CARBONDATA-2468] addition of column to default sort...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2293 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4854/ ---
[GitHub] carbondata pull request #2294: [CARBONDATA-2443][SDK] Multi level complex ty...
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/2294 ---
[GitHub] carbondata issue #2294: [CARBONDATA-2443][SDK] Multi level complex type supp...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2294 LGTM ---
[GitHub] carbondata issue #2278: [CARBONDATA-2452] [CARBONDATA-2451] [CARBONDATA-2450...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2278 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5808/ ---
[GitHub] carbondata issue #2290: [CARBONDATA-2389] Search mode support lucene datamap
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2290 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4853/ ---
[GitHub] carbondata issue #2292: [CARBONDATA-2467] sdk writer log shouldnot print nul...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2292 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4851/ ---
[GitHub] carbondata pull request #2294: [CARBONDATA-2443][SDK] Multi level complex ty...
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2294#discussion_r187343421 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableSchemaBuilder.java --- @@ -114,12 +115,12 @@ public void setSortColumns(List sortColumns) { this.sortColumns = sortColumns; } - public ColumnSchema addColumn(StructField field, boolean isSortColumn) { -return addColumn(field, null, isSortColumn, false); + public ColumnSchema addColumn(StructField field, AtomicInteger valIndex, boolean isSortColumn) { --- End diff -- AtomicInteger is not used here for multi threading purpose. It is used for incrementing a value for complex boolean array type to assign child column name ---
[GitHub] carbondata pull request #2294: [CARBONDATA-2443][SDK] Multi level complex ty...
Github user sounakr commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2294#discussion_r187337029 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableSchemaBuilder.java --- @@ -114,12 +115,12 @@ public void setSortColumns(List sortColumns) { this.sortColumns = sortColumns; } - public ColumnSchema addColumn(StructField field, boolean isSortColumn) { -return addColumn(field, null, isSortColumn, false); + public ColumnSchema addColumn(StructField field, AtomicInteger valIndex, boolean isSortColumn) { --- End diff -- Do we need Atomic Integer ? This is single threaded. Later phase also even if writer becomes multi threaded, building schema and CarbonTable should remain single threaded only. ---
[GitHub] carbondata issue #2294: [CARBONDATA-2443][SDK] Multi level complex type supp...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2294 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4649/ ---
[GitHub] carbondata issue #2281: [CARBONDATA-2455]Fix _System Folder creation and luc...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2281 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4850/ ---
[GitHub] carbondata issue #2290: [CARBONDATA-2389] Search mode support lucene datamap
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2290 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5807/ ---
[GitHub] carbondata pull request #2295: [CARBONDATA-2470] Refactor AlterTableCompacti...
GitHub user dhatchayani opened a pull request: https://github.com/apache/carbondata/pull/2295 [CARBONDATA-2470] Refactor AlterTableCompactionPostStatusUpdateEvent usage in compaction flow AlterTableCompactionPostStatusUpdateEvent is a generic event fired after COMPACTION but it is controlled only by the preaggregate listener. If the CommitPreAggregateListener sets the commitComplete property to true, this event will not be fired for the next iteration. For each and every compacted segments this must be fired. - [ ] Any interfaces changed? - [ ] Any backward compatibility impacted? - [ ] Document update required? - [x] Testing done UTs are already there - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dhatchayani/carbondata postEvent Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/2295.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2295 commit b350b40643c6355b74c03b047579401fd54acae6 Author: dhatchayaniDate: 2018-05-10T13:37:53Z [CARBONDATA-2470] Refactor AlterTableCompactionPostStatusUpdateEvent usage in compaction flow ---
[jira] [Created] (CARBONDATA-2470) Refactor AlterTableCompactionPostStatusUpdateEvent usage in compaction flow
dhatchayani created CARBONDATA-2470: --- Summary: Refactor AlterTableCompactionPostStatusUpdateEvent usage in compaction flow Key: CARBONDATA-2470 URL: https://issues.apache.org/jira/browse/CARBONDATA-2470 Project: CarbonData Issue Type: Improvement Reporter: dhatchayani Assignee: dhatchayani AlterTableCompactionPostStatusUpdateEvent in compaction flow is controlled only by the preaggregate listener. If the CommitPreAggregateListener sets the commitComplete property to true, this event will not be fired for the next iteration -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] carbondata issue #2286: [CARBONDATA-2417] [SDK Writer] SDK writer goes to in...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2286 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5805/ ---
[GitHub] carbondata issue #2278: [CARBONDATA-2452] [CARBONDATA-2451] [CARBONDATA-2450...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2278 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5804/ ---
[GitHub] carbondata issue #2290: [CARBONDATA-2389] Search mode support lucene datamap
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2290 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4647/ ---
[GitHub] carbondata issue #2273: [CARBONDATA-2442] and [CARBONDATA-2469] Fixed: Readi...
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2273 retest this please ---