[GitHub] carbondata pull request #3035: [CARBONDATA-3216] Fix some bugs in CSDK
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3035#discussion_r244947464
--- Diff: store/CSDK/test/main.cpp ---
@@ -709,6 +709,7 @@ bool testWithTableProperty(JNIEnv *env, char *path, int
argc, char **argv) {
writer.outputPath(path);
writer.withCsvInput(jsonSchema);
writer.withTableProperty("sort_columns", "shortField");
+writer.enableLocalDictionary(false);
--- End diff --
add test code for it. In CPP, it will convert NULL to false when user
invoke CarbonWriter::enableLocalDictionary.
---
[GitHub] carbondata pull request #3035: [CARBONDATA-3216] Fix some bugs in CSDK
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3035#discussion_r244946154
--- Diff: store/CSDK/test/main.cpp ---
@@ -546,7 +546,7 @@ bool testWriteData(JNIEnv *env, char *path, int argc,
char *argv[]) {
writer.withCsvInput(jsonSchema);
writer.withLoadOption("complex_delimiter_level_1", "#");
writer.writtenBy("CSDK");
-writer.taskNo(185);
+writer.taskNo(15541554.81);
--- End diff --
There are some different between CPP and java: java taskNo don't support
double, but CPP will convert double to long.
---
[GitHub] carbondata pull request #3035: [CARBONDATA-3216] Fix some bugs in CSDK
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3035#discussion_r244945691
--- Diff: store/CSDK/test/main.cpp ---
@@ -853,7 +854,7 @@ int main(int argc, char *argv[]) {
} else {
int batch = 32000;
int printNum = 32000;
-
+//
--- End diff --
ok, done
---
[GitHub] carbondata pull request #3035: [CARBONDATA-3216] Fix some bugs in CSDK
Github user ajantha-bhat commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3035#discussion_r244915526
--- Diff: store/CSDK/src/CarbonWriter.cpp ---
@@ -291,9 +291,6 @@ void CarbonWriter::localDictionaryThreshold(int
localDictionaryThreshold) {
}
void CarbonWriter::enableLocalDictionary(bool enableLocalDictionary) {
-if (enableLocalDictionary == NULL) {
--- End diff --
@KanakaKumar : In CPP, boolean false value is same as NULL. Both are zero.
Hence when we pass false, it always throws exception due to this wrong code.
Hence he removed.
@xubo245 : This is just two removal, no need separate PR. you can do with
#3048
---
[GitHub] carbondata pull request #3035: [CARBONDATA-3216] Fix some bugs in CSDK
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3035#discussion_r244908015
--- Diff: store/CSDK/test/main.cpp ---
@@ -709,6 +709,7 @@ bool testWithTableProperty(JNIEnv *env, char *path, int
argc, char **argv) {
writer.outputPath(path);
writer.withCsvInput(jsonSchema);
writer.withTableProperty("sort_columns", "shortField");
+writer.enableLocalDictionary(false);
--- End diff --
Can you test if there is any possibility to give NULL in C and how it is
sent to java layer ? true or false?
---
[GitHub] carbondata pull request #3035: [CARBONDATA-3216] Fix some bugs in CSDK
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3035#discussion_r244907927
--- Diff: store/CSDK/test/main.cpp ---
@@ -546,7 +546,7 @@ bool testWriteData(JNIEnv *env, char *path, int argc,
char *argv[]) {
writer.withCsvInput(jsonSchema);
writer.withLoadOption("complex_delimiter_level_1", "#");
writer.writtenBy("CSDK");
-writer.taskNo(185);
+writer.taskNo(15541554.81);
--- End diff --
This change not related to fix
---
[GitHub] carbondata pull request #3035: [CARBONDATA-3216] Fix some bugs in CSDK
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3035#discussion_r244907282
--- Diff: store/CSDK/src/CarbonWriter.cpp ---
@@ -291,9 +291,6 @@ void CarbonWriter::localDictionaryThreshold(int
localDictionaryThreshold) {
}
void CarbonWriter::enableLocalDictionary(bool enableLocalDictionary) {
-if (enableLocalDictionary == NULL) {
--- End diff --
Can you give some description in the PR, how removing this solving the
issue?
---
[GitHub] carbondata pull request #3035: [CARBONDATA-3216] Fix some bugs in CSDK
Github user KanakaKumar commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3035#discussion_r244907183
--- Diff: store/CSDK/test/main.cpp ---
@@ -853,7 +854,7 @@ int main(int argc, char *argv[]) {
} else {
int batch = 32000;
int printNum = 32000;
-
+//
--- End diff --
remove unwanted changes
---
[GitHub] carbondata pull request #3035: [CARBONDATA-3216] Fix some bugs in CSDK
GitHub user xubo245 opened a pull request: https://github.com/apache/carbondata/pull/3035 [CARBONDATA-3216] Fix some bugs in CSDK 1.enableLocalDictionary can' t set false Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any interfaces changed? - [ ] Any backward compatibility impacted? - [ ] Document update required? - [ ] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? - How it is tested? Please attach test report. - Is it a performance related change? Please attach the performance test report. - Any additional information to help reviewers in testing this change. - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. You can merge this pull request into a Git repository by running: $ git pull https://github.com/xubo245/carbondata CARBONDATA-3216_FixBugsOfCSDK Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/3035.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3035 commit ca5999c6e629571d6fede92b1101e8c7cee762c7 Author: xubo245 Date: 2018-12-29T03:34:41Z [CARBONDATA-3216] Fix some bugs in CSDK 1.enableLocalDictionary can' t set false ---
