[GitHub] incubator-carbondata issue #806: Docs for optimizing mass data loading
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/806 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #797: [CARBONDATA-927] show segment in data manag...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/797 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #779: [CARBONDATA-899] Added Support for D...
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/779#discussion_r111276805
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataPageSource.java
---
@@ -0,0 +1,192 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.carbondata.presto;
+
+import java.io.IOException;
+import java.math.BigDecimal;
+import java.util.ArrayList;
+import java.util.List;
+
+import com.facebook.presto.spi.ConnectorPageSource;
+import com.facebook.presto.spi.Page;
+import com.facebook.presto.spi.PageBuilder;
+import com.facebook.presto.spi.RecordCursor;
+import com.facebook.presto.spi.RecordSet;
+import com.facebook.presto.spi.block.BlockBuilder;
+import com.facebook.presto.spi.type.DecimalType;
+import com.facebook.presto.spi.type.Type;
+import io.airlift.slice.Slice;
+
+import static com.facebook.presto.spi.type.Decimals.encodeUnscaledValue;
+import static com.facebook.presto.spi.type.Decimals.isShortDecimal;
+import static com.google.common.base.Preconditions.checkArgument;
+import static com.google.common.base.Preconditions.checkState;
+import static java.math.RoundingMode.HALF_UP;
+import static java.util.Collections.unmodifiableList;
+import static java.util.Objects.requireNonNull;
+
+
+public class CarbondataPageSource implements ConnectorPageSource {
--- End diff --
please provide comment for the new class of CarbondataPageSource
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #779: [CARBONDATA-899] Added Support for D...
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/779#discussion_r111276661
--- Diff:
integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataPageSource.java
---
@@ -0,0 +1,192 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.carbondata.presto;
+
+import java.io.IOException;
+import java.math.BigDecimal;
+import java.util.ArrayList;
+import java.util.List;
+
+import com.facebook.presto.spi.ConnectorPageSource;
+import com.facebook.presto.spi.Page;
+import com.facebook.presto.spi.PageBuilder;
+import com.facebook.presto.spi.RecordCursor;
+import com.facebook.presto.spi.RecordSet;
+import com.facebook.presto.spi.block.BlockBuilder;
+import com.facebook.presto.spi.type.DecimalType;
+import com.facebook.presto.spi.type.Type;
+import io.airlift.slice.Slice;
+
+import static com.facebook.presto.spi.type.Decimals.encodeUnscaledValue;
+import static com.facebook.presto.spi.type.Decimals.isShortDecimal;
+import static com.google.common.base.Preconditions.checkArgument;
+import static com.google.common.base.Preconditions.checkState;
+import static java.math.RoundingMode.HALF_UP;
+import static java.util.Collections.unmodifiableList;
+import static java.util.Objects.requireNonNull;
+
+
+public class CarbondataPageSource implements ConnectorPageSource {
+
+ private static final int ROWS_PER_REQUEST = 4096;
+ private final RecordCursor cursor;
+ private final List types;
+ private final PageBuilder pageBuilder;
+ private boolean closed;
+ private final char[] buffer = new char[100];
+
+
--- End diff --
please remove the redundant blank. same for other place also.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #779: [CARBONDATA-899] Added Support for DecimalT...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/779 @bhavya411 verified, it works fine. Can you change title to : Added Support for DecimalType and Timestamp for spark-2.1 for integration/presto, please change JIRA description accordingly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #785: [CARBONDATA-907] The grammar for DELETE SEG...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/785 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #779: [CARBONDATA-899] Added Support for DecimalT...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/779 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #785: [CARBONDATA-907] The grammar for DELETE SEG...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/785 add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #782: [CARBONDATA-901] Fix some spelling mistakes
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/782 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #751: [CARBONDATA-816] Added Example for H...
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/751#discussion_r110723264
--- Diff:
integration/hive/src/main/scala/org/apache/carbondata/hiveexample/HiveExample.scala
---
@@ -0,0 +1,179 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.carbondata.hiveexample
+
+import java.io.File
+import java.sql.{DriverManager, ResultSet, SQLException, Statement}
+
+import org.apache.spark.sql.SparkSession
+
+import org.apache.carbondata.common.logging.LogServiceFactory
+import org.apache.carbondata.hive.server.HiveEmbeddedServer2
+
+object HiveExample {
+
+ private val driverName: String = "org.apache.hive.jdbc.HiveDriver"
+
+ /**
+ * @param args
+ * @throws SQLException
+ */
+ @throws[SQLException]
+ def main(args: Array[String]) {
+val rootPath = new File(this.getClass.getResource("/").getPath
++ "../../../..").getCanonicalPath
+val store = s"$rootPath/integration/hive/target/store"
+val warehouse = s"$rootPath/integration/hive/target/warehouse"
+val metaStore_Db =
s"$rootPath/integration/hive/target/carbon_metaStore_db"
+val logger =
LogServiceFactory.getLogService(this.getClass.getCanonicalName)
+
+import org.apache.spark.sql.CarbonSession._
+
+System.setProperty("hadoop.home.dir", "/")
+
+val carbon = SparkSession
+ .builder()
+ .master("local")
+ .appName("HiveExample")
+ .config("carbon.sql.warehouse.dir", warehouse).enableHiveSupport()
+ .getOrCreateCarbonSession(
+store, metaStore_Db)
+
+val carbonHadoopJarPath =
s"$rootPath/assembly/target/scala-2.11/carbondata_2.11-1.1" +
+
".0-incubating-SNAPSHOT-shade-hadoop2.7.2.jar"
+
+val carbon_DefaultHadoopVersion_JarPath =
+ s"$rootPath/assembly/target/scala-2.11/carbondata_2.11-1.1" +
+ ".0-incubating-SNAPSHOT-shade-hadoop2.2.0.jar"
+
+val hiveJarPath =
s"$rootPath/integration/hive/target/carbondata-hive-1.1" +
+ ".0-incubating-SNAPSHOT.jar"
+
+carbon.sql("""drop table if exists hive_carbon_example""".stripMargin)
+
+carbon
+ .sql(
+"""create table hive_carbon_example (id int,name string,salary
double) stored by
--- End diff --
Please use uppercase for DDL and DML key words.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #773: [CARBONDATA-893] Fixed testcase in hadoop 2...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/773 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #751: [CARBONDATA-816] Added Example for Hive Int...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/751 @cenyuhai HiveExample can more to examples/ later once hive integration module be completely moved into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #772: [CARBONDATA-891] Fix compilation iss...
GitHub user chenliang613 opened a pull request: https://github.com/apache/incubator-carbondata/pull/772 [CARBONDATA-891] Fix compilation issue of LocalFileLockTest generate new folder "carbon.store" [CARBONDATA-891] Fix compilation issue of LocalFileLockTest generate new folder "carbon.store" You can merge this pull request into a Git repository by running: $ git pull https://github.com/chenliang613/incubator-carbondata fix_compileissue Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-carbondata/pull/772.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #772 commit fce12a8fb09209b7a4a2938dcf99835f0cef2ea1 Author: chenliang613 <chenliang...@huawei.com> Date: 2017-04-10T11:51:47Z [CARBONDATA-891] Fix compilation issue of LocalFileLockTest generate new folder carbon.store --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #770: [CARBONDATA-884] Assembly jar information i...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/770 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #751: [CARBONDATA-816] Added Example for H...
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/751#discussion_r110533556
--- Diff:
integration/hive/src/main/scala/org/apache/carbondata/hiveexample/HiveExample.scala
---
@@ -0,0 +1,166 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.carbondata.hiveexample
+
+import java.io.File
+import java.sql.{DriverManager, ResultSet, SQLException, Statement}
+
+import org.apache.spark.sql.SparkSession
+
+import org.apache.carbondata.common.logging.LogServiceFactory
+import org.apache.carbondata.hive.server.HiveEmbeddedServer2
+
+object HiveExample {
+
+ private val driverName: String = "org.apache.hive.jdbc.HiveDriver"
+
+ /**
+ * @param args
+ * @throws SQLException
+ */
+ @throws[SQLException]
+ def main(args: Array[String]) {
+val rootPath = new File(this.getClass.getResource("/").getPath
++ "../../../..").getCanonicalPath
+val store = s"$rootPath/integration/hive/target/store"
+val warehouse = s"$rootPath/integration/hive/target/warehouse"
+val metaStore_Db =
s"$rootPath/integration/hive/target/carbon_metaStore_db"
+val logger =
LogServiceFactory.getLogService(this.getClass.getCanonicalName)
+
+import org.apache.spark.sql.CarbonSession._
+
+System.setProperty("hadoop.home.dir", "/")
+
+val carbon = SparkSession
+ .builder()
+ .master("local")
+ .appName("HiveExample")
+ .config("carbon.sql.warehouse.dir", warehouse).enableHiveSupport()
+ .getOrCreateCarbonSession(
+store, metaStore_Db)
+
+val carbonJarPath =
s"$rootPath/assembly/target/scala-2.11/carbondata_2.11-1.1" +
+s".0-incubating-SNAPSHOT-shade-hadoop2.7.2.jar"
--- End diff --
For hadoop version of assembly jar , please don't give the fixed version
number(2.7.2), how about using 2.* ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #769: [CARBONDATA-888] Added include and exclude ...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/769 @sanoj-mg please let me know your JIRA account's emailid, i will give your contributor right, then you can assign issues to yourself. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #766: Refactor integration/presto by optim...
GitHub user chenliang613 opened a pull request: https://github.com/apache/incubator-carbondata/pull/766 Refactor integration/presto by optimizing some name definition Refactor integration/presto by optimizing some name definition. You can merge this pull request into a Git repository by running: $ git pull https://github.com/chenliang613/incubator-carbondata presto_comment Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-carbondata/pull/766.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #766 commit d3bbc70969343104b43739fd87095eb30983e1c9 Author: chenliang613 <chenliang...@huawei.com> Date: 2017-04-08T09:37:47Z refactor integration/presto --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #758: [CARBONDATA-885] Fixed inconsistent usage o...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/758 add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #756: [CARBONDATA-856] Alter Table - TABLE RENAME...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/756 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #756: [CARBONDATA-856] Alter Table - TABLE RENAME...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/756 add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #747: [CARBONDATA - 878] - Formatted Document
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/747 Please update the title, how about : [CARBONDATA - 878] Fixed Formatting Issues in document quick-start-guide.md --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #752: [CARBONDATA-879] Clear driver side dict cac...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/752 add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #738: [CARBONDATA-872] Fix comment issues of inte...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/738 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #738: [CARBONDATA-872] Fix comment issues of inte...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/738 @ffpeng90 can you remove this file (integration/presto/src/checkstyle/checks.xml) . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #744: [CARBONDATA -816] Added Example For HIve In...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/744 Please put all files under integration/hive for all hive related PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #744: [CARBONDATA -816] Added Example For ...
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/744#discussion_r110134827 --- Diff: format/src/main/thrift/sort_index.thrift --- @@ -1,28 +1,26 @@ -/** - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + *http://www.apache.org/licenses/LICENSE-2.0 * - * Unless required by applicable law or agreed to in writing, - * software distributed under the License is distributed on an - * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - * KIND, either express or implied. See the License for the - * specific language governing permissions and limitations - * under the License. + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. */ /** - * File format description for carbon sort index file + * File format description for CarbonData sort index file --- End diff -- Suggest creating a new PR based on apache/hive --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #746: changes in troubleshooting.md file
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/746 LGTM :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #744: [CARBONDATA -816] Added Example For ...
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/744#discussion_r110121865 --- Diff: format/src/main/thrift/sort_index.thrift --- @@ -1,28 +1,26 @@ -/** - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + *http://www.apache.org/licenses/LICENSE-2.0 * - * Unless required by applicable law or agreed to in writing, - * software distributed under the License is distributed on an - * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - * KIND, either express or implied. See the License for the - * specific language governing permissions and limitations - * under the License. + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. */ /** - * File format description for carbon sort index file + * File format description for CarbonData sort index file --- End diff -- why change thrift files? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #750: revert pom.xml for hive branch
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/750 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #738: [CARBONDATA-872] Fix comment issues ...
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/738#discussion_r110118287 --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataSplitManager.java --- @@ -106,6 +110,12 @@ public ConnectorSplitSource getSplits(ConnectorTransactionHandle transactionHand return constraintBuilder.build(); } + /** + * Convert presto-TupleDomain predication into Carbon scan express condition + * @param originalConstraint presto-TupleDomain + * @param carbonTable + * @return + */ --- End diff -- please change the comment format. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #738: [CARBONDATA-872] Fix comment issues ...
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/738#discussion_r110118360 --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataSplitManager.java --- @@ -249,6 +250,11 @@ public Expression parseFilterExpression(TupleDomain originalConstr return finalFilters; } + /** + * Convert presto spi Type into Carbondata Type + * @param colType + * @return + */ --- End diff -- please change the comment format --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #738: [CARBONDATA-872] Fix comment issues ...
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/738#discussion_r110116629 --- Diff: integration/presto/src/checkstyle/checks.xml --- @@ -0,0 +1,7 @@ + +http://www.puppycrawl.com/dtds/configuration_1_3.dtd;> --- End diff -- Please remove this file. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #738: [CARBONDATA-872] Fix comment issues ...
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/738#discussion_r110117100 --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataRecordCursor.java --- @@ -78,6 +78,10 @@ public CarbondataRecordCursor(CarbonReadSupport<Object[]> readSupport, return columnHandles.get(field).getColumnType(); } + /** + * get next Row/Page + * @return + */ --- End diff -- please change format the comment as below : /** * get next Row/Page * @return */ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #747: [CARBONDATA] - Formatted Document
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/747 Two comments: 1. The pr title is not correct. 2.Can you explain why need to reformat the document ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #748: changes in release-guide.md file
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/748 add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #749: [CARBONDATA-854] Datastax CFS file system s...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/749 add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #743: [CARBONDATA-866] remove kettle from configu...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/743 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #743: [CARBONDATA-866] remove kettle from configu...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/743 add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #734: [CARBONDATA-865] Remove configurations for ...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/734 LGTM, thanks for your contributing. Indeed, by default the data loading will not use kettle, so the cluster installation document can remove kettle part. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #731: [CARBONDATA-862] Removed Use Kettle From Do...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/731 add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #740: add hive integration for carbon
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/740 @cenyuhai please add [CARBONDATA-815] for the PR title. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #738: [CARBONDATA-872] Fix comment issues of inte...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/738 @ffpeng90 can you optimize other code also, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #734: [CARBONDATA-865] Remove configurations for ...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/734 add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #710: [CARBONDATA-833]load data from dataframe,ge...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/710 Can you provide more detail info for help me to reproduce the issue ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #728: [CARBONDATA-848] Fixed error Presto Connect...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/728 verified. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #729: [CARBONDATA-850] Fix the comment def...
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/729#discussion_r109636424
--- Diff: format/src/main/thrift/carbondata.thrift ---
@@ -1,223 +1,226 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
*
- * http://www.apache.org/licenses/LICENSE-2.0
+ *http://www.apache.org/licenses/LICENSE-2.0
*
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
*/
/**
- * File format description for the carbon file format
+ * File format description for the CarbonData file format
*/
namespace java org.apache.carbondata.format
include "schema.thrift"
include "dictionary.thrift"
/**
-* Information about a segment, that represents one data load
-*/
+ * Information about a segment, that represents one data load
+ */
struct SegmentInfo{
-1: required i32 num_cols; // Number of columns in this load, because
schema can evolve . TODO: Check whether this is really required
+1: required i32 num_cols; // Number of columns in this load, because
schema can evolve, different segments may have different columns
2: required list column_cardinalities; // Cardinality of columns
}
/**
-* Btree index of one blocklet
-*/
+ * Btree index of one blocklet
+ */
struct BlockletBTreeIndex{
1: required binary start_key; // Bit-packed start key of one blocklet
-2: required binary end_key;// Bit-packed start key of one blocklet
+2: required binary end_key;// Bit-packed end key of one blocklet
}
/**
-* Min-max index of one blocklet
-*/
+ * Min-max index of one blocklet
+ */
struct BlockletMinMaxIndex{
1: required list min_values; //Min value of all columns of one
blocklet Bit-Packed
2: required list max_values; //Max value of all columns of one
blocklet Bit-Packed
}
/**
-* Index of one blocklet
-**/
+ * Index of one blocklet
+ */
struct BlockletIndex{
1: optional BlockletMinMaxIndex min_max_index;
2: optional BlockletBTreeIndex b_tree_index;
}
/**
-* Sort state of one column
-*/
+ * Sort state of one column
+ */
enum SortState{
SORT_NONE = 0; // Data is not sorted
SORT_NATIVE = 1; //Source data was sorted
SORT_EXPLICIT = 2; // Sorted (ascending) when loading
}
/**
-* Compressions supported by Carbon Data.
-*/
+ * Compressions supported by CarbonData.
+ */
enum CompressionCodec{
SNAPPY = 0;
}
/**
-* Represents the data of one dimension one dimension group in one blocklet
-*/
-// add a innger level placeholder for further I/O granulatity
+ * Represents the data of one column page or one column page group in one
blocklet.
--- End diff --
agree
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #672: [CARBONDATA-815] add hive integration for c...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/672 @cenyuhai can you raise this PR to branch hive. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #729: [CARBONDATA-850] Fix the comment def...
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/729#discussion_r109628602
--- Diff: format/src/main/thrift/carbondata.thrift ---
@@ -1,223 +1,226 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
*
- * http://www.apache.org/licenses/LICENSE-2.0
+ *http://www.apache.org/licenses/LICENSE-2.0
*
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
*/
/**
- * File format description for the carbon file format
+ * File format description for the CarbonData file format
*/
namespace java org.apache.carbondata.format
include "schema.thrift"
include "dictionary.thrift"
/**
-* Information about a segment, that represents one data load
-*/
+ * Information about a segment, that represents one data load
+ */
struct SegmentInfo{
-1: required i32 num_cols; // Number of columns in this load, because
schema can evolve . TODO: Check whether this is really required
+1: required i32 num_cols; // Number of columns in this load, because
schema can evolve, different segments may have different columns
2: required list column_cardinalities; // Cardinality of columns
}
/**
-* Btree index of one blocklet
-*/
+ * Btree index of one blocklet
+ */
struct BlockletBTreeIndex{
1: required binary start_key; // Bit-packed start key of one blocklet
-2: required binary end_key;// Bit-packed start key of one blocklet
+2: required binary end_key;// Bit-packed end key of one blocklet
}
/**
-* Min-max index of one blocklet
-*/
+ * Min-max index of one blocklet
+ */
struct BlockletMinMaxIndex{
1: required list min_values; //Min value of all columns of one
blocklet Bit-Packed
2: required list max_values; //Max value of all columns of one
blocklet Bit-Packed
}
/**
-* Index of one blocklet
-**/
+ * Index of one blocklet
+ */
struct BlockletIndex{
1: optional BlockletMinMaxIndex min_max_index;
2: optional BlockletBTreeIndex b_tree_index;
}
/**
-* Sort state of one column
-*/
+ * Sort state of one column
+ */
enum SortState{
SORT_NONE = 0; // Data is not sorted
SORT_NATIVE = 1; //Source data was sorted
SORT_EXPLICIT = 2; // Sorted (ascending) when loading
}
/**
-* Compressions supported by Carbon Data.
-*/
+ * Compressions supported by CarbonData.
+ */
enum CompressionCodec{
SNAPPY = 0;
}
/**
-* Represents the data of one dimension one dimension group in one blocklet
-*/
-// add a innger level placeholder for further I/O granulatity
+ * Represents the data of one column page or one column page group in one
blocklet.
+ * Currently CarbonData using snappy for compression directly, user can
specify the different compression by ChunkCompressionMeta.
+ */
struct ChunkCompressionMeta{
-1: required CompressionCodec compression_codec; // the compressor used
-/** total byte size of all uncompressed pages in this column chunk
(including the headers) **/
+1: required CompressionCodec compression_codec; // The compressor
[GitHub] incubator-carbondata pull request #728: [CARBONDATA-848] Fixed error Presto ...
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/728#discussion_r109627894 --- Diff: pom.xml --- @@ -98,6 +98,7 @@ hadoop integration/spark-common integration/spark-common-test +integration/presto --- End diff -- Add integration/presto module to parent pom.xml can be consider later once all issues be fixed and all test cases of presto be added. So please remove it from your PR currently --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #721: Fix typo issues of integration/ pres...
GitHub user chenliang613 opened a pull request: https://github.com/apache/incubator-carbondata/pull/721 Fix typo issues of integration/ presto Fix typo issues of integration/ presto You can merge this pull request into a Git repository by running: $ git pull https://github.com/chenliang613/incubator-carbondata presto_typo_issues Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-carbondata/pull/721.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #721 commit e1a4a2fff8e19b70a08685ca304ce7a82184b376 Author: chenliang613 <chenliang...@huawei.com> Date: 2017-04-02T02:27:12Z fix typo issues of integration/ presto --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #714: Move integration/presto module to br...
GitHub user chenliang613 opened a pull request: https://github.com/apache/incubator-carbondata/pull/714 Move integration/presto module to branch "presto" You can merge this pull request into a Git repository by running: $ git pull https://github.com/chenliang613/incubator-carbondata mv_presto Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-carbondata/pull/714.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #714 commit 7ee8e2799ecb621a003bc53bc7998dcce2647095 Author: chenliang613 <chenliang...@huawei.com> Date: 2017-03-30T17:11:57Z move presto module to branch for dev --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #710: [CARBONDATA-833]load data from dataframe,ge...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/710 add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #712: [CARBONDATA-835] Fixed NullPointerException...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/712 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #705: [CARBONDATA-827] Fix query stats format err...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/705 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #707: [CARBONDATA-828] CarbonGlobalDictionaryRDD ...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/707 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #707: [CARBONDATA-828] CarbonGlobalDictionaryRDD ...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/707 add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #707: [CARBONDATA-828] CarbonGlobalDictionaryRDD ...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/707 @tianlileer please use english to describe the pr title. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #704: [CARBONDATA-826] Create carbondata-c...
GitHub user chenliang613 opened a pull request: https://github.com/apache/incubator-carbondata/pull/704 [CARBONDATA-826] Create carbondata-connector of presto Create carbondata-connector for query carbon data in presto 1.In CarbonData project, generate carbondata-connector of presto 2.Copy carbondata-connector to presto/plugin/ 3.Run query in presto to read carbon data. You can merge this pull request into a Git repository by running: $ git pull https://github.com/chenliang613/incubator-carbondata presto_query Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-carbondata/pull/704.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #704 commit 412d5dadb89d0575336de0f8c5907c8af130eba8 Author: chenliang613 <chenliang...@huawei.com> Date: 2017-03-27T11:10:20Z [CARBONDATA-826] Create carbondata-connector for query carbon data in presto --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #696: [CARBONDATA-818] Make the file_name in carb...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/696 @watermen You are right, the fileName actually is a path parameter. Agree to change fileName to carbonDataFileTempPath, please modify it in your PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #696: [CARBONDATA-818] Make the file_name in carb...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/696 @watermen Thanks for your contribution, everything looks good. Only one comment, in AbstractFactDataWriter.java, there are two parameters(fileName, carbonDataFileName) , what is the different ? /** * file name */ protected String fileName; /** * The name of carbonData file */ protected String carbonDataFileName; --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #696: [CARBONDATA-818] Make the file_name in carb...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/696 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #696: [CARBONDATA-818] Make the file_name ...
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/696#discussion_r108052532
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/writer/v3/CarbonFactDataWriterImplV3.java
---
@@ -528,8 +528,7 @@ protected void fillBlockIndexInfoDetails(long
numberOfRows, String filePath,
org.apache.carbondata.core.metadata.blocklet.index.BlockletIndex
blockletIndex =
new
org.apache.carbondata.core.metadata.blocklet.index.BlockletIndex(btree, minmax);
BlockIndexInfo blockIndexInfo =
-new BlockIndexInfo(numberOfRows, filePath.substring(0,
filePath.lastIndexOf('.')),
-currentPosition, blockletIndex);
+new BlockIndexInfo(numberOfRows, filePath, currentPosition,
blockletIndex);
--- End diff --
can you explain ,why do this change ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #696: [CARBONDATA-818] Make the file_name ...
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/696#discussion_r108052521 --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/writer/v1/CarbonFactDataWriterImplV1.java --- @@ -373,7 +373,7 @@ protected void writeBlockletInfoToFile(FileChannel channel, String filePath) FileFooter convertFileMeta = CarbonMetadataUtil .convertFileFooter(blockletInfoList, localCardinality.length, localCardinality, thriftColumnSchemaList, dataWriterVo.getSegmentProperties()); - fillBlockIndexInfoDetails(convertFileMeta.getNum_rows(), filePath, currentPosition); + fillBlockIndexInfoDetails(convertFileMeta.getNum_rows(), carbonDataFileName, currentPosition); --- End diff -- Please align the parameter name(filePath) for fillBlockIndexInfoDetails of AbstractFactDataWriter.java For example : protected void fillBlockIndexInfoDetails(long numberOfRows, String carbonDataFileName, long currentPosition) Please modify accordingly for all part. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #696: [CARBONDATA-818] Make the file_name ...
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/696#discussion_r108052363 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/dataload/TestDataLoadWithFileName.scala --- @@ -0,0 +1,111 @@ +package org.apache.carbondata.spark.testsuite.dataload --- End diff -- Please add license header --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #696: [CARBONDATA-818] Make the file_name in carb...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/696 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #672: [CARBONDATA-815] add hive integratio...
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/672#discussion_r107842840 --- Diff: dev/java-code-format-template.xml --- @@ -34,8 +34,8 @@ - + --- End diff -- ok --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #672: [CARBONDATA-727][WIP] add hive integration ...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/672 @cenyuhai please change title to : [CARBONDATA-815] add hive integration for carbon --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #672: [CARBONDATA-727][WIP] add hive integ...
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/672#discussion_r107839323 --- Diff: pom.xml --- @@ -381,6 +389,15 @@ + hive-1.2.1 --- End diff -- suggest changing to hive-1.2 for --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #687: [CARBONDATA-801] Examples syntax fix
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/687 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #687: [CARBONDATA-801] Examples syntax fix
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/687 add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #693: [CARBONDATA-813] Fix all issues to build su...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/693 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #692: [CARBONDATA-706] Fixing Spark 1.6 testcases...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/692 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #693: [CARBONDATA-813] Fix all issues to build su...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/693 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #693: [CARBONDATA-813] Fix all issues to build su...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/693 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #693: [CARBONDATA-813] Fix all issues to b...
GitHub user chenliang613 opened a pull request: https://github.com/apache/incubator-carbondata/pull/693 [CARBONDATA-813] Fix all issues to build success for integration/presto Fix pom issues and add the correct dependency jar to build success for integration/presto You can merge this pull request into a Git repository by running: $ git pull https://github.com/chenliang613/incubator-carbondata presto_run Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-carbondata/pull/693.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #693 commit c4c928e6d2baffab3531db9f929235e453cf1abb Author: chenliang613 <chenliang...@huawei.com> Date: 2017-03-23T17:21:23Z Fix pom issues and add the correct dependency jar to build success for integration/presto --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #686: Fix groupid,package name,Class name ...
GitHub user chenliang613 opened a pull request: https://github.com/apache/incubator-carbondata/pull/686 Fix groupid,package name,Class name issues of presto integration Fix groupid,package name,Class name issues of presto integration You can merge this pull request into a Git repository by running: $ git pull https://github.com/chenliang613/incubator-carbondata presto_name Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-carbondata/pull/686.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #686 commit 32bf2961a38d53c4674fc57b25ab48d99e0f4858 Author: chenliang613 <chenliang...@huawei.com> Date: 2017-03-23T08:02:30Z Fix groupid,package name,Class name issues --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #672: [CARBONDATA-727][WIP] add hive integ...
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/672#discussion_r107606797 --- Diff: dev/java-code-format-template.xml --- @@ -34,8 +34,8 @@ - + --- End diff -- Can you explain ,why change the order ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #650: [CARBONDATA-728] add intergation with prest...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/650 @ffpeng90 In presto/pom.xml, please change groupid from "com.facebook.presto" to "org.apache.carbondata" --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #650: [CARBONDATA-728] add intergation with prest...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/650 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #650: [CARBONDATA-728] add intergation with prest...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/650 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #606: [CARBONDATA-713] Make the store path in rig...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/606 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #672: [CARBONDATA-727][WIP] add hive integration ...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/672 @cenyuhai Thank you contributed this feature. Suggest creating a new profile for "integration/hive" module, and let all hive related code decoupled from current modules, let CI run normally first. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #650: [WIP] add intergation with presto
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/650 @ffpeng90 please update the PR title also. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #684: Update file structure info as per V3...
GitHub user chenliang613 opened a pull request: https://github.com/apache/incubator-carbondata/pull/684 Update file structure info as per V3 format definition The master has merged new V3 format for improving performance, this PR is for updating file structure info as per V3 format definition. You can merge this pull request into a Git repository by running: $ git pull https://github.com/chenliang613/incubator-carbondata V3_format_doc Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-carbondata/pull/684.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #684 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #679: [CARBONDATA-799] change word from currenr t...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/679 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #671: [CARBONDATA-793] Fixed count with null valu...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/671 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #667: [Carbondata 772] NumberFormatException disp...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/667 @rahulforallp please change tile to : [CARBONDATA-772] xxx --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #655: [CARBONDATA-762] Change schemaName to datab...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/655 @lionelcao please push a null commit to trigger the travis CI again, CI should be ok. verified in my machine ,it is ok. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #650: [WIP] add intergation with presto
Github user chenliang613 commented on a diff in the pull request: https://github.com/apache/incubator-carbondata/pull/650#discussion_r105558847 --- Diff: integration/presto/pom.xml --- @@ -0,0 +1,167 @@ + +http://maven.apache.org/POM/4.0.0; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> +4.0.0 + + +com.facebook.presto --- End diff -- please change groupId to org.apache.carbondata. you can take integration/spark module as reference, and update accordingly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #650: [WIP] add intergation with presto
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/650 add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #649: [CARBONDATA-748] put 'if' clause out of the...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/649 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata pull request #649: [CARBONDATA-748] put 'if' clause out...
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/649#discussion_r105549626
--- Diff:
core/src/test/java/org/apache/carbondata/core/scan/filter/executer/IncludeFilterExecuterImplTest.java
---
@@ -96,13 +93,39 @@ private BitSet
setFilterdIndexToBitSet(DimensionColumnDataChunk dimensionColumnD
@Test
public void testPerformance() {
-long oldTime = 0;
-long newTime = 0;
-long start;
int dataCnt = 12;
+int queryCnt = 5;
+int repeatCnt = 200;
+
int filterCnt = 800;
+comparePerformance(dataCnt, filterCnt, queryCnt, repeatCnt);
+
+filterCnt = 100;
+comparePerformance(dataCnt, filterCnt, queryCnt, repeatCnt);
+
+ }
+
+ @Test
+ public void testBoundary() {
--- End diff --
Can you explain why add testBoundary() ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #649: [CARBONDATA-748] put 'if' clause out...
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/649#discussion_r105548337
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/IncludeFilterExecuterImpl.java
---
@@ -138,23 +138,23 @@ private BitSet
setFilterdIndexToBitSet(DimensionColumnDataChunk dimensionColumnD
BitSet bitSet = new BitSet(numerOfRows);
if (dimensionColumnDataChunk instanceof FixedLengthDimensionDataChunk)
{
byte[][] filterValues = dimColumnExecuterInfo.getFilterKeys();
- for (int i = 0; i < numerOfRows; i++) {
+ if (filterValues.length > 1) {
--- End diff --
Please remove the blank row
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #649: [CARBONDATA-748] put 'if' clause out...
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/649#discussion_r105548338
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/IncludeFilterExecuterImpl.java
---
@@ -138,23 +138,23 @@ private BitSet
setFilterdIndexToBitSet(DimensionColumnDataChunk dimensionColumnD
BitSet bitSet = new BitSet(numerOfRows);
if (dimensionColumnDataChunk instanceof FixedLengthDimensionDataChunk)
{
byte[][] filterValues = dimColumnExecuterInfo.getFilterKeys();
- for (int i = 0; i < numerOfRows; i++) {
+ if (filterValues.length > 1) {
-if (filterValues.length > 1) {
+for (int i = 0; i < numerOfRows; i++) {
int index = CarbonUtil.binarySearch(filterValues, 0,
filterValues.length - 1,
dimensionColumnDataChunk.getChunkData(i));
if (index >= 0) {
bitSet.set(i);
}
-} else if (filterValues.length == 1) {
+}
+ } else if (filterValues.length == 1) {
+
--- End diff --
Please remove the blank row
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #649: [CARBONDATA-748] put 'if' clause out...
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/649#discussion_r105548334
--- Diff:
core/src/test/java/org/apache/carbondata/core/scan/filter/executer/IncludeFilterExecuterImplTest.java
---
@@ -41,21 +41,20 @@ private BitSet
setFilterdIndexToBitSetNew(DimensionColumnDataChunk dimensionColu
BitSet bitSet = new BitSet(numerOfRows);
if (dimensionColumnDataChunk instanceof FixedLengthDimensionDataChunk)
{
// byte[][] filterValues = dimColumnExecuterInfo.getFilterKeys();
- for (int i = 0; i < numerOfRows; i++) {
-
-if (filterValues.length > 1) {
+ if (filterValues.length > 1) {
+for (int i = 0; i < numerOfRows; i++) {
int index = CarbonUtil.binarySearch(filterValues, 0,
filterValues.length - 1,
--- End diff --
Please remove the blank row
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #620: [CARBONDATA-742]Added batch sort to improve...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/620 please change the title as per the format: [CARBONDATA-issue number>] Title of the pull request (need to add a blank) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #640: [CARBONDATA-755]Confusing comment about def...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/640 please close this PR, because you have raised another PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #427: [CARBONDATA-429]reduce the no of of io oper...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/427 please change the title as per the format: [CARBONDATA-issue number>] Title of the pull request (need to add a blank) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #429: [CARBONDATA-530]Modified optimizer to place...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/429 please change the title as per the format: [CARBONDATA-issue number>] Title of the pull request (need to add a blank) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-carbondata issue #630: [CARBONDATA-730]added decimal type in carbo...
Github user chenliang613 commented on the issue: https://github.com/apache/incubator-carbondata/pull/630 please change the title as per the format: [CARBONDATA-issue number>] Title of the pull request (need to add a blank) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
