[jira] [Commented] (CLOUDSTACK-9730) [VMware] Unable to add a host with space in its name to existing VMware cluster

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314368#comment-16314368
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9730:


blueorangutan commented on issue #1891: CLOUDSTACK-9730: [VMware] Unable to add 
a host with space in its name to existing VMware cluster
URL: https://github.com/apache/cloudstack/pull/1891#issuecomment-355722808
 
 
   Trillian test result (tid-2036)
   Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 43902 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1891-t2036-vmware-55u3.zip
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 66 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_08_migrate_vm | `Error` | 60.99 | test_vm_life_cycle.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [VMware] Unable to add a host with space in its name to existing VMware 
> cluster
> ---
>
> Key: CLOUDSTACK-9730
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9730
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: VMware
>Reporter: Suresh Kumar Anaparti
>Assignee: Suresh Kumar Anaparti
> Fix For: 4.10.1.0
>
>
> ISSUE
> ==
> Unable to add a host with space in the name to existing VMware cluster.
> While adding host, CloudStack tries to persist the validated inventory url 
> path in database, which inserts encoded url into database which means 
> whitespace would be stored as '+' symbols. Url from API parameter string is 
> being converted to URI object as part of validation, where the url path is 
> getting encoded.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9620) Improvements for Managed Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314275#comment-16314275
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9620:


mike-tutkowski commented on a change in pull request #2298: CLOUDSTACK-9620: 
Enhancements for managed storage
URL: https://github.com/apache/cloudstack/pull/2298#discussion_r160013238
 
 

 ##
 File path: server/src/com/cloud/configuration/Config.java
 ##
 @@ -191,6 +191,22 @@
 "10800",
 "In second, timeout for download template to primary storage",
 null),
+KvmStorageOfflineMigrationWait(
 
 Review comment:
   @DaanHoogland I changed the KvmStorageOfflineMigrationWait and 
KvmStorageOnlineMigrationWait keys from using the Config approach to using the 
ConfigKey approach.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Improvements for Managed Storage
> 
>
> Key: CLOUDSTACK-9620
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9620
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Management Server, VMware, XenServer
>Affects Versions: 4.11.0.0
> Environment: KVM, vSphere, and XenServer
>Reporter: Mike Tutkowski
>Assignee: Mike Tutkowski
> Fix For: 4.11.0.0
>
>
> Allowed zone-wide primary storage based on a custom plug-in to be added via 
> the GUI in a KVM-only environment (previously this only worked for XenServer 
> and VMware)
> Added support for root disks on managed storage with KVM
> Added support for volume snapshots with managed storage on KVM
> Enabled creating a template directly from a volume (i.e. without having to go 
> through a volume snapshot) on KVM with managed storage
> Only allowed the resizing of a volume for managed storage on KVM if the 
> volume in question is either not attached to a VM or is attached to a VM in 
> the Stopped state
> Included support for Reinstall VM on KVM with managed storage
> Enabled offline migration on KVM from non-managed storage to managed storage 
> and vice versa
> Included support for online storage migration on KVM with managed storage 
> (NFS and Ceph to managed storage)
> Added support to download (extract) a managed-storage volume to a QCOW2 file
> When uploading a file from outside of CloudStack to CloudStack, set the min 
> and max IOPS, if applicable.
> Included support for the KVM auto-convergence feature
> The compression flag was actually added in version 1.0.3 (103) as opposed 
> to version 1.3.0 (1003000) (changed this to reflect the correct version)
> On KVM when using iSCSI-based managed storage, if the user shuts a VM down 
> from the guest OS (as opposed to doing so from CloudStack), we need to pass 
> to the KVM agent a list of applicable iSCSI volumes that need to be 
> disconnected.
> Added a new Global Setting: kvm.storage.live.migration.wait
> For XenServer, added a check to enforce that only volumes from zone-wide 
> managed storage can be storage motioned from a host in one cluster to a host 
> in another cluster (cannot do so at the time being with volumes from 
> cluster-scoped managed storage)
> Don’t allow Storage XenMotion on a VM that has any managed-storage volume 
> with one or more snapshots.
> Enabled for managed storage with VMware: Template caching, create snapshot, 
> delete snapshot, create volume from snapshot, and create template from 
> snapshot
> Added an SIOC API plug-in to support VMware SIOC
> When starting a VM that uses managed storage in a cluster other than the one 
> it last was running in, we need to remove the reference to the iSCSI volume 
> from the original cluster.
> Added the ability to revert a volume to a snapshot
> Enabled cluster-scoped managed storage
> Added support for VMware dynamic discovery



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9025) Unable to deploy VM instance from template if template spin from linked clone snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314240#comment-16314240
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9025:


mike-tutkowski commented on issue #2315: A comprehensive solution for 
CLOUDSTACK-9025 and CLOUDSTACK-10128.
URL: https://github.com/apache/cloudstack/pull/2315#issuecomment-355708764
 
 
   I've read through the code and the existing comments about it. I don't think 
I have anything to add above and beyond what's already been discussed here.
   
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Unable to deploy VM instance from template if template spin from linked clone 
> snapshot
> --
>
> Key: CLOUDSTACK-9025
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9025
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: XenServer
>Affects Versions: 4.5.2
> Environment: XenServer 6.5
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
>Priority: Critical
> Fix For: 4.6.0
>
>
> As default, CloudStack create linked clone snapshot for VM instance . When we 
> take a snapshot for the VM, and create a template based on such snapshot, 
> CloudStack only download incremental VHD as template file, as a result, the 
> VM instance fail to deploy as it is incomplete.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9025) Unable to deploy VM instance from template if template spin from linked clone snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314229#comment-16314229
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9025:


blueorangutan commented on issue #2315: A comprehensive solution for 
CLOUDSTACK-9025 and CLOUDSTACK-10128.
URL: https://github.com/apache/cloudstack/pull/2315#issuecomment-355706584
 
 
   Trillian test result (tid-2034)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 30567 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2315-t2034-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
   Smoke tests completed. 67 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Unable to deploy VM instance from template if template spin from linked clone 
> snapshot
> --
>
> Key: CLOUDSTACK-9025
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9025
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: XenServer
>Affects Versions: 4.5.2
> Environment: XenServer 6.5
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
>Priority: Critical
> Fix For: 4.6.0
>
>
> As default, CloudStack create linked clone snapshot for VM instance . When we 
> take a snapshot for the VM, and create a template based on such snapshot, 
> CloudStack only download incremental VHD as template file, as a result, the 
> VM instance fail to deploy as it is incomplete.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10109) Enable dedication of public IPs to SSVM and CPVM

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314227#comment-16314227
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10109:
-

blueorangutan commented on issue #2295: CLOUDSTACK-10109: Enable dedication of 
public IPs to SSVM and CPVM
URL: https://github.com/apache/cloudstack/pull/2295#issuecomment-355706246
 
 
   Trillian test result (tid-2035)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 30115 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2295-t2035-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 66 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_redundant_vpc_site2site_vpn | `Failure` | 228.90 | test_vpc_vpn.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Enable dedication of public IPs to SSVM and CPVM
> 
>
> Key: CLOUDSTACK-10109
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10109
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
> Attachments: public01.png, public02.png, public03.png
>
>
> It is required to dedicate a public IP range for SSVM and CPVM in order to 
> apply firewall rules to control inbound access.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9620) Improvements for Managed Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314205#comment-16314205
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9620:


mike-tutkowski commented on issue #2298: CLOUDSTACK-9620: Enhancements for 
managed storage
URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-355701751
 
 
   @rafaelweingartner Oh, it's no problem. There is so much code here to 
implement all of these new features and it all has to work alongside the old 
code, so sometimes it's easier to change as little as possible from the old 
code to "assure" yourself you haven't broken any of it along the way. Of 
course, as you do this, the new code placed on top of the old code ends up 
adding complexity. At some point, it's best to "suck it up," sit down, and 
rewrite a bunch of it to support the entire feature set, but be less 
complicated. To do this, though, it's nice to have a large set of automated 
tests to catch anything you might have broken in the code during the rewrite. I 
do have a lot of new tests to catch issues in the new code, but I've never been 
super confident in CloudStack's automated tests related to its legacy features.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Improvements for Managed Storage
> 
>
> Key: CLOUDSTACK-9620
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9620
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Management Server, VMware, XenServer
>Affects Versions: 4.11.0.0
> Environment: KVM, vSphere, and XenServer
>Reporter: Mike Tutkowski
>Assignee: Mike Tutkowski
> Fix For: 4.11.0.0
>
>
> Allowed zone-wide primary storage based on a custom plug-in to be added via 
> the GUI in a KVM-only environment (previously this only worked for XenServer 
> and VMware)
> Added support for root disks on managed storage with KVM
> Added support for volume snapshots with managed storage on KVM
> Enabled creating a template directly from a volume (i.e. without having to go 
> through a volume snapshot) on KVM with managed storage
> Only allowed the resizing of a volume for managed storage on KVM if the 
> volume in question is either not attached to a VM or is attached to a VM in 
> the Stopped state
> Included support for Reinstall VM on KVM with managed storage
> Enabled offline migration on KVM from non-managed storage to managed storage 
> and vice versa
> Included support for online storage migration on KVM with managed storage 
> (NFS and Ceph to managed storage)
> Added support to download (extract) a managed-storage volume to a QCOW2 file
> When uploading a file from outside of CloudStack to CloudStack, set the min 
> and max IOPS, if applicable.
> Included support for the KVM auto-convergence feature
> The compression flag was actually added in version 1.0.3 (103) as opposed 
> to version 1.3.0 (1003000) (changed this to reflect the correct version)
> On KVM when using iSCSI-based managed storage, if the user shuts a VM down 
> from the guest OS (as opposed to doing so from CloudStack), we need to pass 
> to the KVM agent a list of applicable iSCSI volumes that need to be 
> disconnected.
> Added a new Global Setting: kvm.storage.live.migration.wait
> For XenServer, added a check to enforce that only volumes from zone-wide 
> managed storage can be storage motioned from a host in one cluster to a host 
> in another cluster (cannot do so at the time being with volumes from 
> cluster-scoped managed storage)
> Don’t allow Storage XenMotion on a VM that has any managed-storage volume 
> with one or more snapshots.
> Enabled for managed storage with VMware: Template caching, create snapshot, 
> delete snapshot, create volume from snapshot, and create template from 
> snapshot
> Added an SIOC API plug-in to support VMware SIOC
> When starting a VM that uses managed storage in a cluster other than the one 
> it last was running in, we need to remove the reference to the iSCSI volume 
> from the original cluster.
> Added the ability to revert a volume to a snapshot
> Enabled cluster-scoped managed storage
> Added support for VMware dynamic discovery



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9620) Improvements for Managed Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314195#comment-16314195
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9620:


rafaelweingartner commented on issue #2298: CLOUDSTACK-9620: Enhancements for 
managed storage
URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-355700267
 
 
   @mike-tutkowski thanks for your hard work!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Improvements for Managed Storage
> 
>
> Key: CLOUDSTACK-9620
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9620
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Management Server, VMware, XenServer
>Affects Versions: 4.11.0.0
> Environment: KVM, vSphere, and XenServer
>Reporter: Mike Tutkowski
>Assignee: Mike Tutkowski
> Fix For: 4.11.0.0
>
>
> Allowed zone-wide primary storage based on a custom plug-in to be added via 
> the GUI in a KVM-only environment (previously this only worked for XenServer 
> and VMware)
> Added support for root disks on managed storage with KVM
> Added support for volume snapshots with managed storage on KVM
> Enabled creating a template directly from a volume (i.e. without having to go 
> through a volume snapshot) on KVM with managed storage
> Only allowed the resizing of a volume for managed storage on KVM if the 
> volume in question is either not attached to a VM or is attached to a VM in 
> the Stopped state
> Included support for Reinstall VM on KVM with managed storage
> Enabled offline migration on KVM from non-managed storage to managed storage 
> and vice versa
> Included support for online storage migration on KVM with managed storage 
> (NFS and Ceph to managed storage)
> Added support to download (extract) a managed-storage volume to a QCOW2 file
> When uploading a file from outside of CloudStack to CloudStack, set the min 
> and max IOPS, if applicable.
> Included support for the KVM auto-convergence feature
> The compression flag was actually added in version 1.0.3 (103) as opposed 
> to version 1.3.0 (1003000) (changed this to reflect the correct version)
> On KVM when using iSCSI-based managed storage, if the user shuts a VM down 
> from the guest OS (as opposed to doing so from CloudStack), we need to pass 
> to the KVM agent a list of applicable iSCSI volumes that need to be 
> disconnected.
> Added a new Global Setting: kvm.storage.live.migration.wait
> For XenServer, added a check to enforce that only volumes from zone-wide 
> managed storage can be storage motioned from a host in one cluster to a host 
> in another cluster (cannot do so at the time being with volumes from 
> cluster-scoped managed storage)
> Don’t allow Storage XenMotion on a VM that has any managed-storage volume 
> with one or more snapshots.
> Enabled for managed storage with VMware: Template caching, create snapshot, 
> delete snapshot, create volume from snapshot, and create template from 
> snapshot
> Added an SIOC API plug-in to support VMware SIOC
> When starting a VM that uses managed storage in a cluster other than the one 
> it last was running in, we need to remove the reference to the iSCSI volume 
> from the original cluster.
> Added the ability to revert a volume to a snapshot
> Enabled cluster-scoped managed storage
> Added support for VMware dynamic discovery



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9620) Improvements for Managed Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314187#comment-16314187
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9620:


mike-tutkowski commented on issue #2298: CLOUDSTACK-9620: Enhancements for 
managed storage
URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-355699685
 
 
   Sure, @rafaelweingartner. If you feel that's easier to read, I can write it 
that way. I'll send a new commit up soon. Thanks for your time!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Improvements for Managed Storage
> 
>
> Key: CLOUDSTACK-9620
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9620
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Management Server, VMware, XenServer
>Affects Versions: 4.11.0.0
> Environment: KVM, vSphere, and XenServer
>Reporter: Mike Tutkowski
>Assignee: Mike Tutkowski
> Fix For: 4.11.0.0
>
>
> Allowed zone-wide primary storage based on a custom plug-in to be added via 
> the GUI in a KVM-only environment (previously this only worked for XenServer 
> and VMware)
> Added support for root disks on managed storage with KVM
> Added support for volume snapshots with managed storage on KVM
> Enabled creating a template directly from a volume (i.e. without having to go 
> through a volume snapshot) on KVM with managed storage
> Only allowed the resizing of a volume for managed storage on KVM if the 
> volume in question is either not attached to a VM or is attached to a VM in 
> the Stopped state
> Included support for Reinstall VM on KVM with managed storage
> Enabled offline migration on KVM from non-managed storage to managed storage 
> and vice versa
> Included support for online storage migration on KVM with managed storage 
> (NFS and Ceph to managed storage)
> Added support to download (extract) a managed-storage volume to a QCOW2 file
> When uploading a file from outside of CloudStack to CloudStack, set the min 
> and max IOPS, if applicable.
> Included support for the KVM auto-convergence feature
> The compression flag was actually added in version 1.0.3 (103) as opposed 
> to version 1.3.0 (1003000) (changed this to reflect the correct version)
> On KVM when using iSCSI-based managed storage, if the user shuts a VM down 
> from the guest OS (as opposed to doing so from CloudStack), we need to pass 
> to the KVM agent a list of applicable iSCSI volumes that need to be 
> disconnected.
> Added a new Global Setting: kvm.storage.live.migration.wait
> For XenServer, added a check to enforce that only volumes from zone-wide 
> managed storage can be storage motioned from a host in one cluster to a host 
> in another cluster (cannot do so at the time being with volumes from 
> cluster-scoped managed storage)
> Don’t allow Storage XenMotion on a VM that has any managed-storage volume 
> with one or more snapshots.
> Enabled for managed storage with VMware: Template caching, create snapshot, 
> delete snapshot, create volume from snapshot, and create template from 
> snapshot
> Added an SIOC API plug-in to support VMware SIOC
> When starting a VM that uses managed storage in a cluster other than the one 
> it last was running in, we need to remove the reference to the iSCSI volume 
> from the original cluster.
> Added the ability to revert a volume to a snapshot
> Enabled cluster-scoped managed storage
> Added support for VMware dynamic discovery



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9620) Improvements for Managed Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314183#comment-16314183
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9620:


mike-tutkowski commented on issue #2298: CLOUDSTACK-9620: Enhancements for 
managed storage
URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-355698729
 
 
   Sure, @rafaelweingartner. If you feel that's easier to read, I can write it 
that way. I'll send a new commit up soon. Thanks for your time!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Improvements for Managed Storage
> 
>
> Key: CLOUDSTACK-9620
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9620
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Management Server, VMware, XenServer
>Affects Versions: 4.11.0.0
> Environment: KVM, vSphere, and XenServer
>Reporter: Mike Tutkowski
>Assignee: Mike Tutkowski
> Fix For: 4.11.0.0
>
>
> Allowed zone-wide primary storage based on a custom plug-in to be added via 
> the GUI in a KVM-only environment (previously this only worked for XenServer 
> and VMware)
> Added support for root disks on managed storage with KVM
> Added support for volume snapshots with managed storage on KVM
> Enabled creating a template directly from a volume (i.e. without having to go 
> through a volume snapshot) on KVM with managed storage
> Only allowed the resizing of a volume for managed storage on KVM if the 
> volume in question is either not attached to a VM or is attached to a VM in 
> the Stopped state
> Included support for Reinstall VM on KVM with managed storage
> Enabled offline migration on KVM from non-managed storage to managed storage 
> and vice versa
> Included support for online storage migration on KVM with managed storage 
> (NFS and Ceph to managed storage)
> Added support to download (extract) a managed-storage volume to a QCOW2 file
> When uploading a file from outside of CloudStack to CloudStack, set the min 
> and max IOPS, if applicable.
> Included support for the KVM auto-convergence feature
> The compression flag was actually added in version 1.0.3 (103) as opposed 
> to version 1.3.0 (1003000) (changed this to reflect the correct version)
> On KVM when using iSCSI-based managed storage, if the user shuts a VM down 
> from the guest OS (as opposed to doing so from CloudStack), we need to pass 
> to the KVM agent a list of applicable iSCSI volumes that need to be 
> disconnected.
> Added a new Global Setting: kvm.storage.live.migration.wait
> For XenServer, added a check to enforce that only volumes from zone-wide 
> managed storage can be storage motioned from a host in one cluster to a host 
> in another cluster (cannot do so at the time being with volumes from 
> cluster-scoped managed storage)
> Don’t allow Storage XenMotion on a VM that has any managed-storage volume 
> with one or more snapshots.
> Enabled for managed storage with VMware: Template caching, create snapshot, 
> delete snapshot, create volume from snapshot, and create template from 
> snapshot
> Added an SIOC API plug-in to support VMware SIOC
> When starting a VM that uses managed storage in a cluster other than the one 
> it last was running in, we need to remove the reference to the iSCSI volume 
> from the original cluster.
> Added the ability to revert a volume to a snapshot
> Enabled cluster-scoped managed storage
> Added support for VMware dynamic discovery



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9620) Improvements for Managed Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314175#comment-16314175
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9620:


mike-tutkowski commented on issue #2298: CLOUDSTACK-9620: Enhancements for 
managed storage
URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-355698729
 
 
   Sure, @rafaelweingartner. If you feel that's easier to read, I can write it 
that way. I'll send a new commit up soon. Thanks for your time!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Improvements for Managed Storage
> 
>
> Key: CLOUDSTACK-9620
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9620
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Management Server, VMware, XenServer
>Affects Versions: 4.11.0.0
> Environment: KVM, vSphere, and XenServer
>Reporter: Mike Tutkowski
>Assignee: Mike Tutkowski
> Fix For: 4.11.0.0
>
>
> Allowed zone-wide primary storage based on a custom plug-in to be added via 
> the GUI in a KVM-only environment (previously this only worked for XenServer 
> and VMware)
> Added support for root disks on managed storage with KVM
> Added support for volume snapshots with managed storage on KVM
> Enabled creating a template directly from a volume (i.e. without having to go 
> through a volume snapshot) on KVM with managed storage
> Only allowed the resizing of a volume for managed storage on KVM if the 
> volume in question is either not attached to a VM or is attached to a VM in 
> the Stopped state
> Included support for Reinstall VM on KVM with managed storage
> Enabled offline migration on KVM from non-managed storage to managed storage 
> and vice versa
> Included support for online storage migration on KVM with managed storage 
> (NFS and Ceph to managed storage)
> Added support to download (extract) a managed-storage volume to a QCOW2 file
> When uploading a file from outside of CloudStack to CloudStack, set the min 
> and max IOPS, if applicable.
> Included support for the KVM auto-convergence feature
> The compression flag was actually added in version 1.0.3 (103) as opposed 
> to version 1.3.0 (1003000) (changed this to reflect the correct version)
> On KVM when using iSCSI-based managed storage, if the user shuts a VM down 
> from the guest OS (as opposed to doing so from CloudStack), we need to pass 
> to the KVM agent a list of applicable iSCSI volumes that need to be 
> disconnected.
> Added a new Global Setting: kvm.storage.live.migration.wait
> For XenServer, added a check to enforce that only volumes from zone-wide 
> managed storage can be storage motioned from a host in one cluster to a host 
> in another cluster (cannot do so at the time being with volumes from 
> cluster-scoped managed storage)
> Don’t allow Storage XenMotion on a VM that has any managed-storage volume 
> with one or more snapshots.
> Enabled for managed storage with VMware: Template caching, create snapshot, 
> delete snapshot, create volume from snapshot, and create template from 
> snapshot
> Added an SIOC API plug-in to support VMware SIOC
> When starting a VM that uses managed storage in a cluster other than the one 
> it last was running in, we need to remove the reference to the iSCSI volume 
> from the original cluster.
> Added the ability to revert a volume to a snapshot
> Enabled cluster-scoped managed storage
> Added support for VMware dynamic discovery



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9620) Improvements for Managed Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314077#comment-16314077
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9620:


rafaelweingartner commented on issue #2298: CLOUDSTACK-9620: Enhancements for 
managed storage
URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-355687919
 
 
   I understood that. It is good the way you did as well. What I meant 
previously was the following.
   You have this block of code:
   ```
 if (canHandleSrc) {
   if (srcSnapshotInfo.getDataStore().getId() == 
destVolumeInfo.getDataStore().getId()) {
   
handleCreateVolumeFromSnapshotBothOnStorageSystem(srcSnapshotInfo, 
destVolumeInfo, callback);
   } else {
   String errMsg = "To perform this operation, the source and 
destination primary storages must be the same.";
   
   handleError(errMsg, callback);
   }
   } else {
   handleCreateVolumeFromSnapshotOnSecondaryStorage(srcSnapshotInfo, 
destVolumeInfo, callback);
   }
   ```
   
   This previous block is the same as:
   ```
 if (!canHandleSrc) {
   handleCreateVolumeFromSnapshotOnSecondaryStorage(srcSnapshotInfo, 
destVolumeInfo, callback);
   }
   
if (srcSnapshotInfo.getDataStore().getId() == 
destVolumeInfo.getDataStore().getId()) {
   
handleCreateVolumeFromSnapshotBothOnStorageSystem(srcSnapshotInfo, 
destVolumeInfo, callback);
   } else {
   String errMsg = "To perform this operation, the source and 
destination primary storages must be the same.";
   
   handleError(errMsg, callback);
   }
   ```
   
   Sorry the bad indentation here. So, the idea was to remove one IF inside the 
other. At least for me, the least nested conditions and operations, the better 
to read the code.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Improvements for Managed Storage
> 
>
> Key: CLOUDSTACK-9620
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9620
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Management Server, VMware, XenServer
>Affects Versions: 4.11.0.0
> Environment: KVM, vSphere, and XenServer
>Reporter: Mike Tutkowski
>Assignee: Mike Tutkowski
> Fix For: 4.11.0.0
>
>
> Allowed zone-wide primary storage based on a custom plug-in to be added via 
> the GUI in a KVM-only environment (previously this only worked for XenServer 
> and VMware)
> Added support for root disks on managed storage with KVM
> Added support for volume snapshots with managed storage on KVM
> Enabled creating a template directly from a volume (i.e. without having to go 
> through a volume snapshot) on KVM with managed storage
> Only allowed the resizing of a volume for managed storage on KVM if the 
> volume in question is either not attached to a VM or is attached to a VM in 
> the Stopped state
> Included support for Reinstall VM on KVM with managed storage
> Enabled offline migration on KVM from non-managed storage to managed storage 
> and vice versa
> Included support for online storage migration on KVM with managed storage 
> (NFS and Ceph to managed storage)
> Added support to download (extract) a managed-storage volume to a QCOW2 file
> When uploading a file from outside of CloudStack to CloudStack, set the min 
> and max IOPS, if applicable.
> Included support for the KVM auto-convergence feature
> The compression flag was actually added in version 1.0.3 (103) as opposed 
> to version 1.3.0 (1003000) (changed this to reflect the correct version)
> On KVM when using iSCSI-based managed storage, if the user shuts a VM down 
> from the guest OS (as opposed to doing so from CloudStack), we need to pass 
> to the KVM agent a list of applicable iSCSI volumes that need to be 
> disconnected.
> Added a new Global Setting: kvm.storage.live.migration.wait
> For XenServer, added a check to enforce that only volumes from zone-wide 
> managed storage can be storage motioned from a host in one cluster to a host 
> in another cluster (cannot do so at the time being with volumes from 
> cluster-scoped managed storage)
> Don’t allow Storage XenMotion on a VM that has any managed-storage volume 
> with one or more snapshots.
> Enabled for managed storage with VMware: Template caching, create snapshot, 
> delete snapshot, create volume from snapshot, and create template from 
> snapshot
> Added an 

[jira] [Commented] (CLOUDSTACK-9620) Improvements for Managed Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314055#comment-16314055
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9620:


mike-tutkowski commented on issue #2298: CLOUDSTACK-9620: Enhancements for 
managed storage
URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-355686048
 
 
   As an example:
   
   boolean canHandleSrc = canHandle(srcSnapshotInfo);
   
   if (canHandleSrc) {
   if (srcSnapshotInfo.getDataStore().getId() == 
destVolumeInfo.getDataStore().getId()) {
   
handleCreateVolumeFromSnapshotBothOnStorageSystem(srcSnapshotInfo, 
destVolumeInfo, callback);
   } else {
   String errMsg = "To perform this operation, the source and 
destination primary storages must be the same.";
   
   handleError(errMsg, callback);
   }
   
   In this case, canHandle returns true because srcSnapshotInfo's storage 
driver does support certain features for snapshots. However, the canHandle 
method doesn't know if the destination volume (that we want to copy our 
snapshot to) is in the same primary storage or not. As it turns out, right now 
we only support this operation if the two objects (the snapshot and volume) are 
in the same storage pool. It might come down to the naming of canHandle is a 
bit vague.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Improvements for Managed Storage
> 
>
> Key: CLOUDSTACK-9620
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9620
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Management Server, VMware, XenServer
>Affects Versions: 4.11.0.0
> Environment: KVM, vSphere, and XenServer
>Reporter: Mike Tutkowski
>Assignee: Mike Tutkowski
> Fix For: 4.11.0.0
>
>
> Allowed zone-wide primary storage based on a custom plug-in to be added via 
> the GUI in a KVM-only environment (previously this only worked for XenServer 
> and VMware)
> Added support for root disks on managed storage with KVM
> Added support for volume snapshots with managed storage on KVM
> Enabled creating a template directly from a volume (i.e. without having to go 
> through a volume snapshot) on KVM with managed storage
> Only allowed the resizing of a volume for managed storage on KVM if the 
> volume in question is either not attached to a VM or is attached to a VM in 
> the Stopped state
> Included support for Reinstall VM on KVM with managed storage
> Enabled offline migration on KVM from non-managed storage to managed storage 
> and vice versa
> Included support for online storage migration on KVM with managed storage 
> (NFS and Ceph to managed storage)
> Added support to download (extract) a managed-storage volume to a QCOW2 file
> When uploading a file from outside of CloudStack to CloudStack, set the min 
> and max IOPS, if applicable.
> Included support for the KVM auto-convergence feature
> The compression flag was actually added in version 1.0.3 (103) as opposed 
> to version 1.3.0 (1003000) (changed this to reflect the correct version)
> On KVM when using iSCSI-based managed storage, if the user shuts a VM down 
> from the guest OS (as opposed to doing so from CloudStack), we need to pass 
> to the KVM agent a list of applicable iSCSI volumes that need to be 
> disconnected.
> Added a new Global Setting: kvm.storage.live.migration.wait
> For XenServer, added a check to enforce that only volumes from zone-wide 
> managed storage can be storage motioned from a host in one cluster to a host 
> in another cluster (cannot do so at the time being with volumes from 
> cluster-scoped managed storage)
> Don’t allow Storage XenMotion on a VM that has any managed-storage volume 
> with one or more snapshots.
> Enabled for managed storage with VMware: Template caching, create snapshot, 
> delete snapshot, create volume from snapshot, and create template from 
> snapshot
> Added an SIOC API plug-in to support VMware SIOC
> When starting a VM that uses managed storage in a cluster other than the one 
> it last was running in, we need to remove the reference to the iSCSI volume 
> from the original cluster.
> Added the ability to revert a volume to a snapshot
> Enabled cluster-scoped managed storage
> Added support for VMware dynamic discovery



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9620) Improvements for Managed Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314035#comment-16314035
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9620:


mike-tutkowski commented on issue #2298: CLOUDSTACK-9620: Enhancements for 
managed storage
URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-355684146
 
 
   I've added the following comment to the canHandle method:
   
   // canHandle returns true if the storage driver for the DataObject 
that's passed in can support certain features (what features we
   // care about during a particular invocation of this method depend on 
what type of DataObject was passed in (ex. VolumeInfo versus SnapshotInfo).
   
   Perhaps the method name is misleading. It might be interpreted to mean we 
can't do anything with this object if canHandle returns false. In reality, if 
canHandle returns true, we know you support certain features and we handle you 
a particular way. If it returns false, we might throw an exception or we might 
be able to handle you another way.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Improvements for Managed Storage
> 
>
> Key: CLOUDSTACK-9620
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9620
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Management Server, VMware, XenServer
>Affects Versions: 4.11.0.0
> Environment: KVM, vSphere, and XenServer
>Reporter: Mike Tutkowski
>Assignee: Mike Tutkowski
> Fix For: 4.11.0.0
>
>
> Allowed zone-wide primary storage based on a custom plug-in to be added via 
> the GUI in a KVM-only environment (previously this only worked for XenServer 
> and VMware)
> Added support for root disks on managed storage with KVM
> Added support for volume snapshots with managed storage on KVM
> Enabled creating a template directly from a volume (i.e. without having to go 
> through a volume snapshot) on KVM with managed storage
> Only allowed the resizing of a volume for managed storage on KVM if the 
> volume in question is either not attached to a VM or is attached to a VM in 
> the Stopped state
> Included support for Reinstall VM on KVM with managed storage
> Enabled offline migration on KVM from non-managed storage to managed storage 
> and vice versa
> Included support for online storage migration on KVM with managed storage 
> (NFS and Ceph to managed storage)
> Added support to download (extract) a managed-storage volume to a QCOW2 file
> When uploading a file from outside of CloudStack to CloudStack, set the min 
> and max IOPS, if applicable.
> Included support for the KVM auto-convergence feature
> The compression flag was actually added in version 1.0.3 (103) as opposed 
> to version 1.3.0 (1003000) (changed this to reflect the correct version)
> On KVM when using iSCSI-based managed storage, if the user shuts a VM down 
> from the guest OS (as opposed to doing so from CloudStack), we need to pass 
> to the KVM agent a list of applicable iSCSI volumes that need to be 
> disconnected.
> Added a new Global Setting: kvm.storage.live.migration.wait
> For XenServer, added a check to enforce that only volumes from zone-wide 
> managed storage can be storage motioned from a host in one cluster to a host 
> in another cluster (cannot do so at the time being with volumes from 
> cluster-scoped managed storage)
> Don’t allow Storage XenMotion on a VM that has any managed-storage volume 
> with one or more snapshots.
> Enabled for managed storage with VMware: Template caching, create snapshot, 
> delete snapshot, create volume from snapshot, and create template from 
> snapshot
> Added an SIOC API plug-in to support VMware SIOC
> When starting a VM that uses managed storage in a cluster other than the one 
> it last was running in, we need to remove the reference to the iSCSI volume 
> from the original cluster.
> Added the ability to revert a volume to a snapshot
> Enabled cluster-scoped managed storage
> Added support for VMware dynamic discovery



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10117) LDAP mapping on domain level

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314031#comment-16314031
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10117:
-

blueorangutan commented on issue #2381: CLOUDSTACK-10117 Account ldap binding
URL: https://github.com/apache/cloudstack/pull/2381#issuecomment-355683826
 
 
   Trillian test result (tid-2031)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 38512 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2381-t2031-kvm-centos7.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 66 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_redundant_VPC_default_routes | `Failure` | 882.41 | 
test_vpc_redundant.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> LDAP mapping on domain level
> 
>
> Key: CLOUDSTACK-10117
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10117
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Daan Hoogland
>
> see FS: 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Domain+level+LDAP+bindinings



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9889) Dedicate guest vlan range to a domain

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314022#comment-16314022
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9889:


blueorangutan commented on issue #2102: CLOUDSTACK-9889 Dedication of guest 
vlan range to a domain
URL: https://github.com/apache/cloudstack/pull/2102#issuecomment-355682424
 
 
   Trillian test result (tid-2032)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 36877 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2102-t2032-kvm-centos7.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 65 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | 
test_deploy_virtio_scsi_vm.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 376.02 | 
test_vpc_redundant.py
   test_02_redundant_VPC_default_routes | `Failure` | 891.67 | 
test_vpc_redundant.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Dedicate guest vlan  range to a domain
> --
>
> Key: CLOUDSTACK-9889
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9889
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: subhash yedugundla
>
> List of scenarios covered
> *Dedication of guest Vlan range*
> Admin should be allowed dedicate guest vlan ranges to a domain
> While dedicating a guest Vlan range
> If the range overlaps with any of the existing dedicated range then extend 
> the existing dedicated range
> Otherwise add it as a new dedicated guest Vlan range
> If the range doesn’t exist in the system then the request should fail
> If any of the vlan in the range is in use by a network that belongs to a 
> different account of different domain then the request should fail
> *Releasing guest Vlan range*
> Admin should be allowed to release a dedicated guest vlan range that is 
> dedicated to a domain back to the system pool
> If the range is not dedicated to the domain then the request should fail
> Even If one/more of the Vlans belonging to the range is in use by a network 
> the range should be released back to the system pool
>  The vlans that are in use should continue to be in use by the network
> *Network implementation*
> If the network belongs to an account that has a dedicated range of Vlans then 
> a Vlan from the account's dedicated range should be allocated to the network
> If an account uses up all of its dedicated Vlan’s the next network being 
> created for the account should be assigned a Vlan that belongs to the domain 
> pool
> Otherwise, a Vlan should be allocated from the free pool i.e. Vlan range 
> belonging to the zone
> *Network creation*
> If a Vlan id is specified and if this id belongs to a dedicated Vlan range of 
> a different account/domain then the creation should fail
> If a Vlan id is specified and if this id belongs to the system pool but the 
> network owner has a range of dedicated range of vlans then the creation 
> should fail
> *Domain deletion*
> Guest Ip ranges and vlans dedicated to the domain should be released back to 
> the free pool 
> *Account deletion*
> When an account is deleted, the IP ranges and vlans associated with the 
> account  should be moved to system pool.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9620) Improvements for Managed Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314014#comment-16314014
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9620:


mike-tutkowski commented on issue #2298: CLOUDSTACK-9620: Enhancements for 
managed storage
URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-355681495
 
 
   @rafaelweingartner I might be a be confused on that suggestion. If you 
!canHandleSrc, then you want to invoke 
handleCreateVolumeFromSnapshotOnSecondaryStorage.
   
   canHandleSrc being false just means a non-managed-storage driver is 
responsible for that primary storage. We can still use it, but it has to be 
handled a special way.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Improvements for Managed Storage
> 
>
> Key: CLOUDSTACK-9620
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9620
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Management Server, VMware, XenServer
>Affects Versions: 4.11.0.0
> Environment: KVM, vSphere, and XenServer
>Reporter: Mike Tutkowski
>Assignee: Mike Tutkowski
> Fix For: 4.11.0.0
>
>
> Allowed zone-wide primary storage based on a custom plug-in to be added via 
> the GUI in a KVM-only environment (previously this only worked for XenServer 
> and VMware)
> Added support for root disks on managed storage with KVM
> Added support for volume snapshots with managed storage on KVM
> Enabled creating a template directly from a volume (i.e. without having to go 
> through a volume snapshot) on KVM with managed storage
> Only allowed the resizing of a volume for managed storage on KVM if the 
> volume in question is either not attached to a VM or is attached to a VM in 
> the Stopped state
> Included support for Reinstall VM on KVM with managed storage
> Enabled offline migration on KVM from non-managed storage to managed storage 
> and vice versa
> Included support for online storage migration on KVM with managed storage 
> (NFS and Ceph to managed storage)
> Added support to download (extract) a managed-storage volume to a QCOW2 file
> When uploading a file from outside of CloudStack to CloudStack, set the min 
> and max IOPS, if applicable.
> Included support for the KVM auto-convergence feature
> The compression flag was actually added in version 1.0.3 (103) as opposed 
> to version 1.3.0 (1003000) (changed this to reflect the correct version)
> On KVM when using iSCSI-based managed storage, if the user shuts a VM down 
> from the guest OS (as opposed to doing so from CloudStack), we need to pass 
> to the KVM agent a list of applicable iSCSI volumes that need to be 
> disconnected.
> Added a new Global Setting: kvm.storage.live.migration.wait
> For XenServer, added a check to enforce that only volumes from zone-wide 
> managed storage can be storage motioned from a host in one cluster to a host 
> in another cluster (cannot do so at the time being with volumes from 
> cluster-scoped managed storage)
> Don’t allow Storage XenMotion on a VM that has any managed-storage volume 
> with one or more snapshots.
> Enabled for managed storage with VMware: Template caching, create snapshot, 
> delete snapshot, create volume from snapshot, and create template from 
> snapshot
> Added an SIOC API plug-in to support VMware SIOC
> When starting a VM that uses managed storage in a cluster other than the one 
> it last was running in, we need to remove the reference to the iSCSI volume 
> from the original cluster.
> Added the ability to revert a volume to a snapshot
> Enabled cluster-scoped managed storage
> Added support for VMware dynamic discovery



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9620) Improvements for Managed Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314016#comment-16314016
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9620:


mike-tutkowski commented on issue #2298: CLOUDSTACK-9620: Enhancements for 
managed storage
URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-355681495
 
 
   @rafaelweingartner I might be a bit confused on that suggestion. If you 
!canHandleSrc, then you want to invoke 
handleCreateVolumeFromSnapshotOnSecondaryStorage.
   
   canHandleSrc being false just means a non-managed-storage driver is 
responsible for that primary storage. We can still use it, but it has to be 
handled a special way.
 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Improvements for Managed Storage
> 
>
> Key: CLOUDSTACK-9620
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9620
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Management Server, VMware, XenServer
>Affects Versions: 4.11.0.0
> Environment: KVM, vSphere, and XenServer
>Reporter: Mike Tutkowski
>Assignee: Mike Tutkowski
> Fix For: 4.11.0.0
>
>
> Allowed zone-wide primary storage based on a custom plug-in to be added via 
> the GUI in a KVM-only environment (previously this only worked for XenServer 
> and VMware)
> Added support for root disks on managed storage with KVM
> Added support for volume snapshots with managed storage on KVM
> Enabled creating a template directly from a volume (i.e. without having to go 
> through a volume snapshot) on KVM with managed storage
> Only allowed the resizing of a volume for managed storage on KVM if the 
> volume in question is either not attached to a VM or is attached to a VM in 
> the Stopped state
> Included support for Reinstall VM on KVM with managed storage
> Enabled offline migration on KVM from non-managed storage to managed storage 
> and vice versa
> Included support for online storage migration on KVM with managed storage 
> (NFS and Ceph to managed storage)
> Added support to download (extract) a managed-storage volume to a QCOW2 file
> When uploading a file from outside of CloudStack to CloudStack, set the min 
> and max IOPS, if applicable.
> Included support for the KVM auto-convergence feature
> The compression flag was actually added in version 1.0.3 (103) as opposed 
> to version 1.3.0 (1003000) (changed this to reflect the correct version)
> On KVM when using iSCSI-based managed storage, if the user shuts a VM down 
> from the guest OS (as opposed to doing so from CloudStack), we need to pass 
> to the KVM agent a list of applicable iSCSI volumes that need to be 
> disconnected.
> Added a new Global Setting: kvm.storage.live.migration.wait
> For XenServer, added a check to enforce that only volumes from zone-wide 
> managed storage can be storage motioned from a host in one cluster to a host 
> in another cluster (cannot do so at the time being with volumes from 
> cluster-scoped managed storage)
> Don’t allow Storage XenMotion on a VM that has any managed-storage volume 
> with one or more snapshots.
> Enabled for managed storage with VMware: Template caching, create snapshot, 
> delete snapshot, create volume from snapshot, and create template from 
> snapshot
> Added an SIOC API plug-in to support VMware SIOC
> When starting a VM that uses managed storage in a cluster other than the one 
> it last was running in, we need to remove the reference to the iSCSI volume 
> from the original cluster.
> Added the ability to revert a volume to a snapshot
> Enabled cluster-scoped managed storage
> Added support for VMware dynamic discovery



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9620) Improvements for Managed Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313995#comment-16313995
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9620:


rafaelweingartner commented on issue #2298: CLOUDSTACK-9620: Enhancements for 
managed storage
URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-355677448
 
 
   That happens :)
   Yes, that is what I meant. Actually, you can even go one step further to 
take this code out of the conditional:
   ```
if (srcSnapshotInfo.getDataStore().getId() == 
destVolumeInfo.getDataStore().getId()) {
   
handleCreateVolumeFromSnapshotBothOnStorageSystem(srcSnapshotInfo, 
destVolumeInfo, callback);
   } else {
   String errMsg = "To perform this operation, the source and 
destination primary storages must be the same.";
   
   handleError(errMsg, callback);
   }
   ```
   you can use `if(!canHandleSrc)`, then throw the appropriated exception. 
   Then, you have your nice chunk of happy day (everything working and handling 
things as they should) code out of IFs


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Improvements for Managed Storage
> 
>
> Key: CLOUDSTACK-9620
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9620
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Management Server, VMware, XenServer
>Affects Versions: 4.11.0.0
> Environment: KVM, vSphere, and XenServer
>Reporter: Mike Tutkowski
>Assignee: Mike Tutkowski
> Fix For: 4.11.0.0
>
>
> Allowed zone-wide primary storage based on a custom plug-in to be added via 
> the GUI in a KVM-only environment (previously this only worked for XenServer 
> and VMware)
> Added support for root disks on managed storage with KVM
> Added support for volume snapshots with managed storage on KVM
> Enabled creating a template directly from a volume (i.e. without having to go 
> through a volume snapshot) on KVM with managed storage
> Only allowed the resizing of a volume for managed storage on KVM if the 
> volume in question is either not attached to a VM or is attached to a VM in 
> the Stopped state
> Included support for Reinstall VM on KVM with managed storage
> Enabled offline migration on KVM from non-managed storage to managed storage 
> and vice versa
> Included support for online storage migration on KVM with managed storage 
> (NFS and Ceph to managed storage)
> Added support to download (extract) a managed-storage volume to a QCOW2 file
> When uploading a file from outside of CloudStack to CloudStack, set the min 
> and max IOPS, if applicable.
> Included support for the KVM auto-convergence feature
> The compression flag was actually added in version 1.0.3 (103) as opposed 
> to version 1.3.0 (1003000) (changed this to reflect the correct version)
> On KVM when using iSCSI-based managed storage, if the user shuts a VM down 
> from the guest OS (as opposed to doing so from CloudStack), we need to pass 
> to the KVM agent a list of applicable iSCSI volumes that need to be 
> disconnected.
> Added a new Global Setting: kvm.storage.live.migration.wait
> For XenServer, added a check to enforce that only volumes from zone-wide 
> managed storage can be storage motioned from a host in one cluster to a host 
> in another cluster (cannot do so at the time being with volumes from 
> cluster-scoped managed storage)
> Don’t allow Storage XenMotion on a VM that has any managed-storage volume 
> with one or more snapshots.
> Enabled for managed storage with VMware: Template caching, create snapshot, 
> delete snapshot, create volume from snapshot, and create template from 
> snapshot
> Added an SIOC API plug-in to support VMware SIOC
> When starting a VM that uses managed storage in a cluster other than the one 
> it last was running in, we need to remove the reference to the iSCSI volume 
> from the original cluster.
> Added the ability to revert a volume to a snapshot
> Enabled cluster-scoped managed storage
> Added support for VMware dynamic discovery



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9620) Improvements for Managed Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313983#comment-16313983
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9620:


mike-tutkowski commented on issue #2298: CLOUDSTACK-9620: Enhancements for 
managed storage
URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-355676645
 
 
   @rafaelweingartner Sorry, I've probably been staring at code "too long" this 
afternoon and missed what you were saying at first. You probably mean something 
like this:
   
   private void handleCopyAsyncForSnapshotToVolume(SnapshotInfo 
srcSnapshotInfo, VolumeInfo destVolumeInfo,
   
AsyncCompletionCallback callback) {
   boolean canHandleDest = canHandle(destVolumeInfo);
   
   if (!canHandleDest) {
   handleError(OPERATION_NOT_SUPPORTED, callback);
   }
   
   boolean canHandleSrc = canHandle(srcSnapshotInfo);
   
   if (canHandleSrc) {
   if (srcSnapshotInfo.getDataStore().getId() == 
destVolumeInfo.getDataStore().getId()) {
   
handleCreateVolumeFromSnapshotBothOnStorageSystem(srcSnapshotInfo, 
destVolumeInfo, callback);
   } else {
   String errMsg = "To perform this operation, the source and 
destination primary storages must be the same.";
   
   handleError(errMsg, callback);
   }
   } else {
   
handleCreateVolumeFromSnapshotOnSecondaryStorage(srcSnapshotInfo, 
destVolumeInfo, callback);
   }
   }


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Improvements for Managed Storage
> 
>
> Key: CLOUDSTACK-9620
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9620
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Management Server, VMware, XenServer
>Affects Versions: 4.11.0.0
> Environment: KVM, vSphere, and XenServer
>Reporter: Mike Tutkowski
>Assignee: Mike Tutkowski
> Fix For: 4.11.0.0
>
>
> Allowed zone-wide primary storage based on a custom plug-in to be added via 
> the GUI in a KVM-only environment (previously this only worked for XenServer 
> and VMware)
> Added support for root disks on managed storage with KVM
> Added support for volume snapshots with managed storage on KVM
> Enabled creating a template directly from a volume (i.e. without having to go 
> through a volume snapshot) on KVM with managed storage
> Only allowed the resizing of a volume for managed storage on KVM if the 
> volume in question is either not attached to a VM or is attached to a VM in 
> the Stopped state
> Included support for Reinstall VM on KVM with managed storage
> Enabled offline migration on KVM from non-managed storage to managed storage 
> and vice versa
> Included support for online storage migration on KVM with managed storage 
> (NFS and Ceph to managed storage)
> Added support to download (extract) a managed-storage volume to a QCOW2 file
> When uploading a file from outside of CloudStack to CloudStack, set the min 
> and max IOPS, if applicable.
> Included support for the KVM auto-convergence feature
> The compression flag was actually added in version 1.0.3 (103) as opposed 
> to version 1.3.0 (1003000) (changed this to reflect the correct version)
> On KVM when using iSCSI-based managed storage, if the user shuts a VM down 
> from the guest OS (as opposed to doing so from CloudStack), we need to pass 
> to the KVM agent a list of applicable iSCSI volumes that need to be 
> disconnected.
> Added a new Global Setting: kvm.storage.live.migration.wait
> For XenServer, added a check to enforce that only volumes from zone-wide 
> managed storage can be storage motioned from a host in one cluster to a host 
> in another cluster (cannot do so at the time being with volumes from 
> cluster-scoped managed storage)
> Don’t allow Storage XenMotion on a VM that has any managed-storage volume 
> with one or more snapshots.
> Enabled for managed storage with VMware: Template caching, create snapshot, 
> delete snapshot, create volume from snapshot, and create template from 
> snapshot
> Added an SIOC API plug-in to support VMware SIOC
> When starting a VM that uses managed storage in a cluster other than the one 
> it last was running in, we need to remove the reference to the iSCSI volume 
> from the original cluster.
> Added the ability to revert a volume 

[jira] [Commented] (CLOUDSTACK-9620) Improvements for Managed Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313961#comment-16313961
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9620:


rafaelweingartner commented on issue #2298: CLOUDSTACK-9620: Enhancements for 
managed storage
URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-355674496
 
 
   @mike-tutkowski thanks for the effort. I would still prefer a cleaner 
version though.
   
   This block of code is the case that it is better to start with the 
conditions that generate exceptions `!canHandleDest` and `!canHandleSrc`, and 
then you can create the normal flow without requiring to add it inside a 
conditional. 
   
   Anyways as I said here previously, I understand if you guys do not have time 
and energy to improve this now. However, we should start paying more attention 
to these legacy codes that sometimes are badly structured.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Improvements for Managed Storage
> 
>
> Key: CLOUDSTACK-9620
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9620
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Management Server, VMware, XenServer
>Affects Versions: 4.11.0.0
> Environment: KVM, vSphere, and XenServer
>Reporter: Mike Tutkowski
>Assignee: Mike Tutkowski
> Fix For: 4.11.0.0
>
>
> Allowed zone-wide primary storage based on a custom plug-in to be added via 
> the GUI in a KVM-only environment (previously this only worked for XenServer 
> and VMware)
> Added support for root disks on managed storage with KVM
> Added support for volume snapshots with managed storage on KVM
> Enabled creating a template directly from a volume (i.e. without having to go 
> through a volume snapshot) on KVM with managed storage
> Only allowed the resizing of a volume for managed storage on KVM if the 
> volume in question is either not attached to a VM or is attached to a VM in 
> the Stopped state
> Included support for Reinstall VM on KVM with managed storage
> Enabled offline migration on KVM from non-managed storage to managed storage 
> and vice versa
> Included support for online storage migration on KVM with managed storage 
> (NFS and Ceph to managed storage)
> Added support to download (extract) a managed-storage volume to a QCOW2 file
> When uploading a file from outside of CloudStack to CloudStack, set the min 
> and max IOPS, if applicable.
> Included support for the KVM auto-convergence feature
> The compression flag was actually added in version 1.0.3 (103) as opposed 
> to version 1.3.0 (1003000) (changed this to reflect the correct version)
> On KVM when using iSCSI-based managed storage, if the user shuts a VM down 
> from the guest OS (as opposed to doing so from CloudStack), we need to pass 
> to the KVM agent a list of applicable iSCSI volumes that need to be 
> disconnected.
> Added a new Global Setting: kvm.storage.live.migration.wait
> For XenServer, added a check to enforce that only volumes from zone-wide 
> managed storage can be storage motioned from a host in one cluster to a host 
> in another cluster (cannot do so at the time being with volumes from 
> cluster-scoped managed storage)
> Don’t allow Storage XenMotion on a VM that has any managed-storage volume 
> with one or more snapshots.
> Enabled for managed storage with VMware: Template caching, create snapshot, 
> delete snapshot, create volume from snapshot, and create template from 
> snapshot
> Added an SIOC API plug-in to support VMware SIOC
> When starting a VM that uses managed storage in a cluster other than the one 
> it last was running in, we need to remove the reference to the iSCSI volume 
> from the original cluster.
> Added the ability to revert a volume to a snapshot
> Enabled cluster-scoped managed storage
> Added support for VMware dynamic discovery



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9632) Upgrade bountycastle to 1.55+

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313930#comment-16313930
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9632:


blueorangutan commented on issue #2386: CLOUDSTACK-9632: Upgrade bountycastle 
to v1.59
URL: https://github.com/apache/cloudstack/pull/2386#issuecomment-355670621
 
 
   Trillian test result (tid-2029)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 36392 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2386-t2029-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_accounts.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 65 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_07_resize_fail | `Failure` | 15.33 | test_volumes.py
   test_05_rvpc_multi_tiers | `Failure` | 387.56 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 438.44 | test_vpc_redundant.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Upgrade bountycastle to 1.55+
> -
>
> Key: CLOUDSTACK-9632
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9632
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Rohit Yadav
>Assignee: Rohit Yadav
> Fix For: Future, 4.10.1.0
>
>
> Upgrade bountycastle library to latest versions.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9620) Improvements for Managed Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313924#comment-16313924
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9620:


mike-tutkowski commented on issue #2298: CLOUDSTACK-9620: Enhancements for 
managed storage
URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-355670187
 
 
   @rafaelweingartner I went ahead and updated it to the following:
   
   private void handleCopyAsyncForSnapshotToVolume(boolean canHandleSrc, 
SnapshotInfo srcSnapshotInfo, VolumeInfo destVolumeInfo,
   
AsyncCompletionCallback callback) {
   boolean canHandleDest = canHandle(destVolumeInfo);
   
   if (canHandleSrc && canHandleDest) {
   if (srcSnapshotInfo.getDataStore().getId() == 
destVolumeInfo.getDataStore().getId()) {
   
handleCreateVolumeFromSnapshotBothOnStorageSystem(srcSnapshotInfo, 
destVolumeInfo, callback);
   } else {
   String errMsg = "To perform this operation, the source and 
destination primary storages must be the same.";
   
   handleError(errMsg, callback);
   }
   } else if (canHandleDest) {
   
handleCreateVolumeFromSnapshotOnSecondaryStorage(srcSnapshotInfo, 
destVolumeInfo, callback);
   }
   else {
   handleError(OPERATION_NOT_SUPPORTED, callback);
   }
   }
   
   Basically, the code needs to throw an exception in two cases: [if both 
canHandleSrc and canHandleDest are false] or [if canHandleSrc is true, but 
canHandleDest is false].


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Improvements for Managed Storage
> 
>
> Key: CLOUDSTACK-9620
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9620
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Management Server, VMware, XenServer
>Affects Versions: 4.11.0.0
> Environment: KVM, vSphere, and XenServer
>Reporter: Mike Tutkowski
>Assignee: Mike Tutkowski
> Fix For: 4.11.0.0
>
>
> Allowed zone-wide primary storage based on a custom plug-in to be added via 
> the GUI in a KVM-only environment (previously this only worked for XenServer 
> and VMware)
> Added support for root disks on managed storage with KVM
> Added support for volume snapshots with managed storage on KVM
> Enabled creating a template directly from a volume (i.e. without having to go 
> through a volume snapshot) on KVM with managed storage
> Only allowed the resizing of a volume for managed storage on KVM if the 
> volume in question is either not attached to a VM or is attached to a VM in 
> the Stopped state
> Included support for Reinstall VM on KVM with managed storage
> Enabled offline migration on KVM from non-managed storage to managed storage 
> and vice versa
> Included support for online storage migration on KVM with managed storage 
> (NFS and Ceph to managed storage)
> Added support to download (extract) a managed-storage volume to a QCOW2 file
> When uploading a file from outside of CloudStack to CloudStack, set the min 
> and max IOPS, if applicable.
> Included support for the KVM auto-convergence feature
> The compression flag was actually added in version 1.0.3 (103) as opposed 
> to version 1.3.0 (1003000) (changed this to reflect the correct version)
> On KVM when using iSCSI-based managed storage, if the user shuts a VM down 
> from the guest OS (as opposed to doing so from CloudStack), we need to pass 
> to the KVM agent a list of applicable iSCSI volumes that need to be 
> disconnected.
> Added a new Global Setting: kvm.storage.live.migration.wait
> For XenServer, added a check to enforce that only volumes from zone-wide 
> managed storage can be storage motioned from a host in one cluster to a host 
> in another cluster (cannot do so at the time being with volumes from 
> cluster-scoped managed storage)
> Don’t allow Storage XenMotion on a VM that has any managed-storage volume 
> with one or more snapshots.
> Enabled for managed storage with VMware: Template caching, create snapshot, 
> delete snapshot, create volume from snapshot, and create template from 
> snapshot
> Added an SIOC API plug-in to support VMware SIOC
> When starting a VM that uses managed storage in a cluster other than the one 
> it last was running in, we need to remove the reference to the iSCSI volume 
> from the original 

[jira] [Commented] (CLOUDSTACK-9620) Improvements for Managed Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313814#comment-16313814
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9620:


rafaelweingartner commented on issue #2298: CLOUDSTACK-9620: Enhancements for 
managed storage
URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-355655356
 
 
   @mike-tutkowski my comment was under one of Daan’s where the validations are 
inverted in class “StorageSystemDataMotionStrategy.java”. Here follows what I 
said there:
   
   > Documentation could help. However, I would first suggesting extracting 
lines 308-327 to a method. Then, instead of starting with if (canHandleSrc && 
canHandleDest), you can do the following:
   >
   > if (!canHandleSrc){Throw exception regarding source not being able to 
handle the request}
   > if (!canHandleDest){Throw exception regarding destination not being able 
to handle the request }
   > 
   > Then, if you pass those two IFs, you do not need a third one to check if 
(canHandleSrc && canHandleDest)
   > 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Improvements for Managed Storage
> 
>
> Key: CLOUDSTACK-9620
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9620
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Management Server, VMware, XenServer
>Affects Versions: 4.11.0.0
> Environment: KVM, vSphere, and XenServer
>Reporter: Mike Tutkowski
>Assignee: Mike Tutkowski
> Fix For: 4.11.0.0
>
>
> Allowed zone-wide primary storage based on a custom plug-in to be added via 
> the GUI in a KVM-only environment (previously this only worked for XenServer 
> and VMware)
> Added support for root disks on managed storage with KVM
> Added support for volume snapshots with managed storage on KVM
> Enabled creating a template directly from a volume (i.e. without having to go 
> through a volume snapshot) on KVM with managed storage
> Only allowed the resizing of a volume for managed storage on KVM if the 
> volume in question is either not attached to a VM or is attached to a VM in 
> the Stopped state
> Included support for Reinstall VM on KVM with managed storage
> Enabled offline migration on KVM from non-managed storage to managed storage 
> and vice versa
> Included support for online storage migration on KVM with managed storage 
> (NFS and Ceph to managed storage)
> Added support to download (extract) a managed-storage volume to a QCOW2 file
> When uploading a file from outside of CloudStack to CloudStack, set the min 
> and max IOPS, if applicable.
> Included support for the KVM auto-convergence feature
> The compression flag was actually added in version 1.0.3 (103) as opposed 
> to version 1.3.0 (1003000) (changed this to reflect the correct version)
> On KVM when using iSCSI-based managed storage, if the user shuts a VM down 
> from the guest OS (as opposed to doing so from CloudStack), we need to pass 
> to the KVM agent a list of applicable iSCSI volumes that need to be 
> disconnected.
> Added a new Global Setting: kvm.storage.live.migration.wait
> For XenServer, added a check to enforce that only volumes from zone-wide 
> managed storage can be storage motioned from a host in one cluster to a host 
> in another cluster (cannot do so at the time being with volumes from 
> cluster-scoped managed storage)
> Don’t allow Storage XenMotion on a VM that has any managed-storage volume 
> with one or more snapshots.
> Enabled for managed storage with VMware: Template caching, create snapshot, 
> delete snapshot, create volume from snapshot, and create template from 
> snapshot
> Added an SIOC API plug-in to support VMware SIOC
> When starting a VM that uses managed storage in a cluster other than the one 
> it last was running in, we need to remove the reference to the iSCSI volume 
> from the original cluster.
> Added the ability to revert a volume to a snapshot
> Enabled cluster-scoped managed storage
> Added support for VMware dynamic discovery



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9620) Improvements for Managed Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313810#comment-16313810
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9620:


mike-tutkowski commented on issue #2298: CLOUDSTACK-9620: Enhancements for 
managed storage
URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-355654975
 
 
   @rhtyd Once we do have the requisite number of LGTMs, I'd like to re-run all 
of the managed-storage automated tests (existing and new ones) to verify they 
all still pass (since I have made changes to the code per reviewer requests). 
The automated tests will probably take me a couple days to execute.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Improvements for Managed Storage
> 
>
> Key: CLOUDSTACK-9620
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9620
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Management Server, VMware, XenServer
>Affects Versions: 4.11.0.0
> Environment: KVM, vSphere, and XenServer
>Reporter: Mike Tutkowski
>Assignee: Mike Tutkowski
> Fix For: 4.11.0.0
>
>
> Allowed zone-wide primary storage based on a custom plug-in to be added via 
> the GUI in a KVM-only environment (previously this only worked for XenServer 
> and VMware)
> Added support for root disks on managed storage with KVM
> Added support for volume snapshots with managed storage on KVM
> Enabled creating a template directly from a volume (i.e. without having to go 
> through a volume snapshot) on KVM with managed storage
> Only allowed the resizing of a volume for managed storage on KVM if the 
> volume in question is either not attached to a VM or is attached to a VM in 
> the Stopped state
> Included support for Reinstall VM on KVM with managed storage
> Enabled offline migration on KVM from non-managed storage to managed storage 
> and vice versa
> Included support for online storage migration on KVM with managed storage 
> (NFS and Ceph to managed storage)
> Added support to download (extract) a managed-storage volume to a QCOW2 file
> When uploading a file from outside of CloudStack to CloudStack, set the min 
> and max IOPS, if applicable.
> Included support for the KVM auto-convergence feature
> The compression flag was actually added in version 1.0.3 (103) as opposed 
> to version 1.3.0 (1003000) (changed this to reflect the correct version)
> On KVM when using iSCSI-based managed storage, if the user shuts a VM down 
> from the guest OS (as opposed to doing so from CloudStack), we need to pass 
> to the KVM agent a list of applicable iSCSI volumes that need to be 
> disconnected.
> Added a new Global Setting: kvm.storage.live.migration.wait
> For XenServer, added a check to enforce that only volumes from zone-wide 
> managed storage can be storage motioned from a host in one cluster to a host 
> in another cluster (cannot do so at the time being with volumes from 
> cluster-scoped managed storage)
> Don’t allow Storage XenMotion on a VM that has any managed-storage volume 
> with one or more snapshots.
> Enabled for managed storage with VMware: Template caching, create snapshot, 
> delete snapshot, create volume from snapshot, and create template from 
> snapshot
> Added an SIOC API plug-in to support VMware SIOC
> When starting a VM that uses managed storage in a cluster other than the one 
> it last was running in, we need to remove the reference to the iSCSI volume 
> from the original cluster.
> Added the ability to revert a volume to a snapshot
> Enabled cluster-scoped managed storage
> Added support for VMware dynamic discovery



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10207) updateVpnCustomerGateway: unexpected changes on optional keys

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313806#comment-16313806
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10207:
-

blueorangutan commented on issue #2377: CLOUDSTACK-10207: 
updateVpnCustomerGateway: fix defaulting for option…
URL: https://github.com/apache/cloudstack/pull/2377#issuecomment-355654335
 
 
   Trillian test result (tid-2021)
   Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 45299 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2377-t2021-vmware-55u3.zip
   Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 66 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 156.91 | 
test_host_maintenance.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> updateVpnCustomerGateway: unexpected changes on optional keys
> -
>
> Key: CLOUDSTACK-10207
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10207
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Reporter: René Moser
>Assignee: René Moser
>Priority: Minor
> Fix For: 4.11.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9620) Improvements for Managed Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313804#comment-16313804
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9620:


mike-tutkowski commented on issue #2298: CLOUDSTACK-9620: Enhancements for 
managed storage
URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-355653898
 
 
   @DaanHoogland I've been searching for comments from @rafaelweingartner, but 
I don't see any regarding complexity.
   
   I will say that 90% of this code exists in prior (private) branches that 
customers of mine have been using throughout much of 2017.
   
   Here are some videos that demonstrate a subset of the new functionality:
   
   **KVM enhancements regarding managed storage:**
   
   
https://www.youtube.com/watch?v=-tExEvkMJYs=19=PLqOXKM0Bt13DFnQnwUx8ZtJzoyDV0Uuye=2508s
   
   **VMware enhancements regarding managed storage:**
   
   
https://www.youtube.com/watch?v=UbiAPP9nyEM=20=PLqOXKM0Bt13DFnQnwUx8ZtJzoyDV0Uuye=538s
   
   **KVM volume migration (NFS or Ceph to managed storage):**
   
   
https://www.youtube.com/watch?v=Oy4IsTzqN1c=27s=PLqOXKM0Bt13DFnQnwUx8ZtJzoyDV0Uuye=21
   
   **Online storage migration in KVM (NFS or Ceph to managed storage):**
   
   
https://www.youtube.com/watch?v=VbnMwYYkRnQ=342s=PLqOXKM0Bt13DFnQnwUx8ZtJzoyDV0Uuye=22
   
   **Extract contents of managed-storage volume on KVM to QCOW2 file:**
   
   
https://www.youtube.com/watch?v=mW3hZLKymsI=3s=PLqOXKM0Bt13DFnQnwUx8ZtJzoyDV0Uuye=23
   
   **Upload contents of QCOW2 file to managed-storage volume on KVM:**
   
   
https://www.youtube.com/watch?v=_c3OSluMkxc=164s=PLqOXKM0Bt13DFnQnwUx8ZtJzoyDV0Uuye=24
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Improvements for Managed Storage
> 
>
> Key: CLOUDSTACK-9620
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9620
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Management Server, VMware, XenServer
>Affects Versions: 4.11.0.0
> Environment: KVM, vSphere, and XenServer
>Reporter: Mike Tutkowski
>Assignee: Mike Tutkowski
> Fix For: 4.11.0.0
>
>
> Allowed zone-wide primary storage based on a custom plug-in to be added via 
> the GUI in a KVM-only environment (previously this only worked for XenServer 
> and VMware)
> Added support for root disks on managed storage with KVM
> Added support for volume snapshots with managed storage on KVM
> Enabled creating a template directly from a volume (i.e. without having to go 
> through a volume snapshot) on KVM with managed storage
> Only allowed the resizing of a volume for managed storage on KVM if the 
> volume in question is either not attached to a VM or is attached to a VM in 
> the Stopped state
> Included support for Reinstall VM on KVM with managed storage
> Enabled offline migration on KVM from non-managed storage to managed storage 
> and vice versa
> Included support for online storage migration on KVM with managed storage 
> (NFS and Ceph to managed storage)
> Added support to download (extract) a managed-storage volume to a QCOW2 file
> When uploading a file from outside of CloudStack to CloudStack, set the min 
> and max IOPS, if applicable.
> Included support for the KVM auto-convergence feature
> The compression flag was actually added in version 1.0.3 (103) as opposed 
> to version 1.3.0 (1003000) (changed this to reflect the correct version)
> On KVM when using iSCSI-based managed storage, if the user shuts a VM down 
> from the guest OS (as opposed to doing so from CloudStack), we need to pass 
> to the KVM agent a list of applicable iSCSI volumes that need to be 
> disconnected.
> Added a new Global Setting: kvm.storage.live.migration.wait
> For XenServer, added a check to enforce that only volumes from zone-wide 
> managed storage can be storage motioned from a host in one cluster to a host 
> in another cluster (cannot do so at the time being with volumes from 
> cluster-scoped managed storage)
> Don’t allow Storage XenMotion on a VM that has any managed-storage volume 
> with one or more snapshots.
> Enabled for managed storage with VMware: Template caching, create snapshot, 
> delete snapshot, create volume from snapshot, and create template from 
> snapshot
> Added an SIOC API plug-in to support VMware SIOC
> When starting a VM that uses managed storage in a cluster other than the one 
> it last was running in, we need to remove the reference to the iSCSI volume 
> 

[jira] [Commented] (CLOUDSTACK-9620) Improvements for Managed Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313771#comment-16313771
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9620:


mike-tutkowski commented on issue #2298: CLOUDSTACK-9620: Enhancements for 
managed storage
URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-355490015
 
 
   @rhtyd @DaanHoogland I have refactored the createAsync method in 
StorageSystemDataMotionStrategy.java. I still need to make use of the ConfigKey 
class instead of the Config class, as Daan requested. I should be able to do 
this tomorrow (well, technically, later today).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Improvements for Managed Storage
> 
>
> Key: CLOUDSTACK-9620
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9620
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Management Server, VMware, XenServer
>Affects Versions: 4.11.0.0
> Environment: KVM, vSphere, and XenServer
>Reporter: Mike Tutkowski
>Assignee: Mike Tutkowski
> Fix For: 4.11.0.0
>
>
> Allowed zone-wide primary storage based on a custom plug-in to be added via 
> the GUI in a KVM-only environment (previously this only worked for XenServer 
> and VMware)
> Added support for root disks on managed storage with KVM
> Added support for volume snapshots with managed storage on KVM
> Enabled creating a template directly from a volume (i.e. without having to go 
> through a volume snapshot) on KVM with managed storage
> Only allowed the resizing of a volume for managed storage on KVM if the 
> volume in question is either not attached to a VM or is attached to a VM in 
> the Stopped state
> Included support for Reinstall VM on KVM with managed storage
> Enabled offline migration on KVM from non-managed storage to managed storage 
> and vice versa
> Included support for online storage migration on KVM with managed storage 
> (NFS and Ceph to managed storage)
> Added support to download (extract) a managed-storage volume to a QCOW2 file
> When uploading a file from outside of CloudStack to CloudStack, set the min 
> and max IOPS, if applicable.
> Included support for the KVM auto-convergence feature
> The compression flag was actually added in version 1.0.3 (103) as opposed 
> to version 1.3.0 (1003000) (changed this to reflect the correct version)
> On KVM when using iSCSI-based managed storage, if the user shuts a VM down 
> from the guest OS (as opposed to doing so from CloudStack), we need to pass 
> to the KVM agent a list of applicable iSCSI volumes that need to be 
> disconnected.
> Added a new Global Setting: kvm.storage.live.migration.wait
> For XenServer, added a check to enforce that only volumes from zone-wide 
> managed storage can be storage motioned from a host in one cluster to a host 
> in another cluster (cannot do so at the time being with volumes from 
> cluster-scoped managed storage)
> Don’t allow Storage XenMotion on a VM that has any managed-storage volume 
> with one or more snapshots.
> Enabled for managed storage with VMware: Template caching, create snapshot, 
> delete snapshot, create volume from snapshot, and create template from 
> snapshot
> Added an SIOC API plug-in to support VMware SIOC
> When starting a VM that uses managed storage in a cluster other than the one 
> it last was running in, we need to remove the reference to the iSCSI volume 
> from the original cluster.
> Added the ability to revert a volume to a snapshot
> Enabled cluster-scoped managed storage
> Added support for VMware dynamic discovery



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10197) XenServer 7.1: Cannot mount xentool iso from cloudstack on VMs

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313745#comment-16313745
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10197:
-

khos2ow commented on issue #2365: CLOUDSTACK-10197: Rename xentools iso for 
XenServer 7.0+
URL: https://github.com/apache/cloudstack/pull/2365#issuecomment-355647317
 
 
   @rhtyd I don't think the failed tests are related to the change. The change 
was in attaching ISO. Can you re-run the test?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> XenServer 7.1: Cannot mount  xentool iso from cloudstack on VMs
> ---
>
> Key: CLOUDSTACK-10197
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10197
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.10.0.0
> Environment: XenServer 7.0+
>Reporter: Khosrow Moossavi
> Fix For: Future
>
>
> In XenServer 7.0+ xentools iso has been renamed from *xs-tools* to 
> *guest-tools* so CloudStack fails to attach it to any VM.
> {code}
> (acs-admin) > attach iso 
> virtualmachineid=d13eeff1-2d99-46a9-8fc5-3510df6e9f5e 
> id=e8a56540-0fc3-44de-9911-635d2d8f25c4
> errorcode = 530
> errortext = Failed to attach iso
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313735#comment-16313735
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

rafaelweingartner commented on a change in pull request #2379: 
CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159961885
 
 

 ##
 File path: 
agent/src/com/cloud/agent/direct/download/HttpDirectTemplateDownloader.java
 ##
 @@ -0,0 +1,129 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.agent.direct.download;
+
+import com.cloud.utils.exception.CloudRuntimeException;
+import org.apache.commons.collections.MapUtils;
+import org.apache.commons.httpclient.HttpClient;
+import org.apache.commons.httpclient.HttpMethod;
+import org.apache.commons.httpclient.HttpMethodRetryHandler;
+import org.apache.commons.httpclient.MultiThreadedHttpConnectionManager;
+import org.apache.commons.httpclient.NoHttpResponseException;
+import org.apache.commons.httpclient.methods.GetMethod;
+import org.apache.commons.httpclient.params.HttpMethodParams;
+import org.apache.commons.io.IOUtils;
+import org.apache.log4j.Logger;
+
+import java.io.File;
+import java.io.FileOutputStream;
+import java.io.InputStream;
+import java.io.OutputStream;
+import java.io.IOException;
+import java.util.Map;
+
+public class HttpDirectTemplateDownloader extends DirectTemplateDownloaderImpl 
{
+
+private HttpClient client;
+private static final MultiThreadedHttpConnectionManager 
s_httpClientManager = new MultiThreadedHttpConnectionManager();
+private static final int CHUNK_SIZE = 1024 * 1024; //1M
+protected HttpMethodRetryHandler myretryhandler;
+public static final Logger s_logger = 
Logger.getLogger(HttpDirectTemplateDownloader.class.getName());
+protected GetMethod request;
+
+public HttpDirectTemplateDownloader(String url, Long templateId, String 
destPoolPath, String checksum, Map headers) {
+super(url, destPoolPath, templateId, checksum);
+client = new HttpClient(s_httpClientManager);
+myretryhandler = createRetryTwiceHandler();
+request = createRequest(url, headers);
+String downloadDir = getDirectDownloadTempPath(templateId);
+createTemporaryDirectoryAndFile(downloadDir);
+}
+
+protected void createTemporaryDirectoryAndFile(String downloadDir) {
+createFolder(getDestPoolPath() + File.separator + downloadDir);
+File f = new File(getDestPoolPath() + File.separator + downloadDir + 
File.separator + getFileNameFromUrl());
+setDownloadedFilePath(f.getAbsolutePath());
+}
+
+protected GetMethod createRequest(String downloadUrl, Map 
headers) {
+GetMethod request = new GetMethod(downloadUrl);
+request.getParams().setParameter(HttpMethodParams.RETRY_HANDLER, 
myretryhandler);
+request.setFollowRedirects(true);
+if (MapUtils.isNotEmpty(headers)) {
+for (String key : headers.keySet()) {
+request.setRequestHeader(key, headers.get(key));
+}
+}
+return request;
+}
+
+protected HttpMethodRetryHandler createRetryTwiceHandler() {
+return new HttpMethodRetryHandler() {
+@Override
+public boolean retryMethod(final HttpMethod method, final 
IOException exception, int executionCount) {
+if (executionCount >= 2) {
+// Do not retry if over max retry count
+return false;
+}
+if (exception instanceof NoHttpResponseException) {
+// Retry if the server dropped connection on us
+return true;
+}
+if (!method.isRequestSent()) {
+// Retry if the request has not been sent fully or
+// if it's OK to retry methods that have been sent
+return true;
+}
+// otherwise do not retry
+return false;
+}
+

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313733#comment-16313733
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

rafaelweingartner commented on a change in pull request #2379: 
CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159961885
 
 

 ##
 File path: 
agent/src/com/cloud/agent/direct/download/HttpDirectTemplateDownloader.java
 ##
 @@ -0,0 +1,129 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.agent.direct.download;
+
+import com.cloud.utils.exception.CloudRuntimeException;
+import org.apache.commons.collections.MapUtils;
+import org.apache.commons.httpclient.HttpClient;
+import org.apache.commons.httpclient.HttpMethod;
+import org.apache.commons.httpclient.HttpMethodRetryHandler;
+import org.apache.commons.httpclient.MultiThreadedHttpConnectionManager;
+import org.apache.commons.httpclient.NoHttpResponseException;
+import org.apache.commons.httpclient.methods.GetMethod;
+import org.apache.commons.httpclient.params.HttpMethodParams;
+import org.apache.commons.io.IOUtils;
+import org.apache.log4j.Logger;
+
+import java.io.File;
+import java.io.FileOutputStream;
+import java.io.InputStream;
+import java.io.OutputStream;
+import java.io.IOException;
+import java.util.Map;
+
+public class HttpDirectTemplateDownloader extends DirectTemplateDownloaderImpl 
{
+
+private HttpClient client;
+private static final MultiThreadedHttpConnectionManager 
s_httpClientManager = new MultiThreadedHttpConnectionManager();
+private static final int CHUNK_SIZE = 1024 * 1024; //1M
+protected HttpMethodRetryHandler myretryhandler;
+public static final Logger s_logger = 
Logger.getLogger(HttpDirectTemplateDownloader.class.getName());
+protected GetMethod request;
+
+public HttpDirectTemplateDownloader(String url, Long templateId, String 
destPoolPath, String checksum, Map headers) {
+super(url, destPoolPath, templateId, checksum);
+client = new HttpClient(s_httpClientManager);
+myretryhandler = createRetryTwiceHandler();
+request = createRequest(url, headers);
+String downloadDir = getDirectDownloadTempPath(templateId);
+createTemporaryDirectoryAndFile(downloadDir);
+}
+
+protected void createTemporaryDirectoryAndFile(String downloadDir) {
+createFolder(getDestPoolPath() + File.separator + downloadDir);
+File f = new File(getDestPoolPath() + File.separator + downloadDir + 
File.separator + getFileNameFromUrl());
+setDownloadedFilePath(f.getAbsolutePath());
+}
+
+protected GetMethod createRequest(String downloadUrl, Map 
headers) {
+GetMethod request = new GetMethod(downloadUrl);
+request.getParams().setParameter(HttpMethodParams.RETRY_HANDLER, 
myretryhandler);
+request.setFollowRedirects(true);
+if (MapUtils.isNotEmpty(headers)) {
+for (String key : headers.keySet()) {
+request.setRequestHeader(key, headers.get(key));
+}
+}
+return request;
+}
+
+protected HttpMethodRetryHandler createRetryTwiceHandler() {
+return new HttpMethodRetryHandler() {
+@Override
+public boolean retryMethod(final HttpMethod method, final 
IOException exception, int executionCount) {
+if (executionCount >= 2) {
+// Do not retry if over max retry count
+return false;
+}
+if (exception instanceof NoHttpResponseException) {
+// Retry if the server dropped connection on us
+return true;
+}
+if (!method.isRequestSent()) {
+// Retry if the request has not been sent fully or
+// if it's OK to retry methods that have been sent
+return true;
+}
+// otherwise do not retry
+return false;
+}
+

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313703#comment-16313703
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

nvazquez commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary Storage 
for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355641600
 
 
   Thanks @rhtyd @rafaelweingartner, I tried addressing all your comments 
before going on vacation tomorrow. Thanks @DaanHoogland for taking up the 
remaining open comment


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313697#comment-16313697
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9813:


blueorangutan commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending 
Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-355640904
 
 
   Trillian test result (tid-2025)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 37105 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2097-t2025-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 65 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_vpc_privategw_static_routes | `Failure` | 325.03 | 
test_privategw_acl.py
   test_hostha_kvm_host_fencing | `Error` | 650.21 | test_hostha_kvm.py
   test_hostha_kvm_host_recovering | `Error` | 658.54 | test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --
>
> Key: CLOUDSTACK-9813
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Network Controller, Secondary Storage, SystemVM, 
> VMware
>Affects Versions: Future
>Reporter: Eric Waegeman
>Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement 
> configdrive for userdata, metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware 
> plugins are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (CLOUDSTACK-10214) Unable to remove local primary storage

[JIRA]

 [ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rafael Weingärtner updated CLOUDSTACK-10214:

Status: Reviewable  (was: In Progress)

> Unable to remove local primary storage 
> ---
>
> Key: CLOUDSTACK-10214
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10214
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.10.0.0, 4.9.3.0
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>
> When enabling the use of local storage ACS will automatically load all local 
> storage configured in the Host and start using them as primary storage to 
> deploy user VMs (if the service offering allows to do so). However, if the 
> operator wants to remove the local storage ACS will throw an exception saying 
> that the removal of local storage is not allowed.Therefore, if one wants to 
> remove a local storage, he/she needs to do a manual intervention in the 
> database and hosts.
> This limitation was removed, as it was only a logical restriction.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (CLOUDSTACK-9846) Make provision to store content and subject for Alerts in separate columns.

[JIRA]

 [ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rafael Weingärtner updated CLOUDSTACK-9846:
---
Status: Reviewable  (was: In Progress)

> Make provision to store content and subject for Alerts in separate columns.
> ---
>
> Key: CLOUDSTACK-9846
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9846
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server
>Reporter: Bharat Kumar
>Assignee: Rafael Weingärtner
>
> In AlertManagerImpl.java we store the alerts in db. We currently do not have 
> a separate column for content in the db, So we are appending the subject and 
> content both to the same column. We need to fix this by creating a separate 
> column for content of the alter and store them.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10214) Unable to remove local primary storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313624#comment-16313624
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10214:
-

rafaelweingartner opened a new pull request #2390: [CLOUDSTACK-10214] Unable to 
remove local primary storage
URL: https://github.com/apache/cloudstack/pull/2390
 
 
   When enabling the use of local storage ACS will automatically load all local 
storage configured in the Host and start using them as primary storage to 
deploy user VMs (if the service offering allows to do so). However, if the 
operator wants to remove the local storage ACS will throw an exception saying 
that the removal of local storage is not allowed.Therefore, if one wants to 
remove a local storage, he/she needs to do a manual intervention in the 
database and hosts.
   
   This limitation was removed as it was only a logical restriction.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Unable to remove local primary storage 
> ---
>
> Key: CLOUDSTACK-10214
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10214
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.10.0.0, 4.9.3.0
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>
> When enabling the use of local storage ACS will automatically load all local 
> storage configured in the Host and start using them as primary storage to 
> deploy user VMs (if the service offering allows to do so). However, if the 
> operator wants to remove the local storage ACS will throw an exception saying 
> that the removal of local storage is not allowed.Therefore, if one wants to 
> remove a local storage, he/she needs to do a manual intervention in the 
> database and hosts.
> This limitation was removed, as it was only a logical restriction.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (CLOUDSTACK-10214) Unable to remove local primary storage

[JIRA]

 [ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rafael Weingärtner updated CLOUDSTACK-10214:

Description: 
When enabling the use of local storage ACS will automatically load all local 
storage configured in the Host and start using them as primary storage to 
deploy user VMs (if the service offering allows to do so). However, if the 
operator wants to remove the local storage ACS will throw an exception saying 
that the removal of local storage is not allowed.Therefore, if one wants to 
remove a local storage, he/she needs to do a manual intervention in the 
database and hosts.

This limitation was removed, as it was only a logical restriction.

  was:When enabling the use of local storage ACS will automatically load all 
local storage configured in the Host and start using them as primary storage to 
deploy user VMs (if the service offering allows to do so). However, if the 
operator wants to remove the local storage ACS will throw an exception saying 
that the removal of local storage is not allowed.Therefore, if one wants to 
remove a local storage, he/she needs to do a manual intervention in the 
database and hosts.


> Unable to remove local primary storage 
> ---
>
> Key: CLOUDSTACK-10214
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10214
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.10.0.0, 4.9.3.0
>Reporter: Rafael Weingärtner
>Assignee: Rafael Weingärtner
>
> When enabling the use of local storage ACS will automatically load all local 
> storage configured in the Host and start using them as primary storage to 
> deploy user VMs (if the service offering allows to do so). However, if the 
> operator wants to remove the local storage ACS will throw an exception saying 
> that the removal of local storage is not allowed.Therefore, if one wants to 
> remove a local storage, he/she needs to do a manual intervention in the 
> database and hosts.
> This limitation was removed, as it was only a logical restriction.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10109) Enable dedication of public IPs to SSVM and CPVM

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313611#comment-16313611
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10109:
-

blueorangutan commented on issue #2295: CLOUDSTACK-10109: Enable dedication of 
public IPs to SSVM and CPVM
URL: https://github.com/apache/cloudstack/pull/2295#issuecomment-355629296
 
 
   Trillian test result (tid-2018)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 39590 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2295-t2018-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_accounts.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_affinity_groups_projects.py
   Intermitten failure detected: /marvin/tests/smoke/test_affinity_groups.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 64 look OK, 3 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestAccounts>:setup | `Error` | 0.00 | test_accounts.py
   ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 0.00 | 
test_accounts.py
   test_DeleteDomain | `Error` | 1.59 | test_accounts.py
   test_forceDeleteDomain | `Error` | 1.82 | test_accounts.py
   ContextSuite context=TestRemoveUserFromAccount>:setup | `Error` | 21.96 | 
test_accounts.py
   ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | 
test_affinity_groups_projects.py
   ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | 
test_affinity_groups.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Enable dedication of public IPs to SSVM and CPVM
> 
>
> Key: CLOUDSTACK-10109
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10109
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
> Attachments: public01.png, public02.png, public03.png
>
>
> It is required to dedicate a public IP range for SSVM and CPVM in order to 
> apply firewall rules to control inbound access.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9606) While IP address is released, tag are not deleted

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313612#comment-16313612
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9606:


blueorangutan commented on issue #1775: CLOUDSTACK-9606: While IP address is 
released, tag are not deleted.
URL: https://github.com/apache/cloudstack/pull/1775#issuecomment-355629383
 
 
   Trillian test result (tid-2019)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 39310 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1775-t2019-kvm-centos7.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Smoke tests completed. 66 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 
321.76 | test_routers_network_ops.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> While IP address is released, tag are not deleted
> -
>
> Key: CLOUDSTACK-9606
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9606
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Priyank Parihar
>Assignee: Priyank Parihar
>
> IP address release API call (disassociateIpAddress) does not have any 
> mechanism to remove the tags.
> All though the IP address is not allocated, corresponding tag still exists.
> REPRO STEPS
> ==
> 1. Acquire an IP address by Domain-Admin account A. 
> 2. Add tag to the target IP address by Domain-Admin account A. 
> 3. Release the target IP address without deleting the tag. 
> ⇒We found out that the state of the IP address is "Free" at this point, 
> but the tag which added by Domain-Admin account A still remains. 
> 4. Acquire the target IP address by Domain-Admin account B. 
> ⇒The tag still remains without change. 
> If account B tries to delete the tag, in our lab we can delete the tag as 
> domain admin. Although customer reported that they can't complete it because 
> of authority error.
> EXPECTED BEHAVIOR
> ==
> When we release an IP address, the corresponding tags should be removed from 
> related tables
> ACTUAL BEHAVIOR
> ==
> When we release an IP address, the corresponding tags are not removed from 
> related tables



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9892) Primary storage resource check is broken when using root disk size override to deploy VM

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313581#comment-16313581
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9892:


blueorangutan commented on issue #2088: CLOUDSTACK-9892: Primary storage 
resource check is broken when using …
URL: https://github.com/apache/cloudstack/pull/2088#issuecomment-355624229
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Primary storage resource check is broken when using root disk size override 
> to deploy VM
> 
>
> Key: CLOUDSTACK-9892
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9892
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.10.0.0
>Reporter: Koushik Das
>Assignee: Koushik Das
>Priority: Critical
> Fix For: 4.11.0.0
>
>
> Primary storage resource check for account/domain is broken when using root 
> disk size override to deploy VM



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (CLOUDSTACK-10214) Unable to remove local primary storage

[JIRA]

Rafael Weingärtner created CLOUDSTACK-10214:
---

 Summary: Unable to remove local primary storage 
 Key: CLOUDSTACK-10214
 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10214
 Project: CloudStack
  Issue Type: Bug
  Security Level: Public (Anyone can view this level - this is the default.)
Affects Versions: 4.10.0.0, 4.9.3.0
Reporter: Rafael Weingärtner
Assignee: Rafael Weingärtner


When enabling the use of local storage ACS will automatically load all local 
storage configured in the Host and start using them as primary storage to 
deploy user VMs (if the service offering allows to do so). However, if the 
operator wants to remove the local storage ACS will throw an exception saying 
that the removal of local storage is not allowed.Therefore, if one wants to 
remove a local storage, he/she needs to do a manual intervention in the 
database and hosts.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9892) Primary storage resource check is broken when using root disk size override to deploy VM

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313580#comment-16313580
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9892:


rhtyd commented on issue #2088: CLOUDSTACK-9892: Primary storage resource check 
is broken when using …
URL: https://github.com/apache/cloudstack/pull/2088#issuecomment-355624203
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Primary storage resource check is broken when using root disk size override 
> to deploy VM
> 
>
> Key: CLOUDSTACK-9892
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9892
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.10.0.0
>Reporter: Koushik Das
>Assignee: Koushik Das
>Priority: Critical
> Fix For: 4.11.0.0
>
>
> Primary storage resource check for account/domain is broken when using root 
> disk size override to deploy VM



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10087) Template registration errors out when template URL is https

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313578#comment-16313578
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10087:
-

rhtyd commented on a change in pull request #2271: CLOUDSTACK-10087 Template 
registration errors out when template URL i…
URL: https://github.com/apache/cloudstack/pull/2271#discussion_r159943124
 
 

 ##
 File path: systemvm/debian/opt/cloud/bin/setup/secstorage.sh
 ##
 @@ -80,10 +80,22 @@ CORS
   rm -f /etc/logrotate.d/cloud
 }
 
+import_jvm_cacerts(){
+ log_it "importing jvm keystore to realhostip keystore"
+ keyStore=/usr/local/cloud/systemvm/certs/realhostip.keystore
+ storepass="vmops.com"
+ java_home=$(readlink -f $(which java) | sed "s:/bin/java::")
+ java_keystore=$java_home/jre/lib/security/cacerts
 
 Review comment:
   Tested manually, the keystore path should be 
`$java_home/lib/security/cacerts` for 4.11/debian9 based systemvmtemplate. 
Also, consider using upper case variables such as `JAVA_HOME`, `JAVA_KEYSTORE` 
etc.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Template registration errors out when template URL is https
> ---
>
> Key: CLOUDSTACK-10087
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10087
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: sudharma jain
>
> *Management server logs:*
> 2017-08-23 08:55:36,706 DEBUG [c.c.a.t.Request] (AgentManager-Handler-5:null) 
> (logid:) Seq 4-7842174326135586819: Processing:  { Ans: , MgmtId: 4278190080, 
> via: 4, Ver: v1, Flags: 110, 
> [{"com.cloud.agent.api.Answer":{"result":false,"details":"com.amazonaws.SdkClientException:
>  Unable to execute HTTP request: sun.security.validator.ValidatorException: 
> PKIX path building failed: 
> sun.security.provider.certpath.SunCertPathBuilderException: unable to find 
> valid certification path to requested target\n\tat 
> com.amazonaws.http.AmazonHttpClient$RequestExecutor.executeHelper(AmazonHttpClient.java:972)\n\tat
>  
> com.amazonaws.http.AmazonHttpClient$RequestExecutor.doExecute(AmazonHttpClient.java:676)\n\tat
>  
> com.amazonaws.http.AmazonHttpClient$RequestExecutor.executeWithTimer(AmazonHttpClient.java:650)\n\tat
>  
> com.amazonaws.http.AmazonHttpClient$RequestExecutor.execute(AmazonHttpClient.java:633)\n\tat
>  
> com.amazonaws.http.AmazonHttpClient$RequestExecutor.access$300(AmazonHttpClient.java:601)\n\tat
>  
> com.amazonaws.http.AmazonHttpClient$RequestExecutionBuilderImpl.execute(AmazonHttpClient.java:583)\n\tat
>  com.amazonaws.http.AmazonHttpClient.execute(AmazonHttpClient.java:447)\n\tat 
> com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:4137)\n\tat
>  
> com.amazonaws.services.s3.AmazonS3Client.getBucketRegionViaHeadRequest(AmazonS3Client.java:4856)\n\tat
>  
> com.amazonaws.services.s3.AmazonS3Client.fetchRegionFromCache(AmazonS3Client.java:4830)\n\tat
>  
> com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:4122)\n\tat
>  
> com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:4079)\n\tat
>  
> com.amazonaws.services.s3.AmazonS3Client.listObjects(AmazonS3Client.java:819)\n\tat
>  com.cloud.utils.storage.S3.S3Utils.listDirectory(S3Utils.java:179)\n\tat 
> org.apache.cloudstack.storage.resource.NfsSecondaryStorageResource.s3ListVolume(NfsSecondaryStorageResource.java:1667)\n\tat
>  
> org.apache.cloudstack.storage.resource.NfsSecondaryStorageResource.execute(NfsSecondaryStorageResource.java:1721)\n\tat
>  
> org.apache.cloudstack.storage.resource.NfsSecondaryStorageResource.executeRequest(NfsSecondaryStorageResource.java:277)\n\tat
>  
> com.cloud.storage.resource.PremiumSecondaryStorageResource.defaultAction(PremiumSecondaryStorageResource.java:64)\n\tat
>  
> com.cloud.storage.resource.PremiumSecondaryStorageResource.executeRequest(PremiumSecondaryStorageResource.java:60)\n\tat
>  com.cloud.agent.Agent.processRequest(Agent.java:525)\n\tat 
> com.cloud.agent.Agent$AgentRequestHandler.doTask(Agent.java:833)\n\tat 
> com.cloud.utils.nio.Task.call(Task.java:83)\n\tat 
> com.cloud.utils.nio.Task.call(Task.java:29)\n\tat 
> java.util.concurrent.FutureTask.run(FutureTask.java:266)\n\tat 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)\n\tat
>  
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)\n\tat
>  java.lang.Thread.run(Thread.java:745)\nCaused by: 
> javax.net.ssl.SSLHandshakeException: 
> 

[jira] [Commented] (CLOUDSTACK-9892) Primary storage resource check is broken when using root disk size override to deploy VM

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313565#comment-16313565
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9892:


blueorangutan commented on issue #2088: CLOUDSTACK-9892: Primary storage 
resource check is broken when using …
URL: https://github.com/apache/cloudstack/pull/2088#issuecomment-355622271
 
 
   Trillian test result (tid-2020)
   Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 37542 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2088-t2020-xenserver-65sp1.zip
   Intermitten failure detected: /marvin/tests/smoke/test_accounts.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_affinity_groups_projects.py
   Intermitten failure detected: /marvin/tests/smoke/test_affinity_groups.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Smoke tests completed. 62 look OK, 5 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestAccounts>:setup | `Error` | 0.00 | test_accounts.py
   ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 0.00 | 
test_accounts.py
   test_DeleteDomain | `Error` | 1.41 | test_accounts.py
   test_forceDeleteDomain | `Error` | 1.37 | test_accounts.py
   ContextSuite context=TestRemoveUserFromAccount>:setup | `Error` | 21.77 | 
test_accounts.py
   ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | 
test_affinity_groups_projects.py
   ContextSuite context=TestDeployVmWithAffinityGroup>:setup | `Error` | 0.00 | 
test_affinity_groups.py
   test_02_edit_template | `Failure` | 90.08 | test_templates.py
   test_07_resize_fail | `Failure` | 40.59 | test_volumes.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Primary storage resource check is broken when using root disk size override 
> to deploy VM
> 
>
> Key: CLOUDSTACK-9892
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9892
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.10.0.0
>Reporter: Koushik Das
>Assignee: Koushik Das
>Priority: Critical
> Fix For: 4.11.0.0
>
>
> Primary storage resource check for account/domain is broken when using root 
> disk size override to deploy VM



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10213) Allow specify SSH key lengh

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313422#comment-16313422
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10213:
-

DaanHoogland commented on a change in pull request #2389: CLOUDSTACK-10213: 
Allow specify SSH key lengh
URL: https://github.com/apache/cloudstack/pull/2389#discussion_r159922500
 
 

 ##
 File path: server/src/com/cloud/server/ManagementServerImpl.java
 ##
 @@ -696,6 +696,8 @@
 
 static final ConfigKey vmPasswordLength = new 
ConfigKey("Advanced", Integer.class, "vm.password.length", "6",

   "Specifies the length of a randomly generated password", false);
+static final ConfigKey SSHKeyLength = new 
ConfigKey("Advanced", Integer.class, "ssh.key.length",
 
 Review comment:
   This configkey must be published in a getCofigKeys() implementations


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow specify SSH key lengh
> ---
>
> Key: CLOUDSTACK-10213
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10213
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Dmytro Shevchenko
>
> SSH keys generated by the ACS are only 1024 bit (RSA). The common standard is 
> now at least 2048 bit.
> decompiled com.jcraft.jsch.KeyPair:
> {code:java}
> public static KeyPair genKeyPair(JSch jsch, int type) throws 
> JSchException {
> return genKeyPair(jsch, type, 1024);
> }
> public static KeyPair genKeyPair(JSch jsch, int type, int key_size) 
> throws JSchException {
> KeyPair kpair = null;
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10087) Template registration errors out when template URL is https

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313417#comment-16313417
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10087:
-

rhtyd commented on issue #2271: CLOUDSTACK-10087 Template registration errors 
out when template URL i…
URL: https://github.com/apache/cloudstack/pull/2271#issuecomment-355602144
 
 
   Test LGTM. Given we've moved to debian9 systemvmtemplate, I'll merge only 
after a manual verification.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Template registration errors out when template URL is https
> ---
>
> Key: CLOUDSTACK-10087
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10087
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: sudharma jain
>
> *Management server logs:*
> 2017-08-23 08:55:36,706 DEBUG [c.c.a.t.Request] (AgentManager-Handler-5:null) 
> (logid:) Seq 4-7842174326135586819: Processing:  { Ans: , MgmtId: 4278190080, 
> via: 4, Ver: v1, Flags: 110, 
> [{"com.cloud.agent.api.Answer":{"result":false,"details":"com.amazonaws.SdkClientException:
>  Unable to execute HTTP request: sun.security.validator.ValidatorException: 
> PKIX path building failed: 
> sun.security.provider.certpath.SunCertPathBuilderException: unable to find 
> valid certification path to requested target\n\tat 
> com.amazonaws.http.AmazonHttpClient$RequestExecutor.executeHelper(AmazonHttpClient.java:972)\n\tat
>  
> com.amazonaws.http.AmazonHttpClient$RequestExecutor.doExecute(AmazonHttpClient.java:676)\n\tat
>  
> com.amazonaws.http.AmazonHttpClient$RequestExecutor.executeWithTimer(AmazonHttpClient.java:650)\n\tat
>  
> com.amazonaws.http.AmazonHttpClient$RequestExecutor.execute(AmazonHttpClient.java:633)\n\tat
>  
> com.amazonaws.http.AmazonHttpClient$RequestExecutor.access$300(AmazonHttpClient.java:601)\n\tat
>  
> com.amazonaws.http.AmazonHttpClient$RequestExecutionBuilderImpl.execute(AmazonHttpClient.java:583)\n\tat
>  com.amazonaws.http.AmazonHttpClient.execute(AmazonHttpClient.java:447)\n\tat 
> com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:4137)\n\tat
>  
> com.amazonaws.services.s3.AmazonS3Client.getBucketRegionViaHeadRequest(AmazonS3Client.java:4856)\n\tat
>  
> com.amazonaws.services.s3.AmazonS3Client.fetchRegionFromCache(AmazonS3Client.java:4830)\n\tat
>  
> com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:4122)\n\tat
>  
> com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:4079)\n\tat
>  
> com.amazonaws.services.s3.AmazonS3Client.listObjects(AmazonS3Client.java:819)\n\tat
>  com.cloud.utils.storage.S3.S3Utils.listDirectory(S3Utils.java:179)\n\tat 
> org.apache.cloudstack.storage.resource.NfsSecondaryStorageResource.s3ListVolume(NfsSecondaryStorageResource.java:1667)\n\tat
>  
> org.apache.cloudstack.storage.resource.NfsSecondaryStorageResource.execute(NfsSecondaryStorageResource.java:1721)\n\tat
>  
> org.apache.cloudstack.storage.resource.NfsSecondaryStorageResource.executeRequest(NfsSecondaryStorageResource.java:277)\n\tat
>  
> com.cloud.storage.resource.PremiumSecondaryStorageResource.defaultAction(PremiumSecondaryStorageResource.java:64)\n\tat
>  
> com.cloud.storage.resource.PremiumSecondaryStorageResource.executeRequest(PremiumSecondaryStorageResource.java:60)\n\tat
>  com.cloud.agent.Agent.processRequest(Agent.java:525)\n\tat 
> com.cloud.agent.Agent$AgentRequestHandler.doTask(Agent.java:833)\n\tat 
> com.cloud.utils.nio.Task.call(Task.java:83)\n\tat 
> com.cloud.utils.nio.Task.call(Task.java:29)\n\tat 
> java.util.concurrent.FutureTask.run(FutureTask.java:266)\n\tat 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)\n\tat
>  
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)\n\tat
>  java.lang.Thread.run(Thread.java:745)\nCaused by: 
> javax.net.ssl.SSLHandshakeException: 
> sun.security.validator.ValidatorException: PKIX path building failed: 
> sun.security.provider.certpath.SunCertPathBuilderException: unable to find 
> valid certification path to requested target\n\tat 
> sun.security.ssl.Alerts.getSSLException(Alerts.java:192)\n\tat 
> sun.security.ssl.SSLSocketImpl.fatal(SSLSocketImpl.java:1949)\n\tat 
> sun.security.ssl.Handshaker.fatalSE(Handshaker.java:302)\n\tat 
> sun.security.ssl.Handshaker.fatalSE(Handshaker.java:296)\n\tat 
> sun.security.ssl.ClientHandshaker.serverCertificate(ClientHandshaker.java:1509)\n\tat
>  
> 

[jira] [Commented] (CLOUDSTACK-10104) Optimize database transactions in ListDomain API to improve performance

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313409#comment-16313409
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10104:
-

DaanHoogland commented on a change in pull request #2282: 
CLOUDSTACK-10104:Optimize database transactions in ListDomain API to improve 
performance
URL: https://github.com/apache/cloudstack/pull/2282#discussion_r159820728
 
 

 ##
 File path: api/src/com/cloud/user/ResourceLimitService.java
 ##
 @@ -104,6 +104,14 @@
  */
 public long findCorrectResourceLimitForDomain(Domain domain, ResourceType 
type);
 
+/**
+ * Finds the default resource limit for a specified type.
+ *
+ * @param resourceType
 
 Review comment:
   it is self explanatory. no +or- 1 but this tag is not useful


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Optimize database transactions in ListDomain API to improve performance
> ---
>
> Key: CLOUDSTACK-10104
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10104
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Reporter: Pranali Mande
>
> While creating the response object for the 'listDomain' API, several database 
> calls are triggered to fetch details like parent domain, project limit, IP 
> limit, etc. These database calls are triggered for each record found for in 
> the main fetch query, which is causing the response to slow down. The 
> database transactions could be optimized to reduce the response time of the 
> Listdomain API



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10104) Optimize database transactions in ListDomain API to improve performance

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313410#comment-16313410
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10104:
-

DaanHoogland commented on a change in pull request #2282: 
CLOUDSTACK-10104:Optimize database transactions in ListDomain API to improve 
performance
URL: https://github.com/apache/cloudstack/pull/2282#discussion_r159821325
 
 

 ##
 File path: server/src/com/cloud/api/query/QueryManagerImpl.java
 ##
 @@ -1901,9 +1900,10 @@
 Long domainId = cmd.getId();
 boolean listAll = cmd.listAll();
 boolean isRecursive = false;
+Domain domain = null;
 
 if (domainId != null) {
-Domain domain = _domainDao.findById(domainId);
+domain = _domainDao.findById(domainId);
 
 Review comment:
   :)  


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Optimize database transactions in ListDomain API to improve performance
> ---
>
> Key: CLOUDSTACK-10104
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10104
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Reporter: Pranali Mande
>
> While creating the response object for the 'listDomain' API, several database 
> calls are triggered to fetch details like parent domain, project limit, IP 
> limit, etc. These database calls are triggered for each record found for in 
> the main fetch query, which is causing the response to slow down. The 
> database transactions could be optimized to reduce the response time of the 
> Listdomain API



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10104) Optimize database transactions in ListDomain API to improve performance

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313411#comment-16313411
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10104:
-

DaanHoogland commented on a change in pull request #2282: 
CLOUDSTACK-10104:Optimize database transactions in ListDomain API to improve 
performance
URL: https://github.com/apache/cloudstack/pull/2282#discussion_r159821175
 
 

 ##
 File path: server/src/com/cloud/api/query/QueryManagerImpl.java
 ##
 @@ -1890,8 +1890,7 @@
 respView = ResponseView.Full;
 }
 
-List domainResponses = 
ViewResponseHelper.createDomainResponse(respView, cmd.getDetails(), 
result.first().toArray(
-new DomainJoinVO[result.first().size()]));
+List domainResponses = 
ViewResponseHelper.createDomainResponse(respView, cmd.getDetails(), 
result.first());
 
 Review comment:
   aren't we changing the API semantics here?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Optimize database transactions in ListDomain API to improve performance
> ---
>
> Key: CLOUDSTACK-10104
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10104
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Reporter: Pranali Mande
>
> While creating the response object for the 'listDomain' API, several database 
> calls are triggered to fetch details like parent domain, project limit, IP 
> limit, etc. These database calls are triggered for each record found for in 
> the main fetch query, which is causing the response to slow down. The 
> database transactions could be optimized to reduce the response time of the 
> Listdomain API



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10087) Template registration errors out when template URL is https

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313393#comment-16313393
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10087:
-

blueorangutan commented on issue #2271: CLOUDSTACK-10087 Template registration 
errors out when template URL i…
URL: https://github.com/apache/cloudstack/pull/2271#issuecomment-355600368
 
 
   Trillian test result (tid-2023)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 29895 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2271-t2023-kvm-centos7.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 67 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Template registration errors out when template URL is https
> ---
>
> Key: CLOUDSTACK-10087
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10087
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: sudharma jain
>
> *Management server logs:*
> 2017-08-23 08:55:36,706 DEBUG [c.c.a.t.Request] (AgentManager-Handler-5:null) 
> (logid:) Seq 4-7842174326135586819: Processing:  { Ans: , MgmtId: 4278190080, 
> via: 4, Ver: v1, Flags: 110, 
> [{"com.cloud.agent.api.Answer":{"result":false,"details":"com.amazonaws.SdkClientException:
>  Unable to execute HTTP request: sun.security.validator.ValidatorException: 
> PKIX path building failed: 
> sun.security.provider.certpath.SunCertPathBuilderException: unable to find 
> valid certification path to requested target\n\tat 
> com.amazonaws.http.AmazonHttpClient$RequestExecutor.executeHelper(AmazonHttpClient.java:972)\n\tat
>  
> com.amazonaws.http.AmazonHttpClient$RequestExecutor.doExecute(AmazonHttpClient.java:676)\n\tat
>  
> com.amazonaws.http.AmazonHttpClient$RequestExecutor.executeWithTimer(AmazonHttpClient.java:650)\n\tat
>  
> com.amazonaws.http.AmazonHttpClient$RequestExecutor.execute(AmazonHttpClient.java:633)\n\tat
>  
> com.amazonaws.http.AmazonHttpClient$RequestExecutor.access$300(AmazonHttpClient.java:601)\n\tat
>  
> com.amazonaws.http.AmazonHttpClient$RequestExecutionBuilderImpl.execute(AmazonHttpClient.java:583)\n\tat
>  com.amazonaws.http.AmazonHttpClient.execute(AmazonHttpClient.java:447)\n\tat 
> com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:4137)\n\tat
>  
> com.amazonaws.services.s3.AmazonS3Client.getBucketRegionViaHeadRequest(AmazonS3Client.java:4856)\n\tat
>  
> com.amazonaws.services.s3.AmazonS3Client.fetchRegionFromCache(AmazonS3Client.java:4830)\n\tat
>  
> com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:4122)\n\tat
>  
> com.amazonaws.services.s3.AmazonS3Client.invoke(AmazonS3Client.java:4079)\n\tat
>  
> com.amazonaws.services.s3.AmazonS3Client.listObjects(AmazonS3Client.java:819)\n\tat
>  com.cloud.utils.storage.S3.S3Utils.listDirectory(S3Utils.java:179)\n\tat 
> org.apache.cloudstack.storage.resource.NfsSecondaryStorageResource.s3ListVolume(NfsSecondaryStorageResource.java:1667)\n\tat
>  
> org.apache.cloudstack.storage.resource.NfsSecondaryStorageResource.execute(NfsSecondaryStorageResource.java:1721)\n\tat
>  
> org.apache.cloudstack.storage.resource.NfsSecondaryStorageResource.executeRequest(NfsSecondaryStorageResource.java:277)\n\tat
>  
> com.cloud.storage.resource.PremiumSecondaryStorageResource.defaultAction(PremiumSecondaryStorageResource.java:64)\n\tat
>  
> com.cloud.storage.resource.PremiumSecondaryStorageResource.executeRequest(PremiumSecondaryStorageResource.java:60)\n\tat
>  com.cloud.agent.Agent.processRequest(Agent.java:525)\n\tat 
> com.cloud.agent.Agent$AgentRequestHandler.doTask(Agent.java:833)\n\tat 
> com.cloud.utils.nio.Task.call(Task.java:83)\n\tat 
> com.cloud.utils.nio.Task.call(Task.java:29)\n\tat 
> java.util.concurrent.FutureTask.run(FutureTask.java:266)\n\tat 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)\n\tat
>  
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)\n\tat
>  java.lang.Thread.run(Thread.java:745)\nCaused by: 
> javax.net.ssl.SSLHandshakeException: 
> 

[jira] [Commented] (CLOUDSTACK-10213) Allow specify SSH key lengh

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313388#comment-16313388
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10213:
-

rhtyd commented on a change in pull request #2389: CLOUDSTACK-10213: Allow 
specify SSH key lengh
URL: https://github.com/apache/cloudstack/pull/2389#discussion_r159916996
 
 

 ##
 File path: server/src/com/cloud/configuration/Config.java
 ##
 @@ -1027,6 +1027,14 @@
 "5",
 "Incorrect login attempts allowed before the user is disabled",
 null),
+SSHKeyLength(
 
 Review comment:
   Please remove from here, this is deprecated. The use of ConfigKey is alright.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow specify SSH key lengh
> ---
>
> Key: CLOUDSTACK-10213
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10213
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Dmytro Shevchenko
>
> SSH keys generated by the ACS are only 1024 bit (RSA). The common standard is 
> now at least 2048 bit.
> decompiled com.jcraft.jsch.KeyPair:
> {code:java}
> public static KeyPair genKeyPair(JSch jsch, int type) throws 
> JSchException {
> return genKeyPair(jsch, type, 1024);
> }
> public static KeyPair genKeyPair(JSch jsch, int type, int key_size) 
> throws JSchException {
> KeyPair kpair = null;
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10212) Changing IPv4 Address of NIC in Basic Networking does not update the gateway

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313387#comment-16313387
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10212:
-

rhtyd commented on issue #2388: CLOUDSTACK-10212: Update Netmask/Gateway when 
Changing IPv4 address
URL: https://github.com/apache/cloudstack/pull/2388#issuecomment-355597692
 
 
   @wido can you check unit test/build failures from travis:
   ```
   Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.015 sec - 
in com.cloud.keystore.KeystoreTest
   Results :
   Tests in error: 
 UserVmManagerTest.testUpdateVmNicIpSuccess2:854 » NullPointer
   
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Changing IPv4 Address of NIC in Basic Networking does not update the gateway
> 
>
> Key: CLOUDSTACK-10212
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10212
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Network Controller
>Affects Versions: 4.10.0.0
> Environment: CloudStack 4.10 - KVM - Basic Networking
>Reporter: Wido den Hollander
>Assignee: Wido den Hollander
> Fix For: 4.11.0.0
>
>
> When using updateVMNic to change the IPv4 address of a NIC the IPv4 address 
> is changed, but the Gateway stays the same.
> This can cause problems when multiple IPv4 ranges are used and a wrong 
> gateway is issued to the Instance through DHCP.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10212) Changing IPv4 Address of NIC in Basic Networking does not update the gateway

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313386#comment-16313386
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10212:
-

rhtyd commented on issue #2388: CLOUDSTACK-10212: Update Netmask/Gateway when 
Changing IPv4 address
URL: https://github.com/apache/cloudstack/pull/2388#issuecomment-355597531
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Changing IPv4 Address of NIC in Basic Networking does not update the gateway
> 
>
> Key: CLOUDSTACK-10212
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10212
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Network Controller
>Affects Versions: 4.10.0.0
> Environment: CloudStack 4.10 - KVM - Basic Networking
>Reporter: Wido den Hollander
>Assignee: Wido den Hollander
> Fix For: 4.11.0.0
>
>
> When using updateVMNic to change the IPv4 address of a NIC the IPv4 address 
> is changed, but the Gateway stays the same.
> This can cause problems when multiple IPv4 ranges are used and a wrong 
> gateway is issued to the Instance through DHCP.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-7931) Setting Null for global network throttling params doesn't trigger suitable error, fails silently

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-7931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313385#comment-16313385
 ] 

ASF subversion and git services commented on CLOUDSTACK-7931:
-

Commit b16dcb7174cc493efc92f0960a8cac1d59c11b67 in cloudstack's branch 
refs/heads/master from [~sudharmaj]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=b16dcb7 ]

CLOUDSTACK-10096 Can't reset integration.api.port and 
usage.sanity.check.interval (#2274)

Fix for CLOUDSTACK-7931 enforces a valid integer value to be configured for 
integration.api.port and usage.sanity.check.interval. These global configs 
can't be reset back to null(default).

> Setting Null for global network throttling params doesn't trigger suitable 
> error, fails silently
> 
>
> Key: CLOUDSTACK-7931
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-7931
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
>Priority: Critical
> Fix For: 4.5.0
>
>
> Set global configs network.throttling.rate and vm.network.throttling.rate to 
> NULL value.
> Then launch VM in a new network
> Result
> =
> VM fails to launch but it fails without any ERROR logs or suitable exceptions.
> A corresponding INFO log seems to have nothing but "null"
> Generally, for few global configs NULL is an acceptable value in some cases. 
> If this is not the case, then we should not allow to set such a value for the 
> config. The API should error out suitably. This is one issue.
> Further, it should throw an appropriate error when the deploy VM fails to 
> design network. The error in this case is not handled suitably and there's 
> nothing in ERROR logs as well.
> Looking at the below logs, it's impossible to figure out the reason for the 
> failure of deploy VM. So at some point, if a user inadvertently sets it to 
> NULL, neither does the updateConfiguration API result in error nor does the 
> deployVirtualMachine throw a suitable error.
> Here's the log:
> 2014-11-13 13:29:15,584 DEBUG [c.c.a.ApiServlet] 
> (catalina-exec-18:ctx-285ce7d9) ===START=== 10.144.7.5 – GET 
> command=createNetwork=json=6ZKk3l0f4pdKU1yfDZxwF31YgCM%3D=e8746c6b-e945-4084-9290-37cea253e262=newtest1=newtest1=b642a92a-3480-4818-99bf-6546a28df624&_=1415866216789
> 2014-11-13 13:29:15,617 DEBUG [o.a.c.n.c.m.ContrailGuru] 
> (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) Refusing to design this network
> 2014-11-13 13:29:15,617 DEBUG [c.c.n.g.MidoNetGuestNetworkGuru] 
> (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) design called
> 2014-11-13 13:29:15,618 DEBUG [c.c.n.g.MidoNetGuestNetworkGuru] 
> (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) Refusing to design this network, 
> the physical isolation type is not MIDO
> 2014-11-13 13:29:15,619 DEBUG [c.c.n.g.NiciraNvpGuestNetworkGuru] 
> (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) Refusing to design this network
> 2014-11-13 13:29:15,620 DEBUG [o.a.c.n.o.OpendaylightGuestNetworkGuru] 
> (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) Refusing to design this network
> 2014-11-13 13:29:15,621 DEBUG [c.c.n.g.OvsGuestNetworkGuru] 
> (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) Refusing to design this network
> 2014-11-13 13:29:15,644 DEBUG [o.a.c.n.g.SspGuestNetworkGuru] 
> (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) SSP not configured to be active
> 2014-11-13 13:29:15,645 DEBUG [c.c.n.g.BrocadeVcsGuestNetworkGuru] 
> (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) Refusing to design this network
> 2014-11-13 13:29:15,646 DEBUG [c.c.n.g.NuageVspGuestNetworkGuru] 
> (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) Refusing to design this network
> 2014-11-13 13:29:15,648 DEBUG [o.a.c.e.o.NetworkOrchestrator] 
> (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) Releasing lock for 
> Acct[467a4f66-698f-11e4-be18-42407779c24b-admin]
> 2014-11-13 13:29:15,688 DEBUG [c.c.a.ApiServlet] 
> (catalina-exec-18:ctx-285ce7d9 ctx-5245ccb7) ===END=== 10.144.7.5 – GET 
> command=createNetwork=json=6ZKk3l0f4pdKU1yfDZxwF31YgCM%3D=e8746c6b-e945-4084-9290-37cea253e262=newtest1=newtest1=b642a92a-3480-4818-99bf-6546a28df624&_=1415866216789
> 2014-11-13 13:29:15,727 DEBUG [c.c.a.ApiServlet] 
> (catalina-exec-9:ctx-54781545) ===START=== 10.144.7.5 – GET 
> command=deployVirtualMachine=json=6ZKk3l0f4pdKU1yfDZxwF31YgCM%3D=b642a92a-3480-4818-99bf-6546a28df624=f7df5ef0-698e-11e4-be18-42407779c24b=XenServer=04840780-04d0-4b41-847a-dda08ad460f4%5B0%5D.networkid=c0e24f7a-fe03-4a3b-a11e-ab29150b803b=throttlingvm1=throttlingvm1&_=1415866216945
> 2014-11-13 13:29:15,753 DEBUG [c.c.n.NetworkModelImpl] 
> (catalina-exec-9:ctx-54781545 ctx-e87f4810) Service SecurityGroup is not 
> 

[jira] [Commented] (CLOUDSTACK-10096) Can't reset api.integration.port and usage.sanity.check.interval back to null

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313383#comment-16313383
 ] 

ASF subversion and git services commented on CLOUDSTACK-10096:
--

Commit b16dcb7174cc493efc92f0960a8cac1d59c11b67 in cloudstack's branch 
refs/heads/master from [~sudharmaj]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=b16dcb7 ]

CLOUDSTACK-10096 Can't reset integration.api.port and 
usage.sanity.check.interval (#2274)

Fix for CLOUDSTACK-7931 enforces a valid integer value to be configured for 
integration.api.port and usage.sanity.check.interval. These global configs 
can't be reset back to null(default).

> Can't reset api.integration.port and usage.sanity.check.interval back to null
> -
>
> Key: CLOUDSTACK-10096
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10096
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: sudharma jain
>
> Fix for CLOUDSTACK-7931 enforces a value to be configured for 
> api.integration.port and usage.sanity.check.interval. These global configs 
> can't be reset back to null(default). 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10096) Can't reset api.integration.port and usage.sanity.check.interval back to null

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313382#comment-16313382
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10096:
-

rhtyd closed pull request #2274: CLOUDSTACK-10096 Can't reset 
integration.api.port and usage.sanity.ch…
URL: https://github.com/apache/cloudstack/pull/2274
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/server/src/com/cloud/api/ApiServer.java 
b/server/src/com/cloud/api/ApiServer.java
index 9e237741c96..fdabd8c765d 100644
--- a/server/src/com/cloud/api/ApiServer.java
+++ b/server/src/com/cloud/api/ApiServer.java
@@ -336,6 +336,7 @@ public boolean start() {
 final ConfigurationVO apiPortConfig = values.get(0);
 if (apiPortConfig.getValue() != null) {
 apiPort = Integer.parseInt(apiPortConfig.getValue());
+apiPort = (apiPort <= 0) ? null : apiPort;
 }
 }
 
diff --git a/server/src/com/cloud/configuration/Config.java 
b/server/src/com/cloud/configuration/Config.java
index bc8272a1b79..a8e24a47806 100644
--- a/server/src/com/cloud/configuration/Config.java
+++ b/server/src/com/cloud/configuration/Config.java
@@ -562,7 +562,7 @@
 "The interval (in milliseconds) when host stats are retrieved from 
agents.",
 null),
 HostRetry("Advanced", AgentManager.class, Integer.class, "host.retry", 
"2", "Number of times to retry hosts for creating a volume", null),
-IntegrationAPIPort("Advanced", ManagementServer.class, Integer.class, 
"integration.api.port", null, "Default API port", null),
+IntegrationAPIPort("Advanced", ManagementServer.class, Integer.class, 
"integration.api.port", null, "Default API port. To disable set it to 0 or 
negative.", null),
 InvestigateRetryInterval(
 "Advanced",
 HighAvailabilityManager.class,
@@ -1276,7 +1276,7 @@
 Integer.class,
 "usage.sanity.check.interval",
 null,
-"Interval (in days) to check sanity of usage data",
+"Interval (in days) to check sanity of usage data. To disable set 
it to 0 or negative.",
 null),
 UsageAggregationTimezone("Usage", ManagementServer.class, String.class, 
"usage.aggregation.timezone", "GMT", "The timezone to use for usage stats 
aggregation", null),
 TrafficSentinelIncludeZones(


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Can't reset api.integration.port and usage.sanity.check.interval back to null
> -
>
> Key: CLOUDSTACK-10096
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10096
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: sudharma jain
>
> Fix for CLOUDSTACK-7931 enforces a value to be configured for 
> api.integration.port and usage.sanity.check.interval. These global configs 
> can't be reset back to null(default). 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10096) Can't reset api.integration.port and usage.sanity.check.interval back to null

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313380#comment-16313380
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10096:
-

rhtyd commented on issue #2274: CLOUDSTACK-10096 Can't reset 
integration.api.port and usage.sanity.ch…
URL: https://github.com/apache/cloudstack/pull/2274#issuecomment-355596859
 
 
   LGTM and tests LGTM. Merging this based on code reviews and test results.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Can't reset api.integration.port and usage.sanity.check.interval back to null
> -
>
> Key: CLOUDSTACK-10096
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10096
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: sudharma jain
>
> Fix for CLOUDSTACK-7931 enforces a value to be configured for 
> api.integration.port and usage.sanity.check.interval. These global configs 
> can't be reset back to null(default). 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10104) Optimize database transactions in ListDomain API to improve performance

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313378#comment-16313378
 ] 

ASF subversion and git services commented on CLOUDSTACK-10104:
--

Commit 5fad84174a199f798396fcacedae2c56bdcc2bba in cloudstack's branch 
refs/heads/master from [~pranalim]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=5fad841 ]

CLOUDSTACK-10104: Optimize database transactions in ListDomain API to improve 
performance (#2282)

While creating the response object for the 'listDomain' API, several database 
calls are triggered to fetch details like parent domain, project limit, IP 
limit, etc. These database calls are triggered for each record found in the 
main fetch query, which is causing the response to slow down.

Fix:
The database transactions are reduced to improve response of the Listdomain API

> Optimize database transactions in ListDomain API to improve performance
> ---
>
> Key: CLOUDSTACK-10104
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10104
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Reporter: Pranali Mande
>
> While creating the response object for the 'listDomain' API, several database 
> calls are triggered to fetch details like parent domain, project limit, IP 
> limit, etc. These database calls are triggered for each record found for in 
> the main fetch query, which is causing the response to slow down. The 
> database transactions could be optimized to reduce the response time of the 
> Listdomain API



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10104) Optimize database transactions in ListDomain API to improve performance

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313376#comment-16313376
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10104:
-

rhtyd commented on issue #2282: CLOUDSTACK-10104:Optimize database transactions 
in ListDomain API to improve performance
URL: https://github.com/apache/cloudstack/pull/2282#issuecomment-355596606
 
 
   Merging this based on code reviews and test results.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Optimize database transactions in ListDomain API to improve performance
> ---
>
> Key: CLOUDSTACK-10104
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10104
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: API
>Reporter: Pranali Mande
>
> While creating the response object for the 'listDomain' API, several database 
> calls are triggered to fetch details like parent domain, project limit, IP 
> limit, etc. These database calls are triggered for each record found for in 
> the main fetch query, which is causing the response to slow down. The 
> database transactions could be optimized to reduce the response time of the 
> Listdomain API



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10104) Optimize database transactions in ListDomain API to improve performance

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313377#comment-16313377
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10104:
-

rhtyd closed pull request #2282: CLOUDSTACK-10104:Optimize database 
transactions in ListDomain API to improve performance
URL: https://github.com/apache/cloudstack/pull/2282
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/api/src/com/cloud/user/ResourceLimitService.java 
b/api/src/com/cloud/user/ResourceLimitService.java
index 0ec2dc1c758..aee2e1515e5 100644
--- a/api/src/com/cloud/user/ResourceLimitService.java
+++ b/api/src/com/cloud/user/ResourceLimitService.java
@@ -104,6 +104,14 @@
  */
 public long findCorrectResourceLimitForDomain(Domain domain, ResourceType 
type);
 
+/**
+ * Finds the default resource limit for a specified type.
+ *
+ * @param resourceType
+ * @return resource limit
+ */
+public long findDefaultResourceLimitForDomain(ResourceType resourceType);
+
 /**
  * Increments the resource count
  *
diff --git a/server/src/com/cloud/api/ApiDBUtils.java 
b/server/src/com/cloud/api/ApiDBUtils.java
index 9f67aa748f5..22ed2437d4d 100644
--- a/server/src/com/cloud/api/ApiDBUtils.java
+++ b/server/src/com/cloud/api/ApiDBUtils.java
@@ -867,6 +867,15 @@ public static long findCorrectResourceLimit(Long limit, 
long accountId, Resource
 return 
s_resourceLimitMgr.findCorrectResourceLimitForAccount(accountId, limit, type);
 }
 
+public static long findCorrectResourceLimitForDomain(Long limit, 
ResourceType resourceType, long domainId) {
+//-- No limits for Root domain
+if (domainId == Domain.ROOT_DOMAIN) {
+return Resource.RESOURCE_UNLIMITED;
+}
+//--If limit doesn't have a value then fetch default limit from the 
configs
+return (limit == null) ? 
s_resourceLimitMgr.findDefaultResourceLimitForDomain(resourceType) : limit;
+}
+
 public static long getResourceCount(ResourceType type, long accountId) {
 AccountVO account = s_accountDao.findById(accountId);
 
@@ -981,6 +990,10 @@ public static DomainVO findDomainById(Long domainId) {
 return s_domainDao.findByIdIncludingRemoved(domainId);
 }
 
+public static DomainJoinVO findDomainJoinVOById(Long domainId) {
+return s_domainJoinDao.findByIdIncludingRemoved(domainId);
+}
+
 public static DomainVO findDomainByIdIncludingRemoved(Long domainId) {
 return s_domainDao.findByIdIncludingRemoved(domainId);
 }
diff --git a/server/src/com/cloud/api/query/QueryManagerImpl.java 
b/server/src/com/cloud/api/query/QueryManagerImpl.java
index 2a6919bcf71..1c9890f2269 100644
--- a/server/src/com/cloud/api/query/QueryManagerImpl.java
+++ b/server/src/com/cloud/api/query/QueryManagerImpl.java
@@ -1890,8 +1890,7 @@
 respView = ResponseView.Full;
 }
 
-List domainResponses = 
ViewResponseHelper.createDomainResponse(respView, cmd.getDetails(), 
result.first().toArray(
-new DomainJoinVO[result.first().size()]));
+List domainResponses = 
ViewResponseHelper.createDomainResponse(respView, cmd.getDetails(), 
result.first());
 response.setResponses(domainResponses, result.second());
 return response;
 }
@@ -1901,9 +1900,10 @@
 Long domainId = cmd.getId();
 boolean listAll = cmd.listAll();
 boolean isRecursive = false;
+Domain domain = null;
 
 if (domainId != null) {
-Domain domain = _domainDao.findById(domainId);
+domain = _domainDao.findById(domainId);
 if (domain == null) {
 throw new InvalidParameterValueException("Domain id=" + 
domainId + " doesn't exist");
 }
@@ -1947,7 +1947,10 @@
 
 if (domainId != null) {
 if (isRecursive) {
-sc.setParameters("path", 
_domainDao.findById(domainId).getPath() + "%");
+if(domain == null){
+domain = _domainDao.findById(domainId);
+}
+sc.setParameters("path", domain.getPath() + "%");
 } else {
 sc.setParameters("id", domainId);
 }
diff --git a/server/src/com/cloud/api/query/ViewResponseHelper.java 
b/server/src/com/cloud/api/query/ViewResponseHelper.java
index 11af5a9e760..940ae288c42 100644
--- a/server/src/com/cloud/api/query/ViewResponseHelper.java
+++ b/server/src/com/cloud/api/query/ViewResponseHelper.java
@@ -18,11 +18,16 @@
 
 import java.text.DecimalFormat;
 import java.util.ArrayList;
+import java.util.Collections;
 import java.util.EnumSet;
+import 

[jira] [Commented] (CLOUDSTACK-10109) Enable dedication of public IPs to SSVM and CPVM

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313370#comment-16313370
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10109:
-

borisstoyanov commented on issue #2295: CLOUDSTACK-10109: Enable dedication of 
public IPs to SSVM and CPVM
URL: https://github.com/apache/cloudstack/pull/2295#issuecomment-355595693
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Enable dedication of public IPs to SSVM and CPVM
> 
>
> Key: CLOUDSTACK-10109
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10109
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
> Attachments: public01.png, public02.png, public03.png
>
>
> It is required to dedicate a public IP range for SSVM and CPVM in order to 
> apply firewall rules to control inbound access.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10109) Enable dedication of public IPs to SSVM and CPVM

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313371#comment-16313371
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10109:
-

blueorangutan commented on issue #2295: CLOUDSTACK-10109: Enable dedication of 
public IPs to SSVM and CPVM
URL: https://github.com/apache/cloudstack/pull/2295#issuecomment-355595795
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Enable dedication of public IPs to SSVM and CPVM
> 
>
> Key: CLOUDSTACK-10109
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10109
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
> Attachments: public01.png, public02.png, public03.png
>
>
> It is required to dedicate a public IP range for SSVM and CPVM in order to 
> apply firewall rules to control inbound access.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10109) Enable dedication of public IPs to SSVM and CPVM

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313360#comment-16313360
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10109:
-

blueorangutan commented on issue #2295: CLOUDSTACK-10109: Enable dedication of 
public IPs to SSVM and CPVM
URL: https://github.com/apache/cloudstack/pull/2295#issuecomment-355593733
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1599


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Enable dedication of public IPs to SSVM and CPVM
> 
>
> Key: CLOUDSTACK-10109
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10109
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
> Attachments: public01.png, public02.png, public03.png
>
>
> It is required to dedicate a public IP range for SSVM and CPVM in order to 
> apply firewall rules to control inbound access.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10109) Enable dedication of public IPs to SSVM and CPVM

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313330#comment-16313330
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10109:
-

borisstoyanov commented on issue #2295: CLOUDSTACK-10109: Enable dedication of 
public IPs to SSVM and CPVM
URL: https://github.com/apache/cloudstack/pull/2295#issuecomment-355585828
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Enable dedication of public IPs to SSVM and CPVM
> 
>
> Key: CLOUDSTACK-10109
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10109
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
> Attachments: public01.png, public02.png, public03.png
>
>
> It is required to dedicate a public IP range for SSVM and CPVM in order to 
> apply firewall rules to control inbound access.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10109) Enable dedication of public IPs to SSVM and CPVM

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313334#comment-16313334
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10109:
-

blueorangutan commented on issue #2295: CLOUDSTACK-10109: Enable dedication of 
public IPs to SSVM and CPVM
URL: https://github.com/apache/cloudstack/pull/2295#issuecomment-355585969
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Enable dedication of public IPs to SSVM and CPVM
> 
>
> Key: CLOUDSTACK-10109
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10109
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
> Attachments: public01.png, public02.png, public03.png
>
>
> It is required to dedicate a public IP range for SSVM and CPVM in order to 
> apply firewall rules to control inbound access.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10213) Allow specify SSH key lengh

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313319#comment-16313319
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10213:
-

dmytro-shevchenko opened a new pull request #2389: CLOUDSTACK-10213: Allow 
specify SSH key lengh
URL: https://github.com/apache/cloudstack/pull/2389
 
 
   SSH keys generated by the ACS are only 1024 bit (RSA). The common standard 
is now at least 2048 bit.
   https://issues.apache.org/jira/browse/CLOUDSTACK-10213


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow specify SSH key lengh
> ---
>
> Key: CLOUDSTACK-10213
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10213
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Dmytro Shevchenko
>
> SSH keys generated by the ACS are only 1024 bit (RSA). The common standard is 
> now at least 2048 bit.
> decompiled com.jcraft.jsch.KeyPair:
> {code:java}
> public static KeyPair genKeyPair(JSch jsch, int type) throws 
> JSchException {
> return genKeyPair(jsch, type, 1024);
> }
> public static KeyPair genKeyPair(JSch jsch, int type, int key_size) 
> throws JSchException {
> KeyPair kpair = null;
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (CLOUDSTACK-10213) Allow specify SSH key lengh

[Dmytro Shevchenko (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dmytro Shevchenko updated CLOUDSTACK-10213:
---
Description: 
SSH keys generated by the ACS are only 1024 bit (RSA). The common standard is 
now at least 2048 bit.

decompiled com.jcraft.jsch.KeyPair:

{code:java}
public static KeyPair genKeyPair(JSch jsch, int type) throws JSchException {
return genKeyPair(jsch, type, 1024);
}

public static KeyPair genKeyPair(JSch jsch, int type, int key_size) throws 
JSchException {
KeyPair kpair = null;

{code}


  was:SSH keys generated by the ACS are only 1024 bit (RSA). The common 
standard is now at least 2048 bit.


> Allow specify SSH key lengh
> ---
>
> Key: CLOUDSTACK-10213
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10213
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Dmytro Shevchenko
>
> SSH keys generated by the ACS are only 1024 bit (RSA). The common standard is 
> now at least 2048 bit.
> decompiled com.jcraft.jsch.KeyPair:
> {code:java}
> public static KeyPair genKeyPair(JSch jsch, int type) throws 
> JSchException {
> return genKeyPair(jsch, type, 1024);
> }
> public static KeyPair genKeyPair(JSch jsch, int type, int key_size) 
> throws JSchException {
> KeyPair kpair = null;
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (CLOUDSTACK-10213) Allow specify SSH key lengh

[Dmytro Shevchenko (JIRA)]

Dmytro Shevchenko created CLOUDSTACK-10213:
--

 Summary: Allow specify SSH key lengh
 Key: CLOUDSTACK-10213
 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10213
 Project: CloudStack
  Issue Type: Improvement
  Security Level: Public (Anyone can view this level - this is the default.)
Reporter: Dmytro Shevchenko


SSH keys generated by the ACS are only 1024 bit (RSA). The common standard is 
now at least 2048 bit.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9025) Unable to deploy VM instance from template if template spin from linked clone snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313283#comment-16313283
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9025:


borisstoyanov commented on issue #2315: A comprehensive solution for 
CLOUDSTACK-9025 and CLOUDSTACK-10128.
URL: https://github.com/apache/cloudstack/pull/2315#issuecomment-355579421
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Unable to deploy VM instance from template if template spin from linked clone 
> snapshot
> --
>
> Key: CLOUDSTACK-9025
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9025
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: XenServer
>Affects Versions: 4.5.2
> Environment: XenServer 6.5
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
>Priority: Critical
> Fix For: 4.6.0
>
>
> As default, CloudStack create linked clone snapshot for VM instance . When we 
> take a snapshot for the VM, and create a template based on such snapshot, 
> CloudStack only download incremental VHD as template file, as a result, the 
> VM instance fail to deploy as it is incomplete.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10096) Can't reset api.integration.port and usage.sanity.check.interval back to null

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313286#comment-16313286
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10096:
-

blueorangutan commented on issue #2274: CLOUDSTACK-10096 Can't reset 
integration.api.port and usage.sanity.ch…
URL: https://github.com/apache/cloudstack/pull/2274#issuecomment-355579630
 
 
   Trillian test result (tid-2015)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 33911 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2274-t2015-kvm-centos7.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Smoke tests completed. 67 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Can't reset api.integration.port and usage.sanity.check.interval back to null
> -
>
> Key: CLOUDSTACK-10096
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10096
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: sudharma jain
>
> Fix for CLOUDSTACK-7931 enforces a value to be configured for 
> api.integration.port and usage.sanity.check.interval. These global configs 
> can't be reset back to null(default). 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9025) Unable to deploy VM instance from template if template spin from linked clone snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313285#comment-16313285
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9025:


blueorangutan commented on issue #2315: A comprehensive solution for 
CLOUDSTACK-9025 and CLOUDSTACK-10128.
URL: https://github.com/apache/cloudstack/pull/2315#issuecomment-355579571
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Unable to deploy VM instance from template if template spin from linked clone 
> snapshot
> --
>
> Key: CLOUDSTACK-9025
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9025
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: XenServer
>Affects Versions: 4.5.2
> Environment: XenServer 6.5
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
>Priority: Critical
> Fix For: 4.6.0
>
>
> As default, CloudStack create linked clone snapshot for VM instance . When we 
> take a snapshot for the VM, and create a template based on such snapshot, 
> CloudStack only download incremental VHD as template file, as a result, the 
> VM instance fail to deploy as it is incomplete.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313130#comment-16313130
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

rafaelweingartner commented on a change in pull request #2379: 
CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159878648
 
 

 ##
 File path: 
agent/src/com/cloud/agent/direct/download/DirectTemplateDownloaderImpl.java
 ##
 @@ -0,0 +1,188 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+package com.cloud.agent.direct.download;
+
+import com.cloud.utils.exception.CloudRuntimeException;
+import com.cloud.utils.script.Script;
+import org.apache.cloudstack.utils.security.ChecksumValue;
+import org.apache.commons.lang.StringUtils;
+
+import java.io.File;
+import java.util.UUID;
+
+public abstract class DirectTemplateDownloaderImpl implements 
DirectTemplateDownloader {
+
+private String url;
+private String destPoolPath;
+private Long templateId;
+private String downloadedFilePath;
+private String installPath;
+private String checksum;
+
+protected DirectTemplateDownloaderImpl(final String url, final String 
destPoolPath, final Long templateId, final String checksum) {
+this.url = url;
+this.destPoolPath = destPoolPath;
+this.templateId = templateId;
+this.checksum = checksum;
+}
+
+private static String directDownloadDir = "template";
+
+/**
+ * Return direct download temporary path to download template
+ * @param templateId
+ * @return
+ */
+protected static String getDirectDownloadTempPath(Long templateId) {
+String templateIdAsString = String.valueOf(templateId);
+return directDownloadDir + File.separator + 
templateIdAsString.substring(0,1) +
+File.separator + templateIdAsString;
+}
+
+/**
+ * Create folder on path if it does not exist
+ * @param path
 
 Review comment:
   @param can be removed from here


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313131#comment-16313131
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

rafaelweingartner commented on a change in pull request #2379: 
CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159879369
 
 

 ##
 File path: 
agent/src/com/cloud/agent/direct/download/HttpDirectTemplateDownloader.java
 ##
 @@ -0,0 +1,136 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.agent.direct.download;
+
+import org.apache.commons.collections.MapUtils;
+import org.apache.commons.httpclient.HttpClient;
+import org.apache.commons.httpclient.HttpMethod;
+import org.apache.commons.httpclient.HttpMethodRetryHandler;
+import org.apache.commons.httpclient.MultiThreadedHttpConnectionManager;
+import org.apache.commons.httpclient.NoHttpResponseException;
+import org.apache.commons.httpclient.methods.GetMethod;
+import org.apache.commons.httpclient.params.HttpMethodParams;
+import org.apache.log4j.Logger;
+
+import java.io.File;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.RandomAccessFile;
+import java.util.Map;
+
+public class HttpDirectTemplateDownloader extends DirectTemplateDownloaderImpl 
{
+
+private HttpClient client;
+private static final MultiThreadedHttpConnectionManager 
s_httpClientManager = new MultiThreadedHttpConnectionManager();
+private static final int CHUNK_SIZE = 1024 * 1024; //1M
+protected HttpMethodRetryHandler myretryhandler;
+public static final Logger s_logger = 
Logger.getLogger(HttpDirectTemplateDownloader.class.getName());
+protected GetMethod request;
+
+public HttpDirectTemplateDownloader(String url, Long templateId, String 
destPoolPath, String checksum, Map headers) {
+super(url, destPoolPath, templateId, checksum);
+client = new HttpClient(s_httpClientManager);
+myretryhandler = createRetryTwiceHandler();
+request = createRequest(url, headers);
+String downloadDir = getDirectDownloadTempPath(templateId);
+createTemporaryDirectoryAndFile(downloadDir);
+}
+
+protected void createTemporaryDirectoryAndFile(String downloadDir) {
+createFolder(getDestPoolPath() + File.separator + downloadDir);
+File f = new File(getDestPoolPath() + File.separator + downloadDir + 
File.separator + getFileNameFromUrl());
+setDownloadedFilePath(f.getAbsolutePath());
+}
+
+protected GetMethod createRequest(String downloadUrl, Map 
headers) {
+GetMethod request = new GetMethod(downloadUrl);
+request.getParams().setParameter(HttpMethodParams.RETRY_HANDLER, 
myretryhandler);
+request.setFollowRedirects(true);
+if (MapUtils.isNotEmpty(headers)) {
+for (String key : headers.keySet()) {
+request.setRequestHeader(key, headers.get(key));
+}
+}
+return request;
+}
+
+protected HttpMethodRetryHandler createRetryTwiceHandler() {
+return new HttpMethodRetryHandler() {
+@Override
+public boolean retryMethod(final HttpMethod method, final 
IOException exception, int executionCount) {
+if (executionCount >= 2) {
+// Do not retry if over max retry count
+return false;
+}
+if (exception instanceof NoHttpResponseException) {
+// Retry if the server dropped connection on us
+return true;
+}
+if (!method.isRequestSent()) {
+// Retry if the request has not been sent fully or
+// if it's OK to retry methods that have been sent
+return true;
+}
+// otherwise do not retry
+return false;
+}
+};
+}
+
+@Override
+public boolean downloadTemplate() {
+File f = new File(getDownloadedFilePath());
+

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313129#comment-16313129
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

rafaelweingartner commented on a change in pull request #2379: 
CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159878537
 
 

 ##
 File path: agent/src/com/cloud/agent/Agent.java
 ##
 @@ -600,6 +608,47 @@ protected void processRequest(final Request request, 
final Link link) {
 }
 }
 
+private Answer 
setupDirectDownloadCertificate(SetupDirectDownloadCertificate cmd) {
+String certificate = cmd.getCertificate();
+String certificateName = cmd.getCertificateName();
+s_logger.info("Importing certificate " + certificateName + " into 
keystore");
+
+final File agentFile = 
PropertiesUtil.findConfigFile("agent.properties");
+if (agentFile == null) {
+return new Answer(cmd, false, "Failed to find agent.properties 
file");
+}
+
+final String keyStoreFile = agentFile.getParent() + "/" + 
KeyStoreUtils.defaultKeystoreFile;
 
 Review comment:
   I agree. You can do that, or you can do everything in Java (reading and 
writing files). 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313128#comment-16313128
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

rafaelweingartner commented on a change in pull request #2379: 
CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159878621
 
 

 ##
 File path: 
agent/src/com/cloud/agent/direct/download/DirectTemplateDownloaderImpl.java
 ##
 @@ -0,0 +1,188 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+package com.cloud.agent.direct.download;
+
+import com.cloud.utils.exception.CloudRuntimeException;
+import com.cloud.utils.script.Script;
+import org.apache.cloudstack.utils.security.ChecksumValue;
+import org.apache.commons.lang.StringUtils;
+
+import java.io.File;
+import java.util.UUID;
+
+public abstract class DirectTemplateDownloaderImpl implements 
DirectTemplateDownloader {
+
+private String url;
+private String destPoolPath;
+private Long templateId;
+private String downloadedFilePath;
+private String installPath;
+private String checksum;
+
+protected DirectTemplateDownloaderImpl(final String url, final String 
destPoolPath, final Long templateId, final String checksum) {
+this.url = url;
+this.destPoolPath = destPoolPath;
+this.templateId = templateId;
+this.checksum = checksum;
+}
+
+private static String directDownloadDir = "template";
+
+/**
+ * Return direct download temporary path to download template
+ * @param templateId
 
 Review comment:
   @param and @return can be removed from here


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313122#comment-16313122
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

nvazquez commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass 
Secondary Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159878781
 
 

 ##
 File path: agent/src/com/cloud/agent/Agent.java
 ##
 @@ -600,6 +608,47 @@ protected void processRequest(final Request request, 
final Link link) {
 }
 }
 
+private Answer 
setupDirectDownloadCertificate(SetupDirectDownloadCertificate cmd) {
+String certificate = cmd.getCertificate();
+String certificateName = cmd.getCertificateName();
+s_logger.info("Importing certificate " + certificateName + " into 
keystore");
+
+final File agentFile = 
PropertiesUtil.findConfigFile("agent.properties");
+if (agentFile == null) {
+return new Answer(cmd, false, "Failed to find agent.properties 
file");
+}
+
+final String keyStoreFile = agentFile.getParent() + "/" + 
KeyStoreUtils.defaultKeystoreFile;
 
 Review comment:
   Yes, I prefer using this java approach for those that can be done instead of 
using a script file. If you prefer I can refactor it to a script file


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313120#comment-16313120
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

nvazquez commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass 
Secondary Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159878184
 
 

 ##
 File path: scripts/vm/hypervisor/kvm/setup_agent.sh
 ##
 @@ -224,5 +224,17 @@ then
 setenforce 0
 fi
 
+which aria2c
+if [ $? -gt 0 ]
+then
+yum install epel-release -y
+yum install aria2 -y
 
 Review comment:
   I also added it on cloud.spec, should I remove it from here then?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313119#comment-16313119
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

nvazquez commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary Storage 
for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-37598
 
 
   Thanks @rafaelweingartner @rhtyd, I had pushed a refactor commit after your 
comments


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9025) Unable to deploy VM instance from template if template spin from linked clone snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313094#comment-16313094
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9025:


blueorangutan commented on issue #2315: A comprehensive solution for 
CLOUDSTACK-9025 and CLOUDSTACK-10128.
URL: https://github.com/apache/cloudstack/pull/2315#issuecomment-33470
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1598


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Unable to deploy VM instance from template if template spin from linked clone 
> snapshot
> --
>
> Key: CLOUDSTACK-9025
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9025
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: XenServer
>Affects Versions: 4.5.2
> Environment: XenServer 6.5
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
>Priority: Critical
> Fix For: 4.6.0
>
>
> As default, CloudStack create linked clone snapshot for VM instance . When we 
> take a snapshot for the VM, and create a template based on such snapshot, 
> CloudStack only download incremental VHD as template file, as a result, the 
> VM instance fail to deploy as it is incomplete.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313091#comment-16313091
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

nvazquez commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass 
Secondary Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159874143
 
 

 ##
 File path: 
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/TemplateInfo.java
 ##
 @@ -25,4 +25,6 @@
 String getUniqueName();
 
 String getInstallPath();
+
+boolean isDirectDownload();
 
 Review comment:
   Thanks


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (CLOUDSTACK-10212) Changing IPv4 Address of NIC in Basic Networking does not update the gateway

[Wido den Hollander (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wido den Hollander updated CLOUDSTACK-10212:

Component/s: Network Controller

> Changing IPv4 Address of NIC in Basic Networking does not update the gateway
> 
>
> Key: CLOUDSTACK-10212
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10212
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Network Controller
>Affects Versions: 4.10.0.0
> Environment: CloudStack 4.10 - KVM - Basic Networking
>Reporter: Wido den Hollander
>Assignee: Wido den Hollander
> Fix For: 4.11.0.0
>
>
> When using updateVMNic to change the IPv4 address of a NIC the IPv4 address 
> is changed, but the Gateway stays the same.
> This can cause problems when multiple IPv4 ranges are used and a wrong 
> gateway is issued to the Instance through DHCP.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (CLOUDSTACK-10212) Changing IPv4 Address of NIC in Basic Networking does not update the gateway

[Wido den Hollander (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wido den Hollander updated CLOUDSTACK-10212:

Fix Version/s: 4.11.0.0

> Changing IPv4 Address of NIC in Basic Networking does not update the gateway
> 
>
> Key: CLOUDSTACK-10212
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10212
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Network Controller
>Affects Versions: 4.10.0.0
> Environment: CloudStack 4.10 - KVM - Basic Networking
>Reporter: Wido den Hollander
>Assignee: Wido den Hollander
> Fix For: 4.11.0.0
>
>
> When using updateVMNic to change the IPv4 address of a NIC the IPv4 address 
> is changed, but the Gateway stays the same.
> This can cause problems when multiple IPv4 ranges are used and a wrong 
> gateway is issued to the Instance through DHCP.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (CLOUDSTACK-10212) Changing IPv4 Address of NIC in Basic Networking does not update the gateway

[Wido den Hollander (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wido den Hollander updated CLOUDSTACK-10212:

Affects Version/s: 4.10.0.0

> Changing IPv4 Address of NIC in Basic Networking does not update the gateway
> 
>
> Key: CLOUDSTACK-10212
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10212
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Network Controller
>Affects Versions: 4.10.0.0
> Environment: CloudStack 4.10 - KVM - Basic Networking
>Reporter: Wido den Hollander
>Assignee: Wido den Hollander
> Fix For: 4.11.0.0
>
>
> When using updateVMNic to change the IPv4 address of a NIC the IPv4 address 
> is changed, but the Gateway stays the same.
> This can cause problems when multiple IPv4 ranges are used and a wrong 
> gateway is issued to the Instance through DHCP.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9025) Unable to deploy VM instance from template if template spin from linked clone snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313076#comment-16313076
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9025:


rafaelweingartner commented on a change in pull request #2315: A comprehensive 
solution for CLOUDSTACK-9025 and CLOUDSTACK-10128.
URL: https://github.com/apache/cloudstack/pull/2315#discussion_r159873055
 
 

 ##
 File path: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/XenServerGuru.java
 ##
 @@ -167,35 +170,62 @@ public boolean trackVmHostChange() {
 
 @Override
 public Pair getCommandHostDelegation(long hostId, Command 
cmd) {
 
 Review comment:
   Yes you are right!
   I have seen people counting the return as a point for the final metric; but, 
I am not sure yet if they count or not. In my view the decision point is in the 
conditional that enabled the return to be executed and not in the return per se.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Unable to deploy VM instance from template if template spin from linked clone 
> snapshot
> --
>
> Key: CLOUDSTACK-9025
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9025
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: XenServer
>Affects Versions: 4.5.2
> Environment: XenServer 6.5
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
>Priority: Critical
> Fix For: 4.6.0
>
>
> As default, CloudStack create linked clone snapshot for VM instance . When we 
> take a snapshot for the VM, and create a template based on such snapshot, 
> CloudStack only download incremental VHD as template file, as a result, the 
> VM instance fail to deploy as it is incomplete.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10212) Changing IPv4 Address of NIC in Basic Networking does not update the gateway

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313073#comment-16313073
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10212:
-

wido opened a new pull request #2388: CLOUDSTACK-10212: Update Netmask/Gateway 
when Changing IPv4 address
URL: https://github.com/apache/cloudstack/pull/2388
 
 
   This can otherwise cause problems in Basic Networking where multiple
   IPv4 ranges are configured in a POD.
   
   Signed-off-by: Wido den Hollander 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Changing IPv4 Address of NIC in Basic Networking does not update the gateway
> 
>
> Key: CLOUDSTACK-10212
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10212
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
> Environment: CloudStack 4.10 - KVM - Basic Networking
>Reporter: Wido den Hollander
>Assignee: Wido den Hollander
>
> When using updateVMNic to change the IPv4 address of a NIC the IPv4 address 
> is changed, but the Gateway stays the same.
> This can cause problems when multiple IPv4 ranges are used and a wrong 
> gateway is issued to the Instance through DHCP.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9889) Dedicate guest vlan range to a domain

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313074#comment-16313074
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9889:


DaanHoogland commented on issue #2102: CLOUDSTACK-9889 Dedication of guest vlan 
range to a domain
URL: https://github.com/apache/cloudstack/pull/2102#issuecomment-31494
 
 
   ticket added for the disk problems: 
https://issues.apache.org/jira/browse/INFRA-15793 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Dedicate guest vlan  range to a domain
> --
>
> Key: CLOUDSTACK-9889
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9889
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: subhash yedugundla
>
> List of scenarios covered
> *Dedication of guest Vlan range*
> Admin should be allowed dedicate guest vlan ranges to a domain
> While dedicating a guest Vlan range
> If the range overlaps with any of the existing dedicated range then extend 
> the existing dedicated range
> Otherwise add it as a new dedicated guest Vlan range
> If the range doesn’t exist in the system then the request should fail
> If any of the vlan in the range is in use by a network that belongs to a 
> different account of different domain then the request should fail
> *Releasing guest Vlan range*
> Admin should be allowed to release a dedicated guest vlan range that is 
> dedicated to a domain back to the system pool
> If the range is not dedicated to the domain then the request should fail
> Even If one/more of the Vlans belonging to the range is in use by a network 
> the range should be released back to the system pool
>  The vlans that are in use should continue to be in use by the network
> *Network implementation*
> If the network belongs to an account that has a dedicated range of Vlans then 
> a Vlan from the account's dedicated range should be allocated to the network
> If an account uses up all of its dedicated Vlan’s the next network being 
> created for the account should be assigned a Vlan that belongs to the domain 
> pool
> Otherwise, a Vlan should be allocated from the free pool i.e. Vlan range 
> belonging to the zone
> *Network creation*
> If a Vlan id is specified and if this id belongs to a dedicated Vlan range of 
> a different account/domain then the creation should fail
> If a Vlan id is specified and if this id belongs to the system pool but the 
> network owner has a range of dedicated range of vlans then the creation 
> should fail
> *Domain deletion*
> Guest Ip ranges and vlans dedicated to the domain should be released back to 
> the free pool 
> *Account deletion*
> When an account is deleted, the IP ranges and vlans associated with the 
> account  should be moved to system pool.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9025) Unable to deploy VM instance from template if template spin from linked clone snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313066#comment-16313066
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9025:


DaanHoogland commented on a change in pull request #2315: A comprehensive 
solution for CLOUDSTACK-9025 and CLOUDSTACK-10128.
URL: https://github.com/apache/cloudstack/pull/2315#discussion_r159871814
 
 

 ##
 File path: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/XenServerGuru.java
 ##
 @@ -167,35 +170,62 @@ public boolean trackVmHostChange() {
 
 @Override
 public Pair getCommandHostDelegation(long hostId, Command 
cmd) {
 
 Review comment:
   all the conditional returns compensate more then fully the complexity of the 
nested conditionals, so i think the complexity grew. But of course you are 
right and we should actually measure (lazy mode on - quickly)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Unable to deploy VM instance from template if template spin from linked clone 
> snapshot
> --
>
> Key: CLOUDSTACK-9025
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9025
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: XenServer
>Affects Versions: 4.5.2
> Environment: XenServer 6.5
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
>Priority: Critical
> Fix For: 4.6.0
>
>
> As default, CloudStack create linked clone snapshot for VM instance . When we 
> take a snapshot for the VM, and create a template based on such snapshot, 
> CloudStack only download incremental VHD as template file, as a result, the 
> VM instance fail to deploy as it is incomplete.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9025) Unable to deploy VM instance from template if template spin from linked clone snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313051#comment-16313051
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9025:


blueorangutan commented on issue #2315: A comprehensive solution for 
CLOUDSTACK-9025 and CLOUDSTACK-10128.
URL: https://github.com/apache/cloudstack/pull/2315#issuecomment-355548394
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Unable to deploy VM instance from template if template spin from linked clone 
> snapshot
> --
>
> Key: CLOUDSTACK-9025
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9025
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: XenServer
>Affects Versions: 4.5.2
> Environment: XenServer 6.5
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
>Priority: Critical
> Fix For: 4.6.0
>
>
> As default, CloudStack create linked clone snapshot for VM instance . When we 
> take a snapshot for the VM, and create a template based on such snapshot, 
> CloudStack only download incremental VHD as template file, as a result, the 
> VM instance fail to deploy as it is incomplete.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9025) Unable to deploy VM instance from template if template spin from linked clone snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313048#comment-16313048
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9025:


rafaelweingartner commented on issue #2315: A comprehensive solution for 
CLOUDSTACK-9025 and CLOUDSTACK-10128.
URL: https://github.com/apache/cloudstack/pull/2315#issuecomment-355548163
 
 
   @rhtyd conflicts solved


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Unable to deploy VM instance from template if template spin from linked clone 
> snapshot
> --
>
> Key: CLOUDSTACK-9025
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9025
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: XenServer
>Affects Versions: 4.5.2
> Environment: XenServer 6.5
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
>Priority: Critical
> Fix For: 4.6.0
>
>
> As default, CloudStack create linked clone snapshot for VM instance . When we 
> take a snapshot for the VM, and create a template based on such snapshot, 
> CloudStack only download incremental VHD as template file, as a result, the 
> VM instance fail to deploy as it is incomplete.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9025) Unable to deploy VM instance from template if template spin from linked clone snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313049#comment-16313049
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9025:


rhtyd commented on issue #2315: A comprehensive solution for CLOUDSTACK-9025 
and CLOUDSTACK-10128.
URL: https://github.com/apache/cloudstack/pull/2315#issuecomment-355548279
 
 
   @blueorangutan package 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Unable to deploy VM instance from template if template spin from linked clone 
> snapshot
> --
>
> Key: CLOUDSTACK-9025
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9025
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: XenServer
>Affects Versions: 4.5.2
> Environment: XenServer 6.5
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
>Priority: Critical
> Fix For: 4.6.0
>
>
> As default, CloudStack create linked clone snapshot for VM instance . When we 
> take a snapshot for the VM, and create a template based on such snapshot, 
> CloudStack only download incremental VHD as template file, as a result, the 
> VM instance fail to deploy as it is incomplete.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9025) Unable to deploy VM instance from template if template spin from linked clone snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313041#comment-16313041
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9025:


rafaelweingartner commented on a change in pull request #2315: A comprehensive 
solution for CLOUDSTACK-9025 and CLOUDSTACK-10128.
URL: https://github.com/apache/cloudstack/pull/2315#discussion_r159868750
 
 

 ##
 File path: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/XenServerGuru.java
 ##
 @@ -167,35 +170,62 @@ public boolean trackVmHostChange() {
 
 @Override
 public Pair getCommandHostDelegation(long hostId, Command 
cmd) {
 
 Review comment:
   Actually, it depends on how you count. Normally you would need to build a 
decision graph to calculate. However, the most import thing in my opinion is 
the removal of 3/4 conditionals one inside the other. And More specifically 
this block:
   ```
   if (hypervisorVersion != null && 
!hypervisorVersion.equalsIgnoreCase("6.1.0")) {
   -if (!(hypervisorVersion.equalsIgnoreCase("6.2.0") &&
   -!(snapshotHotFixVersion != null && 
snapshotHotFixVersion.equalsIgnoreCase(XenserverConfigs.XSHotFix62ESP1004 {
   -return new Pair(Boolean.TRUE, 
new Long(host.getId()));
   -}
   -}
   
   
   Those negations altogether do not compute well in my mind...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Unable to deploy VM instance from template if template spin from linked clone 
> snapshot
> --
>
> Key: CLOUDSTACK-9025
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9025
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: XenServer
>Affects Versions: 4.5.2
> Environment: XenServer 6.5
>Reporter: Anshul Gangwar
>Assignee: Anshul Gangwar
>Priority: Critical
> Fix For: 4.6.0
>
>
> As default, CloudStack create linked clone snapshot for VM instance . When we 
> take a snapshot for the VM, and create a template based on such snapshot, 
> CloudStack only download incremental VHD as template file, as a result, the 
> VM instance fail to deploy as it is incomplete.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9620) Improvements for Managed Storage

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313025#comment-16313025
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9620:


rafaelweingartner commented on issue #2298: CLOUDSTACK-9620: Enhancements for 
managed storage
URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-355543496
 
 
   @DaanHoogland comfortable I am not. However, this is an interesting feature; 
and I understand how hard it is to create and maintain something like (conflict 
may happen...). If everything is working and tests passing, I would be ok with 
it.
   
   One thing we must keep in mind though. We need to start looking for better 
code (code for people). I know that it was like this before and @mike-tutkowski 
is only working on top of it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Improvements for Managed Storage
> 
>
> Key: CLOUDSTACK-9620
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9620
> Project: CloudStack
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: KVM, Management Server, VMware, XenServer
>Affects Versions: 4.11.0.0
> Environment: KVM, vSphere, and XenServer
>Reporter: Mike Tutkowski
>Assignee: Mike Tutkowski
> Fix For: 4.11.0.0
>
>
> Allowed zone-wide primary storage based on a custom plug-in to be added via 
> the GUI in a KVM-only environment (previously this only worked for XenServer 
> and VMware)
> Added support for root disks on managed storage with KVM
> Added support for volume snapshots with managed storage on KVM
> Enabled creating a template directly from a volume (i.e. without having to go 
> through a volume snapshot) on KVM with managed storage
> Only allowed the resizing of a volume for managed storage on KVM if the 
> volume in question is either not attached to a VM or is attached to a VM in 
> the Stopped state
> Included support for Reinstall VM on KVM with managed storage
> Enabled offline migration on KVM from non-managed storage to managed storage 
> and vice versa
> Included support for online storage migration on KVM with managed storage 
> (NFS and Ceph to managed storage)
> Added support to download (extract) a managed-storage volume to a QCOW2 file
> When uploading a file from outside of CloudStack to CloudStack, set the min 
> and max IOPS, if applicable.
> Included support for the KVM auto-convergence feature
> The compression flag was actually added in version 1.0.3 (103) as opposed 
> to version 1.3.0 (1003000) (changed this to reflect the correct version)
> On KVM when using iSCSI-based managed storage, if the user shuts a VM down 
> from the guest OS (as opposed to doing so from CloudStack), we need to pass 
> to the KVM agent a list of applicable iSCSI volumes that need to be 
> disconnected.
> Added a new Global Setting: kvm.storage.live.migration.wait
> For XenServer, added a check to enforce that only volumes from zone-wide 
> managed storage can be storage motioned from a host in one cluster to a host 
> in another cluster (cannot do so at the time being with volumes from 
> cluster-scoped managed storage)
> Don’t allow Storage XenMotion on a VM that has any managed-storage volume 
> with one or more snapshots.
> Enabled for managed storage with VMware: Template caching, create snapshot, 
> delete snapshot, create volume from snapshot, and create template from 
> snapshot
> Added an SIOC API plug-in to support VMware SIOC
> When starting a VM that uses managed storage in a cluster other than the one 
> it last was running in, we need to remove the reference to the iSCSI volume 
> from the original cluster.
> Added the ability to revert a volume to a snapshot
> Enabled cluster-scoped managed storage
> Added support for VMware dynamic discovery



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313019#comment-16313019
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

rafaelweingartner commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355542658
 
 
   @nvazquez I believe you addressed almost everything. From my check there are 
still the following question in files:
   agent/src/com/cloud/agent/direct/download/NfsDirectTemplateDownloader.java 
   engine/orchestration/pom.xml 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9889) Dedicate guest vlan range to a domain

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313017#comment-16313017
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9889:


blueorangutan commented on issue #2102: CLOUDSTACK-9889 Dedication of guest 
vlan range to a domain
URL: https://github.com/apache/cloudstack/pull/2102#issuecomment-355541012
 
 
   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Dedicate guest vlan  range to a domain
> --
>
> Key: CLOUDSTACK-9889
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9889
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: subhash yedugundla
>
> List of scenarios covered
> *Dedication of guest Vlan range*
> Admin should be allowed dedicate guest vlan ranges to a domain
> While dedicating a guest Vlan range
> If the range overlaps with any of the existing dedicated range then extend 
> the existing dedicated range
> Otherwise add it as a new dedicated guest Vlan range
> If the range doesn’t exist in the system then the request should fail
> If any of the vlan in the range is in use by a network that belongs to a 
> different account of different domain then the request should fail
> *Releasing guest Vlan range*
> Admin should be allowed to release a dedicated guest vlan range that is 
> dedicated to a domain back to the system pool
> If the range is not dedicated to the domain then the request should fail
> Even If one/more of the Vlans belonging to the range is in use by a network 
> the range should be released back to the system pool
>  The vlans that are in use should continue to be in use by the network
> *Network implementation*
> If the network belongs to an account that has a dedicated range of Vlans then 
> a Vlan from the account's dedicated range should be allocated to the network
> If an account uses up all of its dedicated Vlan’s the next network being 
> created for the account should be assigned a Vlan that belongs to the domain 
> pool
> Otherwise, a Vlan should be allocated from the free pool i.e. Vlan range 
> belonging to the zone
> *Network creation*
> If a Vlan id is specified and if this id belongs to a dedicated Vlan range of 
> a different account/domain then the creation should fail
> If a Vlan id is specified and if this id belongs to the system pool but the 
> network owner has a range of dedicated range of vlans then the creation 
> should fail
> *Domain deletion*
> Guest Ip ranges and vlans dedicated to the domain should be released back to 
> the free pool 
> *Account deletion*
> When an account is deleted, the IP ranges and vlans associated with the 
> account  should be moved to system pool.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-9889) Dedicate guest vlan range to a domain

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313016#comment-16313016
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9889:


DaanHoogland commented on issue #2102: CLOUDSTACK-9889 Dedication of guest vlan 
range to a domain
URL: https://github.com/apache/cloudstack/pull/2102#issuecomment-355540845
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Dedicate guest vlan  range to a domain
> --
>
> Key: CLOUDSTACK-9889
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9889
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: subhash yedugundla
>
> List of scenarios covered
> *Dedication of guest Vlan range*
> Admin should be allowed dedicate guest vlan ranges to a domain
> While dedicating a guest Vlan range
> If the range overlaps with any of the existing dedicated range then extend 
> the existing dedicated range
> Otherwise add it as a new dedicated guest Vlan range
> If the range doesn’t exist in the system then the request should fail
> If any of the vlan in the range is in use by a network that belongs to a 
> different account of different domain then the request should fail
> *Releasing guest Vlan range*
> Admin should be allowed to release a dedicated guest vlan range that is 
> dedicated to a domain back to the system pool
> If the range is not dedicated to the domain then the request should fail
> Even If one/more of the Vlans belonging to the range is in use by a network 
> the range should be released back to the system pool
>  The vlans that are in use should continue to be in use by the network
> *Network implementation*
> If the network belongs to an account that has a dedicated range of Vlans then 
> a Vlan from the account's dedicated range should be allocated to the network
> If an account uses up all of its dedicated Vlan’s the next network being 
> created for the account should be assigned a Vlan that belongs to the domain 
> pool
> Otherwise, a Vlan should be allocated from the free pool i.e. Vlan range 
> belonging to the zone
> *Network creation*
> If a Vlan id is specified and if this id belongs to a dedicated Vlan range of 
> a different account/domain then the creation should fail
> If a Vlan id is specified and if this id belongs to the system pool but the 
> network owner has a range of dedicated range of vlans then the creation 
> should fail
> *Domain deletion*
> Guest Ip ranges and vlans dedicated to the domain should be released back to 
> the free pool 
> *Account deletion*
> When an account is deleted, the IP ranges and vlans associated with the 
> account  should be moved to system pool.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313007#comment-16313007
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355539932
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1597


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-8855) Improve Error Message for Host Alert State

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313006#comment-16313006
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8855:


blueorangutan commented on issue #2387: CLOUDSTACK-8855 Improve Error Message 
for Host Alert State and reconnect host API.
URL: https://github.com/apache/cloudstack/pull/2387#issuecomment-355539933
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1596


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Improve Error Message for Host Alert State
> --
>
> Key: CLOUDSTACK-8855
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8855
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.6.0
>Reporter: Bharat Kumar
>Assignee: Bharat Kumar
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10117) LDAP mapping on domain level

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313000#comment-16313000
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10117:
-

blueorangutan commented on issue #2381: CLOUDSTACK-10117 Account ldap binding
URL: https://github.com/apache/cloudstack/pull/2381#issuecomment-355537580
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> LDAP mapping on domain level
> 
>
> Key: CLOUDSTACK-10117
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10117
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Daan Hoogland
>
> see FS: 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Domain+level+LDAP+bindinings



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10117) LDAP mapping on domain level

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312999#comment-16312999
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10117:
-

rhtyd commented on issue #2381: CLOUDSTACK-10117 Account ldap binding
URL: https://github.com/apache/cloudstack/pull/2381#issuecomment-355537464
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> LDAP mapping on domain level
> 
>
> Key: CLOUDSTACK-10117
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10117
> Project: CloudStack
>  Issue Type: New Feature
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Reporter: Daan Hoogland
>
> see FS: 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Domain+level+LDAP+bindinings



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312987#comment-16312987
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary 
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355533847
 
 
   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312986#comment-16312986
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
-

nvazquez commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary Storage 
for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355533834
 
 
   @borisstoyanov @DaanHoogland fixed
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bypass Secondary Storage for KVM templates
> --
>
> Key: CLOUDSTACK-10146
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>Affects Versions: 4.11.0.0
>Reporter: Nicolas Vazquez
>Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)