[jira] [Commented] (CLOUDSTACK-8893) test_vm_snapshots.py requires modification since we support volume snapshot on a vm with vm snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510825#comment-15510825
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8893:


Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/871
  
@jburwell @rhtyd @karuturi @nvazquez I assume the current code doesn’t 
allow volume snapshots on the top of vmsnapshots on purpose. In that case is it 
best to revert PR871 or create a new PR to address the Marvin script?

From: Nicolas Vazquez 
Reply-To: apache/cloudstack 
Date: Wednesday, September 21, 2016 at 11:15 AM
To: apache/cloudstack 
Cc: Sergey Levitskiy , Mention 

Subject: Re: [apache/cloudstack] CLOUDSTACK-8893: Fixing script as per the 
latest functionality (#871)


Hi @sanju1010,

@serg38 and I are working on this PR 
#1677 which solves vm snapshot 
creation issue. After running test_vm_snapshots.py we're getting exception on 
test_01_test_vm_volume_snapshot as it was expected before your changes in this 
PR.

We're getting: 'CloudstackAPIException: Execute cmd: createsnapshot failed, 
due to: errorCode: 431, errorText:Volume snapshot is not allowed, please detach 
it from VM with VM Snapshots\n']

This is consistent with VolumeApiServiceImpl.allocSnapshot method, in which 
it is:

if (volume.getInstanceId() != null) {

// Check that Vm to which this volume is attached does not have 
VM Snapshots

if (_vmSnapshotDao.findByVm(volume.getInstanceId()).size() > 0) 
{

throw new InvalidParameterValueException("Volume snapshot 
is not allowed, please detach it from VM with VM Snapshots");

}

}

Do you want us to adapt test_vm_snapshots.py in mentioned PR to support 
this or would you like to address it yourself?

Thanks

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on 
GitHub, 
or mute the 
thread.



> test_vm_snapshots.py requires modification since we support volume snapshot 
> on a vm with vm snapshot
> 
>
> Key: CLOUDSTACK-8893
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8893
> Project: CloudStack
>  Issue Type: Test
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Automation
>Affects Versions: 4.6.0
>Reporter: Sanjeev N
>Assignee: Sanjeev N
>
> test_vm_snapshots.py requires modification since we support volume snapshot 
> on a vm with vm snapshot
> test_01_test_vm_volume_snapshot test from test_vm_snapshots.py expects 
> exception when we try to create volume snapshot on a vm with vm snapshot.
> We need to modify this since we are supporting volume snapshot an a vm with 
> vm snapshots .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8893) test_vm_snapshots.py requires modification since we support volume snapshot on a vm with vm snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510725#comment-15510725
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8893:


Github user nvazquez commented on the issue:

https://github.com/apache/cloudstack/pull/871
  
Hi @sanju1010,

@serg38 and I are working on this PR #1677 which solves vm snapshot 
creation issue. After running `test_vm_snapshots.py` we're getting exception on 
`test_01_test_vm_volume_snapshot` as it was expected before your changes in 
this PR.

We're getting: `'CloudstackAPIException: Execute cmd: createsnapshot 
failed, due to: errorCode: 431, errorText:Volume snapshot is not allowed, 
please detach it from VM with VM Snapshots\n']`

This is consistent with `VolumeApiServiceImpl.allocSnapshot` method, in 
which it is:
```
if (volume.getInstanceId() != null) {
// Check that Vm to which this volume is attached does not have 
VM Snapshots
if (_vmSnapshotDao.findByVm(volume.getInstanceId()).size() > 0) 
{
throw new InvalidParameterValueException("Volume snapshot 
is not allowed, please detach it from VM with VM Snapshots");
}
}
```

Do you want us to adapt `test_vm_snapshots.py` in mentioned PR to support 
this or would you like to address it yourself?

Thanks


> test_vm_snapshots.py requires modification since we support volume snapshot 
> on a vm with vm snapshot
> 
>
> Key: CLOUDSTACK-8893
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8893
> Project: CloudStack
>  Issue Type: Test
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Automation
>Affects Versions: 4.6.0
>Reporter: Sanjeev N
>Assignee: Sanjeev N
>
> test_vm_snapshots.py requires modification since we support volume snapshot 
> on a vm with vm snapshot
> test_01_test_vm_volume_snapshot test from test_vm_snapshots.py expects 
> exception when we try to create volume snapshot on a vm with vm snapshot.
> We need to modify this since we are supporting volume snapshot an a vm with 
> vm snapshots .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8893) test_vm_snapshots.py requires modification since we support volume snapshot on a vm with vm snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14936526#comment-14936526
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8893:


Github user runseb commented on the pull request:

https://github.com/apache/cloudstack/pull/871#issuecomment-144322464
  
@pavanb018 it always helps other folks reviewing to know what you did. For 
example. 
Did you just check the Travis green light ? Did you just check the code 
through github ? Did you pull the patch, apply and compile ? Did you do the 
build then run the tests. It may sound obvious to you what you did by giving 
the copy paste form a test, but writing a small friendly sentence for the next 
reviewer will go a long way to help us merge those fixes as a group.

thanks


> test_vm_snapshots.py requires modification since we support volume snapshot 
> on a vm with vm snapshot
> 
>
> Key: CLOUDSTACK-8893
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8893
> Project: CloudStack
>  Issue Type: Test
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Automation
>Affects Versions: 4.6.0
>Reporter: Sanjeev N
>Assignee: Sanjeev N
>
> test_vm_snapshots.py requires modification since we support volume snapshot 
> on a vm with vm snapshot
> test_01_test_vm_volume_snapshot test from test_vm_snapshots.py expects 
> exception when we try to create volume snapshot on a vm with vm snapshot.
> We need to modify this since we are supporting volume snapshot an a vm with 
> vm snapshots .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8893) test_vm_snapshots.py requires modification since we support volume snapshot on a vm with vm snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14905880#comment-14905880
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8893:


Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/871#issuecomment-142820449
  
@remibergsma Next time sure  I will add some details .for this PR i have 
updated my comments .



> test_vm_snapshots.py requires modification since we support volume snapshot 
> on a vm with vm snapshot
> 
>
> Key: CLOUDSTACK-8893
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8893
> Project: CloudStack
>  Issue Type: Test
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Automation
>Affects Versions: 4.6.0
>Reporter: Sanjeev N
>Assignee: Sanjeev N
>
> test_vm_snapshots.py requires modification since we support volume snapshot 
> on a vm with vm snapshot
> test_01_test_vm_volume_snapshot test from test_vm_snapshots.py expects 
> exception when we try to create volume snapshot on a vm with vm snapshot.
> We need to modify this since we are supporting volume snapshot an a vm with 
> vm snapshots .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8893) test_vm_snapshots.py requires modification since we support volume snapshot on a vm with vm snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14905865#comment-14905865
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8893:


Github user pavanb018 commented on the pull request:

https://github.com/apache/cloudstack/pull/871#issuecomment-142819336
  
An LGTM is given after going through the code and understanding what the 
code is accomplishing. The PR already has the test results and if i am not 
wrong an LGTM is for reviewing the code to make sure the functionality is 
working as expected ?


> test_vm_snapshots.py requires modification since we support volume snapshot 
> on a vm with vm snapshot
> 
>
> Key: CLOUDSTACK-8893
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8893
> Project: CloudStack
>  Issue Type: Test
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Automation
>Affects Versions: 4.6.0
>Reporter: Sanjeev N
>Assignee: Sanjeev N
>
> test_vm_snapshots.py requires modification since we support volume snapshot 
> on a vm with vm snapshot
> test_01_test_vm_volume_snapshot test from test_vm_snapshots.py expects 
> exception when we try to create volume snapshot on a vm with vm snapshot.
> We need to modify this since we are supporting volume snapshot an a vm with 
> vm snapshots .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8893) test_vm_snapshots.py requires modification since we support volume snapshot on a vm with vm snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14905031#comment-14905031
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8893:


Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/871#issuecomment-142696052
  
@pavanb018 @nitt10prashant Could you please add what you tested next time? 
A LGTM without any explanation doesn't really tell me anything to be honest.


> test_vm_snapshots.py requires modification since we support volume snapshot 
> on a vm with vm snapshot
> 
>
> Key: CLOUDSTACK-8893
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8893
> Project: CloudStack
>  Issue Type: Test
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Automation
>Affects Versions: 4.6.0
>Reporter: Sanjeev N
>Assignee: Sanjeev N
>
> test_vm_snapshots.py requires modification since we support volume snapshot 
> on a vm with vm snapshot
> test_01_test_vm_volume_snapshot test from test_vm_snapshots.py expects 
> exception when we try to create volume snapshot on a vm with vm snapshot.
> We need to modify this since we are supporting volume snapshot an a vm with 
> vm snapshots .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8893) test_vm_snapshots.py requires modification since we support volume snapshot on a vm with vm snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14904179#comment-14904179
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8893:


Github user pavanb018 commented on the pull request:

https://github.com/apache/cloudstack/pull/871#issuecomment-142532171
  
LGTM !!


> test_vm_snapshots.py requires modification since we support volume snapshot 
> on a vm with vm snapshot
> 
>
> Key: CLOUDSTACK-8893
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8893
> Project: CloudStack
>  Issue Type: Test
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Automation
>Affects Versions: 4.6.0
>Reporter: Sanjeev N
>Assignee: Sanjeev N
>
> test_vm_snapshots.py requires modification since we support volume snapshot 
> on a vm with vm snapshot
> test_01_test_vm_volume_snapshot test from test_vm_snapshots.py expects 
> exception when we try to create volume snapshot on a vm with vm snapshot.
> We need to modify this since we are supporting volume snapshot an a vm with 
> vm snapshots .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8893) test_vm_snapshots.py requires modification since we support volume snapshot on a vm with vm snapshot

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14904235#comment-14904235
 ] 

ASF subversion and git services commented on CLOUDSTACK-8893:
-

Commit 2f7852bc590a8baf3fea842c239294060fbeb5cf in cloudstack's branch 
refs/heads/master from sanjeev
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2f7852b ]

Merge pull request #871 from sanju1010/vmsnap

CLOUDSTACK-8893: Fixing script as per the latest functionalityPlease check 
https://issues.apache.org/jira/browse/CLOUDSTACK-8893 for more details.

* pr/871:
  Modified test description
  CLOUDSTACK-8893: Fixing script as per the latest functionality

Signed-off-by: sanjeev 


> test_vm_snapshots.py requires modification since we support volume snapshot 
> on a vm with vm snapshot
> 
>
> Key: CLOUDSTACK-8893
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8893
> Project: CloudStack
>  Issue Type: Test
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Automation
>Affects Versions: 4.6.0
>Reporter: Sanjeev N
>Assignee: Sanjeev N
>
> test_vm_snapshots.py requires modification since we support volume snapshot 
> on a vm with vm snapshot
> test_01_test_vm_volume_snapshot test from test_vm_snapshots.py expects 
> exception when we try to create volume snapshot on a vm with vm snapshot.
> We need to modify this since we are supporting volume snapshot an a vm with 
> vm snapshots .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8893) test_vm_snapshots.py requires modification since we support volume snapshot on a vm with vm snapshot

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14904237#comment-14904237
 ] 

ASF subversion and git services commented on CLOUDSTACK-8893:
-

Commit 2f7852bc590a8baf3fea842c239294060fbeb5cf in cloudstack's branch 
refs/heads/master from sanjeev
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2f7852b ]

Merge pull request #871 from sanju1010/vmsnap

CLOUDSTACK-8893: Fixing script as per the latest functionalityPlease check 
https://issues.apache.org/jira/browse/CLOUDSTACK-8893 for more details.

* pr/871:
  Modified test description
  CLOUDSTACK-8893: Fixing script as per the latest functionality

Signed-off-by: sanjeev 


> test_vm_snapshots.py requires modification since we support volume snapshot 
> on a vm with vm snapshot
> 
>
> Key: CLOUDSTACK-8893
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8893
> Project: CloudStack
>  Issue Type: Test
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Automation
>Affects Versions: 4.6.0
>Reporter: Sanjeev N
>Assignee: Sanjeev N
>
> test_vm_snapshots.py requires modification since we support volume snapshot 
> on a vm with vm snapshot
> test_01_test_vm_volume_snapshot test from test_vm_snapshots.py expects 
> exception when we try to create volume snapshot on a vm with vm snapshot.
> We need to modify this since we are supporting volume snapshot an a vm with 
> vm snapshots .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8893) test_vm_snapshots.py requires modification since we support volume snapshot on a vm with vm snapshot

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14904234#comment-14904234
 ] 

ASF subversion and git services commented on CLOUDSTACK-8893:
-

Commit fbc2e2e983938e6a16b7e44eb19db9e659b7a570 in cloudstack's branch 
refs/heads/master from sanjeev
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=fbc2e2e ]

CLOUDSTACK-8893: Fixing script as per the latest functionality


> test_vm_snapshots.py requires modification since we support volume snapshot 
> on a vm with vm snapshot
> 
>
> Key: CLOUDSTACK-8893
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8893
> Project: CloudStack
>  Issue Type: Test
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Automation
>Affects Versions: 4.6.0
>Reporter: Sanjeev N
>Assignee: Sanjeev N
>
> test_vm_snapshots.py requires modification since we support volume snapshot 
> on a vm with vm snapshot
> test_01_test_vm_volume_snapshot test from test_vm_snapshots.py expects 
> exception when we try to create volume snapshot on a vm with vm snapshot.
> We need to modify this since we are supporting volume snapshot an a vm with 
> vm snapshots .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8893) test_vm_snapshots.py requires modification since we support volume snapshot on a vm with vm snapshot

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14904236#comment-14904236
 ] 

ASF subversion and git services commented on CLOUDSTACK-8893:
-

Commit 2f7852bc590a8baf3fea842c239294060fbeb5cf in cloudstack's branch 
refs/heads/master from sanjeev
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2f7852b ]

Merge pull request #871 from sanju1010/vmsnap

CLOUDSTACK-8893: Fixing script as per the latest functionalityPlease check 
https://issues.apache.org/jira/browse/CLOUDSTACK-8893 for more details.

* pr/871:
  Modified test description
  CLOUDSTACK-8893: Fixing script as per the latest functionality

Signed-off-by: sanjeev 


> test_vm_snapshots.py requires modification since we support volume snapshot 
> on a vm with vm snapshot
> 
>
> Key: CLOUDSTACK-8893
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8893
> Project: CloudStack
>  Issue Type: Test
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Automation
>Affects Versions: 4.6.0
>Reporter: Sanjeev N
>Assignee: Sanjeev N
>
> test_vm_snapshots.py requires modification since we support volume snapshot 
> on a vm with vm snapshot
> test_01_test_vm_volume_snapshot test from test_vm_snapshots.py expects 
> exception when we try to create volume snapshot on a vm with vm snapshot.
> We need to modify this since we are supporting volume snapshot an a vm with 
> vm snapshots .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8893) test_vm_snapshots.py requires modification since we support volume snapshot on a vm with vm snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14904238#comment-14904238
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8893:


Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/871


> test_vm_snapshots.py requires modification since we support volume snapshot 
> on a vm with vm snapshot
> 
>
> Key: CLOUDSTACK-8893
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8893
> Project: CloudStack
>  Issue Type: Test
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Automation
>Affects Versions: 4.6.0
>Reporter: Sanjeev N
>Assignee: Sanjeev N
>
> test_vm_snapshots.py requires modification since we support volume snapshot 
> on a vm with vm snapshot
> test_01_test_vm_volume_snapshot test from test_vm_snapshots.py expects 
> exception when we try to create volume snapshot on a vm with vm snapshot.
> We need to modify this since we are supporting volume snapshot an a vm with 
> vm snapshots .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8893) test_vm_snapshots.py requires modification since we support volume snapshot on a vm with vm snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14903969#comment-14903969
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8893:


Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/871#issuecomment-142493294
  
LGTM!!


> test_vm_snapshots.py requires modification since we support volume snapshot 
> on a vm with vm snapshot
> 
>
> Key: CLOUDSTACK-8893
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8893
> Project: CloudStack
>  Issue Type: Test
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Automation
>Affects Versions: 4.6.0
>Reporter: Sanjeev N
>Assignee: Sanjeev N
>
> test_vm_snapshots.py requires modification since we support volume snapshot 
> on a vm with vm snapshot
> test_01_test_vm_volume_snapshot test from test_vm_snapshots.py expects 
> exception when we try to create volume snapshot on a vm with vm snapshot.
> We need to modify this since we are supporting volume snapshot an a vm with 
> vm snapshots .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8893) test_vm_snapshots.py requires modification since we support volume snapshot on a vm with vm snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14903973#comment-14903973
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8893:


Github user pavanb018 commented on the pull request:

https://github.com/apache/cloudstack/pull/871#issuecomment-142497091
  
@Desc: Test that Volume snapshot for root volume not allowed ... === 
TestName: test_01_test_vm_volume_snapshot | Status : SUCCESS ===
ok

Sanju1010 , is the above description part of script ? The description looks 
misleading with the current functionality. If it is not part of the code then 
LGTM !! , else please modify the description so that it wont be confusing. 


> test_vm_snapshots.py requires modification since we support volume snapshot 
> on a vm with vm snapshot
> 
>
> Key: CLOUDSTACK-8893
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8893
> Project: CloudStack
>  Issue Type: Test
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Automation
>Affects Versions: 4.6.0
>Reporter: Sanjeev N
>Assignee: Sanjeev N
>
> test_vm_snapshots.py requires modification since we support volume snapshot 
> on a vm with vm snapshot
> test_01_test_vm_volume_snapshot test from test_vm_snapshots.py expects 
> exception when we try to create volume snapshot on a vm with vm snapshot.
> We need to modify this since we are supporting volume snapshot an a vm with 
> vm snapshots .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8893) test_vm_snapshots.py requires modification since we support volume snapshot on a vm with vm snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14902284#comment-14902284
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8893:


GitHub user sanju1010 opened a pull request:

https://github.com/apache/cloudstack/pull/871

CLOUDSTACK-8893: Fixing script as per the latest functionality

Please check https://issues.apache.org/jira/browse/CLOUDSTACK-8893 for more 
details.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sanju1010/cloudstack vmsnap

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/871.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #871


commit 85fad5ae76c97ca17d258245007906a96aa04c21
Author: sanjeev 
Date:   2015-09-22T09:17:37Z

CLOUDSTACK-8893: Fixing script as per the latest functionality




> test_vm_snapshots.py requires modification since we support volume snapshot 
> on a vm with vm snapshot
> 
>
> Key: CLOUDSTACK-8893
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8893
> Project: CloudStack
>  Issue Type: Test
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Automation
>Affects Versions: 4.6.0
>Reporter: Sanjeev N
>Assignee: Sanjeev N
>
> test_vm_snapshots.py requires modification since we support volume snapshot 
> on a vm with vm snapshot
> test_01_test_vm_volume_snapshot test from test_vm_snapshots.py expects 
> exception when we try to create volume snapshot on a vm with vm snapshot.
> We need to modify this since we are supporting volume snapshot an a vm with 
> vm snapshots .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CLOUDSTACK-8893) test_vm_snapshots.py requires modification since we support volume snapshot on a vm with vm snapshot

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14902476#comment-14902476
 ] 

ASF GitHub Bot commented on CLOUDSTACK-8893:


Github user sanju1010 commented on the pull request:

https://github.com/apache/cloudstack/pull/871#issuecomment-142271544
  
@Desc: Test that Volume snapshot for root volume not allowed ... === 
TestName: test_01_test_vm_volume_snapshot | Status : SUCCESS ===
ok

--
Ran 1 test in 165.417s

OK


> test_vm_snapshots.py requires modification since we support volume snapshot 
> on a vm with vm snapshot
> 
>
> Key: CLOUDSTACK-8893
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8893
> Project: CloudStack
>  Issue Type: Test
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Automation
>Affects Versions: 4.6.0
>Reporter: Sanjeev N
>Assignee: Sanjeev N
>
> test_vm_snapshots.py requires modification since we support volume snapshot 
> on a vm with vm snapshot
> test_01_test_vm_volume_snapshot test from test_vm_snapshots.py expects 
> exception when we try to create volume snapshot on a vm with vm snapshot.
> We need to modify this since we are supporting volume snapshot an a vm with 
> vm snapshots .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)