[GitHub] [commons-vfs] PeterAlfredLee opened a new pull request #97: VFS-748 : Fix for cache fail in tar after garbage collection with weakRefFilesCache
PeterAlfredLee opened a new pull request #97: URL: https://github.com/apache/commons-vfs/pull/97 Fix for the cache fail in TarFileSystem after garbage collection with weakRefFilesCache. Added a private field cache and removed the local variable strongRef. This is similiar to the cache design in ZipFileSystem. And also removed the local variable strongRef in ZipFileSystem cause it seems not working at all. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-codec] coveralls commented on pull request #49: Codec 291 - Hex Encode/Decode with existing arrays
coveralls commented on pull request #49: URL: https://github.com/apache/commons-codec/pull/49#issuecomment-651407538 [](https://coveralls.io/builds/31758886) Coverage decreased (-0.05%) to 93.792% when pulling **bdb5a6f8ddc8730c3dc1ab288b0203ebf469e7f8 on adamretter:hex-vararray** into **7118544745cb91f0390b2c0243aa09c1b5e023d7 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-codec] coveralls edited a comment on pull request #46: CODEC-290: Base16 Input and Output Streams
coveralls edited a comment on pull request #46: URL: https://github.com/apache/commons-codec/pull/46#issuecomment-616146181 [](https://coveralls.io/builds/31758859) Coverage increased (+0.1%) to 93.96% when pulling **427998a47a25c4bbc6098c7418cafffcfed53f53 on adamretter:base16** into **7118544745cb91f0390b2c0243aa09c1b5e023d7 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] Turan91 closed pull request #362: Add a check to StringUtils.repeat() for large length repeat value
Turan91 closed pull request #362: URL: https://github.com/apache/commons-lang/pull/362 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-codec] adamretter commented on pull request #46: CODEC-290: Base16 Input and Output Streams
adamretter commented on pull request #46: URL: https://github.com/apache/commons-codec/pull/46#issuecomment-651345087 @aherbert Hopefully that is everything done now. I have moved the Hex changes to a separate PR - https://github.com/apache/commons-codec/pull/49 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-codec] adamretter edited a comment on pull request #46: CODEC-290: Base16 Input and Output Streams
adamretter edited a comment on pull request #46: URL: https://github.com/apache/commons-codec/pull/46#issuecomment-651345087 @aherbert Hopefully that is everything done now. I have moved the Hex.java/HexTest.java changes to a separate PR - https://github.com/apache/commons-codec/pull/49 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-codec] adamretter opened a new pull request #49: Codec 291 - Hex Encode/Decode with existing arrays
adamretter opened a new pull request #49: URL: https://github.com/apache/commons-codec/pull/49 Additional encode/decode methods for the Hex class where you can pass in the array to write the data to. This allows you to work with existing arrays. This is useful for both reducing allocations and prepending/appending to existing data. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (CODEC-291) Add Hex encode/decode methods for writing to existing arrays
adam Retter created CODEC-291: - Summary: Add Hex encode/decode methods for writing to existing arrays Key: CODEC-291 URL: https://issues.apache.org/jira/browse/CODEC-291 Project: Commons Codec Issue Type: New Feature Affects Versions: 1.15 Reporter: adam Retter Fix For: 1.15 Allows use of existing arrays with encode/decode methods of Hex class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-codec] adamretter commented on a change in pull request #46: CODEC-290: Base16 Input and Output Streams
adamretter commented on a change in pull request #46:
URL: https://github.com/apache/commons-codec/pull/46#discussion_r447184029
##
File path: src/test/java/org/apache/commons/codec/binary/Base16Test.java
##
@@ -0,0 +1,634 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.commons.codec.binary;
+
+import org.apache.commons.codec.CodecPolicy;
+import org.apache.commons.codec.DecoderException;
+import org.apache.commons.codec.EncoderException;
+import org.apache.commons.lang3.ArrayUtils;
+import org.junit.Assume;
+import org.junit.Test;
+
+import java.nio.charset.Charset;
+import java.nio.charset.StandardCharsets;
+import java.util.Arrays;
+import java.util.Random;
+
+import static org.junit.Assert.assertArrayEquals;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNull;
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
+
+/**
+ * Test cases for Base16 class.
+ *
+ * @since 1.15
+ */
+public class Base16Test {
+
+private static final Charset CHARSET_UTF8 = StandardCharsets.UTF_8;
+
+private final Random random = new Random();
+
+/**
+ * @return Returns the random.
+ */
+public Random getRandom() {
+return this.random;
+}
+
+/**
+ * Test the Base16 implementation
+ */
+@Test
+public void testBase16() {
+final String content = "Hello World";
+final byte[] encodedBytes = new
Base16().encode(StringUtils.getBytesUtf8(content));
+final String encodedContent = StringUtils.newStringUtf8(encodedBytes);
+assertEquals("encoding hello world", "48656C6C6F20576F726C64",
encodedContent);
+
+final byte[] decodedBytes = new Base16().decode(encodedBytes);
+final String decodedContent = StringUtils.newStringUtf8(decodedBytes);
+assertEquals("decoding hello world", content, decodedContent);
+}
+
+@Test
+public void testBase16AtBufferStart() {
+testBase16InBuffer(0, 100);
+}
+
+@Test
+public void testBase16AtBufferEnd() {
+testBase16InBuffer(100, 0);
+}
+
+@Test
+public void testBase16AtBufferMiddle() {
+testBase16InBuffer(100, 100);
+}
+
+private void testBase16InBuffer(final int startPasSize, final int
endPadSize) {
+final String content = "Hello World";
+String encodedContent;
+final byte[] bytesUtf8 = StringUtils.getBytesUtf8(content);
+byte[] buffer = ArrayUtils.addAll(bytesUtf8, new byte[endPadSize]);
+buffer = ArrayUtils.addAll(new byte[startPasSize], buffer);
+final byte[] encodedBytes = new Base16().encode(buffer, startPasSize,
bytesUtf8.length);
+encodedContent = StringUtils.newStringUtf8(encodedBytes);
+assertEquals("encoding hello world", "48656C6C6F20576F726C64",
encodedContent);
+}
+
+/**
+ * isBase16 throws RuntimeException on some
+ * non-Base16 bytes
+ */
+@Test(expected=RuntimeException.class)
+public void testCodec68() {
+final byte[] x = new byte[] { 'n', 'H', '=', '=', (byte) 0x9c };
+final Base16 b16 = new Base16();
+b16.decode(x);
+}
+
+@Test
+public void testConstructors() {
+new Base16();
+new Base16(false);
+new Base16(true);
+new Base16(false, CodecPolicy.LENIENT);
+new Base16(false, CodecPolicy.STRICT);
+}
+
+@Test
+public void testConstructor_LowerCase() {
+final Base16 base16 = new Base16(true);
+final byte[] encoded = base16.encode(BaseNTestData.DECODED);
+final String expectedResult = Base16TestData.ENCODED_UTF8_LOWERCASE;
+final String result = StringUtils.newStringUtf8(encoded);
+assertEquals("new Base16(true)", expectedResult, result);
+}
+
+@Test
+public void testConstructor_LowerCase_DecodingPolicy() {
+final Base16 base16 = new Base16(false, CodecPolicy.STRICT);
+final byte[] encoded = base16.encode(BaseNTestData.DECODED);
+final String expectedResult = Base16TestData.ENCODED_UTF8_UPPERCASE;
+final String result =
[jira] [Work logged] (LANG-1588) refine StringUtils.center
[ https://issues.apache.org/jira/browse/LANG-1588?focusedWorklogId=452580=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-452580 ] ASF GitHub Bot logged work on LANG-1588: Author: ASF GitHub Bot Created on: 29/Jun/20 18:53 Start Date: 29/Jun/20 18:53 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #577: URL: https://github.com/apache/commons-lang/pull/577#issuecomment-651297946 [](https://coveralls.io/builds/31754329) Coverage decreased (-0.02%) to 94.66% when pulling **9b5a87efdfacf75943cb08ed659fd8cd9265c4a2 on XenoAmess:refine_center** into **da0f6a8051cc60d1bebe703b4e390ce3035497db on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 452580) Remaining Estimate: 0h Time Spent: 10m > refine StringUtils.center > - > > Key: LANG-1588 > URL: https://issues.apache.org/jira/browse/LANG-1588 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/577] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] coveralls commented on pull request #577: [LANG-1588] refine StringUtils.center
coveralls commented on pull request #577: URL: https://github.com/apache/commons-lang/pull/577#issuecomment-651297946 [](https://coveralls.io/builds/31754329) Coverage decreased (-0.02%) to 94.66% when pulling **9b5a87efdfacf75943cb08ed659fd8cd9265c4a2 on XenoAmess:refine_center** into **da0f6a8051cc60d1bebe703b4e390ce3035497db on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1587) refine StringUtils.strip
[ https://issues.apache.org/jira/browse/LANG-1587?focusedWorklogId=452579=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-452579 ] ASF GitHub Bot logged work on LANG-1587: Author: ASF GitHub Bot Created on: 29/Jun/20 18:51 Start Date: 29/Jun/20 18:51 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #576: URL: https://github.com/apache/commons-lang/pull/576#issuecomment-651296961 [](https://coveralls.io/builds/31754225) Coverage increased (+0.006%) to 94.685% when pulling **b21599e1982e9e12c6caeca6c0b047b539566a2c on XenoAmess:refine_strip** into **da0f6a8051cc60d1bebe703b4e390ce3035497db on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 452579) Remaining Estimate: 0h Time Spent: 10m > refine StringUtils.strip > > > Key: LANG-1587 > URL: https://issues.apache.org/jira/browse/LANG-1587 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > https://github.com/apache/commons-lang/pull/576 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] coveralls commented on pull request #576: [LANG-1587] refine StringUtils.strip
coveralls commented on pull request #576: URL: https://github.com/apache/commons-lang/pull/576#issuecomment-651296961 [](https://coveralls.io/builds/31754225) Coverage increased (+0.006%) to 94.685% when pulling **b21599e1982e9e12c6caeca6c0b047b539566a2c on XenoAmess:refine_strip** into **da0f6a8051cc60d1bebe703b4e390ce3035497db on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] ytanikin edited a comment on pull request #564: add passing varargs Supplier to ObjectUtils.getIfNull instead of Supplier single param
ytanikin edited a comment on pull request #564: URL: https://github.com/apache/commons-lang/pull/564#issuecomment-651271832 ObjectUtils.getIfNull( number, () -> Support.getMasterNumber(file), () -> Support.getPredefinedNumber(file), this::takeFreeNumber, () -> UNDEFINED_NUMBER ); it is a lazy calculation, don't need to calculate all possible values and use ObjectUtils.firstNonNull, we have a lot of cases where we use firstNonNull but for this, we calculate values in advance This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] ytanikin edited a comment on pull request #564: add passing varargs Supplier to ObjectUtils.getIfNull instead of Supplier single param
ytanikin edited a comment on pull request #564: URL: https://github.com/apache/commons-lang/pull/564#issuecomment-651271832 ObjectUtils.getIfNull( number, () -> Support.getMasterNumber(file), () -> Support.getPredefinedNumber(file), this::takeFreeNumber, Support::getUndefinedNumber ); it is a lazy calculation, don't need to calculate all possible values and use ObjectUtils.firstNonNull, we have a lot of cases where we use firstNonNull but for this, we calculate values in advance This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] ytanikin edited a comment on pull request #564: add passing varargs Supplier to ObjectUtils.getIfNull instead of Supplier single param
ytanikin edited a comment on pull request #564: URL: https://github.com/apache/commons-lang/pull/564#issuecomment-651271832 ObjectUtils.getIfNull( number, () -> Support.getMasterNumber(file), () -> Support.getPredefinedNumber(file), this::takeFreeNumber, Support::getUndefinedNumber ); it is a lazy calculation, don't need to calculate all possible values and use ObjectUtils.firstNonNull This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] ytanikin commented on pull request #564: add passing varargs Supplier to ObjectUtils.getIfNull instead of Supplier single param
ytanikin commented on pull request #564: URL: https://github.com/apache/commons-lang/pull/564#issuecomment-651271832 `ObjectUtils.getIfNull( number, () -> Support.getMasterNumber(file), () -> Support.getPredefinedNumber(file), this::takeFreeNumber, Support::getUndefinedNumber );` it is a lazy calculation, don't need to calculate all possible values and use ObjectUtils.firstNonNull This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] ytanikin edited a comment on pull request #564: add passing varargs Supplier to ObjectUtils.getIfNull instead of Supplier single param
ytanikin edited a comment on pull request #564: URL: https://github.com/apache/commons-lang/pull/564#issuecomment-651271832 `ObjectUtils.getIfNull( number, () -> Support.getMasterNumber(file), () -> Support.getPredefinedNumber(file), this::takeFreeNumber, Support::getUndefinedNumber );` it is a lazy calculation, don't need to calculate all possible values and use ObjectUtils.firstNonNull This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1585) refine performance of StringUtils.normalizeSpace
[ https://issues.apache.org/jira/browse/LANG-1585?focusedWorklogId=452518=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-452518 ] ASF GitHub Bot logged work on LANG-1585: Author: ASF GitHub Bot Created on: 29/Jun/20 17:29 Start Date: 29/Jun/20 17:29 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #574: URL: https://github.com/apache/commons-lang/pull/574#issuecomment-651258084 [](https://coveralls.io/builds/31752613) Coverage decreased (-0.005%) to 94.674% when pulling **b60d30bbb3a4e3db5726da2ae8eeeb566a0a on XenoAmess:refine_normalizeSpace** into **da0f6a8051cc60d1bebe703b4e390ce3035497db on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 452518) Time Spent: 20m (was: 10m) > refine performance of StringUtils.normalizeSpace > > > Key: LANG-1585 > URL: https://issues.apache.org/jira/browse/LANG-1585 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/574] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] coveralls commented on pull request #574: [LANG-1585] refine performance of StringUtils.normalizeSpace
coveralls commented on pull request #574: URL: https://github.com/apache/commons-lang/pull/574#issuecomment-651258084 [](https://coveralls.io/builds/31752613) Coverage decreased (-0.005%) to 94.674% when pulling **b60d30bbb3a4e3db5726da2ae8eeeb566a0a on XenoAmess:refine_normalizeSpace** into **da0f6a8051cc60d1bebe703b4e390ce3035497db on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (LANG-1588) refine StringUtils.center
Jin Xu created LANG-1588: Summary: refine StringUtils.center Key: LANG-1588 URL: https://issues.apache.org/jira/browse/LANG-1588 Project: Commons Lang Issue Type: Sub-task Reporter: Jin Xu [https://github.com/apache/commons-lang/pull/577] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] XenoAmess opened a new pull request #577: refine StringUtils.center
XenoAmess opened a new pull request #577: URL: https://github.com/apache/commons-lang/pull/577 as title. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (LANG-1587) refine StringUtils.strip
Jin Xu created LANG-1587: Summary: refine StringUtils.strip Key: LANG-1587 URL: https://issues.apache.org/jira/browse/LANG-1587 Project: Commons Lang Issue Type: Sub-task Reporter: Jin Xu https://github.com/apache/commons-lang/pull/576 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] XenoAmess opened a new pull request #576: refine StringUtils.strip
XenoAmess opened a new pull request #576: URL: https://github.com/apache/commons-lang/pull/576 as title. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] XenoAmess edited a comment on pull request #564: add passing varargs Supplier to ObjectUtils.getIfNull instead of Supplier single param
XenoAmess edited a comment on pull request #564: URL: https://github.com/apache/commons-lang/pull/564#issuecomment-650971782 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #564: add passing varargs Supplier to ObjectUtils.getIfNull instead of Supplier single param
garydgregory commented on pull request #564: URL: https://github.com/apache/commons-lang/pull/564#issuecomment-651210322 What is your use-case for this? It seems rather obtuse to me. Perhaps a real example would help. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-codec] aherbert commented on a change in pull request #46: CODEC-290: Base16 Input and Output Streams
aherbert commented on a change in pull request #46:
URL: https://github.com/apache/commons-codec/pull/46#discussion_r447078546
##
File path: src/test/java/org/apache/commons/codec/binary/Base16Test.java
##
@@ -0,0 +1,634 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.commons.codec.binary;
+
+import org.apache.commons.codec.CodecPolicy;
+import org.apache.commons.codec.DecoderException;
+import org.apache.commons.codec.EncoderException;
+import org.apache.commons.lang3.ArrayUtils;
+import org.junit.Assume;
+import org.junit.Test;
+
+import java.nio.charset.Charset;
+import java.nio.charset.StandardCharsets;
+import java.util.Arrays;
+import java.util.Random;
+
+import static org.junit.Assert.assertArrayEquals;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNull;
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
+
+/**
+ * Test cases for Base16 class.
+ *
+ * @since 1.15
+ */
+public class Base16Test {
+
+private static final Charset CHARSET_UTF8 = StandardCharsets.UTF_8;
+
+private final Random random = new Random();
+
+/**
+ * @return Returns the random.
+ */
+public Random getRandom() {
+return this.random;
+}
+
+/**
+ * Test the Base16 implementation
+ */
+@Test
+public void testBase16() {
+final String content = "Hello World";
+final byte[] encodedBytes = new
Base16().encode(StringUtils.getBytesUtf8(content));
+final String encodedContent = StringUtils.newStringUtf8(encodedBytes);
+assertEquals("encoding hello world", "48656C6C6F20576F726C64",
encodedContent);
+
+final byte[] decodedBytes = new Base16().decode(encodedBytes);
+final String decodedContent = StringUtils.newStringUtf8(decodedBytes);
+assertEquals("decoding hello world", content, decodedContent);
+}
+
+@Test
+public void testBase16AtBufferStart() {
+testBase16InBuffer(0, 100);
+}
+
+@Test
+public void testBase16AtBufferEnd() {
+testBase16InBuffer(100, 0);
+}
+
+@Test
+public void testBase16AtBufferMiddle() {
+testBase16InBuffer(100, 100);
+}
+
+private void testBase16InBuffer(final int startPasSize, final int
endPadSize) {
+final String content = "Hello World";
+String encodedContent;
+final byte[] bytesUtf8 = StringUtils.getBytesUtf8(content);
+byte[] buffer = ArrayUtils.addAll(bytesUtf8, new byte[endPadSize]);
+buffer = ArrayUtils.addAll(new byte[startPasSize], buffer);
+final byte[] encodedBytes = new Base16().encode(buffer, startPasSize,
bytesUtf8.length);
+encodedContent = StringUtils.newStringUtf8(encodedBytes);
+assertEquals("encoding hello world", "48656C6C6F20576F726C64",
encodedContent);
+}
+
+/**
+ * isBase16 throws RuntimeException on some
+ * non-Base16 bytes
+ */
+@Test(expected=RuntimeException.class)
+public void testCodec68() {
+final byte[] x = new byte[] { 'n', 'H', '=', '=', (byte) 0x9c };
+final Base16 b16 = new Base16();
+b16.decode(x);
+}
+
+@Test
+public void testConstructors() {
+new Base16();
+new Base16(false);
+new Base16(true);
+new Base16(false, CodecPolicy.LENIENT);
+new Base16(false, CodecPolicy.STRICT);
+}
+
+@Test
+public void testConstructor_LowerCase() {
+final Base16 base16 = new Base16(true);
+final byte[] encoded = base16.encode(BaseNTestData.DECODED);
+final String expectedResult = Base16TestData.ENCODED_UTF8_LOWERCASE;
+final String result = StringUtils.newStringUtf8(encoded);
+assertEquals("new Base16(true)", expectedResult, result);
+}
+
+@Test
+public void testConstructor_LowerCase_DecodingPolicy() {
+final Base16 base16 = new Base16(false, CodecPolicy.STRICT);
+final byte[] encoded = base16.encode(BaseNTestData.DECODED);
+final String expectedResult = Base16TestData.ENCODED_UTF8_UPPERCASE;
+final String result =
[jira] [Commented] (RNG-123) PCG generators may exhibit massive stream correlation
[
https://issues.apache.org/jira/browse/RNG-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147896#comment-17147896
]
Alex Herbert commented on RNG-123:
--
I have added comments to all the relevant PCG generators in the Javadoc to
indicate the issue with using the 128-bit seed variant. There is now an
alternative version using only the 64-bit seed and this is the recommended
version.
> PCG generators may exhibit massive stream correlation
> -
>
> Key: RNG-123
> URL: https://issues.apache.org/jira/browse/RNG-123
> Project: Commons RNG
> Issue Type: Improvement
> Components: core
>Affects Versions: 1.3
>Reporter: Sebastiano Vigna
>Assignee: Alex Herbert
>Priority: Major
> Fix For: 1.4
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> [This is based on an issue I posted on the Rust development mailing list.]
> The documentation of the PCG generators does not state explicit that
> different seeds generate independent sequences, but the existence of a
> 128-bit seed implies somehow the idea that the whole seed is meaningful.
> The user should be made aware that the second parameter (the constant of the
> underlying LCG) is almost useless from a mathematical and statistical
> viewpoint.
> Changing constant to an LCG with power-of-two modulus and a constant like the
> one used in PCG simply adds a constant to the sequence (more precisely, there
> are two equivalence classes of constants, and in each equivalence class the
> sequences are identical, except for an additive constant).
> The minimal scrambling done by the generator usually cannot cancel this fact,
> and as a result changing the constant is equivalent to changing the initial
> state (modulo an additive constant). You can try to run this program:
>
> {noformat}
> import org.apache.commons.rng.core.source32.PcgXshRr32;
> import com.google.common.primitives.Ints;
> public class TestPCG {
> public static void main(final String[] args) {
> final long state = Long.parseLong(args[0]);
> final long c = Long.parseLong(args[1]);
> final long d = Long.parseLong(args[2]);
> if (c % 2 != d % 2) throw new IllegalArgumentException();
> final long C = c << 1 | 1;
> final long D = d << 1 | 1;
> final long r = 1314878037273365987L * ((d - c) >>> 1);
> final PcgXshRr32 rng0 = new PcgXshRr32(new long[] { state, c });
> final PcgXshRr32 rng1 = new PcgXshRr32(new long[] {
> 0xc097ef87329e28a5L *(6364136223846793005L * (state + C) + C - r
> - D) - D, d });
> for(;;) {
> final int a = rng0.nextInt();
> System.out.write(Ints.toByteArray(a), 0, 4);
> final int b = rng1.nextInt();
> System.out.write(Ints.toByteArray(b), 0, 4);
> }
> }
> }{noformat}
> You can pass any state as first argument, and any two constants as the
> following two arguments, as long as they are either both even or both odd .
> The program will set up a second initial state so that the sequences
> generated by the PRNGs using the two constants as seed are based on almost
> identical underlying LCG sequences, in spite of having arbitrary, different
> constants and different initial states. The two streams should be
> independent, but if you pipe the output in PractRand you'll get immediately
> {noformat}
> rng=RNG_stdin32, seed=unknown
> length= 4 megabytes (2^22 bytes), time= 2.1 seconds
> Test Name Raw Processed Evaluation
> BCFN(0+0,13-5,T) R=+263.2 p = 3.4e-103 FAIL !
> BCFN(0+1,13-5,T) R=+128.6 p = 1.5e-50FAIL
> BCFN(0+2,13-6,T) R= +65.2 p = 9.2e-23FAIL !!
> BCFN(0+3,13-6,T) R= +15.4 p = 1.0e-5 mildly suspicious
> DC6-9x1Bytes-1R= +59.1 p = 4.2e-33FAIL !!!
> DC6-6x2Bytes-1R= +34.1 p = 9.0e-19FAIL !
> DC6-5x4Bytes-1R= +15.2 p = 7.7e-8 very suspicious
> [Low4/16]BCFN(0+1,13-6,T) R= +12.0 p = 1.5e-4 unusual
> [Low4/16]FPF-14+6/64:(4,14-8) R= +9.2 p = 1.1e-6 unusual
> [...]
> [Low8/32]FPF-14+6/4:(9,14-9) R= +27.4 p = 1.6e-17FAIL
> [Low8/32]FPF-14+6/4:(10,14-10)R= +16.4 p = 2.5e-9 suspicious
> [Low8/32]FPF-14+6/4:all R=+283.4 p = 8.4e-255 FAIL !!
> [Low8/32]Gap-16:A R=+414.8 p = 2.4e-336 FAIL !!!
> [Low8/32]Gap-16:B R= +1736 p = 5e-1320FAIL
> {noformat}
> You can also offset one of generator by hundred of iterations, but the
> sequences are so correlated that the result won't change. If you peek at the
> state of the two generators you'll see
[jira] [Assigned] (RNG-123) PCG generators may exhibit massive stream correlation
[
https://issues.apache.org/jira/browse/RNG-123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Herbert reassigned RNG-123:
Fix Version/s: 1.4
Assignee: Alex Herbert
Issue Type: Improvement (was: Bug)
> PCG generators may exhibit massive stream correlation
> -
>
> Key: RNG-123
> URL: https://issues.apache.org/jira/browse/RNG-123
> Project: Commons RNG
> Issue Type: Improvement
> Components: core
>Affects Versions: 1.3
>Reporter: Sebastiano Vigna
>Assignee: Alex Herbert
>Priority: Major
> Fix For: 1.4
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> [This is based on an issue I posted on the Rust development mailing list.]
> The documentation of the PCG generators does not state explicit that
> different seeds generate independent sequences, but the existence of a
> 128-bit seed implies somehow the idea that the whole seed is meaningful.
> The user should be made aware that the second parameter (the constant of the
> underlying LCG) is almost useless from a mathematical and statistical
> viewpoint.
> Changing constant to an LCG with power-of-two modulus and a constant like the
> one used in PCG simply adds a constant to the sequence (more precisely, there
> are two equivalence classes of constants, and in each equivalence class the
> sequences are identical, except for an additive constant).
> The minimal scrambling done by the generator usually cannot cancel this fact,
> and as a result changing the constant is equivalent to changing the initial
> state (modulo an additive constant). You can try to run this program:
>
> {noformat}
> import org.apache.commons.rng.core.source32.PcgXshRr32;
> import com.google.common.primitives.Ints;
> public class TestPCG {
> public static void main(final String[] args) {
> final long state = Long.parseLong(args[0]);
> final long c = Long.parseLong(args[1]);
> final long d = Long.parseLong(args[2]);
> if (c % 2 != d % 2) throw new IllegalArgumentException();
> final long C = c << 1 | 1;
> final long D = d << 1 | 1;
> final long r = 1314878037273365987L * ((d - c) >>> 1);
> final PcgXshRr32 rng0 = new PcgXshRr32(new long[] { state, c });
> final PcgXshRr32 rng1 = new PcgXshRr32(new long[] {
> 0xc097ef87329e28a5L *(6364136223846793005L * (state + C) + C - r
> - D) - D, d });
> for(;;) {
> final int a = rng0.nextInt();
> System.out.write(Ints.toByteArray(a), 0, 4);
> final int b = rng1.nextInt();
> System.out.write(Ints.toByteArray(b), 0, 4);
> }
> }
> }{noformat}
> You can pass any state as first argument, and any two constants as the
> following two arguments, as long as they are either both even or both odd .
> The program will set up a second initial state so that the sequences
> generated by the PRNGs using the two constants as seed are based on almost
> identical underlying LCG sequences, in spite of having arbitrary, different
> constants and different initial states. The two streams should be
> independent, but if you pipe the output in PractRand you'll get immediately
> {noformat}
> rng=RNG_stdin32, seed=unknown
> length= 4 megabytes (2^22 bytes), time= 2.1 seconds
> Test Name Raw Processed Evaluation
> BCFN(0+0,13-5,T) R=+263.2 p = 3.4e-103 FAIL !
> BCFN(0+1,13-5,T) R=+128.6 p = 1.5e-50FAIL
> BCFN(0+2,13-6,T) R= +65.2 p = 9.2e-23FAIL !!
> BCFN(0+3,13-6,T) R= +15.4 p = 1.0e-5 mildly suspicious
> DC6-9x1Bytes-1R= +59.1 p = 4.2e-33FAIL !!!
> DC6-6x2Bytes-1R= +34.1 p = 9.0e-19FAIL !
> DC6-5x4Bytes-1R= +15.2 p = 7.7e-8 very suspicious
> [Low4/16]BCFN(0+1,13-6,T) R= +12.0 p = 1.5e-4 unusual
> [Low4/16]FPF-14+6/64:(4,14-8) R= +9.2 p = 1.1e-6 unusual
> [...]
> [Low8/32]FPF-14+6/4:(9,14-9) R= +27.4 p = 1.6e-17FAIL
> [Low8/32]FPF-14+6/4:(10,14-10)R= +16.4 p = 2.5e-9 suspicious
> [Low8/32]FPF-14+6/4:all R=+283.4 p = 8.4e-255 FAIL !!
> [Low8/32]Gap-16:A R=+414.8 p = 2.4e-336 FAIL !!!
> [Low8/32]Gap-16:B R= +1736 p = 5e-1320FAIL
> {noformat}
> You can also offset one of generator by hundred of iterations, but the
> sequences are so correlated that the result won't change. If you peek at the
> state of the two generators you'll see that their difference is constant.
> I think the reader should be made aware of the danger. If you start several
> generators of this kind the state is too small to
[GitHub] [commons-codec] aherbert commented on a change in pull request #46: Base16 Input and Output Streams
aherbert commented on a change in pull request #46:
URL: https://github.com/apache/commons-codec/pull/46#discussion_r447062613
##
File path: src/test/java/org/apache/commons/codec/binary/Base16Test.java
##
@@ -0,0 +1,625 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.commons.codec.binary;
+
+import org.apache.commons.codec.CodecPolicy;
+import org.apache.commons.codec.DecoderException;
+import org.apache.commons.codec.EncoderException;
+import org.apache.commons.lang3.ArrayUtils;
+import org.junit.Assume;
+import org.junit.Test;
+
+import java.nio.charset.Charset;
+import java.nio.charset.StandardCharsets;
+import java.util.Arrays;
+import java.util.Random;
+
+import static org.junit.Assert.assertArrayEquals;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
+
+/**
+ * Test cases for Base16 class.
+ *
+ * @since 1.15
+ */
+public class Base16Test {
+
+private static final Charset CHARSET_UTF8 = StandardCharsets.UTF_8;
+
+private final Random random = new Random();
+
+/**
+ * @return Returns the random.
+ */
+public Random getRandom() {
+return this.random;
+}
+
+/**
+ * Test the Base16 implementation
+ */
+@Test
+public void testBase16() {
+final String content = "Hello World";
+final byte[] encodedBytes = new
Base16().encode(StringUtils.getBytesUtf8(content));
+final String encodedContent = StringUtils.newStringUtf8(encodedBytes);
+assertEquals("encoding hello world", "48656C6C6F20576F726C64",
encodedContent);
+
+final byte[] decodedBytes = new Base16().decode(encodedBytes);
+final String decodedContent = StringUtils.newStringUtf8(decodedBytes);
+assertEquals("decoding hello world", content, decodedContent);
+}
+
+@Test
+public void testBase16AtBufferStart() {
+testBase16InBuffer(0, 100);
+}
+
+@Test
+public void testBase16AtBufferEnd() {
+testBase16InBuffer(100, 0);
+}
+
+@Test
+public void testBase16AtBufferMiddle() {
+testBase16InBuffer(100, 100);
+}
+
+private void testBase16InBuffer(final int startPasSize, final int
endPadSize) {
+final String content = "Hello World";
+String encodedContent;
+final byte[] bytesUtf8 = StringUtils.getBytesUtf8(content);
+byte[] buffer = ArrayUtils.addAll(bytesUtf8, new byte[endPadSize]);
+buffer = ArrayUtils.addAll(new byte[startPasSize], buffer);
+final byte[] encodedBytes = new Base16().encode(buffer, startPasSize,
bytesUtf8.length);
+encodedContent = StringUtils.newStringUtf8(encodedBytes);
+assertEquals("encoding hello world", "48656C6C6F20576F726C64",
encodedContent);
+}
+
+/**
+ * isBase16 throws RuntimeException on some
+ * non-Base16 bytes
+ */
+@Test(expected=RuntimeException.class)
+public void testCodec68() {
+final byte[] x = new byte[] { 'n', 'H', '=', '=', (byte) 0x9c };
+final Base16 b16 = new Base16();
+b16.decode(x);
+}
+
+@Test
+public void testConstructors() {
+new Base16();
+new Base16(false);
+new Base16(true);
+new Base16(false, CodecPolicy.LENIENT);
+new Base16(false, CodecPolicy.STRICT);
+}
+
+@Test
+public void testConstructor_LowerCase() {
+final Base16 Base16 = new Base16(true);
+final byte[] encoded = Base16.encode(Base16TestData.DECODED);
+final String expectedResult = Base16TestData.ENCODED_UTF8_LOWERCASE;
+final String result = StringUtils.newStringUtf8(encoded);
+assertEquals("new Base16(true)", expectedResult, result);
+}
+
+@Test
+public void testConstructor_LowerCase_DecodingPolicy() {
+final Base16 Base16 = new Base16(false, CodecPolicy.STRICT);
+final byte[] encoded = Base16.encode(Base16TestData.DECODED);
+final String expectedResult = Base16TestData.ENCODED_UTF8_UPPERCASE;
+final String result = StringUtils.newStringUtf8(encoded);
+assertEquals("new
[GitHub] [commons-lang] coveralls edited a comment on pull request #564: add passing varargs Supplier to ObjectUtils.getIfNull instead of Supplier single param
coveralls edited a comment on pull request #564: URL: https://github.com/apache/commons-lang/pull/564#issuecomment-651093651 [](https://coveralls.io/builds/31749640) Coverage increased (+0.001%) to 94.68% when pulling **9c53af1deb4c0f8b8442d246cf52b840a981a987 on ytanikin:LANG-1571** into **da0f6a8051cc60d1bebe703b4e390ce3035497db on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-rng] asfgit merged pull request #77: [RNG-123] Document PCG generators potential stream correlation
asfgit merged pull request #77: URL: https://github.com/apache/commons-rng/pull/77 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1585) refine performance of StringUtils.normalizeSpace
[ https://issues.apache.org/jira/browse/LANG-1585?focusedWorklogId=452348=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-452348 ] ASF GitHub Bot logged work on LANG-1585: Author: ASF GitHub Bot Created on: 29/Jun/20 14:08 Start Date: 29/Jun/20 14:08 Worklog Time Spent: 10m Work Description: XenoAmess commented on pull request #574: URL: https://github.com/apache/commons-lang/pull/574#issuecomment-651146257 performance test: ``` D:\workspace\commons-lang>mvn -test -Pbenchmark [ERROR] Error executing Maven. [ERROR] The specified user toolchains file does not exist: D:\workspace\commons-lang\est D:\workspace\commons-lang>mvn test -Pbenchmark [INFO] Scanning for projects... [INFO] [INFO] --< org.apache.commons:commons-lang3 >-- [INFO] Building Apache Commons Lang 3.11-SNAPSHOT [INFO] [ jar ]- [INFO] [INFO] --- maven-enforcer-plugin:3.0.0-M3:enforce (enforce-maven-version) @ commons-lang3 --- [INFO] [INFO] --- maven-enforcer-plugin:3.0.0-M3:enforce (enforce-maven-3) @ commons-lang3 --- [INFO] [INFO] --- apache-rat-plugin:0.13:check (rat-check) @ commons-lang3 --- [INFO] Enabled default license matchers. [INFO] Will parse SCM ignores for exclusions... [INFO] Parsing exclusions from D:\workspace\commons-lang\.gitignore [INFO] Finished adding exclusions from SCM ignore files. [INFO] 73 implicit excludes (use -debug for more details). [INFO] 14 explicit excludes (use -debug for more details). [INFO] 434 resources included (use -debug for more details) [INFO] Rat check: Summary over all files. Unapproved: 0, unknown: 0, generated: 0, approved: 429 licenses. [INFO] [INFO] --- build-helper-maven-plugin:3.1.0:parse-version (parse-version) @ commons-lang3 --- [INFO] [INFO] --- maven-antrun-plugin:1.8:run (javadoc.resources) @ commons-lang3 --- [INFO] Executing tasks main: [INFO] Executed tasks [INFO] [INFO] --- maven-remote-resources-plugin:1.7.0:process (process-resource-bundles) @ commons-lang3 --- [INFO] Skipping remote resources execution. [INFO] [INFO] --- buildnumber-maven-plugin:1.4:create (default) @ commons-lang3 --- [INFO] Executing: cmd.exe /X /C "git rev-parse --verify HEAD" [INFO] Working directory: D:\workspace\commons-lang [INFO] Storing buildNumber: 8bdc0147b17432607900eae83d36ec15f715f203 at timestamp: 1593431635461 [INFO] Storing buildScmBranch: refine_normalizeSpace [INFO] [INFO] --- maven-resources-plugin:3.1.0:resources (default-resources) @ commons-lang3 --- [INFO] Using 'ISO-8859-1' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory D:\workspace\commons-lang\src\main\resources [INFO] Copying 2 resources to META-INF [INFO] [INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @ commons-lang3 --- [INFO] Changes detected - recompiling the module! [INFO] Compiling 210 source files to D:\workspace\commons-lang\target\classes [INFO] /D:/workspace/commons-lang/src/main/java/org/apache/commons/lang3/builder/ToStringStyle.java: Some input files use or ove rride a deprecated API. [INFO] /D:/workspace/commons-lang/src/main/java/org/apache/commons/lang3/builder/ToStringStyle.java: Recompile with -Xlint:depre cation for details. [INFO] /D:/workspace/commons-lang/src/main/java/org/apache/commons/lang3/function/FailablePredicate.java: Some input files use u nchecked or unsafe operations. [INFO] /D:/workspace/commons-lang/src/main/java/org/apache/commons/lang3/function/FailablePredicate.java: Recompile with -Xlint: unchecked for details. [INFO] [INFO] --- maven-bundle-plugin:4.2.1:manifest (bundle-manifest) @ commons-lang3 --- [INFO] [INFO] --- animal-sniffer-maven-plugin:1.18:check (checkAPIcompatibility) @ commons-lang3 --- [INFO] Checking unresolved references to org.codehaus.mojo.signature:java18:1.0 [INFO] [INFO] --- maven-resources-plugin:3.1.0:testResources (default-testResources) @ commons-lang3 --- [INFO] Using 'ISO-8859-1' encoding to copy filtered resources. [INFO] Copying 2 resources [INFO] Copying 2 resources to META-INF [INFO] [INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @ commons-lang3 --- [INFO] Changes detected - recompiling the module! [INFO] Compiling 183 source files to D:\workspace\commons-lang\target\test-classes [INFO] /D:/workspace/commons-lang/src/test/java/org/apache/commons/lang3/StringEscapeUtilsTest.java: Some input files use or ove rride a deprecated API. [INFO] /D:/workspace/commons-lang/src/test/java/org/apache/commons/lang3/StringEscapeUtilsTest.java: Recompile with -Xlint:depre cation for details. [INFO]
[GitHub] [commons-lang] XenoAmess commented on pull request #574: [LANG-1585] refine performance of StringUtils.normalizeSpace
XenoAmess commented on pull request #574: URL: https://github.com/apache/commons-lang/pull/574#issuecomment-651146257 performance test: ``` D:\workspace\commons-lang>mvn -test -Pbenchmark [ERROR] Error executing Maven. [ERROR] The specified user toolchains file does not exist: D:\workspace\commons-lang\est D:\workspace\commons-lang>mvn test -Pbenchmark [INFO] Scanning for projects... [INFO] [INFO] --< org.apache.commons:commons-lang3 >-- [INFO] Building Apache Commons Lang 3.11-SNAPSHOT [INFO] [ jar ]- [INFO] [INFO] --- maven-enforcer-plugin:3.0.0-M3:enforce (enforce-maven-version) @ commons-lang3 --- [INFO] [INFO] --- maven-enforcer-plugin:3.0.0-M3:enforce (enforce-maven-3) @ commons-lang3 --- [INFO] [INFO] --- apache-rat-plugin:0.13:check (rat-check) @ commons-lang3 --- [INFO] Enabled default license matchers. [INFO] Will parse SCM ignores for exclusions... [INFO] Parsing exclusions from D:\workspace\commons-lang\.gitignore [INFO] Finished adding exclusions from SCM ignore files. [INFO] 73 implicit excludes (use -debug for more details). [INFO] 14 explicit excludes (use -debug for more details). [INFO] 434 resources included (use -debug for more details) [INFO] Rat check: Summary over all files. Unapproved: 0, unknown: 0, generated: 0, approved: 429 licenses. [INFO] [INFO] --- build-helper-maven-plugin:3.1.0:parse-version (parse-version) @ commons-lang3 --- [INFO] [INFO] --- maven-antrun-plugin:1.8:run (javadoc.resources) @ commons-lang3 --- [INFO] Executing tasks main: [INFO] Executed tasks [INFO] [INFO] --- maven-remote-resources-plugin:1.7.0:process (process-resource-bundles) @ commons-lang3 --- [INFO] Skipping remote resources execution. [INFO] [INFO] --- buildnumber-maven-plugin:1.4:create (default) @ commons-lang3 --- [INFO] Executing: cmd.exe /X /C "git rev-parse --verify HEAD" [INFO] Working directory: D:\workspace\commons-lang [INFO] Storing buildNumber: 8bdc0147b17432607900eae83d36ec15f715f203 at timestamp: 1593431635461 [INFO] Storing buildScmBranch: refine_normalizeSpace [INFO] [INFO] --- maven-resources-plugin:3.1.0:resources (default-resources) @ commons-lang3 --- [INFO] Using 'ISO-8859-1' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory D:\workspace\commons-lang\src\main\resources [INFO] Copying 2 resources to META-INF [INFO] [INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @ commons-lang3 --- [INFO] Changes detected - recompiling the module! [INFO] Compiling 210 source files to D:\workspace\commons-lang\target\classes [INFO] /D:/workspace/commons-lang/src/main/java/org/apache/commons/lang3/builder/ToStringStyle.java: Some input files use or ove rride a deprecated API. [INFO] /D:/workspace/commons-lang/src/main/java/org/apache/commons/lang3/builder/ToStringStyle.java: Recompile with -Xlint:depre cation for details. [INFO] /D:/workspace/commons-lang/src/main/java/org/apache/commons/lang3/function/FailablePredicate.java: Some input files use u nchecked or unsafe operations. [INFO] /D:/workspace/commons-lang/src/main/java/org/apache/commons/lang3/function/FailablePredicate.java: Recompile with -Xlint: unchecked for details. [INFO] [INFO] --- maven-bundle-plugin:4.2.1:manifest (bundle-manifest) @ commons-lang3 --- [INFO] [INFO] --- animal-sniffer-maven-plugin:1.18:check (checkAPIcompatibility) @ commons-lang3 --- [INFO] Checking unresolved references to org.codehaus.mojo.signature:java18:1.0 [INFO] [INFO] --- maven-resources-plugin:3.1.0:testResources (default-testResources) @ commons-lang3 --- [INFO] Using 'ISO-8859-1' encoding to copy filtered resources. [INFO] Copying 2 resources [INFO] Copying 2 resources to META-INF [INFO] [INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @ commons-lang3 --- [INFO] Changes detected - recompiling the module! [INFO] Compiling 183 source files to D:\workspace\commons-lang\target\test-classes [INFO] /D:/workspace/commons-lang/src/test/java/org/apache/commons/lang3/StringEscapeUtilsTest.java: Some input files use or ove rride a deprecated API. [INFO] /D:/workspace/commons-lang/src/test/java/org/apache/commons/lang3/StringEscapeUtilsTest.java: Recompile with -Xlint:depre cation for details. [INFO] /D:/workspace/commons-lang/src/test/java/org/apache/commons/lang3/builder/ReflectionDiffBuilderTest.java: Some input file s use unchecked or unsafe operations. [INFO] /D:/workspace/commons-lang/src/test/java/org/apache/commons/lang3/builder/ReflectionDiffBuilderTest.java: Recompile with -Xlint:unchecked for details. [INFO] [INFO] --- jacoco-maven-plugin:0.8.5:prepare-agent (prepare-agent) @ commons-lang3 ---
[jira] [Created] (CODEC-290) Base 16 Input/Output Streams
adam Retter created CODEC-290: - Summary: Base 16 Input/Output Streams Key: CODEC-290 URL: https://issues.apache.org/jira/browse/CODEC-290 Project: Commons Codec Issue Type: New Feature Affects Versions: 1.15 Reporter: adam Retter Fix For: 1.15 Add codec for Base16 Input and Output Streams. See - [https://github.com/apache/commons-codec/pull/46] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-codec] adamretter commented on pull request #46: Base16 Input and Output Streams
adamretter commented on pull request #46: URL: https://github.com/apache/commons-codec/pull/46#issuecomment-651139196 @aherbert https://issues.apache.org/jira/browse/CODEC-290 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-codec] adamretter edited a comment on pull request #46: Base16 Input and Output Streams
adamretter edited a comment on pull request #46: URL: https://github.com/apache/commons-codec/pull/46#issuecomment-651139196 @aherbert For this one - https://issues.apache.org/jira/browse/CODEC-290 I will move the Hex class stuff into a separate PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-codec] adamretter commented on a change in pull request #46: Base16 Input and Output Streams
adamretter commented on a change in pull request #46:
URL: https://github.com/apache/commons-codec/pull/46#discussion_r446989594
##
File path: src/test/java/org/apache/commons/codec/binary/Base16Test.java
##
@@ -0,0 +1,625 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.commons.codec.binary;
+
+import org.apache.commons.codec.CodecPolicy;
+import org.apache.commons.codec.DecoderException;
+import org.apache.commons.codec.EncoderException;
+import org.apache.commons.lang3.ArrayUtils;
+import org.junit.Assume;
+import org.junit.Test;
+
+import java.nio.charset.Charset;
+import java.nio.charset.StandardCharsets;
+import java.util.Arrays;
+import java.util.Random;
+
+import static org.junit.Assert.assertArrayEquals;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
+
+/**
+ * Test cases for Base16 class.
+ *
+ * @since 1.15
+ */
+public class Base16Test {
+
+private static final Charset CHARSET_UTF8 = StandardCharsets.UTF_8;
+
+private final Random random = new Random();
+
+/**
+ * @return Returns the random.
+ */
+public Random getRandom() {
+return this.random;
+}
+
+/**
+ * Test the Base16 implementation
+ */
+@Test
+public void testBase16() {
+final String content = "Hello World";
+final byte[] encodedBytes = new
Base16().encode(StringUtils.getBytesUtf8(content));
+final String encodedContent = StringUtils.newStringUtf8(encodedBytes);
+assertEquals("encoding hello world", "48656C6C6F20576F726C64",
encodedContent);
+
+final byte[] decodedBytes = new Base16().decode(encodedBytes);
+final String decodedContent = StringUtils.newStringUtf8(decodedBytes);
+assertEquals("decoding hello world", content, decodedContent);
+}
+
+@Test
+public void testBase16AtBufferStart() {
+testBase16InBuffer(0, 100);
+}
+
+@Test
+public void testBase16AtBufferEnd() {
+testBase16InBuffer(100, 0);
+}
+
+@Test
+public void testBase16AtBufferMiddle() {
+testBase16InBuffer(100, 100);
+}
+
+private void testBase16InBuffer(final int startPasSize, final int
endPadSize) {
+final String content = "Hello World";
+String encodedContent;
+final byte[] bytesUtf8 = StringUtils.getBytesUtf8(content);
+byte[] buffer = ArrayUtils.addAll(bytesUtf8, new byte[endPadSize]);
+buffer = ArrayUtils.addAll(new byte[startPasSize], buffer);
+final byte[] encodedBytes = new Base16().encode(buffer, startPasSize,
bytesUtf8.length);
+encodedContent = StringUtils.newStringUtf8(encodedBytes);
+assertEquals("encoding hello world", "48656C6C6F20576F726C64",
encodedContent);
+}
+
+/**
+ * isBase16 throws RuntimeException on some
+ * non-Base16 bytes
+ */
+@Test(expected=RuntimeException.class)
+public void testCodec68() {
+final byte[] x = new byte[] { 'n', 'H', '=', '=', (byte) 0x9c };
+final Base16 b16 = new Base16();
+b16.decode(x);
+}
+
+@Test
+public void testConstructors() {
+new Base16();
+new Base16(false);
+new Base16(true);
+new Base16(false, CodecPolicy.LENIENT);
+new Base16(false, CodecPolicy.STRICT);
+}
+
+@Test
+public void testConstructor_LowerCase() {
+final Base16 Base16 = new Base16(true);
+final byte[] encoded = Base16.encode(Base16TestData.DECODED);
+final String expectedResult = Base16TestData.ENCODED_UTF8_LOWERCASE;
+final String result = StringUtils.newStringUtf8(encoded);
+assertEquals("new Base16(true)", expectedResult, result);
+}
+
+@Test
+public void testConstructor_LowerCase_DecodingPolicy() {
+final Base16 Base16 = new Base16(false, CodecPolicy.STRICT);
+final byte[] encoded = Base16.encode(Base16TestData.DECODED);
+final String expectedResult = Base16TestData.ENCODED_UTF8_UPPERCASE;
+final String result = StringUtils.newStringUtf8(encoded);
+assertEquals("new
[jira] [Resolved] (NUMBERS-146) Rename "LICENCE.txt" and "NOTICE.txt"
[
https://issues.apache.org/jira/browse/NUMBERS-146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Herbert resolved NUMBERS-146.
--
Resolution: Implemented
Upgrade to parent 51 allows the use of LICENSE and NOTICE which are succesfully
packaged into the jar bundles.
> Rename "LICENCE.txt" and "NOTICE.txt"
> -
>
> Key: NUMBERS-146
> URL: https://issues.apache.org/jira/browse/NUMBERS-146
> Project: Commons Numbers
> Issue Type: Sub-task
> Components: arrays, combinatorics, complex, core, field, fraction,
> gamma, primes, quaternion
>Reporter: Gilles Sadowski
>Priority: Trivial
> Labels: licence, notice
> Fix For: 1.0
>
>
> * Files {{LICENCE.txt}} should be renamed {{LICENCE}}.
> * Files {{NOTICE.txt}} should be renamed {{NOTICE}}.
> See [here|https://infra.apache.org/apply-license.html#license-file-name] and
> [here|http://www.apache.org/dev/licensing-howto.html].
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-codec] aherbert commented on a change in pull request #46: Base16 Input and Output Streams
aherbert commented on a change in pull request #46:
URL: https://github.com/apache/commons-codec/pull/46#discussion_r446952843
##
File path: src/test/java/org/apache/commons/codec/binary/Base16Test.java
##
@@ -0,0 +1,625 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.commons.codec.binary;
+
+import org.apache.commons.codec.CodecPolicy;
+import org.apache.commons.codec.DecoderException;
+import org.apache.commons.codec.EncoderException;
+import org.apache.commons.lang3.ArrayUtils;
+import org.junit.Assume;
+import org.junit.Test;
+
+import java.nio.charset.Charset;
+import java.nio.charset.StandardCharsets;
+import java.util.Arrays;
+import java.util.Random;
+
+import static org.junit.Assert.assertArrayEquals;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
+
+/**
+ * Test cases for Base16 class.
+ *
+ * @since 1.15
+ */
+public class Base16Test {
+
+private static final Charset CHARSET_UTF8 = StandardCharsets.UTF_8;
+
+private final Random random = new Random();
+
+/**
+ * @return Returns the random.
+ */
+public Random getRandom() {
+return this.random;
+}
+
+/**
+ * Test the Base16 implementation
+ */
+@Test
+public void testBase16() {
+final String content = "Hello World";
+final byte[] encodedBytes = new
Base16().encode(StringUtils.getBytesUtf8(content));
+final String encodedContent = StringUtils.newStringUtf8(encodedBytes);
+assertEquals("encoding hello world", "48656C6C6F20576F726C64",
encodedContent);
+
+final byte[] decodedBytes = new Base16().decode(encodedBytes);
+final String decodedContent = StringUtils.newStringUtf8(decodedBytes);
+assertEquals("decoding hello world", content, decodedContent);
+}
+
+@Test
+public void testBase16AtBufferStart() {
+testBase16InBuffer(0, 100);
+}
+
+@Test
+public void testBase16AtBufferEnd() {
+testBase16InBuffer(100, 0);
+}
+
+@Test
+public void testBase16AtBufferMiddle() {
+testBase16InBuffer(100, 100);
+}
+
+private void testBase16InBuffer(final int startPasSize, final int
endPadSize) {
+final String content = "Hello World";
+String encodedContent;
+final byte[] bytesUtf8 = StringUtils.getBytesUtf8(content);
+byte[] buffer = ArrayUtils.addAll(bytesUtf8, new byte[endPadSize]);
+buffer = ArrayUtils.addAll(new byte[startPasSize], buffer);
+final byte[] encodedBytes = new Base16().encode(buffer, startPasSize,
bytesUtf8.length);
+encodedContent = StringUtils.newStringUtf8(encodedBytes);
+assertEquals("encoding hello world", "48656C6C6F20576F726C64",
encodedContent);
+}
+
+/**
+ * isBase16 throws RuntimeException on some
+ * non-Base16 bytes
+ */
+@Test(expected=RuntimeException.class)
+public void testCodec68() {
+final byte[] x = new byte[] { 'n', 'H', '=', '=', (byte) 0x9c };
+final Base16 b16 = new Base16();
+b16.decode(x);
+}
+
+@Test
+public void testConstructors() {
+new Base16();
+new Base16(false);
+new Base16(true);
+new Base16(false, CodecPolicy.LENIENT);
+new Base16(false, CodecPolicy.STRICT);
+}
+
+@Test
+public void testConstructor_LowerCase() {
+final Base16 Base16 = new Base16(true);
+final byte[] encoded = Base16.encode(Base16TestData.DECODED);
+final String expectedResult = Base16TestData.ENCODED_UTF8_LOWERCASE;
+final String result = StringUtils.newStringUtf8(encoded);
+assertEquals("new Base16(true)", expectedResult, result);
+}
+
+@Test
+public void testConstructor_LowerCase_DecodingPolicy() {
+final Base16 Base16 = new Base16(false, CodecPolicy.STRICT);
+final byte[] encoded = Base16.encode(Base16TestData.DECODED);
+final String expectedResult = Base16TestData.ENCODED_UTF8_UPPERCASE;
+final String result = StringUtils.newStringUtf8(encoded);
+assertEquals("new
[GitHub] [commons-codec] aherbert commented on a change in pull request #46: Base16 Input and Output Streams
aherbert commented on a change in pull request #46:
URL: https://github.com/apache/commons-codec/pull/46#discussion_r446943093
##
File path: src/main/java/org/apache/commons/codec/binary/Base16.java
##
@@ -0,0 +1,251 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.commons.codec.binary;
+
+import org.apache.commons.codec.CodecPolicy;
+
+/**
+ * Provides Base16 encoding and decoding.
+ *
+ *
+ * This class is thread-safe.
+ *
+ *
+ * @see https://tools.ietf.org/html/rfc4648#section-8;>RFC 4648 - 8.
Base 16 Encoding
+ *
+ * @since 1.15
+ */
+public class Base16 extends BaseNCodec {
+
+/**
+ * BASE16 characters are 4 bits in length.
+ * They are formed by taking an 8-bit group,
+ * which is converted into two BASE16 characters.
+ */
+private static final int BITS_PER_ENCODED_BYTE = 4;
+private static final int BYTES_PER_ENCODED_BLOCK = 2;
+private static final int BYTES_PER_UNENCODED_BLOCK = 1;
+
+/**
+ * This array is a lookup table that translates Unicode characters drawn
from the "Base16 Alphabet" (as specified
+ * in Table 5 of RFC 4648) into their 4-bit positive integer equivalents.
Characters that are not in the Base16
+ * alphabet but fall within the bounds of the array are translated to -1.
+ */
+private static final byte[] UPPER_CASE_DECODE_TABLE = {
+// 0 1 2 3 4 5 6 7 8 9 A B C D E F
+-1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, //
00-0f
+-1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, //
10-1f
+-1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, //
20-2f
+ 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, -1, -1, -1, -1, -1, -1, //
30-3f 0-9
+-1, 10, 11, 12, 13, 14, 15 //
40-46 A-F
+};
+
+/**
+ * This array is a lookup table that translates 4-bit positive integer
index values into their "Base16 Alphabet"
+ * equivalents as specified in Table 5 of RFC 4648.
+ */
+private static final byte[] UPPER_CASE_ENCODE_TABLE = {
+'0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
+'A', 'B', 'C', 'D', 'E', 'F'
+};
+
+/**
+ * This array is a lookup table that translates Unicode characters drawn
from the a lower-case "Base16 Alphabet"
+ * into their 4-bit positive integer equivalents. Characters that are not
in the Base16
+ * alphabet but fall within the bounds of the array are translated to -1.
+ */
+private static final byte[] LOWER_CASE_DECODE_TABLE = {
+// 0 1 2 3 4 5 6 7 8 9 A B C D E F
+-1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, //
00-0f
+-1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, //
10-1f
+-1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, //
20-2f
+ 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, -1, -1, -1, -1, -1, -1, //
30-3f 0-9
+-1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, //
40-4f
+-1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, //
50-5f
+-1, 10, 11, 12, 13, 14, 15 //
60-66 a-f
+};
+
+/**
+ * This array is a lookup table that translates 4-bit positive integer
index values into their "Base16 Alphabet"
+ * lower-case equivalents.
+ */
+private static final byte[] LOWER_CASE_ENCODE_TABLE = {
+'0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
+'a', 'b', 'c', 'd', 'e', 'f'
+};
+
+/** Mask used to extract 4 bits, used when decoding character. */
+private static final int MASK_4BITS = 0x0f;
+
+/**
+ * Decode table to use.
+ */
+private final byte[] decodeTable;
+
+/**
+ * Encode table to use.
+ */
+private final byte[] encodeTable;
+
+/**
+ * Creates a Base16 codec used for decoding and encoding.
+ */
+public Base16() {
+this(false);
+}
+
+/**
+ * Creates a Base16 codec used for decoding and encoding.
+ *
+ *
[GitHub] [commons-lang] coveralls commented on pull request #564: add passing varargs Supplier to ObjectUtils.getIfNull instead of Supplier single param
coveralls commented on pull request #564: URL: https://github.com/apache/commons-lang/pull/564#issuecomment-651093651 [](https://coveralls.io/builds/31745736) Coverage increased (+0.001%) to 94.68% when pulling **4ae8838205f6eff171c639857f4c2881d65cb33a on ytanikin:LANG-1571** into **da0f6a8051cc60d1bebe703b4e390ce3035497db on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-codec] aherbert commented on pull request #46: Base16 Input and Output Streams
aherbert commented on pull request #46: URL: https://github.com/apache/commons-codec/pull/46#issuecomment-651092582 The changes in Hex are not currently complete for a public API. The changes were originally made to allow the Base16 class to use the Hex class. That no longer happens and the changes do not expose all the added functionality. - The `DIGITS_LOWER/UPPER` arrays have been changed to package private although only used by the Hex class. - The `decodeHex` method to decode into a provided `byte[]` is public (OK) - The `encodeHex` methods to encode into a provided array are protected (Not OK). These should be public with the exception of the actual method that does the encoding which should be private, i.e. a public method call can specify offsets and upper/lower case but not actually pass in the toDigits char[]. I would create a new PR for these changes to make it clear they are not related to the Base16 changes. Have you created a ticket on the [codec bugtracker](https://issues.apache.org/jira/projects/CODEC) for this change? If you create one for Base16 and also for Hex changes then the issue number can be added to the change log when merged. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] coveralls commented on pull request #567: [LANG-1578] refine StringUtils.compare
coveralls commented on pull request #567: URL: https://github.com/apache/commons-lang/pull/567#issuecomment-651078635 [](https://coveralls.io/builds/31745087) Coverage increased (+0.007%) to 94.685% when pulling **f396b9c3b63db59dbb485aa1f421513d1ae56ffa on XenoAmess:refine_compare** into **da0f6a8051cc60d1bebe703b4e390ce3035497db on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1578) refine StringUtils.compare
[ https://issues.apache.org/jira/browse/LANG-1578?focusedWorklogId=452284=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-452284 ] ASF GitHub Bot logged work on LANG-1578: Author: ASF GitHub Bot Created on: 29/Jun/20 12:15 Start Date: 29/Jun/20 12:15 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #567: URL: https://github.com/apache/commons-lang/pull/567#issuecomment-651078635 [](https://coveralls.io/builds/31745087) Coverage increased (+0.007%) to 94.685% when pulling **f396b9c3b63db59dbb485aa1f421513d1ae56ffa on XenoAmess:refine_compare** into **da0f6a8051cc60d1bebe703b4e390ce3035497db on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 452284) Time Spent: 40m (was: 0.5h) > refine StringUtils.compare > -- > > Key: LANG-1578 > URL: https://issues.apache.org/jira/browse/LANG-1578 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 40m > Remaining Estimate: 0h > > https://github.com/apache/commons-lang/pull/567 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1586) refine StringUtils.wrap
[ https://issues.apache.org/jira/browse/LANG-1586?focusedWorklogId=452273=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-452273 ] ASF GitHub Bot logged work on LANG-1586: Author: ASF GitHub Bot Created on: 29/Jun/20 11:57 Start Date: 29/Jun/20 11:57 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #575: URL: https://github.com/apache/commons-lang/pull/575#issuecomment-651068621 [](https://coveralls.io/builds/31744751) Coverage decreased (-0.001%) to 94.677% when pulling **eaf259b9961db083e55faf12cf6e3fd758ade329 on XenoAmess:refine_wrap** into **da0f6a8051cc60d1bebe703b4e390ce3035497db on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 452273) Remaining Estimate: 0h Time Spent: 10m > refine StringUtils.wrap > --- > > Key: LANG-1586 > URL: https://issues.apache.org/jira/browse/LANG-1586 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/575] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] coveralls commented on pull request #575: [LANG-1586] refine StringUtils.wrap
coveralls commented on pull request #575: URL: https://github.com/apache/commons-lang/pull/575#issuecomment-651068621 [](https://coveralls.io/builds/31744751) Coverage decreased (-0.001%) to 94.677% when pulling **eaf259b9961db083e55faf12cf6e3fd758ade329 on XenoAmess:refine_wrap** into **da0f6a8051cc60d1bebe703b4e390ce3035497db on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1578) refine StringUtils.compare
[ https://issues.apache.org/jira/browse/LANG-1578?focusedWorklogId=452252=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-452252 ] ASF GitHub Bot logged work on LANG-1578: Author: ASF GitHub Bot Created on: 29/Jun/20 11:15 Start Date: 29/Jun/20 11:15 Worklog Time Spent: 10m Work Description: XenoAmess edited a comment on pull request #567: URL: https://github.com/apache/commons-lang/pull/567#issuecomment-651040559 Hi. there is some spotbugs issue in this pr. seems we need to white-list some functions out of spotbugs. Any ideas about how to achieve it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 452252) Time Spent: 20m (was: 10m) > refine StringUtils.compare > -- > > Key: LANG-1578 > URL: https://issues.apache.org/jira/browse/LANG-1578 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > https://github.com/apache/commons-lang/pull/567 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1578) refine StringUtils.compare
[ https://issues.apache.org/jira/browse/LANG-1578?focusedWorklogId=452260=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-452260 ] ASF GitHub Bot logged work on LANG-1578: Author: ASF GitHub Bot Created on: 29/Jun/20 11:31 Start Date: 29/Jun/20 11:31 Worklog Time Spent: 10m Work Description: XenoAmess edited a comment on pull request #567: URL: https://github.com/apache/commons-lang/pull/567#issuecomment-651040559 Hi. there is some spotbugs issue in this pr. seems we need to white-list some functions out of spotbugs. Any ideas about how to achieve it? ...OK I found it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 452260) Time Spent: 0.5h (was: 20m) > refine StringUtils.compare > -- > > Key: LANG-1578 > URL: https://issues.apache.org/jira/browse/LANG-1578 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > https://github.com/apache/commons-lang/pull/567 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1583) refine StringUtils.isMixedCase
[ https://issues.apache.org/jira/browse/LANG-1583?focusedWorklogId=452254=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-452254 ] ASF GitHub Bot logged work on LANG-1583: Author: ASF GitHub Bot Created on: 29/Jun/20 11:21 Start Date: 29/Jun/20 11:21 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #572: URL: https://github.com/apache/commons-lang/pull/572#issuecomment-651049585 [](https://coveralls.io/builds/31744013) Coverage decreased (-0.005%) to 94.673% when pulling **766599b06be1b46f9ff3d83d73c4260a1da0ec20 on XenoAmess:refine_isMixedCase** into **da0f6a8051cc60d1bebe703b4e390ce3035497db on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 452254) Time Spent: 20m (was: 10m) > refine StringUtils.isMixedCase > --- > > Key: LANG-1583 > URL: https://issues.apache.org/jira/browse/LANG-1583 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/572] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (LANG-1586) refine StringUtils.wrap
Jin Xu created LANG-1586: Summary: refine StringUtils.wrap Key: LANG-1586 URL: https://issues.apache.org/jira/browse/LANG-1586 Project: Commons Lang Issue Type: Sub-task Reporter: Jin Xu [https://github.com/apache/commons-lang/pull/575] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1583) refine StringUtils.isMixedCase
[ https://issues.apache.org/jira/browse/LANG-1583?focusedWorklogId=452255=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-452255 ] ASF GitHub Bot logged work on LANG-1583: Author: ASF GitHub Bot Created on: 29/Jun/20 11:28 Start Date: 29/Jun/20 11:28 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #572: URL: https://github.com/apache/commons-lang/pull/572#issuecomment-651049585 [](https://coveralls.io/builds/31744098) Coverage decreased (-0.005%) to 94.673% when pulling **766599b06be1b46f9ff3d83d73c4260a1da0ec20 on XenoAmess:refine_isMixedCase** into **da0f6a8051cc60d1bebe703b4e390ce3035497db on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 452255) Time Spent: 0.5h (was: 20m) > refine StringUtils.isMixedCase > --- > > Key: LANG-1583 > URL: https://issues.apache.org/jira/browse/LANG-1583 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/572] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] XenoAmess edited a comment on pull request #567: [LANG-1578] refine StringUtils.compare
XenoAmess edited a comment on pull request #567: URL: https://github.com/apache/commons-lang/pull/567#issuecomment-651040559 Hi. there is some spotbugs issue in this pr. seems we need to white-list some functions out of spotbugs. Any ideas about how to achieve it? ...OK I found it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] coveralls edited a comment on pull request #572: [LANG-1583] refine StringUtils.isMixedCase
coveralls edited a comment on pull request #572: URL: https://github.com/apache/commons-lang/pull/572#issuecomment-651049585 [](https://coveralls.io/builds/31744098) Coverage decreased (-0.005%) to 94.673% when pulling **766599b06be1b46f9ff3d83d73c4260a1da0ec20 on XenoAmess:refine_isMixedCase** into **da0f6a8051cc60d1bebe703b4e390ce3035497db on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] XenoAmess opened a new pull request #575: refine StringUtils.wrap
XenoAmess opened a new pull request #575: URL: https://github.com/apache/commons-lang/pull/575 as title. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] coveralls commented on pull request #572: [LANG-1583] refine StringUtils.isMixedCase
coveralls commented on pull request #572: URL: https://github.com/apache/commons-lang/pull/572#issuecomment-651049585 [](https://coveralls.io/builds/31744013) Coverage decreased (-0.005%) to 94.673% when pulling **766599b06be1b46f9ff3d83d73c4260a1da0ec20 on XenoAmess:refine_isMixedCase** into **da0f6a8051cc60d1bebe703b4e390ce3035497db on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1583) refine StringUtils.isMixedCase
[ https://issues.apache.org/jira/browse/LANG-1583?focusedWorklogId=452246=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-452246 ] ASF GitHub Bot logged work on LANG-1583: Author: ASF GitHub Bot Created on: 29/Jun/20 11:02 Start Date: 29/Jun/20 11:02 Worklog Time Spent: 10m Work Description: XenoAmess commented on pull request #572: URL: https://github.com/apache/commons-lang/pull/572#issuecomment-651040536 travis-ci bugged. will retrigger. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 452246) Remaining Estimate: 0h Time Spent: 10m > refine StringUtils.isMixedCase > --- > > Key: LANG-1583 > URL: https://issues.apache.org/jira/browse/LANG-1583 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/572] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] XenoAmess edited a comment on pull request #567: [LANG-1578] refine StringUtils.compare
XenoAmess edited a comment on pull request #567: URL: https://github.com/apache/commons-lang/pull/567#issuecomment-651040559 Hi. there is some spotbugs issue in this pr. seems we need to white-list some functions out of spotbugs. Any ideas about how to achieve it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1578) refine StringUtils.compare
[ https://issues.apache.org/jira/browse/LANG-1578?focusedWorklogId=452245=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-452245 ] ASF GitHub Bot logged work on LANG-1578: Author: ASF GitHub Bot Created on: 29/Jun/20 11:02 Start Date: 29/Jun/20 11:02 Worklog Time Spent: 10m Work Description: XenoAmess commented on pull request #567: URL: https://github.com/apache/commons-lang/pull/567#issuecomment-651040559 Hi. there is some spotbugs issue in this pr. seems we need to black-list some functions out of spotbugs. Any ideas about how to achieve it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 452245) Remaining Estimate: 0h Time Spent: 10m > refine StringUtils.compare > -- > > Key: LANG-1578 > URL: https://issues.apache.org/jira/browse/LANG-1578 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > https://github.com/apache/commons-lang/pull/567 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] XenoAmess commented on pull request #567: [LANG-1578] refine StringUtils.compare
XenoAmess commented on pull request #567: URL: https://github.com/apache/commons-lang/pull/567#issuecomment-651040559 Hi. there is some spotbugs issue in this pr. seems we need to black-list some functions out of spotbugs. Any ideas about how to achieve it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] XenoAmess commented on pull request #572: [LANG-1583] refine StringUtils.isMixedCase
XenoAmess commented on pull request #572: URL: https://github.com/apache/commons-lang/pull/572#issuecomment-651040536 travis-ci bugged. will retrigger. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NET-685) FTPClient.connect() hangs without any timeout and response. It blocks the whole JVM
Simone created NET-685: -- Summary: FTPClient.connect() hangs without any timeout and response. It blocks the whole JVM Key: NET-685 URL: https://issues.apache.org/jira/browse/NET-685 Project: Commons Net Issue Type: Bug Components: FTP Affects Versions: 3.6 Environment: *OS:* Debian 9 *Java Version:* 1.8 *Scheduler:* On made development using Spring-boot. Multithreading Environment using Runnable Class. Reporter: Simone Attachments: ProductionLogsApache.txt Hello Everybody, we implemented a multithread scheduler in order to run many FTP connections (one for each customer). We use these connections to upload /download files from/to remote servers. Inside the scheduler, we use a ScheduledThreadPoolExecutor to run our FTP connections (about 50). We run one thread (which instantiates an FTPClient object) for each FTP connection. Sometimes, one of those connections tries to connect to the FTP server and the method FTPClient.connect() hangs without any timeout. No log. No server response. The connection is blocked as well as the whole JVM. We needed to restart the service to fix the production. We already checked the following points during the issue: - the server is reachable; - No overlapping between run threads; - the virtual machine runs correctly; - Every other connection works correctly (FTPS, SFTP, CIFS, ...) so far. (Production logs attached) Thanks in advance, Simone -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (LANG-1572) implement TODO in CharSequenceUtils.indexOf : remake it.
[ https://issues.apache.org/jira/browse/LANG-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xu updated LANG-1572: - Priority: Major (was: Minor) > implement TODO in CharSequenceUtils.indexOf : remake it. > > > Key: LANG-1572 > URL: https://issues.apache.org/jira/browse/LANG-1572 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/560] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (LANG-1585) refine performance of StringUtils.normalizeSpace
Jin Xu created LANG-1585: Summary: refine performance of StringUtils.normalizeSpace Key: LANG-1585 URL: https://issues.apache.org/jira/browse/LANG-1585 Project: Commons Lang Issue Type: Sub-task Reporter: Jin Xu [https://github.com/apache/commons-lang/pull/574] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] coveralls commented on pull request #573: [LANG-1584] refine StringUtils.isNumericSpace
coveralls commented on pull request #573: URL: https://github.com/apache/commons-lang/pull/573#issuecomment-651035543 [](https://coveralls.io/builds/31743683) Coverage increased (+0.001%) to 94.68% when pulling **5dbcf2bf2e06f9930bd77f25bb11d39d29ce6ee9 on XenoAmess:refine_isNumericSpace** into **da0f6a8051cc60d1bebe703b4e390ce3035497db on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1584) refine StringUtils.isNumericSpace
[ https://issues.apache.org/jira/browse/LANG-1584?focusedWorklogId=452243=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-452243 ] ASF GitHub Bot logged work on LANG-1584: Author: ASF GitHub Bot Created on: 29/Jun/20 09:47 Start Date: 29/Jun/20 09:47 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #573: URL: https://github.com/apache/commons-lang/pull/573#issuecomment-651035543 [](https://coveralls.io/builds/31743683) Coverage increased (+0.001%) to 94.68% when pulling **5dbcf2bf2e06f9930bd77f25bb11d39d29ce6ee9 on XenoAmess:refine_isNumericSpace** into **da0f6a8051cc60d1bebe703b4e390ce3035497db on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 452243) Remaining Estimate: 0h Time Spent: 10m > refine StringUtils.isNumericSpace > -- > > Key: LANG-1584 > URL: https://issues.apache.org/jira/browse/LANG-1584 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > https://github.com/apache/commons-lang/pull/573 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] XenoAmess opened a new pull request #574: refine performance of StringUtils.normalizeSpace
XenoAmess opened a new pull request #574: URL: https://github.com/apache/commons-lang/pull/574 as title. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-codec] adamretter commented on pull request #46: Base16 Input and Output Streams
adamretter commented on pull request #46: URL: https://github.com/apache/commons-codec/pull/46#issuecomment-651022193 @aherbert I felt that the additional decode/encode methods that I added to Hex still have value; They allow the user to work with an existing byte array rather than the code allocation a fixed size array for them every time. The tests in HexTest accompany them. Arguably, I should move them to a separate PR as its a different feature. What do you prefer? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-codec] adamretter commented on a change in pull request #46: Base16 Input and Output Streams
adamretter commented on a change in pull request #46:
URL: https://github.com/apache/commons-codec/pull/46#discussion_r446865344
##
File path: src/main/java/org/apache/commons/codec/binary/Base16.java
##
@@ -0,0 +1,251 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.commons.codec.binary;
+
+import org.apache.commons.codec.CodecPolicy;
+
+/**
+ * Provides Base16 encoding and decoding.
+ *
+ *
+ * This class is thread-safe.
+ *
+ *
+ * @see https://tools.ietf.org/html/rfc4648#section-8;>RFC 4648 - 8.
Base 16 Encoding
+ *
+ * @since 1.15
+ */
+public class Base16 extends BaseNCodec {
+
+/**
+ * BASE16 characters are 4 bits in length.
+ * They are formed by taking an 8-bit group,
+ * which is converted into two BASE16 characters.
+ */
+private static final int BITS_PER_ENCODED_BYTE = 4;
+private static final int BYTES_PER_ENCODED_BLOCK = 2;
+private static final int BYTES_PER_UNENCODED_BLOCK = 1;
+
+/**
+ * This array is a lookup table that translates Unicode characters drawn
from the "Base16 Alphabet" (as specified
+ * in Table 5 of RFC 4648) into their 4-bit positive integer equivalents.
Characters that are not in the Base16
+ * alphabet but fall within the bounds of the array are translated to -1.
+ */
+private static final byte[] UPPER_CASE_DECODE_TABLE = {
+// 0 1 2 3 4 5 6 7 8 9 A B C D E F
+-1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, //
00-0f
+-1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, //
10-1f
+-1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, //
20-2f
+ 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, -1, -1, -1, -1, -1, -1, //
30-3f 0-9
+-1, 10, 11, 12, 13, 14, 15 //
40-46 A-F
+};
+
+/**
+ * This array is a lookup table that translates 4-bit positive integer
index values into their "Base16 Alphabet"
+ * equivalents as specified in Table 5 of RFC 4648.
+ */
+private static final byte[] UPPER_CASE_ENCODE_TABLE = {
+'0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
+'A', 'B', 'C', 'D', 'E', 'F'
+};
+
+/**
+ * This array is a lookup table that translates Unicode characters drawn
from the a lower-case "Base16 Alphabet"
+ * into their 4-bit positive integer equivalents. Characters that are not
in the Base16
+ * alphabet but fall within the bounds of the array are translated to -1.
+ */
+private static final byte[] LOWER_CASE_DECODE_TABLE = {
+// 0 1 2 3 4 5 6 7 8 9 A B C D E F
+-1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, //
00-0f
+-1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, //
10-1f
+-1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, //
20-2f
+ 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, -1, -1, -1, -1, -1, -1, //
30-3f 0-9
+-1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, //
40-4f
+-1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, //
50-5f
+-1, 10, 11, 12, 13, 14, 15 //
60-66 a-f
+};
+
+/**
+ * This array is a lookup table that translates 4-bit positive integer
index values into their "Base16 Alphabet"
+ * lower-case equivalents.
+ */
+private static final byte[] LOWER_CASE_ENCODE_TABLE = {
+'0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
+'a', 'b', 'c', 'd', 'e', 'f'
+};
+
+/** Mask used to extract 4 bits, used when decoding character. */
+private static final int MASK_4BITS = 0x0f;
+
+/**
+ * Decode table to use.
+ */
+private final byte[] decodeTable;
+
+/**
+ * Encode table to use.
+ */
+private final byte[] encodeTable;
+
+/**
+ * Creates a Base16 codec used for decoding and encoding.
+ */
+public Base16() {
+this(false);
+}
+
+/**
+ * Creates a Base16 codec used for decoding and encoding.
+ *
+
[jira] [Work logged] (LANG-1582) refine StringUtils.indexOfDifference
[ https://issues.apache.org/jira/browse/LANG-1582?focusedWorklogId=452229=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-452229 ] ASF GitHub Bot logged work on LANG-1582: Author: ASF GitHub Bot Created on: 29/Jun/20 08:41 Start Date: 29/Jun/20 08:41 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #571: URL: https://github.com/apache/commons-lang/pull/571#issuecomment-651019968 [](https://coveralls.io/builds/31742984) Coverage decreased (-0.001%) to 94.677% when pulling **31b6e699a56f789d67bbd46cd1a75c048fc1261c on XenoAmess:refine_indexOfDifference** into **da0f6a8051cc60d1bebe703b4e390ce3035497db on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 452229) Remaining Estimate: 0h Time Spent: 10m > refine StringUtils.indexOfDifference > - > > Key: LANG-1582 > URL: https://issues.apache.org/jira/browse/LANG-1582 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/571] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] coveralls commented on pull request #571: [LANG-1582] refine StringUtils.indexOfDifference
coveralls commented on pull request #571: URL: https://github.com/apache/commons-lang/pull/571#issuecomment-651019968 [](https://coveralls.io/builds/31742984) Coverage decreased (-0.001%) to 94.677% when pulling **31b6e699a56f789d67bbd46cd1a75c048fc1261c on XenoAmess:refine_indexOfDifference** into **da0f6a8051cc60d1bebe703b4e390ce3035497db on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (LANG-1584) refine StringUtils.isNumericSpace
Jin Xu created LANG-1584: Summary: refine StringUtils.isNumericSpace Key: LANG-1584 URL: https://issues.apache.org/jira/browse/LANG-1584 Project: Commons Lang Issue Type: Sub-task Reporter: Jin Xu https://github.com/apache/commons-lang/pull/573 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] XenoAmess opened a new pull request #573: refine StringUtils.isNumericSpace
XenoAmess opened a new pull request #573: URL: https://github.com/apache/commons-lang/pull/573 reduce calling charAt several times. also change order to try to reduce function calls. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (NET-684) Most images aren't downloaded completely from an FTP server
[ https://issues.apache.org/jira/browse/NET-684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147606#comment-17147606 ] JRRR edited comment on NET-684 at 6/29/20, 8:17 AM: This problem isn't resolved, it's still happening. Sometimes it might take multiple tries (it doesn't seem to happen to really, really small images, e.g. 12kb ones) but eventually there'll be files that are corrupt. I don't use macOS. I created an Android app (run on Windows, also tested on an actual Android device) that downloads files from a Windows server or a Linux server in the same network and there are almost always files that are affected. I don't know why but the tests with DLP Test have been successful so far but, like I said, there's no guarantee that it'll always work with that one because I can't run any longer, proper tests if files are being deleted after 30 minutes. Btw, it also affects text files (tested with 13mb ones) but those are usually only missing a single byte (rarely more) and it happens less often, that's why I didn't notice it straight away. So can you please re-open the issue. was (Author: jrrr): This problem isn't resolved, it's still happening. Sometimes it might take multiple tries (it doesn't seem to happen to really, really small images, e.g. 12kb ones) but eventually there'll be files that are corrupt. I don't use macOS. I created an Android app (run on Windows, also tested on an actual Android device) that downloads files from a Windows server or a Linux server in the same network and there are almost always files that are affected. I don't know why but the tests with DLP Test have been successful so far but, like I said, there's no guarantee that it'll always work with that one because I can't run any longer, proper tests if files are being deleted after 30 minutes. So can you please re-open the issue. > Most images aren't downloaded completely from an FTP server > --- > > Key: NET-684 > URL: https://issues.apache.org/jira/browse/NET-684 > Project: Commons Net > Issue Type: Bug > Components: FTP >Affects Versions: 3.6 > Environment: Win 10, Java 8, Android Studio 3.6.1, target Android > SDK=27 >Reporter: JRRR >Priority: Major > Attachments: DownloadProblem.java > > > Downloading images from an FTP server succeeds but the resulting images are > incomplete (black/transparent parts at the bottom) or faulty (wrong > colors/visual artifacts) most of the time. > > You can find examples and full code in > [this|http://mail-archives.apache.org/mod_mbox/commons-user/202005.mbox/%3C000b01d6341c%246a66f7f0%243f34e7d0%24%40simutech.at%3E] > mailing list thread. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NET-684) Most images aren't downloaded completely from an FTP server
[ https://issues.apache.org/jira/browse/NET-684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147606#comment-17147606 ] JRRR commented on NET-684: -- This problem isn't resolved, it's still happening. Sometimes it might take multiple tries (it doesn't seem to happen to really, really small images, e.g. 12kb ones) but eventually there'll be files that are corrupt. I don't use macOS. I created an Android app (run on Windows, also tested on an actual Android device) that downloads files from a Windows server or a Linux server in the same network and there are almost always files that are affected. I don't know why but the tests with DLP Test have been successful so far but, like I said, there's no guarantee that it'll always work with that one because I can't run any longer, proper tests if files are being deleted after 30 minutes. So can you please re-open the issue. > Most images aren't downloaded completely from an FTP server > --- > > Key: NET-684 > URL: https://issues.apache.org/jira/browse/NET-684 > Project: Commons Net > Issue Type: Bug > Components: FTP >Affects Versions: 3.6 > Environment: Win 10, Java 8, Android Studio 3.6.1, target Android > SDK=27 >Reporter: JRRR >Priority: Major > Attachments: DownloadProblem.java > > > Downloading images from an FTP server succeeds but the resulting images are > incomplete (black/transparent parts at the bottom) or faulty (wrong > colors/visual artifacts) most of the time. > > You can find examples and full code in > [this|http://mail-archives.apache.org/mod_mbox/commons-user/202005.mbox/%3C000b01d6341c%246a66f7f0%243f34e7d0%24%40simutech.at%3E] > mailing list thread. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (LANG-1583) refine StringUtils.isMixedCase
Jin Xu created LANG-1583: Summary: refine StringUtils.isMixedCase Key: LANG-1583 URL: https://issues.apache.org/jira/browse/LANG-1583 Project: Commons Lang Issue Type: Sub-task Reporter: Jin Xu [https://github.com/apache/commons-lang/pull/572] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] XenoAmess opened a new pull request #572: refine isMixedCase
XenoAmess opened a new pull request #572: URL: https://github.com/apache/commons-lang/pull/572 remake it for better performance. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1581) refine StringUtils.getFuzzyDistance
[ https://issues.apache.org/jira/browse/LANG-1581?focusedWorklogId=452205=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-452205 ] ASF GitHub Bot logged work on LANG-1581: Author: ASF GitHub Bot Created on: 29/Jun/20 07:59 Start Date: 29/Jun/20 07:59 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #570: URL: https://github.com/apache/commons-lang/pull/570#issuecomment-650997920 [](https://coveralls.io/builds/31742068) Coverage remained the same at 94.679% when pulling **6a89188b78090ad87ac07c9d64fad17e280e on XenoAmess:refine_getFuzzyDistance** into **da0f6a8051cc60d1bebe703b4e390ce3035497db on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 452205) Remaining Estimate: 0h Time Spent: 10m > refine StringUtils.getFuzzyDistance > --- > > Key: LANG-1581 > URL: https://issues.apache.org/jira/browse/LANG-1581 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/570] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] coveralls commented on pull request #570: [LANG-1581] refine StringUtils.getFuzzyDistance
coveralls commented on pull request #570: URL: https://github.com/apache/commons-lang/pull/570#issuecomment-650997920 [](https://coveralls.io/builds/31742068) Coverage remained the same at 94.679% when pulling **6a89188b78090ad87ac07c9d64fad17e280e on XenoAmess:refine_getFuzzyDistance** into **da0f6a8051cc60d1bebe703b4e390ce3035497db on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (LANG-1582) refine StringUtils.indexOfDifference
Jin Xu created LANG-1582: Summary: refine StringUtils.indexOfDifference Key: LANG-1582 URL: https://issues.apache.org/jira/browse/LANG-1582 Project: Commons Lang Issue Type: Sub-task Reporter: Jin Xu [https://github.com/apache/commons-lang/pull/571] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] XenoAmess opened a new pull request #571: refine indexOfDifference
XenoAmess opened a new pull request #571: URL: https://github.com/apache/commons-lang/pull/571 break loop. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Issue Comment Deleted] (VFS-748) TarProvider Incorrectly marks file IMAGINARY after garbage collection with weakRefFilesCache
[ https://issues.apache.org/jira/browse/VFS-748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] linchen updated VFS-748: Comment: was deleted (was: Pass the test case you gave， tbz2 and tgz are extension-map with tar in providers.xml. In other words, parsing tbz2 and tgz files requires TarFileSystem.java for processing. According to the comment on line 210 of the code TarFileSystem.java : "This is only called for files which do not exist in the Tar file", I have reason to believe that this is in line with the author's expectations. ) > TarProvider Incorrectly marks file IMAGINARY after garbage collection with > weakRefFilesCache > > > Key: VFS-748 > URL: https://issues.apache.org/jira/browse/VFS-748 > Project: Commons VFS > Issue Type: Bug >Affects Versions: 2.2 > Environment: commons-vfs2.2.jar > commons-compress-1.18.jar >Reporter: Tim >Priority: Major > Attachments: TarBug.java, test.tar.gz > > > A Tar FileObject becomes unusable once it is removed from the filesCache. > The example provided here uses the the WeakRefFilesCache but I suspect the > bug is not limited to this cache type only, since it is the recreation of the > entry after removal that is flawed. > > The following code snippet will repeatedly access the the tarball until > garbage collection occurs. When this happens the cache entry is dropped but > upon reaccess, a new cache entry is created that incorrectly marks the file > as "IMAGINARY". All subsequent access to this file is are not possible in > the VM. > > Output from the class provided looks like this > 97 > 98 > 99 > 100 > tgz:[file:///C:/env/ws/vfsTarBug/target/classes/test.tar.gz!/] did not exist > > The number of successful iterations may vary depending upon the behavior of > the GC. > Tracing the run, the culprit appears to be a createFile method which hard > codes the tarExists argument to false when it should be true. The stack > trace for this appears below. > at > org.apache.commons.vfs2.provider.tar.TarFileSystem.createFile(TarFileSystem.java:210)at > > org.apache.commons.vfs2.provider.tar.TarFileSystem.createFile(TarFileSystem.java:210) > at > org.apache.commons.vfs2.provider.AbstractFileSystem.resolveFile(AbstractFileSystem.java:320) > - locked <0x53d2> (a org.apache.commons.vfs2.provider.tar.TarFileSystem) > at > org.apache.commons.vfs2.provider.AbstractFileSystem.resolveFile(AbstractFileSystem.java:300) > at > org.apache.commons.vfs2.provider.AbstractFileSystem.getRoot(AbstractFileSystem.java:274) > at > org.apache.commons.vfs2.provider.AbstractLayeredFileProvider.createFileSystem(AbstractLayeredFileProvider.java:82) > - locked <0x53e2> (a org.apache.commons.vfs2.provider.tar.TarFileProvider) > at > org.apache.commons.vfs2.provider.AbstractLayeredFileProvider.findFile(AbstractLayeredFileProvider.java:56) > at > org.apache.commons.vfs2.impl.DefaultFileSystemManager.resolveFile(DefaultFileSystemManager.java:711) > at > org.pentaho.di.core.vfs.ConcurrentFileSystemManager.resolveFile(ConcurrentFileSystemManager.java:91) > at > org.apache.commons.vfs2.impl.DefaultFileSystemManager.resolveFile(DefaultFileSystemManager.java:648) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1580) refine StringUtils.deleteWhitespace
[ https://issues.apache.org/jira/browse/LANG-1580?focusedWorklogId=452191=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-452191 ] ASF GitHub Bot logged work on LANG-1580: Author: ASF GitHub Bot Created on: 29/Jun/20 07:11 Start Date: 29/Jun/20 07:11 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #569: URL: https://github.com/apache/commons-lang/pull/569#issuecomment-650976309 [](https://coveralls.io/builds/31741600) Coverage increased (+0.0007%) to 94.679% when pulling **80c32ac2b496e96c487c335651d2c96212cce4e6 on XenoAmess:refine_deleteWhitespace** into **da0f6a8051cc60d1bebe703b4e390ce3035497db on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 452191) Remaining Estimate: 0h Time Spent: 10m > refine StringUtils.deleteWhitespace > --- > > Key: LANG-1580 > URL: https://issues.apache.org/jira/browse/LANG-1580 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/569] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] coveralls commented on pull request #569: [LANG-1580] refine StringUtils.deleteWhitespace
coveralls commented on pull request #569: URL: https://github.com/apache/commons-lang/pull/569#issuecomment-650976309 [](https://coveralls.io/builds/31741600) Coverage increased (+0.0007%) to 94.679% when pulling **80c32ac2b496e96c487c335651d2c96212cce4e6 on XenoAmess:refine_deleteWhitespace** into **da0f6a8051cc60d1bebe703b4e390ce3035497db on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] XenoAmess edited a comment on pull request #564: add passing varargs Supplier to ObjectUtils.getIfNull instead of Supplier single param
XenoAmess edited a comment on pull request #564: URL: https://github.com/apache/commons-lang/pull/564#issuecomment-650971782 > checks failed because of incompatibility, that is actually no true No it is. you can reproduce by: 0. compile original commons-lang to original-commons-lang.jar 1. create another repo who use original-commons-lang.jar as a lib, named A. 2. compile A into a jar. 3. make sure the A.jar can run correctly with original-commons-lang.jar 4. apply your changes to the codes in commons-lang. 5. compile commons-lang to modified-commons-lang.jar 6. run A.jar with modified-commons-lang.jar I strongly guess it will fail. Varargs is not that convienent, my friend. If you really want a varargs version of that function you can create one, but don't delete the original function. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] XenoAmess commented on pull request #564: add passing varargs Supplier to ObjectUtils.getIfNull instead of Supplier single param
XenoAmess commented on pull request #564: URL: https://github.com/apache/commons-lang/pull/564#issuecomment-650971782 > checks failed because of incompatibility, that is actually no true No it is. you can reproduce by: 0. compile original commons-lang to original-commons-lang.jar 1. create another repo who use original-commons-lang.jar as a lib, named A. 2. compile A into a jar. 3. make sure the A.jar can run correctly with original-commons-lang.jar 4. apply your changes to the codes in commons-lang. 5. compile commons-lang to modified-commons-lang.jar 6. run A.jar with modified-commons-lang.jar I strongly guess it will fail. Varargs is not that convienent, my friend. If you really want a varargs version of that function you can create one, but don't delete the original function. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (LANG-1581) refine StringUtils.getFuzzyDistance
Jin Xu created LANG-1581: Summary: refine StringUtils.getFuzzyDistance Key: LANG-1581 URL: https://issues.apache.org/jira/browse/LANG-1581 Project: Commons Lang Issue Type: Sub-task Reporter: Jin Xu [https://github.com/apache/commons-lang/pull/570] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] XenoAmess opened a new pull request #570: refine StringUtils.getFuzzyDistance
XenoAmess opened a new pull request #570: URL: https://github.com/apache/commons-lang/pull/570 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (LANG-1579) refine StringUtils.convertRemainingAccentCharacters
[ https://issues.apache.org/jira/browse/LANG-1579?focusedWorklogId=452185=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-452185 ] ASF GitHub Bot logged work on LANG-1579: Author: ASF GitHub Bot Created on: 29/Jun/20 06:53 Start Date: 29/Jun/20 06:53 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #568: URL: https://github.com/apache/commons-lang/pull/568#issuecomment-650968757 [](https://coveralls.io/builds/31741335) Coverage decreased (-0.0007%) to 94.678% when pulling **b5cf43a26b1c1d709f83f4b5f75946a51fe0a95e on XenoAmess:refine_convertRemainingAccentCharacters** into **da0f6a8051cc60d1bebe703b4e390ce3035497db on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 452185) Remaining Estimate: 0h Time Spent: 10m > refine StringUtils.convertRemainingAccentCharacters > > > Key: LANG-1579 > URL: https://issues.apache.org/jira/browse/LANG-1579 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/568] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] coveralls commented on pull request #568: [LANG-1579] refine StringUtils.convertRemainingAccentCharacters
coveralls commented on pull request #568: URL: https://github.com/apache/commons-lang/pull/568#issuecomment-650968757 [](https://coveralls.io/builds/31741335) Coverage decreased (-0.0007%) to 94.678% when pulling **b5cf43a26b1c1d709f83f4b5f75946a51fe0a95e on XenoAmess:refine_convertRemainingAccentCharacters** into **da0f6a8051cc60d1bebe703b4e390ce3035497db on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] ytanikin edited a comment on pull request #564: add passing varargs Supplier to ObjectUtils.getIfNull instead of Supplier single param
ytanikin edited a comment on pull request #564: URL: https://github.com/apache/commons-lang/pull/564#issuecomment-650965610 checks failed because of incompatibility, that is actually no true, after changing single param to varargs it is compatible [ERROR] Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.14.3:cmp (default-cli) on project commons-lang3: There is at least one incompatibility: org.apache.commons.lang3.ObjectUtils.getIfNull(java.lang.Object,java.util.function.Supplier):METHOD_REMOVED -> [Help 1] how to change it and rerun checks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-lang] ytanikin commented on pull request #564: add passing varargs Supplier to ObjectUtils.getIfNull instead of Supplier single param
ytanikin commented on pull request #564: URL: https://github.com/apache/commons-lang/pull/564#issuecomment-650965610 checks failed because of incompatibility, that is actually no true, after changing single param to varargs it is compatible [ERROR] Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.14.3:cmp (default-cli) on project commons-lang3: There is at least one incompatibility: org.apache.commons.lang3.ObjectUtils.getIfNull(java.lang.Object,java.util.function.Supplier):METHOD_REMOVED -> [Help 1] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (LANG-1580) refine StringUtils.deleteWhitespace
Jin Xu created LANG-1580: Summary: refine StringUtils.deleteWhitespace Key: LANG-1580 URL: https://issues.apache.org/jira/browse/LANG-1580 Project: Commons Lang Issue Type: Sub-task Reporter: Jin Xu [https://github.com/apache/commons-lang/pull/569] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] XenoAmess opened a new pull request #569: refine StringUtils.deleteWhitespace
XenoAmess opened a new pull request #569: URL: https://github.com/apache/commons-lang/pull/569 don't create more empty String. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (LANG-1579) refine StringUtils.convertRemainingAccentCharacters
Jin Xu created LANG-1579: Summary: refine StringUtils.convertRemainingAccentCharacters Key: LANG-1579 URL: https://issues.apache.org/jira/browse/LANG-1579 Project: Commons Lang Issue Type: Sub-task Reporter: Jin Xu [https://github.com/apache/commons-lang/pull/568] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] XenoAmess opened a new pull request #568: refine StringUtils.convertRemainingAccentCharacters
XenoAmess opened a new pull request #568: URL: https://github.com/apache/commons-lang/pull/568 as title. reduce array copy, for two times. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
