[GitHub] [commons-fileupload] coveralls commented on pull request #94: Replace indexOf() with contains()
coveralls commented on pull request #94: URL: https://github.com/apache/commons-fileupload/pull/94#issuecomment-847523151 [](https://coveralls.io/builds/39972246) Coverage remained the same at 78.278% when pulling **7f02be4a08481fe319126b797353f641e9a42214 on arturobernalg:feature/use_contains** into **516552828b7ee2a9ac2e5d58c987cccedd0aa857 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-fileupload] arturobernalg opened a new pull request #94: Replace indexOf() with contains()
arturobernalg opened a new pull request #94: URL: https://github.com/apache/commons-fileupload/pull/94 jsparrow --> 'Most checks against an indexOf value compare it with -1 because 0 is a valid index. Any checks which look for values >0 ignore the first element, which is likely a bug. If the intent is merely to check inclusion of a value in a String or a List, the contains method is better suited to express this intent. Clearer intent means better readability.' -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] PeterAlfredLee commented on pull request #199: Whitespace improvement, site nits and assorted typos
PeterAlfredLee commented on pull request #199: URL: https://github.com/apache/commons-compress/pull/199#issuecomment-847466251 > The idea was to only keep this one, as it gathers all changes away, in the hope that mixing slightly different things, I see. So this PR contains some typo fix and reformatings. > Otherwise I'll also close this PR and try resubmit all three. What do you think? This PR looks good to me. WDYT @bodewig ? > If there's a need to resubmit the PR I'll take that into consideration. You don't have to resubmit a PR to squash commits. A `git rebase` and a `git push --force` in your branch `HelderMagalhaes:assorted-typos` is enough. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (RNG-137) Move class from "Commons Math"
Gilles Sadowski created RNG-137:
---
Summary: Move class from "Commons Math"
Key: RNG-137
URL: https://issues.apache.org/jira/browse/RNG-137
Project: Commons RNG
Issue Type: Task
Components: sampling
Reporter: Gilles Sadowski
Fix For: 1.4
Shouldn't CM's class
[{{StableRandomGenerator}}|https://gitbox.apache.org/repos/asf?p=commons-math.git;a=blob;f=src/main/java/org/apache/commons/math4/random/StableRandomGenerator.java;h=f3a851b9b16c47546cac8371e272dbf59a909c09;hb=HEAD]
be moved to the{{commons-rng-sampling}} module?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (JEXL-347) Missing unsolvable property exception for reference when used with equals
Cameron Samak created JEXL-347:
--
Summary: Missing unsolvable property exception for reference when
used with equals
Key: JEXL-347
URL: https://issues.apache.org/jira/browse/JEXL-347
Project: Commons JEXL
Issue Type: Bug
Reporter: Cameron Samak
I expected {code}A.B == 5{code} (with a strict engine and with nothing in the
context) to result in an unsolvable property exception, but instead the result
was false.
I hit this as part of an attempt to upgrade from 3.0 to a recent snapshot. I
think the change in behavior may be related to the addition of ASTEQNode and
ASTNENode to isTernaryProtected?
Is it intentional that equal and not equal are handled this way when e.g.
greater than or less than are not? If so, is there any option flag that can
restore the behavior?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (RNG-44) Invalid links on web site
[ https://issues.apache.org/jira/browse/RNG-44?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles Sadowski updated RNG-44: --- Description: On [that page|http://commons.apache.org/proper/commons-rng/commons-rng-client-api/scm.html] (and similar for the other maven modules), the "Web Browser Access" link points to a non-existing project (because the module name is appended to the URL of the git repository). (was: On [that page|http://commons.apache.org/proper/commons-rng/commons-rng-client-api/source-repository.html] (and similar for the other maven modules), the "Web Browser Access" link points to a non-existing project (because the module name is appended to the URL of the git repository).) > Invalid links on web site > - > > Key: RNG-44 > URL: https://issues.apache.org/jira/browse/RNG-44 > Project: Commons RNG > Issue Type: Bug >Reporter: Gilles Sadowski >Priority: Minor > Labels: web-site > > On [that > page|http://commons.apache.org/proper/commons-rng/commons-rng-client-api/scm.html] > (and similar for the other maven modules), the "Web Browser Access" link > points to a non-existing project (because the module name is appended to the > URL of the git repository). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (MATH-1410) "MultiStartMultivariateOptimizerTest" is shaky
[ https://issues.apache.org/jira/browse/MATH-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles Sadowski resolved MATH-1410. --- Resolution: Workaround Random seeds and retries make the tests pass (commit ad5f0dac37c3b5f7604d18747f0af434b83d7632 in "modularized_master" branch). > "MultiStartMultivariateOptimizerTest" is shaky > -- > > Key: MATH-1410 > URL: https://issues.apache.org/jira/browse/MATH-1410 > Project: Commons Math > Issue Type: Test >Reporter: Gilles Sadowski >Priority: Minor > Labels: unit-test > Fix For: 4.X > > > The "testRosenbrock" test method (package "o.a.c.m.optim.nonlinear.scalar") > is too sensitive to the seed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-lang] ThrawnCA commented on pull request #278: Lang-1345 Enhance non-empty strings
ThrawnCA commented on pull request #278: URL: https://github.com/apache/commons-lang/pull/278#issuecomment-847403364 Just came across another use case for this. One of our systems is retrieving customer email addresses, if provided, and decorating them with the customer's name, eg `John Smith `. If there is no email address, then it should return an empty string, rather than `John Smith <>`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MATH-1576) Reinstate "checkstyle"
[ https://issues.apache.org/jira/browse/MATH-1576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350653#comment-17350653 ] Gilles Sadowski commented on MATH-1576: --- bq. I am will to put some time into fixing checkstyle for the new modules. Thanks. > Reinstate "checkstyle" > -- > > Key: MATH-1576 > URL: https://issues.apache.org/jira/browse/MATH-1576 > Project: Commons Math > Issue Type: Sub-task >Reporter: Gilles Sadowski >Priority: Critical > Labels: checkstyle > Fix For: 4.0 > > > Modularization configuration was copied from Commons Numbers that used a > newer Checkstyle with a different syntax. The checks trigger more than 31000 > errors in Commons Math; so all checks have been disabled. :( > The syntax of the configuration that worked before modularization should be > adapted to the new syntax... -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NUMBERS-156) SafeNorm 3D overload
[
https://issues.apache.org/jira/browse/NUMBERS-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350645#comment-17350645
]
Matt Juntunen commented on NUMBERS-156:
---
bq. The method extLinearSinglePass is missing from the performance chart for
lengths 1 to 5.
Oops. Fixed now.
> SafeNorm 3D overload
>
>
> Key: NUMBERS-156
> URL: https://issues.apache.org/jira/browse/NUMBERS-156
> Project: Commons Numbers
> Issue Type: Improvement
>Reporter: Matt Juntunen
>Priority: Major
> Attachments: performance-all.png, performance-len-1-5.png,
> performance2-1-5.png, performance2-all.png, performance3-1-5.png,
> performance3-all.png, performance4-1-5.png, performance4-all.png
>
>
> We should create an overload of {{SafeNorm.value}} that accepts 3 arguments
> to potentially improve performance for 3D vectors.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (NUMBERS-156) SafeNorm 3D overload
[
https://issues.apache.org/jira/browse/NUMBERS-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350398#comment-17350398
]
Matt Juntunen edited comment on NUMBERS-156 at 5/24/21, 9:45 PM:
-
Thanks for the fix, Alex. I'm made the updates and run the tests again. I've
also added another version using the linear combination code that only makes a
single pass through the input array, following the same procedure as {{enorm}}.
The new method is called {{extLinearSinglePass}}. (Note that I've left the
standard precision methods out of the tests with the exception of {{direct}}).
||name||input type||error mean||error std dev||error min||error max||failed||
|direct|high|NaN|-0.00|Infinity|-Infinity|20|
|enormModExt|high|-0.00121|0.375|-1.00|1.00|0|
|extLinear|high|-0.00129|0.367|-1.00|1.00|0|
|extLinearMod|high|-0.00129|0.367|-1.00|1.00|0|
|extLinearSinglePass|high|-0.00129|0.367|-1.00|1.00|0|
|direct|high-thresh|-0.00208|1.02|-5.00|6.00|0|
|enormModExt|high-thresh|-0.000570|0.374|-1.00|1.00|0|
|extLinear|high-thresh|-0.000650|0.367|-1.00|1.00|0|
|extLinearMod|high-thresh|-0.000650|0.367|-1.00|1.00|0|
|extLinearSinglePass|high-thresh|-0.000650|0.367|-1.00|1.00|0|
|direct|mid|-0.00237|1.02|-6.00|6.00|0|
|enormModExt|mid|-0.000860|0.385|-1.00|1.00|0|
|extLinear|mid|-0.000940|0.378|-1.00|1.00|0|
|extLinearMod|mid|-0.000940|0.378|-1.00|1.00|0|
|extLinearSinglePass|mid|-0.000940|0.378|-1.00|1.00|0|
|exact|low-thresh|0.00|0.00|0.00|0.00|0|
|direct|low-thresh|-0.00206|1.02|-5.00|6.00|0|
|enormModExt|low-thresh|-0.000550|0.374|-1.00|1.00|0|
|extLinear|low-thresh|-0.000630|0.366|-1.00|1.00|0|
|extLinearMod|low-thresh|-0.000630|0.366|-1.00|1.00|0|
|extLinearSinglePass|low-thresh|-0.000630|0.366|-1.00|1.00|0|
|direct|low|5.76e+04|1.87e+05|-2.52e+06|2.57e+06|0|
|enormModExt|low|-0.00292|1.02|-5.00|6.00|0|
|extLinear|low|-0.00149|0.367|-1.00|1.00|0|
|extLinearMod|low|-0.00149|0.367|-1.00|1.00|0|
|extLinearSinglePass|low|-0.00149|0.367|-1.00|1.00|0|
|direct|full|0.00253|0.497|-2.00|1.00|194074|
|enormModExt|full|-0.000810|0.469|-2.00|1.00|0|
|extLinear|full|0.00149|0.438|-1.00|1.00|0|
|extLinearMod|full|0.00149|0.438|-1.00|1.00|0|
|extLinearSinglePass|full|0.00149|0.438|-1.00|1.00|0|
!performance4-all.png!
!performance4-1-5.png!
It seems like {{extLinearSinglePass}} may be the way to go here since it is
showing the same accuracy as the other {{extLinear}} methods but with improved
performance. The code for this can be found
[here|https://github.com/darkma773r/commons-numbers/blob/vector-methods/commons-numbers-examples/examples-jmh/src/main/java/org/apache/commons/numbers/examples/jmh/arrays/EuclideanNormAlgorithms.java#L483].
was (Author: mattjuntunen):
Thanks for the fix, Alex. I'm made the updates and run the tests again. I've
also added another version using the linear combination code that only makes a
single pass through the input array, following the same procedure as {{enorm}}.
The new method is called {{extLinearSinglePass}}. (Note that I've left the
standard precision methods out of the tests with the exception of {{direct}}).
||name||input type||error mean||error std dev||error min||error max||failed||
|direct|high|NaN|-0.00|Infinity|-Infinity|20|
|enormModExt|high|-0.00121|0.375|-1.00|1.00|0|
|extLinear|high|-0.00129|0.367|-1.00|1.00|0|
|extLinearMod|high|-0.00129|0.367|-1.00|1.00|0|
|extLinearSinglePass|high|-0.00129|0.367|-1.00|1.00|0|
|direct|high-thresh|-0.00208|1.02|-5.00|6.00|0|
|enormModExt|high-thresh|-0.000570|0.374|-1.00|1.00|0|
|extLinear|high-thresh|-0.000650|0.367|-1.00|1.00|0|
|extLinearMod|high-thresh|-0.000650|0.367|-1.00|1.00|0|
|extLinearSinglePass|high-thresh|-0.000650|0.367|-1.00|1.00|0|
|direct|mid|-0.00237|1.02|-6.00|6.00|0|
|enormModExt|mid|-0.000860|0.385|-1.00|1.00|0|
|extLinear|mid|-0.000940|0.378|-1.00|1.00|0|
|extLinearMod|mid|-0.000940|0.378|-1.00|1.00|0|
|extLinearSinglePass|mid|-0.000940|0.378|-1.00|1.00|0|
|exact|low-thresh|0.00|0.00|0.00|0.00|0|
|direct|low-thresh|-0.00206|1.02|-5.00|6.00|0|
|enormModExt|low-thresh|-0.000550|0.374|-1.00|1.00|0|
|extLinear|low-thresh|-0.000630|0.366|-1.00|1.00|0|
|extLinearMod|low-thresh|-0.000630|0.366|-1.00|1.00|0|
|extLinearSinglePass|low-thresh|-0.000630|0.366|-1.00|1.00|0|
|direct|low|5.76e+04|1.87e+05|-2.52e+06|2.57e+06|0|
|enormModExt|low|-0.00292|1.02|-5.00|6.00|0|
|extLinear|low|-0.00149|0.367|-1.00|1.00|0|
|extLinearMod|low|-0.00149|0.367|-1.00|1.00|0|
|extLinearSinglePass|low|-0.00149|0.367|-1.00|1.00|0|
|direct|full|0.00253|0.497|-2.00|1.00|194074|
|enormModExt|full|-0.000810|0.469|-2.00|1.00|0|
|extLinear|full|0.00149|0.438|-1.00|1.00|0|
|extLinearMod|full|0.00149|0.438|-1.00|1.00|0|
|extLinearSinglePass|full|0.00149|0.438|-1.00|1.00|0|
!performance4-all.png!
!performance3-1-5.png!
It seems like {{extLinearSinglePass}} may be the way to go here since it is
showing the same accuracy as the other
[jira] [Commented] (MATH-1576) Reinstate "checkstyle"
[
https://issues.apache.org/jira/browse/MATH-1576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350609#comment-17350609
]
Alex Herbert commented on MATH-1576:
For reference you can view the checkstyle reports by:
Updating {{src/main/resources/checkstyle-suppressions.xml}} to remove the
suppression of everything.
Installing locally the artifacts just to allow the project multi-module
dependencies to be present:
{noformat}
mvn install -DskipTests -Dcheckstyle.skip
{noformat}
I then updated the main pom.xml to change the checkstyle configuration:
{noformat}
true
{noformat}
This will produce a summary of which rules are broken and how many times.
Generate the cross-linked checkstyle reports using:
{noformat}
mvn jxr:jxr jxr:test-jxr checkstyle:checkstyle
{noformat}
The checkstyle reports are then in each module in
{{target/site/checkstyle.html}} which you can open in a browser for local
viewing.
The jxr plugin output (a html-based, cross referenced version of Java source
code) will be correctly linked in the checkstyle report for the main code. Test
code is built by jxr into {{target/site/xref-test}}. The link in the checkstyle
report still uses {{target/site/xref}}. This seems to be a long standing
checkstyle bug in the report goal. But if you click the link the url can be
edited in the browser to change xref to xref-test and then jump to the
offending code. It helps view what the report is detailing.
Looking at the report for the main cm legacy module it seems there are a lot of
issues with indentation and a different opinion on what whitespace is allowed;
these are rules that could be ignored for now. That would remove about over
25,000 errors. Other errors are spread across the range of rules.
I suggest a way forward is to leave the checkstyle configuration in the parent
pom as is. Then update the configuration in cm legacy to use a different
checkstyle suppressions file to suppress warnings and/or a simplified
checkstyle ruleset. All other modules that have been ported from cm legacy for
development should be updated to the stricter rules. Currently the error count
is:
{noformat}
[INFO] There are 222 errors ... commons-math-neuralnet/../...
[INFO] There are 123 errors ... commons-math-transform/../...
[INFO] There are 34766 errors ... commons-math-legacy/../...
[INFO] There are 3 errors ... commons-math-examples/examples-sofm/../../...
[INFO] There are 27 errors ...
commons-math-examples/examples-sofm/chinese-rings/../../../...
[INFO] There are 37 errors ...
commons-math-examples/examples-sofm/tsp/../../../...
{noformat}
Updating a module involves putting this in the child POM:
{code:xml}
org.apache.maven.plugins
maven-checkstyle-plugin
${math.parent.dir}/src/main/resources/checkstyle/checkstyle-legacy.xml
${math.parent.dir}/src/main/resources/checkstyle/checkstyle-suppressions-legacy.xml
{code}
With corresponding files in the main parent resource folder copied for the
checkstyle-legacy configuration. This prevented any errors from the cm legacy
module when I tested it.
New modules will be easily updated to the new syntax due to the low number of
errors. The old legacy module can be updated with less strict rules and then
the remaining errors suppressed on a package basis. Packages can then be
updated over time to pass the rules and the suppressions lifted.
I am will to put some time into fixing checkstyle for the new modules. I can
then try and reduce the amount of errors for the old legacy modules with some
rule tweaking and fixing the source when I have free time.
> Reinstate "checkstyle"
> --
>
> Key: MATH-1576
> URL: https://issues.apache.org/jira/browse/MATH-1576
> Project: Commons Math
> Issue Type: Sub-task
>Reporter: Gilles Sadowski
>Priority: Critical
> Labels: checkstyle
> Fix For: 4.0
>
>
> Modularization configuration was copied from Commons Numbers that used a
> newer Checkstyle with a different syntax. The checks trigger more than 31000
> errors in Commons Math; so all checks have been disabled. :(
> The syntax of the configuration that worked before modularization should be
> adapted to the new syntax...
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (COMPRESS-581) Make getLocalHeaderOffset() public
Franck Valentin created COMPRESS-581: Summary: Make getLocalHeaderOffset() public Key: COMPRESS-581 URL: https://issues.apache.org/jira/browse/COMPRESS-581 Project: Commons Compress Issue Type: Wish Affects Versions: 1.20 Reporter: Franck Valentin Hi, I use this library to analyse zip files and get the entries and to do so I need to get the entries together with their offsets within the archive. I use ZipArchiveEntry but the issue is that getLocalHeaderOffset() is protected instead of being public. Looking at the source code I don't understand the reason behind it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (RNG-136) ObjectSampler and SharedStateObjectSampler interfaces
[
https://issues.apache.org/jira/browse/RNG-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Herbert resolved RNG-136.
--
Fix Version/s: 1.4
Resolution: Implemented
In master.
Commit: 826b3f69cac3c021519c11effa45a2c6f4a44be0
> ObjectSampler and SharedStateObjectSampler interfaces
> ---
>
> Key: RNG-136
> URL: https://issues.apache.org/jira/browse/RNG-136
> Project: Commons RNG
> Issue Type: New Feature
> Components: sampling
>Affects Versions: 1.4
>Reporter: Alex Herbert
>Assignee: Alex Herbert
>Priority: Major
> Fix For: 1.4
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> The sampling package currently contains interfaces for creating int and
> double samples and their extensions to implement the SharedStateSampler
> interface:
> {code:java}
> public interface DiscreteSampler {
> int sample();
> }
> public interface SharedStateDiscreteSampler
> extends DiscreteSampler, SharedStateSampler {
> // Composite interface
> }
> public interface ContinuousSampler {
> double sample();
> }
> public interface SharedStateContinuousSampler
> extends ContinuousSampler,
> SharedStateSampler {
> // Composite interface
> }
> {code}
> Add a matching ObjectSampler interface for all samplers that create objects:
> {code:java}
> public interface ObjectSampler {
> T sample();
> }
> public interface SharedStateObjectSampler extends
> ObjectSampler,
> SharedStateSampler> {
> // Composite interface
> }
> {code}
> Samplers currently returning an object should implement the new interface:
> {code:java}
> int[] CombinationSampler.sample()
> int[] PermutationSampler.sample()
> double[] UnitSphereSampler.nextVector()
> T CollectionSampler.sample()
> T DiscreteProbabilityCollectionSampler.sample()
> double[] BoxSampler.sample()
> double[] LineSampler.sample()
> double[] TriangleSampler.sample()
> double[] TetrahedronSampler.sample()
> double[] UnitBallSampler.sample()
> {code}
> Only the UnitVectorSampler will require a new {{sample}} method. The current
> {{nextVector}} method can be marked deprecated.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-rng] asfgit merged pull request #89: RNG-136: Add ObjectSampler and SharedStateObjectSampler interfaces
asfgit merged pull request #89: URL: https://github.com/apache/commons-rng/pull/89 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MATH-1517) "Cluster" leaks internal data
[
https://issues.apache.org/jira/browse/MATH-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350575#comment-17350575
]
Gilles Sadowski commented on MATH-1517:
---
bq. Hope it helps
Sure it does.
bq. break it in those modules [...]
This discussion belongs in MATH-1575 (and the ["dev"
ML|https://markmail.org/message/vdlz6nrpxrzkj3nw]).
> "Cluster" leaks internal data
> -
>
> Key: MATH-1517
> URL: https://issues.apache.org/jira/browse/MATH-1517
> Project: Commons Math
> Issue Type: Bug
>Reporter: Gilles Sadowski
>Priority: Major
> Fix For: 4.0
>
> Attachments: MATH-1517_cluster_points_leak
>
>
> Method {{getPoints()}} returns a reference to a mutable instance field.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (MATH-1517) "Cluster" leaks internal data
[
https://issues.apache.org/jira/browse/MATH-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350533#comment-17350533
]
Samy Badjoudj edited comment on MATH-1517 at 5/24/21, 6:05 PM:
---
Thanks Gilles
I guess will take some time to break everything in well segregated modules :),
I tried as a starting point to break it in those modules:
*
{color:#e8bf6a}{color}commons-math-utils{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-linear{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-clustering{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-stat{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-analysis{color:#e8bf6a}{color}
Current build states:
* commons-math-utils , contains utils,exceptions, common classes -> might be
renamed as shared
One test is failing which is the same as in legacy
_[ERROR] Failures:_
_[ERROR] FastMathTest.checkMissingFastMathClasses:1273 FastMath should
implement all StrictMath methods_
_[INFO]_
_[ERROR] Tests run: 594, Failures: 1, Errors: 0, Skipped: 1_
* commons-math-linear
_[ERROR] Failures:_
_[ERROR]
RealVectorTest>RealVectorAbstractTest.testMapDivide:811->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR]
RealVectorTest>RealVectorAbstractTest.testMapDivideToSelf:816->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR]
SparseRealVectorTest>RealVectorAbstractTest.testMapDivide:811->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR]
SparseRealVectorTest>RealVectorAbstractTest.testMapDivideToSelf:816->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR] Errors:_
_[ERROR] DiagonalMatrixTest.testCreateError » Unexpected exception,
expected commented until break circular
dependency
* RealVectorAbstractTest -> Univariate[] function commented for local pow(),
circular dependency with analysis module
* Refine granularity, to break down in smaller modules (Functions in analysis
module might be a candidate)
* Split and rename some package and poms
Hope it helps
was (Author: saminou):
Thanks Gilles
I guess will take some time to break everything in well segregated modules :),
I tried as a starting point to break it in those modules:
*
{color:#e8bf6a}{color}commons-math-utils{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-linear{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-clustering{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-stat{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-analysis{color:#e8bf6a}{color}
Current build states:
* commons-math-utils , contains utils,exceptions, common classes -> might be
renamed as shared
One test is failing which is the same as in legacy
_[ERROR] Failures:_
_[ERROR] FastMathTest.checkMissingFastMathClasses:1273 FastMath should
implement all StrictMath methods_
_[INFO]_
_[ERROR] Tests run: 594, Failures: 1, Errors: 0, Skipped: 1_
* commons-math-linear
_[ERROR] Failures:_
_[ERROR]
RealVectorTest>RealVectorAbstractTest.testMapDivide:811->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR]
RealVectorTest>RealVectorAbstractTest.testMapDivideToSelf:816->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR]
SparseRealVectorTest>RealVectorAbstractTest.testMapDivide:811->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR]
SparseRealVectorTest>RealVectorAbstractTest.testMapDivideToSelf:816->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR] Errors:_
_[ERROR] DiagonalMatrixTest.testCreateError » Unexpected exception,
expected commented until break circular
dependency
* RealVectorAbstractTest -> Univariate[] function commented for local pow(),
circular dependency with analysis module
* Refine granularity, to break down in smaller modules (Functions in analysis
module might be a candidate)
* Split and rename some package and poms
Hope it helps
> "Cluster" leaks internal data
> -
>
> Key: MATH-1517
> URL: https://issues.apache.org/jira/browse/MATH-1517
> Project: Commons Math
> Issue Type: Bug
>Reporter: Gilles Sadowski
>Priority: Major
> Fix For: 4.0
>
> Attachments: MATH-1517_cluster_points_leak
>
>
> Method {{getPoints()}} returns a reference to a mutable instance field.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-jcs] arturobernalg commented on pull request #68: JCS-226 - Use toArray with zero-length array argument
arturobernalg commented on pull request #68: URL: https://github.com/apache/commons-jcs/pull/68#issuecomment-847200010 > I thought we discussed this already in #33 True.I'm really sorry @tvand -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-jcs] arturobernalg closed pull request #68: JCS-226 - Use toArray with zero-length array argument
arturobernalg closed pull request #68: URL: https://github.com/apache/commons-jcs/pull/68 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-jcs] arturobernalg commented on pull request #66: JCS-224 - Remove commented code
arturobernalg commented on pull request #66: URL: https://github.com/apache/commons-jcs/pull/66#issuecomment-847199789 OK. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-jcs] arturobernalg closed pull request #66: JCS-224 - Remove commented code
arturobernalg closed pull request #66: URL: https://github.com/apache/commons-jcs/pull/66 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (MATH-1517) "Cluster" leaks internal data
[
https://issues.apache.org/jira/browse/MATH-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350533#comment-17350533
]
Samy Badjoudj edited comment on MATH-1517 at 5/24/21, 5:05 PM:
---
Thanks Gilles
I guess will take some time to break everything in well segregated modules :),
I tried as a starting point to break it in those modules:
*
{color:#e8bf6a}{color}commons-math-utils{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-linear{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-clustering{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-stat{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-analysis{color:#e8bf6a}{color}
Current build states:
* commons-math-utils , contains utils,exceptions, common classes -> might be
renamed as shared
One test is failing which is the same as in legacy
_[ERROR] Failures:_
_[ERROR] FastMathTest.checkMissingFastMathClasses:1273 FastMath should
implement all StrictMath methods_
_[INFO]_
_[ERROR] Tests run: 594, Failures: 1, Errors: 0, Skipped: 1_
* commons-math-linear
_[ERROR] Failures:_
_[ERROR]
RealVectorTest>RealVectorAbstractTest.testMapDivide:811->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR]
RealVectorTest>RealVectorAbstractTest.testMapDivideToSelf:816->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR]
SparseRealVectorTest>RealVectorAbstractTest.testMapDivide:811->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR]
SparseRealVectorTest>RealVectorAbstractTest.testMapDivideToSelf:816->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR] Errors:_
_[ERROR] DiagonalMatrixTest.testCreateError » Unexpected exception,
expected commented until break circular
dependency
* RealVectorAbstractTest -> Univariate[] function commented for local pow(),
circular dependency with analysis module
* Refine granularity, to break down in smaller modules (Functions in analysis
module might be a candidate)
* Split and rename some package and poms
Hope it helps
was (Author: saminou):
Thanks Gilles
I guess will take some time to break everything in well segregated modules :),
I tried to break those:
*
{color:#e8bf6a}{color}commons-math-utils{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-linear{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-clustering{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-stat{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-analysis{color:#e8bf6a}{color}
Current build states:
* commons-math-utils , contains utils,exceptions, common classes -> might be
renamed as shared
One test is failing which is the same as in legacy
_[ERROR] Failures:_
_[ERROR] FastMathTest.checkMissingFastMathClasses:1273 FastMath should
implement all StrictMath methods_
_[INFO]_
_[ERROR] Tests run: 594, Failures: 1, Errors: 0, Skipped: 1_
* commons-math-linear
_[ERROR] Failures:_
_[ERROR]
RealVectorTest>RealVectorAbstractTest.testMapDivide:811->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR]
RealVectorTest>RealVectorAbstractTest.testMapDivideToSelf:816->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR]
SparseRealVectorTest>RealVectorAbstractTest.testMapDivide:811->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR]
SparseRealVectorTest>RealVectorAbstractTest.testMapDivideToSelf:816->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR] Errors:_
_[ERROR] DiagonalMatrixTest.testCreateError » Unexpected exception,
expected commented until break circular
dependency
* RealVectorAbstractTest -> Univariate[] function commented for local pow(),
circular dependency with analysis module
* Refine granularity, to break down in smaller modules (Functions in analysis
module might be a candidate)
* Split and rename some package and poms
Hope it helps
> "Cluster" leaks internal data
> -
>
> Key: MATH-1517
> URL: https://issues.apache.org/jira/browse/MATH-1517
> Project: Commons Math
> Issue Type: Bug
>Reporter: Gilles Sadowski
>Priority: Major
> Fix For: 4.0
>
> Attachments: MATH-1517_cluster_points_leak
>
>
> Method {{getPoints()}} returns a reference to a mutable instance field.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (MATH-1517) "Cluster" leaks internal data
[
https://issues.apache.org/jira/browse/MATH-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350533#comment-17350533
]
Samy Badjoudj edited comment on MATH-1517 at 5/24/21, 5:01 PM:
---
Thanks Gilles
I guess will take some time to break everything in well segregated modules :),
I tried to break those:
*
{color:#e8bf6a}{color}commons-math-utils{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-linear{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-clustering{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-stat{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-analysis{color:#e8bf6a}{color}
Current build states:
* commons-math-utils , contains utils,exceptions, common classes -> might be
renamed as shared
One test is failing which is the same as in legacy
_[ERROR] Failures:_
_[ERROR] FastMathTest.checkMissingFastMathClasses:1273 FastMath should
implement all StrictMath methods_
_[INFO]_
_[ERROR] Tests run: 594, Failures: 1, Errors: 0, Skipped: 1_
* commons-math-linear
_[ERROR] Failures:_
_[ERROR]
RealVectorTest>RealVectorAbstractTest.testMapDivide:811->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR]
RealVectorTest>RealVectorAbstractTest.testMapDivideToSelf:816->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR]
SparseRealVectorTest>RealVectorAbstractTest.testMapDivide:811->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR]
SparseRealVectorTest>RealVectorAbstractTest.testMapDivideToSelf:816->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR] Errors:_
_[ERROR] DiagonalMatrixTest.testCreateError » Unexpected exception,
expected commented until break circular
dependency
* RealVectorAbstractTest -> Univariate[] function commented for local pow(),
circular dependency with analysis module
* Refine granularity, to break down in smaller modules (Functions in analysis
module might be a candidate)
* Split and rename some package and poms
was (Author: saminou):
Thanks Gilles
I guess will take some time to break everything in well segregated modules :),
I tried to break those:
*
{color:#e8bf6a}{color}commons-math-utils{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-linear{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-clustering{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-stat{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-analysis{color:#e8bf6a}{color}
Steps done so far to break the monolithic legacy project:
* commons-math-utils , contains utils,exceptions, common classes -> might be
renamed as shared
One test is failing which is the same as in legacy
_[ERROR] Failures:_
_[ERROR] FastMathTest.checkMissingFastMathClasses:1273 FastMath should
implement all StrictMath methods_
_[INFO]_
_[ERROR] Tests run: 594, Failures: 1, Errors: 0, Skipped: 1_
* commons-math-linear
_[ERROR] Failures:_
_[ERROR]
RealVectorTest>RealVectorAbstractTest.testMapDivide:811->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR]
RealVectorTest>RealVectorAbstractTest.testMapDivideToSelf:816->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR]
SparseRealVectorTest>RealVectorAbstractTest.testMapDivide:811->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR]
SparseRealVectorTest>RealVectorAbstractTest.testMapDivideToSelf:816->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR] Errors:_
_[ERROR] DiagonalMatrixTest.testCreateError » Unexpected exception,
expected commented until break circular
dependency
* RealVectorAbstractTest -> Univariate[] function commented for local pow(),
circular dependency with analysis module
* Refine granularity, to break down in smaller modules (Functions in analysis
module might be a candidate)
* Split and rename some package and poms
> "Cluster" leaks internal data
> -
>
> Key: MATH-1517
> URL: https://issues.apache.org/jira/browse/MATH-1517
> Project: Commons Math
> Issue Type: Bug
>Reporter: Gilles Sadowski
>Priority: Major
> Fix For: 4.0
>
> Attachments: MATH-1517_cluster_points_leak
>
>
> Method {{getPoints()}} returns a reference to a mutable instance field.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (MATH-1517) "Cluster" leaks internal data
[
https://issues.apache.org/jira/browse/MATH-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350533#comment-17350533
]
Samy Badjoudj edited comment on MATH-1517 at 5/24/21, 5:01 PM:
---
Thanks Gilles
I guess will take some time to break everything in well segregated modules :),
I tried to break those:
*
{color:#e8bf6a}{color}commons-math-utils{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-linear{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-clustering{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-stat{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-analysis{color:#e8bf6a}{color}
Current build states:
* commons-math-utils , contains utils,exceptions, common classes -> might be
renamed as shared
One test is failing which is the same as in legacy
_[ERROR] Failures:_
_[ERROR] FastMathTest.checkMissingFastMathClasses:1273 FastMath should
implement all StrictMath methods_
_[INFO]_
_[ERROR] Tests run: 594, Failures: 1, Errors: 0, Skipped: 1_
* commons-math-linear
_[ERROR] Failures:_
_[ERROR]
RealVectorTest>RealVectorAbstractTest.testMapDivide:811->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR]
RealVectorTest>RealVectorAbstractTest.testMapDivideToSelf:816->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR]
SparseRealVectorTest>RealVectorAbstractTest.testMapDivide:811->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR]
SparseRealVectorTest>RealVectorAbstractTest.testMapDivideToSelf:816->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR] Errors:_
_[ERROR] DiagonalMatrixTest.testCreateError » Unexpected exception,
expected commented until break circular
dependency
* RealVectorAbstractTest -> Univariate[] function commented for local pow(),
circular dependency with analysis module
* Refine granularity, to break down in smaller modules (Functions in analysis
module might be a candidate)
* Split and rename some package and poms
Hope it helps
was (Author: saminou):
Thanks Gilles
I guess will take some time to break everything in well segregated modules :),
I tried to break those:
*
{color:#e8bf6a}{color}commons-math-utils{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-linear{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-clustering{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-stat{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-analysis{color:#e8bf6a}{color}
Current build states:
* commons-math-utils , contains utils,exceptions, common classes -> might be
renamed as shared
One test is failing which is the same as in legacy
_[ERROR] Failures:_
_[ERROR] FastMathTest.checkMissingFastMathClasses:1273 FastMath should
implement all StrictMath methods_
_[INFO]_
_[ERROR] Tests run: 594, Failures: 1, Errors: 0, Skipped: 1_
* commons-math-linear
_[ERROR] Failures:_
_[ERROR]
RealVectorTest>RealVectorAbstractTest.testMapDivide:811->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR]
RealVectorTest>RealVectorAbstractTest.testMapDivideToSelf:816->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR]
SparseRealVectorTest>RealVectorAbstractTest.testMapDivide:811->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR]
SparseRealVectorTest>RealVectorAbstractTest.testMapDivideToSelf:816->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR] Errors:_
_[ERROR] DiagonalMatrixTest.testCreateError » Unexpected exception,
expected commented until break circular
dependency
* RealVectorAbstractTest -> Univariate[] function commented for local pow(),
circular dependency with analysis module
* Refine granularity, to break down in smaller modules (Functions in analysis
module might be a candidate)
* Split and rename some package and poms
> "Cluster" leaks internal data
> -
>
> Key: MATH-1517
> URL: https://issues.apache.org/jira/browse/MATH-1517
> Project: Commons Math
> Issue Type: Bug
>Reporter: Gilles Sadowski
>Priority: Major
> Fix For: 4.0
>
> Attachments: MATH-1517_cluster_points_leak
>
>
> Method {{getPoints()}} returns a reference to a mutable instance field.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (MATH-1517) "Cluster" leaks internal data
[
https://issues.apache.org/jira/browse/MATH-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350533#comment-17350533
]
Samy Badjoudj edited comment on MATH-1517 at 5/24/21, 5:01 PM:
---
Thanks Gilles
I guess will take some time to break everything in well segregated modules :),
I tried to break those:
*
{color:#e8bf6a}{color}commons-math-utils{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-linear{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-clustering{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-stat{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-analysis{color:#e8bf6a}{color}
Current build states:
* commons-math-utils , contains utils,exceptions, common classes -> might be
renamed as shared
One test is failing which is the same as in legacy
_[ERROR] Failures:_
_[ERROR] FastMathTest.checkMissingFastMathClasses:1273 FastMath should
implement all StrictMath methods_
_[INFO]_
_[ERROR] Tests run: 594, Failures: 1, Errors: 0, Skipped: 1_
* commons-math-linear
_[ERROR] Failures:_
_[ERROR]
RealVectorTest>RealVectorAbstractTest.testMapDivide:811->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR]
RealVectorTest>RealVectorAbstractTest.testMapDivideToSelf:816->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR]
SparseRealVectorTest>RealVectorAbstractTest.testMapDivide:811->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR]
SparseRealVectorTest>RealVectorAbstractTest.testMapDivideToSelf:816->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR] Errors:_
_[ERROR] DiagonalMatrixTest.testCreateError » Unexpected exception,
expected commented until break circular
dependency
* RealVectorAbstractTest -> Univariate[] function commented for local pow(),
circular dependency with analysis module
* Refine granularity, to break down in smaller modules (Functions in analysis
module might be a candidate)
* Split and rename some package and poms
Hope it helps
was (Author: saminou):
Thanks Gilles
I guess will take some time to break everything in well segregated modules :),
I tried to break those:
*
{color:#e8bf6a}{color}commons-math-utils{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-linear{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-clustering{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-stat{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-analysis{color:#e8bf6a}{color}
Current build states:
* commons-math-utils , contains utils,exceptions, common classes -> might be
renamed as shared
One test is failing which is the same as in legacy
_[ERROR] Failures:_
_[ERROR] FastMathTest.checkMissingFastMathClasses:1273 FastMath should
implement all StrictMath methods_
_[INFO]_
_[ERROR] Tests run: 594, Failures: 1, Errors: 0, Skipped: 1_
* commons-math-linear
_[ERROR] Failures:_
_[ERROR]
RealVectorTest>RealVectorAbstractTest.testMapDivide:811->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR]
RealVectorTest>RealVectorAbstractTest.testMapDivideToSelf:816->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR]
SparseRealVectorTest>RealVectorAbstractTest.testMapDivide:811->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR]
SparseRealVectorTest>RealVectorAbstractTest.testMapDivideToSelf:816->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR] Errors:_
_[ERROR] DiagonalMatrixTest.testCreateError » Unexpected exception,
expected commented until break circular
dependency
* RealVectorAbstractTest -> Univariate[] function commented for local pow(),
circular dependency with analysis module
* Refine granularity, to break down in smaller modules (Functions in analysis
module might be a candidate)
* Split and rename some package and poms
Hope it helps
> "Cluster" leaks internal data
> -
>
> Key: MATH-1517
> URL: https://issues.apache.org/jira/browse/MATH-1517
> Project: Commons Math
> Issue Type: Bug
>Reporter: Gilles Sadowski
>Priority: Major
> Fix For: 4.0
>
> Attachments: MATH-1517_cluster_points_leak
>
>
> Method {{getPoints()}} returns a reference to a mutable instance field.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (MATH-1517) "Cluster" leaks internal data
[
https://issues.apache.org/jira/browse/MATH-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350533#comment-17350533
]
Samy Badjoudj edited comment on MATH-1517 at 5/24/21, 5:00 PM:
---
Thanks Gilles
I guess will take some time to break everything in well segregated modules :),
I tried to break those:
*
{color:#e8bf6a}{color}commons-math-utils{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-linear{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-clustering{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-stat{color:#e8bf6a}{color}
*
{color:#e8bf6a}{color}commons-math-analysis{color:#e8bf6a}{color}
Steps done so far to break the monolithic legacy project:
* commons-math-utils , contains utils,exceptions, common classes -> might be
renamed as shared
One test is failing which is the same as in legacy
_[ERROR] Failures:_
_[ERROR] FastMathTest.checkMissingFastMathClasses:1273 FastMath should
implement all StrictMath methods_
_[INFO]_
_[ERROR] Tests run: 594, Failures: 1, Errors: 0, Skipped: 1_
* commons-math-linear
_[ERROR] Failures:_
_[ERROR]
RealVectorTest>RealVectorAbstractTest.testMapDivide:811->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR]
RealVectorTest>RealVectorAbstractTest.testMapDivideToSelf:816->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR]
SparseRealVectorTest>RealVectorAbstractTest.testMapDivide:811->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR]
SparseRealVectorTest>RealVectorAbstractTest.testMapDivideToSelf:816->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR] Errors:_
_[ERROR] DiagonalMatrixTest.testCreateError » Unexpected exception,
expected commented until break circular
dependency
* RealVectorAbstractTest -> Univariate[] function commented for local pow(),
circular dependency with analysis module
* Refine granularity, to break down in smaller modules (Functions in analysis
module might be a candidate)
* Split and rename some package and poms
was (Author: saminou):
Thanks Gilles
I guess will take some time to break everything in well segregated modules :),
I tried to break those:
{color:#808080}{color}{color:#e8bf6a}
{color}{color:#e8bf6a}{color}commons-math-utils{color:#e8bf6a}
{color}{color:#e8bf6a}{color}commons-math-linear{color:#e8bf6a}
{color}{color:#e8bf6a}{color}commons-math-clustering{color:#e8bf6a}
{color}{color:#e8bf6a}{color}commons-math-stat{color:#e8bf6a}
{color}{color:#e8bf6a}{color}commons-math-analysis{color:#e8bf6a}{color}
Steps done so far to break the monolithic legacy project:
* commons-math-utils , contains utils,exceptions, common classes -> might be
renamed as shared
One test is failing which is the same as in legacy
_[ERROR] Failures:_
_[ERROR] FastMathTest.checkMissingFastMathClasses:1273 FastMath should
implement all StrictMath methods_
_[INFO]_
_[ERROR] Tests run: 594, Failures: 1, Errors: 0, Skipped: 1_
* commons-math-linear
_[ERROR] Failures:_
_[ERROR]
RealVectorTest>RealVectorAbstractTest.testMapDivide:811->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR]
RealVectorTest>RealVectorAbstractTest.testMapDivideToSelf:816->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR]
SparseRealVectorTest>RealVectorAbstractTest.testMapDivide:811->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR]
SparseRealVectorTest>RealVectorAbstractTest.testMapDivideToSelf:816->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR] Errors:_
_[ERROR] DiagonalMatrixTest.testCreateError » Unexpected exception,
expected commented until break circular
dependency
* RealVectorAbstractTest -> Univariate[] function commented for local pow(),
circular dependency with analysis module
* Refine granularity, to break down in smaller modules (Functions in analysis
module might be a candidate)
* Split and rename some package and poms
> "Cluster" leaks internal data
> -
>
> Key: MATH-1517
> URL: https://issues.apache.org/jira/browse/MATH-1517
> Project: Commons Math
> Issue Type: Bug
>Reporter: Gilles Sadowski
>Priority: Major
> Fix For: 4.0
>
> Attachments: MATH-1517_cluster_points_leak
>
>
> Method {{getPoints()}} returns a reference to a mutable instance field.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MATH-1517) "Cluster" leaks internal data
[
https://issues.apache.org/jira/browse/MATH-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350533#comment-17350533
]
Samy Badjoudj commented on MATH-1517:
-
Thanks Gilles
I guess will take some time to break everything in well segregated modules :),
I tried to break those:
{color:#808080}{color}{color:#e8bf6a}
{color}{color:#e8bf6a}{color}commons-math-utils{color:#e8bf6a}
{color}{color:#e8bf6a}{color}commons-math-linear{color:#e8bf6a}
{color}{color:#e8bf6a}{color}commons-math-clustering{color:#e8bf6a}
{color}{color:#e8bf6a}{color}commons-math-stat{color:#e8bf6a}
{color}{color:#e8bf6a}{color}commons-math-analysis{color:#e8bf6a}{color}
Steps done so far to break the monolithic legacy project:
* commons-math-utils , contains utils,exceptions, common classes -> might be
renamed as shared
One test is failing which is the same as in legacy
_[ERROR] Failures:_
_[ERROR] FastMathTest.checkMissingFastMathClasses:1273 FastMath should
implement all StrictMath methods_
_[INFO]_
_[ERROR] Tests run: 594, Failures: 1, Errors: 0, Skipped: 1_
* commons-math-linear
_[ERROR] Failures:_
_[ERROR]
RealVectorTest>RealVectorAbstractTest.testMapDivide:811->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR]
RealVectorTest>RealVectorAbstractTest.testMapDivideToSelf:816->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR]
SparseRealVectorTest>RealVectorAbstractTest.testMapDivide:811->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR]
SparseRealVectorTest>RealVectorAbstractTest.testMapDivideToSelf:816->RealVectorAbstractTest.doTestMapBinaryOperation:775
0.0, entry #3 expected: but was:<0.0>_
_[ERROR] Errors:_
_[ERROR] DiagonalMatrixTest.testCreateError » Unexpected exception,
expected commented until break circular
dependency
* RealVectorAbstractTest -> Univariate[] function commented for local pow(),
circular dependency with analysis module
* Refine granularity, to break down in smaller modules (Functions in analysis
module might be a candidate)
* Split and rename some package and poms
> "Cluster" leaks internal data
> -
>
> Key: MATH-1517
> URL: https://issues.apache.org/jira/browse/MATH-1517
> Project: Commons Math
> Issue Type: Bug
>Reporter: Gilles Sadowski
>Priority: Major
> Fix For: 4.0
>
> Attachments: MATH-1517_cluster_points_leak
>
>
> Method {{getPoints()}} returns a reference to a mutable instance field.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-jcs] tvand merged pull request #67: JCS-225 - Fix Typo and Javadoc
tvand merged pull request #67: URL: https://github.com/apache/commons-jcs/pull/67 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-jcs] tvand commented on pull request #65: Bump openjpa from 2.3.0 to 3.2.0
tvand commented on pull request #65: URL: https://github.com/apache/commons-jcs/pull/65#issuecomment-847160502 @dependabot ignore this major version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-jcs] dependabot[bot] closed pull request #65: Bump openjpa from 2.3.0 to 3.2.0
dependabot[bot] closed pull request #65: URL: https://github.com/apache/commons-jcs/pull/65 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-jcs] dependabot[bot] commented on pull request #65: Bump openjpa from 2.3.0 to 3.2.0
dependabot[bot] commented on pull request #65: URL: https://github.com/apache/commons-jcs/pull/65#issuecomment-847160523 OK, I won't notify you about version 3.x.x again, unless you re-open this PR or update to a 3.x.x release yourself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-jcs] tvand merged pull request #62: JCS-220 - Java8 improvement
tvand merged pull request #62: URL: https://github.com/apache/commons-jcs/pull/62 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-jcs] tvand merged pull request #64: Bump checksum-maven-plugin from 1.9 to 1.10
tvand merged pull request #64: URL: https://github.com/apache/commons-jcs/pull/64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Deleted] (COMMONSSITE-146) Cant seem to find the API for Facebook with JS
[ https://issues.apache.org/jira/browse/COMMONSSITE-146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Herbert deleted COMMONSSITE-146: - > Cant seem to find the API for Facebook with JS > -- > > Key: COMMONSSITE-146 > URL: https://issues.apache.org/jira/browse/COMMONSSITE-146 > Project: Apache Commons All > Issue Type: Bug >Reporter: Martle Monika >Priority: Major > > Cant seem to find the API for Facebook with JS -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (BEANUTILS-548) Update commons-collections dependency to 4.x
[ https://issues.apache.org/jira/browse/BEANUTILS-548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory closed BEANUTILS-548. - Fix Version/s: (was: 1.9.4) Resolution: Duplicate > Update commons-collections dependency to 4.x > > > Key: BEANUTILS-548 > URL: https://issues.apache.org/jira/browse/BEANUTILS-548 > Project: Commons BeanUtils > Issue Type: Improvement > Components: Bean-Collections >Affects Versions: 1.9.3 >Reporter: Steve Lopez >Priority: Minor > > latest version relies on quite outdated version of commons-collections. > request is to update dependency to collections4 v4.4 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (BEANUTILS-532) Require commons-beanutils library which supports commons-collections-4.x version
[ https://issues.apache.org/jira/browse/BEANUTILS-532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated BEANUTILS-532: -- Summary: Require commons-beanutils library which supports commons-collections-4.x version (was: Require commons-beanutils library which supports commons-collections-4.1 version ) > Require commons-beanutils library which supports commons-collections-4.x > version > - > > Key: BEANUTILS-532 > URL: https://issues.apache.org/jira/browse/BEANUTILS-532 > Project: Commons BeanUtils > Issue Type: Bug > Components: Bean-Collections >Reporter: AvanthikaNC >Priority: Blocker > Attachments: image-2020-01-31-14-52-43-114.png > > > Hi Team, > > We are working on ATM SWITCH project and the project currently uses > commons-beanutils library 1.9.4 and we have upgraded to > commons-collections-4.1 as part of our project requirement as it contained > vulnerabilities. > We are facing some errors due to the above mentioned upgrade as > commons-beanutils library 1.9.4 will support commons-collections 3.2.2 > version. > Now as per our requirement we cannot downgrade common-collections library but > we need commons-beanutils library which supports commons-collections4-4.1 > version. > Please provide your response asap. > Thanks -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (BEANUTILS-549) Update commons-lang dependency to commons-lang3
Steve Lopez created BEANUTILS-549: - Summary: Update commons-lang dependency to commons-lang3 Key: BEANUTILS-549 URL: https://issues.apache.org/jira/browse/BEANUTILS-549 Project: Commons BeanUtils Issue Type: Improvement Components: Bean / Property Utils Affects Versions: 1.9.3 Reporter: Steve Lopez Fix For: 1.9.4 current version relies on quite outdated commons-lang. request is to update to use commons-lang3 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (BEANUTILS-548) Update commons-collections dependency to 4.x
Steve Lopez created BEANUTILS-548: - Summary: Update commons-collections dependency to 4.x Key: BEANUTILS-548 URL: https://issues.apache.org/jira/browse/BEANUTILS-548 Project: Commons BeanUtils Issue Type: Improvement Components: Bean-Collections Affects Versions: 1.9.3 Reporter: Steve Lopez Fix For: 1.9.4 latest version relies on quite outdated version of commons-collections. request is to update dependency to collections4 v4.4 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (NUMBERS-156) SafeNorm 3D overload
[
https://issues.apache.org/jira/browse/NUMBERS-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350436#comment-17350436
]
Alex Herbert edited comment on NUMBERS-156 at 5/24/21, 1:42 PM:
The method {{extLinearSinglePass}} is missing from the performance chart for
lengths 1 to 5. I am guessing it is between the {{enormModExt}} and the
{{extLinearMod}} in that chart.
The single pass extended precision algorithm is a nice idea and the algorithm
looks good. I noted on review that the NaN detection can be changed to handle
infinite inputs:
{code:java}
if (Double.isNaN(x)) {
// found an NaN; no use in continuing
return x;
} ...
{code}
to
{code:java}
if (!Double.isFinite(x)) {
// found a non-finite input; no use in continuing.
// even if this is infinite we must check if a NaN is present
// later in the input for the correct result.
return nanOrPositiveInfinity(v, i);
} ...
private static double nanOrPositiveInfinity(double[] v, int start) {
for (int i = start; i < v.length; i++) {
if (Double.isNaN(v[i])) {
return Double.NaN;
}
}
return Double.POSITIVE_INFINITY;
}
{code}
This will just skip out if a non-finite is found and return either positive
infinity or NaN. It is an edge case that may be worth including. The effect on
performance for normal input will be the difference between Double.isNaN and
!Double.isFinite. I would think this is negligible. In the rare case the input
is long and contains non-finite values then the change will be useful.
The extended precision algorithms in [Dekker's original
paper|https://link.springer.com/article/10.1007/BF01397083] (see the last page)
include an extended precision square root. If you have a split number with high
and low parts you compute the square root using:
{code:java}
/**
* Compute the extended precision square root from the split number
* {@code x, xx}.
* This is a modification of Dekker's sqrt2 algorithm to ignore the
* roundoff of the square root.
*
* @param x the high part
* @param xx the low part
* @return the double
*/
static double sqrt2(double x, double xx) {
if (x > 0) {
double c = Math.sqrt(x);
double u = c * c;
//double uu = ExtendedPrecision.productLow(c, c, u);
// Here we use the optimised version:
double uu = productLowUnscaled(c, u);
double cc = (x - u - uu + xx) * 0.5 / c;
// Extended precision sqrt (y, yy)
// y = c + cc
// yy = c - y + cc (ignored)
return c + cc;
}
return x;
}
{code}
This could be applied to the extended precision sum. E.g.
{code:java}
return Math.sqrt(sum + c1) * SCALE_UP
{code}
Becomes:
{code:java}
return sqrt2(sum, c1) * SCALE_UP
{code}
However the sum of the round off parts may not be an non-overlapping two part
split number (x,xx) where xx is so small such that x + xx == x. This may be
required for the algorithm to work. This can be done using:
{code:java}
double x = sum + c1;
double xx = ExtendedPrecision.twoSumLow(sum, c1, x);
return sqrt2(x, xx) * SCALE_UP;
{code}
When I looked at this algorithm for the 2D case for use in the Complex class
it matched the result of BigDecimal.sqrt in all cases I tried. But the
performance overhead was not worth it for 2D as it gains only 1 ULP precision.
For longer arrays the performance impact is relatively less and it may be worth
considering.
was (Author: alexherbert):
The method {{extLinearSinglePass}} is missing from the performance chart for
lengths 1 to 5. I am guessing it is between the {{enormModExt}} and the
{{extLinearMod}} in that chart.
The single pass extended precision algorithm is a nice idea and the algorithm
looks good. I noted on review that the NaN detection can be changed to handle
infinite inputs:
{code:java}
if (Double.isNaN(x)) {
// found an NaN; no use in continuing
return x;
} ...
{code}
to
{code:java}
if (!Double.isFinite(x)) {
// found a non-finite input; no use in continuing.
// even if this is infinite we must check if a NaN is present
// later in the input for the correct result.
return nanOrPositiveInifinty(v, i);
} ...
private static double nanOrPositiveInfinity(double[] v, int start) {
for (int i = start; i < v.length; i++) {
if (Double.isNaN(v[i])) {
return Double.NaN;
}
}
return Double.POSITIVE_INFINITY;
}
{code}
This will just skip out if a non-finite is found and return either positive
infinity or NaN. It is an edge case that may be worth including. The effect on
performance for normal input will be the difference between Double.isNaN and
!Double.isFinite. I would think this is negligible. In the rare case the input
is long and contains non-finite values then the change will be useful.
The extended precision algorithms in [Dekker's original
[jira] [Commented] (NUMBERS-156) SafeNorm 3D overload
[
https://issues.apache.org/jira/browse/NUMBERS-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350436#comment-17350436
]
Alex Herbert commented on NUMBERS-156:
--
The method {{extLinearSinglePass}} is missing from the performance chart for
lengths 1 to 5. I am guessing it is between the {{enormModExt}} and the
{{extLinearMod}} in that chart.
The single pass extended precision algorithm is a nice idea and the algorithm
looks good. I noted on review that the NaN detection can be changed to handle
infinite inputs:
{code:java}
if (Double.isNaN(x)) {
// found an NaN; no use in continuing
return x;
} ...
{code}
to
{code:java}
if (!Double.isFinite(x)) {
// found a non-finite input; no use in continuing.
// even if this is infinite we must check if a NaN is present
// later in the input for the correct result.
return nanOrPositiveInifinty(v, i);
} ...
private static double nanOrPositiveInfinity(double[] v, int start) {
for (int i = start; i < v.length; i++) {
if (Double.isNaN(v[i])) {
return Double.NaN;
}
}
return Double.POSITIVE_INFINITY;
}
{code}
This will just skip out if a non-finite is found and return either positive
infinity or NaN. It is an edge case that may be worth including. The effect on
performance for normal input will be the difference between Double.isNaN and
!Double.isFinite. I would think this is negligible. In the rare case the input
is long and contains non-finite values then the change will be useful.
The extended precision algorithms in [Dekker's original
paper|https://link.springer.com/article/10.1007/BF01397083] (see the last page)
include an extended precision square root. If you have a split number with high
and low parts you compute the square root using:
{code:java}
/**
* Compute the extended precision square root from the split number
* {@code x, xx}.
* This is a modification of Dekker's sqrt2 algorithm to ignore the
* roundoff of the square root.
*
* @param x the high part
* @param xx the low part
* @return the double
*/
static double sqrt2(double x, double xx) {
if (x > 0) {
double c = Math.sqrt(x);
double u = c * c;
//double uu = ExtendedPrecision.productLow(c, c, u);
// Here we use the optimised version:
double uu = productLowUnscaled(c, u);
double cc = (x - u - uu + xx) * 0.5 / c;
// Extended precision sqrt (y, yy)
// y = c + cc
// yy = c - y + cc (ignored)
return c + cc;
}
return x;
}
{code}
This could be applied to the extended precision sum. E.g.
{code:java}
return Math.sqrt(sum + c1) * SCALE_UP
{code}
Becomes:
{code:java}
return sqrt2(sum, c1) * SCALE_UP
{code}
However the sum of the round off parts may not be an non-overlapping two part
split number (x,xx) where xx is so small such that x + xx == x. This may be
required for the algorithm to work. This can be done using:
{code:java}
double x = sum + c1;
double xx = ExtendedPrecision.twoSumLow(sum, c1, x);
return sqrt2(x, xx) * SCALE_UP;
{code}
When I looked at this algorithm for the 2D case for use in the Complex class
it matched the result of BigDecimal.sqrt in all cases I tried. But the
performance overhead was not worth it for 2D as it gains only 1 ULP precision.
For longer arrays the performance impact is relatively less and it may be worth
considering.
> SafeNorm 3D overload
>
>
> Key: NUMBERS-156
> URL: https://issues.apache.org/jira/browse/NUMBERS-156
> Project: Commons Numbers
> Issue Type: Improvement
>Reporter: Matt Juntunen
>Priority: Major
> Attachments: performance-all.png, performance-len-1-5.png,
> performance2-1-5.png, performance2-all.png, performance3-1-5.png,
> performance3-all.png, performance4-1-5.png, performance4-all.png
>
>
> We should create an overload of {{SafeNorm.value}} that accepts 3 arguments
> to potentially improve performance for 3D vectors.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (NUMBERS-156) SafeNorm 3D overload
[
https://issues.apache.org/jira/browse/NUMBERS-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350398#comment-17350398
]
Matt Juntunen commented on NUMBERS-156:
---
Thanks for the fix, Alex. I'm made the updates and run the tests again. I've
also added another version using the linear combination code that only makes a
single pass through the input array, following the same procedure as {{enorm}}.
The new method is called {{extLinearSinglePass}}. (Note that I've left the
standard precision methods out of the tests with the exception of {{direct}}).
||name||input type||error mean||error std dev||error min||error max||failed||
|direct|high|NaN|-0.00|Infinity|-Infinity|20|
|enormModExt|high|-0.00121|0.375|-1.00|1.00|0|
|extLinear|high|-0.00129|0.367|-1.00|1.00|0|
|extLinearMod|high|-0.00129|0.367|-1.00|1.00|0|
|extLinearSinglePass|high|-0.00129|0.367|-1.00|1.00|0|
|direct|high-thresh|-0.00208|1.02|-5.00|6.00|0|
|enormModExt|high-thresh|-0.000570|0.374|-1.00|1.00|0|
|extLinear|high-thresh|-0.000650|0.367|-1.00|1.00|0|
|extLinearMod|high-thresh|-0.000650|0.367|-1.00|1.00|0|
|extLinearSinglePass|high-thresh|-0.000650|0.367|-1.00|1.00|0|
|direct|mid|-0.00237|1.02|-6.00|6.00|0|
|enormModExt|mid|-0.000860|0.385|-1.00|1.00|0|
|extLinear|mid|-0.000940|0.378|-1.00|1.00|0|
|extLinearMod|mid|-0.000940|0.378|-1.00|1.00|0|
|extLinearSinglePass|mid|-0.000940|0.378|-1.00|1.00|0|
|exact|low-thresh|0.00|0.00|0.00|0.00|0|
|direct|low-thresh|-0.00206|1.02|-5.00|6.00|0|
|enormModExt|low-thresh|-0.000550|0.374|-1.00|1.00|0|
|extLinear|low-thresh|-0.000630|0.366|-1.00|1.00|0|
|extLinearMod|low-thresh|-0.000630|0.366|-1.00|1.00|0|
|extLinearSinglePass|low-thresh|-0.000630|0.366|-1.00|1.00|0|
|direct|low|5.76e+04|1.87e+05|-2.52e+06|2.57e+06|0|
|enormModExt|low|-0.00292|1.02|-5.00|6.00|0|
|extLinear|low|-0.00149|0.367|-1.00|1.00|0|
|extLinearMod|low|-0.00149|0.367|-1.00|1.00|0|
|extLinearSinglePass|low|-0.00149|0.367|-1.00|1.00|0|
|direct|full|0.00253|0.497|-2.00|1.00|194074|
|enormModExt|full|-0.000810|0.469|-2.00|1.00|0|
|extLinear|full|0.00149|0.438|-1.00|1.00|0|
|extLinearMod|full|0.00149|0.438|-1.00|1.00|0|
|extLinearSinglePass|full|0.00149|0.438|-1.00|1.00|0|
!performance4-all.png!
!performance3-1-5.png!
It seems like {{extLinearSinglePass}} may be the way to go here since it is
showing the same accuracy as the other {{extLinear}} methods but with improved
performance. The code for this can be found
[here|https://github.com/darkma773r/commons-numbers/blob/vector-methods/commons-numbers-examples/examples-jmh/src/main/java/org/apache/commons/numbers/examples/jmh/arrays/EuclideanNormAlgorithms.java#L483].
> SafeNorm 3D overload
>
>
> Key: NUMBERS-156
> URL: https://issues.apache.org/jira/browse/NUMBERS-156
> Project: Commons Numbers
> Issue Type: Improvement
>Reporter: Matt Juntunen
>Priority: Major
> Attachments: performance-all.png, performance-len-1-5.png,
> performance2-1-5.png, performance2-all.png, performance3-1-5.png,
> performance3-all.png, performance4-1-5.png, performance4-all.png
>
>
> We should create an overload of {{SafeNorm.value}} that accepts 3 arguments
> to potentially improve performance for 3D vectors.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-compress] HelderMagalhaes edited a comment on pull request #199: Whitespace improvement, site nits and assorted typos
HelderMagalhaes edited a comment on pull request #199:
URL: https://github.com/apache/commons-compress/pull/199#issuecomment-846991690
> I'm a little confused about your PR #197, #198 and #199. They look pretty
similar. What's the difference? It's appreciated if you can close the PRs you
don't want to push.
I did want to push but in different pull requests:
* PR 197 was regarding the "whitespace improvement" which had been submitted
to PR 192 but didn't get through due to being mixed with other changes.
* PR 198 was regarding the "site nits", which are also included here
* The remaining part (the initial goal for this PR) are few typos noticed.
The idea was to only keep this one, as it gathers all changes away, in the
hope that mixing slightly different things, particularly whitespace ("If you
feel the source code should be reformatted create a separate PR for this change
first.", as also hinted by @bodewig in already referred PR 192) isn't a
problem. Otherwise I'll also close this PR and try resubmit all three. What do
you think?
> BTW : there're so many commits in your PR. Could you squash them?
If there's a need to resubmit the PR I'll take that into consideration.
Thanks for the feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NUMBERS-156) SafeNorm 3D overload
[
https://issues.apache.org/jira/browse/NUMBERS-156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Juntunen updated NUMBERS-156:
--
Attachment: performance4-all.png
> SafeNorm 3D overload
>
>
> Key: NUMBERS-156
> URL: https://issues.apache.org/jira/browse/NUMBERS-156
> Project: Commons Numbers
> Issue Type: Improvement
>Reporter: Matt Juntunen
>Priority: Major
> Attachments: performance-all.png, performance-len-1-5.png,
> performance2-1-5.png, performance2-all.png, performance3-1-5.png,
> performance3-all.png, performance4-1-5.png, performance4-all.png
>
>
> We should create an overload of {{SafeNorm.value}} that accepts 3 arguments
> to potentially improve performance for 3D vectors.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (NUMBERS-156) SafeNorm 3D overload
[
https://issues.apache.org/jira/browse/NUMBERS-156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Juntunen updated NUMBERS-156:
--
Attachment: performance4-1-5.png
> SafeNorm 3D overload
>
>
> Key: NUMBERS-156
> URL: https://issues.apache.org/jira/browse/NUMBERS-156
> Project: Commons Numbers
> Issue Type: Improvement
>Reporter: Matt Juntunen
>Priority: Major
> Attachments: performance-all.png, performance-len-1-5.png,
> performance2-1-5.png, performance2-all.png, performance3-1-5.png,
> performance3-all.png, performance4-1-5.png, performance4-all.png
>
>
> We should create an overload of {{SafeNorm.value}} that accepts 3 arguments
> to potentially improve performance for 3D vectors.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-compress] HelderMagalhaes commented on pull request #199: Whitespace improvement, site nits and assorted typos
HelderMagalhaes commented on pull request #199:
URL: https://github.com/apache/commons-compress/pull/199#issuecomment-846991690
> I'm a little confused about your PR #197, #198 and #199. They look pretty
similar. What's the difference? It's appreciated if you can close the PRs you
don't want to push.
I did want to push but in different pull requests:
* PR 197 was regarding the "whitespace improvement" which had been submitted
to PR 192 but didn't get through due to being mixed with other changed.
* PR 198 was regarding the "site nits", which are also included here
* The remaining part (the initial goal for this PR) are few typos noticed.
The idea was to keep this one, as it gathers all changes away, in the hope
that mixing slightly different things, particularly whitespace ("If you feel
the source code should be reformatted create a separate PR for this change
first.", as also hinted by @bodewig in already referred PR 192) isn't a
problem. Otherwise I'll also close this PR and try resubmit all three. What do
you think?
> BTW : there're so many commits in your PR. Could you squash them?
If there's a need to resubmit the PR I'll take that into consideration.
Thanks for the feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [commons-compress] HelderMagalhaes commented on pull request #198: Site nits
HelderMagalhaes commented on pull request #198: URL: https://github.com/apache/commons-compress/pull/198#issuecomment-846985033 > Do you mean that there are commits included by mistake in #197 ? Yes: leaving only the most recent PR, which sums all changes. (Sorry for the "noise".) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] HelderMagalhaes closed pull request #198: Site nits
HelderMagalhaes closed pull request #198: URL: https://github.com/apache/commons-compress/pull/198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Issue Comment Deleted] (MATH-1517) "Cluster" leaks internal data
[
https://issues.apache.org/jira/browse/MATH-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Samy Badjoudj updated MATH-1517:
Comment: was deleted
(was: Thanks Gilles
Clustering depends heavily on some utils like Fastmath and linear,
Is there a module coming for utils or linear algebra?)
> "Cluster" leaks internal data
> -
>
> Key: MATH-1517
> URL: https://issues.apache.org/jira/browse/MATH-1517
> Project: Commons Math
> Issue Type: Bug
>Reporter: Gilles Sadowski
>Priority: Major
> Fix For: 4.0
>
> Attachments: MATH-1517_cluster_points_leak
>
>
> Method {{getPoints()}} returns a reference to a mutable instance field.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-compress] HelderMagalhaes edited a comment on pull request #197: Whitespace improvement
HelderMagalhaes edited a comment on pull request #197: URL: https://github.com/apache/commons-compress/pull/197#issuecomment-846983355 Closing PR as the same changes were also included in PR198 and PR199. (Sorry for the "noise".) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] HelderMagalhaes commented on pull request #197: Whitespace improvement
HelderMagalhaes commented on pull request #197: URL: https://github.com/apache/commons-compress/pull/197#issuecomment-846983355 Closing PR as the same changes were also included in PR198 and PR199. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-compress] HelderMagalhaes closed pull request #197: Whitespace improvement
HelderMagalhaes closed pull request #197: URL: https://github.com/apache/commons-compress/pull/197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (COMMONSSITE-146) Cant seem to find the API for Facebook with JS
Martle Monika created COMMONSSITE-146: - Summary: Cant seem to find the API for Facebook with JS Key: COMMONSSITE-146 URL: https://issues.apache.org/jira/browse/COMMONSSITE-146 Project: Apache Commons All Issue Type: Bug Reporter: Martle Monika Cant seem to find the API for Facebook with JS -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MATH-1517) "Cluster" leaks internal data
[
https://issues.apache.org/jira/browse/MATH-1517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17350322#comment-17350322
]
Samy Badjoudj commented on MATH-1517:
-
Thanks Gilles
Clustering depends heavily on some utils like Fastmath and linear,
Is there a module coming for utils or linear algebra?
> "Cluster" leaks internal data
> -
>
> Key: MATH-1517
> URL: https://issues.apache.org/jira/browse/MATH-1517
> Project: Commons Math
> Issue Type: Bug
>Reporter: Gilles Sadowski
>Priority: Major
> Fix For: 4.0
>
> Attachments: MATH-1517_cluster_points_leak
>
>
> Method {{getPoints()}} returns a reference to a mutable instance field.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [commons-digester] dependabot[bot] opened a new pull request #19: Bump maven-javadoc-plugin from 2.8 to 3.3.0
dependabot[bot] opened a new pull request #19: URL: https://github.com/apache/commons-digester/pull/19 Bumps [maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) from 2.8 to 3.3.0. Commits https://github.com/apache/maven-javadoc-plugin/commit/aa3e12c52f0845f0561f3b4db719c0e8ede1aada;>aa3e12c [maven-release-plugin] prepare release maven-javadoc-plugin-3.3.0 https://github.com/apache/maven-javadoc-plugin/commit/55982df63f8de5bfbb48aee353bc29b35b1c6a2c;>55982df [MJAVADOC-584] excludePackageNames is not working as documented anymore https://github.com/apache/maven-javadoc-plugin/commit/e9729cecf01bd1962b5fd4cbff14996bad8f92a6;>e9729ce [MJAVADOC-453] Using Alternate Doclet documentation example snippet is out of... https://github.com/apache/maven-javadoc-plugin/commit/9f98af73ec59629415926374cfe4f6ff3b198e45;>9f98af7 [MJAVADOC-592] detectJavaApiLink should also respect maven.compiler.source pr... https://github.com/apache/maven-javadoc-plugin/commit/1028afcf24ba35eedf1ebbbe62bd9418e06fb7f6;>1028afc [MJAVADOC-592] Prepare integration tests https://github.com/apache/maven-javadoc-plugin/commit/1963ee882e6eb0e4f6c15d5eb6205c31d9f73740;>1963ee8 Bump actions/checkout from 2 to 2.3.4 https://github.com/apache/maven-javadoc-plugin/commit/f27c99dcf35a27ab06b00ad1e2b30336de39fdf8;>f27c99d [MJAVADOC-590] Setting nooverview option always causes a build failure https://github.com/apache/maven-javadoc-plugin/commit/d5b80c06c9d243a3e267c5dbb5961fd9d514ab87;>d5b80c0 Revert (doc) enable streamLogsOnFailure https://github.com/apache/maven-javadoc-plugin/commit/3926bd4cadaa6e4c49c7f973f04927602e384d40;>3926bd4 [MJAVADOC-619] Maven Javadoc bottom claims copyright for future years https://github.com/apache/maven-javadoc-plugin/commit/15a02d6f7928681be6d11a7866ccc09d73a9c869;>15a02d6 (doc) enable streamLogsOnFailure Additional commits viewable in https://github.com/apache/maven-javadoc-plugin/compare/maven-javadoc-plugin-2.8...maven-javadoc-plugin-3.3.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-digester] dependabot[bot] closed pull request #10: Bump maven-javadoc-plugin from 2.8 to 3.2.0
dependabot[bot] closed pull request #10: URL: https://github.com/apache/commons-digester/pull/10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [commons-digester] dependabot[bot] commented on pull request #10: Bump maven-javadoc-plugin from 2.8 to 3.2.0
dependabot[bot] commented on pull request #10: URL: https://github.com/apache/commons-digester/pull/10#issuecomment-846798746 Superseded by #19. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (COMPRESS-566) make gzip deflate buffer size configurable
[ https://issues.apache.org/jira/browse/COMPRESS-566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Bodewig resolved COMPRESS-566. - Fix Version/s: 1.21 Resolution: Fixed > make gzip deflate buffer size configurable > -- > > Key: COMPRESS-566 > URL: https://issues.apache.org/jira/browse/COMPRESS-566 > Project: Commons Compress > Issue Type: Improvement > Components: Compressors >Reporter: Brett Okken >Priority: Minor > Fix For: 1.21 > > Time Spent: 1h 50m > Remaining Estimate: 0h > > The deflateBuffer in GzipCompressorOutputStream is hardcoded to 512. > It would be good if this could be configurable in GzipParameters. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (COMPRESS-566) make gzip deflate buffer size configurable
[ https://issues.apache.org/jira/browse/COMPRESS-566?focusedWorklogId=601028=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601028 ] ASF GitHub Bot logged work on COMPRESS-566: --- Author: ASF GitHub Bot Created on: 24/May/21 06:27 Start Date: 24/May/21 06:27 Worklog Time Spent: 10m Work Description: bodewig merged pull request #168: URL: https://github.com/apache/commons-compress/pull/168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 601028) Time Spent: 1h 50m (was: 1h 40m) > make gzip deflate buffer size configurable > -- > > Key: COMPRESS-566 > URL: https://issues.apache.org/jira/browse/COMPRESS-566 > Project: Commons Compress > Issue Type: Improvement > Components: Compressors >Reporter: Brett Okken >Priority: Minor > Time Spent: 1h 50m > Remaining Estimate: 0h > > The deflateBuffer in GzipCompressorOutputStream is hardcoded to 512. > It would be good if this could be configurable in GzipParameters. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [commons-compress] bodewig merged pull request #168: COMPRESS-566 allow gzip buffer size to be configured
bodewig merged pull request #168: URL: https://github.com/apache/commons-compress/pull/168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
