[jira] [Commented] (CB-9825) Support third-party package managers like Cocoapods and Nuget

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361979#comment-15361979
 ] 

ASF GitHub Bot commented on CB-9825:


Github user shazron commented on the issue:

https://github.com/apache/cordova-ios/pull/234
  
No tests for this feature were available. Tests will need to be added 
before this can land.
The existing tests pass now.


> Support third-party package managers like Cocoapods and Nuget
> -
>
> Key: CB-9825
> URL: https://issues.apache.org/jira/browse/CB-9825
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CordovaLib
>Reporter: Shazron Abdullah
>Assignee: Julia Geist
>  Labels: cordova-ios-5.0.x
>
> ML discussion:
> http://markmail.org/message/5qvg6rwr4nz4q7mc
> cordova-discuss proposal (to be brought back to the list when finalized):
> https://github.com/cordova/cordova-discuss/blob/master/proposals/ThirdPartyPackageManagers.md
> From Steve Gill in the ML:
> At the Cordova F2F, everyone seemed to agree that we should bring CocoaPods
> support to plugins as dependencies for iOS.
> Cordova-android currently uses Gradle as a way to enable external
> dependency resolution for plugins using the framework tag.
> A suggestion about using the engine tag to fetch cocoapods-cli (mac) &
> NuGet (windows) followed by using the framework tag was discussed.
> The minutes[1] show Carlos, Shaz and Raghav as looking into the design.
> Someone should write up a proposal on cordova-discuss[2] and create the
> issues. Post them in this thread.
> This shouldn't take priority over cordova-ios 4 issues.
> [1]
> https://docs.google.com/document/d/1MArKRmnLS052LBbhPxJF57_4ZivghOj8znWo5sTCkbU/edit?usp=sharing
> [2] https://github.com/cordova/cordova-discuss



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9825) Support third-party package managers like Cocoapods and Nuget

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361974#comment-15361974
 ] 

ASF GitHub Bot commented on CB-9825:


Github user shazron commented on a diff in the pull request:

https://github.com/apache/cordova-ios/pull/234#discussion_r69505602
  
--- Diff: bin/templates/scripts/cordova/lib/podMod.js ---
@@ -0,0 +1,162 @@
+var fs = require('fs');
+var util = require('util');
+var events = require('cordova-common').events;
+var superspawn = require('cordova-common').superspawn;
+var CordovaError = require('cordova-common').CordovaError;
+var opts = {};
+/*
+-- After pods are installed in a .xcworkspace, all existing ios code needs 
to go into the WORKSPACE file -- will need to 
+create a workspace file and then embed the Xcode project  
+
+- Holly might have done some work on this, see the docs: 
+  https://github.com/phonegap/phonegap-webview-ios not sure how 
applicable it can be to our case
+*/
+function removeProjectFromPath (pathToProjectFile) {
+var array = [];
+//remove the project from the path
+array = pathToProjectFile.split('/');
+array.pop();
+var path = array.join('/');
+return path;
+}
+
+function createPodfile (projectName, pathToProjectFile) {
+var path = removeProjectFromPath(pathToProjectFile);
+var pathToPodfile = path + '/Podfile';
+var podfileText = util.format('platform :ios, \'8.0\'\n\ntarget \'%s\' 
do\n\n  project \'%s\'\n\n  \n\nend' , projectName, pathToProjectFile);
+fs.writeFileSync(pathToPodfile, podfileText);
+}
+
+function editPodfileSync (Podfile, pod, isRemoval) {
+var podfileContents = fs.readFileSync(Podfile, 'utf8');
+//split by \n, add in the pod after the project line, shift the rest 
down
+var podfileContentsArray = podfileContents.split('\n');
+var linesInPodfileToKeep = [];
+
+if (isRemoval) {
+podfileContentsArray.forEach (function (lineInPodfile) {
+//if the line in Podfile is the pod to rm, don't save it to 
new array (to be returned)
+if (!lineInPodfile.includes(pod)){
+linesInPodfileToKeep.push(lineInPodfile); 
+}
+});
+podfileContents = linesInPodfileToKeep.join('\n');
+} else {
+podfileContentsArray.splice(5, 0, pod);
+podfileContents = podfileContentsArray.join('\n');
+}
+return podfileContents;
+}
+
+function superspawnPodInstall (path, isPathToProjectFile) {
+// change working directory for all calls of pod install to 
platforms/ios
+if (isPathToProjectFile){
+//if the path passed leads to the project, and not the dir that 
contains the proj
+ //remove the project from the path
+path = removeProjectFromPath(path);
+}
+opts.cwd = path;
+superspawn.spawn('pod', ['install'], opts);
+}
+
+function installPodSync (projectName, pathToProjectFile, nameOfPod, 
podSpec, podsJSON) {
+// called from cordova project directory-- when invoked, args are as 
follows
+//  projectName = cordovaProject (name) and 
+//  pathToProjectFile   = ./path/to/cordovaProject 
+//  nameOfPod   = obj.src   //from framework 
tag
+//  podSpec = obj.spec  //from framework 
tag   
+//  podsJSON= pods.json file in 
cordovaProjectDir/platforms/ios/
+
+// readFileSync will currently truncate the Podfile if it exists
+// if a Podfile doesn't exist, one will be created
+
+// this code will be run during cordova plugin add x -- which has to 
be run in the cordova project dir
+
+//---
+//ERROR
+//
+//if no podName is specified, console err 
+if (nameOfPod === '' || nameOfPod === ' '){
+throw new CordovaError('\nERROR: name of pod is not specified\n');
+}
+//---
+
+podSpec = podSpec || ''; //spec is optional
+
+var stringToWrite; //overwrites Podfile
+var lineToInjectInPodfile; //adds pod
+var path = removeProjectFromPath(pathToProjectFile);
+var podfile = path + '/Podfile';
+var podfileExistsInCurrentDirectory = fs.existsSync(podfile);   
//bool
+var podExistsInPodsJSON = podsJSON[nameOfPod];  
//bool
+var podRequestedForSpecChange;  
//bool
+   
+if (podSpec === '') {
+lineToInjectInPodfile = util.format('pod \'%s\'', nameOfPod);
+podRequestedForSpecChange = false;
+} else {
+

[jira] [Commented] (CB-9825) Support third-party package managers like Cocoapods and Nuget

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361972#comment-15361972
 ] 

ASF GitHub Bot commented on CB-9825:


Github user shazron commented on a diff in the pull request:

https://github.com/apache/cordova-ios/pull/234#discussion_r69505429
  
--- Diff: bin/templates/scripts/cordova/Api.js ---
@@ -236,10 +317,50 @@ Api.prototype.addPlugin = function (plugin, 
installOptions) {
  *   CordovaError instance.
  */
 Api.prototype.removePlugin = function (plugin, uninstallOptions) {
-
 var xcodeproj = projectFile.parse(this.locations);
 return PluginManager.get(this.platform, this.locations, xcodeproj)
 .removePlugin(plugin, uninstallOptions)
+.then(function() {
+if (plugin.getFrameworks(this.platform).length === 0) return;
+console.log('Looking into removing pods since the plugin 
contained ');
+//require script to run pod remove
+//pods.json might not exist (if not pods were removed). 
+//the pod will already be removed from pods.json at this 
stage
+//need to check podfile and see if a pod exists in podfile 
that doesn't exist in pods.json. If so, remove it.
+
+// which pods are in the plugin? 
+var frameworkTags = plugin.getFrameworks(this.platform);
+var project_dir = this.locations.root;
+var pods_file = path.join(project_dir, 'pods.json');
+var array_of_pod_objects = [];
+
+delete require.cache[require.resolve(pods_file)];
+var pods = require(pods_file);
+
+// check if any of the framework tags are of type 
"podspec" 
+frameworkTags.forEach(function (obj) { 
+if (obj.type == 'podspec') {
+array_of_pod_objects.push(obj);
+}
+});
+
+var podMod = require('./lib/podMod');
+
+array_of_pod_objects.forEach(function (obj) {
+// according to pods.json, does more than one plugin 
depend on the pod?
+if (pods[obj.src].count > 1) {
--- End diff --

Inconsistent logic from your other code: 
https://github.com/apache/cordova-ios/pull/234/commits/e95fd6f393b7888b8d739dfbe8bd84805e30c67e#diff-4dd01b7c4b3f825b9b9e6f223a83ec71R104


> Support third-party package managers like Cocoapods and Nuget
> -
>
> Key: CB-9825
> URL: https://issues.apache.org/jira/browse/CB-9825
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CordovaLib
>Reporter: Shazron Abdullah
>Assignee: Julia Geist
>  Labels: cordova-ios-5.0.x
>
> ML discussion:
> http://markmail.org/message/5qvg6rwr4nz4q7mc
> cordova-discuss proposal (to be brought back to the list when finalized):
> https://github.com/cordova/cordova-discuss/blob/master/proposals/ThirdPartyPackageManagers.md
> From Steve Gill in the ML:
> At the Cordova F2F, everyone seemed to agree that we should bring CocoaPods
> support to plugins as dependencies for iOS.
> Cordova-android currently uses Gradle as a way to enable external
> dependency resolution for plugins using the framework tag.
> A suggestion about using the engine tag to fetch cocoapods-cli (mac) &
> NuGet (windows) followed by using the framework tag was discussed.
> The minutes[1] show Carlos, Shaz and Raghav as looking into the design.
> Someone should write up a proposal on cordova-discuss[2] and create the
> issues. Post them in this thread.
> This shouldn't take priority over cordova-ios 4 issues.
> [1]
> https://docs.google.com/document/d/1MArKRmnLS052LBbhPxJF57_4ZivghOj8znWo5sTCkbU/edit?usp=sharing
> [2] https://github.com/cordova/cordova-discuss



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9825) Support third-party package managers like Cocoapods and Nuget

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361971#comment-15361971
 ] 

ASF GitHub Bot commented on CB-9825:


Github user shazron commented on a diff in the pull request:

https://github.com/apache/cordova-ios/pull/234#discussion_r69505374
  
--- Diff: bin/templates/scripts/cordova/lib/plugman/pluginHandlers.js ---
@@ -91,18 +93,29 @@ var handlers = {
 }
 },
 uninstall:function(obj, plugin, project, options) {
+var podsJSON = require(path.join(project.projectDir, 
'pods.json'));
 var src = obj.src;
 
 if (!obj.custom) {
 var keepFrameworks = keep_these_frameworks;
-
 if (keepFrameworks.indexOf(src) < 0) {
-project.frameworks[src] -= (project.frameworks[src] || 
1) - 1;
-if (project.frameworks[src] < 1) {
-// Only remove non-custom framework from xcode 
project
-// if there is no references remains
-project.xcode.removeFramework(src);
-delete project.frameworks[src];
+if (obj.type === 'podspec') {
+if(podsJSON[src]) {
+if((podsJSON[src].count - 1) > 0) {
--- End diff --

inconsistent logic from your previous code: 
https://github.com/apache/cordova-ios/pull/234/commits/e95fd6f393b7888b8d739dfbe8bd84805e30c67e#diff-7cbe904f09934e43c81805491f152965R351


> Support third-party package managers like Cocoapods and Nuget
> -
>
> Key: CB-9825
> URL: https://issues.apache.org/jira/browse/CB-9825
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CordovaLib
>Reporter: Shazron Abdullah
>Assignee: Julia Geist
>  Labels: cordova-ios-5.0.x
>
> ML discussion:
> http://markmail.org/message/5qvg6rwr4nz4q7mc
> cordova-discuss proposal (to be brought back to the list when finalized):
> https://github.com/cordova/cordova-discuss/blob/master/proposals/ThirdPartyPackageManagers.md
> From Steve Gill in the ML:
> At the Cordova F2F, everyone seemed to agree that we should bring CocoaPods
> support to plugins as dependencies for iOS.
> Cordova-android currently uses Gradle as a way to enable external
> dependency resolution for plugins using the framework tag.
> A suggestion about using the engine tag to fetch cocoapods-cli (mac) &
> NuGet (windows) followed by using the framework tag was discussed.
> The minutes[1] show Carlos, Shaz and Raghav as looking into the design.
> Someone should write up a proposal on cordova-discuss[2] and create the
> issues. Post them in this thread.
> This shouldn't take priority over cordova-ios 4 issues.
> [1]
> https://docs.google.com/document/d/1MArKRmnLS052LBbhPxJF57_4ZivghOj8znWo5sTCkbU/edit?usp=sharing
> [2] https://github.com/cordova/cordova-discuss



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9825) Support third-party package managers like Cocoapods and Nuget

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361969#comment-15361969
 ] 

ASF GitHub Bot commented on CB-9825:


Github user shazron commented on a diff in the pull request:

https://github.com/apache/cordova-ios/pull/234#discussion_r69505064
  
--- Diff: bin/templates/scripts/cordova/lib/podMod.js ---
@@ -0,0 +1,162 @@
+var fs = require('fs');
+var util = require('util');
+var events = require('cordova-common').events;
+var superspawn = require('cordova-common').superspawn;
+var CordovaError = require('cordova-common').CordovaError;
+var opts = {};
+/*
+-- After pods are installed in a .xcworkspace, all existing ios code needs 
to go into the WORKSPACE file -- will need to 
+create a workspace file and then embed the Xcode project  
+
+- Holly might have done some work on this, see the docs: 
+  https://github.com/phonegap/phonegap-webview-ios not sure how 
applicable it can be to our case
+*/
+function removeProjectFromPath (pathToProjectFile) {
+var array = [];
+//remove the project from the path
+array = pathToProjectFile.split('/');
+array.pop();
+var path = array.join('/');
+return path;
+}
+
+function createPodfile (projectName, pathToProjectFile) {
+var path = removeProjectFromPath(pathToProjectFile);
+var pathToPodfile = path + '/Podfile';
+var podfileText = util.format('platform :ios, \'8.0\'\n\ntarget \'%s\' 
do\n\n  project \'%s\'\n\n  \n\nend' , projectName, pathToProjectFile);
+fs.writeFileSync(pathToPodfile, podfileText);
+}
+
+function editPodfileSync (Podfile, pod, isRemoval) {
+var podfileContents = fs.readFileSync(Podfile, 'utf8');
+//split by \n, add in the pod after the project line, shift the rest 
down
+var podfileContentsArray = podfileContents.split('\n');
+var linesInPodfileToKeep = [];
+
+if (isRemoval) {
+podfileContentsArray.forEach (function (lineInPodfile) {
+//if the line in Podfile is the pod to rm, don't save it to 
new array (to be returned)
+if (!lineInPodfile.includes(pod)){
+linesInPodfileToKeep.push(lineInPodfile); 
+}
+});
+podfileContents = linesInPodfileToKeep.join('\n');
+} else {
+podfileContentsArray.splice(5, 0, pod);
--- End diff --

What is this magic number 5? if it's the length of a known token, 
substitute for "yourknowntoken".length


> Support third-party package managers like Cocoapods and Nuget
> -
>
> Key: CB-9825
> URL: https://issues.apache.org/jira/browse/CB-9825
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CordovaLib
>Reporter: Shazron Abdullah
>Assignee: Julia Geist
>  Labels: cordova-ios-5.0.x
>
> ML discussion:
> http://markmail.org/message/5qvg6rwr4nz4q7mc
> cordova-discuss proposal (to be brought back to the list when finalized):
> https://github.com/cordova/cordova-discuss/blob/master/proposals/ThirdPartyPackageManagers.md
> From Steve Gill in the ML:
> At the Cordova F2F, everyone seemed to agree that we should bring CocoaPods
> support to plugins as dependencies for iOS.
> Cordova-android currently uses Gradle as a way to enable external
> dependency resolution for plugins using the framework tag.
> A suggestion about using the engine tag to fetch cocoapods-cli (mac) &
> NuGet (windows) followed by using the framework tag was discussed.
> The minutes[1] show Carlos, Shaz and Raghav as looking into the design.
> Someone should write up a proposal on cordova-discuss[2] and create the
> issues. Post them in this thread.
> This shouldn't take priority over cordova-ios 4 issues.
> [1]
> https://docs.google.com/document/d/1MArKRmnLS052LBbhPxJF57_4ZivghOj8znWo5sTCkbU/edit?usp=sharing
> [2] https://github.com/cordova/cordova-discuss



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9825) Support third-party package managers like Cocoapods and Nuget

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361967#comment-15361967
 ] 

ASF GitHub Bot commented on CB-9825:


Github user shazron commented on a diff in the pull request:

https://github.com/apache/cordova-ios/pull/234#discussion_r69504887
  
--- Diff: bin/templates/scripts/cordova/lib/podMod.js ---
@@ -0,0 +1,162 @@
+var fs = require('fs');
+var util = require('util');
+var events = require('cordova-common').events;
+var superspawn = require('cordova-common').superspawn;
+var CordovaError = require('cordova-common').CordovaError;
+var opts = {};
+/*
+-- After pods are installed in a .xcworkspace, all existing ios code needs 
to go into the WORKSPACE file -- will need to 
+create a workspace file and then embed the Xcode project  
+
+- Holly might have done some work on this, see the docs: 
+  https://github.com/phonegap/phonegap-webview-ios not sure how 
applicable it can be to our case
+*/
+function removeProjectFromPath (pathToProjectFile) {
+var array = [];
+//remove the project from the path
+array = pathToProjectFile.split('/');
+array.pop();
+var path = array.join('/');
+return path;
+}
+
+function createPodfile (projectName, pathToProjectFile) {
+var path = removeProjectFromPath(pathToProjectFile);
+var pathToPodfile = path + '/Podfile';
+var podfileText = util.format('platform :ios, \'8.0\'\n\ntarget \'%s\' 
do\n\n  project \'%s\'\n\n  \n\nend' , projectName, pathToProjectFile);
+fs.writeFileSync(pathToPodfile, podfileText);
+}
+
+function editPodfileSync (Podfile, pod, isRemoval) {
+var podfileContents = fs.readFileSync(Podfile, 'utf8');
+//split by \n, add in the pod after the project line, shift the rest 
down
+var podfileContentsArray = podfileContents.split('\n');
+var linesInPodfileToKeep = [];
+
+if (isRemoval) {
+podfileContentsArray.forEach (function (lineInPodfile) {
--- End diff --

use Array.filter here


> Support third-party package managers like Cocoapods and Nuget
> -
>
> Key: CB-9825
> URL: https://issues.apache.org/jira/browse/CB-9825
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CordovaLib
>Reporter: Shazron Abdullah
>Assignee: Julia Geist
>  Labels: cordova-ios-5.0.x
>
> ML discussion:
> http://markmail.org/message/5qvg6rwr4nz4q7mc
> cordova-discuss proposal (to be brought back to the list when finalized):
> https://github.com/cordova/cordova-discuss/blob/master/proposals/ThirdPartyPackageManagers.md
> From Steve Gill in the ML:
> At the Cordova F2F, everyone seemed to agree that we should bring CocoaPods
> support to plugins as dependencies for iOS.
> Cordova-android currently uses Gradle as a way to enable external
> dependency resolution for plugins using the framework tag.
> A suggestion about using the engine tag to fetch cocoapods-cli (mac) &
> NuGet (windows) followed by using the framework tag was discussed.
> The minutes[1] show Carlos, Shaz and Raghav as looking into the design.
> Someone should write up a proposal on cordova-discuss[2] and create the
> issues. Post them in this thread.
> This shouldn't take priority over cordova-ios 4 issues.
> [1]
> https://docs.google.com/document/d/1MArKRmnLS052LBbhPxJF57_4ZivghOj8znWo5sTCkbU/edit?usp=sharing
> [2] https://github.com/cordova/cordova-discuss



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9825) Support third-party package managers like Cocoapods and Nuget

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361966#comment-15361966
 ] 

ASF GitHub Bot commented on CB-9825:


Github user shazron commented on a diff in the pull request:

https://github.com/apache/cordova-ios/pull/234#discussion_r69504867
  
--- Diff: bin/templates/scripts/cordova/lib/podMod.js ---
@@ -0,0 +1,162 @@
+var fs = require('fs');
+var util = require('util');
+var events = require('cordova-common').events;
+var superspawn = require('cordova-common').superspawn;
+var CordovaError = require('cordova-common').CordovaError;
+var opts = {};
+/*
+-- After pods are installed in a .xcworkspace, all existing ios code needs 
to go into the WORKSPACE file -- will need to 
+create a workspace file and then embed the Xcode project  
+
+- Holly might have done some work on this, see the docs: 
+  https://github.com/phonegap/phonegap-webview-ios not sure how 
applicable it can be to our case
+*/
+function removeProjectFromPath (pathToProjectFile) {
+var array = [];
+//remove the project from the path
+array = pathToProjectFile.split('/');
+array.pop();
+var path = array.join('/');
+return path;
+}
+
+function createPodfile (projectName, pathToProjectFile) {
+var path = removeProjectFromPath(pathToProjectFile);
+var pathToPodfile = path + '/Podfile';
--- End diff --

use path.join here for cross-platform path separators


> Support third-party package managers like Cocoapods and Nuget
> -
>
> Key: CB-9825
> URL: https://issues.apache.org/jira/browse/CB-9825
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CordovaLib
>Reporter: Shazron Abdullah
>Assignee: Julia Geist
>  Labels: cordova-ios-5.0.x
>
> ML discussion:
> http://markmail.org/message/5qvg6rwr4nz4q7mc
> cordova-discuss proposal (to be brought back to the list when finalized):
> https://github.com/cordova/cordova-discuss/blob/master/proposals/ThirdPartyPackageManagers.md
> From Steve Gill in the ML:
> At the Cordova F2F, everyone seemed to agree that we should bring CocoaPods
> support to plugins as dependencies for iOS.
> Cordova-android currently uses Gradle as a way to enable external
> dependency resolution for plugins using the framework tag.
> A suggestion about using the engine tag to fetch cocoapods-cli (mac) &
> NuGet (windows) followed by using the framework tag was discussed.
> The minutes[1] show Carlos, Shaz and Raghav as looking into the design.
> Someone should write up a proposal on cordova-discuss[2] and create the
> issues. Post them in this thread.
> This shouldn't take priority over cordova-ios 4 issues.
> [1]
> https://docs.google.com/document/d/1MArKRmnLS052LBbhPxJF57_4ZivghOj8znWo5sTCkbU/edit?usp=sharing
> [2] https://github.com/cordova/cordova-discuss



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9825) Support third-party package managers like Cocoapods and Nuget

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361962#comment-15361962
 ] 

ASF GitHub Bot commented on CB-9825:


Github user shazron commented on a diff in the pull request:

https://github.com/apache/cordova-ios/pull/234#discussion_r69504824
  
--- Diff: bin/templates/scripts/cordova/lib/plugman/pluginHandlers.js ---
@@ -91,18 +93,29 @@ var handlers = {
 }
 },
 uninstall:function(obj, plugin, project, options) {
+var podsJSON = require(path.join(project.projectDir, 
'pods.json'));
 var src = obj.src;
 
 if (!obj.custom) {
 var keepFrameworks = keep_these_frameworks;
-
 if (keepFrameworks.indexOf(src) < 0) {
-project.frameworks[src] -= (project.frameworks[src] || 
1) - 1;
-if (project.frameworks[src] < 1) {
-// Only remove non-custom framework from xcode 
project
-// if there is no references remains
-project.xcode.removeFramework(src);
-delete project.frameworks[src];
+if (obj.type === 'podspec') {
+if(podsJSON[src]) {
+if((podsJSON[src].count - 1) > 0) {
+podsJSON[src].count = podsJSON[src].count 
- 1;
+} else {
+delete podsJSON[src];
+}
+}
+} else {
+project.frameworks[src] -= 
(project.frameworks[src] || 1) - 1;
--- End diff --

Not your code but I'm not sure if this code is correct. It's definitely 
confusing as heck.
equivalent to 
```
project.frameworks[src] = project.frameworks[src] - 
(project.frameworks[src] || 1) - 1
```


> Support third-party package managers like Cocoapods and Nuget
> -
>
> Key: CB-9825
> URL: https://issues.apache.org/jira/browse/CB-9825
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CordovaLib
>Reporter: Shazron Abdullah
>Assignee: Julia Geist
>  Labels: cordova-ios-5.0.x
>
> ML discussion:
> http://markmail.org/message/5qvg6rwr4nz4q7mc
> cordova-discuss proposal (to be brought back to the list when finalized):
> https://github.com/cordova/cordova-discuss/blob/master/proposals/ThirdPartyPackageManagers.md
> From Steve Gill in the ML:
> At the Cordova F2F, everyone seemed to agree that we should bring CocoaPods
> support to plugins as dependencies for iOS.
> Cordova-android currently uses Gradle as a way to enable external
> dependency resolution for plugins using the framework tag.
> A suggestion about using the engine tag to fetch cocoapods-cli (mac) &
> NuGet (windows) followed by using the framework tag was discussed.
> The minutes[1] show Carlos, Shaz and Raghav as looking into the design.
> Someone should write up a proposal on cordova-discuss[2] and create the
> issues. Post them in this thread.
> This shouldn't take priority over cordova-ios 4 issues.
> [1]
> https://docs.google.com/document/d/1MArKRmnLS052LBbhPxJF57_4ZivghOj8znWo5sTCkbU/edit?usp=sharing
> [2] https://github.com/cordova/cordova-discuss



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9825) Support third-party package managers like Cocoapods and Nuget

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361959#comment-15361959
 ] 

ASF GitHub Bot commented on CB-9825:


Github user shazron commented on a diff in the pull request:

https://github.com/apache/cordova-ios/pull/234#discussion_r69504742
  
--- Diff: bin/templates/scripts/cordova/lib/plugman/pluginHandlers.js ---
@@ -66,17 +66,19 @@ var handlers = {
 install:function(obj, plugin, project, options) {
 var src = obj.src,
 custom = obj.custom;
-
 if (!custom) {
 var keepFrameworks = keep_these_frameworks;
 
-if (keepFrameworks.indexOf(src) < 0) {
-project.xcode.addFramework(src, {weak: obj.weak});
-project.frameworks[src] = (project.frameworks[src] || 
0) + 1;
+if (keepFrameworks.indexOf(src) < 0) { 
+if (obj.type === 'podspec') {
+//podspec handled in Api.js
+} else {
+project.frameworks[src] = (project.frameworks[src] 
|| 0) + 1;
--- End diff --

not your code, but dislike code like this that tries to be clever although 
I know the meaning is "increment by 1. set to zero first if it doesn't exist"


> Support third-party package managers like Cocoapods and Nuget
> -
>
> Key: CB-9825
> URL: https://issues.apache.org/jira/browse/CB-9825
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CordovaLib
>Reporter: Shazron Abdullah
>Assignee: Julia Geist
>  Labels: cordova-ios-5.0.x
>
> ML discussion:
> http://markmail.org/message/5qvg6rwr4nz4q7mc
> cordova-discuss proposal (to be brought back to the list when finalized):
> https://github.com/cordova/cordova-discuss/blob/master/proposals/ThirdPartyPackageManagers.md
> From Steve Gill in the ML:
> At the Cordova F2F, everyone seemed to agree that we should bring CocoaPods
> support to plugins as dependencies for iOS.
> Cordova-android currently uses Gradle as a way to enable external
> dependency resolution for plugins using the framework tag.
> A suggestion about using the engine tag to fetch cocoapods-cli (mac) &
> NuGet (windows) followed by using the framework tag was discussed.
> The minutes[1] show Carlos, Shaz and Raghav as looking into the design.
> Someone should write up a proposal on cordova-discuss[2] and create the
> issues. Post them in this thread.
> This shouldn't take priority over cordova-ios 4 issues.
> [1]
> https://docs.google.com/document/d/1MArKRmnLS052LBbhPxJF57_4ZivghOj8znWo5sTCkbU/edit?usp=sharing
> [2] https://github.com/cordova/cordova-discuss



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9825) Support third-party package managers like Cocoapods and Nuget

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361957#comment-15361957
 ] 

ASF GitHub Bot commented on CB-9825:


Github user shazron commented on a diff in the pull request:

https://github.com/apache/cordova-ios/pull/234#discussion_r69504623
  
--- Diff: bin/templates/scripts/cordova/Api.js ---
@@ -236,10 +317,50 @@ Api.prototype.addPlugin = function (plugin, 
installOptions) {
  *   CordovaError instance.
  */
 Api.prototype.removePlugin = function (plugin, uninstallOptions) {
-
 var xcodeproj = projectFile.parse(this.locations);
 return PluginManager.get(this.platform, this.locations, xcodeproj)
 .removePlugin(plugin, uninstallOptions)
+.then(function() {
+if (plugin.getFrameworks(this.platform).length === 0) return;
+console.log('Looking into removing pods since the plugin 
contained ');
+//require script to run pod remove
+//pods.json might not exist (if not pods were removed). 
+//the pod will already be removed from pods.json at this 
stage
+//need to check podfile and see if a pod exists in podfile 
that doesn't exist in pods.json. If so, remove it.
+
+// which pods are in the plugin? 
+var frameworkTags = plugin.getFrameworks(this.platform);
+var project_dir = this.locations.root;
+var pods_file = path.join(project_dir, 'pods.json');
+var array_of_pod_objects = [];
+
+delete require.cache[require.resolve(pods_file)];
+var pods = require(pods_file);
+
+// check if any of the framework tags are of type 
"podspec" 
+frameworkTags.forEach(function (obj) { 
--- End diff --

use Array.filter instead


> Support third-party package managers like Cocoapods and Nuget
> -
>
> Key: CB-9825
> URL: https://issues.apache.org/jira/browse/CB-9825
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CordovaLib
>Reporter: Shazron Abdullah
>Assignee: Julia Geist
>  Labels: cordova-ios-5.0.x
>
> ML discussion:
> http://markmail.org/message/5qvg6rwr4nz4q7mc
> cordova-discuss proposal (to be brought back to the list when finalized):
> https://github.com/cordova/cordova-discuss/blob/master/proposals/ThirdPartyPackageManagers.md
> From Steve Gill in the ML:
> At the Cordova F2F, everyone seemed to agree that we should bring CocoaPods
> support to plugins as dependencies for iOS.
> Cordova-android currently uses Gradle as a way to enable external
> dependency resolution for plugins using the framework tag.
> A suggestion about using the engine tag to fetch cocoapods-cli (mac) &
> NuGet (windows) followed by using the framework tag was discussed.
> The minutes[1] show Carlos, Shaz and Raghav as looking into the design.
> Someone should write up a proposal on cordova-discuss[2] and create the
> issues. Post them in this thread.
> This shouldn't take priority over cordova-ios 4 issues.
> [1]
> https://docs.google.com/document/d/1MArKRmnLS052LBbhPxJF57_4ZivghOj8znWo5sTCkbU/edit?usp=sharing
> [2] https://github.com/cordova/cordova-discuss



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9825) Support third-party package managers like Cocoapods and Nuget

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361956#comment-15361956
 ] 

ASF GitHub Bot commented on CB-9825:


Github user shazron commented on a diff in the pull request:

https://github.com/apache/cordova-ios/pull/234#discussion_r69504555
  
--- Diff: bin/templates/scripts/cordova/Api.js ---
@@ -217,6 +214,90 @@ Api.prototype.addPlugin = function (plugin, 
installOptions) {
 
 return PluginManager.get(this.platform, this.locations, xcodeproj)
 .addPlugin(plugin, installOptions)
+.then(function() {
+var project_dir = this.locations.root;
+var project_path = this.locations.xcodeProjDir;
+var project_name = 
this.locations.xcodeCordovaProj.split('/').pop();
+var array_of_pod_objects = [];
+
+if (plugin.getFrameworks(this.platform).length === 0) return;
+events.emit('verbose', 'Looking into adding pods since the 
plugin contained ');
+
+var pods_file = path.join(project_dir, 'pods.json');
+var pods = {};
+
+try {
+delete require.cache[require.resolve(pods_file)];
+pods = require(pods_file);
+} catch (e) { 
+/* no pods.json exists */ 
+// create an empty pods.json file 
+fs.writeFileSync(pods_file, JSON.stringify({}));
+delete require.cache[require.resolve(pods_file)];
+pods = require(pods_file);
+}  
+
+var podMod = require('./lib/podMod');
+var frameworkTags = plugin.getFrameworks(this.platform);
+
+// check if any of the framework tags are of type "podspec" 
+frameworkTags.forEach(function (obj) { 
+if (obj.type == 'podspec') {
+array_of_pod_objects.push(obj);
+}
+});
+
+var podIsAlreadyInPodfile;
+
+array_of_pod_objects.forEach(function (obj) {
+//check if pod already exists, if so if spec has changed 
+//if pods.json does not exist yet, create it
+// if it does not exist, only overwrite the type and spec, 
NOT the count
+var nameOfPod = obj.src;
+
+if(!pods[nameOfPod]) {
+pods[nameOfPod] = {'type': obj.type, 'spec': obj.spec};
+podIsAlreadyInPodfile = false;
+} else {
+pods[nameOfPod].type = obj.type;
+pods[nameOfPod].spec = obj.spec;
+podIsAlreadyInPodfile = true;
+}
+
+// add a count incase multiple plugins depend on it.
+if (pods[nameOfPod].count) {
+pods[nameOfPod].count = pods[nameOfPod].count + 1;
+} else {
+pods[nameOfPod].count = 1;
+} 
+
+function addToPodfile (callback) {
--- End diff --

see corresponding note below. Function does not need a callback since the 
contents are synchronous.


> Support third-party package managers like Cocoapods and Nuget
> -
>
> Key: CB-9825
> URL: https://issues.apache.org/jira/browse/CB-9825
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CordovaLib
>Reporter: Shazron Abdullah
>Assignee: Julia Geist
>  Labels: cordova-ios-5.0.x
>
> ML discussion:
> http://markmail.org/message/5qvg6rwr4nz4q7mc
> cordova-discuss proposal (to be brought back to the list when finalized):
> https://github.com/cordova/cordova-discuss/blob/master/proposals/ThirdPartyPackageManagers.md
> From Steve Gill in the ML:
> At the Cordova F2F, everyone seemed to agree that we should bring CocoaPods
> support to plugins as dependencies for iOS.
> Cordova-android currently uses Gradle as a way to enable external
> dependency resolution for plugins using the framework tag.
> A suggestion about using the engine tag to fetch cocoapods-cli (mac) &
> NuGet (windows) followed by using the framework tag was discussed.
> The minutes[1] show Carlos, Shaz and Raghav as looking into the design.
> Someone should write up a proposal on cordova-discuss[2] and create the
> issues. Post them in this thread.
> This shouldn't take priority over cordova-ios 4 issues.
> [1]
> https://docs.google.com/document/d/1MArKRmnLS052LBbhPxJF57_4ZivghOj8znWo5sTCkbU/edit?usp=sharing
> [2] 

[jira] [Commented] (CB-9825) Support third-party package managers like Cocoapods and Nuget

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361952#comment-15361952
 ] 

ASF GitHub Bot commented on CB-9825:


Github user shazron commented on a diff in the pull request:

https://github.com/apache/cordova-ios/pull/234#discussion_r69504527
  
--- Diff: bin/templates/scripts/cordova/Api.js ---
@@ -217,6 +214,90 @@ Api.prototype.addPlugin = function (plugin, 
installOptions) {
 
 return PluginManager.get(this.platform, this.locations, xcodeproj)
 .addPlugin(plugin, installOptions)
+.then(function() {
+var project_dir = this.locations.root;
+var project_path = this.locations.xcodeProjDir;
+var project_name = 
this.locations.xcodeCordovaProj.split('/').pop();
+var array_of_pod_objects = [];
+
+if (plugin.getFrameworks(this.platform).length === 0) return;
+events.emit('verbose', 'Looking into adding pods since the 
plugin contained ');
+
+var pods_file = path.join(project_dir, 'pods.json');
+var pods = {};
+
+try {
+delete require.cache[require.resolve(pods_file)];
+pods = require(pods_file);
+} catch (e) { 
+/* no pods.json exists */ 
+// create an empty pods.json file 
+fs.writeFileSync(pods_file, JSON.stringify({}));
+delete require.cache[require.resolve(pods_file)];
+pods = require(pods_file);
+}  
+
+var podMod = require('./lib/podMod');
+var frameworkTags = plugin.getFrameworks(this.platform);
+
+// check if any of the framework tags are of type "podspec" 
+frameworkTags.forEach(function (obj) { 
+if (obj.type == 'podspec') {
+array_of_pod_objects.push(obj);
+}
+});
+
+var podIsAlreadyInPodfile;
+
+array_of_pod_objects.forEach(function (obj) {
+//check if pod already exists, if so if spec has changed 
+//if pods.json does not exist yet, create it
+// if it does not exist, only overwrite the type and spec, 
NOT the count
+var nameOfPod = obj.src;
+
+if(!pods[nameOfPod]) {
+pods[nameOfPod] = {'type': obj.type, 'spec': obj.spec};
+podIsAlreadyInPodfile = false;
+} else {
+pods[nameOfPod].type = obj.type;
+pods[nameOfPod].spec = obj.spec;
+podIsAlreadyInPodfile = true;
+}
+
+// add a count incase multiple plugins depend on it.
+if (pods[nameOfPod].count) {
+pods[nameOfPod].count = pods[nameOfPod].count + 1;
+} else {
+pods[nameOfPod].count = 1;
+} 
+
+function addToPodfile (callback) {
+podMod.installPodSync(project_name, project_path, 
nameOfPod, obj.spec, pods_file); 
+events.emit('verbose', 'About to add ' + nameOfPod + ' 
to pods json');
+callback();
+}
+
+//write out updated pods.json, 
+// keep track of the order of the pods
+function addToPodsJSON () {
+try { 
+fs.writeFileSync(pods_file, JSON.stringify(pods, 
null, 4));
+} catch (e) {
+throw new CordovaError('\nPod was not able to be 
added to pods.json in Api.js\n\n' + e);
+}
+}
+
+if (podIsAlreadyInPodfile) {
+addToPodsJSON();
+} else if (!podIsAlreadyInPodfile) {
+//add the pods to the Podfile, then add to pods.json
+addToPodfile(addToPodsJSON);
--- End diff --

addToPodfile does not need to take in a callback since the function is 
synchronous.

so this line can just be:

addToPodFile();
addToPodsJSON();


> Support third-party package managers like Cocoapods and Nuget
> -
>
> Key: CB-9825
> URL: https://issues.apache.org/jira/browse/CB-9825
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: 

[jira] [Commented] (CB-9825) Support third-party package managers like Cocoapods and Nuget

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-9825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361951#comment-15361951
 ] 

ASF GitHub Bot commented on CB-9825:


Github user shazron commented on a diff in the pull request:

https://github.com/apache/cordova-ios/pull/234#discussion_r69504477
  
--- Diff: bin/templates/scripts/cordova/Api.js ---
@@ -217,6 +214,90 @@ Api.prototype.addPlugin = function (plugin, 
installOptions) {
 
 return PluginManager.get(this.platform, this.locations, xcodeproj)
 .addPlugin(plugin, installOptions)
+.then(function() {
+var project_dir = this.locations.root;
+var project_path = this.locations.xcodeProjDir;
+var project_name = 
this.locations.xcodeCordovaProj.split('/').pop();
+var array_of_pod_objects = [];
+
+if (plugin.getFrameworks(this.platform).length === 0) return;
+events.emit('verbose', 'Looking into adding pods since the 
plugin contained ');
+
+var pods_file = path.join(project_dir, 'pods.json');
+var pods = {};
+
+try {
+delete require.cache[require.resolve(pods_file)];
+pods = require(pods_file);
+} catch (e) { 
+/* no pods.json exists */ 
+// create an empty pods.json file 
+fs.writeFileSync(pods_file, JSON.stringify({}));
+delete require.cache[require.resolve(pods_file)];
+pods = require(pods_file);
+}  
+
+var podMod = require('./lib/podMod');
+var frameworkTags = plugin.getFrameworks(this.platform);
+
+// check if any of the framework tags are of type "podspec" 
+frameworkTags.forEach(function (obj) { 
--- End diff --

use Array.filter to do this instead


> Support third-party package managers like Cocoapods and Nuget
> -
>
> Key: CB-9825
> URL: https://issues.apache.org/jira/browse/CB-9825
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CordovaLib
>Reporter: Shazron Abdullah
>Assignee: Julia Geist
>  Labels: cordova-ios-5.0.x
>
> ML discussion:
> http://markmail.org/message/5qvg6rwr4nz4q7mc
> cordova-discuss proposal (to be brought back to the list when finalized):
> https://github.com/cordova/cordova-discuss/blob/master/proposals/ThirdPartyPackageManagers.md
> From Steve Gill in the ML:
> At the Cordova F2F, everyone seemed to agree that we should bring CocoaPods
> support to plugins as dependencies for iOS.
> Cordova-android currently uses Gradle as a way to enable external
> dependency resolution for plugins using the framework tag.
> A suggestion about using the engine tag to fetch cocoapods-cli (mac) &
> NuGet (windows) followed by using the framework tag was discussed.
> The minutes[1] show Carlos, Shaz and Raghav as looking into the design.
> Someone should write up a proposal on cordova-discuss[2] and create the
> issues. Post them in this thread.
> This shouldn't take priority over cordova-ios 4 issues.
> [1]
> https://docs.google.com/document/d/1MArKRmnLS052LBbhPxJF57_4ZivghOj8znWo5sTCkbU/edit?usp=sharing
> [2] https://github.com/cordova/cordova-discuss



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11533) Launch images won't be needed on iOS.

[zhuisui (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361913#comment-15361913
 ] 

zhuisui commented on CB-11533:
--

After I delete images in LaunchImage(not itself), it can build successfully.

> Launch images won't be needed on iOS.
> -
>
> Key: CB-11533
> URL: https://issues.apache.org/jira/browse/CB-11533
> Project: Apache Cordova
>  Issue Type: Wish
>  Components: Plugin SplashScreen
>Reporter: zhuisui
>
> LaunchImage is not necessary now, so please remove the code to generate 
> launch image with cordova icon if splash doesn't be set in config.xml.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11533) Launch images won't be needed on iOS.

[jcesarmobile (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361825#comment-15361825
 ] 

jcesarmobile commented on CB-11533:
---

Can you provide some information about launch images not being required now?


> Launch images won't be needed on iOS.
> -
>
> Key: CB-11533
> URL: https://issues.apache.org/jira/browse/CB-11533
> Project: Apache Cordova
>  Issue Type: Wish
>  Components: Plugin SplashScreen
>Reporter: zhuisui
>
> LaunchImage is not necessary now, so please remove the code to generate 
> launch image with cordova icon if splash doesn't be set in config.xml.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Closed] (CB-7176) Statusbar plugin methods not working in inapp browser

[jcesarmobile (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-7176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jcesarmobile closed CB-7176.

Resolution: Not A Problem
  Assignee: jcesarmobile

InAppBrowser shouldn't be able to run plugins code.

> Statusbar plugin methods not working in inapp browser
> -
>
> Key: CB-7176
> URL: https://issues.apache.org/jira/browse/CB-7176
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser, Plugin Statusbar
>Affects Versions: 3.4.0
> Environment: jQuery Mobile, iOS platform using xCode 5
>Reporter: Mitresh Joshi
>Assignee: jcesarmobile
>Priority: Minor
>  Labels: Triaged, easyfix, features
> Fix For: 3.4.0
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> All the methods of status bar plugin are working except 
> StatusBarOverlaysWebView & StatusBarBackgroundColor in inappbrowser.
> I do not want the overlay but just cant get it right. Wondering other methods 
> of status bar is working but not the above mentioned 2 methods.
> Any particular thing that i am missing here? I had doubts if statusbar plugin 
> works in inappbrowser but as mentioned other methods are working except these 
> two.
> i am able to use these methods & change color & overlay property in native 
> pages on the app but as soon i as open the inappbrowser these 2 methods do 
> not work.
> Also what i noticed is both these methods need some value in () like 
> true/false or colorname, whereas other methods dont need any value.
> Is there any property which i need to set, for the 2 two methods to work in 
> inappbrowser on web?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Closed] (CB-11191) Statusbar plugin causing issues with webview size

[jcesarmobile (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jcesarmobile closed CB-11191.
-
Resolution: Duplicate

It's a duplicate of CB-11287

Should be fixed in version 2.1.4-dev of cordova-plugin-statusbar (install from 
github url)

> Statusbar plugin causing issues with webview size
> -
>
> Key: CB-11191
> URL: https://issues.apache.org/jira/browse/CB-11191
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Statusbar
>Affects Versions: 2.1.0
> Environment: Cordova CLI Version: 6.1.1
> Cordova iOS Engine: 4.1.1
> Build environment: OSX El Capitan & XCode 7.3
> Device experiencing problem: iPod Touch running iOS 9.3.1
>Reporter: Dave Philipson
>Assignee: Sergey Shakhnazarov
>  Labels: ios, triaged
>
> It appears the statusbar plugin is causing issues with the iOS webview on 
> small form factor devices (iPhone & iPod) when switching orientation whilst 
> the camera is open (camera opened using cordova camera plugin)
> Steps to reproduce:
> Start the application and begin using it in landscape
> Open the camera using the cordova camera plugin
> Whilst the camera is open, rotate into portrait
> Close the camera
> Webview is now squashed down the left of the screen (only fills about 1/4 of 
> the screens overall width)
> Can recover by changing orientation again.
> Sample test app on Github:
> https://github.com/ISeeBinary/statusbar_plugin_testapp
> (tapping on the red square at the top of the test app page should launch the 
> camera)
> Removing the statusbar plugin rectifies the issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Comment Edited] (CB-11059) Status bar overlay isn't wide enough

[jcesarmobile (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361809#comment-15361809
 ] 

jcesarmobile edited comment on CB-11059 at 7/4/16 10:45 PM:


can you try with inAppBrowser 1.4.0?

I think I already fixed this on the other issue you reported (CB-10305), I 
think that was on 1.3.0 of the plugin.

 


was (Author: jcesarmobile):
can you try with inAppBrowser 1.4.0?

I think I already fixed this on another issue you reported. 

> Status bar overlay isn't wide enough
> 
>
> Key: CB-11059
> URL: https://issues.apache.org/jira/browse/CB-11059
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
> Environment: cordova-ios 4.1.0
>Reporter: Jacob Weber
>Assignee: jcesarmobile
>  Labels: triaged
> Attachments: screen1.png, screen2.png
>
>
> Launch an app in portrait, open an in-app-browser, and rotate to landscape. 
> The gray bar behind the status bar doesn't extend to the full width of the 
> device (see screen shots).
> This looks similar to an issue I reported in CB-10305.
> Tested on iPhone 6 simulator with iOS 9.3 and iPad Air simulator with iOS 8.4.
> Example config.xml:
> {code}
> 
> 
> 
> 
> 
> 
> 
> 
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Assigned] (CB-11059) Status bar overlay isn't wide enough

[jcesarmobile (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jcesarmobile reassigned CB-11059:
-

Assignee: jcesarmobile

> Status bar overlay isn't wide enough
> 
>
> Key: CB-11059
> URL: https://issues.apache.org/jira/browse/CB-11059
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
> Environment: cordova-ios 4.1.0
>Reporter: Jacob Weber
>Assignee: jcesarmobile
>  Labels: triaged
> Attachments: screen1.png, screen2.png
>
>
> Launch an app in portrait, open an in-app-browser, and rotate to landscape. 
> The gray bar behind the status bar doesn't extend to the full width of the 
> device (see screen shots).
> This looks similar to an issue I reported in CB-10305.
> Tested on iPhone 6 simulator with iOS 9.3 and iPad Air simulator with iOS 8.4.
> Example config.xml:
> {code}
> 
> 
> 
> 
> 
> 
> 
> 
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11059) Status bar overlay isn't wide enough

[jcesarmobile (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361809#comment-15361809
 ] 

jcesarmobile commented on CB-11059:
---

can you try with inAppBrowser 1.4.0?

I think I already fixed this on another issue you reported. 

> Status bar overlay isn't wide enough
> 
>
> Key: CB-11059
> URL: https://issues.apache.org/jira/browse/CB-11059
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
> Environment: cordova-ios 4.1.0
>Reporter: Jacob Weber
>  Labels: triaged
> Attachments: screen1.png, screen2.png
>
>
> Launch an app in portrait, open an in-app-browser, and rotate to landscape. 
> The gray bar behind the status bar doesn't extend to the full width of the 
> device (see screen shots).
> This looks similar to an issue I reported in CB-10305.
> Tested on iPhone 6 simulator with iOS 9.3 and iPad Air simulator with iOS 8.4.
> Example config.xml:
> {code}
> 
> 
> 
> 
> 
> 
> 
> 
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11059) Status bar overlay isn't wide enough

[jcesarmobile (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jcesarmobile updated CB-11059:
--
Component/s: (was: Plugin Statusbar)
 Plugin InAppBrowser

> Status bar overlay isn't wide enough
> 
>
> Key: CB-11059
> URL: https://issues.apache.org/jira/browse/CB-11059
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
> Environment: cordova-ios 4.1.0
>Reporter: Jacob Weber
>  Labels: triaged
> Attachments: screen1.png, screen2.png
>
>
> Launch an app in portrait, open an in-app-browser, and rotate to landscape. 
> The gray bar behind the status bar doesn't extend to the full width of the 
> device (see screen shots).
> This looks similar to an issue I reported in CB-10305.
> Tested on iPhone 6 simulator with iOS 9.3 and iPad Air simulator with iOS 8.4.
> Example config.xml:
> {code}
> 
> 
> 
> 
> 
> 
> 
> 
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11059) Status bar overlay isn't wide enough

[jcesarmobile (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jcesarmobile updated CB-11059:
--
Environment: 
cordova-ios 4.1.0


  was:
cordova-ios 4.1.0
cordova-plugin-statusbar 2.1.2 (couldn't select this in JIRA's Version field)


> Status bar overlay isn't wide enough
> 
>
> Key: CB-11059
> URL: https://issues.apache.org/jira/browse/CB-11059
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Statusbar
> Environment: cordova-ios 4.1.0
>Reporter: Jacob Weber
>  Labels: triaged
> Attachments: screen1.png, screen2.png
>
>
> Launch an app in portrait, open an in-app-browser, and rotate to landscape. 
> The gray bar behind the status bar doesn't extend to the full width of the 
> device (see screen shots).
> This looks similar to an issue I reported in CB-10305.
> Tested on iPhone 6 simulator with iOS 9.3 and iPad Air simulator with iOS 8.4.
> Example config.xml:
> {code}
> 
> 
> 
> 
> 
> 
> 
> 
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Closed] (CB-11125) camera breaks UI when orientation changes from landscape to portrait on iOS

[jcesarmobile (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jcesarmobile closed CB-11125.
-
Resolution: Duplicate

It's a duplicate of CB-11287

It has been fixed in 2.1.4-dev of statusbar plugin

> camera breaks UI when orientation changes from landscape to portrait on iOS
> ---
>
> Key: CB-11125
> URL: https://issues.apache.org/jira/browse/CB-11125
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Camera, Plugin Statusbar
>Affects Versions: 4.1.1
> Environment: Mac OS 10.11.4, iOS 9.3.1, iPhone 6
>Reporter: Jacob Weber
>Assignee: jcesarmobile
>
> CB-10884 also affects the camera plugin. Rotate the device to landscape and 
> launch the camera. Rotate to portrait while the camera window is open, then 
> close the camera window. The viewport doesn't adjust to fill the screen.
> config.xml:
> {code}
> 
> 
> 
> 
> 
> 
> {code}
> Code to launch camera:
> {code}
> navigator.camera.getPicture(function(){}, function(){}, {
> sourceType: Camera.PictureSourceType.CAMERA,
> destinationType: Camera.DestinationType.FILE_URI
> });
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Comment Edited] (CB-11287) iOS: landscape iPhone app: webview orientation turns to portrait after camera displayed

[jcesarmobile (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361804#comment-15361804
 ] 

jcesarmobile edited comment on CB-11287 at 7/4/16 10:25 PM:


Fixed in 2.1.4-dev of statusbar plugin


was (Author: jcesarmobile):
Fixed in 2.1.4-dev

> iOS: landscape iPhone app: webview orientation turns to portrait after camera 
> displayed
> ---
>
> Key: CB-11287
> URL: https://issues.apache.org/jira/browse/CB-11287
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Statusbar
>Affects Versions: 2.2.0
> Environment: cordova 6.1.1
> ios 4.1.1
> cordova-plugin-camera 2.2.0 "Camera"
>Reporter: Michael Schmidt
>Assignee: jcesarmobile
>  Labels: iOS
>
> *situation*
> * app in landscape mode
> {code:JavaScript}
>   
> {code}
> * camera options
> {code:JavaScript}
> {
>  destinationType: Camera.DestinationType.FILE_URI,
>  sourceType: Camera.PictureSourceType.CAMERA,
>  encodingType: Camera.EncodingType.JPEG,
>  mediaType: Camera.MediaType.PICTURE,
> };
> {code}
> *problem*
> After displaying the camera, the app viewport turns to portrait mode - 
> despite that the whole app is set to landscape.
> This takes place for either taking a picture or pressing cancel.
> This bug occurs only on iPhone, it works on iPad though.
> *appearance*
> the bug (viewport turns portrait) appears in all combinations of 
> - holding phone in portrait/landscape
> - setting correctOrientation to true/false
> - using Camera.PictureSourceType.PHOTOLIBRARY/Camera.PictureSourceType.CAMERA
> *possibly related*
> this error occurs after closing the camera picker:
> {code}
> 2016-06-04 16:38:37.527 CordovaApp[2217:1174793] Warning: Attempt to present 
>  on  whose 
> view is not in the window hierarchy!
> {code}
> *regression from camera 1.2.0*
> This is a regression - it works reproducably in the following configuration:
> {code}
> cordova 5.3.3
> cordova-ios 3.9.1
> cordova-plugin-camera 1.2.0
> {code}
> it slowly degraded: with cordova-plugin-camera 2.0.0 it showed wrong - but 
> still still could changed by rotating the phone back and forth. With 
> cordova-plugin-camera 2.0.0 the actual phone orientation makes a difference 
> when correctOrientation is set to true - it seems that the bug occurs only 
> when the phone is held in portrait during the camera open
> -> seems to be related to correctOrientation



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Resolved] (CB-11287) iOS: landscape iPhone app: webview orientation turns to portrait after camera displayed

[jcesarmobile (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jcesarmobile resolved CB-11287.
---
Resolution: Fixed

Fixed in 2.1.4-dev

> iOS: landscape iPhone app: webview orientation turns to portrait after camera 
> displayed
> ---
>
> Key: CB-11287
> URL: https://issues.apache.org/jira/browse/CB-11287
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Statusbar
>Affects Versions: 2.2.0
> Environment: cordova 6.1.1
> ios 4.1.1
> cordova-plugin-camera 2.2.0 "Camera"
>Reporter: Michael Schmidt
>Assignee: jcesarmobile
>  Labels: iOS
>
> *situation*
> * app in landscape mode
> {code:JavaScript}
>   
> {code}
> * camera options
> {code:JavaScript}
> {
>  destinationType: Camera.DestinationType.FILE_URI,
>  sourceType: Camera.PictureSourceType.CAMERA,
>  encodingType: Camera.EncodingType.JPEG,
>  mediaType: Camera.MediaType.PICTURE,
> };
> {code}
> *problem*
> After displaying the camera, the app viewport turns to portrait mode - 
> despite that the whole app is set to landscape.
> This takes place for either taking a picture or pressing cancel.
> This bug occurs only on iPhone, it works on iPad though.
> *appearance*
> the bug (viewport turns portrait) appears in all combinations of 
> - holding phone in portrait/landscape
> - setting correctOrientation to true/false
> - using Camera.PictureSourceType.PHOTOLIBRARY/Camera.PictureSourceType.CAMERA
> *possibly related*
> this error occurs after closing the camera picker:
> {code}
> 2016-06-04 16:38:37.527 CordovaApp[2217:1174793] Warning: Attempt to present 
>  on  whose 
> view is not in the window hierarchy!
> {code}
> *regression from camera 1.2.0*
> This is a regression - it works reproducably in the following configuration:
> {code}
> cordova 5.3.3
> cordova-ios 3.9.1
> cordova-plugin-camera 1.2.0
> {code}
> it slowly degraded: with cordova-plugin-camera 2.0.0 it showed wrong - but 
> still still could changed by rotating the phone back and forth. With 
> cordova-plugin-camera 2.0.0 the actual phone orientation makes a difference 
> when correctOrientation is set to true - it seems that the bug occurs only 
> when the phone is held in portrait during the camera open
> -> seems to be related to correctOrientation



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11287) iOS: landscape iPhone app: webview orientation turns to portrait after camera displayed

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361802#comment-15361802
 ] 

ASF subversion and git services commented on CB-11287:
--

Commit 86cfafeaf9796c45c855fc55c3605aadb713af62 in cordova-plugin-statusbar's 
branch refs/heads/master from [~jcesarmobile]
[ 
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-statusbar.git;h=86cfafe
 ]

CB-11287: (ios) - fix webview resize after modal on iPhones


> iOS: landscape iPhone app: webview orientation turns to portrait after camera 
> displayed
> ---
>
> Key: CB-11287
> URL: https://issues.apache.org/jira/browse/CB-11287
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Statusbar
>Affects Versions: 2.2.0
> Environment: cordova 6.1.1
> ios 4.1.1
> cordova-plugin-camera 2.2.0 "Camera"
>Reporter: Michael Schmidt
>Assignee: jcesarmobile
>  Labels: iOS
>
> *situation*
> * app in landscape mode
> {code:JavaScript}
>   
> {code}
> * camera options
> {code:JavaScript}
> {
>  destinationType: Camera.DestinationType.FILE_URI,
>  sourceType: Camera.PictureSourceType.CAMERA,
>  encodingType: Camera.EncodingType.JPEG,
>  mediaType: Camera.MediaType.PICTURE,
> };
> {code}
> *problem*
> After displaying the camera, the app viewport turns to portrait mode - 
> despite that the whole app is set to landscape.
> This takes place for either taking a picture or pressing cancel.
> This bug occurs only on iPhone, it works on iPad though.
> *appearance*
> the bug (viewport turns portrait) appears in all combinations of 
> - holding phone in portrait/landscape
> - setting correctOrientation to true/false
> - using Camera.PictureSourceType.PHOTOLIBRARY/Camera.PictureSourceType.CAMERA
> *possibly related*
> this error occurs after closing the camera picker:
> {code}
> 2016-06-04 16:38:37.527 CordovaApp[2217:1174793] Warning: Attempt to present 
>  on  whose 
> view is not in the window hierarchy!
> {code}
> *regression from camera 1.2.0*
> This is a regression - it works reproducably in the following configuration:
> {code}
> cordova 5.3.3
> cordova-ios 3.9.1
> cordova-plugin-camera 1.2.0
> {code}
> it slowly degraded: with cordova-plugin-camera 2.0.0 it showed wrong - but 
> still still could changed by rotating the phone back and forth. With 
> cordova-plugin-camera 2.0.0 the actual phone orientation makes a difference 
> when correctOrientation is set to true - it seems that the bug occurs only 
> when the phone is held in portrait during the camera open
> -> seems to be related to correctOrientation



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11287) iOS: landscape iPhone app: webview orientation turns to portrait after camera displayed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361803#comment-15361803
 ] 

ASF GitHub Bot commented on CB-11287:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-statusbar/pull/61


> iOS: landscape iPhone app: webview orientation turns to portrait after camera 
> displayed
> ---
>
> Key: CB-11287
> URL: https://issues.apache.org/jira/browse/CB-11287
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Statusbar
>Affects Versions: 2.2.0
> Environment: cordova 6.1.1
> ios 4.1.1
> cordova-plugin-camera 2.2.0 "Camera"
>Reporter: Michael Schmidt
>Assignee: jcesarmobile
>  Labels: iOS
>
> *situation*
> * app in landscape mode
> {code:JavaScript}
>   
> {code}
> * camera options
> {code:JavaScript}
> {
>  destinationType: Camera.DestinationType.FILE_URI,
>  sourceType: Camera.PictureSourceType.CAMERA,
>  encodingType: Camera.EncodingType.JPEG,
>  mediaType: Camera.MediaType.PICTURE,
> };
> {code}
> *problem*
> After displaying the camera, the app viewport turns to portrait mode - 
> despite that the whole app is set to landscape.
> This takes place for either taking a picture or pressing cancel.
> This bug occurs only on iPhone, it works on iPad though.
> *appearance*
> the bug (viewport turns portrait) appears in all combinations of 
> - holding phone in portrait/landscape
> - setting correctOrientation to true/false
> - using Camera.PictureSourceType.PHOTOLIBRARY/Camera.PictureSourceType.CAMERA
> *possibly related*
> this error occurs after closing the camera picker:
> {code}
> 2016-06-04 16:38:37.527 CordovaApp[2217:1174793] Warning: Attempt to present 
>  on  whose 
> view is not in the window hierarchy!
> {code}
> *regression from camera 1.2.0*
> This is a regression - it works reproducably in the following configuration:
> {code}
> cordova 5.3.3
> cordova-ios 3.9.1
> cordova-plugin-camera 1.2.0
> {code}
> it slowly degraded: with cordova-plugin-camera 2.0.0 it showed wrong - but 
> still still could changed by rotating the phone back and forth. With 
> cordova-plugin-camera 2.0.0 the actual phone orientation makes a difference 
> when correctOrientation is set to true - it seems that the bug occurs only 
> when the phone is held in portrait during the camera open
> -> seems to be related to correctOrientation



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11287) iOS: landscape iPhone app: webview orientation turns to portrait after camera displayed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361799#comment-15361799
 ] 

ASF GitHub Bot commented on CB-11287:
-

GitHub user jcesarmobile opened a pull request:

https://github.com/apache/cordova-plugin-statusbar/pull/61

CB-11287: (ios) - fix webview resize after modal on iPhones


### Platforms affected
iOS

### What does this PR do?
Fixes CB-11287

### What testing has been done on this change?
Tested on iPhones, presenting a modal (camera picker) on landscape mode and 
dismissing it.

### Checklist
- [X] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and 
submitted to secret...@apache.org.
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jcesarmobile/cordova-plugin-statusbar 
CB-11287-ios-statusbar

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-statusbar/pull/61.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #61


commit 86cfafeaf9796c45c855fc55c3605aadb713af62
Author: Julio César 
Date:   2016-07-04T22:12:20Z

CB-11287: (ios) - fix webview resize after modal on iPhones




> iOS: landscape iPhone app: webview orientation turns to portrait after camera 
> displayed
> ---
>
> Key: CB-11287
> URL: https://issues.apache.org/jira/browse/CB-11287
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Statusbar
>Affects Versions: 2.2.0
> Environment: cordova 6.1.1
> ios 4.1.1
> cordova-plugin-camera 2.2.0 "Camera"
>Reporter: Michael Schmidt
>Assignee: jcesarmobile
>  Labels: iOS
>
> *situation*
> * app in landscape mode
> {code:JavaScript}
>   
> {code}
> * camera options
> {code:JavaScript}
> {
>  destinationType: Camera.DestinationType.FILE_URI,
>  sourceType: Camera.PictureSourceType.CAMERA,
>  encodingType: Camera.EncodingType.JPEG,
>  mediaType: Camera.MediaType.PICTURE,
> };
> {code}
> *problem*
> After displaying the camera, the app viewport turns to portrait mode - 
> despite that the whole app is set to landscape.
> This takes place for either taking a picture or pressing cancel.
> This bug occurs only on iPhone, it works on iPad though.
> *appearance*
> the bug (viewport turns portrait) appears in all combinations of 
> - holding phone in portrait/landscape
> - setting correctOrientation to true/false
> - using Camera.PictureSourceType.PHOTOLIBRARY/Camera.PictureSourceType.CAMERA
> *possibly related*
> this error occurs after closing the camera picker:
> {code}
> 2016-06-04 16:38:37.527 CordovaApp[2217:1174793] Warning: Attempt to present 
>  on  whose 
> view is not in the window hierarchy!
> {code}
> *regression from camera 1.2.0*
> This is a regression - it works reproducably in the following configuration:
> {code}
> cordova 5.3.3
> cordova-ios 3.9.1
> cordova-plugin-camera 1.2.0
> {code}
> it slowly degraded: with cordova-plugin-camera 2.0.0 it showed wrong - but 
> still still could changed by rotating the phone back and forth. With 
> cordova-plugin-camera 2.0.0 the actual phone orientation makes a difference 
> when correctOrientation is set to true - it seems that the bug occurs only 
> when the phone is held in portrait during the camera open
> -> seems to be related to correctOrientation



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10653) Universal Windows Platform -- activationContext is incomplete

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361756#comment-15361756
 ] 

ASF GitHub Bot commented on CB-10653:
-

Github user daserge commented on the issue:

https://github.com/apache/cordova-windows/pull/173
  
@rakatyal, you also noted that it was happening for some other activation 
kinds - could you please share which ones I should also test?
What do you think on a solution to have the raw args.details AND the cloned 
object so that a developer could make a call to the clone if some property is 
missing. This could help with types loss as reported 
[here](https://github.com/apache/cordova-windows/pull/173#issuecomment-227366714).


> Universal Windows Platform -- activationContext is incomplete
> -
>
> Key: CB-10653
> URL: https://issues.apache.org/jira/browse/CB-10653
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Windows
> Environment: Windows 10, Windows 10 Phone
>Reporter: Adam Fourney
>Assignee: Raghav Katyal
>Priority: Minor
>  Labels: easyfix
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> CB-8674 modified cordova-js-src/platform.js to capture the application's 
> onactivated event, and record the details in the platform.activationContext 
> instance. 
> Unfortunately, CB-8674 covers only a few of the 12 types of UWP activation 
> events. As an example, if an app is activated by a Cortana voice command, the 
> details are missed. See here for more details: 
> https://msdn.microsoft.com/en-us/library/windows/apps/br212679.aspx
> The proposed fix is to change:
> var activationHandler = function (e) {
>var args = e.detail.arguments;
>var actType = e.detail.type;
>platform.activationContext = { type: actType, args: args };
>cordova.fireDocumentEvent('activated', platform.activationContext, 
> true);
> };
> To be: 
> var activationHandler = function (e) {
> platform.activationContext = utils.clone(e.detail);
> platform.activationContext.args = e.detail.arguments; // 
> Backwards compatibility
> cordova.fireDocumentEvent('activated', 
> platform.activationContext, true);
> };
> This also means that platform.js should require("cordova/utils")



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Resolved] (CB-11485) Web view doesn't resize when switching from portrait mode to landscape

[jcesarmobile (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jcesarmobile resolved CB-11485.
---
Resolution: Fixed

Fixed in 2.1.4-dev

> Web view doesn't resize when switching from portrait mode to landscape 
> ---
>
> Key: CB-11485
> URL: https://issues.apache.org/jira/browse/CB-11485
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Statusbar
>Affects Versions: Master
> Environment: iOS 9.3, iPad
>Reporter: Yazeed Fares
>Assignee: jcesarmobile
>
> Web view doesn't resize when switching from portrait mode to landscape, the 
> issue happens when you have a popover opened in a select field or when you 
> open the camera picker.
> Screen shot ==> https://i.imgsafe.org/fa3905cbe2.png



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10653) Universal Windows Platform -- activationContext is incomplete

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361753#comment-15361753
 ] 

ASF GitHub Bot commented on CB-10653:
-

Github user daserge commented on the issue:

https://github.com/apache/cordova-windows/pull/173
  
@rakatyal, @afourney, do you happen to have some examples with details 
disappearing?
I tried and it did not reproduce for me on Windows Phone 8.1 project 
running on Windows 10 Mobile.
Which OS and project types was it reproducing on for you BTW?


> Universal Windows Platform -- activationContext is incomplete
> -
>
> Key: CB-10653
> URL: https://issues.apache.org/jira/browse/CB-10653
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Windows
> Environment: Windows 10, Windows 10 Phone
>Reporter: Adam Fourney
>Assignee: Raghav Katyal
>Priority: Minor
>  Labels: easyfix
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> CB-8674 modified cordova-js-src/platform.js to capture the application's 
> onactivated event, and record the details in the platform.activationContext 
> instance. 
> Unfortunately, CB-8674 covers only a few of the 12 types of UWP activation 
> events. As an example, if an app is activated by a Cortana voice command, the 
> details are missed. See here for more details: 
> https://msdn.microsoft.com/en-us/library/windows/apps/br212679.aspx
> The proposed fix is to change:
> var activationHandler = function (e) {
>var args = e.detail.arguments;
>var actType = e.detail.type;
>platform.activationContext = { type: actType, args: args };
>cordova.fireDocumentEvent('activated', platform.activationContext, 
> true);
> };
> To be: 
> var activationHandler = function (e) {
> platform.activationContext = utils.clone(e.detail);
> platform.activationContext.args = e.detail.arguments; // 
> Backwards compatibility
> cordova.fireDocumentEvent('activated', 
> platform.activationContext, true);
> };
> This also means that platform.js should require("cordova/utils")



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11485) Web view doesn't resize when switching from portrait mode to landscape

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361750#comment-15361750
 ] 

ASF GitHub Bot commented on CB-11485:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-statusbar/pull/60


> Web view doesn't resize when switching from portrait mode to landscape 
> ---
>
> Key: CB-11485
> URL: https://issues.apache.org/jira/browse/CB-11485
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Statusbar
>Affects Versions: Master
> Environment: iOS 9.3, iPad
>Reporter: Yazeed Fares
>Assignee: jcesarmobile
>
> Web view doesn't resize when switching from portrait mode to landscape, the 
> issue happens when you have a popover opened in a select field or when you 
> open the camera picker.
> Screen shot ==> https://i.imgsafe.org/fa3905cbe2.png



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11485) Web view doesn't resize when switching from portrait mode to landscape

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361749#comment-15361749
 ] 

ASF subversion and git services commented on CB-11485:
--

Commit 8159e1b307f69629efd75940458e73ebab90f5f8 in cordova-plugin-statusbar's 
branch refs/heads/master from [~jcesarmobile]
[ 
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-statusbar.git;h=8159e1b
 ]

CB-11485 fix resize on rotation with popover


> Web view doesn't resize when switching from portrait mode to landscape 
> ---
>
> Key: CB-11485
> URL: https://issues.apache.org/jira/browse/CB-11485
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Statusbar
>Affects Versions: Master
> Environment: iOS 9.3, iPad
>Reporter: Yazeed Fares
>Assignee: jcesarmobile
>
> Web view doesn't resize when switching from portrait mode to landscape, the 
> issue happens when you have a popover opened in a select field or when you 
> open the camera picker.
> Screen shot ==> https://i.imgsafe.org/fa3905cbe2.png



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11485) Web view doesn't resize when switching from portrait mode to landscape

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361746#comment-15361746
 ] 

ASF GitHub Bot commented on CB-11485:
-

GitHub user jcesarmobile opened a pull request:

https://github.com/apache/cordova-plugin-statusbar/pull/60

CB-11485: (ios) fix resize on rotation with popover

This PR fix the webview resize problem when a popover is present

### Platforms affected
iOS

### What does this PR do?
Fixes CB-11485 

### What testing has been done on this change?
Tested on iOS 7, 8 and 9 iPads when a popover is present

### Checklist
- [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and 
submitted to secret...@apache.org.
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [] Added automated test coverage as appropriate for this change.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jcesarmobile/cordova-plugin-statusbar 
CB-11485-ios-statusbar

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-statusbar/pull/60.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #60


commit 8159e1b307f69629efd75940458e73ebab90f5f8
Author: Julio César 
Date:   2016-07-04T19:20:33Z

CB-11485 fix resize on rotation with popover




> Web view doesn't resize when switching from portrait mode to landscape 
> ---
>
> Key: CB-11485
> URL: https://issues.apache.org/jira/browse/CB-11485
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Statusbar
>Affects Versions: Master
> Environment: iOS 9.3, iPad
>Reporter: Yazeed Fares
>Assignee: jcesarmobile
>
> Web view doesn't resize when switching from portrait mode to landscape, the 
> issue happens when you have a popover opened in a select field or when you 
> open the camera picker.
> Screen shot ==> https://i.imgsafe.org/fa3905cbe2.png



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11534) Cordova file-transfer-plugin should support Android Marshmallow runtime permission

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361707#comment-15361707
 ] 

ASF GitHub Bot commented on CB-11534:
-

GitHub user homen opened a pull request:

https://github.com/apache/cordova-plugin-file-transfer/pull/150

CB-11534 This plugin should support Android Marshmallow runtime permission



### Platforms affected
Android

### What does this PR do?
It will support Android Marshmallow runtime permission.

### What testing has been done on this change?
Tested in Android.

### Checklist
- [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and 
submitted to secret...@apache.org.
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/homen/cordova-plugin-file-transfer master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file-transfer/pull/150.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #150


commit 153efabe173f825a72dbbd13ce476cdd3bdd841b
Author: homen 
Date:   2016-07-02T13:07:52Z

Android 6 runtime permission

commit a03dc62dd2ebd79b81b81cd18f1359a01aa92478
Author: homen 
Date:   2016-07-02T14:03:11Z

Revert "Android 6 runtime permission"

This reverts commit 153efabe173f825a72dbbd13ce476cdd3bdd841b.

commit de8e3d3f7edf575b81e93e78ca5ff56cea0ef0d3
Author: homen 
Date:   2016-07-04T19:06:17Z

CB-11534 Cordova file-transfer-plugin should support Android Marshmallow 
runtime permission

commit a1dc3f3cb00c91a43dcb83d8759d6b3ed9965298
Author: homen 
Date:   2016-07-04T19:13:52Z

Revert "CB-11534 Cordova file-transfer-plugin should support Android 
Marshmallow runtime permission"

This reverts commit de8e3d3f7edf575b81e93e78ca5ff56cea0ef0d3.

commit 1e0d0e02667c1a5e8f7eb20520d737a3947fa9d3
Author: homen 
Date:   2016-07-04T19:15:24Z

CB-11534:(android) Cordova file-transfer-plugin should support Android 
Marshmallow runtime permission




> Cordova file-transfer-plugin should support Android Marshmallow runtime 
> permission
> --
>
> Key: CB-11534
> URL: https://issues.apache.org/jira/browse/CB-11534
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: Android
> Environment: Android Marshmallow,Android target platform 23.
>Reporter: Homen Borgohain
>  Labels: android6.0, permission
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> In Android Marshmallow file-transfer-plugin should show a pop up if storage 
> permission is not granted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11534) Cordova file-transfer-plugin should support Android Marshmallow runtime permission

[Homen Borgohain (JIRA)]

Homen Borgohain created CB-11534:


 Summary: Cordova file-transfer-plugin should support Android 
Marshmallow runtime permission
 Key: CB-11534
 URL: https://issues.apache.org/jira/browse/CB-11534
 Project: Apache Cordova
  Issue Type: New Feature
  Components: Android
 Environment: Android Marshmallow,Android target platform 23.
Reporter: Homen Borgohain


In Android Marshmallow file-transfer-plugin should show a pop up if storage 
permission is not granted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Closed] (CB-11516) Preparing fails on icons with a target

[Vladimir Kotikov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-11516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov closed CB-11516.
-
Resolution: Fixed

> Preparing fails on icons with a target
> --
>
> Key: CB-11516
> URL: https://issues.apache.org/jira/browse/CB-11516
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Affects Versions: 4.4.0
>Reporter: Cody Hoover
>
> Putting the following line in the config will will cause an error: "Source 
> directory does not exist: Square44x44Logo_100.scale"
> 
> In prepare.js, `copyImages` calls `mapImageResources` but subdirectory 
> information was lost. `copyMrtImage` in an earlier commit preserved this 
> information (shown in the link below), but it was lost in a refactoring.
> https://github.com/apache/cordova-windows/blob/c1b80be51cdbd90160b6cb8162350bced8e1c44b/template/cordova/lib/prepare.js#L316
> This was missed by a defect in the `copyIcons` test in Prepare.Win10.spec.js:
> `readdirSync` was spied on to return an array of file paths when it actually 
> only returns an array of the filenames. This caused the `copyIcons` spec to 
> pass but the code failed when used.
> I have a fix ready for github.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11516) Preparing fails on icons with a target

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361562#comment-15361562
 ] 

ASF subversion and git services commented on CB-11516:
--

Commit b0502ae450c61e8bcb99969a174d062ef751f081 in cordova-windows's branch 
refs/heads/master from [~hoovercj]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=b0502ae ]

CB-11516 windows: Preparing icons w/ target fails

This closes #179


> Preparing fails on icons with a target
> --
>
> Key: CB-11516
> URL: https://issues.apache.org/jira/browse/CB-11516
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Affects Versions: 4.4.0
>Reporter: Cody Hoover
>
> Putting the following line in the config will will cause an error: "Source 
> directory does not exist: Square44x44Logo_100.scale"
> 
> In prepare.js, `copyImages` calls `mapImageResources` but subdirectory 
> information was lost. `copyMrtImage` in an earlier commit preserved this 
> information (shown in the link below), but it was lost in a refactoring.
> https://github.com/apache/cordova-windows/blob/c1b80be51cdbd90160b6cb8162350bced8e1c44b/template/cordova/lib/prepare.js#L316
> This was missed by a defect in the `copyIcons` test in Prepare.Win10.spec.js:
> `readdirSync` was spied on to return an array of file paths when it actually 
> only returns an array of the filenames. This caused the `copyIcons` spec to 
> pass but the code failed when used.
> I have a fix ready for github.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11516) Preparing fails on icons with a target

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361561#comment-15361561
 ] 

ASF GitHub Bot commented on CB-11516:
-

Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-windows/pull/179
  
LGTM


> Preparing fails on icons with a target
> --
>
> Key: CB-11516
> URL: https://issues.apache.org/jira/browse/CB-11516
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Affects Versions: 4.4.0
>Reporter: Cody Hoover
>
> Putting the following line in the config will will cause an error: "Source 
> directory does not exist: Square44x44Logo_100.scale"
> 
> In prepare.js, `copyImages` calls `mapImageResources` but subdirectory 
> information was lost. `copyMrtImage` in an earlier commit preserved this 
> information (shown in the link below), but it was lost in a refactoring.
> https://github.com/apache/cordova-windows/blob/c1b80be51cdbd90160b6cb8162350bced8e1c44b/template/cordova/lib/prepare.js#L316
> This was missed by a defect in the `copyIcons` test in Prepare.Win10.spec.js:
> `readdirSync` was spied on to return an array of file paths when it actually 
> only returns an array of the filenames. This caused the `copyIcons` spec to 
> pass but the code failed when used.
> I have a fix ready for github.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11516) Preparing fails on icons with a target

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361564#comment-15361564
 ] 

ASF GitHub Bot commented on CB-11516:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-windows/pull/179


> Preparing fails on icons with a target
> --
>
> Key: CB-11516
> URL: https://issues.apache.org/jira/browse/CB-11516
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Windows
>Affects Versions: 4.4.0
>Reporter: Cody Hoover
>
> Putting the following line in the config will will cause an error: "Source 
> directory does not exist: Square44x44Logo_100.scale"
> 
> In prepare.js, `copyImages` calls `mapImageResources` but subdirectory 
> information was lost. `copyMrtImage` in an earlier commit preserved this 
> information (shown in the link below), but it was lost in a refactoring.
> https://github.com/apache/cordova-windows/blob/c1b80be51cdbd90160b6cb8162350bced8e1c44b/template/cordova/lib/prepare.js#L316
> This was missed by a defect in the `copyIcons` test in Prepare.Win10.spec.js:
> `readdirSync` was spied on to return an array of file paths when it actually 
> only returns an array of the filenames. This caused the `copyIcons` spec to 
> pass but the code failed when used.
> I have a fix ready for github.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11491) Introduce before_deploy hook

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361130#comment-15361130
 ] 

ASF GitHub Bot commented on CB-11491:
-

Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-lib/pull/460
  
Some minor comments, LGTM otherwise


> Introduce before_deploy hook
> 
>
> Key: CB-11491
> URL: https://issues.apache.org/jira/browse/CB-11491
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CordovaLib
>Reporter: Sergey Shakhnazarov
>Assignee: Sergey Shakhnazarov
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11491) Introduce before_deploy hook

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361127#comment-15361127
 ] 

ASF GitHub Bot commented on CB-11491:
-

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/460#discussion_r69436760
  
--- Diff: cordova-lib/spec-cordova/run.spec.js ---
@@ -79,7 +82,7 @@ describe('run command', function() {
 it('should pass down parameters', function(done) {
 cordova.raw.run({platforms: ['blackberry10'], 
options:{password: '1q1q'}}).then(function() {
 expect(prepare_spy).toHaveBeenCalledWith({ platforms: [ 
'blackberry10' ], options: { password: '1q1q' }, verbose: false });
-expect(platformApi.run).toHaveBeenCalledWith({password: 
'1q1q'});
+expect(platformApi.run).toHaveBeenCalledWith({password: 
'1q1q', nobuild: true});
--- End diff --

Same here


> Introduce before_deploy hook
> 
>
> Key: CB-11491
> URL: https://issues.apache.org/jira/browse/CB-11491
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CordovaLib
>Reporter: Sergey Shakhnazarov
>Assignee: Sergey Shakhnazarov
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11491) Introduce before_deploy hook

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361126#comment-15361126
 ] 

ASF GitHub Bot commented on CB-11491:
-

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/460#discussion_r69436735
  
--- Diff: cordova-lib/spec-cordova/emulate.spec.js ---
@@ -82,7 +85,7 @@ describe('emulate command', function() {
 cordova.raw.emulate({platforms: ['ios'], options: 
{optionTastic: true }}).then(function(err) {
 
expect(prepare_spy).toHaveBeenCalledWith(jasmine.objectContaining({platforms: 
['ios']}));
 expect(getPlatformApi).toHaveBeenCalledWith('ios');
-expect(platformApi.run).toHaveBeenCalledWith({ device: 
false, emulator: true, optionTastic: true });
+expect(platformApi.run).toHaveBeenCalledWith({ device: 
false, emulator: true, optionTastic: true, nobuild: true });
--- End diff --

@daserge, could you please add another expectation to check if `build` also 
had been called and changing the options in `build` does not affect `run` 
command?


> Introduce before_deploy hook
> 
>
> Key: CB-11491
> URL: https://issues.apache.org/jira/browse/CB-11491
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: CordovaLib
>Reporter: Sergey Shakhnazarov
>Assignee: Sergey Shakhnazarov
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11533) Launch images won't be needed on iOS.

[zhuisui (JIRA)]

zhuisui created CB-11533:


 Summary: Launch images won't be needed on iOS.
 Key: CB-11533
 URL: https://issues.apache.org/jira/browse/CB-11533
 Project: Apache Cordova
  Issue Type: Wish
  Components: Plugin SplashScreen
Reporter: zhuisui


LaunchImage is not necessary now, so please remove the code to generate launch 
image with cordova icon if splash doesn't be set in config.xml.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11532) Contacts EOF error on iOS

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-11532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361094#comment-15361094
 ] 

ASF GitHub Bot commented on CB-11532:
-

GitHub user philbenoit opened a pull request:

https://github.com/apache/cordova-plugin-contacts/pull/130

CB-11532: (ios) Fix bug with bad characters in contact name



### Platforms affected
iOS

### What does this PR do?
Fixes https://issues.apache.org/jira/browse/CB-11532

### What testing has been done on this change?
Testing on the problem device iOS 9.3 - iPhone 5s. 

### Checklist
- [ Yes ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed 
and submitted to secret...@apache.org.
- [ Yes ] [Reported an 
issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ Yes ] Commit message follows the format: "CB-3232: (android) Fix bug 
with resolving file paths", where CB- is the JIRA ID & "android" is the 
platform affected.
- [ No ] Added automated test coverage as appropriate for this change.

This update fixes the issue https://issues.apache.org/jira/browse/CB-11532
I am not an iOS dev so am sure the code can be improved as it seems a bit 
heavy to create new dictionaries for each user. 

Please also look to add code tests as I have no knowledge of this, the 
names causing issues are listed below.

I have tested this in the wild with a phone containing the contacts below 
and it has solved the issue. 

Gökmen
Brûlé
França
ادوارد
Gabby ••••
Damián M.A.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/philbenoit/cordova-plugin-contacts patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-contacts/pull/130.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #130


commit 430770c51fc4377db1f8ef3f4e251c6189fcd29f
Author: KiwiDC 
Date:   2016-07-04T09:33:49Z

Update CDVContacts.m

This update fixes the issue https://issues.apache.org/jira/browse/CB-11532
I am not an iOS dev so am sure the code can be improved as it seems a bit 
heavy to create new dictionaries for each user. 

I have tested this in the wild with a phone containing the contacts below 
and it has solved the issue. 

Gökmen
Brûlé
França
ادوارد
Gabby ••••
Damián M.A.




> Contacts EOF error on iOS
> -
>
> Key: CB-11532
> URL: https://issues.apache.org/jira/browse/CB-11532
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Contacts
>Affects Versions: 2.1.1
> Environment: Cordova CLI: 6.2.0
> Gulp version:  CLI version 3.9.0
> Gulp local:   Local version 3.9.1
> Ionic Framework Version: 2.0.0-beta.7
> Ionic CLI Version: 2.0.0-beta.32
> Ionic App Lib Version: 2.0.0-beta.18
> ios-deploy version: 1.8.5
> ios-sim version: 4.1.1
> OS: Mac OS X El Capitan
> Node Version: v4.1.1
> Xcode version: Xcode 7.3 Build version 7D175
>Reporter: Phil Benoit
>  Labels: contacts, ios
>
> When importing contacts from Google or Facebook the plugin crashes as it is 
> not able to handle the imported characters. 
> The error is - Syntax error: EOF reached
> Here is a list of real world contacts imported from Google that cause the 
> issue. 
> Gökmen
> Brûlé
> França
> ادوارد
> Gabby ••••
> Damián M.A.
> I have a fix for this that has been implemented in a live app. I will be 
> sending a pull request to the repo for review but wanted to log this incase 
> there were others coming across the same issue.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11532) Contacts EOF error on iOS

[Phil Benoit (JIRA)]

Phil Benoit created CB-11532:


 Summary: Contacts EOF error on iOS
 Key: CB-11532
 URL: https://issues.apache.org/jira/browse/CB-11532
 Project: Apache Cordova
  Issue Type: Bug
  Components: Plugin Contacts
Affects Versions: 2.1.1
 Environment: Cordova CLI: 6.2.0
Gulp version:  CLI version 3.9.0
Gulp local:   Local version 3.9.1
Ionic Framework Version: 2.0.0-beta.7
Ionic CLI Version: 2.0.0-beta.32
Ionic App Lib Version: 2.0.0-beta.18
ios-deploy version: 1.8.5
ios-sim version: 4.1.1
OS: Mac OS X El Capitan
Node Version: v4.1.1
Xcode version: Xcode 7.3 Build version 7D175
Reporter: Phil Benoit


When importing contacts from Google or Facebook the plugin crashes as it is not 
able to handle the imported characters. 

The error is - Syntax error: EOF reached

Here is a list of real world contacts imported from Google that cause the 
issue. 

Gökmen
Brûlé
França
ادوارد
Gabby ••••
Damián M.A.

I have a fix for this that has been implemented in a live app. I will be 
sending a pull request to the repo for review but wanted to log this incase 
there were others coming across the same issue.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Resolved] (CB-8150) Add a `--noprepare` flag to `cordova run`

[sandstrom (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

sandstrom resolved CB-8150.
---
   Resolution: Fixed
Fix Version/s: 6.2.0

https://issues.apache.org/jira/browse/CB-11042

> Add a `--noprepare` flag to `cordova run`
> -
>
> Key: CB-8150
> URL: https://issues.apache.org/jira/browse/CB-8150
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CLI
>Affects Versions: 4.0.0
>Reporter: sandstrom
>Priority: Minor
> Fix For: 6.2.0
>
>
> `cordova run` has the excellent `--nobuild` flag, which makes it possible to 
> skip building (when `cordova build` is called manually).
> Similarly, it would be neat if a `--noprepare` flag was available.
> This allows for more fine-grained control over `run`.
> In our case, we want to do adjustments to files after calling `cordova 
> prepare` (similar to the hooks, but we've implemented it a bit differently), 
> and this is impossible since `cordova run` will call `prepare`, undoing our 
> changes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-8150) Add a `--noprepare` flag to `cordova run`

[sandstrom (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360977#comment-15360977
 ] 

sandstrom commented on CB-8150:
---

This has been added to Cordova 6.2

https://issues.apache.org/jira/browse/CB-11042

> Add a `--noprepare` flag to `cordova run`
> -
>
> Key: CB-8150
> URL: https://issues.apache.org/jira/browse/CB-8150
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CLI
>Affects Versions: 4.0.0
>Reporter: sandstrom
>Priority: Minor
>
> `cordova run` has the excellent `--nobuild` flag, which makes it possible to 
> skip building (when `cordova build` is called manually).
> Similarly, it would be neat if a `--noprepare` flag was available.
> This allows for more fine-grained control over `run`.
> In our case, we want to do adjustments to files after calling `cordova 
> prepare` (similar to the hooks, but we've implemented it a bit differently), 
> and this is impossible since `cordova run` will call `prepare`, undoing our 
> changes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org