date:20170316

[jira] [Commented] (CB-11346) Remove known platforms check for Platform API

2017-03-16 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929460#comment-15929460
 ] 

ASF GitHub Bot commented on CB-11346:
-

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/529
  
Now to add tests! 


> Remove known platforms check for Platform API
> -
>
> Key: CB-11346
> URL: https://issues.apache.org/jira/browse/CB-11346
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaLib
>Reporter: Shazron Abdullah
>Assignee: Jesse MacFadyen
>  Labels: cordova-7.0.0
>
> https://github.com/apache/cordova-lib/blob/61f584de5891c52431e40a2dd534ac24cc081fcb/cordova-lib/src/platforms/PlatformApiPoly.js#L58-L59
> So that users can install any "platform".



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Comment Edited] (CB-9953) cordova platform check working very poorly

2017-03-16 Thread Shazron Abdullah (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-9953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929220#comment-15929220
 ] 

Shazron Abdullah edited comment on CB-9953 at 3/17/17 12:18 AM:


Doesn't seem to work unless you upgrade your cordova. 
{code}
$ cordova --version
6.3.0
$ node --version
v6.2.2
$ node --version
$ cordova create test
$ cd test
$ cordova platform add ios@4.1.0
$ cordova platform check
{code}


The last command does nothing, nor does it report any errors. With 
cordova@6.5.0, it does report a newer version available.


was (Author: shazron):
Doesn't seem to work unless you upgrade your cordova. 
{code}
$ cordova --version
6.3.0
$ node --version
$ cordova create test
$ cd test
$ cordova platform add ios@4.1.0
$ cordova platform check
{code}


The last command does nothing, nor does it report any errors. With 
cordova@6.5.0, it does report a newer version available.

> cordova platform check working very poorly
> --
>
> Key: CB-9953
> URL: https://issues.apache.org/jira/browse/CB-9953
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI
>Reporter: Raymond Camden
>Priority: Minor
>
> I've tested cordova platform check now in about 4 different projects and not 
> once was it able to tell me that iOS had a version newer than the one I was 
> using. For example, I get this:
> ios @ 3.9.1; current did not install, and thus its version cannot be 
> determined



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-9953) cordova platform check working very poorly

2017-03-16 Thread Shazron Abdullah (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-9953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929220#comment-15929220
 ] 

Shazron Abdullah commented on CB-9953:
--

Doesn't seem to work. 
{code}
$ cordova --version
6.3.0
$ node --version
$ cordova create test
$ cd test
$ cordova platform add ios@4.1.0
$ cordova platform check
{code}


The last command does nothing, nor does it report any errors. With 
cordova@6.5.0, it does report a newer version available.

> cordova platform check working very poorly
> --
>
> Key: CB-9953
> URL: https://issues.apache.org/jira/browse/CB-9953
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI
>Reporter: Raymond Camden
>Priority: Minor
>
> I've tested cordova platform check now in about 4 different projects and not 
> once was it able to tell me that iOS had a version newer than the one I was 
> using. For example, I get this:
> ios @ 3.9.1; current did not install, and thus its version cannot be 
> determined



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Comment Edited] (CB-9953) cordova platform check working very poorly

2017-03-16 Thread Shazron Abdullah (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-9953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929220#comment-15929220
 ] 

Shazron Abdullah edited comment on CB-9953 at 3/17/17 12:17 AM:


Doesn't seem to work unless you upgrade your cordova. 
{code}
$ cordova --version
6.3.0
$ node --version
$ cordova create test
$ cd test
$ cordova platform add ios@4.1.0
$ cordova platform check
{code}


The last command does nothing, nor does it report any errors. With 
cordova@6.5.0, it does report a newer version available.


was (Author: shazron):
Doesn't seem to work. 
{code}
$ cordova --version
6.3.0
$ node --version
$ cordova create test
$ cd test
$ cordova platform add ios@4.1.0
$ cordova platform check
{code}


The last command does nothing, nor does it report any errors. With 
cordova@6.5.0, it does report a newer version available.

> cordova platform check working very poorly
> --
>
> Key: CB-9953
> URL: https://issues.apache.org/jira/browse/CB-9953
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI
>Reporter: Raymond Camden
>Priority: Minor
>
> I've tested cordova platform check now in about 4 different projects and not 
> once was it able to tell me that iOS had a version newer than the one I was 
> using. For example, I get this:
> ios @ 3.9.1; current did not install, and thus its version cannot be 
> determined



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12576) "cordova platform check" doesn't work

2017-03-16 Thread Shazron Abdullah (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-12576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929218#comment-15929218
 ] 

Shazron Abdullah commented on CB-12576:
---

Is this a duplicate of CB-9953?

> "cordova platform check" doesn't work
> -
>
> Key: CB-12576
> URL: https://issues.apache.org/jira/browse/CB-12576
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI
>Affects Versions: 6.5.0
> Environment: OSX
>Reporter: Shawn Lan
>
> cordova -v = 6.5.0
> cordova platform ls:
> Installed platforms:
> android 6.1.2
> ios 4.3.1
> cordova platform check:
> Subproject Path: CordovaLib
> ios @ 4.3.1; current did not install, and thus its version cannot be 
> determined
> cp: no such file or directory: 
> /var/folders/wm/xyqns5v17zz0jyfhh9bpy_bmgp/T/cordova-platform-check-1489627520595/platforms/ios/HelloC
> ordova/.gitignore
> grep: no such file or directory: 
> /var/folders/wm/xyqns5v17zz0jyfhh9bpy_bmgp/T/cordova-platform-check-1489627520595/platforms/ios/Hell
> oCordova.xcodeproj/project.pbxproj
> sed: no such file or directory: 
> /var/folders/wm/xyqns5v17zz0jyfhh9bpy_bmgp/T/cordova-platform-check-1489627520595/platforms/ios/Hello
> Cordova.xcodeproj/project.pbxproj
> Error: Entry not found in project file for sub-project: 
> CordovaLib/CordovaLib.xcodeproj



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Resolved] (CB-12571) Podfile gets overwriten and some dependencies disappear

2017-03-16 Thread Shazron Abdullah (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-12571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shazron Abdullah resolved CB-12571.
---
Resolution: Fixed

> Podfile gets overwriten and some dependencies disappear
> ---
>
> Key: CB-12571
> URL: https://issues.apache.org/jira/browse/CB-12571
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: iOS
>Reporter: jcesarmobile
>Assignee: Shazron Abdullah
>  Labels: cordova-ios
> Fix For: cordova-ios@4.4.0
>
>
> When you install some plugins that use CocoaPods, some of the libraries 
> disappear from the Podfile.
> Steps to reproduce:
> 1. cordova create testPods
> 2. cd testPods
> 3. cordova platform add ios
> 4. cordova plugin add https://github.com/aerogear/aerogear-cordova-push/
> 5. Open platforms/ios/Podfile and check that pod 'AeroGear-Push', '1.2.0' is 
> there
> 6. cordova plugin add 
> https://github.com/jcesarmobile/cordova-plugin-tesseract-ocr
> 7. Open platforms/ios/Podfile and check that pod 'TesseractOCRiOS', '~> 
> 4.0.0' is there, but pod 'AeroGear-Push', '1.2.0' is gone
> Expected:
> have both 
> pod 'AeroGear-Push', '1.2.0' 
> pod 'TesseractOCRiOS', '~> 4.0.0'
> It's curious that if you install them in the opossite order, this doesn't 
> happen
> In both cases, the pods.json file has the information of both pods
> This doesn't happen with all plugins, so looks like an edge case. I found 
> this two plugins where the problem is present, but it was also reported on 
> Slack.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12571) Podfile gets overwriten and some dependencies disappear

2017-03-16 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-12571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929208#comment-15929208
 ] 

ASF GitHub Bot commented on CB-12571:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-ios/pull/296


> Podfile gets overwriten and some dependencies disappear
> ---
>
> Key: CB-12571
> URL: https://issues.apache.org/jira/browse/CB-12571
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: iOS
>Reporter: jcesarmobile
>Assignee: Shazron Abdullah
>  Labels: cordova-ios
> Fix For: cordova-ios@4.4.0
>
>
> When you install some plugins that use CocoaPods, some of the libraries 
> disappear from the Podfile.
> Steps to reproduce:
> 1. cordova create testPods
> 2. cd testPods
> 3. cordova platform add ios
> 4. cordova plugin add https://github.com/aerogear/aerogear-cordova-push/
> 5. Open platforms/ios/Podfile and check that pod 'AeroGear-Push', '1.2.0' is 
> there
> 6. cordova plugin add 
> https://github.com/jcesarmobile/cordova-plugin-tesseract-ocr
> 7. Open platforms/ios/Podfile and check that pod 'TesseractOCRiOS', '~> 
> 4.0.0' is there, but pod 'AeroGear-Push', '1.2.0' is gone
> Expected:
> have both 
> pod 'AeroGear-Push', '1.2.0' 
> pod 'TesseractOCRiOS', '~> 4.0.0'
> It's curious that if you install them in the opossite order, this doesn't 
> happen
> In both cases, the pods.json file has the information of both pods
> This doesn't happen with all plugins, so looks like an edge case. I found 
> this two plugins where the problem is present, but it was also reported on 
> Slack.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12571) Podfile gets overwriten and some dependencies disappear

2017-03-16 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-12571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929206#comment-15929206
 ] 

ASF subversion and git services commented on CB-12571:
--

Commit 6514b63265289e0955c8d03309cac5d2b98a9edd in cordova-ios's branch 
refs/heads/master from [~shazron]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=6514b63 ]

CB-12571 - Podfile gets overwritten and some dependencies disappear.

 This closes #296


> Podfile gets overwriten and some dependencies disappear
> ---
>
> Key: CB-12571
> URL: https://issues.apache.org/jira/browse/CB-12571
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: iOS
>Reporter: jcesarmobile
>Assignee: Shazron Abdullah
>  Labels: cordova-ios
> Fix For: cordova-ios@4.4.0
>
>
> When you install some plugins that use CocoaPods, some of the libraries 
> disappear from the Podfile.
> Steps to reproduce:
> 1. cordova create testPods
> 2. cd testPods
> 3. cordova platform add ios
> 4. cordova plugin add https://github.com/aerogear/aerogear-cordova-push/
> 5. Open platforms/ios/Podfile and check that pod 'AeroGear-Push', '1.2.0' is 
> there
> 6. cordova plugin add 
> https://github.com/jcesarmobile/cordova-plugin-tesseract-ocr
> 7. Open platforms/ios/Podfile and check that pod 'TesseractOCRiOS', '~> 
> 4.0.0' is there, but pod 'AeroGear-Push', '1.2.0' is gone
> Expected:
> have both 
> pod 'AeroGear-Push', '1.2.0' 
> pod 'TesseractOCRiOS', '~> 4.0.0'
> It's curious that if you install them in the opossite order, this doesn't 
> happen
> In both cases, the pods.json file has the information of both pods
> This doesn't happen with all plugins, so looks like an edge case. I found 
> this two plugins where the problem is present, but it was also reported on 
> Slack.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12577) Fix module import warnings when using Cordova.framework (Carthage)

2017-03-16 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-12577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929200#comment-15929200
 ] 

ASF GitHub Bot commented on CB-12577:
-

Github user khawkins commented on the issue:

https://github.com/apache/cordova-ios/pull/298
  
Thanks @shazron .  I could have sworn those were in there initially, but I 
guess not?


> Fix module import warnings when using Cordova.framework (Carthage)
> --
>
> Key: CB-12577
> URL: https://issues.apache.org/jira/browse/CB-12577
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
> Fix For: cordova-ios@4.4.0
>
> Attachments: moduleimport.png
>
>
> When adding {{Cordova.framework}} after adding and building it using 
> Carthage, and using module import:
> {code}
> @import Cordova;
> {code}
> then adding this to my code and building:
> {code}
> CDVViewController* cdv = [CDVViewController new];
> {code}
> I get two lexical or preprocessor issue warnings:
> {code}
> :1:1: warning: umbrella header for module 'Cordova' does not 
> include header 'CDV.h' [-Wincomplete-umbrella]
> #import "Headers/Cordova.h"
> ^
> :1:1: warning: umbrella header for module 'Cordova' does not 
> include header 'CDVCommandDelegateImpl.h' [-Wincomplete-umbrella]
> 2 warnings generated.
> /Users/shazron/Desktop/TestCarthage/TestCarthage/AppDelegate.m:21:24: 
> warning: unused variable 'c' [-Wunused-variable]
> CDVViewController* c = [CDVViewController new];
>^
> 3 warnings generated.
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12559) Update cordova-android documentation with respect to new Android SDK Tools 25.3.1

2017-03-16 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-12559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929187#comment-15929187
 ] 

ASF GitHub Bot commented on CB-12559:
-

Github user dpogue commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/686#discussion_r106557529
  
--- Diff: www/docs/en/dev/guide/platforms/android/index.md ---
@@ -62,19 +63,20 @@ they dip below 5% on Google's
 
 ### Java Development Kit (JDK)
 
-Install [Java Development Kit (JDK) 
7](http://www.oracle.com/technetwork/java/javase/downloads/jdk7-downloads-1880260.html)
+Install [Java Development Kit (JDK) 
8](http://www.oracle.com/technetwork/java/javase/downloads/jdk8-downloads-2133151.html)
 or later.
 
 When installing on Windows you also need to set `JAVA_HOME` Environment 
Variable
 according to your JDK installation path (see [Setting Environment 
Variables](#setting-environment-variables))
 
  Android SDK
 
-Install the [Android Stand-alone SDK 
Tools](http://developer.android.com/sdk/installing/index.html?pkg=tools) or 
[Android 
Studio](http://developer.android.com/sdk/installing/index.html?pkg=studio).
-Proceed with Android Studio if you plan on
-developing new Cordova for Android plugins or using native tools to
-run and debug the Android platform. Otherwise, the Android Stand-alone SDK 
Tools
-are enough to build and deploy Android applications.
+Install [Android Studio](reference/cordova-plugin-camera/index.html) or the
--- End diff --

Seems like the wrong link here?


> Update cordova-android documentation with respect to new Android SDK Tools 
> 25.3.1
> -
>
> Key: CB-12559
> URL: https://issues.apache.org/jira/browse/CB-12559
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Docs
>Reporter: Filip Maj
>Assignee: Filip Maj
>
> These docs: 
> https://cordova.apache.org/docs/en/latest/guide/platforms/android/index.html
> 1. It contains references to the {{android}} command. In the latest SDK, this 
> command does not work. Will need to add notes about using either the 
> {{sdkmanager}} or the {{avdmanager}} commands in the new SDK, depending on 
> what you originally needed {{android}} to do.
> 2. Add a recommendation to add the {{tools/bin}} folder to your path in this 
> part:
> {quote}
> 3. It is also recommended that you add the Android SDK's tools and 
> platform-tools directories to your PATH
> {quote}
> 3. Once-over EVERYTHING, including the linked docs.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11346) Remove known platforms check for Platform API

2017-03-16 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929186#comment-15929186
 ] 

ASF GitHub Bot commented on CB-11346:
-

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-lib/pull/529
  
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr=h1) 
Report
> Merging 
[#529](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr=desc) into 
[master](https://codecov.io/gh/apache/cordova-lib/commit/07001dc4e0acf89358c50791589428615198286b?src=pr=desc)
 will **increase** coverage by `<.01%`.
> The diff coverage is `92.68%`.


```diff
@@Coverage Diff@@
##   master#529  +/-   ##
=
+ Coverage81.9%   81.9%   +<.01% 
=
  Files  68  68  
  Lines54985499   +1 
  Branches 10901086   -4 
=
+ Hits 45034504   +1 
  Misses995 995
```


| [Impacted 
Files](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr=tree) | 
Coverage Δ | |
|---|---|---|
| 
[cordova-lib/src/plugman/install.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vaW5zdGFsbC5qcw==)
 | `87.07% <ø> (-0.09%)` | :x: |
| 
[cordova-lib/src/platforms/PlatformApiPoly.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL3BsYXRmb3Jtcy9QbGF0Zm9ybUFwaVBvbHkuanM=)
 | `93.75% <ø> (-0.44%)` | :x: |
| 
[cordova-lib/src/cordova/util.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvdXRpbC5qcw==)
 | `97.2% <100%> (ø)` | :white_check_mark: |
| 
[cordova-lib/src/cordova/platform.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvcGxhdGZvcm0uanM=)
 | `78.42% <88.88%> (+0.17%)` | :white_check_mark: |
| 
[cordova-lib/src/platforms/platforms.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL3BsYXRmb3Jtcy9wbGF0Zm9ybXMuanM=)
 | `97.14% <94.73%> (+0.59%)` | :white_check_mark: |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr=footer). 
Last update 
[07001dc...56d0746](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?el=footer=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


> Remove known platforms check for Platform API
> -
>
> Key: CB-11346
> URL: https://issues.apache.org/jira/browse/CB-11346
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaLib
>Reporter: Shazron Abdullah
>Assignee: Jesse MacFadyen
>  Labels: cordova-7.0.0
>
> https://github.com/apache/cordova-lib/blob/61f584de5891c52431e40a2dd534ac24cc081fcb/cordova-lib/src/platforms/PlatformApiPoly.js#L58-L59
> So that users can install any "platform".



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11346) Remove known platforms check for Platform API

2017-03-16 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929185#comment-15929185
 ] 

ASF GitHub Bot commented on CB-11346:
-

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-lib/pull/529
  
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr=h1) 
Report
> Merging 
[#529](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr=desc) into 
[master](https://codecov.io/gh/apache/cordova-lib/commit/07001dc4e0acf89358c50791589428615198286b?src=pr=desc)
 will **increase** coverage by `<.01%`.
> The diff coverage is `92.68%`.


```diff
@@Coverage Diff@@
##   master#529  +/-   ##
=
+ Coverage81.9%   81.9%   +<.01% 
=
  Files  68  68  
  Lines54985499   +1 
  Branches 10901086   -4 
=
+ Hits 45034504   +1 
  Misses995 995
```


| [Impacted 
Files](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr=tree) | 
Coverage Δ | |
|---|---|---|
| 
[cordova-lib/src/platforms/PlatformApiPoly.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL3BsYXRmb3Jtcy9QbGF0Zm9ybUFwaVBvbHkuanM=)
 | `93.75% <ø> (-0.44%)` | :x: |
| 
[cordova-lib/src/plugman/install.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL3BsdWdtYW4vaW5zdGFsbC5qcw==)
 | `87.07% <ø> (-0.09%)` | :x: |
| 
[cordova-lib/src/cordova/util.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvdXRpbC5qcw==)
 | `97.2% <100%> (ø)` | :white_check_mark: |
| 
[cordova-lib/src/cordova/platform.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvcGxhdGZvcm0uanM=)
 | `78.42% <88.88%> (+0.17%)` | :white_check_mark: |
| 
[cordova-lib/src/platforms/platforms.js](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL3BsYXRmb3Jtcy9wbGF0Zm9ybXMuanM=)
 | `97.14% <94.73%> (+0.59%)` | :white_check_mark: |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr=footer). 
Last update 
[07001dc...56d0746](https://codecov.io/gh/apache/cordova-lib/compare/07001dc4e0acf89358c50791589428615198286b...56d0746e7d26421fc3be3b4c5d6c8254cf801088?el=footer=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


> Remove known platforms check for Platform API
> -
>
> Key: CB-11346
> URL: https://issues.apache.org/jira/browse/CB-11346
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaLib
>Reporter: Shazron Abdullah
>Assignee: Jesse MacFadyen
>  Labels: cordova-7.0.0
>
> https://github.com/apache/cordova-lib/blob/61f584de5891c52431e40a2dd534ac24cc081fcb/cordova-lib/src/platforms/PlatformApiPoly.js#L58-L59
> So that users can install any "platform".



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12577) Fix module import warnings when using Cordova.framework (Carthage)

2017-03-16 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-12577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929153#comment-15929153
 ] 

ASF GitHub Bot commented on CB-12577:
-

GitHub user shazron opened a pull request:

https://github.com/apache/cordova-ios/pull/298

CB-12577 - Fix module import warnings when using Cordova.framework 
(Carthage)

### Platforms affected

self

### What does this PR do?

Remove warnings related to incomplete umbrella headers when using `@import 
Cordova` after compiling Cordova.framework using Carthage.

### What testing has been done on this change?

Added Cordova.framework from the repo using Carthage, added the import, 
added a reference to CDVViewController, and built an iOS View app.

### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shazron/cordova-ios CB-12577

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ios/pull/298.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #298


commit c7b422c5bd7a45e37df5945ca336bab58a1263a2
Author: Shazron Abdullah 
Date:   2017-03-16T23:35:02Z

CB-12577 - Fix module import warnings when using Cordova.framework 
(Carthage)




> Fix module import warnings when using Cordova.framework (Carthage)
> --
>
> Key: CB-12577
> URL: https://issues.apache.org/jira/browse/CB-12577
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
> Fix For: cordova-ios@4.4.0
>
> Attachments: moduleimport.png
>
>
> When adding {{Cordova.framework}} after adding and building it using 
> Carthage, and using module import:
> {code}
> @import Cordova;
> {code}
> then adding this to my code and building:
> {code}
> CDVViewController* cdv = [CDVViewController new];
> {code}
> I get two lexical or preprocessor issue warnings:
> {code}
> :1:1: warning: umbrella header for module 'Cordova' does not 
> include header 'CDV.h' [-Wincomplete-umbrella]
> #import "Headers/Cordova.h"
> ^
> :1:1: warning: umbrella header for module 'Cordova' does not 
> include header 'CDVCommandDelegateImpl.h' [-Wincomplete-umbrella]
> 2 warnings generated.
> /Users/shazron/Desktop/TestCarthage/TestCarthage/AppDelegate.m:21:24: 
> warning: unused variable 'c' [-Wunused-variable]
> CDVViewController* c = [CDVViewController new];
>^
> 3 warnings generated.
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12559) Update cordova-android documentation with respect to new Android SDK Tools 25.3.1

2017-03-16 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-12559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929167#comment-15929167
 ] 

ASF GitHub Bot commented on CB-12559:
-

GitHub user filmaj opened a pull request:

https://github.com/apache/cordova-docs/pull/686

CB-12559: documentation updates for new Android SDK Tools



Ping @infil00p, @shazron, @dpogue, @purplecabbage for review, please and 
thank you.

Please do not merge this until apache/cordova-android#369 is merged in.

### Platforms affected

Android

### What does this PR do?

Documents changes to set up introduced with the new Android SDK Tools.

Also once-over'ed all the links and updated some of the ones to 
developer.android.com to avoid redirects.

This incorporates / is related to #678. 

### What testing has been done on this change?

Simply ran generated docs - seemed to work.

### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database: 
[CB-12559](https://issues.apache.org/jira/browse/CB-12559), 
[CB-12391](https://issues.apache.org/jira/browse/CB-12391), and related to the 
changes in [CB-12546](https://issues.apache.org/jira/browse/CB-12546) and 
[CB-12554](https://issues.apache.org/jira/browse/CB-12554).
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/filmaj/cordova-docs CB-12559

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/686.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #686


commit 55d356a4c96ec904d3028ba6a0e3846cb2fe3de8
Author: filmaj 
Date:   2017-03-16T23:34:26Z

CB-12559: updates for new android SDK Tools. also updated links to avoid 
redirects. 80-character width limit honouring.

commit 176c03ca47b629d11550729b1da67a233669a517
Author: filmaj 
Date:   2017-03-16T23:37:18Z

CB-12391: update android target levels for cordova-android 6.x.x




> Update cordova-android documentation with respect to new Android SDK Tools 
> 25.3.1
> -
>
> Key: CB-12559
> URL: https://issues.apache.org/jira/browse/CB-12559
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Docs
>Reporter: Filip Maj
>Assignee: Filip Maj
>
> These docs: 
> https://cordova.apache.org/docs/en/latest/guide/platforms/android/index.html
> 1. It contains references to the {{android}} command. In the latest SDK, this 
> command does not work. Will need to add notes about using either the 
> {{sdkmanager}} or the {{avdmanager}} commands in the new SDK, depending on 
> what you originally needed {{android}} to do.
> 2. Add a recommendation to add the {{tools/bin}} folder to your path in this 
> part:
> {quote}
> 3. It is also recommended that you add the Android SDK's tools and 
> platform-tools directories to your PATH
> {quote}
> 3. Once-over EVERYTHING, including the linked docs.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12050) Add support for integrating Cordova for iOS with Carthage

2017-03-16 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-12050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929158#comment-15929158
 ] 

ASF GitHub Bot commented on CB-12050:
-

Github user shazron commented on the issue:

https://github.com/apache/cordova-ios/pull/297
  
Posted #298 


> Add support for integrating Cordova for iOS with Carthage
> -
>
> Key: CB-12050
> URL: https://issues.apache.org/jira/browse/CB-12050
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: iOS
>Reporter: Dan Ursu
>Assignee: Shazron Abdullah
> Fix For: cordova-ios@4.4.0
>
>
> Currently the documentation doesn't clearly state how one would integrate the 
> cordova framework into an iOS app using carthage. It would be nice if there 
> would be support. Same with cocoapods.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12559) Update cordova-android documentation with respect to new Android SDK Tools 25.3.1

2017-03-16 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-12559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929147#comment-15929147
 ] 

ASF subversion and git services commented on CB-12559:
--

Commit 55d356a4c96ec904d3028ba6a0e3846cb2fe3de8 in cordova-docs's branch 
refs/heads/CB-12559 from filmaj
[ https://git-wip-us.apache.org/repos/asf?p=cordova-docs.git;h=55d356a ]

CB-12559: updates for new android SDK Tools. also updated links to avoid 
redirects. 80-character width limit honouring.


> Update cordova-android documentation with respect to new Android SDK Tools 
> 25.3.1
> -
>
> Key: CB-12559
> URL: https://issues.apache.org/jira/browse/CB-12559
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Docs
>Reporter: Filip Maj
>Assignee: Filip Maj
>
> These docs: 
> https://cordova.apache.org/docs/en/latest/guide/platforms/android/index.html
> 1. It contains references to the {{android}} command. In the latest SDK, this 
> command does not work. Will need to add notes about using either the 
> {{sdkmanager}} or the {{avdmanager}} commands in the new SDK, depending on 
> what you originally needed {{android}} to do.
> 2. Add a recommendation to add the {{tools/bin}} folder to your path in this 
> part:
> {quote}
> 3. It is also recommended that you add the Android SDK's tools and 
> platform-tools directories to your PATH
> {quote}
> 3. Once-over EVERYTHING, including the linked docs.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-12577) Fix module import warnings when using Cordova.framework (Carthage)

2017-03-16 Thread Shazron Abdullah (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-12577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shazron Abdullah updated CB-12577:
--
Description: 
When adding {{Cordova.framework}} after adding and building it using Carthage, 
and using module import:

{code}
@import Cordova;
{code}

then adding this to my code and building:
{code}
CDVViewController* cdv = [CDVViewController new];
{code}

I get two lexical or preprocessor issue warnings:
{code}
:1:1: warning: umbrella header for module 'Cordova' does not 
include header 'CDV.h' [-Wincomplete-umbrella]
#import "Headers/Cordova.h"
^
:1:1: warning: umbrella header for module 'Cordova' does not 
include header 'CDVCommandDelegateImpl.h' [-Wincomplete-umbrella]
2 warnings generated.
/Users/shazron/Desktop/TestCarthage/TestCarthage/AppDelegate.m:21:24: warning: 
unused variable 'c' [-Wunused-variable]
CDVViewController* c = [CDVViewController new];
   ^
3 warnings generated.
{code}

  was:
When adding {{Cordova.framework}} after adding and building it using Carthage, 
and using module import:

{code}
import Cordova;
{code}

then adding this to my code and building:
{code}
CDVViewController* cdv = [CDVViewController new];
{code}

I get two lexical or preprocessor issue warnings:
{code}
:1:1: warning: umbrella header for module 'Cordova' does not 
include header 'CDV.h' [-Wincomplete-umbrella]
#import "Headers/Cordova.h"
^
:1:1: warning: umbrella header for module 'Cordova' does not 
include header 'CDVCommandDelegateImpl.h' [-Wincomplete-umbrella]
2 warnings generated.
/Users/shazron/Desktop/TestCarthage/TestCarthage/AppDelegate.m:21:24: warning: 
unused variable 'c' [-Wunused-variable]
CDVViewController* c = [CDVViewController new];
   ^
3 warnings generated.
{code}


> Fix module import warnings when using Cordova.framework (Carthage)
> --
>
> Key: CB-12577
> URL: https://issues.apache.org/jira/browse/CB-12577
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
> Fix For: cordova-ios@4.4.0
>
> Attachments: moduleimport.png
>
>
> When adding {{Cordova.framework}} after adding and building it using 
> Carthage, and using module import:
> {code}
> @import Cordova;
> {code}
> then adding this to my code and building:
> {code}
> CDVViewController* cdv = [CDVViewController new];
> {code}
> I get two lexical or preprocessor issue warnings:
> {code}
> :1:1: warning: umbrella header for module 'Cordova' does not 
> include header 'CDV.h' [-Wincomplete-umbrella]
> #import "Headers/Cordova.h"
> ^
> :1:1: warning: umbrella header for module 'Cordova' does not 
> include header 'CDVCommandDelegateImpl.h' [-Wincomplete-umbrella]
> 2 warnings generated.
> /Users/shazron/Desktop/TestCarthage/TestCarthage/AppDelegate.m:21:24: 
> warning: unused variable 'c' [-Wunused-variable]
> CDVViewController* c = [CDVViewController new];
>^
> 3 warnings generated.
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-12577) Fix module import warnings when using Cordova.framework (Carthage)

2017-03-16 Thread Shazron Abdullah (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-12577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shazron Abdullah updated CB-12577:
--
Attachment: moduleimport.png

> Fix module import warnings when using Cordova.framework (Carthage)
> --
>
> Key: CB-12577
> URL: https://issues.apache.org/jira/browse/CB-12577
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
> Fix For: cordova-ios@4.4.0
>
> Attachments: moduleimport.png
>
>
> When adding {{Cordova.framework}} after adding and building it using 
> Carthage, and using module import:
> {code}
> import Cordova;
> {code}
> then adding this to my code and building:
> {code}
> CDVViewController* cdv = [CDVViewController new];
> {code}
> I get two lexical or preprocessor issue warnings:
> {code}
> :1:1: warning: umbrella header for module 'Cordova' does not 
> include header 'CDV.h' [-Wincomplete-umbrella]
> #import "Headers/Cordova.h"
> ^
> :1:1: warning: umbrella header for module 'Cordova' does not 
> include header 'CDVCommandDelegateImpl.h' [-Wincomplete-umbrella]
> 2 warnings generated.
> /Users/shazron/Desktop/TestCarthage/TestCarthage/AppDelegate.m:21:24: 
> warning: unused variable 'c' [-Wunused-variable]
> CDVViewController* c = [CDVViewController new];
>^
> 3 warnings generated.
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-12577) Fix module import warnings when using Cordova.framework (Carthage)

2017-03-16 Thread Shazron Abdullah (JIRA)

Shazron Abdullah created CB-12577:
-

 Summary: Fix module import warnings when using Cordova.framework 
(Carthage)
 Key: CB-12577
 URL: https://issues.apache.org/jira/browse/CB-12577
 Project: Apache Cordova
  Issue Type: Sub-task
  Components: iOS
Reporter: Shazron Abdullah
Assignee: Shazron Abdullah


When adding {{Cordova.framework}} after adding and building it using Carthage, 
and using module import:

{code}
import Cordova;
{code}

then adding this to my code and building:
{code}
CDVViewController* cdv = [CDVViewController new];
{code}

I get two lexical or preprocessor issue warnings:
{code}
:1:1: warning: umbrella header for module 'Cordova' does not 
include header 'CDV.h' [-Wincomplete-umbrella]
#import "Headers/Cordova.h"
^
:1:1: warning: umbrella header for module 'Cordova' does not 
include header 'CDVCommandDelegateImpl.h' [-Wincomplete-umbrella]
2 warnings generated.
/Users/shazron/Desktop/TestCarthage/TestCarthage/AppDelegate.m:21:24: warning: 
unused variable 'c' [-Wunused-variable]
CDVViewController* c = [CDVViewController new];
   ^
3 warnings generated.
{code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12050) Add support for integrating Cordova for iOS with Carthage

2017-03-16 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-12050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929090#comment-15929090
 ] 

ASF GitHub Bot commented on CB-12050:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-ios/pull/297


> Add support for integrating Cordova for iOS with Carthage
> -
>
> Key: CB-12050
> URL: https://issues.apache.org/jira/browse/CB-12050
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: iOS
>Reporter: Dan Ursu
>Assignee: Shazron Abdullah
> Fix For: cordova-ios@4.4.0
>
>
> Currently the documentation doesn't clearly state how one would integrate the 
> cordova framework into an iOS app using carthage. It would be nice if there 
> would be support. Same with cocoapods.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12050) Add support for integrating Cordova for iOS with Carthage

2017-03-16 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-12050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929089#comment-15929089
 ] 

ASF subversion and git services commented on CB-12050:
--

Commit 3a8e994bb21ac6d2a364d372be86cbd29c3bb947 in cordova-ios's branch 
refs/heads/master from [~khawk...@salesforce.com]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=3a8e994 ]

CB-12050 ios: Create shared scheme for framework target, for Carthage support

 This closes #297


> Add support for integrating Cordova for iOS with Carthage
> -
>
> Key: CB-12050
> URL: https://issues.apache.org/jira/browse/CB-12050
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: iOS
>Reporter: Dan Ursu
>Assignee: Shazron Abdullah
> Fix For: cordova-ios@4.4.0
>
>
> Currently the documentation doesn't clearly state how one would integrate the 
> cordova framework into an iOS app using carthage. It would be nice if there 
> would be support. Same with cocoapods.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12050) Add support for integrating Cordova for iOS with Carthage

2017-03-16 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-12050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929085#comment-15929085
 ] 

ASF GitHub Bot commented on CB-12050:
-

Github user shazron commented on the issue:

https://github.com/apache/cordova-ios/pull/297
  
Good stuff, tested it, it works as you described.
Two issues related to using module import using `@import Cordova;` which I 
will address in a separate PR though:
![screen shot 2017-03-16 at 3 53 02 
pm](https://cloud.githubusercontent.com/assets/36107/24021947/cad8c278-0a60-11e7-85a7-46dc1138a6b8.png)



> Add support for integrating Cordova for iOS with Carthage
> -
>
> Key: CB-12050
> URL: https://issues.apache.org/jira/browse/CB-12050
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: iOS
>Reporter: Dan Ursu
>Assignee: Shazron Abdullah
> Fix For: cordova-ios@4.4.0
>
>
> Currently the documentation doesn't clearly state how one would integrate the 
> cordova framework into an iOS app using carthage. It would be nice if there 
> would be support. Same with cocoapods.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12571) Podfile gets overwriten and some dependencies disappear

2017-03-16 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-12571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929052#comment-15929052
 ] 

ASF GitHub Bot commented on CB-12571:
-

Github user shazron commented on the issue:

https://github.com/apache/cordova-ios/pull/296
  
For reference, it passed on my personal repo here: 
https://travis-ci.org/shazron/cordova-ios/builds/211143535


> Podfile gets overwriten and some dependencies disappear
> ---
>
> Key: CB-12571
> URL: https://issues.apache.org/jira/browse/CB-12571
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: iOS
>Reporter: jcesarmobile
>Assignee: Shazron Abdullah
>  Labels: cordova-ios
> Fix For: cordova-ios@4.4.0
>
>
> When you install some plugins that use CocoaPods, some of the libraries 
> disappear from the Podfile.
> Steps to reproduce:
> 1. cordova create testPods
> 2. cd testPods
> 3. cordova platform add ios
> 4. cordova plugin add https://github.com/aerogear/aerogear-cordova-push/
> 5. Open platforms/ios/Podfile and check that pod 'AeroGear-Push', '1.2.0' is 
> there
> 6. cordova plugin add 
> https://github.com/jcesarmobile/cordova-plugin-tesseract-ocr
> 7. Open platforms/ios/Podfile and check that pod 'TesseractOCRiOS', '~> 
> 4.0.0' is there, but pod 'AeroGear-Push', '1.2.0' is gone
> Expected:
> have both 
> pod 'AeroGear-Push', '1.2.0' 
> pod 'TesseractOCRiOS', '~> 4.0.0'
> It's curious that if you install them in the opossite order, this doesn't 
> happen
> In both cases, the pods.json file has the information of both pods
> This doesn't happen with all plugins, so looks like an edge case. I found 
> this two plugins where the problem is present, but it was also reported on 
> Slack.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12571) Podfile gets overwriten and some dependencies disappear

2017-03-16 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-12571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929046#comment-15929046
 ] 

ASF GitHub Bot commented on CB-12571:
-

GitHub user shazron reopened a pull request:

https://github.com/apache/cordova-ios/pull/296

CB-12571 - Podfile gets overwritten and some dependencies disappear.

### Platforms affected

self

### What does this PR do?

Fix reading of pods with non-alphanumeric characters in the name from 
Podfile

### What testing has been done on this change?

Added unit tests

### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shazron/cordova-ios CB-12571

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ios/pull/296.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #296


commit 303bb5480c225ffa3a374fb592dfc560dabf0804
Author: Shazron Abdullah 
Date:   2017-03-14T22:17:09Z

CB-12571 - Podfile gets overwritten and some dependencies disappear.




> Podfile gets overwriten and some dependencies disappear
> ---
>
> Key: CB-12571
> URL: https://issues.apache.org/jira/browse/CB-12571
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: iOS
>Reporter: jcesarmobile
>Assignee: Shazron Abdullah
>  Labels: cordova-ios
> Fix For: cordova-ios@4.4.0
>
>
> When you install some plugins that use CocoaPods, some of the libraries 
> disappear from the Podfile.
> Steps to reproduce:
> 1. cordova create testPods
> 2. cd testPods
> 3. cordova platform add ios
> 4. cordova plugin add https://github.com/aerogear/aerogear-cordova-push/
> 5. Open platforms/ios/Podfile and check that pod 'AeroGear-Push', '1.2.0' is 
> there
> 6. cordova plugin add 
> https://github.com/jcesarmobile/cordova-plugin-tesseract-ocr
> 7. Open platforms/ios/Podfile and check that pod 'TesseractOCRiOS', '~> 
> 4.0.0' is there, but pod 'AeroGear-Push', '1.2.0' is gone
> Expected:
> have both 
> pod 'AeroGear-Push', '1.2.0' 
> pod 'TesseractOCRiOS', '~> 4.0.0'
> It's curious that if you install them in the opossite order, this doesn't 
> happen
> In both cases, the pods.json file has the information of both pods
> This doesn't happen with all plugins, so looks like an edge case. I found 
> this two plugins where the problem is present, but it was also reported on 
> Slack.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12571) Podfile gets overwriten and some dependencies disappear

2017-03-16 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-12571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929045#comment-15929045
 ] 

ASF GitHub Bot commented on CB-12571:
-

Github user shazron closed the pull request at:

https://github.com/apache/cordova-ios/pull/296


> Podfile gets overwriten and some dependencies disappear
> ---
>
> Key: CB-12571
> URL: https://issues.apache.org/jira/browse/CB-12571
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: iOS
>Reporter: jcesarmobile
>Assignee: Shazron Abdullah
>  Labels: cordova-ios
> Fix For: cordova-ios@4.4.0
>
>
> When you install some plugins that use CocoaPods, some of the libraries 
> disappear from the Podfile.
> Steps to reproduce:
> 1. cordova create testPods
> 2. cd testPods
> 3. cordova platform add ios
> 4. cordova plugin add https://github.com/aerogear/aerogear-cordova-push/
> 5. Open platforms/ios/Podfile and check that pod 'AeroGear-Push', '1.2.0' is 
> there
> 6. cordova plugin add 
> https://github.com/jcesarmobile/cordova-plugin-tesseract-ocr
> 7. Open platforms/ios/Podfile and check that pod 'TesseractOCRiOS', '~> 
> 4.0.0' is there, but pod 'AeroGear-Push', '1.2.0' is gone
> Expected:
> have both 
> pod 'AeroGear-Push', '1.2.0' 
> pod 'TesseractOCRiOS', '~> 4.0.0'
> It's curious that if you install them in the opossite order, this doesn't 
> happen
> In both cases, the pods.json file has the information of both pods
> This doesn't happen with all plugins, so looks like an edge case. I found 
> this two plugins where the problem is present, but it was also reported on 
> Slack.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12571) Podfile gets overwriten and some dependencies disappear

2017-03-16 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-12571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929044#comment-15929044
 ] 

ASF GitHub Bot commented on CB-12571:
-

Github user shazron commented on the issue:

https://github.com/apache/cordova-ios/pull/296
  
Looks like another case of simulator not starting. Closing and re-opening 
for CI


> Podfile gets overwriten and some dependencies disappear
> ---
>
> Key: CB-12571
> URL: https://issues.apache.org/jira/browse/CB-12571
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: iOS
>Reporter: jcesarmobile
>Assignee: Shazron Abdullah
>  Labels: cordova-ios
> Fix For: cordova-ios@4.4.0
>
>
> When you install some plugins that use CocoaPods, some of the libraries 
> disappear from the Podfile.
> Steps to reproduce:
> 1. cordova create testPods
> 2. cd testPods
> 3. cordova platform add ios
> 4. cordova plugin add https://github.com/aerogear/aerogear-cordova-push/
> 5. Open platforms/ios/Podfile and check that pod 'AeroGear-Push', '1.2.0' is 
> there
> 6. cordova plugin add 
> https://github.com/jcesarmobile/cordova-plugin-tesseract-ocr
> 7. Open platforms/ios/Podfile and check that pod 'TesseractOCRiOS', '~> 
> 4.0.0' is there, but pod 'AeroGear-Push', '1.2.0' is gone
> Expected:
> have both 
> pod 'AeroGear-Push', '1.2.0' 
> pod 'TesseractOCRiOS', '~> 4.0.0'
> It's curious that if you install them in the opossite order, this doesn't 
> happen
> In both cases, the pods.json file has the information of both pods
> This doesn't happen with all plugins, so looks like an edge case. I found 
> this two plugins where the problem is present, but it was also reported on 
> Slack.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12458) [cordova-plugin-camera] - The information about old versions of the plugin install the deprecated ID is missing in the README

2017-03-16 Thread Camila Macedo (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-12458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928936#comment-15928936
 ] 

Camila Macedo commented on CB-12458:


[~jcesarmobile]Could you approve and merge now?

> [cordova-plugin-camera] - The information about old versions of the plugin 
> install the deprecated ID is missing in the README
> -
>
> Key: CB-12458
> URL: https://issues.apache.org/jira/browse/CB-12458
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Camera
>Reporter: Camila Macedo
>  Labels: camera, plugin, readme
>
> The information about old versions of the plugin install the deprecated ID is 
> missing in the README of the cordova-plugin-camera 
> (https://github.com/apache/cordova-plugin-camera)
> *Example:*
> *Add plugin without defining the version of the plugin. ( lastest )*
>  {code}
> dhcp-17-22:01789921-Cordova-App cmacedo$ cordova plugin add 
> cordova-plugin-camera --save
> Saved plugin info for "cordova-plugin-camera" to config.xml
> dhcp-17-22:01789921-Cordova-App cmacedo$ cat config.xml 
> 
>  xmlns="http://www.w3.org/ns/widgets; 
> xmlns:cdv="http://cordova.apache.org/ns/1.0;>
> Blank App
> 
> This is an hybrid app, built using Cordova
> 
> 
> 
> 
> 
> 
> 
> 
> 
> *Add plugin with the definition of the version as 0.2.7.*  
> dhcp-17-22:CordovaHello-Cordova-App cmacedo$ cordova plugin add 
> cordova-plugin-camera@0.2.7 --save
> Fetching plugin "cordova-plugin-camera@0.2.7" via npm
> Saved plugin info for "org.apache.cordova.camera" to config.xml
> dhcp-17-22:CordovaHello-Cordova-App cmacedo$ cat config.xml 
> 
>  xmlns="http://www.w3.org/ns/widgets; 
> xmlns:cdv="http://cordova.apache.org/ns/1.0;>
> Blank App
> 
> This is an hybrid app, built using Cordova
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
>  {code}
> *Cordova CLI tool used*
> dhcp-17-22:CordovaHello-Cordova-App cmacedo$ cordova -g -v
> 6.4.0
> *Point of the documentation*
> Installation
> This requires cordova 5.0+
> cordova plugin add cordova-plugin-camera
> Older versions of cordova can still install via the deprecated id
> cordova plugin add org.apache.cordova.camera
> It is also possible to install via repo url directly ( unstable )
> cordova plugin add https://github.com/apache/cordova-plugin-camera.git 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12542) can’t record to a “wav” file on IOS media plugin

2017-03-16 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-12542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928499#comment-15928499
 ] 

ASF GitHub Bot commented on CB-12542:
-

Github user LoneyGG commented on the issue:

https://github.com/apache/cordova-plugin-media/pull/134
  
Why this hasn't been merged yet? its a pain to apply the fix manually and 
remove this plugin from the gitignore in order to share my code with my 
partners.


> can’t record to a “wav” file on IOS media plugin
> 
>
> Key: CB-12542
> URL: https://issues.apache.org/jira/browse/CB-12542
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Media
>Affects Versions: 3.5.0
> Environment: 9.x Simulator , IOS 8.x device (iPod touch)
>Reporter: Leo Schubert
>Priority: Critical
> Attachments: cdvsound.diff
>
>
> I get “Failed to initialize AVAudioRecorder: (null)” in the error callback of 
> the startRecordingAudio() exec API.
> I see that the AVAudioPlayer settings in CDVAudio.m are
> {code}
> NSDictionary *audioSettings = @{AVFormatIDKey: @(kAudioFormatMPEG4AAC),
> AVSampleRateKey: @(44100),
> AVNumberOfChannelsKey: @(1),
> AVEncoderAudioQualityKey: 
> @(AVAudioQualityMedium)
> };
> {code}
> This is IMHO the reason it doesn’t work. Either one uses the .m4a extension 
> with {{kAudioFormatMPEG4AAC}} or
> .wav with the {{kAudioFormatLinearPCM}} key (the IOS docs are very unclear 
> about which file extensions are actually supported)
> The plugin enforces “wav” but the settings enforce the MPEG4AAC encoder.
> Using the attached simple patch and using .m4a at the JS side solves the 
> problem and records on my iPod touch IOS 8.x.
> I stumbled also across 
> https://github.com/remoorejr/cordova-plugin-media-with-compression where the 
> exchange wav->m4a is done too.
> Strangely I can’t find much problems reported on stackoverflow, but this one 
> seems to cover it
> http://stackoverflow.com/questions/12244111/failed-to-initialize-avaudiorecorder-null
> The last poster seem to indicate that the problem sneaked in in IOS 8 
> (previously it was probably possible to record to a .wav file but with AAC 
> content).
> Looking at the recordAudio() test for the plugin in tests/tests.js I can’t 
> see that potential errors are actually causing the test to fail: they are 
> just logged with console.log , so this may explain why the problem has not 
> been detected by the tests.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Assigned] (CB-12570) make --fetch true by default, make --nofetch flag

2017-03-16 Thread Audrey So (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-12570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Audrey So reassigned CB-12570:
--

Assignee: Audrey So

> make --fetch true by default, make --nofetch flag
> -
>
> Key: CB-12570
> URL: https://issues.apache.org/jira/browse/CB-12570
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CLI
>Reporter: Steve Gill
>Assignee: Audrey So
>  Labels: cordova-7.0.0
> Fix For: 7.0.0
>
>
> We want to make --fetch true by default so all platform/plugin add/rm uses 
> cordova-fetch under the hood.
> Similar to how autosave was handled in 
> https://github.com/apache/cordova-cli/pull/266



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12008) Discuss moving towards autosave by default for cordova@7

2017-03-16 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-12008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928442#comment-15928442
 ] 

ASF GitHub Bot commented on CB-12008:
-

Github user audreyso commented on the issue:

https://github.com/apache/cordova-cli/pull/266
  
Thanks! @stevengill  ...Rebased cli PR's! Let me know if I need to make any 
additional changes! 


> Discuss moving towards autosave by default for cordova@7
> 
>
> Key: CB-12008
> URL: https://issues.apache.org/jira/browse/CB-12008
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaLib
>Reporter: Steve Gill
>Assignee: Audrey So
>  Labels: cordova-7.0.0
> Fix For: 7.0.0
>
>
> Need to create a discuss thread about this. Our analytics show --save usage 
> is pretty low (presumably due to people not knowing about it). 
> It might be time to consider saving by default and having a --no-save flag to 
> not save. 
> We can also have global config to turn auto-save off for cordova 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-12576) "cordova platform check" doesn't work

2017-03-16 Thread Shawn Lan (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-12576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shawn Lan updated CB-12576:
---
Description: 
cordova -v = 6.5.0

cordova platform ls:

Installed platforms:
android 6.1.2
ios 4.3.1

cordova platform check:

Subproject Path: CordovaLib

ios @ 4.3.1; current did not install, and thus its version cannot be determined


cp: no such file or directory: 
/var/folders/wm/xyqns5v17zz0jyfhh9bpy_bmgp/T/cordova-platform-check-1489627520595/platforms/ios/HelloC
ordova/.gitignore


grep: no such file or directory: 
/var/folders/wm/xyqns5v17zz0jyfhh9bpy_bmgp/T/cordova-platform-check-1489627520595/platforms/ios/Hell
oCordova.xcodeproj/project.pbxproj


sed: no such file or directory: 
/var/folders/wm/xyqns5v17zz0jyfhh9bpy_bmgp/T/cordova-platform-check-1489627520595/platforms/ios/Hello
Cordova.xcodeproj/project.pbxproj


Error: Entry not found in project file for sub-project: 
CordovaLib/CordovaLib.xcodeproj

  was:
Here is the output. Doesn't look right to me:

Subproject Path: CordovaLib

ios @ 4.3.1; current did not install, and thus its version cannot be determined


cp: no such file or directory: 
/var/folders/wm/xyqns5v17zz0jyfhh9bpy_bmgp/T/cordova-platform-check-1489627520595/platforms/ios/HelloC
ordova/.gitignore


grep: no such file or directory: 
/var/folders/wm/xyqns5v17zz0jyfhh9bpy_bmgp/T/cordova-platform-check-1489627520595/platforms/ios/Hell
oCordova.xcodeproj/project.pbxproj


sed: no such file or directory: 
/var/folders/wm/xyqns5v17zz0jyfhh9bpy_bmgp/T/cordova-platform-check-1489627520595/platforms/ios/Hello
Cordova.xcodeproj/project.pbxproj


Error: Entry not found in project file for sub-project: 
CordovaLib/CordovaLib.xcodeproj


> "cordova platform check" doesn't work
> -
>
> Key: CB-12576
> URL: https://issues.apache.org/jira/browse/CB-12576
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI
>Affects Versions: 6.5.0
> Environment: OSX
>Reporter: Shawn Lan
>
> cordova -v = 6.5.0
> cordova platform ls:
> Installed platforms:
> android 6.1.2
> ios 4.3.1
> cordova platform check:
> Subproject Path: CordovaLib
> ios @ 4.3.1; current did not install, and thus its version cannot be 
> determined
> cp: no such file or directory: 
> /var/folders/wm/xyqns5v17zz0jyfhh9bpy_bmgp/T/cordova-platform-check-1489627520595/platforms/ios/HelloC
> ordova/.gitignore
> grep: no such file or directory: 
> /var/folders/wm/xyqns5v17zz0jyfhh9bpy_bmgp/T/cordova-platform-check-1489627520595/platforms/ios/Hell
> oCordova.xcodeproj/project.pbxproj
> sed: no such file or directory: 
> /var/folders/wm/xyqns5v17zz0jyfhh9bpy_bmgp/T/cordova-platform-check-1489627520595/platforms/ios/Hello
> Cordova.xcodeproj/project.pbxproj
> Error: Entry not found in project file for sub-project: 
> CordovaLib/CordovaLib.xcodeproj



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-3232) "cordova platform add blackberry" fails on 2.7.1-rc.1

2017-03-16 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928212#comment-15928212
 ] 

ASF GitHub Bot commented on CB-3232:


GitHub user murphy85 opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/216

Update README.md

Changed options description from string to object



### Platforms affected


### What does this PR do?


### What testing has been done on this change?


### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/murphy85/cordova-plugin-inappbrowser patch-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/216.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #216


commit e027ec51bb77e93858dd918a407431d11bc1f3fc
Author: murphy85 
Date:   2017-03-16T14:55:20Z

Update README.md

Changed options description from string to object




> "cordova platform add blackberry" fails on 2.7.1-rc.1
> -
>
> Key: CB-3232
> URL: https://issues.apache.org/jira/browse/CB-3232
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: BlackBerry (deprecated), CLI
>Affects Versions: 2.7.0
>Reporter: Michael Brooks
>Assignee: Michael Brooks
> Fix For: 2.7.0
>
>
> The following error is thrown when running {{$ cordova platform add 
> blackberry}}:
> {code}
> [Error: An error occured during creation of blackberry sub-project. Creating 
> BlackBerry project...
> Updating config.xml ...
> sed: 
> /Users/mwbrooks/Dropbox/Development/sandbox/myapp/platforms/blackberry/www/config.xml:
>  No such file or directory
> Cleaning up ...
> Remember to update the project.properties file inside your application 
> directory!
> ]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12546) Latest Android SDK tools introduce bug w/ Android emulator

2017-03-16 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-12546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928141#comment-15928141
 ] 

ASF GitHub Bot commented on CB-12546:
-

Github user filmaj commented on the issue:

https://github.com/apache/cordova-android/pull/369
  
@dpogue thanks for checking! So I think `android_sdk_version` failing in 
this case is kind of expected, as that script, historically, did not do any 
environment checking, and I tried keeping the same behaviour.

The other commands that are part of `Api.js`, like `build` and `clean` and 
`run`, [always call through to 
`check_reqs`](https://github.com/apache/cordova-android/blob/master/bin/templates/cordova/Api.js#L344-L346).
 Part of that functionality in this pull request now [automatically adds the 
new SDK tools to your 
`PATH`](https://github.com/filmaj/cordova-android/blob/CB-12546/bin/templates/cordova/lib/check_reqs.js#L295-L297)
 if they are missing. That's why the `build` command worked for you, but the 
`android_sdk_version` command did not.

We could tweak the behaviour of `android_sdk_version` so that it calls 
through to `check_reqs` as well? This change would fix that command failing in 
your case, and provide more meaningful errors for people who don't have their 
environments configured properly (i.e. will check for missing `ANDROID_HOME`, 
will munge `PATH` based on what kinds of Android tooling it will find, etc.). 
What do you think?

The deeper question that rises out of this is: is `android_sdk_version` 
useful? Is it worth keeping around? It is not part of the platform API and is 
still hanging around due to history more than anything else.

Let me know what y'all think.


> Latest Android SDK tools introduce bug w/ Android emulator
> --
>
> Key: CB-12546
> URL: https://issues.apache.org/jira/browse/CB-12546
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Android
>Reporter: Filip Maj
>Assignee: Filip Maj
>
> For details: https://code.google.com/p/android/issues/detail?id=235461
> A workaround is to change the current working directory to the directory 
> housing the {{emulator}} binary. E.g.:
> {noformat}
> ~ via ⬢ v6.9.4
> ➔ which emulator
> /Users/maj/sdks/android/tools/emulator
> ~ via ⬢ v6.9.4
> ➔ emulator -avd nexus5-5.1
> [140736778830784]:ERROR:./android/qt/qt_setup.cpp:28:Qt library not found at 
> ../emulator/lib64/qt/lib
> Could not launch '../emulator/qemu/darwin-x86_64/qemu-system-x86_64': No such 
> file or directory
> ~ via ⬢ v6.9.4
> ➔ cd ~/sdks/android/tools
> sdks/android/tools via ⬢ v6.9.4
> ➔ ./emulator -avd nexus5-5.1
> emulator: WARNING: encryption is off
> Hax is enabled
> Hax ram_size 0x8000
> HAX is working and emulator runs in fast virt mode.
> {noformat}
> Potential fix: tweak the {{cordova run --emulator}} command to change the 
> current working directory to be the location of the emulator binary. That 
> might be an easy fix, as cordova uses the {{superspawn}} node module to kick 
> off the {{emulator}} process. That module takes an optional {{cwd}} parameter.
> Let's also check for the existence of {{android}} vs. {{sdkmanager}} to fix 
> the listing of images based on SDK version.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12008) Discuss moving towards autosave by default for cordova@7

2017-03-16 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-12008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927647#comment-15927647
 ] 

ASF GitHub Bot commented on CB-12008:
-

Github user stevengill commented on the issue:

https://github.com/apache/cordova-cli/pull/266
  
Your cordova-cli PRs are ready to rebase now :)


> Discuss moving towards autosave by default for cordova@7
> 
>
> Key: CB-12008
> URL: https://issues.apache.org/jira/browse/CB-12008
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaLib
>Reporter: Steve Gill
>Assignee: Audrey So
>  Labels: cordova-7.0.0
> Fix For: 7.0.0
>
>
> Need to create a discuss thread about this. Our analytics show --save usage 
> is pretty low (presumably due to people not knowing about it). 
> It might be time to consider saving by default and having a --no-save flag to 
> not save. 
> We can also have global config to turn auto-save off for cordova 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11346) Remove known platforms check for Platform API

2017-03-16 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927641#comment-15927641
 ] 

ASF subversion and git services commented on CB-11346:
--

Commit 92eb5858ea9681c5558bfa786dd536f406ead8e1 in cordova-cli's branch 
refs/heads/master from [~purplecabbage]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=92eb585 ]

CB-11346: Removed check for 'known' platforms, code cleanup, clarity, refactored

 This closes #270


> Remove known platforms check for Platform API
> -
>
> Key: CB-11346
> URL: https://issues.apache.org/jira/browse/CB-11346
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaLib
>Reporter: Shazron Abdullah
>Assignee: Jesse MacFadyen
>  Labels: cordova-7.0.0
>
> https://github.com/apache/cordova-lib/blob/61f584de5891c52431e40a2dd534ac24cc081fcb/cordova-lib/src/platforms/PlatformApiPoly.js#L58-L59
> So that users can install any "platform".



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11346) Remove known platforms check for Platform API

2017-03-16 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927642#comment-15927642
 ] 

ASF GitHub Bot commented on CB-11346:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-cli/pull/270


> Remove known platforms check for Platform API
> -
>
> Key: CB-11346
> URL: https://issues.apache.org/jira/browse/CB-11346
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaLib
>Reporter: Shazron Abdullah
>Assignee: Jesse MacFadyen
>  Labels: cordova-7.0.0
>
> https://github.com/apache/cordova-lib/blob/61f584de5891c52431e40a2dd534ac24cc081fcb/cordova-lib/src/platforms/PlatformApiPoly.js#L58-L59
> So that users can install any "platform".



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11346) Remove known platforms check for Platform API

2017-03-16 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-11346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927636#comment-15927636
 ] 

ASF GitHub Bot commented on CB-11346:
-

GitHub user stevengill opened a pull request:

https://github.com/apache/cordova-lib/pull/529

CB-11346 Remove known platforms check

Building on top of the work by @purplecabbage and @shazron.

Still need to fix failing tests + add some new tests.

Also, need to run through plugin install steps.

work in progress



### Platforms affected


### What does this PR do?


### What testing has been done on this change?


### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stevengill/cordova-lib master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/529.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #529


commit 3a810d1887bc488e8e9e9dfacdc6e86a80b4b318
Author: Shazron Abdullah 
Date:   2017-02-21T01:47:14Z

CB-11346 - Remove known platforms check for Platform API

commit faf54779fd6e02f23d2a302629599e578fd5d02a
Author: Jesse MacFadyen 
Date:   2017-02-28T00:13:43Z

CB-11346: Remove known platforms check

This closes #523, This closes #519

commit 5a5d02898dc3286c8494c5986edf0e5f439d8215
Author: Steve Gill 
Date:   2017-03-11T00:43:56Z

CB-11346: fixed remove platform to work with unknown platforms




> Remove known platforms check for Platform API
> -
>
> Key: CB-11346
> URL: https://issues.apache.org/jira/browse/CB-11346
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: CordovaLib
>Reporter: Shazron Abdullah
>Assignee: Jesse MacFadyen
>  Labels: cordova-7.0.0
>
> https://github.com/apache/cordova-lib/blob/61f584de5891c52431e40a2dd534ac24cc081fcb/cordova-lib/src/platforms/PlatformApiPoly.js#L58-L59
> So that users can install any "platform".



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

37 matches

Mail list logo