[
https://issues.apache.org/jira/browse/CB-11346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15927636#comment-15927636
]
ASF GitHub Bot commented on CB-11346:
-------------------------------------
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-lib/pull/529
CB-11346 Remove known platforms check
Building on top of the work by @purplecabbage and @shazron.
Still need to fix failing tests + add some new tests.
Also, need to run through plugin install steps.
work in progress
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### What does this PR do?
### What testing has been done on this change?
### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-lib master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/529.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #529
----
commit 3a810d1887bc488e8e9e9dfacdc6e86a80b4b318
Author: Shazron Abdullah <[email protected]>
Date: 2017-02-21T01:47:14Z
CB-11346 - Remove known platforms check for Platform API
commit faf54779fd6e02f23d2a302629599e578fd5d02a
Author: Jesse MacFadyen <[email protected]>
Date: 2017-02-28T00:13:43Z
CB-11346: Remove known platforms check
This closes #523, This closes #519
commit 5a5d02898dc3286c8494c5986edf0e5f439d8215
Author: Steve Gill <[email protected]>
Date: 2017-03-11T00:43:56Z
CB-11346: fixed remove platform to work with unknown platforms
----
> Remove known platforms check for Platform API
> ---------------------------------------------
>
> Key: CB-11346
> URL: https://issues.apache.org/jira/browse/CB-11346
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CordovaLib
> Reporter: Shazron Abdullah
> Assignee: Jesse MacFadyen
> Labels: cordova-7.0.0
>
> https://github.com/apache/cordova-lib/blob/61f584de5891c52431e40a2dd534ac24cc081fcb/cordova-lib/src/platforms/PlatformApiPoly.js#L58-L59
> So that users can install any "platform".
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
