[jira] [Commented] (CB-13289) Gradle/Android Plugin DSL change breaks including CordovaLib
[ https://issues.apache.org/jira/browse/CB-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219837#comment-16219837 ] ASF GitHub Bot commented on CB-13289: - macdonst commented on issue #413: CB-13289: This fixes the Cordova-Android build on cordova-android 6.x URL: https://github.com/apache/cordova-android/pull/413#issuecomment-339525427 @infil00p looks good to me. Haven't upgraded to Android Studio 3.0.0 though. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Gradle/Android Plugin DSL change breaks including CordovaLib > > > Key: CB-13289 > URL: https://issues.apache.org/jira/browse/CB-13289 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: 6.2.1 >Reporter: Joe Bowser >Assignee: Joe Bowser >Priority: Blocker > Labels: android-next > Fix For: 7.0.0 > > > Android Studio 3.0.0 uses a new DSL, and this breaks the dependency list. > This directly affects Cordova plugins that work as a Library Module, as well > as adding and removing the Android platform. Basically, once Android Studio > 3.0 updates, Cordova projects will not work properly with the new version of > Android Studio once they're updated. > This depends on CB-11244 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13289) Gradle/Android Plugin DSL change breaks including CordovaLib
[ https://issues.apache.org/jira/browse/CB-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219787#comment-16219787 ] ASF GitHub Bot commented on CB-13289: - codecov-io commented on issue #413: CB-13289: This fixes the Cordova-Android build on cordova-android 6.x URL: https://github.com/apache/cordova-android/pull/413#issuecomment-339514900 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/413?src=pr=h1) Report > Merging [#413](https://codecov.io/gh/apache/cordova-android/pull/413?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/93efe71080d065e2cf86c9324e9ef0cdf032e88c?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/cordova-android/pull/413?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #413 +/- ## === Coverage 43.77% 43.77% === Files 17 17 Lines1688 1688 Branches 307 307 === Hits 739 739 Misses949 949 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/413?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/413?src=pr=footer). Last update [93efe71...d73108c](https://codecov.io/gh/apache/cordova-android/pull/413?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Gradle/Android Plugin DSL change breaks including CordovaLib > > > Key: CB-13289 > URL: https://issues.apache.org/jira/browse/CB-13289 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: 6.2.1 >Reporter: Joe Bowser >Assignee: Joe Bowser >Priority: Blocker > Labels: android-next > Fix For: 7.0.0 > > > Android Studio 3.0.0 uses a new DSL, and this breaks the dependency list. > This directly affects Cordova plugins that work as a Library Module, as well > as adding and removing the Android platform. Basically, once Android Studio > 3.0 updates, Cordova projects will not work properly with the new version of > Android Studio once they're updated. > This depends on CB-11244 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13289) Gradle/Android Plugin DSL change breaks including CordovaLib
[ https://issues.apache.org/jira/browse/CB-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219782#comment-16219782 ] ASF GitHub Bot commented on CB-13289: - infil00p opened a new pull request #413: CB-13289: This fixes the Cordova-Android build on cordova-android 6.x URL: https://github.com/apache/cordova-android/pull/413 ### Platforms affected Android ### What does this PR do? Fixes build errors caused by the installation/update of the latest Android Studio ### What testing has been done on this change? ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Gradle/Android Plugin DSL change breaks including CordovaLib > > > Key: CB-13289 > URL: https://issues.apache.org/jira/browse/CB-13289 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: 6.2.1 >Reporter: Joe Bowser >Assignee: Joe Bowser >Priority: Blocker > Labels: android-next > Fix For: 7.0.0 > > > Android Studio 3.0.0 uses a new DSL, and this breaks the dependency list. > This directly affects Cordova plugins that work as a Library Module, as well > as adding and removing the Android platform. Basically, once Android Studio > 3.0 updates, Cordova projects will not work properly with the new version of > Android Studio once they're updated. > This depends on CB-11244 -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13495) Android Studio 3.0 removes the execute permission from Gradle, breaking the build
Joe Bowser created CB-13495: --- Summary: Android Studio 3.0 removes the execute permission from Gradle, breaking the build Key: CB-13495 URL: https://issues.apache.org/jira/browse/CB-13495 Project: Apache Cordova Issue Type: Bug Affects Versions: 6.3.0 Reporter: Joe Bowser Priority: Blocker Fix For: 6.4.0 Because of the ASF policy against bundling JARs, currently Cordova-Android uses a blank gradle file called wrapper.gradle and the Gradle that gets installed with Android Studio to install Gradle Wrapper on cordova projects. However, Google has recently changed the permissions on Androdi Studio 3.0 so that you can no longer use their bundled Gradle to to do this, which now breaks the build. We may now have to add Gradle as a dependency for cordova-android and we may have to increment the version to 7.0 because of this major breaking change. Unfortunately, that means that the work planned for 7.0 is now going to be in 8.0, so there may be two major version bumps this year, which will be problematic. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13191) iOS: Missing icons in Images.xcassets
[ https://issues.apache.org/jira/browse/CB-13191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219756#comment-16219756 ] ASF GitHub Bot commented on CB-13191: - ThorvaldAagaard commented on issue #337: CB-13191: (ios) Support marketing icon URL: https://github.com/apache/cordova-ios/pull/337#issuecomment-339509057 I am on the bleeding edge of all version now (And it wasn't easy)   I can see that Ionic cordova resources generates the following images  But neither of these have the sizes mentioned in the warnings  I can see that Appicon.appicons is created during build, but I have no clue, how the process from the above files to the AppIcon.appicons are. To mee it looks like that if it doesnt fint one with the right dimensions the it creates (or copy) one with size 96*96 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > iOS: Missing icons in Images.xcassets > - > > Key: CB-13191 > URL: https://issues.apache.org/jira/browse/CB-13191 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Reporter: Tim Brust >Assignee: Suraj Pindoria > Labels: backlog, ios-next > Fix For: cordova-ios@4.5.1 > > Attachments: missing_icons_ios.png, missing_icons_watchos.png > > > There are some missing icons when the generated Xcode project is opened. > I believe this is the place where Images.xcassets are created: > https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/lib/prepare.js#L312 > and a reference commit for iOS 9 update: > https://github.com/apache/cordova-ios/commit/d0521fe28d3c20054908d229298ba9ced1033c92 > The updated links from Apple regarding App Icon sizes and images can be found > here: > https://developer.apple.com/ios/human-interface-guidelines/graphics/app-icon/ > https://developer.apple.com/watchos/human-interface-guidelines/icons-and-images/ > (should be changed in the code comment) > See attached screenshot from Xcode Version 9.0 beta 5 (9M202q) > h4. *List of missing icons* > *iOS* > -App icons:- > -1024x1024 (@1) for the App Store - new/added in Xcode 9 and iOS- (fixed via > PR #337) > Notifications: > iPhone Notification iOS 7 - 11 (20x20 @2 and @3) > iPad Notification iOS 7 - 11 (20x20 @1 and @2) > *watchOS* > There are currently *no* Apple Watch Icons at all: > App icon: > Apple Watch Companion Settings (29x29 @2 and @3) > Home screen icon: > Apple Watch Home Screen (all) (40x40 @2) > Notification: > Apple Watch Notification Center 38mm (24x24 @2) > Apple Watch Notification Center 42mm (27.5x27.5 @2) > Look icons (see here: > https://developer.apple.com/watchos/human-interface-guidelines/app-components) > Short look icons > Apple Watch Short Look 38mm (86x86 @2) > Apple Watch Short Look 42mm (98x98 @2) > Long look icons > Apple Watch Long Look 38mm (40x40 @2) > Apple Watch Long Look 42mm (44x44 @2) > App Store > Apple Watch App Store (1024x1024 @1) -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12774) cordova plugin add doesn't support npm scope
[
https://issues.apache.org/jira/browse/CB-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219735#comment-16219735
]
ASF GitHub Bot commented on CB-12774:
-
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/602#discussion_r147014589
--- Diff: src/cordova/util.js ---
@@ -255,11 +255,20 @@ function findPlugins (pluginDir) {
var plugins = [];
if (fs.existsSync(pluginDir)) {
-plugins = fs.readdirSync(pluginDir).filter(function (fileName) {
-var pluginPath = path.join(pluginDir, fileName);
-var isPlugin = isDirectory(pluginPath) ||
isSymbolicLink(pluginPath);
-return fileName !== '.svn' && fileName !== 'CVS' && isPlugin;
-});
+plugins = fs.readdirSync(pluginDir)
+.reduce(function (plugins, pluginOrScope) {
+if (pluginOrScope[0] === '@') {
+plugins.push(...fs.readdirSync(path.join(pluginDir,
pluginOrScope)).map(s => path.join(pluginOrScope, s)));
--- End diff --
Thanks for your question! We are sticking to the current style for now. We
need to have a discussion on our mailing list about starting to use es2015
features/ which ones to use and get some consensus.
> cordova plugin add doesn't support npm scope
>
>
> Key: CB-12774
> URL: https://issues.apache.org/jira/browse/CB-12774
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-fetch
>Affects Versions: 1.1.0
>Reporter: Enrico Mazzucchelli
> Labels: cordova-8.0.0
> Fix For: 1.1.1
>
>
> STEP TO REPRODUCE:
> 1) setup a private repo (for example sinopia with docker:
> https://github.com/kfatehi/docker-sinopia)
> 2) add scope in your npm config: npm config set @myco:registry
> http://0.0.0.0:4873/
> 3) create you plugin. In package.json set name: @myco/my.co.plugin.demo; in
> plugin.xml set plugin id: @myco/my.co.plugin.demo.
> 3) publish plugin in your private repo:
> - npm set registry http://0.0.0.0:4873
> - npm publish
>- npm set registry https://registry.npmjs.org/
> 4) in your cordova project dir, exec:
> cordova plugin add @myco/my.co.plugin.demo
> EXPECTED BEHAVIOR:
> cordova plugin are installed
> ACTUAL BEHAVIOR:
> cordova installation failed:
> Error: Failed to fetch plugin my.co.plugin.demo via registry.
> Probably this is either a connection problem, or plugin spec is incorrect.
> Check your connection and plugin name/version/URL.
> Error: npm: Command failed with exit code 1 Error output:
> npm ERR! code E404
> npm ERR! 404 Registry returned 404 for GET on
> https://registry.npmjs.org/my.co.plugin.demo
> npm ERR! 404
> npm ERR! 404 'com.vipera.de.foundation.commons' is not in the npm registry.
> npm ERR! 404 You should bug the author to publish it (or use the name
> yourself!)
> npm ERR! 404
> npm ERR! 404 Note that you can also install from a
> npm ERR! 404 tarball, folder, http url, or git url.
> However node module are correctly installed (verified with npm ls) and
> fetch.json have a new entry with key
> @my.co.plugin.demo.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12774) cordova plugin add doesn't support npm scope
[
https://issues.apache.org/jira/browse/CB-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219721#comment-16219721
]
ASF GitHub Bot commented on CB-12774:
-
Github user akdor1154 commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/602#discussion_r147012928
--- Diff: src/cordova/util.js ---
@@ -255,11 +255,20 @@ function findPlugins (pluginDir) {
var plugins = [];
if (fs.existsSync(pluginDir)) {
-plugins = fs.readdirSync(pluginDir).filter(function (fileName) {
-var pluginPath = path.join(pluginDir, fileName);
-var isPlugin = isDirectory(pluginPath) ||
isSymbolicLink(pluginPath);
-return fileName !== '.svn' && fileName !== 'CVS' && isPlugin;
-});
+plugins = fs.readdirSync(pluginDir)
+.reduce(function (plugins, pluginOrScope) {
+if (pluginOrScope[0] === '@') {
+plugins.push(...fs.readdirSync(path.join(pluginDir,
pluginOrScope)).map(s => path.join(pluginOrScope, s)));
--- End diff --
yup just started looking at the failed test :) While you're here and kind
of related, I noticed most of the Cordova codebase avoids `() => arrow
functions`. Is this just historical? I have used full `function () { }` when
I've paid attention just to match code style, but is this necessary?
> cordova plugin add doesn't support npm scope
>
>
> Key: CB-12774
> URL: https://issues.apache.org/jira/browse/CB-12774
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-fetch
>Affects Versions: 1.1.0
>Reporter: Enrico Mazzucchelli
> Labels: cordova-8.0.0
> Fix For: 1.1.1
>
>
> STEP TO REPRODUCE:
> 1) setup a private repo (for example sinopia with docker:
> https://github.com/kfatehi/docker-sinopia)
> 2) add scope in your npm config: npm config set @myco:registry
> http://0.0.0.0:4873/
> 3) create you plugin. In package.json set name: @myco/my.co.plugin.demo; in
> plugin.xml set plugin id: @myco/my.co.plugin.demo.
> 3) publish plugin in your private repo:
> - npm set registry http://0.0.0.0:4873
> - npm publish
>- npm set registry https://registry.npmjs.org/
> 4) in your cordova project dir, exec:
> cordova plugin add @myco/my.co.plugin.demo
> EXPECTED BEHAVIOR:
> cordova plugin are installed
> ACTUAL BEHAVIOR:
> cordova installation failed:
> Error: Failed to fetch plugin my.co.plugin.demo via registry.
> Probably this is either a connection problem, or plugin spec is incorrect.
> Check your connection and plugin name/version/URL.
> Error: npm: Command failed with exit code 1 Error output:
> npm ERR! code E404
> npm ERR! 404 Registry returned 404 for GET on
> https://registry.npmjs.org/my.co.plugin.demo
> npm ERR! 404
> npm ERR! 404 'com.vipera.de.foundation.commons' is not in the npm registry.
> npm ERR! 404 You should bug the author to publish it (or use the name
> yourself!)
> npm ERR! 404
> npm ERR! 404 Note that you can also install from a
> npm ERR! 404 tarball, folder, http url, or git url.
> However node module are correctly installed (verified with npm ls) and
> fetch.json have a new entry with key
> @my.co.plugin.demo.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12774) cordova plugin add doesn't support npm scope
[
https://issues.apache.org/jira/browse/CB-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219719#comment-16219719
]
ASF GitHub Bot commented on CB-12774:
-
Github user audreyso commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/602#discussion_r147012615
--- Diff: src/cordova/util.js ---
@@ -255,11 +255,20 @@ function findPlugins (pluginDir) {
var plugins = [];
if (fs.existsSync(pluginDir)) {
-plugins = fs.readdirSync(pluginDir).filter(function (fileName) {
-var pluginPath = path.join(pluginDir, fileName);
-var isPlugin = isDirectory(pluginPath) ||
isSymbolicLink(pluginPath);
-return fileName !== '.svn' && fileName !== 'CVS' && isPlugin;
-});
+plugins = fs.readdirSync(pluginDir)
+.reduce(function (plugins, pluginOrScope) {
+if (pluginOrScope[0] === '@') {
+plugins.push(...fs.readdirSync(path.join(pluginDir,
pluginOrScope)).map(s => path.join(pluginOrScope, s)));
--- End diff --
Hi! This line will need to be changed as it will not work with Node 4,
which is still currently supported.
http://node.green/#ES2015-syntax-spread---operator-with-generic-iterables--in-calls
> cordova plugin add doesn't support npm scope
>
>
> Key: CB-12774
> URL: https://issues.apache.org/jira/browse/CB-12774
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-fetch
>Affects Versions: 1.1.0
>Reporter: Enrico Mazzucchelli
> Labels: cordova-8.0.0
> Fix For: 1.1.1
>
>
> STEP TO REPRODUCE:
> 1) setup a private repo (for example sinopia with docker:
> https://github.com/kfatehi/docker-sinopia)
> 2) add scope in your npm config: npm config set @myco:registry
> http://0.0.0.0:4873/
> 3) create you plugin. In package.json set name: @myco/my.co.plugin.demo; in
> plugin.xml set plugin id: @myco/my.co.plugin.demo.
> 3) publish plugin in your private repo:
> - npm set registry http://0.0.0.0:4873
> - npm publish
>- npm set registry https://registry.npmjs.org/
> 4) in your cordova project dir, exec:
> cordova plugin add @myco/my.co.plugin.demo
> EXPECTED BEHAVIOR:
> cordova plugin are installed
> ACTUAL BEHAVIOR:
> cordova installation failed:
> Error: Failed to fetch plugin my.co.plugin.demo via registry.
> Probably this is either a connection problem, or plugin spec is incorrect.
> Check your connection and plugin name/version/URL.
> Error: npm: Command failed with exit code 1 Error output:
> npm ERR! code E404
> npm ERR! 404 Registry returned 404 for GET on
> https://registry.npmjs.org/my.co.plugin.demo
> npm ERR! 404
> npm ERR! 404 'com.vipera.de.foundation.commons' is not in the npm registry.
> npm ERR! 404 You should bug the author to publish it (or use the name
> yourself!)
> npm ERR! 404
> npm ERR! 404 Note that you can also install from a
> npm ERR! 404 tarball, folder, http url, or git url.
> However node module are correctly installed (verified with npm ls) and
> fetch.json have a new entry with key
> @my.co.plugin.demo.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13493) Cordova-iOS Platform Release October 25, 2017
[ https://issues.apache.org/jira/browse/CB-13493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219650#comment-16219650 ] ASF subversion and git services commented on CB-13493: -- Commit 4466f480d3d8e3099d6d587b558cc9f7dac3c04c in cordova-ios's branch refs/heads/master from [~surajpindoria] [ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=4466f48 ] CB-13493 Updated checked-in node_modules > Cordova-iOS Platform Release October 25, 2017 > - > > Key: CB-13493 > URL: https://issues.apache.org/jira/browse/CB-13493 > Project: Apache Cordova > Issue Type: Task >Reporter: Suraj Pindoria >Assignee: Suraj Pindoria > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13493) Cordova-iOS Platform Release October 25, 2017
[ https://issues.apache.org/jira/browse/CB-13493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219653#comment-16219653 ] ASF subversion and git services commented on CB-13493: -- Commit 8d871012b1a89ec8cbf27c8f1fc7680d46a8b921 in cordova-ios's branch refs/heads/4.5.x from [~surajpindoria] [ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=8d87101 ] CB-13493 Updated checked-in node_modules > Cordova-iOS Platform Release October 25, 2017 > - > > Key: CB-13493 > URL: https://issues.apache.org/jira/browse/CB-13493 > Project: Apache Cordova > Issue Type: Task >Reporter: Suraj Pindoria >Assignee: Suraj Pindoria > > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13290) SplashScreen dont handle iPhone X asset catalog image
[ https://issues.apache.org/jira/browse/CB-13290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219652#comment-16219652 ] ASF subversion and git services commented on CB-13290: -- Commit 985aa4d6bad0ba511d8d488b3df5763c37e0dd96 in cordova-ios's branch refs/heads/4.5.x from [~surajpindoria] [ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=985aa4d ] CB-13290: (ios) Update splash screen mapping for missing devices > SplashScreen dont handle iPhone X asset catalog image > - > > Key: CB-13290 > URL: https://issues.apache.org/jira/browse/CB-13290 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-splashscreen >Affects Versions: cordova-ios 4.5.0 >Reporter: Stefano Boeri > > I've digged into source code but i dont see anything related to iPhone X. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13454) Icon 40x40@2x is not copied
[
https://issues.apache.org/jira/browse/CB-13454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219651#comment-16219651
]
ASF subversion and git services commented on CB-13454:
--
Commit e8b997098df1a397dabc855b6efeeeb203bca86f in cordova-ios's branch
refs/heads/4.5.x from [~surajpindoria]
[ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=e8b9970 ]
CB-13454: (ios) re-add icon...@2x.png that was accidentally removed
> Icon 40x40@2x is not copied
> ---
>
> Key: CB-13454
> URL: https://issues.apache.org/jira/browse/CB-13454
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
>Reporter: Thomas Brian
>Assignee: Suraj Pindoria
>
> Hi,
> The 40...@2x.png icon (80x80) is no longer copied in cordova-ios 4.5.2.
> This is a regression from version 4.5.1.
> The commit that introduced the bug is this one
> https://github.com/apache/cordova-ios/pull/341/commits/7b7964f349276ac3f3452e2dad817dfdadca29b3
>
> The file names in prepare.js were re-ordered but the line {dest:
> 'icon...@2x.png', width: 80, height: 80} got deleted by mistake.
> Have a nice day,
> Thomas
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13492) Pass in the nosave flag to cordova-fetch & update uninstall to include nosave flag
[ https://issues.apache.org/jira/browse/CB-13492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So updated CB-13492: --- Summary: Pass in the nosave flag to cordova-fetch & update uninstall to include nosave flag (was: Pass in the nosave flag to cordova-fetch & update rm to include nosave flag) > Pass in the nosave flag to cordova-fetch & update uninstall to include nosave > flag > -- > > Key: CB-13492 > URL: https://issues.apache.org/jira/browse/CB-13492 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-fetch >Affects Versions: cordova@7.1.0 >Reporter: Audrey So >Assignee: Audrey So >Priority: Minor > > Make sure that the -nosave flag is passed in via cordova-fetch (when save is > false) -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13492) Pass in the nosave flag to cordova-fetch & update uninstall to include nosave flag
[ https://issues.apache.org/jira/browse/CB-13492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So updated CB-13492: --- Description: Make sure that the -nosave flag is passed in via cordova-fetch (when save is false) Add unit-test was:Make sure that the -nosave flag is passed in via cordova-fetch (when save is false) > Pass in the nosave flag to cordova-fetch & update uninstall to include nosave > flag > -- > > Key: CB-13492 > URL: https://issues.apache.org/jira/browse/CB-13492 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-fetch >Affects Versions: cordova@7.1.0 >Reporter: Audrey So >Assignee: Audrey So >Priority: Minor > > Make sure that the -nosave flag is passed in via cordova-fetch (when save is > false) > Add unit-test -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13494) cordova-js node_modules is getting removed when running some commands using npm@5
Suraj Pindoria created CB-13494: --- Summary: cordova-js node_modules is getting removed when running some commands using npm@5 Key: CB-13494 URL: https://issues.apache.org/jira/browse/CB-13494 Project: Apache Cordova Issue Type: Bug Components: cordova-coho Reporter: Suraj Pindoria This only seems to be an issue when using npm@5. While going through the platform release process, I was attempting to run "coho prepare-platform-release-branch ...", but it kept failing with an error saying it can't find local grunt. After inspecting the cordova-js directory was able to see that node_modules/ was no longer there, even after explicitly running "npm install". After downgrading to npm@4 and running prepare-platform-release-branch it successfully completed. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13492) Pass in the nosave flag to cordova-fetch & update rm to include nosave flag
[ https://issues.apache.org/jira/browse/CB-13492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Audrey So updated CB-13492: --- Summary: Pass in the nosave flag to cordova-fetch & update rm to include nosave flag (was: Pass in the nosave flag to cordova-fetch) > Pass in the nosave flag to cordova-fetch & update rm to include nosave flag > --- > > Key: CB-13492 > URL: https://issues.apache.org/jira/browse/CB-13492 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-fetch >Affects Versions: cordova@7.1.0 >Reporter: Audrey So >Assignee: Audrey So >Priority: Minor > > Make sure that the -nosave flag is passed in via cordova-fetch (when save is > false) -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13191) iOS: Missing icons in Images.xcassets
[ https://issues.apache.org/jira/browse/CB-13191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219551#comment-16219551 ] ASF GitHub Bot commented on CB-13191: - surajpindoria commented on issue #337: CB-13191: (ios) Support marketing icon URL: https://github.com/apache/cordova-ios/pull/337#issuecomment-339477342 @ThorvaldAagaard Just spoke with someone from Ionic and he said that this command should properly resize the images. He suggested updating to the latest, `npm install -g ionic@latest`, because they recently added fixes for the new icon sizes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > iOS: Missing icons in Images.xcassets > - > > Key: CB-13191 > URL: https://issues.apache.org/jira/browse/CB-13191 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Reporter: Tim Brust >Assignee: Suraj Pindoria > Labels: backlog, ios-next > Fix For: cordova-ios@4.5.1 > > Attachments: missing_icons_ios.png, missing_icons_watchos.png > > > There are some missing icons when the generated Xcode project is opened. > I believe this is the place where Images.xcassets are created: > https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/lib/prepare.js#L312 > and a reference commit for iOS 9 update: > https://github.com/apache/cordova-ios/commit/d0521fe28d3c20054908d229298ba9ced1033c92 > The updated links from Apple regarding App Icon sizes and images can be found > here: > https://developer.apple.com/ios/human-interface-guidelines/graphics/app-icon/ > https://developer.apple.com/watchos/human-interface-guidelines/icons-and-images/ > (should be changed in the code comment) > See attached screenshot from Xcode Version 9.0 beta 5 (9M202q) > h4. *List of missing icons* > *iOS* > -App icons:- > -1024x1024 (@1) for the App Store - new/added in Xcode 9 and iOS- (fixed via > PR #337) > Notifications: > iPhone Notification iOS 7 - 11 (20x20 @2 and @3) > iPad Notification iOS 7 - 11 (20x20 @1 and @2) > *watchOS* > There are currently *no* Apple Watch Icons at all: > App icon: > Apple Watch Companion Settings (29x29 @2 and @3) > Home screen icon: > Apple Watch Home Screen (all) (40x40 @2) > Notification: > Apple Watch Notification Center 38mm (24x24 @2) > Apple Watch Notification Center 42mm (27.5x27.5 @2) > Look icons (see here: > https://developer.apple.com/watchos/human-interface-guidelines/app-components) > Short look icons > Apple Watch Short Look 38mm (86x86 @2) > Apple Watch Short Look 42mm (98x98 @2) > Long look icons > Apple Watch Long Look 38mm (40x40 @2) > Apple Watch Long Look 42mm (44x44 @2) > App Store > Apple Watch App Store (1024x1024 @1) -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13493) Cordova-iOS Platform Release October 25, 2017
Suraj Pindoria created CB-13493: --- Summary: Cordova-iOS Platform Release October 25, 2017 Key: CB-13493 URL: https://issues.apache.org/jira/browse/CB-13493 Project: Apache Cordova Issue Type: Task Reporter: Suraj Pindoria Assignee: Suraj Pindoria Following steps at https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-13290) SplashScreen dont handle iPhone X asset catalog image
[ https://issues.apache.org/jira/browse/CB-13290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Pindoria closed CB-13290. --- Resolution: Fixed > SplashScreen dont handle iPhone X asset catalog image > - > > Key: CB-13290 > URL: https://issues.apache.org/jira/browse/CB-13290 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-splashscreen >Affects Versions: cordova-ios 4.5.0 >Reporter: Stefano Boeri > > I've digged into source code but i dont see anything related to iPhone X. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13290) SplashScreen dont handle iPhone X asset catalog image
[ https://issues.apache.org/jira/browse/CB-13290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219489#comment-16219489 ] ASF subversion and git services commented on CB-13290: -- Commit c17f2577b00fbbb9542a4df1d621b29d0313a933 in cordova-ios's branch refs/heads/master from [~surajpindoria] [ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=c17f257 ] Merge pull request #344 from surajpindoria/splashScreens CB-13290: (ios) Update splash screen mapping for missing devices > SplashScreen dont handle iPhone X asset catalog image > - > > Key: CB-13290 > URL: https://issues.apache.org/jira/browse/CB-13290 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-splashscreen >Affects Versions: cordova-ios 4.5.0 >Reporter: Stefano Boeri > > I've digged into source code but i dont see anything related to iPhone X. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13290) SplashScreen dont handle iPhone X asset catalog image
[ https://issues.apache.org/jira/browse/CB-13290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219488#comment-16219488 ] ASF subversion and git services commented on CB-13290: -- Commit c3d24a9f02aa096c2b8951cc6980eefbbd26fd72 in cordova-ios's branch refs/heads/master from [~surajpindoria] [ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=c3d24a9 ] CB-13290: (ios) Update splash screen mapping for missing devices > SplashScreen dont handle iPhone X asset catalog image > - > > Key: CB-13290 > URL: https://issues.apache.org/jira/browse/CB-13290 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-splashscreen >Affects Versions: cordova-ios 4.5.0 >Reporter: Stefano Boeri > > I've digged into source code but i dont see anything related to iPhone X. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13290) SplashScreen dont handle iPhone X asset catalog image
[
https://issues.apache.org/jira/browse/CB-13290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219487#comment-16219487
]
ASF GitHub Bot commented on CB-13290:
-
surajpindoria closed pull request #344: CB-13290: (ios) Update splash screen
mapping for missing devices
URL: https://github.com/apache/cordova-ios/pull/344
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/bin/templates/project/__PROJECT_NAME__/Images.xcassets/LaunchImage.launchimage/Contents.json
b/bin/templates/project/__PROJECT_NAME__/Images.xcassets/LaunchImage.launchimage/Contents.json
index 175f378c6..58735deb7 100644
---
a/bin/templates/project/__PROJECT_NAME__/Images.xcassets/LaunchImage.launchimage/Contents.json
+++
b/bin/templates/project/__PROJECT_NAME__/Images.xcassets/LaunchImage.launchimage/Contents.json
@@ -1,6 +1,24 @@
{
"images" : [
{
+ "extent": "full-screen",
+ "idiom": "iphone",
+ "subtype": "2436h",
+ "filename": "Default-2436h.png",
+ "minimum-system-version": "11.0",
+ "orientation": "portrait",
+ "scale": "3x"
+},
+{
+ "extent": "full-screen",
+ "idiom": "iphone",
+ "subtype": "2436h",
+ "filename": "Default-Landscape-2436h.png",
+ "minimum-system-version": "11.0",
+ "orientation": "landscape",
+ "scale": "3x"
+},
+{
"extent" : "full-screen",
"idiom" : "iphone",
"subtype" : "736h",
@@ -120,6 +138,7 @@
{
"orientation" : "landscape",
"idiom" : "ipad",
+ "filename": "Default-Landscape~ipad.png",
"extent" : "full-screen",
"scale" : "1x"
},
@@ -145,6 +164,7 @@
{
"orientation" : "landscape",
"idiom" : "ipad",
+ "filename": "Default-Landscape@2x~ipad.png",
"extent" : "full-screen",
"scale" : "2x"
}
@@ -153,4 +173,4 @@
"version" : 1,
"author" : "xcode"
}
-}
\ No newline at end of file
+}
diff --git a/bin/templates/scripts/cordova/lib/prepare.js
b/bin/templates/scripts/cordova/lib/prepare.js
index 33f318b97..de345dd55 100644
--- a/bin/templates/scripts/cordova/lib/prepare.js
+++ b/bin/templates/scripts/cordova/lib/prepare.js
@@ -411,7 +411,9 @@ function mapSplashScreenResources (splashScreens,
splashScreensDir) {
{dest: 'Default-568h@2x~iphone.png', width: 640, height: 1136},
{dest: 'Default-667h.png', width: 750, height: 1334},
{dest: 'Default-736h.png', width: 1242, height: 2208},
-{dest: 'Default-Landscape-736h.png', width: 2208, height: 1242}
+{dest: 'Default-Landscape-736h.png', width: 2208, height: 1242},
+{dest: 'Default-2436h.png', width: 1125, height: 2436},
+{dest: 'Default-Landscape-2436h.png', width: 2436, height: 1125}
];
var pathMap = {};
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> SplashScreen dont handle iPhone X asset catalog image
> -
>
> Key: CB-13290
> URL: https://issues.apache.org/jira/browse/CB-13290
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-splashscreen
>Affects Versions: cordova-ios 4.5.0
>Reporter: Stefano Boeri
>
> I've digged into source code but i dont see anything related to iPhone X.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13492) Pass in the nosave flag to cordova-fetch
Audrey So created CB-13492: -- Summary: Pass in the nosave flag to cordova-fetch Key: CB-13492 URL: https://issues.apache.org/jira/browse/CB-13492 Project: Apache Cordova Issue Type: Improvement Components: cordova-fetch Affects Versions: cordova@7.1.0 Reporter: Audrey So Assignee: Audrey So Priority: Minor Make sure that the -nosave flag is passed in via cordova-fetch (when save is false) -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12886) white area where status bar is in iOS 11
[ https://issues.apache.org/jira/browse/CB-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219440#comment-16219440 ] Richard Kimber commented on CB-12886: - I've written up my own experience and workarounds, for this bug. Thank you to the various people on this thread that have pointed me in the right direction, with their comments. https://github.com/kim3er/ios11-scroll-offset > white area where status bar is in iOS 11 > > > Key: CB-12886 > URL: https://issues.apache.org/jira/browse/CB-12886 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios > Environment: iOS 11 beta 1 >Reporter: Shazron Abdullah > Labels: backlog, ios11 > Fix For: cordova-ios@5.0.0 > > Attachments: ios11.png, screenshot-1.png, screenshot-2.png > > > See attached screenshot. Using WKWebView plugin, new app. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13191) iOS: Missing icons in Images.xcassets
[ https://issues.apache.org/jira/browse/CB-13191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219431#comment-16219431 ] ASF GitHub Bot commented on CB-13191: - janpio commented on issue #337: CB-13191: (ios) Support marketing icon URL: https://github.com/apache/cordova-ios/pull/337#issuecomment-339453969 If that doesn't generate the sizes of the file that are expected by Xcode, this would be a bug on Ionic's site: `ionic cordova resources` uses a server side API. But your outdated `@ionic/app-scripts` might also play a role there. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > iOS: Missing icons in Images.xcassets > - > > Key: CB-13191 > URL: https://issues.apache.org/jira/browse/CB-13191 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Reporter: Tim Brust >Assignee: Suraj Pindoria > Labels: backlog, ios-next > Fix For: cordova-ios@4.5.1 > > Attachments: missing_icons_ios.png, missing_icons_watchos.png > > > There are some missing icons when the generated Xcode project is opened. > I believe this is the place where Images.xcassets are created: > https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/lib/prepare.js#L312 > and a reference commit for iOS 9 update: > https://github.com/apache/cordova-ios/commit/d0521fe28d3c20054908d229298ba9ced1033c92 > The updated links from Apple regarding App Icon sizes and images can be found > here: > https://developer.apple.com/ios/human-interface-guidelines/graphics/app-icon/ > https://developer.apple.com/watchos/human-interface-guidelines/icons-and-images/ > (should be changed in the code comment) > See attached screenshot from Xcode Version 9.0 beta 5 (9M202q) > h4. *List of missing icons* > *iOS* > -App icons:- > -1024x1024 (@1) for the App Store - new/added in Xcode 9 and iOS- (fixed via > PR #337) > Notifications: > iPhone Notification iOS 7 - 11 (20x20 @2 and @3) > iPad Notification iOS 7 - 11 (20x20 @1 and @2) > *watchOS* > There are currently *no* Apple Watch Icons at all: > App icon: > Apple Watch Companion Settings (29x29 @2 and @3) > Home screen icon: > Apple Watch Home Screen (all) (40x40 @2) > Notification: > Apple Watch Notification Center 38mm (24x24 @2) > Apple Watch Notification Center 42mm (27.5x27.5 @2) > Look icons (see here: > https://developer.apple.com/watchos/human-interface-guidelines/app-components) > Short look icons > Apple Watch Short Look 38mm (86x86 @2) > Apple Watch Short Look 42mm (98x98 @2) > Long look icons > Apple Watch Long Look 38mm (40x40 @2) > Apple Watch Long Look 42mm (44x44 @2) > App Store > Apple Watch App Store (1024x1024 @1) -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13191) iOS: Missing icons in Images.xcassets
[ https://issues.apache.org/jira/browse/CB-13191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219430#comment-16219430 ] ASF GitHub Bot commented on CB-13191: - janpio commented on issue #337: CB-13191: (ios) Support marketing icon URL: https://github.com/apache/cordova-ios/pull/337#issuecomment-339453969 If that doesn't generate the sizes of the file that are expected by Xcode, this would be a bug in Ionic's site. `ionic cordova resources` uses a server side API, but your outdated `@ionic/app-scripts` might also play a role there. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > iOS: Missing icons in Images.xcassets > - > > Key: CB-13191 > URL: https://issues.apache.org/jira/browse/CB-13191 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Reporter: Tim Brust >Assignee: Suraj Pindoria > Labels: backlog, ios-next > Fix For: cordova-ios@4.5.1 > > Attachments: missing_icons_ios.png, missing_icons_watchos.png > > > There are some missing icons when the generated Xcode project is opened. > I believe this is the place where Images.xcassets are created: > https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/lib/prepare.js#L312 > and a reference commit for iOS 9 update: > https://github.com/apache/cordova-ios/commit/d0521fe28d3c20054908d229298ba9ced1033c92 > The updated links from Apple regarding App Icon sizes and images can be found > here: > https://developer.apple.com/ios/human-interface-guidelines/graphics/app-icon/ > https://developer.apple.com/watchos/human-interface-guidelines/icons-and-images/ > (should be changed in the code comment) > See attached screenshot from Xcode Version 9.0 beta 5 (9M202q) > h4. *List of missing icons* > *iOS* > -App icons:- > -1024x1024 (@1) for the App Store - new/added in Xcode 9 and iOS- (fixed via > PR #337) > Notifications: > iPhone Notification iOS 7 - 11 (20x20 @2 and @3) > iPad Notification iOS 7 - 11 (20x20 @1 and @2) > *watchOS* > There are currently *no* Apple Watch Icons at all: > App icon: > Apple Watch Companion Settings (29x29 @2 and @3) > Home screen icon: > Apple Watch Home Screen (all) (40x40 @2) > Notification: > Apple Watch Notification Center 38mm (24x24 @2) > Apple Watch Notification Center 42mm (27.5x27.5 @2) > Look icons (see here: > https://developer.apple.com/watchos/human-interface-guidelines/app-components) > Short look icons > Apple Watch Short Look 38mm (86x86 @2) > Apple Watch Short Look 42mm (98x98 @2) > Long look icons > Apple Watch Long Look 38mm (40x40 @2) > Apple Watch Long Look 42mm (44x44 @2) > App Store > Apple Watch App Store (1024x1024 @1) -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13191) iOS: Missing icons in Images.xcassets
[ https://issues.apache.org/jira/browse/CB-13191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219407#comment-16219407 ] ASF GitHub Bot commented on CB-13191: - ThorvaldAagaard commented on issue #337: CB-13191: (ios) Support marketing icon URL: https://github.com/apache/cordova-ios/pull/337#issuecomment-339450679 I have just 2 images and then i run ionic cordova resources to get all images generated Isn't that ok? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > iOS: Missing icons in Images.xcassets > - > > Key: CB-13191 > URL: https://issues.apache.org/jira/browse/CB-13191 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Reporter: Tim Brust >Assignee: Suraj Pindoria > Labels: backlog, ios-next > Fix For: cordova-ios@4.5.1 > > Attachments: missing_icons_ios.png, missing_icons_watchos.png > > > There are some missing icons when the generated Xcode project is opened. > I believe this is the place where Images.xcassets are created: > https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/lib/prepare.js#L312 > and a reference commit for iOS 9 update: > https://github.com/apache/cordova-ios/commit/d0521fe28d3c20054908d229298ba9ced1033c92 > The updated links from Apple regarding App Icon sizes and images can be found > here: > https://developer.apple.com/ios/human-interface-guidelines/graphics/app-icon/ > https://developer.apple.com/watchos/human-interface-guidelines/icons-and-images/ > (should be changed in the code comment) > See attached screenshot from Xcode Version 9.0 beta 5 (9M202q) > h4. *List of missing icons* > *iOS* > -App icons:- > -1024x1024 (@1) for the App Store - new/added in Xcode 9 and iOS- (fixed via > PR #337) > Notifications: > iPhone Notification iOS 7 - 11 (20x20 @2 and @3) > iPad Notification iOS 7 - 11 (20x20 @1 and @2) > *watchOS* > There are currently *no* Apple Watch Icons at all: > App icon: > Apple Watch Companion Settings (29x29 @2 and @3) > Home screen icon: > Apple Watch Home Screen (all) (40x40 @2) > Notification: > Apple Watch Notification Center 38mm (24x24 @2) > Apple Watch Notification Center 42mm (27.5x27.5 @2) > Look icons (see here: > https://developer.apple.com/watchos/human-interface-guidelines/app-components) > Short look icons > Apple Watch Short Look 38mm (86x86 @2) > Apple Watch Short Look 42mm (98x98 @2) > Long look icons > Apple Watch Long Look 38mm (40x40 @2) > Apple Watch Long Look 42mm (44x44 @2) > App Store > Apple Watch App Store (1024x1024 @1) -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13491) NullPointerException in Splash Screen on Android
Carey Pfaff created CB-13491: Summary: NullPointerException in Splash Screen on Android Key: CB-13491 URL: https://issues.apache.org/jira/browse/CB-13491 Project: Apache Cordova Issue Type: Bug Components: cordova-plugin-splashscreen Environment: Being reported on multiple devices including: Moto G4 Play Galaxy S6 LG K20 Plus Galaxy S8+ Samsung Galaxy On5 LG K8 V LG K20 plus HTC ONE LG Aristo LG V20 Slate 8 LG X power Motorola DROID Turbo LG Stylo 2 LG K7 Moto E Being reported on multiple versions including: Android 7.1 Android 7.0 Android 6.0 Android 5.1 Reporter: Carey Pfaff Priority: Critical Multiple crash logs are being reported with the error below. The app is using cordova-plugin-splashscreen version 4.0.3. java.lang.NullPointerException: at org.apache.cordova.splashscreen.SplashScreen$4.run (SplashScreen.java:227) at android.app.Activity.runOnUiThread (Activity.java:5874) at org.apache.cordova.splashscreen.SplashScreen.removeSplashScreen (SplashScreen.java:217) at org.apache.cordova.splashscreen.SplashScreen.onMessage (SplashScreen.java:187) at org.apache.cordova.PluginManager.postMessage (PluginManager.java:312) at org.apache.cordova.CordovaWebViewImpl.postMessage (CordovaWebViewImpl.java:377) at org.apache.cordova.splashscreen.SplashScreen$2.run (SplashScreen.java:163) at android.os.Handler.handleCallback (Handler.java:751) at android.os.Handler.dispatchMessage (Handler.java:95) at android.os.Looper.loop (Looper.java:154) at android.app.ActivityThread.main (ActivityThread.java: 6165) at java.lang.reflect.Method.invoke (Native Method) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:888) at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:787) -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13490) bug with ionic cordova emulate android
gilles Godefroid created CB-13490: - Summary: bug with ionic cordova emulate android Key: CB-13490 URL: https://issues.apache.org/jira/browse/CB-13490 Project: Apache Cordova Issue Type: Bug Components: cordova-android Affects Versions: cordova@7.0.0 Environment: OS : macOS Sierra version 10.12.6 cli packages: (/usr/local/lib/node_modules) @ionic/cli-utils : 1.15.0 ionic (Ionic CLI) : 3.15.0 global packages: cordova (Cordova CLI) : 7.1.0 local packages: @ionic/app-scripts : 3.0.1 Cordova Platforms : android 6.3.0 ios 4.5.2 Ionic Framework: ionic-angular 3.7.1 System: ios-deploy : 1.9.2 ios-sim: 6.1.2 Node : v8.7.0 npm: 5.4.2 OS : macOS Sierra Xcode : Xcode 9.0.1 Build version 9A1004 Environment Variables: ANDROID_HOME : not set Misc: backend : pro Reporter: gilles Godefroid Assignee: Joe Bowser when I run ionic cordova emulate android I get this message : " Running app-scripts build: --platform android --target cordova [13:56:09] build dev started ... [13:56:09] clean started ... [13:56:09] clean finished in 3 ms [13:56:09] copy started ... [13:56:09] deeplinks started ... [13:56:09] deeplinks finished in 22 ms [13:56:09] transpile started ... [13:56:12] transpile finished in 2.54 s [13:56:12] preprocess started ... [13:56:12] preprocess finished in less than 1 ms [13:56:12] webpack started ... [13:56:12] copy finished in 2.70 s [13:56:19] webpack finished in 7.69 s [13:56:19] sass started ... [13:56:20] sass finished in 1.03 s [13:56:20] postprocess started ... [13:56:20] postprocess finished in 7 ms [13:56:20] lint started ... [13:56:20] build dev finished in 11.44 s > cordova emulate android ANDROID_HOME=/Users/gillesgodefroid/Library/Android/sdk JAVA_HOME=/Library/Java/JavaVirtualMachines/jdk1.8.0_91.jdk/Contents/Home Subproject Path: CordovaLib NDK is missing a "platforms" directory. If you are using NDK, verify the ndk.dir is set to a valid NDK directory. It is currently set to /Users/gillesgodefroid/Library/Android/sdk/ndk-bundle. If you are not using NDK, unset the NDK variable from ANDROID_NDK_HOME or local.properties to remove this warning. The Task.leftShift(Closure) method has been deprecated and is scheduled to be removed in Gradle 5.0. Please use Task.doLast(Action) instead. at build_8kqdndo9vqvve12axgld7tbu6.run(/Users/gillesgodefroid/Documents/Ionic2Do/platforms/android/build.gradle:141) [13:56:23] lint finished in 2.69 s NDK is missing a "platforms" directory. If you are using NDK, verify the ndk.dir is set to a valid NDK directory. It is currently set to /Users/gillesgodefroid/Library/Android/sdk/ndk-bundle. If you are not using NDK, unset the NDK variable from ANDROID_NDK_HOME or local.properties to remove this warning. Incremental java compilation is an incubating feature. :preBuild UP-TO-DATE :preDebugBuild UP-TO-DATE :checkDebugManifest :CordovaLib:preBuild UP-TO-DATE :CordovaLib:preDebugBuild UP-TO-DATE :CordovaLib:checkDebugManifest :CordovaLib:prepareDebugDependencies :CordovaLib:compileDebugAidl UP-TO-DATE :CordovaLib:compileDebugNdk UP-TO-DATE :CordovaLib:compileLint UP-TO-DATE :CordovaLib:copyDebugLint UP-TO-DATE :CordovaLib:mergeDebugShaders UP-TO-DATE :CordovaLib:compileDebugShaders UP-TO-DATE :CordovaLib:generateDebugAssets UP-TO-DATE :CordovaLib:mergeDebugAssets UP-TO-DATE :CordovaLib:mergeDebugProguardFiles UP-TO-DATE :CordovaLib:packageDebugRenderscript UP-TO-DATE :CordovaLib:compileDebugRenderscript UP-TO-DATE :CordovaLib:generateDebugResValues UP-TO-DATE :CordovaLib:generateDebugResources UP-TO-DATE :CordovaLib:packageDebugResources UP-TO-DATE :CordovaLib:processDebugManifest UP-TO-DATE :CordovaLib:generateDebugBuildConfig UP-TO-DATE :CordovaLib:processDebugResources UP-TO-DATE :CordovaLib:generateDebugSources UP-TO-DATE :CordovaLib:incrementalDebugJavaCompilationSafeguard UP-TO-DATE :CordovaLib:javaPreCompileDebug :CordovaLib:compileDebugJavaWithJavac UP-TO-DATE :CordovaLib:processDebugJavaRes UP-TO-DATE :CordovaLib:transformResourcesWithMergeJavaResForDebug UP-TO-DATE :CordovaLib:transformClassesAndResourcesWithSyncLibJarsForDebug UP-TO-DATE :CordovaLib:mergeDebugJniLibFolders UP-TO-DATE :CordovaLib:transformNativeLibsWithMergeJniLibsForDebug UP-TO-DATE :CordovaLib:transformNativeLibsWithSyncJniLibsForDebug UP-TO-DATE :CordovaLib:bundleDebug UP-TO-DATE :prepareDebugDependencies :compileDebugAidl UP-TO-DATE :compileDebugRenderscript UP-TO-DATE :generateDebugBuildConfig UP-TO-DATE :generateDebugResValues UP-TO-DATE :generateDebugResources UP-TO-DATE :mergeDebugResources UP-TO-DATE :processDebugManifest UP-TO-DATE :processDebugResources UP-TO-DATE
[jira] [Updated] (CB-12593) FileProvider conflict in the camera plugin
[
https://issues.apache.org/jira/browse/CB-12593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Bowser updated CB-12593:
Labels: android-next (was: )
> FileProvider conflict in the camera plugin
> --
>
> Key: CB-12593
> URL: https://issues.apache.org/jira/browse/CB-12593
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-camera
>Reporter: Connor Pearson
> Labels: android-next
>
> Version 2.3.1 of the camera plugin adds a FileProvider to the
> AndroidManifest. I already have a plugin that is doing this, so the duplicate
> entries cause a build error.
> {code}
> Element provider#android.support.v4.content.FileProvider at
> AndroidManifest.xml:19:9-21:20 duplicated with element declared at
> AndroidManifest.xml:16:9-18:20
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13423) The cameraDirection option does not work on Android
[ https://issues.apache.org/jira/browse/CB-13423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219217#comment-16219217 ] Scott S commented on CB-13423: -- I understand that it's documented, but that doesn't mean it's not still a bug. It looks like there was even a fix made for this that was never merged. Is there a reason for that? Here is the fix: https://github.com/apache/cordova-plugin-camera/pull/54 > The cameraDirection option does not work on Android > --- > > Key: CB-13423 > URL: https://issues.apache.org/jira/browse/CB-13423 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Reporter: Scott S > > It looks like the CameraLauncher class does not retrieve the passed > cameraDirection value from args. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13124) statusTap event is not triggered until momentum scrolling is complete
[ https://issues.apache.org/jira/browse/CB-13124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219192#comment-16219192 ] ASF GitHub Bot commented on CB-13124: - Github user lunaru commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/83 @jcesarmobile hey -- i haven't seen any updates on this. any concerns? It would be really nice to have this in the main branch. > statusTap event is not triggered until momentum scrolling is complete > - > > Key: CB-13124 > URL: https://issues.apache.org/jira/browse/CB-13124 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-statusbar >Affects Versions: cordova@7.0.0 >Reporter: Lu Wang >Priority: Minor > > The statusTap event isn't triggered until the momentum scrolling is complete. > To reproduce: > 1. Create an app that has a natural scrolling body (*not* 100% height div > with overflow-x set to "auto" and -webkit-overflow-scrolling set to "touch"). > This means a standard WebView with body contents larger than one screen. > 2. Flick the screen to scroll and notice that momentum/inertial scroll > triggers. > 3. During momentum scrolling, tap the status bar > 4. Note the statusTap event fired only after the scrolling has completely > stopped. > There isn't a great way to fix this since the events are triggered in > cordova.js with a setTimeout. I have a PR available to fix this by adding a > config option to StatusBar that enables the native scroll-to-top behavior. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-13463) No way to prevent package.json update with cordova commands even with --nosave
[
https://issues.apache.org/jira/browse/CB-13463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Audrey So reassigned CB-13463:
--
Assignee: Audrey So
> No way to prevent package.json update with cordova commands even with --nosave
> --
>
> Key: CB-13463
> URL: https://issues.apache.org/jira/browse/CB-13463
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-cli
>Affects Versions: cordova@7.0.0
>Reporter: Andrew Crites
>Assignee: Audrey So
> Labels: reproduced, triaged
>
> With Cordova 7, cordova commands including {{cordova platform add}} and
> {{cordova prepare}} will copy plugin information from {{config.xml}} to
> {{package.json}}.
> According to [the saving platforms
> documentation|https://cordova.apache.org/docs/en/latest/platform_plugin_versioning_ref/],
> using {{--nosave}} should prevent updating {{package.json}} or
> {{config.xml}}, but this does not work (i.e. using {{--nosave}} still seems
> to update the {{package.json}}.
> I want to avoid updating {{package.json}} specifically because there doesn't
> seem to be a way to avoid hard coding variables for plugins. An example is
> the cordova fabric plugin:
> {code}
>
>
>
>
> {code}
> Cordova doesn't seem to provide a way for you to parameterize variables in
> the configuration. To get around this, I have {{build.config.xml}} where they
> are parameterized, and {{config.xml}} is created at install-time and not
> version controlled. However, this would be much more difficult to do with
> {{package.json}} and is practically not an option.
> When running {{cordova platform add ios --nosave}} with the above plugin,
> cordova still updates {{package.json}} to include the fabric plugin with the
> hard coded variables.
> * Cordova 6 question (with solution):
> https://stackoverflow.com/questions/37816035/using-environment-variables-parameterizing-config-xml
> * Cordova 7 question (no solution yet)
> https://stackoverflow.com/questions/46816928/parameterize-do-not-hard-code-variables-when-building-with-cordova-7
> Ideally {{--nosave}} would not update {{package.json}} as advertised. Even
> better, there should be a way to set up a cordova project so that any cordova
> commands do not save by default. This would prevent mistakes in a larger team
> and allow use of tools that wrap cordova such as ionic.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13463) No way to prevent package.json update with cordova commands even with --nosave
[
https://issues.apache.org/jira/browse/CB-13463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219156#comment-16219156
]
Audrey So commented on CB-13463:
Pull request has been merged to address this issue. Closing this issue #. Thank
you!
> No way to prevent package.json update with cordova commands even with --nosave
> --
>
> Key: CB-13463
> URL: https://issues.apache.org/jira/browse/CB-13463
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-cli
>Affects Versions: cordova@7.0.0
>Reporter: Andrew Crites
> Labels: reproduced, triaged
>
> With Cordova 7, cordova commands including {{cordova platform add}} and
> {{cordova prepare}} will copy plugin information from {{config.xml}} to
> {{package.json}}.
> According to [the saving platforms
> documentation|https://cordova.apache.org/docs/en/latest/platform_plugin_versioning_ref/],
> using {{--nosave}} should prevent updating {{package.json}} or
> {{config.xml}}, but this does not work (i.e. using {{--nosave}} still seems
> to update the {{package.json}}.
> I want to avoid updating {{package.json}} specifically because there doesn't
> seem to be a way to avoid hard coding variables for plugins. An example is
> the cordova fabric plugin:
> {code}
>
>
>
>
> {code}
> Cordova doesn't seem to provide a way for you to parameterize variables in
> the configuration. To get around this, I have {{build.config.xml}} where they
> are parameterized, and {{config.xml}} is created at install-time and not
> version controlled. However, this would be much more difficult to do with
> {{package.json}} and is practically not an option.
> When running {{cordova platform add ios --nosave}} with the above plugin,
> cordova still updates {{package.json}} to include the fabric plugin with the
> hard coded variables.
> * Cordova 6 question (with solution):
> https://stackoverflow.com/questions/37816035/using-environment-variables-parameterizing-config-xml
> * Cordova 7 question (no solution yet)
> https://stackoverflow.com/questions/46816928/parameterize-do-not-hard-code-variables-when-building-with-cordova-7
> Ideally {{--nosave}} would not update {{package.json}} as advertised. Even
> better, there should be a way to set up a cordova project so that any cordova
> commands do not save by default. This would prevent mistakes in a larger team
> and allow use of tools that wrap cordova such as ionic.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-13463) No way to prevent package.json update with cordova commands even with --nosave
[
https://issues.apache.org/jira/browse/CB-13463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Audrey So resolved CB-13463.
Resolution: Fixed
> No way to prevent package.json update with cordova commands even with --nosave
> --
>
> Key: CB-13463
> URL: https://issues.apache.org/jira/browse/CB-13463
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-cli
>Affects Versions: cordova@7.0.0
>Reporter: Andrew Crites
> Labels: reproduced, triaged
>
> With Cordova 7, cordova commands including {{cordova platform add}} and
> {{cordova prepare}} will copy plugin information from {{config.xml}} to
> {{package.json}}.
> According to [the saving platforms
> documentation|https://cordova.apache.org/docs/en/latest/platform_plugin_versioning_ref/],
> using {{--nosave}} should prevent updating {{package.json}} or
> {{config.xml}}, but this does not work (i.e. using {{--nosave}} still seems
> to update the {{package.json}}.
> I want to avoid updating {{package.json}} specifically because there doesn't
> seem to be a way to avoid hard coding variables for plugins. An example is
> the cordova fabric plugin:
> {code}
>
>
>
>
> {code}
> Cordova doesn't seem to provide a way for you to parameterize variables in
> the configuration. To get around this, I have {{build.config.xml}} where they
> are parameterized, and {{config.xml}} is created at install-time and not
> version controlled. However, this would be much more difficult to do with
> {{package.json}} and is practically not an option.
> When running {{cordova platform add ios --nosave}} with the above plugin,
> cordova still updates {{package.json}} to include the fabric plugin with the
> hard coded variables.
> * Cordova 6 question (with solution):
> https://stackoverflow.com/questions/37816035/using-environment-variables-parameterizing-config-xml
> * Cordova 7 question (no solution yet)
> https://stackoverflow.com/questions/46816928/parameterize-do-not-hard-code-variables-when-building-with-cordova-7
> Ideally {{--nosave}} would not update {{package.json}} as advertised. Even
> better, there should be a way to set up a cordova project so that any cordova
> commands do not save by default. This would prevent mistakes in a larger team
> and allow use of tools that wrap cordova such as ionic.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13191) iOS: Missing icons in Images.xcassets
[ https://issues.apache.org/jira/browse/CB-13191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219153#comment-16219153 ] ASF GitHub Bot commented on CB-13191: - surajpindoria commented on issue #337: CB-13191: (ios) Support marketing icon URL: https://github.com/apache/cordova-ios/pull/337#issuecomment-339409188 @Gemeapp That single missing icon is the bug that I mentioned earlier. I am starting the release process to get a version out that will resolve this. As to those warnings, you may want to check the actual images that you are using. Cordova will not resize the images for you and by the looks of it they all seem to be of size 96x96. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > iOS: Missing icons in Images.xcassets > - > > Key: CB-13191 > URL: https://issues.apache.org/jira/browse/CB-13191 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Reporter: Tim Brust >Assignee: Suraj Pindoria > Labels: backlog, ios-next > Fix For: cordova-ios@4.5.1 > > Attachments: missing_icons_ios.png, missing_icons_watchos.png > > > There are some missing icons when the generated Xcode project is opened. > I believe this is the place where Images.xcassets are created: > https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/lib/prepare.js#L312 > and a reference commit for iOS 9 update: > https://github.com/apache/cordova-ios/commit/d0521fe28d3c20054908d229298ba9ced1033c92 > The updated links from Apple regarding App Icon sizes and images can be found > here: > https://developer.apple.com/ios/human-interface-guidelines/graphics/app-icon/ > https://developer.apple.com/watchos/human-interface-guidelines/icons-and-images/ > (should be changed in the code comment) > See attached screenshot from Xcode Version 9.0 beta 5 (9M202q) > h4. *List of missing icons* > *iOS* > -App icons:- > -1024x1024 (@1) for the App Store - new/added in Xcode 9 and iOS- (fixed via > PR #337) > Notifications: > iPhone Notification iOS 7 - 11 (20x20 @2 and @3) > iPad Notification iOS 7 - 11 (20x20 @1 and @2) > *watchOS* > There are currently *no* Apple Watch Icons at all: > App icon: > Apple Watch Companion Settings (29x29 @2 and @3) > Home screen icon: > Apple Watch Home Screen (all) (40x40 @2) > Notification: > Apple Watch Notification Center 38mm (24x24 @2) > Apple Watch Notification Center 42mm (27.5x27.5 @2) > Look icons (see here: > https://developer.apple.com/watchos/human-interface-guidelines/app-components) > Short look icons > Apple Watch Short Look 38mm (86x86 @2) > Apple Watch Short Look 42mm (98x98 @2) > Long look icons > Apple Watch Long Look 38mm (40x40 @2) > Apple Watch Long Look 42mm (44x44 @2) > App Store > Apple Watch App Store (1024x1024 @1) -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13463) No way to prevent package.json update with cordova commands even with --nosave
[
https://issues.apache.org/jira/browse/CB-13463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219152#comment-16219152
]
ASF GitHub Bot commented on CB-13463:
-
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/599
> No way to prevent package.json update with cordova commands even with --nosave
> --
>
> Key: CB-13463
> URL: https://issues.apache.org/jira/browse/CB-13463
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-cli
>Affects Versions: cordova@7.0.0
>Reporter: Andrew Crites
> Labels: reproduced, triaged
>
> With Cordova 7, cordova commands including {{cordova platform add}} and
> {{cordova prepare}} will copy plugin information from {{config.xml}} to
> {{package.json}}.
> According to [the saving platforms
> documentation|https://cordova.apache.org/docs/en/latest/platform_plugin_versioning_ref/],
> using {{--nosave}} should prevent updating {{package.json}} or
> {{config.xml}}, but this does not work (i.e. using {{--nosave}} still seems
> to update the {{package.json}}.
> I want to avoid updating {{package.json}} specifically because there doesn't
> seem to be a way to avoid hard coding variables for plugins. An example is
> the cordova fabric plugin:
> {code}
>
>
>
>
> {code}
> Cordova doesn't seem to provide a way for you to parameterize variables in
> the configuration. To get around this, I have {{build.config.xml}} where they
> are parameterized, and {{config.xml}} is created at install-time and not
> version controlled. However, this would be much more difficult to do with
> {{package.json}} and is practically not an option.
> When running {{cordova platform add ios --nosave}} with the above plugin,
> cordova still updates {{package.json}} to include the fabric plugin with the
> hard coded variables.
> * Cordova 6 question (with solution):
> https://stackoverflow.com/questions/37816035/using-environment-variables-parameterizing-config-xml
> * Cordova 7 question (no solution yet)
> https://stackoverflow.com/questions/46816928/parameterize-do-not-hard-code-variables-when-building-with-cordova-7
> Ideally {{--nosave}} would not update {{package.json}} as advertised. Even
> better, there should be a way to set up a cordova project so that any cordova
> commands do not save by default. This would prevent mistakes in a larger team
> and allow use of tools that wrap cordova such as ionic.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13463) No way to prevent package.json update with cordova commands even with --nosave
[
https://issues.apache.org/jira/browse/CB-13463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219151#comment-16219151
]
ASF subversion and git services commented on CB-13463:
--
Commit e8fec2519d6082b02f349408b147a04ebd020c87 in cordova-lib's branch
refs/heads/master from [~auso]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=e8fec25 ]
CB-13463 : prevent package.json update plugins with --nosave
> No way to prevent package.json update with cordova commands even with --nosave
> --
>
> Key: CB-13463
> URL: https://issues.apache.org/jira/browse/CB-13463
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-cli
>Affects Versions: cordova@7.0.0
>Reporter: Andrew Crites
> Labels: reproduced, triaged
>
> With Cordova 7, cordova commands including {{cordova platform add}} and
> {{cordova prepare}} will copy plugin information from {{config.xml}} to
> {{package.json}}.
> According to [the saving platforms
> documentation|https://cordova.apache.org/docs/en/latest/platform_plugin_versioning_ref/],
> using {{--nosave}} should prevent updating {{package.json}} or
> {{config.xml}}, but this does not work (i.e. using {{--nosave}} still seems
> to update the {{package.json}}.
> I want to avoid updating {{package.json}} specifically because there doesn't
> seem to be a way to avoid hard coding variables for plugins. An example is
> the cordova fabric plugin:
> {code}
>
>
>
>
> {code}
> Cordova doesn't seem to provide a way for you to parameterize variables in
> the configuration. To get around this, I have {{build.config.xml}} where they
> are parameterized, and {{config.xml}} is created at install-time and not
> version controlled. However, this would be much more difficult to do with
> {{package.json}} and is practically not an option.
> When running {{cordova platform add ios --nosave}} with the above plugin,
> cordova still updates {{package.json}} to include the fabric plugin with the
> hard coded variables.
> * Cordova 6 question (with solution):
> https://stackoverflow.com/questions/37816035/using-environment-variables-parameterizing-config-xml
> * Cordova 7 question (no solution yet)
> https://stackoverflow.com/questions/46816928/parameterize-do-not-hard-code-variables-when-building-with-cordova-7
> Ideally {{--nosave}} would not update {{package.json}} as advertised. Even
> better, there should be a way to set up a cordova project so that any cordova
> commands do not save by default. This would prevent mistakes in a larger team
> and allow use of tools that wrap cordova such as ionic.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13483) cordova add platform ios adds cordova-ios@4.4.0 not latest
[ https://issues.apache.org/jira/browse/CB-13483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219147#comment-16219147 ] Audrey So commented on CB-13483: Hi! I see you are using cordova@7.0.1. Please update to use cordova@7.1.0. It should work after you update. Please let me know the results. Thanks! > cordova add platform ios adds cordova-ios@4.4.0 not latest > -- > > Key: CB-13483 > URL: https://issues.apache.org/jira/browse/CB-13483 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli >Affects Versions: 7.0.1 >Reporter: Austin France > > $ cordova platform add ios --save > Using cordova-fetch for ios@~4.4.0 > It does this even when the engine setting for ios in config.xml is set to > 4.5.1. > To get version 4.5.1 (which contains important fixes) I have to remember to > $ cordova platform add ios@4.5.1 --save -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13463) No way to prevent package.json update with cordova commands even with --nosave
[
https://issues.apache.org/jira/browse/CB-13463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219120#comment-16219120
]
ASF GitHub Bot commented on CB-13463:
-
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/599
merge!
> No way to prevent package.json update with cordova commands even with --nosave
> --
>
> Key: CB-13463
> URL: https://issues.apache.org/jira/browse/CB-13463
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-cli
>Affects Versions: cordova@7.0.0
>Reporter: Andrew Crites
> Labels: reproduced, triaged
>
> With Cordova 7, cordova commands including {{cordova platform add}} and
> {{cordova prepare}} will copy plugin information from {{config.xml}} to
> {{package.json}}.
> According to [the saving platforms
> documentation|https://cordova.apache.org/docs/en/latest/platform_plugin_versioning_ref/],
> using {{--nosave}} should prevent updating {{package.json}} or
> {{config.xml}}, but this does not work (i.e. using {{--nosave}} still seems
> to update the {{package.json}}.
> I want to avoid updating {{package.json}} specifically because there doesn't
> seem to be a way to avoid hard coding variables for plugins. An example is
> the cordova fabric plugin:
> {code}
>
>
>
>
> {code}
> Cordova doesn't seem to provide a way for you to parameterize variables in
> the configuration. To get around this, I have {{build.config.xml}} where they
> are parameterized, and {{config.xml}} is created at install-time and not
> version controlled. However, this would be much more difficult to do with
> {{package.json}} and is practically not an option.
> When running {{cordova platform add ios --nosave}} with the above plugin,
> cordova still updates {{package.json}} to include the fabric plugin with the
> hard coded variables.
> * Cordova 6 question (with solution):
> https://stackoverflow.com/questions/37816035/using-environment-variables-parameterizing-config-xml
> * Cordova 7 question (no solution yet)
> https://stackoverflow.com/questions/46816928/parameterize-do-not-hard-code-variables-when-building-with-cordova-7
> Ideally {{--nosave}} would not update {{package.json}} as advertised. Even
> better, there should be a way to set up a cordova project so that any cordova
> commands do not save by default. This would prevent mistakes in a larger team
> and allow use of tools that wrap cordova such as ionic.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13489) Failed to fetch platform cordova-android@~6.3.0
[ https://issues.apache.org/jira/browse/CB-13489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] SAJANA MAHARJAN updated CB-13489: - Description: Deleted platform and plugins and did cordova prepare. Got following error: Error: Failed to fetch platform cordova-android@~6.3.0 Probably this is either a connection problem, or platform spec is incorrect. Check your connection and platform name/version/URL. Failed to get absolute path to installed module It works fine when adding individual platform: cordova platform add android I have cordova 7.1.0 and it says "Platforms and plugins are now required to have a package.json file" but I don't get package.json file created for platforms when adding platforms. is that a problem too? was: Deleted platform and plugins and did cordova prepare. Got following error: Error: Failed to fetch platform cordova-android@~6.3.0 Probably this is either a connection problem, or platform spec is incorrect. Check your connection and platform name/version/URL. Failed to get absolute path to installed module > Failed to fetch platform cordova-android@~6.3.0 > --- > > Key: CB-13489 > URL: https://issues.apache.org/jira/browse/CB-13489 > Project: Apache Cordova > Issue Type: Bug >Affects Versions: cordova@7.1.0 >Reporter: SAJANA MAHARJAN > > Deleted platform and plugins and did cordova prepare. Got following error: > Error: Failed to fetch platform cordova-android@~6.3.0 > Probably this is either a connection problem, or platform spec is incorrect. > Check your connection and platform name/version/URL. > Failed to get absolute path to installed module > It works fine when adding individual platform: cordova platform add android > I have cordova 7.1.0 and it says "Platforms and plugins are now required to > have a package.json file" but I don't get package.json file created for > platforms when adding platforms. is that a problem too? -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13489) Failed to fetch platform cordova-android@~6.3.0
SAJANA MAHARJAN created CB-13489: Summary: Failed to fetch platform cordova-android@~6.3.0 Key: CB-13489 URL: https://issues.apache.org/jira/browse/CB-13489 Project: Apache Cordova Issue Type: Bug Affects Versions: cordova@7.1.0 Reporter: SAJANA MAHARJAN Deleted platform and plugins and did cordova prepare. Got following error: Error: Failed to fetch platform cordova-android@~6.3.0 Probably this is either a connection problem, or platform spec is incorrect. Check your connection and platform name/version/URL. Failed to get absolute path to installed module -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13463) No way to prevent package.json update with cordova commands even with --nosave
[
https://issues.apache.org/jira/browse/CB-13463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218985#comment-16218985
]
ASF GitHub Bot commented on CB-13463:
-
Github user audreyso commented on the issue:
https://github.com/apache/cordova-lib/pull/599
@stevengill CI is passing now. Let me know if I should merge it in!
> No way to prevent package.json update with cordova commands even with --nosave
> --
>
> Key: CB-13463
> URL: https://issues.apache.org/jira/browse/CB-13463
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-cli
>Affects Versions: cordova@7.0.0
>Reporter: Andrew Crites
> Labels: reproduced, triaged
>
> With Cordova 7, cordova commands including {{cordova platform add}} and
> {{cordova prepare}} will copy plugin information from {{config.xml}} to
> {{package.json}}.
> According to [the saving platforms
> documentation|https://cordova.apache.org/docs/en/latest/platform_plugin_versioning_ref/],
> using {{--nosave}} should prevent updating {{package.json}} or
> {{config.xml}}, but this does not work (i.e. using {{--nosave}} still seems
> to update the {{package.json}}.
> I want to avoid updating {{package.json}} specifically because there doesn't
> seem to be a way to avoid hard coding variables for plugins. An example is
> the cordova fabric plugin:
> {code}
>
>
>
>
> {code}
> Cordova doesn't seem to provide a way for you to parameterize variables in
> the configuration. To get around this, I have {{build.config.xml}} where they
> are parameterized, and {{config.xml}} is created at install-time and not
> version controlled. However, this would be much more difficult to do with
> {{package.json}} and is practically not an option.
> When running {{cordova platform add ios --nosave}} with the above plugin,
> cordova still updates {{package.json}} to include the fabric plugin with the
> hard coded variables.
> * Cordova 6 question (with solution):
> https://stackoverflow.com/questions/37816035/using-environment-variables-parameterizing-config-xml
> * Cordova 7 question (no solution yet)
> https://stackoverflow.com/questions/46816928/parameterize-do-not-hard-code-variables-when-building-with-cordova-7
> Ideally {{--nosave}} would not update {{package.json}} as advertised. Even
> better, there should be a way to set up a cordova project so that any cordova
> commands do not save by default. This would prevent mistakes in a larger team
> and allow use of tools that wrap cordova such as ionic.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12366) InAppBrowser overlaps iOS status bar
[
https://issues.apache.org/jira/browse/CB-12366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218830#comment-16218830
]
ASF GitHub Bot commented on CB-12366:
-
Github user CVeniamin commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/209
Here it goes... [CB-13488](https://issues.apache.org/jira/browse/CB-13488)
> InAppBrowser overlaps iOS status bar
>
>
> Key: CB-12366
> URL: https://issues.apache.org/jira/browse/CB-12366
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
> Environment: iOS
>Reporter: Reid Beels
>Assignee: Shazron Abdullah
>
> This affects the unreleased 1.6.2-dev (which I can't select from the affects
> version field).
> Since the change introduced in CB-11136 /
> https://github.com/apache/cordova-plugin-inappbrowser/pull/187, the IAB
> window seems to be rendering on top of the iOS status bar.
> Dropping the {{tmpWindow}} window level from {{UIWindowLevelAlert}} to
> {{UIWindowLevelNormal}} seems to fix the issue, but I'm not sure how this
> affects the problem CB-11136 set out to solve.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13488) InAppBrowser content is ignored on iOS Longpress
[ https://issues.apache.org/jira/browse/CB-13488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Veniamin Craciun updated CB-13488: -- Description: InAppBrowser content isn't displayed on magnifiying glass (iOS Longpress). On longpress content that's displayed is content from behind the InAppBrowser and not content from IAB itself. My recommendation is to change setWindowLevel:UIWindowLevelNormal to setWindowLevel:UIWindowLevelNormal + 1. (was: InAppBrowser content isn't displayed on magnifiying glass (iOS Longpress). On longpress content that's displayed is content from behind the InAppBrowser. My recommendation is to change setWindowLevel:UIWindowLevelNormal to setWindowLevel:UIWindowLevelNormal + 1. ) > InAppBrowser content is ignored on iOS Longpress > > > Key: CB-13488 > URL: https://issues.apache.org/jira/browse/CB-13488 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Affects Versions: cordova-ios 4.5.0 >Reporter: Veniamin Craciun > > InAppBrowser content isn't displayed on magnifiying glass (iOS Longpress). On > longpress content that's displayed is content from behind the InAppBrowser > and not content from IAB itself. My recommendation is to change > setWindowLevel:UIWindowLevelNormal to setWindowLevel:UIWindowLevelNormal + 1. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13488) InAppBrowser content is ignored on iOS Longpress
[ https://issues.apache.org/jira/browse/CB-13488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Veniamin Craciun updated CB-13488: -- Description: InAppBrowser content isn't displayed on magnifiying glass (iOS Longpress). On longpress content that's displayed is content from behind the InAppBrowser. My recommendation is to change setWindowLevel:UIWindowLevelNormal to setWindowLevel:UIWindowLevelNormal + 1. (was: InAppBrowser content isn't displayed on magnifiying glass (iOS Longpress). My recommendation is to change setWindowLevel:UIWindowLevelNormal to setWindowLevel:UIWindowLevelNormal + 1. On longpress content that's displayed is content from behind the InAppBrowser.) > InAppBrowser content is ignored on iOS Longpress > > > Key: CB-13488 > URL: https://issues.apache.org/jira/browse/CB-13488 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Affects Versions: cordova-ios 4.5.0 >Reporter: Veniamin Craciun > > InAppBrowser content isn't displayed on magnifiying glass (iOS Longpress). On > longpress content that's displayed is content from behind the InAppBrowser. > My recommendation is to change setWindowLevel:UIWindowLevelNormal to > setWindowLevel:UIWindowLevelNormal + 1. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13488) InAppBrowser content is ignored on iOS Longpress
[ https://issues.apache.org/jira/browse/CB-13488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Veniamin Craciun updated CB-13488: -- Summary: InAppBrowser content is ignored on iOS Longpress (was: inAppBrowser content is ignored on iOS Longpress) > InAppBrowser content is ignored on iOS Longpress > > > Key: CB-13488 > URL: https://issues.apache.org/jira/browse/CB-13488 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Affects Versions: cordova-ios 4.5.0 >Reporter: Veniamin Craciun > > InAppBrowser content isn't displayed on magnifiying glass (iOS Longpress). My > recommendation is to change setWindowLevel:UIWindowLevelNormal to > setWindowLevel:UIWindowLevelNormal + 1. On longpress content that's displayed > is content from behind the InAppBrowser. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13488) inAppBrowser content is ignored on iOS Longpress
Veniamin Craciun created CB-13488: - Summary: inAppBrowser content is ignored on iOS Longpress Key: CB-13488 URL: https://issues.apache.org/jira/browse/CB-13488 Project: Apache Cordova Issue Type: Bug Components: cordova-plugin-inappbrowser Affects Versions: cordova-ios 4.5.0 Reporter: Veniamin Craciun InAppBrowser content isn't displayed on magnifiying glass (iOS Longpress). My recommendation is to change setWindowLevel:UIWindowLevelNormal to setWindowLevel:UIWindowLevelNormal + 1. On longpress content that's displayed is content from behind the InAppBrowser. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13290) SplashScreen dont handle iPhone X asset catalog image
[
https://issues.apache.org/jira/browse/CB-13290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218722#comment-16218722
]
ASF GitHub Bot commented on CB-13290:
-
Stefano1964 commented on a change in pull request #344: CB-13290: (ios) Update
splash screen mapping for missing devices
URL: https://github.com/apache/cordova-ios/pull/344#discussion_r146873474
##
File path: bin/templates/scripts/cordova/lib/prepare.js
##
@@ -411,7 +411,9 @@ function mapSplashScreenResources (splashScreens,
splashScreensDir) {
{dest: 'Default-568h@2x~iphone.png', width: 640, height: 1136},
{dest: 'Default-667h.png', width: 750, height: 1334},
{dest: 'Default-736h.png', width: 1242, height: 2208},
-{dest: 'Default-Landscape-736h.png', width: 2208, height: 1242}
+{dest: 'Default-Landscape-736h.png', width: 2208, height: 1242},
+{dest: 'Default-2436h.png', width: 1125, height: 2436},
+{dest: 'Default-Landscape-2436h.png', width: 2436, height: 1125}
Review comment:
There is support for iPhone X in asset catalog (LaunchImage), just check iOS
8 and later, but there is a bug in xCode 9 (seems to be fixed in 9.1) that
prevent to use LaunchImage for both portrait and landscape:
https://stackoverflow.com/questions/46263795/iphone-x-incorrect-launch-screen-orientation-used
I modified the splashscreen plugin to support iPhoneX and is working,
portrait only, for now.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> SplashScreen dont handle iPhone X asset catalog image
> -
>
> Key: CB-13290
> URL: https://issues.apache.org/jira/browse/CB-13290
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-splashscreen
>Affects Versions: cordova-ios 4.5.0
>Reporter: Stefano Boeri
>
> I've digged into source code but i dont see anything related to iPhone X.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13290) SplashScreen dont handle iPhone X asset catalog image
[
https://issues.apache.org/jira/browse/CB-13290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218688#comment-16218688
]
ASF GitHub Bot commented on CB-13290:
-
kerrishotts commented on a change in pull request #344: CB-13290: (ios) Update
splash screen mapping for missing devices
URL: https://github.com/apache/cordova-ios/pull/344#discussion_r146868190
##
File path: bin/templates/scripts/cordova/lib/prepare.js
##
@@ -411,7 +411,9 @@ function mapSplashScreenResources (splashScreens,
splashScreensDir) {
{dest: 'Default-568h@2x~iphone.png', width: 640, height: 1136},
{dest: 'Default-667h.png', width: 750, height: 1334},
{dest: 'Default-736h.png', width: 1242, height: 2208},
-{dest: 'Default-Landscape-736h.png', width: 2208, height: 1242}
+{dest: 'Default-Landscape-736h.png', width: 2208, height: 1242},
+{dest: 'Default-2436h.png', width: 1125, height: 2436},
+{dest: 'Default-Landscape-2436h.png', width: 2436, height: 1125}
Review comment:
Yeah, the lack of support for larger screens is the reason we added launch
storyboard support. IIRC there are hacks to use launch images for the 12.9”
iPad Pro, but I don’t think you’d ever get Xcode to be happy with them.
(Personally I fully expected Apple to require launch storyboards for the new
iPhone X. Surprised they aren’t!)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> SplashScreen dont handle iPhone X asset catalog image
> -
>
> Key: CB-13290
> URL: https://issues.apache.org/jira/browse/CB-13290
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-splashscreen
>Affects Versions: cordova-ios 4.5.0
>Reporter: Stefano Boeri
>
> I've digged into source code but i dont see anything related to iPhone X.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13191) iOS: Missing icons in Images.xcassets
[ https://issues.apache.org/jira/browse/CB-13191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218384#comment-16218384 ] ASF GitHub Bot commented on CB-13191: - ThorvaldAagaard commented on issue #337: CB-13191: (ios) Support marketing icon URL: https://github.com/apache/cordova-ios/pull/337#issuecomment-339289248 I am updating all to latest version so when done I will verify that the problem still is here. I might have taken the 2 screen shots at diffefent times as I saw IOS platform was reverted to 4.4.0 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > iOS: Missing icons in Images.xcassets > - > > Key: CB-13191 > URL: https://issues.apache.org/jira/browse/CB-13191 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Reporter: Tim Brust >Assignee: Suraj Pindoria > Labels: backlog, ios-next > Fix For: cordova-ios@4.5.1 > > Attachments: missing_icons_ios.png, missing_icons_watchos.png > > > There are some missing icons when the generated Xcode project is opened. > I believe this is the place where Images.xcassets are created: > https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/lib/prepare.js#L312 > and a reference commit for iOS 9 update: > https://github.com/apache/cordova-ios/commit/d0521fe28d3c20054908d229298ba9ced1033c92 > The updated links from Apple regarding App Icon sizes and images can be found > here: > https://developer.apple.com/ios/human-interface-guidelines/graphics/app-icon/ > https://developer.apple.com/watchos/human-interface-guidelines/icons-and-images/ > (should be changed in the code comment) > See attached screenshot from Xcode Version 9.0 beta 5 (9M202q) > h4. *List of missing icons* > *iOS* > -App icons:- > -1024x1024 (@1) for the App Store - new/added in Xcode 9 and iOS- (fixed via > PR #337) > Notifications: > iPhone Notification iOS 7 - 11 (20x20 @2 and @3) > iPad Notification iOS 7 - 11 (20x20 @1 and @2) > *watchOS* > There are currently *no* Apple Watch Icons at all: > App icon: > Apple Watch Companion Settings (29x29 @2 and @3) > Home screen icon: > Apple Watch Home Screen (all) (40x40 @2) > Notification: > Apple Watch Notification Center 38mm (24x24 @2) > Apple Watch Notification Center 42mm (27.5x27.5 @2) > Look icons (see here: > https://developer.apple.com/watchos/human-interface-guidelines/app-components) > Short look icons > Apple Watch Short Look 38mm (86x86 @2) > Apple Watch Short Look 42mm (98x98 @2) > Long look icons > Apple Watch Long Look 38mm (40x40 @2) > Apple Watch Long Look 42mm (44x44 @2) > App Store > Apple Watch App Store (1024x1024 @1) -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13191) iOS: Missing icons in Images.xcassets
[ https://issues.apache.org/jira/browse/CB-13191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218316#comment-16218316 ] ASF GitHub Bot commented on CB-13191: - janpio commented on issue #337: CB-13191: (ios) Support marketing icon URL: https://github.com/apache/cordova-ios/pull/337#issuecomment-339276035 @Gemeapp @ThorvaldAagaard Something is broken here, `ionic info` is reporting different things than the platform list. You should create a topic at https://forum.ionicframework.com/ (include the same screenshots and info as here) and post the link to it here so I can help you debug that. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > iOS: Missing icons in Images.xcassets > - > > Key: CB-13191 > URL: https://issues.apache.org/jira/browse/CB-13191 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios >Reporter: Tim Brust >Assignee: Suraj Pindoria > Labels: backlog, ios-next > Fix For: cordova-ios@4.5.1 > > Attachments: missing_icons_ios.png, missing_icons_watchos.png > > > There are some missing icons when the generated Xcode project is opened. > I believe this is the place where Images.xcassets are created: > https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/lib/prepare.js#L312 > and a reference commit for iOS 9 update: > https://github.com/apache/cordova-ios/commit/d0521fe28d3c20054908d229298ba9ced1033c92 > The updated links from Apple regarding App Icon sizes and images can be found > here: > https://developer.apple.com/ios/human-interface-guidelines/graphics/app-icon/ > https://developer.apple.com/watchos/human-interface-guidelines/icons-and-images/ > (should be changed in the code comment) > See attached screenshot from Xcode Version 9.0 beta 5 (9M202q) > h4. *List of missing icons* > *iOS* > -App icons:- > -1024x1024 (@1) for the App Store - new/added in Xcode 9 and iOS- (fixed via > PR #337) > Notifications: > iPhone Notification iOS 7 - 11 (20x20 @2 and @3) > iPad Notification iOS 7 - 11 (20x20 @1 and @2) > *watchOS* > There are currently *no* Apple Watch Icons at all: > App icon: > Apple Watch Companion Settings (29x29 @2 and @3) > Home screen icon: > Apple Watch Home Screen (all) (40x40 @2) > Notification: > Apple Watch Notification Center 38mm (24x24 @2) > Apple Watch Notification Center 42mm (27.5x27.5 @2) > Look icons (see here: > https://developer.apple.com/watchos/human-interface-guidelines/app-components) > Short look icons > Apple Watch Short Look 38mm (86x86 @2) > Apple Watch Short Look 42mm (98x98 @2) > Long look icons > Apple Watch Long Look 38mm (40x40 @2) > Apple Watch Long Look 42mm (44x44 @2) > App Store > Apple Watch App Store (1024x1024 @1) -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-13483) cordova add platform ios adds cordova-ios@4.4.0 not latest
[
https://issues.apache.org/jira/browse/CB-13483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218281#comment-16218281
]
Austin France edited comment on CB-13483 at 10/25/17 9:20 AM:
--
{code}
$ cordova create testApp com.redskyit.mobile.testApp testApp
Creating a new cordova project.
$ cd testApp
$ cordova platform add ios
Using cordova-fetch for cordova-ios@~4.4.0
Adding ios project...
Creating Cordova project for the iOS platform:
Path: platforms/ios
Package: com.redskyit.mobile.testApp
Name: testApp
iOS project created with cordova-ios@4.4.0
Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the
project
Installing "cordova-plugin-whitelist" for ios
Adding cordova-plugin-whitelist to package.json
Saved plugin info for "cordova-plugin-whitelist" to config.xml
--save flag or autosave detected
Saving ios@~4.4.0 into config.xml file ...
{code}
{code}
$ npm ls -g |grep cordova
├─┬ cordova@7.0.1
│ ├─┬ cordova-common@2.0.3
│ │ ├── cordova-registry-mapper@1.1.15
│ ├─┬ cordova-lib@7.0.1
│ │ ├─┬ cordova-create@1.1.1
│ │ │ ├── cordova-app-hello-world@3.12.0
│ │ ├─┬ cordova-fetch@1.1.0
│ │ ├─┬ cordova-js@4.2.1
│ │ ├─┬ cordova-serve@1.0.1
{code}
was (Author: mehuge):
{code}
$ cordova create testApp com.redskyit.mobile.testApp testApp
Creating a new cordova project.
$ cd testApp
$ cordova platform add ios
Using cordova-fetch for cordova-ios@~4.4.0
Adding ios project...
Creating Cordova project for the iOS platform:
Path: platforms/ios
Package: com.redskyit.mobile.testApp
Name: testApp
iOS project created with cordova-ios@4.4.0
Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the
project
Installing "cordova-plugin-whitelist" for ios
Adding cordova-plugin-whitelist to package.json
Saved plugin info for "cordova-plugin-whitelist" to config.xml
--save flag or autosave detected
Saving ios@~4.4.0 into config.xml file ...
$
$ npm ls -g |grep cordova
├─┬ cordova@7.0.1
│ ├─┬ cordova-common@2.0.3
│ │ ├── cordova-registry-mapper@1.1.15
│ ├─┬ cordova-lib@7.0.1
│ │ ├─┬ cordova-create@1.1.1
│ │ │ ├── cordova-app-hello-world@3.12.0
│ │ ├─┬ cordova-fetch@1.1.0
│ │ ├─┬ cordova-js@4.2.1
│ │ ├─┬ cordova-serve@1.0.1
{code}
> cordova add platform ios adds cordova-ios@4.4.0 not latest
> --
>
> Key: CB-13483
> URL: https://issues.apache.org/jira/browse/CB-13483
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-cli
>Affects Versions: 7.0.1
>Reporter: Austin France
>
> $ cordova platform add ios --save
> Using cordova-fetch for ios@~4.4.0
> It does this even when the engine setting for ios in config.xml is set to
> 4.5.1.
> To get version 4.5.1 (which contains important fixes) I have to remember to
> $ cordova platform add ios@4.5.1 --save
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-13483) cordova add platform ios adds cordova-ios@4.4.0 not latest
[
https://issues.apache.org/jira/browse/CB-13483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218281#comment-16218281
]
Austin France edited comment on CB-13483 at 10/25/17 9:19 AM:
--
{code}
$ cordova create testApp com.redskyit.mobile.testApp testApp
Creating a new cordova project.
$ cd testApp
$ cordova platform add ios
Using cordova-fetch for cordova-ios@~4.4.0
Adding ios project...
Creating Cordova project for the iOS platform:
Path: platforms/ios
Package: com.redskyit.mobile.testApp
Name: testApp
iOS project created with cordova-ios@4.4.0
Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the
project
Installing "cordova-plugin-whitelist" for ios
Adding cordova-plugin-whitelist to package.json
Saved plugin info for "cordova-plugin-whitelist" to config.xml
--save flag or autosave detected
Saving ios@~4.4.0 into config.xml file ...
$
$ npm ls -g |grep cordova
├─┬ cordova@7.0.1
│ ├─┬ cordova-common@2.0.3
│ │ ├── cordova-registry-mapper@1.1.15
│ ├─┬ cordova-lib@7.0.1
│ │ ├─┬ cordova-create@1.1.1
│ │ │ ├── cordova-app-hello-world@3.12.0
│ │ ├─┬ cordova-fetch@1.1.0
│ │ ├─┬ cordova-js@4.2.1
│ │ ├─┬ cordova-serve@1.0.1
{code}
was (Author: mehuge):
{{
$ cordova create testApp com.redskyit.mobile.testApp testApp
Creating a new cordova project.
$ cd testApp
$ cordova platform add ios
Using cordova-fetch for cordova-ios@~4.4.0
Adding ios project...
Creating Cordova project for the iOS platform:
Path: platforms/ios
Package: com.redskyit.mobile.testApp
Name: testApp
iOS project created with cordova-ios@4.4.0
Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the
project
Installing "cordova-plugin-whitelist" for ios
Adding cordova-plugin-whitelist to package.json
Saved plugin info for "cordova-plugin-whitelist" to config.xml
--save flag or autosave detected
Saving ios@~4.4.0 into config.xml file ...
$
}}
$ npm ls -g |grep cordova
├─┬ cordova@7.0.1
│ ├─┬ cordova-common@2.0.3
│ │ ├── cordova-registry-mapper@1.1.15
│ ├─┬ cordova-lib@7.0.1
│ │ ├─┬ cordova-create@1.1.1
│ │ │ ├── cordova-app-hello-world@3.12.0
│ │ ├─┬ cordova-fetch@1.1.0
│ │ ├─┬ cordova-js@4.2.1
│ │ ├─┬ cordova-serve@1.0.1
}}
> cordova add platform ios adds cordova-ios@4.4.0 not latest
> --
>
> Key: CB-13483
> URL: https://issues.apache.org/jira/browse/CB-13483
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-cli
>Affects Versions: 7.0.1
>Reporter: Austin France
>
> $ cordova platform add ios --save
> Using cordova-fetch for ios@~4.4.0
> It does this even when the engine setting for ios in config.xml is set to
> 4.5.1.
> To get version 4.5.1 (which contains important fixes) I have to remember to
> $ cordova platform add ios@4.5.1 --save
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-13483) cordova add platform ios adds cordova-ios@4.4.0 not latest
[
https://issues.apache.org/jira/browse/CB-13483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218281#comment-16218281
]
Austin France edited comment on CB-13483 at 10/25/17 9:18 AM:
--
{{
$ cordova create testApp com.redskyit.mobile.testApp testApp
Creating a new cordova project.
$ cd testApp
$ cordova platform add ios
Using cordova-fetch for cordova-ios@~4.4.0
Adding ios project...
Creating Cordova project for the iOS platform:
Path: platforms/ios
Package: com.redskyit.mobile.testApp
Name: testApp
iOS project created with cordova-ios@4.4.0
Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the
project
Installing "cordova-plugin-whitelist" for ios
Adding cordova-plugin-whitelist to package.json
Saved plugin info for "cordova-plugin-whitelist" to config.xml
--save flag or autosave detected
Saving ios@~4.4.0 into config.xml file ...
$
}}
$ npm ls -g |grep cordova
├─┬ cordova@7.0.1
│ ├─┬ cordova-common@2.0.3
│ │ ├── cordova-registry-mapper@1.1.15
│ ├─┬ cordova-lib@7.0.1
│ │ ├─┬ cordova-create@1.1.1
│ │ │ ├── cordova-app-hello-world@3.12.0
│ │ ├─┬ cordova-fetch@1.1.0
│ │ ├─┬ cordova-js@4.2.1
│ │ ├─┬ cordova-serve@1.0.1
}}
was (Author: mehuge):
{{test}}
$ cordova create testApp com.redskyit.mobile.testApp testApp
Creating a new cordova project.
$ cd testApp
$ cordova platform add ios
Using cordova-fetch for cordova-ios@~4.4.0
Adding ios project...
Creating Cordova project for the iOS platform:
Path: platforms/ios
Package: com.redskyit.mobile.testApp
Name: testApp
iOS project created with cordova-ios@4.4.0
Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the
project
Installing "cordova-plugin-whitelist" for ios
Adding cordova-plugin-whitelist to package.json
Saved plugin info for "cordova-plugin-whitelist" to config.xml
--save flag or autosave detected
Saving ios@~4.4.0 into config.xml file ...
$
$ npm ls -g |grep cordova
├─┬ cordova@7.0.1
│ ├─┬ cordova-common@2.0.3
│ │ ├── cordova-registry-mapper@1.1.15
│ ├─┬ cordova-lib@7.0.1
│ │ ├─┬ cordova-create@1.1.1
│ │ │ ├── cordova-app-hello-world@3.12.0
│ │ ├─┬ cordova-fetch@1.1.0
│ │ ├─┬ cordova-js@4.2.1
│ │ ├─┬ cordova-serve@1.0.1
}}
> cordova add platform ios adds cordova-ios@4.4.0 not latest
> --
>
> Key: CB-13483
> URL: https://issues.apache.org/jira/browse/CB-13483
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-cli
>Affects Versions: 7.0.1
>Reporter: Austin France
>
> $ cordova platform add ios --save
> Using cordova-fetch for ios@~4.4.0
> It does this even when the engine setting for ios in config.xml is set to
> 4.5.1.
> To get version 4.5.1 (which contains important fixes) I have to remember to
> $ cordova platform add ios@4.5.1 --save
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-13483) cordova add platform ios adds cordova-ios@4.4.0 not latest
[
https://issues.apache.org/jira/browse/CB-13483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218281#comment-16218281
]
Austin France edited comment on CB-13483 at 10/25/17 9:18 AM:
--
{{test}}
$ cordova create testApp com.redskyit.mobile.testApp testApp
Creating a new cordova project.
$ cd testApp
$ cordova platform add ios
Using cordova-fetch for cordova-ios@~4.4.0
Adding ios project...
Creating Cordova project for the iOS platform:
Path: platforms/ios
Package: com.redskyit.mobile.testApp
Name: testApp
iOS project created with cordova-ios@4.4.0
Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the
project
Installing "cordova-plugin-whitelist" for ios
Adding cordova-plugin-whitelist to package.json
Saved plugin info for "cordova-plugin-whitelist" to config.xml
--save flag or autosave detected
Saving ios@~4.4.0 into config.xml file ...
$
$ npm ls -g |grep cordova
├─┬ cordova@7.0.1
│ ├─┬ cordova-common@2.0.3
│ │ ├── cordova-registry-mapper@1.1.15
│ ├─┬ cordova-lib@7.0.1
│ │ ├─┬ cordova-create@1.1.1
│ │ │ ├── cordova-app-hello-world@3.12.0
│ │ ├─┬ cordova-fetch@1.1.0
│ │ ├─┬ cordova-js@4.2.1
│ │ ├─┬ cordova-serve@1.0.1
}}
was (Author: mehuge):
{{
$ cordova create testApp com.redskyit.mobile.testApp testApp
Creating a new cordova project.
$ cd testApp
$ cordova platform add ios
Using cordova-fetch for cordova-ios@~4.4.0
Adding ios project...
Creating Cordova project for the iOS platform:
Path: platforms/ios
Package: com.redskyit.mobile.testApp
Name: testApp
iOS project created with cordova-ios@4.4.0
Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the
project
Installing "cordova-plugin-whitelist" for ios
Adding cordova-plugin-whitelist to package.json
Saved plugin info for "cordova-plugin-whitelist" to config.xml
--save flag or autosave detected
Saving ios@~4.4.0 into config.xml file ...
$
$ npm ls -g |grep cordova
├─┬ cordova@7.0.1
│ ├─┬ cordova-common@2.0.3
│ │ ├── cordova-registry-mapper@1.1.15
│ ├─┬ cordova-lib@7.0.1
│ │ ├─┬ cordova-create@1.1.1
│ │ │ ├── cordova-app-hello-world@3.12.0
│ │ ├─┬ cordova-fetch@1.1.0
│ │ ├─┬ cordova-js@4.2.1
│ │ ├─┬ cordova-serve@1.0.1
}}
> cordova add platform ios adds cordova-ios@4.4.0 not latest
> --
>
> Key: CB-13483
> URL: https://issues.apache.org/jira/browse/CB-13483
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-cli
>Affects Versions: 7.0.1
>Reporter: Austin France
>
> $ cordova platform add ios --save
> Using cordova-fetch for ios@~4.4.0
> It does this even when the engine setting for ios in config.xml is set to
> 4.5.1.
> To get version 4.5.1 (which contains important fixes) I have to remember to
> $ cordova platform add ios@4.5.1 --save
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Issue Comment Deleted] (CB-13483) cordova add platform ios adds cordova-ios@4.4.0 not latest
[
https://issues.apache.org/jira/browse/CB-13483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Austin France updated CB-13483:
---
Comment: was deleted
(was: {{
$ cordova create testApp com.redskyit.mobile.testApp testApp
Creating a new cordova project.
$ cd testApp
$ cordova platform add ios
Using cordova-fetch for cordova-ios@~4.4.0
Adding ios project...
Creating Cordova project for the iOS platform:
Path: platforms/ios
Package: com.redskyit.mobile.testApp
Name: testApp
iOS project created with cordova-ios@4.4.0
Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the
project
Installing "cordova-plugin-whitelist" for ios
Adding cordova-plugin-whitelist to package.json
Saved plugin info for "cordova-plugin-whitelist" to config.xml
--save flag or autosave detected
Saving ios@~4.4.0 into config.xml file ...
$
$ npm ls -g |grep cordova
├─┬ cordova@7.0.1
│ ├─┬ cordova-common@2.0.3
│ │ ├── cordova-registry-mapper@1.1.15
│ ├─┬ cordova-lib@7.0.1
│ │ ├─┬ cordova-create@1.1.1
│ │ │ ├── cordova-app-hello-world@3.12.0
│ │ ├─┬ cordova-fetch@1.1.0
│ │ ├─┬ cordova-js@4.2.1
│ │ ├─┬ cordova-serve@1.0.1
}})
> cordova add platform ios adds cordova-ios@4.4.0 not latest
> --
>
> Key: CB-13483
> URL: https://issues.apache.org/jira/browse/CB-13483
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-cli
>Affects Versions: 7.0.1
>Reporter: Austin France
>
> $ cordova platform add ios --save
> Using cordova-fetch for ios@~4.4.0
> It does this even when the engine setting for ios in config.xml is set to
> 4.5.1.
> To get version 4.5.1 (which contains important fixes) I have to remember to
> $ cordova platform add ios@4.5.1 --save
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13483) cordova add platform ios adds cordova-ios@4.4.0 not latest
[
https://issues.apache.org/jira/browse/CB-13483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218281#comment-16218281
]
Austin France commented on CB-13483:
{{
$ cordova create testApp com.redskyit.mobile.testApp testApp
Creating a new cordova project.
$ cd testApp
$ cordova platform add ios
Using cordova-fetch for cordova-ios@~4.4.0
Adding ios project...
Creating Cordova project for the iOS platform:
Path: platforms/ios
Package: com.redskyit.mobile.testApp
Name: testApp
iOS project created with cordova-ios@4.4.0
Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the
project
Installing "cordova-plugin-whitelist" for ios
Adding cordova-plugin-whitelist to package.json
Saved plugin info for "cordova-plugin-whitelist" to config.xml
--save flag or autosave detected
Saving ios@~4.4.0 into config.xml file ...
$
$ npm ls -g |grep cordova
├─┬ cordova@7.0.1
│ ├─┬ cordova-common@2.0.3
│ │ ├── cordova-registry-mapper@1.1.15
│ ├─┬ cordova-lib@7.0.1
│ │ ├─┬ cordova-create@1.1.1
│ │ │ ├── cordova-app-hello-world@3.12.0
│ │ ├─┬ cordova-fetch@1.1.0
│ │ ├─┬ cordova-js@4.2.1
│ │ ├─┬ cordova-serve@1.0.1
}}
> cordova add platform ios adds cordova-ios@4.4.0 not latest
> --
>
> Key: CB-13483
> URL: https://issues.apache.org/jira/browse/CB-13483
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-cli
>Affects Versions: 7.0.1
>Reporter: Austin France
>
> $ cordova platform add ios --save
> Using cordova-fetch for ios@~4.4.0
> It does this even when the engine setting for ios in config.xml is set to
> 4.5.1.
> To get version 4.5.1 (which contains important fixes) I have to remember to
> $ cordova platform add ios@4.5.1 --save
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-13483) cordova add platform ios adds cordova-ios@4.4.0 not latest
[
https://issues.apache.org/jira/browse/CB-13483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218278#comment-16218278
]
Austin France edited comment on CB-13483 at 10/25/17 9:17 AM:
--
{{
$ cordova create testApp com.redskyit.mobile.testApp testApp
Creating a new cordova project.
$ cd testApp
$ cordova platform add ios
Using cordova-fetch for cordova-ios@~4.4.0
Adding ios project...
Creating Cordova project for the iOS platform:
Path: platforms/ios
Package: com.redskyit.mobile.testApp
Name: testApp
iOS project created with cordova-ios@4.4.0
Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the
project
Installing "cordova-plugin-whitelist" for ios
Adding cordova-plugin-whitelist to package.json
Saved plugin info for "cordova-plugin-whitelist" to config.xml
--save flag or autosave detected
Saving ios@~4.4.0 into config.xml file ...
$
$ npm ls -g |grep cordova
├─┬ cordova@7.0.1
│ ├─┬ cordova-common@2.0.3
│ │ ├── cordova-registry-mapper@1.1.15
│ ├─┬ cordova-lib@7.0.1
│ │ ├─┬ cordova-create@1.1.1
│ │ │ ├── cordova-app-hello-world@3.12.0
│ │ ├─┬ cordova-fetch@1.1.0
│ │ ├─┬ cordova-js@4.2.1
│ │ ├─┬ cordova-serve@1.0.1
}}
was (Author: mehuge):
{{$ cordova create testApp com.redskyit.mobile.testApp testApp
Creating a new cordova project.
$ cd testApp
$ cordova platform add ios
Using cordova-fetch for cordova-ios@~4.4.0
Adding ios project...
Creating Cordova project for the iOS platform:
Path: platforms/ios
Package: com.redskyit.mobile.testApp
Name: testApp
iOS project created with cordova-ios@4.4.0
Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the
project
Installing "cordova-plugin-whitelist" for ios
Adding cordova-plugin-whitelist to package.json
Saved plugin info for "cordova-plugin-whitelist" to config.xml
--save flag or autosave detected
Saving ios@~4.4.0 into config.xml file ...
$
$ npm ls -g |grep cordova
├─┬ cordova@7.0.1
│ ├─┬ cordova-common@2.0.3
│ │ ├── cordova-registry-mapper@1.1.15
│ ├─┬ cordova-lib@7.0.1
│ │ ├─┬ cordova-create@1.1.1
│ │ │ ├── cordova-app-hello-world@3.12.0
│ │ ├─┬ cordova-fetch@1.1.0
│ │ ├─┬ cordova-js@4.2.1
│ │ ├─┬ cordova-serve@1.0.1
}}
> cordova add platform ios adds cordova-ios@4.4.0 not latest
> --
>
> Key: CB-13483
> URL: https://issues.apache.org/jira/browse/CB-13483
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-cli
>Affects Versions: 7.0.1
>Reporter: Austin France
>
> $ cordova platform add ios --save
> Using cordova-fetch for ios@~4.4.0
> It does this even when the engine setting for ios in config.xml is set to
> 4.5.1.
> To get version 4.5.1 (which contains important fixes) I have to remember to
> $ cordova platform add ios@4.5.1 --save
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-13483) cordova add platform ios adds cordova-ios@4.4.0 not latest
[
https://issues.apache.org/jira/browse/CB-13483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218278#comment-16218278
]
Austin France edited comment on CB-13483 at 10/25/17 9:16 AM:
--
{{$ cordova create testApp com.redskyit.mobile.testApp testApp
Creating a new cordova project.
$ cd testApp
$ cordova platform add ios
Using cordova-fetch for cordova-ios@~4.4.0
Adding ios project...
Creating Cordova project for the iOS platform:
Path: platforms/ios
Package: com.redskyit.mobile.testApp
Name: testApp
iOS project created with cordova-ios@4.4.0
Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the
project
Installing "cordova-plugin-whitelist" for ios
Adding cordova-plugin-whitelist to package.json
Saved plugin info for "cordova-plugin-whitelist" to config.xml
--save flag or autosave detected
Saving ios@~4.4.0 into config.xml file ...
$
$ npm ls -g |grep cordova
├─┬ cordova@7.0.1
│ ├─┬ cordova-common@2.0.3
│ │ ├── cordova-registry-mapper@1.1.15
│ ├─┬ cordova-lib@7.0.1
│ │ ├─┬ cordova-create@1.1.1
│ │ │ ├── cordova-app-hello-world@3.12.0
│ │ ├─┬ cordova-fetch@1.1.0
│ │ ├─┬ cordova-js@4.2.1
│ │ ├─┬ cordova-serve@1.0.1
}}
was (Author: mehuge):
$ cordova create testApp com.redskyit.mobile.testApp testApp
Creating a new cordova project.
$ cd testApp
$ cordova platform add ios
Using cordova-fetch for cordova-ios@~4.4.0
Adding ios project...
Creating Cordova project for the iOS platform:
Path: platforms/ios
Package: com.redskyit.mobile.testApp
Name: testApp
iOS project created with cordova-ios@4.4.0
Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the
project
Installing "cordova-plugin-whitelist" for ios
Adding cordova-plugin-whitelist to package.json
Saved plugin info for "cordova-plugin-whitelist" to config.xml
--save flag or autosave detected
Saving ios@~4.4.0 into config.xml file ...
$
$ npm ls -g |grep cordova
├─┬ cordova@7.0.1
│ ├─┬ cordova-common@2.0.3
│ │ ├── cordova-registry-mapper@1.1.15
│ ├─┬ cordova-lib@7.0.1
│ │ ├─┬ cordova-create@1.1.1
│ │ │ ├── cordova-app-hello-world@3.12.0
│ │ ├─┬ cordova-fetch@1.1.0
│ │ ├─┬ cordova-js@4.2.1
│ │ ├─┬ cordova-serve@1.0.1
> cordova add platform ios adds cordova-ios@4.4.0 not latest
> --
>
> Key: CB-13483
> URL: https://issues.apache.org/jira/browse/CB-13483
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-cli
>Affects Versions: 7.0.1
>Reporter: Austin France
>
> $ cordova platform add ios --save
> Using cordova-fetch for ios@~4.4.0
> It does this even when the engine setting for ios in config.xml is set to
> 4.5.1.
> To get version 4.5.1 (which contains important fixes) I have to remember to
> $ cordova platform add ios@4.5.1 --save
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-13483) cordova add platform ios adds cordova-ios@4.4.0 not latest
[ https://issues.apache.org/jira/browse/CB-13483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218278#comment-16218278 ] Austin France edited comment on CB-13483 at 10/25/17 9:16 AM: -- $ cordova create testApp com.redskyit.mobile.testApp testApp Creating a new cordova project. $ cd testApp $ cordova platform add ios Using cordova-fetch for cordova-ios@~4.4.0 Adding ios project... Creating Cordova project for the iOS platform: Path: platforms/ios Package: com.redskyit.mobile.testApp Name: testApp iOS project created with cordova-ios@4.4.0 Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the project Installing "cordova-plugin-whitelist" for ios Adding cordova-plugin-whitelist to package.json Saved plugin info for "cordova-plugin-whitelist" to config.xml --save flag or autosave detected Saving ios@~4.4.0 into config.xml file ... $ $ npm ls -g |grep cordova ├─┬ cordova@7.0.1 │ ├─┬ cordova-common@2.0.3 │ │ ├── cordova-registry-mapper@1.1.15 │ ├─┬ cordova-lib@7.0.1 │ │ ├─┬ cordova-create@1.1.1 │ │ │ ├── cordova-app-hello-world@3.12.0 │ │ ├─┬ cordova-fetch@1.1.0 │ │ ├─┬ cordova-js@4.2.1 │ │ ├─┬ cordova-serve@1.0.1 was (Author: mehuge): $ cordova create testApp com.redskyit.mobile.testApp testApp Creating a new cordova project. $ cd testApp $ cordova platform add ios Using cordova-fetch for cordova-ios@~4.4.0 Adding ios project... Creating Cordova project for the iOS platform: Path: platforms/ios Package: com.redskyit.mobile.testApp Name: testApp iOS project created with cordova-ios@4.4.0 Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the project Installing "cordova-plugin-whitelist" for ios Adding cordova-plugin-whitelist to package.json Saved plugin info for "cordova-plugin-whitelist" to config.xml --save flag or autosave detected Saving ios@~4.4.0 into config.xml file ... $ > cordova add platform ios adds cordova-ios@4.4.0 not latest > -- > > Key: CB-13483 > URL: https://issues.apache.org/jira/browse/CB-13483 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli >Affects Versions: 7.0.1 >Reporter: Austin France > > $ cordova platform add ios --save > Using cordova-fetch for ios@~4.4.0 > It does this even when the engine setting for ios in config.xml is set to > 4.5.1. > To get version 4.5.1 (which contains important fixes) I have to remember to > $ cordova platform add ios@4.5.1 --save -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-13483) cordova add platform ios adds cordova-ios@4.4.0 not latest
[ https://issues.apache.org/jira/browse/CB-13483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218278#comment-16218278 ] Austin France edited comment on CB-13483 at 10/25/17 9:14 AM: -- $ cordova create testApp com.redskyit.mobile.testApp testApp Creating a new cordova project. $ cd testApp $ cordova platform add ios Using cordova-fetch for cordova-ios@~4.4.0 Adding ios project... Creating Cordova project for the iOS platform: Path: platforms/ios Package: com.redskyit.mobile.testApp Name: testApp iOS project created with cordova-ios@4.4.0 Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the project Installing "cordova-plugin-whitelist" for ios Adding cordova-plugin-whitelist to package.json Saved plugin info for "cordova-plugin-whitelist" to config.xml --save flag or autosave detected Saving ios@~4.4.0 into config.xml file ... $ was (Author: mehuge): $ cordova create testApp com.redskyit.mobile.testApp testApp Creating a new cordova project. $ cd testApp f$ cordova platform add ios Using cordova-fetch for cordova-ios@~4.4.0 Adding ios project... Creating Cordova project for the iOS platform: Path: platforms/ios Package: com.redskyit.mobile.testApp Name: testApp iOS project created with cordova-ios@4.4.0 Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the project Installing "cordova-plugin-whitelist" for ios Adding cordova-plugin-whitelist to package.json Saved plugin info for "cordova-plugin-whitelist" to config.xml --save flag or autosave detected Saving ios@~4.4.0 into config.xml file ... $ > cordova add platform ios adds cordova-ios@4.4.0 not latest > -- > > Key: CB-13483 > URL: https://issues.apache.org/jira/browse/CB-13483 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli >Affects Versions: 7.0.1 >Reporter: Austin France > > $ cordova platform add ios --save > Using cordova-fetch for ios@~4.4.0 > It does this even when the engine setting for ios in config.xml is set to > 4.5.1. > To get version 4.5.1 (which contains important fixes) I have to remember to > $ cordova platform add ios@4.5.1 --save -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13483) cordova add platform ios adds cordova-ios@4.4.0 not latest
[ https://issues.apache.org/jira/browse/CB-13483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218278#comment-16218278 ] Austin France commented on CB-13483: $ cordova create testApp com.redskyit.mobile.testApp testApp Creating a new cordova project. $ cd testApp f$ cordova platform add ios Using cordova-fetch for cordova-ios@~4.4.0 Adding ios project... Creating Cordova project for the iOS platform: Path: platforms/ios Package: com.redskyit.mobile.testApp Name: testApp iOS project created with cordova-ios@4.4.0 Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the project Installing "cordova-plugin-whitelist" for ios Adding cordova-plugin-whitelist to package.json Saved plugin info for "cordova-plugin-whitelist" to config.xml --save flag or autosave detected Saving ios@~4.4.0 into config.xml file ... $ > cordova add platform ios adds cordova-ios@4.4.0 not latest > -- > > Key: CB-13483 > URL: https://issues.apache.org/jira/browse/CB-13483 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli >Affects Versions: 7.0.1 >Reporter: Austin France > > $ cordova platform add ios --save > Using cordova-fetch for ios@~4.4.0 > It does this even when the engine setting for ios in config.xml is set to > 4.5.1. > To get version 4.5.1 (which contains important fixes) I have to remember to > $ cordova platform add ios@4.5.1 --save -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13483) cordova add platform ios adds cordova-ios@4.4.0 not latest
[ https://issues.apache.org/jira/browse/CB-13483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218275#comment-16218275 ] Austin France commented on CB-13483: $ npm -v 4.2.0 $ node -v v7.9.0 > cordova add platform ios adds cordova-ios@4.4.0 not latest > -- > > Key: CB-13483 > URL: https://issues.apache.org/jira/browse/CB-13483 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli >Affects Versions: 7.0.1 >Reporter: Austin France > > $ cordova platform add ios --save > Using cordova-fetch for ios@~4.4.0 > It does this even when the engine setting for ios in config.xml is set to > 4.5.1. > To get version 4.5.1 (which contains important fixes) I have to remember to > $ cordova platform add ios@4.5.1 --save -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
