[jira] [Commented] (CB-8954) Update platform check_reqs script to return structured result to 'requirements' command
[
https://issues.apache.org/jira/browse/CB-8954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14590707#comment-14590707
]
ASF subversion and git services commented on CB-8954:
-
Commit f9c6249f45dfdf71fd5346a549318d5c9ee335d9 in cordova-ios's branch
refs/heads/4.0.x from [~vladimir.kotikov]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=f9c6249 ]
CB-8954 Adds `requirements` command support to check_reqs module
Update platform check_reqs script to return structured result to
'requirements' command
---
Key: CB-8954
URL: https://issues.apache.org/jira/browse/CB-8954
Project: Apache Cordova
Issue Type: Bug
Components: Android, iOS, Windows, WP8
Reporter: Vladimir Kotikov
Assignee: Vladimir Kotikov
Since {{requirements}} LIB method assumes that underlying platform script
will be {{require}}d instead of spawning child process and capturing output,
we need to modify these scripts to provide method that will be called for
getting current requirements status.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8954) Update platform check_reqs script to return structured result to 'requirements' command
[
https://issues.apache.org/jira/browse/CB-8954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14564513#comment-14564513
]
ASF subversion and git services commented on CB-8954:
-
Commit a90d167d6f2b8bda87ab45825563656a54561f5d in cordova-wp8's branch
refs/heads/master from [~vladimir.kotikov]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-wp8.git;h=a90d167 ]
CB-8954 Adds `requirements` command support to check_reqs module
Update platform check_reqs script to return structured result to
'requirements' command
---
Key: CB-8954
URL: https://issues.apache.org/jira/browse/CB-8954
Project: Apache Cordova
Issue Type: Bug
Components: Android, iOS, Windows, WP8
Reporter: Vladimir Kotikov
Assignee: Vladimir Kotikov
Since {{requirements}} LIB method assumes that underlying platform script
will be {{require}}d instead of spawning child process and capturing output,
we need to modify these scripts to provide method that will be called for
getting current requirements status.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8954) Update platform check_reqs script to return structured result to 'requirements' command
[
https://issues.apache.org/jira/browse/CB-8954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14564514#comment-14564514
]
ASF GitHub Bot commented on CB-8954:
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-wp8/pull/82
Update platform check_reqs script to return structured result to
'requirements' command
---
Key: CB-8954
URL: https://issues.apache.org/jira/browse/CB-8954
Project: Apache Cordova
Issue Type: Bug
Components: Android, iOS, Windows, WP8
Reporter: Vladimir Kotikov
Assignee: Vladimir Kotikov
Since {{requirements}} LIB method assumes that underlying platform script
will be {{require}}d instead of spawning child process and capturing output,
we need to modify these scripts to provide method that will be called for
getting current requirements status.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8954) Update platform check_reqs script to return structured result to 'requirements' command
[
https://issues.apache.org/jira/browse/CB-8954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14564511#comment-14564511
]
ASF GitHub Bot commented on CB-8954:
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/176
Update platform check_reqs script to return structured result to
'requirements' command
---
Key: CB-8954
URL: https://issues.apache.org/jira/browse/CB-8954
Project: Apache Cordova
Issue Type: Bug
Components: Android, iOS, Windows, WP8
Reporter: Vladimir Kotikov
Assignee: Vladimir Kotikov
Since {{requirements}} LIB method assumes that underlying platform script
will be {{require}}d instead of spawning child process and capturing output,
we need to modify these scripts to provide method that will be called for
getting current requirements status.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8954) Update platform check_reqs script to return structured result to 'requirements' command
[
https://issues.apache.org/jira/browse/CB-8954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14564487#comment-14564487
]
ASF GitHub Bot commented on CB-8954:
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/83
Update platform check_reqs script to return structured result to
'requirements' command
---
Key: CB-8954
URL: https://issues.apache.org/jira/browse/CB-8954
Project: Apache Cordova
Issue Type: Bug
Components: Android, iOS, Windows, WP8
Reporter: Vladimir Kotikov
Assignee: Vladimir Kotikov
Since {{requirements}} LIB method assumes that underlying platform script
will be {{require}}d instead of spawning child process and capturing output,
we need to modify these scripts to provide method that will be called for
getting current requirements status.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8954) Update platform check_reqs script to return structured result to 'requirements' command
[
https://issues.apache.org/jira/browse/CB-8954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14564486#comment-14564486
]
ASF subversion and git services commented on CB-8954:
-
Commit 782ea083988706579d3f322ac111b084982310c3 in cordova-windows's branch
refs/heads/master from [~vladimir.kotikov]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=782ea08 ]
CB-8954 Adds `requirements` command support to check_reqs module
Update platform check_reqs script to return structured result to
'requirements' command
---
Key: CB-8954
URL: https://issues.apache.org/jira/browse/CB-8954
Project: Apache Cordova
Issue Type: Bug
Components: Android, iOS, Windows, WP8
Reporter: Vladimir Kotikov
Assignee: Vladimir Kotikov
Since {{requirements}} LIB method assumes that underlying platform script
will be {{require}}d instead of spawning child process and capturing output,
we need to modify these scripts to provide method that will be called for
getting current requirements status.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8954) Update platform check_reqs script to return structured result to 'requirements' command
[
https://issues.apache.org/jira/browse/CB-8954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14564503#comment-14564503
]
ASF GitHub Bot commented on CB-8954:
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/142
Update platform check_reqs script to return structured result to
'requirements' command
---
Key: CB-8954
URL: https://issues.apache.org/jira/browse/CB-8954
Project: Apache Cordova
Issue Type: Bug
Components: Android, iOS, Windows, WP8
Reporter: Vladimir Kotikov
Assignee: Vladimir Kotikov
Since {{requirements}} LIB method assumes that underlying platform script
will be {{require}}d instead of spawning child process and capturing output,
we need to modify these scripts to provide method that will be called for
getting current requirements status.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8954) Update platform check_reqs script to return structured result to 'requirements' command
[
https://issues.apache.org/jira/browse/CB-8954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14564502#comment-14564502
]
ASF subversion and git services commented on CB-8954:
-
Commit f9c6249f45dfdf71fd5346a549318d5c9ee335d9 in cordova-ios's branch
refs/heads/master from [~vladimir.kotikov]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=f9c6249 ]
CB-8954 Adds `requirements` command support to check_reqs module
Update platform check_reqs script to return structured result to
'requirements' command
---
Key: CB-8954
URL: https://issues.apache.org/jira/browse/CB-8954
Project: Apache Cordova
Issue Type: Bug
Components: Android, iOS, Windows, WP8
Reporter: Vladimir Kotikov
Assignee: Vladimir Kotikov
Since {{requirements}} LIB method assumes that underlying platform script
will be {{require}}d instead of spawning child process and capturing output,
we need to modify these scripts to provide method that will be called for
getting current requirements status.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8954) Update platform check_reqs script to return structured result to 'requirements' command
[
https://issues.apache.org/jira/browse/CB-8954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14564510#comment-14564510
]
ASF subversion and git services commented on CB-8954:
-
Commit 4bf705a3d39b34400388265381a9975b246e3779 in cordova-android's branch
refs/heads/master from [~vladimir.kotikov]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=4bf705a ]
CB-8954 Adds `requirements` command support to check_reqs module
Update platform check_reqs script to return structured result to
'requirements' command
---
Key: CB-8954
URL: https://issues.apache.org/jira/browse/CB-8954
Project: Apache Cordova
Issue Type: Bug
Components: Android, iOS, Windows, WP8
Reporter: Vladimir Kotikov
Assignee: Vladimir Kotikov
Since {{requirements}} LIB method assumes that underlying platform script
will be {{require}}d instead of spawning child process and capturing output,
we need to modify these scripts to provide method that will be called for
getting current requirements status.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8954) Update platform check_reqs script to return structured result to 'requirements' command
[
https://issues.apache.org/jira/browse/CB-8954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14559602#comment-14559602
]
ASF GitHub Bot commented on CB-8954:
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/176#discussion_r31066149
--- Diff: bin/lib/check_reqs.js ---
@@ -196,20 +208,22 @@ module.exports.check_android = function() {
process.env['ANDROID_HOME'] = grandParentDir;
hasAndroidHome = true;
} else {
-throw new Error('ANDROID_HOME is not set and no tools
directory found at ' + parentDir);
+throw new Error('Failed to find \'ANDROID_HOME\'
environment variable. Try setting setting it manually.\n' +
+'Detected \'android\' command at ' + parentDir + ' but
no \'tools\' directory found near.\n' +
+'Try reinstall Android SDK or update your PATH to
include path to valid SDK directory.');
}
}
if (hasAndroidHome !adbInPath) {
process.env['PATH'] += path.delimiter +
path.join(process.env['ANDROID_HOME'], 'platform-tools');
}
if (!process.env['ANDROID_HOME']) {
-throw new Error('ANDROID_HOME is not set and android command
not in your PATH. You must fulfill at least one of these conditions.');
+throw new Error('Failed to find \'ANDROID_HOME\' environment
variable. Try setting setting it manually.\n' +
+'Failed to find \'android\' command in your \'PATH\'. Try
update your \'PATH\' to include path to valid SDK directory.');
}
if (!fs.existsSync(process.env['ANDROID_HOME'])) {
-throw new Error('ANDROID_HOME is set to a non-existant path: '
+ process.env['ANDROID_HOME']);
+throw new Error('\'ANDROID_HOME\' environment variable is
leads to non-existant path: ' + process.env['ANDROID_HOME'] +
--- End diff --
is leads to isn't good grammar :smile: ... Either leave it as it was ('is
set to'), or just 'leads to' (I actually think it worked fine how it was).
Update platform check_reqs script to return structured result to
'requirements' command
---
Key: CB-8954
URL: https://issues.apache.org/jira/browse/CB-8954
Project: Apache Cordova
Issue Type: Bug
Components: Android, iOS, Windows, WP8
Reporter: Vladimir Kotikov
Assignee: Vladimir Kotikov
Since {{requirements}} LIB method assumes that underlying platform script
will be {{require}}d instead of spawning child process and capturing output,
we need to modify these scripts to provide method that will be called for
getting current requirements status.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8954) Update platform check_reqs script to return structured result to 'requirements' command
[
https://issues.apache.org/jira/browse/CB-8954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14559587#comment-14559587
]
ASF GitHub Bot commented on CB-8954:
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/176#discussion_r31065606
--- Diff: bin/lib/check_reqs.js ---
@@ -70,18 +72,23 @@ module.exports.get_target = function() {
// Returns a promise. Called only by build and clean commands.
module.exports.check_ant = function() {
-return tryCommand('ant -version', 'Failed to run ant -version, make
sure you have ant installed and added to your PATH.');
+return tryCommand('ant -version', 'Failed to run ant -version, make
sure you have ant installed and added to your PATH.')
+.then(function (output) {
+// Parse Ant version from command output
+return /version ((?:\d+\.)+(?:\d+))/i.exec(output)[1];
+});
};
// Returns a promise. Called only by build and clean commands.
module.exports.check_gradle = function() {
var sdkDir = process.env['ANDROID_HOME'];
-var wrapperDir = path.join(sdkDir, 'tools', 'templates', 'gradle',
'wrapper');
-if (!fs.existsSync(wrapperDir)) {
-return Q.reject(new Error('Could not find gradle wrapper within
android sdk. Might need to update your Android SDK.\n' +
-'Looked here: ' + wrapperDir));
-}
-return Q.when();
+var wrapper = path.join(sdkDir, 'tools', 'templates', 'gradle',
'wrapper', 'gradlew');
--- End diff --
If `ANDROID_HOME` is not defined, the error you will get here is:
Gradle: not installed
[TypeError: Arguments to path.join must be strings]
(since you end up passing null to `path.join()`)
While there is a previous check for `ANDROID_HOME` (as part of the Android
SDK check), it would be nice to make this error more meaningful.
Update platform check_reqs script to return structured result to
'requirements' command
---
Key: CB-8954
URL: https://issues.apache.org/jira/browse/CB-8954
Project: Apache Cordova
Issue Type: Bug
Components: Android, iOS, Windows, WP8
Reporter: Vladimir Kotikov
Assignee: Vladimir Kotikov
Since {{requirements}} LIB method assumes that underlying platform script
will be {{require}}d instead of spawning child process and capturing output,
we need to modify these scripts to provide method that will be called for
getting current requirements status.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8954) Update platform check_reqs script to return structured result to 'requirements' command
[
https://issues.apache.org/jira/browse/CB-8954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14559609#comment-14559609
]
ASF GitHub Bot commented on CB-8954:
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-android/pull/176#issuecomment-105632526
In general looks good. A few minor comments.
Update platform check_reqs script to return structured result to
'requirements' command
---
Key: CB-8954
URL: https://issues.apache.org/jira/browse/CB-8954
Project: Apache Cordova
Issue Type: Bug
Components: Android, iOS, Windows, WP8
Reporter: Vladimir Kotikov
Assignee: Vladimir Kotikov
Since {{requirements}} LIB method assumes that underlying platform script
will be {{require}}d instead of spawning child process and capturing output,
we need to modify these scripts to provide method that will be called for
getting current requirements status.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8954) Update platform check_reqs script to return structured result to 'requirements' command
[
https://issues.apache.org/jira/browse/CB-8954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14559492#comment-14559492
]
ASF GitHub Bot commented on CB-8954:
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/176#discussion_r31061078
--- Diff: bin/lib/check_reqs.js ---
@@ -196,20 +208,22 @@ module.exports.check_android = function() {
process.env['ANDROID_HOME'] = grandParentDir;
hasAndroidHome = true;
} else {
-throw new Error('ANDROID_HOME is not set and no tools
directory found at ' + parentDir);
+throw new Error('Failed to find \'ANDROID_HOME\'
environment variable. Try setting setting it manually.\n' +
+'Detected \'android\' command at ' + parentDir + ' but
no \'tools\' directory found near.\n' +
+'Try reinstall Android SDK or update your PATH to
include path to valid SDK directory.');
}
}
if (hasAndroidHome !adbInPath) {
process.env['PATH'] += path.delimiter +
path.join(process.env['ANDROID_HOME'], 'platform-tools');
}
if (!process.env['ANDROID_HOME']) {
-throw new Error('ANDROID_HOME is not set and android command
not in your PATH. You must fulfill at least one of these conditions.');
+throw new Error('Failed to find \'ANDROID_HOME\' environment
variable. Try setting setting it manually.\n' +
+'Failed to find \'android\' command in your \'PATH\'. Try
update your \'PATH\' to include path to valid SDK directory.');
}
if (!fs.existsSync(process.env['ANDROID_HOME'])) {
-throw new Error('ANDROID_HOME is set to a non-existant path: '
+ process.env['ANDROID_HOME']);
+throw new Error('\'ANDROID_HOME\' environment variable is
leads to non-existant path: ' + process.env['ANDROID_HOME'] +
--- End diff --
Typo - 'existent' (I know - not new code, but good to fix while you're here)
Update platform check_reqs script to return structured result to
'requirements' command
---
Key: CB-8954
URL: https://issues.apache.org/jira/browse/CB-8954
Project: Apache Cordova
Issue Type: Bug
Components: Android, iOS, Windows, WP8
Reporter: Vladimir Kotikov
Assignee: Vladimir Kotikov
Since {{requirements}} LIB method assumes that underlying platform script
will be {{require}}d instead of spawning child process and capturing output,
we need to modify these scripts to provide method that will be called for
getting current requirements status.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8954) Update platform check_reqs script to return structured result to 'requirements' command
[
https://issues.apache.org/jira/browse/CB-8954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14559495#comment-14559495
]
ASF GitHub Bot commented on CB-8954:
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/176#discussion_r31061166
--- Diff: bin/lib/check_reqs.js ---
@@ -223,27 +237,87 @@ module.exports.check_android_target =
function(valid_target) {
// android-L
// Google Inc.:Google APIs:20
// Google Inc.:Glass Development Kit Preview:20
+if (!valid_target) valid_target = module.exports.get_target();
var msg = 'Android SDK not found. Make sure that it is installed. If
it is not at the default location, set the ANDROID_HOME environment variable.';
return tryCommand('android list targets --compact', msg)
.then(function(output) {
-if (output.split('\n').indexOf(valid_target) == -1) {
-var androidCmd = module.exports.getAbsoluteAndroidCmd();
-throw new Error('Please install Android target: ' +
valid_target + '.\n\n' +
-'Hint: Open the SDK manager by running: ' + androidCmd +
'\n' +
-'You will require:\n' +
-'1. SDK Platform for ' + valid_target + '\n' +
-'2. Android SDK Platform-tools (latest)\n' +
-'3. Android SDK Build-tools (latest)');
+var targets = output.split('\n');
+if (targets.indexOf(valid_target) = 0) {
+return targets;
}
+
+var androidCmd = module.exports.getAbsoluteAndroidCmd();
+throw new Error('Please install Android target: ' + valid_target
+ '.\n\n' +
+'Hint: Open the SDK manager by running: ' + androidCmd + '\n' +
+'You will require:\n' +
+'1. SDK Platform for ' + valid_target + '\n' +
+'2. Android SDK Platform-tools (latest)\n' +
+'3. Android SDK Build-tools (latest)');
});
};
// Returns a promise.
module.exports.run = function() {
-return Q.all([this.check_java(), this.check_android()])
+return Q.all([this.check_java(), this.check_android(),
this.check_android_target()])
.then(function() {
console.log('ANDROID_HOME=' + process.env['ANDROID_HOME']);
console.log('JAVA_HOME=' + process.env['JAVA_HOME']);
});
};
+/**
+ * Object thar represents one of requirements for current platform.
+ * @param {String} id The unique identifier for this requirements.
+ * @param {String} name The name of requirements. Human-readable
field.
+ * @param {String} versionThe version of requirement installed. In
some cases could be an array of strings
+ *(for example, check_android_target returns
an array of android targets installed)
+ * @param {Boolean} installed Indicates whether the reuirement is
installed or not
--- End diff --
My IDE wants you to mark `version` and `installed` as optional :)
Update platform check_reqs script to return structured result to
'requirements' command
---
Key: CB-8954
URL: https://issues.apache.org/jira/browse/CB-8954
Project: Apache Cordova
Issue Type: Bug
Components: Android, iOS, Windows, WP8
Reporter: Vladimir Kotikov
Assignee: Vladimir Kotikov
Since {{requirements}} LIB method assumes that underlying platform script
will be {{require}}d instead of spawning child process and capturing output,
we need to modify these scripts to provide method that will be called for
getting current requirements status.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8954) Update platform check_reqs script to return structured result to 'requirements' command
[
https://issues.apache.org/jira/browse/CB-8954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14559494#comment-14559494
]
ASF GitHub Bot commented on CB-8954:
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/176#discussion_r31061124
--- Diff: bin/lib/check_reqs.js ---
@@ -223,27 +237,87 @@ module.exports.check_android_target =
function(valid_target) {
// android-L
// Google Inc.:Google APIs:20
// Google Inc.:Glass Development Kit Preview:20
+if (!valid_target) valid_target = module.exports.get_target();
var msg = 'Android SDK not found. Make sure that it is installed. If
it is not at the default location, set the ANDROID_HOME environment variable.';
return tryCommand('android list targets --compact', msg)
.then(function(output) {
-if (output.split('\n').indexOf(valid_target) == -1) {
-var androidCmd = module.exports.getAbsoluteAndroidCmd();
-throw new Error('Please install Android target: ' +
valid_target + '.\n\n' +
-'Hint: Open the SDK manager by running: ' + androidCmd +
'\n' +
-'You will require:\n' +
-'1. SDK Platform for ' + valid_target + '\n' +
-'2. Android SDK Platform-tools (latest)\n' +
-'3. Android SDK Build-tools (latest)');
+var targets = output.split('\n');
+if (targets.indexOf(valid_target) = 0) {
+return targets;
}
+
+var androidCmd = module.exports.getAbsoluteAndroidCmd();
+throw new Error('Please install Android target: ' + valid_target
+ '.\n\n' +
+'Hint: Open the SDK manager by running: ' + androidCmd + '\n' +
+'You will require:\n' +
+'1. SDK Platform for ' + valid_target + '\n' +
+'2. Android SDK Platform-tools (latest)\n' +
+'3. Android SDK Build-tools (latest)');
});
};
// Returns a promise.
module.exports.run = function() {
-return Q.all([this.check_java(), this.check_android()])
+return Q.all([this.check_java(), this.check_android(),
this.check_android_target()])
.then(function() {
console.log('ANDROID_HOME=' + process.env['ANDROID_HOME']);
console.log('JAVA_HOME=' + process.env['JAVA_HOME']);
});
};
+/**
+ * Object thar represents one of requirements for current platform.
+ * @param {String} id The unique identifier for this requirements.
+ * @param {String} name The name of requirements. Human-readable
field.
+ * @param {String} versionThe version of requirement installed. In
some cases could be an array of strings
+ *(for example, check_android_target returns
an array of android targets installed)
+ * @param {Boolean} installed Indicates whether the reuirement is
installed or not
--- End diff --
Typo - 'requirement'
Update platform check_reqs script to return structured result to
'requirements' command
---
Key: CB-8954
URL: https://issues.apache.org/jira/browse/CB-8954
Project: Apache Cordova
Issue Type: Bug
Components: Android, iOS, Windows, WP8
Reporter: Vladimir Kotikov
Assignee: Vladimir Kotikov
Since {{requirements}} LIB method assumes that underlying platform script
will be {{require}}d instead of spawning child process and capturing output,
we need to modify these scripts to provide method that will be called for
getting current requirements status.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8954) Update platform check_reqs script to return structured result to 'requirements' command
[
https://issues.apache.org/jira/browse/CB-8954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14559653#comment-14559653
]
ASF GitHub Bot commented on CB-8954:
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-ios/pull/142#issuecomment-105637853
Looks good apart from some minor points.
Update platform check_reqs script to return structured result to
'requirements' command
---
Key: CB-8954
URL: https://issues.apache.org/jira/browse/CB-8954
Project: Apache Cordova
Issue Type: Bug
Components: Android, iOS, Windows, WP8
Reporter: Vladimir Kotikov
Assignee: Vladimir Kotikov
Since {{requirements}} LIB method assumes that underlying platform script
will be {{require}}d instead of spawning child process and capturing output,
we need to modify these scripts to provide method that will be called for
getting current requirements status.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8954) Update platform check_reqs script to return structured result to 'requirements' command
[
https://issues.apache.org/jira/browse/CB-8954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14559681#comment-14559681
]
ASF GitHub Bot commented on CB-8954:
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/83#discussion_r31070257
--- Diff: bin/lib/check_reqs.js ---
@@ -17,17 +17,101 @@
under the License.
*/
-var Q = require('Q'),
-os= require('os'),
+/*jshint node:true*/
+
+var Q = require('Q');
+
+var MSBuildTools;
+try {
MSBuildTools = require('../../template/cordova/lib/MSBuildTools');
+} catch (ex) {
+// If previous import fails, we probably running this script
+// from installed platform and the module location is different.
+MSBuildTools = require('./MSBuildTools');
+}
+
+/**
+ * Check if current OS is supports building windows platform
+ * @return {Promise} Promise either fullfilled or rejected with error
message.
+ */
+var checkOS = function () {
+var platform = process.platform;
+return (platform === 'win32') ?
+Q.resolve(platform):
+// Build Universal windows apps available for windows platform
only, so we reject on others platforms
+Q.reject('Cordova tooling for Windows requires Windows OS to build
project');
+};
+
+/**
+ * Checks if MSBuild tools is available.
+ * @return {Promise} Promise either fullfilled with MSBuild version
+ * or rejected with error message.
+ */
+var checkMSBuild = function () {
+return MSBuildTools.findAvailableVersion()
+.then(function (msbuildTools) {
+// return Q.resolve('MSBuild tools v.' + msbuildTools.version + '
found at ' + msbuildTools.path);
--- End diff --
Remove commented line.
Update platform check_reqs script to return structured result to
'requirements' command
---
Key: CB-8954
URL: https://issues.apache.org/jira/browse/CB-8954
Project: Apache Cordova
Issue Type: Bug
Components: Android, iOS, Windows, WP8
Reporter: Vladimir Kotikov
Assignee: Vladimir Kotikov
Since {{requirements}} LIB method assumes that underlying platform script
will be {{require}}d instead of spawning child process and capturing output,
we need to modify these scripts to provide method that will be called for
getting current requirements status.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8954) Update platform check_reqs script to return structured result to 'requirements' command
[
https://issues.apache.org/jira/browse/CB-8954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14559703#comment-14559703
]
ASF GitHub Bot commented on CB-8954:
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-wp8/pull/82#discussion_r31070971
--- Diff: bin/lib/check_reqs.js ---
@@ -17,17 +17,100 @@
under the License.
*/
-var Q = require('Q'),
-os= require('os'),
+var Q = require('Q');
+
+var MSBuildTools;
+try {
MSBuildTools = require('../../template/cordova/lib/MSBuildTools');
+} catch (ex) {
+// If previous import fails, we probably running this script
+// from installed platform and the module location is different.
+MSBuildTools = require('./MSBuildTools');
+}
+
+/**
+ * Check if current OS is supports building windows platform
+ * @return {Promise} Promise either fullfilled or rejected with error
message.
+ */
+var checkOS = function () {
+var platform = process.platform;
+return (platform === 'win32') ?
+Q.resolve(platform):
+// Build Universal windows apps available for windows platform
only, so we reject on others platforms
+Q.reject('Cordova tooling for Windows requires Windows OS to build
project');
+};
+
+/**
+ * Checks if MSBuild tools is available.
+ * @return {Promise} Promise either fullfilled with MSBuild version
+ * or rejected with error message.
+ */
+var checkMSBuild = function () {
+return MSBuildTools.findAvailableVersion()
+.then(function (msbuildTools) {
+// return Q.resolve('MSBuild tools v.' + msbuildTools.version + '
found at ' + msbuildTools.path);
--- End diff --
Remove commented line.
Update platform check_reqs script to return structured result to
'requirements' command
---
Key: CB-8954
URL: https://issues.apache.org/jira/browse/CB-8954
Project: Apache Cordova
Issue Type: Bug
Components: Android, iOS, Windows, WP8
Reporter: Vladimir Kotikov
Assignee: Vladimir Kotikov
Since {{requirements}} LIB method assumes that underlying platform script
will be {{require}}d instead of spawning child process and capturing output,
we need to modify these scripts to provide method that will be called for
getting current requirements status.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8954) Update platform check_reqs script to return structured result to 'requirements' command
[
https://issues.apache.org/jira/browse/CB-8954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14559625#comment-14559625
]
ASF GitHub Bot commented on CB-8954:
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/142#discussion_r31067211
--- Diff: bin/lib/check_reqs.js ---
@@ -17,34 +17,30 @@
under the License.
*/
-/* jshint node:true, bitwise:true, undef:true, trailing:true,
quotmark:true,
- indent:4, unused:vars, latedef:nofunc,
- sub:true, laxcomma:true, laxbreak:true
-*/
-
var Q = require('q'),
-os= require('os'),
shell = require('shelljs'),
versions = require('./versions');
var XCODEBUILD_MIN_VERSION = '4.6.0';
+var XCODEBUILD_NOT_FOUND_MESSAGE =
+'Please install version ' + XCODEBUILD_MIN_VERSION + ' or greater from
App Store';
var IOS_SIM_MIN_VERSION = '3.0.0';
-var IOS_SIM_NOT_FOUND_MESSAGE = 'ios-sim was not found. Please download,
build and install version ' + IOS_SIM_MIN_VERSION +
-' or greater from https://github.com/phonegap/ios-sim into your path.'
+
-' Or \'npm install -g ios-sim\' using node.js: http://nodejs.org';
+var IOS_SIM_NOT_FOUND_MESSAGE =
+'Please download, build and install version ' + IOS_SIM_MIN_VERSION +
' or greater' +
+' from https://github.com/phonegap/ios-sim into your path, or do \'npm
install -g ios-sim\'';
--- End diff --
Remove 'do' (or add it to `IOS_DEPLOY_NOT_FOUND_MESSAGE`).
Update platform check_reqs script to return structured result to
'requirements' command
---
Key: CB-8954
URL: https://issues.apache.org/jira/browse/CB-8954
Project: Apache Cordova
Issue Type: Bug
Components: Android, iOS, Windows, WP8
Reporter: Vladimir Kotikov
Assignee: Vladimir Kotikov
Since {{requirements}} LIB method assumes that underlying platform script
will be {{require}}d instead of spawning child process and capturing output,
we need to modify these scripts to provide method that will be called for
getting current requirements status.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8954) Update platform check_reqs script to return structured result to 'requirements' command
[
https://issues.apache.org/jira/browse/CB-8954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14559627#comment-14559627
]
ASF GitHub Bot commented on CB-8954:
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/142#discussion_r31067511
--- Diff: bin/lib/check_reqs.js ---
@@ -75,20 +78,74 @@ module.exports.help = function () {
* @return {Promise} Returns a promise either resolved with tool
version or rejected
*/
function checkTool (tool, minVersion, optMessage) {
-if (os.platform() !== 'darwin'){
-// Build iOS apps available for OSX platform only, so we reject on
others platforms
-return Q.reject('Cordova tooling for iOS requires Apple OS X');
-}
// Check whether tool command is available at all
var tool_command = shell.which(tool);
if (!tool_command) {
-return Q.reject(optMessage || (tool + 'command is unavailable.'));
+return Q.reject(tool + ' was not found. ' + (optMessage || ''));
--- End diff --
I presume the `opt` in `optMessage` stands for 'optional` - it's not longer
really optional, so perhaps change the name?
Update platform check_reqs script to return structured result to
'requirements' command
---
Key: CB-8954
URL: https://issues.apache.org/jira/browse/CB-8954
Project: Apache Cordova
Issue Type: Bug
Components: Android, iOS, Windows, WP8
Reporter: Vladimir Kotikov
Assignee: Vladimir Kotikov
Since {{requirements}} LIB method assumes that underlying platform script
will be {{require}}d instead of spawning child process and capturing output,
we need to modify these scripts to provide method that will be called for
getting current requirements status.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8954) Update platform check_reqs script to return structured result to 'requirements' command
[
https://issues.apache.org/jira/browse/CB-8954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14559694#comment-14559694
]
ASF GitHub Bot commented on CB-8954:
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/83#discussion_r31070612
--- Diff: bin/lib/check_reqs.js ---
@@ -17,17 +17,101 @@
under the License.
*/
-var Q = require('Q'),
-os= require('os'),
+/*jshint node:true*/
+
+var Q = require('Q');
+
+var MSBuildTools;
+try {
MSBuildTools = require('../../template/cordova/lib/MSBuildTools');
+} catch (ex) {
+// If previous import fails, we probably running this script
+// from installed platform and the module location is different.
+MSBuildTools = require('./MSBuildTools');
+}
+
+/**
+ * Check if current OS is supports building windows platform
+ * @return {Promise} Promise either fullfilled or rejected with error
message.
+ */
+var checkOS = function () {
+var platform = process.platform;
+return (platform === 'win32') ?
+Q.resolve(platform):
+// Build Universal windows apps available for windows platform
only, so we reject on others platforms
+Q.reject('Cordova tooling for Windows requires Windows OS to build
project');
+};
+
+/**
+ * Checks if MSBuild tools is available.
+ * @return {Promise} Promise either fullfilled with MSBuild version
+ * or rejected with error message.
+ */
+var checkMSBuild = function () {
+return MSBuildTools.findAvailableVersion()
+.then(function (msbuildTools) {
+// return Q.resolve('MSBuild tools v.' + msbuildTools.version + '
found at ' + msbuildTools.path);
+return Q.resolve(msbuildTools.version);
+}, function () {
+return Q.reject('MSBuild tools not found. Please install MSBuild
tools or VS 2013 from ' +
+
'https://www.visualstudio.com/downloads/download-visual-studio-vs');
+});
+};
module.exports.run = function () {
-if (os.platform() != 'win32'){
- // Build Universal windows apps available for windows platform only,
so we reject on others platforms
-return Q.reject('ERROR: Cordova tooling for Windows requires
Windows OS');
-}
-// Check whther MSBuild Tools are available
-return MSBuildTools.findAvailableVersion();
+return checkOS().then(function () {
+return MSBuildTools.findAvailableVersion();
+});
+};
+
+/**
+ * Object thar represents one of requirements for current platform.
+ * @param {String} id The unique identifier for this requirements.
+ * @param {String} name The name of requirements. Human-readable
field.
+ * @param {String} versionThe version of requirement installed. In
some cases could be an array of strings
+ *(for example, check_android_target returns
an array of android targets installed)
+ * @param {Boolean} installed Indicates whether the reuirement is
installed or not
+ */
+var Requirement = function (id, name, version, installed) {
+this.id = id;
+this.name = name;
+this.installed = installed || false;
+this.metadata = {
+version: version,
+};
+};
+
+/**
+ * Methods that runs all checks one by one and returns a result of checks
+ * as an array of Requirement objects. This method intended to be used by
cordova-lib check_reqs method
+ *
+ * @return PromiseRequirement[] Array of requirements. Due to
implementation, promise is always fulfilled.
+ */
+module.exports.check_all = function() {
+
+var requirements = [
+new Requirement('os', 'Windows OS'),
+new Requirement('msbuild', 'MSBuild Tools')
+];
+
+// Define list of checks needs to be performed
+var checkFns = [checkOS, checkMSBuild];
+// Then execute them one-by-one
+return checkFns.reduce(function (promise, checkFn, idx) {
+// Update each requirement with results
+var requirement = requirements[idx];
+return promise.then(checkFn)
+.then(function (version) {
+requirement.installed = true;
+requirement.metadata.version = version;
+}, function (err) {
+requirement.metadata.reason = err;
+});
+}, Q())
+.then(function () {
+// When chain is completed, return requirements array to upstream
API
+return requirements;
+});
--- End diff --
I know it's not a lot of code, but since it
[jira] [Commented] (CB-8954) Update platform check_reqs script to return structured result to 'requirements' command
[
https://issues.apache.org/jira/browse/CB-8954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14559702#comment-14559702
]
ASF GitHub Bot commented on CB-8954:
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-wp8/pull/82#discussion_r31070932
--- Diff: bin/lib/check_reqs.js ---
@@ -17,17 +17,100 @@
under the License.
*/
-var Q = require('Q'),
-os= require('os'),
+var Q = require('Q');
+
+var MSBuildTools;
+try {
MSBuildTools = require('../../template/cordova/lib/MSBuildTools');
+} catch (ex) {
+// If previous import fails, we probably running this script
--- End diff --
Typo: we should be we're or we are.
Update platform check_reqs script to return structured result to
'requirements' command
---
Key: CB-8954
URL: https://issues.apache.org/jira/browse/CB-8954
Project: Apache Cordova
Issue Type: Bug
Components: Android, iOS, Windows, WP8
Reporter: Vladimir Kotikov
Assignee: Vladimir Kotikov
Since {{requirements}} LIB method assumes that underlying platform script
will be {{require}}d instead of spawning child process and capturing output,
we need to modify these scripts to provide method that will be called for
getting current requirements status.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8954) Update platform check_reqs script to return structured result to 'requirements' command
[
https://issues.apache.org/jira/browse/CB-8954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14559701#comment-14559701
]
ASF GitHub Bot commented on CB-8954:
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/83#discussion_r31070922
--- Diff: bin/lib/check_reqs.js ---
@@ -17,17 +17,101 @@
under the License.
*/
-var Q = require('Q'),
-os= require('os'),
+/*jshint node:true*/
+
+var Q = require('Q');
+
+var MSBuildTools;
+try {
MSBuildTools = require('../../template/cordova/lib/MSBuildTools');
+} catch (ex) {
+// If previous import fails, we probably running this script
--- End diff --
Typo: we should be we're or we are.
Update platform check_reqs script to return structured result to
'requirements' command
---
Key: CB-8954
URL: https://issues.apache.org/jira/browse/CB-8954
Project: Apache Cordova
Issue Type: Bug
Components: Android, iOS, Windows, WP8
Reporter: Vladimir Kotikov
Assignee: Vladimir Kotikov
Since {{requirements}} LIB method assumes that underlying platform script
will be {{require}}d instead of spawning child process and capturing output,
we need to modify these scripts to provide method that will be called for
getting current requirements status.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8954) Update platform check_reqs script to return structured result to 'requirements' command
[
https://issues.apache.org/jira/browse/CB-8954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555867#comment-14555867
]
ASF GitHub Bot commented on CB-8954:
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-ios/pull/142
CB-8954 Adds support for `requirements` command
Implemetation for https://issues.apache.org/jira/browse/CB-8954
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-ios CB-8954
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/142.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #142
commit f376e9501153883b09799e9bda9aac5650d058f5
Author: Vladimir Kotikov v-vlk...@microsoft.com
Date: 2015-05-05T12:08:54Z
CB-8954 Adds `requirements` command support to check_reqs module
Update platform check_reqs script to return structured result to
'requirements' command
---
Key: CB-8954
URL: https://issues.apache.org/jira/browse/CB-8954
Project: Apache Cordova
Issue Type: Bug
Components: Android, iOS, Windows, WP8
Reporter: Vladimir Kotikov
Assignee: Vladimir Kotikov
Since {{requirements}} LIB method assumes that underlying platform script
will be {{require}}d instead of spawning child process and capturing output,
we need to modify these scripts to provide method that will be called for
getting current requirements status.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8954) Update platform check_reqs script to return structured result to 'requirements' command
[
https://issues.apache.org/jira/browse/CB-8954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555870#comment-14555870
]
ASF GitHub Bot commented on CB-8954:
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-wp8/pull/82
CB-8954 Adds support for `requirements` command
Implementation for https://issues.apache.org/jira/browse/CB-8954
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-wp8 CB-8954
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-wp8/pull/82.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #82
commit 6294952199791ec6c61757bcaebd1387362fee77
Author: Vladimir Kotikov v-vlk...@microsoft.com
Date: 2015-05-05T10:32:32Z
Adds `requirements` command support to check_reqs module
Update platform check_reqs script to return structured result to
'requirements' command
---
Key: CB-8954
URL: https://issues.apache.org/jira/browse/CB-8954
Project: Apache Cordova
Issue Type: Bug
Components: Android, iOS, Windows, WP8
Reporter: Vladimir Kotikov
Assignee: Vladimir Kotikov
Since {{requirements}} LIB method assumes that underlying platform script
will be {{require}}d instead of spawning child process and capturing output,
we need to modify these scripts to provide method that will be called for
getting current requirements status.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8954) Update platform check_reqs script to return structured result to 'requirements' command
[
https://issues.apache.org/jira/browse/CB-8954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555882#comment-14555882
]
Vladimir Kotikov commented on CB-8954:
--
[~timwindsor], the place where this structure is placed - the platform's
check_reqs code. In general, the platform code will return a Promise, resolved
with array of {{Requirement}} objects, which defined as following:
{noformat}
/**
* Object thar represents one of requirements for current platform.
* @param {String} id The unique identifier for this requirement.
* @param {String} name The name of requirements. Human-readable field.
* @param {String} versionThe version of requirement installed. In some
cases could be an array of strings
*(for example, check_android_target returns an
array of android targets installed)
* @param {Boolean} installed Indicates whether the reuirement is installed or
not
*/
var Requirement = function (id, name, version, installed) {
/* The unique identifier for this requirement */
this.id = id;
/* The name of requirements. Human-readable field */
this.name = name;
/* Indicates whether the reuirement is installed or not */
this.installed = installed || false;
this.metadata = {
/* The version of requirement installed. In some cases could be an
array of strings
(for example, check_android_target returns an array of android
targets installed) */
version: version,
/* Reason of failed check, should be a string with description, why
check is failed,
and, probably, the steps to resolve/install missing requirement */
reason: undefined
};
};
{noformat}
Update platform check_reqs script to return structured result to
'requirements' command
---
Key: CB-8954
URL: https://issues.apache.org/jira/browse/CB-8954
Project: Apache Cordova
Issue Type: Bug
Components: Android, iOS, Windows, WP8
Reporter: Vladimir Kotikov
Assignee: Vladimir Kotikov
Since {{requirements}} LIB method assumes that underlying platform script
will be {{require}}d instead of spawning child process and capturing output,
we need to modify these scripts to provide method that will be called for
getting current requirements status.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8954) Update platform check_reqs script to return structured result to 'requirements' command
[
https://issues.apache.org/jira/browse/CB-8954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555866#comment-14555866
]
ASF GitHub Bot commented on CB-8954:
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-android/pull/176
CB-8954 Adds support for `requirements` command
Implemetation for https://issues.apache.org/jira/browse/CB-8954
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-android CB-8954
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/176.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #176
commit 7013b1ff01efe3a666b16e358f2028c4219b286e
Author: Vladimir Kotikov v-vlk...@microsoft.com
Date: 2015-04-22T11:24:26Z
Updates check_reqs API to aloow consume it in more advanced way.
* Updates all check_* methods to return information about version of tool
installed.
* Introduces Requirement class
* Introduces check_all method, which return result of checks instead of
resolving/failing in case of unsatisfied requirements
* Makes check_all method check all of the requirements
commit a84d5e3f168b8866273a45bae000352279a8
Author: Vladimir Kotikov v-vlk...@microsoft.com
Date: 2015-04-22T11:30:33Z
Makes error mesages a bit more descriptive.
Update platform check_reqs script to return structured result to
'requirements' command
---
Key: CB-8954
URL: https://issues.apache.org/jira/browse/CB-8954
Project: Apache Cordova
Issue Type: Bug
Components: Android, iOS, Windows, WP8
Reporter: Vladimir Kotikov
Assignee: Vladimir Kotikov
Since {{requirements}} LIB method assumes that underlying platform script
will be {{require}}d instead of spawning child process and capturing output,
we need to modify these scripts to provide method that will be called for
getting current requirements status.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8954) Update platform check_reqs script to return structured result to 'requirements' command
[
https://issues.apache.org/jira/browse/CB-8954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555868#comment-14555868
]
ASF GitHub Bot commented on CB-8954:
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-windows/pull/83
CB-8954 Adds support for `requirements` command
Implementation for https://issues.apache.org/jira/browse/CB-8954
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-windows CB-8954
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/83.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #83
commit 8b6b50212dbfc6aacbf0cdda861c63ff81555295
Author: Vladimir Kotikov v-vlk...@microsoft.com
Date: 2015-05-05T10:05:55Z
Adds `requirements` command support to check_reqs module
Update platform check_reqs script to return structured result to
'requirements' command
---
Key: CB-8954
URL: https://issues.apache.org/jira/browse/CB-8954
Project: Apache Cordova
Issue Type: Bug
Components: Android, iOS, Windows, WP8
Reporter: Vladimir Kotikov
Assignee: Vladimir Kotikov
Since {{requirements}} LIB method assumes that underlying platform script
will be {{require}}d instead of spawning child process and capturing output,
we need to modify these scripts to provide method that will be called for
getting current requirements status.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8954) Update platform check_reqs script to return structured result to 'requirements' command
[
https://issues.apache.org/jira/browse/CB-8954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542689#comment-14542689
]
Tim Windsor commented on CB-8954:
-
Is there a spec for this structure defined somewhere? I'm working backwards
from the requirements.js code but I expect I may miss something.
Update platform check_reqs script to return structured result to
'requirements' command
---
Key: CB-8954
URL: https://issues.apache.org/jira/browse/CB-8954
Project: Apache Cordova
Issue Type: Bug
Components: Android, iOS, Windows, WP8
Reporter: Vladimir Kotikov
Assignee: Vladimir Kotikov
Since {{requirements}} LIB method assumes that underlying platform script
will be {{require}}d instead of spawning child process and capturing output,
we need to modify these scripts to provide method that will be called for
getting current requirements status.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
