[jira] [Commented] (CB-9158) InAppBrowser zoomControls are always set to true
[ https://issues.apache.org/jira/browse/CB-9158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14592138#comment-14592138 ] ASF GitHub Bot commented on CB-9158: Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/104#issuecomment-113225945 Agree with @purplecabbage, the iOS whitespace stripping is a blocker. InAppBrowser zoomControls are always set to true Key: CB-9158 URL: https://issues.apache.org/jira/browse/CB-9158 Project: Apache Cordova Issue Type: Bug Components: Android Affects Versions: 3.5.0 Environment: Latest InAppBrowser https://github.com/apache/cordova-plugin-inappbrowser, any Android device Reporter: Anton Antonov Labels: easyfix, patch InAppBrowser does not respect the passed options string to *window.open*. *zoom=no* or *zoom=yes* will never make a difference due to source code always assuming it's boolean true. Fix is in https://github.com/apache/cordova-plugin-inappbrowser/pull/104 P.S This is my first issue and patch on Apache JIRA. Feedback is appreciated. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9158) InAppBrowser zoomControls are always set to true
[ https://issues.apache.org/jira/browse/CB-9158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14592152#comment-14592152 ] ASF GitHub Bot commented on CB-9158: Github user syndbg commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/104#issuecomment-113228209 Alright. Sorry for the delays guys. Rebased latest upstream master, didn't commit the iOS file and updated the commit message to make more sense. InAppBrowser zoomControls are always set to true Key: CB-9158 URL: https://issues.apache.org/jira/browse/CB-9158 Project: Apache Cordova Issue Type: Bug Components: Android Affects Versions: 3.5.0 Environment: Latest InAppBrowser https://github.com/apache/cordova-plugin-inappbrowser, any Android device Reporter: Anton Antonov Labels: easyfix, patch InAppBrowser does not respect the passed options string to *window.open*. *zoom=no* or *zoom=yes* will never make a difference due to source code always assuming it's boolean true. Fix is in https://github.com/apache/cordova-plugin-inappbrowser/pull/104 P.S This is my first issue and patch on Apache JIRA. Feedback is appreciated. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9158) InAppBrowser zoomControls are always set to true
[ https://issues.apache.org/jira/browse/CB-9158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14592625#comment-14592625 ] ASF subversion and git services commented on CB-9158: - Commit 74aa099b7e69ddc067a46c06e20d593ef5a0874a in cordova-plugin-inappbrowser's branch refs/heads/master from [~syndbg] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=74aa099 ] CB-9158 - InAppBrowser zoomControls are always set to true InAppBrowser zoomControls are always set to true Key: CB-9158 URL: https://issues.apache.org/jira/browse/CB-9158 Project: Apache Cordova Issue Type: Bug Components: Android Affects Versions: 3.5.0 Environment: Latest InAppBrowser https://github.com/apache/cordova-plugin-inappbrowser, any Android device Reporter: Anton Antonov Labels: easyfix, patch InAppBrowser does not respect the passed options string to *window.open*. *zoom=no* or *zoom=yes* will never make a difference due to source code always assuming it's boolean true. Fix is in https://github.com/apache/cordova-plugin-inappbrowser/pull/104 P.S This is my first issue and patch on Apache JIRA. Feedback is appreciated. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9158) InAppBrowser zoomControls are always set to true
[ https://issues.apache.org/jira/browse/CB-9158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14592627#comment-14592627 ] ASF GitHub Bot commented on CB-9158: Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/104 InAppBrowser zoomControls are always set to true Key: CB-9158 URL: https://issues.apache.org/jira/browse/CB-9158 Project: Apache Cordova Issue Type: Bug Components: Android Affects Versions: 3.5.0 Environment: Latest InAppBrowser https://github.com/apache/cordova-plugin-inappbrowser, any Android device Reporter: Anton Antonov Labels: easyfix, patch InAppBrowser does not respect the passed options string to *window.open*. *zoom=no* or *zoom=yes* will never make a difference due to source code always assuming it's boolean true. Fix is in https://github.com/apache/cordova-plugin-inappbrowser/pull/104 P.S This is my first issue and patch on Apache JIRA. Feedback is appreciated. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9158) InAppBrowser zoomControls are always set to true
[ https://issues.apache.org/jira/browse/CB-9158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14592635#comment-14592635 ] ASF GitHub Bot commented on CB-9158: Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/104#issuecomment-113302682 I have tested the change, and verified it. So it is now merged. Thanks for the contribution @syndbg Some great next steps would be to document the feature (under android quirks) and to add a manual test to the list in the /tests/tests.js file. InAppBrowser zoomControls are always set to true Key: CB-9158 URL: https://issues.apache.org/jira/browse/CB-9158 Project: Apache Cordova Issue Type: Bug Components: Android Affects Versions: 3.5.0 Environment: Latest InAppBrowser https://github.com/apache/cordova-plugin-inappbrowser, any Android device Reporter: Anton Antonov Labels: easyfix, patch InAppBrowser does not respect the passed options string to *window.open*. *zoom=no* or *zoom=yes* will never make a difference due to source code always assuming it's boolean true. Fix is in https://github.com/apache/cordova-plugin-inappbrowser/pull/104 P.S This is my first issue and patch on Apache JIRA. Feedback is appreciated. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9158) InAppBrowser zoomControls are always set to true
[ https://issues.apache.org/jira/browse/CB-9158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14590781#comment-14590781 ] ASF GitHub Bot commented on CB-9158: Github user syndbg commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/104#issuecomment-112974072 @purplecabbage Good catch. In the JIRA ticket, unfortunately I've pasted the wrong option parameter, `location`, when in fact I meant `zoom`. This PR fixes `zoom=true` or `zoom=false` not making a difference in the android app. Can we agree on the fact that fixing (in my opinion) non-formatted code, even in the iOS section of the plugin, should not be a blocker to merge this PR. InAppBrowser zoomControls are always set to true Key: CB-9158 URL: https://issues.apache.org/jira/browse/CB-9158 Project: Apache Cordova Issue Type: Bug Components: Android Affects Versions: 3.5.0 Environment: Latest InAppBrowser https://github.com/apache/cordova-plugin-inappbrowser, any Android device Reporter: Anton Antonov Labels: easyfix, patch InAppBrowser does not respect the passed options string to *window.open*. *zoom=no* or *zoom=yes* will never make a difference due to source code always assuming it's boolean true. Fix is in https://github.com/apache/cordova-plugin-inappbrowser/pull/104 P.S This is my first issue and patch on Apache JIRA. Feedback is appreciated. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9158) InAppBrowser zoomControls are always set to true
[ https://issues.apache.org/jira/browse/CB-9158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14590790#comment-14590790 ] ASF GitHub Bot commented on CB-9158: Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/104#issuecomment-112974712 It is a blocker typically. Modifications should be restricted to resolving the issue at hand, or at the bare minimum whitespace/formatting changes should be in their own commit. Reviewing pull requests is enough work without the overhead of having to manually sort through what is relevant. InAppBrowser zoomControls are always set to true Key: CB-9158 URL: https://issues.apache.org/jira/browse/CB-9158 Project: Apache Cordova Issue Type: Bug Components: Android Affects Versions: 3.5.0 Environment: Latest InAppBrowser https://github.com/apache/cordova-plugin-inappbrowser, any Android device Reporter: Anton Antonov Labels: easyfix, patch InAppBrowser does not respect the passed options string to *window.open*. *zoom=no* or *zoom=yes* will never make a difference due to source code always assuming it's boolean true. Fix is in https://github.com/apache/cordova-plugin-inappbrowser/pull/104 P.S This is my first issue and patch on Apache JIRA. Feedback is appreciated. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9158) InAppBrowser zoomControls are always set to true
[ https://issues.apache.org/jira/browse/CB-9158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14587865#comment-14587865 ] ASF GitHub Bot commented on CB-9158: Github user syndbg commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/104#issuecomment-112385310 The white spaces are automatically stripped by my text editor. InAppBrowser zoomControls are always set to true Key: CB-9158 URL: https://issues.apache.org/jira/browse/CB-9158 Project: Apache Cordova Issue Type: Bug Components: Android Affects Versions: 3.5.0 Environment: Latest InAppBrowser https://github.com/apache/cordova-plugin-inappbrowser, any Android device Reporter: Anton Antonov Labels: easyfix, patch InAppBrowser does not respect the passed options string to *window.open*. *location=no* or *location=yes* will never make a difference due to source code always assuming it's boolean true. Fix is in https://github.com/apache/cordova-plugin-inappbrowser/pull/104 P.S This is my first issue and patch on Apache JIRA. Feedback is appreciated. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9158) InAppBrowser zoomControls are always set to true
[ https://issues.apache.org/jira/browse/CB-9158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14587077#comment-14587077 ] ASF GitHub Bot commented on CB-9158: Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/104#issuecomment-112232035 Why does this pull request touch iOS? Can you make it so that it's only Android? InAppBrowser zoomControls are always set to true Key: CB-9158 URL: https://issues.apache.org/jira/browse/CB-9158 Project: Apache Cordova Issue Type: Bug Components: Android Affects Versions: 3.5.0 Environment: Latest InAppBrowser https://github.com/apache/cordova-plugin-inappbrowser, any Android device Reporter: Anton Antonov Labels: easyfix, patch InAppBrowser does not respect the passed options string to *window.open*. *location=no* or *location=yes* will never make a difference due to source code always assuming it's boolean true. Fix is in https://github.com/apache/cordova-plugin-inappbrowser/pull/104 P.S This is my first issue and patch on Apache JIRA. Feedback is appreciated. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9158) InAppBrowser zoomControls are always set to true
[ https://issues.apache.org/jira/browse/CB-9158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14587085#comment-14587085 ] ASF GitHub Bot commented on CB-9158: Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/104#issuecomment-112232437 Numerous issues here .. removing whitespace from the diff reveals only minor changes. The changes however do not address the issue as reported in JIRA. InAppBrowser zoomControls are always set to true Key: CB-9158 URL: https://issues.apache.org/jira/browse/CB-9158 Project: Apache Cordova Issue Type: Bug Components: Android Affects Versions: 3.5.0 Environment: Latest InAppBrowser https://github.com/apache/cordova-plugin-inappbrowser, any Android device Reporter: Anton Antonov Labels: easyfix, patch InAppBrowser does not respect the passed options string to *window.open*. *location=no* or *location=yes* will never make a difference due to source code always assuming it's boolean true. Fix is in https://github.com/apache/cordova-plugin-inappbrowser/pull/104 P.S This is my first issue and patch on Apache JIRA. Feedback is appreciated. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9158) InAppBrowser zoomControls are always set to true
[
https://issues.apache.org/jira/browse/CB-9158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14581672#comment-14581672
]
ASF GitHub Bot commented on CB-9158:
Github user syndbg commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/104#discussion_r32199198
--- Diff: src/android/InAppBrowser.java ---
@@ -656,7 +647,7 @@ public void onClick(View v) {
WebSettings settings = inAppWebView.getSettings();
settings.setJavaScriptEnabled(true);
settings.setJavaScriptCanOpenWindowsAutomatically(true);
-settings.setBuiltInZoomControls(getShowZoomControls());
+settings.setBuiltInZoomControls(showZoomControls);
--- End diff --
here's the issue
InAppBrowser zoomControls are always set to true
Key: CB-9158
URL: https://issues.apache.org/jira/browse/CB-9158
Project: Apache Cordova
Issue Type: Bug
Components: Android
Affects Versions: 3.5.0
Environment: Latest InAppBrowser
https://github.com/apache/cordova-plugin-inappbrowser, any Android device
Reporter: Anton Antonov
Labels: easyfix, patch
InAppBrowser does not respect the passed options string to *window.open*.
*location=no* or *location=yes* will never make a difference due to source
code always assuming it's boolean true.
Fix is in https://github.com/apache/cordova-plugin-inappbrowser/pull/104
P.S This is my first issue and patch on Apache JIRA. Feedback is appreciated.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
