[jira] [Commented] (FLINK-16105) Translate "User-defined Sources & Sinks" page of "Table API & SQL" into Chinese

2020-06-09 Thread Benchao Li (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-16105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17130100#comment-17130100
 ] 

Benchao Li commented on FLINK-16105:


[~wangsong] Thanks for taking this, assigned to you~

> Translate "User-defined Sources & Sinks" page of "Table API & SQL" into 
> Chinese 
> 
>
> Key: FLINK-16105
> URL: https://issues.apache.org/jira/browse/FLINK-16105
> Project: Flink
>  Issue Type: Sub-task
>  Components: chinese-translation, Documentation
>Reporter: Jark Wu
>Assignee: wangsong
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The page url is 
> https://ci.apache.org/projects/flink/flink-docs-master/zh/dev/table/sourceSinks.html
> The markdown file is located in {{flink/docs/dev/table/sourceSinks.zh.md}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (FLINK-16105) Translate "User-defined Sources & Sinks" page of "Table API & SQL" into Chinese

2020-06-09 Thread Benchao Li (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-16105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benchao Li reassigned FLINK-16105:
--

Assignee: wangsong  (was: Benchao Li)

> Translate "User-defined Sources & Sinks" page of "Table API & SQL" into 
> Chinese 
> 
>
> Key: FLINK-16105
> URL: https://issues.apache.org/jira/browse/FLINK-16105
> Project: Flink
>  Issue Type: Sub-task
>  Components: chinese-translation, Documentation
>Reporter: Jark Wu
>Assignee: wangsong
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The page url is 
> https://ci.apache.org/projects/flink/flink-docs-master/zh/dev/table/sourceSinks.html
> The markdown file is located in {{flink/docs/dev/table/sourceSinks.zh.md}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-18230) Table API has no Functions like sparkSQL explode

2020-06-09 Thread mzz (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-18230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17130097#comment-17130097
 ] 

mzz commented on FLINK-18230:
-

As for my SQL, my idea is to flattening nest Array like sparksql.explode 
function
SparkSQL.eg:
"select ip, ts,launchs,adv.`count` from aggs_test LATERAL VIEW explode(advs) a 
AS adv"

> Table API has no Functions like  sparkSQL explode
> -
>
> Key: FLINK-18230
> URL: https://issues.apache.org/jira/browse/FLINK-18230
> Project: Flink
>  Issue Type: Improvement
>Reporter: mzz
>Priority: Major
>
> streamTableEnvironment.connect(new Kafka()
>   .topic(TOPIC)
>   .version(VERSION)
>   .startFromEarliest()
>   .property("bootstrap.servers", "172.16.30.207:9092")
>   .property("group.id", "km_aggs_group_3")
> )
>   .withFormat(
> new Json()
>   .failOnMissingField(true)
>   .deriveSchema()
>   )
>   .withSchema(new Schema()
> .field("devs", Types.STRING())
> .field("advs", ObjectArrayTypeInfo.getInfoFor(new 
> Array[Row](0).getClass,
> Types.ROW(Array("count", "eventid", "sid", "params"), 
> Array[TypeInformation[_]](Types.STRING(), Types.STRING, Types.STRING,
>   Types.ROW(Array("adid", "adtype", "ecpm"), 
> Array[TypeInformation[_]](Types.STRING, Types.STRING, Types.STRING
>   ))
> .field("identity", Types.STRING())
> .field("ip", Types.STRING())
> .field("launchs", Types.STRING())
> .field("ts", Types.STRING())
>   )
>   .inAppendMode()
>   .registerTableSource("aggs_test")
> val tableResult = streamTableEnvironment.sqlQuery("select ip, 
> ts,launchs,advs[1].`count` from aggs_test")
> tableResult.printSchema()
> streamTableEnvironment.toAppendStream[Row](tableResult).print()



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (FLINK-18230) Table API has no Functions like sparkSQL explode

2020-06-09 Thread mzz (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-18230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

mzz updated FLINK-18230:

Issue Type: Improvement  (was: Bug)

> Table API has no Functions like  sparkSQL explode
> -
>
> Key: FLINK-18230
> URL: https://issues.apache.org/jira/browse/FLINK-18230
> Project: Flink
>  Issue Type: Improvement
>Reporter: mzz
>Priority: Major
>
> streamTableEnvironment.connect(new Kafka()
>   .topic(TOPIC)
>   .version(VERSION)
>   .startFromEarliest()
>   .property("bootstrap.servers", "172.16.30.207:9092")
>   .property("group.id", "km_aggs_group_3")
> )
>   .withFormat(
> new Json()
>   .failOnMissingField(true)
>   .deriveSchema()
>   )
>   .withSchema(new Schema()
> .field("devs", Types.STRING())
> .field("advs", ObjectArrayTypeInfo.getInfoFor(new 
> Array[Row](0).getClass,
> Types.ROW(Array("count", "eventid", "sid", "params"), 
> Array[TypeInformation[_]](Types.STRING(), Types.STRING, Types.STRING,
>   Types.ROW(Array("adid", "adtype", "ecpm"), 
> Array[TypeInformation[_]](Types.STRING, Types.STRING, Types.STRING
>   ))
> .field("identity", Types.STRING())
> .field("ip", Types.STRING())
> .field("launchs", Types.STRING())
> .field("ts", Types.STRING())
>   )
>   .inAppendMode()
>   .registerTableSource("aggs_test")
> val tableResult = streamTableEnvironment.sqlQuery("select ip, 
> ts,launchs,advs[1].`count` from aggs_test")
> tableResult.printSchema()
> streamTableEnvironment.toAppendStream[Row](tableResult).print()



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink-web] klion26 commented on a change in pull request #345: [FLINK-17491] Translate Training page on project website

2020-06-09 Thread GitBox


klion26 commented on a change in pull request #345:
URL: https://github.com/apache/flink-web/pull/345#discussion_r437873298



##
File path: training.zh.md
##
@@ -1,54 +1,52 @@
 ---
-title: "Training Course"
+title: "培训课程"
 ---
 
 
 
-The Apache Flink community maintains a self-paced training course that contains
-a set of lessons and hands-on exercises. This step-by-step introduction to 
Flink focuses
-on learning how to use the DataStream API to meet the needs of common, 
real-world use cases.
+Apache Flink 社区维护了一套自学培训课程,包括了一系列课程和上手练习。 这个对 Flink 的逐步介绍关注于学习如何使用 DataStream 
API 来满足常见的实际使用需求。

Review comment:
   `这个对 Flink 的逐步介绍关注于学习如何使用 DataStream API 来满足常见的实际使用需求。` 这句话感觉有点拗口。能否修改一下呢

##
File path: training.zh.md
##
@@ -58,49 +56,49 @@ This training covers the fundamentals of Flink, including:
 
 
 
- Streaming 
Analytics
+ 流式分析
 
 
 
-Event Time Processing
-Watermarks
-Windows
+事件时间处理
+水印
+窗口
 
 
 
 
 
 
 
- 
Event-driven Applications
+ 事件驱动的应用
 
 
 
-Process Functions
-Timers
-Side Outputs
+处理函数
+定时器
+旁路输出
 
 
 
 
 
 
 
- Fault 
Tolerance
+ 容错
 
 
 
-Checkpoints and Savepoints
-Exactly-once vs. At-least-once
-Exactly-once End-to-end
+Checkpoints 和 Savepoints
+精确一次与至少一次
+精确一次的端到端

Review comment:
   `端到端的精确一次` 会更好一些吗?

##
File path: training.zh.md
##
@@ -58,49 +56,49 @@ This training covers the fundamentals of Flink, including:
 
 
 
- Streaming 
Analytics
+ 流式分析
 
 
 
-Event Time Processing
-Watermarks
-Windows
+事件时间处理
+水印

Review comment:
   watermark 可以不翻译,可以参考 
[wiki](https://cwiki.apache.org/confluence/display/FLINK/Flink+Translation+Specifications)

##
File path: training.zh.md
##
@@ -1,54 +1,52 @@
 ---
-title: "Training Course"
+title: "培训课程"
 ---
 
 
 
-The Apache Flink community maintains a self-paced training course that contains
-a set of lessons and hands-on exercises. This step-by-step introduction to 
Flink focuses
-on learning how to use the DataStream API to meet the needs of common, 
real-world use cases.
+Apache Flink 社区维护了一套自学培训课程,包括了一系列课程和上手练习。 这个对 Flink 的逐步介绍关注于学习如何使用 DataStream 
API 来满足常见的实际使用需求。
 
-This training covers the fundamentals of Flink, including:
+这个培训涵盖了 Flink 的基础知识,包括:
 
 
 
 
 
-  Intro 
to Flink
+  Flink 
简介
 
 
 
-Batch vs. Streaming
-Parallel Dataflows
-State, Time, and Snapshots
+批处理与流处理
+并行的数据流
+状态、时间和快照
 
 
 
 
 
 
 
- Intro to 
the DataStream API
+ DataStream 
API 简介
 
 
 
-Data Types and Serialization
-Architecture
-Sources and Sinks
+数据类型和序列化
+架构
+数据源和 Sink

Review comment:
   Source 和 sink 建议都继续翻译,和网站其他翻译保持一致





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Created] (FLINK-18230) Table API has no Functions like sparkSQL explode

2020-06-09 Thread mzz (Jira)
mzz created FLINK-18230:
---

 Summary: Table API has no Functions like  sparkSQL explode
 Key: FLINK-18230
 URL: https://issues.apache.org/jira/browse/FLINK-18230
 Project: Flink
  Issue Type: Bug
Reporter: mzz


streamTableEnvironment.connect(new Kafka()
  .topic(TOPIC)
  .version(VERSION)
  .startFromEarliest()
  .property("bootstrap.servers", "172.16.30.207:9092")
  .property("group.id", "km_aggs_group_3")
)
  .withFormat(
new Json()
  .failOnMissingField(true)
  .deriveSchema()
  )
  .withSchema(new Schema()
.field("devs", Types.STRING())
.field("advs", ObjectArrayTypeInfo.getInfoFor(new 
Array[Row](0).getClass,
Types.ROW(Array("count", "eventid", "sid", "params"), 
Array[TypeInformation[_]](Types.STRING(), Types.STRING, Types.STRING,
  Types.ROW(Array("adid", "adtype", "ecpm"), 
Array[TypeInformation[_]](Types.STRING, Types.STRING, Types.STRING
  ))
.field("identity", Types.STRING())
.field("ip", Types.STRING())
.field("launchs", Types.STRING())
.field("ts", Types.STRING())
  )
  .inAppendMode()
  .registerTableSource("aggs_test")

val tableResult = streamTableEnvironment.sqlQuery("select ip, 
ts,launchs,advs[1].`count` from aggs_test")
tableResult.printSchema()
streamTableEnvironment.toAppendStream[Row](tableResult).print()



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (FLINK-18228) Release pending pods/containers timely when pending slots changed

2020-06-09 Thread Yang Wang (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-18228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yang Wang closed FLINK-18228.
-
Resolution: Duplicate

> Release pending pods/containers timely when pending slots changed
> -
>
> Key: FLINK-18228
> URL: https://issues.apache.org/jira/browse/FLINK-18228
> Project: Flink
>  Issue Type: Improvement
>  Components: Deployment / Kubernetes, Deployment / YARN, Runtime / 
> Coordination
>Affects Versions: 1.12.0
>Reporter: Yang Wang
>Priority: Major
>
> Currently, when we deploy a session cluster on Yarn/K8s and submit a job into 
> the existing cluster, some pending pods/containers may be created due to no 
> enough resource. Even the job will fail with slot allocation timeout or be 
> canceled, the pending pods/containers will still be there. Until allocated 
> and launched, they could be released via TaskManager idle timeout.
>  
> This behavior how to release the pending pods/containers could be improved. 
> Once the pending slots changed in the {{SlotManager}}, it could notify the 
> {{ActiveResourceManager}} to do some corresponding actions(e.g. release the 
> needless pending pods). This will help a lot when the cluster is small and do 
> not have too much available resources.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] zjffdu commented on a change in pull request #12346: [FLINK-17944][sql-client] Wrong output in sql client's table mode

2020-06-09 Thread GitBox


zjffdu commented on a change in pull request #12346:
URL: https://github.com/apache/flink/pull/12346#discussion_r437868981



##
File path: 
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/result/MaterializedCollectStreamResult.java
##
@@ -224,7 +224,7 @@ private void processDelete(Row row) {
}
 
for (int i = startSearchPos; i >= validRowPosition; i--) {
-   if (materializedTable.get(i).equals(row)) {
+   if (materializedTable.get(i).fieldsEquals(row)) {
materializedTable.remove(i);
rowPositionCache.remove(row);

Review comment:
   ping @twalthr 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (FLINK-13554) ResourceManager should have a timeout on starting new TaskExecutors.

2020-06-09 Thread Xintong Song (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-13554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17130083#comment-17130083
 ] 

Xintong Song commented on FLINK-13554:
--

FYI, I've created FLINK-18229, which I believe is related to this ticket.

> ResourceManager should have a timeout on starting new TaskExecutors.
> 
>
> Key: FLINK-13554
> URL: https://issues.apache.org/jira/browse/FLINK-13554
> Project: Flink
>  Issue Type: Improvement
>  Components: Runtime / Coordination
>Affects Versions: 1.9.0
>Reporter: Xintong Song
>Assignee: Till Rohrmann
>Priority: Critical
> Fix For: 1.12.0
>
>
> Recently, we encountered a case that one TaskExecutor get stuck during 
> launching on Yarn (without fail), causing that job cannot recover from 
> continuous failovers.
> The reason the TaskExecutor gets stuck is due to our environment problem. The 
> TaskExecutor gets stuck somewhere after the ResourceManager starts the 
> TaskExecutor and waiting for the TaskExecutor to be brought up and register. 
> Later when the slot request timeouts, the job fails over and requests slots 
> from ResourceManager again, the ResourceManager still see a TaskExecutor (the 
> stuck one) is being started and will not request new container from Yarn. 
> Therefore, the job can not recover from failure.
> I think to avoid such unrecoverable status, the ResourceManager need to have 
> a timeout on starting new TaskExecutor. If the starting of TaskExecutor takes 
> too long, it should just fail the TaskExecutor and starts a new one.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (FLINK-18136) Don't start channel state writing for savepoints (RPC)

2020-06-09 Thread Zhijiang (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-18136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129018#comment-17129018
 ] 

Zhijiang edited comment on FLINK-18136 at 6/10/20, 5:27 AM:


Merged in master: 6dc624d931858e0ee5da14bc6b41b834c94cbba7

Merged in release-1.11: 7f410fa4f4758e48fcc6c33d8354c21ab02e2dc6


was (Author: zjwang):
Merged in master: 6dc624d931858e0ee5da14bc6b41b834c94cbba7

> Don't start channel state writing for savepoints (RPC)
> --
>
> Key: FLINK-18136
> URL: https://issues.apache.org/jira/browse/FLINK-18136
> Project: Flink
>  Issue Type: Bug
>  Components: Runtime / Checkpointing, Runtime / Task
>Affects Versions: 1.11.0
>Reporter: Roman Khachatryan
>Assignee: Roman Khachatryan
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.11.0, 1.12.0
>
>
> ChannelStateWriter#start should be only called for unaligned checkpoint. 
> While source triggering savepoint, 
> SubtaskCheckpointCoordinator#initCheckpoint is introduced to judge the 
> condition whether to start the internal writer or not. And this new method is 
> also used in other places like CheckpointBarrierUnaligner.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] zhijiangW merged pull request #12545: [FLINK-18136] Don't start channel state writing for savepoints (backport to 1.11)

2020-06-09 Thread GitBox


zhijiangW merged pull request #12545:
URL: https://github.com/apache/flink/pull/12545


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (FLINK-17976) Test native K8s integration

2020-06-09 Thread Xintong Song (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-17976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17130080#comment-17130080
 ] 

Xintong Song commented on FLINK-17976:
--

And FLINK-18229 for question #2. But I guess this is rather an improvement than 
a 1.11.0 blocker.

> Test native K8s integration
> ---
>
> Key: FLINK-17976
> URL: https://issues.apache.org/jira/browse/FLINK-17976
> Project: Flink
>  Issue Type: Sub-task
>  Components: Runtime / Coordination
>Affects Versions: 1.11.0
>Reporter: Till Rohrmann
>Assignee: Robert Metzger
>Priority: Critical
>  Labels: pull-request-available, release-testing
> Fix For: 1.11.0
>
> Attachments: enough_tm_wait_5min.txt
>
>
> Test Flink's native K8s integration:
> * session mode
> * application mode
> * custom Flink image
> * custom configuration and log properties



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (FLINK-18229) Pending worker requests should be properly cleared

2020-06-09 Thread Xintong Song (Jira)
Xintong Song created FLINK-18229:


 Summary: Pending worker requests should be properly cleared
 Key: FLINK-18229
 URL: https://issues.apache.org/jira/browse/FLINK-18229
 Project: Flink
  Issue Type: Improvement
  Components: Deployment / Kubernetes, Deployment / YARN, Runtime / 
Coordination
Affects Versions: 1.10.1, 1.9.3, 1.11.0
Reporter: Xintong Song


Currently, if Kubernetes/Yarn does not have enough resources to fulfill Flink's 
resource requirement, there will be pending pod/container requests on 
Kubernetes/Yarn. These pending resource requirements are never cleared until 
either fulfilled or the Flink cluster is shutdown.

However, sometimes Flink no longer needs the pending resources. E.g., the slot 
request is then fulfilled by another slots that become available, or the job 
failed due to slot request timeout (in a session cluster). In such cases, Flink 
does not remove the resource request until the resource is allocated, then it 
discovers that it no longer needs the allocated resource and release them. This 
would affect the underlying Kubernetes/Yarn cluster, especially when the 
cluster is under heavy workload.

It would be good for Flink to cancel pod/container requests as earlier as 
possible if it can discover that some of the pending workers are no longer 
needed.

There are several approaches potentially achieve this.
 # We can always check whether there's a pending worker that can be canceled 
when a \{{PendingTaskManagerSlot}} is unassigned.
 # We can have a separate timeout for requesting new worker. If the resource 
cannot be allocated within the given time since requested, we should cancel 
that resource request and claim a resource allocation failure.
 # We can share the same timeout for starting new worker (proposed in 
FLINK-13554). This is similar to 2), but it requires the worker to be 
registered, rather than allocated, before timeout.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] wangyang0918 commented on a change in pull request #12549: [FLINK-18084][docs] Document the Application Mode

2020-06-09 Thread GitBox


wangyang0918 commented on a change in pull request #12549:
URL: https://github.com/apache/flink/pull/12549#discussion_r437844204



##
File path: 
flink-clients/src/main/java/org/apache/flink/client/cli/GenericCLI.java
##
@@ -44,19 +44,23 @@
  * for further parsing.
  */
 @Internal
-public class ExecutorCLI implements CustomCommandLine {
+public class GenericCLI implements CustomCommandLine {
 
-   private static final Logger LOG = 
LoggerFactory.getLogger(ExecutorCLI.class);
+   private static final Logger LOG = 
LoggerFactory.getLogger(GenericCLI.class);
 
private static final String ID = "Generic CLI";
 
private final Option executorOption = new Option("e", "executor", true,
-   "The name of the executor to be used for executing the 
given job, which is equivalent " +
+   "DEPRECATED: Please use the -t option instead which is 
also available with the \"Application Mode\".\n" +

Review comment:
   I am not sure whether we need to update the existing usage of 
`-e/--executor`. For example, here[1] in the native K8s document.
   
   [1]. 
https://ci.apache.org/projects/flink/flink-docs-master/ops/deployment/native_kubernetes.html#submitting-jobs-to-an-existing-session

##
File path: docs/ops/deployment/yarn_setup.md
##
@@ -251,6 +250,31 @@ The user-jars position in the class path can be controlled 
by setting the parame
 - `FIRST`: Adds the jar to the beginning of the system class path.
 - `LAST`: Adds the jar to the end of the system class path.
 
+## Run an application in Application Mode
+
+To launch an application in [Application Mode]({% link ops/deployment/index.md 
%}#deployment-modes), you can type:
+
+{% highlight bash %}
+./bin/flink run-application -t yarn-application ./examples/batch/WordCount.jar
+{% endhighlight %}
+
+
+  Attention: Apart from the `-t`, all other configuration 
parameters, such as the path 
+  to the savepoint to be used to bootstrap the application's state, the 
application parallelism or the 
+  required job manager/task manager memory sizes, can be specified by their 
configuration option, 
+  prefixed by `-D`.
+
+  
+As an example, the command to specify the memory sizes of the JM and the TM, 
looks like:
+
+{% highlight bash %}
+./bin/flink run-application -t yarn-application 
-Djobmanager.memory.process.size=2048m -Dtaskmanager.memory.process.size=4096m  
./examples/batch/WordCount.jar
+{% endhighlight %}
+

Review comment:
   I suggest to add `remote user jar` and `provided lib` support in the 
document. It will make the submission more like a pure application. Almost 
everything is done on the cluster side. Starting a Flink application will be 
very fast.
   
   Maybe it is out of the scope of this PR. And we do it in a separate one 
later.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (FLINK-16105) Translate "User-defined Sources & Sinks" page of "Table API & SQL" into Chinese

2020-06-09 Thread wangsong (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-16105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17130074#comment-17130074
 ] 

wangsong commented on FLINK-16105:
--

Hi benchao,
    Do you still have time to do this, I am very interested in this, and I want 
do some job for flink,can I help to do that?
Thank you

> Translate "User-defined Sources & Sinks" page of "Table API & SQL" into 
> Chinese 
> 
>
> Key: FLINK-16105
> URL: https://issues.apache.org/jira/browse/FLINK-16105
> Project: Flink
>  Issue Type: Sub-task
>  Components: chinese-translation, Documentation
>Reporter: Jark Wu
>Assignee: Benchao Li
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The page url is 
> https://ci.apache.org/projects/flink/flink-docs-master/zh/dev/table/sourceSinks.html
> The markdown file is located in {{flink/docs/dev/table/sourceSinks.zh.md}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (FLINK-17976) Test native K8s integration

2020-06-09 Thread Yang Wang (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-17976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129965#comment-17129965
 ] 

Yang Wang edited comment on FLINK-17976 at 6/10/20, 5:00 AM:
-

For question #1, it is probably a bug or improvement of 
{{ActiveResourceManager}}. Currently, we decrease the pending workers after 
allocated, not TaskManager registered. So both in K8s and Yarn, we may come 
into this issue. cc [~xintongsong], i think you could give more suggestions 
here.

 

For question #2, make the pending pods/containers could be released when we do 
not need any pods/containers(e.g. Flink job failed/canceled). I have created a 
new ticket FLINK-18228 to track this.


was (Author: fly_in_gis):
For question #1, it is probably a bug or improvement of 
{{ActiveResourceManager}}. Currently, we decrease the pending workers after 
allocated, not TaskManager registered. So both in K8s and Yarn, we may come 
into this issue. cc [~xintongsong], i think you could give more suggestions 
here.

 

For question #2, make the pending pods/containers could be released when we do 
not need any pods/containers(e.g. Flink job failed/canceled). I will create a 
new ticket to track this.

> Test native K8s integration
> ---
>
> Key: FLINK-17976
> URL: https://issues.apache.org/jira/browse/FLINK-17976
> Project: Flink
>  Issue Type: Sub-task
>  Components: Runtime / Coordination
>Affects Versions: 1.11.0
>Reporter: Till Rohrmann
>Assignee: Robert Metzger
>Priority: Critical
>  Labels: pull-request-available, release-testing
> Fix For: 1.11.0
>
> Attachments: enough_tm_wait_5min.txt
>
>
> Test Flink's native K8s integration:
> * session mode
> * application mode
> * custom Flink image
> * custom configuration and log properties



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (FLINK-18228) Release pending pods/containers timely when pending slots changed

2020-06-09 Thread Yang Wang (Jira)
Yang Wang created FLINK-18228:
-

 Summary: Release pending pods/containers timely when pending slots 
changed
 Key: FLINK-18228
 URL: https://issues.apache.org/jira/browse/FLINK-18228
 Project: Flink
  Issue Type: Improvement
  Components: Deployment / Kubernetes, Deployment / YARN, Runtime / 
Coordination
Affects Versions: 1.12.0
Reporter: Yang Wang


Currently, when we deploy a session cluster on Yarn/K8s and submit a job into 
the existing cluster, some pending pods/containers may be created due to no 
enough resource. Even the job will fail with slot allocation timeout or be 
canceled, the pending pods/containers will still be there. Until allocated and 
launched, they could be released via TaskManager idle timeout.

 

This behavior how to release the pending pods/containers could be improved. 
Once the pending slots changed in the {{SlotManager}}, it could notify the 
{{ActiveResourceManager}} to do some corresponding actions(e.g. release the 
needless pending pods). This will help a lot when the cluster is small and do 
not have too much available resources.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] flinkbot edited a comment on pull request #12567: [FLINK-15849][doc] Update SQL-CLIENT document from type to data-type

2020-06-09 Thread GitBox


flinkbot edited a comment on pull request #12567:
URL: https://github.com/apache/flink/pull/12567#issuecomment-641709980


   
   ## CI report:
   
   * 76c6bca81f3834034fb8a530cf1916fac6793d25 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3121)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #12554: [FLINK-18218][python][e2e] Add yarn perjob, java dependency management e2e tests for pyflink.

2020-06-09 Thread GitBox


flinkbot edited a comment on pull request #12554:
URL: https://github.com/apache/flink/pull/12554#issuecomment-641294850


   
   ## CI report:
   
   * 561fef4b26a6b3e393daaea5f97135deb19e9070 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3103)
 
   * b0a13736a1137b58f6d75cb5fabb7e09ef3314e9 UNKNOWN
   * d9d29d6a9c67ab9749f69049062818e463179a45 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3117)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`

2020-06-09 Thread GitBox


flinkbot edited a comment on pull request #12566:
URL: https://github.com/apache/flink/pull/12566#issuecomment-641701238


   
   ## CI report:
   
   * 4086eac47b36d124dd13d8a15261bcc823b89e74 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3118)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot commented on pull request #12567: [FLINK-15849][doc] Update SQL-CLIENT document from type to data-type

2020-06-09 Thread GitBox


flinkbot commented on pull request #12567:
URL: https://github.com/apache/flink/pull/12567#issuecomment-641709980


   
   ## CI report:
   
   * 76c6bca81f3834034fb8a530cf1916fac6793d25 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #12527: [FLINK-18173][build] Bundle flink-csv,flink-json,flink-avro jars in lib

2020-06-09 Thread GitBox


flinkbot edited a comment on pull request #12527:
URL: https://github.com/apache/flink/pull/12527#issuecomment-640564258


   
   ## CI report:
   
   * 861e2a4a123eeca7e81cf1e932a3e0cdff2f1a2e Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3114)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (FLINK-17688) Support consuming Kinesis' enhanced fanout for flink-connector-kinesis

2020-06-09 Thread Tzu-Li (Gordon) Tai (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-17688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17130040#comment-17130040
 ] 

Tzu-Li (Gordon) Tai commented on FLINK-17688:
-

Thanks for taking this issue [~danny.cranmer]! I'm looking forward to it a lot.
I've assigned this ticket to you.

> Support consuming Kinesis' enhanced fanout for flink-connector-kinesis
> --
>
> Key: FLINK-17688
> URL: https://issues.apache.org/jira/browse/FLINK-17688
> Project: Flink
>  Issue Type: New Feature
>  Components: Connectors / Kinesis
>Affects Versions: 1.10.1
>Reporter: roland
>Priority: Major
>
> AWS Kinesis enhanced fanout is a feature that allows consumers to consume a 
> separated sub-stream without competing with other consumers. 
> ([https://docs.aws.amazon.com/streams/latest/dev/building-enhanced-consumers-api.html])
> Yet, currently flink-connector-kinesis can only consume main streams, which 
> may lead to tense competition.
> A support for the enhanced fanout feature is quite useful for AWS users.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (FLINK-17688) Support consuming Kinesis' enhanced fanout for flink-connector-kinesis

2020-06-09 Thread Tzu-Li (Gordon) Tai (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-17688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tzu-Li (Gordon) Tai reassigned FLINK-17688:
---

Assignee: Danny Cranmer

> Support consuming Kinesis' enhanced fanout for flink-connector-kinesis
> --
>
> Key: FLINK-17688
> URL: https://issues.apache.org/jira/browse/FLINK-17688
> Project: Flink
>  Issue Type: New Feature
>  Components: Connectors / Kinesis
>Affects Versions: 1.10.1
>Reporter: roland
>Assignee: Danny Cranmer
>Priority: Major
>
> AWS Kinesis enhanced fanout is a feature that allows consumers to consume a 
> separated sub-stream without competing with other consumers. 
> ([https://docs.aws.amazon.com/streams/latest/dev/building-enhanced-consumers-api.html])
> Yet, currently flink-connector-kinesis can only consume main streams, which 
> may lead to tense competition.
> A support for the enhanced fanout feature is quite useful for AWS users.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] pyscala commented on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`

2020-06-09 Thread GitBox


pyscala commented on pull request #12566:
URL: https://github.com/apache/flink/pull/12566#issuecomment-641707884


   @flinkbot run travis
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot commented on pull request #12567: [FLINK-15849][doc] Update SQL-CLIENT document from type to data-type

2020-06-09 Thread GitBox


flinkbot commented on pull request #12567:
URL: https://github.com/apache/flink/pull/12567#issuecomment-641705466


   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit 76c6bca81f3834034fb8a530cf1916fac6793d25 (Wed Jun 10 
03:58:19 UTC 2020)
   
✅no warnings
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Updated] (FLINK-15849) Update SQL-CLIENT document from type to data-type

2020-06-09 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-15849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated FLINK-15849:
---
Labels: pull-request-available  (was: )

> Update SQL-CLIENT document from type to data-type
> -
>
> Key: FLINK-15849
> URL: https://issues.apache.org/jira/browse/FLINK-15849
> Project: Flink
>  Issue Type: Task
>  Components: Documentation, Table SQL / API
>Reporter: Jingsong Lee
>Assignee: Danny Chen
>Priority: Blocker
>  Labels: pull-request-available
> Fix For: 1.11.0, 1.10.2
>
>
> There are documentation of {{type}} instead of {{data-type}} in sql-client.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] danny0405 opened a new pull request #12567: [FLINK-15849][doc] Update SQL-CLIENT document from type to data-type

2020-06-09 Thread GitBox


danny0405 opened a new pull request #12567:
URL: https://github.com/apache/flink/pull/12567


   ## What is the purpose of the change
   
   Fix the SQL-CLI document to use `data-type` as key for schema fields.
   
   ## Brief change log
   
 - Fix sqlClient.md and sqlClient.zh.md
   
   
   ## Verifying this change
   
   Build local and works ok.
   
   ## Does this pull request potentially affect one of the following parts:
   
 - Dependencies (does it add or upgrade a dependency): no
 - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
 - The serializers: no
 - The runtime per-record code paths (performance sensitive): no
 - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
 - The S3 file system connector: no
   
   ## Documentation
   
 - Does this pull request introduce a new feature? no
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (FLINK-18227) official example stuck in flink shell(local mode)

2020-06-09 Thread appleyuchi (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-18227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17130026#comment-17130026
 ] 

appleyuchi commented on FLINK-18227:


!卡住.png!

> official example stuck in flink shell(local mode)
> -
>
> Key: FLINK-18227
> URL: https://issues.apache.org/jira/browse/FLINK-18227
> Project: Flink
>  Issue Type: Bug
>Affects Versions: 1.10.1
>Reporter: appleyuchi
>Priority: Major
> Attachments: 卡住.png
>
>
> *1.*start-scala-shell.sh local
> then I type the example from the log after I start flink shell(local)
> and get stuck finally,no result in the picture I uploaded.
>  
>  
> *2.*Maybe the above question is not regarded as issue,but "support",
> um,is there any other website except stackoverflow to propose a question?
> I want to try flink shell,but almost no material in China's website.
> my question is more than one,*but the stackoverflow has many limitations.*
> *for example:*
> ①I can't propose more than one question in an hour.
> ②If I propose several questions got downvote,my stackoverflow account will be 
> banned.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (FLINK-18227) official example stuck in flink shell(local mode)

2020-06-09 Thread appleyuchi (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-18227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

appleyuchi updated FLINK-18227:
---
Attachment: 卡住.png

> official example stuck in flink shell(local mode)
> -
>
> Key: FLINK-18227
> URL: https://issues.apache.org/jira/browse/FLINK-18227
> Project: Flink
>  Issue Type: Bug
>Affects Versions: 1.10.1
>Reporter: appleyuchi
>Priority: Major
> Attachments: 卡住.png
>
>
> *1.*start-scala-shell.sh local
> then I type the example from the log after I start flink shell(local)
> and get stuck finally,no result in the picture I uploaded.
>  
>  
> *2.*Maybe the above question is not regarded as issue,but "support",
> um,is there any other website except stackoverflow to propose a question?
> I want to try flink shell,but almost no material in China's website.
> my question is more than one,*but the stackoverflow has many limitations.*
> *for example:*
> ①I can't propose more than one question in an hour.
> ②If I propose several questions got downvote,my stackoverflow account will be 
> banned.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (FLINK-18227) official example stuck in flink shell(local mode)

2020-06-09 Thread appleyuchi (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-18227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

appleyuchi updated FLINK-18227:
---
Attachment: (was: 卡住.png)

> official example stuck in flink shell(local mode)
> -
>
> Key: FLINK-18227
> URL: https://issues.apache.org/jira/browse/FLINK-18227
> Project: Flink
>  Issue Type: Bug
>Affects Versions: 1.10.1
>Reporter: appleyuchi
>Priority: Major
> Attachments: 卡住.png
>
>
> *1.*start-scala-shell.sh local
> then I type the example from the log after I start flink shell(local)
> and get stuck finally,no result in the picture I uploaded.
>  
>  
> *2.*Maybe the above question is not regarded as issue,but "support",
> um,is there any other website except stackoverflow to propose a question?
> I want to try flink shell,but almost no material in China's website.
> my question is more than one,*but the stackoverflow has many limitations.*
> *for example:*
> ①I can't propose more than one question in an hour.
> ②If I propose several questions got downvote,my stackoverflow account will be 
> banned.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (FLINK-18227) official example stuck in flink shell(local mode)

2020-06-09 Thread appleyuchi (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-18227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

appleyuchi updated FLINK-18227:
---
Description: 
*1.*start-scala-shell.sh local

then I type the example from the log after I start flink shell(local)

and get stuck finally,no result in the picture I uploaded.

 

 

*2.*Maybe the above question is not regarded as issue,but "support",

um,is there any other website except stackoverflow to propose a question?

I want to try flink shell,but almost no material in China's website.

my question is more than one,*but the stackoverflow has many limitations.*

*for example:*

①I can't propose more than one question in an hour.

②If I propose several questions got downvote,my stackoverflow account will be 
banned.

  was:
*1.*start-scala-shell.sh local

then I type the example from the log after I start flink shell(local)

and get stuck finally,no result.

 

 

*2.*Maybe the above question is not regarded as issue,but "support",

So,is there any other website except stackoverflow to propose a question?

I want to try flink shell,but almost no material in China's website.

my question is more than one,*but the stackoverflow has many limitations.*

*for example:*

①I can't propose more than one question in an hour.

②If I propose several questions got downvote,my stackoverflow account will be 
banned.


> official example stuck in flink shell(local mode)
> -
>
> Key: FLINK-18227
> URL: https://issues.apache.org/jira/browse/FLINK-18227
> Project: Flink
>  Issue Type: Bug
>Affects Versions: 1.10.1
>Reporter: appleyuchi
>Priority: Major
> Attachments: 卡住.png
>
>
> *1.*start-scala-shell.sh local
> then I type the example from the log after I start flink shell(local)
> and get stuck finally,no result in the picture I uploaded.
>  
>  
> *2.*Maybe the above question is not regarded as issue,but "support",
> um,is there any other website except stackoverflow to propose a question?
> I want to try flink shell,but almost no material in China's website.
> my question is more than one,*but the stackoverflow has many limitations.*
> *for example:*
> ①I can't propose more than one question in an hour.
> ②If I propose several questions got downvote,my stackoverflow account will be 
> banned.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-18227) official example stuck in flink shell(local mode)

2020-06-09 Thread appleyuchi (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-18227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17130024#comment-17130024
 ] 

appleyuchi commented on FLINK-18227:


!卡住.png!

> official example stuck in flink shell(local mode)
> -
>
> Key: FLINK-18227
> URL: https://issues.apache.org/jira/browse/FLINK-18227
> Project: Flink
>  Issue Type: Bug
>Affects Versions: 1.10.1
>Reporter: appleyuchi
>Priority: Major
> Attachments: 卡住.png
>
>
> *1.*start-scala-shell.sh local
> then I type the example from the log after I start flink shell(local)
> and get stuck finally,no result.
>  
>  
> *2.*Maybe the above question is not regarded as issue,but "support",
> So,is there any other website except stackoverflow to propose a question?
> I want to try flink shell,but almost no material in China's website.
> my question is more than one,*but the stackoverflow has many limitations.*
> *for example:*
> ①I can't propose more than one question in an hour.
> ②If I propose several questions got downvote,my stackoverflow account will be 
> banned.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (FLINK-18227) official example stuck in flink shell(local mode)

2020-06-09 Thread appleyuchi (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-18227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

appleyuchi updated FLINK-18227:
---
Description: 
*1.*start-scala-shell.sh local

then I type the example from the log after I start flink shell(local)

and get stuck finally,no result.

 

 

*2.*Maybe the above question is not regarded as issue,but "support",

So,is there any other website except stackoverflow to propose a question?

I want to try flink shell,but almost no material in China's website.

my question is more than one,*but the stackoverflow has many limitations.*

*for example:*

①I can't propose more than one question in an hour.

②If I propose several questions got downvote,my stackoverflow account will be 
banned.

  was:
*1.*start-scala-shell.sh local

then I type the example from the log after I start flink shell(local)

 

 

*2.*Maybe the above question is not regarded as issue,but "support",

So,is there any other website except stackoverflow to propose a question?

I want to try flink shell,but almost no material in China's website.

my question is more than one,*but the stackoverflow has many limitations.*

*for example:*

①I can't propose more than one question in an hour.

②If I propose several questions got downvote,my stackoverflow account will be 
banned.


> official example stuck in flink shell(local mode)
> -
>
> Key: FLINK-18227
> URL: https://issues.apache.org/jira/browse/FLINK-18227
> Project: Flink
>  Issue Type: Bug
>Affects Versions: 1.10.1
>Reporter: appleyuchi
>Priority: Major
> Attachments: 卡住.png
>
>
> *1.*start-scala-shell.sh local
> then I type the example from the log after I start flink shell(local)
> and get stuck finally,no result.
>  
>  
> *2.*Maybe the above question is not regarded as issue,but "support",
> So,is there any other website except stackoverflow to propose a question?
> I want to try flink shell,but almost no material in China's website.
> my question is more than one,*but the stackoverflow has many limitations.*
> *for example:*
> ①I can't propose more than one question in an hour.
> ②If I propose several questions got downvote,my stackoverflow account will be 
> banned.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-18226) ResourceManager requests unnecessary new workers if previous workers are allocated but not registered.

2020-06-09 Thread Xintong Song (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-18226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17130022#comment-17130022
 ] 

Xintong Song commented on FLINK-18226:
--

cc [~trohrmann]

> ResourceManager requests unnecessary new workers if previous workers are 
> allocated but not registered.
> --
>
> Key: FLINK-18226
> URL: https://issues.apache.org/jira/browse/FLINK-18226
> Project: Flink
>  Issue Type: Bug
>  Components: Deployment / Kubernetes, Deployment / YARN, Runtime / 
> Coordination
>Affects Versions: 1.11.0
>Reporter: Xintong Song
>Assignee: Xintong Song
>Priority: Blocker
> Fix For: 1.11.0
>
>
> h2. Problem
> Currently on Kubernetes & Yarn deployment, the ResourceManager compares 
> *pending workers requested from Kubernetes/Yarn* against *pending workers 
> required by SlotManager*, for deciding whether new workers should be 
> requested in case of a worker failure.
>  * {{KubernetesResourceManager#requestKubernetesPodIfRequired}}
>  * {{YarnResourceManager#requestYarnContainerIfRequired}}
> *Pending workers requested from Kubernetes/Yarn* is decreased when the worker 
> is allocated, *before the worker is actually started and registered*.
>  * Decreased in {{ActiveResourceManager#notifyNewWorkerAllocated}}, which is 
> called in
>  * {{KubernetesResourceManager#onAdded}}
>  * {{YarnResourceManager#onContainersOfResourceAllocated}}
> On the other hand, *pending workers required by SlotManager* is derived from 
> the number of pending slots inside SlotManager, which is decreased *when the 
> new workers/slots are registered*.
>  * {{SlotManagerImpl#registerSlot}}
> Therefore, if a worker {{w1}} is failed after another worker {{w2}} is 
> allocated but before {{w2}} is registered, the ResourceManager will request 
> an unnecessary new worker for {{w2}}.
> h2. Impact
> Normally, the extra worker should be released soon after allocated. But in 
> cases where the Kubernetes/Yarn cluster does not have enough resources, it 
> might create more and more pending pods/containers.
> It's even more severe for Kubernetes, because 
> {{KubernetesResourceManager#onAdded}} only suggest that the pod spec has been 
> successfully added to the cluster, but the pod may not actually been 
> allocated due to lack of resources. Imagine there are {{N}} pending pods, a 
> failure of a running pod means requesting another {{N}} new pods.
> In a session cluster, such pending pods could take long to be cleared even 
> after all jobs in the session cluster have terminated.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (FLINK-18227) official example stuck in flink shell(local mode)

2020-06-09 Thread appleyuchi (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-18227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

appleyuchi updated FLINK-18227:
---
Description: 
*1.*start-scala-shell.sh local

then I type the example from the log after I start flink shell(local)

 

 

*2.*Maybe the above question is not regarded as issue,but "support",

So,is there any other website except stackoverflow to propose a question?

I want to try flink shell,but almost no material in China's website.

my question is more than one,*but the stackoverflow has many limitations.*

*for example:*

①I can't propose more than one question in an hour.

②If I propose several questions got downvote,my stackoverflow account will be 
banned.

  was:
*1.*start-scala-shell.sh local

then I type the example from the log after I start flink shell(local)

and what's the meaning of *'num* in the picture I  uploaded?

 

'num'?

"num"?

Is it a mistake made by official support?

 

*2.*Maybe the above question is not regarded as issue,but "support",

So,is there any other website except stackoverflow to propose a question?

I want to try flink shell,but almost no material in China's website.

my question is more than one,*but the stackoverflow has many limitations.*

*for example:*

①I can't propose more than one question in an hour.

②If I propose several questions got downvote,my stackoverflow account will be 
banned.


> official example stuck in flink shell(local mode)
> -
>
> Key: FLINK-18227
> URL: https://issues.apache.org/jira/browse/FLINK-18227
> Project: Flink
>  Issue Type: Bug
>Affects Versions: 1.10.1
>Reporter: appleyuchi
>Priority: Major
> Attachments: 卡住.png
>
>
> *1.*start-scala-shell.sh local
> then I type the example from the log after I start flink shell(local)
>  
>  
> *2.*Maybe the above question is not regarded as issue,but "support",
> So,is there any other website except stackoverflow to propose a question?
> I want to try flink shell,but almost no material in China's website.
> my question is more than one,*but the stackoverflow has many limitations.*
> *for example:*
> ①I can't propose more than one question in an hour.
> ②If I propose several questions got downvote,my stackoverflow account will be 
> banned.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] flinkbot edited a comment on pull request #12565: [BP-1.11][FLINK-18018] Bundle GPU plugin in plugins/ directory

2020-06-09 Thread GitBox


flinkbot edited a comment on pull request #12565:
URL: https://github.com/apache/flink/pull/12565#issuecomment-641696166


   
   ## CI report:
   
   * 23b6eb404e2f8abb263e97c19ea17341a4264dda Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3115)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #12527: [FLINK-18173][build] Bundle flink-csv,flink-json,flink-avro jars in lib

2020-06-09 Thread GitBox


flinkbot edited a comment on pull request #12527:
URL: https://github.com/apache/flink/pull/12527#issuecomment-640564258


   
   ## CI report:
   
   * d9f08ec3f759dc19667162150bad8cf6197d0efd Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3061)
 
   * 861e2a4a123eeca7e81cf1e932a3e0cdff2f1a2e Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3114)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot commented on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`

2020-06-09 Thread GitBox


flinkbot commented on pull request #12566:
URL: https://github.com/apache/flink/pull/12566#issuecomment-641701238


   
   ## CI report:
   
   * 4086eac47b36d124dd13d8a15261bcc823b89e74 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (FLINK-18226) ResourceManager requests unnecessary new workers if previous workers are allocated but not registered.

2020-06-09 Thread Xintong Song (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-18226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17130021#comment-17130021
 ] 

Xintong Song commented on FLINK-18226:
--

Here are my proposal for solving this problem.
 * We should decrease *pending workers requested from Kubernetes/Yarn* when the 
new worker is registered, rather than allocated.
 * We would need to match the registered workers with the pending ones, wrt 
their resource spec. To avoid passing {{WorkerResourceSpec}} all the way to the 
{{TaskExecutor}} and register it back, we can record the mapping between 
{{ResourceID}} and {{WorkerResourceSpec}} when the workers are allocated, and 
find out the {{WorkerResourceSpec}} from the {{ResourceID}} when the worker is 
registered.

> ResourceManager requests unnecessary new workers if previous workers are 
> allocated but not registered.
> --
>
> Key: FLINK-18226
> URL: https://issues.apache.org/jira/browse/FLINK-18226
> Project: Flink
>  Issue Type: Bug
>  Components: Deployment / Kubernetes, Deployment / YARN, Runtime / 
> Coordination
>Affects Versions: 1.11.0
>Reporter: Xintong Song
>Assignee: Xintong Song
>Priority: Blocker
> Fix For: 1.11.0
>
>
> h2. Problem
> Currently on Kubernetes & Yarn deployment, the ResourceManager compares 
> *pending workers requested from Kubernetes/Yarn* against *pending workers 
> required by SlotManager*, for deciding whether new workers should be 
> requested in case of a worker failure.
>  * {{KubernetesResourceManager#requestKubernetesPodIfRequired}}
>  * {{YarnResourceManager#requestYarnContainerIfRequired}}
> *Pending workers requested from Kubernetes/Yarn* is decreased when the worker 
> is allocated, *before the worker is actually started and registered*.
>  * Decreased in {{ActiveResourceManager#notifyNewWorkerAllocated}}, which is 
> called in
>  * {{KubernetesResourceManager#onAdded}}
>  * {{YarnResourceManager#onContainersOfResourceAllocated}}
> On the other hand, *pending workers required by SlotManager* is derived from 
> the number of pending slots inside SlotManager, which is decreased *when the 
> new workers/slots are registered*.
>  * {{SlotManagerImpl#registerSlot}}
> Therefore, if a worker {{w1}} is failed after another worker {{w2}} is 
> allocated but before {{w2}} is registered, the ResourceManager will request 
> an unnecessary new worker for {{w2}}.
> h2. Impact
> Normally, the extra worker should be released soon after allocated. But in 
> cases where the Kubernetes/Yarn cluster does not have enough resources, it 
> might create more and more pending pods/containers.
> It's even more severe for Kubernetes, because 
> {{KubernetesResourceManager#onAdded}} only suggest that the pod spec has been 
> successfully added to the cluster, but the pod may not actually been 
> allocated due to lack of resources. Imagine there are {{N}} pending pods, a 
> failure of a running pod means requesting another {{N}} new pods.
> In a session cluster, such pending pods could take long to be cleared even 
> after all jobs in the session cluster have terminated.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (FLINK-18227) official example stuck in flink shell(local mode)

2020-06-09 Thread appleyuchi (Jira)
appleyuchi created FLINK-18227:
--

 Summary: official example stuck in flink shell(local mode)
 Key: FLINK-18227
 URL: https://issues.apache.org/jira/browse/FLINK-18227
 Project: Flink
  Issue Type: Bug
Affects Versions: 1.10.1
Reporter: appleyuchi
 Attachments: 卡住.png

*1.*start-scala-shell.sh local

then I type the example from the log after I start flink shell(local)

and what's the meaning of *'num* in the picture I  uploaded?

 

'num'?

"num"?

Is it a mistake made by official support?

 

*2.*Maybe the above question is not regarded as issue,but "support",

So,is there any other website except stackoverflow to propose a question?

I want to try flink shell,but almost no material in China's website.

my question is more than one,*but the stackoverflow has many limitations.*

*for example:*

①I can't propose more than one question in an hour.

②If I propose several questions got downvote,my stackoverflow account will be 
banned.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-17976) Test native K8s integration

2020-06-09 Thread Xintong Song (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-17976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17130017#comment-17130017
 ] 

Xintong Song commented on FLINK-17976:
--

bq. For question #1, it is probably a bug or improvement of 
{{ActiveResourceManager}}. Currently, we decrease the pending workers after 
allocated, not TaskManager registered. So both in K8s and Yarn, we may come 
into this issue. cc [~xintongsong], i think you could give more suggestions 
here.

This is indeed a problem. I've created FLINK-18226 for tracking this.

> Test native K8s integration
> ---
>
> Key: FLINK-17976
> URL: https://issues.apache.org/jira/browse/FLINK-17976
> Project: Flink
>  Issue Type: Sub-task
>  Components: Runtime / Coordination
>Affects Versions: 1.11.0
>Reporter: Till Rohrmann
>Assignee: Robert Metzger
>Priority: Critical
>  Labels: pull-request-available, release-testing
> Fix For: 1.11.0
>
> Attachments: enough_tm_wait_5min.txt
>
>
> Test Flink's native K8s integration:
> * session mode
> * application mode
> * custom Flink image
> * custom configuration and log properties



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (FLINK-18226) ResourceManager requests unnecessary new workers if previous workers are allocated but not registered.

2020-06-09 Thread Xintong Song (Jira)
Xintong Song created FLINK-18226:


 Summary: ResourceManager requests unnecessary new workers if 
previous workers are allocated but not registered.
 Key: FLINK-18226
 URL: https://issues.apache.org/jira/browse/FLINK-18226
 Project: Flink
  Issue Type: Bug
  Components: Deployment / Kubernetes, Deployment / YARN, Runtime / 
Coordination
Affects Versions: 1.11.0
Reporter: Xintong Song
Assignee: Xintong Song
 Fix For: 1.11.0


h2. Problem

Currently on Kubernetes & Yarn deployment, the ResourceManager compares 
*pending workers requested from Kubernetes/Yarn* against *pending workers 
required by SlotManager*, for deciding whether new workers should be requested 
in case of a worker failure.
 * {{KubernetesResourceManager#requestKubernetesPodIfRequired}}
 * {{YarnResourceManager#requestYarnContainerIfRequired}}

*Pending workers requested from Kubernetes/Yarn* is decreased when the worker 
is allocated, *before the worker is actually started and registered*.
 * Decreased in {{ActiveResourceManager#notifyNewWorkerAllocated}}, which is 
called in
 * {{KubernetesResourceManager#onAdded}}
 * {{YarnResourceManager#onContainersOfResourceAllocated}}

On the other hand, *pending workers required by SlotManager* is derived from 
the number of pending slots inside SlotManager, which is decreased *when the 
new workers/slots are registered*.
 * {{SlotManagerImpl#registerSlot}}

Therefore, if a worker {{w1}} is failed after another worker {{w2}} is 
allocated but before {{w2}} is registered, the ResourceManager will request an 
unnecessary new worker for {{w2}}.

h2. Impact

Normally, the extra worker should be released soon after allocated. But in 
cases where the Kubernetes/Yarn cluster does not have enough resources, it 
might create more and more pending pods/containers.

It's even more severe for Kubernetes, because 
{{KubernetesResourceManager#onAdded}} only suggest that the pod spec has been 
successfully added to the cluster, but the pod may not actually been allocated 
due to lack of resources. Imagine there are {{N}} pending pods, a failure of a 
running pod means requesting another {{N}} new pods.

In a session cluster, such pending pods could take long to be cleared even 
after all jobs in the session cluster have terminated.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (FLINK-18225) Add collect method in the Python TableResult

2020-06-09 Thread Dian Fu (Jira)
Dian Fu created FLINK-18225:
---

 Summary: Add collect method in the Python TableResult
 Key: FLINK-18225
 URL: https://issues.apache.org/jira/browse/FLINK-18225
 Project: Flink
  Issue Type: Improvement
  Components: API / Python
Reporter: Dian Fu
 Fix For: 1.12.0


There is a collect method in the Java TableResult which allows to retrieve the 
execution results. We should also add support of it in the Python TableResult.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] libenchao merged pull request #12564: [hotfix][javadocs]Fix typo in KafkaResource.java

2020-06-09 Thread GitBox


libenchao merged pull request #12564:
URL: https://github.com/apache/flink/pull/12564


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Assigned] (FLINK-16087) Translate "Detecting Patterns" page of "Streaming Concepts" into Chinese

2020-06-09 Thread Jark Wu (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-16087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jark Wu reassigned FLINK-16087:
---

Assignee: RocMarshal

> Translate "Detecting Patterns" page of "Streaming Concepts" into Chinese 
> -
>
> Key: FLINK-16087
> URL: https://issues.apache.org/jira/browse/FLINK-16087
> Project: Flink
>  Issue Type: Sub-task
>  Components: chinese-translation, Documentation
>Reporter: Jark Wu
>Assignee: RocMarshal
>Priority: Major
>
> The page url is 
> https://ci.apache.org/projects/flink/flink-docs-master/zh/dev/table/streaming/match_recognize.html
> The markdown file is located in 
> {{flink/docs/dev/table/streaming/match_recognize.zh.md}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] flinkbot edited a comment on pull request #12564: [hotfix][javadocs]Fix typo in KafkaResource.java

2020-06-09 Thread GitBox


flinkbot edited a comment on pull request #12564:
URL: https://github.com/apache/flink/pull/12564#issuecomment-641690061


   
   ## CI report:
   
   * df0871ba78a0e4b68a7550ae3599d4a3c878a874 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3108)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot commented on pull request #12565: [BP-1.11][FLINK-18018] Bundle GPU plugin in plugins/ directory

2020-06-09 Thread GitBox


flinkbot commented on pull request #12565:
URL: https://github.com/apache/flink/pull/12565#issuecomment-641696166


   
   ## CI report:
   
   * 23b6eb404e2f8abb263e97c19ea17341a4264dda UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #12538: [FLINK-17422] Create user document for the external resource framewor…

2020-06-09 Thread GitBox


flinkbot edited a comment on pull request #12538:
URL: https://github.com/apache/flink/pull/12538#issuecomment-641018334


   
   ## CI report:
   
   * 66760850c9e34be7445a9bbcd2d8a12b87a760ce Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2996)
 
   * 0d89db3d1c1d7bc1c20ee38d3b0ad7a45531c206 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3107)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #12554: [FLINK-18218][python][e2e] Add yarn perjob, java dependency management e2e tests for pyflink.

2020-06-09 Thread GitBox


flinkbot edited a comment on pull request #12554:
URL: https://github.com/apache/flink/pull/12554#issuecomment-641294850


   
   ## CI report:
   
   * e2905d883839d1b8f32b5e9d82320e2dcbdb3e57 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3068)
 
   * 561fef4b26a6b3e393daaea5f97135deb19e9070 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3103)
 
   * b0a13736a1137b58f6d75cb5fabb7e09ef3314e9 UNKNOWN
   * d9d29d6a9c67ab9749f69049062818e463179a45 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #12527: [FLINK-18173][build] Bundle flink-csv,flink-json,flink-avro jars in lib

2020-06-09 Thread GitBox


flinkbot edited a comment on pull request #12527:
URL: https://github.com/apache/flink/pull/12527#issuecomment-640564258


   
   ## CI report:
   
   * d9f08ec3f759dc19667162150bad8cf6197d0efd Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3061)
 
   * 861e2a4a123eeca7e81cf1e932a3e0cdff2f1a2e UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] libenchao commented on pull request #12564: [hotfix][javadocs]Fix typo in KafkaResource.java

2020-06-09 Thread GitBox


libenchao commented on pull request #12564:
URL: https://github.com/apache/flink/pull/12564#issuecomment-641696051


   @DashShen Thanks for your contribution, the changes LGTM, will merge.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (FLINK-18082) UnsignedTypeConversionITCase stalls in ch.vorburger.mariadb4j.DB.stop

2020-06-09 Thread Jark Wu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-18082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17130005#comment-17130005
 ] 

Jark Wu commented on FLINK-18082:
-

I will just merge the pull request (not sure whether it can totall resovle 
this). Let's reopen this issue if the failure happens again. 

> UnsignedTypeConversionITCase stalls in ch.vorburger.mariadb4j.DB.stop
> -
>
> Key: FLINK-18082
> URL: https://issues.apache.org/jira/browse/FLINK-18082
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / JDBC, Table SQL / Ecosystem
>Affects Versions: 1.12.0
>Reporter: Robert Metzger
>Assignee: Leonard Xu
>Priority: Major
>  Labels: pull-request-available, test-stability
>
> CI: 
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=2582=logs=d44f43ce-542c-597d-bf94-b0718c71e5e8=03dca39c-73e8-5aaf-601d-328ae5c35f20
> {code}
> 2020-06-02T19:01:31.8486456Z 
> ==
> 2020-06-02T19:01:31.8487052Z Printing stack trace of Java process 8653
> 2020-06-02T19:01:31.8487424Z 
> ==
> 2020-06-02T19:01:31.8541169Z Picked up JAVA_TOOL_OPTIONS: 
> -XX:+HeapDumpOnOutOfMemoryError
> 2020-06-02T19:01:32.1665740Z 2020-06-02 19:01:32
> 2020-06-02T19:01:32.1666470Z Full thread dump OpenJDK 64-Bit Server VM 
> (25.242-b08 mixed mode):
> 2020-06-02T19:01:32.1666735Z 
> 2020-06-02T19:01:32.1667614Z "Attach Listener" #537 daemon prio=9 os_prio=0 
> tid=0x7f61f8001000 nid=0x3b9f waiting on condition [0x]
> 2020-06-02T19:01:32.1668130Zjava.lang.Thread.State: RUNNABLE
> 2020-06-02T19:01:32.1668311Z 
> 2020-06-02T19:01:32.1668958Z "flink-akka.actor.default-dispatcher-193" #535 
> prio=5 os_prio=0 tid=0x7f6034001000 nid=0x3af7 waiting on condition 
> [0x7f61a25b8000]
> 2020-06-02T19:01:32.1669418Zjava.lang.Thread.State: TIMED_WAITING 
> (parking)
> 2020-06-02T19:01:32.1669730Z  at sun.misc.Unsafe.park(Native Method)
> 2020-06-02T19:01:32.1670301Z  - parking to wait for  <0x80c51528> (a 
> akka.dispatch.ForkJoinExecutorConfigurator$AkkaForkJoinPool)
> 2020-06-02T19:01:32.1670791Z  at 
> akka.dispatch.forkjoin.ForkJoinPool.idleAwaitWork(ForkJoinPool.java:2135)
> 2020-06-02T19:01:32.1671329Z  at 
> akka.dispatch.forkjoin.ForkJoinPool.scan(ForkJoinPool.java:2067)
> 2020-06-02T19:01:32.1671763Z  at 
> akka.dispatch.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979)
> 2020-06-02T19:01:32.1672211Z  at 
> akka.dispatch.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107)
> 2020-06-02T19:01:32.1672491Z 
> 2020-06-02T19:01:32.1673104Z "flink-akka.actor.default-dispatcher-191" #533 
> prio=5 os_prio=0 tid=0x7f619801e000 nid=0x3ae1 waiting on condition 
> [0x7f60770f1000]
> 2020-06-02T19:01:32.1673564Zjava.lang.Thread.State: WAITING (parking)
> 2020-06-02T19:01:32.1673839Z  at sun.misc.Unsafe.park(Native Method)
> 2020-06-02T19:01:32.1674422Z  - parking to wait for  <0x80c51528> (a 
> akka.dispatch.ForkJoinExecutorConfigurator$AkkaForkJoinPool)
> 2020-06-02T19:01:32.1674865Z  at 
> akka.dispatch.forkjoin.ForkJoinPool.scan(ForkJoinPool.java:2075)
> 2020-06-02T19:01:32.1675305Z  at 
> akka.dispatch.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979)
> 2020-06-02T19:01:32.1675751Z  at 
> akka.dispatch.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107)
> 2020-06-02T19:01:32.1676046Z 
> 2020-06-02T19:01:32.1676669Z "jobmanager-future-thread-2" #466 daemon prio=5 
> os_prio=0 tid=0x7f6124001000 nid=0x3795 waiting on condition 
> [0x7f61a23b6000]
> 2020-06-02T19:01:32.1677316Zjava.lang.Thread.State: WAITING (parking)
> 2020-06-02T19:01:32.1677617Z  at sun.misc.Unsafe.park(Native Method)
> 2020-06-02T19:01:32.1678220Z  - parking to wait for  <0x816a4c90> (a 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
> 2020-06-02T19:01:32.1678702Z  at 
> java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
> 2020-06-02T19:01:32.1679209Z  at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039)
> 2020-06-02T19:01:32.1679822Z  at 
> java.util.concurrent.ScheduledThreadPoolExecutor$DelayedWorkQueue.take(ScheduledThreadPoolExecutor.java:1088)
> 2020-06-02T19:01:32.1680422Z  at 
> java.util.concurrent.ScheduledThreadPoolExecutor$DelayedWorkQueue.take(ScheduledThreadPoolExecutor.java:809)
> 2020-06-02T19:01:32.1680962Z  at 
> java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1074)
> 2020-06-02T19:01:32.1681424Z  at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1134)
> 

[jira] [Closed] (FLINK-18082) UnsignedTypeConversionITCase stalls in ch.vorburger.mariadb4j.DB.stop

2020-06-09 Thread Jark Wu (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-18082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jark Wu closed FLINK-18082.
---
Fix Version/s: 1.11.0
   Resolution: Fixed

- master (1.12.0): 919bd548706c664e38804b009be7edf9365c7b8e
- 1.11.0: 8cdd78c6f301e7b818188c1f2d620f22498e6c9f

> UnsignedTypeConversionITCase stalls in ch.vorburger.mariadb4j.DB.stop
> -
>
> Key: FLINK-18082
> URL: https://issues.apache.org/jira/browse/FLINK-18082
> Project: Flink
>  Issue Type: Bug
>  Components: Connectors / JDBC, Table SQL / Ecosystem
>Affects Versions: 1.12.0
>Reporter: Robert Metzger
>Assignee: Leonard Xu
>Priority: Major
>  Labels: pull-request-available, test-stability
> Fix For: 1.11.0
>
>
> CI: 
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=2582=logs=d44f43ce-542c-597d-bf94-b0718c71e5e8=03dca39c-73e8-5aaf-601d-328ae5c35f20
> {code}
> 2020-06-02T19:01:31.8486456Z 
> ==
> 2020-06-02T19:01:31.8487052Z Printing stack trace of Java process 8653
> 2020-06-02T19:01:31.8487424Z 
> ==
> 2020-06-02T19:01:31.8541169Z Picked up JAVA_TOOL_OPTIONS: 
> -XX:+HeapDumpOnOutOfMemoryError
> 2020-06-02T19:01:32.1665740Z 2020-06-02 19:01:32
> 2020-06-02T19:01:32.1666470Z Full thread dump OpenJDK 64-Bit Server VM 
> (25.242-b08 mixed mode):
> 2020-06-02T19:01:32.1666735Z 
> 2020-06-02T19:01:32.1667614Z "Attach Listener" #537 daemon prio=9 os_prio=0 
> tid=0x7f61f8001000 nid=0x3b9f waiting on condition [0x]
> 2020-06-02T19:01:32.1668130Zjava.lang.Thread.State: RUNNABLE
> 2020-06-02T19:01:32.1668311Z 
> 2020-06-02T19:01:32.1668958Z "flink-akka.actor.default-dispatcher-193" #535 
> prio=5 os_prio=0 tid=0x7f6034001000 nid=0x3af7 waiting on condition 
> [0x7f61a25b8000]
> 2020-06-02T19:01:32.1669418Zjava.lang.Thread.State: TIMED_WAITING 
> (parking)
> 2020-06-02T19:01:32.1669730Z  at sun.misc.Unsafe.park(Native Method)
> 2020-06-02T19:01:32.1670301Z  - parking to wait for  <0x80c51528> (a 
> akka.dispatch.ForkJoinExecutorConfigurator$AkkaForkJoinPool)
> 2020-06-02T19:01:32.1670791Z  at 
> akka.dispatch.forkjoin.ForkJoinPool.idleAwaitWork(ForkJoinPool.java:2135)
> 2020-06-02T19:01:32.1671329Z  at 
> akka.dispatch.forkjoin.ForkJoinPool.scan(ForkJoinPool.java:2067)
> 2020-06-02T19:01:32.1671763Z  at 
> akka.dispatch.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979)
> 2020-06-02T19:01:32.1672211Z  at 
> akka.dispatch.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107)
> 2020-06-02T19:01:32.1672491Z 
> 2020-06-02T19:01:32.1673104Z "flink-akka.actor.default-dispatcher-191" #533 
> prio=5 os_prio=0 tid=0x7f619801e000 nid=0x3ae1 waiting on condition 
> [0x7f60770f1000]
> 2020-06-02T19:01:32.1673564Zjava.lang.Thread.State: WAITING (parking)
> 2020-06-02T19:01:32.1673839Z  at sun.misc.Unsafe.park(Native Method)
> 2020-06-02T19:01:32.1674422Z  - parking to wait for  <0x80c51528> (a 
> akka.dispatch.ForkJoinExecutorConfigurator$AkkaForkJoinPool)
> 2020-06-02T19:01:32.1674865Z  at 
> akka.dispatch.forkjoin.ForkJoinPool.scan(ForkJoinPool.java:2075)
> 2020-06-02T19:01:32.1675305Z  at 
> akka.dispatch.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979)
> 2020-06-02T19:01:32.1675751Z  at 
> akka.dispatch.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107)
> 2020-06-02T19:01:32.1676046Z 
> 2020-06-02T19:01:32.1676669Z "jobmanager-future-thread-2" #466 daemon prio=5 
> os_prio=0 tid=0x7f6124001000 nid=0x3795 waiting on condition 
> [0x7f61a23b6000]
> 2020-06-02T19:01:32.1677316Zjava.lang.Thread.State: WAITING (parking)
> 2020-06-02T19:01:32.1677617Z  at sun.misc.Unsafe.park(Native Method)
> 2020-06-02T19:01:32.1678220Z  - parking to wait for  <0x816a4c90> (a 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
> 2020-06-02T19:01:32.1678702Z  at 
> java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
> 2020-06-02T19:01:32.1679209Z  at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039)
> 2020-06-02T19:01:32.1679822Z  at 
> java.util.concurrent.ScheduledThreadPoolExecutor$DelayedWorkQueue.take(ScheduledThreadPoolExecutor.java:1088)
> 2020-06-02T19:01:32.1680422Z  at 
> java.util.concurrent.ScheduledThreadPoolExecutor$DelayedWorkQueue.take(ScheduledThreadPoolExecutor.java:809)
> 2020-06-02T19:01:32.1680962Z  at 
> java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1074)
> 2020-06-02T19:01:32.1681424Z  at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1134)
> 

[GitHub] [flink] flinkbot edited a comment on pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase

2020-06-09 Thread GitBox


flinkbot edited a comment on pull request #12369:
URL: https://github.com/apache/flink/pull/12369#issuecomment-635090403


   
   ## CI report:
   
   * 586cad86df6ee5de33537f735fa5c65cabebe260 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3102)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] wuchong closed pull request #12465: [FLINK-18082][jdbc] UnsignedTypeConversionITCase stalls in ch.vorburer.mariadb4j.DB.stop

2020-06-09 Thread GitBox


wuchong closed pull request #12465:
URL: https://github.com/apache/flink/pull/12465


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot commented on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`

2020-06-09 Thread GitBox


flinkbot commented on pull request #12566:
URL: https://github.com/apache/flink/pull/12566#issuecomment-641693809


   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit 4086eac47b36d124dd13d8a15261bcc823b89e74 (Wed Jun 10 
03:13:08 UTC 2020)
   
   **Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up 
to date!
   
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] pyscala commented on pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`

2020-06-09 Thread GitBox


pyscala commented on pull request #12566:
URL: https://github.com/apache/flink/pull/12566#issuecomment-641693599


   Hi @becketqin ,appreciate for your time to review this PR,thanks



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Closed] (FLINK-16681) Jdbc JDBCOutputFormat and JDBCLookupFunction PreparedStatement loss connection, if long time not records to write.

2020-06-09 Thread Jark Wu (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-16681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jark Wu closed FLINK-16681.
---
Fix Version/s: (was: 1.10.2)
   Resolution: Fixed

- master (1.12.0): 7ab4d33ec492b5abb93c078abd6ac2027337b421
- 1.11.0: da677ec4338fdcbafa84420c3899e883489fca6c

> Jdbc JDBCOutputFormat   and JDBCLookupFunction PreparedStatement loss 
> connection, if long time not records to write.
> 
>
> Key: FLINK-16681
> URL: https://issues.apache.org/jira/browse/FLINK-16681
> Project: Flink
>  Issue Type: Improvement
>  Components: Connectors / JDBC
>Reporter: LakeShen
>Assignee: Lijie Wang
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.11.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> In my thought, jdbc connector is the one of most frequently used connector in 
> flink . But maybe there is a problem for jdbc connector. For example, if 
> there are no records to write or join with dim table for a long time , the 
> exception will throw like this :
> java.sql.SQLException: No operations allowed after statement closed
> Because there are long time no records to write , the PreparedStatement loss 
> the connection.
>  If there is no other jira to solve this problem , can you assign this jira 
> to me , I will try my best to solve it , thank you .



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (FLINK-17761) FutureCompletingBlockingQueue should have a capacity limit.

2020-06-09 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-17761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated FLINK-17761:
---
Labels: pull-request-available  (was: )

> FutureCompletingBlockingQueue should have a capacity limit.
> ---
>
> Key: FLINK-17761
> URL: https://issues.apache.org/jira/browse/FLINK-17761
> Project: Flink
>  Issue Type: Sub-task
>  Components: Connectors / Common
>Reporter: Jiangjie Qin
>Assignee: liufangliang
>Priority: Major
>  Labels: pull-request-available
>
> Currently FutureCompletingBlockingQueue does not have a capacity. It should 
> have one.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] wuchong closed pull request #11499: [FLINK-16681][Connectors/JDBC]Jdbc JDBCOutputFormat and JDBCLookupFunction PreparedStatement loss connection, if long time not records to write.

2020-06-09 Thread GitBox


wuchong closed pull request #11499:
URL: https://github.com/apache/flink/pull/11499


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] wuchong closed pull request #12427: [FLINK-16681][jdbc] Fix the bug that jdbc lost connection after a lon…

2020-06-09 Thread GitBox


wuchong closed pull request #12427:
URL: https://github.com/apache/flink/pull/12427


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] pyscala opened a new pull request #12566: [FLINK-17761][connector/common] Add a constructor taking capacity as a parameter for `FutureCompletingBlockingQueue`

2020-06-09 Thread GitBox


pyscala opened a new pull request #12566:
URL: https://github.com/apache/flink/pull/12566


   
   
   
   ## What is the purpose of the change
   Add a constructor taking capacity as a parameter for 
`FutureCompletingBlockingQueue`
   
   ## Brief change log
   Add a constructor taking capacity as a parameter for 
`FutureCompletingBlockingQueue`
   `private final static Integer DEFAULT_CAPACITY = 1;
   
   public FutureCompletingBlockingQueue(FutureNotifier futureNotifier) {
  this(futureNotifier, DEFAULT_CAPACITY);
   }
   
   public FutureCompletingBlockingQueue(FutureNotifier futureNotifier, int 
capacity) {
  super(capacity);
  this.futureNotifier = futureNotifier;
   }`
   
   ## Verifying this change
   
   This change is already covered by existing tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
 - Dependencies (does it add or upgrade a dependency): (no)
 - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
 - The serializers: (no)
 - The runtime per-record code paths (performance sensitive): (no)
 - Anything that affects deployment or recovery: JobManager (no), 
Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
 - The S3 file system connector: (no)
   
   ## Documentation
   
 - Does this pull request introduce a new feature? (no)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] wuchong commented on pull request #11499: [FLINK-16681][Connectors/JDBC]Jdbc JDBCOutputFormat and JDBCLookupFunction PreparedStatement loss connection, if long time not records to wri

2020-06-09 Thread GitBox


wuchong commented on pull request #11499:
URL: https://github.com/apache/flink/pull/11499#issuecomment-641693145


   Fixed by #12427.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] wuchong commented on a change in pull request #12523: [FLINK-18133][docs][avro] Add documentation for the new Avro format

2020-06-09 Thread GitBox


wuchong commented on a change in pull request #12523:
URL: https://github.com/apache/flink/pull/12523#discussion_r437835002



##
File path: docs/dev/table/connectors/formats/avro.md
##
@@ -0,0 +1,203 @@
+---
+title: "Avro Format"
+nav-title: Avro
+nav-parent_id: sql-formats
+nav-pos: 3
+---
+
+
+Format: Serialization Schema
+Format: Deserialization Schema
+
+* This will be replaced by the TOC
+{:toc}
+
+The [Apache Avro](https://avro.apache.org/) format allows to read and write 
Avro data based on an Avro schema. Currently, the Avro schema is derived from 
table schema.
+
+Dependencies
+
+
+In order to setup the Avro format, the following table provides dependency 
information for both projects using a build automation tool (such as Maven or 
SBT) and SQL Client with SQL JAR bundles.
+
+| Maven dependency   | SQL Client JAR |
+| :- | :--|
+| `flink-avro`   | [Pre-bundled 
Hadoop](https://flink.apache.org/downloads.html#additional-components) |

Review comment:
   You are right. I have also noticed that when reviewing Kafka 
documentation. But I don't want to block the following format documentation. So 
I will create other pull request for this. 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] libenchao commented on a change in pull request #11359: [FLINK-16095] [docs-zh] Translate "Modules" page of "Table API & SQL" into Chinese

2020-06-09 Thread GitBox


libenchao commented on a change in pull request #11359:
URL: https://github.com/apache/flink/pull/11359#discussion_r437517254



##
File path: docs/dev/table/modules.zh.md
##
@@ -22,51 +22,41 @@ KIND, either express or implied.  See the License for the
 specific language governing permissions and limitations
 under the License.
 -->
+模块让用户能够对 Flink 内置对象进行扩展。例如定义一些类似Flink内置函数的函数。模块是可插拔的,Flink 
已经提供了一些预构建的模块,用户还可以实现自己的模块。
 
-Modules allow users to extend Flink's built-in objects, such as defining 
functions that behave like Flink 
-built-in functions. They are pluggable, and while Flink provides a few 
pre-built modules, users can write 
-their own.
-
-For example, users can define their own geo functions and plug them into Flink 
as built-in functions to be used in 
-Flink SQL and Table APIs. Another example is users can load an out-of-shelf 
Hive module to use Hive built-in 
-functions as Flink built-in functions.
+例如,用户可以自定义 geo 函数,并将其作为内置函数插入 Flink,随后就可以在 Flink SQL 和 Table API 
中使用它了。另一个示例是,用户可以加载现成的 Hive 模块,随后就可以像使用 Flink 内置函数一样使用 Hive 模块的函数了。

Review comment:
   geo 函数,感觉geo是不是可以翻译出来?

##
File path: docs/dev/table/modules.zh.md
##
@@ -22,51 +22,41 @@ KIND, either express or implied.  See the License for the
 specific language governing permissions and limitations
 under the License.
 -->
+模块让用户能够对 Flink 内置对象进行扩展。例如定义一些类似Flink内置函数的函数。模块是可插拔的,Flink 
已经提供了一些预构建的模块,用户还可以实现自己的模块。

Review comment:
   ```suggestion
   模块让用户能够对 Flink 内置对象进行扩展。例如定义一些类似 Flink 内置函数的函数。模块是可插拔的,Flink 
已经提供了一些预构建的模块,用户还可以实现自己的模块。
   ```

##
File path: docs/dev/table/modules.zh.md
##
@@ -76,31 +66,31 @@ tableEnv.unloadModule("myModule");
 {% endhighlight %}
 
 
+使用YAML定义的模块必须设置`类型`属性来指定模块类型。原生支持以下模块类型。
 
-All modules defined using YAML must provide a `type` property that specifies 
the type. 
-The following types are supported out of the box.
 
 
   
 
-  Catalog
-  Type Value
+  模块种类
+  类型值
 
   
   
 
-CoreModule
+核心模块
 core
 
 
-HiveModule
+Hive模块
 hive
 
   
 
 
 {% highlight yaml %}
 modules:
+

Review comment:
   why add this blank line?

##
File path: docs/dev/table/modules.zh.md
##
@@ -76,31 +66,31 @@ tableEnv.unloadModule("myModule");
 {% endhighlight %}
 
 
+使用YAML定义的模块必须设置`类型`属性来指定模块类型。原生支持以下模块类型。
 
-All modules defined using YAML must provide a `type` property that specifies 
the type. 
-The following types are supported out of the box.
 
 
   
 
-  Catalog
-  Type Value
+  模块种类
+  类型值
 
   
   
 
-CoreModule
+核心模块
 core
 
 
-HiveModule
+Hive模块

Review comment:
   ```suggestion
   Hive 模块
   ```





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] wuchong commented on pull request #12427: [FLINK-16681][jdbc] Fix the bug that jdbc lost connection after a lon…

2020-06-09 Thread GitBox


wuchong commented on pull request #12427:
URL: https://github.com/apache/flink/pull/12427#issuecomment-641691720


   The failed tests are unrelated to this issue. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] wuchong edited a comment on pull request #12427: [FLINK-16681][jdbc] Fix the bug that jdbc lost connection after a lon…

2020-06-09 Thread GitBox


wuchong edited a comment on pull request #12427:
URL: https://github.com/apache/flink/pull/12427#issuecomment-641691720


   The failed tests are unrelated to this issue. 
   Merging...



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] JingsongLi commented on a change in pull request #12523: [FLINK-18133][docs][avro] Add documentation for the new Avro format

2020-06-09 Thread GitBox


JingsongLi commented on a change in pull request #12523:
URL: https://github.com/apache/flink/pull/12523#discussion_r437834284



##
File path: docs/dev/table/connectors/formats/avro.md
##
@@ -0,0 +1,203 @@
+---
+title: "Avro Format"
+nav-title: Avro
+nav-parent_id: sql-formats
+nav-pos: 3
+---
+
+
+Format: Serialization Schema
+Format: Deserialization Schema
+
+* This will be replaced by the TOC
+{:toc}
+
+The [Apache Avro](https://avro.apache.org/) format allows to read and write 
Avro data based on an Avro schema. Currently, the Avro schema is derived from 
table schema.
+
+Dependencies
+
+
+In order to setup the Avro format, the following table provides dependency 
information for both projects using a build automation tool (such as Maven or 
SBT) and SQL Client with SQL JAR bundles.
+
+| Maven dependency   | SQL Client JAR |
+| :- | :--|
+| `flink-avro`   | [Pre-bundled 
Hadoop](https://flink.apache.org/downloads.html#additional-components) |

Review comment:
   I think it is better to link 
https://ci.apache.org/projects/flink/flink-docs-master/ops/deployment/hadoop.html





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot commented on pull request #12565: [BP][FLINK-18018] Bundle GPU plugin in plugins/ directory

2020-06-09 Thread GitBox


flinkbot commented on pull request #12565:
URL: https://github.com/apache/flink/pull/12565#issuecomment-641690273


   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit 23b6eb404e2f8abb263e97c19ea17341a4264dda (Wed Jun 10 
02:59:23 UTC 2020)
   
   **Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up 
to date!
   
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #12538: [FLINK-17422] Create user document for the external resource framewor…

2020-06-09 Thread GitBox


flinkbot edited a comment on pull request #12538:
URL: https://github.com/apache/flink/pull/12538#issuecomment-641018334


   
   ## CI report:
   
   * 66760850c9e34be7445a9bbcd2d8a12b87a760ce Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2996)
 
   * 0d89db3d1c1d7bc1c20ee38d3b0ad7a45531c206 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #12554: [FLINK-18218][python][e2e] Add yarn perjob, java dependency management e2e tests for pyflink.

2020-06-09 Thread GitBox


flinkbot edited a comment on pull request #12554:
URL: https://github.com/apache/flink/pull/12554#issuecomment-641294850


   
   ## CI report:
   
   * e2905d883839d1b8f32b5e9d82320e2dcbdb3e57 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3068)
 
   * 561fef4b26a6b3e393daaea5f97135deb19e9070 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3103)
 
   * b0a13736a1137b58f6d75cb5fabb7e09ef3314e9 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Assigned] (FLINK-7479) Support physical offset in MATCH_RECOGNIZE (PREV)

2020-06-09 Thread Dian Fu (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-7479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dian Fu reassigned FLINK-7479:
--

Assignee: (was: Dian Fu)

> Support physical offset in MATCH_RECOGNIZE (PREV) 
> --
>
> Key: FLINK-7479
> URL: https://issues.apache.org/jira/browse/FLINK-7479
> Project: Flink
>  Issue Type: Sub-task
>  Components: Library / CEP, Table SQL / API
>Reporter: Dian Fu
>Priority: Major
>  Labels: pull-request-available
>
> Currently, it's already able to retrieve events matched to the specifed 
> pattern in {{IterativeCondition.Context}}. While there are also requirements 
> to retrieve events by an physical offset. The retrieved events may not be 
> matched to any pattern.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] flinkbot commented on pull request #12564: [hotfix][javadocs]Fix typo in KafkaResource.java

2020-06-09 Thread GitBox


flinkbot commented on pull request #12564:
URL: https://github.com/apache/flink/pull/12564#issuecomment-641690061


   
   ## CI report:
   
   * df0871ba78a0e4b68a7550ae3599d4a3c878a874 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Closed] (FLINK-18133) Add documentation for the new Avro format

2020-06-09 Thread Jark Wu (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-18133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jark Wu closed FLINK-18133.
---
Resolution: Fixed

- master (1.12.0): 821e786ce1e94e0074affcd50ecd4b87a6bd744b
- 1.11.0: a45645e8a69c469871bd9a07fed9d770df0a84e9

> Add documentation for the new Avro format
> -
>
> Key: FLINK-18133
> URL: https://issues.apache.org/jira/browse/FLINK-18133
> Project: Flink
>  Issue Type: Sub-task
>  Components: Documentation, Formats (JSON, Avro, Parquet, ORC, 
> SequenceFile), Table SQL / Ecosystem
>Reporter: Jark Wu
>Assignee: Jark Wu
>Priority: Blocker
>  Labels: pull-request-available
> Fix For: 1.11.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (FLINK-7479) Support physical offset in MATCH_RECOGNIZE (PREV)

2020-06-09 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-7479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated FLINK-7479:
--
Labels: pull-request-available  (was: )

> Support physical offset in MATCH_RECOGNIZE (PREV) 
> --
>
> Key: FLINK-7479
> URL: https://issues.apache.org/jira/browse/FLINK-7479
> Project: Flink
>  Issue Type: Sub-task
>  Components: Library / CEP, Table SQL / API
>Reporter: Dian Fu
>Assignee: Dian Fu
>Priority: Major
>  Labels: pull-request-available
>
> Currently, it's already able to retrieve events matched to the specifed 
> pattern in {{IterativeCondition.Context}}. While there are also requirements 
> to retrieve events by an physical offset. The retrieved events may not be 
> matched to any pattern.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] dianfu closed pull request #4563: [FLINK-7479] [cep] Support to retrieve the past event by an offset

2020-06-09 Thread GitBox


dianfu closed pull request #4563:
URL: https://github.com/apache/flink/pull/4563


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] dianfu closed pull request #7237: [FLINK-7209] [table] Support DataView in Tuple and Case Class as the ACC type of AggregateFunction

2020-06-09 Thread GitBox


dianfu closed pull request #7237:
URL: https://github.com/apache/flink/pull/7237


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] wuchong closed pull request #12523: [FLINK-18133][docs][avro] Add documentation for the new Avro format

2020-06-09 Thread GitBox


wuchong closed pull request #12523:
URL: https://github.com/apache/flink/pull/12523


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] KarmaGYZ opened a new pull request #12565: [BP][FLINK-18018] Bundle GPU plugin in plugins/ directory

2020-06-09 Thread GitBox


KarmaGYZ opened a new pull request #12565:
URL: https://github.com/apache/flink/pull/12565


   
   
   ## What is the purpose of the change
   
   Bundle GPU plugin in plugins/ directory
   
   ## Brief change log
   
   Bundle GPU plugin in plugins/ directory
   
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   cc @zentol 
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Created] (FLINK-18224) Add document about sql client's tableau result mode

2020-06-09 Thread Kurt Young (Jira)
Kurt Young created FLINK-18224:
--

 Summary: Add document about sql client's tableau result mode
 Key: FLINK-18224
 URL: https://issues.apache.org/jira/browse/FLINK-18224
 Project: Flink
  Issue Type: Task
  Components: Documentation, Table SQL / Client
Reporter: Kurt Young
Assignee: Kurt Young
 Fix For: 1.11.0






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] flinkbot edited a comment on pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase

2020-06-09 Thread GitBox


flinkbot edited a comment on pull request #12369:
URL: https://github.com/apache/flink/pull/12369#issuecomment-635090403


   
   ## CI report:
   
   * 7e9def2db9b7b755f7b048e4ee99339a509e390b Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3009)
 
   * 586cad86df6ee5de33537f735fa5c65cabebe260 Azure: 
[PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3102)
 
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (FLINK-18018) Bundle GPU plugin in "plugins/" directory

2020-06-09 Thread Yangze Guo (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-18018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129970#comment-17129970
 ] 

Yangze Guo commented on FLINK-18018:


[~chesnay] Should we also backport it to branch {{release-1.11}}?

> Bundle GPU plugin in "plugins/" directory
> -
>
> Key: FLINK-18018
> URL: https://issues.apache.org/jira/browse/FLINK-18018
> Project: Flink
>  Issue Type: Improvement
>  Components: Runtime / Coordination
>Affects Versions: 1.11.0, 1.12.0
>Reporter: Yangze Guo
>Assignee: Yangze Guo
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.11.0
>
>
> As discussed in 
> [http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Releasing-quot-fat-quot-and-quot-slim-quot-Flink-distributions-td40237.html]
>  . The community has made a consensus on move those plugins from "opt/" to 
> "plugins/". In FLINK-17812, we have already moved reporters to "plugins/". In 
> this ticket, we move GPU plugin to that directory.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] WeiZhong94 commented on pull request #12554: [FLINK-18218][python][e2e] Add yarn perjob, java dependency management e2e tests for pyflink.

2020-06-09 Thread GitBox


WeiZhong94 commented on pull request #12554:
URL: https://github.com/apache/flink/pull/12554#issuecomment-641684707


   @dianfu Thanks for your review! I have addressed your comments.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (FLINK-17761) FutureCompletingBlockingQueue should have a capacity limit.

2020-06-09 Thread liufangliang (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-17761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129969#comment-17129969
 ] 

liufangliang commented on FLINK-17761:
--

okey,thanks for your reply

> FutureCompletingBlockingQueue should have a capacity limit.
> ---
>
> Key: FLINK-17761
> URL: https://issues.apache.org/jira/browse/FLINK-17761
> Project: Flink
>  Issue Type: Sub-task
>  Components: Connectors / Common
>Reporter: Jiangjie Qin
>Assignee: liufangliang
>Priority: Major
>
> Currently FutureCompletingBlockingQueue does not have a capacity. It should 
> have one.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (FLINK-17752) Align the timestamp format with Flink SQL types in JSON format

2020-06-09 Thread Jark Wu (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-17752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jark Wu updated FLINK-17752:

Component/s: Table SQL / Ecosystem

> Align the timestamp format with Flink SQL types in JSON format
> --
>
> Key: FLINK-17752
> URL: https://issues.apache.org/jira/browse/FLINK-17752
> Project: Flink
>  Issue Type: Bug
>  Components: Formats (JSON, Avro, Parquet, ORC, SequenceFile), Table 
> SQL / Ecosystem
>Reporter: Jark Wu
>Priority: Critical
> Fix For: 1.11.0
>
>
> Currently, we are using RFC3339_TIMESTAMP_FORMAT (which will add timezone at 
> the end of string) to as the timestamp format in JSON. However, the string 
> representation fo {{TIMESTAMP (WITHOUT TIME ZONE)}} shoudn't adding 'Z' at 
> the end. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-16947) ArtifactResolutionException: Could not transfer artifact. Entry [...] has not been leased from this pool

2020-06-09 Thread Lijie Wang (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-16947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129967#comment-17129967
 ] 

Lijie Wang commented on FLINK-16947:


Another instance: 
[https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=3088=logs=fc5181b0-e452-5c8f-68de-1097947f6483=62110053-334f-5295-a0ab-80dd7e2babbf]

> ArtifactResolutionException: Could not transfer artifact.  Entry [...] has 
> not been leased from this pool
> -
>
> Key: FLINK-16947
> URL: https://issues.apache.org/jira/browse/FLINK-16947
> Project: Flink
>  Issue Type: Bug
>  Components: Build System / Azure Pipelines
>Reporter: Piotr Nowojski
>Assignee: Robert Metzger
>Priority: Blocker
>  Labels: test-stability
> Fix For: 1.12.0
>
>
> https://dev.azure.com/rmetzger/Flink/_build/results?buildId=6982=logs=c88eea3b-64a0-564d-0031-9fdcd7b8abee=1e2bbe5b-4657-50be-1f07-d84bfce5b1f5
> Build of flink-metrics-availability-test failed with:
> {noformat}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.22.1:test (end-to-end-tests) 
> on project flink-metrics-availability-test: Unable to generate classpath: 
> org.apache.maven.artifact.resolver.ArtifactResolutionException: Could not 
> transfer artifact org.apache.maven.surefire:surefire-grouper:jar:2.22.1 
> from/to google-maven-central 
> (https://maven-central-eu.storage-download.googleapis.com/maven2/): Entry 
> [id:13][route:{s}->https://maven-central-eu.storage-download.googleapis.com:443][state:null]
>  has not been leased from this pool
> [ERROR] org.apache.maven.surefire:surefire-grouper:jar:2.22.1
> [ERROR] 
> [ERROR] from the specified remote repositories:
> [ERROR] google-maven-central 
> (https://maven-central-eu.storage-download.googleapis.com/maven2/, 
> releases=true, snapshots=false),
> [ERROR] apache.snapshots (https://repository.apache.org/snapshots, 
> releases=false, snapshots=true)
> [ERROR] Path to dependency:
> [ERROR] 1) dummy:dummy:jar:1.0
> [ERROR] 2) org.apache.maven.surefire:surefire-junit47:jar:2.22.1
> [ERROR] 3) org.apache.maven.surefire:common-junit48:jar:2.22.1
> [ERROR] 4) org.apache.maven.surefire:surefire-grouper:jar:2.22.1
> [ERROR] -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> [ERROR] 
> [ERROR] After correcting the problems, you can resume the build with the 
> command
> [ERROR]   mvn  -rf :flink-metrics-availability-test
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (FLINK-17761) FutureCompletingBlockingQueue should have a capacity limit.

2020-06-09 Thread Jiangjie Qin (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-17761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jiangjie Qin reassigned FLINK-17761:


Assignee: liufangliang

> FutureCompletingBlockingQueue should have a capacity limit.
> ---
>
> Key: FLINK-17761
> URL: https://issues.apache.org/jira/browse/FLINK-17761
> Project: Flink
>  Issue Type: Sub-task
>  Components: Connectors / Common
>Reporter: Jiangjie Qin
>Assignee: liufangliang
>Priority: Major
>
> Currently FutureCompletingBlockingQueue does not have a capacity. It should 
> have one.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] Myasuka commented on pull request #12529: [FLINK-17800][roksdb] Ensure total order seek to avoid user misuse

2020-06-09 Thread GitBox


Myasuka commented on pull request #12529:
URL: https://github.com/apache/flink/pull/12529#issuecomment-641682439


   @StephanEwen Thanks for your review. I realized this problem when I created 
this PR, and I actually try to use [Parameterized test on single method with 
junit5](https://www.baeldung.com/parameterized-tests-junit-5). However, I found 
Flink still use junit4, and then I give up this choice.
   Since you also bring up this problem, I will refactor current tests.
   
   BTW, this PR is for release-1.11, and Yu already give some comments for PR 
targets to master branch at https://github.com/apache/flink/pull/12514 . We can 
put our comments there and then update all related PRs for different branches.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot commented on pull request #12564: [hotfix][javadocs]Fix typo in KafkaResource.java

2020-06-09 Thread GitBox


flinkbot commented on pull request #12564:
URL: https://github.com/apache/flink/pull/12564#issuecomment-641682460


   Thanks a lot for your contribution to the Apache Flink project. I'm the 
@flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress 
of the review.
   
   
   ## Automated Checks
   Last check on commit df0871ba78a0e4b68a7550ae3599d4a3c878a874 (Wed Jun 10 
02:30:27 UTC 2020)
   
   **Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up 
to date!
   
   
   Mention the bot in a comment to re-run the automated checks.
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review 
Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full 
explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied 
according to the order of the review items. For consensus, approval by a Flink 
committer of PMC member is required Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot approve description` to approve one or more aspects (aspects: 
`description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until 
`architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's 
attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] dianfu commented on a change in pull request #12554: [FLINK-18218][python][e2e] Add yarn perjob, java dependency management e2e tests for pyflink.

2020-06-09 Thread GitBox


dianfu commented on a change in pull request #12554:
URL: https://github.com/apache/flink/pull/12554#discussion_r437821836



##
File path: 
flink-end-to-end-tests/flink-python-test/src/main/java/org/apache/flink/python/tests/TestScalarUdf.java
##
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.python.tests;

Review comment:
   move to package org.apache.flink.python.tests.util?

##
File path: 
flink-end-to-end-tests/flink-python-test/src/main/java/org/apache/flink/python/tests/TestScalarUdf.java
##
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.python.tests;
+
+import org.apache.flink.table.functions.ScalarFunction;
+
+/**
+ * Scala UDF for testing.
+ */
+public class TestScalarUdf extends ScalarFunction {

Review comment:
   Rename to AddOne?

##
File path: flink-end-to-end-tests/test-scripts/test_pyflink.sh
##
@@ -18,8 +18,11 @@
 

 
 set -Eeuo pipefail
+set -x

Review comment:
   unnecessary change?

##
File path: flink-end-to-end-tests/test-scripts/test_pyflink.sh
##
@@ -18,8 +18,11 @@
 

 
 set -Eeuo pipefail
+set -x
 CURRENT_DIR=`cd "$(dirname "$0")" && pwd -P`
+cd "${CURRENT_DIR}/../"

Review comment:
   unnecessary change?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (FLINK-17761) FutureCompletingBlockingQueue should have a capacity limit.

2020-06-09 Thread Jiangjie Qin (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-17761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129966#comment-17129966
 ] 

Jiangjie Qin commented on FLINK-17761:
--

[~liufangliang] Thanks for being interested. Sounds good to me. Just assigned 
you the ticket.

> FutureCompletingBlockingQueue should have a capacity limit.
> ---
>
> Key: FLINK-17761
> URL: https://issues.apache.org/jira/browse/FLINK-17761
> Project: Flink
>  Issue Type: Sub-task
>  Components: Connectors / Common
>Reporter: Jiangjie Qin
>Priority: Major
>
> Currently FutureCompletingBlockingQueue does not have a capacity. It should 
> have one.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-17976) Test native K8s integration

2020-06-09 Thread Yang Wang (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-17976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129965#comment-17129965
 ] 

Yang Wang commented on FLINK-17976:
---

For question #1, it is probably a bug or improvement of 
{{ActiveResourceManager}}. Currently, we decrease the pending workers after 
allocated, not TaskManager registered. So both in K8s and Yarn, we may come 
into this issue. cc [~xintongsong], i think you could give more suggestions 
here.

 

For question #2, make the pending pods/containers could be released when we do 
not need any pods/containers(e.g. Flink job failed/canceled). I will create a 
new ticket to track this.

> Test native K8s integration
> ---
>
> Key: FLINK-17976
> URL: https://issues.apache.org/jira/browse/FLINK-17976
> Project: Flink
>  Issue Type: Sub-task
>  Components: Runtime / Coordination
>Affects Versions: 1.11.0
>Reporter: Till Rohrmann
>Assignee: Robert Metzger
>Priority: Critical
>  Labels: pull-request-available, release-testing
> Fix For: 1.11.0
>
> Attachments: enough_tm_wait_5min.txt
>
>
> Test Flink's native K8s integration:
> * session mode
> * application mode
> * custom Flink image
> * custom configuration and log properties



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [flink] DashShen opened a new pull request #12564: [hotfix][javadocs]Fix typo in KafkaResource.java

2020-06-09 Thread GitBox


DashShen opened a new pull request #12564:
URL: https://github.com/apache/flink/pull/12564


   
   Modify (**is** none is configured) to   (**if**  none is configured)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #12554: [FLINK-18218][python][e2e] Add yarn perjob, java dependency management e2e tests for pyflink.

2020-06-09 Thread GitBox


flinkbot edited a comment on pull request #12554:
URL: https://github.com/apache/flink/pull/12554#issuecomment-641294850


   
   ## CI report:
   
   * e2905d883839d1b8f32b5e9d82320e2dcbdb3e57 Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3068)
 
   * 561fef4b26a6b3e393daaea5f97135deb19e9070 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [flink] flinkbot edited a comment on pull request #12369: [FLINK-17678][Connectors/HBase]Support fink-sql-connector-hbase

2020-06-09 Thread GitBox


flinkbot edited a comment on pull request #12369:
URL: https://github.com/apache/flink/pull/12369#issuecomment-635090403


   
   ## CI report:
   
   * 7e9def2db9b7b755f7b048e4ee99339a509e390b Azure: 
[FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=3009)
 
   * 586cad86df6ee5de33537f735fa5c65cabebe260 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (FLINK-16087) Translate "Detecting Patterns" page of "Streaming Concepts" into Chinese

2020-06-09 Thread RocMarshal (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-16087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129956#comment-17129956
 ] 

RocMarshal commented on FLINK-16087:


Hi, [~jark]

I'm willing to translate this page.

Could you assign this ticket to me if no one is working on this ?

Thank You.

> Translate "Detecting Patterns" page of "Streaming Concepts" into Chinese 
> -
>
> Key: FLINK-16087
> URL: https://issues.apache.org/jira/browse/FLINK-16087
> Project: Flink
>  Issue Type: Sub-task
>  Components: chinese-translation, Documentation
>Reporter: Jark Wu
>Priority: Major
>
> The page url is 
> https://ci.apache.org/projects/flink/flink-docs-master/zh/dev/table/streaming/match_recognize.html
> The markdown file is located in 
> {{flink/docs/dev/table/streaming/match_recognize.zh.md}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-18104) Test pyflink on windows

2020-06-09 Thread Wei Zhong (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-18104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129959#comment-17129959
 ] 

Wei Zhong commented on FLINK-18104:
---

Verified that:

      - build PyFlink Java part on Windows, works as expected.

      - test PyFlink Java part on windows, some tests failed due to the Windows 
driver letters. Fixed.

      - build PyFlink Python part on Windows, works as expected.

      - test PyFlink Python part on Windows (python3.5, python3.6, python3.7), 
works as expected.

      - install PyFlink on Windows, works as expected.

      - run Python UDF example with dependencies, works as expected.

      

> Test pyflink on windows
> ---
>
> Key: FLINK-18104
> URL: https://issues.apache.org/jira/browse/FLINK-18104
> Project: Flink
>  Issue Type: Test
>  Components: API / Python
>Reporter: sunjincheng
>Assignee: Wei Zhong
>Priority: Blocker
>  Labels: pull-request-available, release-testing
> Fix For: 1.11.0
>
>
> Test pyflink on windows as follows:
>  * maven test
>  * maven build
>  * python build
>  * python test,
>  * python install
>  * python udf example with dependencies
> Feel free to add any other check items.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (FLINK-18104) Test pyflink on windows

2020-06-09 Thread Dian Fu (Jira)


 [ 
https://issues.apache.org/jira/browse/FLINK-18104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dian Fu closed FLINK-18104.
---
Resolution: Done

> Test pyflink on windows
> ---
>
> Key: FLINK-18104
> URL: https://issues.apache.org/jira/browse/FLINK-18104
> Project: Flink
>  Issue Type: Test
>  Components: API / Python
>Reporter: sunjincheng
>Assignee: Wei Zhong
>Priority: Blocker
>  Labels: pull-request-available, release-testing
> Fix For: 1.11.0
>
>
> Test pyflink on windows as follows:
>  * maven test
>  * maven build
>  * python build
>  * python test,
>  * python install
>  * python udf example with dependencies
> Feel free to add any other check items.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (FLINK-18104) Test pyflink on windows

2020-06-09 Thread Dian Fu (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-18104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129954#comment-17129954
 ] 

Dian Fu commented on FLINK-18104:
-

master: a16069da2bced3bb4f626ee5f8c860f615f0
release-1.11: 54fb17c88f40e7ed16701117a5e0e6f3e88191dd

> Test pyflink on windows
> ---
>
> Key: FLINK-18104
> URL: https://issues.apache.org/jira/browse/FLINK-18104
> Project: Flink
>  Issue Type: Test
>  Components: API / Python
>Reporter: sunjincheng
>Assignee: Wei Zhong
>Priority: Blocker
>  Labels: pull-request-available, release-testing
> Fix For: 1.11.0
>
>
> Test pyflink on windows as follows:
>  * maven test
>  * maven build
>  * python build
>  * python test,
>  * python install
>  * python udf example with dependencies
> Feel free to add any other check items.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


  1   2   3   4   5   6   7   8   >