[jira] [Comment Edited] (FLINK-10406) Port JobManagerTest to new code base
[
https://issues.apache.org/jira/browse/FLINK-10406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628197#comment-16628197
]
tison edited comment on FLINK-10406 at 9/26/18 3:41 AM:
- {{testCancelWithSavepoint}} is covered by
{{JobMasterTriggerSavepointIT#testStopJobAfterSavepoint}}
- {{testCancelWithSavepointNoDirectoriesConfigured}} is somehow covered by
{{JobMasterTriggerSavepointIT#testDoNotCancelJobIfSavepointFails}}. Now we
don't provide detail error message to dig out the cause a savepoint fails.
{{testDoNotCancelJobIfSavepointFails}} tests if the savepoint path permission
denied, but change it to a /not/exist/path provide the same process.
the exception stringified as "java.util.concurrent.ExecutionException:
java.util.concurrent.CompletionException:
org.apache.flink.runtime.checkpoint.CheckpointTriggerException: Failed to
trigger savepoint. Decline reason: An Exception occurred while triggering the
checkpoint."
- {{testCancelJobWithSavepointFailurePeriodicCheckpoints}} is covered by
{{JobMasterTriggerSavepointIT#testDoNotCancelJobIfSavepointFails}}.
was (Author: tison):
- {{testCancelWithSavepoint}} is covered by
{{JobMasterTriggerSavepointIT#testStopJobAfterSavepoint}}
- {{testCancelWithSavepointNoDirectoriesConfigured}} is somehow covered by
{{JobMasterTriggerSavepointIT#testDoNotCancelJobIfSavepointFails}}. Now we
don't provide detail error message to dig out the cause a savepoint fails.
{{testDoNotCancelJobIfSavepointFails}} tests if the savepoint path permission
denied, but change it to a /not/exist/path provide the same process.
the exception stringified as "java.util.concurrent.ExecutionException:
java.util.concurrent.CompletionException:
org.apache.flink.runtime.checkpoint.CheckpointTriggerException: Failed to
trigger savepoint. Decline reason: An Exception occurred while triggering the
checkpoint."
> Port JobManagerTest to new code base
>
>
> Key: FLINK-10406
> URL: https://issues.apache.org/jira/browse/FLINK-10406
> Project: Flink
> Issue Type: Sub-task
> Components: Tests
>Affects Versions: 1.7.0
>Reporter: tison
>Assignee: tison
>Priority: Major
> Fix For: 1.7.0
>
>
> Port {{JobManagerTest}} to new code base
> Not all of its tests should be ported, since some of them are covered by
> {{JobMasterTest}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (FLINK-10406) Port JobManagerTest to new code base
[
https://issues.apache.org/jira/browse/FLINK-10406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628197#comment-16628197
]
tison edited comment on FLINK-10406 at 9/26/18 3:27 AM:
- {{testCancelWithSavepoint}} is covered by
{{JobMasterTriggerSavepointIT#testStopJobAfterSavepoint}}
- {{testCancelWithSavepointNoDirectoriesConfigured}} is somehow covered by
{{JobMasterTriggerSavepointIT#testDoNotCancelJobIfSavepointFails}}. Now we
don't provide detail error message to dig out the cause a savepoint fails.
{{testDoNotCancelJobIfSavepointFails}} tests if the savepoint path permission
denied, but change it to a /not/exist/path provide the same process.
the exception stringified as "java.util.concurrent.ExecutionException:
java.util.concurrent.CompletionException:
org.apache.flink.runtime.checkpoint.CheckpointTriggerException: Failed to
trigger savepoint. Decline reason: An Exception occurred while triggering the
checkpoint."
was (Author: tison):
- {{testCancelWithSavepoint}} is covered by
{{JobMasterTriggerSavepointIT#testStopJobAfterSavepoint}}
- {{testCancelWithSavepointNoDirectoriesConfigured}} is somehow covered by
{{JobMasterTriggerSavepointIT#testDoNotCancelJobIfSavepointFails}}. Now we
don't provide detail error message to dig out the cause a savepoint fails.
{{testDoNotCancelJobIfSavepointFails}} tests if the savepoint path permission
denied, but change it to a /not/exist/path provide the same process.
> Port JobManagerTest to new code base
>
>
> Key: FLINK-10406
> URL: https://issues.apache.org/jira/browse/FLINK-10406
> Project: Flink
> Issue Type: Sub-task
> Components: Tests
>Affects Versions: 1.7.0
>Reporter: tison
>Assignee: tison
>Priority: Major
> Fix For: 1.7.0
>
>
> Port {{JobManagerTest}} to new code base
> Not all of its tests should be ported, since some of them are covered by
> {{JobMasterTest}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (FLINK-10406) Port JobManagerTest to new code base
[
https://issues.apache.org/jira/browse/FLINK-10406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628197#comment-16628197
]
tison edited comment on FLINK-10406 at 9/26/18 3:26 AM:
- {{testCancelWithSavepoint}} is covered by
{{JobMasterTriggerSavepointIT#testStopJobAfterSavepoint}}
- {{testCancelWithSavepointNoDirectoriesConfigured}} is somehow covered by
{{JobMasterTriggerSavepointIT#testDoNotCancelJobIfSavepointFails}}. Now we
don't provide detail error message to dig out the cause a savepoint fails.
{{testDoNotCancelJobIfSavepointFails}} tests if the savepoint path permission
denied, but change it to a /not/exist/path provide the same process.
was (Author: tison):
- {{testCancelWithSavepoint}} is covered by
{{JobMasterTriggerSavepointIT#testStopJobAfterSavepoint}}
> Port JobManagerTest to new code base
>
>
> Key: FLINK-10406
> URL: https://issues.apache.org/jira/browse/FLINK-10406
> Project: Flink
> Issue Type: Sub-task
> Components: Tests
>Affects Versions: 1.7.0
>Reporter: tison
>Assignee: tison
>Priority: Major
> Fix For: 1.7.0
>
>
> Port {{JobManagerTest}} to new code base
> Not all of its tests should be ported, since some of them are covered by
> {{JobMasterTest}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (FLINK-10406) Port JobManagerTest to new code base
[
https://issues.apache.org/jira/browse/FLINK-10406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628148#comment-16628148
]
tison edited comment on FLINK-10406 at 9/26/18 2:57 AM:
- {{testSavepointRestoreSettings}} is covered by
{{JobMaster#testRestoringFromSavepoint}}
the {{triggerSavepoint}} part is covered by {{JobMasterTriggerSavepointIT}},
and the submit failure part should be taken care of when port
{{JobSubmitTest}}, which has a test {{testAnswerFailureWhenSavepointReadFails}}
was (Author: tison):
- {{testSavepointRestoreSettings}} is covered by
{{JobMaster#testRestoringFromSavepoint}}
> Port JobManagerTest to new code base
>
>
> Key: FLINK-10406
> URL: https://issues.apache.org/jira/browse/FLINK-10406
> Project: Flink
> Issue Type: Sub-task
> Components: Tests
>Affects Versions: 1.7.0
>Reporter: tison
>Assignee: tison
>Priority: Major
> Fix For: 1.7.0
>
>
> Port {{JobManagerTest}} to new code base
> Not all of its tests should be ported, since some of them are covered by
> {{JobMasterTest}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (FLINK-10406) Port JobManagerTest to new code base
[
https://issues.apache.org/jira/browse/FLINK-10406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16627806#comment-16627806
]
tison edited comment on FLINK-10406 at 9/25/18 7:28 PM:
* {{testStopSignal}} and {{testStopSignalFail}} are covered by
{{ExecutionGraphStopTest}}. High level invocation at {{Dispatcher}} and
{{JobMaster}} level are trivial.
* {{testNullHostnameGoesToLocalhost}} is ported to {{AkkaUtilsTest#"null
hostname should go to localhost"}}
* {{testRequestPartitionState*}} I would propose to ignore all of them since
we have FLINK-10319. It proposed to disable {{JobMaster#requestPartitionState}}
and have one approval and no objection yet. Also cc [~trohrm...@apache.org],
could you take a look at FLINK-10319 so that we could make the decision of this
removal? (UPDATE: even without FLINK-10319 accepted, these tests should be
covered by {{JobMasterTest#testRequestPartitionState}} and {{TaskTest#...}})
was (Author: tison):
* {{testStopSignal}} and {{testStopSignalFail}} are covered by
{{ExecutionGraphStopTest}}. High level invocation at {{Dispatcher}} and
{{JobMaster}} level are trivial.
* {{testNullHostnameGoesToLocalhost}} is ported to {{AkkaUtilsTest#"null
hostname should go to localhost"}}
* {{testRequestPartitionState*}} I would propose to ignore all of them since
we have FLINK-10319. It proposed to disable {{JobMaster#requestPartitionState}}
and have one approval and no objection yet. Also cc [~trohrm...@apache.org],
could you take a look at FLINK-10319 so that we could make the decision of this
removal?
> Port JobManagerTest to new code base
>
>
> Key: FLINK-10406
> URL: https://issues.apache.org/jira/browse/FLINK-10406
> Project: Flink
> Issue Type: Sub-task
> Components: Tests
>Affects Versions: 1.7.0
>Reporter: tison
>Assignee: tison
>Priority: Major
> Fix For: 1.7.0
>
>
> Port {{JobManagerTest}} to new code base
> Not all of its tests should be ported, since some of them are covered by
> {{JobMasterTest}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (FLINK-10406) Port JobManagerTest to new code base
[
https://issues.apache.org/jira/browse/FLINK-10406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16627806#comment-16627806
]
tison edited comment on FLINK-10406 at 9/25/18 7:22 PM:
* {{testStopSignal}} and {{testStopSignalFail}} are covered by
{{ExecutionGraphStopTest}}. High level invocation at {{Dispatcher}} and
{{JobMaster}} level are trivial.
* {{testNullHostnameGoesToLocalhost}} is ported to {{AkkaUtilsTest#"null
hostname should go to localhost"}}
* {{testRequestPartitionState*}} I would propose to ignore all of them since
we have FLINK-10319. It proposed to disable {{JobMaster#requestPartitionState}}
and have one approval and no objection yet. Also cc [~trohrm...@apache.org],
could you take a look at FLINK-10319 so that we could make the decision of this
removal?
was (Author: tison):
* {{testStopSignal}} and {{testStopSignalFail}} are covered by
{{ExecutionGraphStopTest}}. High level invocation at {{Dispatcher}} and
{{JobMaster}} level are trivial.
* {{testNullHostnameGoesToLocalhost}} is ported to {{AkkaUtilsTest#"null
hostname should go to localhost"}}
> Port JobManagerTest to new code base
>
>
> Key: FLINK-10406
> URL: https://issues.apache.org/jira/browse/FLINK-10406
> Project: Flink
> Issue Type: Sub-task
> Components: Tests
>Affects Versions: 1.7.0
>Reporter: tison
>Assignee: tison
>Priority: Major
> Fix For: 1.7.0
>
>
> Port {{JobManagerTest}} to new code base
> Not all of its tests should be ported, since some of them are covered by
> {{JobMasterTest}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (FLINK-10406) Port JobManagerTest to new code base
[
https://issues.apache.org/jira/browse/FLINK-10406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16627806#comment-16627806
]
tison edited comment on FLINK-10406 at 9/25/18 7:13 PM:
* {{testStopSignal}} and {{testStopSignalFail}} are covered by
{{ExecutionGraphStopTest}}. High level invocation at {{Dispatcher}} and
{{JobMaster}} level are trivial.
* {{testNullHostnameGoesToLocalhost}} is ported to {{AkkaUtilsTest#"null
hostname should go to localhost"}}
was (Author: tison):
* {{testStopSignal}} and {{testStopSignalFail}} are covered by
{{ExecutionGraphStopTest}}. High level invocation at {{Dispatcher}} and
{{JobMaster}} level are trivial.
*
> Port JobManagerTest to new code base
>
>
> Key: FLINK-10406
> URL: https://issues.apache.org/jira/browse/FLINK-10406
> Project: Flink
> Issue Type: Sub-task
> Components: Tests
>Affects Versions: 1.7.0
>Reporter: tison
>Assignee: tison
>Priority: Major
> Fix For: 1.7.0
>
>
> Port {{JobManagerTest}} to new code base
> Not all of its tests should be ported, since some of them are covered by
> {{JobMasterTest}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
