[jira] [Commented] (FLINK-2155) Add an additional checkstyle validation for illegal imports
[ https://issues.apache.org/jira/browse/FLINK-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15333671#comment-15333671 ] Robert Metzger commented on FLINK-2155: --- I'm removing the target 1.1. release for this issue. [~kkl0u], are you still working on this one? > Add an additional checkstyle validation for illegal imports > --- > > Key: FLINK-2155 > URL: https://issues.apache.org/jira/browse/FLINK-2155 > Project: Flink > Issue Type: Improvement > Components: Build System >Affects Versions: 1.1.0 >Reporter: Lokesh Rajaram >Assignee: Kostas Kloudas > Fix For: 0.10.0, 1.1.0 > > > Add an additional check-style validation for illegal imports. > To begin with the following two package import are marked as illegal: > 1. org.apache.commons.lang3.Validate > 2. org.apache.flink.shaded.* > Implementation based on: > http://checkstyle.sourceforge.net/config_imports.html#IllegalImport -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-2155) Add an additional checkstyle validation for illegal imports
[ https://issues.apache.org/jira/browse/FLINK-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298086#comment-15298086 ] Kostas Kloudas commented on FLINK-2155: --- Yes of course! Will do that later in the day. > Add an additional checkstyle validation for illegal imports > --- > > Key: FLINK-2155 > URL: https://issues.apache.org/jira/browse/FLINK-2155 > Project: Flink > Issue Type: Improvement > Components: Build System >Affects Versions: 1.1.0 >Reporter: Lokesh Rajaram >Assignee: Kostas Kloudas > Fix For: 0.10.0, 1.1.0 > > > Add an additional check-style validation for illegal imports. > To begin with the following two package import are marked as illegal: > 1. org.apache.commons.lang3.Validate > 2. org.apache.flink.shaded.* > Implementation based on: > http://checkstyle.sourceforge.net/config_imports.html#IllegalImport -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-2155) Add an additional checkstyle validation for illegal imports
[ https://issues.apache.org/jira/browse/FLINK-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298085#comment-15298085 ] ASF GitHub Bot commented on FLINK-2155: --- Github user mxm commented on the pull request: https://github.com/apache/flink/pull/2026#issuecomment-221251824 Follow-up issue is here: https://issues.apache.org/jira/browse/FLINK-2155 > Add an additional checkstyle validation for illegal imports > --- > > Key: FLINK-2155 > URL: https://issues.apache.org/jira/browse/FLINK-2155 > Project: Flink > Issue Type: Improvement > Components: Build System >Reporter: Lokesh Rajaram >Assignee: Kostas Kloudas > Fix For: 0.10.0 > > > Add an additional check-style validation for illegal imports. > To begin with the following two package import are marked as illegal: > 1. org.apache.commons.lang3.Validate > 2. org.apache.flink.shaded.* > Implementation based on: > http://checkstyle.sourceforge.net/config_imports.html#IllegalImport -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-2155) Add an additional checkstyle validation for illegal imports
[ https://issues.apache.org/jira/browse/FLINK-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14595572#comment-14595572 ] ASF GitHub Bot commented on FLINK-2155: --- Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/790 Add an additional checkstyle validation for illegal imports --- Key: FLINK-2155 URL: https://issues.apache.org/jira/browse/FLINK-2155 Project: Flink Issue Type: Improvement Components: Build System Reporter: Lokesh Rajaram Assignee: Lokesh Rajaram Fix For: 0.10 Add an additional check-style validation for illegal imports. To begin with the following two package import are marked as illegal: 1. org.apache.commons.lang3.Validate 2. org.apache.flink.shaded.* Implementation based on: http://checkstyle.sourceforge.net/config_imports.html#IllegalImport -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-2155) Add an additional checkstyle validation for illegal imports
[ https://issues.apache.org/jira/browse/FLINK-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14574082#comment-14574082 ] ASF GitHub Bot commented on FLINK-2155: --- Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/790#issuecomment-109192811 Thank you for the contribution. +1 to merge. Add an additional checkstyle validation for illegal imports --- Key: FLINK-2155 URL: https://issues.apache.org/jira/browse/FLINK-2155 Project: Flink Issue Type: Improvement Components: Build System Reporter: Lokesh Rajaram Assignee: Lokesh Rajaram Add an additional check-style validation for illegal imports. To begin with the following two package import are marked as illegal: 1. org.apache.commons.lang3.Validate 2. org.apache.flink.shaded.* Implementation based on: http://checkstyle.sourceforge.net/config_imports.html#IllegalImport -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-2155) Add an additional checkstyle validation for illegal imports
[ https://issues.apache.org/jira/browse/FLINK-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14572954#comment-14572954 ] ASF GitHub Bot commented on FLINK-2155: --- Github user lokeshrajaram commented on the pull request: https://github.com/apache/flink/pull/776#issuecomment-108929985 @uce Thanks for the instructions. will follow this and create a new pull request. sorry for the trouble. Add an additional checkstyle validation for illegal imports --- Key: FLINK-2155 URL: https://issues.apache.org/jira/browse/FLINK-2155 Project: Flink Issue Type: Improvement Components: Build System Reporter: Lokesh Rajaram Assignee: Lokesh Rajaram Add an additional check-style validation for illegal imports. To begin with the following two package import are marked as illegal: 1. org.apache.commons.lang3.Validate 2. org.apache.flink.shaded.* Implementation based on: http://checkstyle.sourceforge.net/config_imports.html#IllegalImport -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-2155) Add an additional checkstyle validation for illegal imports
[ https://issues.apache.org/jira/browse/FLINK-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14572957#comment-14572957 ] ASF GitHub Bot commented on FLINK-2155: --- Github user uce commented on the pull request: https://github.com/apache/flink/pull/776#issuecomment-108930518 You don't have to update the pull request when you force push to the branch of this pull request. :-) Add an additional checkstyle validation for illegal imports --- Key: FLINK-2155 URL: https://issues.apache.org/jira/browse/FLINK-2155 Project: Flink Issue Type: Improvement Components: Build System Reporter: Lokesh Rajaram Assignee: Lokesh Rajaram Add an additional check-style validation for illegal imports. To begin with the following two package import are marked as illegal: 1. org.apache.commons.lang3.Validate 2. org.apache.flink.shaded.* Implementation based on: http://checkstyle.sourceforge.net/config_imports.html#IllegalImport -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-2155) Add an additional checkstyle validation for illegal imports
[ https://issues.apache.org/jira/browse/FLINK-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14572290#comment-14572290 ] ASF GitHub Bot commented on FLINK-2155: --- Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/775#issuecomment-108758033 +1 change looks good. Can you squash your changes into one commit, named `[FLINK-2155] Enforce import restriction on usage of Flink shaded package and Commons Validate` That makes merging for us easier. Add an additional checkstyle validation for illegal imports --- Key: FLINK-2155 URL: https://issues.apache.org/jira/browse/FLINK-2155 Project: Flink Issue Type: Improvement Components: Build System Reporter: Lokesh Rajaram Assignee: Lokesh Rajaram Add an additional check-style validation for illegal imports. To begin with the following two package import are marked as illegal: 1. org.apache.commons.lang3.Validate 2. org.apache.flink.shaded.* Implementation based on: http://checkstyle.sourceforge.net/config_imports.html#IllegalImport -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-2155) Add an additional checkstyle validation for illegal imports
[ https://issues.apache.org/jira/browse/FLINK-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14572285#comment-14572285 ] ASF GitHub Bot commented on FLINK-2155: --- GitHub user lokeshrajaram opened a pull request: https://github.com/apache/flink/pull/775 Enforce import restriction on usage of Flink shaded package and Commons Validate https://issues.apache.org/jira/browse/FLINK-2155 You can merge this pull request into a Git repository by running: $ git pull https://github.com/lokeshrajaram/flink enforce_import_restriction Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/775.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #775 commit 733c704b094c2d7a19351e43d6338ccc774d02df Author: Lokesh Rajaram rajaram.lok...@gmail.com Date: 2015-05-28T04:29:33Z Merge pull request #1 from apache/master update from original commit 3b1c2eb8aa98f9176007f7e7a9cb3e973fdc4a02 Author: Lokesh Rajaram rajaram.lok...@gmail.com Date: 2015-06-03T06:22:12Z getting latest Merge branch 'master' of https://github.com/apache/flink commit f14a0626092e68a2670cfe242bb44dd877d005cb Author: Lokesh Rajaram rajaram.lok...@gmail.com Date: 2015-06-04T04:12:55Z added illegal import restrictions module commit f33a0f33a770b5a8fe40e35451a3e1058b990c42 Author: Lokesh Rajaram rajaram.lok...@gmail.com Date: 2015-06-04T06:41:21Z added package import restriction check and restriction check for using Commons Validate commit 9188d804e84a350848fed7d01c1a698d0bcfbaea Author: Lokesh Rajaram rajaram.lok...@gmail.com Date: 2015-06-04T06:45:44Z Merge branch 'master' of https://github.com/apache/flink commit 110d1dfe579284c8cc9fe4851aa3ddeaf8cdbea2 Author: Lokesh Rajaram rajaram.lok...@gmail.com Date: 2015-06-04T04:12:55Z added illegal import restrictions module commit 536ba194af1888a2d5bff91070bbb4fa14f450da Author: Lokesh Rajaram rajaram.lok...@gmail.com Date: 2015-06-04T06:41:21Z added package import restriction check and restriction check for using Commons Validate commit a600dc5a35bb5b60cacb70019c49b987b0896e11 Author: Lokesh Rajaram rajaram.lok...@gmail.com Date: 2015-06-04T06:48:27Z Merge branch 'enforce_import_restriction' of https://github.com/lokeshrajaram/flink into enforce_import_restriction Add an additional checkstyle validation for illegal imports --- Key: FLINK-2155 URL: https://issues.apache.org/jira/browse/FLINK-2155 Project: Flink Issue Type: Improvement Components: Build System Reporter: Lokesh Rajaram Assignee: Lokesh Rajaram Add an additional check-style validation for illegal imports. To begin with the following two package import are marked as illegal: 1. org.apache.commons.lang3.Validate 2. org.apache.flink.shaded.* Implementation based on: http://checkstyle.sourceforge.net/config_imports.html#IllegalImport -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-2155) Add an additional checkstyle validation for illegal imports
[ https://issues.apache.org/jira/browse/FLINK-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14572259#comment-14572259 ] Lokesh Rajaram commented on FLINK-2155: --- Checkstyle IllegalImport works only at package level. I could get it working for a class. Looked at various options in checkstyle checks and nothing seems to suit our requirement. So, used illeaglImport for org.apache.flink.shaded package. Used a regular expression for validating use of org.apache.commons.lang3.Validate. Add an additional checkstyle validation for illegal imports --- Key: FLINK-2155 URL: https://issues.apache.org/jira/browse/FLINK-2155 Project: Flink Issue Type: Improvement Components: Build System Reporter: Lokesh Rajaram Assignee: Lokesh Rajaram Add an additional check-style validation for illegal imports. To begin with the following two package import are marked as illegal: 1. org.apache.commons.lang3.Validate 2. org.apache.flink.shaded.* Implementation based on: http://checkstyle.sourceforge.net/config_imports.html#IllegalImport -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-2155) Add an additional checkstyle validation for illegal imports
[ https://issues.apache.org/jira/browse/FLINK-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14572350#comment-14572350 ] ASF GitHub Bot commented on FLINK-2155: --- GitHub user lokeshrajaram opened a pull request: https://github.com/apache/flink/pull/776 [FLINK-2155] Enforce import restriction on usage of Flink shaded package and Commons Validate @rmetzger sorry I had issues squashing commits hence this new pull request. Not sure if I am doing it right. Sorry for the trouble You can merge this pull request into a Git repository by running: $ git pull https://github.com/lokeshrajaram/flink checks_for_import Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/776.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #776 commit 733c704b094c2d7a19351e43d6338ccc774d02df Author: Lokesh Rajaram rajaram.lok...@gmail.com Date: 2015-05-28T04:29:33Z Merge pull request #1 from apache/master update from original commit 3b1c2eb8aa98f9176007f7e7a9cb3e973fdc4a02 Author: Lokesh Rajaram rajaram.lok...@gmail.com Date: 2015-06-03T06:22:12Z getting latest Merge branch 'master' of https://github.com/apache/flink commit 9188d804e84a350848fed7d01c1a698d0bcfbaea Author: Lokesh Rajaram rajaram.lok...@gmail.com Date: 2015-06-04T06:45:44Z Merge branch 'master' of https://github.com/apache/flink commit 3f07464ce937296c0409d561bf8548e5403c4346 Author: Lokesh Rajaram rajaram.lok...@gmail.com Date: 2015-06-04T08:13:27Z [FLINK-2155] Enforce import restriction on usage of Flink shaded package and Commons Validate Add an additional checkstyle validation for illegal imports --- Key: FLINK-2155 URL: https://issues.apache.org/jira/browse/FLINK-2155 Project: Flink Issue Type: Improvement Components: Build System Reporter: Lokesh Rajaram Assignee: Lokesh Rajaram Add an additional check-style validation for illegal imports. To begin with the following two package import are marked as illegal: 1. org.apache.commons.lang3.Validate 2. org.apache.flink.shaded.* Implementation based on: http://checkstyle.sourceforge.net/config_imports.html#IllegalImport -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-2155) Add an additional checkstyle validation for illegal imports
[ https://issues.apache.org/jira/browse/FLINK-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14572392#comment-14572392 ] ASF GitHub Bot commented on FLINK-2155: --- Github user uce commented on the pull request: https://github.com/apache/flink/pull/776#issuecomment-108791701 Hey @lokeshrajaram. This is not right, but it's not a problem. We can easily fix it. :-) I suggest that you do the following: 1. If you don't have the Flink repository as a remote, add it: `git add remote flink https://git-wip-us.apache.org/repos/asf/flink.git` and do a fetch `git fetch flink`. This depends on whether you cloned your fork or the main repo. 2. Checkout a new branch from flink/master: `git checkout -b YOUR_BRANCH flink/master`. 3. Cherry pick your commit: `git cherry-pick 3f07464`. This will add your commit to the new branch. There should be no conflicts. 4. Now force push this to the branch of *this* pull request: `git push -f origin YOUR_BRANCH:checks_for_import`. Assuming that origin is your forked repository. You have to force push, because you are changing the history of this branch. Add an additional checkstyle validation for illegal imports --- Key: FLINK-2155 URL: https://issues.apache.org/jira/browse/FLINK-2155 Project: Flink Issue Type: Improvement Components: Build System Reporter: Lokesh Rajaram Assignee: Lokesh Rajaram Add an additional check-style validation for illegal imports. To begin with the following two package import are marked as illegal: 1. org.apache.commons.lang3.Validate 2. org.apache.flink.shaded.* Implementation based on: http://checkstyle.sourceforge.net/config_imports.html#IllegalImport -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-2155) Add an additional checkstyle validation for illegal imports
[ https://issues.apache.org/jira/browse/FLINK-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14572351#comment-14572351 ] ASF GitHub Bot commented on FLINK-2155: --- Github user lokeshrajaram closed the pull request at: https://github.com/apache/flink/pull/775 Add an additional checkstyle validation for illegal imports --- Key: FLINK-2155 URL: https://issues.apache.org/jira/browse/FLINK-2155 Project: Flink Issue Type: Improvement Components: Build System Reporter: Lokesh Rajaram Assignee: Lokesh Rajaram Add an additional check-style validation for illegal imports. To begin with the following two package import are marked as illegal: 1. org.apache.commons.lang3.Validate 2. org.apache.flink.shaded.* Implementation based on: http://checkstyle.sourceforge.net/config_imports.html#IllegalImport -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-2155) Add an additional checkstyle validation for illegal imports
[ https://issues.apache.org/jira/browse/FLINK-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14571577#comment-14571577 ] Ufuk Celebi commented on FLINK-2155: Thanks! Are there more Validate versions we could exclude? I think lang3 is a commons version? Add an additional checkstyle validation for illegal imports --- Key: FLINK-2155 URL: https://issues.apache.org/jira/browse/FLINK-2155 Project: Flink Issue Type: Improvement Reporter: Lokesh Rajaram Assignee: Lokesh Rajaram Add an additional check-style validation for illegal imports. To begin with the following two package import are marked as illegal: 1. org.apache.commons.lang3.Validate 2. org.apache.flink.shaded.* -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLINK-2155) Add an additional checkstyle validation for illegal imports
[ https://issues.apache.org/jira/browse/FLINK-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14572071#comment-14572071 ] Lokesh Rajaram commented on FLINK-2155: --- I could not think of anything more... if you think of anything else please comment here. I can add it to the list. Add an additional checkstyle validation for illegal imports --- Key: FLINK-2155 URL: https://issues.apache.org/jira/browse/FLINK-2155 Project: Flink Issue Type: Improvement Reporter: Lokesh Rajaram Assignee: Lokesh Rajaram Add an additional check-style validation for illegal imports. To begin with the following two package import are marked as illegal: 1. org.apache.commons.lang3.Validate 2. org.apache.flink.shaded.* -- This message was sent by Atlassian JIRA (v6.3.4#6332)
