[jira] [Commented] (FLINK-6859) StateCleaningCountTrigger should not delete timer

[Fabian Hueske (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16054078#comment-16054078
 ] 

Fabian Hueske commented on FLINK-6859:
--

I'll merge it to 1.3

> StateCleaningCountTrigger should not delete timer
> -
>
> Key: FLINK-6859
> URL: https://issues.apache.org/jira/browse/FLINK-6859
> Project: Flink
>  Issue Type: Improvement
>  Components: Table API & SQL
>Affects Versions: 1.3.0
>Reporter: Fabian Hueske
>Assignee: sunjincheng
> Fix For: 1.3.1, 1.4.0
>
>
> The {{StateCleaningCountTrigger}} which is used to clean-up inactive state 
> should not delete timers, i.e.. not call {{deleteProcessingTimeTimer()}}.
> This is an expensive operation.
> We should rather fire the timer and check if we need to clean the state or 
> not.
> What do you think [~sunjincheng121]?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (FLINK-6859) StateCleaningCountTrigger should not delete timer

[Chesnay Schepler (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16042336#comment-16042336
 ] 

Chesnay Schepler commented on FLINK-6859:
-

1.4: 92cd736daf65aae10f77bb6e8144623a5c82b5be

> StateCleaningCountTrigger should not delete timer
> -
>
> Key: FLINK-6859
> URL: https://issues.apache.org/jira/browse/FLINK-6859
> Project: Flink
>  Issue Type: Improvement
>  Components: Table API & SQL
>Affects Versions: 1.3.0
>Reporter: Fabian Hueske
>Assignee: sunjincheng
>
> The {{StateCleaningCountTrigger}} which is used to clean-up inactive state 
> should not delete timers, i.e.. not call {{deleteProcessingTimeTimer()}}.
> This is an expensive operation.
> We should rather fire the timer and check if we need to clean the state or 
> not.
> What do you think [~sunjincheng121]?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6859) StateCleaningCountTrigger should not delete timer

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16042334#comment-16042334
 ] 

ASF GitHub Bot commented on FLINK-6859:
---

Github user asfgit closed the pull request at:

https://github.com/apache/flink/pull/4085


> StateCleaningCountTrigger should not delete timer
> -
>
> Key: FLINK-6859
> URL: https://issues.apache.org/jira/browse/FLINK-6859
> Project: Flink
>  Issue Type: Improvement
>  Components: Table API & SQL
>Affects Versions: 1.3.0
>Reporter: Fabian Hueske
>Assignee: sunjincheng
>
> The {{StateCleaningCountTrigger}} which is used to clean-up inactive state 
> should not delete timers, i.e.. not call {{deleteProcessingTimeTimer()}}.
> This is an expensive operation.
> We should rather fire the timer and check if we need to clean the state or 
> not.
> What do you think [~sunjincheng121]?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6859) StateCleaningCountTrigger should not delete timer

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040982#comment-16040982
 ] 

ASF GitHub Bot commented on FLINK-6859:
---

Github user zentol commented on the issue:

https://github.com/apache/flink/pull/4085
  
merging.


> StateCleaningCountTrigger should not delete timer
> -
>
> Key: FLINK-6859
> URL: https://issues.apache.org/jira/browse/FLINK-6859
> Project: Flink
>  Issue Type: Improvement
>  Components: Table API & SQL
>Affects Versions: 1.3.0
>Reporter: Fabian Hueske
>Assignee: sunjincheng
>
> The {{StateCleaningCountTrigger}} which is used to clean-up inactive state 
> should not delete timers, i.e.. not call {{deleteProcessingTimeTimer()}}.
> This is an expensive operation.
> We should rather fire the timer and check if we need to clean the state or 
> not.
> What do you think [~sunjincheng121]?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6859) StateCleaningCountTrigger should not delete timer

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040905#comment-16040905
 ] 

ASF GitHub Bot commented on FLINK-6859:
---

Github user fhueske commented on the issue:

https://github.com/apache/flink/pull/4085
  
+1 to merge


> StateCleaningCountTrigger should not delete timer
> -
>
> Key: FLINK-6859
> URL: https://issues.apache.org/jira/browse/FLINK-6859
> Project: Flink
>  Issue Type: Improvement
>  Components: Table API & SQL
>Affects Versions: 1.3.0
>Reporter: Fabian Hueske
>Assignee: sunjincheng
>
> The {{StateCleaningCountTrigger}} which is used to clean-up inactive state 
> should not delete timers, i.e.. not call {{deleteProcessingTimeTimer()}}.
> This is an expensive operation.
> We should rather fire the timer and check if we need to clean the state or 
> not.
> What do you think [~sunjincheng121]?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6859) StateCleaningCountTrigger should not delete timer

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040762#comment-16040762
 ] 

ASF GitHub Bot commented on FLINK-6859:
---

GitHub user sunjincheng121 opened a pull request:

https://github.com/apache/flink/pull/4085

[FLINK-6859][table] remove delete useless times for improve StateClea…


- [x] General
  - The pull request references the related JIRA issue ([FLINK-6859][table] 
remove delete useless times for improve StateCleaningCountTrigger)
  - The pull request addresses only one issue
  - Each commit in the PR has a meaningful commit message (including the 
JIRA id)

- [ ] Documentation
  - Documentation has been added for new functionality
  - Old documentation affected by the pull request has been updated
  - JavaDoc for public methods has been added

- [x] Tests & Build
  - Functionality added by the pull request is covered by tests
  - `mvn clean verify` has been executed successfully locally or a Travis 
build has passed


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sunjincheng121/flink FLINK-6859-PR

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/4085.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4085


commit 44c3b0de07c16f9d58d21177a06231425bab2add
Author: sunjincheng121 
Date:   2017-06-07T11:46:32Z

[FLINK-6859][table] remove delete useless times for improve 
StateCleaningCountTrigger




> StateCleaningCountTrigger should not delete timer
> -
>
> Key: FLINK-6859
> URL: https://issues.apache.org/jira/browse/FLINK-6859
> Project: Flink
>  Issue Type: Improvement
>  Components: Table API & SQL
>Affects Versions: 1.3.0
>Reporter: Fabian Hueske
>
> The {{StateCleaningCountTrigger}} which is used to clean-up inactive state 
> should not delete timers, i.e.. not call {{deleteProcessingTimeTimer()}}.
> This is an expensive operation.
> We should rather fire the timer and check if we need to clean the state or 
> not.
> What do you think [~sunjincheng121]?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (FLINK-6859) StateCleaningCountTrigger should not delete timer

[sunjincheng (JIRA)]

[ 
https://issues.apache.org/jira/browse/FLINK-6859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040629#comment-16040629
 ] 

sunjincheng commented on FLINK-6859:


Get set of registered timers by namespace. And traverse the timer queue to 
delete the timers. is really expensive operation. I'll remove it .

> StateCleaningCountTrigger should not delete timer
> -
>
> Key: FLINK-6859
> URL: https://issues.apache.org/jira/browse/FLINK-6859
> Project: Flink
>  Issue Type: Improvement
>  Components: Table API & SQL
>Affects Versions: 1.3.0
>Reporter: Fabian Hueske
>
> The {{StateCleaningCountTrigger}} which is used to clean-up inactive state 
> should not delete timers, i.e.. not call {{deleteProcessingTimeTimer()}}.
> This is an expensive operation.
> We should rather fire the timer and check if we need to clean the state or 
> not.
> What do you think [~sunjincheng121]?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)