[GitHub] incubator-hawq pull request #1171: HAWQ-1359. Add test cases for Ranger supp...

[linwen]

Github user linwen closed the pull request at:

https://github.com/apache/incubator-hawq/pull/1171


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1171: HAWQ-1359. Add test cases for Ranger supp...

[stanlyxiang]

Github user stanlyxiang commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1171#discussion_r106091426
  
--- Diff: src/test/feature/Ranger/test_ranger.cpp ---
@@ -24,19 +24,34 @@
 
 #include "lib/command.h"
 #include "lib/gpfdist.h"
-#include "lib/sql_util.h"
 #include "lib/string_util.h"
 
 using std::vector;
 using std::string;
 using hawq::test::SQLUtility;
 using hawq::test::Command;
 
+TestHawqRanger::TestHawqRanger()
+{
+   initfile = hawq::test::stringFormat("Ranger/sql/init_file");
+   rangerHost = getRangerHost();
+}
+
+std::string& TestHawqRanger::getRangerHost()
--- End diff --

I mean the python script "rangeruser.py" need ranger server host, but you 
gave it rps host.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1171: HAWQ-1359. Add test cases for Ranger supp...

[linwen]

Github user linwen commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1171#discussion_r106084037
  
--- Diff: src/test/feature/Ranger/test_ranger.cpp ---
@@ -24,19 +24,34 @@
 
 #include "lib/command.h"
 #include "lib/gpfdist.h"
-#include "lib/sql_util.h"
 #include "lib/string_util.h"
 
 using std::vector;
 using std::string;
 using hawq::test::SQLUtility;
 using hawq::test::Command;
 
+TestHawqRanger::TestHawqRanger()
+{
+   initfile = hawq::test::stringFormat("Ranger/sql/init_file");
+   rangerHost = getRangerHost();
+}
+
+std::string& TestHawqRanger::getRangerHost()
--- End diff --

The RPS and HAWQ master are required to installed on a same node. This test 
case is to add/remove policy from Ranger Admin, but HAWQ only knows and 
interacts with RPS, it need not configure Ranger Admin address/hostname. 

I am considering still use a environment value to control it.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1171: HAWQ-1359. Add test cases for Ranger supp...

[linwen]

Github user linwen commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1171#discussion_r106080149
  
--- Diff: src/test/feature/lib/sql_util.cpp ---
@@ -224,7 +225,9 @@ const string SQLUtility::generateSQLFile(const string 
, bool usingDefaul
 EXPECT_TRUE(false) << "Error opening file " << newSqlFile;
   }
   out << "-- start_ignore" << std::endl;
+  printf("dd2d%s\n",schemaName.c_str());
   if (!usingDefaultSchema) {
+ printf("ddd%s\n",schemaName.c_str());
--- End diff --

Thanks, I will check it. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1171: HAWQ-1359. Add test cases for Ranger supp...

[stanlyxiang]

Github user stanlyxiang commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1171#discussion_r106078845
  
--- Diff: ranger-plugin/.gitignore ---
@@ -1,2 +1,3 @@
 target/
 Makefile.global
+/bin/
--- End diff --

is there any dir "bin" generated by building ? "/bin/" only ignore 
directory "bin" in current directory, e.g ranger-plugin/bin. Recommend "bin/" 
to ignore all "bin" directory from current directory to all sub-directories. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1171: HAWQ-1359. Add test cases for Ranger supp...

[stanlyxiang]

Github user stanlyxiang commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1171#discussion_r106079103
  
--- Diff: src/test/feature/Ranger/test_ranger.cpp ---
@@ -24,19 +24,34 @@
 
 #include "lib/command.h"
 #include "lib/gpfdist.h"
-#include "lib/sql_util.h"
 #include "lib/string_util.h"
 
 using std::vector;
 using std::string;
 using hawq::test::SQLUtility;
 using hawq::test::Command;
 
+TestHawqRanger::TestHawqRanger()
+{
+   initfile = hawq::test::stringFormat("Ranger/sql/init_file");
+   rangerHost = getRangerHost();
+}
+
+std::string& TestHawqRanger::getRangerHost()
--- End diff --

I checked rangeruser.py and found that the "-h" option stands for "ranger 
server host". Since rps won't be installed on ranger server host that usually, 
so I don't think this is a right way to get ranger server host. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1171: HAWQ-1359. Add test cases for Ranger supp...

[stanlyxiang]

Github user stanlyxiang commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/1171#discussion_r106078042
  
--- Diff: src/test/feature/Ranger/test_ranger.cpp ---
@@ -24,19 +24,34 @@
 
 #include "lib/command.h"
 #include "lib/gpfdist.h"
-#include "lib/sql_util.h"
 #include "lib/string_util.h"
 
 using std::vector;
 using std::string;
 using hawq::test::SQLUtility;
 using hawq::test::Command;
 
+TestHawqRanger::TestHawqRanger()
+{
+   initfile = hawq::test::stringFormat("Ranger/sql/init_file");
+   rangerHost = getRangerHost();
+}
+
+std::string& TestHawqRanger::getRangerHost()
--- End diff --

Better to get guc value by connecting to db and using sql from pg_settings, 
not hawq config. Using sql could avoid string find and hardcoded number length. 
And hawq config also connect to db and use sql to get the value. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1171: HAWQ-1359. Add test cases for Ranger supp...

[linwen]

GitHub user linwen opened a pull request:

https://github.com/apache/incubator-hawq/pull/1171

HAWQ-1359. Add test cases for Ranger support, combinations of differe…

Please review, thanks! 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/linwen/incubator-hawq hawq-1359

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/1171.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1171


commit dc36e81b3a74d1c04c3b138f6cfc053a657b62d4
Author: Wen Lin 
Date:   2017-03-14T07:17:32Z

HAWQ-1359. Add test cases for Ranger support, combinations of different 
allow/exclude policies.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---