[jira] [Commented] (HBASE-18798) Remove the unused methods in RegionServerObserver
[
https://issues.apache.org/jira/browse/HBASE-18798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169200#comment-16169200
]
Hadoop QA commented on HBASE-18798:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
18s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
48s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
17s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 5m
16s{color} | {color:red} branch has 12 errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 4m
4s{color} | {color:red} patch has 12 errors when building our shaded downstream
artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
38m 41s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}157m 48s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
53s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}217m 23s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hbase.master.procedure.TestModifyNamespaceProcedure |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18798 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12887530/HBASE-18798.v1.patch |
| Optional Tests | asflicense shadedjars javac javadoc unit findbugs
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux bda87ade3874 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / 5c12e42 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/8656/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8656/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8656/console |
|
[jira] [Commented] (HBASE-18831) Add explicit dependency on javax.el
[ https://issues.apache.org/jira/browse/HBASE-18831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169191#comment-16169191 ] Hudson commented on HBASE-18831: SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #3726 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3726/]) HBASE-18831 Add explicit dependency on javax.el (stack: rev 5c12e424e679e738a5b6282ff24348a50ed4ca14) * (edit) pom.xml * (edit) hbase-server/pom.xml * (edit) hbase-thrift/pom.xml * (edit) hbase-rest/pom.xml > Add explicit dependency on javax.el > --- > > Key: HBASE-18831 > URL: https://issues.apache.org/jira/browse/HBASE-18831 > Project: HBase > Issue Type: Bug > Components: dependencies >Reporter: stack >Assignee: stack > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18831.branch-2.001.patch > > > Previous build would search for it running up through all point version from > 3.0.1-b1 until it hit b8. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18831) Add explicit dependency on javax.el
[ https://issues.apache.org/jira/browse/HBASE-18831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169180#comment-16169180 ] Hudson commented on HBASE-18831: FAILURE: Integrated in Jenkins build HBase-2.0 #525 (See [https://builds.apache.org/job/HBase-2.0/525/]) HBASE-18831 Add explicit dependency on javax.el (stack: rev a1b6dd22e9f4c7d81d7e4ac521a7f22928e0) * (edit) hbase-server/pom.xml * (edit) hbase-rest/pom.xml * (edit) hbase-thrift/pom.xml * (edit) pom.xml > Add explicit dependency on javax.el > --- > > Key: HBASE-18831 > URL: https://issues.apache.org/jira/browse/HBASE-18831 > Project: HBase > Issue Type: Bug > Components: dependencies >Reporter: stack >Assignee: stack > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18831.branch-2.001.patch > > > Previous build would search for it running up through all point version from > 3.0.1-b1 until it hit b8. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18811) Introduce the limited private to filter
[ https://issues.apache.org/jira/browse/HBASE-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18811: --- Release Note: The list of changed filters is shown below: # ColumnCountGetFilter # ColumnPaginationFilter # ColumnPrefixFilter # ColumnRangeFilter # CompareFilter # DependentColumnFilter # FamilyFilter # Filter # FilterBase # FilterList # FirstKeyOnlyFilter # FirstKeyValueMatchingQualifiersFilter # FuzzyRowFilter # InclusiveStopFilter # KeyOnlyFilter # MultiRowRangeFilter # MultipleColumnPrefixFilter # PageFilter # ParseFilter # PrefixFilter # QualifierFilter # RandomRowFilter # RowFilter # SingleColumnValueExcludeFilter # SingleColumnValueFilter # SkipFilter # TimestampsFilter # ValueFilter # WhileMatchFilter > Introduce the limited private to filter > --- > > Key: HBASE-18811 > URL: https://issues.apache.org/jira/browse/HBASE-18811 > Project: HBase > Issue Type: Task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18811.v0.patch > > > We have many powerful callback functions to help user to build amazing > application/services. The most of functions are declared as IA.LimitedPrivate > excluding the filters. As i see it, the IA.LimitedPrivate will make the > improvement of filter more flexible. Also, we can introduce more server-side > components to filters. In conclusion, we should consider adding the limited > private level for filter. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18811) Introduce the limited private to filter
[ https://issues.apache.org/jira/browse/HBASE-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169177#comment-16169177 ] Chia-Ping Tsai commented on HBASE-18811: The filters in production files are changed to IA.LimitedPrivate from IA.Public. > Introduce the limited private to filter > --- > > Key: HBASE-18811 > URL: https://issues.apache.org/jira/browse/HBASE-18811 > Project: HBase > Issue Type: Task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18811.v0.patch > > > We have many powerful callback functions to help user to build amazing > application/services. The most of functions are declared as IA.LimitedPrivate > excluding the filters. As i see it, the IA.LimitedPrivate will make the > improvement of filter more flexible. Also, we can introduce more server-side > components to filters. In conclusion, we should consider adding the limited > private level for filter. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18811) Introduce the limited private to filter
[ https://issues.apache.org/jira/browse/HBASE-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18811: --- Attachment: HBASE-18811.v0.patch > Introduce the limited private to filter > --- > > Key: HBASE-18811 > URL: https://issues.apache.org/jira/browse/HBASE-18811 > Project: HBase > Issue Type: Task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18811.v0.patch > > > We have many powerful callback functions to help user to build amazing > application/services. The most of functions are declared as IA.LimitedPrivate > excluding the filters. As i see it, the IA.LimitedPrivate will make the > improvement of filter more flexible. Also, we can introduce more server-side > components to filters. In conclusion, we should consider adding the limited > private level for filter. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18811) Introduce the limited private to filter
[ https://issues.apache.org/jira/browse/HBASE-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18811: --- Description: We have many powerful callback functions to help user to build amazing application/services. The most of functions are declared as IA.LimitedPrivate excluding the filters. As i see it, the IA.LimitedPrivate will make the improvement of filter more flexible. Also, we can introduce more server-side components to filters. In conclusion, we should consider adding the limited private level for filter. was:The filter is treated like observer, so we should consider adding the limited private level for filter. > Introduce the limited private to filter > --- > > Key: HBASE-18811 > URL: https://issues.apache.org/jira/browse/HBASE-18811 > Project: HBase > Issue Type: Task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-alpha-4 > > > We have many powerful callback functions to help user to build amazing > application/services. The most of functions are declared as IA.LimitedPrivate > excluding the filters. As i see it, the IA.LimitedPrivate will make the > improvement of filter more flexible. Also, we can introduce more server-side > components to filters. In conclusion, we should consider adding the limited > private level for filter. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18811) Introduce the limited private to filter
[ https://issues.apache.org/jira/browse/HBASE-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18811: --- Fix Version/s: 2.0.0-alpha-4 > Introduce the limited private to filter > --- > > Key: HBASE-18811 > URL: https://issues.apache.org/jira/browse/HBASE-18811 > Project: HBase > Issue Type: Task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-alpha-4 > > > The filter is treated like observer, so we should consider adding the limited > private level for filter. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (HBASE-18811) Introduce the limited private to filter
[ https://issues.apache.org/jira/browse/HBASE-18811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned HBASE-18811: -- Assignee: Chia-Ping Tsai > Introduce the limited private to filter > --- > > Key: HBASE-18811 > URL: https://issues.apache.org/jira/browse/HBASE-18811 > Project: HBase > Issue Type: Task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > > The filter is treated like observer, so we should consider adding the limited > private level for filter. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18798) Remove the unused methods in RegionServerObserver
[ https://issues.apache.org/jira/browse/HBASE-18798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18798: --- Attachment: HBASE-18798.v1.patch retry > Remove the unused methods in RegionServerObserver > - > > Key: HBASE-18798 > URL: https://issues.apache.org/jira/browse/HBASE-18798 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18798.v0.patch, HBASE-18798.v0.patch, > HBASE-18798.v0.patch, HBASE-18798.v1.patch, HBASE-18798.v1.patch, > HBASE-18798.v1.patch > > > # preRollBackMerge > # postRollBackMerge > # preMergeCommit > # postMergeCommit > # postMerge > # preMerge > HBASE-17470 drop the rs-side merge code -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18798) Remove the unused methods in RegionServerObserver
[ https://issues.apache.org/jira/browse/HBASE-18798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18798: --- Status: Patch Available (was: Open) > Remove the unused methods in RegionServerObserver > - > > Key: HBASE-18798 > URL: https://issues.apache.org/jira/browse/HBASE-18798 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18798.v0.patch, HBASE-18798.v0.patch, > HBASE-18798.v0.patch, HBASE-18798.v1.patch, HBASE-18798.v1.patch, > HBASE-18798.v1.patch > > > # preRollBackMerge > # postRollBackMerge > # preMergeCommit > # postMergeCommit > # postMerge > # preMerge > HBASE-17470 drop the rs-side merge code -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18798) Remove the unused methods in RegionServerObserver
[ https://issues.apache.org/jira/browse/HBASE-18798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18798: --- Status: Open (was: Patch Available) > Remove the unused methods in RegionServerObserver > - > > Key: HBASE-18798 > URL: https://issues.apache.org/jira/browse/HBASE-18798 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18798.v0.patch, HBASE-18798.v0.patch, > HBASE-18798.v0.patch, HBASE-18798.v1.patch, HBASE-18798.v1.patch > > > # preRollBackMerge > # postRollBackMerge > # preMergeCommit > # postMergeCommit > # postMerge > # preMerge > HBASE-17470 drop the rs-side merge code -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18810) TestClientScannerRPCTimeout failing in branch-1 / branch-1.4
[
https://issues.apache.org/jira/browse/HBASE-18810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169167#comment-16169167
]
Chia-Ping Tsai commented on HBASE-18810:
I have attached the patch in HBASE-18415. [~apurtell] Please take a look if you
have free time. Thanks.
> TestClientScannerRPCTimeout failing in branch-1 / branch-1.4
>
>
> Key: HBASE-18810
> URL: https://issues.apache.org/jira/browse/HBASE-18810
> Project: HBase
> Issue Type: Bug
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
> Fix For: 1.4.0, 1.5.0
>
>
> TestClientScannerRPCTimeout is failing in branch-1 / branch-1.4, but it's a
> setup problem involving CreateTableProcedure. Fails for me the first time in
> both Linux and MacOS dev environments.
> Bisect says this is the cause, been there for a while
> {noformat}
> commit af359d03b5e2cc798cee8ba52d2a9fcbb1022104
> Author: Stephen Yuan Jiang
> Date: Tue Jul 18 06:58:29 2017 -0700
> HBASE-16488 Starting namespace and quota services in master startup
> asynchronizely (Stephen Yuan Jiang)
> {noformat}
> and sure enough, if I revert HBASE-16488 from branch-1 / branch-1.4 then the
> test passes again.
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 7.211 sec <<<
> FAILURE! - in org.apache.hadoop.hbase.client.TestClientScannerRPCTimeout
> testScannerNextRPCTimesout(org.apache.hadoop.hbase.client.TestClientScannerRPCTimeout)
> Time elapsed: 6.248 sec <<< ERROR!
> org.apache.hadoop.hbase.TableExistsException: testScannerNextRPCTimesout
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:526)
> at
> org.apache.hadoop.ipc.RemoteException.instantiateException(RemoteException.java:106)
> at
> org.apache.hadoop.ipc.RemoteException.unwrapRemoteException(RemoteException.java:95)
> at
> org.apache.hadoop.hbase.util.ForeignExceptionUtil.toIOException(ForeignExceptionUtil.java:45)
> at
> org.apache.hadoop.hbase.client.HBaseAdmin$ProcedureFuture.convertResult(HBaseAdmin.java:4774)
> at
> org.apache.hadoop.hbase.client.HBaseAdmin$ProcedureFuture.waitProcedureResult(HBaseAdmin.java:4732)
> at
> org.apache.hadoop.hbase.client.HBaseAdmin$ProcedureFuture.get(HBaseAdmin.java:4665)
> at
> org.apache.hadoop.hbase.client.HBaseAdmin.createTable(HBaseAdmin.java:679)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.createTable(HBaseTestingUtility.java:1500)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.createTable(HBaseTestingUtility.java:1547)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.createTable(HBaseTestingUtility.java:1438)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.createTable(HBaseTestingUtility.java:1414)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.createTable(HBaseTestingUtility.java:1370)
> at
> org.apache.hadoop.hbase.client.TestClientScannerRPCTimeout.testScannerNextRPCTimesout(TestClientScannerRPCTimeout.java:87)
> Caused by: org.apache.hadoop.ipc.RemoteException: testScannerNextRPCTimesout
> at
> org.apache.hadoop.hbase.master.procedure.CreateTableProcedure.prepareCreate(CreateTableProcedure.java:286)
> at
> org.apache.hadoop.hbase.master.procedure.CreateTableProcedure.executeFromState(CreateTableProcedure.java:107)
> at
> org.apache.hadoop.hbase.master.procedure.CreateTableProcedure.executeFromState(CreateTableProcedure.java:59)
> at
> org.apache.hadoop.hbase.procedure2.StateMachineProcedure.execute(StateMachineProcedure.java:139)
> at
> org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:506)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1152)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execLoop(ProcedureExecutor.java:940)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execLoop(ProcedureExecutor.java:893)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$400(ProcedureExecutor.java:76)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor$2.run(ProcedureExecutor.java:478)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18415) The local timeout may cause Admin to submit duplicate request
[ https://issues.apache.org/jira/browse/HBASE-18415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18415: --- Status: Patch Available (was: Open) > The local timeout may cause Admin to submit duplicate request > - > > Key: HBASE-18415 > URL: https://issues.apache.org/jira/browse/HBASE-18415 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18415.branch-1.ut.patch, > HBASE-18415.branch-1.v0.patch, HBASE-18415.branch-1.v1.patch, > HBASE-18415.branch-1.v2.patch, HBASE-18415.branch-1.v3.patch > > > After a timeout occurs on first request, client will retry the request with > distinct group/nonce. The second request may bring the TableXXXException back > if the first request have changed the table state. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18415) The local timeout may cause Admin to submit duplicate request
[ https://issues.apache.org/jira/browse/HBASE-18415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18415: --- Status: Open (was: Patch Available) > The local timeout may cause Admin to submit duplicate request > - > > Key: HBASE-18415 > URL: https://issues.apache.org/jira/browse/HBASE-18415 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18415.branch-1.ut.patch, > HBASE-18415.branch-1.v0.patch, HBASE-18415.branch-1.v1.patch, > HBASE-18415.branch-1.v2.patch, HBASE-18415.branch-1.v3.patch > > > After a timeout occurs on first request, client will retry the request with > distinct group/nonce. The second request may bring the TableXXXException back > if the first request have changed the table state. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18415) The local timeout may cause Admin to submit duplicate request
[ https://issues.apache.org/jira/browse/HBASE-18415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18415: --- Attachment: HBASE-18415.branch-1.v3.patch v3: address ted's comment > The local timeout may cause Admin to submit duplicate request > - > > Key: HBASE-18415 > URL: https://issues.apache.org/jira/browse/HBASE-18415 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18415.branch-1.ut.patch, > HBASE-18415.branch-1.v0.patch, HBASE-18415.branch-1.v1.patch, > HBASE-18415.branch-1.v2.patch, HBASE-18415.branch-1.v3.patch > > > After a timeout occurs on first request, client will retry the request with > distinct group/nonce. The second request may bring the TableXXXException back > if the first request have changed the table state. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18415) The local timeout may cause Admin to submit duplicate request
[ https://issues.apache.org/jira/browse/HBASE-18415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169157#comment-16169157 ] Ted Yu commented on HBASE-18415: Fine - I wasn't using IDE when reviewing so didn't notice this. > The local timeout may cause Admin to submit duplicate request > - > > Key: HBASE-18415 > URL: https://issues.apache.org/jira/browse/HBASE-18415 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18415.branch-1.ut.patch, > HBASE-18415.branch-1.v0.patch, HBASE-18415.branch-1.v1.patch, > HBASE-18415.branch-1.v2.patch > > > After a timeout occurs on first request, client will retry the request with > distinct group/nonce. The second request may bring the TableXXXException back > if the first request have changed the table state. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18415) The local timeout may cause Admin to submit duplicate request
[
https://issues.apache.org/jira/browse/HBASE-18415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169156#comment-16169156
]
Hadoop QA commented on HBASE-18415:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
21s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
25s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
53s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
38s{color} | {color:green} branch-1 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
44s{color} | {color:green} branch-1 passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
45s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
55s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
48s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
20s{color} | {color:green} branch-1 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
46s{color} | {color:green} branch-1 passed with JDK v1.7.0_151 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
45s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
14s{color} | {color:green} hbase-client in the patch passed with JDK
v1.8.0_144. {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
31s{color} | {color:green} hbase-server-jdk1.8.0_144 with JDK v1.8.0_144
generated 0 new + 5 unchanged - 5 fixed = 5 total (was 10) {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
52s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
17s{color} | {color:green} hbase-client in the patch passed with JDK
v1.7.0_151. {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
35s{color} | {color:green} hbase-server-jdk1.7.0_151 with JDK v1.7.0_151
generated 0 new + 5 unchanged - 5 fixed = 5 total (was 10) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
15m 56s{color} | {color:green} The patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
14s{color} | {color:green} hbase-client-jdk1.8.0_144 with JDK v1.8.0_144
generated 0 new + 13 unchanged - 13 fixed = 13 total (was 26) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
25s{color} | {color:green} hbase-server-jdk1.8.0_144 with JDK v1.8.0_144
generated 0 new + 3 unchanged - 3 fixed = 3 total (was 6) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
20s{color} | {color:green} hbase-client-jdk1.7.0_151 with JDK v1.7.0_151
generated 0 new + 13 unchanged
[jira] [Commented] (HBASE-18415) The local timeout may cause Admin to submit duplicate request
[
https://issues.apache.org/jira/browse/HBASE-18415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169154#comment-16169154
]
Chia-Ping Tsai commented on HBASE-18415:
{code}
+@Override
+public void throwable(Throwable t, boolean retrying) {
+ if (!isLocalError(t)) {
+group = ng.getNonceGroup();
+nonce = ng.newNonce();
+ }
+}
{code}
ReuseNonceMasterCallable need to keep reference to ng to reset the group/nonce.
> The local timeout may cause Admin to submit duplicate request
> -
>
> Key: HBASE-18415
> URL: https://issues.apache.org/jira/browse/HBASE-18415
> Project: HBase
> Issue Type: Bug
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7
>
> Attachments: HBASE-18415.branch-1.ut.patch,
> HBASE-18415.branch-1.v0.patch, HBASE-18415.branch-1.v1.patch,
> HBASE-18415.branch-1.v2.patch
>
>
> After a timeout occurs on first request, client will retry the request with
> distinct group/nonce. The second request may bring the TableXXXException back
> if the first request have changed the table state.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18415) The local timeout may cause Admin to submit duplicate request
[ https://issues.apache.org/jira/browse/HBASE-18415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169152#comment-16169152 ] Ted Yu commented on HBASE-18415: For #3, since the getters of ReuseNonceMasterCallable only return long, I think the NonceGenerator field can be dropped. > The local timeout may cause Admin to submit duplicate request > - > > Key: HBASE-18415 > URL: https://issues.apache.org/jira/browse/HBASE-18415 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18415.branch-1.ut.patch, > HBASE-18415.branch-1.v0.patch, HBASE-18415.branch-1.v1.patch, > HBASE-18415.branch-1.v2.patch > > > After a timeout occurs on first request, client will retry the request with > distinct group/nonce. The second request may bring the TableXXXException back > if the first request have changed the table state. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18415) The local timeout may cause Admin to submit duplicate request
[ https://issues.apache.org/jira/browse/HBASE-18415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169151#comment-16169151 ] Chia-Ping Tsai commented on HBASE-18415: bq. Wildcard should not be used. My dumb ide...Will fix it. bq. ReuseNonceMasterCallable -> NonceReusingMasterCallable copy that. bq. Do we need to keep reference to NonceGenerator and the (group, nounce) pair at the same time ? Do you mean *synchronization*? If so, we don't need to keep them at the same time because the group/nonce is just random long value now. > The local timeout may cause Admin to submit duplicate request > - > > Key: HBASE-18415 > URL: https://issues.apache.org/jira/browse/HBASE-18415 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18415.branch-1.ut.patch, > HBASE-18415.branch-1.v0.patch, HBASE-18415.branch-1.v1.patch, > HBASE-18415.branch-1.v2.patch > > > After a timeout occurs on first request, client will retry the request with > distinct group/nonce. The second request may bring the TableXXXException back > if the first request have changed the table state. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18798) Remove the unused methods in RegionServerObserver
[ https://issues.apache.org/jira/browse/HBASE-18798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169066#comment-16169066 ] stack commented on HBASE-18798: --- +1 on patch. Sorry for the retry. We need to figure why the timeout happens. But yeah, good to get a clean run to be sure no one depends on these removals. Nice cleanup. > Remove the unused methods in RegionServerObserver > - > > Key: HBASE-18798 > URL: https://issues.apache.org/jira/browse/HBASE-18798 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18798.v0.patch, HBASE-18798.v0.patch, > HBASE-18798.v0.patch, HBASE-18798.v1.patch, HBASE-18798.v1.patch > > > # preRollBackMerge > # postRollBackMerge > # preMergeCommit > # postMergeCommit > # postMerge > # preMerge > HBASE-17470 drop the rs-side merge code -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18832) LTT fails with casting exception for HColumnDescriptor
[
https://issues.apache.org/jira/browse/HBASE-18832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169064#comment-16169064
]
stack commented on HBASE-18832:
---
I think you have a patch [~uagashe], no? Thanks boss.
> LTT fails with casting exception for HColumnDescriptor
> --
>
> Key: HBASE-18832
> URL: https://issues.apache.org/jira/browse/HBASE-18832
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0-alpha-4
>Reporter: Umesh Agashe
>Assignee: Umesh Agashe
>
> Here is the stack trace:
> {code}
> 2017-09-15 12:38:38,158 ERROR [main] util.AbstractHBaseTool: Error running
> command-line tool
> java.lang.ClassCastException:
> org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder$ModifyableColumnFamilyDescriptor
> cannot be cast to org.apache.hadoop.hbase.HColumnDescriptor
> at
> org.apache.hadoop.hbase.util.LoadTestTool.applyColumnFamilyOptions(LoadTestTool.java:265)
> at
> org.apache.hadoop.hbase.util.LoadTestTool.initTestTable(LoadTestTool.java:540)
> at
> org.apache.hadoop.hbase.util.LoadTestTool.loadTable(LoadTestTool.java:567)
> at
> org.apache.hadoop.hbase.util.LoadTestTool.doWork(LoadTestTool.java:548)
> at
> org.apache.hadoop.hbase.util.AbstractHBaseTool.run(AbstractHBaseTool.java:154)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
> at
> org.apache.hadoop.hbase.util.AbstractHBaseTool.doStaticMain(AbstractHBaseTool.java:262)
> at
> org.apache.hadoop.hbase.util.LoadTestTool.main(LoadTestTool.java:793)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18601) Update Htrace to 4.2
[
https://issues.apache.org/jira/browse/HBASE-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169062#comment-16169062
]
stack commented on HBASE-18601:
---
[~tamaas] Fix your IDE so it does not do this 'helpful' change for you: +import
java.util.*; We do explicit import of each class always sir.
+public class TraceUtil { Needs InterfaceAudience Private (see the adjacent
classes in the package -- I like how you put this util back up in hbase-common
in here in this package... good one). A bit of javadoc on how to use and a test
even wouldn't go amiss (smile). We need to shove this nice utility back up into
htrace. Let me open issue pointing to your example after it goes in.
Skimmed the rest. LGTM. Thanks [~tamaas]
> Update Htrace to 4.2
>
>
> Key: HBASE-18601
> URL: https://issues.apache.org/jira/browse/HBASE-18601
> Project: HBase
> Issue Type: Task
>Affects Versions: 2.0.0, 3.0.0
>Reporter: Tamas Penzes
>Assignee: Tamas Penzes
> Fix For: 2.0.0-alpha-3
>
> Attachments: HBASE-18601.master.001.patch,
> HBASE-18601.master.002.patch, HBASE-18601.master.003 (3).patch,
> HBASE-18601.master.003.patch
>
>
> HTrace is not perfectly integrated into HBase, the version 3.2.0 is buggy,
> the upgrade to 4.x is not trivial and would take time. It might not worth to
> keep it in this state, so would be better to remove it.
> Of course it doesn't mean tracing would be useless, just that in this form
> the use of HTrace 3.2 might not add any value to the project and fixing it
> would be far too much effort.
> -
> Based on the decision of the community we keep htrace now and update version
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18601) Update Htrace to 4.2
[ https://issues.apache.org/jira/browse/HBASE-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18601: -- Attachment: HBASE-18601.master.003 (3).patch Retry > Update Htrace to 4.2 > > > Key: HBASE-18601 > URL: https://issues.apache.org/jira/browse/HBASE-18601 > Project: HBase > Issue Type: Task >Affects Versions: 2.0.0, 3.0.0 >Reporter: Tamas Penzes >Assignee: Tamas Penzes > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18601.master.001.patch, > HBASE-18601.master.002.patch, HBASE-18601.master.003 (3).patch, > HBASE-18601.master.003.patch > > > HTrace is not perfectly integrated into HBase, the version 3.2.0 is buggy, > the upgrade to 4.x is not trivial and would take time. It might not worth to > keep it in this state, so would be better to remove it. > Of course it doesn't mean tracing would be useless, just that in this form > the use of HTrace 3.2 might not add any value to the project and fixing it > would be far too much effort. > - > Based on the decision of the community we keep htrace now and update version -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18415) The local timeout may cause Admin to submit duplicate request
[
https://issues.apache.org/jira/browse/HBASE-18415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169024#comment-16169024
]
Ted Yu commented on HBASE-18415:
{code}
+import org.apache.hadoop.hbase.ipc.*;
{code}
Wildcard should not be used.
ReuseNonceMasterCallable -> NonceReusingMasterCallable
{code}
+ReuseNonceMasterCallable(HConnection con, NonceGenerator ng) {
+ super(con);
+ this.ng = ng;
+ group = ng.getNonceGroup();
+ nonce = ng.newNonce();
{code}
Do we need to keep reference to NonceGenerator and the (group, nounce) pair at
the same time ?
> The local timeout may cause Admin to submit duplicate request
> -
>
> Key: HBASE-18415
> URL: https://issues.apache.org/jira/browse/HBASE-18415
> Project: HBase
> Issue Type: Bug
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7
>
> Attachments: HBASE-18415.branch-1.ut.patch,
> HBASE-18415.branch-1.v0.patch, HBASE-18415.branch-1.v1.patch,
> HBASE-18415.branch-1.v2.patch
>
>
> After a timeout occurs on first request, client will retry the request with
> distinct group/nonce. The second request may bring the TableXXXException back
> if the first request have changed the table state.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (HBASE-18415) The local timeout may cause Admin to submit duplicate request
[ https://issues.apache.org/jira/browse/HBASE-18415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169007#comment-16169007 ] Chia-Ping Tsai edited comment on HBASE-18415 at 9/16/17 6:08 PM: - The following methods will re-submit request with same group/nonce if the previous request timeout. # createTable # disableTable # truncateTable # addColumn # deleteColumn # enableTable # deleteTable was (Author: chia7712): The following methods will re-submit request with same group/nonce. # createTable # disableTable # truncateTable # addColumn # deleteColumn # enableTable # deleteTable > The local timeout may cause Admin to submit duplicate request > - > > Key: HBASE-18415 > URL: https://issues.apache.org/jira/browse/HBASE-18415 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18415.branch-1.ut.patch, > HBASE-18415.branch-1.v0.patch, HBASE-18415.branch-1.v1.patch, > HBASE-18415.branch-1.v2.patch > > > After a timeout occurs on first request, client will retry the request with > distinct group/nonce. The second request may bring the TableXXXException back > if the first request have changed the table state. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18415) The local timeout may cause Admin to submit duplicate request
[ https://issues.apache.org/jira/browse/HBASE-18415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169007#comment-16169007 ] Chia-Ping Tsai commented on HBASE-18415: The following methods will re-submit request with same group/nonce. # createTable # disableTable # truncateTable # addColumn # deleteColumn # enableTable # deleteTable > The local timeout may cause Admin to submit duplicate request > - > > Key: HBASE-18415 > URL: https://issues.apache.org/jira/browse/HBASE-18415 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18415.branch-1.ut.patch, > HBASE-18415.branch-1.v0.patch, HBASE-18415.branch-1.v1.patch, > HBASE-18415.branch-1.v2.patch > > > After a timeout occurs on first request, client will retry the request with > distinct group/nonce. The second request may bring the TableXXXException back > if the first request have changed the table state. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18415) The local timeout may cause Admin to submit duplicate request
[ https://issues.apache.org/jira/browse/HBASE-18415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18415: --- Attachment: HBASE-18415.branch-1.v2.patch > The local timeout may cause Admin to submit duplicate request > - > > Key: HBASE-18415 > URL: https://issues.apache.org/jira/browse/HBASE-18415 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18415.branch-1.ut.patch, > HBASE-18415.branch-1.v0.patch, HBASE-18415.branch-1.v1.patch, > HBASE-18415.branch-1.v2.patch > > > After a timeout occurs on first request, client will retry the request with > distinct group/nonce. The second request may bring the TableXXXException back > if the first request have changed the table state. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18415) The local timeout may cause Admin to submit duplicate request
[ https://issues.apache.org/jira/browse/HBASE-18415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18415: --- Status: Patch Available (was: Open) > The local timeout may cause Admin to submit duplicate request > - > > Key: HBASE-18415 > URL: https://issues.apache.org/jira/browse/HBASE-18415 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18415.branch-1.ut.patch, > HBASE-18415.branch-1.v0.patch, HBASE-18415.branch-1.v1.patch, > HBASE-18415.branch-1.v2.patch > > > After a timeout occurs on first request, client will retry the request with > distinct group/nonce. The second request may bring the TableXXXException back > if the first request have changed the table state. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18415) The local timeout may cause Admin to submit duplicate request
[ https://issues.apache.org/jira/browse/HBASE-18415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18415: --- Summary: The local timeout may cause Admin to submit duplicate request (was: The "retry" may cause TableExistsException even if the table did not exist before) > The local timeout may cause Admin to submit duplicate request > - > > Key: HBASE-18415 > URL: https://issues.apache.org/jira/browse/HBASE-18415 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18415.branch-1.ut.patch, > HBASE-18415.branch-1.v0.patch, HBASE-18415.branch-1.v1.patch > > > After a timeout occurs on first request, client will retry the request with > distinct group/nonce. The second request may bring the TableXXXException back > if the first request have changed the table state. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18131) Add an hbase shell command to clear deadserver list in ServerManager
[
https://issues.apache.org/jira/browse/HBASE-18131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169006#comment-16169006
]
Chia-Ping Tsai commented on HBASE-18131:
The {{getClusterStatus}} can return the list of dead servers. Perhaps the
{{listDeadServers}} is unnecessary. WDYT? [~andrewcheng] Thanks.
> Add an hbase shell command to clear deadserver list in ServerManager
>
>
> Key: HBASE-18131
> URL: https://issues.apache.org/jira/browse/HBASE-18131
> Project: HBase
> Issue Type: New Feature
> Components: Operability
>Reporter: Yu Li
>Assignee: Guangxu Cheng
> Fix For: 1.4.0, 1.5.0, 2.0.0-alpha-3
>
> Attachments: HBASE-18131.branch-1.v1.patch,
> HBASE-18131.branch-1.v2.patch, HBASE-18131.master.v1.patch,
> HBASE-18131.master.v2.patch, HBASE-18131.master.v3.patch,
> HBASE-18131.master.v4.patch, HBASE-18131.master.v5.patch,
> HBASE-18131.master.v6.patch, HBASE-18131.master.v6.patch,
> HBASE-18131.master.v7.patch, HBASE-18131.patch
>
>
> Currently if a regionserver is aborted due to fatal error or stopped by
> operator on purpose, it will be added into {{ServerManager#deadservers}} list
> and shown as "Dead Servers" in the master UI. This is a valid warn for
> operators to notice the self-aborted servers and give a sanity check to
> avoid further issues. However, after necessary checks, even if operator is
> sure that the node is decommissioned (such as for repair), there's no way to
> clear the dead server list except restarting master. See more details in
> [this
> discussion|http://mail-archives.apache.org/mod_mbox/hbase-user/201705.mbox/%3CCAM7-19%2BD4MLu2b1R94%2BtWQDspjfny2sCy4Qit8JtCgjvTOZzzg%40mail.gmail.com%3E]
> in mail list
> Here we propose to add a hbase shell command to allow clearing dead server
> list in {{ServerManager}} for advanced users, and the command should be
> executed with caution.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Assigned] (HBASE-18808) Ineffective config check in BackupLogCleaner#getDeletableFiles()
[
https://issues.apache.org/jira/browse/HBASE-18808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vladimir Rodionov reassigned HBASE-18808:
-
Assignee: (was: Vladimir Rodionov)
> Ineffective config check in BackupLogCleaner#getDeletableFiles()
>
>
> Key: HBASE-18808
> URL: https://issues.apache.org/jira/browse/HBASE-18808
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>
> Here is related code:
> {code}
> if (this.getConf() == null || !BackupManager.isBackupEnabled(getConf())) {
> LOG.warn("Backup is not enabled. Check your " +
> BackupRestoreConstants.BACKUP_ENABLE_KEY
> + " setting");
> return files;
> }
> {code}
> However, in setConf() we don't store the Configuration where backup is
> disabled:
> {code}
> public void setConf(Configuration config) {
> // If backup is disabled, keep all members null
> if (!config.getBoolean(BackupRestoreConstants.BACKUP_ENABLE_KEY,
> BackupRestoreConstants.BACKUP_ENABLE_DEFAULT)) {
> LOG.warn("Backup is disabled - allowing all wals to be deleted");
> return;
> }
> {code}
> This means that once config with backup enabled is remembered, it won't go to
> disabled state.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18829) Consider reverting HBASE-14893 Race between mutation on region and region closing operation
[ https://issues.apache.org/jira/browse/HBASE-18829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169002#comment-16169002 ] Andrew Purtell commented on HBASE-18829: I want to see rigorous testing of this change before we commit it. I don't want a repeat of the storefile locking change. Rigorous implies ~24 hours of testing with ITBLL. I will insist on post of evidence of positive results like this before a commit, thanks. I think everyone can appreciate the abundance of caution. > Consider reverting HBASE-14893 Race between mutation on region and region > closing operation > --- > > Key: HBASE-18829 > URL: https://issues.apache.org/jira/browse/HBASE-18829 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 18829.v1.txt > > > HBASE-14893 was brought to attention by [~rajeshbabu] over PHOENIX-3111. > This issue is to consider reverting the fix from HBASE-14893 based on the > following observations: > * The closing boolean was intended to be acquired before taking the lock > ([~enis]) > * Phoenix local index has evolved over the years, the situation leading to > NotServingRegionException may not exist from Phoenix side > * Even if the situation still exists, downstream project (Phoenix) should > properly handle NotServingRegionException without change in locking scheme in > hbase -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18831) Add explicit dependency on javax.el
[ https://issues.apache.org/jira/browse/HBASE-18831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18831: -- Resolution: Fixed Hadoop Flags: Reviewed Release Note: Specify an explicit version for javax.el. Without it we rely on repository cached metadata of which a prevalent version seems to list all versions between b01 and b08 but finishes with a b08-jbossorg which is in the jboss repo, a repo most of us do not list in our poms. Status: Resolved (was: Patch Available) Pushed to master and branch-2 (FYI [~appy] <= This worked for [~Apache9] too) > Add explicit dependency on javax.el > --- > > Key: HBASE-18831 > URL: https://issues.apache.org/jira/browse/HBASE-18831 > Project: HBase > Issue Type: Bug > Components: dependencies >Reporter: stack >Assignee: stack > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18831.branch-2.001.patch > > > Previous build would search for it running up through all point version from > 3.0.1-b1 until it hit b8. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18831) Add explicit dependency on javax.el
[ https://issues.apache.org/jira/browse/HBASE-18831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168995#comment-16168995 ] stack commented on HBASE-18831: --- [~Apache9] I asked because it didn't look like it fixed the issue for us on our internal repo but it seems it does after all. Thanks for confirming. > Add explicit dependency on javax.el > --- > > Key: HBASE-18831 > URL: https://issues.apache.org/jira/browse/HBASE-18831 > Project: HBase > Issue Type: Bug > Components: dependencies >Reporter: stack >Assignee: stack > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18831.branch-2.001.patch > > > Previous build would search for it running up through all point version from > 3.0.1-b1 until it hit b8. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18131) Add an hbase shell command to clear deadserver list in ServerManager
[
https://issues.apache.org/jira/browse/HBASE-18131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-18131:
---
Resolution: Fixed
Hadoop Flags: Reviewed
Fix Version/s: (was: 2.0.0)
2.0.0-alpha-3
1.5.0
Status: Resolved (was: Patch Available)
Ran TestReplicationShell and TestShell locally with branch-1 patch which passed.
Thanks for the patch.
> Add an hbase shell command to clear deadserver list in ServerManager
>
>
> Key: HBASE-18131
> URL: https://issues.apache.org/jira/browse/HBASE-18131
> Project: HBase
> Issue Type: New Feature
> Components: Operability
>Reporter: Yu Li
>Assignee: Guangxu Cheng
> Fix For: 1.4.0, 1.5.0, 2.0.0-alpha-3
>
> Attachments: HBASE-18131.branch-1.v1.patch,
> HBASE-18131.branch-1.v2.patch, HBASE-18131.master.v1.patch,
> HBASE-18131.master.v2.patch, HBASE-18131.master.v3.patch,
> HBASE-18131.master.v4.patch, HBASE-18131.master.v5.patch,
> HBASE-18131.master.v6.patch, HBASE-18131.master.v6.patch,
> HBASE-18131.master.v7.patch, HBASE-18131.patch
>
>
> Currently if a regionserver is aborted due to fatal error or stopped by
> operator on purpose, it will be added into {{ServerManager#deadservers}} list
> and shown as "Dead Servers" in the master UI. This is a valid warn for
> operators to notice the self-aborted servers and give a sanity check to
> avoid further issues. However, after necessary checks, even if operator is
> sure that the node is decommissioned (such as for repair), there's no way to
> clear the dead server list except restarting master. See more details in
> [this
> discussion|http://mail-archives.apache.org/mod_mbox/hbase-user/201705.mbox/%3CCAM7-19%2BD4MLu2b1R94%2BtWQDspjfny2sCy4Qit8JtCgjvTOZzzg%40mail.gmail.com%3E]
> in mail list
> Here we propose to add a hbase shell command to allow clearing dead server
> list in {{ServerManager}} for advanced users, and the command should be
> executed with caution.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18641) Include block content verification logic used in lruCache in bucketCache
[ https://issues.apache.org/jira/browse/HBASE-18641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-18641: --- Resolution: Fixed Status: Resolved (was: Patch Available) Failed tests were not related. Thanks for the patch, Biju. > Include block content verification logic used in lruCache in bucketCache > > > Key: HBASE-18641 > URL: https://issues.apache.org/jira/browse/HBASE-18641 > Project: HBase > Issue Type: Bug > Components: regionserver >Reporter: Biju Nair >Assignee: Biju Nair >Priority: Minor > Fix For: 1.4.0, 1.5.0, 2.0.0-alpha-3 > > Attachments: HBASE-18641-branch-1.PATCH, HBASE-18641.PATCH, > HBASE-18641-V1.0.PATCH, HBASE-18641-WIP.PATCH > > > With off-heap/bucketCache being used to cache data blocks without going > through on-heap cache, the logic used in lruCache to check the content of > already cached block need to be included in bucketCache. Please see this > [discussion|https://mail-archives.apache.org/mod_mbox/hbase-dev/201708.mbox/%3cCAO40JLCnXLw3=0bbUaXdDx=w2fklljefvgj6-uvj_2jhfvo...@mail.gmail.com%3e] > for details. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18415) The "retry" may cause TableExistsException even if the table did not exist before
[ https://issues.apache.org/jira/browse/HBASE-18415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18415: --- Fix Version/s: 1.2.7 1.3.2 > The "retry" may cause TableExistsException even if the table did not exist > before > - > > Key: HBASE-18415 > URL: https://issues.apache.org/jira/browse/HBASE-18415 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18415.branch-1.ut.patch, > HBASE-18415.branch-1.v0.patch, HBASE-18415.branch-1.v1.patch > > > After a timeout occurs on first request, client will retry the request with > distinct group/nonce. The second request may bring the TableXXXException back > if the first request have changed the table state. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18415) The "retry" may cause TableExistsException even if the table did not exist before
[ https://issues.apache.org/jira/browse/HBASE-18415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18415: --- Fix Version/s: 1.5.0 1.4.0 > The "retry" may cause TableExistsException even if the table did not exist > before > - > > Key: HBASE-18415 > URL: https://issues.apache.org/jira/browse/HBASE-18415 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0, 1.4.0, 1.5.0 > > Attachments: HBASE-18415.branch-1.ut.patch, > HBASE-18415.branch-1.v0.patch, HBASE-18415.branch-1.v1.patch > > > After a timeout occurs on first request, client will retry the request with > distinct group/nonce. The second request may bring the TableXXXException back > if the first request have changed the table state. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18142) Deletion of a cell deletes the previous versions too
[ https://issues.apache.org/jira/browse/HBASE-18142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168882#comment-16168882 ] Chia-Ping Tsai commented on HBASE-18142: Will commit it tomorrow if no objections. > Deletion of a cell deletes the previous versions too > > > Key: HBASE-18142 > URL: https://issues.apache.org/jira/browse/HBASE-18142 > Project: HBase > Issue Type: Bug > Components: API, shell >Affects Versions: 3.0.0, 1.3.1, 1.2.6, 2.0.0-alpha-1 >Reporter: Karthick >Assignee: ChunHao > Labels: beginner > Fix For: 2.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7 > > Attachments: HBASE-18142.master.v0.patch, > HBASE-18142.master.v1.patch, HBASE-18142.master.v2.patch, > HBASE-18142.master.v3.patch, HBASE-18142.master.v4.patch, > HBASE-18142.master.v5.patch, HBASE-18142.master.v6.patch, > HBASE-18142.master.v7.patch, HBASE-18142.master.v8.patch > > > When I tried to delete a cell using it's timestamp in the Hbase Shell, the > previous versions of the same cell also got deleted. But when I tried the > same using the Java API, then the previous versions are not deleted and I can > retrive the previous values. > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Delete.java > see this file to fix the issue. This method (public Delete addColumn(final > byte [] family, final byte [] qualifier, final long timestamp)) only deletes > the current version of the cell. The previous versions are not deleted. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17169) Remove Cell variants with ShareableMemory
[
https://issues.apache.org/jira/browse/HBASE-17169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168872#comment-16168872
]
Chia-Ping Tsai commented on HBASE-17169:
{code}
+ /**
+ * Does a deep copy of the contents to a new memory area and returns it as a
new cell.
+ * @return The deep cloned cell
+ */
+ Cell deepClone();
{code}
The clone of ExtendedCell is not a ExtendedCell but Cell. Should we change the
return type to ExtendedCell?
> Remove Cell variants with ShareableMemory
> -
>
> Key: HBASE-17169
> URL: https://issues.apache.org/jira/browse/HBASE-17169
> Project: HBase
> Issue Type: Sub-task
> Components: regionserver
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
> Fix For: 2.0.0
>
> Attachments: HBASE-17169.patch
>
>
> As asked by Stack in review comment of other sub tasks of the parent.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18010) Connect CellChunkMap to be used for flattening in CompactingMemStore
[ https://issues.apache.org/jira/browse/HBASE-18010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168870#comment-16168870 ] Anastasia Braginsky commented on HBASE-18010: - Hey, I'll prepare a patch for branch2 tomorrow. > Connect CellChunkMap to be used for flattening in CompactingMemStore > > > Key: HBASE-18010 > URL: https://issues.apache.org/jira/browse/HBASE-18010 > Project: HBase > Issue Type: Sub-task >Reporter: Anastasia Braginsky >Assignee: Anastasia Braginsky > Fix For: 3.0.0 > > Attachments: HBASE-18010-V04.patch, HBASE-18010-V06.patch, > HBASE-18010-V07.patch, HBASE-18010-V08.patch, HBASE-18010-V09.patch, > HBASE-18010-V10.patch, HBASE-18010-V11.patch > > > The CellChunkMap helps to create a new type of ImmutableSegment, where the > index (CellSet's delegatee) is going to be CellChunkMap. No big cells or > upserted cells are going to be supported here. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18010) Connect CellChunkMap to be used for flattening in CompactingMemStore
[ https://issues.apache.org/jira/browse/HBASE-18010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168869#comment-16168869 ] Chia-Ping Tsai commented on HBASE-18010: Ping [~anastas] > Connect CellChunkMap to be used for flattening in CompactingMemStore > > > Key: HBASE-18010 > URL: https://issues.apache.org/jira/browse/HBASE-18010 > Project: HBase > Issue Type: Sub-task >Reporter: Anastasia Braginsky >Assignee: Anastasia Braginsky > Fix For: 3.0.0 > > Attachments: HBASE-18010-V04.patch, HBASE-18010-V06.patch, > HBASE-18010-V07.patch, HBASE-18010-V08.patch, HBASE-18010-V09.patch, > HBASE-18010-V10.patch, HBASE-18010-V11.patch > > > The CellChunkMap helps to create a new type of ImmutableSegment, where the > index (CellSet's delegatee) is going to be CellChunkMap. No big cells or > upserted cells are going to be supported here. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18798) Remove the unused methods in RegionServerObserver
[ https://issues.apache.org/jira/browse/HBASE-18798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18798: --- Status: Patch Available (was: Open) > Remove the unused methods in RegionServerObserver > - > > Key: HBASE-18798 > URL: https://issues.apache.org/jira/browse/HBASE-18798 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18798.v0.patch, HBASE-18798.v0.patch, > HBASE-18798.v0.patch, HBASE-18798.v1.patch, HBASE-18798.v1.patch > > > # preRollBackMerge > # postRollBackMerge > # preMergeCommit > # postMergeCommit > # postMerge > # preMerge > HBASE-17470 drop the rs-side merge code -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18798) Remove the unused methods in RegionServerObserver
[ https://issues.apache.org/jira/browse/HBASE-18798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18798: --- Attachment: HBASE-18798.v1.patch retry > Remove the unused methods in RegionServerObserver > - > > Key: HBASE-18798 > URL: https://issues.apache.org/jira/browse/HBASE-18798 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18798.v0.patch, HBASE-18798.v0.patch, > HBASE-18798.v0.patch, HBASE-18798.v1.patch, HBASE-18798.v1.patch > > > # preRollBackMerge > # postRollBackMerge > # preMergeCommit > # postMergeCommit > # postMerge > # preMerge > HBASE-17470 drop the rs-side merge code -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18798) Remove the unused methods in RegionServerObserver
[ https://issues.apache.org/jira/browse/HBASE-18798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18798: --- Status: Open (was: Patch Available) > Remove the unused methods in RegionServerObserver > - > > Key: HBASE-18798 > URL: https://issues.apache.org/jira/browse/HBASE-18798 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18798.v0.patch, HBASE-18798.v0.patch, > HBASE-18798.v0.patch, HBASE-18798.v1.patch > > > # preRollBackMerge > # postRollBackMerge > # preMergeCommit > # postMergeCommit > # postMerge > # preMerge > HBASE-17470 drop the rs-side merge code -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (HBASE-17980) Any HRegionInfo we give out should be immutable
[ https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved HBASE-17980. Resolution: Fixed Pushed the addendum to branch-2 and master. > Any HRegionInfo we give out should be immutable > --- > > Key: HBASE-17980 > URL: https://issues.apache.org/jira/browse/HBASE-17980 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0 >Reporter: Chia-Ping Tsai >Assignee: Kuan-Po Tseng > Labels: beginner > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-17980.master.001.patch, > HBASE-17980.master.002.patch, HBASE-17980.master.003.patch, > HBASE-17980.master.004.patch, HBASE-17980.master.005.patch, > HBASE-17980.master.006.patch, HBASE-17980.master.007.patch, > HBASE-17980.master.v0.patch, HBASE-17980.master.v1.patch, > HBASE-17980-master.v2.patch, HBASE-17980-master.v2.patch, > HBASE-17980.master.v3.patch, HBASE-17980.master.v4.patch, > HBASE-17980.master.v5.patch, HBASE-17980.master.v6.patch, > HBASE-17980.v0.addendum.patch > > > This is similar to HBASE-15583. > # Introduce RegionInfo class. HRegionInfo will extend RegionInfo. > # Deprecate HRegionInfo to be removed in 3.0 > # RegionInfo contain all of the read-only methods of HRegionInfo > # Add "RegionInfo Builder" -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18832) LTT fails with casting exception for HColumnDescriptor
[
https://issues.apache.org/jira/browse/HBASE-18832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168862#comment-16168862
]
Chia-Ping Tsai commented on HBASE-18832:
My mistake...Good finding!
> LTT fails with casting exception for HColumnDescriptor
> --
>
> Key: HBASE-18832
> URL: https://issues.apache.org/jira/browse/HBASE-18832
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0-alpha-4
>Reporter: Umesh Agashe
>Assignee: Umesh Agashe
>
> Here is the stack trace:
> {code}
> 2017-09-15 12:38:38,158 ERROR [main] util.AbstractHBaseTool: Error running
> command-line tool
> java.lang.ClassCastException:
> org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder$ModifyableColumnFamilyDescriptor
> cannot be cast to org.apache.hadoop.hbase.HColumnDescriptor
> at
> org.apache.hadoop.hbase.util.LoadTestTool.applyColumnFamilyOptions(LoadTestTool.java:265)
> at
> org.apache.hadoop.hbase.util.LoadTestTool.initTestTable(LoadTestTool.java:540)
> at
> org.apache.hadoop.hbase.util.LoadTestTool.loadTable(LoadTestTool.java:567)
> at
> org.apache.hadoop.hbase.util.LoadTestTool.doWork(LoadTestTool.java:548)
> at
> org.apache.hadoop.hbase.util.AbstractHBaseTool.run(AbstractHBaseTool.java:154)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
> at
> org.apache.hadoop.hbase.util.AbstractHBaseTool.doStaticMain(AbstractHBaseTool.java:262)
> at
> org.apache.hadoop.hbase.util.LoadTestTool.main(LoadTestTool.java:793)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18824) Default timestamp for Put and Delete is not System.currentTimeMillis(), but Long.MAX_VALUE
[
https://issues.apache.org/jira/browse/HBASE-18824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168850#comment-16168850
]
Chia-Ping Tsai commented on HBASE-18824:
Nice suggestion. [~water] What do yo think?
> Default timestamp for Put and Delete is not System.currentTimeMillis(), but
> Long.MAX_VALUE
> --
>
> Key: HBASE-18824
> URL: https://issues.apache.org/jira/browse/HBASE-18824
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Reporter: Xiang Li
>Assignee: Xiang Li
>Priority: Minor
>
> In http://hbase.apache.org/book.html#versions,
> 1. In chapter 27.2.4 Put
> bq. Doing a put always creates a new version of a cell, at a certain
> timestamp. {color:#205081}By default the system uses the server’s
> currentTimeMillis{color}, ...
> 2. In chapter 27.2.5 Delete
> bq. Deletes work by creating tombstone markers. For example, let’s suppose we
> want to delete a row. For this you can specify a version, or else
> {color:#205081}by default the currentTimeMillis is used.{color}...
> Checking the code, when timestamp is not specified,
> HConstants.LATEST_TIMESTAMP is used, which is Long.MAX_VALUE, rather than
> System.currentTimeMillis()
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18641) Include block content verification logic used in lruCache in bucketCache
[
https://issues.apache.org/jira/browse/HBASE-18641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168839#comment-16168839
]
Hadoop QA commented on HBASE-18641:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
22s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m
2s{color} | {color:blue} The patch file was not named according to hbase's
naming conventions. Please see
https://yetus.apache.org/documentation/0.4.0/precommit-patchnames for
instructions. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
4s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
32s{color} | {color:green} branch-1 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
35s{color} | {color:green} branch-1 passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
57s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
17s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
54s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
27s{color} | {color:green} branch-1 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
35s{color} | {color:green} branch-1 passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
32s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
34s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
15m 56s{color} | {color:green} The patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
25s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} the patch passed with JDK v1.7.0_151 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}407m 26s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 3m
41s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}441m 29s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.master.balancer.TestStochasticLoadBalancer2
|
| | hadoop.hbase.regionserver.TestRecoveredEdits |
| | hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint |
| | hadoop.hbase.client.TestAdmin2 |
| |
[jira] [Commented] (HBASE-18831) Add explicit dependency on javax.el
[
https://issues.apache.org/jira/browse/HBASE-18831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168829#comment-16168829
]
Hadoop QA commented on HBASE-18831:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
19s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
32s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m
17s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
55s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m
11s{color} | {color:green} branch-2 passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
17s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 5m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
6s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
35m 53s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 89m
23s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
53s{color} | {color:green} hbase-thrift in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
17s{color} | {color:green} hbase-rest in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}153m 46s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
3s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}320m 32s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:bd219c0 |
| JIRA Issue | HBASE-18831 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12887462/HBASE-18831.branch-2.001.patch
|
| Optional Tests | asflicense javac javadoc unit xml compile |
| uname | Linux 7cd5574b12ad 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | branch-2 / a5c8461 |
| Default Java | 1.8.0_144 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/8652/artifact/patchprocess/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8652/testReport/ |
| modules | C: hbase-server hbase-thrift hbase-rest . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8652/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Add explicit dependency on javax.el
> ---
>
> Key:
