[jira] [Updated] (HBASE-22728) Upgrade jackson dependencies in branch-1
[ https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22728: - Attachment: (was: HBASE-22728.branch-1.06.patch) > Upgrade jackson dependencies in branch-1 > > > Key: HBASE-22728 > URL: https://issues.apache.org/jira/browse/HBASE-22728 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.4.10, 1.3.5 >Reporter: Andrew Purtell >Assignee: Viraj Jasani >Priority: Major > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22728.branch-1.01.patch, > HBASE-22728.branch-1.02.patch, HBASE-22728.branch-1.04.patch, > HBASE-22728.branch-1.06.patch, dependency_codehaus.out > > > Avoid Jackson versions and dependencies with known CVEs -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22728) Upgrade jackson dependencies in branch-1
[ https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22728: - Attachment: HBASE-22728.branch-1.06.patch > Upgrade jackson dependencies in branch-1 > > > Key: HBASE-22728 > URL: https://issues.apache.org/jira/browse/HBASE-22728 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.4.10, 1.3.5 >Reporter: Andrew Purtell >Assignee: Viraj Jasani >Priority: Major > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22728.branch-1.01.patch, > HBASE-22728.branch-1.02.patch, HBASE-22728.branch-1.04.patch, > HBASE-22728.branch-1.06.patch, HBASE-22728.branch-1.06.patch, > dependency_codehaus.out > > > Avoid Jackson versions and dependencies with known CVEs -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22728) Upgrade jackson dependencies in branch-1
[ https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22728: - Attachment: HBASE-22728.branch-1.06.patch > Upgrade jackson dependencies in branch-1 > > > Key: HBASE-22728 > URL: https://issues.apache.org/jira/browse/HBASE-22728 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.4.10, 1.3.5 >Reporter: Andrew Purtell >Assignee: Viraj Jasani >Priority: Major > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22728.branch-1.01.patch, > HBASE-22728.branch-1.02.patch, HBASE-22728.branch-1.04.patch, > HBASE-22728.branch-1.06.patch, HBASE-22728.branch-1.06.patch, > dependency_codehaus.out > > > Avoid Jackson versions and dependencies with known CVEs -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22728) Upgrade jackson dependencies in branch-1
[ https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22728: - Attachment: (was: HBASE-22728.branch-1.06.patch) > Upgrade jackson dependencies in branch-1 > > > Key: HBASE-22728 > URL: https://issues.apache.org/jira/browse/HBASE-22728 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.4.10, 1.3.5 >Reporter: Andrew Purtell >Assignee: Viraj Jasani >Priority: Major > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22728.branch-1.01.patch, > HBASE-22728.branch-1.02.patch, HBASE-22728.branch-1.04.patch, > dependency_codehaus.out > > > Avoid Jackson versions and dependencies with known CVEs -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22728) Upgrade jackson dependencies in branch-1
[ https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22728: - Attachment: HBASE-22728.branch-1.06.patch > Upgrade jackson dependencies in branch-1 > > > Key: HBASE-22728 > URL: https://issues.apache.org/jira/browse/HBASE-22728 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.4.10, 1.3.5 >Reporter: Andrew Purtell >Assignee: Viraj Jasani >Priority: Major > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22728.branch-1.01.patch, > HBASE-22728.branch-1.02.patch, HBASE-22728.branch-1.04.patch, > dependency_codehaus.out > > > Avoid Jackson versions and dependencies with known CVEs -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22728) Upgrade jackson dependencies in branch-1
[ https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22728: - Attachment: (was: HBASE-22728.branch-1.06.patch) > Upgrade jackson dependencies in branch-1 > > > Key: HBASE-22728 > URL: https://issues.apache.org/jira/browse/HBASE-22728 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.4.10, 1.3.5 >Reporter: Andrew Purtell >Assignee: Viraj Jasani >Priority: Major > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22728.branch-1.01.patch, > HBASE-22728.branch-1.02.patch, HBASE-22728.branch-1.04.patch, > dependency_codehaus.out > > > Avoid Jackson versions and dependencies with known CVEs -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend
Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend URL: https://github.com/apache/hbase/pull/390#issuecomment-517888510 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 58 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 3 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 289 | master passed | | +1 | compile | 54 | master passed | | +1 | checkstyle | 80 | master passed | | +1 | shadedjars | 266 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 34 | master passed | | 0 | spotbugs | 230 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 228 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 290 | the patch passed | | +1 | compile | 52 | the patch passed | | +1 | javac | 52 | the patch passed | | +1 | checkstyle | 82 | hbase-server: The patch generated 0 new + 376 unchanged - 1 fixed = 376 total (was 377) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 270 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 897 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 35 | the patch passed | | +1 | findbugs | 243 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 15727 | hbase-server in the patch failed. | | +1 | asflicense | 43 | The patch does not generate ASF License warnings. | | | | 19016 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/27/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/390 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 815652470a26 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-390/out/precommit/personality/provided.sh | | git revision | master / a6f065396a | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/27/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/27/testReport/ | | Max. process+thread count | 5040 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/27/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22707) [HBCK2] MasterRpcServices assigns method should try to reload regions from meta if the passed regions isn't found under AssignmentManager RegionsStateStore
[
https://issues.apache.org/jira/browse/HBASE-22707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899309#comment-16899309
]
Hudson commented on HBASE-22707:
Results for branch branch-2
[build #2140 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2140/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2140//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2140//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2140//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [HBCK2] MasterRpcServices assigns method should try to reload regions from
> meta if the passed regions isn't found under AssignmentManager
> RegionsStateStore
> ---
>
> Key: HBASE-22707
> URL: https://issues.apache.org/jira/browse/HBASE-22707
> Project: HBase
> Issue Type: Task
> Components: hbck2, master
>Affects Versions: 3.0.0, 2.2.0, 2.3.0, 2.1.5
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments: HBASE-22707.branch-2.001.patch,
> HBASE-22707.branch-2.002.patch, HBASE-22707.master.001.patch
>
>
> Although HBCK2 related, this is a master side improvement. On situations
> where regions are missing in META, any online fix tool such as the one being
> implemented in HBASE-22567 would require a further master restart to get
> RegionsStateStore reloaded from META, so that master can be aware of the
> newly re-added regions.
> After regions are re-added to meta in CLOSED state, it should be possible to
> bring those by simply invoking hbck2 _assigns_ command. But before
> _MasterRpcServices.assigns_ submits an _Assign_ procedure, it validates first
> if the given region is available on _AssignmentManager.RegionsStateStore_.
> The current patch reloads meta on _MasterRpcServices.assigns_ if the given
> region is not found on the first lookup, then try a new lookup again before
> giving-up on region assignment.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase
[
https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899295#comment-16899295
]
Hudson commented on HBASE-22514:
Results for branch HBASE-22514
[build #42 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/42/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/42//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/42//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/42//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Move rsgroup feature into core of HBase
> ---
>
> Key: HBASE-22514
> URL: https://issues.apache.org/jira/browse/HBASE-22514
> Project: HBase
> Issue Type: Umbrella
> Components: Admin, Client, rsgroup
>Reporter: Yechao Chen
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22514.master.001.patch,
> image-2019-05-31-18-25-38-217.png
>
>
> The class RSGroupAdminClient is not public
> we need to use java api RSGroupAdminClient to manager RSG
> so RSGroupAdminClient should be public
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Resolved] (HBASE-22695) Store the rsgroup of a table in table configuration
[ https://issues.apache.org/jira/browse/HBASE-22695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-22695. --- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: HBASE-22514 Pushed to branch HBASE-22514. Thanks [~zghaobac] for reviewing. > Store the rsgroup of a table in table configuration > --- > > Key: HBASE-22695 > URL: https://issues.apache.org/jira/browse/HBASE-22695 > Project: HBase > Issue Type: Sub-task > Components: rsgroup >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: HBASE-22514 > > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache9 merged pull request #426: HBASE-22695 Store the rsgroup of a table in table configuration
Apache9 merged pull request #426: HBASE-22695 Store the rsgroup of a table in table configuration URL: https://github.com/apache/hbase/pull/426 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #436: HBASE-22699 refactor isMetaClearingException
Apache9 commented on a change in pull request #436: HBASE-22699 refactor
isMetaClearingException
URL: https://github.com/apache/hbase/pull/436#discussion_r310327168
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/ClientExceptionsUtil.java
##
@@ -81,13 +77,13 @@ public static boolean isSpecialException(Throwable cur) {
*RpcThrottlingException
* @return null if we didn't find the exception, the exception otherwise.
*/
- public static Throwable findException(Object exception) {
+ public static Throwable unwrapRemoteException(Object exception) {
Review comment:
I think the old name is better? As the RemoteException has an
unwarpRemoteException method, but here we are doing more.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #436: HBASE-22699 refactor isMetaClearingException
Apache9 commented on a change in pull request #436: HBASE-22699 refactor
isMetaClearingException
URL: https://github.com/apache/hbase/pull/436#discussion_r310327049
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/ClientExceptionsUtil.java
##
@@ -53,25 +52,22 @@
private ClientExceptionsUtil() {}
- public static boolean isMetaClearingException(Throwable cur) {
-cur = findException(cur);
+ public static boolean isMetaClearingException(Throwable t) {
+t = unwrapRemoteException(t);
-if (cur == null) {
+if (t == null) {
return true;
}
-return !isSpecialException(cur) || (cur instanceof RegionMovedException)
-|| cur instanceof NotServingRegionException;
+return !regionDefinitelyOnTheRegionServerException(t);
}
- public static boolean isSpecialException(Throwable cur) {
Review comment:
I think this method is used elsewhere? Not only for clearing meta. Is it
safe to change the implementation?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-22709) Add a chore thread in master to do hbck checking and display results in 'HBCK Report' page
[
https://issues.apache.org/jira/browse/HBASE-22709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899274#comment-16899274
]
Sakthi commented on HBASE-22709:
{quote}Is there way to stop it?
{quote}
[~zghaobac], Now that there is a way to run the chore using the shell after
HBASE-22737, should we add a way to turn the chore off as indicated by
[~anoop.hbase]? If yes, I can file the Jira & work on it.
> Add a chore thread in master to do hbck checking and display results in 'HBCK
> Report' page
> --
>
> Key: HBASE-22709
> URL: https://issues.apache.org/jira/browse/HBASE-22709
> Project: HBase
> Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: HBASE-22709.master.001.patch
>
>
> See HBASE-21965. There may have two type of failed splited/merged regions.
> One is orphan region on filesystem. Another one is unassigned daughter
> regions or merged regions. Plan to add a seperate hbck.jsp for them. Will add
> more hbck problems to this UI in future.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22779) TestTableShell is broken
[
https://issues.apache.org/jira/browse/HBASE-22779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899264#comment-16899264
]
Hudson commented on HBASE-22779:
Results for branch master
[build #1307 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1307/]: (/)
*{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1307//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1307//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1307//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> TestTableShell is broken
>
>
> Key: HBASE-22779
> URL: https://issues.apache.org/jira/browse/HBASE-22779
> Project: HBase
> Issue Type: Bug
> Components: Client, shell
>Reporter: Duo Zhang
>Assignee: Junhong Xu
>Priority: Major
> Fix For: 3.0.0
>
>
> {noformat}
> Error: test_append_should_work_with_value(Hbase::TableSimpleMethodsTest):
> ArgumentError: wrong number of arguments (3 for 1)
> /home/zhangduo/hbase/code/hbase-shell/src/main/ruby/hbase/table.rb:291:in
> `_append_internal'
> /home/zhangduo/hbase/code/hbase-shell/src/main/ruby/shell/commands/append.rb:45:in
> `append'
> /home/zhangduo/hbase/code/hbase-shell/src/main/ruby/shell/commands.rb:49:in
> `block in command_safe'
> /home/zhangduo/hbase/code/hbase-shell/src/main/ruby/shell/commands.rb:122:in
> `translate_hbase_exceptions'
> /home/zhangduo/hbase/code/hbase-shell/src/main/ruby/shell/commands.rb:49:in
> `command_safe'
> /home/zhangduo/hbase/code/hbase-shell/src/main/ruby/shell.rb:148:in
> `internal_command'
> /home/zhangduo/hbase/code/hbase-shell/src/main/ruby/hbase/table.rb:51:in
> `block in add_command'
> src/test/ruby/hbase/table_test.rb:186:in `block in
> test_append_should_work_with_value'
> 183: end
> 184:
> 185: define_test "append should work with value" do
> => 186: @test_table.append("123", 'x:cnt2', '123')
> 187: assert_equal("123123", @test_table._append_internal("123",
> 'x:cnt2', '123'))
> 188: end
> 189:
> Error:
> test_append_should_work_without_qualifier(Hbase::TableSimpleMethodsTest):
> ArgumentError: wrong number of arguments (3 for 1)
> /home/zhangduo/hbase/code/hbase-shell/src/main/ruby/hbase/table.rb:291:in
> `_append_internal'
> /home/zhangduo/hbase/code/hbase-shell/src/main/ruby/shell/commands/append.rb:45:in
> `append'
> /home/zhangduo/hbase/code/hbase-shell/src/main/ruby/shell/commands.rb:49:in
> `block in command_safe'
> /home/zhangduo/hbase/code/hbase-shell/src/main/ruby/shell/commands.rb:122:in
> `translate_hbase_exceptions'
> /home/zhangduo/hbase/code/hbase-shell/src/main/ruby/shell/commands.rb:49:in
> `command_safe'
> /home/zhangduo/hbase/code/hbase-shell/src/main/ruby/shell.rb:148:in
> `internal_command'
> /home/zhangduo/hbase/code/hbase-shell/src/main/ruby/hbase/table.rb:51:in
> `block in add_command'
> src/test/ruby/hbase/table_test.rb:191:in `block in
> test_append_should_work_without_qualifier'
> 188: end
> 189:
> 190: define_test 'append should work without qualifier' do
> => 191: @test_table.append('1001', 'x', '123')
> 192: assert_equal('123321', @test_table._append_internal('1001',
> 'x', '321'))
> 193: end
> 194:
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22771) [HBCK2] fixMeta method and server-side support
[
https://issues.apache.org/jira/browse/HBASE-22771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899247#comment-16899247
]
HBase QA commented on HBASE-22771:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
13s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
46s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
48s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
6s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 7m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
9s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
16s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 2m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
0s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
26s{color} | {color:red} hbase-server: The patch generated 6 new + 271
unchanged - 0 fixed = 277 total (was 271) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
3s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
16m 59s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
1m 42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 7m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
0s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
40s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
41s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}213m 3s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
1s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}293m 20s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.client.TestAsyncTableGetMultiThreaded |
| | hadoop.hbase.master.TestMetaFixer |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/PreCommit-HBASE-Build/707/artifact/patchprocess/Dockerfile
|
| JIRA Issue |
[jira] [Updated] (HBASE-22728) Upgrade jackson dependencies in branch-1
[ https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22728: - Attachment: dependency_codehaus.out > Upgrade jackson dependencies in branch-1 > > > Key: HBASE-22728 > URL: https://issues.apache.org/jira/browse/HBASE-22728 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.4.10, 1.3.5 >Reporter: Andrew Purtell >Assignee: Viraj Jasani >Priority: Major > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22728.branch-1.01.patch, > HBASE-22728.branch-1.02.patch, HBASE-22728.branch-1.04.patch, > HBASE-22728.branch-1.06.patch, dependency_codehaus.out > > > Avoid Jackson versions and dependencies with known CVEs -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22728) Upgrade jackson dependencies in branch-1
[ https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22728: - Attachment: HBASE-22728.branch-1.06.patch > Upgrade jackson dependencies in branch-1 > > > Key: HBASE-22728 > URL: https://issues.apache.org/jira/browse/HBASE-22728 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.4.10, 1.3.5 >Reporter: Andrew Purtell >Assignee: Viraj Jasani >Priority: Major > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22728.branch-1.01.patch, > HBASE-22728.branch-1.02.patch, HBASE-22728.branch-1.04.patch, > HBASE-22728.branch-1.06.patch > > > Avoid Jackson versions and dependencies with known CVEs -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22728) Upgrade jackson dependencies in branch-1
[ https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22728: - Attachment: (was: HBASE-22728.branch-1.06.patch) > Upgrade jackson dependencies in branch-1 > > > Key: HBASE-22728 > URL: https://issues.apache.org/jira/browse/HBASE-22728 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.4.10, 1.3.5 >Reporter: Andrew Purtell >Assignee: Viraj Jasani >Priority: Major > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22728.branch-1.01.patch, > HBASE-22728.branch-1.02.patch, HBASE-22728.branch-1.04.patch > > > Avoid Jackson versions and dependencies with known CVEs -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22728) Upgrade jackson dependencies in branch-1
[ https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22728: - Attachment: (was: HBASE-22728.branch-1.06.patch) > Upgrade jackson dependencies in branch-1 > > > Key: HBASE-22728 > URL: https://issues.apache.org/jira/browse/HBASE-22728 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.4.10, 1.3.5 >Reporter: Andrew Purtell >Assignee: Viraj Jasani >Priority: Major > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22728.branch-1.01.patch, > HBASE-22728.branch-1.02.patch, HBASE-22728.branch-1.04.patch, > HBASE-22728.branch-1.06.patch > > > Avoid Jackson versions and dependencies with known CVEs -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22728) Upgrade jackson dependencies in branch-1
[ https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22728: - Attachment: (was: dependency_codehaus.out) > Upgrade jackson dependencies in branch-1 > > > Key: HBASE-22728 > URL: https://issues.apache.org/jira/browse/HBASE-22728 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.4.10, 1.3.5 >Reporter: Andrew Purtell >Assignee: Viraj Jasani >Priority: Major > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22728.branch-1.01.patch, > HBASE-22728.branch-1.02.patch, HBASE-22728.branch-1.04.patch, > HBASE-22728.branch-1.06.patch, HBASE-22728.branch-1.06.patch > > > Avoid Jackson versions and dependencies with known CVEs -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22728) Upgrade jackson dependencies in branch-1
[ https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22728: - Attachment: HBASE-22728.branch-1.06.patch > Upgrade jackson dependencies in branch-1 > > > Key: HBASE-22728 > URL: https://issues.apache.org/jira/browse/HBASE-22728 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.4.10, 1.3.5 >Reporter: Andrew Purtell >Assignee: Viraj Jasani >Priority: Major > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22728.branch-1.01.patch, > HBASE-22728.branch-1.02.patch, HBASE-22728.branch-1.04.patch, > HBASE-22728.branch-1.06.patch, HBASE-22728.branch-1.06.patch > > > Avoid Jackson versions and dependencies with known CVEs -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22728) Upgrade jackson dependencies in branch-1
[ https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22728: - Attachment: HBASE-22728.branch-1.06.patch > Upgrade jackson dependencies in branch-1 > > > Key: HBASE-22728 > URL: https://issues.apache.org/jira/browse/HBASE-22728 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.4.10, 1.3.5 >Reporter: Andrew Purtell >Assignee: Viraj Jasani >Priority: Major > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22728.branch-1.01.patch, > HBASE-22728.branch-1.02.patch, HBASE-22728.branch-1.04.patch, > HBASE-22728.branch-1.06.patch, dependency_codehaus.out > > > Avoid Jackson versions and dependencies with known CVEs -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #426: HBASE-22695 Store the rsgroup of a table in table configuration
Apache-HBase commented on issue #426: HBASE-22695 Store the rsgroup of a table in table configuration URL: https://github.com/apache/hbase/pull/426#issuecomment-517828147 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 62 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 10 new or modified test files. | ||| _ HBASE-22514 Compile Tests _ | | 0 | mvndep | 31 | Maven dependency ordering for branch | | -1 | mvninstall | 322 | root in HBASE-22514 failed. | | +1 | compile | 106 | HBASE-22514 passed | | +1 | checkstyle | 139 | HBASE-22514 passed | | +1 | shadedjars | 290 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 82 | HBASE-22514 passed | | 0 | spotbugs | 280 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 398 | HBASE-22514 passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | -1 | mvninstall | 312 | root in the patch failed. | | +1 | compile | 102 | the patch passed | | +1 | javac | 102 | the patch passed | | +1 | checkstyle | 25 | The patch passed checkstyle in hbase-common | | +1 | checkstyle | 31 | The patch passed checkstyle in hbase-client | | +1 | checkstyle | 79 | hbase-server: The patch generated 0 new + 136 unchanged - 15 fixed = 136 total (was 151) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 291 | patch has no errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 314 | The patch causes 10 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 653 | The patch causes 10 errors with Hadoop v2.9.2. | | -1 | hadoopcheck | 995 | The patch causes 10 errors with Hadoop v3.1.2. | | +1 | javadoc | 79 | the patch passed | | +1 | findbugs | 432 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 183 | hbase-common in the patch passed. | | +1 | unit | 111 | hbase-client in the patch passed. | | +1 | unit | 15484 | hbase-server in the patch passed. | | +1 | asflicense | 74 | The patch does not generate ASF License warnings. | | | | 19769 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/15/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/426 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 25f9f8aa79d1 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-426/out/precommit/personality/provided.sh | | git revision | HBASE-22514 / 06c8e4e52c | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/15/artifact/out/branch-mvninstall-root.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/15/artifact/out/patch-mvninstall-root.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/15/artifact/out/patch-javac-2.8.5.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/15/artifact/out/patch-javac-2.9.2.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/15/artifact/out/patch-javac-3.1.2.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/15/testReport/ | | Max. process+thread count | 4682 (vs. ulimit of 1) | | modules | C: hbase-common hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/15/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #445: HBASE-22759. Added remote address to grant/revoke audit log messages
Apache-HBase commented on issue #445: HBASE-22759. Added remote address to grant/revoke audit log messages URL: https://github.com/apache/hbase/pull/445#issuecomment-517825673 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 85 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.1 Compile Tests _ | | +1 | mvninstall | 328 | branch-2.1 passed | | +1 | compile | 62 | branch-2.1 passed | | +1 | checkstyle | 97 | branch-2.1 passed | | +1 | shadedjars | 264 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 37 | branch-2.1 passed | | 0 | spotbugs | 182 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 179 | branch-2.1 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 305 | the patch passed | | +1 | compile | 56 | the patch passed | | +1 | javac | 56 | the patch passed | | -1 | checkstyle | 91 | hbase-server: The patch generated 2 new + 27 unchanged - 0 fixed = 29 total (was 27) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 277 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1365 | Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2. | | +1 | javadoc | 40 | the patch passed | | +1 | findbugs | 176 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 11262 | hbase-server in the patch failed. | | +1 | asflicense | 23 | The patch does not generate ASF License warnings. | | | | 15052 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-445/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/445 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux fd8011b0f7c8 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-445/out/precommit/personality/provided.sh | | git revision | branch-2.1 / e68b16a6c1 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-445/1/artifact/out/diff-checkstyle-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-445/1/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-445/1/testReport/ | | Max. process+thread count | 4583 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-445/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] apurtell edited a comment on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend
apurtell edited a comment on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend URL: https://github.com/apache/hbase/pull/390#issuecomment-517818517 > I have not yet incorporated @apurtell 's suggestion to add WALEdit to the coprocessor hook, because of the InterfaceAudience.Private notations on WALEdit.add Change the annotation. Raise it here and on the JIRA for feedback. If someone does object, then the path forward is clear. > I personally don't see an issue with adding WALEdit to the coproc (if it's OK to write a coproc that adds a column to every Put, why not a coproc that adds a Cell to every WALEdit?), but it's not necessary for my purposes, and I don't want to add it in just to find out that I need to take it out after all. I do not want to be in the position in the future, now that we are going to the trouble of adding a hook, to find out that it is not suitable for someone else only because we didn't have the foresight to add WALedit to the method signature. It is impossible to know of course all possible potential future use cases but this one seems somewhat obvious by omission. @gjacoby126 @anoopsjohn This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] apurtell edited a comment on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend
apurtell edited a comment on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend URL: https://github.com/apache/hbase/pull/390#issuecomment-517818517 > I have not yet incorporated @apurtell 's suggestion to add WALEdit to the coprocessor hook, because of the InterfaceAudience.Private notations on WALEdit.add Change the annotation. Raise it here and on the JIRA for feedback. If someone does object, then the path forward is clear. > I personally don't see an issue with adding WALEdit to the coproc (if it's OK to write a coproc that adds a column to every Put, why not a coproc that adds a Cell to every WALEdit?), but it's not necessary for my purposes, and I don't want to add it in just to find out that I need to take it out after all. I do not want to be in the position in the future, now that we are going to the trouble of adding a hook, to find out that it is not suitable for someone else only because we didn't have the foresight to add WALedit to the method signature. It is impossible to know of course all possible potential future use cases but this one seems somewhat obvious by omission. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] apurtell commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend
apurtell commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend URL: https://github.com/apache/hbase/pull/390#issuecomment-517818517 > I have not yet incorporated @apurtell 's suggestion to add WALEdit to the coprocessor hook, because of the InterfaceAudience.Private notations on WALEdit.add Change the annotation. Raise it here and on the JIRA for feedback. > I personally don't see an issue with adding WALEdit to the coproc (if it's OK to write a coproc that adds a column to every Put, why not a coproc that adds a Cell to every WALEdit?), but it's not necessary for my purposes, and I don't want to add it in just to find out that I need to take it out after all. I do not want to be in the position in the future, now that we are going to the trouble of adding a hook, to find out that it is not suitable for someone else only because we didn't have the foresight to add WALedit to the method signature. It is impossible to know of course all possible potential future use cases but this one seems somewhat obvious by omission. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22724) Add a emoji on the vote table for pre commit result on github
[
https://issues.apache.org/jira/browse/HBASE-22724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899154#comment-16899154
]
Hudson commented on HBASE-22724:
Results for branch HBASE-22724
[build #1 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22724/1/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22724/1//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22724/1//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22724/1//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add a emoji on the vote table for pre commit result on github
> -
>
> Key: HBASE-22724
> URL: https://issues.apache.org/jira/browse/HBASE-22724
> Project: HBase
> Issue Type: Improvement
>Reporter: Duo Zhang
>Priority: Major
>
> [~zghaobac] said that the current vote table on github is not good enough, as
> the colors are almost the same, it is not easy to find out which line is
> broken.
> Since github can not change the color of the text, he suggested that we add a
> column at the left most with some emojis to better notify the developpers.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22784) OldWALs not cleared in a replication slave cluster (cyclic replication bw 2 clusters)
[ https://issues.apache.org/jira/browse/HBASE-22784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899124#comment-16899124 ] Wellington Chevreuil commented on HBASE-22784: -- Thanks for filing this, [~solvannan]. Would you paste some log snippets/dum replication queue/status replication outputs for each of your enumerated assumptions? > OldWALs not cleared in a replication slave cluster (cyclic replication bw 2 > clusters) > - > > Key: HBASE-22784 > URL: https://issues.apache.org/jira/browse/HBASE-22784 > Project: HBase > Issue Type: Bug > Components: regionserver, Replication >Affects Versions: 1.4.9, 1.4.10 >Reporter: Solvannan R M >Priority: Major > > When a cluster is passive (receiving edits only via replication) in a cyclic > replication setup of 2 clusters, OldWALs size keeps on growing. On analysing, > we observed the following behaviour. > # New entry is added to WAL (Edit replicated from other cluster). > # ReplicationSourceWALReaderThread(RSWALRT) reads and applies the configured > filters (due to cyclic replication setup, ClusterMarkingEntryFilter discards > new entry from other cluster). > # Entry is null, RSWALRT neither updates the batch stats > (WALEntryBatch.lastWalPosition) nor puts it in the entryBatchQueue. > # ReplicationSource thread is blocked in entryBachQueue.take(). > # So ReplicationSource#updateLogPosition has never invoked and WAL file is > never cleared from ReplicationQueue. > # Hence LogCleaner on the master, doesn't deletes the oldWAL files from > hadoop. > NOTE: When a new edit is added via hbase-client, ReplicationSource thread > process and clears the oldWAL files from replication queues and hence master > cleans up the WALs > Please provide us a solution > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22728) Upgrade jackson dependencies in branch-1
[
https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899119#comment-16899119
]
HBase QA commented on HBASE-22728:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
22s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
27s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
47s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
31s{color} | {color:green} branch-1 passed {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 0m
11s{color} | {color:red} branch has 10 errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
44s{color} | {color:green} branch-1 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
11s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 4m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
26s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 0m
10s{color} | {color:red} patch has 10 errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
3m 38s{color} | {color:green} Patch does not cause any errors with Hadoop 2.8.5
2.9.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
44s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
4s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
51s{color} | {color:green} hbase-procedure in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
16s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
25s{color} | {color:green} hbase-hadoop2-compat in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
24s{color} | {color:green} hbase-prefix-tree in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}133m 9s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
21s{color} | {color:green} hbase-testing-util in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 57s{color}
| {color:red} hbase-thrift in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 18m
9s{color} | {color:green} hbase-rest in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 1m 18s{color}
| {color:red} hbase-rsgroup in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 10m
58s{color} | {color:green} hbase-shell in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
29s{color} | {color:green} hbase-it in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} |
[jira] [Updated] (HBASE-22771) [HBCK2] fixMeta method and server-side support
[ https://issues.apache.org/jira/browse/HBASE-22771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22771: -- Assignee: stack Status: Patch Available (was: Open) > [HBCK2] fixMeta method and server-side support > -- > > Key: HBASE-22771 > URL: https://issues.apache.org/jira/browse/HBASE-22771 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Assignee: stack >Priority: Major > Attachments: HBASE-22771.master.001.patch, > HBASE-22771.master.002.patch, HBASE-22771.master.003.patch > > > Add a fixMeta method to hbck Service. > HBCK2 tool in hbase-operator-tools will use this if it is available otherwise > it will do its own client-side version. Making these server-side versions so > can copy/exploit code/findings doing hbase-operator-tools HBCK2 tool version. > This does pure meta fixup plug holes and fix overlaps. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22771) [HBCK2] fixMeta method and server-side support
[ https://issues.apache.org/jira/browse/HBASE-22771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22771: -- Component/s: hbck2 > [HBCK2] fixMeta method and server-side support > -- > > Key: HBASE-22771 > URL: https://issues.apache.org/jira/browse/HBASE-22771 > Project: HBase > Issue Type: Sub-task > Components: hbck2 >Reporter: stack >Assignee: stack >Priority: Major > Attachments: HBASE-22771.master.001.patch, > HBASE-22771.master.002.patch, HBASE-22771.master.003.patch > > > Add a fixMeta method to hbck Service. > HBCK2 tool in hbase-operator-tools will use this if it is available otherwise > it will do its own client-side version. Making these server-side versions so > can copy/exploit code/findings doing hbase-operator-tools HBCK2 tool version. > This does pure meta fixup plug holes and fix overlaps. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22771) [HBCK2] fixMeta method and server-side support
[ https://issues.apache.org/jira/browse/HBASE-22771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-22771: -- Attachment: HBASE-22771.master.003.patch > [HBCK2] fixMeta method and server-side support > -- > > Key: HBASE-22771 > URL: https://issues.apache.org/jira/browse/HBASE-22771 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Priority: Major > Attachments: HBASE-22771.master.001.patch, > HBASE-22771.master.002.patch, HBASE-22771.master.003.patch > > > Add a fixMeta method to hbck Service. > HBCK2 tool in hbase-operator-tools will use this if it is available otherwise > it will do its own client-side version. Making these server-side versions so > can copy/exploit code/findings doing hbase-operator-tools HBCK2 tool version. > This does pure meta fixup plug holes and fix overlaps. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22771) [HBCK2] fixMeta method and server-side support
[ https://issues.apache.org/jira/browse/HBASE-22771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899055#comment-16899055 ] stack commented on HBASE-22771: --- .003 incorporates latest helpful feedback from [~openinx] up on rb. > [HBCK2] fixMeta method and server-side support > -- > > Key: HBASE-22771 > URL: https://issues.apache.org/jira/browse/HBASE-22771 > Project: HBase > Issue Type: Sub-task >Reporter: stack >Priority: Major > Attachments: HBASE-22771.master.001.patch, > HBASE-22771.master.002.patch, HBASE-22771.master.003.patch > > > Add a fixMeta method to hbck Service. > HBCK2 tool in hbase-operator-tools will use this if it is available otherwise > it will do its own client-side version. Making these server-side versions so > can copy/exploit code/findings doing hbase-operator-tools HBCK2 tool version. > This does pure meta fixup plug holes and fix overlaps. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien…
Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien… URL: https://github.com/apache/hbase/pull/361#issuecomment-51403 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 87 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 47 | Maven dependency ordering for branch | | +1 | mvninstall | 378 | master passed | | +1 | compile | 81 | master passed | | +1 | checkstyle | 108 | master passed | | +1 | shadedjars | 291 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 62 | master passed | | 0 | spotbugs | 244 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 327 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for patch | | +1 | mvninstall | 328 | the patch passed | | +1 | compile | 80 | the patch passed | | +1 | javac | 80 | the patch passed | | +1 | checkstyle | 102 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 290 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 955 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 54 | the patch passed | | +1 | findbugs | 326 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 102 | hbase-client in the patch passed. | | -1 | unit | 18341 | hbase-server in the patch failed. | | +1 | asflicense | 65 | The patch does not generate ASF License warnings. | | | | 22419 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory | | | hadoop.hbase.replication.TestReplicationSmallTests | | | hadoop.hbase.master.procedure.TestRestoreSnapshotProcedure | | | hadoop.hbase.client.TestAsyncTableAdminApi | | | hadoop.hbase.client.TestCloneSnapshotFromClientNormal | | | hadoop.hbase.master.procedure.TestProcedurePriority | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/58/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/361 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 200b7b55dbbc 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh | | git revision | master / a6f065396a | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/58/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/58/testReport/ | | Max. process+thread count | 4902 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/58/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #438: HBASE-11062 hbtop
Apache-HBase commented on issue #438: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/438#issuecomment-517775917 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 215 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | 0 | shelldocs | 1 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 19 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 35 | Maven dependency ordering for branch | | +1 | mvninstall | 278 | master passed | | +1 | compile | 165 | master passed | | +1 | checkstyle | 134 | master passed | | +1 | shadedjars | 258 | branch has no errors when building our shaded downstream artifacts. | | -1 | javadoc | 130 | root in master failed. | | 0 | spotbugs | 838 | Used deprecated FindBugs config; considering switching to SpotBugs. | | 0 | findbugs | 24 | branch/hbase-assembly no findbugs output file (findbugsXml.xml) | ||| _ Patch Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for patch | | +1 | mvninstall | 284 | the patch passed | | -1 | compile | 153 | root in the patch failed. | | -1 | javac | 153 | root in the patch failed. | | +1 | checkstyle | 138 | the patch passed | | +1 | shellcheck | 2 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 4 | The patch has no ill-formed XML file. | | +1 | shadedjars | 255 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 885 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 187 | the patch passed | | -1 | findbugs | 834 | root in the patch failed. | | 0 | findbugs | 29 | hbase-assembly has no data from findbugs | ||| _ Other Tests _ | | -1 | unit | 16776 | root in the patch failed. | | -1 | asflicense | 90 | The patch generated 2 ASF License warnings. | | | | 22167 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestAdmin1 | | | hadoop.hbase.master.TestMasterOperationsForRegionReplicas | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/438 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit shadedjars hadoopcheck xml compile spotbugs findbugs hbaseanti checkstyle | | uname | Linux 9b355c5e2f45 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-438/out/precommit/personality/provided.sh | | git revision | master / a6f065396a | | Default Java | 1.8.0_181 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/3/artifact/out/branch-javadoc-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/3/artifact/out/patch-compile-root.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/3/artifact/out/patch-compile-root.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/3/artifact/out/patch-findbugs-root.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/3/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/3/testReport/ | | asflicense | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/3/artifact/out/patch-asflicense-problems.txt | | Max. process+thread count | 5126 (vs. ulimit of 1) | | modules | C: hbase-hbtop . hbase-assembly U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-438/3/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #440: HBASE-22776 Rename config names in user scan snapshot feature
Apache-HBase commented on issue #440: HBASE-22776 Rename config names in user scan snapshot feature URL: https://github.com/apache/hbase/pull/440#issuecomment-517772358 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 91 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 400 | master passed | | +1 | compile | 70 | master passed | | +1 | checkstyle | 95 | master passed | | +1 | shadedjars | 353 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 43 | master passed | | 0 | spotbugs | 290 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 287 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 374 | the patch passed | | +1 | compile | 68 | the patch passed | | +1 | javac | 68 | the patch passed | | -1 | checkstyle | 100 | hbase-server: The patch generated 1 new + 15 unchanged - 0 fixed = 16 total (was 15) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 359 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1252 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 41 | the patch passed | | +1 | findbugs | 312 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 17086 | hbase-server in the patch failed. | | +1 | asflicense | 40 | The patch does not generate ASF License warnings. | | | | 21523 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestAsyncTableAdminApi | | | hadoop.hbase.client.TestCloneSnapshotFromClientNormal | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-440/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/440 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 3e2f659ba18e 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-440/out/precommit/personality/provided.sh | | git revision | master / a6f065396a | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-440/2/artifact/out/diff-checkstyle-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-440/2/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-440/2/testReport/ | | Max. process+thread count | 4660 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-440/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend
Apache-HBase commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend URL: https://github.com/apache/hbase/pull/390#issuecomment-517772346 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 116 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 3 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 594 | master passed | | +1 | compile | 71 | master passed | | +1 | checkstyle | 104 | master passed | | +1 | shadedjars | 382 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 48 | master passed | | 0 | spotbugs | 326 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 323 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 402 | the patch passed | | +1 | compile | 70 | the patch passed | | +1 | javac | 70 | the patch passed | | +1 | checkstyle | 105 | hbase-server: The patch generated 0 new + 375 unchanged - 1 fixed = 375 total (was 376) | | +1 | whitespace | 1 | The patch has no whitespace issues. | | +1 | shadedjars | 360 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1237 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 41 | the patch passed | | +1 | findbugs | 309 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 16824 | hbase-server in the patch failed. | | +1 | asflicense | 30 | The patch does not generate ASF License warnings. | | | | 21504 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestCloneSnapshotFromClientNormal | | | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/26/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/390 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 673c85ffac50 4.4.0-143-generic #169-Ubuntu SMP Thu Feb 7 07:56:38 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-390/out/precommit/personality/provided.sh | | git revision | master / a6f065396a | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/26/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/26/testReport/ | | Max. process+thread count | 4611 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-390/26/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve…
Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve… URL: https://github.com/apache/hbase/pull/435#issuecomment-517768789 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 84 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | 0 | shelldocs | 0 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 28 | Maven dependency ordering for branch | | +1 | mvninstall | 326 | master passed | | +1 | compile | 98 | master passed | | +1 | checkstyle | 112 | master passed | | +1 | shadedjars | 263 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 90 | master passed | | 0 | spotbugs | 53 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 375 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for patch | | +1 | mvninstall | 364 | the patch passed | | +1 | compile | 106 | the patch passed | | +1 | javac | 106 | the patch passed | | -1 | checkstyle | 73 | hbase-server: The patch generated 1 new + 9 unchanged - 0 fixed = 10 total (was 9) | | +1 | shellcheck | 1 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 268 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1038 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 81 | the patch passed | | -1 | findbugs | 61 | hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 | unit | 184 | hbase-common in the patch passed. | | -1 | unit | 15984 | hbase-server in the patch failed. | | +1 | unit | 447 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 78 | The patch does not generate ASF License warnings. | | | | 20846 | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-common | | | org.apache.hadoop.hbase.Version.() invokes inefficient new String(String) constructor At Version.java:inefficient new String(String) constructor At Version.java:[line 10] | | Failed junit tests | hadoop.hbase.master.TestMasterShutdown | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/435 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 741f8fd0bd99 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-435/out/precommit/personality/provided.sh | | git revision | master / a6f065396a | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/4/artifact/out/diff-checkstyle-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/4/artifact/out/new-findbugs-hbase-common.html | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/4/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/4/testReport/ | | Max. process+thread count | 5075 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server hbase-rsgroup U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/4/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #437: HBASE-22539 WAL corruption due to early DBBs re-use when Durability.A…
Apache-HBase commented on issue #437: HBASE-22539 WAL corruption due to early DBBs re-use when Durability.A… URL: https://github.com/apache/hbase/pull/437#issuecomment-517764853 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 65 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 6 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 410 | master passed | | +1 | compile | 89 | master passed | | +1 | checkstyle | 80 | master passed | | +1 | shadedjars | 285 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 33 | master passed | | 0 | spotbugs | 274 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 262 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 392 | the patch passed | | +1 | compile | 109 | the patch passed | | +1 | javac | 109 | the patch passed | | +1 | checkstyle | 125 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 284 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 985 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 33 | the patch passed | | +1 | findbugs | 371 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 16160 | hbase-server in the patch failed. | | +1 | asflicense | 24 | The patch does not generate ASF License warnings. | | | | 20107 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-437/6/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/437 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 509cff76c25c 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-437/out/precommit/personality/provided.sh | | git revision | master / a6f065396a | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-437/6/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-437/6/testReport/ | | Max. process+thread count | 4665 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-437/6/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #428: HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke (master)
Apache-HBase commented on issue #428: HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke (master) URL: https://github.com/apache/hbase/pull/428#issuecomment-517762167 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 213 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 413 | master passed | | +1 | compile | 52 | master passed | | +1 | checkstyle | 75 | master passed | | +1 | shadedjars | 265 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 36 | master passed | | 0 | spotbugs | 248 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 245 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 284 | the patch passed | | +1 | compile | 51 | the patch passed | | +1 | javac | 51 | the patch passed | | +1 | checkstyle | 71 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 263 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 897 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 31 | the patch passed | | +1 | findbugs | 258 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 16059 | hbase-server in the patch failed. | | +1 | asflicense | 40 | The patch does not generate ASF License warnings. | | | | 19615 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/20/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/428 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux cc7711733bbe 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh | | git revision | master / a6f065396a | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/20/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/20/testReport/ | | Max. process+thread count | 4637 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/20/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-22784) OldWALs not cleared in a replication slave cluster (cyclic replication bw 2 clusters)
Solvannan R M created HBASE-22784: - Summary: OldWALs not cleared in a replication slave cluster (cyclic replication bw 2 clusters) Key: HBASE-22784 URL: https://issues.apache.org/jira/browse/HBASE-22784 Project: HBase Issue Type: Bug Components: regionserver, Replication Affects Versions: 1.4.10, 1.4.9 Reporter: Solvannan R M When a cluster is passive (receiving edits only via replication) in a cyclic replication setup of 2 clusters, OldWALs size keeps on growing. On analysing, we observed the following behaviour. # New entry is added to WAL (Edit replicated from other cluster). # ReplicationSourceWALReaderThread(RSWALRT) reads and applies the configured filters (due to cyclic replication setup, ClusterMarkingEntryFilter discards new entry from other cluster). # Entry is null, RSWALRT neither updates the batch stats (WALEntryBatch.lastWalPosition) nor puts it in the entryBatchQueue. # ReplicationSource thread is blocked in entryBachQueue.take(). # So ReplicationSource#updateLogPosition has never invoked and WAL file is never cleared from ReplicationQueue. # Hence LogCleaner on the master, doesn't deletes the oldWAL files from hadoop. NOTE: When a new edit is added via hbase-client, ReplicationSource thread process and clears the oldWAL files from replication queues and hence master cleans up the WALs Please provide us a solution -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] gjacoby126 commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend
gjacoby126 commented on issue #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend URL: https://github.com/apache/hbase/pull/390#issuecomment-517757619 @apurtell @anoopsjohn - The currently posted version of this PR incorporates @anoopsjohn 's feedback for adding an addExtendedAttributes method to WALKey rather than allowing the coprocessor to create and return a new WALKeyImpl. The last run of Yetus should have been a +1, because the only thing that failed was a timeout tearing down a test. I have not yet incorporated @apurtell 's suggestion to add WALEdit to the coprocessor hook, because of the InterfaceAudience.Private notations on WALEdit.add and the seemingly deliberate decision to exclude WALEdit from any coprocessor that could alter it before committing to the WAL. I personally don't see an issue with adding WALEdit to the coproc (if it's OK to write a coproc that adds a column to every Put, why not a coproc that adds a Cell to every WALEdit?), but it's not necessary for my purposes, and I don't want to add it in just to find out that I need to take it out after all. I assume either the restriction's there for a reason I don't understand, or I misunderstand the restriction. Please advise, and thanks for the feedback. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22618) Provide a way to have Heterogeneous deployment
[
https://issues.apache.org/jira/browse/HBASE-22618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16898994#comment-16898994
]
Wellington Chevreuil commented on HBASE-22618:
--
Thanks [~PierreZ], had made some comments on the PR.
> Provide a way to have Heterogeneous deployment
> --
>
> Key: HBASE-22618
> URL: https://issues.apache.org/jira/browse/HBASE-22618
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 2.1.6, 1.4.11
>Reporter: Pierre Zemb
>Priority: Major
>
> Hi,
> We wouls like to open the discussion about bringing the possibility to have
> regions deployed on {color:#22}Heterogeneous deployment{color}, i.e Hbase
> cluster running different kind of hardware.
> h2. Why?
> * Cloud deployments means that we may not be able to have the same hardware
> throughout the years
> * Some tables may need special requirements such as SSD whereas others
> should be using hard-drives
> * {color:#22} {color}*in our usecase*{color:#22}(single table,
> dedicated HBase and Hadoop tuned for our usecase, good key
> distribution){color}*, the number of regions per RS was the real limit for
> us*{color:#22}.{color}
> h2. Our usecase
> We found out that *in our usecase*(single table, dedicated HBase and Hadoop
> tuned for our usecase, good key distribution)*, the number of regions per RS
> was the real limit for us*.
> Over the years, due to historical reasons and also the need to benchmark new
> machines, we ended-up with differents groups of hardware: some servers can
> handle only 180 regions, whereas the biggest can handle more than 900.
> Because of such a difference, we had to disable the LoadBalancing to avoid
> the {{roundRobinAssigmnent}}. We developed some internal tooling which are
> responsible for load balancing regions across RegionServers. That was 1.5
> year ago.
> h2. Our Proof-of-concept
> We did work on a Proof-of-concept
> [here|https://github.com/PierreZ/hbase/blob/dev/hbase14/balancer/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/HeterogeneousBalancer.java],
> and some early tests
> [here|https://github.com/PierreZ/hbase/blob/dev/hbase14/balancer/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/HeterogeneousBalancer.java],
>
> [here|https://github.com/PierreZ/hbase/blob/dev/hbase14/balancer/hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestHeterogeneousBalancerBalance.java],
> and
> [here|https://github.com/PierreZ/hbase/blob/dev/hbase14/balancer/hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestHeterogeneousBalancerRules.java].
> We wrote the balancer for our use-case, which means that:
> * there is one table
> * there is no region-replica
> * good key dispersion
> * there is no regions on master
> A rule file is loaded before balancing. It contains lines of rules. A rule is
> composed of a regexp for hostname, and a limit. For example, we could have:
>
> {quote}rs[0-9] 200
> rs1[0-9] 50
> {quote}
>
> RegionServers with hostname matching the first rules will have a limit of
> 200, and the others 50. If there's no match, a default is set.
> Thanks to the rule, we have two informations: the max number of regions for
> this cluster, and the rules for each servers. {{HeterogeneousBalancer}} will
> try to balance regions according to their capacity.
> Let's take an example. Let's say that we have 20 RS:
> * 10 RS, named through {{rs0}} to {{rs9}} loaded with 60 regions each, and
> each can handle 200 regions.
> * 10 RS, named through {{rs10}} to {{rs19}} loaded with 60 regions each, and
> each can support 50 regions.
> Based on the following rules:
>
> {quote}rs[0-9] 200
> rs1[0-9] 50
> {quote}
>
> The second group is overloaded, whereas the first group has plenty of space.
> We know that we can handle at maximum *2500 regions* (200*10 + 50*10) and we
> have currently *1200 regions* (60*20). {{HeterogeneousBalancer}} will
> understand that the cluster is *full at 48.0%* (1200/2500). Based on this
> information, we will then *try to put all the RegionServers to ~48% of load
> according to the rules.* In this case, it will move regions from the second
> group to the first.
> The balancer will:
> * compute how many regions needs to be moved. In our example, by moving 36
> regions on rs10, we could go from 120.0% to 46.0%
> * select regions with lowest data-locality
> * try to find an appropriate RS for the region. We will take the lowest
> available RS.
> h2. Other implementations and ideas
> Clay Baenziger proposed this idea on the dev ML:
> {quote}{color:#22}Could it work to have the stochastic load balancer use
> [pluggable cost functions instead of this static list of cost
>
[GitHub] [hbase] wchevreuil commented on issue #439: HBASE-22618 Provide a way to have Heterogeneous deployment
wchevreuil commented on issue #439: HBASE-22618 Provide a way to have Heterogeneous deployment URL: https://github.com/apache/hbase/pull/439#issuecomment-517749588 Thanks for the contribution @PierreZ ! I had made some small nits remarks on the PR. Please address the reported [checkstyle issues](https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/3/artifact/out/diff-checkstyle-hbase-server.txt) added by these changes. Reported UT failures should be unrelated, verified those locally and those passed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22778) Upgrade jasckson databind to 2.9.9.2
[ https://issues.apache.org/jira/browse/HBASE-22778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16898991#comment-16898991 ] Wei-Chiu Chuang commented on HBASE-22778: - How about removing jackson-databind dependency? It looks like it is mostly used in test code. > Upgrade jasckson databind to 2.9.9.2 > > > Key: HBASE-22778 > URL: https://issues.apache.org/jira/browse/HBASE-22778 > Project: HBase > Issue Type: Bug > Components: dependencies >Reporter: Duo Zhang >Priority: Blocker > > Due to this CVE > https://nvd.nist.gov/vuln/detail/CVE-2019-14379 -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] anmolnar opened a new pull request #445: HBASE-22759. Added remote address to grant/revoke audit log messages
anmolnar opened a new pull request #445: HBASE-22759. Added remote address to grant/revoke audit log messages URL: https://github.com/apache/hbase/pull/445 @petersomogyi Sorry, I missed one more thing: added the user's remote address to the message. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] wchevreuil commented on a change in pull request #439: HBASE-22618 Provide a way to have Heterogeneous deployment
wchevreuil commented on a change in pull request #439: HBASE-22618 Provide a
way to have Heterogeneous deployment
URL: https://github.com/apache/hbase/pull/439#discussion_r310176814
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java
##
@@ -457,6 +450,13 @@ public void testLosingRs() throws Exception {
assertNull(plans);
}
Review comment:
How about test that, upon _StochasticLoadBalancer.balanceCluster()_ call,
verify that _DummyCostFunctions.cost()_ get indeed called? That would validate
custom cost functions are indeed used.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Updated] (HBASE-22783) Remove deprecated classes(status and load) usage from hbase-shell
[ https://issues.apache.org/jira/browse/HBASE-22783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22783: - Description: Need to replace deprecated usages of classes: ClusterStatus, RegionLoad, ServerLoad from hbase-shell > Remove deprecated classes(status and load) usage from hbase-shell > - > > Key: HBASE-22783 > URL: https://issues.apache.org/jira/browse/HBASE-22783 > Project: HBase > Issue Type: Sub-task > Components: shell >Affects Versions: 3.0.0 >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > > Need to replace deprecated usages of classes: ClusterStatus, RegionLoad, > ServerLoad from hbase-shell -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22783) Remove deprecated classes(status and load) usage from hbase-shell
[ https://issues.apache.org/jira/browse/HBASE-22783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22783: - Summary: Remove deprecated classes(status and load) usage from hbase-shell (was: Remove deprecated classes usage from hbase-shell) > Remove deprecated classes(status and load) usage from hbase-shell > - > > Key: HBASE-22783 > URL: https://issues.apache.org/jira/browse/HBASE-22783 > Project: HBase > Issue Type: Sub-task > Components: shell >Affects Versions: 3.0.0 >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (HBASE-22783) Remove deprecated classes usage from hbase-shell
Viraj Jasani created HBASE-22783: Summary: Remove deprecated classes usage from hbase-shell Key: HBASE-22783 URL: https://issues.apache.org/jira/browse/HBASE-22783 Project: HBase Issue Type: Sub-task Components: shell Affects Versions: 3.0.0 Reporter: Viraj Jasani Assignee: Viraj Jasani -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22728) Upgrade jackson dependencies in branch-1
[ https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22728: - Attachment: dependency_codehaus.out > Upgrade jackson dependencies in branch-1 > > > Key: HBASE-22728 > URL: https://issues.apache.org/jira/browse/HBASE-22728 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.4.10, 1.3.5 >Reporter: Andrew Purtell >Assignee: Viraj Jasani >Priority: Major > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22728.branch-1.01.patch, > HBASE-22728.branch-1.02.patch, HBASE-22728.branch-1.04.patch, > dependency_codehaus.out > > > Avoid Jackson versions and dependencies with known CVEs -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22728) Upgrade jackson dependencies in branch-1
[ https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16898961#comment-16898961 ] Viraj Jasani commented on HBASE-22728: -- Uploaded new patch and uploading result of dependency tree. For now, to see build results with this patch, I have not updated hbase-rest with Jackson2 safer versions. If the build goes all good and the changes look good to you so far, may be I can do some backport from master/branch-2 and introduce fasterxml.jackson for branch-1 only for rest module? > Upgrade jackson dependencies in branch-1 > > > Key: HBASE-22728 > URL: https://issues.apache.org/jira/browse/HBASE-22728 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.4.10, 1.3.5 >Reporter: Andrew Purtell >Assignee: Viraj Jasani >Priority: Major > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22728.branch-1.01.patch, > HBASE-22728.branch-1.02.patch, HBASE-22728.branch-1.04.patch > > > Avoid Jackson versions and dependencies with known CVEs -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-21879) Read HFile's block to ByteBuffer directly instead of to byte for reducing young gc purpose
[
https://issues.apache.org/jira/browse/HBASE-21879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16898960#comment-16898960
]
Hudson commented on HBASE-21879:
Results for branch HBASE-21879
[build #196 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/196/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/196//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/196//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/196//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Read HFile's block to ByteBuffer directly instead of to byte for reducing
> young gc purpose
> --
>
> Key: HBASE-21879
> URL: https://issues.apache.org/jira/browse/HBASE-21879
> Project: HBase
> Issue Type: Improvement
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments: HBASE-21879.v1.patch, HBASE-21879.v1.patch,
> QPS-latencies-before-HBASE-21879.png, gc-data-before-HBASE-21879.png
>
>
> In HFileBlock#readBlockDataInternal, we have the following:
> {code}
> @VisibleForTesting
> protected HFileBlock readBlockDataInternal(FSDataInputStream is, long offset,
> long onDiskSizeWithHeaderL, boolean pread, boolean verifyChecksum,
> boolean updateMetrics)
> throws IOException {
> // .
> // TODO: Make this ByteBuffer-based. Will make it easier to go to HDFS with
> BBPool (offheap).
> byte [] onDiskBlock = new byte[onDiskSizeWithHeader + hdrSize];
> int nextBlockOnDiskSize = readAtOffset(is, onDiskBlock, preReadHeaderSize,
> onDiskSizeWithHeader - preReadHeaderSize, true, offset +
> preReadHeaderSize, pread);
> if (headerBuf != null) {
> // ...
> }
> // ...
> }
> {code}
> In the read path, we still read the block from hfile to on-heap byte[], then
> copy the on-heap byte[] to offheap bucket cache asynchronously, and in my
> 100% get performance test, I also observed some frequent young gc, The
> largest memory footprint in the young gen should be the on-heap block byte[].
> In fact, we can read HFile's block to ByteBuffer directly instead of to
> byte[] for reducing young gc purpose. we did not implement this before,
> because no ByteBuffer reading interface in the older HDFS client, but 2.7+
> has supported this now, so we can fix this now. I think.
> Will provide an patch and some perf-comparison for this.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-22782) Add String constructors for Get client
[ https://issues.apache.org/jira/browse/HBASE-22782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Murtaza Hassan updated HBASE-22782: --- Description: As we cannot directly pass a String using Get constructors it is better to have new String constructors so that we can pass a String directly and don't need to convert Strings into Bytes. It will also help everyone who is using the Get client as now they dont need to worry about writing the conversion themselves as it will be taken care by the String constructor. Add String constructors for Get client. Also write the necessary tests and change the code where required in TestGet.java class. was: As we cannot directly pass a String using Get constructors it is better to have new String constructors so that we can pass a String directly and don't need to convert Strings into Bytes. It will also help everyone who is using the Get client as now that they dont need to worry about writing the conversiuon themselves as it will be taken care by the String constructor. Add String constructors for Get client. Also write the necessary tests and change the code where required in TestGet.java class. > Add String constructors for Get client > -- > > Key: HBASE-22782 > URL: https://issues.apache.org/jira/browse/HBASE-22782 > Project: HBase > Issue Type: New Feature >Affects Versions: 3.0.0 >Reporter: Murtaza Hassan >Assignee: Murtaza Hassan >Priority: Trivial > > As we cannot directly pass a String using Get constructors it is better to > have new String constructors so that we can pass a String directly and don't > need to convert Strings into Bytes. It will also help everyone who is using > the Get client as now they dont need to worry about writing the conversion > themselves as it will be taken care by the String constructor. > > Add String constructors for Get client. Also write the necessary tests and > change the code where required in TestGet.java class. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22782) Add String constructors for Get client
[ https://issues.apache.org/jira/browse/HBASE-22782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Murtaza Hassan updated HBASE-22782: --- Description: As we cannot directly pass a String using Get constructors it is better to have new String constructors so that we can pass a String directly and don't need to convert Strings into Bytes. It will also help everyone who is using the Get client as now that they dont need to worry about writing the conversiuon themselves as it will be taken care by the String constructor. Add String constructors for Get client. Also write the necessary tests and change the code where required in TestGet.java class. was:Add String constructors for Get client. Also write the necessary tests and change the code where required in TestGet.java class. > Add String constructors for Get client > -- > > Key: HBASE-22782 > URL: https://issues.apache.org/jira/browse/HBASE-22782 > Project: HBase > Issue Type: New Feature >Affects Versions: 3.0.0 >Reporter: Murtaza Hassan >Assignee: Murtaza Hassan >Priority: Trivial > > As we cannot directly pass a String using Get constructors it is better to > have new String constructors so that we can pass a String directly and don't > need to convert Strings into Bytes. It will also help everyone who is using > the Get client as now that they dont need to worry about writing the > conversiuon themselves as it will be taken care by the String constructor. > Add String constructors for Get client. Also write the necessary tests and > change the code where required in TestGet.java class. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22728) Upgrade jackson dependencies in branch-1
[ https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22728: - Attachment: HBASE-22728.branch-1.04.patch > Upgrade jackson dependencies in branch-1 > > > Key: HBASE-22728 > URL: https://issues.apache.org/jira/browse/HBASE-22728 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.4.10, 1.3.5 >Reporter: Andrew Purtell >Assignee: Viraj Jasani >Priority: Major > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22728.branch-1.01.patch, > HBASE-22728.branch-1.02.patch, HBASE-22728.branch-1.04.patch, > dependency_codehaus.out > > > Avoid Jackson versions and dependencies with known CVEs -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22728) Upgrade jackson dependencies in branch-1
[ https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22728: - Attachment: (was: dependency_codehaus.out) > Upgrade jackson dependencies in branch-1 > > > Key: HBASE-22728 > URL: https://issues.apache.org/jira/browse/HBASE-22728 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.4.10, 1.3.5 >Reporter: Andrew Purtell >Assignee: Viraj Jasani >Priority: Major > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22728.branch-1.01.patch, > HBASE-22728.branch-1.02.patch, HBASE-22728.branch-1.04.patch > > > Avoid Jackson versions and dependencies with known CVEs -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22782) Add String constructors for Get client
[ https://issues.apache.org/jira/browse/HBASE-22782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Murtaza Hassan updated HBASE-22782: --- Affects Version/s: 3.0.0 > Add String constructors for Get client > -- > > Key: HBASE-22782 > URL: https://issues.apache.org/jira/browse/HBASE-22782 > Project: HBase > Issue Type: New Feature >Affects Versions: 3.0.0 >Reporter: Murtaza Hassan >Assignee: Murtaza Hassan >Priority: Trivial > > Add String constructors for Get client. Also write the necessary tests in > TestGet.java class. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22782) Add String constructors for Get client
[ https://issues.apache.org/jira/browse/HBASE-22782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Murtaza Hassan updated HBASE-22782: --- Description: Add String constructors for Get client. Also write the necessary tests and change the code where required in TestGet.java class. (was: Add String constructors for Get client. Also write the necessary tests in TestGet.java class. ) > Add String constructors for Get client > -- > > Key: HBASE-22782 > URL: https://issues.apache.org/jira/browse/HBASE-22782 > Project: HBase > Issue Type: New Feature >Affects Versions: 3.0.0 >Reporter: Murtaza Hassan >Assignee: Murtaza Hassan >Priority: Trivial > > Add String constructors for Get client. Also write the necessary tests and > change the code where required in TestGet.java class. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (HBASE-22782) Add String constructors for Get client
Murtaza Hassan created HBASE-22782: -- Summary: Add String constructors for Get client Key: HBASE-22782 URL: https://issues.apache.org/jira/browse/HBASE-22782 Project: HBase Issue Type: New Feature Reporter: Murtaza Hassan Assignee: Murtaza Hassan Add String constructors for Get client. Also write the necessary tests in TestGet.java class. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22744) Remove deprecated classes around status and load
[
https://issues.apache.org/jira/browse/HBASE-22744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16898923#comment-16898923
]
Jan Hentschel commented on HBASE-22744:
---
SGTM
> Remove deprecated classes around status and load
>
>
> Key: HBASE-22744
> URL: https://issues.apache.org/jira/browse/HBASE-22744
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Major
> Fix For: 3.0.0
>
>
> The client module has three deprecated classes around metrics,
> {{ClusterStatus}}, {{RegionLoad}} and {{ServerLoad}}, which should be removed.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22744) Remove deprecated classes around status and load
[
https://issues.apache.org/jira/browse/HBASE-22744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16898920#comment-16898920
]
Viraj Jasani commented on HBASE-22744:
--
Sure, in that case, let me create a sub-task for shell, and once it is done,
you can merge your original PR.
Thanks
> Remove deprecated classes around status and load
>
>
> Key: HBASE-22744
> URL: https://issues.apache.org/jira/browse/HBASE-22744
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Major
> Fix For: 3.0.0
>
>
> The client module has three deprecated classes around metrics,
> {{ClusterStatus}}, {{RegionLoad}} and {{ServerLoad}}, which should be removed.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-22725) Remove all remaining javadoc warnings
[ https://issues.apache.org/jira/browse/HBASE-22725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Murtaza Hassan updated HBASE-22725: --- Issue Type: Test (was: Bug) > Remove all remaining javadoc warnings > -- > > Key: HBASE-22725 > URL: https://issues.apache.org/jira/browse/HBASE-22725 > Project: HBase > Issue Type: Test >Affects Versions: 3.0.0 >Reporter: Murtaza Hassan >Assignee: Murtaza Hassan >Priority: Trivial > Labels: beginner > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22725) Remove all remaining javadoc warnings
[ https://issues.apache.org/jira/browse/HBASE-22725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Murtaza Hassan updated HBASE-22725: --- Labels: (was: beginner) > Remove all remaining javadoc warnings > -- > > Key: HBASE-22725 > URL: https://issues.apache.org/jira/browse/HBASE-22725 > Project: HBase > Issue Type: Test >Affects Versions: 3.0.0 >Reporter: Murtaza Hassan >Assignee: Murtaza Hassan >Priority: Trivial > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (HBASE-22725) Remove all remaining javadoc warnings
[ https://issues.apache.org/jira/browse/HBASE-22725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Murtaza Hassan updated HBASE-22725: --- Component/s: test > Remove all remaining javadoc warnings > -- > > Key: HBASE-22725 > URL: https://issues.apache.org/jira/browse/HBASE-22725 > Project: HBase > Issue Type: Test > Components: test >Affects Versions: 3.0.0 >Reporter: Murtaza Hassan >Assignee: Murtaza Hassan >Priority: Trivial > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22744) Remove deprecated classes around status and load
[
https://issues.apache.org/jira/browse/HBASE-22744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16898918#comment-16898918
]
Jan Hentschel commented on HBASE-22744:
---
[~vjasani] Yes, sure, go ahead. If you want to separate them, you can create a
sub-task for the shell changes. For the actual removal you can refer to my
linked PR, which had this already.
> Remove deprecated classes around status and load
>
>
> Key: HBASE-22744
> URL: https://issues.apache.org/jira/browse/HBASE-22744
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Major
> Fix For: 3.0.0
>
>
> The client module has three deprecated classes around metrics,
> {{ClusterStatus}}, {{RegionLoad}} and {{ServerLoad}}, which should be removed.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Assigned] (HBASE-22781) Not suitable params of StoreScanner in the test case TestStoreScanner.testScanSameTimestamp
[
https://issues.apache.org/jira/browse/HBASE-22781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zheng Wang reassigned HBASE-22781:
--
Assignee: Zheng Wang
> Not suitable params of StoreScanner in the test case
> TestStoreScanner.testScanSameTimestamp
> ---
>
> Key: HBASE-22781
> URL: https://issues.apache.org/jira/browse/HBASE-22781
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 2.0.0
>Reporter: Zheng Wang
>Assignee: Zheng Wang
>Priority: Minor
>
> {code:java}
> public void testScanSameTimestamp() throws IOException {
> // returns only 1 of these 2 even though same timestamp
> KeyValue [] kvs = new KeyValue[] {
> create("R1", "cf", "a", 1, KeyValue.Type.Put, "dont-care"),
> create("R1", "cf", "a", 1, KeyValue.Type.Put, "dont-care"),
> };
> List scanners = Arrays.asList(
> new KeyValueScanner[] {
> new KeyValueScanFixture(CellComparator.getInstance(), kvs)
> });
> Scan scanSpec = new Scan().withStartRow(Bytes.toBytes("R1"));
> // this only uses maxVersions (default=1) and TimeRange (default=all)
> try (StoreScanner scan = new StoreScanner(scanSpec, scanInfo, getCols("a"),
> scanners)) {
> List results = new ArrayList<>();
> assertEquals(true, scan.next(results));
> assertEquals(1, results.size());
> assertEquals(kvs[0], results.get(0));
> }
> }
> {code}
>
> It will not to compare the timestamp of the two cells,because of the
> 'getCols("a")' limit only one column and one version(default).
> For example,modify the timestamp of the first cell to 2 can also pass.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache9 closed pull request #444: HBASE-22724 Test github post
Apache9 closed pull request #444: HBASE-22724 Test github post URL: https://github.com/apache/hbase/pull/444 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #426: HBASE-22695 Store the rsgroup of a table in table configuration
Apache9 commented on a change in pull request #426: HBASE-22695 Store the
rsgroup of a table in table configuration
URL: https://github.com/apache/hbase/pull/426#discussion_r310130785
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServiceImpl.java
##
@@ -276,14 +321,28 @@ public void balanceRSGroup(RpcController controller,
BalanceRSGroupRequest reque
public void listRSGroupInfos(RpcController controller,
ListRSGroupInfosRequest request,
RpcCallback done) {
ListRSGroupInfosResponse.Builder builder =
ListRSGroupInfosResponse.newBuilder();
-RSGroupAdminEndpoint.LOG.info(master.getClientIdAuditPrefix() + " list
rsgroup");
+LOG.info(master.getClientIdAuditPrefix() + " list rsgroup");
try {
if (master.getMasterCoprocessorHost() != null) {
master.getMasterCoprocessorHost().preListRSGroups();
}
checkPermission("listRSGroup");
- for (RSGroupInfo RSGroupInfo : groupAdminServer.listRSGroups()) {
-builder.addRSGroupInfo(ProtobufUtil.toProtoGroupInfo(RSGroupInfo));
+ List rsGroupInfos = groupAdminServer.listRSGroups().stream()
+ .map(RSGroupInfo::new).collect(Collectors.toList());
+ Map name2Info = new HashMap<>();
+ for (RSGroupInfo rsGroupInfo : rsGroupInfos) {
+name2Info.put(rsGroupInfo.getName(), rsGroupInfo);
+ }
+ for (TableDescriptor td :
master.getTableDescriptors().getAll().values()) {
+String groupName =
td.getRegionServerGroup().orElse(RSGroupInfo.DEFAULT_GROUP);
+RSGroupInfo rsGroupInfo = name2Info.get(groupName);
+if (rsGroupInfo != null) {
+ rsGroupInfo.addTable(td.getTableName());
Review comment:
We need to be compatible with 2.x client I think. And also, we need to
change a lot of tests if we want to change the behavior here. So I suggest that
we do it in 4.0.0.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #426: HBASE-22695 Store the rsgroup of a table in table configuration
Apache9 commented on a change in pull request #426: HBASE-22695 Store the
rsgroup of a table in table configuration
URL: https://github.com/apache/hbase/pull/426#discussion_r310130394
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServiceImpl.java
##
@@ -137,17 +156,24 @@ public void getRSGroupInfoOfTable(RpcController
controller, GetRSGroupInfoOfTabl
RpcCallback done) {
GetRSGroupInfoOfTableResponse.Builder builder =
GetRSGroupInfoOfTableResponse.newBuilder();
TableName tableName = ProtobufUtil.toTableName(request.getTableName());
-RSGroupAdminEndpoint.LOG.info(
+LOG.info(
master.getClientIdAuditPrefix() + " initiates rsgroup info retrieval,
table=" + tableName);
try {
if (master.getMasterCoprocessorHost() != null) {
master.getMasterCoprocessorHost().preGetRSGroupInfoOfTable(tableName);
}
checkPermission("getRSGroupInfoOfTable");
- RSGroupInfo RSGroupInfo =
groupAdminServer.getRSGroupInfoOfTable(tableName);
- if (RSGroupInfo != null) {
-builder.setRSGroupInfo(ProtobufUtil.toProtoGroupInfo(RSGroupInfo));
+ Optional optGroup =
+ RSGroupUtil.getRSGroupInfo(master, groupAdminServer, tableName);
+ if (optGroup.isPresent()) {
+
builder.setRSGroupInfo(ProtobufUtil.toProtoGroupInfo(fillTables(optGroup.get(;
+ } else {
+if (master.getTableStateManager().isTablePresent(tableName)) {
Review comment:
Only if the table is present, we can have a rs group config for the table.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] infraio commented on a change in pull request #426: HBASE-22695 Store the rsgroup of a table in table configuration
infraio commented on a change in pull request #426: HBASE-22695 Store the
rsgroup of a table in table configuration
URL: https://github.com/apache/hbase/pull/426#discussion_r310129943
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServiceImpl.java
##
@@ -276,14 +321,28 @@ public void balanceRSGroup(RpcController controller,
BalanceRSGroupRequest reque
public void listRSGroupInfos(RpcController controller,
ListRSGroupInfosRequest request,
RpcCallback done) {
ListRSGroupInfosResponse.Builder builder =
ListRSGroupInfosResponse.newBuilder();
-RSGroupAdminEndpoint.LOG.info(master.getClientIdAuditPrefix() + " list
rsgroup");
+LOG.info(master.getClientIdAuditPrefix() + " list rsgroup");
try {
if (master.getMasterCoprocessorHost() != null) {
master.getMasterCoprocessorHost().preListRSGroups();
}
checkPermission("listRSGroup");
- for (RSGroupInfo RSGroupInfo : groupAdminServer.listRSGroups()) {
-builder.addRSGroupInfo(ProtobufUtil.toProtoGroupInfo(RSGroupInfo));
+ List rsGroupInfos = groupAdminServer.listRSGroups().stream()
+ .map(RSGroupInfo::new).collect(Collectors.toList());
+ Map name2Info = new HashMap<>();
+ for (RSGroupInfo rsGroupInfo : rsGroupInfos) {
+name2Info.put(rsGroupInfo.getName(), rsGroupInfo);
+ }
+ for (TableDescriptor td :
master.getTableDescriptors().getAll().values()) {
+String groupName =
td.getRegionServerGroup().orElse(RSGroupInfo.DEFAULT_GROUP);
+RSGroupInfo rsGroupInfo = name2Info.get(groupName);
+if (rsGroupInfo != null) {
+ rsGroupInfo.addTable(td.getTableName());
Review comment:
For 3.0 client, don't need return tables in RSGroupInfo?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #426: HBASE-22695 Store the rsgroup of a table in table configuration
Apache9 commented on a change in pull request #426: HBASE-22695 Store the
rsgroup of a table in table configuration
URL: https://github.com/apache/hbase/pull/426#discussion_r310129795
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.java
##
@@ -524,100 +398,66 @@ public RSGroupInfo getRSGroupOfServer(Address hostPort)
throws IOException {
}
@Override
- public void moveServersAndTables(Set servers, Set
tables, String targetGroup)
- throws IOException {
+ public void removeServers(Set servers) throws IOException {
if (servers == null || servers.isEmpty()) {
- throw new ConstraintException("The list of servers to move cannot be
null or empty.");
-}
-if (tables == null || tables.isEmpty()) {
- throw new ConstraintException("The list of tables to move cannot be null
or empty.");
+ throw new ConstraintException("The set of servers to remove cannot be
null or empty.");
}
-
-//check target group
-getAndCheckRSGroupInfo(targetGroup);
-
-// Hold a lock on the manager instance while moving servers and tables to
prevent
+// Hold a lock on the manager instance while moving servers to prevent
// another writer changing our state while we are working.
synchronized (rsGroupInfoManager) {
- //check servers and tables status
- checkServersAndTables(servers, tables, targetGroup);
-
- //Move servers and tables to a new group.
- String srcGroup =
getRSGroupOfServer(servers.iterator().next()).getName();
- rsGroupInfoManager.moveServersAndTables(servers, tables, srcGroup,
targetGroup);
-
- //move regions on these servers which do not belong to group tables
- moveServerRegionsFromGroup(servers, targetGroup);
- //move regions of these tables which are not on group servers
- moveTableRegionsToGroup(tables, targetGroup);
+ // check the set of servers
+ checkForDeadOrOnlineServers(servers);
+ rsGroupInfoManager.removeServers(servers);
+ LOG.info("Remove decommissioned servers {} from RSGroup done", servers);
Review comment:
I haven't changed the logic here, just formatting. I guess the removeServers
method is to completely remove servers from any rs groups, that;s why they use
the word 'decommissioned'.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] infraio commented on a change in pull request #426: HBASE-22695 Store the rsgroup of a table in table configuration
infraio commented on a change in pull request #426: HBASE-22695 Store the
rsgroup of a table in table configuration
URL: https://github.com/apache/hbase/pull/426#discussion_r310128343
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServiceImpl.java
##
@@ -137,17 +156,24 @@ public void getRSGroupInfoOfTable(RpcController
controller, GetRSGroupInfoOfTabl
RpcCallback done) {
GetRSGroupInfoOfTableResponse.Builder builder =
GetRSGroupInfoOfTableResponse.newBuilder();
TableName tableName = ProtobufUtil.toTableName(request.getTableName());
-RSGroupAdminEndpoint.LOG.info(
+LOG.info(
master.getClientIdAuditPrefix() + " initiates rsgroup info retrieval,
table=" + tableName);
try {
if (master.getMasterCoprocessorHost() != null) {
master.getMasterCoprocessorHost().preGetRSGroupInfoOfTable(tableName);
}
checkPermission("getRSGroupInfoOfTable");
- RSGroupInfo RSGroupInfo =
groupAdminServer.getRSGroupInfoOfTable(tableName);
- if (RSGroupInfo != null) {
-builder.setRSGroupInfo(ProtobufUtil.toProtoGroupInfo(RSGroupInfo));
+ Optional optGroup =
+ RSGroupUtil.getRSGroupInfo(master, groupAdminServer, tableName);
+ if (optGroup.isPresent()) {
+
builder.setRSGroupInfo(ProtobufUtil.toProtoGroupInfo(fillTables(optGroup.get(;
+ } else {
+if (master.getTableStateManager().isTablePresent(tableName)) {
Review comment:
Don't check table present for above case?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #426: HBASE-22695 Store the rsgroup of a table in table configuration
Apache-HBase commented on issue #426: HBASE-22695 Store the rsgroup of a table in table configuration URL: https://github.com/apache/hbase/pull/426#issuecomment-517695506 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 81 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 10 new or modified test files. | ||| _ HBASE-22514 Compile Tests _ | | 0 | mvndep | 25 | Maven dependency ordering for branch | | -1 | mvninstall | 81 | root in HBASE-22514 failed. | | -1 | compile | 20 | hbase-client in HBASE-22514 failed. | | -1 | compile | 34 | hbase-server in HBASE-22514 failed. | | +1 | checkstyle | 128 | HBASE-22514 passed | | +1 | shadedjars | 273 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 71 | HBASE-22514 passed | | 0 | spotbugs | 48 | Used deprecated FindBugs config; considering switching to SpotBugs. | | -1 | findbugs | 20 | hbase-client in HBASE-22514 failed. | | -1 | findbugs | 36 | hbase-server in HBASE-22514 failed. | ||| _ Patch Compile Tests _ | | 0 | mvndep | 13 | Maven dependency ordering for patch | | -1 | mvninstall | 87 | root in the patch failed. | | -1 | compile | 20 | hbase-client in the patch failed. | | -1 | compile | 37 | hbase-server in the patch failed. | | -1 | javac | 20 | hbase-client in the patch failed. | | -1 | javac | 37 | hbase-server in the patch failed. | | +1 | checkstyle | 22 | The patch passed checkstyle in hbase-common | | +1 | checkstyle | 30 | The patch passed checkstyle in hbase-client | | +1 | checkstyle | 74 | hbase-server: The patch generated 0 new + 136 unchanged - 15 fixed = 136 total (was 151) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 268 | patch has no errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 54 | The patch causes 10 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 109 | The patch causes 10 errors with Hadoop v2.9.2. | | -1 | hadoopcheck | 166 | The patch causes 10 errors with Hadoop v3.1.2. | | +1 | javadoc | 71 | the patch passed | | -1 | findbugs | 20 | hbase-client in the patch failed. | | -1 | findbugs | 37 | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 | unit | 171 | hbase-common in the patch passed. | | -1 | unit | 21 | hbase-client in the patch failed. | | -1 | unit | 37 | hbase-server in the patch failed. | | +1 | asflicense | 33 | The patch does not generate ASF License warnings. | | | | 2111 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/13/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/426 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux c4b67407b971 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-426/out/precommit/personality/provided.sh | | git revision | HBASE-22514 / 33a99f2d28 | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/13/artifact/out/branch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/13/artifact/out/branch-compile-hbase-client.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/13/artifact/out/branch-compile-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/13/artifact/out/branch-findbugs-hbase-client.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/13/artifact/out/branch-findbugs-hbase-server.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/13/artifact/out/patch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/13/artifact/out/patch-compile-hbase-client.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/13/artifact/out/patch-compile-hbase-server.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/13/artifact/out/patch-compile-hbase-client.txt | | javac |
[GitHub] [hbase] infraio commented on a change in pull request #426: HBASE-22695 Store the rsgroup of a table in table configuration
infraio commented on a change in pull request #426: HBASE-22695 Store the
rsgroup of a table in table configuration
URL: https://github.com/apache/hbase/pull/426#discussion_r310124084
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.java
##
@@ -524,100 +398,66 @@ public RSGroupInfo getRSGroupOfServer(Address hostPort)
throws IOException {
}
@Override
- public void moveServersAndTables(Set servers, Set
tables, String targetGroup)
- throws IOException {
+ public void removeServers(Set servers) throws IOException {
if (servers == null || servers.isEmpty()) {
- throw new ConstraintException("The list of servers to move cannot be
null or empty.");
-}
-if (tables == null || tables.isEmpty()) {
- throw new ConstraintException("The list of tables to move cannot be null
or empty.");
+ throw new ConstraintException("The set of servers to remove cannot be
null or empty.");
}
-
-//check target group
-getAndCheckRSGroupInfo(targetGroup);
-
-// Hold a lock on the manager instance while moving servers and tables to
prevent
+// Hold a lock on the manager instance while moving servers to prevent
// another writer changing our state while we are working.
synchronized (rsGroupInfoManager) {
- //check servers and tables status
- checkServersAndTables(servers, tables, targetGroup);
-
- //Move servers and tables to a new group.
- String srcGroup =
getRSGroupOfServer(servers.iterator().next()).getName();
- rsGroupInfoManager.moveServersAndTables(servers, tables, srcGroup,
targetGroup);
-
- //move regions on these servers which do not belong to group tables
- moveServerRegionsFromGroup(servers, targetGroup);
- //move regions of these tables which are not on group servers
- moveTableRegionsToGroup(tables, targetGroup);
+ // check the set of servers
+ checkForDeadOrOnlineServers(servers);
+ rsGroupInfoManager.removeServers(servers);
+ LOG.info("Remove decommissioned servers {} from RSGroup done", servers);
Review comment:
Why "decommissioned" servers?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on a change in pull request #442: HBASE-22631 assign failed may make gced parent region appear again
Apache-HBase commented on a change in pull request #442: HBASE-22631 assign failed may make gced parent region appear again URL: https://github.com/apache/hbase/pull/442#discussion_r310123010 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignProcedure.java ## @@ -362,10 +362,11 @@ private void handleFailure(final MasterProcedureEnv env, final RegionStateNode r } this.forceNewPlan = true; this.targetServer = null; -regionNode.offline(); + Review comment: whitespace:end of line This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #442: HBASE-22631 assign failed may make gced parent region appear again
Apache-HBase commented on issue #442: HBASE-22631 assign failed may make gced parent region appear again URL: https://github.com/apache/hbase/pull/442#issuecomment-517694503 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 72 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.1 Compile Tests _ | | +1 | mvninstall | 399 | branch-2.1 passed | | +1 | compile | 65 | branch-2.1 passed | | +1 | checkstyle | 88 | branch-2.1 passed | | +1 | shadedjars | 300 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 39 | branch-2.1 passed | | 0 | spotbugs | 209 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 206 | branch-2.1 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 343 | the patch passed | | +1 | compile | 68 | the patch passed | | +1 | javac | 68 | the patch passed | | +1 | checkstyle | 93 | the patch passed | | -1 | whitespace | 0 | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | +1 | shadedjars | 290 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1472 | Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2. | | +1 | javadoc | 38 | the patch passed | | +1 | findbugs | 209 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 13524 | hbase-server in the patch passed. | | +1 | asflicense | 46 | The patch does not generate ASF License warnings. | | | | 17682 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-442/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/442 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux b36131079dec 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-442/out/precommit/personality/provided.sh | | git revision | branch-2.1 / e68b16a6c1 | | Default Java | 1.8.0_181 | | whitespace | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-442/1/artifact/out/whitespace-eol.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-442/1/testReport/ | | Max. process+thread count | 5153 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-442/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] infraio commented on a change in pull request #426: HBASE-22695 Store the rsgroup of a table in table configuration
infraio commented on a change in pull request #426: HBASE-22695 Store the
rsgroup of a table in table configuration
URL: https://github.com/apache/hbase/pull/426#discussion_r310122692
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.java
##
@@ -440,17 +311,18 @@ public void removeRSGroup(String name) throws
IOException {
if (rsGroupInfo == null) {
throw new ConstraintException("RSGroup " + name + " does not exist");
}
- int tableCount = rsGroupInfo.getTables().size();
- if (tableCount > 0) {
-throw new ConstraintException("RSGroup " + name + " has " + tableCount
+
-" tables; you must remove these tables from the rsgroup before " +
-"the rsgroup can be removed.");
- }
int serverCount = rsGroupInfo.getServers().size();
if (serverCount > 0) {
throw new ConstraintException("RSGroup " + name + " has " +
serverCount +
-" servers; you must remove these servers from the RSGroup before" +
-"the RSGroup can be removed.");
+ " servers; you must remove these servers from the RSGroup before" +
Review comment:
Need a space after "RSGroup before"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-22724) Add a emoji on the vote table for pre commit result on github
[ https://issues.apache.org/jira/browse/HBASE-22724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16898875#comment-16898875 ] Duo Zhang commented on HBASE-22724: --- Oh, seems there is no way to override the github_finalreport method... [~busbey], is this expected? We used to override the javac_logfilter method... > Add a emoji on the vote table for pre commit result on github > - > > Key: HBASE-22724 > URL: https://issues.apache.org/jira/browse/HBASE-22724 > Project: HBase > Issue Type: Improvement >Reporter: Duo Zhang >Priority: Major > > [~zghaobac] said that the current vote table on github is not good enough, as > the colors are almost the same, it is not easy to find out which line is > broken. > Since github can not change the color of the text, he suggested that we add a > column at the left most with some emojis to better notify the developpers. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22777) Add a multi-region merge (for fixing overlaps, etc.)
[
https://issues.apache.org/jira/browse/HBASE-22777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16898873#comment-16898873
]
HBase QA commented on HBASE-22777:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
4s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
44s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
33s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 7m
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
20s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
59s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
27s{color} | {color:red} hbase-client: The patch generated 3 new + 121
unchanged - 2 fixed = 124 total (was 123) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
11s{color} | {color:red} hbase-server: The patch generated 20 new + 151
unchanged - 3 fixed = 171 total (was 154) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
22s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
14m 45s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
1m 47s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m
35s{color} | {color:red} hbase-server generated 2 new + 0 unchanged - 0 fixed =
2 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
10s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
31s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
41s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
32s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}301m 7s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
20s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} |
[GitHub] [hbase] Apache-HBase commented on issue #444: HBASE-22724 Test github post
Apache-HBase commented on issue #444: HBASE-22724 Test github post URL: https://github.com/apache/hbase/pull/444#issuecomment-517689831 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 44 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ HBASE-22724 Compile Tests _ | | -1 | mvninstall | 95 | root in HBASE-22724 failed. | | +1 | compile | 22 | HBASE-22724 passed | | +1 | checkstyle | 22 | HBASE-22724 passed | | +1 | shadedjars | 273 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 17 | HBASE-22724 passed | | 0 | spotbugs | 52 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 50 | HBASE-22724 passed | ||| _ Patch Compile Tests _ | | -1 | mvninstall | 87 | root in the patch failed. | | +1 | compile | 22 | the patch passed | | +1 | javac | 22 | the patch passed | | -1 | checkstyle | 22 | hbase-common: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 282 | patch has no errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 78 | The patch causes 10 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 159 | The patch causes 10 errors with Hadoop v2.9.2. | | -1 | hadoopcheck | 242 | The patch causes 10 errors with Hadoop v3.1.2. | | +1 | javadoc | 18 | the patch passed | | +1 | findbugs | 53 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 168 | hbase-common in the patch passed. | | +1 | asflicense | 10 | The patch does not generate ASF License warnings. | | | | 1511 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-444/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/444 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 7d04500cb870 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-444/out/precommit/personality/provided.sh | | git revision | HBASE-22724 / 8e99b85718 | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-444/4/artifact/out/branch-mvninstall-root.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-444/4/artifact/out/patch-mvninstall-root.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-444/4/artifact/out/diff-checkstyle-hbase-common.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-444/4/artifact/out/patch-javac-2.8.5.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-444/4/artifact/out/patch-javac-2.9.2.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-444/4/artifact/out/patch-javac-3.1.2.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-444/4/testReport/ | | Max. process+thread count | 290 (vs. ulimit of 1) | | modules | C: hbase-common U: hbase-common | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-444/4/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] wchevreuil commented on a change in pull request #439: HBASE-22618 Provide a way to have Heterogeneous deployment
wchevreuil commented on a change in pull request #439: HBASE-22618 Provide a
way to have Heterogeneous deployment
URL: https://github.com/apache/hbase/pull/439#discussion_r310118173
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##
@@ -196,25 +199,53 @@ public synchronized void setConf(Configuration conf) {
};
regionReplicaHostCostFunction = new RegionReplicaHostCostFunction(conf);
regionReplicaRackCostFunction = new RegionReplicaRackCostFunction(conf);
-costFunctions = new CostFunction[]{
- new RegionCountSkewCostFunction(conf),
- new PrimaryRegionCountSkewCostFunction(conf),
- new MoveCostFunction(conf),
- localityCost,
- rackLocalityCost,
- new TableSkewCostFunction(conf),
- regionReplicaHostCostFunction,
- regionReplicaRackCostFunction,
- regionLoadFunctions[0],
- regionLoadFunctions[1],
- regionLoadFunctions[2],
- regionLoadFunctions[3],
- regionLoadFunctions[4]
-};
-curFunctionCosts= new Double[costFunctions.length];
-tempFunctionCosts= new Double[costFunctions.length];
+
+costFunctions = new ArrayList<>();
+costFunctions.add(new RegionCountSkewCostFunction(conf));
+costFunctions.add(new PrimaryRegionCountSkewCostFunction(conf));
+costFunctions.add(new MoveCostFunction(conf));
+costFunctions.add(localityCost);
+costFunctions.add(rackLocalityCost);
+costFunctions.add(new TableSkewCostFunction(conf));
+costFunctions.add(regionReplicaHostCostFunction);
+costFunctions.add(regionReplicaRackCostFunction);
+costFunctions.add(regionLoadFunctions[0]);
+costFunctions.add(regionLoadFunctions[1]);
+costFunctions.add(regionLoadFunctions[2]);
+costFunctions.add(regionLoadFunctions[3]);
+costFunctions.add( regionLoadFunctions[4]);
+loadCustomCostFunctions(conf);
+
+curFunctionCosts= new Double[costFunctions.size()];
+tempFunctionCosts= new Double[costFunctions.size()];
LOG.info("Loaded config; maxSteps=" + maxSteps + ", stepsPerRegion=" +
stepsPerRegion +
-", maxRunningTime=" + maxRunningTime + ", isByTable=" + isByTable + ",
etc.");
+", maxRunningTime=" + maxRunningTime + ", isByTable=" + isByTable
+ ", CostFunctions=" + Arrays.toString(getCostFunctionNames()) + " etc.");
+ }
+
+ private void loadCustomCostFunctions(Configuration conf) {
+String[] functionsNames =
conf.getStrings(StochasticLoadBalancer.COST_FUNCTIONS_COST_FUNCTIONS_KEY);
+
+if (null == functionsNames) {
+ return;
+}
+
+costFunctions.addAll(Arrays.stream(functionsNames)
+.map(c -> {
+ Class klass = null;
+ try {
+klass = (Class) Class.forName(c);
+ } catch (ClassNotFoundException e) {
+e.printStackTrace();
Review comment:
Should log a WARN, as _e.printStackTrace_ goes to the stdo.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #441: HBASE-22631 assign failed may make gced parent region appear again
Apache-HBase commented on issue #441: HBASE-22631 assign failed may make gced parent region appear again URL: https://github.com/apache/hbase/pull/441#issuecomment-517686972 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 62 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.1 Compile Tests _ | | +1 | mvninstall | 297 | branch-2.1 passed | | +1 | compile | 54 | branch-2.1 passed | | +1 | checkstyle | 74 | branch-2.1 passed | | +1 | shadedjars | 225 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 32 | branch-2.1 passed | | 0 | spotbugs | 153 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 150 | branch-2.1 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 274 | the patch passed | | +1 | compile | 53 | the patch passed | | +1 | javac | 53 | the patch passed | | +1 | checkstyle | 74 | the patch passed | | -1 | whitespace | 0 | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | +1 | shadedjars | 235 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1295 | Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2. | | +1 | javadoc | 31 | the patch passed | | +1 | findbugs | 180 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 13504 | hbase-server in the patch passed. | | +1 | asflicense | 30 | The patch does not generate ASF License warnings. | | | | 16956 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-441/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/441 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 74a7444f9ffe 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-441/out/precommit/personality/provided.sh | | git revision | branch-2.1 / e68b16a6c1 | | Default Java | 1.8.0_181 | | whitespace | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-441/1/artifact/out/whitespace-eol.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-441/1/testReport/ | | Max. process+thread count | 4895 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-441/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on a change in pull request #441: HBASE-22631 assign failed may make gced parent region appear again
Apache-HBase commented on a change in pull request #441: HBASE-22631 assign failed may make gced parent region appear again URL: https://github.com/apache/hbase/pull/441#discussion_r310114723 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignProcedure.java ## @@ -362,10 +362,11 @@ private void handleFailure(final MasterProcedureEnv env, final RegionStateNode r } this.forceNewPlan = true; this.targetServer = null; -regionNode.offline(); + Review comment: whitespace:end of line This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #439: HBASE-22618 Provide a way to have Heterogeneous deployment
Apache-HBase commented on issue #439: HBASE-22618 Provide a way to have Heterogeneous deployment URL: https://github.com/apache/hbase/pull/439#issuecomment-517677723 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 221 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 300 | master passed | | +1 | compile | 53 | master passed | | +1 | checkstyle | 71 | master passed | | +1 | shadedjars | 259 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 32 | master passed | | 0 | spotbugs | 237 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 235 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 284 | the patch passed | | +1 | compile | 51 | the patch passed | | +1 | javac | 51 | the patch passed | | -1 | checkstyle | 76 | hbase-server: The patch generated 17 new + 64 unchanged - 0 fixed = 81 total (was 64) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | -1 | shadedjars | 212 | patch has 10 errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 888 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 30 | the patch passed | | -1 | findbugs | 35 | hbase-server in the patch failed. | ||| _ Other Tests _ | | -1 | unit | 1648 | hbase-server in the patch failed. | | -1 | asflicense | 11 | The patch generated 1 ASF License warnings. | | | | 4769 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.filter.TestDependentColumnFilter | | | hadoop.hbase.regionserver.TestRegionInfoBuilder | | | hadoop.hbase.filter.TestColumnPrefixFilter | | | hadoop.hbase.regionserver.TestStoreFileRefresherChore | | | hadoop.hbase.quotas.TestRegionServerSpaceQuotaManager | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/439 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux c46671c24184 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-439/out/precommit/personality/provided.sh | | git revision | master / a6f065396a | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/3/artifact/out/diff-checkstyle-hbase-server.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/3/artifact/out/patch-shadedjars.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/3/artifact/out/patch-findbugs-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/3/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/3/testReport/ | | asflicense | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/3/artifact/out/patch-asflicense-problems.txt | | Max. process+thread count | 684 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/3/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22781) Not suitable params of StoreScanner in the test case TestStoreScanner.testScanSameTimestamp
[
https://issues.apache.org/jira/browse/HBASE-22781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zheng Wang updated HBASE-22781:
---
Description:
{code:java}
public void testScanSameTimestamp() throws IOException {
// returns only 1 of these 2 even though same timestamp
KeyValue [] kvs = new KeyValue[] {
create("R1", "cf", "a", 1, KeyValue.Type.Put, "dont-care"),
create("R1", "cf", "a", 1, KeyValue.Type.Put, "dont-care"),
};
List scanners = Arrays.asList(
new KeyValueScanner[] {
new KeyValueScanFixture(CellComparator.getInstance(), kvs)
});
Scan scanSpec = new Scan().withStartRow(Bytes.toBytes("R1"));
// this only uses maxVersions (default=1) and TimeRange (default=all)
try (StoreScanner scan = new StoreScanner(scanSpec, scanInfo, getCols("a"),
scanners)) {
List results = new ArrayList<>();
assertEquals(true, scan.next(results));
assertEquals(1, results.size());
assertEquals(kvs[0], results.get(0));
}
}
{code}
It will not to compare the timestamp of the two cells,because of the
'getCols("a")' limit only one column and one version(default).
For example,modify the timestamp of the first cell to 2 can also pass.
was:
{code:java}
public void testScanSameTimestamp() throws IOException {
// returns only 1 of these 2 even though same timestamp
KeyValue [] kvs = new KeyValue[] {
create("R1", "cf", "a", 1, KeyValue.Type.Put, "dont-care"),
create("R1", "cf", "a", 1, KeyValue.Type.Put, "dont-care"),
};
List scanners = Arrays.asList(
new KeyValueScanner[] {
new KeyValueScanFixture(CellComparator.getInstance(), kvs)
});
Scan scanSpec = new Scan().withStartRow(Bytes.toBytes("R1"));
// this only uses maxVersions (default=1) and TimeRange (default=all)
try (StoreScanner scan = new StoreScanner(scanSpec, scanInfo, getCols("a"),
scanners)) {
List results = new ArrayList<>();
assertEquals(true, scan.next(results));
assertEquals(1, results.size());
assertEquals(kvs[0], results.get(0));
}
}
{code}
It will not to compare the timestamp of the two cells,because of the
'getCols("a")' limit one column and one version(default).
For example,modify the timestamp of the first cell to 2 can also pass.
> Not suitable params of StoreScanner in the test case
> TestStoreScanner.testScanSameTimestamp
> ---
>
> Key: HBASE-22781
> URL: https://issues.apache.org/jira/browse/HBASE-22781
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 2.0.0
>Reporter: Zheng Wang
>Priority: Minor
>
> {code:java}
> public void testScanSameTimestamp() throws IOException {
> // returns only 1 of these 2 even though same timestamp
> KeyValue [] kvs = new KeyValue[] {
> create("R1", "cf", "a", 1, KeyValue.Type.Put, "dont-care"),
> create("R1", "cf", "a", 1, KeyValue.Type.Put, "dont-care"),
> };
> List scanners = Arrays.asList(
> new KeyValueScanner[] {
> new KeyValueScanFixture(CellComparator.getInstance(), kvs)
> });
> Scan scanSpec = new Scan().withStartRow(Bytes.toBytes("R1"));
> // this only uses maxVersions (default=1) and TimeRange (default=all)
> try (StoreScanner scan = new StoreScanner(scanSpec, scanInfo, getCols("a"),
> scanners)) {
> List results = new ArrayList<>();
> assertEquals(true, scan.next(results));
> assertEquals(1, results.size());
> assertEquals(kvs[0], results.get(0));
> }
> }
> {code}
>
> It will not to compare the timestamp of the two cells,because of the
> 'getCols("a")' limit only one column and one version(default).
> For example,modify the timestamp of the first cell to 2 can also pass.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-22781) Not suitable params of StoreScanner in the test case TestStoreScanner.testScanSameTimestamp
[
https://issues.apache.org/jira/browse/HBASE-22781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zheng Wang updated HBASE-22781:
---
Description:
{code:java}
public void testScanSameTimestamp() throws IOException {
// returns only 1 of these 2 even though same timestamp
KeyValue [] kvs = new KeyValue[] {
create("R1", "cf", "a", 1, KeyValue.Type.Put, "dont-care"),
create("R1", "cf", "a", 1, KeyValue.Type.Put, "dont-care"),
};
List scanners = Arrays.asList(
new KeyValueScanner[] {
new KeyValueScanFixture(CellComparator.getInstance(), kvs)
});
Scan scanSpec = new Scan().withStartRow(Bytes.toBytes("R1"));
// this only uses maxVersions (default=1) and TimeRange (default=all)
try (StoreScanner scan = new StoreScanner(scanSpec, scanInfo, getCols("a"),
scanners)) {
List results = new ArrayList<>();
assertEquals(true, scan.next(results));
assertEquals(1, results.size());
assertEquals(kvs[0], results.get(0));
}
}
{code}
It will not to compare the timestamp of the two cells,because of the
'getCols("a")' limit one column and one version(default).
For example,modify the timestamp of the first cell to 2 can also pass.
was:
{code:java}
public void testScanSameTimestamp() throws IOException {
// returns only 1 of these 2 even though same timestamp
KeyValue [] kvs = new KeyValue[] {
create("R1", "cf", "a", 1, KeyValue.Type.Put, "dont-care"),
create("R1", "cf", "a", 1, KeyValue.Type.Put, "dont-care"),
};
List scanners = Arrays.asList(
new KeyValueScanner[] {
new KeyValueScanFixture(CellComparator.getInstance(), kvs)
});
Scan scanSpec = new Scan().withStartRow(Bytes.toBytes("R1"));
// this only uses maxVersions (default=1) and TimeRange (default=all)
try (StoreScanner scan = new StoreScanner(scanSpec, scanInfo, getCols("a"),
scanners)) {
List results = new ArrayList<>();
assertEquals(true, scan.next(results));
assertEquals(1, results.size());
assertEquals(kvs[0], results.get(0));
}
}
{code}
It will not to compare the timestamp of the two cells,because of the
'getCols("a")' limit one column and one version(default).
> Not suitable params of StoreScanner in the test case
> TestStoreScanner.testScanSameTimestamp
> ---
>
> Key: HBASE-22781
> URL: https://issues.apache.org/jira/browse/HBASE-22781
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 2.0.0
>Reporter: Zheng Wang
>Priority: Minor
>
> {code:java}
> public void testScanSameTimestamp() throws IOException {
> // returns only 1 of these 2 even though same timestamp
> KeyValue [] kvs = new KeyValue[] {
> create("R1", "cf", "a", 1, KeyValue.Type.Put, "dont-care"),
> create("R1", "cf", "a", 1, KeyValue.Type.Put, "dont-care"),
> };
> List scanners = Arrays.asList(
> new KeyValueScanner[] {
> new KeyValueScanFixture(CellComparator.getInstance(), kvs)
> });
> Scan scanSpec = new Scan().withStartRow(Bytes.toBytes("R1"));
> // this only uses maxVersions (default=1) and TimeRange (default=all)
> try (StoreScanner scan = new StoreScanner(scanSpec, scanInfo, getCols("a"),
> scanners)) {
> List results = new ArrayList<>();
> assertEquals(true, scan.next(results));
> assertEquals(1, results.size());
> assertEquals(kvs[0], results.get(0));
> }
> }
> {code}
>
> It will not to compare the timestamp of the two cells,because of the
> 'getCols("a")' limit one column and one version(default).
> For example,modify the timestamp of the first cell to 2 can also pass.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-22781) Not suitable params of StoreScanner in the test case TestStoreScanner.testScanSameTimestamp
[
https://issues.apache.org/jira/browse/HBASE-22781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zheng Wang updated HBASE-22781:
---
Description:
{code:java}
public void testScanSameTimestamp() throws IOException {
// returns only 1 of these 2 even though same timestamp
KeyValue [] kvs = new KeyValue[] {
create("R1", "cf", "a", 2, KeyValue.Type.Put, "dont-care"),
create("R1", "cf", "a", 1, KeyValue.Type.Put, "dont-care"),
};
List scanners = Arrays.asList(
new KeyValueScanner[] {
new KeyValueScanFixture(CellComparator.getInstance(), kvs)
});
Scan scanSpec = new Scan().withStartRow(Bytes.toBytes("R1"));
// this only uses maxVersions (default=1) and TimeRange (default=all)
try (StoreScanner scan = new StoreScanner(scanSpec, scanInfo, getCols("a"),
scanners)) {
List results = new ArrayList<>();
assertEquals(true, scan.next(results));
assertEquals(1, results.size());
assertEquals(kvs[0], results.get(0));
}
}
{code}
It will not to compare the timestamp of the two cells,because of the
'getCols("a")' limit one column and one version(default).
was:
{code:java}
Scan scanSpec = new Scan().withStartRow(Bytes.toBytes("R1"));
// this only uses maxVersions (default=1) and TimeRange (default=all)
try (StoreScanner scan = new StoreScanner(scanSpec, scanInfo, getCols("a"),
scanners)) {
List results = new ArrayList<>();
assertEquals(true, scan.next(results));
assertEquals(1, results.size());
assertEquals(kvs[0], results.get(0));
}
{code}
It will not to compare the timestamp of the two cells,because of the
'getCols("a")' limit one column and one version(default).
> Not suitable params of StoreScanner in the test case
> TestStoreScanner.testScanSameTimestamp
> ---
>
> Key: HBASE-22781
> URL: https://issues.apache.org/jira/browse/HBASE-22781
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 2.0.0
>Reporter: Zheng Wang
>Priority: Minor
>
> {code:java}
> public void testScanSameTimestamp() throws IOException {
> // returns only 1 of these 2 even though same timestamp
> KeyValue [] kvs = new KeyValue[] {
> create("R1", "cf", "a", 2, KeyValue.Type.Put, "dont-care"),
> create("R1", "cf", "a", 1, KeyValue.Type.Put, "dont-care"),
> };
> List scanners = Arrays.asList(
> new KeyValueScanner[] {
> new KeyValueScanFixture(CellComparator.getInstance(), kvs)
> });
> Scan scanSpec = new Scan().withStartRow(Bytes.toBytes("R1"));
> // this only uses maxVersions (default=1) and TimeRange (default=all)
> try (StoreScanner scan = new StoreScanner(scanSpec, scanInfo, getCols("a"),
> scanners)) {
> List results = new ArrayList<>();
> assertEquals(true, scan.next(results));
> assertEquals(1, results.size());
> assertEquals(kvs[0], results.get(0));
> }
> }
> {code}
>
> It will not to compare the timestamp of the two cells,because of the
> 'getCols("a")' limit one column and one version(default).
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (HBASE-22781) Not suitable params of StoreScanner in the test case TestStoreScanner.testScanSameTimestamp
[
https://issues.apache.org/jira/browse/HBASE-22781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zheng Wang updated HBASE-22781:
---
Description:
{code:java}
public void testScanSameTimestamp() throws IOException {
// returns only 1 of these 2 even though same timestamp
KeyValue [] kvs = new KeyValue[] {
create("R1", "cf", "a", 1, KeyValue.Type.Put, "dont-care"),
create("R1", "cf", "a", 1, KeyValue.Type.Put, "dont-care"),
};
List scanners = Arrays.asList(
new KeyValueScanner[] {
new KeyValueScanFixture(CellComparator.getInstance(), kvs)
});
Scan scanSpec = new Scan().withStartRow(Bytes.toBytes("R1"));
// this only uses maxVersions (default=1) and TimeRange (default=all)
try (StoreScanner scan = new StoreScanner(scanSpec, scanInfo, getCols("a"),
scanners)) {
List results = new ArrayList<>();
assertEquals(true, scan.next(results));
assertEquals(1, results.size());
assertEquals(kvs[0], results.get(0));
}
}
{code}
It will not to compare the timestamp of the two cells,because of the
'getCols("a")' limit one column and one version(default).
was:
{code:java}
public void testScanSameTimestamp() throws IOException {
// returns only 1 of these 2 even though same timestamp
KeyValue [] kvs = new KeyValue[] {
create("R1", "cf", "a", 2, KeyValue.Type.Put, "dont-care"),
create("R1", "cf", "a", 1, KeyValue.Type.Put, "dont-care"),
};
List scanners = Arrays.asList(
new KeyValueScanner[] {
new KeyValueScanFixture(CellComparator.getInstance(), kvs)
});
Scan scanSpec = new Scan().withStartRow(Bytes.toBytes("R1"));
// this only uses maxVersions (default=1) and TimeRange (default=all)
try (StoreScanner scan = new StoreScanner(scanSpec, scanInfo, getCols("a"),
scanners)) {
List results = new ArrayList<>();
assertEquals(true, scan.next(results));
assertEquals(1, results.size());
assertEquals(kvs[0], results.get(0));
}
}
{code}
It will not to compare the timestamp of the two cells,because of the
'getCols("a")' limit one column and one version(default).
> Not suitable params of StoreScanner in the test case
> TestStoreScanner.testScanSameTimestamp
> ---
>
> Key: HBASE-22781
> URL: https://issues.apache.org/jira/browse/HBASE-22781
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 2.0.0
>Reporter: Zheng Wang
>Priority: Minor
>
> {code:java}
> public void testScanSameTimestamp() throws IOException {
> // returns only 1 of these 2 even though same timestamp
> KeyValue [] kvs = new KeyValue[] {
> create("R1", "cf", "a", 1, KeyValue.Type.Put, "dont-care"),
> create("R1", "cf", "a", 1, KeyValue.Type.Put, "dont-care"),
> };
> List scanners = Arrays.asList(
> new KeyValueScanner[] {
> new KeyValueScanFixture(CellComparator.getInstance(), kvs)
> });
> Scan scanSpec = new Scan().withStartRow(Bytes.toBytes("R1"));
> // this only uses maxVersions (default=1) and TimeRange (default=all)
> try (StoreScanner scan = new StoreScanner(scanSpec, scanInfo, getCols("a"),
> scanners)) {
> List results = new ArrayList<>();
> assertEquals(true, scan.next(results));
> assertEquals(1, results.size());
> assertEquals(kvs[0], results.get(0));
> }
> }
> {code}
>
> It will not to compare the timestamp of the two cells,because of the
> 'getCols("a")' limit one column and one version(default).
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Created] (HBASE-22781) Not suitable params of StoreScanner in the test case TestStoreScanner.testScanSameTimestamp
Zheng Wang created HBASE-22781:
--
Summary: Not suitable params of StoreScanner in the test case
TestStoreScanner.testScanSameTimestamp
Key: HBASE-22781
URL: https://issues.apache.org/jira/browse/HBASE-22781
Project: HBase
Issue Type: Bug
Components: test
Affects Versions: 2.0.0
Reporter: Zheng Wang
{code:java}
Scan scanSpec = new Scan().withStartRow(Bytes.toBytes("R1"));
// this only uses maxVersions (default=1) and TimeRange (default=all)
try (StoreScanner scan = new StoreScanner(scanSpec, scanInfo, getCols("a"),
scanners)) {
List results = new ArrayList<>();
assertEquals(true, scan.next(results));
assertEquals(1, results.size());
assertEquals(kvs[0], results.get(0));
}
{code}
It will not to compare the timestamp of the two cells,because of the
'getCols("a")' limit one column and one version(default).
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22047) LeaseException in Scan should be retired
[
https://issues.apache.org/jira/browse/HBASE-22047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16898836#comment-16898836
]
Hudson commented on HBASE-22047:
Results for branch branch-1
[build #988 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/988/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/988//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/988//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/988//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> LeaseException in Scan should be retired
>
>
> Key: HBASE-22047
> URL: https://issues.apache.org/jira/browse/HBASE-22047
> Project: HBase
> Issue Type: Bug
> Components: Client, Scanners
>Affects Versions: 2.2.0, 2.0.4, 2.1.3
>Reporter: Allan Yang
>Assignee: Igor Rudenko
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.2.0, 2.3.0, 2.1.5
>
>
> We should retry LeaseException just like other exceptions like
> OutOfOrderScannerNextException and UnknownScannerException
> Code in ClientScanner：
> {code:java}
> if ((cause != null && cause instanceof NotServingRegionException) ||
> (cause != null && cause instanceof RegionServerStoppedException) ||
> e instanceof OutOfOrderScannerNextException || e instanceof
> UnknownScannerException ||
> e instanceof ScannerResetException) {
> // Pass. It is easier writing the if loop test as list of what is
> allowed rather than
> // as a list of what is not allowed... so if in here, it means we do
> not throw.
> if (retriesLeft <= 0) {
> throw e; // no more retries
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22762) Print the delta between phases in the split/merge/compact/flush transaction journals
[
https://issues.apache.org/jira/browse/HBASE-22762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16898837#comment-16898837
]
Hudson commented on HBASE-22762:
Results for branch branch-1
[build #988 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/988/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/988//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/988//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/988//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Print the delta between phases in the split/merge/compact/flush transaction
> journals
>
>
> Key: HBASE-22762
> URL: https://issues.apache.org/jira/browse/HBASE-22762
> Project: HBase
> Issue Type: Improvement
> Components: logging
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Minor
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
> Attachments: HBASE-22762-branch-1-addendum.patch,
> HBASE-22762.branch-1.001.patch, HBASE-22762.branch-1.002.patch,
> HBASE-22762.branch-1.004.patch
>
>
> We print the start timestamp for each phase when logging the
> split/merge/compact/flush transaction journals and so when debugging an
> operator must do the math by hand. It would be trivial to also print the
> delta from the start timestamp of the previous phase and helpful to do so.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22744) Remove deprecated classes around status and load
[
https://issues.apache.org/jira/browse/HBASE-22744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16898834#comment-16898834
]
Viraj Jasani commented on HBASE-22744:
--
[~Jan Hentschel] if it is fine with you, can I pick up this task? I can try to
focus on shell first and then remove completely.
> Remove deprecated classes around status and load
>
>
> Key: HBASE-22744
> URL: https://issues.apache.org/jira/browse/HBASE-22744
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Major
> Fix For: 3.0.0
>
>
> The client module has three deprecated classes around metrics,
> {{ClusterStatus}}, {{RegionLoad}} and {{ServerLoad}}, which should be removed.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #444: HBASE-22724 Test github post
Apache-HBase commented on issue #444: HBASE-22724 Test github post URL: https://github.com/apache/hbase/pull/444#issuecomment-517675764 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 73 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ HBASE-22724 Compile Tests _ | | +1 | mvninstall | 407 | HBASE-22724 passed | | +1 | compile | 28 | HBASE-22724 passed | | +1 | checkstyle | 34 | HBASE-22724 passed | | +1 | shadedjars | 347 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 24 | HBASE-22724 passed | | 0 | spotbugs | 63 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 60 | HBASE-22724 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 369 | the patch passed | | +1 | compile | 28 | the patch passed | | +1 | javac | 28 | the patch passed | | -1 | checkstyle | 31 | hbase-common: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 339 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1168 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 23 | the patch passed | | +1 | findbugs | 70 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 207 | hbase-common in the patch passed. | | +1 | asflicense | 14 | The patch does not generate ASF License warnings. | | | | 3694 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-444/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/444 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 0316e01bddff 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-444/out/precommit/personality/provided.sh | | git revision | HBASE-22724 / f258d99a77 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-444/1/artifact/out/diff-checkstyle-hbase-common.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-444/1/testReport/ | | Max. process+thread count | 292 (vs. ulimit of 1) | | modules | C: hbase-common U: hbase-common | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-444/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent
Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent URL: https://github.com/apache/hbase/pull/387#issuecomment-517675117 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 67 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 483 | master passed | | +1 | compile | 28 | master passed | | +1 | checkstyle | 14 | master passed | | +1 | shadedjars | 347 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 25 | master passed | | 0 | spotbugs | 60 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 58 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 369 | the patch passed | | +1 | compile | 28 | the patch passed | | +1 | javac | 28 | the patch passed | | +1 | checkstyle | 13 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 336 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1153 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 22 | the patch passed | | +1 | findbugs | 61 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 655 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 11 | The patch does not generate ASF License warnings. | | | | 4124 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/48/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/387 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux e1e5c9319663 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-387/out/precommit/personality/provided.sh | | git revision | master / a6f065396a | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/48/testReport/ | | Max. process+thread count | 4606 (vs. ulimit of 1) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/48/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22762) Print the delta between phases in the split/merge/compact/flush transaction journals
[
https://issues.apache.org/jira/browse/HBASE-22762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16898831#comment-16898831
]
Hudson commented on HBASE-22762:
Results for branch branch-1.4
[build #938 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/938/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/938//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/938//JDK7_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/938//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Print the delta between phases in the split/merge/compact/flush transaction
> journals
>
>
> Key: HBASE-22762
> URL: https://issues.apache.org/jira/browse/HBASE-22762
> Project: HBase
> Issue Type: Improvement
> Components: logging
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Minor
> Fix For: 1.5.0, 1.3.6, 1.4.11
>
> Attachments: HBASE-22762-branch-1-addendum.patch,
> HBASE-22762.branch-1.001.patch, HBASE-22762.branch-1.002.patch,
> HBASE-22762.branch-1.004.patch
>
>
> We print the start timestamp for each phase when logging the
> split/merge/compact/flush transaction journals and so when debugging an
> operator must do the math by hand. It would be trivial to also print the
> delta from the start timestamp of the previous phase and helpful to do so.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #436: HBASE-22699 refactor isMetaClearingException
Apache-HBase commented on issue #436: HBASE-22699 refactor isMetaClearingException URL: https://github.com/apache/hbase/pull/436#issuecomment-517672277 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 72 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 42 | Maven dependency ordering for branch | | -1 | mvninstall | 328 | root in master failed. | | +1 | compile | 54 | master passed | | +1 | checkstyle | 68 | master passed | | +1 | shadedjars | 292 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 50 | master passed | | 0 | spotbugs | 88 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 154 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 16 | Maven dependency ordering for patch | | -1 | mvninstall | 314 | root in the patch failed. | | +1 | compile | 53 | the patch passed | | +1 | javac | 53 | the patch passed | | +1 | checkstyle | 66 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 282 | patch has no errors when building our shaded downstream artifacts. | | -1 | hadoopcheck | 260 | The patch causes 10 errors with Hadoop v2.8.5. | | -1 | hadoopcheck | 527 | The patch causes 10 errors with Hadoop v2.9.2. | | -1 | hadoopcheck | 761 | The patch causes 10 errors with Hadoop v3.1.2. | | +1 | javadoc | 47 | the patch passed | | +1 | findbugs | 161 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 100 | hbase-client in the patch passed. | | -1 | unit | 476 | hbase-thrift in the patch failed. | | +1 | asflicense | 20 | The patch does not generate ASF License warnings. | | | | 3452 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.thrift.TestThriftServerCmdLine | | | hadoop.hbase.thrift2.TestThriftConnection | | | hadoop.hbase.thrift2.TestThriftHBaseServiceHandler | | | hadoop.hbase.thrift2.TestThrift2ServerCmdLine | | | hadoop.hbase.thrift2.TestThriftHBaseServiceHandlerWithReadOnly | | | hadoop.hbase.thrift.TestThriftSpnegoHttpServer | | | hadoop.hbase.thrift2.TestThriftHBaseServiceHandlerWithLabels | | | hadoop.hbase.thrift2.TestThrift2HttpServer | | | hadoop.hbase.thrift.TestThriftServer | | | hadoop.hbase.thrift.TestThriftHttpServer | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/6/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/436 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux e4ed7747edd4 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-436/out/precommit/personality/provided.sh | | git revision | master / a6f065396a | | Default Java | 1.8.0_181 | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/6/artifact/out/branch-mvninstall-root.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/6/artifact/out/patch-mvninstall-root.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/6/artifact/out/patch-javac-2.8.5.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/6/artifact/out/patch-javac-2.9.2.txt | | hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/6/artifact/out/patch-javac-3.1.2.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/6/artifact/out/patch-unit-hbase-thrift.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/6/testReport/ | | Max. process+thread count | 1129 (vs. ulimit of 1) | | modules | C: hbase-client hbase-thrift U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/6/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the
[GitHub] [hbase] Apache-HBase commented on issue #374: HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and Classes
Apache-HBase commented on issue #374: HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and Classes URL: https://github.com/apache/hbase/pull/374#issuecomment-517670211 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 42 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 294 | master passed | | +1 | compile | 20 | master passed | | +1 | checkstyle | 25 | master passed | | +1 | shadedjars | 275 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 18 | master passed | | 0 | spotbugs | 49 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 46 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 287 | the patch passed | | +1 | compile | 22 | the patch passed | | +1 | javac | 22 | the patch passed | | -1 | checkstyle | 23 | hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 274 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 938 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 21 | the patch passed | | +1 | findbugs | 53 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 183 | hbase-common in the patch passed. | | +1 | asflicense | 12 | The patch does not generate ASF License warnings. | | | | 2899 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/49/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/374 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 2a2f3f4f6df4 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh | | git revision | master / a6f065396a | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/49/artifact/out/diff-checkstyle-hbase-common.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/49/testReport/ | | Max. process+thread count | 289 (vs. ulimit of 1) | | modules | C: hbase-common U: hbase-common | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/49/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
