[GitHub] [hbase] Apache-HBase commented on issue #528: HBASE-22890 Verify the files when RegionServer is starting and BucketCache is in file mode
Apache-HBase commented on issue #528: HBASE-22890 Verify the files when RegionServer is starting and BucketCache is in file mode URL: https://github.com/apache/hbase/pull/528#issuecomment-528226829 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 0m 34s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. | ||| _ branch-1 Compile Tests _ | | :green_heart: | mvninstall | 8m 31s | branch-1 passed | | :green_heart: | compile | 0m 44s | branch-1 passed | | :green_heart: | checkstyle | 2m 5s | branch-1 passed | | :broken_heart: | shadedjars | 0m 14s | branch has 10 errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 0m 44s | branch-1 passed | | :blue_heart: | spotbugs | 2m 46s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 2m 44s | branch-1 passed | | :yellow_heart: | patch | 2m 51s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | :green_heart: | mvninstall | 1m 55s | the patch passed | | :green_heart: | compile | 0m 43s | the patch passed | | :green_heart: | javac | 0m 43s | the patch passed | | :broken_heart: | checkstyle | 1m 45s | hbase-server: The patch generated 3 new + 53 unchanged - 6 fixed = 56 total (was 59) | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :broken_heart: | shadedjars | 0m 11s | patch has 10 errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 4m 48s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | :green_heart: | javadoc | 0m 31s | the patch passed | | :broken_heart: | findbugs | 2m 24s | hbase-server generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) | ||| _ Other Tests _ | | :green_heart: | unit | 112m 25s | hbase-server in the patch passed. | | :green_heart: | asflicense | 0m 28s | The patch does not generate ASF License warnings. | | | | 143m 52s | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-server | | | org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.retrieveFromFile(int[]) ignores result of java.io.ObjectInputStream.read(byte[]) At BucketCache.java: At BucketCache.java:[line 1070] | | | org.apache.hadoop.hbase.io.hfile.bucket.PersistentIOEngineUtils.readPersistenceChecksum(String) ignores result of java.io.ObjectInputStream.read(byte[]) At PersistentIOEngineUtils.java: At PersistentIOEngineUtils.java:[line 53] | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-528/25/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/528 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 570a3fae3357 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-528/out/precommit/personality/provided.sh | | git revision | branch-1 / 157ffae | | Default Java | 1.8.0_222 | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-528/25/artifact/out/branch-shadedjars.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-528/25/artifact/out/diff-checkstyle-hbase-server.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-528/25/artifact/out/patch-shadedjars.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-528/25/artifact/out/new-findbugs-hbase-server.html | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-528/25/testReport/ | | Max. process+thread count | 4006 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-528/25/console | | versions | git=1.9.1 maven=3.0.5 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This
[GitHub] [hbase] Apache-HBase commented on issue #574: HBASE-22964 Fix flaky TestClusterRestartFailover and TestClusterResta…
Apache-HBase commented on issue #574: HBASE-22964 Fix flaky TestClusterRestartFailover and TestClusterResta… URL: https://github.com/apache/hbase/pull/574#issuecomment-528223176 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 0m 0s | Docker mode activated. | | :broken_heart: | patch | 2m 14s | https://github.com/apache/hbase/pull/574 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. | | Subsystem | Report/Notes | |--:|:-| | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-574/3/console | | versions | git=2.17.1 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22649) FileNotFoundException shown in UI when tried to access HFILE URL of a column family name have special char (e.g #)
[
https://issues.apache.org/jira/browse/HBASE-22649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16923098#comment-16923098
]
Y. SREENIVASULU REDDY commented on HBASE-22649:
---
[~apurtell], Thanks for looking into this issue.
I have attached the latest patches, and same addressed the comments as you
provided.
please review and provide your comments.
Thanks
> FileNotFoundException shown in UI when tried to access HFILE URL of a column
> family name have special char (e.g #)
> --
>
> Key: HBASE-22649
> URL: https://issues.apache.org/jira/browse/HBASE-22649
> Project: HBase
> Issue Type: Bug
> Components: UI
>Affects Versions: 3.0.0, 2.1.5, 1.3.5
>Reporter: Ashok shetty
>Assignee: Y. SREENIVASULU REDDY
>Priority: Major
> Fix For: 3.0.0, 1.3.6, 2.1.7
>
> Attachments: HBASE-22649.branch-1.002.patch,
> HBASE-22649.branch-1.003.patch, HBASE-22649.branch-1.patch,
> HBASE-22649.branch-2.patch, HBASE-22649.branch-2_002.patch,
> HBASE-22649.patch, HBASE-22649_002.patch
>
>
> 【Test step】：
> 1. create 'specialchar' ,'#'
> 2.put 'specialchar','r1','#:cq','1000'
> 3.flush 'specialchar'
> 4.put 'specialchar','r2','#:cq','1000'
> 5.flush 'specialchar'
>
> Once hfile is created, click the hfile link in UI.
> The following error is throwing.
> {noformat}
> java.io.FileNotFoundException: Path is not a file:
> /hbase/data/default/specialchar/df9d19830c562c4eeb3f8b396211d52d
> at
> org.apache.hadoop.hdfs.server.namenode.INodeFile.valueOf(INodeFile.java:90)
> at
> org.apache.hadoop.hdfs.server.namenode.INodeFile.valueOf(INodeFile.java:76)
> at
> org.apache.hadoop.hdfs.server.namenode.FSDirStatAndListingOp.getBlockLocations(FSDirStatAndListingOp.java:153)
> at
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlockLocations(FSNamesystem.java:1942)
> at
> org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.getBlockLocations(NameNodeRpcServer.java:739)
> at
> org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.getBlockLocations(ClientNamenodeProtocolServerSideTranslatorPB.java:432)
> at
> org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java)
> at
> org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:524)
> at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:991)
> at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:878)
> at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:824)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:422)
> at
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1729)
> at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2684)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Updated] (HBASE-22649) FileNotFoundException shown in UI when tried to access HFILE URL of a column family name have special char (e.g #)
[
https://issues.apache.org/jira/browse/HBASE-22649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Y. SREENIVASULU REDDY updated HBASE-22649:
--
Attachment: HBASE-22649_002.patch
> FileNotFoundException shown in UI when tried to access HFILE URL of a column
> family name have special char (e.g #)
> --
>
> Key: HBASE-22649
> URL: https://issues.apache.org/jira/browse/HBASE-22649
> Project: HBase
> Issue Type: Bug
> Components: UI
>Affects Versions: 3.0.0, 2.1.5, 1.3.5
>Reporter: Ashok shetty
>Assignee: Y. SREENIVASULU REDDY
>Priority: Major
> Fix For: 3.0.0, 1.3.6, 2.1.7
>
> Attachments: HBASE-22649.branch-1.002.patch,
> HBASE-22649.branch-1.003.patch, HBASE-22649.branch-1.patch,
> HBASE-22649.branch-2.patch, HBASE-22649.branch-2_002.patch,
> HBASE-22649.patch, HBASE-22649_002.patch
>
>
> 【Test step】：
> 1. create 'specialchar' ,'#'
> 2.put 'specialchar','r1','#:cq','1000'
> 3.flush 'specialchar'
> 4.put 'specialchar','r2','#:cq','1000'
> 5.flush 'specialchar'
>
> Once hfile is created, click the hfile link in UI.
> The following error is throwing.
> {noformat}
> java.io.FileNotFoundException: Path is not a file:
> /hbase/data/default/specialchar/df9d19830c562c4eeb3f8b396211d52d
> at
> org.apache.hadoop.hdfs.server.namenode.INodeFile.valueOf(INodeFile.java:90)
> at
> org.apache.hadoop.hdfs.server.namenode.INodeFile.valueOf(INodeFile.java:76)
> at
> org.apache.hadoop.hdfs.server.namenode.FSDirStatAndListingOp.getBlockLocations(FSDirStatAndListingOp.java:153)
> at
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlockLocations(FSNamesystem.java:1942)
> at
> org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.getBlockLocations(NameNodeRpcServer.java:739)
> at
> org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.getBlockLocations(ClientNamenodeProtocolServerSideTranslatorPB.java:432)
> at
> org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java)
> at
> org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:524)
> at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:991)
> at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:878)
> at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:824)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:422)
> at
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1729)
> at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2684)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Updated] (HBASE-22649) FileNotFoundException shown in UI when tried to access HFILE URL of a column family name have special char (e.g #)
[
https://issues.apache.org/jira/browse/HBASE-22649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Y. SREENIVASULU REDDY updated HBASE-22649:
--
Attachment: HBASE-22649.branch-1.003.patch
> FileNotFoundException shown in UI when tried to access HFILE URL of a column
> family name have special char (e.g #)
> --
>
> Key: HBASE-22649
> URL: https://issues.apache.org/jira/browse/HBASE-22649
> Project: HBase
> Issue Type: Bug
> Components: UI
>Affects Versions: 3.0.0, 2.1.5, 1.3.5
>Reporter: Ashok shetty
>Assignee: Y. SREENIVASULU REDDY
>Priority: Major
> Fix For: 3.0.0, 1.3.6, 2.1.7
>
> Attachments: HBASE-22649.branch-1.002.patch,
> HBASE-22649.branch-1.003.patch, HBASE-22649.branch-1.patch,
> HBASE-22649.branch-2.patch, HBASE-22649.branch-2_002.patch, HBASE-22649.patch
>
>
> 【Test step】：
> 1. create 'specialchar' ,'#'
> 2.put 'specialchar','r1','#:cq','1000'
> 3.flush 'specialchar'
> 4.put 'specialchar','r2','#:cq','1000'
> 5.flush 'specialchar'
>
> Once hfile is created, click the hfile link in UI.
> The following error is throwing.
> {noformat}
> java.io.FileNotFoundException: Path is not a file:
> /hbase/data/default/specialchar/df9d19830c562c4eeb3f8b396211d52d
> at
> org.apache.hadoop.hdfs.server.namenode.INodeFile.valueOf(INodeFile.java:90)
> at
> org.apache.hadoop.hdfs.server.namenode.INodeFile.valueOf(INodeFile.java:76)
> at
> org.apache.hadoop.hdfs.server.namenode.FSDirStatAndListingOp.getBlockLocations(FSDirStatAndListingOp.java:153)
> at
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlockLocations(FSNamesystem.java:1942)
> at
> org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.getBlockLocations(NameNodeRpcServer.java:739)
> at
> org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.getBlockLocations(ClientNamenodeProtocolServerSideTranslatorPB.java:432)
> at
> org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java)
> at
> org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:524)
> at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:991)
> at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:878)
> at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:824)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:422)
> at
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1729)
> at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2684)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Updated] (HBASE-22649) FileNotFoundException shown in UI when tried to access HFILE URL of a column family name have special char (e.g #)
[
https://issues.apache.org/jira/browse/HBASE-22649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Y. SREENIVASULU REDDY updated HBASE-22649:
--
Attachment: HBASE-22649.branch-2_002.patch
> FileNotFoundException shown in UI when tried to access HFILE URL of a column
> family name have special char (e.g #)
> --
>
> Key: HBASE-22649
> URL: https://issues.apache.org/jira/browse/HBASE-22649
> Project: HBase
> Issue Type: Bug
> Components: UI
>Affects Versions: 3.0.0, 2.1.5, 1.3.5
>Reporter: Ashok shetty
>Assignee: Y. SREENIVASULU REDDY
>Priority: Major
> Fix For: 3.0.0, 1.3.6, 2.1.7
>
> Attachments: HBASE-22649.branch-1.002.patch,
> HBASE-22649.branch-1.003.patch, HBASE-22649.branch-1.patch,
> HBASE-22649.branch-2.patch, HBASE-22649.branch-2_002.patch, HBASE-22649.patch
>
>
> 【Test step】：
> 1. create 'specialchar' ,'#'
> 2.put 'specialchar','r1','#:cq','1000'
> 3.flush 'specialchar'
> 4.put 'specialchar','r2','#:cq','1000'
> 5.flush 'specialchar'
>
> Once hfile is created, click the hfile link in UI.
> The following error is throwing.
> {noformat}
> java.io.FileNotFoundException: Path is not a file:
> /hbase/data/default/specialchar/df9d19830c562c4eeb3f8b396211d52d
> at
> org.apache.hadoop.hdfs.server.namenode.INodeFile.valueOf(INodeFile.java:90)
> at
> org.apache.hadoop.hdfs.server.namenode.INodeFile.valueOf(INodeFile.java:76)
> at
> org.apache.hadoop.hdfs.server.namenode.FSDirStatAndListingOp.getBlockLocations(FSDirStatAndListingOp.java:153)
> at
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlockLocations(FSNamesystem.java:1942)
> at
> org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.getBlockLocations(NameNodeRpcServer.java:739)
> at
> org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.getBlockLocations(ClientNamenodeProtocolServerSideTranslatorPB.java:432)
> at
> org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java)
> at
> org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:524)
> at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:991)
> at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:878)
> at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:824)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:422)
> at
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1729)
> at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2684)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [hbase] shardul-cr7 commented on a change in pull request #571: HBASE-20821 Re-creating a dropped namespace and contained table inherits previously set space quota settings
shardul-cr7 commented on a change in pull request #571: HBASE-20821 Re-creating
a dropped namespace and contained table inherits previously set space quota
settings
URL: https://github.com/apache/hbase/pull/571#discussion_r321080845
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/MasterQuotasObserver.java
##
@@ -78,6 +79,20 @@ public void postDeleteTable(
admin.setQuota(settings);
}
}
+} else if (quotasAtNamespace != null) {
+ // If quota present at namespace level remove the table entry from
'hbase:quota'
Review comment:
Because even though table is dropped it's entry is still present in the
'hbase:quota' table because of the namespace quota. If we create another table
with same name inside that namespace it inherits the earlier quota settings. So
during dropping the table we need to remove that entry/setting from the
hbase:quota for our table even though quota was present at namespace level.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-22930) Set unique name to longCompactions/shortCompactions threads
[
https://issues.apache.org/jira/browse/HBASE-22930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16923043#comment-16923043
]
Hudson commented on HBASE-22930:
Results for branch branch-2.1
[build #1562 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1562/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1562//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1562//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1562//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 3. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1562//artifact/output-integration/hadoop-3.log].
(note that this means we didn't check the Hadoop 3 shaded client)
> Set unique name to longCompactions/shortCompactions threads
> ---
>
> Key: HBASE-22930
> URL: https://issues.apache.org/jira/browse/HBASE-22930
> Project: HBase
> Issue Type: Improvement
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>
>
> Sometime observed multiple compaction threads have the same name which is
> misleading while analysing the log.
> Currently we just append the current timestamp which can be same for multiple
> threads,
> [https://github.com/apache/hbase/blob/ec68bf30ba91ea7484d3b56b0809ff5434f9406e/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java#L144]
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22890) Verify the files when RegionServer is starting and BucketCache is in file mode
[ https://issues.apache.org/jira/browse/HBASE-22890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16923039#comment-16923039 ] zbq.dean commented on HBASE-22890: -- Ping [~anoop.hbase], could you give some more suggests? > Verify the files when RegionServer is starting and BucketCache is in file mode > -- > > Key: HBASE-22890 > URL: https://issues.apache.org/jira/browse/HBASE-22890 > Project: HBase > Issue Type: Bug > Components: BucketCache >Affects Versions: 1.4.6, 1.4.10, 1.3.5 >Reporter: zbq.dean >Priority: Major > Attachments: HBASE-22890.branch-1.0001.patch > > > We use FileIOEngine in BucketCache and have configured > . If the RegionServer is stopped, and the > cache data file or the backingMap persistence file is deleted or changed > before the RegionServer is restarted. When restart RegionServer, the > backingMap and cache data are Inconsistent, and get or scan command will get > IOException like follows: > bucket.BucketCache: Failed reading block > 18951416e2ca4e8bbc11523f4f5ea576_1125745279 from bucket cache > java.io.IOException: Invalid HFile block magic: > \x00\x00\x00\x00\x00\x00\x00\x00 > at org.apache.hadoop.hbase.io.hfile.BlockType.parse(BlockType.java:154) > at org.apache.hadoop.hbase.io.hfile.BlockType.read(BlockType.java:167) > at org.apache.hadoop.hbase.io.hfile.HFileBlock.(HFileBlock.java:347) > at > org.apache.hadoop.hbase.io.hfile.HFileBlock$1.deserialize(HFileBlock.java:247) > at > org.apache.hadoop.hbase.io.hfile.HFileBlock$1.deserialize(HFileBlock.java:226) > at > org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.getBlock(BucketCache.java:514) > .. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase] brfrn169 commented on issue #476: HBASE-11062 hbtop
brfrn169 commented on issue #476: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/476#issuecomment-528176572 It looks like the QA is okay. @saintstack Could you please take a look at this? As Josh, Sean and Andrew have approved it, If you are okay with it, I will commit it. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase
[
https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922992#comment-16922992
]
Hudson commented on HBASE-22514:
Results for branch HBASE-22514
[build #92 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/92/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/92//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/92//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/92//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/92//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Move rsgroup feature into core of HBase
> ---
>
> Key: HBASE-22514
> URL: https://issues.apache.org/jira/browse/HBASE-22514
> Project: HBase
> Issue Type: Umbrella
> Components: Admin, Client, rsgroup
>Reporter: Yechao Chen
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22514.master.001.patch,
> image-2019-05-31-18-25-38-217.png
>
>
> The class RSGroupAdminClient is not public
> we need to use java api RSGroupAdminClient to manager RSG
> so RSGroupAdminClient should be public
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [hbase] Apache-HBase commented on issue #585: HBASE-22930 Set unique name to longCompactions/shortCompactions/split threads
Apache-HBase commented on issue #585: HBASE-22930 Set unique name to longCompactions/shortCompactions/split threads URL: https://github.com/apache/hbase/pull/585#issuecomment-528163977 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 1m 21s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :yellow_heart: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | :green_heart: | mvninstall | 6m 19s | master passed | | :green_heart: | compile | 1m 4s | master passed | | :green_heart: | checkstyle | 1m 35s | master passed | | :green_heart: | shadedjars | 5m 12s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 0m 40s | master passed | | :blue_heart: | spotbugs | 4m 48s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 4m 46s | master passed | ||| _ Patch Compile Tests _ | | :green_heart: | mvninstall | 5m 33s | the patch passed | | :green_heart: | compile | 0m 58s | the patch passed | | :green_heart: | javac | 0m 58s | the patch passed | | :green_heart: | checkstyle | 1m 28s | the patch passed | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | shadedjars | 5m 1s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 17m 30s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :green_heart: | javadoc | 0m 37s | the patch passed | | :green_heart: | findbugs | 4m 24s | the patch passed | ||| _ Other Tests _ | | :broken_heart: | unit | 242m 2s | hbase-server in the patch failed. | | :green_heart: | asflicense | 0m 27s | The patch does not generate ASF License warnings. | | | | 305m 51s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController | | | hadoop.hbase.quotas.TestQuotaAdmin | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-585/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/585 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux b3091ed2a617 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-585/out/precommit/personality/provided.sh | | git revision | master / 0d338a1820 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-585/1/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-585/1/testReport/ | | Max. process+thread count | 4966 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-585/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 commented on issue #584: HBASE-22927 Upgrade mockito version for Java 11 compatibility
Apache9 commented on issue #584: HBASE-22927 Upgrade mockito version for Java 11 compatibility URL: https://github.com/apache/hbase/pull/584#issuecomment-528162138 > [INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (enforce-maven-version) @ hbase-shaded-check-invariants --- > [INFO] Restricted to JDK 1.8 yet net.bytebuddy:byte-buddy:jar:1.9.0:provided contains module-info.class targeted to JDK 1.9 > [INFO] Restricted to JDK 1.8 yet net.bytebuddy:byte-buddy-agent:jar:1.9.0:provided contains module-info.class targeted to JDK 1.9 > [WARNING] Rule 1: org.apache.maven.plugins.enforcer.EnforceBytecodeVersion failed with message: > HBase has unsupported dependencies. > HBase requires that all dependencies be compiled with version 1.8 or earlier > of the JDK to properly build from source. You appear to be using a newer dependency. You can use > either "mvn -version" or "mvn enforcer:display-info" to verify what version is active. > Non-release builds can temporarily build with a newer JDK version by setting the > 'compileSource' property (eg. mvn -DcompileSource=1.8 clean package). > Found Banned Dependency: net.bytebuddy:byte-buddy:jar:1.9.0 > Found Banned Dependency: net.bytebuddy:byte-buddy-agent:jar:1.9.0 So the new mockito just drops the support for java 8? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22927) Upgrade mockito version for Java 11 compatibility
[ https://issues.apache.org/jira/browse/HBASE-22927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22927: -- Parent: HBASE-22972 Issue Type: Sub-task (was: Task) > Upgrade mockito version for Java 11 compatibility > - > > Key: HBASE-22927 > URL: https://issues.apache.org/jira/browse/HBASE-22927 > Project: HBase > Issue Type: Sub-task >Reporter: Sakthi >Assignee: Rabi Kumar K C >Priority: Major > Labels: jdk11 > > Pasting the discussion from HBASE-22534 here: > "Currently mockito-core version is at 2.1.0. According to > [https://github.com/mockito/mockito/blob/release/2.x/doc/release-notes/official.md], > looks like Java 11 compatibility was introduced in 2.19+. And 2.23.2 claims > to have full java 11 support after byte-buddy fix etc." -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-22927) Upgrade mockito version for Java 11 compatibility
[ https://issues.apache.org/jira/browse/HBASE-22927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22927: -- Labels: jdk11 (was: ) > Upgrade mockito version for Java 11 compatibility > - > > Key: HBASE-22927 > URL: https://issues.apache.org/jira/browse/HBASE-22927 > Project: HBase > Issue Type: Task >Reporter: Sakthi >Assignee: Rabi Kumar K C >Priority: Major > Labels: jdk11 > > Pasting the discussion from HBASE-22534 here: > "Currently mockito-core version is at 2.1.0. According to > [https://github.com/mockito/mockito/blob/release/2.x/doc/release-notes/official.md], > looks like Java 11 compatibility was introduced in 2.19+. And 2.23.2 claims > to have full java 11 support after byte-buddy fix etc." -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase] chenxu14 commented on issue #583: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
chenxu14 commented on issue #583: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read URL: https://github.com/apache/hbase/pull/583#issuecomment-528149628 TestMasterShutdown seems not related, let's fix the failed UT This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #578: HBASE-22699 refactor isMetaClearingException
Apache-HBase commented on issue #578: HBASE-22699 refactor isMetaClearingException URL: https://github.com/apache/hbase/pull/578#issuecomment-528142161 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 1m 6s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ branch-2 Compile Tests _ | | :blue_heart: | mvndep | 0m 15s | Maven dependency ordering for branch | | :green_heart: | mvninstall | 5m 17s | branch-2 passed | | :green_heart: | compile | 1m 22s | branch-2 passed | | :green_heart: | checkstyle | 2m 4s | branch-2 passed | | :green_heart: | shadedjars | 4m 39s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 1m 5s | branch-2 passed | | :blue_heart: | spotbugs | 3m 26s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 4m 43s | branch-2 passed | ||| _ Patch Compile Tests _ | | :blue_heart: | mvndep | 0m 15s | Maven dependency ordering for patch | | :green_heart: | mvninstall | 4m 48s | the patch passed | | :green_heart: | compile | 1m 23s | the patch passed | | :green_heart: | javac | 1m 23s | the patch passed | | :green_heart: | checkstyle | 1m 51s | the patch passed | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | shadedjars | 4m 8s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 15m 5s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :green_heart: | javadoc | 0m 59s | the patch passed | | :green_heart: | findbugs | 4m 37s | the patch passed | ||| _ Other Tests _ | | :broken_heart: | unit | 3m 37s | hbase-client in the patch failed. | | :broken_heart: | unit | 292m 51s | hbase-server in the patch failed. | | :green_heart: | asflicense | 1m 5s | The patch does not generate ASF License warnings. | | | | 357m 28s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestAsyncProcess | | | hadoop.hbase.client.replication.TestReplicationAdminWithClusters | | | hadoop.hbase.client.TestFromClientSide3 | | | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory | | | hadoop.hbase.client.TestAsyncTableAdminApi | | | hadoop.hbase.replication.TestReplicationSmallTests | | | hadoop.hbase.client.TestCloneSnapshotFromClientNormal | | | hadoop.hbase.client.TestFromClientSideWithCoprocessor | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-578/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/578 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 2b2425832026 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-578/out/precommit/personality/provided.sh | | git revision | branch-2 / aeacfd3d59 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-578/2/artifact/out/patch-unit-hbase-client.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-578/2/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-578/2/testReport/ | | Max. process+thread count | 4978 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-578/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra
[GitHub] [hbase] Apache-HBase commented on issue #584: HBASE-22927 Upgrade mockito version for Java 11 compatibility
Apache-HBase commented on issue #584: HBASE-22927 Upgrade mockito version for Java 11 compatibility URL: https://github.com/apache/hbase/pull/584#issuecomment-528142310 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 3m 46s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :yellow_heart: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | :green_heart: | mvninstall | 6m 18s | master passed | | :green_heart: | compile | 3m 20s | master passed | | :green_heart: | shadedjars | 4m 48s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 2m 51s | master passed | ||| _ Patch Compile Tests _ | | :green_heart: | mvninstall | 4m 56s | the patch passed | | :green_heart: | compile | 2m 55s | the patch passed | | :green_heart: | javac | 2m 55s | the patch passed | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | :broken_heart: | shadedjars | 4m 27s | patch has 10 errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 15m 29s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :green_heart: | javadoc | 2m 48s | the patch passed | ||| _ Other Tests _ | | :broken_heart: | unit | 311m 11s | root in the patch failed. | | :green_heart: | asflicense | 0m 41s | The patch does not generate ASF License warnings. | | | | 369m 43s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.client.TestFromClientSideWithCoprocessor | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-584/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/584 | | Optional Tests | dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile | | uname | Linux 742b07b3fcec 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-584/out/precommit/personality/provided.sh | | git revision | master / 0d338a1820 | | Default Java | 1.8.0_181 | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-584/1/artifact/out/patch-shadedjars.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-584/1/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-584/1/testReport/ | | Max. process+thread count | 4921 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-584/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary
[
https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922950#comment-16922950
]
HBase QA commented on HBASE-22804:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
43s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
16s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
39s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
27s{color} | {color:green} branch-1 passed {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 0m
13s{color} | {color:red} branch has 10 errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} branch-1 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
21s{color} | {color:red} hbase-server: The patch generated 1 new + 67 unchanged
- 2 fixed = 68 total (was 69) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 0m
12s{color} | {color:red} patch has 10 errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
4m 31s{color} | {color:green} Patch does not cause any errors with Hadoop 2.8.5
2.9.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
28s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}111m
31s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
28s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}135m 8s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/PreCommit-HBASE-Build/863/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22804 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12979475/HBASE-22804.branch-1.007.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 9c55fe5a3629 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-1 / 157ffae |
| maven | version: Apache Maven 3.0.5 |
| Default Java | 1.8.0_222 |
| shadedjars |
https://builds.apache.org/job/PreCommit-HBASE-Build/863/artifact/patchprocess/branch-shadedjars.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/863/artifact/patchprocess/diff-checkstyle-hbase-server.txt
|
| shadedjars |
https://builds.apache.org/job/PreCommit-HBASE-Build/863/artifact/patchprocess/patch-shadedjars.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/863/testReport/ |
| Max. process+thread count | 4424 (vs. ulimit of 1) |
| modules | C: hbase-server U: hbas
[GitHub] [hbase] Apache-HBase commented on issue #528: HBASE-22890 Verify the files when RegionServer is starting and BucketCache is in file mode
Apache-HBase commented on issue #528: HBASE-22890 Verify the files when RegionServer is starting and BucketCache is in file mode URL: https://github.com/apache/hbase/pull/528#issuecomment-528139126 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 42m 2s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. | ||| _ branch-1 Compile Tests _ | | :green_heart: | mvninstall | 8m 18s | branch-1 passed | | :green_heart: | compile | 0m 44s | branch-1 passed | | :green_heart: | checkstyle | 1m 41s | branch-1 passed | | :broken_heart: | shadedjars | 0m 14s | branch has 10 errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 0m 38s | branch-1 passed | | :blue_heart: | spotbugs | 2m 24s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 2m 22s | branch-1 passed | | :yellow_heart: | patch | 2m 29s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | :green_heart: | mvninstall | 1m 47s | the patch passed | | :green_heart: | compile | 0m 39s | the patch passed | | :green_heart: | javac | 0m 39s | the patch passed | | :broken_heart: | checkstyle | 1m 27s | hbase-server: The patch generated 13 new + 53 unchanged - 6 fixed = 66 total (was 59) | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :broken_heart: | shadedjars | 0m 12s | patch has 10 errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 4m 44s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | :green_heart: | javadoc | 0m 33s | the patch passed | | :broken_heart: | findbugs | 2m 41s | hbase-server generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) | ||| _ Other Tests _ | | :green_heart: | unit | 110m 51s | hbase-server in the patch passed. | | :green_heart: | asflicense | 0m 31s | The patch does not generate ASF License warnings. | | | | 182m 50s | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-server | | | org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.retrieveFromFile(int[]) ignores result of java.io.ObjectInputStream.read(byte[]) At BucketCache.java: At BucketCache.java:[line 1070] | | | org.apache.hadoop.hbase.io.hfile.bucket.PersistentIOEngineUtils.readPersistenceChecksum(String) ignores result of java.io.ObjectInputStream.read(byte[]) At PersistentIOEngineUtils.java: At PersistentIOEngineUtils.java:[line 53] | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-528/24/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/528 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 230b41e1468d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-528/out/precommit/personality/provided.sh | | git revision | branch-1 / 157ffae | | Default Java | 1.8.0_222 | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-528/24/artifact/out/branch-shadedjars.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-528/24/artifact/out/diff-checkstyle-hbase-server.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-528/24/artifact/out/patch-shadedjars.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-528/24/artifact/out/new-findbugs-hbase-server.html | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-528/24/testReport/ | | Max. process+thread count | 4553 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-528/24/console | | versions | git=1.9.1 maven=3.0.5 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This
[jira] [Commented] (HBASE-22749) Distributed MOB compactions
[ https://issues.apache.org/jira/browse/HBASE-22749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922943#comment-16922943 ] Vladimir Rodionov commented on HBASE-22749: --- Updated design document to v2.2. Added totally new MOB compaction algorithm section, which now can limit for sure, overall Read/Write I/O amplification (major concern so far) The initial patch is almost done, just need to fix the algorithm and run tests. > Distributed MOB compactions > > > Key: HBASE-22749 > URL: https://issues.apache.org/jira/browse/HBASE-22749 > Project: HBase > Issue Type: New Feature > Components: mob >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Major > Attachments: HBase-MOB-2.0-v1.pdf, HBase-MOB-2.0-v2.1.pdf, > HBase-MOB-2.0-v2.2.pdf, HBase-MOB-2.0-v2.pdf > > > There are several drawbacks in the original MOB 1.0 (Moderate Object > Storage) implementation, which can limit the adoption of the MOB feature: > # MOB compactions are executed in a Master as a chore, which limits > scalability because all I/O goes through a single HBase Master server. > # Yarn/Mapreduce framework is required to run MOB compactions in a scalable > way, but this won’t work in a stand-alone HBase cluster. > # Two separate compactors for MOB and for regular store files and their > interactions can result in a data loss (see HBASE-22075) > The design goals for MOB 2.0 were to provide 100% MOB 1.0 - compatible > implementation, which is free of the above drawbacks and can be used as a > drop in replacement in existing MOB deployments. So, these are design goals > of a MOB 2.0: > # Make MOB compactions scalable without relying on Yarn/Mapreduce framework > # Provide unified compactor for both MOB and regular store files > # Make it more robust especially w.r.t. to data losses. > # Simplify and reduce the overall MOB code. > # Provide 100% compatible implementation with MOB 1.0. > # No migration of data should be required between MOB 1.0 and MOB 2.0 - just > software upgrade. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-22749) Distributed MOB compactions
[ https://issues.apache.org/jira/browse/HBASE-22749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Rodionov updated HBASE-22749: -- Attachment: HBase-MOB-2.0-v2.2.pdf > Distributed MOB compactions > > > Key: HBASE-22749 > URL: https://issues.apache.org/jira/browse/HBASE-22749 > Project: HBase > Issue Type: New Feature > Components: mob >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Major > Attachments: HBase-MOB-2.0-v1.pdf, HBase-MOB-2.0-v2.1.pdf, > HBase-MOB-2.0-v2.2.pdf, HBase-MOB-2.0-v2.pdf > > > There are several drawbacks in the original MOB 1.0 (Moderate Object > Storage) implementation, which can limit the adoption of the MOB feature: > # MOB compactions are executed in a Master as a chore, which limits > scalability because all I/O goes through a single HBase Master server. > # Yarn/Mapreduce framework is required to run MOB compactions in a scalable > way, but this won’t work in a stand-alone HBase cluster. > # Two separate compactors for MOB and for regular store files and their > interactions can result in a data loss (see HBASE-22075) > The design goals for MOB 2.0 were to provide 100% MOB 1.0 - compatible > implementation, which is free of the above drawbacks and can be used as a > drop in replacement in existing MOB deployments. So, these are design goals > of a MOB 2.0: > # Make MOB compactions scalable without relying on Yarn/Mapreduce framework > # Provide unified compactor for both MOB and regular store files > # Make it more robust especially w.r.t. to data losses. > # Simplify and reduce the overall MOB code. > # Provide 100% compatible implementation with MOB 1.0. > # No migration of data should be required between MOB 1.0 and MOB 2.0 - just > software upgrade. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase] Apache-HBase commented on issue #583: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
Apache-HBase commented on issue #583: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read URL: https://github.com/apache/hbase/pull/583#issuecomment-528127117 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 1m 6s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | :blue_heart: | mvndep | 0m 33s | Maven dependency ordering for branch | | :green_heart: | mvninstall | 5m 41s | master passed | | :green_heart: | compile | 1m 19s | master passed | | :green_heart: | checkstyle | 1m 57s | master passed | | :green_heart: | shadedjars | 4m 54s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 0m 56s | master passed | | :blue_heart: | spotbugs | 4m 19s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 5m 6s | master passed | ||| _ Patch Compile Tests _ | | :blue_heart: | mvndep | 0m 13s | Maven dependency ordering for patch | | :green_heart: | mvninstall | 5m 21s | the patch passed | | :green_heart: | compile | 1m 20s | the patch passed | | :green_heart: | javac | 1m 20s | the patch passed | | :green_heart: | checkstyle | 0m 27s | hbase-common: The patch generated 0 new + 48 unchanged - 2 fixed = 48 total (was 50) | | :green_heart: | checkstyle | 1m 28s | The patch passed checkstyle in hbase-server | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | shadedjars | 4m 57s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 17m 5s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :green_heart: | javadoc | 0m 55s | the patch passed | | :green_heart: | findbugs | 5m 28s | the patch passed | ||| _ Other Tests _ | | :broken_heart: | unit | 2m 43s | hbase-common in the patch failed. | | :broken_heart: | unit | 245m 32s | hbase-server in the patch failed. | | :green_heart: | asflicense | 0m 51s | The patch does not generate ASF License warnings. | | | | 314m 49s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.io.TestByteBuffAllocator | | | hadoop.hbase.io.hfile.bucket.TestBucketCacheRefCnt | | | hadoop.hbase.master.TestMasterShutdown | | | hadoop.hbase.io.hfile.bucket.TestBucketCache | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-583/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/583 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 8a65a742a1a5 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-583/out/precommit/personality/provided.sh | | git revision | master / 0d338a1820 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-583/1/artifact/out/patch-unit-hbase-common.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-583/1/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-583/1/testReport/ | | Max. process+thread count | 5312 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-583/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-22974) Show Space quotas in the newly added "Quotas" section in the web UI
Sakthi created HBASE-22974: -- Summary: Show Space quotas in the newly added "Quotas" section in the web UI Key: HBASE-22974 URL: https://issues.apache.org/jira/browse/HBASE-22974 Project: HBase Issue Type: Task Reporter: Sakthi Assignee: Sakthi HBASE-22945 added a "Quotas" section in the web ui for the table/user throttles. Let's make this a unified place to show all the quotas in hbase. This Jira tracks the addition of space quotas info in this web ui. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22945) Show quota infos in master UI
[ https://issues.apache.org/jira/browse/HBASE-22945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922926#comment-16922926 ] Sakthi commented on HBASE-22945: Let me create a sub-Jira to show all the space quotas info as well in this newly added web ui, [~Yi Mei] > Show quota infos in master UI > - > > Key: HBASE-22945 > URL: https://issues.apache.org/jira/browse/HBASE-22945 > Project: HBase > Issue Type: Sub-task > Components: master, UI >Reporter: Yi Mei >Assignee: Yi Mei >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.1 > > Attachments: 1.png, 2.png > > > Add a page in master UI to show the following quota infos: > if rpc throttle is enabled; > if exceed throttle quota is enabled; > namespace throtlles; > user throttles. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase] jatsakthi commented on issue #510: HBASE-22878 Show table throttle quotas in table jsp
jatsakthi commented on issue #510: HBASE-22878 Show table throttle quotas in table jsp URL: https://github.com/apache/hbase/pull/510#issuecomment-528124722 Agree with you @mymeiyi This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22930) Set unique name to longCompactions/shortCompactions threads
[
https://issues.apache.org/jira/browse/HBASE-22930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922892#comment-16922892
]
Hudson commented on HBASE-22930:
Results for branch master
[build #1403 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1403/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1403//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1403//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1403//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Set unique name to longCompactions/shortCompactions threads
> ---
>
> Key: HBASE-22930
> URL: https://issues.apache.org/jira/browse/HBASE-22930
> Project: HBase
> Issue Type: Improvement
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>
>
> Sometime observed multiple compaction threads have the same name which is
> misleading while analysing the log.
> Currently we just append the current timestamp which can be same for multiple
> threads,
> [https://github.com/apache/hbase/blob/ec68bf30ba91ea7484d3b56b0809ff5434f9406e/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java#L144]
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22930) Set unique name to longCompactions/shortCompactions threads
[
https://issues.apache.org/jira/browse/HBASE-22930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922896#comment-16922896
]
Hudson commented on HBASE-22930:
Results for branch branch-2.2
[build #576 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/576/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/576//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/576//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/576//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Set unique name to longCompactions/shortCompactions threads
> ---
>
> Key: HBASE-22930
> URL: https://issues.apache.org/jira/browse/HBASE-22930
> Project: HBase
> Issue Type: Improvement
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>
>
> Sometime observed multiple compaction threads have the same name which is
> misleading while analysing the log.
> Currently we just append the current timestamp which can be same for multiple
> threads,
> [https://github.com/apache/hbase/blob/ec68bf30ba91ea7484d3b56b0809ff5434f9406e/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java#L144]
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22930) Set unique name to longCompactions/shortCompactions threads
[
https://issues.apache.org/jira/browse/HBASE-22930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922893#comment-16922893
]
Hudson commented on HBASE-22930:
Results for branch branch-2.1
[build #1561 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1561/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1561//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1561//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1561//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Set unique name to longCompactions/shortCompactions threads
> ---
>
> Key: HBASE-22930
> URL: https://issues.apache.org/jira/browse/HBASE-22930
> Project: HBase
> Issue Type: Improvement
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>
>
> Sometime observed multiple compaction threads have the same name which is
> misleading while analysing the log.
> Currently we just append the current timestamp which can be same for multiple
> threads,
> [https://github.com/apache/hbase/blob/ec68bf30ba91ea7484d3b56b0809ff5434f9406e/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java#L144]
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [hbase-operator-tools] asf-ci commented on issue #18: HBASE-22567 - HBCK2 addMissingRegionsToMeta
asf-ci commented on issue #18: HBASE-22567 - HBCK2 addMissingRegionsToMeta URL: https://github.com/apache/hbase-operator-tools/pull/18#issuecomment-528109208 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-HBASE-OPERATOR-TOOLS-Build/84/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-21879) Read HFile's block to ByteBuffer directly instead of to byte for reducing young gc purpose
[
https://issues.apache.org/jira/browse/HBASE-21879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922887#comment-16922887
]
Hudson commented on HBASE-21879:
Results for branch HBASE-21879
[build #230 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/230/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/230//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/230//console].
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/230//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Read HFile's block to ByteBuffer directly instead of to byte for reducing
> young gc purpose
> --
>
> Key: HBASE-21879
> URL: https://issues.apache.org/jira/browse/HBASE-21879
> Project: HBase
> Issue Type: Improvement
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments: HBASE-21879.v1.patch, HBASE-21879.v1.patch,
> QPS-latencies-before-HBASE-21879.png, gc-data-before-HBASE-21879.png
>
>
> In HFileBlock#readBlockDataInternal, we have the following:
> {code}
> @VisibleForTesting
> protected HFileBlock readBlockDataInternal(FSDataInputStream is, long offset,
> long onDiskSizeWithHeaderL, boolean pread, boolean verifyChecksum,
> boolean updateMetrics)
> throws IOException {
> // .
> // TODO: Make this ByteBuffer-based. Will make it easier to go to HDFS with
> BBPool (offheap).
> byte [] onDiskBlock = new byte[onDiskSizeWithHeader + hdrSize];
> int nextBlockOnDiskSize = readAtOffset(is, onDiskBlock, preReadHeaderSize,
> onDiskSizeWithHeader - preReadHeaderSize, true, offset +
> preReadHeaderSize, pread);
> if (headerBuf != null) {
> // ...
> }
> // ...
> }
> {code}
> In the read path, we still read the block from hfile to on-heap byte[], then
> copy the on-heap byte[] to offheap bucket cache asynchronously, and in my
> 100% get performance test, I also observed some frequent young gc, The
> largest memory footprint in the young gen should be the on-heap block byte[].
> In fact, we can read HFile's block to ByteBuffer directly instead of to
> byte[] for reducing young gc purpose. we did not implement this before,
> because no ByteBuffer reading interface in the older HDFS client, but 2.7+
> has supported this now, so we can fix this now. I think.
> Will provide an patch and some perf-comparison for this.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [hbase-operator-tools] asf-ci commented on issue #18: HBASE-22567 - HBCK2 addMissingRegionsToMeta
asf-ci commented on issue #18: HBASE-22567 - HBCK2 addMissingRegionsToMeta URL: https://github.com/apache/hbase-operator-tools/pull/18#issuecomment-528111715 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-HBASE-OPERATOR-TOOLS-Build/85/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22930) Set unique name to longCompactions/shortCompactions threads
[
https://issues.apache.org/jira/browse/HBASE-22930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922884#comment-16922884
]
Hudson commented on HBASE-22930:
Results for branch branch-2
[build #2228 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2228/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2228//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2228//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2228//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Set unique name to longCompactions/shortCompactions threads
> ---
>
> Key: HBASE-22930
> URL: https://issues.apache.org/jira/browse/HBASE-22930
> Project: HBase
> Issue Type: Improvement
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>
>
> Sometime observed multiple compaction threads have the same name which is
> misleading while analysing the log.
> Currently we just append the current timestamp which can be same for multiple
> threads,
> [https://github.com/apache/hbase/blob/ec68bf30ba91ea7484d3b56b0809ff5434f9406e/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java#L144]
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22930) Set unique name to longCompactions/shortCompactions threads
[
https://issues.apache.org/jira/browse/HBASE-22930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922872#comment-16922872
]
Hudson commented on HBASE-22930:
Results for branch branch-2.2
[build #575 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/575/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/575//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/575//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/575//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Set unique name to longCompactions/shortCompactions threads
> ---
>
> Key: HBASE-22930
> URL: https://issues.apache.org/jira/browse/HBASE-22930
> Project: HBase
> Issue Type: Improvement
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>
>
> Sometime observed multiple compaction threads have the same name which is
> misleading while analysing the log.
> Currently we just append the current timestamp which can be same for multiple
> threads,
> [https://github.com/apache/hbase/blob/ec68bf30ba91ea7484d3b56b0809ff5434f9406e/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java#L144]
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22930) Set unique name to longCompactions/shortCompactions threads
[
https://issues.apache.org/jira/browse/HBASE-22930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922867#comment-16922867
]
Hudson commented on HBASE-22930:
Results for branch master
[build #1402 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1402/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1402//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1402//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1402//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/master/1402//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Set unique name to longCompactions/shortCompactions threads
> ---
>
> Key: HBASE-22930
> URL: https://issues.apache.org/jira/browse/HBASE-22930
> Project: HBase
> Issue Type: Improvement
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>
>
> Sometime observed multiple compaction threads have the same name which is
> misleading while analysing the log.
> Currently we just append the current timestamp which can be same for multiple
> threads,
> [https://github.com/apache/hbase/blob/ec68bf30ba91ea7484d3b56b0809ff5434f9406e/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java#L144]
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22930) Set unique name to longCompactions/shortCompactions threads
[
https://issues.apache.org/jira/browse/HBASE-22930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922864#comment-16922864
]
Hudson commented on HBASE-22930:
Results for branch branch-2
[build #2227 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2227/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2227//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2227//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2227//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Set unique name to longCompactions/shortCompactions threads
> ---
>
> Key: HBASE-22930
> URL: https://issues.apache.org/jira/browse/HBASE-22930
> Project: HBase
> Issue Type: Improvement
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>
>
> Sometime observed multiple compaction threads have the same name which is
> misleading while analysing the log.
> Currently we just append the current timestamp which can be same for multiple
> threads,
> [https://github.com/apache/hbase/blob/ec68bf30ba91ea7484d3b56b0809ff5434f9406e/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java#L144]
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [hbase-operator-tools] asf-ci commented on issue #18: HBASE-22567 - HBCK2 addMissingRegionsToMeta
asf-ci commented on issue #18: HBASE-22567 - HBCK2 addMissingRegionsToMeta URL: https://github.com/apache/hbase-operator-tools/pull/18#issuecomment-528084625 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-HBASE-OPERATOR-TOOLS-Build/83/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #580: [HBASE-22874] Canary should not be IA.Public
Apache-HBase commented on issue #580: [HBASE-22874] Canary should not be IA.Public URL: https://github.com/apache/hbase/pull/580#issuecomment-528084341 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 82 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 401 | master passed | | +1 | compile | 68 | master passed | | +1 | checkstyle | 94 | master passed | | +1 | shadedjars | 304 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 40 | master passed | | 0 | spotbugs | 276 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 273 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 331 | the patch passed | | +1 | compile | 60 | the patch passed | | +1 | javac | 60 | the patch passed | | -1 | checkstyle | 89 | hbase-server: The patch generated 2 new + 21 unchanged - 2 fixed = 23 total (was 23) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 323 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1108 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 37 | the patch passed | | +1 | findbugs | 282 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 16255 | hbase-server in the patch failed. | | +1 | asflicense | 27 | The patch does not generate ASF License warnings. | | | | 20185 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestFromClientSide | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-580/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/580 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 12056470573a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-580/out/precommit/personality/provided.sh | | git revision | master / dfe5280d0c | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-580/1/artifact/out/diff-checkstyle-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-580/1/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-580/1/testReport/ | | Max. process+thread count | 4621 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-580/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22724) Add a emoji on the vote table for pre commit result on github
[
https://issues.apache.org/jira/browse/HBASE-22724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922857#comment-16922857
]
Hudson commented on HBASE-22724:
Results for branch branch-1
[build #1045 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1045/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1045//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1045//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1045//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Add a emoji on the vote table for pre commit result on github
> -
>
> Key: HBASE-22724
> URL: https://issues.apache.org/jira/browse/HBASE-22724
> Project: HBase
> Issue Type: Improvement
> Components: build, test
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 1.3.6, 1.4.11, 2.1.7
>
>
> [~zghaobac] said that the current vote table on github is not good enough, as
> the colors are almost the same, it is not easy to find out which line is
> broken.
> Since github can not change the color of the text, he suggested that we add a
> column at the left most with some emojis to better notify the developpers.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22961) Deprecate hbck1 in core
[
https://issues.apache.org/jira/browse/HBASE-22961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922853#comment-16922853
]
Hudson commented on HBASE-22961:
Results for branch master
[build #1401 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1401/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1401//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1401//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1401//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Deprecate hbck1 in core
> ---
>
> Key: HBASE-22961
> URL: https://issues.apache.org/jira/browse/HBASE-22961
> Project: HBase
> Issue Type: Bug
> Components: hbck
>Reporter: stack
>Assignee: stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.7
>
> Attachments: 0001-HBASE-22961-Deprecate-hbck1-in-core.patch,
> 0001-HBASE-22961-Deprecate-hbck1-in-core.patch, HBASE-22961.master.001.patch,
> HBASE-22961.master.002.patch
>
>
> HBaseFsck is just noted as read-only (along w/ noting that it is unreliable
> and shouldn't be used). Need to add deprecation so can be removed especially
> now that hbck2 has been built up and that the bulk of hbck1 is not
> rejiggered, repurposed to serve hbck2 and living out in hbase-operator-tools.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22954) Whitelist net.java.dev.jna which got pulled in through Hadoop 3.3.0
[
https://issues.apache.org/jira/browse/HBASE-22954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922852#comment-16922852
]
Hudson commented on HBASE-22954:
Results for branch master
[build #1401 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1401/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1401//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1401//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1401//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Whitelist net.java.dev.jna which got pulled in through Hadoop 3.3.0
> ---
>
> Key: HBASE-22954
> URL: https://issues.apache.org/jira/browse/HBASE-22954
> Project: HBase
> Issue Type: Improvement
> Components: community, hadoop3
>Affects Versions: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>Reporter: Wei-Chiu Chuang
>Assignee: Wei-Chiu Chuang
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.7
>
> Attachments: HBASE-22954.001.patch, HBASE-22954.master.001.patch
>
>
> YARN-9477 added a new dependency net.java.dev.jna, which resulted in license
> check failure in HBase because the checker thinks it's LGPL 2.1 licensed. But
> in fact, it is dual licensed.
> {code}
> Java Native Access
> Java Native Access
> https://github.com/java-native-access/jna
>
>
> LGPL, version 2.1
> http://www.gnu.org/licenses/licenses.html
> repo
>
>
> Apache License v2.0
> http://www.apache.org/licenses/LICENSE-2.0.txt
> repo
>
>
> {code}
> We can
> (1) white list this dependency
> (2) or update the license checker to search for if any of the licenses is
> permitted
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22724) Add a emoji on the vote table for pre commit result on github
[
https://issues.apache.org/jira/browse/HBASE-22724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922855#comment-16922855
]
Hudson commented on HBASE-22724:
Results for branch master
[build #1401 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1401/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1401//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1401//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1401//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add a emoji on the vote table for pre commit result on github
> -
>
> Key: HBASE-22724
> URL: https://issues.apache.org/jira/browse/HBASE-22724
> Project: HBase
> Issue Type: Improvement
> Components: build, test
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 1.3.6, 1.4.11, 2.1.7
>
>
> [~zghaobac] said that the current vote table on github is not good enough, as
> the colors are almost the same, it is not easy to find out which line is
> broken.
> Since github can not change the color of the text, he suggested that we add a
> column at the left most with some emojis to better notify the developpers.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22970) split parents show as overlaps in the HBCK Report
[
https://issues.apache.org/jira/browse/HBASE-22970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922854#comment-16922854
]
Hudson commented on HBASE-22970:
Results for branch master
[build #1401 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1401/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1401//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1401//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1401//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> split parents show as overlaps in the HBCK Report
> -
>
> Key: HBASE-22970
> URL: https://issues.apache.org/jira/browse/HBASE-22970
> Project: HBase
> Issue Type: Bug
>Reporter: stack
>Assignee: stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.7
>
> Attachments: HBASE-22970.master.001.patch, Screen Shot 2019-09-03 at
> 2.43.41 PM.png
>
>
> Split parents show in the overlap list and continue to do so until cleared up
> by CatalogJanitor.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22724) Add a emoji on the vote table for pre commit result on github
[
https://issues.apache.org/jira/browse/HBASE-22724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922848#comment-16922848
]
Hudson commented on HBASE-22724:
Results for branch branch-2.2
[build #574 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/574/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/574//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/574//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/574//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/574//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Add a emoji on the vote table for pre commit result on github
> -
>
> Key: HBASE-22724
> URL: https://issues.apache.org/jira/browse/HBASE-22724
> Project: HBase
> Issue Type: Improvement
> Components: build, test
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 1.3.6, 1.4.11, 2.1.7
>
>
> [~zghaobac] said that the current vote table on github is not good enough, as
> the colors are almost the same, it is not easy to find out which line is
> broken.
> Since github can not change the color of the text, he suggested that we add a
> column at the left most with some emojis to better notify the developpers.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22954) Whitelist net.java.dev.jna which got pulled in through Hadoop 3.3.0
[
https://issues.apache.org/jira/browse/HBASE-22954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922845#comment-16922845
]
Hudson commented on HBASE-22954:
Results for branch branch-2.2
[build #574 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/574/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/574//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/574//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/574//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/574//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Whitelist net.java.dev.jna which got pulled in through Hadoop 3.3.0
> ---
>
> Key: HBASE-22954
> URL: https://issues.apache.org/jira/browse/HBASE-22954
> Project: HBase
> Issue Type: Improvement
> Components: community, hadoop3
>Affects Versions: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>Reporter: Wei-Chiu Chuang
>Assignee: Wei-Chiu Chuang
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.7
>
> Attachments: HBASE-22954.001.patch, HBASE-22954.master.001.patch
>
>
> YARN-9477 added a new dependency net.java.dev.jna, which resulted in license
> check failure in HBase because the checker thinks it's LGPL 2.1 licensed. But
> in fact, it is dual licensed.
> {code}
> Java Native Access
> Java Native Access
> https://github.com/java-native-access/jna
>
>
> LGPL, version 2.1
> http://www.gnu.org/licenses/licenses.html
> repo
>
>
> Apache License v2.0
> http://www.apache.org/licenses/LICENSE-2.0.txt
> repo
>
>
> {code}
> We can
> (1) white list this dependency
> (2) or update the license checker to search for if any of the licenses is
> permitted
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22850) Generate CHANGES.md and RELEASENOTES.md for 2.2.1
[
https://issues.apache.org/jira/browse/HBASE-22850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922849#comment-16922849
]
Hudson commented on HBASE-22850:
Results for branch branch-2.2
[build #574 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/574/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/574//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/574//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/574//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/574//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Generate CHANGES.md and RELEASENOTES.md for 2.2.1
> -
>
> Key: HBASE-22850
> URL: https://issues.apache.org/jira/browse/HBASE-22850
> Project: HBase
> Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
>Priority: Major
> Fix For: 2.2.1
>
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22970) split parents show as overlaps in the HBCK Report
[
https://issues.apache.org/jira/browse/HBASE-22970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922847#comment-16922847
]
Hudson commented on HBASE-22970:
Results for branch branch-2.2
[build #574 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/574/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/574//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/574//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/574//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/574//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> split parents show as overlaps in the HBCK Report
> -
>
> Key: HBASE-22970
> URL: https://issues.apache.org/jira/browse/HBASE-22970
> Project: HBase
> Issue Type: Bug
>Reporter: stack
>Assignee: stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.7
>
> Attachments: HBASE-22970.master.001.patch, Screen Shot 2019-09-03 at
> 2.43.41 PM.png
>
>
> Split parents show in the overlap list and continue to do so until cleared up
> by CatalogJanitor.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22961) Deprecate hbck1 in core
[
https://issues.apache.org/jira/browse/HBASE-22961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922846#comment-16922846
]
Hudson commented on HBASE-22961:
Results for branch branch-2.2
[build #574 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/574/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/574//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/574//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/574//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/574//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Deprecate hbck1 in core
> ---
>
> Key: HBASE-22961
> URL: https://issues.apache.org/jira/browse/HBASE-22961
> Project: HBase
> Issue Type: Bug
> Components: hbck
>Reporter: stack
>Assignee: stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.7
>
> Attachments: 0001-HBASE-22961-Deprecate-hbck1-in-core.patch,
> 0001-HBASE-22961-Deprecate-hbck1-in-core.patch, HBASE-22961.master.001.patch,
> HBASE-22961.master.002.patch
>
>
> HBaseFsck is just noted as read-only (along w/ noting that it is unreliable
> and shouldn't be used). Need to add deprecation so can be removed especially
> now that hbck2 has been built up and that the bulk of hbck1 is not
> rejiggered, repurposed to serve hbck2 and living out in hbase-operator-tools.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [hbase] Apache-HBase commented on issue #581: HBASE-22888 Use separate classe to deal with streaming read and pread
Apache-HBase commented on issue #581: HBASE-22888 Use separate classe to deal with streaming read and pread URL: https://github.com/apache/hbase/pull/581#issuecomment-528076665 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 0m 40s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 1s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | :green_heart: | mvninstall | 5m 34s | master passed | | :green_heart: | compile | 1m 4s | master passed | | :green_heart: | checkstyle | 1m 19s | master passed | | :green_heart: | shadedjars | 4m 35s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 0m 37s | master passed | | :blue_heart: | spotbugs | 4m 4s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 4m 2s | master passed | ||| _ Patch Compile Tests _ | | :green_heart: | mvninstall | 4m 53s | the patch passed | | :green_heart: | compile | 0m 57s | the patch passed | | :green_heart: | javac | 0m 57s | the patch passed | | :green_heart: | checkstyle | 1m 18s | hbase-server: The patch generated 0 new + 105 unchanged - 3 fixed = 105 total (was 108) | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | shadedjars | 4m 40s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 16m 35s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :broken_heart: | javadoc | 0m 36s | hbase-server generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) | | :green_heart: | findbugs | 4m 16s | the patch passed | ||| _ Other Tests _ | | :green_heart: | unit | 160m 26s | hbase-server in the patch passed. | | :green_heart: | asflicense | 0m 35s | The patch does not generate ASF License warnings. | | | | 218m 24s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-581/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/581 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux f51cfb76de47 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-581/out/precommit/personality/provided.sh | | git revision | master / 0d338a1820 | | Default Java | 1.8.0_181 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-581/1/artifact/out/diff-javadoc-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-581/1/testReport/ | | Max. process+thread count | 4450 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-581/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22724) Add a emoji on the vote table for pre commit result on github
[
https://issues.apache.org/jira/browse/HBASE-22724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922842#comment-16922842
]
Hudson commented on HBASE-22724:
Results for branch branch-1.3
[build #953 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/953/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/953//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/953//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/953//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Add a emoji on the vote table for pre commit result on github
> -
>
> Key: HBASE-22724
> URL: https://issues.apache.org/jira/browse/HBASE-22724
> Project: HBase
> Issue Type: Improvement
> Components: build, test
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 1.3.6, 1.4.11, 2.1.7
>
>
> [~zghaobac] said that the current vote table on github is not good enough, as
> the colors are almost the same, it is not easy to find out which line is
> broken.
> Since github can not change the color of the text, he suggested that we add a
> column at the left most with some emojis to better notify the developpers.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22973) [DOC] Update REST Section of Ref Guide to describe supported Content-type/Accept
[
https://issues.apache.org/jira/browse/HBASE-22973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922839#comment-16922839
]
HBase QA commented on HBASE-22973:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 3m
53s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
17s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 5m
55s{color} | {color:blue} branch has no errors when building the reference
guide. See footer for rendered docs, which you should manually inspect. {color}
|
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 5m
34s{color} | {color:blue} patch has no errors when building the reference
guide. See footer for rendered docs, which you should manually inspect. {color}
|
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 27m 13s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.2 Server=19.03.2 base:
https://builds.apache.org/job/PreCommit-HBASE-Build/862/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22973 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12979464/HBASE-22973.master.0001.patch
|
| Optional Tests | dupname asflicense refguide |
| uname | Linux 10604fbfb3c3 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24
13:14:43 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 0d338a1820 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| refguide |
https://builds.apache.org/job/PreCommit-HBASE-Build/862/artifact/patchprocess/branch-site/book.html
|
| refguide |
https://builds.apache.org/job/PreCommit-HBASE-Build/862/artifact/patchprocess/patch-site/book.html
|
| Max. process+thread count | 95 (vs. ulimit of 1) |
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/862/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
> [DOC] Update REST Section of Ref Guide to describe supported
> Content-type/Accept
>
>
> Key: HBASE-22973
> URL: https://issues.apache.org/jira/browse/HBASE-22973
> Project: HBase
> Issue Type: Improvement
> Components: documentation
> Environment: HBase REST API Endpoints section should detail the
> expected Content-type and Accept for each resource, as this may influence on
> the expected result.
> This also fixes some minor typos among the description/examples defined on
> this section.
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Minor
> Attachments: HBASE-22973.master.0001.patch
>
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22724) Add a emoji on the vote table for pre commit result on github
[
https://issues.apache.org/jira/browse/HBASE-22724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922826#comment-16922826
]
Hudson commented on HBASE-22724:
Results for branch branch-1.4
[build #994 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/994/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/994//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/994//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/994//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Add a emoji on the vote table for pre commit result on github
> -
>
> Key: HBASE-22724
> URL: https://issues.apache.org/jira/browse/HBASE-22724
> Project: HBase
> Issue Type: Improvement
> Components: build, test
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 1.3.6, 1.4.11, 2.1.7
>
>
> [~zghaobac] said that the current vote table on github is not good enough, as
> the colors are almost the same, it is not easy to find out which line is
> broken.
> Since github can not change the color of the text, he suggested that we add a
> column at the left most with some emojis to better notify the developpers.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [hbase] Apache-HBase commented on issue #476: HBASE-11062 hbtop
Apache-HBase commented on issue #476: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/476#issuecomment-528064674 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 49 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 2 | No case conflicting files found. | | 0 | shelldocs | 2 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 1 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 22 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 36 | Maven dependency ordering for branch | | +1 | mvninstall | 314 | master passed | | +1 | compile | 186 | master passed | | +1 | checkstyle | 157 | master passed | | +1 | shadedjars | 279 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 194 | master passed | | 0 | spotbugs | 33 | Used deprecated FindBugs config; considering switching to SpotBugs. | | 0 | findbugs | 33 | branch/hbase-assembly no findbugs output file (findbugsXml.xml) | ||| _ Patch Compile Tests _ | | 0 | mvndep | 16 | Maven dependency ordering for patch | | +1 | mvninstall | 313 | the patch passed | | +1 | compile | 186 | the patch passed | | +1 | javac | 186 | the patch passed | | +1 | checkstyle | 142 | the patch passed | | +1 | shellcheck | 3 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 5 | The patch has no ill-formed XML file. | | +1 | shadedjars | 295 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 992 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 202 | the patch passed | | 0 | findbugs | 33 | hbase-assembly has no data from findbugs | ||| _ Other Tests _ | | +1 | unit | 14862 | root in the patch passed. | | +1 | asflicense | 112 | The patch does not generate ASF License warnings. | | | | 20620 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/71/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/476 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit shadedjars hadoopcheck xml compile spotbugs findbugs hbaseanti checkstyle | | uname | Linux 5285cdcfbc6f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-476/out/precommit/personality/provided.sh | | git revision | master / dfe5280d0c | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/71/testReport/ | | Max. process+thread count | 5497 (vs. ulimit of 1) | | modules | C: hbase-hbtop . hbase-assembly U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/71/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22338) LICENSE file only contains Apache 2.0
[ https://issues.apache.org/jira/browse/HBASE-22338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922796#comment-16922796 ] Sean Busbey commented on HBASE-22338: - that said, it looks like the hbase-connectors repo already has some of the moving pieces to use the build stuff that the main repo uses to build aggregate license information, so maybe it's not so much better to manually maintain files ourselves. how many dependencies with non-ALv2 licenses are we talking about? > LICENSE file only contains Apache 2.0 > - > > Key: HBASE-22338 > URL: https://issues.apache.org/jira/browse/HBASE-22338 > Project: HBase > Issue Type: Bug > Components: hbase-connectors >Affects Versions: connector-1.0.0 >Reporter: Peter Somogyi >Assignee: Rabi Kumar K C >Priority: Critical > Fix For: connector-1.0.1 > > > LICENSE.md file has only Apache 2.0 licenses but we package dependencies that > use different ones. For example jcodings uses MIT. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22338) LICENSE file only contains Apache 2.0
[
https://issues.apache.org/jira/browse/HBASE-22338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922795#comment-16922795
]
Sean Busbey commented on HBASE-22338:
-
I am thrilled that someone else is interested in doing license work. :)
The main HBase repository has a bunch of build automation to handle making the
correct LICENSE files for our various build artifacts. Given how much simpler
the hbase-connectors repo is, I suspect we might be better off just manually
maintaining a LICENSE and NOTICE file.
This page gives guidelines on how we're expected to keep things in each of the
LICENSE and NOTICE file:
http://www.apache.org/dev/licensing-howto.html
The tl;dr: there should be a copy of each license applicable to a contained
work in LICENSE. For everything under a license other than ALv2 we should call
out which license it's under within that file. For things with a notification
requirement, basically anything other than permissive licenses (e.g. MIT or
BSD) or ALv2 works that don't have a NOTICE files, we should include a line in
our packaged NOTICE file.
The easy way to have a LICENSE and NOTICE file in the artifact we make that's
different from the one we use for the source repository is:
* for modules that make jars, create a LICENSE and NOTICE file in
{{src/main/appended-resources/META-INF/}} that has anything we need in addition
to a plain ALv2 license and a simple project copyright notice.
* for modules that make tarballs, create a LICENSE and NOTICE file in
{{src/main/resources}} that has the entire desired text (including the base
ALv2) and then include it in the assembly, e.g.
{code}
src/main/resources
0755
0644
.
LICENSE
NOTICE
{code}
To figure out what the license of a dependency is, I usually check a) license
indicated in the maven pom, b) LICENSE info in the jar, and c) license info
available on their website. If the three don't match then we should have a
discussion about how to figure out which is intended. Sometimes the outcome of
that is to ask the project to make it clear.
> LICENSE file only contains Apache 2.0
> -
>
> Key: HBASE-22338
> URL: https://issues.apache.org/jira/browse/HBASE-22338
> Project: HBase
> Issue Type: Bug
> Components: hbase-connectors
>Affects Versions: connector-1.0.0
>Reporter: Peter Somogyi
>Assignee: Rabi Kumar K C
>Priority: Critical
> Fix For: connector-1.0.1
>
>
> LICENSE.md file has only Apache 2.0 licenses but we package dependencies that
> use different ones. For example jcodings uses MIT.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22961) Deprecate hbck1 in core
[
https://issues.apache.org/jira/browse/HBASE-22961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922786#comment-16922786
]
Hudson commented on HBASE-22961:
Results for branch branch-2
[build #2226 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2226/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2226//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2226//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2226//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Deprecate hbck1 in core
> ---
>
> Key: HBASE-22961
> URL: https://issues.apache.org/jira/browse/HBASE-22961
> Project: HBase
> Issue Type: Bug
> Components: hbck
>Reporter: stack
>Assignee: stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.7
>
> Attachments: 0001-HBASE-22961-Deprecate-hbck1-in-core.patch,
> 0001-HBASE-22961-Deprecate-hbck1-in-core.patch, HBASE-22961.master.001.patch,
> HBASE-22961.master.002.patch
>
>
> HBaseFsck is just noted as read-only (along w/ noting that it is unreliable
> and shouldn't be used). Need to add deprecation so can be removed especially
> now that hbck2 has been built up and that the bulk of hbck1 is not
> rejiggered, repurposed to serve hbck2 and living out in hbase-operator-tools.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22724) Add a emoji on the vote table for pre commit result on github
[
https://issues.apache.org/jira/browse/HBASE-22724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922788#comment-16922788
]
Hudson commented on HBASE-22724:
Results for branch branch-2
[build #2226 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2226/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2226//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2226//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2226//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add a emoji on the vote table for pre commit result on github
> -
>
> Key: HBASE-22724
> URL: https://issues.apache.org/jira/browse/HBASE-22724
> Project: HBase
> Issue Type: Improvement
> Components: build, test
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 1.3.6, 1.4.11, 2.1.7
>
>
> [~zghaobac] said that the current vote table on github is not good enough, as
> the colors are almost the same, it is not easy to find out which line is
> broken.
> Since github can not change the color of the text, he suggested that we add a
> column at the left most with some emojis to better notify the developpers.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22954) Whitelist net.java.dev.jna which got pulled in through Hadoop 3.3.0
[
https://issues.apache.org/jira/browse/HBASE-22954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922785#comment-16922785
]
Hudson commented on HBASE-22954:
Results for branch branch-2
[build #2226 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2226/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2226//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2226//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2226//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Whitelist net.java.dev.jna which got pulled in through Hadoop 3.3.0
> ---
>
> Key: HBASE-22954
> URL: https://issues.apache.org/jira/browse/HBASE-22954
> Project: HBase
> Issue Type: Improvement
> Components: community, hadoop3
>Affects Versions: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>Reporter: Wei-Chiu Chuang
>Assignee: Wei-Chiu Chuang
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.7
>
> Attachments: HBASE-22954.001.patch, HBASE-22954.master.001.patch
>
>
> YARN-9477 added a new dependency net.java.dev.jna, which resulted in license
> check failure in HBase because the checker thinks it's LGPL 2.1 licensed. But
> in fact, it is dual licensed.
> {code}
> Java Native Access
> Java Native Access
> https://github.com/java-native-access/jna
>
>
> LGPL, version 2.1
> http://www.gnu.org/licenses/licenses.html
> repo
>
>
> Apache License v2.0
> http://www.apache.org/licenses/LICENSE-2.0.txt
> repo
>
>
> {code}
> We can
> (1) white list this dependency
> (2) or update the license checker to search for if any of the licenses is
> permitted
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22970) split parents show as overlaps in the HBCK Report
[
https://issues.apache.org/jira/browse/HBASE-22970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922787#comment-16922787
]
Hudson commented on HBASE-22970:
Results for branch branch-2
[build #2226 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2226/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2226//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2226//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2226//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> split parents show as overlaps in the HBCK Report
> -
>
> Key: HBASE-22970
> URL: https://issues.apache.org/jira/browse/HBASE-22970
> Project: HBase
> Issue Type: Bug
>Reporter: stack
>Assignee: stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.7
>
> Attachments: HBASE-22970.master.001.patch, Screen Shot 2019-09-03 at
> 2.43.41 PM.png
>
>
> Split parents show in the overlap list and continue to do so until cleared up
> by CatalogJanitor.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22724) Add a emoji on the vote table for pre commit result on github
[
https://issues.apache.org/jira/browse/HBASE-22724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922782#comment-16922782
]
Hudson commented on HBASE-22724:
Results for branch branch-2.1
[build #1559 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1559/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1559//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1559//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1559//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add a emoji on the vote table for pre commit result on github
> -
>
> Key: HBASE-22724
> URL: https://issues.apache.org/jira/browse/HBASE-22724
> Project: HBase
> Issue Type: Improvement
> Components: build, test
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 1.3.6, 1.4.11, 2.1.7
>
>
> [~zghaobac] said that the current vote table on github is not good enough, as
> the colors are almost the same, it is not easy to find out which line is
> broken.
> Since github can not change the color of the text, he suggested that we add a
> column at the left most with some emojis to better notify the developpers.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22961) Deprecate hbck1 in core
[
https://issues.apache.org/jira/browse/HBASE-22961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922780#comment-16922780
]
Hudson commented on HBASE-22961:
Results for branch branch-2.1
[build #1559 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1559/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1559//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1559//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1559//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Deprecate hbck1 in core
> ---
>
> Key: HBASE-22961
> URL: https://issues.apache.org/jira/browse/HBASE-22961
> Project: HBase
> Issue Type: Bug
> Components: hbck
>Reporter: stack
>Assignee: stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.7
>
> Attachments: 0001-HBASE-22961-Deprecate-hbck1-in-core.patch,
> 0001-HBASE-22961-Deprecate-hbck1-in-core.patch, HBASE-22961.master.001.patch,
> HBASE-22961.master.002.patch
>
>
> HBaseFsck is just noted as read-only (along w/ noting that it is unreliable
> and shouldn't be used). Need to add deprecation so can be removed especially
> now that hbck2 has been built up and that the bulk of hbck1 is not
> rejiggered, repurposed to serve hbck2 and living out in hbase-operator-tools.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22970) split parents show as overlaps in the HBCK Report
[
https://issues.apache.org/jira/browse/HBASE-22970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922781#comment-16922781
]
Hudson commented on HBASE-22970:
Results for branch branch-2.1
[build #1559 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1559/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1559//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1559//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1559//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> split parents show as overlaps in the HBCK Report
> -
>
> Key: HBASE-22970
> URL: https://issues.apache.org/jira/browse/HBASE-22970
> Project: HBase
> Issue Type: Bug
>Reporter: stack
>Assignee: stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.7
>
> Attachments: HBASE-22970.master.001.patch, Screen Shot 2019-09-03 at
> 2.43.41 PM.png
>
>
> Split parents show in the overlap list and continue to do so until cleared up
> by CatalogJanitor.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Commented] (HBASE-22896) TestHRegion.testFlushMarkersWALFail is flaky
[
https://issues.apache.org/jira/browse/HBASE-22896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922778#comment-16922778
]
Hudson commented on HBASE-22896:
Results for branch branch-2.1
[build #1559 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1559/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1559//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1559//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1559//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> TestHRegion.testFlushMarkersWALFail is flaky
>
>
> Key: HBASE-22896
> URL: https://issues.apache.org/jira/browse/HBASE-22896
> Project: HBase
> Issue Type: Bug
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.7
>
>
> It has two problems,
> 1. didn't initalize chunkCreator, and fails at NPE,
> {quote}java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.getOrMakeChunk(MemStoreLABImpl.java:334)
> at
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.copyCellInto(MemStoreLABImpl.java:193)
> at
> org.apache.hadoop.hbase.regionserver.MemStoreLABImpl.copyCellInto(MemStoreLABImpl.java:115)
> at
> org.apache.hadoop.hbase.regionserver.Segment.maybeCloneWithAllocator(Segment.java:176)
> at
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.maybeCloneWithAllocator(AbstractMemStore.java:334)
> at
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.doAdd(AbstractMemStore.java:157)
> at
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.doAddOrUpsert(AbstractMemStore.java:147)
> at
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.add(AbstractMemStore.java:117)
> at
> org.apache.hadoop.hbase.regionserver.AbstractMemStore.add(AbstractMemStore.java:111)
> at org.apache.hadoop.hbase.regionserver.HStore.add(HStore.java:775)
> at
> org.apache.hadoop.hbase.regionserver.HRegion.applyToMemStore(HRegion.java:4510)
> at org.apache.hadoop.hbase.regionserver.HRegion.access$500(HRegion.java:229)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.applyFamilyMapToMemStore(HRegion.java:3571)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.lambda$writeMiniBatchOperationsToMemStore$0(HRegion.java:3262)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.visitBatchOperations(HRegion.java:3195)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.writeMiniBatchOperationsToMemStore(HRegion.java:3254)
> at
> org.apache.hadoop.hbase.regionserver.HRegion$MutationBatchOperation.writeMiniBatchOperationsToMemStore(HRegion.java:3736)
> at
> org.apache.hadoop.hbase.regionserver.HRegion.doMiniBatchMutate(HRegion.java:4150)
> at
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4083)
> at
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4014)
> at
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4005)
> at
> org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4019)
> at
> org.apache.hadoop.hbase.regionserver.HRegion.doBatchMutate(HRegion.java:4346)
> at org.apache.hadoop.hbase.regionserver.HRegion.put(HRegion.java:3138)
> at
> org.apache.hadoop.hbase.regionserver.TestHRegion.testFlushMarkersWALFail(TestHRegion.java:1213)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:2
[jira] [Commented] (HBASE-22954) Whitelist net.java.dev.jna which got pulled in through Hadoop 3.3.0
[
https://issues.apache.org/jira/browse/HBASE-22954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922779#comment-16922779
]
Hudson commented on HBASE-22954:
Results for branch branch-2.1
[build #1559 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1559/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1559//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1559//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1559//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Whitelist net.java.dev.jna which got pulled in through Hadoop 3.3.0
> ---
>
> Key: HBASE-22954
> URL: https://issues.apache.org/jira/browse/HBASE-22954
> Project: HBase
> Issue Type: Improvement
> Components: community, hadoop3
>Affects Versions: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>Reporter: Wei-Chiu Chuang
>Assignee: Wei-Chiu Chuang
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.7
>
> Attachments: HBASE-22954.001.patch, HBASE-22954.master.001.patch
>
>
> YARN-9477 added a new dependency net.java.dev.jna, which resulted in license
> check failure in HBase because the checker thinks it's LGPL 2.1 licensed. But
> in fact, it is dual licensed.
> {code}
> Java Native Access
> Java Native Access
> https://github.com/java-native-access/jna
>
>
> LGPL, version 2.1
> http://www.gnu.org/licenses/licenses.html
> repo
>
>
> Apache License v2.0
> http://www.apache.org/licenses/LICENSE-2.0.txt
> repo
>
>
> {code}
> We can
> (1) white list this dependency
> (2) or update the license checker to search for if any of the licenses is
> permitted
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[GitHub] [hbase-operator-tools] asf-ci commented on issue #18: HBASE-22567 - HBCK2 addMissingRegionsToMeta
asf-ci commented on issue #18: HBASE-22567 - HBCK2 addMissingRegionsToMeta URL: https://github.com/apache/hbase-operator-tools/pull/18#issuecomment-528036805 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-HBASE-OPERATOR-TOOLS-Build/82/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary
[ https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caroline updated HBASE-22804: - Attachment: HBASE-22804.branch-1.007.patch > Provide an API to get list of successful regions and total expected regions > in Canary > - > > Key: HBASE-22804 > URL: https://issues.apache.org/jira/browse/HBASE-22804 > Project: HBase > Issue Type: Improvement > Components: canary >Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1 >Reporter: Caroline >Assignee: Caroline >Priority: Minor > Labels: Canary > Attachments: HBASE-22804.branch-1.001.patch, > HBASE-22804.branch-1.002.patch, HBASE-22804.branch-1.003.patch, > HBASE-22804.branch-1.004.patch, HBASE-22804.branch-1.005.patch, > HBASE-22804.branch-1.006.patch, HBASE-22804.branch-1.007.patch, > HBASE-22804.branch-2.001.patch, HBASE-22804.branch-2.002.patch, > HBASE-22804.branch-2.003.patch, HBASE-22804.branch-2.004.patch, > HBASE-22804.branch-2.005.patch, HBASE-22804.branch-2.006.patch, > HBASE-22804.master.001.patch, HBASE-22804.master.002.patch, > HBASE-22804.master.003.patch, HBASE-22804.master.004.patch, > HBASE-22804.master.005.patch, HBASE-22804.master.006.patch > > > At present HBase Canary tool only prints the successes as part of logs. > Providing an API to get the list of successes, as well as total number of > expected regions, will make it easier to get a more accurate availability > estimate. > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase] Apache-HBase commented on issue #528: HBASE-22890 Verify the files when RegionServer is starting and BucketCache is in file mode
Apache-HBase commented on issue #528: HBASE-22890 Verify the files when RegionServer is starting and BucketCache is in file mode URL: https://github.com/apache/hbase/pull/528#issuecomment-528029728 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 51m 57s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. | ||| _ branch-1 Compile Tests _ | | :green_heart: | mvninstall | 8m 26s | branch-1 passed | | :green_heart: | compile | 0m 42s | branch-1 passed | | :green_heart: | checkstyle | 1m 44s | branch-1 passed | | :broken_heart: | shadedjars | 0m 12s | branch has 10 errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 0m 36s | branch-1 passed | | :blue_heart: | spotbugs | 2m 28s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 2m 26s | branch-1 passed | | :yellow_heart: | patch | 2m 33s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | :green_heart: | mvninstall | 1m 52s | the patch passed | | :green_heart: | compile | 0m 41s | the patch passed | | :green_heart: | javac | 0m 41s | the patch passed | | :broken_heart: | checkstyle | 1m 41s | hbase-server: The patch generated 13 new + 53 unchanged - 6 fixed = 66 total (was 59) | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :broken_heart: | shadedjars | 0m 10s | patch has 10 errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 4m 43s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | :green_heart: | javadoc | 0m 31s | the patch passed | | :broken_heart: | findbugs | 2m 25s | hbase-server generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) | ||| _ Other Tests _ | | :broken_heart: | unit | 27m 20s | hbase-server in the patch failed. | | :green_heart: | asflicense | 0m 17s | The patch does not generate ASF License warnings. | | | | 108m 50s | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-server | | | org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.retrieveFromFile(int[]) ignores result of java.io.ObjectInputStream.read(byte[]) At BucketCache.java: At BucketCache.java:[line 1070] | | | org.apache.hadoop.hbase.io.hfile.bucket.PersistentIOEngineUtils.readPersistenceChecksum(String) ignores result of java.io.ObjectInputStream.read(byte[]) At PersistentIOEngineUtils.java: At PersistentIOEngineUtils.java:[line 53] | | Failed junit tests | hadoop.hbase.executor.TestExecutorService | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-528/23/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/528 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 733474fe6096 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-528/out/precommit/personality/provided.sh | | git revision | branch-1 / 157ffae | | Default Java | 1.8.0_222 | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-528/23/artifact/out/branch-shadedjars.txt | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-528/23/artifact/out/diff-checkstyle-hbase-server.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-528/23/artifact/out/patch-shadedjars.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-528/23/artifact/out/new-findbugs-hbase-server.html | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-528/23/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-528/23/testReport/ | | Max. process+thread count | 734 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.
[GitHub] [hbase] pankaj72981 opened a new pull request #585: HBASE-22930 Set unique name to longCompactions/shortCompactions/split threads
pankaj72981 opened a new pull request #585: HBASE-22930 Set unique name to longCompactions/shortCompactions/split threads URL: https://github.com/apache/hbase/pull/585 ThreadFactoryBuilder internally has the its own counter, but to have the counter in the thread name we need to define the format in setNameFormat(), new ThreadFactoryBuilder().setNameFormat(n + "-longCompactions-%d") This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22701) Better handle invalid local directory for DynamicClassLoader
[
https://issues.apache.org/jira/browse/HBASE-22701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922740#comment-16922740
]
Ankit Singhal commented on HBASE-22701:
---
+1 [~elserj]
> Better handle invalid local directory for DynamicClassLoader
>
>
> Key: HBASE-22701
> URL: https://issues.apache.org/jira/browse/HBASE-22701
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Major
> Fix For: 2.3.0, 2.1.7, 2.2.2
>
> Attachments: HBASE-22701.001.patch, HBASE-22701.002.patch,
> HBASE-22701.003.patch
>
>
> If you give HBase an {{hbase.local.dir}} (usually, "{{hbase.tmp.dir}}/local")
> which is not writable to it, you will get some weird errors on the scan path.
> I just saw this (again?) with Phoenix.
> Specifically, the first attempt to reference DynamicClassLoader (via
> ProtobufUtil), will result in an ExceptionInInitializationError because the
> unchecked exception coming out of DynamicClassLoader's constructor interrupts
> the loading of {{DynamicClassLoader.class}}.
> {noformat}
> 2019-07-14 06:25:34,284 ERROR
> [RpcServer.Metadata.Fifo.handler=12,queue=0,port=16020]
> coprocessor.MetaDataEndpointImpl: dropTable failed
> org.apache.hadoop.hbase.DoNotRetryIOException:
> java.lang.ExceptionInInitializerError
> at
> org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.translateException(RpcRetryingCallerImpl.java:221)
> at
> org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithoutRetries(RpcRetryingCallerImpl.java:194)
> at
> org.apache.hadoop.hbase.client.ScannerCallableWithReplicas$RetryingRPC.call(ScannerCallableWithReplicas.java:387)
> at
> org.apache.hadoop.hbase.client.ScannerCallableWithReplicas$RetryingRPC.call(ScannerCallableWithReplicas.java:361)
> at
> org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:107)
> at
> org.apache.hadoop.hbase.client.ResultBoundedCompletionService$QueueingFuture.run(ResultBoundedCompletionService.java:80)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: java.lang.ExceptionInInitializerError
> at
> org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.toFilter(ProtobufUtil.java:1598)
> at
> org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.toScan(ProtobufUtil.java:1152)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.newRegionScanner(RSRpcServices.java:2967)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:3301)
> at
> org.apache.hadoop.hbase.client.ScannerCallable.openScanner(ScannerCallable.java:332)
> at
> org.apache.hadoop.hbase.client.ScannerCallable.rpcCall(ScannerCallable.java:242)
> at
> org.apache.hadoop.hbase.client.ScannerCallable.rpcCall(ScannerCallable.java:58)
> at
> org.apache.hadoop.hbase.client.RegionServerCallable.call(RegionServerCallable.java:127)
> at
> org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithoutRetries(RpcRetryingCallerImpl.java:192)
> ... 7 more
> Caused by: java.lang.RuntimeException: Failed to create local dir
> /hadoopfs/fs1/hbase/local/jars, DynamicClassLoader failed to init
> at
> org.apache.hadoop.hbase.util.DynamicClassLoader.initTempDir(DynamicClassLoader.java:110)
> at
> org.apache.hadoop.hbase.util.DynamicClassLoader.(DynamicClassLoader.java:98)
> at
> org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil$ClassLoaderHolder.lambda$static$0(ProtobufUtil.java:261)
> at java.security.AccessController.doPrivileged(Native Method)
> at
> org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil$ClassLoaderHolder.(ProtobufUtil.java:260)
> ... 16 more
> {noformat}
> Every subsequent call will result in a NoClassDefFoundError, because we
> already tried to load DynamicClassLoader.class once and failed.
> {noformat}
> 2019-07-14 06:25:34,380 ERROR
> [RpcServer.Metadata.Fifo.handler=2,queue=2,port=16020]
> coprocessor.MetaDataEndpointImpl: dropTable failed
> org.apache.hadoop.hbase.DoNotRetryIOException:
> java.lang.NoClassDefFoundError: Could not initialize class
> org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil$ClassLoaderHolder
> at
> org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.translateException(RpcRetryingCallerImpl.java:221)
> at
> org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithoutRetries(RpcRetryingCallerImpl.java:194)
> at
> org.ap
[jira] [Updated] (HBASE-22973) [DOC] Update REST Section of Ref Guide to describe supported Content-type/Accept
[ https://issues.apache.org/jira/browse/HBASE-22973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-22973: - Summary: [DOC] Update REST Section of Ref Guide to describe supported Content-type/Accept (was: Update REST Section of Ref Guide to describe supported Content-type/Accept) > [DOC] Update REST Section of Ref Guide to describe supported > Content-type/Accept > > > Key: HBASE-22973 > URL: https://issues.apache.org/jira/browse/HBASE-22973 > Project: HBase > Issue Type: Improvement > Components: documentation > Environment: HBase REST API Endpoints section should detail the > expected Content-type and Accept for each resource, as this may influence on > the expected result. > This also fixes some minor typos among the description/examples defined on > this section. >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Minor > Attachments: HBASE-22973.master.0001.patch > > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-22804) Provide an API to get list of successful regions and total expected regions in Canary
[ https://issues.apache.org/jira/browse/HBASE-22804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caroline updated HBASE-22804: - Attachment: (was: HBASE-22804.branch-1.006.patch) > Provide an API to get list of successful regions and total expected regions > in Canary > - > > Key: HBASE-22804 > URL: https://issues.apache.org/jira/browse/HBASE-22804 > Project: HBase > Issue Type: Improvement > Components: canary >Affects Versions: 3.0.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.5, 2.2.1 >Reporter: Caroline >Assignee: Caroline >Priority: Minor > Labels: Canary > Attachments: HBASE-22804.branch-1.001.patch, > HBASE-22804.branch-1.002.patch, HBASE-22804.branch-1.003.patch, > HBASE-22804.branch-1.004.patch, HBASE-22804.branch-1.005.patch, > HBASE-22804.branch-1.006.patch, HBASE-22804.branch-2.001.patch, > HBASE-22804.branch-2.002.patch, HBASE-22804.branch-2.003.patch, > HBASE-22804.branch-2.004.patch, HBASE-22804.branch-2.005.patch, > HBASE-22804.branch-2.006.patch, HBASE-22804.master.001.patch, > HBASE-22804.master.002.patch, HBASE-22804.master.003.patch, > HBASE-22804.master.004.patch, HBASE-22804.master.005.patch, > HBASE-22804.master.006.patch > > > At present HBase Canary tool only prints the successes as part of logs. > Providing an API to get the list of successes, as well as total number of > expected regions, will make it easier to get a more accurate availability > estimate. > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase] Apache-HBase commented on issue #582: HBASE-22937 The RawBytesComparator in branch-1 have wrong comparison order
Apache-HBase commented on issue #582: HBASE-22937 The RawBytesComparator in branch-1 have wrong comparison order URL: https://github.com/apache/hbase/pull/582#issuecomment-528008634 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | :blue_heart: | reexec | 0m 45s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ branch-1 Compile Tests _ | | :green_heart: | mvninstall | 8m 10s | branch-1 passed | | :green_heart: | compile | 0m 18s | branch-1 passed | | :green_heart: | checkstyle | 0m 31s | branch-1 passed | | :broken_heart: | shadedjars | 0m 14s | branch has 10 errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 0m 25s | branch-1 passed | | :blue_heart: | spotbugs | 0m 58s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 0m 56s | branch-1 passed | ||| _ Patch Compile Tests _ | | :green_heart: | mvninstall | 1m 47s | the patch passed | | :green_heart: | compile | 0m 18s | the patch passed | | :green_heart: | javac | 0m 18s | the patch passed | | :green_heart: | checkstyle | 0m 28s | the patch passed | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :broken_heart: | shadedjars | 0m 11s | patch has 10 errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 4m 47s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | :green_heart: | javadoc | 0m 18s | the patch passed | | :green_heart: | findbugs | 0m 46s | the patch passed | ||| _ Other Tests _ | | :green_heart: | unit | 2m 14s | hbase-common in the patch passed. | | :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. | | | | 25m 34s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-582/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/582 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux c86b15c83499 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-582/out/precommit/personality/provided.sh | | git revision | branch-1 / 157ffae | | Default Java | 1.8.0_222 | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-582/1/artifact/out/branch-shadedjars.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-582/1/artifact/out/patch-shadedjars.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-582/1/testReport/ | | Max. process+thread count | 196 (vs. ulimit of 1) | | modules | C: hbase-common U: hbase-common | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-582/1/console | | versions | git=1.9.1 maven=3.0.5 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-operator-tools] asf-ci commented on issue #18: HBASE-22567 - HBCK2 addMissingRegionsToMeta
asf-ci commented on issue #18: HBASE-22567 - HBCK2 addMissingRegionsToMeta URL: https://github.com/apache/hbase-operator-tools/pull/18#issuecomment-528007285 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-HBASE-OPERATOR-TOOLS-Build/81/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] joshelser commented on a change in pull request #570: HBASE-22013 SpaceQuotas - getNumRegions() returning wrong number of regions due to region replicas
joshelser commented on a change in pull request #570: HBASE-22013 SpaceQuotas -
getNumRegions() returning wrong number of regions due to region replicas
URL: https://github.com/apache/hbase/pull/570#discussion_r320883888
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestSpaceQuotasWithRegionReplicas.java
##
@@ -0,0 +1,119 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.quotas;
+
+import java.util.concurrent.atomic.AtomicLong;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtility;
+import org.apache.hadoop.hbase.NamespaceDescriptor;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.Put;
+import org.apache.hadoop.hbase.testclassification.MediumTests;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.junit.AfterClass;
+import org.junit.Before;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.TestName;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+@Category(MediumTests.class)
+public class TestSpaceQuotasWithRegionReplicas {
+
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+ HBaseClassTestRule.forClass(TestSpaceQuotasWithRegionReplicas.class);
+
+ private static final Logger LOG =
+ LoggerFactory.getLogger(TestSpaceQuotasWithRegionReplicas.class);
+ private static final HBaseTestingUtility TEST_UTIL = new
HBaseTestingUtility();
+ private static final int NUM_RETRIES = 10;
+
+ @Rule
+ public TestName testName = new TestName();
+ private SpaceQuotaHelperForTests helper;
+
+ @BeforeClass
+ public static void setUp() throws Exception {
+Configuration conf = TEST_UTIL.getConfiguration();
+SpaceQuotaHelperForTests.updateConfigForQuotas(conf);
+TEST_UTIL.startMiniCluster(1);
+ }
+
+ @AfterClass
+ public static void tearDown() throws Exception {
+TEST_UTIL.shutdownMiniCluster();
+ }
+
+ @Before
+ public void removeAllQuotas() throws Exception {
+helper = new SpaceQuotaHelperForTests(TEST_UTIL, testName, new
AtomicLong(0));
+helper.removeAllQuotas();
+ }
+
+ @Test
+ public void testSetQuotaWithRegionReplicaSingleRegion() throws Exception {
+setQuotaAndVerifyForRegionReplication(1, 2,
SpaceViolationPolicy.NO_INSERTS);
+setQuotaAndVerifyForRegionReplication(1, 2,
SpaceViolationPolicy.NO_WRITES);
+setQuotaAndVerifyForRegionReplication(1, 2,
SpaceViolationPolicy.NO_WRITES_COMPACTIONS);
+setQuotaAndVerifyForRegionReplication(1, 2, SpaceViolationPolicy.DISABLE);
+ }
+
+ @Test
+ public void testSetQuotaWithRegionReplicaMultipleRegion() throws Exception {
+setQuotaAndVerifyForRegionReplication(5, 3,
SpaceViolationPolicy.NO_INSERTS);
Review comment:
Is it intentional that this is `5` and the other lines are `6`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] joshelser commented on a change in pull request #570: HBASE-22013 SpaceQuotas - getNumRegions() returning wrong number of regions due to region replicas
joshelser commented on a change in pull request #570: HBASE-22013 SpaceQuotas -
getNumRegions() returning wrong number of regions due to region replicas
URL: https://github.com/apache/hbase/pull/570#discussion_r320884036
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestSpaceQuotasWithRegionReplicas.java
##
@@ -0,0 +1,119 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.quotas;
+
+import java.util.concurrent.atomic.AtomicLong;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtility;
+import org.apache.hadoop.hbase.NamespaceDescriptor;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.Put;
+import org.apache.hadoop.hbase.testclassification.MediumTests;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.junit.AfterClass;
+import org.junit.Before;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.TestName;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+@Category(MediumTests.class)
+public class TestSpaceQuotasWithRegionReplicas {
+
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+ HBaseClassTestRule.forClass(TestSpaceQuotasWithRegionReplicas.class);
+
+ private static final Logger LOG =
+ LoggerFactory.getLogger(TestSpaceQuotasWithRegionReplicas.class);
+ private static final HBaseTestingUtility TEST_UTIL = new
HBaseTestingUtility();
+ private static final int NUM_RETRIES = 10;
+
+ @Rule
+ public TestName testName = new TestName();
+ private SpaceQuotaHelperForTests helper;
+
+ @BeforeClass
+ public static void setUp() throws Exception {
+Configuration conf = TEST_UTIL.getConfiguration();
+SpaceQuotaHelperForTests.updateConfigForQuotas(conf);
+TEST_UTIL.startMiniCluster(1);
+ }
+
+ @AfterClass
+ public static void tearDown() throws Exception {
+TEST_UTIL.shutdownMiniCluster();
+ }
+
+ @Before
+ public void removeAllQuotas() throws Exception {
+helper = new SpaceQuotaHelperForTests(TEST_UTIL, testName, new
AtomicLong(0));
+helper.removeAllQuotas();
+ }
+
+ @Test
+ public void testSetQuotaWithRegionReplicaSingleRegion() throws Exception {
+setQuotaAndVerifyForRegionReplication(1, 2,
SpaceViolationPolicy.NO_INSERTS);
Review comment:
Turn this into a for-loop with `SpaceViolationPolicy.values()`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] joshelser commented on a change in pull request #570: HBASE-22013 SpaceQuotas - getNumRegions() returning wrong number of regions due to region replicas
joshelser commented on a change in pull request #570: HBASE-22013 SpaceQuotas -
getNumRegions() returning wrong number of regions due to region replicas
URL: https://github.com/apache/hbase/pull/570#discussion_r320883609
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestSpaceQuotasWithRegionReplicas.java
##
@@ -0,0 +1,119 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.quotas;
+
+import java.util.concurrent.atomic.AtomicLong;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtility;
+import org.apache.hadoop.hbase.NamespaceDescriptor;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.Put;
+import org.apache.hadoop.hbase.testclassification.MediumTests;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.junit.AfterClass;
+import org.junit.Before;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.TestName;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+@Category(MediumTests.class)
+public class TestSpaceQuotasWithRegionReplicas {
+
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+ HBaseClassTestRule.forClass(TestSpaceQuotasWithRegionReplicas.class);
+
+ private static final Logger LOG =
+ LoggerFactory.getLogger(TestSpaceQuotasWithRegionReplicas.class);
+ private static final HBaseTestingUtility TEST_UTIL = new
HBaseTestingUtility();
+ private static final int NUM_RETRIES = 10;
+
+ @Rule
+ public TestName testName = new TestName();
+ private SpaceQuotaHelperForTests helper;
+
+ @BeforeClass
+ public static void setUp() throws Exception {
+Configuration conf = TEST_UTIL.getConfiguration();
+SpaceQuotaHelperForTests.updateConfigForQuotas(conf);
+TEST_UTIL.startMiniCluster(1);
+ }
+
+ @AfterClass
+ public static void tearDown() throws Exception {
+TEST_UTIL.shutdownMiniCluster();
+ }
+
+ @Before
+ public void removeAllQuotas() throws Exception {
+helper = new SpaceQuotaHelperForTests(TEST_UTIL, testName, new
AtomicLong(0));
+helper.removeAllQuotas();
+ }
+
+ @Test
+ public void testSetQuotaWithRegionReplicaSingleRegion() throws Exception {
+setQuotaAndVerifyForRegionReplication(1, 2,
SpaceViolationPolicy.NO_INSERTS);
+setQuotaAndVerifyForRegionReplication(1, 2,
SpaceViolationPolicy.NO_WRITES);
+setQuotaAndVerifyForRegionReplication(1, 2,
SpaceViolationPolicy.NO_WRITES_COMPACTIONS);
+setQuotaAndVerifyForRegionReplication(1, 2, SpaceViolationPolicy.DISABLE);
+ }
+
+ @Test
+ public void testSetQuotaWithRegionReplicaMultipleRegion() throws Exception {
+setQuotaAndVerifyForRegionReplication(5, 3,
SpaceViolationPolicy.NO_INSERTS);
+setQuotaAndVerifyForRegionReplication(6, 3,
SpaceViolationPolicy.NO_WRITES);
+setQuotaAndVerifyForRegionReplication(6, 3,
SpaceViolationPolicy.NO_WRITES_COMPACTIONS);
+setQuotaAndVerifyForRegionReplication(6, 3, SpaceViolationPolicy.DISABLE);
+ }
+
+ @Test
+ public void testSetQuotaWithSingleRegionZeroRegionReplica() throws Exception
{
+setQuotaAndVerifyForRegionReplication(1, 0,
SpaceViolationPolicy.NO_INSERTS);
+setQuotaAndVerifyForRegionReplication(1, 0,
SpaceViolationPolicy.NO_WRITES);
+setQuotaAndVerifyForRegionReplication(1, 0,
SpaceViolationPolicy.NO_WRITES_COMPACTIONS);
+setQuotaAndVerifyForRegionReplication(1, 0, SpaceViolationPolicy.DISABLE);
+ }
+
+ @Test
+ public void testSetQuotaWithMultipleRegionZeroRegionReplicas() throws
Exception {
+setQuotaAndVerifyForRegionReplication(5, 0,
SpaceViolationPolicy.NO_INSERTS);
+setQuotaAndVerifyForRegionReplication(6, 0,
SpaceViolationPolicy.NO_WRITES);
+setQuotaAndVerifyForRegionReplication(6, 0,
SpaceViolationPolicy.NO_WRITES_COMPACTIONS);
+setQuotaAndVerifyForRegionReplication(6, 0, SpaceViolationPolicy.DISABLE);
+ }
+
+ private void setQuotaAndVerifyForRegionReplication(int region, int
replicatedRegion,
+ SpaceViolationPolicy policy) throws Exception {
+
[jira] [Commented] (HBASE-22701) Better handle invalid local directory for DynamicClassLoader
[
https://issues.apache.org/jira/browse/HBASE-22701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922703#comment-16922703
]
Josh Elser commented on HBASE-22701:
Ankit and/or Anoop – still good with v3?
> Better handle invalid local directory for DynamicClassLoader
>
>
> Key: HBASE-22701
> URL: https://issues.apache.org/jira/browse/HBASE-22701
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Major
> Fix For: 2.3.0, 2.1.7, 2.2.2
>
> Attachments: HBASE-22701.001.patch, HBASE-22701.002.patch,
> HBASE-22701.003.patch
>
>
> If you give HBase an {{hbase.local.dir}} (usually, "{{hbase.tmp.dir}}/local")
> which is not writable to it, you will get some weird errors on the scan path.
> I just saw this (again?) with Phoenix.
> Specifically, the first attempt to reference DynamicClassLoader (via
> ProtobufUtil), will result in an ExceptionInInitializationError because the
> unchecked exception coming out of DynamicClassLoader's constructor interrupts
> the loading of {{DynamicClassLoader.class}}.
> {noformat}
> 2019-07-14 06:25:34,284 ERROR
> [RpcServer.Metadata.Fifo.handler=12,queue=0,port=16020]
> coprocessor.MetaDataEndpointImpl: dropTable failed
> org.apache.hadoop.hbase.DoNotRetryIOException:
> java.lang.ExceptionInInitializerError
> at
> org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.translateException(RpcRetryingCallerImpl.java:221)
> at
> org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithoutRetries(RpcRetryingCallerImpl.java:194)
> at
> org.apache.hadoop.hbase.client.ScannerCallableWithReplicas$RetryingRPC.call(ScannerCallableWithReplicas.java:387)
> at
> org.apache.hadoop.hbase.client.ScannerCallableWithReplicas$RetryingRPC.call(ScannerCallableWithReplicas.java:361)
> at
> org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:107)
> at
> org.apache.hadoop.hbase.client.ResultBoundedCompletionService$QueueingFuture.run(ResultBoundedCompletionService.java:80)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: java.lang.ExceptionInInitializerError
> at
> org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.toFilter(ProtobufUtil.java:1598)
> at
> org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.toScan(ProtobufUtil.java:1152)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.newRegionScanner(RSRpcServices.java:2967)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:3301)
> at
> org.apache.hadoop.hbase.client.ScannerCallable.openScanner(ScannerCallable.java:332)
> at
> org.apache.hadoop.hbase.client.ScannerCallable.rpcCall(ScannerCallable.java:242)
> at
> org.apache.hadoop.hbase.client.ScannerCallable.rpcCall(ScannerCallable.java:58)
> at
> org.apache.hadoop.hbase.client.RegionServerCallable.call(RegionServerCallable.java:127)
> at
> org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithoutRetries(RpcRetryingCallerImpl.java:192)
> ... 7 more
> Caused by: java.lang.RuntimeException: Failed to create local dir
> /hadoopfs/fs1/hbase/local/jars, DynamicClassLoader failed to init
> at
> org.apache.hadoop.hbase.util.DynamicClassLoader.initTempDir(DynamicClassLoader.java:110)
> at
> org.apache.hadoop.hbase.util.DynamicClassLoader.(DynamicClassLoader.java:98)
> at
> org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil$ClassLoaderHolder.lambda$static$0(ProtobufUtil.java:261)
> at java.security.AccessController.doPrivileged(Native Method)
> at
> org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil$ClassLoaderHolder.(ProtobufUtil.java:260)
> ... 16 more
> {noformat}
> Every subsequent call will result in a NoClassDefFoundError, because we
> already tried to load DynamicClassLoader.class once and failed.
> {noformat}
> 2019-07-14 06:25:34,380 ERROR
> [RpcServer.Metadata.Fifo.handler=2,queue=2,port=16020]
> coprocessor.MetaDataEndpointImpl: dropTable failed
> org.apache.hadoop.hbase.DoNotRetryIOException:
> java.lang.NoClassDefFoundError: Could not initialize class
> org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil$ClassLoaderHolder
> at
> org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.translateException(RpcRetryingCallerImpl.java:221)
> at
> org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithoutRetries(RpcRetryingCallerImpl.java:194)
>
[GitHub] [hbase] joshelser commented on a change in pull request #570: HBASE-22013 SpaceQuotas - getNumRegions() returning wrong number of regions due to region replicas
joshelser commented on a change in pull request #570: HBASE-22013 SpaceQuotas -
getNumRegions() returning wrong number of regions due to region replicas
URL: https://github.com/apache/hbase/pull/570#discussion_r320882392
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/QuotaObserverChore.java
##
@@ -764,6 +765,9 @@ int getNumRegions(TableName table) throws IOException {
List regions = this.conn.getAdmin().getRegions(table);
if (regions == null) {
return 0;
+ } else {
Review comment:
Nit: the `else` branch is unnecessary. Just make this `if (regions==null)
{return 0;} RegionReplicaUtil...` (but properly formatted).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Updated] (HBASE-22973) Update REST Section of Ref Guide to describe supported Content-type/Accept
[ https://issues.apache.org/jira/browse/HBASE-22973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-22973: - Status: Patch Available (was: Open) > Update REST Section of Ref Guide to describe supported Content-type/Accept > -- > > Key: HBASE-22973 > URL: https://issues.apache.org/jira/browse/HBASE-22973 > Project: HBase > Issue Type: Improvement > Components: documentation > Environment: HBase REST API Endpoints section should detail the > expected Content-type and Accept for each resource, as this may influence on > the expected result. > This also fixes some minor typos among the description/examples defined on > this section. >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Minor > Attachments: HBASE-22973.master.0001.patch > > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (HBASE-22973) Update REST Section of Ref Guide to describe supported Content-type/Accept
[ https://issues.apache.org/jira/browse/HBASE-22973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-22973: - Attachment: HBASE-22973.master.0001.patch > Update REST Section of Ref Guide to describe supported Content-type/Accept > -- > > Key: HBASE-22973 > URL: https://issues.apache.org/jira/browse/HBASE-22973 > Project: HBase > Issue Type: Improvement > Components: documentation > Environment: HBase REST API Endpoints section should detail the > expected Content-type and Accept for each resource, as this may influence on > the expected result. > This also fixes some minor typos among the description/examples defined on > this section. >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Minor > Attachments: HBASE-22973.master.0001.patch > > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Created] (HBASE-22973) Update REST Section of Ref Guide to describe supported Content-type/Accept
Wellington Chevreuil created HBASE-22973: Summary: Update REST Section of Ref Guide to describe supported Content-type/Accept Key: HBASE-22973 URL: https://issues.apache.org/jira/browse/HBASE-22973 Project: HBase Issue Type: Improvement Components: documentation Environment: HBase REST API Endpoints section should detail the expected Content-type and Accept for each resource, as this may influence on the expected result. This also fixes some minor typos among the description/examples defined on this section. Reporter: Wellington Chevreuil Assignee: Wellington Chevreuil -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase-operator-tools] busbey commented on a change in pull request #18: HBASE-22567 - HBCK2 addMissingRegionsToMeta
busbey commented on a change in pull request #18: HBASE-22567 - HBCK2 addMissingRegionsToMeta URL: https://github.com/apache/hbase-operator-tools/pull/18#discussion_r320873317 ## File path: hbase-hbck2/src/main/java/org/apache/hbase/hbck2/meta/MetaFixer.java ## @@ -0,0 +1,130 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hbase.hbck2.meta; Review comment: I don't want us to bounce back and forth here, but in the future we'll probably have to add all of these into some subpackage, wether that's `hbck2` or otherwise in order to do proper jar sealing in our build process. Sealed jars require that a given package not span multiple jars, so we'd need to deconflict with the jars in the main project. I'm happy to have that done later since we already have stuff in this repo that will need to get fixed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-operator-tools] wchevreuil commented on a change in pull request #18: HBASE-22567 - HBCK2 addMissingRegionsToMeta
wchevreuil commented on a change in pull request #18: HBASE-22567 - HBCK2
addMissingRegionsToMeta
URL:
https://github.com/apache/hbase-operator-tools/pull/18#discussion_r320871970
##
File path: hbase-hbck2/src/main/java/org/apache/hbase/hbck2/meta/MetaFixer.java
##
@@ -0,0 +1,130 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hbase.hbck2.meta;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FileStatus;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.MetaTableAccessor;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.Connection;
+import org.apache.hadoop.hbase.client.ConnectionFactory;
+import org.apache.hadoop.hbase.client.RegionInfo;
+import org.apache.hadoop.hbase.regionserver.HRegionFileSystem;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+import java.io.Closeable;
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.stream.Collectors;
+
+/**
+ * This class implements the inner works required for check and recover
regions that wrongly
+ * went missing in META. It assumes HDFS state as the source of truth, in
other words,
+ * methods provided here consider meta information found on HDFS region dirs
as the valid ones.
+ */
+public class MetaFixer implements Closeable {
+ private static final String TABLE_DESC_FILE = ".tabledesc";
+ private static final Logger LOG = LogManager.getLogger(MetaFixer.class);
+ private final FileSystem fs;
+ private final Connection conn;
+ private final Configuration config;
+
+ public MetaFixer(Configuration configuration) throws IOException {
+this.config = configuration;
+this.fs = FileSystem.get(configuration);
Review comment:
Addressed on last commit.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase-operator-tools] wchevreuil commented on a change in pull request #18: HBASE-22567 - HBCK2 addMissingRegionsToMeta
wchevreuil commented on a change in pull request #18: HBASE-22567 - HBCK2
addMissingRegionsToMeta
URL:
https://github.com/apache/hbase-operator-tools/pull/18#discussion_r320864805
##
File path: hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java
##
@@ -334,6 +444,58 @@ private static final String getCommandUsage() {
writer.println(" Returns \"0\" SUCCESS code if it informed region state
is changed, "
+ "\"1\" FAIL code otherwise.");
writer.println();
+writer.println(" " + ADD_MISSING_REGIONS_IN_META_FOR_TABLES + "
...");
+writer.println(" To be used in scenarios where some regions may be
missing in META,");
+writer.println(" but there's still a valid 'regioninfo metadata file on
HDFS. ");
+writer.println(" This is a lighter version of 'OfflineMetaRepair tool
commonly used for ");
+writer.println(" similar issues on 1.x release line. ");
+writer.println(" This command needs META to be online. For each table
name passed as");
+writer.println(" parameter, it performs a diff between regions available
in META, ");
+writer.println(" against existing regions dirs on HDFS. Then, for region
dirs with ");
+writer.println(" no matches in META, it reads regioninfo metadata file
and ");
+writer.println(" re-creates given region in META. Regions are re-created
in 'CLOSED' ");
+writer.println(" state at META table only, but not in Masters' cache,
and are not ");
+writer.println(" assigned either. A rolling Masters restart, followed by
a ");
+writer.println(" hbck2 'assigns' command with all re-inserted regions is
required. ");
Review comment:
Addressed in last commit.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] joshelser commented on a change in pull request #571: HBASE-20821 Re-creating a dropped namespace and contained table inherits previously set space quota settings
joshelser commented on a change in pull request #571: HBASE-20821 Re-creating a
dropped namespace and contained table inherits previously set space quota
settings
URL: https://github.com/apache/hbase/pull/571#discussion_r320857047
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/QuotaUtil.java
##
@@ -456,6 +470,46 @@ private static TimedQuota updateTimedQuota(TimedQuota
timedQuota, double factor)
double getFactor(T t);
}
+ /**
+ * Method to return the space quotas defined on a given table.
+ *
+ * @param conn connection
+ * @param tn tablename
+ * @return returns space quota settings defined on the table tn otherwise
null.
+ * @throws IOException throws IOException
+ */
+ public static QuotaSettings getTableSpaceQuota(Connection conn, TableName
tn) throws IOException {
+try (QuotaRetriever scanner = QuotaRetriever
+.open(conn.getConfiguration(), new
QuotaFilter().setTableFilter(tn.getNameAsString( {
+ for (QuotaSettings setting : scanner) {
+if (setting.getTableName().equals(tn) && setting.getQuotaType() ==
QuotaType.SPACE) {
Review comment:
Checking the table name is unnecessary if you set the table filter above.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] joshelser commented on a change in pull request #571: HBASE-20821 Re-creating a dropped namespace and contained table inherits previously set space quota settings
joshelser commented on a change in pull request #571: HBASE-20821 Re-creating a
dropped namespace and contained table inherits previously set space quota
settings
URL: https://github.com/apache/hbase/pull/571#discussion_r320858193
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/QuotaUtil.java
##
@@ -117,6 +118,19 @@ public static void addNamespaceQuota(final Connection
connection, final String n
public static void deleteNamespaceQuota(final Connection connection, final
String namespace)
throws IOException {
+// Before removing namespace quota , remove quota from the tables inside
the namespace
+// which does not have explicit space quotas defined on them.
+TableName[] tableNames = QuotaUtil.listTableNamesByNamepsace(connection,
namespace);
Review comment:
This case should never happen. You can't delete a namespace which has tables
in it. If we're cleaning up a namespace, we shouldn't have any table-level
quotas hanging around.
Please log a `WARN` stating that we found a quota entry that shouldn't exist
and that we're going to remove it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] joshelser commented on a change in pull request #571: HBASE-20821 Re-creating a dropped namespace and contained table inherits previously set space quota settings
joshelser commented on a change in pull request #571: HBASE-20821 Re-creating a
dropped namespace and contained table inherits previously set space quota
settings
URL: https://github.com/apache/hbase/pull/571#discussion_r320862275
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestSpaceQuotasAtNamespaceLevel.java
##
@@ -0,0 +1,143 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.quotas;
+
+
+import java.util.Map;
+import java.util.concurrent.atomic.AtomicLong;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtility;
+import org.apache.hadoop.hbase.NamespaceDescriptor;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.testclassification.MediumTests;
+import org.junit.After;
+import org.junit.AfterClass;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.TestName;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@Category(MediumTests.class)
+public class TestSpaceQuotasAtNamespaceLevel {
Review comment:
I don't feel like this is testing the bug you originally described.
I would expect to see a test:
* Create a namespace
* Set a space quota
* Validate that the space quota is set
* _any extra validation that space quota is taking effect_
* Drop the namespace
* Create namespace with same name
* Validate that space quota does not exist for the namespace
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] joshelser commented on a change in pull request #571: HBASE-20821 Re-creating a dropped namespace and contained table inherits previously set space quota settings
joshelser commented on a change in pull request #571: HBASE-20821 Re-creating a
dropped namespace and contained table inherits previously set space quota
settings
URL: https://github.com/apache/hbase/pull/571#discussion_r320861097
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestSpaceQuotasAtNamespaceLevel.java
##
@@ -0,0 +1,143 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.quotas;
+
+
+import java.util.Map;
+import java.util.concurrent.atomic.AtomicLong;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtility;
+import org.apache.hadoop.hbase.NamespaceDescriptor;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.testclassification.MediumTests;
+import org.junit.After;
+import org.junit.AfterClass;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.TestName;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@Category(MediumTests.class)
+public class TestSpaceQuotasAtNamespaceLevel {
+
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+ HBaseClassTestRule.forClass(TestSpaceQuotasAtNamespaceLevel.class);
+
+ private static final Logger LOG =
LoggerFactory.getLogger(TestSpaceQuotasAtNamespaceLevel.class);
+ private static final HBaseTestingUtility TEST_UTIL = new
HBaseTestingUtility();
+
+ @Rule
+ public TestName testName = new TestName();
+ private SpaceQuotaHelperForTests helper;
+
+ @BeforeClass
+ public static void setUp() throws Exception {
+Configuration conf = TEST_UTIL.getConfiguration();
+SpaceQuotaHelperForTests.updateConfigForQuotas(conf);
+TEST_UTIL.startMiniCluster(1);
+ }
+
+ @AfterClass
+ public static void tearDown() throws Exception {
+TEST_UTIL.shutdownMiniCluster();
+ }
+
+ @Before
+ public void removeAllQuotas() throws Exception {
+helper = new SpaceQuotaHelperForTests(TEST_UTIL, testName, new
AtomicLong(0));
+helper.removeAllQuotas();
+ }
+
+ @After
+ public void removeQuotas() throws Exception {
+helper.removeAllQuotas();
+ }
+
+ @Test
+ public void testSetNamespaceQuotaAndRemove() throws Exception {
+NamespaceDescriptor nd = helper.createNamespace();
+TableName table = helper.createTableInNamespace(nd);
+
+// Set quota on namespace.
+helper.setQuotaLimitNamespace(nd.getName(),
SpaceViolationPolicy.NO_WRITES, 2L);
+
+// Sufficient time for all the chores to run
+Thread.sleep(5000);
+
+// Get Current Snapshot from 'hbase:quota'
+Map snapshotMap =
+QuotaTableUtil.getSnapshots(TEST_UTIL.getConnection());
+
+// After setting quota on namespace, 'hbase:quota' should have some
entries present.
+Assert.assertEquals(1, snapshotMap.size());
+
+helper.removeQuotaFromNamespace(nd.getName());
+
+// Get Current Snapshot from 'hbase:quota'
+snapshotMap = QuotaTableUtil.getSnapshots(TEST_UTIL.getConnection());
+
+// After removing quota on namespace, 'hbase:quota' should not have any
entry present.
+Assert.assertEquals(0, snapshotMap.size());
+
+// drop table and namespace.
+TEST_UTIL.getAdmin().disableTable(table);
+TEST_UTIL.getAdmin().deleteTable(table);
+TEST_UTIL.getAdmin().deleteNamespace(nd.getName());
+ }
+
+ @Test
+ public void testDropTableInNamespaceQuota() throws Exception {
+NamespaceDescriptor nd = helper.createNamespace();
+TableName table = helper.createTableInNamespace(nd);
+
+// Set quota on namespace.
+helper.setQuotaLimitNamespace(nd.getName(),
SpaceViolationPolicy.NO_WRITES, 2L);
+
+// write some data.
+helper.writeData(table,SpaceQuotaHelperForTests.ONE_KILOBYTE);
+
+// Sufficient time for all the chores to run
+Thread.sleep(5000);
+
+// Get Current Snapshot from 'hbase:quota'
+Map snapshotMap =
+QuotaTableUtil.getSnapshots(TEST_UTIL.getConnection());
+
+// Table before drop should have entry in 'hbase:quota'
+As
[GitHub] [hbase] joshelser commented on a change in pull request #571: HBASE-20821 Re-creating a dropped namespace and contained table inherits previously set space quota settings
joshelser commented on a change in pull request #571: HBASE-20821 Re-creating a
dropped namespace and contained table inherits previously set space quota
settings
URL: https://github.com/apache/hbase/pull/571#discussion_r320855631
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/QuotaUtil.java
##
@@ -456,6 +470,46 @@ private static TimedQuota updateTimedQuota(TimedQuota
timedQuota, double factor)
double getFactor(T t);
}
+ /**
+ * Method to return the space quotas defined on a given table.
+ *
+ * @param conn connection
+ * @param tn tablename
+ * @return returns space quota settings defined on the table tn otherwise
null.
+ * @throws IOException throws IOException
+ */
+ public static QuotaSettings getTableSpaceQuota(Connection conn, TableName
tn) throws IOException {
+try (QuotaRetriever scanner = QuotaRetriever
+.open(conn.getConfiguration(), new
QuotaFilter().setTableFilter(tn.getNameAsString( {
+ for (QuotaSettings setting : scanner) {
+if (setting.getTableName().equals(tn) && setting.getQuotaType() ==
QuotaType.SPACE) {
+ return setting;
+}
+ }
+ return null;
+}
+ }
+
+ /**
+ * Retrieve list of tables for the given namespace.
+ *
+ * @param connection Connection
+ * @param namespace name of the namespace
+ * @return list of tables present inside the namespace otherwise returns
null.
+ * @throws IOException throws IOException
+ */
+ public static TableName[] listTableNamesByNamepsace(final Connection
connection, String namespace)
Review comment:
Seems unnecessary to break this out into its own method if the only consumer
is `deleteNamespaceQuota`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] joshelser commented on a change in pull request #571: HBASE-20821 Re-creating a dropped namespace and contained table inherits previously set space quota settings
joshelser commented on a change in pull request #571: HBASE-20821 Re-creating a
dropped namespace and contained table inherits previously set space quota
settings
URL: https://github.com/apache/hbase/pull/571#discussion_r320858976
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/SpaceQuotaHelperForTests.java
##
@@ -271,6 +271,17 @@ void setQuotaLimit(final TableName tn,
SpaceViolationPolicy policy, long sizeInM
LOG.debug("Quota limit set for table = {}, limit = {}", tn, sizeLimit);
}
+ /**
+ * Sets the given quota (policy & limit) on the passed namespace.
+ */
+ void setQuotaLimitNamespace(final String namespace, SpaceViolationPolicy
policy, long sizeInMBs)
Review comment:
Can you please fix `setQuotaLimit()` and `removeQuotaFromtable` to be
consistent with these new methods?
e.g. `setQuotaLimitTable()` and `removeQuotaFromTable()`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] joshelser commented on a change in pull request #571: HBASE-20821 Re-creating a dropped namespace and contained table inherits previously set space quota settings
joshelser commented on a change in pull request #571: HBASE-20821 Re-creating a
dropped namespace and contained table inherits previously set space quota
settings
URL: https://github.com/apache/hbase/pull/571#discussion_r320860033
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestSpaceQuotasAtNamespaceLevel.java
##
@@ -0,0 +1,143 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.quotas;
+
+
+import java.util.Map;
+import java.util.concurrent.atomic.AtomicLong;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtility;
+import org.apache.hadoop.hbase.NamespaceDescriptor;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.testclassification.MediumTests;
+import org.junit.After;
+import org.junit.AfterClass;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.TestName;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@Category(MediumTests.class)
+public class TestSpaceQuotasAtNamespaceLevel {
+
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+ HBaseClassTestRule.forClass(TestSpaceQuotasAtNamespaceLevel.class);
+
+ private static final Logger LOG =
LoggerFactory.getLogger(TestSpaceQuotasAtNamespaceLevel.class);
+ private static final HBaseTestingUtility TEST_UTIL = new
HBaseTestingUtility();
+
+ @Rule
+ public TestName testName = new TestName();
+ private SpaceQuotaHelperForTests helper;
+
+ @BeforeClass
+ public static void setUp() throws Exception {
+Configuration conf = TEST_UTIL.getConfiguration();
+SpaceQuotaHelperForTests.updateConfigForQuotas(conf);
+TEST_UTIL.startMiniCluster(1);
+ }
+
+ @AfterClass
+ public static void tearDown() throws Exception {
+TEST_UTIL.shutdownMiniCluster();
+ }
+
+ @Before
+ public void removeAllQuotas() throws Exception {
+helper = new SpaceQuotaHelperForTests(TEST_UTIL, testName, new
AtomicLong(0));
+helper.removeAllQuotas();
+ }
+
+ @After
+ public void removeQuotas() throws Exception {
+helper.removeAllQuotas();
+ }
+
+ @Test
+ public void testSetNamespaceQuotaAndRemove() throws Exception {
+NamespaceDescriptor nd = helper.createNamespace();
+TableName table = helper.createTableInNamespace(nd);
+
+// Set quota on namespace.
+helper.setQuotaLimitNamespace(nd.getName(),
SpaceViolationPolicy.NO_WRITES, 2L);
+
+// Sufficient time for all the chores to run
+Thread.sleep(5000);
Review comment:
:-1: please change this to explicitly poll the state that you expect to see.
There are lots of other quota test examples which show how to wait on the state
to change (e.g. `fgrep -R waitFor
hbase-server/src/test/java/org/apache/hadoop/hbase/quotas`).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] joshelser commented on a change in pull request #571: HBASE-20821 Re-creating a dropped namespace and contained table inherits previously set space quota settings
joshelser commented on a change in pull request #571: HBASE-20821 Re-creating a
dropped namespace and contained table inherits previously set space quota
settings
URL: https://github.com/apache/hbase/pull/571#discussion_r320854576
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/MasterQuotasObserver.java
##
@@ -78,6 +79,20 @@ public void postDeleteTable(
admin.setQuota(settings);
}
}
+} else if (quotasAtNamespace != null) {
+ // If quota present at namespace level remove the table entry from
'hbase:quota'
Review comment:
Why is this in `postDeleteTable`? The quota should be dropped if the
namespace is dropped, which should happen in `postDeleteNamespace`, right?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase-operator-tools] wchevreuil commented on a change in pull request #18: HBASE-22567 - HBCK2 addMissingRegionsToMeta
wchevreuil commented on a change in pull request #18: HBASE-22567 - HBCK2 addMissingRegionsToMeta URL: https://github.com/apache/hbase-operator-tools/pull/18#discussion_r320854321 ## File path: hbase-hbck2/src/main/java/org/apache/hbase/hbck2/meta/MetaFixer.java ## @@ -0,0 +1,130 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hbase.hbck2.meta; Review comment: Addressed on last commit. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase-operator-tools] wchevreuil commented on a change in pull request #18: HBASE-22567 - HBCK2 addMissingRegionsToMeta
wchevreuil commented on a change in pull request #18: HBASE-22567 - HBCK2
addMissingRegionsToMeta
URL:
https://github.com/apache/hbase-operator-tools/pull/18#discussion_r320854169
##
File path: hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java
##
@@ -164,6 +178,102 @@ int setRegionState(String region, RegionState.State
newState)
return EXIT_FAILURE;
}
+ Map> reportTablesWithMissingRegionsInMeta(String...
nameSpaceOrTable)
+ throws Exception {
+Map> report;
+try(final MetaFixer metaFixer = new MetaFixer(this.conf)){
+ List names = nameSpaceOrTable != null ?
Arrays.asList(nameSpaceOrTable) : null;
+ report = metaFixer.reportTablesMissingRegions(names);
+} catch (Exception e) {
+ LOG.error("Error reporting missing regions: ", e);
+ throw e;
+}
+if(LOG.isDebugEnabled()) {
+ LOG.debug(formatMissingRegionsInMetaReport(report));
+}
+return report;
+ }
+
+ List addMissingRegionsInMeta(List regionsPath) throws
IOException {
+List reAddedRegionsEncodedNames = new ArrayList<>();
+try(final MetaFixer metaFixer = new MetaFixer(this.conf)){
+ for(Path regionPath : regionsPath){
+metaFixer.putRegionInfoFromHdfsInMeta(regionPath);
+reAddedRegionsEncodedNames.add(regionPath.getName());
+ }
+}
+return reAddedRegionsEncodedNames;
+ }
+
+ Pair, List>
addMissingRegionsInMetaForTables(String...
+ nameSpaceOrTable) {
+ExecutorService executorService = Executors.newFixedThreadPool(
+ (nameSpaceOrTable == null ||
+nameSpaceOrTable.length > Runtime.getRuntime().availableProcessors()) ?
+ Runtime.getRuntime().availableProcessors() :
+ nameSpaceOrTable.length);
+List>> futures = new ArrayList<>( nameSpaceOrTable ==
null ? 1 :
+ nameSpaceOrTable.length);
+final List readdedRegionNames = new ArrayList<>();
+List executionErrors = new ArrayList<>();
+try {
+ //reducing number of retries in case disable fails due to namespace
table region also missing
+ this.conf.setInt(HConstants.HBASE_CLIENT_RETRIES_NUMBER, 1);
+ try(Connection conn = ConnectionFactory.createConnection(this.conf);
+final Admin admin = conn.getAdmin()) {
+Map> report =
reportTablesWithMissingRegionsInMeta(nameSpaceOrTable);
+for (TableName tableName : report.keySet()) {
+ if(admin.tableExists(tableName)) {
+futures.add(executorService.submit(new Callable>() {
+ @Override
+ public List call() throws Exception {
+LOG.debug("running thread for {}",
tableName.getNameWithNamespaceInclAsString());
+try {
+ admin.disableTable(tableName);
Review comment:
My motivation with disabling is trying to minimise potential extra problems
due to splitting or merging, that may occur in a situation a table is missing
regions but is still being written to or manipulated by client applications.
> So, if table fails disable, you dump out regions to assign but table could
be in DISABLING state?
That's a possibility indeed, and assigns would then fail, but I believe the
errors printed by assigns would give some clues, and operator could use extra
hbck2 or hbase shell commands to get it sorted.
Would you think is wort to remove this extra disable/enable steps?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-22930) Set unique name to longCompactions/shortCompactions threads
[
https://issues.apache.org/jira/browse/HBASE-22930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922641#comment-16922641
]
Pankaj Kumar commented on HBASE-22930:
--
{quote}And drop the currentTime noise?
{quote}
Yeah, can be done. Will do it for all three
(longCompactions/shortCompactions/splits) threads.
> Set unique name to longCompactions/shortCompactions threads
> ---
>
> Key: HBASE-22930
> URL: https://issues.apache.org/jira/browse/HBASE-22930
> Project: HBase
> Issue Type: Improvement
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>
>
> Sometime observed multiple compaction threads have the same name which is
> misleading while analysing the log.
> Currently we just append the current timestamp which can be same for multiple
> threads,
> [https://github.com/apache/hbase/blob/ec68bf30ba91ea7484d3b56b0809ff5434f9406e/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java#L144]
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Reopened] (HBASE-22930) Set unique name to longCompactions/shortCompactions threads
[ https://issues.apache.org/jira/browse/HBASE-22930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack reopened HBASE-22930: --- Reopening because reverting the merged PR in favor of a better fix. > Set unique name to longCompactions/shortCompactions threads > --- > > Key: HBASE-22930 > URL: https://issues.apache.org/jira/browse/HBASE-22930 > Project: HBase > Issue Type: Improvement >Reporter: Pankaj Kumar >Assignee: Pankaj Kumar >Priority: Minor > Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2 > > > Sometime observed multiple compaction threads have the same name which is > misleading while analysing the log. > Currently we just append the current timestamp which can be same for multiple > threads, > [https://github.com/apache/hbase/blob/ec68bf30ba91ea7484d3b56b0809ff5434f9406e/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java#L144] -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HBASE-22930) Set unique name to longCompactions/shortCompactions threads
[ https://issues.apache.org/jira/browse/HBASE-22930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922638#comment-16922638 ] stack commented on HBASE-22930: --- And drop the currentTime noise? Ok. Let me revert what was up in the PR. Thanks for jumping in. > Set unique name to longCompactions/shortCompactions threads > --- > > Key: HBASE-22930 > URL: https://issues.apache.org/jira/browse/HBASE-22930 > Project: HBase > Issue Type: Improvement >Reporter: Pankaj Kumar >Assignee: Pankaj Kumar >Priority: Minor > Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2 > > > Sometime observed multiple compaction threads have the same name which is > misleading while analysing the log. > Currently we just append the current timestamp which can be same for multiple > threads, > [https://github.com/apache/hbase/blob/ec68bf30ba91ea7484d3b56b0809ff5434f9406e/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java#L144] -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [hbase] pankaj72981 commented on issue #544: HBASE-22917 Proc-WAL roll fails saying someone else has already created log
pankaj72981 commented on issue #544: HBASE-22917 Proc-WAL roll fails saying someone else has already created log URL: https://github.com/apache/hbase/pull/544#issuecomment-527975459 > I'd say that the fencing logic is a bit tricky here(I mean how do we know that another master has already become the active one and we should give up), so maybe increasing the flushLogId is not safe here. I do not mean this is not right, I'm just not sure... > However Hmaster failover will resolve this issue, but we should handle it. Thanks @Apache9 for looking into this issue, I meant to say that current active HMaster will keep trying infinetly to roll the WAL with same flushLogId, which will fail always as WAL file already exist (since file was not delted on header write failure). On master failover we reinit the flushLogId based on the existing proc-wal file and new proc-wal will be created, so this workaround for this problem is HMaster failover. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Comment Edited] (HBASE-22930) Set unique name to longCompactions/shortCompactions threads
[
https://issues.apache.org/jira/browse/HBASE-22930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922635#comment-16922635
]
Pankaj Kumar edited comment on HBASE-22930 at 9/4/19 4:14 PM:
--
Pardon [~stack] sir, I think we should use ThreadFactoryBuilder's internal
counter instead of explicit AtomicInteger counter.
{color:#de350b}{{new ThreadFactoryBuilder().setNameFormat(n +
"shortCompactions%d-" + EnvironmentEdgeManager.currentTime())}}{color}
Please provide your opnion.
was (Author: pankaj2461):
Pardon [~stack] sir, I think we should use ThreadFactoryBuilder's internal
counter instead of explicit AtomicInteger counter.
{color:#de350b}{{new ThreadFactoryBuilder().setNameFormat(n +
"-shortCompactions-%d-" + EnvironmentEdgeManager.currentTime())}}{color}
Please provide your opnion.
> Set unique name to longCompactions/shortCompactions threads
> ---
>
> Key: HBASE-22930
> URL: https://issues.apache.org/jira/browse/HBASE-22930
> Project: HBase
> Issue Type: Improvement
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>
>
> Sometime observed multiple compaction threads have the same name which is
> misleading while analysing the log.
> Currently we just append the current timestamp which can be same for multiple
> threads,
> [https://github.com/apache/hbase/blob/ec68bf30ba91ea7484d3b56b0809ff5434f9406e/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java#L144]
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Comment Edited] (HBASE-22930) Set unique name to longCompactions/shortCompactions threads
[
https://issues.apache.org/jira/browse/HBASE-22930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16922635#comment-16922635
]
Pankaj Kumar edited comment on HBASE-22930 at 9/4/19 4:14 PM:
--
Pardon [~stack] sir, I think we should use ThreadFactoryBuilder's internal
counter instead of explicit AtomicInteger counter.
{color:#de350b}{{new ThreadFactoryBuilder().setNameFormat(n +
"shortCompactions-%d-" + EnvironmentEdgeManager.currentTime())}}{color}
Please provide your opnion.
was (Author: pankaj2461):
Pardon [~stack] sir, I think we should use ThreadFactoryBuilder's internal
counter instead of explicit AtomicInteger counter.
{color:#de350b}{{new ThreadFactoryBuilder().setNameFormat(n +
"shortCompactions%d-" + EnvironmentEdgeManager.currentTime())}}{color}
Please provide your opnion.
> Set unique name to longCompactions/shortCompactions threads
> ---
>
> Key: HBASE-22930
> URL: https://issues.apache.org/jira/browse/HBASE-22930
> Project: HBase
> Issue Type: Improvement
>Reporter: Pankaj Kumar
>Assignee: Pankaj Kumar
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.1.7, 2.2.2
>
>
> Sometime observed multiple compaction threads have the same name which is
> misleading while analysing the log.
> Currently we just append the current timestamp which can be same for multiple
> threads,
> [https://github.com/apache/hbase/blob/ec68bf30ba91ea7484d3b56b0809ff5434f9406e/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java#L144]
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
