[jira] [Commented] (HBASE-23806) Provide a much faster and efficient alternate option to maven and surefire for running tests.
[ https://issues.apache.org/jira/browse/HBASE-23806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17037448#comment-17037448 ] Mark Robert Miller commented on HBASE-23806: While things have been getting better over the years, build and test running tools in general have not gone very far down the road of good efficiency. In my experience, Gradle easily leads the pack, Maven is trying to match with similiar features, but it's a turbo charger on an Eclipse vs a solid Audi at best. But Gradle is mostly living off what it's done for build, which is great, but no real focus on tests. We can do better for special occasions. > Provide a much faster and efficient alternate option to maven and surefire > for running tests. > - > > Key: HBASE-23806 > URL: https://issues.apache.org/jira/browse/HBASE-23806 > Project: HBase > Issue Type: Wish >Reporter: Mark Robert Miller >Priority: Minor > > With HBASE-23795, the hope is to drive tests with maven and surefire much > closer to their potential. > That will still leave a lot of room for improvement. > For those that have some nice hardware and a need for speed, we can blow > right past maven+surefire. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23795) Enable all tests to be run in parallel on reused JVMs.
[ https://issues.apache.org/jira/browse/HBASE-23795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17037443#comment-17037443 ] Mark Robert Miller commented on HBASE-23795: I'll start with small and medium tests in HBASE-23849 Harden small and medium tests for lots of parallel runs with re-used jvms. Good way to get some solid, easy progress before the mountain that is large tests. In the mean time, I've been working in parallel on things related to HBASE-23806 Provide a much faster and efficient alternate option to maven and surefire for running tests. Not likely to be shared any time soon, but providing it's own benefit to this related issue. > Enable all tests to be run in parallel on reused JVMs. > -- > > Key: HBASE-23795 > URL: https://issues.apache.org/jira/browse/HBASE-23795 > Project: HBase > Issue Type: Wish >Reporter: Mark Robert Miller >Priority: Major > > I'd like to be able to run HBase tests in under 30-40 minutes on good > parallel hardware. > It will require some small changes / fixes for that wish to come true. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-23849) Harden small and medium tests for lots of parallel runs with re-used jvms.
Mark Robert Miller created HBASE-23849: -- Summary: Harden small and medium tests for lots of parallel runs with re-used jvms. Key: HBASE-23849 URL: https://issues.apache.org/jira/browse/HBASE-23849 Project: HBase Issue Type: Test Reporter: Mark Robert Miller -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23631) Backport HBASE-23066, HBASE-23588, HBASE-23350 to branch-1
[ https://issues.apache.org/jira/browse/HBASE-23631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-23631: - Fix Version/s: 1.6.1 > Backport HBASE-23066, HBASE-23588, HBASE-23350 to branch-1 > -- > > Key: HBASE-23631 > URL: https://issues.apache.org/jira/browse/HBASE-23631 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.6.0 >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Fix For: 1.6.1 > > > Backport HBASE-23066 and all relevant subtasks to branch-1: > HBASE-23066: Create a config that forces to cache blocks on compaction > HBASE-23588: Cache index blocks and bloom blocks on write if > CacheCompactedBlocksOnWrite is enabled > HBASE-23350: Make compaction files cacheonWrite configurable based on > threshold -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-22749) Distributed MOB compactions
[
https://issues.apache.org/jira/browse/HBASE-22749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17037440#comment-17037440
]
HBase QA commented on HBASE-22749:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
35s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
1s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 23 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
40s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
26s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 4m
49s{color} | {color:blue} branch has no errors when building the reference
guide. See footer for rendered docs, which you should manually inspect. {color}
|
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
40s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
27s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 4m
8s{color} | {color:blue} Used deprecated FindBugs config; considering switching
to SpotBugs. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
17s{color} | {color:blue} branch/hbase-checkstyle no findbugs output file
(findbugsXml.xml) {color} |
| {color:orange}-0{color} | {color:orange} patch {color} | {color:orange} 4m
40s{color} | {color:orange} Used diff version of patch file. Binary files and
potentially other changes not applied. Please rebase and squash commits if
necessary. {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
24s{color} | {color:green} root: The patch generated 0 new + 427 unchanged - 58
fixed = 427 total (was 485) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
3s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 4m
48s{color} | {color:blue} patch has no errors when building the reference
guide. See footer for rendered docs, which you should manually inspect. {color}
|
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
44s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
16m 5s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
27s{color} | {color:green} the patch passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
14s{color} | {color:blue} hbase-checkstyle has no data from findbugs {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit
[GitHub] [hbase] Apache-HBase commented on issue #921: HBASE-22749: Distributed MOB compactions
Apache-HBase commented on issue #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#issuecomment-586562330 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 23 new or modified test files. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 40s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 15s | master passed | | +1 :green_heart: | compile | 2m 5s | master passed | | +1 :green_heart: | checkstyle | 2m 26s | master passed | | +0 :ok: | refguide | 4m 49s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | shadedjars | 4m 40s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 27s | master passed | | +0 :ok: | spotbugs | 4m 8s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +0 :ok: | findbugs | 0m 17s | branch/hbase-checkstyle no findbugs output file (findbugsXml.xml) | | -0 :warning: | patch | 4m 40s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 6s | the patch passed | | +1 :green_heart: | compile | 2m 6s | the patch passed | | +1 :green_heart: | javac | 2m 6s | the patch passed | | +1 :green_heart: | checkstyle | 2m 24s | root: The patch generated 0 new + 427 unchanged - 58 fixed = 427 total (was 485) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. | | +0 :ok: | refguide | 4m 48s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | shadedjars | 4m 44s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 16m 5s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 1m 27s | the patch passed | | +0 :ok: | findbugs | 0m 14s | hbase-checkstyle has no data from findbugs | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 14s | hbase-checkstyle in the patch passed. | | +1 :green_heart: | unit | 1m 7s | hbase-common in the patch passed. | | -1 :x: | unit | 66m 58s | hbase-server in the patch failed. | | +1 :green_heart: | unit | 1m 16s | hbase-it in the patch passed. | | +1 :green_heart: | asflicense | 2m 13s | The patch does not generate ASF License warnings. | | | | 148m 45s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.regionserver.TestTags | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-921/13/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/921 | | JIRA Issue | HBASE-22749 | | Optional Tests | dupname asflicense checkstyle javac javadoc unit xml refguide spotbugs findbugs shadedjars hadoopcheck hbaseanti compile | | uname | Linux c6a2b99c5b64 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-921/out/precommit/personality/provided.sh | | git revision | master / 0e96638898 | | Default Java | 1.8.0_181 | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-921/13/artifact/out/branch-site/book.html | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-921/13/artifact/out/patch-site/book.html | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-921/13/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-921/13/testReport/ | | Max. process+thread count | 8412 (vs. ulimit of 1) | | modules | C:
[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase
[
https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17037431#comment-17037431
]
Hudson commented on HBASE-22514:
Results for branch HBASE-22514
[build #274 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/274/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/274//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/274//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/274//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Move rsgroup feature into core of HBase
> ---
>
> Key: HBASE-22514
> URL: https://issues.apache.org/jira/browse/HBASE-22514
> Project: HBase
> Issue Type: Umbrella
> Components: Admin, Client, rsgroup
>Reporter: Yechao Chen
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22514.master.001.patch,
> image-2019-05-31-18-25-38-217.png
>
>
> The class RSGroupAdminClient is not public
> we need to use java api RSGroupAdminClient to manager RSG
> so RSGroupAdminClient should be public
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-22749) Distributed MOB compactions
[
https://issues.apache.org/jira/browse/HBASE-22749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17037425#comment-17037425
]
Hudson commented on HBASE-22749:
Results for branch HBASE-22749
[build #2 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22749/2/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22749/2//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22749/2//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22749/2//JDK8_Nightly_Build_Report_(Hadoop3)/]
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
-- Something went wrong with this stage, [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22749/2//console].
> Distributed MOB compactions
>
>
> Key: HBASE-22749
> URL: https://issues.apache.org/jira/browse/HBASE-22749
> Project: HBase
> Issue Type: New Feature
> Components: mob
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
>Priority: Major
> Attachments: HBASE-22749-branch-2.2-v4.patch,
> HBASE-22749-master-v1.patch, HBASE-22749-master-v2.patch,
> HBASE-22749-master-v3.patch, HBASE-22749-master-v4.patch,
> HBase-MOB-2.0-v3.0.pdf
>
>
> There are several drawbacks in the original MOB 1.0 (Moderate Object
> Storage) implementation, which can limit the adoption of the MOB feature:
> # MOB compactions are executed in a Master as a chore, which limits
> scalability because all I/O goes through a single HBase Master server.
> # Yarn/Mapreduce framework is required to run MOB compactions in a scalable
> way, but this won’t work in a stand-alone HBase cluster.
> # Two separate compactors for MOB and for regular store files and their
> interactions can result in a data loss (see HBASE-22075)
> The design goals for MOB 2.0 were to provide 100% MOB 1.0 - compatible
> implementation, which is free of the above drawbacks and can be used as a
> drop in replacement in existing MOB deployments. So, these are design goals
> of a MOB 2.0:
> # Make MOB compactions scalable without relying on Yarn/Mapreduce framework
> # Provide unified compactor for both MOB and regular store files
> # Make it more robust especially w.r.t. to data losses.
> # Simplify and reduce the overall MOB code.
> # Provide 100% compatible implementation with MOB 1.0.
> # No migration of data should be required between MOB 1.0 and MOB 2.0 - just
> software upgrade.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23838) Adding debug logging to a few ExportSnapshot tests
[
https://issues.apache.org/jira/browse/HBASE-23838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17037422#comment-17037422
]
Hudson commented on HBASE-23838:
Results for branch master
[build #1630 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1630/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1630//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1630//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1630//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Adding debug logging to a few ExportSnapshot tests
> --
>
> Key: HBASE-23838
> URL: https://issues.apache.org/jira/browse/HBASE-23838
> Project: HBase
> Issue Type: Bug
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Trivial
> Fix For: 3.0.0, 2.3.0
>
> Attachments:
> 0001-HBASE-23838-Adding-debug-logging-to-a-few-ExportSnap.patch
>
>
> Bit of extra logging in tests to help me diagnose where they are going wrong.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23838) Adding debug logging to a few ExportSnapshot tests
[
https://issues.apache.org/jira/browse/HBASE-23838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17037415#comment-17037415
]
Hudson commented on HBASE-23838:
Results for branch branch-2
[build #2474 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2474/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2474//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2474//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2474//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Adding debug logging to a few ExportSnapshot tests
> --
>
> Key: HBASE-23838
> URL: https://issues.apache.org/jira/browse/HBASE-23838
> Project: HBase
> Issue Type: Bug
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Trivial
> Fix For: 3.0.0, 2.3.0
>
> Attachments:
> 0001-HBASE-23838-Adding-debug-logging-to-a-few-ExportSnap.patch
>
>
> Bit of extra logging in tests to help me diagnose where they are going wrong.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-22749) Distributed MOB compactions
[
https://issues.apache.org/jira/browse/HBASE-22749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17037409#comment-17037409
]
HBase QA commented on HBASE-22749:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
33s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
1s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 23 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
36s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
7s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
26s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 4m
50s{color} | {color:blue} branch has no errors when building the reference
guide. See footer for rendered docs, which you should manually inspect. {color}
|
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
44s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
27s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 4m
20s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
17s{color} | {color:blue} branch/hbase-checkstyle no findbugs output file
(findbugsXml.xml) {color} |
| {color:orange}-0{color} | {color:orange} patch {color} | {color:orange} 4m
51s{color} | {color:orange} Used diff version of patch file. Binary files and
potentially other changes not applied. Please rebase and squash commits if
necessary. {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
24s{color} | {color:green} root: The patch generated 0 new + 427 unchanged - 58
fixed = 427 total (was 485) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 2 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
3s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 4m
53s{color} | {color:blue} patch has no errors when building the reference
guide. See footer for rendered docs, which you should manually inspect. {color}
|
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
52s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
18m 3s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
2s{color} | {color:green} the patch passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
17s{color} | {color:blue} hbase-checkstyle has no data from findbugs {color} |
|| || || ||
[GitHub] [hbase] Apache-HBase commented on issue #921: HBASE-22749: Distributed MOB compactions
Apache-HBase commented on issue #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#issuecomment-586549026 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 23 new or modified test files. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 36s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 15s | master passed | | +1 :green_heart: | compile | 2m 7s | master passed | | +1 :green_heart: | checkstyle | 2m 26s | master passed | | +0 :ok: | refguide | 4m 50s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | shadedjars | 4m 44s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 27s | master passed | | +0 :ok: | spotbugs | 4m 20s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +0 :ok: | findbugs | 0m 17s | branch/hbase-checkstyle no findbugs output file (findbugsXml.xml) | | -0 :warning: | patch | 4m 51s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 0s | the patch passed | | +1 :green_heart: | compile | 2m 4s | the patch passed | | +1 :green_heart: | javac | 2m 4s | the patch passed | | +1 :green_heart: | checkstyle | 2m 24s | root: The patch generated 0 new + 427 unchanged - 58 fixed = 427 total (was 485) | | -1 :x: | whitespace | 0m 0s | The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. | | +0 :ok: | refguide | 4m 53s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | shadedjars | 4m 52s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 18m 3s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 2m 2s | the patch passed | | +0 :ok: | findbugs | 0m 17s | hbase-checkstyle has no data from findbugs | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 17s | hbase-checkstyle in the patch passed. | | +1 :green_heart: | unit | 1m 38s | hbase-common in the patch passed. | | -1 :x: | unit | 95m 40s | hbase-server in the patch failed. | | +1 :green_heart: | unit | 1m 16s | hbase-it in the patch passed. | | +1 :green_heart: | asflicense | 2m 1s | The patch does not generate ASF License warnings. | | | | 185m 50s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.client.TestMalformedCellFromClient | | | hadoop.hbase.TestAcidGuaranteesWithAdaptivePolicy | | | hadoop.hbase.master.balancer.TestStochasticLoadBalancerRegionReplicaHighReplication | | | hadoop.hbase.security.access.TestCoprocessorWhitelistMasterObserver | | | hadoop.hbase.quotas.TestSuperUserQuotaPermissions | | | hadoop.hbase.quotas.TestQuotaObserverChoreWithMiniCluster | | | hadoop.hbase.client.TestTableFavoredNodes | | | hadoop.hbase.io.hfile.TestCacheOnWrite | | | hadoop.hbase.io.TestFileLink | | | hadoop.hbase.client.TestCloneSnapshotFromClientError | | | hadoop.hbase.quotas.TestSpaceQuotaBasicFunctioning | | | hadoop.hbase.io.asyncfs.TestSaslFanOutOneBlockAsyncDFSOutput | | | hadoop.hbase.quotas.TestSnapshotQuotaObserverChore | | | hadoop.hbase.client.TestAsyncNamespaceAdminApi | | | hadoop.hbase.client.TestSnapshotTemporaryDirectory | | | hadoop.hbase.io.asyncfs.TestOverwriteFileUnderConstruction | | | hadoop.hbase.security.TestSecureIPC | | | hadoop.hbase.quotas.TestSpaceQuotaDropTable | | | hadoop.hbase.client.TestCloneSnapshotFromClientAfterSplittingRegion | | | hadoop.hbase.quotas.TestSpaceQuotaIncrease | | |
[jira] [Commented] (HBASE-18095) Provide an option for clients to find the server hosting META that does not involve the ZooKeeper client
[
https://issues.apache.org/jira/browse/HBASE-18095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17037405#comment-17037405
]
Hudson commented on HBASE-18095:
Results for branch HBASE-18095/client-locate-meta-no-zookeeper
[build #76 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-18095%252Fclient-locate-meta-no-zookeeper/76/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-18095%252Fclient-locate-meta-no-zookeeper/76//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-18095%252Fclient-locate-meta-no-zookeeper/76//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-18095%252Fclient-locate-meta-no-zookeeper/76//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Provide an option for clients to find the server hosting META that does not
> involve the ZooKeeper client
>
>
> Key: HBASE-18095
> URL: https://issues.apache.org/jira/browse/HBASE-18095
> Project: HBase
> Issue Type: New Feature
> Components: Client
>Reporter: Andrew Kyle Purtell
>Assignee: Bharath Vissapragada
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 1.7.0
>
> Attachments: HBASE-18095.master-v1.patch, HBASE-18095.master-v2.patch
>
>
> Clients are required to connect to ZooKeeper to find the location of the
> regionserver hosting the meta table region. Site configuration provides the
> client a list of ZK quorum peers and the client uses an embedded ZK client to
> query meta location. Timeouts and retry behavior of this embedded ZK client
> are managed orthogonally to HBase layer settings and in some cases the ZK
> cannot manage what in theory the HBase client can, i.e. fail fast upon outage
> or network partition.
> We should consider new configuration settings that provide a list of
> well-known master and backup master locations, and with this information the
> client can contact any of the master processes directly. Any master in either
> active or passive state will track meta location and respond to requests for
> it with its cached last known location. If this location is stale, the client
> can ask again with a flag set that requests the master refresh its location
> cache and return the up-to-date location. Every client interaction with the
> cluster thus uses only HBase RPC as transport, with appropriate settings
> applied to the connection. The configuration toggle that enables this
> alternative meta location lookup should be false by default.
> This removes the requirement that HBase clients embed the ZK client and
> contact the ZK service directly at the beginning of the connection lifecycle.
> This has several benefits. ZK service need not be exposed to clients, and
> their potential abuse, yet no benefit ZK provides the HBase server cluster is
> compromised. Normalizing HBase client and ZK client timeout settings and
> retry behavior - in some cases, impossible, i.e. for fail-fast - is no longer
> necessary.
> And, from [~ghelmling]: There is an additional complication here for
> token-based authentication. When a delegation token is used for SASL
> authentication, the client uses the cluster ID obtained from Zookeeper to
> select the token identifier to use. So there would also need to be some
> Zookeeper-less, unauthenticated way to obtain the cluster ID as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase-thirdparty] jojochuang opened a new pull request #13: HBASE-23811. [OpenTracing] Add shaded JaegerTracing tracer to hbase-thirdparty.
jojochuang opened a new pull request #13: HBASE-23811. [OpenTracing] Add shaded JaegerTracing tracer to hbase-thirdparty. URL: https://github.com/apache/hbase-thirdparty/pull/13 This commit adds a new artifact org.hbase.thirdparty:hbase-shaded-jaeger. It shades io.jagertracing:jaeger-client and its dependencies, relocating the classpath. In particular, it requires libthrift 0.13.0 which is incompatible with libthrift 0.12.0 shipped by the current HBase. Dependencies that are already included by hbase-common are excluded from the uber jar. The resulting jar is about 3.9 MB in size. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase
[
https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17037386#comment-17037386
]
Hudson commented on HBASE-22514:
Results for branch HBASE-22514
[build #273 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/273/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/272//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/272//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/272//JDK8_Nightly_Build_Report_(Hadoop3)/]
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
-- Something went wrong with this stage, [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/273//console].
> Move rsgroup feature into core of HBase
> ---
>
> Key: HBASE-22514
> URL: https://issues.apache.org/jira/browse/HBASE-22514
> Project: HBase
> Issue Type: Umbrella
> Components: Admin, Client, rsgroup
>Reporter: Yechao Chen
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22514.master.001.patch,
> image-2019-05-31-18-25-38-217.png
>
>
> The class RSGroupAdminClient is not public
> we need to use java api RSGroupAdminClient to manager RSG
> so RSGroupAdminClient should be public
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-22749) Distributed MOB compactions
[
https://issues.apache.org/jira/browse/HBASE-22749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17037380#comment-17037380
]
Hudson commented on HBASE-22749:
Results for branch HBASE-22749
[build #1 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22749/1/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22749/1//console].
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
-- Something went wrong with this stage, [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22749/1//console].
> Distributed MOB compactions
>
>
> Key: HBASE-22749
> URL: https://issues.apache.org/jira/browse/HBASE-22749
> Project: HBase
> Issue Type: New Feature
> Components: mob
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
>Priority: Major
> Attachments: HBASE-22749-branch-2.2-v4.patch,
> HBASE-22749-master-v1.patch, HBASE-22749-master-v2.patch,
> HBASE-22749-master-v3.patch, HBASE-22749-master-v4.patch,
> HBase-MOB-2.0-v3.0.pdf
>
>
> There are several drawbacks in the original MOB 1.0 (Moderate Object
> Storage) implementation, which can limit the adoption of the MOB feature:
> # MOB compactions are executed in a Master as a chore, which limits
> scalability because all I/O goes through a single HBase Master server.
> # Yarn/Mapreduce framework is required to run MOB compactions in a scalable
> way, but this won’t work in a stand-alone HBase cluster.
> # Two separate compactors for MOB and for regular store files and their
> interactions can result in a data loss (see HBASE-22075)
> The design goals for MOB 2.0 were to provide 100% MOB 1.0 - compatible
> implementation, which is free of the above drawbacks and can be used as a
> drop in replacement in existing MOB deployments. So, these are design goals
> of a MOB 2.0:
> # Make MOB compactions scalable without relying on Yarn/Mapreduce framework
> # Provide unified compactor for both MOB and regular store files
> # Make it more robust especially w.r.t. to data losses.
> # Simplify and reduce the overall MOB code.
> # Provide 100% compatible implementation with MOB 1.0.
> # No migration of data should be required between MOB 1.0 and MOB 2.0 - just
> software upgrade.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] busbey commented on issue #921: HBASE-22749: Distributed MOB compactions
busbey commented on issue #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#issuecomment-586533590 a precommit check of e11ec68 is in progress; about 20 minutes into the usual 2.5 hours. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r379688843 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java ## @@ -85,6 +90,12 @@ protected static final CallQueueTooBigException CALL_QUEUE_TOO_BIG_EXCEPTION = new CallQueueTooBigException(); + private static final String MULTI_GETS = "multi.gets"; Review comment: nit: I think these are out of place..move to one of the util classes? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r379691406 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java ## @@ -2262,4 +2262,30 @@ boolean snapshotCleanupSwitch(final boolean on, final boolean synchronous) */ boolean isSnapshotCleanupEnabled() throws IOException; + + /** + * Retrieves online slowlog responses from in memory ringbuffer maintained by + * RegionServers + * + * @param serverNames Server names to get slowlog responses from + * @param slowLogQueryFilter filter to be used if provided + * @return online slowlog response list + * @throws IOException if a remote or network exception occurs + */ + List getSlowLogResponses(final List serverNames, Review comment: Like I mentioned elsewhere, I think these should getSlowRequests() and clearSlowRequestBuffer() in the interest of keeping the API simple and easy to follow.. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow
response log
URL: https://github.com/apache/hbase/pull/754#discussion_r379693393
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/slowlog/SlowLogRecorder.java
##
@@ -0,0 +1,144 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.regionserver.slowlog;
+
+import com.lmax.disruptor.BlockingWaitStrategy;
+import com.lmax.disruptor.RingBuffer;
+import com.lmax.disruptor.dsl.Disruptor;
+import com.lmax.disruptor.dsl.ProducerType;
+
+import java.util.Collections;
+import java.util.List;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.util.Threads;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.apache.yetus.audience.InterfaceStability;
+
+import org.apache.hbase.thirdparty.com.google.common.base.Preconditions;
+
+import org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos;
+import
org.apache.hadoop.hbase.shaded.protobuf.generated.TooSlowLog.SlowLogPayload;
+
+/**
+ * Online SlowLog Provider Service that keeps slow logs in the ring buffer
+ */
+@InterfaceAudience.Private
+@InterfaceStability.Evolving
+public class SlowLogRecorder {
Review comment:
This needs more java docs, especially around thread safety and how it works?
Mind adding?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow
response log
URL: https://github.com/apache/hbase/pull/754#discussion_r379693205
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/slowlog/SlowLogRecorder.java
##
@@ -0,0 +1,144 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.regionserver.slowlog;
+
+import com.lmax.disruptor.BlockingWaitStrategy;
+import com.lmax.disruptor.RingBuffer;
+import com.lmax.disruptor.dsl.Disruptor;
+import com.lmax.disruptor.dsl.ProducerType;
+
+import java.util.Collections;
+import java.util.List;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.util.Threads;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.apache.yetus.audience.InterfaceStability;
+
+import org.apache.hbase.thirdparty.com.google.common.base.Preconditions;
+
+import org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos;
+import
org.apache.hadoop.hbase.shaded.protobuf.generated.TooSlowLog.SlowLogPayload;
+
+/**
+ * Online SlowLog Provider Service that keeps slow logs in the ring buffer
+ */
+@InterfaceAudience.Private
+@InterfaceStability.Evolving
+public class SlowLogRecorder {
+
+ private final Disruptor disruptor;
+ private final SlowLogEventHandler slowLogEventHandler;
+ private final int eventCount;
+ private final boolean isOnlineSlowLogProviderEnabled;
+
+ private static final String SLOW_LOG_RING_BUFFER_SIZE =
+"hbase.regionserver.slowlog.ringbuffer.size";
+
+ /**
+ * Initialize disruptor with configurable ringbuffer size
+ */
+ public SlowLogRecorder(Configuration conf) {
+isOnlineSlowLogProviderEnabled =
conf.getBoolean(HConstants.SLOW_LOG_BUFFER_ENABLED_KEY,
+ HConstants.DEFAULT_ONLINE_LOG_PROVIDER_ENABLED);
+
+this.eventCount = conf.getInt(SLOW_LOG_RING_BUFFER_SIZE,
Review comment:
All this can be short-circuted if isOnlineSlowLogProviderEnabled == false.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r379691679 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncAdmin.java ## @@ -1507,4 +1507,24 @@ */ CompletableFuture isSnapshotCleanupEnabled(); + /** + * Retrieves online slowlog responses from in memory ringbuffer maintained by Review comment: nit: I think inmemory ringbuffer part can be removed I think, that is server side implementation that client doesn't care about. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow
response log
URL: https://github.com/apache/hbase/pull/754#discussion_r379698328
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/slowlog/TestSlowLogRecorder.java
##
@@ -0,0 +1,312 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.regionserver.slowlog;
+
+import java.util.List;
+import java.util.concurrent.TimeUnit;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtility;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.testclassification.MasterTests;
+import org.apache.hadoop.hbase.testclassification.MediumTests;
+import org.apache.hadoop.hbase.util.EnvironmentEdgeManager;
+import org.junit.Assert;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import
org.apache.hbase.thirdparty.com.google.common.util.concurrent.Uninterruptibles;
+
+import org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos;
+import
org.apache.hadoop.hbase.shaded.protobuf.generated.TooSlowLog.SlowLogPayload;
+
+/**
+ * Tests for Online SlowLog Provider Service
+ */
+@Category({MasterTests.class, MediumTests.class})
+public class TestSlowLogRecorder {
+
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+HBaseClassTestRule.forClass(TestSlowLogRecorder.class);
+
+ private static final Logger LOG =
LoggerFactory.getLogger(TestSlowLogRecorder.class);
+
+ private static final HBaseTestingUtility HBASE_TESTING_UTILITY = new
HBaseTestingUtility();
+
+ private SlowLogRecorder slowLogRecorder;
+
+ private static Configuration applySlowLogRecorderConf(int eventSize) {
+Configuration conf = HBASE_TESTING_UTILITY.getConfiguration();
+conf.setBoolean(HConstants.SLOW_LOG_BUFFER_ENABLED_KEY, true);
+conf.setInt("hbase.regionserver.slowlog.ringbuffer.size", eventSize);
+return conf;
+ }
+
+ private SlowLogPayload getSlowLogPayload(int i) {
+SlowLogPayload slowLogPayload = SlowLogPayload.newBuilder()
+ .setCallDetails("call_" + i)
+ .setClientAddress("client_" + i)
+ .setMethodName("method_" + i)
+ .setUserName("userName_" + i)
+ .setMultiGets(i)
+ .setMultiMutations(i)
+ .setMultiServiceCalls(i)
+ .setProcessingTime(i + 500)
+ .setQueueTime(i + 400)
+ .setResponseSize(i + 200)
+ .setStartTime(EnvironmentEdgeManager.currentTime())
+ .setServerClass("class_" + i)
+ .setParam("param_" + i)
+ .build();
+return slowLogPayload;
+ }
+
+ /**
+ * confirm that for a ringbuffer of slow logs, payload on given index of
buffer
+ * has expected elements
+ *
+ * @param i index of ringbuffer logs
+ * @param j data value that was put on index i
+ * @param slowLogPayloads list of payload retrieved from {@link
SlowLogRecorder}
+ */
+ private void confirmPayloadParams(int i, int j, List
slowLogPayloads) {
+Assert.assertEquals(slowLogPayloads.get(i).getClientAddress(), "client_" +
j);
+Assert.assertEquals(slowLogPayloads.get(i).getCallDetails(), "call_" + j);
+Assert.assertEquals(slowLogPayloads.get(i).getMethodName(), "method_" + j);
+Assert.assertEquals(slowLogPayloads.get(i).getUserName(), "userName_" + j);
+Assert.assertEquals(slowLogPayloads.get(i).getProcessingTime(), j + 500);
+Assert.assertEquals(slowLogPayloads.get(i).getQueueTime(), j + 400);
+Assert.assertEquals(slowLogPayloads.get(i).getResponseSize(), j + 200);
+Assert.assertEquals(slowLogPayloads.get(i).getServerClass(), "class_" + j);
+Assert.assertEquals(slowLogPayloads.get(i).getParam(), "param_" + j);
+ }
+
+ @Test
+ public void testOnlieSlowLogConsumption() throws Exception {
+Configuration conf = applySlowLogRecorderConf(8);
+slowLogRecorder = new SlowLogRecorder(conf);
+AdminProtos.SlowLogResponseRequest request =
+ AdminProtos.SlowLogResponseRequest.newBuilder().build();
+
[jira] [Commented] (HBASE-22749) Distributed MOB compactions
[
https://issues.apache.org/jira/browse/HBASE-22749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17037374#comment-17037374
]
HBase QA commented on HBASE-22749:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
33s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
1s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 23 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
36s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
20s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 4m
55s{color} | {color:blue} branch has no errors when building the reference
guide. See footer for rendered docs, which you should manually inspect. {color}
|
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
43s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
28s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 4m
30s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
15s{color} | {color:blue} branch/hbase-checkstyle no findbugs output file
(findbugsXml.xml) {color} |
| {color:orange}-0{color} | {color:orange} patch {color} | {color:orange} 4m
58s{color} | {color:orange} Used diff version of patch file. Binary files and
potentially other changes not applied. Please rebase and squash commits if
necessary. {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m
3s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 3m
36s{color} | {color:red} root: The patch generated 1 new + 427 unchanged - 58
fixed = 428 total (was 485) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 9 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
5s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 8m
4s{color} | {color:blue} patch has no errors when building the reference guide.
See footer for rendered docs, which you should manually inspect. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 7m
15s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
24m 21s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
14s{color} | {color:green} the patch passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
23s{color} | {color:blue} hbase-checkstyle has no data from findbugs {color} |
|| || || || {color:brown}
[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow
response log
URL: https://github.com/apache/hbase/pull/754#discussion_r379698112
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/slowlog/SlowLogEventHandler.java
##
@@ -0,0 +1,137 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.regionserver.slowlog;
+
+import com.lmax.disruptor.EventHandler;
+import com.lmax.disruptor.RingBuffer;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Objects;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicInteger;
+import java.util.concurrent.locks.Lock;
+import java.util.concurrent.locks.ReentrantLock;
+import java.util.stream.Collectors;
+
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import
org.apache.hadoop.hbase.shaded.protobuf.generated.TooSlowLog.SlowLogPayload;
+
+/**
+ * Event Handler run by disruptor ringbuffer consumer
+ */
+@InterfaceAudience.Private
+class SlowLogEventHandler implements EventHandler {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(SlowLogEventHandler.class);
+
+ private final SlowLogPayload[] slowLogPayloads;
+
+ private AtomicInteger slowLogPayloadIdx = new AtomicInteger();
+
+ private static final Lock LOCK = new ReentrantLock();
+
+ private static final int WRITE_LOCK_WAIT = 1;
+ private static final int READ_LOCK_WAIT = 1;
+
+ SlowLogEventHandler(int eventCount) {
+this.slowLogPayloads = new SlowLogPayload[eventCount];
+ }
+
+ /**
+ * Called when a publisher has published an event to the {@link RingBuffer}
+ *
+ * @param event published to the {@link RingBuffer}
+ * @param sequence of the event being processed
+ * @param endOfBatch flag to indicate if this is the last event in a batch
from
+ * the {@link RingBuffer}
+ * @throws Exception if the EventHandler would like the exception handled
further up the chain
+ */
+ @Override
+ public void onEvent(RingBufferTruck event, long sequence, boolean
endOfBatch) throws Exception {
+SlowLogPayload slowLogPayload = event.getPayload();
+if (LOG.isTraceEnabled()) {
+ LOG.trace("Received Slow Log Event. RingBuffer sequence: {},
isEndOfBatch: {}, " +
+ "Event Call: {}", sequence, endOfBatch,
+slowLogPayload.getCallDetails());
+}
+try {
+ if (LOCK.tryLock(WRITE_LOCK_WAIT, TimeUnit.SECONDS)) {
+int index = slowLogPayloadIdx.getAndSet(
+ (slowLogPayloadIdx.get() + 1) % slowLogPayloads.length);
+slowLogPayloads[index] = slowLogPayload;
+ }
Review comment:
Also, looking at the implementation, we are always blocking on a lock, so
all writes are pretty much serialized.. so I'd guess my suggestion won't be any
less performant..(I think)..
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow
response log
URL: https://github.com/apache/hbase/pull/754#discussion_r379688135
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
##
@@ -496,11 +518,65 @@ void logResponse(Message param, String methodName,
String call, String tag,
}
}
}
- responseInfo.put("multi.gets", numGets);
- responseInfo.put("multi.mutations", numMutations);
- responseInfo.put("multi.servicecalls", numServiceCalls);
+ responseInfo.put(MULTI_GETS, numGets);
+ responseInfo.put(MULTI_MUTATIONS, numMutations);
+ responseInfo.put(MULTI_SERVICE_CALLS, numServiceCalls);
}
+final String tag = (tooLarge && tooSlow) ? "TooLarge & TooSlow"
+ : (tooSlow ? "TooSlow" : "TooLarge");
LOG.warn("(response" + tag + "): " + GSON.toJson(responseInfo));
+if (tooSlow && this.slowLogRecorder != null) {
+ logOnlineSlowResponse(param, methodName, call, clientAddress, startTime,
+processingTime, qTime, responseSize, userName, className,
responseInfo);
+}
+ }
+
+ /**
+ * Add too slow log to ringbuffer for retrieval of latest n slow logs
+ *
+ * @param param The parameters received in the call
+ * @param methodName The name of the method invoked
+ * @param call The string representation of the call
+ * @param clientAddress The address of the client who made this call
+ * @param startTime The time that the call was initiated, in ms
+ * @param processingTime The duration that the call took to run, in ms
+ * @param qTime The duration that the call spent on the queue
+ * prior to being initiated, in ms
+ * @param responseSize The size in bytes of the response buffer
+ * @param userName UserName of the current RPC Call
+ * @param className ClassName of the SlowLog call
+ * @param responseInfo Base information map that is reported regardless of
type of call
+ */
+ private void logOnlineSlowResponse(Message param, String methodName, String
call,
Review comment:
Shouldn't this happen asynchronously? This adds latency to an already slow
request (and you are serializing stuff which is even slower with larger
requests), client doesn't care whether we log the request to the ring buffer or
not..
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow
response log
URL: https://github.com/apache/hbase/pull/754#discussion_r379697765
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/slowlog/SlowLogEventHandler.java
##
@@ -0,0 +1,137 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.regionserver.slowlog;
+
+import com.lmax.disruptor.EventHandler;
+import com.lmax.disruptor.RingBuffer;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Objects;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicInteger;
+import java.util.concurrent.locks.Lock;
+import java.util.concurrent.locks.ReentrantLock;
+import java.util.stream.Collectors;
+
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import
org.apache.hadoop.hbase.shaded.protobuf.generated.TooSlowLog.SlowLogPayload;
+
+/**
+ * Event Handler run by disruptor ringbuffer consumer
+ */
+@InterfaceAudience.Private
+class SlowLogEventHandler implements EventHandler {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(SlowLogEventHandler.class);
+
+ private final SlowLogPayload[] slowLogPayloads;
+
+ private AtomicInteger slowLogPayloadIdx = new AtomicInteger();
+
+ private static final Lock LOCK = new ReentrantLock();
+
+ private static final int WRITE_LOCK_WAIT = 1;
+ private static final int READ_LOCK_WAIT = 1;
+
+ SlowLogEventHandler(int eventCount) {
+this.slowLogPayloads = new SlowLogPayload[eventCount];
+ }
+
+ /**
+ * Called when a publisher has published an event to the {@link RingBuffer}
+ *
+ * @param event published to the {@link RingBuffer}
+ * @param sequence of the event being processed
+ * @param endOfBatch flag to indicate if this is the last event in a batch
from
+ * the {@link RingBuffer}
+ * @throws Exception if the EventHandler would like the exception handled
further up the chain
+ */
+ @Override
+ public void onEvent(RingBufferTruck event, long sequence, boolean
endOfBatch) throws Exception {
+SlowLogPayload slowLogPayload = event.getPayload();
+if (LOG.isTraceEnabled()) {
+ LOG.trace("Received Slow Log Event. RingBuffer sequence: {},
isEndOfBatch: {}, " +
+ "Event Call: {}", sequence, endOfBatch,
+slowLogPayload.getCallDetails());
+}
+try {
+ if (LOCK.tryLock(WRITE_LOCK_WAIT, TimeUnit.SECONDS)) {
+int index = slowLogPayloadIdx.getAndSet(
+ (slowLogPayloadIdx.get() + 1) % slowLogPayloads.length);
+slowLogPayloads[index] = slowLogPayload;
+ }
Review comment:
I kind of agree with @ndimiduk here. Its odd that we are missing events.
I'm not super familiar with disruptor's implementation of ring buffer (which
is obviously super complex and optimized for certain ingest pattern).. but I
think we can simplify it by adding a simple thread-safe wrapper over
EvictingQueue...
The wrapper runs in a simple thread that consumes input from a shared-buffer
to which RpcServer writes and this thread keeps polling entries and appends to
an underlying EvictingQueue...that way
- we don't miss any events and the whole thing is asynchronous too (since
the RpcServer just writes the entry to the shared buffer).
- Most of the logic can be folded into the wrapper class (currently there is
a lot of serialization stuff happening in the context of RpcServer).. this
thread can also "log" entries.
- Fewer lines of code.
Thoughts?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow
response log
URL: https://github.com/apache/hbase/pull/754#discussion_r379692118
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/SlowLogRecord.java
##
@@ -0,0 +1,317 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.client;
+
+import org.apache.commons.lang3.builder.EqualsBuilder;
+import org.apache.commons.lang3.builder.HashCodeBuilder;
+import org.apache.commons.lang3.builder.ToStringBuilder;
+import org.apache.hadoop.hbase.util.GsonUtil;
+import org.apache.yetus.audience.InterfaceAudience;
+
+import org.apache.hbase.thirdparty.com.google.gson.Gson;
+import org.apache.hbase.thirdparty.com.google.gson.JsonObject;
+import org.apache.hbase.thirdparty.com.google.gson.JsonSerializer;
+
+/**
+ * SlowLog payload for client
+ */
+@InterfaceAudience.Private
+final public class SlowLogRecord {
+
+ private static final Gson GSON = GsonUtil.createGson()
+.setPrettyPrinting()
+.registerTypeAdapter(SlowLogRecord.class, (JsonSerializer)
+ (slowLogPayload, type, jsonSerializationContext) -> {
+Gson gson = new Gson();
+JsonObject jsonObj = (JsonObject) gson.toJsonTree(slowLogPayload);
+if (slowLogPayload.getMultiGetsCount() == 0) {
+ jsonObj.remove("multiGetsCount");
+}
+if (slowLogPayload.getMultiMutationsCount() == 0) {
+ jsonObj.remove("multiMutationsCount");
+}
+if (slowLogPayload.getMultiServiceCalls() == 0) {
+ jsonObj.remove("multiServiceCalls");
+}
+return jsonObj;
+ }).create();
+
+ private long startTime;
+ private int processingTime;
+ private int queueTime;
+ private long responseSize;
+ private String clientAddress;
+ private String serverClass;
+ private String methodName;
+ private String callDetails;
+ private String param;
+ // we don't want to serialize region name, it is just for the filter purpose
+ // hence avoiding deserialization
+ private transient String regionName;
+ private String userName;
+ private int multiGetsCount;
+ private int multiMutationsCount;
+ private int multiServiceCalls;
+
+ public long getStartTime() {
+return startTime;
+ }
+
+ public int getProcessingTime() {
+return processingTime;
+ }
+
+ public int getQueueTime() {
+return queueTime;
+ }
+
+ public long getResponseSize() {
+return responseSize;
+ }
+
+ public String getClientAddress() {
+return clientAddress;
+ }
+
+ public String getServerClass() {
+return serverClass;
+ }
+
+ public String getMethodName() {
+return methodName;
+ }
+
+ public String getCallDetails() {
+return callDetails;
+ }
+
+ public String getParam() {
+return param;
+ }
+
+ public String getRegionName() {
+return regionName;
+ }
+
+ public String getUserName() {
+return userName;
+ }
+
+ public int getMultiGetsCount() {
+return multiGetsCount;
+ }
+
+ public int getMultiMutationsCount() {
+return multiMutationsCount;
+ }
+
+ public int getMultiServiceCalls() {
+return multiServiceCalls;
+ }
+
+ private SlowLogRecord(final long startTime, final int processingTime, final
int queueTime,
Review comment:
nit: use a builder?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r379692739 ## File path: hbase-common/src/main/resources/hbase-default.xml ## @@ -1956,4 +1956,27 @@ possible configurations would overwhelm and obscure the important. enable this feature. + +hbase.regionserver.slowlog.ringbuffer.size +256 + + Default size of ringbuffer to be maintained by each RegionServer in order + to store online slowlog responses. This is an in-memory ring buffer of + requests that were judged to be too slow in addition to the responseTooSlow + logging. The in-memory representation would be complete. + For more details, please look into Doc Section: + Get Slow Response Log from shell + + + +hbase.regionserver.slowlog.buffer.enabled Review comment: Why two configs? if "hbase.regionserver.slowlog.ringbuffer.size" > 0, it means it is enabled..(in the interest of reducing the number of knobs) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow
response log
URL: https://github.com/apache/hbase/pull/754#discussion_r379698898
##
File path:
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/client/ThriftAdmin.java
##
@@ -1157,6 +1158,18 @@ public boolean isSnapshotCleanupEnabled() {
throw new NotImplementedException("isSnapshotCleanupEnabled not supported
in ThriftAdmin");
}
+ @Override
+ public List getSlowLogResponses(final List
serverNames)
+ throws IOException {
+throw new NotImplementedException("getSlowLogResponses not supported in
ThriftAdmin");
Review comment:
Ya, I had a similar question about thrift interface when I was working on
HBASE-23330, but it looks like it is supported. So we should probably do this
too.. it is not too much code right? (just defining the equivalent thrift
specs).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow
response log
URL: https://github.com/apache/hbase/pull/754#discussion_r379691734
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncAdmin.java
##
@@ -1507,4 +1507,24 @@
*/
CompletableFuture isSnapshotCleanupEnabled();
+ /**
+ * Retrieves online slowlog responses from in memory ringbuffer maintained by
+ * RegionServers
+ *
+ * @param serverNames Server names to get slowlog responses from
+ * @param slowLogQueryFilter filter to be used if provided
+ * @return Online slowlog response list. The return value wrapped by a
{@link CompletableFuture}
+ */
+ CompletableFuture> getSlowLogResponses(final
List serverNames,
Review comment:
nit: switch to a Set<> ?, we don't want duplicates?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #754: HBASE-22978 : Online slow response log
bharathv commented on a change in pull request #754: HBASE-22978 : Online slow
response log
URL: https://github.com/apache/hbase/pull/754#discussion_r379685711
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/SlowLogParams.java
##
@@ -0,0 +1,89 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.client;
+
+import org.apache.commons.lang3.StringUtils;
+import org.apache.commons.lang3.builder.EqualsBuilder;
+import org.apache.commons.lang3.builder.HashCodeBuilder;
+import org.apache.commons.lang3.builder.ToStringBuilder;
+import org.apache.yetus.audience.InterfaceAudience;
+
+/**
+ * SlowLog params object that contains detailed info as params and region name
: to be used
+ * for filter purpose
+ */
+@InterfaceAudience.Private
+public class SlowLogParams {
Review comment:
I have this very basic question(may be discussed elsewhere but I don't see
it)..why does everything contain"log"
SlowLogParams
SlowLogResponses
SlowLogQueryFilter...
Reading through the jira, I think we should be calling it SlowRequestBuffer
or something like that? I don't understand the "log" part here.. reading
through the patch, it looks like we are book-keeping this data *after* the
logging is done, right?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #921: HBASE-22749: Distributed MOB compactions
Apache-HBase commented on issue #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#issuecomment-586529777 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 23 new or modified test files. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 36s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 18s | master passed | | +1 :green_heart: | compile | 2m 5s | master passed | | +1 :green_heart: | checkstyle | 2m 20s | master passed | | +0 :ok: | refguide | 4m 55s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | shadedjars | 4m 43s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 28s | master passed | | +0 :ok: | spotbugs | 4m 30s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +0 :ok: | findbugs | 0m 15s | branch/hbase-checkstyle no findbugs output file (findbugsXml.xml) | | -0 :warning: | patch | 4m 58s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 6m 48s | the patch passed | | +1 :green_heart: | compile | 3m 3s | the patch passed | | +1 :green_heart: | javac | 3m 3s | the patch passed | | -1 :x: | checkstyle | 3m 36s | root: The patch generated 1 new + 427 unchanged - 58 fixed = 428 total (was 485) | | -1 :x: | whitespace | 0m 0s | The patch has 9 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | +1 :green_heart: | xml | 0m 5s | The patch has no ill-formed XML file. | | +0 :ok: | refguide | 8m 4s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | shadedjars | 7m 15s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 24m 21s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 2m 14s | the patch passed | | +0 :ok: | findbugs | 0m 23s | hbase-checkstyle has no data from findbugs | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 15s | hbase-checkstyle in the patch passed. | | +1 :green_heart: | unit | 1m 8s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 61m 47s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 1m 21s | hbase-it in the patch passed. | | +1 :green_heart: | asflicense | 2m 10s | The patch does not generate ASF License warnings. | | | | 166m 26s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-921/11/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/921 | | JIRA Issue | HBASE-22749 | | Optional Tests | dupname asflicense checkstyle javac javadoc unit xml refguide spotbugs findbugs shadedjars hadoopcheck hbaseanti compile | | uname | Linux 1ffda1287723 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-921/out/precommit/personality/provided.sh | | git revision | master / 5f61df4792 | | Default Java | 1.8.0_181 | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-921/11/artifact/out/branch-site/book.html | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-921/11/artifact/out/diff-checkstyle-root.txt | | whitespace | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-921/11/artifact/out/whitespace-eol.txt | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-921/11/artifact/out/patch-site/book.html | | Test Results |
[jira] [Commented] (HBASE-23838) Adding debug logging to a few ExportSnapshot tests
[
https://issues.apache.org/jira/browse/HBASE-23838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17037370#comment-17037370
]
Michael Stack commented on HBASE-23838:
---
Pushed an addendum on branch-2 and master to fix failing TestExportSnapshot:
{code}
diff --git
a/hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/snapshot/TestExportSnapshot.java
b/hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/snapshot/TestExportSnapshot.java
index 4293d461d9..99d9d65d30 100644
---
a/hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/snapshot/TestExportSnapshot.java
+++
b/hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/snapshot/TestExportSnapshot.java
@@ -213,8 +213,7 @@ public class TestExportSnapshot {
final RegionPredicate bypassregionPredicate, boolean success) throws
Exception {
URI hdfsUri = FileSystem.get(conf).getUri();
FileSystem fs = FileSystem.get(copyDir.toUri(), conf);
-copyDir = copyDir.makeQualified(hdfsUri, copyDir);
-
+copyDir = copyDir.makeQualified(fs.getUri(), fs.getWorkingDirectory());
List opts = new ArrayList<>();
opts.add("--snapshot");
opts.add(Bytes.toString(snapshotName));
@@ -227,10 +226,8 @@ public class TestExportSnapshot {
if (overwrite) opts.add("--overwrite");
// Export Snapshot
-ExportSnapshot es = new ExportSnapshot();
-es.setConf(conf);
-int res = run(conf, es, opts.toArray(new String[opts.size()]));
-assertEquals(success ? 0 : 1, res);
+int res = run(conf, new ExportSnapshot(), opts.toArray(new
String[opts.size()]));
+assertEquals("success " + success + ", res=" + res, success ? 0 : 1, res);
if (!success) {
final Path targetDir = new Path(HConstants.SNAPSHOT_DIR_NAME,
Bytes.toString(targetName));
assertFalse(copyDir.toString() + " " + targetDir.toString(),
{code}
> Adding debug logging to a few ExportSnapshot tests
> --
>
> Key: HBASE-23838
> URL: https://issues.apache.org/jira/browse/HBASE-23838
> Project: HBase
> Issue Type: Bug
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Trivial
> Fix For: 3.0.0, 2.3.0
>
> Attachments:
> 0001-HBASE-23838-Adding-debug-logging-to-a-few-ExportSnap.patch
>
>
> Bit of extra logging in tests to help me diagnose where they are going wrong.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1171: HBASE-23767 WIP do not merge
Apache-HBase commented on issue #1171: HBASE-23767 WIP do not merge URL: https://github.com/apache/hbase/pull/1171#issuecomment-586526103 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 29s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +0 :ok: | shellcheck | 0m 1s | Shellcheck was not available. | | +0 :ok: | shelldocs | 0m 1s | Shelldocs was not available. | | +0 :ok: | hadolint | 0m 1s | hadolint was not available. | | +0 :ok: | xml | 0m 0s | jrunscript was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | -1 :x: | mvninstall | 0m 3s | root in master failed. | | -1 :x: | compile | 0m 3s | root in master failed. | | +1 :green_heart: | shadedjars | 0m 1s | branch has no errors when building our shaded downstream artifacts. | | -1 :x: | javadoc | 0m 3s | root in master failed. | ||| _ Patch Compile Tests _ | | -1 :x: | mvninstall | 0m 2s | root in the patch failed. | | -1 :x: | compile | 0m 2s | root in the patch failed. | | -1 :x: | javac | 0m 2s | root in the patch failed. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 0m 1s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 0m 3s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | -1 :x: | javadoc | 0m 3s | root in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 0m 3s | root in the patch failed. | | +0 :ok: | asflicense | 0m 3s | ASF License check generated no output? | | | | 2m 43s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1171/11/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1171 | | Optional Tests | dupname asflicense shellcheck shelldocs hadolint javac javadoc unit shadedjars hadoopcheck xml compile | | uname | Linux 8e5a779aede7 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1171/out/precommit/personality/provided.sh | | git revision | master / 5f61df4792 | | Default Java | directory | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1171/11/artifact/out/branch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1171/11/artifact/out/branch-compile-root.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1171/11/artifact/out/branch-javadoc-root.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1171/11/artifact/out/patch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1171/11/artifact/out/patch-compile-root.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1171/11/artifact/out/patch-compile-root.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1171/11/artifact/out/patch-javadoc-root.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1171/11/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1171/11/testReport/ | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1171/11/console | | versions | git=2.24.1 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (HBASE-23840) Revert optimized IO back to general compaction during upgrade/migration process
[ https://issues.apache.org/jira/browse/HBASE-23840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Rodionov resolved HBASE-23840. --- Resolution: Fixed > Revert optimized IO back to general compaction during upgrade/migration > process > > > Key: HBASE-23840 > URL: https://issues.apache.org/jira/browse/HBASE-23840 > Project: HBase > Issue Type: Sub-task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Major > > Optimized mode IO compaction may leave old MOB file, which size is above > threshold as is and don't compact it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1146: HBASE-23781 Removed deprecated createTableDescriptor(String) from HBaseTestingUtility
Apache-HBase commented on issue #1146: HBASE-23781 Removed deprecated createTableDescriptor(String) from HBaseTestingUtility URL: https://github.com/apache/hbase/pull/1146#issuecomment-586525822 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 21s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 14 new or modified test files. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 8m 12s | master passed | | +1 :green_heart: | compile | 1m 27s | master passed | | +1 :green_heart: | checkstyle | 1m 38s | master passed | | +1 :green_heart: | shadedjars | 6m 31s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 7s | master passed | | +0 :ok: | spotbugs | 5m 44s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 5m 41s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 8m 12s | the patch passed | | +1 :green_heart: | compile | 1m 25s | the patch passed | | +1 :green_heart: | javac | 1m 25s | the patch passed | | +1 :green_heart: | checkstyle | 1m 29s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 6m 32s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 24m 46s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 0m 52s | the patch passed | | +1 :green_heart: | findbugs | 5m 25s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 106m 13s | hbase-server in the patch failed. | | +1 :green_heart: | asflicense | 0m 32s | The patch does not generate ASF License warnings. | | | | 192m 22s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.replication.regionserver.TestSerialReplicationChecker | | | hadoop.hbase.replication.TestReplicationStatusAfterLagging | | | hadoop.hbase.replication.TestRemoveFromSerialReplicationPeer | | | hadoop.hbase.replication.TestReplicationKillMasterRSCompressed | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1146/5/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1146 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux d4f040148022 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1146/out/precommit/personality/provided.sh | | git revision | master / 5f61df4792 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1146/5/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1146/5/testReport/ | | Max. process+thread count | 6742 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1146/5/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1171: HBASE-23767 WIP do not merge
Apache-HBase commented on issue #1171: HBASE-23767 WIP do not merge URL: https://github.com/apache/hbase/pull/1171#issuecomment-586525672 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1171/11/console in case of problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1171: HBASE-23767 WIP do not merge
Apache-HBase commented on issue #1171: HBASE-23767 WIP do not merge URL: https://github.com/apache/hbase/pull/1171#issuecomment-586525379 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 24s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shellcheck | 0m 0s | Shellcheck was not available. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +0 :ok: | hadolint | 0m 1s | hadolint was not available. | | +0 :ok: | xml | 0m 0s | jrunscript was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | -1 :x: | mvninstall | 0m 3s | root in master failed. | | -1 :x: | compile | 0m 3s | root in master failed. | | +1 :green_heart: | shadedjars | 0m 1s | branch has no errors when building our shaded downstream artifacts. | | -1 :x: | javadoc | 0m 3s | root in master failed. | ||| _ Patch Compile Tests _ | | -1 :x: | mvninstall | 0m 3s | root in the patch failed. | | -1 :x: | compile | 0m 2s | root in the patch failed. | | -1 :x: | javac | 0m 2s | root in the patch failed. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 0m 1s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 0m 3s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | -1 :x: | javadoc | 0m 3s | root in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 0m 3s | root in the patch failed. | | +0 :ok: | asflicense | 0m 3s | ASF License check generated no output? | | | | 3m 40s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1171/10/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1171 | | Optional Tests | dupname asflicense shellcheck shelldocs hadolint javac javadoc unit shadedjars hadoopcheck xml compile | | uname | Linux d2ca720d3bcf 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1171/out/precommit/personality/provided.sh | | git revision | master / 5f61df4792 | | Default Java | directory | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1171/10/artifact/out/branch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1171/10/artifact/out/branch-compile-root.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1171/10/artifact/out/branch-javadoc-root.txt | | mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1171/10/artifact/out/patch-mvninstall-root.txt | | compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1171/10/artifact/out/patch-compile-root.txt | | javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1171/10/artifact/out/patch-compile-root.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1171/10/artifact/out/patch-javadoc-root.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1171/10/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1171/10/testReport/ | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1171/10/console | | versions | git=2.24.1 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1171: HBASE-23767 WIP do not merge
Apache-HBase commented on issue #1171: HBASE-23767 WIP do not merge URL: https://github.com/apache/hbase/pull/1171#issuecomment-586524685 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1171/10/console in case of problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1171: HBASE-23767 WIP do not merge
Apache-HBase commented on issue #1171: HBASE-23767 WIP do not merge URL: https://github.com/apache/hbase/pull/1171#issuecomment-586520865 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1171/9/console in case of problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1171: HBASE-23767 WIP do not merge
Apache-HBase commented on issue #1171: HBASE-23767 WIP do not merge URL: https://github.com/apache/hbase/pull/1171#issuecomment-586518675 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1171/8/console in case of problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1168: HBASE-23837 Removed deprecated isLegalFamilyName(byte[]) from HColumnDescriptor
Apache-HBase commented on issue #1168: HBASE-23837 Removed deprecated isLegalFamilyName(byte[]) from HColumnDescriptor URL: https://github.com/apache/hbase/pull/1168#issuecomment-586514534 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 37s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 55s | master passed | | +1 :green_heart: | compile | 1m 30s | master passed | | +1 :green_heart: | checkstyle | 1m 56s | master passed | | +1 :green_heart: | shadedjars | 4m 50s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 2s | master passed | | +0 :ok: | spotbugs | 4m 18s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 5m 24s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 53s | the patch passed | | +1 :green_heart: | compile | 1m 24s | the patch passed | | +1 :green_heart: | javac | 1m 24s | the patch passed | | +1 :green_heart: | checkstyle | 0m 31s | hbase-client: The patch generated 0 new + 37 unchanged - 2 fixed = 37 total (was 39) | | +1 :green_heart: | checkstyle | 1m 8s | The patch passed checkstyle in hbase-server | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 4m 51s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 16m 20s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 0m 59s | the patch passed | | +1 :green_heart: | findbugs | 6m 4s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 55s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 65m 45s | hbase-server in the patch passed. | | +1 :green_heart: | asflicense | 0m 54s | The patch does not generate ASF License warnings. | | | | 132m 55s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1168/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1168 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 7a395734b9dc 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1168/out/precommit/personality/provided.sh | | git revision | master / 5f61df4792 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1168/2/testReport/ | | Max. process+thread count | 8395 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1168/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ndimiduk commented on issue #1171: HBASE-23767 WIP do not merge
ndimiduk commented on issue #1171: HBASE-23767 WIP do not merge URL: https://github.com/apache/hbase/pull/1171#issuecomment-586511994 > @busbey this mean anything to you? > > ``` > /usr/bin/docker: Error response from daemon: unable to find user jenkins: no matching entries in passwd file. > ``` Okay, please disregard. I've discovered `Dockerfile.patchspecific` and am making progress again. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1171: HBASE-23767 WIP do not merge
Apache-HBase commented on issue #1171: HBASE-23767 WIP do not merge URL: https://github.com/apache/hbase/pull/1171#issuecomment-586509335 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1171/7/console in case of problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23808) [Flakey Test] TestMasterShutdown#testMasterShutdownBeforeStartingAnyRegionServer
[
https://issues.apache.org/jira/browse/HBASE-23808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17037343#comment-17037343
]
Hudson commented on HBASE-23808:
Results for branch branch-2.2
[build #785 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/785/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/785//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/785//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/785//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [Flakey Test]
> TestMasterShutdown#testMasterShutdownBeforeStartingAnyRegionServer
>
>
> Key: HBASE-23808
> URL: https://issues.apache.org/jira/browse/HBASE-23808
> Project: HBase
> Issue Type: Test
> Components: test
>Affects Versions: 2.3.0
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.4
>
>
> Reproduces locally from time to time. Not much to go on here. Looks like the
> test is trying to do some fancy HBase cluster initialization order on top of
> a mini-cluster. Failure seems related to trying to start the HBase master
> before HDFS is fully initialized.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1172: HBASE-23844 Removed deprecated Scan(byte[], Filter) from Scan
Apache-HBase commented on issue #1172: HBASE-23844 Removed deprecated Scan(byte[], Filter) from Scan URL: https://github.com/apache/hbase/pull/1172#issuecomment-586504552 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 9s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 26s | master passed | | +1 :green_heart: | compile | 0m 25s | master passed | | +1 :green_heart: | checkstyle | 0m 33s | master passed | | +1 :green_heart: | shadedjars | 5m 20s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | master passed | | +0 :ok: | spotbugs | 1m 12s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 1m 10s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 35s | the patch passed | | +1 :green_heart: | compile | 0m 26s | the patch passed | | +1 :green_heart: | javac | 0m 26s | the patch passed | | +1 :green_heart: | checkstyle | 0m 31s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 5m 5s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 17m 42s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 0m 21s | the patch passed | | +1 :green_heart: | findbugs | 1m 17s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 58s | hbase-client in the patch passed. | | +1 :green_heart: | asflicense | 0m 12s | The patch does not generate ASF License warnings. | | | | 54m 26s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1172/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1172 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 640e6a9af000 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1172/out/precommit/personality/provided.sh | | git revision | master / 5f61df4792 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1172/1/testReport/ | | Max. process+thread count | 386 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1172/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22827) Expose multi-region merge in shell and Admin API
[ https://issues.apache.org/jira/browse/HBASE-22827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17037333#comment-17037333 ] Sakthi commented on HBASE-22827: Pushed to master. Working on backport to 2.3.0 > Expose multi-region merge in shell and Admin API > > > Key: HBASE-22827 > URL: https://issues.apache.org/jira/browse/HBASE-22827 > Project: HBase > Issue Type: Improvement > Components: Admin, shell >Reporter: Michael Stack >Assignee: Sakthi >Priority: Major > Fix For: 3.0.0 > > > HBASE-22777 adds being able to merge more than two regions at once. It is > only available internally currently for use by hbck2 doing fixup of overlaps > in hbase:meta. This issue is about exposing it via the Admin Interface and in > turn, via the shell. Probably best if old two region merge method is > deprecated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-22827) Expose multi-region merge in shell and Admin API
[ https://issues.apache.org/jira/browse/HBASE-22827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sakthi updated HBASE-22827: --- Fix Version/s: 3.0.0 > Expose multi-region merge in shell and Admin API > > > Key: HBASE-22827 > URL: https://issues.apache.org/jira/browse/HBASE-22827 > Project: HBase > Issue Type: Improvement > Components: Admin, shell >Reporter: Michael Stack >Assignee: Sakthi >Priority: Major > Fix For: 3.0.0 > > > HBASE-22777 adds being able to merge more than two regions at once. It is > only available internally currently for use by hbck2 doing fixup of overlaps > in hbase:meta. This issue is about exposing it via the Admin Interface and in > turn, via the shell. Probably best if old two region merge method is > deprecated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] ndimiduk commented on issue #1171: HBASE-23767 WIP do not merge
ndimiduk commented on issue #1171: HBASE-23767 WIP do not merge URL: https://github.com/apache/hbase/pull/1171#issuecomment-586489774 ``` 13:54:38 [Fri Feb 14 21:54:30 UTC 2020 DEBUG]: dockercmd: /usr/bin/docker run --rm=true -i -v /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1171/out/console.txt:/precommit/console.txt -v /home/jenkins/.m2:/home/jenkins/.m2 -v /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1171/yetus-m2:/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1171/yetus-m2 -v /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1171/out/brief.txt:/precommit/brief.txt -v /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1171/out/report.html:/precommit/report.htm --env=QUICK_HADOOPCHECK=true -m 20g --oom-score-adj 500 --cidfile=/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1171/out/cidfile.txt -v /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1171/src:/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1171/src -u jenkins -w /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1171/src --env=BASEDIR=/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1171/src --env=DOCKER_VERSION_STR=Client=19.03.6 Server=19.03.6 --env=PATCH_SYSTEM=github --env=PROJECT_NAME=hbase --env=BRANCH_NAME=PR-1171 --env=BUILD_URL=https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1171/6/ --env=CHANGE_URL=https://github.com/apache/hbase/pull/1171 --env=EXECUTOR_NUMBER=1 --env=ghprbPullId= --env=ghprbPullLink= --env=GIT_URL=https://github.com/apache/hbase.git --env=JENKINS_URL=https://builds.apache.org/ --env=MAVEN_OPTS=-Xms4G -Xmx4G --env=CGO_LDFLAGS= --env=CGO_ENABLED= --env=GO111MODULE= --env=GOPATH= --env=DOCKER_WORK_DIR=/precommit --name yetus_tp-6039 -v /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1171/out:/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1171/out --env=PATCH_DIR=/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1171/out yetus/hbase:tp-6039 13:54:38 WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap. 13:54:38 /usr/bin/docker: Error response from daemon: unable to find user jenkins: no matching entries in passwd file. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23808) [Flakey Test] TestMasterShutdown#testMasterShutdownBeforeStartingAnyRegionServer
[
https://issues.apache.org/jira/browse/HBASE-23808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17037322#comment-17037322
]
Hudson commented on HBASE-23808:
Results for branch branch-2
[build #2473 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2473/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2473//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2473//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2473//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [Flakey Test]
> TestMasterShutdown#testMasterShutdownBeforeStartingAnyRegionServer
>
>
> Key: HBASE-23808
> URL: https://issues.apache.org/jira/browse/HBASE-23808
> Project: HBase
> Issue Type: Test
> Components: test
>Affects Versions: 2.3.0
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.4
>
>
> Reproduces locally from time to time. Not much to go on here. Looks like the
> test is trying to do some fancy HBase cluster initialization order on top of
> a mini-cluster. Failure seems related to trying to start the HBase master
> before HDFS is fully initialized.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work started] (HBASE-23848) Remove deprecated setStopRow(byte[]) from Scan
[
https://issues.apache.org/jira/browse/HBASE-23848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-23848 started by Jan Hentschel.
-
> Remove deprecated setStopRow(byte[]) from Scan
> --
>
> Key: HBASE-23848
> URL: https://issues.apache.org/jira/browse/HBASE-23848
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
>
> {{setStopRow(byte[]}} in {{Scan}} was deprecated back in 2.0.0 and should be
> removed for 3.0.0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1171: HBASE-23767 WIP do not merge
Apache-HBase commented on issue #1171: HBASE-23767 WIP do not merge URL: https://github.com/apache/hbase/pull/1171#issuecomment-586487603 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1171/6/console in case of problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-23848) Remove deprecated setStopRow(byte[]) from Scan
Jan Hentschel created HBASE-23848:
-
Summary: Remove deprecated setStopRow(byte[]) from Scan
Key: HBASE-23848
URL: https://issues.apache.org/jira/browse/HBASE-23848
Project: HBase
Issue Type: Sub-task
Affects Versions: 3.0.0
Reporter: Jan Hentschel
Assignee: Jan Hentschel
{{setStopRow(byte[]}} in {{Scan}} was deprecated back in 2.0.0 and should be
removed for 3.0.0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work started] (HBASE-23847) Remove deprecated setStartRow(byte[]) from Scan
[
https://issues.apache.org/jira/browse/HBASE-23847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-23847 started by Jan Hentschel.
-
> Remove deprecated setStartRow(byte[]) from Scan
> ---
>
> Key: HBASE-23847
> URL: https://issues.apache.org/jira/browse/HBASE-23847
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
>
> {{setStartRow(byte[]}} in {{Scan}} was deprecated back in 2.0.0 and should be
> removed in 3.0.0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (HBASE-23847) Remove deprecated setStartRow(byte[]) from Scan
Jan Hentschel created HBASE-23847:
-
Summary: Remove deprecated setStartRow(byte[]) from Scan
Key: HBASE-23847
URL: https://issues.apache.org/jira/browse/HBASE-23847
Project: HBase
Issue Type: Sub-task
Affects Versions: 3.0.0
Reporter: Jan Hentschel
Assignee: Jan Hentschel
{{setStartRow(byte[]}} in {{Scan}} was deprecated back in 2.0.0 and should be
removed in 3.0.0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1171: HBASE-23767 WIP do not merge
Apache-HBase commented on issue #1171: HBASE-23767 WIP do not merge URL: https://github.com/apache/hbase/pull/1171#issuecomment-586484560 (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1171/4/console in case of problems. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work started] (HBASE-23846) Remove deprecated setMaxVersions(int) from Scan
[
https://issues.apache.org/jira/browse/HBASE-23846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-23846 started by Jan Hentschel.
-
> Remove deprecated setMaxVersions(int) from Scan
> ---
>
> Key: HBASE-23846
> URL: https://issues.apache.org/jira/browse/HBASE-23846
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
>
> {{setMaxVersions(int)}} in {{Scan}} was deprecated back in 2.0.0 and should
> be removed for 3.0.0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (HBASE-23846) Remove deprecated setMaxVersions(int) from Scan
Jan Hentschel created HBASE-23846:
-
Summary: Remove deprecated setMaxVersions(int) from Scan
Key: HBASE-23846
URL: https://issues.apache.org/jira/browse/HBASE-23846
Project: HBase
Issue Type: Sub-task
Affects Versions: 3.0.0
Reporter: Jan Hentschel
Assignee: Jan Hentschel
{{setMaxVersions(int)}} in {{Scan}} was deprecated back in 2.0.0 and should be
removed for 3.0.0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-22749) Distributed MOB compactions
[
https://issues.apache.org/jira/browse/HBASE-22749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17037303#comment-17037303
]
HBase QA commented on HBASE-22749:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
32s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
1s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 23 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
48s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
25s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 4m
52s{color} | {color:blue} branch has no errors when building the reference
guide. See footer for rendered docs, which you should manually inspect. {color}
|
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
42s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
28s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 4m
14s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
17s{color} | {color:blue} branch/hbase-checkstyle no findbugs output file
(findbugsXml.xml) {color} |
| {color:orange}-0{color} | {color:orange} patch {color} | {color:orange} 4m
46s{color} | {color:orange} Used diff version of patch file. Binary files and
potentially other changes not applied. Please rebase and squash commits if
necessary. {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
11s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 2m
21s{color} | {color:red} root: The patch generated 1 new + 427 unchanged - 58
fixed = 428 total (was 485) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 8 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
4s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 4m
46s{color} | {color:blue} patch has no errors when building the reference
guide. See footer for rendered docs, which you should manually inspect. {color}
|
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
53s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
16m 7s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
24s{color} | {color:green} the patch passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
13s{color} | {color:blue} hbase-checkstyle has no data from findbugs {color} |
|| || || || {color:brown}
[jira] [Created] (HBASE-23845) Remove deprecated setMaxVersions() from Scan
Jan Hentschel created HBASE-23845:
-
Summary: Remove deprecated setMaxVersions() from Scan
Key: HBASE-23845
URL: https://issues.apache.org/jira/browse/HBASE-23845
Project: HBase
Issue Type: Sub-task
Affects Versions: 3.0.0
Reporter: Jan Hentschel
Assignee: Jan Hentschel
{{setMaxVersions()}} in {{Scan}} was deprecated back in 2.0.0 and should be
removed for 3.0.0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work started] (HBASE-23845) Remove deprecated setMaxVersions() from Scan
[
https://issues.apache.org/jira/browse/HBASE-23845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-23845 started by Jan Hentschel.
-
> Remove deprecated setMaxVersions() from Scan
>
>
> Key: HBASE-23845
> URL: https://issues.apache.org/jira/browse/HBASE-23845
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
>
> {{setMaxVersions()}} in {{Scan}} was deprecated back in 2.0.0 and should be
> removed for 3.0.0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #921: HBASE-22749: Distributed MOB compactions
Apache-HBase commented on issue #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#issuecomment-586481783 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 23 new or modified test files. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 48s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 16s | master passed | | +1 :green_heart: | compile | 2m 9s | master passed | | +1 :green_heart: | checkstyle | 2m 25s | master passed | | +0 :ok: | refguide | 4m 52s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | shadedjars | 4m 42s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 28s | master passed | | +0 :ok: | spotbugs | 4m 14s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +0 :ok: | findbugs | 0m 17s | branch/hbase-checkstyle no findbugs output file (findbugsXml.xml) | | -0 :warning: | patch | 4m 46s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 50s | the patch passed | | +1 :green_heart: | compile | 2m 11s | the patch passed | | +1 :green_heart: | javac | 2m 11s | the patch passed | | -1 :x: | checkstyle | 2m 21s | root: The patch generated 1 new + 427 unchanged - 58 fixed = 428 total (was 485) | | -1 :x: | whitespace | 0m 0s | The patch has 8 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | +1 :green_heart: | xml | 0m 4s | The patch has no ill-formed XML file. | | +0 :ok: | refguide | 4m 46s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | shadedjars | 4m 53s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 16m 7s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | javadoc | 1m 24s | the patch passed | | +0 :ok: | findbugs | 0m 13s | hbase-checkstyle has no data from findbugs | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 13s | hbase-checkstyle in the patch passed. | | +1 :green_heart: | unit | 1m 8s | hbase-common in the patch passed. | | -1 :x: | unit | 51m 26s | hbase-server in the patch failed. | | +1 :green_heart: | unit | 1m 15s | hbase-it in the patch passed. | | +1 :green_heart: | asflicense | 1m 38s | The patch does not generate ASF License warnings. | | | | 133m 52s | | | Reason | Tests | |---:|:--| | Unreaped Processes | hbase-server:6 | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-921/10/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/921 | | JIRA Issue | HBASE-22749 | | Optional Tests | dupname asflicense checkstyle javac javadoc unit xml refguide spotbugs findbugs shadedjars hadoopcheck hbaseanti compile | | uname | Linux 7380b57b2fe3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-921/out/precommit/personality/provided.sh | | git revision | master / 5f61df4792 | | Default Java | 1.8.0_181 | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-921/10/artifact/out/branch-site/book.html | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-921/10/artifact/out/diff-checkstyle-root.txt | | whitespace | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-921/10/artifact/out/whitespace-eol.txt | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-921/10/artifact/out/patch-site/book.html | | Unreaped
[jira] [Updated] (HBASE-23844) Remove deprecated Scan(byte[], Filter) from Scan
[
https://issues.apache.org/jira/browse/HBASE-23844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel updated HBASE-23844:
--
Status: Patch Available (was: In Progress)
> Remove deprecated Scan(byte[], Filter) from Scan
>
>
> Key: HBASE-23844
> URL: https://issues.apache.org/jira/browse/HBASE-23844
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
>
> {{Scan(byte[], Filter)}} in {{Scan}} was deprecated back in 2.0.0 and should
> be removed for 3.0.0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] HorizonNet opened a new pull request #1172: HBASE-23844 Removed deprecated Scan(byte[], Filter) from Scan
HorizonNet opened a new pull request #1172: HBASE-23844 Removed deprecated Scan(byte[], Filter) from Scan URL: https://github.com/apache/hbase/pull/1172 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-23844) Remove deprecated Scan(byte[], Filter) from Scan
Jan Hentschel created HBASE-23844:
-
Summary: Remove deprecated Scan(byte[], Filter) from Scan
Key: HBASE-23844
URL: https://issues.apache.org/jira/browse/HBASE-23844
Project: HBase
Issue Type: Sub-task
Affects Versions: 3.0.0
Reporter: Jan Hentschel
Assignee: Jan Hentschel
{{Scan(byte[], Filter)}} in {{Scan}} was deprecated back in 2.0.0 and should be
removed for 3.0.0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work started] (HBASE-23844) Remove deprecated Scan(byte[], Filter) from Scan
[
https://issues.apache.org/jira/browse/HBASE-23844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-23844 started by Jan Hentschel.
-
> Remove deprecated Scan(byte[], Filter) from Scan
>
>
> Key: HBASE-23844
> URL: https://issues.apache.org/jira/browse/HBASE-23844
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
>
> {{Scan(byte[], Filter)}} in {{Scan}} was deprecated back in 2.0.0 and should
> be removed for 3.0.0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work started] (HBASE-23843) Remove deprecated Scan(byte[]) from Scan
[
https://issues.apache.org/jira/browse/HBASE-23843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-23843 started by Jan Hentschel.
-
> Remove deprecated Scan(byte[]) from Scan
>
>
> Key: HBASE-23843
> URL: https://issues.apache.org/jira/browse/HBASE-23843
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
>
> {{Scan(byte[])}} in {{Scan}} was deprecated back in 2.0.0 and should be
> removed for 3.0.0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (HBASE-23843) Remove deprecated Scan(byte[]) from Scan
Jan Hentschel created HBASE-23843:
-
Summary: Remove deprecated Scan(byte[]) from Scan
Key: HBASE-23843
URL: https://issues.apache.org/jira/browse/HBASE-23843
Project: HBase
Issue Type: Sub-task
Affects Versions: 3.0.0
Reporter: Jan Hentschel
Assignee: Jan Hentschel
{{Scan(byte[])}} in {{Scan}} was deprecated back in 2.0.0 and should be removed
for 3.0.0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work started] (HBASE-23842) Remove deprecated Scan(byte[], byte[]) from Scan
[
https://issues.apache.org/jira/browse/HBASE-23842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-23842 started by Jan Hentschel.
-
> Remove deprecated Scan(byte[], byte[]) from Scan
>
>
> Key: HBASE-23842
> URL: https://issues.apache.org/jira/browse/HBASE-23842
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
>
> {{Scan(byte[], byte[])}} in {{Scan}} was deprecated back in 2.0.0 and should
> be removed for 3.0.0
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (HBASE-23842) Remove deprecated Scan(byte[], byte[]) from Scan
Jan Hentschel created HBASE-23842:
-
Summary: Remove deprecated Scan(byte[], byte[]) from Scan
Key: HBASE-23842
URL: https://issues.apache.org/jira/browse/HBASE-23842
Project: HBase
Issue Type: Sub-task
Affects Versions: 3.0.0
Reporter: Jan Hentschel
Assignee: Jan Hentschel
{{Scan(byte[], byte[])}} in {{Scan}} was deprecated back in 2.0.0 and should be
removed for 3.0.0
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (HBASE-23841) Remove deprecated methods from Scan
Jan Hentschel created HBASE-23841:
-
Summary: Remove deprecated methods from Scan
Key: HBASE-23841
URL: https://issues.apache.org/jira/browse/HBASE-23841
Project: HBase
Issue Type: Improvement
Affects Versions: 3.0.0
Reporter: Jan Hentschel
Assignee: Jan Hentschel
Umbrella ticket for handling the deprecations of {{Scan}} for version 3.0.0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work started] (HBASE-23841) Remove deprecated methods from Scan
[
https://issues.apache.org/jira/browse/HBASE-23841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-23841 started by Jan Hentschel.
-
> Remove deprecated methods from Scan
> ---
>
> Key: HBASE-23841
> URL: https://issues.apache.org/jira/browse/HBASE-23841
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
>
> Umbrella ticket for handling the deprecations of {{Scan}} for version 3.0.0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase-operator-tools] jatsakthi commented on issue #46: HBASE-23562 [operator tools] Add a RegionsMerge tool that allows for …
jatsakthi commented on issue #46: HBASE-23562 [operator tools] Add a RegionsMerge tool that allows for … URL: https://github.com/apache/hbase-operator-tools/pull/46#issuecomment-586468454 @wchevreuil also just in case if you are using/looping 2 regions merge, I think you can use the multi-region merge feature This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] HorizonNet commented on issue #1146: HBASE-23781 Removed deprecated createTableDescriptor(String) from HBaseTestingUtility
HorizonNet commented on issue #1146: HBASE-23781 Removed deprecated createTableDescriptor(String) from HBaseTestingUtility URL: https://github.com/apache/hbase/pull/1146#issuecomment-586467058 Test failures seem to be different with each build. Let me dig into it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23816) [Flakey Test] TestExportSnapshotNoCluster.testSnapshotV2WithRefsExportFileSystemState(TestExportSnapshotNoCluster.java:91) Wrong FS!
[
https://issues.apache.org/jira/browse/HBASE-23816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17037267#comment-17037267
]
Michael Stack commented on HBASE-23816:
---
In HBASE-23838 add some extra debug
> [Flakey Test]
> TestExportSnapshotNoCluster.testSnapshotV2WithRefsExportFileSystemState(TestExportSnapshotNoCluster.java:91)
> Wrong FS!
>
>
> Key: HBASE-23816
> URL: https://issues.apache.org/jira/browse/HBASE-23816
> Project: HBase
> Issue Type: Sub-task
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments: Screen Shot 2020-02-11 at 9.00.06 AM.png, Screen Shot
> 2020-02-12 at 7.12.41 PM.png
>
>
> Can't repro locally w/o running with lots of parallelism. Follow-on from
> parent issue.
> Here is error:
> {code}
> [ERROR] Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> 115.741 s <<< FAILURE! - in
> org.apache.hadoop.hbase.snapshot.TestExportSnapshotNoCluster
> [ERROR]
> org.apache.hadoop.hbase.snapshot.TestExportSnapshotNoCluster.testSnapshotV2WithRefsExportFileSystemState
> Time elapsed: 74.459 s <<< ERROR!
> java.lang.IllegalArgumentException: Wrong FS:
> file:/Users/stack/checkouts/hbase.apache.git/hbase-mapreduce/target/test-data/fad01338-65ef-e973-2412-05de114016fe/.hbase-snapshot/tableWithRefsV2,
> expected: hdfs://localhost:58051
>at
> org.apache.hadoop.hbase.snapshot.TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState(TestExportSnapshotNoCluster.java:107)
>at
> org.apache.hadoop.hbase.snapshot.TestExportSnapshotNoCluster.testSnapshotV2WithRefsExportFileSystemState(TestExportSnapshotNoCluster.java:91)
> {code}
> With v1 had just run find which does same thing.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-23631) Backport HBASE-23066, HBASE-23588, HBASE-23350 to branch-1
[ https://issues.apache.org/jira/browse/HBASE-23631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-23631: - Fix Version/s: (was: 1.6.0) > Backport HBASE-23066, HBASE-23588, HBASE-23350 to branch-1 > -- > > Key: HBASE-23631 > URL: https://issues.apache.org/jira/browse/HBASE-23631 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.6.0 >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > > Backport HBASE-23066 and all relevant subtasks to branch-1: > HBASE-23066: Create a config that forces to cache blocks on compaction > HBASE-23588: Cache index blocks and bloom blocks on write if > CacheCompactedBlocksOnWrite is enabled > HBASE-23350: Make compaction files cacheonWrite configurable based on > threshold -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23631) Backport HBASE-23066, HBASE-23588, HBASE-23350 to branch-1
[ https://issues.apache.org/jira/browse/HBASE-23631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-23631: - Fix Version/s: 1.6.0 > Backport HBASE-23066, HBASE-23588, HBASE-23350 to branch-1 > -- > > Key: HBASE-23631 > URL: https://issues.apache.org/jira/browse/HBASE-23631 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.6.0 >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Fix For: 1.6.0 > > > Backport HBASE-23066 and all relevant subtasks to branch-1: > HBASE-23066: Create a config that forces to cache blocks on compaction > HBASE-23588: Cache index blocks and bloom blocks on write if > CacheCompactedBlocksOnWrite is enabled > HBASE-23350: Make compaction files cacheonWrite configurable based on > threshold -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23631) Backport HBASE-23066, HBASE-23588, HBASE-23350 to branch-1
[ https://issues.apache.org/jira/browse/HBASE-23631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17037245#comment-17037245 ] Viraj Jasani commented on HBASE-23631: -- [~apurtell] all sub tasks are committed to master and branch-2. Would you like the backport in 1.6.0? > Backport HBASE-23066, HBASE-23588, HBASE-23350 to branch-1 > -- > > Key: HBASE-23631 > URL: https://issues.apache.org/jira/browse/HBASE-23631 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.6.0 >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > > Backport HBASE-23066 and all relevant subtasks to branch-1: > HBASE-23066: Create a config that forces to cache blocks on compaction > HBASE-23588: Cache index blocks and bloom blocks on write if > CacheCompactedBlocksOnWrite is enabled > HBASE-23350: Make compaction files cacheonWrite configurable based on > threshold -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23220) Release 1.6.0
[ https://issues.apache.org/jira/browse/HBASE-23220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17037232#comment-17037232 ] Andrew Kyle Purtell commented on HBASE-23220: - Unit tests generally look good. Some of the rsgroup tests time out but this is a known issue when they are executed in parallel with each other. > Release 1.6.0 > - > > Key: HBASE-23220 > URL: https://issues.apache.org/jira/browse/HBASE-23220 > Project: HBase > Issue Type: Task > Components: community >Affects Versions: 1.5.1 >Reporter: Sean Busbey >Assignee: Andrew Kyle Purtell >Priority: Major > > let's roll 1.6.0 to get HBASE-23174 out on recent branch-1 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] VladRodionov commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions
VladRodionov commented on a change in pull request #921: HBASE-22749:
Distributed MOB compactions
URL: https://github.com/apache/hbase/pull/921#discussion_r379600734
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCleanerChore.java
##
@@ -0,0 +1,310 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.mob;
+
+import java.io.FileNotFoundException;
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.TimeUnit;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.LocatedFileStatus;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.fs.RemoteIterator;
+import org.apache.hadoop.hbase.ScheduledChore;
+import org.apache.hadoop.hbase.TableDescriptors;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.backup.HFileArchiver;
+import org.apache.hadoop.hbase.client.Admin;
+import org.apache.hadoop.hbase.client.ColumnFamilyDescriptor;
+import org.apache.hadoop.hbase.client.Connection;
+import org.apache.hadoop.hbase.client.ConnectionFactory;
+import org.apache.hadoop.hbase.client.TableDescriptor;
+import org.apache.hadoop.hbase.io.hfile.CacheConfig;
+import org.apache.hadoop.hbase.master.HMaster;
+import org.apache.hadoop.hbase.regionserver.BloomType;
+import org.apache.hadoop.hbase.regionserver.HStoreFile;
+import org.apache.hadoop.hbase.util.EnvironmentEdgeManager;
+import org.apache.hadoop.hbase.util.FSUtils;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import
org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting;
+
+/**
+ * The class MobFileCleanerChore for running cleaner regularly to remove the
expired
+ * and obsolete (files which have no active references to) mob files.
+ */
+@SuppressWarnings("deprecation")
+@InterfaceAudience.Private
+public class MobFileCleanerChore extends ScheduledChore {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(MobFileCleanerChore.class);
+ private final HMaster master;
+ private ExpiredMobFileCleaner cleaner;
+
+ static {
+Configuration.addDeprecation(MobConstants.DEPRECATED_MOB_CLEANER_PERIOD,
+ MobConstants.MOB_CLEANER_PERIOD);
+ }
+
+ public MobFileCleanerChore(HMaster master) {
+super(master.getServerName() + "-ExpiredMobFileCleanerChore", master,
+master.getConfiguration().getInt(MobConstants.MOB_CLEANER_PERIOD,
+ MobConstants.DEFAULT_MOB_CLEANER_PERIOD),
+master.getConfiguration().getInt(MobConstants.MOB_CLEANER_PERIOD,
+ MobConstants.DEFAULT_MOB_CLEANER_PERIOD),
+TimeUnit.SECONDS);
+this.master = master;
+cleaner = new ExpiredMobFileCleaner();
+cleaner.setConf(master.getConfiguration());
+checkObsoleteConfigurations();
+ }
+
+ private void checkObsoleteConfigurations() {
+Configuration conf = master.getConfiguration();
+
+if (conf.get("hbase.mob.compaction.mergeable.threshold") != null) {
+ LOG.warn("'hbase.mob.compaction.mergeable.threshold' is obsolete and not
used anymore.");
+}
+if (conf.get("hbase.mob.delfile.max.count") != null) {
+ LOG.warn("'hbase.mob.delfile.max.count' is obsolete and not used
anymore.");
+}
+if (conf.get("hbase.mob.compaction.threads.max") != null) {
+ LOG.warn("'hbase.mob.compaction.threads.max' is obsolete and not used
anymore.");
+}
+if (conf.get("hbase.mob.compaction.batch.size") != null) {
+ LOG.warn("'hbase.mob.compaction.batch.size' is obsolete and not used
anymore.");
+}
+ }
+
+ @VisibleForTesting
+ public MobFileCleanerChore() {
+this.master = null;
+ }
+
+ @Override
+ @edu.umd.cs.findbugs.annotations.SuppressWarnings(value =
"REC_CATCH_EXCEPTION",
+ justification = "Intentional")
+
+ protected void chore() {
+TableDescriptors htds = master.getTableDescriptors();
+
+Map map = null;
+try {
+ map = htds.getAll();
+} catch (IOException e) {
+
[jira] [Commented] (HBASE-18095) Provide an option for clients to find the server hosting META that does not involve the ZooKeeper client
[
https://issues.apache.org/jira/browse/HBASE-18095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17037204#comment-17037204
]
Hudson commented on HBASE-18095:
Results for branch HBASE-18095/client-locate-meta-no-zookeeper
[build #75 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-18095%252Fclient-locate-meta-no-zookeeper/75/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-18095%252Fclient-locate-meta-no-zookeeper/75//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-18095%252Fclient-locate-meta-no-zookeeper/75//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-18095%252Fclient-locate-meta-no-zookeeper/75//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Provide an option for clients to find the server hosting META that does not
> involve the ZooKeeper client
>
>
> Key: HBASE-18095
> URL: https://issues.apache.org/jira/browse/HBASE-18095
> Project: HBase
> Issue Type: New Feature
> Components: Client
>Reporter: Andrew Kyle Purtell
>Assignee: Bharath Vissapragada
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 1.7.0
>
> Attachments: HBASE-18095.master-v1.patch, HBASE-18095.master-v2.patch
>
>
> Clients are required to connect to ZooKeeper to find the location of the
> regionserver hosting the meta table region. Site configuration provides the
> client a list of ZK quorum peers and the client uses an embedded ZK client to
> query meta location. Timeouts and retry behavior of this embedded ZK client
> are managed orthogonally to HBase layer settings and in some cases the ZK
> cannot manage what in theory the HBase client can, i.e. fail fast upon outage
> or network partition.
> We should consider new configuration settings that provide a list of
> well-known master and backup master locations, and with this information the
> client can contact any of the master processes directly. Any master in either
> active or passive state will track meta location and respond to requests for
> it with its cached last known location. If this location is stale, the client
> can ask again with a flag set that requests the master refresh its location
> cache and return the up-to-date location. Every client interaction with the
> cluster thus uses only HBase RPC as transport, with appropriate settings
> applied to the connection. The configuration toggle that enables this
> alternative meta location lookup should be false by default.
> This removes the requirement that HBase clients embed the ZK client and
> contact the ZK service directly at the beginning of the connection lifecycle.
> This has several benefits. ZK service need not be exposed to clients, and
> their potential abuse, yet no benefit ZK provides the HBase server cluster is
> compromised. Normalizing HBase client and ZK client timeout settings and
> retry behavior - in some cases, impossible, i.e. for fail-fast - is no longer
> necessary.
> And, from [~ghelmling]: There is an additional complication here for
> token-based authentication. When a delegation token is used for SASL
> authentication, the client uses the cluster ID obtained from Zookeeper to
> select the token identifier to use. So there would also need to be some
> Zookeeper-less, unauthenticated way to obtain the cluster ID as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-23840) Revert optimized IO back to general compaction during upgrade/migration process
[ https://issues.apache.org/jira/browse/HBASE-23840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Rodionov updated HBASE-23840: -- Summary: Revert optimized IO back to general compaction during upgrade/migration process (was: Revert optimized IO backt to general compaction during upgrade/migration process ) > Revert optimized IO back to general compaction during upgrade/migration > process > > > Key: HBASE-23840 > URL: https://issues.apache.org/jira/browse/HBASE-23840 > Project: HBase > Issue Type: Sub-task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Major > > Optimized mode IO compaction may leave old MOB file, which size is above > threshold as is and don't compact it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-23840) Revert optimized IO backt to general compaction during upgrade/migration process
Vladimir Rodionov created HBASE-23840: - Summary: Revert optimized IO backt to general compaction during upgrade/migration process Key: HBASE-23840 URL: https://issues.apache.org/jira/browse/HBASE-23840 Project: HBase Issue Type: Sub-task Reporter: Vladimir Rodionov Assignee: Vladimir Rodionov Optimized mode IO compaction may leave old MOB file, which size is above threshold as is and don't compact it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] virajjasani commented on issue #754: HBASE-22978 : Online slow response log
virajjasani commented on issue #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#issuecomment-586385701 Failed tests in recent build are passing locally, not relevant to the PR changes This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (HBASE-23808) [Flakey Test] TestMasterShutdown#testMasterShutdownBeforeStartingAnyRegionServer
[ https://issues.apache.org/jira/browse/HBASE-23808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-23808. -- Resolution: Fixed > [Flakey Test] > TestMasterShutdown#testMasterShutdownBeforeStartingAnyRegionServer > > > Key: HBASE-23808 > URL: https://issues.apache.org/jira/browse/HBASE-23808 > Project: HBase > Issue Type: Test > Components: test >Affects Versions: 2.3.0 >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.4 > > > Reproduces locally from time to time. Not much to go on here. Looks like the > test is trying to do some fancy HBase cluster initialization order on top of > a mini-cluster. Failure seems related to trying to start the HBase master > before HDFS is fully initialized. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23808) [Flakey Test] TestMasterShutdown#testMasterShutdownBeforeStartingAnyRegionServer
[ https://issues.apache.org/jira/browse/HBASE-23808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-23808: - Fix Version/s: 2.2.4 2.3.0 > [Flakey Test] > TestMasterShutdown#testMasterShutdownBeforeStartingAnyRegionServer > > > Key: HBASE-23808 > URL: https://issues.apache.org/jira/browse/HBASE-23808 > Project: HBase > Issue Type: Test > Components: test >Affects Versions: 2.3.0 >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.4 > > > Reproduces locally from time to time. Not much to go on here. Looks like the > test is trying to do some fancy HBase cluster initialization order on top of > a mini-cluster. Failure seems related to trying to start the HBase master > before HDFS is fully initialized. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] ndimiduk merged pull request #1170: Backport HBASE-23808 to branch-2.2
ndimiduk merged pull request #1170: Backport HBASE-23808 to branch-2.2 URL: https://github.com/apache/hbase/pull/1170 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ndimiduk merged pull request #1169: Backport HBASE-23808 to branch-2
ndimiduk merged pull request #1169: Backport HBASE-23808 to branch-2 URL: https://github.com/apache/hbase/pull/1169 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23562) [operator tools] Add a RegionsMerge tool that allows for merging multiple adjacent regions until a desired number of regions is reached.
[ https://issues.apache.org/jira/browse/HBASE-23562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17037037#comment-17037037 ] Wellington Chevreuil commented on HBASE-23562: -- Thanks [~sakthi]! Any suggestions for this PR? :D > [operator tools] Add a RegionsMerge tool that allows for merging multiple > adjacent regions until a desired number of regions is reached. > > > Key: HBASE-23562 > URL: https://issues.apache.org/jira/browse/HBASE-23562 > Project: HBase > Issue Type: New Feature >Reporter: Wellington Chevreuil >Assignee: Wellington Chevreuil >Priority: Minor > > There's been a few occasions where different customers had faced the need to > reduce the number of regions for specific tables, either due to mistakenly > pre-split or after a purge in table data. This jira is for adding a simple > merge tool that takes the table name and the desired number of regions, then > perform region merges until the total number of regions for the given table > reached the passed valued. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1167: HBASE-18095 Zookeeper-less client connection umbrella
Apache-HBase commented on issue #1167: HBASE-18095 Zookeeper-less client connection umbrella URL: https://github.com/apache/hbase/pull/1167#issuecomment-586267672 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 4s | No case conflicting files found. | | +0 :ok: | prototool | 0m 0s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 95 new or modified test files. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 34s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 24s | master passed | | +1 :green_heart: | compile | 3m 43s | master passed | | +1 :green_heart: | checkstyle | 2m 58s | master passed | | +0 :ok: | refguide | 5m 28s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | shadedjars | 4m 58s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 5m 30s | master passed | | +0 :ok: | spotbugs | 1m 21s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 24m 58s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 6s | the patch passed | | +1 :green_heart: | compile | 3m 4s | the patch passed | | +1 :green_heart: | cc | 3m 4s | the patch passed | | +1 :green_heart: | javac | 3m 4s | the patch passed | | -1 :x: | checkstyle | 2m 30s | root: The patch generated 1 new + 753 unchanged - 96 fixed = 754 total (was 849) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +0 :ok: | refguide | 4m 44s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | shadedjars | 4m 41s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 15m 51s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | hbaseprotoc | 8m 41s | the patch passed | | +1 :green_heart: | javadoc | 5m 35s | the patch passed | | +1 :green_heart: | findbugs | 26m 1s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 72m 8s | root in the patch failed. | | +1 :green_heart: | asflicense | 4m 45s | The patch does not generate ASF License warnings. | | | | 217m 28s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1167/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1167 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool refguide | | uname | Linux e1775d202116 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1167/out/precommit/personality/provided.sh | | git revision | master / 5f61df4792 | | Default Java | 1.8.0_181 | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1167/4/artifact/out/branch-site/book.html | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1167/4/artifact/out/diff-checkstyle-root.txt | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1167/4/artifact/out/patch-site/book.html | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1167/4/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1167/4/testReport/ | | Max. process+thread count | 9344 (vs. ulimit of 1) | | modules | C: hbase-protocol-shaded hbase-common hbase-client hbase-zookeeper hbase-server hbase-mapreduce hbase-thrift . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1167/4/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This
[jira] [Commented] (HBASE-22827) Expose multi-region merge in shell and Admin API
[
https://issues.apache.org/jira/browse/HBASE-22827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036948#comment-17036948
]
Hudson commented on HBASE-22827:
Results for branch master
[build #1629 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1629/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1629//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1629//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1629//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Expose multi-region merge in shell and Admin API
>
>
> Key: HBASE-22827
> URL: https://issues.apache.org/jira/browse/HBASE-22827
> Project: HBase
> Issue Type: Improvement
> Components: Admin, shell
>Reporter: Michael Stack
>Assignee: Sakthi
>Priority: Major
>
> HBASE-22777 adds being able to merge more than two regions at once. It is
> only available internally currently for use by hbck2 doing fixup of overlaps
> in hbase:meta. This issue is about exposing it via the Admin Interface and in
> turn, via the shell. Probably best if old two region merge method is
> deprecated.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23838) Adding debug logging to a few ExportSnapshot tests
[
https://issues.apache.org/jira/browse/HBASE-23838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036946#comment-17036946
]
Hudson commented on HBASE-23838:
Results for branch master
[build #1629 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1629/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1629//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1629//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1629//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Adding debug logging to a few ExportSnapshot tests
> --
>
> Key: HBASE-23838
> URL: https://issues.apache.org/jira/browse/HBASE-23838
> Project: HBase
> Issue Type: Bug
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Trivial
> Fix For: 3.0.0, 2.3.0
>
> Attachments:
> 0001-HBASE-23838-Adding-debug-logging-to-a-few-ExportSnap.patch
>
>
> Bit of extra logging in tests to help me diagnose where they are going wrong.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23808) [Flakey Test] TestMasterShutdown#testMasterShutdownBeforeStartingAnyRegionServer
[
https://issues.apache.org/jira/browse/HBASE-23808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036947#comment-17036947
]
Hudson commented on HBASE-23808:
Results for branch master
[build #1629 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1629/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1629//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1629//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1629//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [Flakey Test]
> TestMasterShutdown#testMasterShutdownBeforeStartingAnyRegionServer
>
>
> Key: HBASE-23808
> URL: https://issues.apache.org/jira/browse/HBASE-23808
> Project: HBase
> Issue Type: Test
> Components: test
>Affects Versions: 2.3.0
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0
>
>
> Reproduces locally from time to time. Not much to go on here. Looks like the
> test is trying to do some fancy HBase cluster initialization order on top of
> a mini-cluster. Failure seems related to trying to start the HBase master
> before HDFS is fully initialized.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-21776) Duplicate "Set storagePolicy" debug logging
[
https://issues.apache.org/jira/browse/HBASE-21776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036906#comment-17036906
]
Hudson commented on HBASE-21776:
Results for branch branch-1
[build #1231 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1231/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1231//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1231//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1231//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Duplicate "Set storagePolicy" debug logging
> ---
>
> Key: HBASE-21776
> URL: https://issues.apache.org/jira/browse/HBASE-21776
> Project: HBase
> Issue Type: Bug
> Components: Compaction
>Affects Versions: 1.5.0
>Reporter: Andrew Kyle Purtell
>Assignee: Sandeep Pal
>Priority: Trivial
> Labels: branch-1
> Fix For: 1.6.0
>
> Attachments: HBASE-21776-branch-1.001.patch
>
>
> An example:
> 2019-01-25 02:57:15,831 DEBUG
> [regionserver/ip-172-31-13-83.us-west-2.compute.internal/172.31.13.83:8120-longCompactions-1548384634805]
> util.CommonFSUtils: Set storagePolicy=HOT for
> path=hdfs://ip-172-31-5-95.us-west-2.compute.internal:8020/hbase/data/default/IntegrationTestBigLinkedList/16899cdfdb4ab217208f4108ad0c4803/.tmp/meta
> 2019-01-25 02:57:15,831 DEBUG
> [regionserver/ip-172-31-13-83.us-west-2.compute.internal/172.31.13.83:8120-longCompactions-1548384634805]
> util.CommonFSUtils: Set storagePolicy=HOT for
> path=hdfs://ip-172-31-5-95.us-west-2.compute.internal:8020/hbase/data/default/IntegrationTestBigLinkedList/16899cdfdb4ab217208f4108ad0c4803/.tmp/meta
> Seen most often during compactions. Ideally we only log once per directory
> per flush or compaction.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23835) TestFromClientSide3 and subclasses often fail on testScanAfterDeletingSpecifiedRowV2.
[ https://issues.apache.org/jira/browse/HBASE-23835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036897#comment-17036897 ] Mark Robert Miller commented on HBASE-23835: I've started to dig into this test - I've played around with speeding it up and hardening it - that led to a couple other little things in other code - I'll put up a pr for this test soon and spin off a JIRA issue or two. > TestFromClientSide3 and subclasses often fail on > testScanAfterDeletingSpecifiedRowV2. > - > > Key: HBASE-23835 > URL: https://issues.apache.org/jira/browse/HBASE-23835 > Project: HBase > Issue Type: Test >Affects Versions: master >Reporter: Mark Robert Miller >Priority: Major > > This test method fails a fair amount on me with something like: > TestFromClientSide3WoUnsafe>TestFromClientSide3.testScanAfterDeletingSpecifiedRowV2:236 > expected:<3> but was:<2> > I had a hunch that it might be due to interference from other test methods > running first so I tried changing the table name for just this method to be > unique - still fails. > However, when I just run testScanAfterDeletingSpecifiedRowV2 on it's own > without the methods, it does not seem to fail so far. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #754: HBASE-22978 : Online slow response log
Apache-HBase commented on issue #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#issuecomment-586195233 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +0 :ok: | prototool | 0m 0s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 6 new or modified test files. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 37s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 10s | master passed | | +1 :green_heart: | compile | 3m 6s | master passed | | +1 :green_heart: | checkstyle | 2m 24s | master passed | | +0 :ok: | refguide | 4m 48s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | shadedjars | 4m 41s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 5m 10s | master passed | | +0 :ok: | spotbugs | 1m 20s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 23m 8s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 5s | the patch passed | | +1 :green_heart: | compile | 3m 9s | the patch passed | | +1 :green_heart: | cc | 3m 9s | the patch passed | | +1 :green_heart: | javac | 3m 9s | the patch passed | | +1 :green_heart: | checkstyle | 2m 19s | root: The patch generated 0 new + 448 unchanged - 2 fixed = 448 total (was 450) | | +1 :green_heart: | rubocop | 0m 9s | There were no new rubocop issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | +0 :ok: | refguide | 4m 41s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | shadedjars | 4m 42s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 16m 0s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 :green_heart: | hbaseprotoc | 8m 36s | the patch passed | | +1 :green_heart: | javadoc | 5m 18s | the patch passed | | +1 :green_heart: | findbugs | 24m 42s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 70m 20s | root in the patch failed. | | +1 :green_heart: | asflicense | 4m 2s | The patch does not generate ASF License warnings. | | | | 207m 11s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestAsyncTableGetMultiThreaded | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.replication.TestNamespaceReplicationWithBulkLoadedData | | | hadoop.hbase.replication.TestNamespaceReplication | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/13/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/754 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml cc hbaseprotoc prototool rubocop | | uname | Linux 4c78be5576a0 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-754/out/precommit/personality/provided.sh | | git revision | master / 5f61df4792 | | Default Java | 1.8.0_181 | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/13/artifact/out/branch-site/book.html | | refguide | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/13/artifact/out/patch-site/book.html | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/13/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-754/13/testReport/ | | Max. process+thread count | 9807 (vs. ulimit of 1) | | modules | C:
[jira] [Commented] (HBASE-23829) Get `-PrunSmallTests` passing on JDK11
[
https://issues.apache.org/jira/browse/HBASE-23829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036804#comment-17036804
]
Mark Robert Miller commented on HBASE-23829:
Here is some work I have done towards this against small/med tests (so far have
not needed/jumped to hadoop 3x): https://github.com/markrmiller/hbase/tree/jdk11
> Get `-PrunSmallTests` passing on JDK11
> --
>
> Key: HBASE-23829
> URL: https://issues.apache.org/jira/browse/HBASE-23829
> Project: HBase
> Issue Type: Sub-task
> Components: test
>Reporter: Nick Dimiduk
>Priority: Major
>
> Start with the small tests, shaking out issues identified by the harness. So
> far it seems like {{-Dhadoop.profile=3.0}} and
> {{-Dhadoop-three.version=3.3.0-SNAPSHOT}} maybe be required.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
