[GitHub] [hbase] saintstack commented on a change in pull request #1274: HBASE-23968 Periodically check whether a system stop is requested in compaction by time.
saintstack commented on a change in pull request #1274: HBASE-23968
Periodically check whether a system stop is requested in compaction by time.
URL: https://github.com/apache/hbase/pull/1274#discussion_r399047446
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CloseChecker.java
##
@@ -0,0 +1,70 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.regionserver.compactions;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.regionserver.Store;
+import org.apache.yetus.audience.InterfaceAudience;
+
+/**
+ * Check periodically to see if a system stop is requested
+ */
+@InterfaceAudience.Private
+public class CloseChecker {
Review comment:
dang.
ok. public for now.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-24052) Add debug to TestMasterShutdown
[ https://issues.apache.org/jira/browse/HBASE-24052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068289#comment-17068289 ] Michael Stack commented on HBASE-24052: --- This failure is pretty informative: https://builds.apache.org/job/HBase-Flaky-Tests/job/branch-2/5884/artifact/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.master.TestMasterShutdown-output.txt The join on shutdown is not coming home though the shutdown went in to the master. We seem to be stuck trying to put up a ReadOnlyZKClient zk connection. I pushed a simplification on the test. Seems to be working. Will know more in morning. > Add debug to TestMasterShutdown > --- > > Key: HBASE-24052 > URL: https://issues.apache.org/jira/browse/HBASE-24052 > Project: HBase > Issue Type: Sub-task >Reporter: Michael Stack >Priority: Trivial > Attachments: > 0001-HBASE-24052-Add-debug-to-TestMasterShutdown.addendum.patch, > 0001-HBASE-24052-Add-debug-to-TestMasterShutdown.addendum2.patch, > 0001-HBASE-24052-Add-debug-to-TestMasterShutdown.patch > > > Temporarily add debug to TestMasterShutdown overnight to learn more about a > test failure not reproducible locally. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache9 opened a new pull request #1371: HBASE-24059 Set version as 2.1.10 in branch-2.1 in prep for first RC …
Apache9 opened a new pull request #1371: HBASE-24059 Set version as 2.1.10 in branch-2.1 in prep for first RC … URL: https://github.com/apache/hbase/pull/1371 …of 2.1.10 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-24059) Set version as 2.1.10 in branch-2.1 in prep for first RC of 2.1.10
[ https://issues.apache.org/jira/browse/HBASE-24059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24059: -- Fix Version/s: (was: 2.1.9) 2.1.10 > Set version as 2.1.10 in branch-2.1 in prep for first RC of 2.1.10 > -- > > Key: HBASE-24059 > URL: https://issues.apache.org/jira/browse/HBASE-24059 > Project: HBase > Issue Type: Sub-task > Components: build, pom >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 2.1.10 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24051) When the data directory is set to EC,the amount of storefiles reaches a relatively high level,heap Occupancy Percent is above heap occupancy alarm watermark,resulting in
[ https://issues.apache.org/jira/browse/HBASE-24051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shenshengli updated HBASE-24051: Priority: Critical (was: Major) > When the data directory is set to EC,the amount of storefiles reaches a > relatively high level,heap Occupancy Percent is above heap occupancy alarm > watermark,resulting in frequent gc and eventual failure > -- > > Key: HBASE-24051 > URL: https://issues.apache.org/jira/browse/HBASE-24051 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.1 >Reporter: shenshengli >Priority: Critical > Attachments: 1.png > > > When the data directory is set to EC, during the continuous load process, > regionserver is found down ,to view the log: > regionserver.HeapMemoryManager: heapOccupancyPercent 0.91630864 is now below > the heap occupancy alarm watermark (0.95) > regionserver.HeapMemoryManager: heapOccupancyPercent 0.969546 is above heap > occupancy alarm watermark (0.95) > [JvmPauseMonitor] util.JvmPauseMonitor: Detected pause in JVM or host machine > (eg GC): pause of approximately 1254ms > GC pool 'G1 Young Generation' had collection(s): count=2 time=115ms > GC pool 'G1 Old Generation' had collection(s): count=1 time=1487ms > In particular, GC pauses occurred 283 times in half an hour. > The memory analysis found that most of the memory footprint was generated by > HeepByteBuffer,and DFSStripedInputStream produces the HeepByteBuffer > See HDFS-14308，but after the fix, hbase did not return to normal. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24051) When the data directory is set to EC,the amount of storefiles reaches a relatively high level,heap Occupancy Percent is above heap occupancy alarm watermark,resulting in
[ https://issues.apache.org/jira/browse/HBASE-24051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shenshengli updated HBASE-24051: Priority: Major (was: Critical) > When the data directory is set to EC,the amount of storefiles reaches a > relatively high level,heap Occupancy Percent is above heap occupancy alarm > watermark,resulting in frequent gc and eventual failure > -- > > Key: HBASE-24051 > URL: https://issues.apache.org/jira/browse/HBASE-24051 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.1 >Reporter: shenshengli >Priority: Major > Attachments: 1.png > > > When the data directory is set to EC, during the continuous load process, > regionserver is found down ,to view the log: > regionserver.HeapMemoryManager: heapOccupancyPercent 0.91630864 is now below > the heap occupancy alarm watermark (0.95) > regionserver.HeapMemoryManager: heapOccupancyPercent 0.969546 is above heap > occupancy alarm watermark (0.95) > [JvmPauseMonitor] util.JvmPauseMonitor: Detected pause in JVM or host machine > (eg GC): pause of approximately 1254ms > GC pool 'G1 Young Generation' had collection(s): count=2 time=115ms > GC pool 'G1 Old Generation' had collection(s): count=1 time=1487ms > In particular, GC pauses occurred 283 times in half an hour. > The memory analysis found that most of the memory footprint was generated by > HeepByteBuffer,and DFSStripedInputStream produces the HeepByteBuffer > See HDFS-14308，but after the fix, hbase did not return to normal. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24051) When the data directory is set to EC,the amount of storefiles reaches a relatively high level,heap Occupancy Percent is above heap occupancy alarm watermark,resulting
[ https://issues.apache.org/jira/browse/HBASE-24051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068235#comment-17068235 ] shenshengli commented on HBASE-24051: - Another easy way to avoid errors is to add "implements CanUnbuffer" to the DFSStripedInputStream > When the data directory is set to EC,the amount of storefiles reaches a > relatively high level,heap Occupancy Percent is above heap occupancy alarm > watermark,resulting in frequent gc and eventual failure > -- > > Key: HBASE-24051 > URL: https://issues.apache.org/jira/browse/HBASE-24051 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.1 >Reporter: shenshengli >Priority: Major > Attachments: 1.png > > > When the data directory is set to EC, during the continuous load process, > regionserver is found down ,to view the log: > regionserver.HeapMemoryManager: heapOccupancyPercent 0.91630864 is now below > the heap occupancy alarm watermark (0.95) > regionserver.HeapMemoryManager: heapOccupancyPercent 0.969546 is above heap > occupancy alarm watermark (0.95) > [JvmPauseMonitor] util.JvmPauseMonitor: Detected pause in JVM or host machine > (eg GC): pause of approximately 1254ms > GC pool 'G1 Young Generation' had collection(s): count=2 time=115ms > GC pool 'G1 Old Generation' had collection(s): count=1 time=1487ms > In particular, GC pauses occurred 283 times in half an hour. > The memory analysis found that most of the memory footprint was generated by > HeepByteBuffer,and DFSStripedInputStream produces the HeepByteBuffer > See HDFS-14308，but after the fix, hbase did not return to normal. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24053) hbase/bin/region_status.rb Not available in hbase2
[ https://issues.apache.org/jira/browse/HBASE-24053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068231#comment-17068231 ] shenshengli commented on HBASE-24053: - Before modification, when./hbase-jruby region_status.rb is executed, an error is reported: NameError:uninitialized constant IOException Did you mean? Exception ... After I follow the instructions to modify,an error is reported: NoMethodError:undefined method 'getHRegionInfo' for Java::OrApacheHadoopHbase::MetaTableAccessor:class Did you mean? get_region_info So I revised it again,an error is reported: NameError: undefined local variable or method 'scanner' for main:Object When I last modified it, it returned correct > hbase/bin/region_status.rb Not available in hbase2 > -- > > Key: HBASE-24053 > URL: https://issues.apache.org/jira/browse/HBASE-24053 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.1 >Reporter: shenshengli >Priority: Minor > > A series of strange errors occurred while running this script in hbase2, > which was corrected as prompted, and note that in hbase2's MetaTableAccessor, > getHRegionInfo has been replaced by getRegionInfo -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24065) Enable SpotBugs in PreCommit
[
https://issues.apache.org/jira/browse/HBASE-24065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068229#comment-17068229
]
Duo Zhang commented on HBASE-24065:
---
We are running spotbugs now I think? Aren't we?
> Enable SpotBugs in PreCommit
>
>
> Key: HBASE-24065
> URL: https://issues.apache.org/jira/browse/HBASE-24065
> Project: HBase
> Issue Type: Task
> Components: build, test
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
>
> Yetus's SpotBugs module depends on {{maven_add_install}}. In
> {{Jenkinsfile_GitHub}}, I'm pretty strict on my module definitions, with
> {noformat}
> GENERAL_CHECK_PLUGINS = 'all,-compile,-javac,-javadoc,-jira,-shadedjars,-unit'
> JDK_SPECIFIC_PLUGINS =
> 'compile,github,htmlout,javac,javadoc,maven,mvninstall,shadedjars,unit'
> {noformat}
> The general check requests {{all}} but omits {{compile}} and {{maven}}, which
> I think means the {{spotbugs}} check gets dropped. Before HBASE-23767, we had
> just a single yetus that did {{all}}, so {{spotbugs}} would have been run.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (HBASE-24050) Deprecated PBType on all 2.x branches
[ https://issues.apache.org/jira/browse/HBASE-24050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-24050. --- Hadoop Flags: Reviewed Resolution: Fixed Pushed to branch-2, branch-2.3, branch-2.2 and branch-2.1 Thanks [~janh] and [~vjasani] for reviewing. > Deprecated PBType on all 2.x branches > - > > Key: HBASE-24050 > URL: https://issues.apache.org/jira/browse/HBASE-24050 > Project: HBase > Issue Type: Sub-task > Components: Protobufs >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 2.3.0, 2.1.10, 2.2.5 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24053) hbase/bin/region_status.rb Not available in hbase2
[ https://issues.apache.org/jira/browse/HBASE-24053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shenshengli updated HBASE-24053: Description: A series of strange errors occurred while running this script in hbase2, which was corrected as prompted, and note that in hbase2's MetaTableAccessor, getHRegionInfo has been replaced by getRegionInfo (was: A series of strange errors occurred while running this script in hbase2, which was corrected as prompted, and it was important to note that MetaTableAccessor had been replaced with getHRegionInfo instead of getHRegionInfo) > hbase/bin/region_status.rb Not available in hbase2 > -- > > Key: HBASE-24053 > URL: https://issues.apache.org/jira/browse/HBASE-24053 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.1 >Reporter: shenshengli >Priority: Minor > > A series of strange errors occurred while running this script in hbase2, > which was corrected as prompted, and note that in hbase2's MetaTableAccessor, > getHRegionInfo has been replaced by getRegionInfo -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache9 merged pull request #1354: HBASE-24050 Deprecated PBType on all 2.x branches
Apache9 merged pull request #1354: HBASE-24050 Deprecated PBType on all 2.x branches URL: https://github.com/apache/hbase/pull/1354 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22146) SpaceQuotaViolationPolicy Disable is not working in Namespace level
[ https://issues.apache.org/jira/browse/HBASE-22146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22146: -- Fix Version/s: (was: 2.1.10) > SpaceQuotaViolationPolicy Disable is not working in Namespace level > --- > > Key: HBASE-22146 > URL: https://issues.apache.org/jira/browse/HBASE-22146 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0, 2.0.0 >Reporter: Uma Maheswari >Assignee: Shardul Singh >Priority: Major > Labels: Quota, space > Fix For: 3.0.0, 2.2.5 > > > SpaceQuotaViolationPolicy Disable is not working in Namespace level > PFB the steps: > * Create Namespace and set Quota violation policy as Disable > * Create tables under namespace and violate Quota > Expected result: Tables to get disabled > Actual Result: Tables are not getting disabled > Note: mutation operation is not allowed on the table -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24051) When the data directory is set to EC,the amount of storefiles reaches a relatively high level,heap Occupancy Percent is above heap occupancy alarm watermark,resulting
[ https://issues.apache.org/jira/browse/HBASE-24051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068225#comment-17068225 ] shenshengli commented on HBASE-24051: - I don't know why hbase keeps those inputstreams after load, just unbuffer.I'll keep watching. > When the data directory is set to EC,the amount of storefiles reaches a > relatively high level,heap Occupancy Percent is above heap occupancy alarm > watermark,resulting in frequent gc and eventual failure > -- > > Key: HBASE-24051 > URL: https://issues.apache.org/jira/browse/HBASE-24051 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.1 >Reporter: shenshengli >Priority: Major > Attachments: 1.png > > > When the data directory is set to EC, during the continuous load process, > regionserver is found down ,to view the log: > regionserver.HeapMemoryManager: heapOccupancyPercent 0.91630864 is now below > the heap occupancy alarm watermark (0.95) > regionserver.HeapMemoryManager: heapOccupancyPercent 0.969546 is above heap > occupancy alarm watermark (0.95) > [JvmPauseMonitor] util.JvmPauseMonitor: Detected pause in JVM or host machine > (eg GC): pause of approximately 1254ms > GC pool 'G1 Young Generation' had collection(s): count=2 time=115ms > GC pool 'G1 Old Generation' had collection(s): count=1 time=1487ms > In particular, GC pauses occurred 283 times in half an hour. > The memory analysis found that most of the memory footprint was generated by > HeepByteBuffer,and DFSStripedInputStream produces the HeepByteBuffer > See HDFS-14308，but after the fix, hbase did not return to normal. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-24040) WALFactory.Providers.multiwal causes StackOverflowError
[
https://issues.apache.org/jira/browse/HBASE-24040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang resolved HBASE-24040.
---
Hadoop Flags: Reviewed
Resolution: Fixed
Pushed to all branches.
Thanks [~wenfeiyi666] for contributing.
> WALFactory.Providers.multiwal causes StackOverflowError
> ---
>
> Key: HBASE-24040
> URL: https://issues.apache.org/jira/browse/HBASE-24040
> Project: HBase
> Issue Type: Bug
> Components: wal
>Affects Versions: 1.0.0, 2.0.0
>Reporter: wenfeiyi666
>Assignee: wenfeiyi666
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.3.7, 1.7.0, 2.1.10, 1.4.14, 2.2.5
>
>
> if 'hbase.wal.provider=multiwal' and
> 'hbase.wal.regiongrouping.delegate.provider=multiwal', regionserver will
> create RegionGroupingProvider in a loop until StackOverflowError.
> {code:java}
> 2020-03-24 19:08:19,180 WARN [RS_CLOSE_META-regionserver/localhost:16020-0]
> handler.AssignRegionHandler: Fatal error occurred while opening region
> hbase:meta,,1.1
> 588230740, aborting...
> java.lang.StackOverflowError
> at
> java.lang.AbstractStringBuilder.ensureCapacityInternal(AbstractStringBuilder.java:125)
> at
> java.lang.AbstractStringBuilder.append(AbstractStringBuilder.java:566)
> at java.lang.StringBuffer.append(StringBuffer.java:357)
> at
> org.apache.log4j.helpers.ISO8601DateFormat.format(ISO8601DateFormat.java:134)
> at java.text.DateFormat.format(DateFormat.java:345)
> at
> org.apache.log4j.helpers.PatternParser$DatePatternConverter.convert(PatternParser.java:443)
> at
> org.apache.log4j.helpers.PatternConverter.format(PatternConverter.java:65)
> at org.apache.log4j.PatternLayout.format(PatternLayout.java:506)
> at org.apache.log4j.WriterAppender.subAppend(WriterAppender.java:310)
> at
> org.apache.log4j.RollingFileAppender.subAppend(RollingFileAppender.java:276)
> at org.apache.log4j.WriterAppender.append(WriterAppender.java:162)
> at
> org.apache.log4j.AppenderSkeleton.doAppend(AppenderSkeleton.java:251)
> at
> org.apache.log4j.helpers.AppenderAttachableImpl.appendLoopOnAppenders(AppenderAttachableImpl.java:66)
> at org.apache.log4j.Category.callAppenders(Category.java:206)
> at org.apache.log4j.Category.forcedLog(Category.java:391)
> at org.apache.log4j.Category.log(Category.java:856)
> at org.slf4j.impl.Log4jLoggerAdapter.info(Log4jLoggerAdapter.java:304)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.getStrategy(RegionGroupingProvider.java:105)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.init(RegionGroupingProvider.java:160)
> at
> org.apache.hadoop.hbase.wal.WALFactory.createProvider(WALFactory.java:161)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.createProvider(RegionGroupingProvider.java:166)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.getWAL(RegionGroupingProvider.java:184)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.getWAL(RegionGroupingProvider.java:212)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.getWAL(RegionGroupingProvider.java:192)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.getWAL(RegionGroupingProvider.java:212)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.getWAL(RegionGroupingProvider.java:192)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.getWAL(RegionGroupingProvider.java:212)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.getWAL(RegionGroupingProvider.java:192)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.getWAL(RegionGroupingProvider.java:212)
> ..
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1369: HBASE-24054
Apache-HBase commented on issue #1369: HBASE-24054 URL: https://github.com/apache/hbase/pull/1369#issuecomment-604784957 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 9s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 20s | master passed | | +1 :green_heart: | checkstyle | 0m 13s | master passed | | +1 :green_heart: | spotbugs | 0m 35s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 55s | the patch passed | | +1 :green_heart: | checkstyle | 0m 12s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 9s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 0m 43s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 12s | The patch does not generate ASF License warnings. | | | | 35m 3s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1369/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1369 | | JIRA Issue | HBASE-24054 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux c14c8002ae61 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / eb1fec1c53 | | Max. process+thread count | 83 (vs. ulimit of 1) | | modules | C: hbase-http U: hbase-http | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1369/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1369: HBASE-24054
Apache-HBase commented on issue #1369: HBASE-24054 URL: https://github.com/apache/hbase/pull/1369#issuecomment-604783541 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 45s | master passed | | +1 :green_heart: | compile | 0m 23s | master passed | | +1 :green_heart: | shadedjars | 5m 54s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 20s | hbase-http in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 20s | the patch passed | | +1 :green_heart: | compile | 0m 23s | the patch passed | | +1 :green_heart: | javac | 0m 23s | the patch passed | | +1 :green_heart: | shadedjars | 5m 52s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 17s | hbase-http in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 40s | hbase-http in the patch passed. | | | | 28m 42s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1369/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1369 | | JIRA Issue | HBASE-24054 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux e19401ec1fa4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / eb1fec1c53 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1369/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-http.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1369/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-http.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1369/1/testReport/ | | Max. process+thread count | 438 (vs. ulimit of 1) | | modules | C: hbase-http U: hbase-http | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1369/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] mwkang commented on issue #1274: HBASE-23968 Periodically check whether a system stop is requested in compaction by time.
mwkang commented on issue #1274: HBASE-23968 Periodically check whether a system stop is requested in compaction by time. URL: https://github.com/apache/hbase/pull/1274#issuecomment-604783606 @saintstack Thank you for your review. I reflected your feedback. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1369: HBASE-24054
Apache-HBase commented on issue #1369: HBASE-24054 URL: https://github.com/apache/hbase/pull/1369#issuecomment-604783271 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 20s | master passed | | +1 :green_heart: | compile | 0m 21s | master passed | | +1 :green_heart: | shadedjars | 5m 31s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 16s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 1s | the patch passed | | +1 :green_heart: | compile | 0m 21s | the patch passed | | +1 :green_heart: | javac | 0m 21s | the patch passed | | +1 :green_heart: | shadedjars | 5m 30s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 15s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 55s | hbase-http in the patch passed. | | | | 27m 40s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1369/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1369 | | JIRA Issue | HBASE-24054 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 31fd53ecf224 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / eb1fec1c53 | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1369/1/testReport/ | | Max. process+thread count | 417 (vs. ulimit of 1) | | modules | C: hbase-http U: hbase-http | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1369/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-24051) When the data directory is set to EC,the amount of storefiles reaches a relatively high level,heap Occupancy Percent is above heap occupancy alarm watermark,resulting
[ https://issues.apache.org/jira/browse/HBASE-24051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068218#comment-17068218 ] shenshengli commented on HBASE-24051: - I don't think you can pin your hopes on someone else thinking about perfection,So the hbase side as a client needs to be as thoughtful as possible. > When the data directory is set to EC,the amount of storefiles reaches a > relatively high level,heap Occupancy Percent is above heap occupancy alarm > watermark,resulting in frequent gc and eventual failure > -- > > Key: HBASE-24051 > URL: https://issues.apache.org/jira/browse/HBASE-24051 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.1 >Reporter: shenshengli >Priority: Major > Attachments: 1.png > > > When the data directory is set to EC, during the continuous load process, > regionserver is found down ,to view the log: > regionserver.HeapMemoryManager: heapOccupancyPercent 0.91630864 is now below > the heap occupancy alarm watermark (0.95) > regionserver.HeapMemoryManager: heapOccupancyPercent 0.969546 is above heap > occupancy alarm watermark (0.95) > [JvmPauseMonitor] util.JvmPauseMonitor: Detected pause in JVM or host machine > (eg GC): pause of approximately 1254ms > GC pool 'G1 Young Generation' had collection(s): count=2 time=115ms > GC pool 'G1 Old Generation' had collection(s): count=1 time=1487ms > In particular, GC pauses occurred 283 times in half an hour. > The memory analysis found that most of the memory footprint was generated by > HeepByteBuffer,and DFSStripedInputStream produces the HeepByteBuffer > See HDFS-14308，but after the fix, hbase did not return to normal. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1370: HBASE-24053 Correct some errors to make it available in hbase2
Apache-HBase commented on issue #1370: HBASE-24053 Correct some errors to make it available in hbase2 URL: https://github.com/apache/hbase/pull/1370#issuecomment-604782395 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 54s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 4m 0s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1370/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1370 | | Optional Tests | | | uname | Linux 7fffb8fc4f24 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / eb1fec1c53 | | Max. process+thread count | 41 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1370/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1370: HBASE-24053 Correct some errors to make it available in hbase2
Apache-HBase commented on issue #1370: HBASE-24053 Correct some errors to make it available in hbase2 URL: https://github.com/apache/hbase/pull/1370#issuecomment-604781971 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | | -0 :warning: | rubocop | 0m 4s | The patch generated 2 new + 19 unchanged - 1 fixed = 21 total (was 20) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. | | | | 2m 14s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1370/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1370 | | Optional Tests | dupname asflicense rubocop | | uname | Linux e687fe14aa54 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / eb1fec1c53 | | rubocop | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1370/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt | | Max. process+thread count | 46 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1370/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) rubocop=0.80.0 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1370: HBASE-24053 Correct some errors to make it available in hbase2
Apache-HBase commented on issue #1370: HBASE-24053 Correct some errors to make it available in hbase2 URL: https://github.com/apache/hbase/pull/1370#issuecomment-604781816 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 1m 37s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1370/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1370 | | Optional Tests | | | uname | Linux 2896e9867aa6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / eb1fec1c53 | | Max. process+thread count | 56 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1370/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-24053) hbase/bin/region_status.rb Not available in hbase2
[ https://issues.apache.org/jira/browse/HBASE-24053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068215#comment-17068215 ] shenshengli commented on HBASE-24053: - Re-pull request > hbase/bin/region_status.rb Not available in hbase2 > -- > > Key: HBASE-24053 > URL: https://issues.apache.org/jira/browse/HBASE-24053 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.1 >Reporter: shenshengli >Priority: Minor > > A series of strange errors occurred while running this script in hbase2, > which was corrected as prompted, and it was important to note that > MetaTableAccessor had been replaced with getHRegionInfo instead of > getHRegionInfo -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] mwkang commented on a change in pull request #1274: HBASE-23968 Periodically check whether a system stop is requested in compaction by time.
mwkang commented on a change in pull request #1274: HBASE-23968 Periodically
check whether a system stop is requested in compaction by time.
URL: https://github.com/apache/hbase/pull/1274#discussion_r398998728
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java
##
@@ -317,7 +318,14 @@ protected boolean performCompaction(FileDetails fd,
InternalScanner scanner, Cel
do {
hasMore = scanner.next(cells, scannerContext);
-now = EnvironmentEdgeManager.currentTime();
+currentTime = EnvironmentEdgeManager.currentTime();
+if (LOG.isDebugEnabled()) {
+ now = currentTime;
+}
+if (closeChecker.isClosedByTimeLimit(store, currentTime)) {
Review comment:
> This is a bug fix?
No, It is not a bug fix. I think it is `improvement`.
> s/isClosedByTimeLime/isTimeLimit/ ... and
s/isClosedBySizeLiimt/isSizeLimit/
Okay.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] mwkang commented on a change in pull request #1274: HBASE-23968 Periodically check whether a system stop is requested in compaction by time.
mwkang commented on a change in pull request #1274: HBASE-23968 Periodically
check whether a system stop is requested in compaction by time.
URL: https://github.com/apache/hbase/pull/1274#discussion_r398998333
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CloseChecker.java
##
@@ -0,0 +1,70 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.regionserver.compactions;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.regionserver.Store;
+import org.apache.yetus.audience.InterfaceAudience;
+
+/**
+ * Check periodically to see if a system stop is requested
+ */
+@InterfaceAudience.Private
+public class CloseChecker {
Review comment:
I think it would be good to use `package local`.
However, The package of `FaultyMobStoreCompactor` is not the same as
`CloseChecker`.
The package of `FaultyMobStoreCompactor` is `org.apache.hadoop.hbase.mob`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] shenshengli opened a new pull request #1370: HBASE-24053 Correct some errors to make it available in hbase2
shenshengli opened a new pull request #1370: HBASE-24053 Correct some errors to make it available in hbase2 URL: https://github.com/apache/hbase/pull/1370 Re-pull request This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] shenshengli closed pull request #1358: HBASE-24053
shenshengli closed pull request #1358: HBASE-24053 URL: https://github.com/apache/hbase/pull/1358 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] shenshengli commented on issue #1358: HBASE-24053
shenshengli commented on issue #1358: HBASE-24053 URL: https://github.com/apache/hbase/pull/1358#issuecomment-604779570 Incorrect pull request This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] mwkang commented on a change in pull request #1274: HBASE-23968 Periodically check whether a system stop is requested in compaction by time.
mwkang commented on a change in pull request #1274: HBASE-23968 Periodically
check whether a system stop is requested in compaction by time.
URL: https://github.com/apache/hbase/pull/1274#discussion_r398997341
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CloseChecker.java
##
@@ -0,0 +1,70 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.regionserver.compactions;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.regionserver.Store;
+import org.apache.yetus.audience.InterfaceAudience;
+
+/**
+ * Check periodically to see if a system stop is requested
+ */
+@InterfaceAudience.Private
+public class CloseChecker {
+ public static final String SIZE_LIMIT_KEY =
"hbase.hstore.close.check.interval";
+ public static final String TIME_LIMIT_KEY =
"hbase.hstore.close.check.time.interval";
+
+ private final int closeCheckSizeLimit;
+ private final long closeCheckTimeLimit;
+
+ private long bytesWrittenProgressForCloseCheck;
+ private long lastCloseCheckMillis;
+
+ public CloseChecker(Configuration conf, long currentTime) {
+this.closeCheckSizeLimit = conf.getInt(SIZE_LIMIT_KEY, 10 * 1000 * 1000 /*
10 MB */);
+this.closeCheckTimeLimit = conf.getLong(TIME_LIMIT_KEY, 10 * 1000L /* 10 s
*/);
+this.bytesWrittenProgressForCloseCheck = 0;
+this.lastCloseCheckMillis = currentTime;
+ }
+
+ public boolean isClosedBySizeLimit(Store store, long bytesWritten) {
+if (closeCheckSizeLimit <= 0) {
+ return false;
+}
+
+bytesWrittenProgressForCloseCheck += bytesWritten;
+if (bytesWrittenProgressForCloseCheck <= closeCheckSizeLimit) {
+ return false;
+}
+
+bytesWrittenProgressForCloseCheck = 0;
+return !store.areWritesEnabled();
+ }
+
+ public boolean isClosedByTimeLimit(Store store, long now) {
+if (closeCheckTimeLimit <= 0) {
+ return false;
+}
+
+final long elapsedMillis = now - lastCloseCheckMillis;
+if (elapsedMillis <= closeCheckTimeLimit) {
+ return false;
+}
+
+lastCloseCheckMillis = now;
Review comment:
CloseChecker is created and used in `performCompaction`.
```java
protected boolean performCompaction() throws IOException {
CloseChecker closeChecker = new CloseChecker(conf, currentTime);
try {
do {
// ...
}
}
```
I think unuse `volatile` is okay.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Updated] (HBASE-22146) SpaceQuotaViolationPolicy Disable is not working in Namespace level
[ https://issues.apache.org/jira/browse/HBASE-22146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22146: -- Fix Version/s: (was: 2.0.7) > SpaceQuotaViolationPolicy Disable is not working in Namespace level > --- > > Key: HBASE-22146 > URL: https://issues.apache.org/jira/browse/HBASE-22146 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0, 2.0.0 >Reporter: Uma Maheswari >Assignee: Shardul Singh >Priority: Major > Labels: Quota, space > Fix For: 3.0.0, 2.1.10, 2.2.5 > > > SpaceQuotaViolationPolicy Disable is not working in Namespace level > PFB the steps: > * Create Namespace and set Quota violation policy as Disable > * Create tables under namespace and violate Quota > Expected result: Tables to get disabled > Actual Result: Tables are not getting disabled > Note: mutation operation is not allowed on the table -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24040) WALFactory.Providers.multiwal causes StackOverflowError
[
https://issues.apache.org/jira/browse/HBASE-24040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-24040:
--
Fix Version/s: 1.7.0
> WALFactory.Providers.multiwal causes StackOverflowError
> ---
>
> Key: HBASE-24040
> URL: https://issues.apache.org/jira/browse/HBASE-24040
> Project: HBase
> Issue Type: Bug
> Components: wal
>Affects Versions: 1.0.0, 2.0.0
>Reporter: wenfeiyi666
>Assignee: wenfeiyi666
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.7.0, 2.1.10, 1.4.14, 2.2.5
>
>
> if 'hbase.wal.provider=multiwal' and
> 'hbase.wal.regiongrouping.delegate.provider=multiwal', regionserver will
> create RegionGroupingProvider in a loop until StackOverflowError.
> {code:java}
> 2020-03-24 19:08:19,180 WARN [RS_CLOSE_META-regionserver/localhost:16020-0]
> handler.AssignRegionHandler: Fatal error occurred while opening region
> hbase:meta,,1.1
> 588230740, aborting...
> java.lang.StackOverflowError
> at
> java.lang.AbstractStringBuilder.ensureCapacityInternal(AbstractStringBuilder.java:125)
> at
> java.lang.AbstractStringBuilder.append(AbstractStringBuilder.java:566)
> at java.lang.StringBuffer.append(StringBuffer.java:357)
> at
> org.apache.log4j.helpers.ISO8601DateFormat.format(ISO8601DateFormat.java:134)
> at java.text.DateFormat.format(DateFormat.java:345)
> at
> org.apache.log4j.helpers.PatternParser$DatePatternConverter.convert(PatternParser.java:443)
> at
> org.apache.log4j.helpers.PatternConverter.format(PatternConverter.java:65)
> at org.apache.log4j.PatternLayout.format(PatternLayout.java:506)
> at org.apache.log4j.WriterAppender.subAppend(WriterAppender.java:310)
> at
> org.apache.log4j.RollingFileAppender.subAppend(RollingFileAppender.java:276)
> at org.apache.log4j.WriterAppender.append(WriterAppender.java:162)
> at
> org.apache.log4j.AppenderSkeleton.doAppend(AppenderSkeleton.java:251)
> at
> org.apache.log4j.helpers.AppenderAttachableImpl.appendLoopOnAppenders(AppenderAttachableImpl.java:66)
> at org.apache.log4j.Category.callAppenders(Category.java:206)
> at org.apache.log4j.Category.forcedLog(Category.java:391)
> at org.apache.log4j.Category.log(Category.java:856)
> at org.slf4j.impl.Log4jLoggerAdapter.info(Log4jLoggerAdapter.java:304)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.getStrategy(RegionGroupingProvider.java:105)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.init(RegionGroupingProvider.java:160)
> at
> org.apache.hadoop.hbase.wal.WALFactory.createProvider(WALFactory.java:161)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.createProvider(RegionGroupingProvider.java:166)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.getWAL(RegionGroupingProvider.java:184)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.getWAL(RegionGroupingProvider.java:212)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.getWAL(RegionGroupingProvider.java:192)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.getWAL(RegionGroupingProvider.java:212)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.getWAL(RegionGroupingProvider.java:192)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.getWAL(RegionGroupingProvider.java:212)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.getWAL(RegionGroupingProvider.java:192)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.getWAL(RegionGroupingProvider.java:212)
> ..
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-24040) WALFactory.Providers.multiwal causes StackOverflowError
[
https://issues.apache.org/jira/browse/HBASE-24040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-24040:
--
Fix Version/s: 1.3.7
> WALFactory.Providers.multiwal causes StackOverflowError
> ---
>
> Key: HBASE-24040
> URL: https://issues.apache.org/jira/browse/HBASE-24040
> Project: HBase
> Issue Type: Bug
> Components: wal
>Affects Versions: 1.0.0, 2.0.0
>Reporter: wenfeiyi666
>Assignee: wenfeiyi666
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 1.3.7, 1.7.0, 2.1.10, 1.4.14, 2.2.5
>
>
> if 'hbase.wal.provider=multiwal' and
> 'hbase.wal.regiongrouping.delegate.provider=multiwal', regionserver will
> create RegionGroupingProvider in a loop until StackOverflowError.
> {code:java}
> 2020-03-24 19:08:19,180 WARN [RS_CLOSE_META-regionserver/localhost:16020-0]
> handler.AssignRegionHandler: Fatal error occurred while opening region
> hbase:meta,,1.1
> 588230740, aborting...
> java.lang.StackOverflowError
> at
> java.lang.AbstractStringBuilder.ensureCapacityInternal(AbstractStringBuilder.java:125)
> at
> java.lang.AbstractStringBuilder.append(AbstractStringBuilder.java:566)
> at java.lang.StringBuffer.append(StringBuffer.java:357)
> at
> org.apache.log4j.helpers.ISO8601DateFormat.format(ISO8601DateFormat.java:134)
> at java.text.DateFormat.format(DateFormat.java:345)
> at
> org.apache.log4j.helpers.PatternParser$DatePatternConverter.convert(PatternParser.java:443)
> at
> org.apache.log4j.helpers.PatternConverter.format(PatternConverter.java:65)
> at org.apache.log4j.PatternLayout.format(PatternLayout.java:506)
> at org.apache.log4j.WriterAppender.subAppend(WriterAppender.java:310)
> at
> org.apache.log4j.RollingFileAppender.subAppend(RollingFileAppender.java:276)
> at org.apache.log4j.WriterAppender.append(WriterAppender.java:162)
> at
> org.apache.log4j.AppenderSkeleton.doAppend(AppenderSkeleton.java:251)
> at
> org.apache.log4j.helpers.AppenderAttachableImpl.appendLoopOnAppenders(AppenderAttachableImpl.java:66)
> at org.apache.log4j.Category.callAppenders(Category.java:206)
> at org.apache.log4j.Category.forcedLog(Category.java:391)
> at org.apache.log4j.Category.log(Category.java:856)
> at org.slf4j.impl.Log4jLoggerAdapter.info(Log4jLoggerAdapter.java:304)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.getStrategy(RegionGroupingProvider.java:105)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.init(RegionGroupingProvider.java:160)
> at
> org.apache.hadoop.hbase.wal.WALFactory.createProvider(WALFactory.java:161)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.createProvider(RegionGroupingProvider.java:166)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.getWAL(RegionGroupingProvider.java:184)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.getWAL(RegionGroupingProvider.java:212)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.getWAL(RegionGroupingProvider.java:192)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.getWAL(RegionGroupingProvider.java:212)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.getWAL(RegionGroupingProvider.java:192)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.getWAL(RegionGroupingProvider.java:212)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.getWAL(RegionGroupingProvider.java:192)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.getWAL(RegionGroupingProvider.java:212)
> ..
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-24040) WALFactory.Providers.multiwal causes StackOverflowError
[
https://issues.apache.org/jira/browse/HBASE-24040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-24040:
--
Fix Version/s: (was: 2.4.0)
> WALFactory.Providers.multiwal causes StackOverflowError
> ---
>
> Key: HBASE-24040
> URL: https://issues.apache.org/jira/browse/HBASE-24040
> Project: HBase
> Issue Type: Bug
> Components: wal
>Affects Versions: 1.0.0, 2.0.0
>Reporter: wenfeiyi666
>Assignee: wenfeiyi666
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.1.10, 1.4.14, 2.2.5
>
>
> if 'hbase.wal.provider=multiwal' and
> 'hbase.wal.regiongrouping.delegate.provider=multiwal', regionserver will
> create RegionGroupingProvider in a loop until StackOverflowError.
> {code:java}
> 2020-03-24 19:08:19,180 WARN [RS_CLOSE_META-regionserver/localhost:16020-0]
> handler.AssignRegionHandler: Fatal error occurred while opening region
> hbase:meta,,1.1
> 588230740, aborting...
> java.lang.StackOverflowError
> at
> java.lang.AbstractStringBuilder.ensureCapacityInternal(AbstractStringBuilder.java:125)
> at
> java.lang.AbstractStringBuilder.append(AbstractStringBuilder.java:566)
> at java.lang.StringBuffer.append(StringBuffer.java:357)
> at
> org.apache.log4j.helpers.ISO8601DateFormat.format(ISO8601DateFormat.java:134)
> at java.text.DateFormat.format(DateFormat.java:345)
> at
> org.apache.log4j.helpers.PatternParser$DatePatternConverter.convert(PatternParser.java:443)
> at
> org.apache.log4j.helpers.PatternConverter.format(PatternConverter.java:65)
> at org.apache.log4j.PatternLayout.format(PatternLayout.java:506)
> at org.apache.log4j.WriterAppender.subAppend(WriterAppender.java:310)
> at
> org.apache.log4j.RollingFileAppender.subAppend(RollingFileAppender.java:276)
> at org.apache.log4j.WriterAppender.append(WriterAppender.java:162)
> at
> org.apache.log4j.AppenderSkeleton.doAppend(AppenderSkeleton.java:251)
> at
> org.apache.log4j.helpers.AppenderAttachableImpl.appendLoopOnAppenders(AppenderAttachableImpl.java:66)
> at org.apache.log4j.Category.callAppenders(Category.java:206)
> at org.apache.log4j.Category.forcedLog(Category.java:391)
> at org.apache.log4j.Category.log(Category.java:856)
> at org.slf4j.impl.Log4jLoggerAdapter.info(Log4jLoggerAdapter.java:304)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.getStrategy(RegionGroupingProvider.java:105)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.init(RegionGroupingProvider.java:160)
> at
> org.apache.hadoop.hbase.wal.WALFactory.createProvider(WALFactory.java:161)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.createProvider(RegionGroupingProvider.java:166)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.getWAL(RegionGroupingProvider.java:184)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.getWAL(RegionGroupingProvider.java:212)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.getWAL(RegionGroupingProvider.java:192)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.getWAL(RegionGroupingProvider.java:212)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.getWAL(RegionGroupingProvider.java:192)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.getWAL(RegionGroupingProvider.java:212)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.getWAL(RegionGroupingProvider.java:192)
> at
> org.apache.hadoop.hbase.wal.RegionGroupingProvider.getWAL(RegionGroupingProvider.java:212)
> ..
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache9 merged pull request #1338: HBASE-24040 WALFactory.Providers.multiwal causes StackOverflowError
Apache9 merged pull request #1338: HBASE-24040 WALFactory.Providers.multiwal causes StackOverflowError URL: https://github.com/apache/hbase/pull/1338 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] shenshengli opened a new pull request #1369: HBASE-24054
shenshengli opened a new pull request #1369: HBASE-24054 URL: https://github.com/apache/hbase/pull/1369 To be safe, jetty's version number should be blocked. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1364: HBASE-24065 Enable SpotBugs in PreCommit
Apache-HBase commented on issue #1364: HBASE-24065 Enable SpotBugs in PreCommit URL: https://github.com/apache/hbase/pull/1364#issuecomment-604775889 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 24s | master passed | | +1 :green_heart: | compile | 0m 59s | master passed | | +1 :green_heart: | shadedjars | 5m 3s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | master passed | | +1 :green_heart: | spotbugs | 2m 36s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 26s | the patch passed | | +1 :green_heart: | compile | 0m 58s | the patch passed | | +1 :green_heart: | javac | 0m 58s | the patch passed | | +1 :green_heart: | shadedjars | 5m 2s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 41s | the patch passed | | +1 :green_heart: | spotbugs | 2m 44s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 113m 32s | hbase-server in the patch failed. | | | | 146m 1s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1364/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1364 | | Optional Tests | javac javadoc unit spotbugs shadedjars compile | | uname | Linux 0fb3d5e9e882 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 78eecd3a7d | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1364/4/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1364/4/testReport/ | | Max. process+thread count | 5200 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1364/4/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-24063) Make branch-2.1 EOM
[ https://issues.apache.org/jira/browse/HBASE-24063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24063: -- Fix Version/s: (was: 2.1.10) > Make branch-2.1 EOM > --- > > Key: HBASE-24063 > URL: https://issues.apache.org/jira/browse/HBASE-24063 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23827) [HBCK2] Add mergeRegions method to hbck service
[ https://issues.apache.org/jira/browse/HBASE-23827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-23827: -- Fix Version/s: (was: 2.1.10) > [HBCK2] Add mergeRegions method to hbck service > --- > > Key: HBASE-23827 > URL: https://issues.apache.org/jira/browse/HBASE-23827 > Project: HBase > Issue Type: Task >Reporter: Sakthi >Assignee: Sakthi >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.5 > > > Let's add the mergeRegions method to the hbck service so that hbck2 can use > it from the client side. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1364: HBASE-24065 Enable SpotBugs in PreCommit
Apache-HBase commented on issue #1364: HBASE-24065 Enable SpotBugs in PreCommit URL: https://github.com/apache/hbase/pull/1364#issuecomment-604775547 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 45s | master passed | | +1 :green_heart: | compile | 1m 10s | master passed | | +1 :green_heart: | shadedjars | 6m 1s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 39s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 28s | the patch passed | | +1 :green_heart: | compile | 1m 13s | the patch passed | | +1 :green_heart: | javac | 1m 13s | the patch passed | | +1 :green_heart: | shadedjars | 6m 5s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 44s | hbase-server in the patch failed. | ||| _ Other Tests _ | | -0 :warning: | unit | 112m 38s | hbase-server in the patch failed. | | | | 144m 24s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1364/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1364 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 9e14f38b21ea 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 78eecd3a7d | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1364/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1364/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1364/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1364/4/testReport/ | | Max. process+thread count | 5529 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1364/4/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-24009) Backport the personality changes in HBASE-23989 to all active branches
[ https://issues.apache.org/jira/browse/HBASE-24009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068198#comment-17068198 ] Duo Zhang commented on HBASE-24009: --- At least the nightly job will use the jenkins file on each branch and in the jenkins file we will also call the personality script. > Backport the personality changes in HBASE-23989 to all active branches > -- > > Key: HBASE-24009 > URL: https://issues.apache.org/jira/browse/HBASE-24009 > Project: HBase > Issue Type: Sub-task > Components: build >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 2.3.0, 1.3.7, 1.7.0, 2.1.10, 1.4.14, 2.2.5 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache9 commented on a change in pull request #1364: HBASE-24065 Enable SpotBugs in PreCommit
Apache9 commented on a change in pull request #1364: HBASE-24065 Enable
SpotBugs in PreCommit
URL: https://github.com/apache/hbase/pull/1364#discussion_r398989248
##
File path: dev-support/Jenkinsfile_GitHub
##
@@ -156,11 +161,16 @@ pipeline {
}
}
environment {
+
// customized per parallel stage
-PLUGINS = "${JDK_SPECIFIC_PLUGINS}"
+//
+// run SpotBugs only once, and run it on JDK8.
+PLUGINS = "${JDK_SPECIFIC_PLUGINS},spotbugs"
Review comment:
The -fingbugs is from the release note of yetus, as the official way to
enable spotbugs.
https://issues.apache.org/jira/browse/YETUS-749
Of course I haven't checked the code of yetus so maybe specify spotbugs also
works.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Updated] (HBASE-24054) The Jetty's version number leak occurred while using the thrift service
[ https://issues.apache.org/jira/browse/HBASE-24054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shenshengli updated HBASE-24054: Issue Type: Improvement (was: Bug) > The Jetty's version number leak occurred while using the thrift service > --- > > Key: HBASE-24054 > URL: https://issues.apache.org/jira/browse/HBASE-24054 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.1 >Reporter: shenshengli >Priority: Minor > > When the port is checked with curl -I host:port, the version number of jetty > is displayed. > To be safe, jetty's version number should be blocked. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1367: Backport: HBASE-23853 [Flakey Test] TestBlockEvictionFromClient#testBlockRefCou…
Apache-HBase commented on issue #1367: Backport: HBASE-23853 [Flakey Test] TestBlockEvictionFromClient#testBlockRefCou… URL: https://github.com/apache/hbase/pull/1367#issuecomment-604755229 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 36s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.3 Compile Tests _ | | +1 :green_heart: | mvninstall | 8m 0s | branch-2.3 passed | | +1 :green_heart: | compile | 1m 12s | branch-2.3 passed | | +1 :green_heart: | shadedjars | 5m 58s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 42s | hbase-server in branch-2.3 failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 53s | the patch passed | | +1 :green_heart: | compile | 1m 11s | the patch passed | | +1 :green_heart: | javac | 1m 11s | the patch passed | | +1 :green_heart: | shadedjars | 5m 48s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 40s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 103m 34s | hbase-server in the patch passed. | | | | 137m 29s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1367/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1367 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 978bdd8844fe 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.3 / 00c8ccd70f | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1367/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1367/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1367/1/testReport/ | | Max. process+thread count | 4102 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1367/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-24000) Simplify CommonFSUtils after upgrading to hadoop 2.10.0
[
https://issues.apache.org/jira/browse/HBASE-24000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068158#comment-17068158
]
Hudson commented on HBASE-24000:
Results for branch branch-2
[build #2568 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2568/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2568//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2568//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2568//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2568//JDK11_Nightly_Build_Report/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2568//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Simplify CommonFSUtils after upgrading to hadoop 2.10.0
> ---
>
> Key: HBASE-24000
> URL: https://issues.apache.org/jira/browse/HBASE-24000
> Project: HBase
> Issue Type: Improvement
> Components: hadoop2, wal
>Affects Versions: 3.0.0, 2.3.0, 2.4.0
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> As now the builder is always presented, we do not need to use reflection for
> most of methods any more.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24052) Add debug to TestMasterShutdown
[
https://issues.apache.org/jira/browse/HBASE-24052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068156#comment-17068156
]
Hudson commented on HBASE-24052:
Results for branch branch-2
[build #2568 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2568/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2568//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2568//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2568//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2568//JDK11_Nightly_Build_Report/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2568//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Add debug to TestMasterShutdown
> ---
>
> Key: HBASE-24052
> URL: https://issues.apache.org/jira/browse/HBASE-24052
> Project: HBase
> Issue Type: Sub-task
>Reporter: Michael Stack
>Priority: Trivial
> Attachments:
> 0001-HBASE-24052-Add-debug-to-TestMasterShutdown.addendum.patch,
> 0001-HBASE-24052-Add-debug-to-TestMasterShutdown.addendum2.patch,
> 0001-HBASE-24052-Add-debug-to-TestMasterShutdown.patch
>
>
> Temporarily add debug to TestMasterShutdown overnight to learn more about a
> test failure not reproducible locally.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-22555) Re-enable TestMasterOperationsForRegionReplicas$testIncompleteMetaTableReplicaInformation
[
https://issues.apache.org/jira/browse/HBASE-22555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068157#comment-17068157
]
Hudson commented on HBASE-22555:
Results for branch branch-2
[build #2568 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2568/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2568//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2568//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2568//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2568//JDK11_Nightly_Build_Report/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2568//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Re-enable
> TestMasterOperationsForRegionReplicas$testIncompleteMetaTableReplicaInformation
> -
>
> Key: HBASE-22555
> URL: https://issues.apache.org/jira/browse/HBASE-22555
> Project: HBase
> Issue Type: Bug
> Components: Replication, test
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.4.0
>
>
> The test is ignored until HBASE-10361 is ready which already happened.
> Simply removing @Ignore does not work, the test needs some modification to
> pass.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23853) [Flakey Test] TestBlockEvictionFromClient#testBlockRefCountAfterSplits
[ https://issues.apache.org/jira/browse/HBASE-23853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068153#comment-17068153 ] Huaxiang Sun commented on HBASE-23853: -- Patch committed to master/branch-2/branch-2.3. > [Flakey Test] TestBlockEvictionFromClient#testBlockRefCountAfterSplits > -- > > Key: HBASE-23853 > URL: https://issues.apache.org/jira/browse/HBASE-23853 > Project: HBase > Issue Type: Bug > Components: flakies >Affects Versions: 2.3.0, master, 2.4.0 >Reporter: Michael Stack >Assignee: Hua Xiang >Priority: Major > Fix For: 3.0.0, 2.3.0 > > Attachments: > 0001-HBASE-23853-Flakey-Test-TestBlockEvictionFromClient-.patch, Screen Shot > 2020-02-15 at 2.36.47 PM.png > > > Fails 12-25% of the time in the GCE build. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23853) [Flakey Test] TestBlockEvictionFromClient#testBlockRefCountAfterSplits
[ https://issues.apache.org/jira/browse/HBASE-23853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun updated HBASE-23853: - Affects Version/s: 2.4.0 master 2.3.0 > [Flakey Test] TestBlockEvictionFromClient#testBlockRefCountAfterSplits > -- > > Key: HBASE-23853 > URL: https://issues.apache.org/jira/browse/HBASE-23853 > Project: HBase > Issue Type: Bug > Components: flakies >Affects Versions: 2.3.0, master, 2.4.0 >Reporter: Michael Stack >Assignee: Hua Xiang >Priority: Major > Fix For: 3.0.0, 2.3.0 > > Attachments: > 0001-HBASE-23853-Flakey-Test-TestBlockEvictionFromClient-.patch, Screen Shot > 2020-02-15 at 2.36.47 PM.png > > > Fails 12-25% of the time in the GCE build. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HBASE-23957) [flakey test] client.TestMultiParallel fails to read hbase-site.xml
[
https://issues.apache.org/jira/browse/HBASE-23957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Huaxiang Sun reassigned HBASE-23957:
Assignee: Hua Xiang
> [flakey test] client.TestMultiParallel fails to read hbase-site.xml
> ---
>
> Key: HBASE-23957
> URL: https://issues.apache.org/jira/browse/HBASE-23957
> Project: HBase
> Issue Type: Test
> Components: test
>Affects Versions: 2.3.0, master, 1.4.13, 2.2.4
>Reporter: Nick Dimiduk
>Assignee: Hua Xiang
>Priority: Minor
>
> Saw this on a [PreCommit
> run|https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1258/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt].
> Log file says
> {noformat}
> 2020-03-09 22:48:26,295 FATAL [Time-limited test] conf.Configuration(2853):
> error parsing conf hbase-site.xml
> java.io.FileNotFoundException:
> /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1258@2/yetus-jdk8-hadoop2-check/src/hbase-server/target/test-classes/hbase-site.xml
> (No such file or directory)
> at java.io.FileInputStream.open0(Native Method)
> at java.io.FileInputStream.open(FileInputStream.java:195)
> at java.io.FileInputStream.(FileInputStream.java:138)
> at java.io.FileInputStream.(FileInputStream.java:93)
> at
> sun.net.www.protocol.file.FileURLConnection.connect(FileURLConnection.java:90)
> at
> sun.net.www.protocol.file.FileURLConnection.getInputStream(FileURLConnection.java:188)
> at org.apache.hadoop.conf.Configuration.parse(Configuration.java:2672)
> at
> org.apache.hadoop.conf.Configuration.loadResource(Configuration.java:2746)
> at
> org.apache.hadoop.conf.Configuration.loadResources(Configuration.java:2706)
> at
> org.apache.hadoop.conf.Configuration.getProps(Configuration.java:2579)
> at org.apache.hadoop.conf.Configuration.get(Configuration.java:1091)
> at
> org.apache.hadoop.conf.Configuration.getTrimmed(Configuration.java:1145)
> at
> org.apache.hadoop.conf.Configuration.getClass(Configuration.java:2363)
> at
> org.apache.hadoop.fs.FileSystem.getFileSystemClass(FileSystem.java:2793)
> at
> org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2810)
> at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:100)
> at
> org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:2849)
> at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:2831)
> at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:389)
> at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:181)
> at org.apache.hadoop.hbase.fs.HFileSystem.(HFileSystem.java:85)
> at org.apache.hadoop.hbase.fs.HFileSystem.get(HFileSystem.java:465)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.getTestFileSystem(HBaseTestingUtility.java:3180)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.getNewDataTestDirOnTestFS(HBaseTestingUtility.java:507)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.setupDataTestDirOnTestFS(HBaseTestingUtility.java:496)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.getDataTestDirOnTestFS(HBaseTestingUtility.java:469)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.getDataTestDirOnTestFS(HBaseTestingUtility.java:483)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.createDirsAndSetProperties(HBaseTestingUtility.java:651)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.startMiniDFSCluster(HBaseTestingUtility.java:603)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.startMiniDFSCluster(HBaseTestingUtility.java:586)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:1039)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:1004)
> at
> org.apache.hadoop.hbase.client.TestMultiParallel.beforeClass(TestMultiParallel.java:96)
> {noformat}
> This stage ran on H9.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] huaxiangsun merged pull request #1367: Backport: HBASE-23853 [Flakey Test] TestBlockEvictionFromClient#testBlockRefCou…
huaxiangsun merged pull request #1367: Backport: HBASE-23853 [Flakey Test] TestBlockEvictionFromClient#testBlockRefCou… URL: https://github.com/apache/hbase/pull/1367 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] huaxiangsun merged pull request #1366: Backport: HBASE-23853 [Flakey Test] TestBlockEvictionFromClient#testBlockRefCou…
huaxiangsun merged pull request #1366: Backport: HBASE-23853 [Flakey Test] TestBlockEvictionFromClient#testBlockRefCou… URL: https://github.com/apache/hbase/pull/1366 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-24041) [regression] Increase RESTServer buffer size back to 64k
[
https://issues.apache.org/jira/browse/HBASE-24041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068152#comment-17068152
]
Hudson commented on HBASE-24041:
Results for branch branch-2.2
[build #826 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/826/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/826//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/826//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/826//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [regression] Increase RESTServer buffer size back to 64k
> -
>
> Key: HBASE-24041
> URL: https://issues.apache.org/jira/browse/HBASE-24041
> Project: HBase
> Issue Type: Bug
> Components: REST
>Affects Versions: 3.0.0, 2.2.0, 2.3.0, 2.4.0
>Reporter: Esteban Gutierrez
>Priority: Major
>
> HBASE-14492 is not longer present in our current releases after HBASE-12894.
> Unfortunately our RESTServer is not extending HttpServer which means that
> {{DEFAULT_MAX_HEADER_SIZE}} is not being set and HTTP requests with a very
> large header can still cause connection issues for clients. A quick fix is
> just to add the settings to the {{HttpConfiguration}} configuration object. A
> long term solution should be to re-factor services that create an HTTP server
> and normalize all configuration settings across all of them.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] huaxiangsun commented on issue #1367: Backport: HBASE-23853 [Flakey Test] TestBlockEvictionFromClient#testBlockRefCou…
huaxiangsun commented on issue #1367: Backport: HBASE-23853 [Flakey Test]
TestBlockEvictionFromClient#testBlockRefCou…
URL: https://github.com/apache/hbase/pull/1367#issuecomment-604751990
Unittest error complains about
{code}
server/target/surefire-reports/TEST-org.apache.hadoop.hbase.client.replication.TestReplicationAdminWithClusters.xml
org.dom4j.DocumentException: Error on line 96 of document : XML document
structures must start and end within the same entity. Nested exception: XML
document structures must start and end within the same entity.
{code}
Test infra issue.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1364: HBASE-24065 Enable SpotBugs in PreCommit
Apache-HBase commented on issue #1364: HBASE-24065 Enable SpotBugs in PreCommit URL: https://github.com/apache/hbase/pull/1364#issuecomment-604750384 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 50s | master passed | | +1 :green_heart: | checkstyle | 1m 17s | master passed | | +0 :ok: | spotbugs | 2m 16s | Both FindBugs and SpotBugs are enabled, using SpotBugs. | | +1 :green_heart: | spotbugs | 2m 13s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 52s | the patch passed | | +1 :green_heart: | checkstyle | 1m 16s | the patch passed | | +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 55s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 2m 20s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 11s | The patch does not generate ASF License warnings. | | | | 38m 44s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1364/4/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1364 | | Optional Tests | dupname asflicense shellcheck shelldocs spotbugs findbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 36dabb358b26 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 78eecd3a7d | | Max. process+thread count | 83 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1364/4/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) shellcheck=0.4.6 spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1366: Backport: HBASE-23853 [Flakey Test] TestBlockEvictionFromClient#testBlockRefCou…
Apache-HBase commented on issue #1366: Backport: HBASE-23853 [Flakey Test] TestBlockEvictionFromClient#testBlockRefCou… URL: https://github.com/apache/hbase/pull/1366#issuecomment-604749656 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 26s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 7m 47s | branch-2 passed | | +1 :green_heart: | compile | 0m 59s | branch-2 passed | | +1 :green_heart: | shadedjars | 5m 2s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 55s | the patch passed | | +1 :green_heart: | compile | 0m 59s | the patch passed | | +1 :green_heart: | javac | 0m 59s | the patch passed | | +1 :green_heart: | shadedjars | 4m 56s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 35s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 103m 14s | hbase-server in the patch passed. | | | | 135m 39s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1366/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1366 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 12f16b688f03 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / a18f5b1517 | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1366/1/testReport/ | | Max. process+thread count | 3742 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1366/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ndimiduk commented on issue #1364: HBASE-24065 Enable SpotBugs in PreCommit
ndimiduk commented on issue #1364: HBASE-24065 Enable SpotBugs in PreCommit URL: https://github.com/apache/hbase/pull/1364#issuecomment-604744795 that worked! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1368: HBASE-24049 use hadoop-2.10.0 for "packaging and integration" check
Apache-HBase commented on issue #1368: HBASE-24049 use hadoop-2.10.0 for "packaging and integration" check URL: https://github.com/apache/hbase/pull/1368#issuecomment-604743380 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 16s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 33s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for patch | ||| _ Other Tests _ | | | | 2m 51s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1368/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1368 | | Optional Tests | | | uname | Linux aeed3f4ca11c 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 78eecd3a7d | | Max. process+thread count | 57 (vs. ulimit of 1) | | modules | C: U: | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1368/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1368: HBASE-24049 use hadoop-2.10.0 for "packaging and integration" check
Apache-HBase commented on issue #1368: HBASE-24049 use hadoop-2.10.0 for "packaging and integration" check URL: https://github.com/apache/hbase/pull/1368#issuecomment-604743235 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 36s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch | | +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | ||| _ Other Tests _ | | +0 :ok: | asflicense | 0m 1s | ASF License check generated no output? | | | | 2m 21s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1368/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1368 | | Optional Tests | dupname asflicense shellcheck shelldocs | | uname | Linux 0f2c71021e73 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 78eecd3a7d | | Max. process+thread count | 50 (vs. ulimit of 1) | | modules | C: U: | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1368/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) shellcheck=0.4.6 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1367: Backport: HBASE-23853 [Flakey Test] TestBlockEvictionFromClient#testBlockRefCou…
Apache-HBase commented on issue #1367: Backport: HBASE-23853 [Flakey Test] TestBlockEvictionFromClient#testBlockRefCou… URL: https://github.com/apache/hbase/pull/1367#issuecomment-604743186 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.3 Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 35s | branch-2.3 passed | | +1 :green_heart: | compile | 0m 56s | branch-2.3 passed | | +1 :green_heart: | shadedjars | 4m 35s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | branch-2.3 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 18s | the patch passed | | +1 :green_heart: | compile | 0m 58s | the patch passed | | +1 :green_heart: | javac | 0m 58s | the patch passed | | +1 :green_heart: | shadedjars | 4m 28s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 35s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 66m 43s | hbase-server in the patch failed. | | | | 92m 51s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1367/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1367 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 996f5affe493 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.3 / 00c8ccd70f | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1367/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1367/1/testReport/ | | Max. process+thread count | (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1367/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1368: HBASE-24049 use hadoop-2.10.0 for "packaging and integration" check
Apache-HBase commented on issue #1368: HBASE-24049 use hadoop-2.10.0 for "packaging and integration" check URL: https://github.com/apache/hbase/pull/1368#issuecomment-604743422 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 28s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 33s | Maven dependency ordering for branch | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for patch | ||| _ Other Tests _ | | | | 3m 4s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1368/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1368 | | Optional Tests | | | uname | Linux c6a7e0fd13dd 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 78eecd3a7d | | Max. process+thread count | 47 (vs. ulimit of 1) | | modules | C: U: | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1368/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ndimiduk commented on issue #1368: HBASE-24049 use hadoop-2.10.0 for "packaging and integration" check
ndimiduk commented on issue #1368: HBASE-24049 use hadoop-2.10.0 for "packaging and integration" check URL: https://github.com/apache/hbase/pull/1368#issuecomment-604741239 We only run this check on nightly, so pushed a feature branch, https://builds.apache.org/job/HBase%20Nightly/job/HBASE-24049-packaging-integration-hadoop-2.10.0/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ndimiduk opened a new pull request #1368: HBASE-24049 use hadoop-2.10.0 for "packaging and integration" check
ndimiduk opened a new pull request #1368: HBASE-24049 use hadoop-2.10.0 for "packaging and integration" check URL: https://github.com/apache/hbase/pull/1368 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work started] (HBASE-24049) "Packaging and Integration" check fails
[
https://issues.apache.org/jira/browse/HBASE-24049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-24049 started by Nick Dimiduk.
> "Packaging and Integration" check fails
> ---
>
> Key: HBASE-24049
> URL: https://issues.apache.org/jira/browse/HBASE-24049
> Project: HBase
> Issue Type: Bug
> Components: build
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
>
> Looks like this is running with Hadoop 2.8.5, despite HBASE-23986
> {noformat}
> [2020-03-24T09:14:00.930Z] ++ ls -1
> /home/jenkins/jenkins-slave/workspace/HBase_Nightly_master/hadoop-2.8.5-bin.tar.gz
> [2020-03-24T09:14:00.930Z] ++ head -n 1
> [2020-03-24T09:14:00.930Z] +
> artifact=/home/jenkins/jenkins-slave/workspace/HBase_Nightly_master/hadoop-2.8.5-bin.tar.gz
> [2020-03-24T09:14:00.930Z] + tar --strip-components=1 -xzf
> /home/jenkins/jenkins-slave/workspace/HBase_Nightly_master/hadoop-2.8.5-bin.tar.gz
> -C hadoop-2
> [2020-03-24T09:14:06.186Z] +
> /home/jenkins/jenkins-slave/workspace/HBase_Nightly_master/component/dev-support/hbase_nightly_pseudo-distributed-test.sh
> --single-process --working-dir output-integration/hadoop-2
> --hbase-client-install hbase-client hbase-install hadoop-2/bin/hadoop
> hadoop-2/share/hadoop/yarn/test/hadoop-yarn-server-tests-2.8.5-tests.jar
> hadoop-2/share/hadoop/mapreduce/hadoop-mapreduce-client-jobclient-2.8.5-tests.jar
> hadoop-2/bin/mapred
> [2020-03-24T17:50:28.859Z] Sending interrupt signal to process
> [2020-03-24T17:50:30.005Z] Sending interrupt signal to process
> [2020-03-24T17:50:42.558Z] + echo '(x) {color:red}-1 client integration
> test{color}
> [2020-03-24T17:50:42.558Z] --Failed when running client tests on top of
> Hadoop 2. [see log for
> details|https://builds.apache.org/job/HBase%20Nightly/job/master/1677//artifact/output-integration/hadoop-2.log].
> (note that this means we didn'\''t run on Hadoop 3)'
> [2020-03-24T17:50:42.558Z] + exit 2
> [2020-03-24T17:50:42.866Z] script returned exit code 2
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (HBASE-24049) "Packaging and Integration" check fails
[
https://issues.apache.org/jira/browse/HBASE-24049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk reassigned HBASE-24049:
Assignee: Nick Dimiduk
> "Packaging and Integration" check fails
> ---
>
> Key: HBASE-24049
> URL: https://issues.apache.org/jira/browse/HBASE-24049
> Project: HBase
> Issue Type: Bug
> Components: build
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
>
> Looks like this is running with Hadoop 2.8.5, despite HBASE-23986
> {noformat}
> [2020-03-24T09:14:00.930Z] ++ ls -1
> /home/jenkins/jenkins-slave/workspace/HBase_Nightly_master/hadoop-2.8.5-bin.tar.gz
> [2020-03-24T09:14:00.930Z] ++ head -n 1
> [2020-03-24T09:14:00.930Z] +
> artifact=/home/jenkins/jenkins-slave/workspace/HBase_Nightly_master/hadoop-2.8.5-bin.tar.gz
> [2020-03-24T09:14:00.930Z] + tar --strip-components=1 -xzf
> /home/jenkins/jenkins-slave/workspace/HBase_Nightly_master/hadoop-2.8.5-bin.tar.gz
> -C hadoop-2
> [2020-03-24T09:14:06.186Z] +
> /home/jenkins/jenkins-slave/workspace/HBase_Nightly_master/component/dev-support/hbase_nightly_pseudo-distributed-test.sh
> --single-process --working-dir output-integration/hadoop-2
> --hbase-client-install hbase-client hbase-install hadoop-2/bin/hadoop
> hadoop-2/share/hadoop/yarn/test/hadoop-yarn-server-tests-2.8.5-tests.jar
> hadoop-2/share/hadoop/mapreduce/hadoop-mapreduce-client-jobclient-2.8.5-tests.jar
> hadoop-2/bin/mapred
> [2020-03-24T17:50:28.859Z] Sending interrupt signal to process
> [2020-03-24T17:50:30.005Z] Sending interrupt signal to process
> [2020-03-24T17:50:42.558Z] + echo '(x) {color:red}-1 client integration
> test{color}
> [2020-03-24T17:50:42.558Z] --Failed when running client tests on top of
> Hadoop 2. [see log for
> details|https://builds.apache.org/job/HBase%20Nightly/job/master/1677//artifact/output-integration/hadoop-2.log].
> (note that this means we didn'\''t run on Hadoop 3)'
> [2020-03-24T17:50:42.558Z] + exit 2
> [2020-03-24T17:50:42.866Z] script returned exit code 2
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1366: Backport: HBASE-23853 [Flakey Test] TestBlockEvictionFromClient#testBlockRefCou…
Apache-HBase commented on issue #1366: Backport: HBASE-23853 [Flakey Test] TestBlockEvictionFromClient#testBlockRefCou… URL: https://github.com/apache/hbase/pull/1366#issuecomment-604738714 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 28s | branch-2 passed | | +1 :green_heart: | compile | 1m 6s | branch-2 passed | | +1 :green_heart: | shadedjars | 5m 18s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 41s | hbase-server in branch-2 failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 10s | the patch passed | | +1 :green_heart: | compile | 1m 6s | the patch passed | | +1 :green_heart: | javac | 1m 6s | the patch passed | | +1 :green_heart: | shadedjars | 5m 11s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 39s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 65m 12s | hbase-server in the patch passed. | | | | 94m 46s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1366/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1366 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 9007a64450e6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / a18f5b1517 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1366/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1366/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1366/1/testReport/ | | Max. process+thread count | 6402 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1366/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ndimiduk commented on issue #1364: HBASE-24065 Enable SpotBugs in PreCommit
ndimiduk commented on issue #1364: HBASE-24065 Enable SpotBugs in PreCommit
URL: https://github.com/apache/hbase/pull/1364#issuecomment-604737816
Oh, unless spotbugs only runs when a java file is modified...
```sh
function spotbugs_filefilter
{
declare filename=$1
if [[ ${BUILDTOOL} == maven
|| ${BUILDTOOL} == ant ]]; then
if [[ ${filename} =~ \.java$
|| ${filename} =~ (^|/)${SPOTBUGS_MODE}-exclude.xml$ ]]; then
add_test "${SPOTBUGS_MODE}"
fi
fi
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on issue #1364: HBASE-24065 Enable SpotBugs in PreCommit
ndimiduk commented on issue #1364: HBASE-24065 Enable SpotBugs in PreCommit URL: https://github.com/apache/hbase/pull/1364#issuecomment-604735186 > Is it just me or has the spotbugs disappeared from the build report? That's what I'm trying to enable here. I think the functionality was dropped in HBASE-23077 or HBASE-23767. > The way I read https://issues.apache.org/jira/browse/YETUS-749 ... Ah thanks, I hadn't read the Yetus side of the feature change. I believe that when `SPOTBUGS_HOME` is defined, as we do in our Dockerfile, `-findbugs` is not necessary since t that's the default mode. I'm currently thinking there's a plugin dependency for spotbugs that I'm missing because of the explicit omission of `all` in the JDK-specific plugin lists. But I cannot find it. On this PR, for JDK8, I specify `--plugins=compile,github,htmlout,javac,javadoc,maven,mvninstall,shadedjars,unit,spotbugs`. When I run yetus locally using an even reduced list, `--plugins=compile,javac,javadoc,mav en,mvninstall,spotbugs`, I get the SpotBugs check as expected. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23881) TestShadeSaslAuthenticationProvider failures
[
https://issues.apache.org/jira/browse/HBASE-23881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068127#comment-17068127
]
Josh Elser commented on HBASE-23881:
HBASE-24047 _might_ be related to some of the changes done here. I pushed to
2.3 originally without sufficient testing, it seems.
> TestShadeSaslAuthenticationProvider failures
>
>
> Key: HBASE-23881
> URL: https://issues.apache.org/jira/browse/HBASE-23881
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Bharath Vissapragada
>Assignee: Josh Elser
>Priority: Major
> Fix For: 3.0.0
>
>
> TestShadeSaslAuthenticationProvider now fails deterministically with the
> following exception..
> {noformat}
> java.lang.Exception: Unexpected exception,
> expected but
> was
> at
> org.apache.hadoop.hbase.security.provider.example.TestShadeSaslAuthenticationProvider.testNegativeAuthentication(TestShadeSaslAuthenticationProvider.java:233)
> {noformat}
> The test now fails a different place than before merging HBASE-18095 because
> the RPCs are also a part of connection setup. We might need to rewrite the
> test..
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23881) TestShadeSaslAuthenticationProvider failures
[
https://issues.apache.org/jira/browse/HBASE-23881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068125#comment-17068125
]
Josh Elser commented on HBASE-23881:
{quote}Oh sorry. Thought this another issue. Still excellent digging though.
{quote}
Haha, worry not -- HBASE-24047 is also on my radar. Let me link these now.
> TestShadeSaslAuthenticationProvider failures
>
>
> Key: HBASE-23881
> URL: https://issues.apache.org/jira/browse/HBASE-23881
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Bharath Vissapragada
>Assignee: Josh Elser
>Priority: Major
> Fix For: 3.0.0
>
>
> TestShadeSaslAuthenticationProvider now fails deterministically with the
> following exception..
> {noformat}
> java.lang.Exception: Unexpected exception,
> expected but
> was
> at
> org.apache.hadoop.hbase.security.provider.example.TestShadeSaslAuthenticationProvider.testNegativeAuthentication(TestShadeSaslAuthenticationProvider.java:233)
> {noformat}
> The test now fails a different place than before merging HBASE-18095 because
> the RPCs are also a part of connection setup. We might need to rewrite the
> test..
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24066) Expose shaded clients through WebUI as Maven repository
[
https://issues.apache.org/jira/browse/HBASE-24066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068122#comment-17068122
]
Josh Elser commented on HBASE-24066:
{quote} it strikes me as something that makes HBase less stable in production,
not more
{quote}
It certainly has no chance of making HBase more stable, no. However, I don't
see a very big risk of a user (or collection of users) DDOS'ing the Master (as
opposed to a RegionServer) being a large risk to stability. Point taken,
nonetheless.
{quote}What's wrong with the {{bin/hbase}} script
{quote}
Users of HBase do not always exist on the cluster where HBase is running. This
is not for people who can access the cluster nodes directly because, as you
indicate, they already have a full-fledged classpath/environment set up for
them to use. I see this coming up more and more often where groups running
HBase don't _want_ users to be on the system directly for fear of doing things
on the same hardware that could impact shared services. For example, if you
want to write some application that reads/writes to HBase, we'll launch some
new hosts/containers where you are allowed to "go to town" without fear of
locking up that same node.
{quote}Why would be burden production hosts with artifact distribution? Why
would we encourage deployments where the production hosts are on the same
networks as developers? There are plenty of other means of distributing
artifacts available to an organization, means that do not couple development to
production, that are managed directly by IT and IT's policies.
{quote}
I agree with you that this isn't what we would call a "production ready"
solution in that it wouldn't effectively scale to 100's of users at a large
corporation. It started off as a "thought experiment", but I ended up really
liking how it felt as a user.
{quote}Do we not distribute these artifacts via our tarballs? Wouldn't they be
installed on any host via "normal" means?
{quote}
We have the "client" tarball which can localize a full client environment (sans
getting proper hbase configuration, but this also does nothing to solve that
problem; moving past that). This is essentially giving you that "{{bin/hbase}}
feel" from wherever you're coming from. As "HBase the project", we don't do a
good job of encouraging users to actually use this client tarball. I like the
client tarball, but how do we prescribe users to actually use that thing? I
think we've all struggled to evangelize the client tarball (we barely
acknowledge it IMO, but that's also on me having written part of it).
The idea of this change is to try to provide something which is easier for a
user to consume without dictating how they bundle/package their applications.
If they can build an application to an API and then dynamically get the
implementation of that API at runtime from the system they're about to talk to,
that sounds to me like a win. e.g. say IT notices that there's a critical HBase
bug and they upgrade HBase to patch that issue. Clients which dynamically
pulled the newest client jar would just pick up the fix. I've seen many, many
times where users will take a copy of a client jar exactly once, put it in
their application, and expect to use that jar until the day they die. This also
encourages us to take advantage of our better API stability that we've been
driving in 2.x.
To try to drive it home: I will agree with you that serving a large binary blob
out of a Java process is a smell and isn't something that will work for edge
cases. However, I do think this is improving part of our population's lives. I
appreciate you taking the time to quickly write back and I will respect your
opinion if I've not swayed it at all. I was worried that I'd not given enough
context to show what I was seeing.
> Expose shaded clients through WebUI as Maven repository
> ---
>
> Key: HBASE-24066
> URL: https://issues.apache.org/jira/browse/HBASE-24066
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Minor
>
> Props to [~busbey] for this idea.
> We have a number of shaded jars which are (largely) sufficient for launching
> any Java application against HBase. However, if users have multiple versions
> of HBase in their organization, it might be confusing to know "which client"
> do I need to use? Can we expose our shaded clients from HBase in such a way
> that build tools can just ask HBase for the client jars they should use?
> The idea here is that we can use embedded Jetty to "fake" out a Maven
> repository that users can put in their client applications. We have no extra
> burden from HBase because we already are packaging these jars. I'll link an
> example Maven
[jira] [Comment Edited] (HBASE-23881) TestShadeSaslAuthenticationProvider failures
[
https://issues.apache.org/jira/browse/HBASE-23881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068116#comment-17068116
]
Michael Stack edited comment on HBASE-23881 at 3/26/20, 10:50 PM:
--
Excellent. Thanks [~elserj] for taking a look
Oh sorry. Thought this another issue. Still excellent digging though.
was (Author: stack):
Excellent. Thanks [~elserj] for taking a look
> TestShadeSaslAuthenticationProvider failures
>
>
> Key: HBASE-23881
> URL: https://issues.apache.org/jira/browse/HBASE-23881
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Bharath Vissapragada
>Assignee: Josh Elser
>Priority: Major
> Fix For: 3.0.0
>
>
> TestShadeSaslAuthenticationProvider now fails deterministically with the
> following exception..
> {noformat}
> java.lang.Exception: Unexpected exception,
> expected but
> was
> at
> org.apache.hadoop.hbase.security.provider.example.TestShadeSaslAuthenticationProvider.testNegativeAuthentication(TestShadeSaslAuthenticationProvider.java:233)
> {noformat}
> The test now fails a different place than before merging HBASE-18095 because
> the RPCs are also a part of connection setup. We might need to rewrite the
> test..
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23881) TestShadeSaslAuthenticationProvider failures
[
https://issues.apache.org/jira/browse/HBASE-23881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068116#comment-17068116
]
Michael Stack commented on HBASE-23881:
---
Excellent. Thanks [~elserj] for taking a look
> TestShadeSaslAuthenticationProvider failures
>
>
> Key: HBASE-23881
> URL: https://issues.apache.org/jira/browse/HBASE-23881
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Bharath Vissapragada
>Assignee: Josh Elser
>Priority: Major
> Fix For: 3.0.0
>
>
> TestShadeSaslAuthenticationProvider now fails deterministically with the
> following exception..
> {noformat}
> java.lang.Exception: Unexpected exception,
> expected but
> was
> at
> org.apache.hadoop.hbase.security.provider.example.TestShadeSaslAuthenticationProvider.testNegativeAuthentication(TestShadeSaslAuthenticationProvider.java:233)
> {noformat}
> The test now fails a different place than before merging HBASE-18095 because
> the RPCs are also a part of connection setup. We might need to rewrite the
> test..
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1367: Backport: HBASE-23853 [Flakey Test] TestBlockEvictionFromClient#testBlockRefCou…
Apache-HBase commented on issue #1367: Backport: HBASE-23853 [Flakey Test] TestBlockEvictionFromClient#testBlockRefCou… URL: https://github.com/apache/hbase/pull/1367#issuecomment-604726949 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 18s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2.3 Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 15s | branch-2.3 passed | | +1 :green_heart: | checkstyle | 1m 18s | branch-2.3 passed | | +1 :green_heart: | spotbugs | 2m 9s | branch-2.3 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 45s | the patch passed | | +1 :green_heart: | checkstyle | 1m 15s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 51s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 2m 15s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 39m 43s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1367/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1367 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux a22c3a03fee8 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.3 / 00c8ccd70f | | Max. process+thread count | 83 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1367/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-24052) Add debug to TestMasterShutdown
[ https://issues.apache.org/jira/browse/HBASE-24052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068115#comment-17068115 ] Michael Stack commented on HBASE-24052: --- Dumbed down TestMasterShutdown and pushed it on branch-2. > Add debug to TestMasterShutdown > --- > > Key: HBASE-24052 > URL: https://issues.apache.org/jira/browse/HBASE-24052 > Project: HBase > Issue Type: Sub-task >Reporter: Michael Stack >Priority: Trivial > Attachments: > 0001-HBASE-24052-Add-debug-to-TestMasterShutdown.addendum.patch, > 0001-HBASE-24052-Add-debug-to-TestMasterShutdown.addendum2.patch, > 0001-HBASE-24052-Add-debug-to-TestMasterShutdown.patch > > > Temporarily add debug to TestMasterShutdown overnight to learn more about a > test failure not reproducible locally. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24052) Add debug to TestMasterShutdown
[ https://issues.apache.org/jira/browse/HBASE-24052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-24052: -- Attachment: 0001-HBASE-24052-Add-debug-to-TestMasterShutdown.addendum2.patch > Add debug to TestMasterShutdown > --- > > Key: HBASE-24052 > URL: https://issues.apache.org/jira/browse/HBASE-24052 > Project: HBase > Issue Type: Sub-task >Reporter: Michael Stack >Priority: Trivial > Attachments: > 0001-HBASE-24052-Add-debug-to-TestMasterShutdown.addendum.patch, > 0001-HBASE-24052-Add-debug-to-TestMasterShutdown.addendum2.patch, > 0001-HBASE-24052-Add-debug-to-TestMasterShutdown.patch > > > Temporarily add debug to TestMasterShutdown overnight to learn more about a > test failure not reproducible locally. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23881) TestShadeSaslAuthenticationProvider failures
[
https://issues.apache.org/jira/browse/HBASE-23881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068112#comment-17068112
]
Josh Elser commented on HBASE-23881:
Pushed this to master as that branch looks good. A bunch of spin-outs to come
from this... Thinking through them.
* Need backports of the Netty impl to the other 2.x branches which contain
HBASE-23347
* Need to make the same fix to the NIO impl to branches which contain
HBASE-23347
* Need to fix existing tests on those 2.x branches which likely fail due to
the new master registry logic
* Need to expand tests to cover async and sync connection impls on relevant
2.x branches
Theoretically, our code is "wrong" on all branches, but it will only exhibit
this error on branches where we have HBASE-23347. I don't think it's worth it
to proactively fix something we can't actually test/exercise.
> TestShadeSaslAuthenticationProvider failures
>
>
> Key: HBASE-23881
> URL: https://issues.apache.org/jira/browse/HBASE-23881
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Bharath Vissapragada
>Assignee: Josh Elser
>Priority: Major
> Fix For: 3.0.0
>
>
> TestShadeSaslAuthenticationProvider now fails deterministically with the
> following exception..
> {noformat}
> java.lang.Exception: Unexpected exception,
> expected but
> was
> at
> org.apache.hadoop.hbase.security.provider.example.TestShadeSaslAuthenticationProvider.testNegativeAuthentication(TestShadeSaslAuthenticationProvider.java:233)
> {noformat}
> The test now fails a different place than before merging HBASE-18095 because
> the RPCs are also a part of connection setup. We might need to rewrite the
> test..
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1365: HBASE-24066 Let HBase master UI act as a maven repo
Apache-HBase commented on issue #1365: HBASE-24066 Let HBase master UI act as a maven repo URL: https://github.com/apache/hbase/pull/1365#issuecomment-604723947 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.2 Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 10s | branch-2.2 passed | | +1 :green_heart: | compile | 0m 48s | branch-2.2 passed | | +1 :green_heart: | checkstyle | 0m 26s | branch-2.2 passed | | +1 :green_heart: | shadedjars | 4m 22s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 30s | branch-2.2 passed | | +0 :ok: | spotbugs | 0m 34s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +0 :ok: | findbugs | 0m 29s | branch/hbase-assembly no findbugs output file (findbugsXml.xml) | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 46s | the patch passed | | +1 :green_heart: | compile | 0m 48s | the patch passed | | +1 :green_heart: | javac | 0m 47s | the patch passed | | +1 :green_heart: | checkstyle | 0m 25s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | +1 :green_heart: | shadedjars | 4m 13s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 22m 24s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2. | | +1 :green_heart: | javadoc | 0m 32s | the patch passed | | +0 :ok: | findbugs | 0m 28s | hbase-assembly has no data from findbugs | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 3s | hbase-http in the patch passed. | | +1 :green_heart: | unit | 0m 27s | hbase-assembly in the patch passed. | | +1 :green_heart: | asflicense | 0m 24s | The patch does not generate ASF License warnings. | | | | 55m 54s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1365/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1365 | | Optional Tests | dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile spotbugs findbugs hbaseanti checkstyle | | uname | Linux eeddef3b1488 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1365/out/precommit/personality/provided.sh | | git revision | branch-2.2 / 1777513455 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1365/2/testReport/ | | Max. process+thread count | 283 (vs. ulimit of 1) | | modules | C: hbase-http hbase-assembly U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1365/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-23881) TestShadeSaslAuthenticationProvider failures
[
https://issues.apache.org/jira/browse/HBASE-23881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh Elser updated HBASE-23881:
---
Fix Version/s: 3.0.0
> TestShadeSaslAuthenticationProvider failures
>
>
> Key: HBASE-23881
> URL: https://issues.apache.org/jira/browse/HBASE-23881
> Project: HBase
> Issue Type: Bug
> Components: test
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Bharath Vissapragada
>Assignee: Josh Elser
>Priority: Major
> Fix For: 3.0.0
>
>
> TestShadeSaslAuthenticationProvider now fails deterministically with the
> following exception..
> {noformat}
> java.lang.Exception: Unexpected exception,
> expected but
> was
> at
> org.apache.hadoop.hbase.security.provider.example.TestShadeSaslAuthenticationProvider.testNegativeAuthentication(TestShadeSaslAuthenticationProvider.java:233)
> {noformat}
> The test now fails a different place than before merging HBASE-18095 because
> the RPCs are also a part of connection setup. We might need to rewrite the
> test..
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] asfgit closed pull request #1260: HBASE-23881 Ensure Netty client receives at least one response before…
asfgit closed pull request #1260: HBASE-23881 Ensure Netty client receives at least one response before… URL: https://github.com/apache/hbase/pull/1260 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-24066) Expose shaded clients through WebUI as Maven repository
[
https://issues.apache.org/jira/browse/HBASE-24066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068098#comment-17068098
]
Nick Dimiduk commented on HBASE-24066:
--
No irking intended; off-hand, it strikes me as something that makes HBase less
stable in production, not more; something that enabled chaos instead of
discipline around production deployments. My limited imagination doesn't
conjure a case where this is helpful to the organization that deploys it. Maybe
you want to document some incantation for running a tool that starts with
{{`java -jar "$(curl ...)"`}} ? What's wrong with the {{bin/hbase}} script? Why
not put effort into exposing a fully featured http/json/protobuf interface out
of the box?
bq. No thank you, that's not the purpose of the cluster.
You're right, this was very terse, but it includes my justification: "hosting
thick-client library artifacts is not the purpose of the cluster". My reasoning
is that artifact distribution is not the purpose of the cluster or webUI. Why
would be burden production hosts with artifact distribution? Why would we
encourage deployments where the production hosts are on the same networks as
developers? There are plenty of other means of distributing artifacts available
to an organization, means that do not couple development to production, that
are managed directly by IT and IT's policies.
Do we not distribute these artifacts via our tarballs? Wouldn't they be
installed on any host via "normal" means?
The -1 expresses the strength of my opinion based on what I've seen so far
(this JIRA and the PR). I considered -0 and decided that no, I think this is
really not a good idea. Of course a quorum of committers overrides a single
vote, does it not? Please change my mind with some use-case ideas/stories.
> Expose shaded clients through WebUI as Maven repository
> ---
>
> Key: HBASE-24066
> URL: https://issues.apache.org/jira/browse/HBASE-24066
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Minor
>
> Props to [~busbey] for this idea.
> We have a number of shaded jars which are (largely) sufficient for launching
> any Java application against HBase. However, if users have multiple versions
> of HBase in their organization, it might be confusing to know "which client"
> do I need to use? Can we expose our shaded clients from HBase in such a way
> that build tools can just ask HBase for the client jars they should use?
> The idea here is that we can use embedded Jetty to "fake" out a Maven
> repository that users can put in their client applications. We have no extra
> burden from HBase because we already are packaging these jars. I'll link an
> example Maven application which uses this "feature".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1366: Backport: HBASE-23853 [Flakey Test] TestBlockEvictionFromClient#testBlockRefCou…
Apache-HBase commented on issue #1366: Backport: HBASE-23853 [Flakey Test] TestBlockEvictionFromClient#testBlockRefCou… URL: https://github.com/apache/hbase/pull/1366#issuecomment-604721056 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 47s | branch-2 passed | | +1 :green_heart: | checkstyle | 1m 10s | branch-2 passed | | +1 :green_heart: | spotbugs | 2m 0s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 12s | the patch passed | | +1 :green_heart: | checkstyle | 1m 7s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 10m 36s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 2m 7s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 35m 47s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1366/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1366 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 7951666286b4 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / a18f5b1517 | | Max. process+thread count | 93 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1366/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1364: HBASE-24065 Enable SpotBugs in PreCommit
Apache-HBase commented on issue #1364: HBASE-24065 Enable SpotBugs in PreCommit URL: https://github.com/apache/hbase/pull/1364#issuecomment-604717478 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 57s | master passed | | +1 :green_heart: | compile | 3m 16s | master passed | | +1 :green_heart: | shadedjars | 5m 3s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 49s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 31s | the patch passed | | +1 :green_heart: | compile | 3m 11s | the patch passed | | +1 :green_heart: | javac | 3m 11s | the patch passed | | +1 :green_heart: | shadedjars | 5m 6s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 46s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 9m 36s | root in the patch failed. | | | | 45m 23s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1364/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1364 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 9a155449dfc1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 50c8f49c31 | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1364/3/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1364/3/testReport/ | | Max. process+thread count | 1094 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1364/3/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] joshelser commented on a change in pull request #1260: HBASE-23881 Ensure Netty client receives at least one response before…
joshelser commented on a change in pull request #1260: HBASE-23881 Ensure Netty
client receives at least one response before…
URL: https://github.com/apache/hbase/pull/1260#discussion_r398924292
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/security/NettyHBaseSaslRpcClientHandler.java
##
@@ -114,7 +122,10 @@ public void handlerAdded(ChannelHandlerContext ctx) {
if (initialResponse != null) {
writeResponse(ctx, initialResponse);
}
- tryComplete(ctx);
+ // HBASE-23881 We do not want to check if the SaslClient thinks the
handshake is
Review comment:
Sure, let me add that, too.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-24066) Expose shaded clients through WebUI as Maven repository
[
https://issues.apache.org/jira/browse/HBASE-24066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068089#comment-17068089
]
Josh Elser commented on HBASE-24066:
{quote}No thank you, that's not the purpose of the cluster. -1
{quote}
This is uncharacteristically terse from you and I'm a little irked by a -1
being immediately thrown out with "because" as the justification.
> Expose shaded clients through WebUI as Maven repository
> ---
>
> Key: HBASE-24066
> URL: https://issues.apache.org/jira/browse/HBASE-24066
> Project: HBase
> Issue Type: Improvement
> Components: Client
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Minor
>
> Props to [~busbey] for this idea.
> We have a number of shaded jars which are (largely) sufficient for launching
> any Java application against HBase. However, if users have multiple versions
> of HBase in their organization, it might be confusing to know "which client"
> do I need to use? Can we expose our shaded clients from HBase in such a way
> that build tools can just ask HBase for the client jars they should use?
> The idea here is that we can use embedded Jetty to "fake" out a Maven
> repository that users can put in their client applications. We have no extra
> burden from HBase because we already are packaging these jars. I'll link an
> example Maven application which uses this "feature".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24051) When the data directory is set to EC,the amount of storefiles reaches a relatively high level,heap Occupancy Percent is above heap occupancy alarm watermark,resulting
[ https://issues.apache.org/jira/browse/HBASE-24051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068088#comment-17068088 ] Michael Stack commented on HBASE-24051: --- The wrap was added by: HBASE-9393 Hbase does not closing a closed socket resulting in many CLOSE_WAIT Signed-off-by: Andrew Purtell HBase on EC is a new domain. Would be interested in the use-case. Didn't think anyone would ever want to do this. Thanks. > When the data directory is set to EC,the amount of storefiles reaches a > relatively high level,heap Occupancy Percent is above heap occupancy alarm > watermark,resulting in frequent gc and eventual failure > -- > > Key: HBASE-24051 > URL: https://issues.apache.org/jira/browse/HBASE-24051 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.1 >Reporter: shenshengli >Priority: Major > Attachments: 1.png > > > When the data directory is set to EC, during the continuous load process, > regionserver is found down ,to view the log: > regionserver.HeapMemoryManager: heapOccupancyPercent 0.91630864 is now below > the heap occupancy alarm watermark (0.95) > regionserver.HeapMemoryManager: heapOccupancyPercent 0.969546 is above heap > occupancy alarm watermark (0.95) > [JvmPauseMonitor] util.JvmPauseMonitor: Detected pause in JVM or host machine > (eg GC): pause of approximately 1254ms > GC pool 'G1 Young Generation' had collection(s): count=2 time=115ms > GC pool 'G1 Old Generation' had collection(s): count=1 time=1487ms > In particular, GC pauses occurred 283 times in half an hour. > The memory analysis found that most of the memory footprint was generated by > HeepByteBuffer,and DFSStripedInputStream produces the HeepByteBuffer > See HDFS-14308，but after the fix, hbase did not return to normal. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1363: HBASE-23853 [Flakey Test] TestBlockEvictionFromClient#testBlockRefCou…
Apache-HBase commented on issue #1363: HBASE-23853 [Flakey Test] TestBlockEvictionFromClient#testBlockRefCou… URL: https://github.com/apache/hbase/pull/1363#issuecomment-604710952 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 11s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 7m 27s | master passed | | +1 :green_heart: | compile | 1m 12s | master passed | | +1 :green_heart: | shadedjars | 6m 39s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 42s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 7m 10s | the patch passed | | +1 :green_heart: | compile | 1m 12s | the patch passed | | +1 :green_heart: | javac | 1m 12s | the patch passed | | +1 :green_heart: | shadedjars | 6m 26s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 40s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 103m 7s | hbase-server in the patch passed. | | | | 137m 40s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1363/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1363 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux b3f1a26cd267 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d05fccfc24 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1363/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1363/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1363/2/testReport/ | | Max. process+thread count | 4147 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1363/2/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1364: HBASE-24065 Enable SpotBugs in PreCommit
Apache-HBase commented on issue #1364: HBASE-24065 Enable SpotBugs in PreCommit URL: https://github.com/apache/hbase/pull/1364#issuecomment-604706946 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | | +1 :green_heart: | shellcheck | 0m 0s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 12m 22s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 17s | The patch does not generate ASF License warnings. | | | | 20m 11s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1364/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1364 | | Optional Tests | dupname asflicense shellcheck shelldocs hadoopcheck xml | | uname | Linux df98c0aeaf53 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 50c8f49c31 | | Max. process+thread count | 63 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1364/3/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) shellcheck=0.4.6 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] huaxiangsun opened a new pull request #1367: Backport: HBASE-23853 [Flakey Test] TestBlockEvictionFromClient#testBlockRefCou…
huaxiangsun opened a new pull request #1367: Backport: HBASE-23853 [Flakey Test] TestBlockEvictionFromClient#testBlockRefCou… URL: https://github.com/apache/hbase/pull/1367 …ntAfterSplits (#1363) Signed-off-by: Jan Hentschel Signed-off-by: Viraj Jasani Signed-off-by: stack This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1364: HBASE-24065 Enable SpotBugs in PreCommit
ndimiduk commented on a change in pull request #1364: HBASE-24065 Enable
SpotBugs in PreCommit
URL: https://github.com/apache/hbase/pull/1364#discussion_r398912429
##
File path: dev-support/Jenkinsfile_GitHub
##
@@ -46,6 +46,7 @@ pipeline {
TESTS_FILTER =
'cc,checkstyle,javac,javadoc,pylint,shellcheck,whitespace,perlcritic,ruby-lint,rubocop,mvnsite'
EXCLUDE_TESTS_URL =
"${JENKINS_URL}/job/HBase-Find-Flaky-Tests/job/${CHANGE_TARGET}/lastSuccessfulBuild/artifact/excludes"
+
Review comment:
Trying to distinguish between comments that describe the following section
of code vs. comments that describe the following line. Suggestions?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] huaxiangsun opened a new pull request #1366: Backport: HBASE-23853 [Flakey Test] TestBlockEvictionFromClient#testBlockRefCou…
huaxiangsun opened a new pull request #1366: Backport: HBASE-23853 [Flakey Test] TestBlockEvictionFromClient#testBlockRefCou… URL: https://github.com/apache/hbase/pull/1366 …ntAfterSplits (#1363) Signed-off-by: Jan Hentschel Signed-off-by: Viraj Jasani Signed-off-by: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1364: HBASE-24065 Enable SpotBugs in PreCommit
ndimiduk commented on a change in pull request #1364: HBASE-24065 Enable
SpotBugs in PreCommit
URL: https://github.com/apache/hbase/pull/1364#discussion_r398913220
##
File path: dev-support/Jenkinsfile_GitHub
##
@@ -156,11 +161,16 @@ pipeline {
}
}
environment {
+
// customized per parallel stage
-PLUGINS = "${JDK_SPECIFIC_PLUGINS}"
+//
+// run SpotBugs only once, and run it on JDK8.
+PLUGINS = "${JDK_SPECIFIC_PLUGINS},spotbugs"
Review comment:
`-fingbugs` explicitly disabled findbugs. I'm trying to explicitly enable
`spotbugs`. The two appear to be driven by the same yetus "check", so I'm
attempting to ensure that module is enabled. Because we don't ship findbugs
binaries in our Dockerfile anymore, I think that "check" will do the right
thing, as long as it's enabled (see earlier comments re: that check also
requiring the `maven` check as a dependency).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-24053) hbase/bin/region_status.rb Not available in hbase2
[ https://issues.apache.org/jira/browse/HBASE-24053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068076#comment-17068076 ] Michael Stack commented on HBASE-24053: --- Mind pasting evidence of what happens before and after patch? The PR seems to have an unrelated change. Thanks. > hbase/bin/region_status.rb Not available in hbase2 > -- > > Key: HBASE-24053 > URL: https://issues.apache.org/jira/browse/HBASE-24053 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.1 >Reporter: shenshengli >Priority: Minor > > A series of strange errors occurred while running this script in hbase2, > which was corrected as prompted, and it was important to note that > MetaTableAccessor had been replaced with getHRegionInfo instead of > getHRegionInfo -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1365: HBASE-24066 Let HBase master UI act as a maven repo
Apache-HBase commented on issue #1365: HBASE-24066 Let HBase master UI act as a maven repo URL: https://github.com/apache/hbase/pull/1365#issuecomment-604702439 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 58s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.2 Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 8m 6s | branch-2.2 passed | | +1 :green_heart: | compile | 1m 22s | branch-2.2 passed | | +1 :green_heart: | checkstyle | 0m 45s | branch-2.2 passed | | +1 :green_heart: | shadedjars | 6m 25s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 51s | branch-2.2 passed | | +0 :ok: | spotbugs | 0m 53s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +0 :ok: | findbugs | 0m 49s | branch/hbase-assembly no findbugs output file (findbugsXml.xml) | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 7m 30s | the patch passed | | +1 :green_heart: | compile | 1m 15s | the patch passed | | +1 :green_heart: | javac | 1m 15s | the patch passed | | +1 :green_heart: | checkstyle | 0m 41s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 4s | The patch has no ill-formed XML file. | | +1 :green_heart: | shadedjars | 6m 29s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 28m 28s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2. | | +1 :green_heart: | javadoc | 0m 30s | the patch passed | | +0 :ok: | findbugs | 0m 27s | hbase-assembly has no data from findbugs | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 1s | hbase-http in the patch passed. | | +1 :green_heart: | unit | 0m 27s | hbase-assembly in the patch passed. | | +1 :green_heart: | asflicense | 0m 22s | The patch does not generate ASF License warnings. | | | | 77m 50s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1365/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1365 | | Optional Tests | dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile spotbugs findbugs hbaseanti checkstyle | | uname | Linux 153a3de1b2da 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1365/out/precommit/personality/provided.sh | | git revision | branch-2.2 / 1777513455 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1365/1/testReport/ | | Max. process+thread count | 261 (vs. ulimit of 1) | | modules | C: hbase-http hbase-assembly U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1365/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-24009) Backport the personality changes in HBASE-23989 to all active branches
[ https://issues.apache.org/jira/browse/HBASE-24009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068067#comment-17068067 ] Nick Dimiduk commented on HBASE-24009: -- I thought all branches use the personality from master in both Nightly and PreCommit. That not the case? > Backport the personality changes in HBASE-23989 to all active branches > -- > > Key: HBASE-24009 > URL: https://issues.apache.org/jira/browse/HBASE-24009 > Project: HBase > Issue Type: Sub-task > Components: build >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 2.3.0, 1.3.7, 1.7.0, 2.1.10, 1.4.14, 2.2.5 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24066) Expose shaded clients through WebUI as Maven repository
[ https://issues.apache.org/jira/browse/HBASE-24066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068066#comment-17068066 ] Nick Dimiduk commented on HBASE-24066: -- You propose the master and region servers host a maven-style jar repository over their info ports? No thank you, that's not the purpose of the cluster. -1 > Expose shaded clients through WebUI as Maven repository > --- > > Key: HBASE-24066 > URL: https://issues.apache.org/jira/browse/HBASE-24066 > Project: HBase > Issue Type: Improvement > Components: Client >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Minor > > Props to [~busbey] for this idea. > We have a number of shaded jars which are (largely) sufficient for launching > any Java application against HBase. However, if users have multiple versions > of HBase in their organization, it might be confusing to know "which client" > do I need to use? Can we expose our shaded clients from HBase in such a way > that build tools can just ask HBase for the client jars they should use? > The idea here is that we can use embedded Jetty to "fake" out a Maven > repository that users can put in their client applications. We have no extra > burden from HBase because we already are packaging these jars. I'll link an > example Maven application which uses this "feature". -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] saintstack commented on a change in pull request #1364: HBASE-24065 Enable SpotBugs in PreCommit
saintstack commented on a change in pull request #1364: HBASE-24065 Enable
SpotBugs in PreCommit
URL: https://github.com/apache/hbase/pull/1364#discussion_r398908162
##
File path: dev-support/Jenkinsfile_GitHub
##
@@ -46,6 +46,7 @@ pipeline {
TESTS_FILTER =
'cc,checkstyle,javac,javadoc,pylint,shellcheck,whitespace,perlcritic,ruby-lint,rubocop,mvnsite'
EXCLUDE_TESTS_URL =
"${JENKINS_URL}/job/HBase-Find-Flaky-Tests/job/${CHANGE_TARGET}/lastSuccessfulBuild/artifact/excludes"
+
Review comment:
?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1364: HBASE-24065 Enable SpotBugs in PreCommit
saintstack commented on a change in pull request #1364: HBASE-24065 Enable
SpotBugs in PreCommit
URL: https://github.com/apache/hbase/pull/1364#discussion_r398908719
##
File path: dev-support/Jenkinsfile_GitHub
##
@@ -156,11 +161,16 @@ pipeline {
}
}
environment {
+
// customized per parallel stage
-PLUGINS = "${JDK_SPECIFIC_PLUGINS}"
+//
+// run SpotBugs only once, and run it on JDK8.
+PLUGINS = "${JDK_SPECIFIC_PLUGINS},spotbugs"
Review comment:
It used to be -findbugs with hyphen. No need of it when doing spotbugs?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1364: HBASE-24065 Enable SpotBugs in PreCommit
Apache-HBase commented on issue #1364: HBASE-24065 Enable SpotBugs in PreCommit URL: https://github.com/apache/hbase/pull/1364#issuecomment-604698164 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 51s | master passed | | +1 :green_heart: | compile | 3m 59s | master passed | | +1 :green_heart: | shadedjars | 6m 13s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 22s | root in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 17s | the patch passed | | +1 :green_heart: | compile | 3m 58s | the patch passed | | +1 :green_heart: | javac | 3m 58s | the patch passed | | +1 :green_heart: | shadedjars | 6m 10s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 20s | root in the patch failed. | ||| _ Other Tests _ | | -0 :warning: | unit | 89m 38s | root in the patch failed. | | | | 127m 26s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1364/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1364 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 54957bf43591 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d05fccfc24 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1364/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1364/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1364/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1364/2/testReport/ | | Max. process+thread count | 6856 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1364/2/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1363: HBASE-23853 [Flakey Test] TestBlockEvictionFromClient#testBlockRefCou…
Apache-HBase commented on issue #1363: HBASE-23853 [Flakey Test] TestBlockEvictionFromClient#testBlockRefCou… URL: https://github.com/apache/hbase/pull/1363#issuecomment-604695793 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 11s | master passed | | +1 :green_heart: | compile | 1m 2s | master passed | | +1 :green_heart: | shadedjars | 5m 22s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 46s | the patch passed | | +1 :green_heart: | compile | 0m 57s | the patch passed | | +1 :green_heart: | javac | 0m 57s | the patch passed | | +1 :green_heart: | shadedjars | 5m 17s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 71m 11s | hbase-server in the patch passed. | | | | 99m 51s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1363/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1363 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux f201a22e9719 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d05fccfc24 | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1363/2/testReport/ | | Max. process+thread count | 5559 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1363/2/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
