[GitHub] [hbase] Apache-HBase commented on issue #1405: HBASE-24097 [Flakey Tests] TestSnapshotScannerHDFSAclController#testRestoreSnapshot
Apache-HBase commented on issue #1405: HBASE-24097 [Flakey Tests] TestSnapshotScannerHDFSAclController#testRestoreSnapshot URL: https://github.com/apache/hbase/pull/1405#issuecomment-607067627 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 20s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 47s | branch-2 passed | | +1 :green_heart: | checkstyle | 1m 21s | branch-2 passed | | +1 :green_heart: | spotbugs | 2m 18s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 55s | the patch passed | | -0 :warning: | checkstyle | 1m 15s | hbase-server: The patch generated 8 new + 1 unchanged - 0 fixed = 9 total (was 1) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 2s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 2m 25s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 11s | The patch does not generate ASF License warnings. | | | | 40m 12s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1405/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1405 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 2ea0141a9761 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / c5a3ab7504 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1405/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 83 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1405/2/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] shenshengli opened a new pull request #1406: HBASE-24051 Allows indirect inheritance to CanUnbuffer
shenshengli opened a new pull request #1406: HBASE-24051 Allows indirect inheritance to CanUnbuffer URL: https://github.com/apache/hbase/pull/1406 If you have an inherited parent class that implements CanUnbuffer instead of directly implementing CanUnbuffer, you cannot get unbuffer.Differences between the old and new methods can be found in UT. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (HBASE-24096) Fix TestRSGroupsBalance
[ https://issues.apache.org/jira/browse/HBASE-24096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijin Bin resolved HBASE-24096. --- Resolution: Fixed > Fix TestRSGroupsBalance > --- > > Key: HBASE-24096 > URL: https://issues.apache.org/jira/browse/HBASE-24096 > Project: HBase > Issue Type: Bug > Components: rsgroup >Affects Versions: 3.0.0 >Reporter: Lijin Bin >Assignee: Lijin Bin >Priority: Major > Fix For: 3.0.0 > > > run TestRSGroupsBalance failed, after debug into it, it related to > HBASE-24032. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24096) Fix TestRSGroupsBalance
[ https://issues.apache.org/jira/browse/HBASE-24096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijin Bin updated HBASE-24096: -- Component/s: rsgroup Fix Version/s: 3.0.0 Affects Version/s: 3.0.0 > Fix TestRSGroupsBalance > --- > > Key: HBASE-24096 > URL: https://issues.apache.org/jira/browse/HBASE-24096 > Project: HBase > Issue Type: Bug > Components: rsgroup >Affects Versions: 3.0.0 >Reporter: Lijin Bin >Assignee: Lijin Bin >Priority: Major > Fix For: 3.0.0 > > > run TestRSGroupsBalance failed, after debug into it, it related to > HBASE-24032. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] shenshengli closed pull request #1404: HBASE-24051 Allows indirect inheritance to CanUnbuffer
shenshengli closed pull request #1404: HBASE-24051 Allows indirect inheritance to CanUnbuffer URL: https://github.com/apache/hbase/pull/1404 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] shenshengli commented on a change in pull request #1404: HBASE-24051 Allows indirect inheritance to CanUnbuffer
shenshengli commented on a change in pull request #1404: HBASE-24051 Allows
indirect inheritance to CanUnbuffer
URL: https://github.com/apache/hbase/pull/1404#discussion_r401379902
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java
##
@@ -331,22 +332,18 @@ public void unbuffer() {
if (this.instanceOfCanUnbuffer == null) {
// To ensure we compute whether the stream is instance of CanUnbuffer
only once.
this.instanceOfCanUnbuffer = false;
-Class[] streamInterfaces = streamClass.getInterfaces();
-for (Class c : streamInterfaces) {
- if
(c.getCanonicalName().toString().equals("org.apache.hadoop.fs.CanUnbuffer")) {
-try {
- this.unbuffer = streamClass.getDeclaredMethod("unbuffer");
-} catch (NoSuchMethodException | SecurityException e) {
- if (isLogTraceEnabled) {
-LOG.trace("Failed to find 'unbuffer' method in class " +
streamClass
-+ " . So there may be a TCP socket connection "
-+ "left open in CLOSE_WAIT state.", e);
- }
- return;
Review comment:
The old method can only get those that implement Canbuffer directly.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] binlijin merged pull request #1402: HBASE-24096 Fix TestRSGroupsBalance
binlijin merged pull request #1402: HBASE-24096 Fix TestRSGroupsBalance URL: https://github.com/apache/hbase/pull/1402 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-24097) [Flakey Tests] TestSnapshotScannerHDFSAclController#testRestoreSnapshot
[ https://issues.apache.org/jira/browse/HBASE-24097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072411#comment-17072411 ] Yi Mei commented on HBASE-24097: +1 on the PR > [Flakey Tests] TestSnapshotScannerHDFSAclController#testRestoreSnapshot > --- > > Key: HBASE-24097 > URL: https://issues.apache.org/jira/browse/HBASE-24097 > Project: HBase > Issue Type: Bug > Components: flakies >Reporter: Michael Stack >Priority: Major > > Fails on occasion, 15% of the time according to flakie report. I can > reproduce it failing locally. A single method fails. I don't follow how it is > supposed to work (what looks wrong to me passes...). I noticed that if I ran > testRestoreSnapshot on its own, it passed but failed when run as part of the > test suite so I broke it out into its own suite. Now both old and new suites > pass for me locally after 20 repeats. Let me push it up. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1405: HBASE-24097 [Flakey Tests] TestSnapshotScannerHDFSAclController#testRestoreSnapshot
Apache-HBase commented on issue #1405: HBASE-24097 [Flakey Tests] TestSnapshotScannerHDFSAclController#testRestoreSnapshot URL: https://github.com/apache/hbase/pull/1405#issuecomment-607053610 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 19s | branch-2 passed | | +1 :green_heart: | compile | 1m 5s | branch-2 passed | | +1 :green_heart: | shadedjars | 5m 14s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 42s | hbase-server in branch-2 failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 6s | the patch passed | | +1 :green_heart: | compile | 1m 6s | the patch passed | | +1 :green_heart: | javac | 1m 6s | the patch passed | | +1 :green_heart: | shadedjars | 5m 18s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 39s | hbase-server in the patch failed. | ||| _ Other Tests _ | | -0 :warning: | unit | 67m 6s | hbase-server in the patch failed. | | | | 96m 26s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1405/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1405 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 4d7e5ea5a0bb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / c5a3ab7504 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1405/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1405/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1405/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1405/1/testReport/ | | Max. process+thread count | 5483 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1405/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1405: HBASE-24097 [Flakey Tests] TestSnapshotScannerHDFSAclController#testRestoreSnapshot
Apache-HBase commented on issue #1405: HBASE-24097 [Flakey Tests] TestSnapshotScannerHDFSAclController#testRestoreSnapshot URL: https://github.com/apache/hbase/pull/1405#issuecomment-607052857 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 38s | branch-2 passed | | +1 :green_heart: | compile | 0m 58s | branch-2 passed | | +1 :green_heart: | shadedjars | 4m 29s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 10s | the patch passed | | +1 :green_heart: | compile | 0m 57s | the patch passed | | +1 :green_heart: | javac | 0m 57s | the patch passed | | +1 :green_heart: | shadedjars | 4m 27s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 35s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 68m 10s | hbase-server in the patch failed. | | | | 93m 51s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1405/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1405 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 4467b5d11d6d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / c5a3ab7504 | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1405/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1405/1/testReport/ | | Max. process+thread count | 5909 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1405/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1401: HBASE-24075: Fix a race between master shutdown and metrics (re)init
Apache-HBase commented on issue #1401: HBASE-24075: Fix a race between master shutdown and metrics (re)init URL: https://github.com/apache/hbase/pull/1401#issuecomment-607046829 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 15s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 59s | branch-2 passed | | +1 :green_heart: | checkstyle | 1m 41s | branch-2 passed | | +1 :green_heart: | spotbugs | 2m 57s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 38s | the patch passed | | +1 :green_heart: | checkstyle | 1m 39s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 44s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 3m 27s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 32s | The patch does not generate ASF License warnings. | | | | 43m 12s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1401/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1401 | | JIRA Issue | HBASE-24075 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux fcd027e757b4 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / c5a3ab7504 | | Max. process+thread count | 83 (vs. ulimit of 1) | | modules | C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1401/2/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (HBASE-24068) [Flakey Tests] TestServerSideScanMetricsFromClientSide and NullPointerException
[
https://issues.apache.org/jira/browse/HBASE-24068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Stack resolved HBASE-24068.
---
Fix Version/s: 2.3.0
3.0.0
Hadoop Flags: Reviewed
Resolution: Implemented
Resolving as implemented by HBASE-24079.
Thanks for reviews of PR [~ndimiduk] and [~janh]
> [Flakey Tests] TestServerSideScanMetricsFromClientSide and
> NullPointerException
> ---
>
> Key: HBASE-24068
> URL: https://issues.apache.org/jira/browse/HBASE-24068
> Project: HBase
> Issue Type: Bug
> Components: flakies
>Reporter: Michael Stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> This fails for me locally sporadically.
> {code}
>
> ---
> Test set: org.apache.hadoop.hbase.TestServerSideScanMetricsFromClientSide
>
> ---
> Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.893 s <<<
> FAILURE! - in org.apache.hadoop.hbase.TestServerSideScanMetricsFromClientSide
>
> org.apache.hadoop.hbase.TestServerSideScanMetricsFromClientSide.testRowsSeenMetricWithAsync
> Time elapsed: 0.325 s <<< ERROR!
> java.lang.NullPointerException
> {code}
> Log pinpoints the problem a little better
> {code}
> Exception in thread "testTable.asyncPrefetcher"
> java.lang.NullPointerException
>at
> org.apache.hadoop.hbase.client.ClientAsyncPrefetchScanner$PrefetchRunnable.run(ClientAsyncPrefetchScanner.java:183)
>at java.lang.Thread.run(Thread.java:748)
> java.lang.NullPointerException
>at
> org.apache.hadoop.hbase.client.ClientAsyncPrefetchScanner$PrefetchRunnable.run(ClientAsyncPrefetchScanner.java:174)
>at java.lang.Thread.run(Thread.java:748)
> java.lang.NullPointerException
>at
> org.apache.hadoop.hbase.client.ClientAsyncPrefetchScanner$PrefetchRunnable.run(ClientAsyncPrefetchScanner.java:174)
>at java.lang.Thread.run(Thread.java:748)
> 2020-03-26 22:18:15,160 ERROR [Listener at localhost/53268]
> hbase.TestServerSideScanMetricsFromClientSide(202): FAIL
> java.lang.NullPointerException
>at
> org.apache.hadoop.hbase.client.ClientAsyncPrefetchScanner$PrefetchRunnable.run(ClientAsyncPrefetchScanner.java:174)
>at java.lang.Thread.run(Thread.java:748)
> {code}
> It didn't make sense to me since complaint was about a 'lock' that is created
> as a final data member. But then this issue happened for my compañero,
> [~ndimiduk]... and he saw that the call is from a Thread inner class in this
> class's grandparent that is set running on construction; i.e. the lock
> *could* be null at the time of reference.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (HBASE-24079) [Flakey Tests] Misc fixes and debug; fix BindException in Thrift tests; add waits on quota table to come online; etc.
[
https://issues.apache.org/jira/browse/HBASE-24079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Stack resolved HBASE-24079.
---
Fix Version/s: 2.3.0
3.0.0
Resolution: Fixed
Merged to branch-2.3+. Thanks for reviews [~bharathv]
> [Flakey Tests] Misc fixes and debug; fix BindException in Thrift tests; add
> waits on quota table to come online; etc.
> -
>
> Key: HBASE-24079
> URL: https://issues.apache.org/jira/browse/HBASE-24079
> Project: HBase
> Issue Type: Bug
> Components: flakies
>Reporter: Michael Stack
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> Some fixes that have accumulated over last few days.
> Fixes for weird NPE on construction of ClientAsyncPrefetchScanner, catches
> for unexpected, test-killing exceptions in RSProcedureDispatcher and in
> CompactSplit; add waits on quota table to come on line and regionservers to
> go down before proceeding; add retry if BindException in thrift tests;
> disabled a few flakies; etc. Add some debug too.
> {code}
>
> hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientAsyncPrefetchScanner.java
> Refactor to avoid NPE timing issue referencing lock during Construction.
>
> hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
> Comment
>
> hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RSProcedureDispatcher.java
> Refactor. Catch NPE during startup and return it instead as failed
> initialization.
>
> hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java
> Catch IndexOutOfBounds exception and convert to non-split request.
>
> hbase-server/src/test/java/org/apache/hadoop/hbase/TestCachedClusterId.java
> Make less furious. Make it less flakie.
>
> hbase-server/src/test/java/org/apache/hadoop/hbase/TestServerSideScanMetricsFromClientSide.java
> Debug. Catch exception to log, then rethrow.
>
> hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncRegionAdminApi.java
> Guess that waiting longer on compaction to succeed may help make this
> less flakey.
>
> hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide3.java
> Be explicit about timestamping to avoid concurrent edit landing
> server-side and messing up test expectation.
>
> hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMasterRegistry.java
> Add wait on meta before proceeding w/ test.
>
> hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestScannersFromClientSide.java
> Be explicit that edits are distinct.
>
> hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/bucket/TestBucketCacheRefCnt.java
> Add @Ignore on RAM test... Fails sporadically.
>
> hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestRegionMoveAndAbandon.java
> Add wait for all RegionServers going down before proceeding; was
> messing up RS accounting.
>
> hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/BalancerTestBase.java
> Make balancer test sloppier; less restrictive; would fail on occasion
> by being just outside test limits.
>
> hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestQuotaObserverChoreRegionReports.java
> Add wait on quota table coming up; helps make this less flakie.
>
> hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
> Be explicity about timestamps; see if helps w/ flakie failure.
>
> hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionReplicas.java
> Catch and ignore if issue in shutdown; don't care if after test.
>
> hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerReportForDuty.java
> Comment.
>
> hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java
> Add retry to see if helps w/ odd failure; grant hasn't propagated?
>
> hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestCellACLWithMultipleVersions.java
> Explicit w/ timestamps so no accidental overlap of puts.
>
> hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftHttpServer.java
>
> hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java
> Hack to deal w/ BindException on startup.
>
> hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThrift2ServerCmdLine.java
> Use loopback.
>
> hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java
> Disable flakie test.
> {code}
[GitHub] [hbase] saintstack commented on issue #1405: HBASE-24097 [Flakey Tests] TestSnapshotScannerHDFSAclController#testRestoreSnapshot
saintstack commented on issue #1405: HBASE-24097 [Flakey Tests] TestSnapshotScannerHDFSAclController#testRestoreSnapshot URL: https://github.com/apache/hbase/pull/1405#issuecomment-607041332 First patch was stale. Old. Fix. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1405: HBASE-24097 [Flakey Tests] TestSnapshotScannerHDFSAclController#testRestoreSnapshot
Apache-HBase commented on issue #1405: HBASE-24097 [Flakey Tests] TestSnapshotScannerHDFSAclController#testRestoreSnapshot URL: https://github.com/apache/hbase/pull/1405#issuecomment-607038003 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 51s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 8m 5s | branch-2 passed | | +1 :green_heart: | checkstyle | 1m 30s | branch-2 passed | | +1 :green_heart: | spotbugs | 2m 32s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 7m 6s | the patch passed | | -0 :warning: | checkstyle | 1m 28s | hbase-server: The patch generated 8 new + 1 unchanged - 0 fixed = 9 total (was 1) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 14m 16s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 2m 36s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 17s | The patch does not generate ASF License warnings. | | | | 48m 49s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1405/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1405 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux c4c50e1512cd 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / c5a3ab7504 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1405/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 83 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1405/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1374: HBASE-24068 [Flakey Tests] TestServerSideScanMetricsFromClientSide an…
saintstack commented on a change in pull request #1374: HBASE-24068 [Flakey
Tests] TestServerSideScanMetricsFromClientSide an…
URL: https://github.com/apache/hbase/pull/1374#discussion_r401358236
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientAsyncPrefetchScanner.java
##
@@ -80,13 +77,10 @@ void setPrefetchListener(Consumer
prefetchListener) {
@Override
protected void initCache() {
-// concurrent cache
-maxCacheSize = resultSize2CacheSize(maxScannerResultSize);
+// Override to put a different cache in place of the super's -- a
concurrent one.
cache = new LinkedBlockingQueue<>();
+maxCacheSize = resultSize2CacheSize(maxScannerResultSize);
cacheSizeInBytes = new AtomicLong(0);
-exceptionsQueue = new ConcurrentLinkedQueue<>();
-prefetcher = new Thread(new PrefetchRunnable());
Review comment:
Nothing was done w/ the reference previously. Yeah, its daemon so should be
just dying when process goes away.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1401: HBASE-24075: Fix a race between master shutdown and metrics (re)init
saintstack commented on a change in pull request #1401: HBASE-24075: Fix a race
between master shutdown and metrics (re)init
URL: https://github.com/apache/hbase/pull/1401#discussion_r401357417
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/CachedClusterId.java
##
@@ -130,9 +134,12 @@ private void waitForFetchToFinish() throws
InterruptedException {
* trying get from a clean cache.
*
* @return ClusterId by reading from FileSystem or null in any error case or
cluster ID does
- * not exist on the file system.
+ * not exist on the file system or if the server initiated a tear down.
*/
public String getFromCacheOrFetch() {
+if (server.isStopping() || server.isStopped()) {
Review comment:
Great
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1401: HBASE-24075: Fix a race between master shutdown and metrics (re)init
saintstack commented on a change in pull request #1401: HBASE-24075: Fix a race
between master shutdown and metrics (re)init
URL: https://github.com/apache/hbase/pull/1401#discussion_r401357499
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/CachedClusterId.java
##
@@ -130,9 +134,12 @@ private void waitForFetchToFinish() throws
InterruptedException {
* trying get from a clean cache.
*
* @return ClusterId by reading from FileSystem or null in any error case or
cluster ID does
- * not exist on the file system.
+ * not exist on the file system or if the server initiated a tear down.
*/
public String getFromCacheOrFetch() {
+if (server.isStopping() || server.isStopped()) {
Review comment:
isStopped is probably enough but this is fine.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on issue #1401: HBASE-24075: Fix a race between master shutdown and metrics (re)init
saintstack commented on issue #1401: HBASE-24075: Fix a race between master shutdown and metrics (re)init URL: https://github.com/apache/hbase/pull/1401#issuecomment-607033841 Seems like a nonsense result. Re-running. ``` ... [INFO] Running org.apache.hadoop.hbase.replication.regionserver.TestMetricsReplicationSourceFactoryImpl [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.125 s - in org.apache.hadoop.hbase.replication.regionserver.TestMetricsReplicationSourceFactoryImpl [INFO] Running org.apache.hadoop.hbase.metrics.TestBaseSourceImpl [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.569 s - in org.apache.hadoop.hbase.master.TestMetricsMasterProcSourceImpl [INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.19 s - in org.apache.hadoop.hbase.metrics.TestBaseSourceImpl [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.613 s - in org.apache.hadoop.hbase.rest.TestMetricsRESTSourceImpl [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.618 s - in org.apache.hadoop.hbase.regionserver.TestMetricsTableSourceImpl [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.65 s - in org.apache.hadoop.hbase.regionserver.wal.TestMetricsWALSourceImpl [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.678 s - in org.apache.hadoop.hbase.regionserver.TestMetricsRegionServerSourceImpl [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.65 s - in org.apache.hadoop.hbase.regionserver.TestMetricsRegionSourceImpl [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.626 s - in org.apache.hadoop.hbase.master.TestMetricsMasterSourceImpl [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.63 s - in org.apache.hadoop.hbase.replication.regionserver.TestMetricsReplicationSourceImpl [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.724 s - in org.apache.hadoop.hbase.thrift.TestMetricsThriftServerSourceFactoryImpl [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.767 s - in org.apache.hadoop.hbase.regionserver.TestMetricsUserSourceImpl [INFO] Running org.apache.hadoop.hbase.zookeeper.TestMetricsZooKeeperSourceImpl [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.378 s - in org.apache.hadoop.hbase.zookeeper.TestMetricsZooKeeperSourceImpl [INFO] [INFO] Results: [INFO] [INFO] Tests run: 25, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 13.382 s [INFO] Finished at: 2020-04-01T00:29:48Z [INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M4:test (default-test) on project hbase-hadoop2-compat: There are test failures. [ERROR] [ERROR] Please refer to /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1401/yetus-jdk8-hadoop2-check/src/hbase-hadoop2-compat/target/surefire-reports for the individual test results. [ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream. [ERROR] ExecutionException The forked VM terminated without properly saying goodbye. VM crash or System.exit called? [ERROR] Command was /bin/sh -c cd /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1401/yetus-jdk8-hadoop2-check/src/hbase-hadoop2-compat && /usr/lib/jvm/jdk8u232-b09/jre/bin/java -enableassertions -Dhbase.build.id=2020-04-01T00:29:35Z -Xmx2800m -Djava.security.egd=file:/dev/./urandom -Djava.net.preferIPv4Stack=true -Djava.awt.headless=true -Djdk.net.URLClassPath.disableClassPathURLCheck=true -Dorg.apache.hbase.thirdparty.io.netty.leakDetection.level=advanced -Dio.netty.eventLoopThreads=3 -jar /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1401/yetus-jdk8-hadoop2-check/src/hbase-hadoop2-compat/target/surefire/surefirebooter6813753669247351658.jar /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1401/yetus-jdk8-hadoop2-check/src/hbase-hadoop2-compat/target/surefire 2020-04-01T00-29-44_503-jvmRun10 surefire8764034184098951423tmp surefire_64101371706643629520tmp [ERROR] Process Exit Code: 0 [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException: ExecutionException The forked VM terminated without properly saying goodbye. VM crash or System.exit called? [ERROR] Command was /bin/sh -c cd /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1401/yetus-jdk8-hadoop2-check/src/hbase-hadoop2-compat && /usr/lib/jvm/jdk8u232-b09/jre/bin/java -enableassertions -Dhbase.build.id=2020-04-01T0
[GitHub] [hbase] saintstack commented on a change in pull request #1404: HBASE-24051 Allows indirect inheritance to CanUnbuffer
saintstack commented on a change in pull request #1404: HBASE-24051 Allows
indirect inheritance to CanUnbuffer
URL: https://github.com/apache/hbase/pull/1404#discussion_r401355790
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/FSDataInputStreamWrapper.java
##
@@ -331,22 +332,18 @@ public void unbuffer() {
if (this.instanceOfCanUnbuffer == null) {
// To ensure we compute whether the stream is instance of CanUnbuffer
only once.
this.instanceOfCanUnbuffer = false;
-Class[] streamInterfaces = streamClass.getInterfaces();
-for (Class c : streamInterfaces) {
- if
(c.getCanonicalName().toString().equals("org.apache.hadoop.fs.CanUnbuffer")) {
-try {
- this.unbuffer = streamClass.getDeclaredMethod("unbuffer");
-} catch (NoSuchMethodException | SecurityException e) {
- if (isLogTraceEnabled) {
-LOG.trace("Failed to find 'unbuffer' method in class " +
streamClass
-+ " . So there may be a TCP socket connection "
-+ "left open in CLOSE_WAIT state.", e);
- }
- return;
Review comment:
Why doesn't the old way work? Is it not finding the unbuffer method via
reflection? Thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-24060) Generate CHANGES.md and RELEASENOTES.md for 2.1.10
[
https://issues.apache.org/jira/browse/HBASE-24060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072380#comment-17072380
]
Hudson commented on HBASE-24060:
Results for branch branch-2.1
[build #1848 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1848/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1848//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1848//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1848//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Generate CHANGES.md and RELEASENOTES.md for 2.1.10
> --
>
> Key: HBASE-24060
> URL: https://issues.apache.org/jira/browse/HBASE-24060
> Project: HBase
> Issue Type: Sub-task
> Components: documentation
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.1.10
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24097) [Flakey Tests] TestSnapshotScannerHDFSAclController#testRestoreSnapshot
[ https://issues.apache.org/jira/browse/HBASE-24097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072378#comment-17072378 ] Zheng Hu commented on HBASE-24097: -- Ping [~meiyi] > [Flakey Tests] TestSnapshotScannerHDFSAclController#testRestoreSnapshot > --- > > Key: HBASE-24097 > URL: https://issues.apache.org/jira/browse/HBASE-24097 > Project: HBase > Issue Type: Bug > Components: flakies >Reporter: Michael Stack >Priority: Major > > Fails on occasion, 15% of the time according to flakie report. I can > reproduce it failing locally. A single method fails. I don't follow how it is > supposed to work (what looks wrong to me passes...). I noticed that if I ran > testRestoreSnapshot on its own, it passed but failed when run as part of the > test suite so I broke it out into its own suite. Now both old and new suites > pass for me locally after 20 repeats. Let me push it up. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24051) When the data directory is set to EC,the amount of storefiles reaches a relatively high level,heap Occupancy Percent is above heap occupancy alarm watermark,resulting
[ https://issues.apache.org/jira/browse/HBASE-24051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072375#comment-17072375 ] Michael Stack commented on HBASE-24051: --- bq. I don't think you can pin your hopes on someone else thinking about perfection... Sorry. What you mean by above? You mean client doing manual unbuffer calls will never be satisfactory? bq. So the hbase side as a client needs to be as thoughtful as possible. Agree. bq. I don't know why hbase keeps those inputstreams after load, just unbuffer They were added to address an old plethora of CLOSE_WAIT issues, a common complaint. Do the CLOSE_WAITs return do you know if we apply this patch? bq. vI'll keep watching. Do you mean, apply the patch and you'll watch how it performs (or something else?) bq. Another easy way to avoid errors is to add "implements CanUnbuffer" to the DFSStripedInputStream Would this be a HDFS change? Was interested in the use case that has hbase run on top of an EC FS. Thanks > When the data directory is set to EC,the amount of storefiles reaches a > relatively high level,heap Occupancy Percent is above heap occupancy alarm > watermark,resulting in frequent gc and eventual failure > -- > > Key: HBASE-24051 > URL: https://issues.apache.org/jira/browse/HBASE-24051 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.1 >Reporter: shenshengli >Priority: Major > Attachments: 1.png > > > When the data directory is set to EC, during the continuous load process, > regionserver is found down ,to view the log: > regionserver.HeapMemoryManager: heapOccupancyPercent 0.91630864 is now below > the heap occupancy alarm watermark (0.95) > regionserver.HeapMemoryManager: heapOccupancyPercent 0.969546 is above heap > occupancy alarm watermark (0.95) > [JvmPauseMonitor] util.JvmPauseMonitor: Detected pause in JVM or host machine > (eg GC): pause of approximately 1254ms > GC pool 'G1 Young Generation' had collection(s): count=2 time=115ms > GC pool 'G1 Old Generation' had collection(s): count=1 time=1487ms > In particular, GC pauses occurred 283 times in half an hour. > The memory analysis found that most of the memory footprint was generated by > HeepByteBuffer,and DFSStripedInputStream produces the HeepByteBuffer > See HDFS-14308，but after the fix, hbase did not return to normal. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] saintstack commented on issue #1405: HBASE-24097 [Flakey Tests] TestSnapshotScannerHDFSAclController#testRestoreSnapshot
saintstack commented on issue #1405: HBASE-24097 [Flakey Tests] TestSnapshotScannerHDFSAclController#testRestoreSnapshot URL: https://github.com/apache/hbase/pull/1405#issuecomment-607023940 HBASE-24097 [Flakey Tests] TestSnapshotScannerHDFSAclController#testRestoreSnapshot hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationTrackerZKImpl.java Add debug for when assert fails (it fails on occasion locally) hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestHDFSAclHelper.java Move this inner class out standalone since it used now by two tests. hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestSnapshotScannerHDFSAclController.java Moved out testRestoreSnapshot and made methods in here static so could be used by a new adacent test. Also made tablenames unique to methods thinking that was root of original issue (wasn't but no harm in doing this change) Moved out the inner class TestHDFSAclHelper. hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestSnapshotScannerHDFSAclController2.java New class that sets up same context as TestSnapshotScannerHDFSAclController but just to run single testRestoreSnapshot method. hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestZKSecretWatcher.java Some debug. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack opened a new pull request #1405: HBASE-24097 [Flakey Tests] TestSnapshotScannerHDFSAclController#testRestoreSnapshot
saintstack opened a new pull request #1405: HBASE-24097 [Flakey Tests] TestSnapshotScannerHDFSAclController#testRestoreSnapshot URL: https://github.com/apache/hbase/pull/1405 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1404: HBASE-24051 Allows indirect inheritance to CanUnbuffer
Apache-HBase commented on issue #1404: HBASE-24051 Allows indirect inheritance to CanUnbuffer URL: https://github.com/apache/hbase/pull/1404#issuecomment-607023377 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 27s | master passed | | +1 :green_heart: | compile | 1m 12s | master passed | | +1 :green_heart: | shadedjars | 5m 43s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 40s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 1s | the patch passed | | +1 :green_heart: | compile | 1m 7s | the patch passed | | +1 :green_heart: | javac | 1m 7s | the patch passed | | +1 :green_heart: | shadedjars | 6m 55s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 42s | hbase-server in the patch failed. | ||| _ Other Tests _ | | -0 :warning: | unit | 5m 4s | hbase-server in the patch failed. | | | | 35m 45s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1404/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1404 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 84ef7566d382 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6f213e9d5a | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1404/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1404/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1404/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1404/1/testReport/ | | Max. process+thread count | 675 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1404/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1404: HBASE-24051 Allows indirect inheritance to CanUnbuffer
Apache-HBase commented on issue #1404: HBASE-24051 Allows indirect inheritance to CanUnbuffer URL: https://github.com/apache/hbase/pull/1404#issuecomment-607023083 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 29s | master passed | | +1 :green_heart: | checkstyle | 1m 7s | master passed | | +1 :green_heart: | spotbugs | 2m 3s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 0s | the patch passed | | -0 :warning: | checkstyle | 1m 6s | hbase-server: The patch generated 38 new + 7 unchanged - 0 fixed = 45 total (was 7) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 10m 22s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 2m 9s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 34m 45s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1404/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1404 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 7679741fa936 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6f213e9d5a | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1404/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 93 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1404/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-24097) [Flakey Tests] TestSnapshotScannerHDFSAclController#testRestoreSnapshot
[ https://issues.apache.org/jira/browse/HBASE-24097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-24097: -- Summary: [Flakey Tests] TestSnapshotScannerHDFSAclController#testRestoreSnapshot (was: [Flakey Tests] TestSnapshotScannerHDFSAclController) > [Flakey Tests] TestSnapshotScannerHDFSAclController#testRestoreSnapshot > --- > > Key: HBASE-24097 > URL: https://issues.apache.org/jira/browse/HBASE-24097 > Project: HBase > Issue Type: Bug > Components: flakies >Reporter: Michael Stack >Priority: Major > > Fails on occasion, 15% of the time according to flakie report. I can > reproduce it failing locally. A single method fails. I don't follow how it is > supposed to work (what looks wrong to me passes...). I noticed that if I ran > testRestoreSnapshot on its own, it passed but failed when run as part of the > test suite so I broke it out into its own suite. Now both old and new suites > pass for me locally after 20 repeats. Let me push it up. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1402: HBASE-24096 Fix TestRSGroupsBalance
Apache-HBase commented on issue #1402: HBASE-24096 Fix TestRSGroupsBalance URL: https://github.com/apache/hbase/pull/1402#issuecomment-607022190 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 7m 6s | master passed | | +1 :green_heart: | compile | 1m 13s | master passed | | +1 :green_heart: | shadedjars | 6m 20s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 46s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 49s | the patch passed | | +1 :green_heart: | compile | 1m 17s | the patch passed | | +1 :green_heart: | javac | 1m 17s | the patch passed | | +1 :green_heart: | shadedjars | 6m 28s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 46s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 68m 38s | hbase-server in the patch passed. | | | | 102m 12s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1402/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1402 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 5844934dd2b9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6f213e9d5a | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1402/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1402/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1402/1/testReport/ | | Max. process+thread count | 5779 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1402/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1404: HBASE-24051 Allows indirect inheritance to CanUnbuffer
Apache-HBase commented on issue #1404: HBASE-24051 Allows indirect inheritance to CanUnbuffer URL: https://github.com/apache/hbase/pull/1404#issuecomment-607021446 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 35s | master passed | | +1 :green_heart: | compile | 0m 58s | master passed | | +1 :green_heart: | shadedjars | 4m 51s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 14s | the patch passed | | +1 :green_heart: | compile | 0m 57s | the patch passed | | +1 :green_heart: | javac | 0m 57s | the patch passed | | +1 :green_heart: | shadedjars | 4m 46s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 35s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 4m 32s | hbase-server in the patch failed. | | | | 29m 56s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1404/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1404 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 53659b81fcc0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6f213e9d5a | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1404/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1404/1/testReport/ | | Max. process+thread count | 784 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1404/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-24097) [Flakey Tests] TestSnapshotScannerHDFSAclController
Michael Stack created HBASE-24097: - Summary: [Flakey Tests] TestSnapshotScannerHDFSAclController Key: HBASE-24097 URL: https://issues.apache.org/jira/browse/HBASE-24097 Project: HBase Issue Type: Bug Components: flakies Reporter: Michael Stack Fails on occasion, 15% of the time according to flakie report. I can reproduce it failing locally. A single method fails. I don't follow how it is supposed to work (what looks wrong to me passes...). I noticed that if I ran testRestoreSnapshot on its own, it passed but failed when run as part of the test suite so I broke it out into its own suite. Now both old and new suites pass for me locally after 20 repeats. Let me push it up. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24032) [RSGroup] Assign created tables to respective rsgroup automatically instead of manual operations
[ https://issues.apache.org/jira/browse/HBASE-24032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24032: -- Fix Version/s: (was: master) 3.0.0 > [RSGroup] Assign created tables to respective rsgroup automatically instead > of manual operations > - > > Key: HBASE-24032 > URL: https://issues.apache.org/jira/browse/HBASE-24032 > Project: HBase > Issue Type: Improvement > Components: master, rsgroup >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Major > Fix For: 3.0.0, 2.3.0, 1.7.0, 1.4.14, 2.2.5 > > > In prod practise, it's time consuming and tiring to assign tables to their > rsgroups for HBase admin by shell, especially in 1.x rsgroup client is > IA.private, we could not even write some programs to do that. > And I'm here proposing a solution to do the automated rsgroup assignment by > allowing running a shell in postCreateTable to determine which table should > go to which rsgroup (way in branch-1 not master). The benefit is obvious, > admin can determine or change at any time the mapping rule in script without > restarting or re-config anything. It's flexible, convenience and time saving. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1402: HBASE-24096 Fix TestRSGroupsBalance
Apache-HBase commented on issue #1402: HBASE-24096 Fix TestRSGroupsBalance URL: https://github.com/apache/hbase/pull/1402#issuecomment-607019164 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 33s | master passed | | +1 :green_heart: | compile | 0m 58s | master passed | | +1 :green_heart: | shadedjars | 4m 48s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 10s | the patch passed | | +1 :green_heart: | compile | 0m 59s | the patch passed | | +1 :green_heart: | javac | 0m 59s | the patch passed | | +1 :green_heart: | shadedjars | 4m 44s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 35s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 65m 0s | hbase-server in the patch passed. | | | | 90m 59s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1402/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1402 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux a07d51b584a8 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6f213e9d5a | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1402/1/testReport/ | | Max. process+thread count | 6081 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1402/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1403: HBASE-24051 Allows indirect inheritance to CanUnbuffer
Apache-HBase commented on issue #1403: HBASE-24051 Allows indirect inheritance to CanUnbuffer URL: https://github.com/apache/hbase/pull/1403#issuecomment-607009821 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 55s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 11s | master passed | | +1 :green_heart: | checkstyle | 1m 17s | master passed | | +1 :green_heart: | spotbugs | 2m 23s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 39s | the patch passed | | -0 :warning: | checkstyle | 1m 15s | hbase-server: The patch generated 38 new + 7 unchanged - 0 fixed = 45 total (was 7) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 53s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 2m 19s | the patch passed | ||| _ Other Tests _ | | -1 :x: | asflicense | 0m 13s | The patch generated 1 ASF License warnings. | | | | 41m 41s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1403/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1403 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 7b9277bc1abf 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6f213e9d5a | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1403/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | asflicense | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1403/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt | | Max. process+thread count | 83 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1403/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] shenshengli opened a new pull request #1404: HBASE-24051 Allows indirect inheritance to CanUnbuffer
shenshengli opened a new pull request #1404: HBASE-24051 Allows indirect inheritance to CanUnbuffer URL: https://github.com/apache/hbase/pull/1404 If you have an inherited parent class that implements CanUnbuffer instead of directly implementing CanUnbuffer, you cannot get unbuffer This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1403: HBASE-24051 Allows indirect inheritance to CanUnbuffer
Apache-HBase commented on issue #1403: HBASE-24051 Allows indirect inheritance to CanUnbuffer URL: https://github.com/apache/hbase/pull/1403#issuecomment-607007865 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 55s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 12s | master passed | | +1 :green_heart: | compile | 1m 4s | master passed | | +1 :green_heart: | shadedjars | 5m 22s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 45s | the patch passed | | +1 :green_heart: | compile | 1m 3s | the patch passed | | +1 :green_heart: | javac | 1m 3s | the patch passed | | -1 :x: | shadedjars | 4m 15s | patch has 10 errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 6m 33s | hbase-server in the patch failed. | | | | 34m 35s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1403/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1403 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux c83a4f5118a9 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6f213e9d5a | | Default Java | 1.8.0_232 | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1403/1/artifact/yetus-jdk8-hadoop2-check/output/patch-shadedjars.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1403/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1403/1/testReport/ | | Max. process+thread count | 575 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1403/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1403: HBASE-24051 Allows indirect inheritance to CanUnbuffer
Apache-HBase commented on issue #1403: HBASE-24051 Allows indirect inheritance to CanUnbuffer URL: https://github.com/apache/hbase/pull/1403#issuecomment-607007480 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 17s | master passed | | +1 :green_heart: | compile | 1m 8s | master passed | | +1 :green_heart: | shadedjars | 5m 39s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 41s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 0s | the patch passed | | +1 :green_heart: | compile | 1m 7s | the patch passed | | +1 :green_heart: | javac | 1m 7s | the patch passed | | -1 :x: | shadedjars | 4m 43s | patch has 10 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 39s | hbase-server in the patch failed. | ||| _ Other Tests _ | | -0 :warning: | unit | 4m 59s | hbase-server in the patch failed. | | | | 33m 5s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1403/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1403 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 06ce43573942 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6f213e9d5a | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1403/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1403/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1403/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1403/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1403/1/testReport/ | | Max. process+thread count | 801 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1403/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] shenshengli closed pull request #1403: HBASE-24051 Allows indirect inheritance to CanUnbuffer
shenshengli closed pull request #1403: HBASE-24051 Allows indirect inheritance to CanUnbuffer URL: https://github.com/apache/hbase/pull/1403 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] shenshengli edited a comment on issue #1370: HBASE-24053 Correct some errors to make it available in hbase2
shenshengli edited a comment on issue #1370: HBASE-24053 Correct some errors to make it available in hbase2 URL: https://github.com/apache/hbase/pull/1370#issuecomment-606981005 I didn't test the master branch, and my test environment was version 2.0.1, I don't think the script changes will involve much. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1402: HBASE-24096 Fix TestRSGroupsBalance
Apache-HBase commented on issue #1402: HBASE-24096 Fix TestRSGroupsBalance URL: https://github.com/apache/hbase/pull/1402#issuecomment-607003294 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 42s | master passed | | +1 :green_heart: | checkstyle | 1m 14s | master passed | | +1 :green_heart: | spotbugs | 2m 12s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 29s | the patch passed | | +1 :green_heart: | checkstyle | 1m 14s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 10m 28s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 2m 11s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. | | | | 36m 18s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1402/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1402 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 37a63d6f3870 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6f213e9d5a | | Max. process+thread count | 93 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1402/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-8458) Support for batch version of checkAndPut() and checkAndDelete()
[ https://issues.apache.org/jira/browse/HBASE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki updated HBASE-8458: Affects Version/s: (was: 0.95.0) > Support for batch version of checkAndPut() and checkAndDelete() > --- > > Key: HBASE-8458 > URL: https://issues.apache.org/jira/browse/HBASE-8458 > Project: HBase > Issue Type: New Feature > Components: Client, regionserver >Reporter: Hari Mankude >Assignee: Toshihiro Suzuki >Priority: Major > Fix For: 3.0.0, 2.4.0 > > > The use case is that the user has multiple threads loading hundreds of keys > into a hbase table. Occasionally there are collisions in the keys being > uploaded by different threads. So for correctness, it is required to do > checkAndPut() instead of a put(). However, doing a checkAndPut() rpc for > every key update is non optimal. It would be good to have a batch version of > checkAndPut() similar to batch put(). The client can partition the keys on > region boundaries. > The jira is NOT looking for any type of cross-row locking or multi-row > atomicity with checkAndPut() > Batch version of checkAndDelete() is a similar requirement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-8458) Support for batch version of checkAndPut() and checkAndDelete()
[ https://issues.apache.org/jira/browse/HBASE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki updated HBASE-8458: Issue Type: New Feature (was: Improvement) > Support for batch version of checkAndPut() and checkAndDelete() > --- > > Key: HBASE-8458 > URL: https://issues.apache.org/jira/browse/HBASE-8458 > Project: HBase > Issue Type: New Feature > Components: Client, regionserver >Affects Versions: 0.95.0 >Reporter: Hari Mankude >Assignee: Toshihiro Suzuki >Priority: Major > Fix For: 3.0.0, 2.4.0 > > > The use case is that the user has multiple threads loading hundreds of keys > into a hbase table. Occasionally there are collisions in the keys being > uploaded by different threads. So for correctness, it is required to do > checkAndPut() instead of a put(). However, doing a checkAndPut() rpc for > every key update is non optimal. It would be good to have a batch version of > checkAndPut() similar to batch put(). The client can partition the keys on > region boundaries. > The jira is NOT looking for any type of cross-row locking or multi-row > atomicity with checkAndPut() > Batch version of checkAndDelete() is a similar requirement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Reidddddd commented on issue #1402: HBASE-24096 Fix TestRSGroupsBalance
Reidd commented on issue #1402: HBASE-24096 Fix TestRSGroupsBalance URL: https://github.com/apache/hbase/pull/1402#issuecomment-606998065 Oh, get it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-8458) Support for batch version of checkAndPut() and checkAndDelete()
[ https://issues.apache.org/jira/browse/HBASE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072324#comment-17072324 ] Toshihiro Suzuki commented on HBASE-8458: - [~stack] [~ndimiduk] Thank you for the confirmation. I made its target versions to 3.0 and 2.4. Thanks. > Support for batch version of checkAndPut() and checkAndDelete() > --- > > Key: HBASE-8458 > URL: https://issues.apache.org/jira/browse/HBASE-8458 > Project: HBase > Issue Type: Improvement > Components: Client, regionserver >Affects Versions: 0.95.0 >Reporter: Hari Mankude >Assignee: Toshihiro Suzuki >Priority: Major > Fix For: 3.0.0, 2.4.0 > > > The use case is that the user has multiple threads loading hundreds of keys > into a hbase table. Occasionally there are collisions in the keys being > uploaded by different threads. So for correctness, it is required to do > checkAndPut() instead of a put(). However, doing a checkAndPut() rpc for > every key update is non optimal. It would be good to have a batch version of > checkAndPut() similar to batch put(). The client can partition the keys on > region boundaries. > The jira is NOT looking for any type of cross-row locking or multi-row > atomicity with checkAndPut() > Batch version of checkAndDelete() is a similar requirement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] binlijin commented on issue #1402: HBASE-24096 Fix TestRSGroupsBalance
binlijin commented on issue #1402: HBASE-24096 Fix TestRSGroupsBalance URL: https://github.com/apache/hbase/pull/1402#issuecomment-606997710 If we return "default", we will not fall back to namespace as rsgroup if exists. @Reidd " // Finally, we will try to fall back to namespace as rsgroup if exists " This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] shenshengli opened a new pull request #1403: Shenshengli patch n hbase 24051
shenshengli opened a new pull request #1403: Shenshengli patch n hbase 24051 URL: https://github.com/apache/hbase/pull/1403 If you have an inherited parent class that implements CanUnbuffer instead of directly implementing CanUnbuffer, you cannot get unbuffer This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-8458) Support for batch version of checkAndPut() and checkAndDelete()
[ https://issues.apache.org/jira/browse/HBASE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki updated HBASE-8458: Fix Version/s: 2.4.0 3.0.0 > Support for batch version of checkAndPut() and checkAndDelete() > --- > > Key: HBASE-8458 > URL: https://issues.apache.org/jira/browse/HBASE-8458 > Project: HBase > Issue Type: Improvement > Components: Client, regionserver >Affects Versions: 0.95.0 >Reporter: Hari Mankude >Assignee: Toshihiro Suzuki >Priority: Major > Fix For: 3.0.0, 2.4.0 > > > The use case is that the user has multiple threads loading hundreds of keys > into a hbase table. Occasionally there are collisions in the keys being > uploaded by different threads. So for correctness, it is required to do > checkAndPut() instead of a put(). However, doing a checkAndPut() rpc for > every key update is non optimal. It would be good to have a batch version of > checkAndPut() similar to batch put(). The client can partition the keys on > region boundaries. > The jira is NOT looking for any type of cross-row locking or multi-row > atomicity with checkAndPut() > Batch version of checkAndDelete() is a similar requirement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Reidddddd commented on issue #1402: HBASE-24096 Fix TestRSGroupsBalance
Reidd commented on issue #1402: HBASE-24096 Fix TestRSGroupsBalance URL: https://github.com/apache/hbase/pull/1402#issuecomment-606997233 May I ask what will happen when returning "default" in TestRSGroupsBalance This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] binlijin commented on issue #1402: HBASE-24096 Fix TestRSGroupsBalance
binlijin commented on issue #1402: HBASE-24096 Fix TestRSGroupsBalance URL: https://github.com/apache/hbase/pull/1402#issuecomment-606992735 if hbase.rsgroup.table.mapping.script not set, we should not return DEFAULT_GROUP... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] binlijin opened a new pull request #1402: HBASE-24096 Fix TestRSGroupsBalance
binlijin opened a new pull request #1402: HBASE-24096 Fix TestRSGroupsBalance URL: https://github.com/apache/hbase/pull/1402 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-24096) Fix TestRSGroupsBalance
Lijin Bin created HBASE-24096: - Summary: Fix TestRSGroupsBalance Key: HBASE-24096 URL: https://issues.apache.org/jira/browse/HBASE-24096 Project: HBase Issue Type: Bug Reporter: Lijin Bin Assignee: Lijin Bin run TestRSGroupsBalance failed, after debug into it, it related to HBASE-24032. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] shenshengli commented on issue #1370: HBASE-24053 Correct some errors to make it available in hbase2
shenshengli commented on issue #1370: HBASE-24053 Correct some errors to make it available in hbase2 URL: https://github.com/apache/hbase/pull/1370#issuecomment-606981005 > 我尝试运行区域脚本并得到以下信息： > > ``` > ^[[ONameError: uninitialized constant IOException > Did you mean? Exception > const_missing at org/jruby/RubyModule.java:3372 > block in ./bin/region_status.rb at ./bin/region_status.rb:105 > loop at org/jruby/RubyKernel.java:1316 > at ./bin/region_status.rb:100 > ``` > > 让我测试w /补丁到位。 > > 这是用于master分支和branch-2吗？ > 我尝试运行区域脚本并得到以下信息： > > ``` > ^[[ONameError: uninitialized constant IOException > Did you mean? Exception > const_missing at org/jruby/RubyModule.java:3372 > block in ./bin/region_status.rb at ./bin/region_status.rb:105 > loop at org/jruby/RubyKernel.java:1316 > at ./bin/region_status.rb:100 > ``` > > 让我测试w /补丁到位。 > > 这是用于master分支和branch-2吗？ I didn't test the master branch, and my test environment was version 2.0.1, I don't think the script changes will involve much. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1401: HBASE-24075: Fix a race between master shutdown and metrics (re)init
Apache-HBase commented on issue #1401: HBASE-24075: Fix a race between master shutdown and metrics (re)init URL: https://github.com/apache/hbase/pull/1401#issuecomment-606975119 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 35s | branch-2 passed | | +1 :green_heart: | compile | 1m 31s | branch-2 passed | | +1 :green_heart: | shadedjars | 4m 32s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 8s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 17s | the patch passed | | +1 :green_heart: | compile | 1m 30s | the patch passed | | +1 :green_heart: | javac | 1m 30s | the patch passed | | +1 :green_heart: | shadedjars | 4m 28s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 5s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 26s | hbase-hadoop-compat in the patch passed. | | -1 :x: | unit | 0m 22s | hbase-hadoop2-compat in the patch failed. | | +1 :green_heart: | unit | 66m 41s | hbase-server in the patch passed. | | | | 96m 30s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1401/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1401 | | JIRA Issue | HBASE-24075 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 8486fa28707d 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / c5a3ab7504 | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1401/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-hadoop2-compat.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1401/1/testReport/ | | Max. process+thread count | 5778 (vs. ulimit of 1) | | modules | C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1401/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1401: HBASE-24075: Fix a race between master shutdown and metrics (re)init
Apache-HBase commented on issue #1401: HBASE-24075: Fix a race between master shutdown and metrics (re)init URL: https://github.com/apache/hbase/pull/1401#issuecomment-606962122 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 7m 6s | branch-2 passed | | +1 :green_heart: | compile | 1m 46s | branch-2 passed | | +1 :green_heart: | shadedjars | 5m 51s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 18s | hbase-hadoop2-compat in branch-2 failed. | | -0 :warning: | javadoc | 0m 16s | hbase-hadoop-compat in branch-2 failed. | | -0 :warning: | javadoc | 0m 42s | hbase-server in branch-2 failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 6m 55s | the patch passed | | +1 :green_heart: | compile | 1m 48s | the patch passed | | +1 :green_heart: | javac | 1m 48s | the patch passed | | +1 :green_heart: | shadedjars | 5m 53s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 16s | hbase-hadoop-compat in the patch failed. | | -0 :warning: | javadoc | 0m 16s | hbase-hadoop2-compat in the patch failed. | | -0 :warning: | javadoc | 0m 40s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 27s | hbase-hadoop-compat in the patch passed. | | +1 :green_heart: | unit | 0m 29s | hbase-hadoop2-compat in the patch passed. | | -0 :warning: | unit | 7m 29s | hbase-server in the patch failed. | | | | 44m 57s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1401/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1401 | | JIRA Issue | HBASE-24075 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 6a968935963f 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / c5a3ab7504 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1401/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-hadoop2-compat.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1401/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-hadoop-compat.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1401/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1401/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-hadoop-compat.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1401/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-hadoop2-compat.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1401/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1401/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1401/1/testReport/ | | Max. process+thread count | 547 (vs. ulimit of 1) | | modules | C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1401/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1401: HBASE-24075: Fix a race between master shutdown and metrics (re)init
Apache-HBase commented on issue #1401: HBASE-24075: Fix a race between master shutdown and metrics (re)init URL: https://github.com/apache/hbase/pull/1401#issuecomment-606961795 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 6m 50s | branch-2 passed | | +1 :green_heart: | checkstyle | 1m 42s | branch-2 passed | | +1 :green_heart: | spotbugs | 2m 58s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 36s | the patch passed | | +1 :green_heart: | checkstyle | 1m 37s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 25s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 3m 26s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 31s | The patch does not generate ASF License warnings. | | | | 42m 47s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1401/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1401 | | JIRA Issue | HBASE-24075 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux b4480a54ca74 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / c5a3ab7504 | | Max. process+thread count | 83 (vs. ulimit of 1) | | modules | C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1401/1/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1189: HBASE-23842 Removed deprecated Scan(byte[], byte[]) from Scan
Apache-HBase commented on issue #1189: HBASE-23842 Removed deprecated Scan(byte[], byte[]) from Scan URL: https://github.com/apache/hbase/pull/1189#issuecomment-606958995 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 16s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 31s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 7m 59s | master passed | | +1 :green_heart: | compile | 4m 47s | master passed | | +1 :green_heart: | shadedjars | 6m 58s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 35s | hbase-client in master failed. | | -0 :warning: | javadoc | 0m 25s | hbase-mapreduce in master failed. | | -0 :warning: | javadoc | 0m 25s | hbase-rest in master failed. | | -0 :warning: | javadoc | 0m 51s | hbase-server in master failed. | | -0 :warning: | javadoc | 1m 6s | hbase-thrift in master failed. | | -0 :warning: | patch | 11m 54s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 6m 54s | the patch passed | | +1 :green_heart: | compile | 4m 21s | the patch passed | | +1 :green_heart: | javac | 4m 21s | the patch passed | | +1 :green_heart: | shadedjars | 6m 13s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 25s | hbase-client in the patch failed. | | -0 :warning: | javadoc | 0m 40s | hbase-server in the patch failed. | | -0 :warning: | javadoc | 0m 19s | hbase-mapreduce in the patch failed. | | -0 :warning: | javadoc | 0m 59s | hbase-thrift in the patch failed. | | -0 :warning: | javadoc | 0m 19s | hbase-rest in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 8s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 99m 28s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 14m 48s | hbase-mapreduce in the patch passed. | | +1 :green_heart: | unit | 3m 26s | hbase-thrift in the patch passed. | | +1 :green_heart: | unit | 7m 15s | hbase-shell in the patch passed. | | +1 :green_heart: | unit | 3m 1s | hbase-endpoint in the patch passed. | | +1 :green_heart: | unit | 3m 3s | hbase-rest in the patch passed. | | | | 181m 50s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1189/10/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1189 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux b0c904ece0fc 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e5a8435b48 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1189/10/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1189/10/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1189/10/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1189/10/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1189/10/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1189/10/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1189/10/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1189/10/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt | | jav
[GitHub] [hbase] Apache-HBase commented on issue #1189: HBASE-23842 Removed deprecated Scan(byte[], byte[]) from Scan
Apache-HBase commented on issue #1189: HBASE-23842 Removed deprecated Scan(byte[], byte[]) from Scan URL: https://github.com/apache/hbase/pull/1189#issuecomment-606954858 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 19s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 34s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 55s | master passed | | +1 :green_heart: | compile | 3m 45s | master passed | | +1 :green_heart: | shadedjars | 5m 16s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 27s | master passed | | -0 :warning: | patch | 8m 44s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 33s | the patch passed | | +1 :green_heart: | compile | 3m 41s | the patch passed | | +1 :green_heart: | javac | 3m 41s | the patch passed | | +1 :green_heart: | shadedjars | 5m 16s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 26s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 55s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 99m 4s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 11m 3s | hbase-mapreduce in the patch passed. | | +1 :green_heart: | unit | 2m 50s | hbase-thrift in the patch passed. | | +1 :green_heart: | unit | 7m 14s | hbase-shell in the patch passed. | | +1 :green_heart: | unit | 2m 54s | hbase-endpoint in the patch passed. | | +1 :green_heart: | unit | 3m 47s | hbase-rest in the patch passed. | | | | 167m 3s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1189/10/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1189 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 2e20cdce1053 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e5a8435b48 | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1189/10/testReport/ | | Max. process+thread count | 6021 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-endpoint hbase-rest U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1189/10/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1188: HBASE-23843 Removed deprecated Scan(byte[]) from Scan
Apache-HBase commented on issue #1188: HBASE-23843 Removed deprecated Scan(byte[]) from Scan URL: https://github.com/apache/hbase/pull/1188#issuecomment-606952761 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 34s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 6m 51s | master passed | | +1 :green_heart: | compile | 4m 21s | master passed | | +1 :green_heart: | shadedjars | 6m 13s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 26s | hbase-client in master failed. | | -0 :warning: | javadoc | 0m 18s | hbase-examples in master failed. | | -0 :warning: | javadoc | 0m 20s | hbase-mapreduce in master failed. | | -0 :warning: | javadoc | 0m 19s | hbase-rest in master failed. | | -0 :warning: | javadoc | 0m 41s | hbase-server in master failed. | | -0 :warning: | javadoc | 0m 57s | hbase-thrift in master failed. | | -0 :warning: | patch | 10m 28s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 6m 35s | the patch passed | | +1 :green_heart: | compile | 4m 23s | the patch passed | | +1 :green_heart: | javac | 4m 23s | the patch passed | | +1 :green_heart: | shadedjars | 6m 6s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 25s | hbase-client in the patch failed. | | -0 :warning: | javadoc | 0m 41s | hbase-server in the patch failed. | | -0 :warning: | javadoc | 0m 19s | hbase-mapreduce in the patch failed. | | -0 :warning: | javadoc | 0m 57s | hbase-thrift in the patch failed. | | -0 :warning: | javadoc | 0m 20s | hbase-rest in the patch failed. | | -0 :warning: | javadoc | 0m 18s | hbase-examples in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 8s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 98m 11s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 13m 56s | hbase-mapreduce in the patch passed. | | +1 :green_heart: | unit | 2m 25s | hbase-thrift in the patch passed. | | +1 :green_heart: | unit | 7m 15s | hbase-shell in the patch passed. | | +1 :green_heart: | unit | 3m 24s | hbase-rest in the patch passed. | | +1 :green_heart: | unit | 1m 44s | hbase-examples in the patch passed. | | | | 173m 3s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/8/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1188 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux b2b0b0d21e00 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e5a8435b48 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/8/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/8/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-examples.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/8/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/8/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/8/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/8/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/8/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt | | javadoc | https:/
[GitHub] [hbase] Apache-HBase commented on issue #1188: HBASE-23843 Removed deprecated Scan(byte[]) from Scan
Apache-HBase commented on issue #1188: HBASE-23843 Removed deprecated Scan(byte[]) from Scan URL: https://github.com/apache/hbase/pull/1188#issuecomment-606948695 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 31s | master passed | | +1 :green_heart: | compile | 3m 45s | master passed | | +1 :green_heart: | shadedjars | 5m 11s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 31s | master passed | | -0 :warning: | patch | 8m 41s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 29s | the patch passed | | +1 :green_heart: | compile | 3m 44s | the patch passed | | +1 :green_heart: | javac | 3m 44s | the patch passed | | +1 :green_heart: | shadedjars | 5m 12s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 30s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 55s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 95m 30s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 10m 54s | hbase-mapreduce in the patch passed. | | +1 :green_heart: | unit | 2m 33s | hbase-thrift in the patch passed. | | +1 :green_heart: | unit | 7m 3s | hbase-shell in the patch passed. | | +1 :green_heart: | unit | 3m 27s | hbase-rest in the patch passed. | | +1 :green_heart: | unit | 1m 34s | hbase-examples in the patch passed. | | | | 159m 58s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/8/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1188 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 92874925a456 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e5a8435b48 | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/8/testReport/ | | Max. process+thread count | 5832 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-rest hbase-examples U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/8/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-24095) HBase Bad Substitution ERROR on hadoop-functions.sh
Alex Swarner created HBASE-24095: Summary: HBase Bad Substitution ERROR on hadoop-functions.sh Key: HBASE-24095 URL: https://issues.apache.org/jira/browse/HBASE-24095 Project: HBase Issue Type: Bug Components: hadoop3 Affects Versions: 2.2.3 Environment: hbase 2.2.3 with hadoop 3.2.1: Installed both hadoop and hbase according the apache "Getting Started" guides. for hbase, i have removed the hadoop jar files it downloaded with, which do not match my current version of hadoop, as per the documentation. Reporter: Alex Swarner Any Time i make a call to hbase (e.g. "hbase version" or "hbase-daemon.sh start master", i receive this error message: */usr/hdeco/hadoop/bin/../libexec/hadoop-functions.sh: line 2366: HADOOP_ORG.APACHE.HADOOP.HBASE.UTIL.GETJAVAPROPERTY_USER: bad substitution* */usr/hdeco/hadoop/bin/../libexec/hadoop-functions.sh: line 2461: HADOOP_ORG.APACHE.HADOOP.HBASE.UTIL.GETJAVAPROPERTY_OPTS: bad substitution* "hbase version" does provide version information after this error message, but i am unable to start the hbase master, so i am unable to use hbase further. I have never posted in any forum before, so let me know if more information is needed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] bharathv opened a new pull request #1401: HBASE-24075: Fix a race between master shutdown and metrics (re)init
bharathv opened a new pull request #1401: HBASE-24075: Fix a race between master shutdown and metrics (re)init URL: https://github.com/apache/hbase/pull/1401 JMXCacheBuster resets the metrics state at various points in time. These events can potentially race with a master shutdown. When the master is tearing down, metrics initialization can touch a lot of unsafe state, for example invalidated FS objects. To avoid this, this patch makes the getMetrics() a no-op when the master is either stopped or in the process of shutting down. Additionally, getClusterId() when the server is shutting down is made a no-op. Simulating a test for this is a bit tricky but with the patch I don't locally see the long stacktraces from the jira. Signed-off-by: Michael Stack (cherry picked from commit 6f213e9d5a15afcc40b6562ab4898f913cec91eb) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-23992) Fix TestAdminShell and TestQuotasShell mistakenly broken by parent commit
[
https://issues.apache.org/jira/browse/HBASE-23992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072250#comment-17072250
]
Hudson commented on HBASE-23992:
Results for branch branch-2.2
[build #829 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/829/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/829//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/829//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/829//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Fix TestAdminShell and TestQuotasShell mistakenly broken by parent commit
> -
>
> Key: HBASE-23992
> URL: https://issues.apache.org/jira/browse/HBASE-23992
> Project: HBase
> Issue Type: Sub-task
> Components: test
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Trivial
> Fix For: 3.0.0, 2.3.0, 2.2.5
>
> Attachments:
> 0001-HBASE-23992-Fix-TestAdminShell-and-TestQuotasShell-m.patch, Screen Shot
> 2020-03-14 at 3.05.31 PM.png, Screen Shot 2020-03-15 at 12.18.57 PM.png
>
>
> Minor fix...
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24086) master fails to becomeActive running out of source repo
[
https://issues.apache.org/jira/browse/HBASE-24086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072249#comment-17072249
]
Bharath Vissapragada commented on HBASE-24086:
--
Just curious, did you set the following config in hdfs-site and it still
doesn't work? https://hbase.apache.org/book.html#quickstart
{noformat}
hbase.unsafe.stream.capability.enforce
false
..
{noformat}
> master fails to becomeActive running out of source repo
> ---
>
> Key: HBASE-24086
> URL: https://issues.apache.org/jira/browse/HBASE-24086
> Project: HBase
> Issue Type: Bug
> Components: master
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Nick Dimiduk
>Priority: Major
>
> {noformat}
> $
> JAVA_HOME=/Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home
> mvn clean install -DskipTests
> $
> JAVA_HOME=/Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home
> ./bin/hbase master start
> {noformat}
> gives
> {noformat}
> 2020-03-30 17:12:43,857 ERROR
> [master/192.168.111.13:16000:becomeActiveMaster] master.HMaster: Failed to
> become active master
>
> java.io.IOException: cannot get log writer
>
>
> at
> org.apache.hadoop.hbase.wal.AsyncFSWALProvider.createAsyncWriter(AsyncFSWALProvider.java:118)
>
>
> at
> org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createAsyncWriter(AsyncFSWAL.java:704)
>
>
> at
> org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createWriterInstance(AsyncFSWAL.java:710)
>
>
> at
> org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createWriterInstance(AsyncFSWAL.java:128)
>
>
> at
> org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.rollWriter(AbstractFSWAL.java:839)
>
>
> at
> org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.rollWriter(AbstractFSWAL.java:549)
>
>
> at
> org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.init(AbstractFSWAL.java:490)
>
>
> at
> org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:156)
>
>
> at
> org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:61)
>
>
> at org.apache.hadoop.hbase.wal.WALFactory.getWAL(WALFactory.java:297)
>
>
> at
> org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.createWAL(RegionProcedureStore.java:256)
>
>
> at
> org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.bootstrap(RegionProcedureStore.java:273)
>
>
> at
> org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.recoverLease(RegionProcedureStore.java:482)
>
>
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.init(ProcedureExecutor.java:587)
>
>
> at
> org.apache.hadoop.hbase.master.HMaster.createProcedureExecutor(HMaster.java:1575)
>
>
> at
> org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:961)
>
[GitHub] [hbase] bharathv merged pull request #1394: HBASE-24075: Fix a race between master shutdown and metrics (re)init
bharathv merged pull request #1394: HBASE-24075: Fix a race between master shutdown and metrics (re)init URL: https://github.com/apache/hbase/pull/1394 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-24086) master fails to becomeActive running out of source repo
[
https://issues.apache.org/jira/browse/HBASE-24086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072236#comment-17072236
]
Nick Dimiduk commented on HBASE-24086:
--
Git bisect fingers HBASE-23986, but if I build known "good" shas with
{{-Dhadoop-two.version=2.10.0}}, this has been broken for a long while.
> master fails to becomeActive running out of source repo
> ---
>
> Key: HBASE-24086
> URL: https://issues.apache.org/jira/browse/HBASE-24086
> Project: HBase
> Issue Type: Bug
> Components: master
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Nick Dimiduk
>Priority: Major
>
> {noformat}
> $
> JAVA_HOME=/Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home
> mvn clean install -DskipTests
> $
> JAVA_HOME=/Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home
> ./bin/hbase master start
> {noformat}
> gives
> {noformat}
> 2020-03-30 17:12:43,857 ERROR
> [master/192.168.111.13:16000:becomeActiveMaster] master.HMaster: Failed to
> become active master
>
> java.io.IOException: cannot get log writer
>
>
> at
> org.apache.hadoop.hbase.wal.AsyncFSWALProvider.createAsyncWriter(AsyncFSWALProvider.java:118)
>
>
> at
> org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createAsyncWriter(AsyncFSWAL.java:704)
>
>
> at
> org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createWriterInstance(AsyncFSWAL.java:710)
>
>
> at
> org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createWriterInstance(AsyncFSWAL.java:128)
>
>
> at
> org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.rollWriter(AbstractFSWAL.java:839)
>
>
> at
> org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.rollWriter(AbstractFSWAL.java:549)
>
>
> at
> org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.init(AbstractFSWAL.java:490)
>
>
> at
> org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:156)
>
>
> at
> org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:61)
>
>
> at org.apache.hadoop.hbase.wal.WALFactory.getWAL(WALFactory.java:297)
>
>
> at
> org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.createWAL(RegionProcedureStore.java:256)
>
>
> at
> org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.bootstrap(RegionProcedureStore.java:273)
>
>
> at
> org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.recoverLease(RegionProcedureStore.java:482)
>
>
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.init(ProcedureExecutor.java:587)
>
>
> at
> org.apache.hadoop.hbase.master.HMaster.createProcedureExecutor(HMaster.java:1575)
>
>
> at
> org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:961)
>
>
> at
> org.apache
[jira] [Issue Comment Deleted] (HBASE-24084) master fails to start out of binary tarball
[
https://issues.apache.org/jira/browse/HBASE-24084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-24084:
-
Comment: was deleted
(was: Git bisect fingers HBASE-23986, but if I build known "good" shas with
{{-Dhadoop-two.version=2.10.0}}, this has been broken for a long while.)
> master fails to start out of binary tarball
> ---
>
> Key: HBASE-24084
> URL: https://issues.apache.org/jira/browse/HBASE-24084
> Project: HBase
> Issue Type: Bug
> Components: build, master
>Affects Versions: 3.0.0
>Reporter: Nick Dimiduk
>Priority: Major
>
> Trying to launch a standalone master out of binary tarball, doesn't start.
> {noformat}
> $
> JAVA_HOME=/Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home
> ~/tmp/packaging_and_integration/hbase-install/bin/hbase master start
> 2020-03-30 17:14:21,831 INFO [main] master.HMaster: STARTING service HMaster
> 2020-03-30 17:14:21,833 INFO [main] util.VersionInfo: HBase 3.0.0-SNAPSHOT
> 2020-03-30 17:14:21,833 INFO [main] util.VersionInfo: Source code repository
> file:///Users/ndimiduk/tmp/packaging_and_integration/unpacked_src_tarball
> revision=Unknown
> 2020-03-30 17:14:21,833 INFO [main] util.VersionInfo: Compiled by ndimiduk
> on Mon Mar 30 14:59:17 PDT 2020
> 2020-03-30 17:14:21,833 INFO [main] util.VersionInfo: From source with
> checksum
> c13d259fe1832de6fef3f5d192e6651d3ca0b52599c64ef19eaa87c6bdbd3956cc51fda3c3dc917b47add5a633c9058a6968df24ddce88f85c345681763cd568
> Exception in thread "main" java.lang.NoClassDefFoundError:
> com/ctc/wstx/io/InputBootstrapper
> at
> org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:149)
> at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:3062)
> Caused by: java.lang.ClassNotFoundException: com.ctc.wstx.io.InputBootstrapper
> at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:349)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
> ... 2 more
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24084) master fails to start out of binary tarball
[
https://issues.apache.org/jira/browse/HBASE-24084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072235#comment-17072235
]
Nick Dimiduk commented on HBASE-24084:
--
Git bisect fingers HBASE-23986, but if I build known "good" shas with
{{-Dhadoop-two.version=2.10.0}}, this has been broken for a long while.
> master fails to start out of binary tarball
> ---
>
> Key: HBASE-24084
> URL: https://issues.apache.org/jira/browse/HBASE-24084
> Project: HBase
> Issue Type: Bug
> Components: build, master
>Affects Versions: 3.0.0
>Reporter: Nick Dimiduk
>Priority: Major
>
> Trying to launch a standalone master out of binary tarball, doesn't start.
> {noformat}
> $
> JAVA_HOME=/Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home
> ~/tmp/packaging_and_integration/hbase-install/bin/hbase master start
> 2020-03-30 17:14:21,831 INFO [main] master.HMaster: STARTING service HMaster
> 2020-03-30 17:14:21,833 INFO [main] util.VersionInfo: HBase 3.0.0-SNAPSHOT
> 2020-03-30 17:14:21,833 INFO [main] util.VersionInfo: Source code repository
> file:///Users/ndimiduk/tmp/packaging_and_integration/unpacked_src_tarball
> revision=Unknown
> 2020-03-30 17:14:21,833 INFO [main] util.VersionInfo: Compiled by ndimiduk
> on Mon Mar 30 14:59:17 PDT 2020
> 2020-03-30 17:14:21,833 INFO [main] util.VersionInfo: From source with
> checksum
> c13d259fe1832de6fef3f5d192e6651d3ca0b52599c64ef19eaa87c6bdbd3956cc51fda3c3dc917b47add5a633c9058a6968df24ddce88f85c345681763cd568
> Exception in thread "main" java.lang.NoClassDefFoundError:
> com/ctc/wstx/io/InputBootstrapper
> at
> org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:149)
> at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:3062)
> Caused by: java.lang.ClassNotFoundException: com.ctc.wstx.io.InputBootstrapper
> at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:349)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
> ... 2 more
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1394: HBASE-24075: Fix a race between master shutdown and metrics (re)init
Apache-HBase commented on issue #1394: HBASE-24075: Fix a race between master shutdown and metrics (re)init URL: https://github.com/apache/hbase/pull/1394#issuecomment-606933826 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 55s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 43s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 52s | master passed | | +1 :green_heart: | compile | 3m 22s | master passed | | +1 :green_heart: | shadedjars | 5m 14s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 45s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 37s | the patch passed | | +1 :green_heart: | compile | 3m 16s | the patch passed | | +1 :green_heart: | javac | 3m 16s | the patch passed | | +1 :green_heart: | shadedjars | 5m 17s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 44s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 150m 38s | root in the patch passed. | | | | 193m 46s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1394/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1394 | | JIRA Issue | HBASE-24075 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 4e86c11cfa8e 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e5a8435b48 | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1394/2/testReport/ | | Max. process+thread count | 5926 (vs. ulimit of 1) | | modules | C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1394/2/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] bharathv commented on issue #1385: HBASE-24071 [JDK11] Remove `unit` filter from nightly and precommit jobs
bharathv commented on issue #1385: HBASE-24071 [JDK11] Remove `unit` filter from nightly and precommit jobs URL: https://github.com/apache/hbase/pull/1385#issuecomment-606922357 Yes sir. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1346: HBASE-23937 : Support Online LargeLogs similar to SlowLogs APIs
Apache-HBase commented on issue #1346: HBASE-23937 : Support Online LargeLogs similar to SlowLogs APIs URL: https://github.com/apache/hbase/pull/1346#issuecomment-606921255 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 7m 42s | master passed | | +1 :green_heart: | compile | 4m 6s | master passed | | +1 :green_heart: | shadedjars | 7m 24s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 31s | hbase-client in master failed. | | -0 :warning: | javadoc | 0m 47s | hbase-server in master failed. | | -0 :warning: | javadoc | 1m 6s | hbase-thrift in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 7m 47s | the patch passed | | +1 :green_heart: | compile | 4m 19s | the patch passed | | +1 :green_heart: | javac | 4m 19s | the patch passed | | +1 :green_heart: | shadedjars | 7m 18s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 29s | hbase-client in the patch failed. | | -0 :warning: | javadoc | 0m 49s | hbase-server in the patch failed. | | -0 :warning: | javadoc | 1m 1s | hbase-thrift in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 12s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 10s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 85m 4s | hbase-server in the patch passed. | | -0 :warning: | unit | 3m 4s | hbase-thrift in the patch failed. | | +1 :green_heart: | unit | 7m 15s | hbase-shell in the patch passed. | | | | 145m 59s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1346/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1346 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux baf1a5acc1c4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e5a8435b48 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1346/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1346/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1346/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1346/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1346/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1346/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1346/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-thrift.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1346/4/testReport/ | | Max. process+thread count | 5685 (vs. ulimit of 1) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1346/4/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@in
[GitHub] [hbase] ndimiduk commented on issue #1385: HBASE-24071 [JDK11] Remove `unit` filter from nightly and precommit jobs
ndimiduk commented on issue #1385: HBASE-24071 [JDK11] Remove `unit` filter from nightly and precommit jobs URL: https://github.com/apache/hbase/pull/1385#issuecomment-606920734 The -1 votes for failed unit test run on "2020-01-14", a.k.a. JDK11, demonstrates the patch works as intended. Good by you @bharathv ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1189: HBASE-23842 Removed deprecated Scan(byte[], byte[]) from Scan
Apache-HBase commented on issue #1189: HBASE-23842 Removed deprecated Scan(byte[], byte[]) from Scan URL: https://github.com/apache/hbase/pull/1189#issuecomment-606920442 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 45s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 6m 55s | master passed | | +1 :green_heart: | checkstyle | 3m 55s | master passed | | +1 :green_heart: | spotbugs | 7m 45s | master passed | | -0 :warning: | patch | 2m 34s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 6m 46s | the patch passed | | +1 :green_heart: | checkstyle | 0m 36s | The patch passed checkstyle in hbase-client | | +1 :green_heart: | checkstyle | 1m 29s | hbase-server: The patch generated 0 new + 365 unchanged - 83 fixed = 365 total (was 448) | | +1 :green_heart: | checkstyle | 0m 24s | The patch passed checkstyle in hbase-mapreduce | | +1 :green_heart: | checkstyle | 0m 50s | The patch passed checkstyle in hbase-thrift | | +1 :green_heart: | checkstyle | 0m 13s | The patch passed checkstyle in hbase-shell | | +1 :green_heart: | checkstyle | 0m 14s | The patch passed checkstyle in hbase-endpoint | | +1 :green_heart: | checkstyle | 0m 18s | The patch passed checkstyle in hbase-rest | | -0 :warning: | rubocop | 0m 8s | The patch generated 2 new + 109 unchanged - 2 fixed = 111 total (was 111) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 57s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 8m 49s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 1m 23s | The patch does not generate ASF License warnings. | | | | 63m 59s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1189/10/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1189 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle rubocop | | uname | Linux 46f071412ab6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e5a8435b48 | | rubocop | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1189/10/artifact/yetus-general-check/output/diff-patch-rubocop.txt | | Max. process+thread count | 94 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-endpoint hbase-rest U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1189/10/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 rubocop=0.80.0 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-8458) Support for batch version of checkAndPut() and checkAndDelete()
[ https://issues.apache.org/jira/browse/HBASE-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072215#comment-17072215 ] Nick Dimiduk commented on HBASE-8458: - At this point, I prefer we not land any new features into 2.3. Looks like it's a very popular feature though! > Support for batch version of checkAndPut() and checkAndDelete() > --- > > Key: HBASE-8458 > URL: https://issues.apache.org/jira/browse/HBASE-8458 > Project: HBase > Issue Type: Improvement > Components: Client, regionserver >Affects Versions: 0.95.0 >Reporter: Hari Mankude >Assignee: Toshihiro Suzuki >Priority: Major > > The use case is that the user has multiple threads loading hundreds of keys > into a hbase table. Occasionally there are collisions in the keys being > uploaded by different threads. So for correctness, it is required to do > checkAndPut() instead of a put(). However, doing a checkAndPut() rpc for > every key update is non optimal. It would be good to have a batch version of > checkAndPut() similar to batch put(). The client can partition the keys on > region boundaries. > The jira is NOT looking for any type of cross-row locking or multi-row > atomicity with checkAndPut() > Batch version of checkAndDelete() is a similar requirement. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1188: HBASE-23843 Removed deprecated Scan(byte[]) from Scan
Apache-HBase commented on issue #1188: HBASE-23843 Removed deprecated Scan(byte[]) from Scan URL: https://github.com/apache/hbase/pull/1188#issuecomment-606904895 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 11s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 33s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 46s | master passed | | +1 :green_heart: | checkstyle | 3m 34s | master passed | | +1 :green_heart: | spotbugs | 6m 44s | master passed | | -0 :warning: | patch | 2m 15s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 33s | the patch passed | | +1 :green_heart: | checkstyle | 3m 34s | the patch passed | | -0 :warning: | rubocop | 0m 6s | The patch generated 1 new + 110 unchanged - 1 fixed = 111 total (was 111) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 23s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 7m 45s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 1m 12s | The patch does not generate ASF License warnings. | | | | 55m 54s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/8/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1188 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle rubocop | | uname | Linux 5b9fba46afee 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e5a8435b48 | | rubocop | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/8/artifact/yetus-general-check/output/diff-patch-rubocop.txt | | Max. process+thread count | 83 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-rest hbase-examples U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/8/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 rubocop=0.80.0 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] xcangCRM commented on a change in pull request #1381: HBASE-23678 : Builder API for version management - setVersionsWithTim…
xcangCRM commented on a change in pull request #1381: HBASE-23678 : Builder API
for version management - setVersionsWithTim…
URL: https://github.com/apache/hbase/pull/1381#discussion_r401105409
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMinVersions.java
##
@@ -528,80 +530,147 @@ public void testMinVersionsWithKeepDeletedCellsTTL()
throws Exception {
int ttl = 4;
ColumnFamilyDescriptor cfd =
ColumnFamilyDescriptorBuilder.newBuilder(c0)
-
.setMinVersions(2).setMaxVersions(Integer.MAX_VALUE).setTimeToLive(ttl).
-setKeepDeletedCells(KeepDeletedCells.TTL).build();
+.setVersionsWithTimeToLive(ttl, 2).build();
+verifyVersionedCellKeyValues(ttl, cfd);
+
+cfd = ColumnFamilyDescriptorBuilder.newBuilder(c0)
+ .setMinVersions(2)
+ .setMaxVersions(Integer.MAX_VALUE)
+ .setTimeToLive(ttl)
+ .setKeepDeletedCells(KeepDeletedCells.TTL)
+ .build();
+verifyVersionedCellKeyValues(ttl, cfd);
+ }
+ private void verifyVersionedCellKeyValues(int ttl, ColumnFamilyDescriptor
cfd)
+ throws IOException {
TableDescriptor htd = TableDescriptorBuilder.
newBuilder(TableName.valueOf(name.getMethodName())).setColumnFamily(cfd).build();
HRegion region = hbu.createLocalHRegion(htd, null, null);
-long startTS = EnvironmentEdgeManager.currentTime();
-ManualEnvironmentEdge injectEdge = new ManualEnvironmentEdge();
-injectEdge.setValue(startTS);
-EnvironmentEdgeManager.injectEdge(injectEdge);
+try {
+ long startTS = EnvironmentEdgeManager.currentTime();
+ ManualEnvironmentEdge injectEdge = new ManualEnvironmentEdge();
+ injectEdge.setValue(startTS);
+ EnvironmentEdgeManager.injectEdge(injectEdge);
+
+ long ts = startTS - 2000;
+ putFourVersions(region, ts);
+
+ Get get;
+ Result result;
+
+ //check we can still see all versions before compaction
+ get = new Get(T1);
+ get.readAllVersions();
+ get.setTimeRange(0, ts);
+ result = region.get(get);
+ checkResult(result, c0, T4, T3, T2, T1);
+
+ region.flush(true);
+ region.compact(true);
+ Assert.assertEquals(startTS, EnvironmentEdgeManager.currentTime());
+ long expiredTime = EnvironmentEdgeManager.currentTime() - ts - 4;
+ Assert.assertTrue("TTL for T1 has expired", expiredTime < (ttl * 1000));
+ //check that nothing was purged yet
+ verifyBeforeCompaction(region, ts);
+
+ injectEdge.incValue(ttl * 1000);
+
+ region.flush(true);
+ region.compact(true);
+ verifyAfterTtl(region, ts);
+
Review comment:
extra space line
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1346: HBASE-23937 : Support Online LargeLogs similar to SlowLogs APIs
Apache-HBase commented on issue #1346: HBASE-23937 : Support Online LargeLogs similar to SlowLogs APIs URL: https://github.com/apache/hbase/pull/1346#issuecomment-606900592 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 34s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 18s | master passed | | +1 :green_heart: | compile | 3m 4s | master passed | | +1 :green_heart: | shadedjars | 4m 46s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 56s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 59s | the patch passed | | +1 :green_heart: | compile | 3m 7s | the patch passed | | +1 :green_heart: | javac | 3m 7s | the patch passed | | +1 :green_heart: | shadedjars | 4m 47s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 57s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 45s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 0m 51s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 65m 36s | hbase-server in the patch passed. | | -1 :x: | unit | 2m 30s | hbase-thrift in the patch failed. | | +1 :green_heart: | unit | 7m 11s | hbase-shell in the patch passed. | | | | 111m 7s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1346/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1346 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 6099aecb0b0e 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e5a8435b48 | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1346/4/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-thrift.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1346/4/testReport/ | | Max. process+thread count | 5690 (vs. ulimit of 1) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1346/4/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1394: HBASE-24075: Fix a race between master shutdown and metrics (re)init
Apache-HBase commented on issue #1394: HBASE-24075: Fix a race between master shutdown and metrics (re)init URL: https://github.com/apache/hbase/pull/1394#issuecomment-606896921 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 44s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 6m 8s | master passed | | +1 :green_heart: | compile | 3m 37s | master passed | | +1 :green_heart: | shadedjars | 5m 35s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 18s | hbase-hadoop-compat in master failed. | | -0 :warning: | javadoc | 0m 18s | hbase-hadoop2-compat in master failed. | | -0 :warning: | javadoc | 0m 18s | root in master failed. | | -0 :warning: | javadoc | 0m 40s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 49s | the patch passed | | +1 :green_heart: | compile | 3m 42s | the patch passed | | +1 :green_heart: | javac | 3m 42s | the patch passed | | +1 :green_heart: | shadedjars | 5m 29s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 17s | hbase-hadoop-compat in the patch failed. | | -0 :warning: | javadoc | 0m 17s | hbase-hadoop2-compat in the patch failed. | | -0 :warning: | javadoc | 0m 39s | hbase-server in the patch failed. | | -0 :warning: | javadoc | 0m 19s | root in the patch failed. | ||| _ Other Tests _ | | -0 :warning: | unit | 74m 59s | root in the patch failed. | | | | 113m 4s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1394/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1394 | | JIRA Issue | HBASE-24075 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux f57e4523f113 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e5a8435b48 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1394/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-hadoop-compat.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1394/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-hadoop2-compat.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1394/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1394/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1394/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-hadoop-compat.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1394/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-hadoop2-compat.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1394/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1394/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1394/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1394/2/testReport/ | | Max. process+thread count | 6781 (vs. ulimit of 1) | | modules | C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1394/2/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service.
[GitHub] [hbase] Apache-HBase commented on issue #1189: HBASE-23842 Removed deprecated Scan(byte[], byte[]) from Scan
Apache-HBase commented on issue #1189: HBASE-23842 Removed deprecated Scan(byte[], byte[]) from Scan URL: https://github.com/apache/hbase/pull/1189#issuecomment-606881594 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s | Docker mode activated. | | -1 :x: | patch | 0m 4s | https://github.com/apache/hbase/pull/1189 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. | | Subsystem | Report/Notes | |--:|:-| | GITHUB PR | https://github.com/apache/hbase/pull/1189 | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1189/9/console | | versions | git=2.17.1 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1189: HBASE-23842 Removed deprecated Scan(byte[], byte[]) from Scan
Apache-HBase commented on issue #1189: HBASE-23842 Removed deprecated Scan(byte[], byte[]) from Scan URL: https://github.com/apache/hbase/pull/1189#issuecomment-606881487 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s | Docker mode activated. | | -1 :x: | patch | 0m 3s | https://github.com/apache/hbase/pull/1189 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. | | Subsystem | Report/Notes | |--:|:-| | GITHUB PR | https://github.com/apache/hbase/pull/1189 | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1189/9/console | | versions | git=2.17.1 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1189: HBASE-23842 Removed deprecated Scan(byte[], byte[]) from Scan
Apache-HBase commented on issue #1189: HBASE-23842 Removed deprecated Scan(byte[], byte[]) from Scan URL: https://github.com/apache/hbase/pull/1189#issuecomment-606881705 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s | Docker mode activated. | | -1 :x: | patch | 0m 3s | https://github.com/apache/hbase/pull/1189 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. | | Subsystem | Report/Notes | |--:|:-| | GITHUB PR | https://github.com/apache/hbase/pull/1189 | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1189/9/console | | versions | git=2.17.1 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #1346: HBASE-23937 : Support Online LargeLogs similar to SlowLogs APIs
bharathv commented on a change in pull request #1346: HBASE-23937 : Support
Online LargeLogs similar to SlowLogs APIs
URL: https://github.com/apache/hbase/pull/1346#discussion_r401215250
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java
##
@@ -3952,17 +3952,27 @@ private void getProcedureResult(long procId,
CompletableFuture future, int
@Override
public CompletableFuture> getSlowLogResponses(
-@Nullable final Set serverNames,
+ @Nullable final Set serverNames,
final SlowLogQueryFilter slowLogQueryFilter) {
if (CollectionUtils.isEmpty(serverNames)) {
return CompletableFuture.completedFuture(Collections.emptyList());
}
-return CompletableFuture.supplyAsync(() -> serverNames.stream()
- .map((ServerName serverName) ->
-getSlowLogResponseFromServer(serverName, slowLogQueryFilter))
- .map(CompletableFuture::join)
- .flatMap(List::stream)
- .collect(Collectors.toList()));
+if (slowLogQueryFilter.getType() == null
Review comment:
Why this branch on the client? Can't the server side infer the type and
respond accordingly?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #1346: HBASE-23937 : Support Online LargeLogs similar to SlowLogs APIs
bharathv commented on a change in pull request #1346: HBASE-23937 : Support
Online LargeLogs similar to SlowLogs APIs
URL: https://github.com/apache/hbase/pull/1346#discussion_r401216640
##
File path: hbase-protocol-shaded/src/main/protobuf/Admin.proto
##
@@ -369,6 +369,9 @@ service AdminService {
rpc GetSlowLogResponses(SlowLogResponseRequest)
returns(SlowLogResponses);
+ rpc GetLargeLogResponses(SlowLogResponseRequest)
Review comment:
same question as above.. we can get rid of this one, right? (I thought that
was our discussion in the PR earlier).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #1346: HBASE-23937 : Support Online LargeLogs similar to SlowLogs APIs
bharathv commented on a change in pull request #1346: HBASE-23937 : Support
Online LargeLogs similar to SlowLogs APIs
URL: https://github.com/apache/hbase/pull/1346#discussion_r401215748
##
File path: hbase-protocol-shaded/src/main/protobuf/TooSlowLog.proto
##
@@ -42,4 +42,12 @@ message SlowLogPayload {
optional int32 multi_gets = 12 [default = 0];
optional int32 multi_mutations = 13 [default = 0];
optional int32 multi_service_calls = 14 [default = 0];
+ required Type type = 15;
+
+ enum Type {
+SLOW_LOG = 0;
+LARGE_LOG = 1;
Review comment:
nit: Helps to have a code comment about what a SLOW log is and what a LARGE
log is..
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (HBASE-24094) Disable "Packaging and Integration" stage from nightly
[ https://issues.apache.org/jira/browse/HBASE-24094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072158#comment-17072158 ] Nick Dimiduk commented on HBASE-24094: -- The ASF build workers are backed up again because of us. Let's avoid being egregiously poor neighbors. > Disable "Packaging and Integration" stage from nightly > -- > > Key: HBASE-24094 > URL: https://issues.apache.org/jira/browse/HBASE-24094 > Project: HBase > Issue Type: Task > Components: build >Affects Versions: 3.0.0, 2.3.0 >Reporter: Nick Dimiduk >Priority: Major > > This stage hangs up executors for 8 hours. Let's disable this until > HBASE-24049 is resolved. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-24094) Disable "Packaging and Integration" stage from nightly
Nick Dimiduk created HBASE-24094: Summary: Disable "Packaging and Integration" stage from nightly Key: HBASE-24094 URL: https://issues.apache.org/jira/browse/HBASE-24094 Project: HBase Issue Type: Task Components: build Affects Versions: 3.0.0, 2.3.0 Reporter: Nick Dimiduk This stage hangs up executors for 8 hours. Let's disable this until HBASE-24049 is resolved. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-24093) Exclude H2 from the build workers pool
Nick Dimiduk created HBASE-24093: Summary: Exclude H2 from the build workers pool Key: HBASE-24093 URL: https://issues.apache.org/jira/browse/HBASE-24093 Project: HBase Issue Type: Task Components: build Reporter: Nick Dimiduk Tracking INFRA-20025, H2 keeps coming up as impacted. Let's exclude it from our build workers while Infra investigates the hardware. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1346: HBASE-23937 : Support Online LargeLogs similar to SlowLogs APIs
Apache-HBase commented on issue #1346: HBASE-23937 : Support Online LargeLogs similar to SlowLogs APIs URL: https://github.com/apache/hbase/pull/1346#issuecomment-606876882 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 13s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +0 :ok: | prototool | 0m 1s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 28s | master passed | | +1 :green_heart: | checkstyle | 2m 47s | master passed | | +1 :green_heart: | spotbugs | 8m 2s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 28s | the patch passed | | +1 :green_heart: | checkstyle | 2m 46s | the patch passed | | -0 :warning: | rubocop | 0m 13s | The patch generated 6 new + 338 unchanged - 1 fixed = 344 total (was 339) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 30s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | hbaseprotoc | 2m 57s | the patch passed | | +1 :green_heart: | spotbugs | 8m 38s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 52s | The patch does not generate ASF License warnings. | | | | 58m 16s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1346/4/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1346 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle cc hbaseprotoc prototool rubocop | | uname | Linux fdf83ae67f71 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e5a8435b48 | | rubocop | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1346/4/artifact/yetus-general-check/output/diff-patch-rubocop.txt | | Max. process+thread count | 83 (vs. ulimit of 1) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1346/4/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 rubocop=0.80.0 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1394: HBASE-24075: Fix a race between master shutdown and metrics (re)init
Apache-HBase commented on issue #1394: HBASE-24075: Fix a race between master shutdown and metrics (re)init URL: https://github.com/apache/hbase/pull/1394#issuecomment-606876380 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 41s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 55s | master passed | | +1 :green_heart: | checkstyle | 2m 39s | master passed | | +1 :green_heart: | spotbugs | 14m 51s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 26s | the patch passed | | +1 :green_heart: | checkstyle | 2m 36s | the patch passed | | +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 11m 18s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 15m 38s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 45s | The patch does not generate ASF License warnings. | | | | 68m 13s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1394/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1394 | | JIRA Issue | HBASE-24075 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle xml | | uname | Linux ca8d2fd7ab20 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e5a8435b48 | | Max. process+thread count | 83 (vs. ulimit of 1) | | modules | C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1394/2/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1385: HBASE-24071 [JDK11] Remove `unit` filter from nightly and precommit jobs
Apache-HBase commented on issue #1385: HBASE-24071 [JDK11] Remove `unit` filter from nightly and precommit jobs URL: https://github.com/apache/hbase/pull/1385#issuecomment-606844486 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 18s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 7m 7s | master passed | | +1 :green_heart: | compile | 4m 6s | master passed | | +1 :green_heart: | shadedjars | 6m 13s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 19s | root in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 42s | the patch passed | | +1 :green_heart: | compile | 4m 2s | the patch passed | | +1 :green_heart: | javac | 4m 2s | the patch passed | | +1 :green_heart: | shadedjars | 6m 13s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 18s | root in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 113m 50s | root in the patch failed. | | | | 151m 57s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1385/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1385 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 519c6e9cb657 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e5a8435b48 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1385/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1385/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1385/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1385/3/testReport/ | | Max. process+thread count | 4181 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1385/3/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] bharathv commented on issue #1394: HBASE-24075: Fix a race between master shutdown and metrics (re)init
bharathv commented on issue #1394: HBASE-24075: Fix a race between master shutdown and metrics (re)init URL: https://github.com/apache/hbase/pull/1394#issuecomment-606841508 > Perhaps related, I wonder if getFromCacheOrFetch should check if master is stopped and if so, NOT trying fetching clusterid from fs. Another issue? I fixed it. I wanted to see how the metrics change alone affects the patch, hence marked it as a draft. The latest version has this change that makes getClusterId() a no-op if the server is shutting down. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1188: HBASE-23843 Removed deprecated Scan(byte[]) from Scan
Apache-HBase commented on issue #1188: HBASE-23843 Removed deprecated Scan(byte[]) from Scan URL: https://github.com/apache/hbase/pull/1188#issuecomment-606834446 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 11s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 41s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 9m 56s | master passed | | +1 :green_heart: | compile | 6m 25s | master passed | | +1 :green_heart: | shadedjars | 8m 57s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 38s | hbase-client in master failed. | | -0 :warning: | javadoc | 0m 29s | hbase-examples in master failed. | | -0 :warning: | javadoc | 0m 29s | hbase-mapreduce in master failed. | | -0 :warning: | javadoc | 0m 30s | hbase-rest in master failed. | | -0 :warning: | javadoc | 1m 0s | hbase-server in master failed. | | -0 :warning: | javadoc | 1m 20s | hbase-thrift in master failed. | | -0 :warning: | patch | 15m 10s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 9m 5s | the patch passed | | +1 :green_heart: | compile | 4m 20s | the patch passed | | +1 :green_heart: | javac | 4m 20s | the patch passed | | +1 :green_heart: | shadedjars | 5m 34s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 26s | hbase-client in the patch failed. | | -0 :warning: | javadoc | 0m 40s | hbase-server in the patch failed. | | -0 :warning: | javadoc | 0m 20s | hbase-mapreduce in the patch failed. | | -0 :warning: | javadoc | 0m 51s | hbase-thrift in the patch failed. | | -0 :warning: | javadoc | 0m 20s | hbase-rest in the patch failed. | | -0 :warning: | javadoc | 0m 20s | hbase-examples in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 59s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 66m 11s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 10m 26s | hbase-mapreduce in the patch passed. | | +1 :green_heart: | unit | 2m 34s | hbase-thrift in the patch passed. | | +1 :green_heart: | unit | 7m 12s | hbase-shell in the patch passed. | | +1 :green_heart: | unit | 2m 55s | hbase-rest in the patch passed. | | +1 :green_heart: | unit | 1m 29s | hbase-examples in the patch passed. | | | | 150m 24s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1188 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 6384a0a12d68 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e5a8435b48 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/7/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/7/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-examples.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/7/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/7/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/7/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/7/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/7/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt | | javadoc | https://
[GitHub] [hbase] saintstack commented on issue #1385: HBASE-24071 [JDK11] Remove `unit` filter from nightly and precommit jobs
saintstack commented on issue #1385: HBASE-24071 [JDK11] Remove `unit` filter from nightly and precommit jobs URL: https://github.com/apache/hbase/pull/1385#issuecomment-606828701 java.lang.OutOfMemoryError: unable to create new native thread This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1385: HBASE-24071 [JDK11] Remove `unit` filter from nightly and precommit jobs
Apache-HBase commented on issue #1385: HBASE-24071 [JDK11] Remove `unit` filter from nightly and precommit jobs URL: https://github.com/apache/hbase/pull/1385#issuecomment-606825836 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 33s | master passed | | +1 :green_heart: | compile | 3m 4s | master passed | | +1 :green_heart: | shadedjars | 4m 53s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 37s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 8s | the patch passed | | +1 :green_heart: | compile | 2m 59s | the patch passed | | +1 :green_heart: | javac | 2m 59s | the patch passed | | +1 :green_heart: | shadedjars | 4m 52s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 35s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 81m 32s | root in the patch failed. | | | | 116m 29s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1385/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1385 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 031bec405a23 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e5a8435b48 | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1385/3/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1385/3/testReport/ | | Max. process+thread count | 6519 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1385/3/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1188: HBASE-23843 Removed deprecated Scan(byte[]) from Scan
Apache-HBase commented on issue #1188: HBASE-23843 Removed deprecated Scan(byte[]) from Scan URL: https://github.com/apache/hbase/pull/1188#issuecomment-606823601 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 35s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 5m 21s | master passed | | +1 :green_heart: | compile | 3m 49s | master passed | | +1 :green_heart: | shadedjars | 4m 49s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 40s | master passed | | -0 :warning: | patch | 8m 42s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 4s | the patch passed | | +1 :green_heart: | compile | 3m 46s | the patch passed | | +1 :green_heart: | javac | 3m 46s | the patch passed | | +1 :green_heart: | shadedjars | 4m 48s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 38s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 51s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 63m 9s | hbase-server in the patch passed. | | -1 :x: | unit | 14m 50s | hbase-mapreduce in the patch failed. | | +1 :green_heart: | unit | 2m 31s | hbase-thrift in the patch passed. | | +1 :green_heart: | unit | 7m 11s | hbase-shell in the patch passed. | | +1 :green_heart: | unit | 2m 41s | hbase-rest in the patch passed. | | +1 :green_heart: | unit | 1m 28s | hbase-examples in the patch passed. | | | | 130m 31s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/7/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1188 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 9140a6450a1b 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e5a8435b48 | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/7/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-mapreduce.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/7/testReport/ | | Max. process+thread count | 6956 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-rest hbase-examples U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/7/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (HBASE-24073) [flakey test] client.TestAsyncRegionAdminApi messed up compaction state.
[
https://issues.apache.org/jira/browse/HBASE-24073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Huaxiang Sun resolved HBASE-24073.
--
Fix Version/s: 2.4.0
master
2.3.0
Resolution: Fixed
Patch pushed to the fixed branches.
> [flakey test] client.TestAsyncRegionAdminApi messed up compaction state.
>
>
> Key: HBASE-24073
> URL: https://issues.apache.org/jira/browse/HBASE-24073
> Project: HBase
> Issue Type: Test
> Components: Compaction
>Affects Versions: 2.3.0, master, 2.4.0
> Environment:
>Reporter: Huaxiang Sun
>Assignee: Hua Xiang
>Priority: Major
> Fix For: 2.3.0, master, 2.4.0
>
>
> {code:java}
> ---
> Test set: org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi
> ---
> Tests run: 20, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 268.838 s
> <<< FAILURE! - in org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi
> org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi.testCompact[0] Time
> elapsed: 50.471 s <<< FAILURE!
> java.lang.AssertionError: expected: but was:
> at
> org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi.compactionTest(TestAsyncRegionAdminApi.java:415)
> at
> org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi.testCompact(TestAsyncRegionAdminApi.java:364)
> Another case found during local test:
> ---
> Test set: org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi
> ---
> Tests run: 20, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 224.399 s
> <<< FAILURE! - in org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi
> org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi.testCompact[1] Time
> elapsed: 30.861 s <<< FAILURE!
> java.lang.AssertionError
> at org.junit.Assert.fail(Assert.java:87)
> at org.junit.Assert.assertTrue(Assert.java:42)
> at org.junit.Assert.assertTrue(Assert.java:53)
> at
> org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi.compactionTest(TestAsyncRegionAdminApi.java:444)
> at
> org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi.testCompact(TestAsyncRegionAdminApi.java:363)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at
> org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
> at org.junit.runners.Suite.runChild(Suite.java:128)
> at org.junit.runners.Suite.runChild(Suite.java:27)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
>
[jira] [Assigned] (HBASE-24073) [flakey test] client.TestAsyncRegionAdminApi messed up compaction state.
[
https://issues.apache.org/jira/browse/HBASE-24073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Huaxiang Sun reassigned HBASE-24073:
Assignee: Hua Xiang
> [flakey test] client.TestAsyncRegionAdminApi messed up compaction state.
>
>
> Key: HBASE-24073
> URL: https://issues.apache.org/jira/browse/HBASE-24073
> Project: HBase
> Issue Type: Test
> Components: Compaction
>Affects Versions: 2.3.0, master, 2.4.0
> Environment:
>Reporter: Huaxiang Sun
>Assignee: Hua Xiang
>Priority: Major
>
> {code:java}
> ---
> Test set: org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi
> ---
> Tests run: 20, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 268.838 s
> <<< FAILURE! - in org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi
> org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi.testCompact[0] Time
> elapsed: 50.471 s <<< FAILURE!
> java.lang.AssertionError: expected: but was:
> at
> org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi.compactionTest(TestAsyncRegionAdminApi.java:415)
> at
> org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi.testCompact(TestAsyncRegionAdminApi.java:364)
> Another case found during local test:
> ---
> Test set: org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi
> ---
> Tests run: 20, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 224.399 s
> <<< FAILURE! - in org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi
> org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi.testCompact[1] Time
> elapsed: 30.861 s <<< FAILURE!
> java.lang.AssertionError
> at org.junit.Assert.fail(Assert.java:87)
> at org.junit.Assert.assertTrue(Assert.java:42)
> at org.junit.Assert.assertTrue(Assert.java:53)
> at
> org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi.compactionTest(TestAsyncRegionAdminApi.java:444)
> at
> org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi.testCompact(TestAsyncRegionAdminApi.java:363)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at
> org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
> at org.junit.runners.Suite.runChild(Suite.java:128)
> at org.junit.runners.Suite.runChild(Suite.java:27)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.ja
[GitHub] [hbase] Apache-HBase commented on issue #1320: HBASE-8458 Support for batch version of checkAndPut() and checkAndDel…
Apache-HBase commented on issue #1320: HBASE-8458 Support for batch version of checkAndPut() and checkAndDel… URL: https://github.com/apache/hbase/pull/1320#issuecomment-606801589 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 25s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 7m 13s | master passed | | +1 :green_heart: | compile | 4m 12s | master passed | | +1 :green_heart: | shadedjars | 6m 20s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 26s | hbase-client in master failed. | | -0 :warning: | javadoc | 0m 44s | hbase-server in master failed. | | -0 :warning: | javadoc | 1m 2s | hbase-thrift in master failed. | | -0 :warning: | javadoc | 0m 21s | hbase-rest in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 7m 37s | the patch passed | | +1 :green_heart: | compile | 5m 59s | the patch passed | | +1 :green_heart: | javac | 5m 59s | the patch passed | | +1 :green_heart: | shadedjars | 9m 5s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 38s | hbase-client in the patch failed. | | -0 :warning: | javadoc | 0m 59s | hbase-server in the patch failed. | | -0 :warning: | javadoc | 1m 20s | hbase-thrift in the patch failed. | | -0 :warning: | javadoc | 0m 31s | hbase-rest in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 25s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 44s | hbase-client in the patch passed. | | -0 :warning: | unit | 145m 16s | hbase-server in the patch failed. | | +1 :green_heart: | unit | 2m 31s | hbase-thrift in the patch passed. | | +1 :green_heart: | unit | 3m 4s | hbase-rest in the patch passed. | | | | 204m 51s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1320 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 658660626fc0 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / fded2b9ddc | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/4/testReport/ | | Max. process+thread count | 4019 (vs. ulimit of 1) | | modules | C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rest U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1320/4/console | |
[GitHub] [hbase-connectors] meszibalu commented on issue #63: HBASE-24088 Solve the ambiguous reference for scala 2.12
meszibalu commented on issue #63: HBASE-24088 Solve the ambiguous reference for scala 2.12 URL: https://github.com/apache/hbase-connectors/pull/63#issuecomment-606792058 Thanks! Did you run the tests? I have the following error: ``` [ERROR] Tests run: 6, Failures: 0, Errors: 6, Skipped: 0, Time elapsed: 16.968 s <<< FAILURE! - in org.apache.hadoop.hbase.spark.TestJavaHBaseContext [ERROR] org.apache.hadoop.hbase.spark.TestJavaHBaseContext.testBulkDelete Time elapsed: 1.562 s <<< ERROR! java.lang.ArrayIndexOutOfBoundsException: 10582 at org.apache.hadoop.hbase.spark.TestJavaHBaseContext.testBulkDelete(TestJavaHBaseContext.java:212) ... ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1188: HBASE-23843 Removed deprecated Scan(byte[]) from Scan
Apache-HBase commented on issue #1188: HBASE-23843 Removed deprecated Scan(byte[]) from Scan URL: https://github.com/apache/hbase/pull/1188#issuecomment-606791251 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 51s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 44s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 8m 11s | master passed | | +1 :green_heart: | checkstyle | 5m 31s | master passed | | +1 :green_heart: | spotbugs | 9m 46s | master passed | | -0 :warning: | patch | 2m 31s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 6m 12s | the patch passed | | +1 :green_heart: | checkstyle | 3m 33s | the patch passed | | -0 :warning: | rubocop | 0m 8s | The patch generated 1 new + 110 unchanged - 1 fixed = 111 total (was 111) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 36s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. | | +1 :green_heart: | spotbugs | 8m 28s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 1m 17s | The patch does not generate ASF License warnings. | | | | 67m 14s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/7/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1188 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle rubocop | | uname | Linux 9dbf2d9dbab1 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / e5a8435b48 | | rubocop | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/7/artifact/yetus-general-check/output/diff-patch-rubocop.txt | | Max. process+thread count | 83 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-rest hbase-examples U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1188/7/console | | versions | git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12 rubocop=0.80.0 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-24086) master fails to becomeActive running out of source repo
[
https://issues.apache.org/jira/browse/HBASE-24086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Dimiduk updated HBASE-24086:
-
Affects Version/s: 2.3.0
> master fails to becomeActive running out of source repo
> ---
>
> Key: HBASE-24086
> URL: https://issues.apache.org/jira/browse/HBASE-24086
> Project: HBase
> Issue Type: Bug
> Components: master
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Nick Dimiduk
>Priority: Major
>
> {noformat}
> $
> JAVA_HOME=/Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home
> mvn clean install -DskipTests
> $
> JAVA_HOME=/Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home
> ./bin/hbase master start
> {noformat}
> gives
> {noformat}
> 2020-03-30 17:12:43,857 ERROR
> [master/192.168.111.13:16000:becomeActiveMaster] master.HMaster: Failed to
> become active master
>
> java.io.IOException: cannot get log writer
>
>
> at
> org.apache.hadoop.hbase.wal.AsyncFSWALProvider.createAsyncWriter(AsyncFSWALProvider.java:118)
>
>
> at
> org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createAsyncWriter(AsyncFSWAL.java:704)
>
>
> at
> org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createWriterInstance(AsyncFSWAL.java:710)
>
>
> at
> org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL.createWriterInstance(AsyncFSWAL.java:128)
>
>
> at
> org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.rollWriter(AbstractFSWAL.java:839)
>
>
> at
> org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.rollWriter(AbstractFSWAL.java:549)
>
>
> at
> org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL.init(AbstractFSWAL.java:490)
>
>
> at
> org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:156)
>
>
> at
> org.apache.hadoop.hbase.wal.AbstractFSWALProvider.getWAL(AbstractFSWALProvider.java:61)
>
>
> at org.apache.hadoop.hbase.wal.WALFactory.getWAL(WALFactory.java:297)
>
>
> at
> org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.createWAL(RegionProcedureStore.java:256)
>
>
> at
> org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.bootstrap(RegionProcedureStore.java:273)
>
>
> at
> org.apache.hadoop.hbase.procedure2.store.region.RegionProcedureStore.recoverLease(RegionProcedureStore.java:482)
>
>
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.init(ProcedureExecutor.java:587)
>
>
> at
> org.apache.hadoop.hbase.master.HMaster.createProcedureExecutor(HMaster.java:1575)
>
>
> at
> org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:961)
>
>
> at
> org.apache.hadoop.hbase.master.HMaster.startActiveMasterManager(HMaster.java:2231)
>
>
