[GitHub] [hbase] Apache-HBase commented on pull request #3554: HBASE-26166 fix a minor table display bug in master ui
Apache-HBase commented on pull request #3554: URL: https://github.com/apache/hbase/pull/3554#issuecomment-891555088 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 0s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 8s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 42s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 12m 54s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3554/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3554 | | Optional Tests | dupname asflicense javac | | uname | Linux 92c4824f149e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / de84c1765a | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 78 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3554/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3553: HBASE-26155 JVM crash when RPC calls ship scanner
Apache-HBase commented on pull request #3553: URL: https://github.com/apache/hbase/pull/3553#issuecomment-891550425 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 40s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 21s | master passed | | +1 :green_heart: | compile | 3m 25s | master passed | | +1 :green_heart: | checkstyle | 1m 10s | master passed | | +1 :green_heart: | spotbugs | 2m 13s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 3s | the patch passed | | +1 :green_heart: | compile | 3m 19s | the patch passed | | +1 :green_heart: | javac | 3m 19s | the patch passed | | +1 :green_heart: | checkstyle | 1m 8s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 20m 11s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | +1 :green_heart: | spotbugs | 2m 23s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 53m 24s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3553/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3553 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 9f1c1373b7da 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / de84c1765a | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 86 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3553/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] frostruan opened a new pull request #3554: HBASE-26166 fix a minor table display bug in master ui
frostruan opened a new pull request #3554: URL: https://github.com/apache/hbase/pull/3554 before  after  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (HBASE-26166) table list in master ui has a monor bug
[ https://issues.apache.org/jira/browse/HBASE-26166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ruanhui reassigned HBASE-26166: --- Assignee: ruanhui > table list in master ui has a monor bug > --- > > Key: HBASE-26166 > URL: https://issues.apache.org/jira/browse/HBASE-26166 > Project: HBase > Issue Type: Bug > Components: UI >Affects Versions: 2.4.5 >Reporter: ruanhui >Assignee: ruanhui >Priority: Minor > Attachments: image-2021-08-03-13-09-24-030.png > > > !image-2021-08-03-13-09-24-030.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-26166) table list in master ui has a monor bug
ruanhui created HBASE-26166: --- Summary: table list in master ui has a monor bug Key: HBASE-26166 URL: https://issues.apache.org/jira/browse/HBASE-26166 Project: HBase Issue Type: Bug Components: UI Affects Versions: 2.4.5 Reporter: ruanhui Attachments: image-2021-08-03-13-09-24-030.png !image-2021-08-03-13-09-24-030.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] sunhelly opened a new pull request #3553: HBASE-26155 JVM crash when RPC calls ship scanner
sunhelly opened a new pull request #3553: URL: https://github.com/apache/hbase/pull/3553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (HBASE-26155) JVM crash when RPC calls ship scanner
[
https://issues.apache.org/jira/browse/HBASE-26155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiaolin Ha reassigned HBASE-26155:
--
Assignee: Xiaolin Ha
> JVM crash when RPC calls ship scanner
> -
>
> Key: HBASE-26155
> URL: https://issues.apache.org/jira/browse/HBASE-26155
> Project: HBase
> Issue Type: Bug
> Components: Scanners
>Affects Versions: 3.0.0-alpha-1
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
>
> There are scanner close caused regionserver JVM coredump problems on our
> production clusters.
> {code:java}
> Stack: [0x7fca4b0cc000,0x7fca4b1cd000], sp=0x7fca4b1cb0d8, free
> space=1020k
> Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native
> code)
> V [libjvm.so+0x7fd314]
> J 2810 sun.misc.Unsafe.copyMemory(Ljava/lang/Object;JLjava/lang/Object;JJ)V
> (0 bytes) @ 0x7fdae55a9e61 [0x7fdae55a9d80+0xe1]
> j
> org.apache.hadoop.hbase.util.UnsafeAccess.unsafeCopy(Ljava/lang/Object;JLjava/lang/Object;JJ)V+36
> j
> org.apache.hadoop.hbase.util.UnsafeAccess.copy(Ljava/nio/ByteBuffer;I[BII)V+69
> j
> org.apache.hadoop.hbase.util.ByteBufferUtils.copyFromBufferToArray([BLjava/nio/ByteBuffer;III)V+39
> j
> org.apache.hadoop.hbase.CellUtil.copyQualifierTo(Lorg/apache/hadoop/hbase/Cell;[BI)I+31
> j
> org.apache.hadoop.hbase.KeyValueUtil.appendKeyTo(Lorg/apache/hadoop/hbase/Cell;[BI)I+43
> J 14724 C2 org.apache.hadoop.hbase.regionserver.StoreScanner.shipped()V (51
> bytes) @ 0x7fdae6a298d0 [0x7fdae6a29780+0x150]
> J 21387 C2
> org.apache.hadoop.hbase.regionserver.RSRpcServices$RegionScannerShippedCallBack.run()V
> (53 bytes) @ 0x7fdae622bab8 [0x7fdae622acc0+0xdf8]
> J 26353 C2
> org.apache.hadoop.hbase.ipc.ServerCall.setResponse(Lorg/apache/hbase/thirdparty/com/google/protobuf/Message;Lorg/apache/hadoop/hbase/CellScanner;Ljava/lang/Throwable;Ljava/lang/String;)V
> (384 bytes) @ 0x7fdae7f139d8 [0x7fdae7f12980+0x1058]
> J 26226 C2 org.apache.hadoop.hbase.ipc.CallRunner.run()V (1554 bytes) @
> 0x7fdae959f68c [0x7fdae959e400+0x128c]
> J 19598% C2
> org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(Ljava/util/concurrent/BlockingQueue;Ljava/util/concurrent/atomic/AtomicInteger;)V
> (338 bytes) @ 0x7fdae81c54d4 [0x7fdae81c53e0+0xf4]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-26155) JVM crash when RPC calls ship scanner
[
https://issues.apache.org/jira/browse/HBASE-26155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiaolin Ha updated HBASE-26155:
---
Summary: JVM crash when RPC calls ship scanner (was: JVM crash when rpc
calls close scanner)
> JVM crash when RPC calls ship scanner
> -
>
> Key: HBASE-26155
> URL: https://issues.apache.org/jira/browse/HBASE-26155
> Project: HBase
> Issue Type: Bug
> Components: Scanners
>Affects Versions: 3.0.0-alpha-1
>Reporter: Xiaolin Ha
>Priority: Major
>
> There are scanner close caused regionserver JVM coredump problems on our
> production clusters.
> {code:java}
> Stack: [0x7fca4b0cc000,0x7fca4b1cd000], sp=0x7fca4b1cb0d8, free
> space=1020k
> Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native
> code)
> V [libjvm.so+0x7fd314]
> J 2810 sun.misc.Unsafe.copyMemory(Ljava/lang/Object;JLjava/lang/Object;JJ)V
> (0 bytes) @ 0x7fdae55a9e61 [0x7fdae55a9d80+0xe1]
> j
> org.apache.hadoop.hbase.util.UnsafeAccess.unsafeCopy(Ljava/lang/Object;JLjava/lang/Object;JJ)V+36
> j
> org.apache.hadoop.hbase.util.UnsafeAccess.copy(Ljava/nio/ByteBuffer;I[BII)V+69
> j
> org.apache.hadoop.hbase.util.ByteBufferUtils.copyFromBufferToArray([BLjava/nio/ByteBuffer;III)V+39
> j
> org.apache.hadoop.hbase.CellUtil.copyQualifierTo(Lorg/apache/hadoop/hbase/Cell;[BI)I+31
> j
> org.apache.hadoop.hbase.KeyValueUtil.appendKeyTo(Lorg/apache/hadoop/hbase/Cell;[BI)I+43
> J 14724 C2 org.apache.hadoop.hbase.regionserver.StoreScanner.shipped()V (51
> bytes) @ 0x7fdae6a298d0 [0x7fdae6a29780+0x150]
> J 21387 C2
> org.apache.hadoop.hbase.regionserver.RSRpcServices$RegionScannerShippedCallBack.run()V
> (53 bytes) @ 0x7fdae622bab8 [0x7fdae622acc0+0xdf8]
> J 26353 C2
> org.apache.hadoop.hbase.ipc.ServerCall.setResponse(Lorg/apache/hbase/thirdparty/com/google/protobuf/Message;Lorg/apache/hadoop/hbase/CellScanner;Ljava/lang/Throwable;Ljava/lang/String;)V
> (384 bytes) @ 0x7fdae7f139d8 [0x7fdae7f12980+0x1058]
> J 26226 C2 org.apache.hadoop.hbase.ipc.CallRunner.run()V (1554 bytes) @
> 0x7fdae959f68c [0x7fdae959e400+0x128c]
> J 19598% C2
> org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(Ljava/util/concurrent/BlockingQueue;Ljava/util/concurrent/atomic/AtomicInteger;)V
> (338 bytes) @ 0x7fdae81c54d4 [0x7fdae81c53e0+0xf4]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #3552: HBASE-26126 Backport HBASE-25424 "Find a way to config OpenTelemetry …
Apache-HBase commented on pull request #3552: URL: https://github.com/apache/hbase/pull/3552#issuecomment-891523515 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m 17s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 44s | branch-2 passed | | +1 :green_heart: | compile | 3m 4s | branch-2 passed | | +1 :green_heart: | shadedjars | 7m 54s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 13s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 29s | the patch passed | | +1 :green_heart: | compile | 3m 2s | the patch passed | | +1 :green_heart: | javac | 3m 2s | the patch passed | | +1 :green_heart: | shadedjars | 7m 58s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 8s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 242m 33s | root in the patch passed. | | | | 289m 30s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3552 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux ed122d6f2ce8 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / ca096437d7 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/1/testReport/ | | Max. process+thread count | 3959 (vs. ulimit of 12500) | | modules | C: hbase-assembly . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26154) Provide exception metric for quota exceeded and throttling
[ https://issues.apache.org/jira/browse/HBASE-26154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17391958#comment-17391958 ] Pankaj Kumar commented on HBASE-26154: -- That looks like flaky and not relevant to this change. > Provide exception metric for quota exceeded and throttling > -- > > Key: HBASE-26154 > URL: https://issues.apache.org/jira/browse/HBASE-26154 > Project: HBase > Issue Type: Improvement >Reporter: Bryan Beaudreault >Assignee: Bryan Beaudreault >Priority: Minor > Fix For: 2.5.0, 3.0.0-alpha-2, 2.4.6 > > > We should add metrics for QuotaExceededException and RpcThrottlingException. > This is something we've found very useful to track as it helps us identify > bad access patterns in clients. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #3535: HBASE-25469 Create RIT servlet in HMaster to track more detailed RIT info not captured in metrics
Apache-HBase commented on pull request #3535: URL: https://github.com/apache/hbase/pull/3535#issuecomment-891517733 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 5s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 8s | master passed | | +1 :green_heart: | compile | 1m 12s | master passed | | +1 :green_heart: | shadedjars | 8m 11s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 14s | the patch passed | | +1 :green_heart: | compile | 1m 14s | the patch passed | | +1 :green_heart: | javac | 1m 14s | the patch passed | | +1 :green_heart: | shadedjars | 8m 16s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 40s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 142m 58s | hbase-server in the patch passed. | | | | 174m 55s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3535/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3535 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 2d3f2b6c6b6e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / de84c1765a | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3535/3/testReport/ | | Max. process+thread count | 3938 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3535/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3535: HBASE-25469 Create RIT servlet in HMaster to track more detailed RIT info not captured in metrics
Apache-HBase commented on pull request #3535: URL: https://github.com/apache/hbase/pull/3535#issuecomment-891517598 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 39s | master passed | | +1 :green_heart: | compile | 0m 59s | master passed | | +1 :green_heart: | shadedjars | 8m 10s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 43s | the patch passed | | +1 :green_heart: | compile | 1m 2s | the patch passed | | +1 :green_heart: | javac | 1m 2s | the patch passed | | +1 :green_heart: | shadedjars | 8m 12s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 144m 44s | hbase-server in the patch passed. | | | | 174m 30s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3535/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3535 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 3978121de5ca 4.15.0-151-generic #157-Ubuntu SMP Fri Jul 9 23:07:57 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / de84c1765a | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3535/3/testReport/ | | Max. process+thread count | 4089 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3535/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26158) MiniZooKeeperCluster should not be IA.Public
[ https://issues.apache.org/jira/browse/HBASE-26158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17391939#comment-17391939 ] Geoffrey Jacoby commented on HBASE-26158: - [~zhangduo] - I'm not sure that this is a correct assumption. For example, my colleague [~bharathv] recently wrote an IT test that used the MiniZooKeeperCluster to share a ZK quorum between an in-memory Kafka instance, an HBase minicluster, and a custom process implementing the HBase RegionServer API. (It's part of a project that will be contributed to Phoenix when it's closer to final form.) And I can see other valid test cases for using the MiniZooKeeperCluster, such as verifying that a custom coproc or replication endpoint (particularly the endpoint) don't leak resources or do other bad things if ZK connectivity is lost. > MiniZooKeeperCluster should not be IA.Public > > > Key: HBASE-26158 > URL: https://issues.apache.org/jira/browse/HBASE-26158 > Project: HBase > Issue Type: Sub-task > Components: API, test >Reporter: Duo Zhang >Priority: Major > > End users do not need to test HBase when zookeeper is broken. And if users > want to start only a zookeeper cluster, they can just use curator-test, so I > do not think we should expose this class as IA.Public. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-26152) Exclude javax.servlet:servlet-api in hbase-shaded-testing-util
[
https://issues.apache.org/jira/browse/HBASE-26152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17391900#comment-17391900
]
Hudson commented on HBASE-26152:
Results for branch branch-2.4
[build #173 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/173/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/173/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/173/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/173/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/173/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Exclude javax.servlet:servlet-api in hbase-shaded-testing-util
> --
>
> Key: HBASE-26152
> URL: https://issues.apache.org/jira/browse/HBASE-26152
> Project: HBase
> Issue Type: Task
>Affects Versions: 2.4.0, 2.4.1, 2.4.2, 2.4.3, 2.4.4, 2.4.5
>Reporter: Andrew Kyle Purtell
>Assignee: Peter Somogyi
>Priority: Major
> Fix For: 2.5.0, 2.4.6
>
>
> {noformat}
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> [INFO] Running org.apache.hbase.shaded.TestShadedHBaseTestingUtility
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> 19.515 s <<< FAILURE! - in
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility
> [ERROR] org.apache.hbase.shaded.TestShadedHBaseTestingUtility Time elapsed:
> 19.513 s <<< ERROR!
> java.io.IOException: Shutting down
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: java.lang.RuntimeException: Failed construction of Master: class
> org.apache.hadoop.hbase.master.HMasterMultiple exceptions
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: java.io.IOException: Problem starting http server
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: org.apache.hbase.thirdparty.org.eclipse.jetty.util.MultiException:
> Multiple exceptions
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: java.lang.NoSuchMethodError:
> javax.servlet.ServletContext.createFilter(Ljava/lang/Class;)Ljavax/servlet/Filter;
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> [INFO]
> [INFO] Results:
> [INFO]
> [ERROR] Errors:
> [ERROR] TestShadedHBaseTestingUtility.setUp:47 » IO Shutting down
> [INFO]
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0
> {noformat}
> The hadoop-common and hadoop-mapreduce-client-app dependencies are leaking
> javax.servlet:servlet-api:2.5.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-26154) Provide exception metric for quota exceeded and throttling
[
https://issues.apache.org/jira/browse/HBASE-26154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17391899#comment-17391899
]
Hudson commented on HBASE-26154:
Results for branch branch-2.4
[build #173 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/173/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/173/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/173/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/173/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/173/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Provide exception metric for quota exceeded and throttling
> --
>
> Key: HBASE-26154
> URL: https://issues.apache.org/jira/browse/HBASE-26154
> Project: HBase
> Issue Type: Improvement
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Minor
> Fix For: 2.5.0, 3.0.0-alpha-2, 2.4.6
>
>
> We should add metrics for QuotaExceededException and RpcThrottlingException.
> This is something we've found very useful to track as it helps us identify
> bad access patterns in clients.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #3535: HBASE-25469 Create RIT servlet in HMaster to track more detailed RIT info not captured in metrics
Apache-HBase commented on pull request #3535: URL: https://github.com/apache/hbase/pull/3535#issuecomment-891467858 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 59s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 0s | master passed | | +1 :green_heart: | compile | 3m 16s | master passed | | +1 :green_heart: | checkstyle | 1m 11s | master passed | | +1 :green_heart: | spotbugs | 2m 8s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 4s | the patch passed | | +1 :green_heart: | compile | 3m 20s | the patch passed | | +1 :green_heart: | javac | 3m 20s | the patch passed | | -0 :warning: | checkstyle | 1m 10s | hbase-server: The patch generated 1 new + 89 unchanged - 0 fixed = 90 total (was 89) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 19m 57s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | +1 :green_heart: | spotbugs | 2m 25s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 11s | The patch does not generate ASF License warnings. | | | | 51m 3s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3535/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3535 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux da190570a27c 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / de84c1765a | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3535/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 86 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3535/3/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3535: HBASE-25469 Create RIT servlet in HMaster to track more detailed RIT info not captured in metrics
Apache-HBase commented on pull request #3535: URL: https://github.com/apache/hbase/pull/3535#issuecomment-891443859 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 14s | master passed | | +1 :green_heart: | compile | 1m 3s | master passed | | +1 :green_heart: | shadedjars | 8m 12s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 40s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 41s | the patch passed | | +1 :green_heart: | compile | 1m 0s | the patch passed | | +1 :green_heart: | javac | 1m 0s | the patch passed | | +1 :green_heart: | shadedjars | 8m 10s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 144m 51s | hbase-server in the patch passed. | | | | 175m 29s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3535/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3535 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux e361ccdfe72f 4.15.0-151-generic #157-Ubuntu SMP Fri Jul 9 23:07:57 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / de84c1765a | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3535/2/testReport/ | | Max. process+thread count | 4025 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3535/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3535: HBASE-25469 Create RIT servlet in HMaster to track more detailed RIT info not captured in metrics
Apache-HBase commented on pull request #3535: URL: https://github.com/apache/hbase/pull/3535#issuecomment-891443649 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 2s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 28s | master passed | | +1 :green_heart: | compile | 1m 11s | master passed | | +1 :green_heart: | shadedjars | 8m 18s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 43s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 13s | the patch passed | | +1 :green_heart: | compile | 1m 13s | the patch passed | | +1 :green_heart: | javac | 1m 13s | the patch passed | | +1 :green_heart: | shadedjars | 8m 16s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 142m 43s | hbase-server in the patch passed. | | | | 174m 59s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3535/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3535 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux fe34390c66f9 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / de84c1765a | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3535/2/testReport/ | | Max. process+thread count | 3852 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3535/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3552: HBASE-26126 Backport HBASE-25424 "Find a way to config OpenTelemetry …
Apache-HBase commented on pull request #3552: URL: https://github.com/apache/hbase/pull/3552#issuecomment-891426332 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 1s | Shelldocs was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 24s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 45s | branch-2 passed | | +1 :green_heart: | compile | 8m 44s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 24s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 19s | the patch passed | | +1 :green_heart: | compile | 8m 47s | the patch passed | | +1 :green_heart: | javac | 8m 47s | the patch passed | | +1 :green_heart: | shellcheck | 0m 2s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 4s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 11m 45s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 29s | The patch does not generate ASF License warnings. | | | | 45m 43s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3552 | | Optional Tests | dupname asflicense shellcheck shelldocs javac hadoopcheck xml compile | | uname | Linux 844874d93543 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / ca096437d7 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 141 (vs. ulimit of 12500) | | modules | C: hbase-assembly . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3552/1/console | | versions | git=2.17.1 maven=3.6.3 shellcheck=0.4.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] caroliney14 edited a comment on pull request #3535: HBASE-25469 Create RIT servlet in HMaster to track more detailed RIT info not captured in metrics
caroliney14 edited a comment on pull request #3535: URL: https://github.com/apache/hbase/pull/3535#issuecomment-891412977 @bharathv there already are multiple places where RIT info can be found: the main `/master-status` page and the `rits.jsp` page. I don't think it's that confusing what the differences between the different RIT info sources are; the `/master-status` gives an overview of the RIT, the `rits.jsp` gives more details in a human-friendly format, and the `/rit` servlet displays the metrics we want as JSON. there are indeed overlaps between these places, but each has its own purpose that is independent of the other ones. we may choose to display different info in the JSON than on the `rits.jsp` page (I asked for feedback in [this JIRA comment](https://issues.apache.org/jira/browse/HBASE-25469?focusedCommentId=17388214=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17388214) about whether we should consider displaying only RITs over threshold in the JSON, or consider grouping by server name or state in the JSON -- if you or @apurtell have any thoughts there, please do share). that is just my personal opinion though, any thoughts @apurtell? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] caroliney14 commented on pull request #3535: HBASE-25469 Create RIT servlet in HMaster to track more detailed RIT info not captured in metrics
caroliney14 commented on pull request #3535: URL: https://github.com/apache/hbase/pull/3535#issuecomment-891415561 actually, I think it makes more sense to link `/rit` from the `/master-status` RIT section as a "view as JSON" link rather than the `rits.jsp` page because the `rit.jsp` page may display RITs only for a certain table, depending on the filter, while the JSON always returns all RITs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] caroliney14 edited a comment on pull request #3535: HBASE-25469 Create RIT servlet in HMaster to track more detailed RIT info not captured in metrics
caroliney14 edited a comment on pull request #3535: URL: https://github.com/apache/hbase/pull/3535#issuecomment-891412977 @bharathv there already are multiple places where RIT info can be found: the main `/master-status` page and the `rits.jsp` page. I don't think it's that confusing what the differences between the different RIT info sources are; the `/master-status` gives an overview of the RIT, the `rits.jsp` gives more details in a human-friendly format, and the `/rit` servlet displays the metrics we want as JSON. there are indeed overlaps between these places, but each has its own purpose that is independent of the other ones. we may choose to display different info in the JSON than on the `rits.jsp` page (I asked for feedback on [this JIRA comment](https://issues.apache.org/jira/browse/HBASE-25469?focusedCommentId=17388214=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17388214) about whether we should consider displaying only RITs over threshold in the JSON, or consider grouping by server name or state in the JSON -- if you or @apurtell have any thoughts there, please do share). that is just my personal opinion though, any thoughts @apurtell? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] taklwu edited a comment on pull request #3529: HBASE-26124 Backport HBASE-25373 "Remove HTrace completely in code base and try to make use of OpenTelemetry" to branch-2
taklwu edited a comment on pull request #3529: URL: https://github.com/apache/hbase/pull/3529#issuecomment-891242759 @Apache9 hey Duo, having your +1 is good and it's never late to comment!. (updated) let me clarify with you first, do you mean we should have a single feature branch for all remaining commits (about 14 commits remaining) , then have a single PR for reviewing all cherry-picks (with merge conflicts) such we can move the review faster ? (in fact I actually had backported all 17 commits in my local repository) or, do you have other concerns for "the other issues" (what does "other" means here)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] taklwu edited a comment on pull request #3529: HBASE-26124 Backport HBASE-25373 "Remove HTrace completely in code base and try to make use of OpenTelemetry" to branch-2
taklwu edited a comment on pull request #3529: URL: https://github.com/apache/hbase/pull/3529#issuecomment-891242759 @Apache9 hey Duo, having your +1 is good and it's never late to comment!. (updated) let me clarify with you first, do you mean we should have a single feature branch for all remaining commits (about 14 commits remaining) , then have a single PR for reviewing all cherry-picks (with merge conflicts) such we can move the review faster ? (in fact I actually had backported all 17 commits in a private repository) or, do you have other concerns for "the other issues" (what does "other" means here)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-26164) Update dependencies in hbase-filesystem
[ https://issues.apache.org/jira/browse/HBASE-26164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-26164: --- Status: Patch Available (was: Open) > Update dependencies in hbase-filesystem > --- > > Key: HBASE-26164 > URL: https://issues.apache.org/jira/browse/HBASE-26164 > Project: HBase > Issue Type: Task > Components: hboss >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Major > Fix For: hbase-filesystem-1.0.0-alpha2 > > > hbase-filesystem still has some old dependencies. Notably aws-java-sdk is at > 1.11.525 whereas hadoop is all the way at 1.11.1026. > We're also still building HBase 2 against 2.1.4 instead of anything newer. > Bump up the relevant dependencies to something more current and make sure the > code still works. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase-filesystem] joshelser opened a new pull request #24: HBASE-26164 Update dependencies and remove duplicative aws-java-sdk d…
joshelser opened a new pull request #24: URL: https://github.com/apache/hbase-filesystem/pull/24 …efinition -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26164) Update dependencies in hbase-filesystem
[ https://issues.apache.org/jira/browse/HBASE-26164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17391841#comment-17391841 ] Josh Elser commented on HBASE-26164: I was expecting to get some test breakages as a result of the newer aws-java-sdk, but it seems like that's in conjunction with hadoop 3.3. So, this change gets really easy. Harder work to be done in HBASE-25900. > Update dependencies in hbase-filesystem > --- > > Key: HBASE-26164 > URL: https://issues.apache.org/jira/browse/HBASE-26164 > Project: HBase > Issue Type: Task > Components: hboss >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Major > Fix For: hbase-filesystem-1.0.0-alpha2 > > > hbase-filesystem still has some old dependencies. Notably aws-java-sdk is at > 1.11.525 whereas hadoop is all the way at 1.11.1026. > We're also still building HBase 2 against 2.1.4 instead of anything newer. > Bump up the relevant dependencies to something more current and make sure the > code still works. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] caroliney14 commented on pull request #3535: HBASE-25469 Create RIT servlet in HMaster to track more detailed RIT info not captured in metrics
caroliney14 commented on pull request #3535: URL: https://github.com/apache/hbase/pull/3535#issuecomment-891412977 @bharathv there already are multiple places where RIT info can be found: the main `/master-status` page and the `rits.jsp` page. I don't think it's that confusing what the differences between the different RIT info sources are; the `/master-status` gives an overview of the RIT, the `rits.jsp` gives more details, and the `/rit` servlet displays the metrics we want as JSON. and, each one links to the next. there are indeed overlaps between these places, but each has its own purpose that is independent of the other ones. we may choose to display different info in the JSON than on the `rits.jsp` page (I asked for feedback on [this JIRA comment](https://issues.apache.org/jira/browse/HBASE-25469?focusedCommentId=17388214=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17388214) about whether we should consider displaying only RITs over threshold in the JSON, or consider grouping by server name or state in the JSON -- if you or @apurtell have any thoughts there, please do share). that is just my personal opinion though, any thoughts @apurtell? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3551: HBASE-26165 Fix the 2.3.6 downloads page version column
Apache-HBase commented on pull request #3551: URL: https://github.com/apache/hbase/pull/3551#issuecomment-891412028 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 1s | master passed | | +1 :green_heart: | mvnsite | 8m 56s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 38s | the patch passed | | +1 :green_heart: | mvnsite | 9m 10s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 19s | The patch does not generate ASF License warnings. | | | | 28m 28s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3551/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3551 | | Optional Tests | dupname asflicense mvnsite xml | | uname | Linux 8d2b8a0c7420 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / de84c1765a | | Max. process+thread count | 89 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3551/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (HBASE-26126) Backport HBASE-25424 to branch-2
[ https://issues.apache.org/jira/browse/HBASE-26126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu reassigned HBASE-26126: Assignee: Tak-Lon (Stephen) Wu > Backport HBASE-25424 to branch-2 > > > Key: HBASE-26126 > URL: https://issues.apache.org/jira/browse/HBASE-26126 > Project: HBase > Issue Type: Sub-task >Reporter: Tak-Lon (Stephen) Wu >Assignee: Tak-Lon (Stephen) Wu >Priority: Major > > [3/17 commits of > HBASE-22120|https://github.com/apache/hbase/pull/2901/commits], original > commit of HBASE-25424 was > [https://github.com/apache/hbase/commit/57960fa8fa7228d65b1a4adc8e9b5b1a8158824d] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-26126) Backport HBASE-25424 "Find a way to config OpenTelemetry tracing without directly depending on opentelemetry-sdk" to branch-2
[ https://issues.apache.org/jira/browse/HBASE-26126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-26126: - Summary: Backport HBASE-25424 "Find a way to config OpenTelemetry tracing without directly depending on opentelemetry-sdk" to branch-2 (was: Backport HBASE-25424 to branch-2) > Backport HBASE-25424 "Find a way to config OpenTelemetry tracing without > directly depending on opentelemetry-sdk" to branch-2 > - > > Key: HBASE-26126 > URL: https://issues.apache.org/jira/browse/HBASE-26126 > Project: HBase > Issue Type: Sub-task >Reporter: Tak-Lon (Stephen) Wu >Assignee: Tak-Lon (Stephen) Wu >Priority: Major > > [3/17 commits of > HBASE-22120|https://github.com/apache/hbase/pull/2901/commits], original > commit of HBASE-25424 was > [https://github.com/apache/hbase/commit/57960fa8fa7228d65b1a4adc8e9b5b1a8158824d] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-26164) Update dependencies in hbase-filesystem
[ https://issues.apache.org/jira/browse/HBASE-26164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17391837#comment-17391837 ] Josh Elser commented on HBASE-26164: Ah, I see the great SteveL was here a while ago in HBASE-25900. Let me try to focus this change on Hadoop 3.2 and then help HBASE-25900 get landed for the Hadoop 3.3 support. > Update dependencies in hbase-filesystem > --- > > Key: HBASE-26164 > URL: https://issues.apache.org/jira/browse/HBASE-26164 > Project: HBase > Issue Type: Task > Components: hboss >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Major > Fix For: hbase-filesystem-1.0.0-alpha2 > > > hbase-filesystem still has some old dependencies. Notably aws-java-sdk is at > 1.11.525 whereas hadoop is all the way at 1.11.1026. > We're also still building HBase 2 against 2.1.4 instead of anything newer. > Bump up the relevant dependencies to something more current and make sure the > code still works. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] taklwu opened a new pull request #3552: HBASE-26126 Backport HBASE-25424 "Find a way to config OpenTelemetry …
taklwu opened a new pull request #3552: URL: https://github.com/apache/hbase/pull/3552 …tracing without directly depending on opentelemetry-sdk" to branch-2 3/17 commits of HBASE-22120, original commit#57960fa8fa7228d65b1a4adc8e9b5b1a8158824d -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-26126) Backport HBASE-25424 to branch-2
[ https://issues.apache.org/jira/browse/HBASE-26126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-26126: - Description: [3/17 commits of HBASE-22120|https://github.com/apache/hbase/pull/2901/commits], original commit of HBASE-25424 was [https://github.com/apache/hbase/commit/57960fa8fa7228d65b1a4adc8e9b5b1a8158824d] (was: [2/17 commits of HBASE-22120|https://github.com/apache/hbase/pull/2901/commits], original commit of HBASE-25424 was https://github.com/apache/hbase/commit/57960fa8fa7228d65b1a4adc8e9b5b1a8158824d ) > Backport HBASE-25424 to branch-2 > > > Key: HBASE-26126 > URL: https://issues.apache.org/jira/browse/HBASE-26126 > Project: HBase > Issue Type: Sub-task >Reporter: Tak-Lon (Stephen) Wu >Priority: Major > > [3/17 commits of > HBASE-22120|https://github.com/apache/hbase/pull/2901/commits], original > commit of HBASE-25424 was > [https://github.com/apache/hbase/commit/57960fa8fa7228d65b1a4adc8e9b5b1a8158824d] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-26126) Backport HBASE-25424 to branch-2
[ https://issues.apache.org/jira/browse/HBASE-26126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu updated HBASE-26126: - Description: [2/17 commits of HBASE-22120|https://github.com/apache/hbase/pull/2901/commits], original commit of HBASE-25424 was https://github.com/apache/hbase/commit/57960fa8fa7228d65b1a4adc8e9b5b1a8158824d > Backport HBASE-25424 to branch-2 > > > Key: HBASE-26126 > URL: https://issues.apache.org/jira/browse/HBASE-26126 > Project: HBase > Issue Type: Sub-task >Reporter: Tak-Lon (Stephen) Wu >Priority: Major > > [2/17 commits of > HBASE-22120|https://github.com/apache/hbase/pull/2901/commits], original > commit of HBASE-25424 was > https://github.com/apache/hbase/commit/57960fa8fa7228d65b1a4adc8e9b5b1a8158824d > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-26125) Backport HBASE-25401 "Add trace support for async call in rpc client" to branch-2
[ https://issues.apache.org/jira/browse/HBASE-26125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tak-Lon (Stephen) Wu resolved HBASE-26125. -- Fix Version/s: 2.5.0 Hadoop Flags: Reviewed Release Note: https://github.com/apache/hbase/commit/ca096437d7e096b514ddda53ec2f97b85d90752d Resolution: Fixed > Backport HBASE-25401 "Add trace support for async call in rpc client" to > branch-2 > - > > Key: HBASE-26125 > URL: https://issues.apache.org/jira/browse/HBASE-26125 > Project: HBase > Issue Type: Sub-task > Components: tracing >Affects Versions: 2.5.0 >Reporter: Tak-Lon (Stephen) Wu >Assignee: Tak-Lon (Stephen) Wu >Priority: Major > Fix For: 2.5.0 > > > [2/17 commits of > HBASE-22120|https://github.com/apache/hbase/pull/2901/commits], original > commit of HBASE-25401 was > [https://github.com/apache/hbase/commit/242028671535dfed67ec13d9ed0d6067f3ccfd04] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] bharathv commented on pull request #3535: HBASE-25469 Create RIT servlet in HMaster to track more detailed RIT info not captured in metrics
bharathv commented on pull request #3535: URL: https://github.com/apache/hbase/pull/3535#issuecomment-891405967 The problem is that the two places can now diverge. If someone is not familiar with the other page, they just update one of them. As an operator it is now confusing whether to use /rit or /rit.jsp or both or how they differ apart from the output type is not obvious. Is it difficult to clean up rit.jsp or move rit.jsp logic into /rit servlet (and add a redirect in branch-2) ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26125) Backport HBASE-25401 "Add trace support for async call in rpc client" to branch-2
[ https://issues.apache.org/jira/browse/HBASE-26125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17391834#comment-17391834 ] Tak-Lon (Stephen) Wu commented on HBASE-26125: -- commit [https://github.com/apache/hbase/commit/ca096437d7e096b514ddda53ec2f97b85d90752d] merged to branch-2 > Backport HBASE-25401 "Add trace support for async call in rpc client" to > branch-2 > - > > Key: HBASE-26125 > URL: https://issues.apache.org/jira/browse/HBASE-26125 > Project: HBase > Issue Type: Sub-task > Components: tracing >Affects Versions: 2.5.0 >Reporter: Tak-Lon (Stephen) Wu >Assignee: Tak-Lon (Stephen) Wu >Priority: Major > > [2/17 commits of > HBASE-22120|https://github.com/apache/hbase/pull/2901/commits], original > commit of HBASE-25401 was > [https://github.com/apache/hbase/commit/242028671535dfed67ec13d9ed0d6067f3ccfd04] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #3535: HBASE-25469 Create RIT servlet in HMaster to track more detailed RIT info not captured in metrics
Apache-HBase commented on pull request #3535: URL: https://github.com/apache/hbase/pull/3535#issuecomment-891403504 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 5m 56s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 21s | master passed | | +1 :green_heart: | compile | 3m 13s | master passed | | +1 :green_heart: | checkstyle | 1m 11s | master passed | | +1 :green_heart: | spotbugs | 2m 12s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 3s | the patch passed | | +1 :green_heart: | compile | 3m 17s | the patch passed | | +1 :green_heart: | javac | 3m 17s | the patch passed | | -0 :warning: | checkstyle | 1m 9s | hbase-server: The patch generated 1 new + 89 unchanged - 0 fixed = 90 total (was 89) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 20m 9s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | +1 :green_heart: | spotbugs | 2m 25s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 56m 40s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3535/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3535 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 5baad65097aa 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / de84c1765a | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3535/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 86 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3535/2/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] caroliney14 commented on pull request #3535: HBASE-25469 Create RIT servlet in HMaster to track more detailed RIT info not captured in metrics
caroliney14 commented on pull request #3535: URL: https://github.com/apache/hbase/pull/3535#issuecomment-891403371 @bharathv I considered consolidating, but mainly wrote it this way so that 1) the url isn't so complex, and 2) the code is not dependent on this page/the complex url (we can also attach the servlet elsewhere if we want). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3551: HBASE-26165 Fix the 2.3.6 downloads page version column
Apache-HBase commented on pull request #3551: URL: https://github.com/apache/hbase/pull/3551#issuecomment-891403388 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 27s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 2m 52s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3551/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3551 | | Optional Tests | | | uname | Linux 574fc009c9ad 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / de84c1765a | | Max. process+thread count | 46 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3551/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3551: HBASE-26165 Fix the 2.3.6 downloads page version column
Apache-HBase commented on pull request #3551: URL: https://github.com/apache/hbase/pull/3551#issuecomment-891403155 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 2s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | ||| _ Patch Compile Tests _ | ||| _ Other Tests _ | | | | 2m 16s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3551/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3551 | | Optional Tests | | | uname | Linux 8fbea0a180bb 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / de84c1765a | | Max. process+thread count | 44 (vs. ulimit of 3) | | modules | C: . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3551/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-26165) 2.3.5 listed on website downloads page but row intends to be for 2.3.6
[ https://issues.apache.org/jira/browse/HBASE-26165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-26165: --- Status: Patch Available (was: Open) > 2.3.5 listed on website downloads page but row intends to be for 2.3.6 > -- > > Key: HBASE-26165 > URL: https://issues.apache.org/jira/browse/HBASE-26165 > Project: HBase > Issue Type: Task > Components: website >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Trivial > > Typo on downloads.html. Row is for 2.3.6 but still says 2.3.5. > Missed in HBASE-26162. PR coming. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] joshelser opened a new pull request #3551: HBASE-26165 Fix the 2.3.6 downloads page version column
joshelser opened a new pull request #3551: URL: https://github.com/apache/hbase/pull/3551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-26165) 2.3.5 listed on website downloads page but row intends to be for 2.3.6
Josh Elser created HBASE-26165: -- Summary: 2.3.5 listed on website downloads page but row intends to be for 2.3.6 Key: HBASE-26165 URL: https://issues.apache.org/jira/browse/HBASE-26165 Project: HBase Issue Type: Task Components: website Reporter: Josh Elser Assignee: Josh Elser Typo on downloads.html. Row is for 2.3.6 but still says 2.3.5. Missed in HBASE-26162. PR coming. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-25469) Create RIT servlet in HMaster to track more detailed RIT info not captured in metrics
[
https://issues.apache.org/jira/browse/HBASE-25469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bharath Vissapragada updated HBASE-25469:
-
Affects Version/s: 2.3.7
2.4.6
3.0.0-alpha-1
> Create RIT servlet in HMaster to track more detailed RIT info not captured in
> metrics
> -
>
> Key: HBASE-25469
> URL: https://issues.apache.org/jira/browse/HBASE-25469
> Project: HBase
> Issue Type: Improvement
> Components: master
>Affects Versions: 3.0.0-alpha-1, 2.4.6, 2.3.7
>Reporter: Caroline Zhou
>Assignee: Caroline Zhou
>Priority: Minor
> Labels: observability
> Attachments: Screen Shot 2021-07-27 at 10.34.45.png, Screen Shot
> 2021-07-27 at 10.34.53.png
>
>
> In HBase 2.1+, there is a RIT jsp page that was added as part of HBASE-21410.
> There are some additional RIT details that would be helpful to have in one
> place:
> * RIT Start Time
> * RIT Duration (ms)
> * Server
> * Procedure Type
> This info can be added to the table under the {{/rit.jsp}} page, and we can
> also add a button on that page to view info as JSON, for easy parsing into
> metrics, etc. This JSON dump can be served as a servlet.
> We may also consider different ways of grouping the JSON results, such as by
> state, table, or server name, and/or adding counts of RIT by state or server
> name.
> !Screen Shot 2021-07-27 at 10.34.45.png!
> !Screen Shot 2021-07-27 at 10.34.53.png!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-25469) Create RIT servlet in HMaster to track more detailed RIT info not captured in metrics
[
https://issues.apache.org/jira/browse/HBASE-25469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bharath Vissapragada updated HBASE-25469:
-
Labels: observability (was: )
> Create RIT servlet in HMaster to track more detailed RIT info not captured in
> metrics
> -
>
> Key: HBASE-25469
> URL: https://issues.apache.org/jira/browse/HBASE-25469
> Project: HBase
> Issue Type: Improvement
> Components: master
>Reporter: Caroline Zhou
>Assignee: Caroline Zhou
>Priority: Minor
> Labels: observability
> Attachments: Screen Shot 2021-07-27 at 10.34.45.png, Screen Shot
> 2021-07-27 at 10.34.53.png
>
>
> In HBase 2.1+, there is a RIT jsp page that was added as part of HBASE-21410.
> There are some additional RIT details that would be helpful to have in one
> place:
> * RIT Start Time
> * RIT Duration (ms)
> * Server
> * Procedure Type
> This info can be added to the table under the {{/rit.jsp}} page, and we can
> also add a button on that page to view info as JSON, for easy parsing into
> metrics, etc. This JSON dump can be served as a servlet.
> We may also consider different ways of grouping the JSON results, such as by
> state, table, or server name, and/or adding counts of RIT by state or server
> name.
> !Screen Shot 2021-07-27 at 10.34.45.png!
> !Screen Shot 2021-07-27 at 10.34.53.png!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-25469) Create RIT servlet in HMaster to track more detailed RIT info not captured in metrics
[
https://issues.apache.org/jira/browse/HBASE-25469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bharath Vissapragada updated HBASE-25469:
-
Component/s: master
> Create RIT servlet in HMaster to track more detailed RIT info not captured in
> metrics
> -
>
> Key: HBASE-25469
> URL: https://issues.apache.org/jira/browse/HBASE-25469
> Project: HBase
> Issue Type: Improvement
> Components: master
>Reporter: Caroline Zhou
>Assignee: Caroline Zhou
>Priority: Minor
> Attachments: Screen Shot 2021-07-27 at 10.34.45.png, Screen Shot
> 2021-07-27 at 10.34.53.png
>
>
> In HBase 2.1+, there is a RIT jsp page that was added as part of HBASE-21410.
> There are some additional RIT details that would be helpful to have in one
> place:
> * RIT Start Time
> * RIT Duration (ms)
> * Server
> * Procedure Type
> This info can be added to the table under the {{/rit.jsp}} page, and we can
> also add a button on that page to view info as JSON, for easy parsing into
> metrics, etc. This JSON dump can be served as a servlet.
> We may also consider different ways of grouping the JSON results, such as by
> state, table, or server name, and/or adding counts of RIT by state or server
> name.
> !Screen Shot 2021-07-27 at 10.34.45.png!
> !Screen Shot 2021-07-27 at 10.34.53.png!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] bharathv commented on a change in pull request #3550: HBASE-26150 Let region server also carry ClientMetaService
bharathv commented on a change in pull request #3550:
URL: https://github.com/apache/hbase/pull/3550#discussion_r681325431
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcConnectionRegistry.java
##
@@ -0,0 +1,99 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.client;
+
+import java.io.IOException;
+import java.util.List;
+import java.util.concurrent.CompletableFuture;
+import java.util.stream.Collectors;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseInterfaceAudience;
+import org.apache.hadoop.hbase.ServerName;
+import org.apache.yetus.audience.InterfaceAudience;
+
+import org.apache.hbase.thirdparty.com.google.common.base.Splitter;
+
+import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil;
+import
org.apache.hadoop.hbase.shaded.protobuf.generated.RegistryProtos.ClientMetaService;
+import
org.apache.hadoop.hbase.shaded.protobuf.generated.RegistryProtos.GetBootstrapNodesRequest;
+import
org.apache.hadoop.hbase.shaded.protobuf.generated.RegistryProtos.GetBootstrapNodesResponse;
+
+/**
+ * Rpc based connection registry. It will make use of the {@link
ClientMetaService} to get registry
+ * information.
+ *
+ * It needs bootstrap node list when start up, and then it will use {@link
ClientMetaService} to
+ * refresh the bootstrap node list periodically.
+ *
+ * Usually, you could set masters as the bootstrap nodes,as they will also
implement the
+ * {@link ClientMetaService}, and then, we will switch to use region servers
after refreshing the
+ * bootstrap nodes.
+ */
+@InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.CONFIG)
+public class RpcConnectionRegistry extends AbstractRpcBasedConnectionRegistry {
+
+ /** Configuration key that controls the fan out of requests **/
+ public static final String HEDGED_REQS_FANOUT_KEY =
"hbase.client.rpc_registry.hedged.fanout";
+
+ public static final String PERIODIC_REFRESH_INTERVAL_SECS =
+"hbase.client.rpc_registry.refresh_interval_secs";
+
+ public static final String MIN_SECS_BETWEEN_REFRESHES =
+"hbase.client.rpc_registry.min_secs_between_refreshes";
+
+ public static final String BOOTSTRAP_NODES =
"hbase.client.rpc_registry.bootstrap_nodes";
Review comment:
nit: We can use a more simpler config hbase.client.bootstrap.servers or
hbase.client.connection.boostrap.servers? I feel rpc_registry is an internal
thing and not obvious to operators. Open to suggestions these are two things
that that popped into my head (first one inspired by kafka.bootstrap.servers)
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/MasterRegistry.java
##
@@ -79,36 +51,27 @@
* TODO: Handle changes to the configuration dynamically without having to
restart the client.
*/
@InterfaceAudience.Private
-public class MasterRegistry implements ConnectionRegistry {
+public class MasterRegistry extends AbstractRpcBasedConnectionRegistry {
/** Configuration key that controls the fan out of requests **/
public static final String MASTER_REGISTRY_HEDGED_REQS_FANOUT_KEY =
"hbase.client.master_registry.hedged.fanout";
- /** Default value for the fan out of hedged requests. **/
- public static final int MASTER_REGISTRY_HEDGED_REQS_FANOUT_DEFAULT = 2;
+ public static final String MASTER_REGISTRY_PERIODIC_REFRESH_INTERVAL_SECS =
+"hbase.client.master_registry.refresh_interval_secs";
- private static final String MASTER_ADDRS_CONF_SEPARATOR = ",";
-
- private final int hedgedReadFanOut;
-
- // Configured list of masters to probe the meta information from.
- private volatile ImmutableMap
masterAddr2Stub;
-
- // RPC client used to talk to the masters.
- private final RpcClient rpcClient;
- private final RpcControllerFactory rpcControllerFactory;
- private final int rpcTimeoutMs;
+ public static final String MASTER_REGISTRY_MIN_SECS_BETWEEN_REFRESHES =
+"hbase.client.master_registry.min_secs_between_refreshes";
- protected final MasterAddressRefresher masterAddressRefresher;
+ private static final String MASTER_ADDRS_CONF_SEPARATOR = ",";
/**
*
[jira] [Commented] (HBASE-26164) Update dependencies in hbase-filesystem
[ https://issues.apache.org/jira/browse/HBASE-26164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17391824#comment-17391824 ] Josh Elser commented on HBASE-26164: Bonus, it seems like when we update to Hadoop 3.3, we get some new API coming in on S3a which we need to account for in hbase-oss tests. > Update dependencies in hbase-filesystem > --- > > Key: HBASE-26164 > URL: https://issues.apache.org/jira/browse/HBASE-26164 > Project: HBase > Issue Type: Task > Components: hboss >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Major > Fix For: hbase-filesystem-1.0.0-alpha2 > > > hbase-filesystem still has some old dependencies. Notably aws-java-sdk is at > 1.11.525 whereas hadoop is all the way at 1.11.1026. > We're also still building HBase 2 against 2.1.4 instead of anything newer. > Bump up the relevant dependencies to something more current and make sure the > code still works. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-26164) Update dependencies in hbase-filesystem
Josh Elser created HBASE-26164: -- Summary: Update dependencies in hbase-filesystem Key: HBASE-26164 URL: https://issues.apache.org/jira/browse/HBASE-26164 Project: HBase Issue Type: Task Components: hboss Reporter: Josh Elser Assignee: Josh Elser Fix For: hbase-filesystem-1.0.0-alpha2 hbase-filesystem still has some old dependencies. Notably aws-java-sdk is at 1.11.525 whereas hadoop is all the way at 1.11.1026. We're also still building HBase 2 against 2.1.4 instead of anything newer. Bump up the relevant dependencies to something more current and make sure the code still works. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] caroliney14 commented on a change in pull request #3535: HBASE-25469 Create RIT servlet in HMaster to track more detailed RIT info not captured in metrics
caroliney14 commented on a change in pull request #3535:
URL: https://github.com/apache/hbase/pull/3535#discussion_r681314405
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/http/RitServlet.java
##
@@ -0,0 +1,93 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.master.http;
+
+import java.io.IOException;
+import java.io.OutputStream;
+import java.io.PrintWriter;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+import org.apache.hadoop.hbase.master.HMaster;
+import org.apache.hadoop.hbase.master.RegionState;
+import org.apache.hadoop.hbase.master.assignment.AssignmentManager;
+import org.apache.hadoop.hbase.master.assignment.RegionStateNode;
+import org.apache.hadoop.hbase.master.assignment.TransitRegionStateProcedure;
+import org.apache.hadoop.hbase.util.GsonUtil;
+import org.apache.hbase.thirdparty.com.google.gson.Gson;
+import org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.DefaultServlet;
+import org.apache.yetus.audience.InterfaceAudience;
+
+@InterfaceAudience.Private
+public class RitServlet extends DefaultServlet {
+ private static final long serialVersionUID = 1L;
+ private static final Gson GSON = GsonUtil.createGson().create();
+
+ @Override
+ public void doGet(HttpServletRequest request, HttpServletResponse response)
+throws IOException {
+HMaster master = (HMaster)
getServletContext().getAttribute(HMaster.MASTER);
+assert master != null : "No Master in context!";
+
+response.setContentType("application/json");
+OutputStream os = response.getOutputStream();
+
+try (PrintWriter out = new PrintWriter(os)) {
+
+ AssignmentManager am = master.getAssignmentManager();
+ if (am == null) {
+out.println("AssignmentManager is not initialized");
+return;
+ }
+
+ Map>> map = new HashMap<>();
+ List> rits = new ArrayList<>();
+ map.put("rits", rits);
+ for (RegionStateNode regionStateNode : am.getRegionsInTransition()) {
+Map rit = new HashMap<>();
+rit.put("region", regionStateNode.getRegionInfo().getEncodedName());
+rit.put("table",
regionStateNode.getRegionInfo().getTable().getNameAsString());
+rit.put("state", regionStateNode.getState());
+rit.put("server", regionStateNode.getRegionLocation().getServerName());
+
+TransitRegionStateProcedure procedure = regionStateNode.getProcedure();
+if (procedure != null) {
+ rit.put("procedureId", procedure.getProcId());
+ rit.put("procedureState", procedure.getState().toString());
+}
+
+RegionState rs = regionStateNode.toRegionState();
+rit.put("startTime", rs.getStamp());
+rit.put("duration", System.currentTimeMillis() - rs.getStamp());
+
+rits.add(rit);
+ }
+
+ if (rits.isEmpty()) {
+out.write("There are currently no regions in transition.");
Review comment:
is it okay to return an empty map then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] apurtell commented on a change in pull request #3535: HBASE-25469 Create RIT servlet in HMaster to track more detailed RIT info not captured in metrics
apurtell commented on a change in pull request #3535:
URL: https://github.com/apache/hbase/pull/3535#discussion_r681301709
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##
@@ -659,6 +660,7 @@ protected RSRpcServices createRpcServices() throws
IOException {
@Override
protected void configureInfoServer() {
infoServer.addUnprivilegedServlet("master-status", "/master-status",
MasterStatusServlet.class);
+infoServer.addPrivilegedServlet("rits", "/rits", RitServlet.class);
Review comment:
Nit: Let's call it "/rit".
Not a big deal, but other paths are not in the plural form.
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/http/RitServlet.java
##
@@ -0,0 +1,93 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.master.http;
+
+import java.io.IOException;
+import java.io.OutputStream;
+import java.io.PrintWriter;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+import org.apache.hadoop.hbase.master.HMaster;
+import org.apache.hadoop.hbase.master.RegionState;
+import org.apache.hadoop.hbase.master.assignment.AssignmentManager;
+import org.apache.hadoop.hbase.master.assignment.RegionStateNode;
+import org.apache.hadoop.hbase.master.assignment.TransitRegionStateProcedure;
+import org.apache.hadoop.hbase.util.GsonUtil;
+import org.apache.hbase.thirdparty.com.google.gson.Gson;
+import org.apache.hbase.thirdparty.org.eclipse.jetty.servlet.DefaultServlet;
+import org.apache.yetus.audience.InterfaceAudience;
+
+@InterfaceAudience.Private
+public class RitServlet extends DefaultServlet {
+ private static final long serialVersionUID = 1L;
+ private static final Gson GSON = GsonUtil.createGson().create();
+
+ @Override
+ public void doGet(HttpServletRequest request, HttpServletResponse response)
+throws IOException {
+HMaster master = (HMaster)
getServletContext().getAttribute(HMaster.MASTER);
+assert master != null : "No Master in context!";
+
+response.setContentType("application/json");
+OutputStream os = response.getOutputStream();
+
+try (PrintWriter out = new PrintWriter(os)) {
+
+ AssignmentManager am = master.getAssignmentManager();
+ if (am == null) {
+out.println("AssignmentManager is not initialized");
+return;
+ }
+
+ Map>> map = new HashMap<>();
+ List> rits = new ArrayList<>();
+ map.put("rits", rits);
+ for (RegionStateNode regionStateNode : am.getRegionsInTransition()) {
+Map rit = new HashMap<>();
+rit.put("region", regionStateNode.getRegionInfo().getEncodedName());
+rit.put("table",
regionStateNode.getRegionInfo().getTable().getNameAsString());
+rit.put("state", regionStateNode.getState());
+rit.put("server", regionStateNode.getRegionLocation().getServerName());
+
+TransitRegionStateProcedure procedure = regionStateNode.getProcedure();
+if (procedure != null) {
+ rit.put("procedureId", procedure.getProcId());
+ rit.put("procedureState", procedure.getState().toString());
+}
+
+RegionState rs = regionStateNode.toRegionState();
+rit.put("startTime", rs.getStamp());
+rit.put("duration", System.currentTimeMillis() - rs.getStamp());
+
+rits.add(rit);
+ }
+
+ if (rits.isEmpty()) {
+out.write("There are currently no regions in transition.");
Review comment:
This is not valid JSON.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (HBASE-26163) Better logging in RSGroupInfoManagerImpl
Caroline Zhou created HBASE-26163: - Summary: Better logging in RSGroupInfoManagerImpl Key: HBASE-26163 URL: https://issues.apache.org/jira/browse/HBASE-26163 Project: HBase Issue Type: Improvement Reporter: Caroline Zhou Assignee: Caroline Zhou -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25690) Specify and document the criteria for moving the 'stable' pointer
[ https://issues.apache.org/jira/browse/HBASE-25690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17391807#comment-17391807 ] Nick Dimiduk commented on HBASE-25690: -- One criteria that comes to my mind is use of a data correctness test (i.e., ITBLL) in the face of Chaos. We've never had resources in Apache to run such a test on a regular cadence, so to use this as a criteria, we'd need to rely on community-reported experiences. Perhaps we could include some criteria for launch parameters and successful completion for such a job as part of our "stable" definition. > Specify and document the criteria for moving the 'stable' pointer > - > > Key: HBASE-25690 > URL: https://issues.apache.org/jira/browse/HBASE-25690 > Project: HBase > Issue Type: Task > Components: documentation >Reporter: Andrew Kyle Purtell >Priority: Major > > We can consider reported experience with new code lines released ahead of > where the stable pointer currently points, when and if it happens but this > should not be a formal criteria because it has nothing directly to do with > our PMC or project. We need a criteria for deciding when new code lines are > sufficiently stable as to warrant moving the 'stable' pointer that we as > project and PMC can achieve and implement effectively. > IMHO "one of our project devs has it running" does not meet that requirement, > because this depends on third party organizations (a dev's employer, and > such) and idiosyncratic criteria. > Collect and document requirements, test scenarios, and success (and failure) > criteria. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-26157) Expose some IA.LimitedPrivate interface in TestingHBaseCluster
[ https://issues.apache.org/jira/browse/HBASE-26157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17391770#comment-17391770 ] Geoffrey Jacoby commented on HBASE-26157: - Thanks, [~zhangduo] I'm very interested in seeing what this proposal looks like. My concern is: What if we miss some needed method on the interface, and we don't realize it until after HBase 3.0 is released? Am I correct that because of semver the soonest a fix to the interface could be released would be HBase 3.1, and that the fix could not be backported to 3.0.x? Minor versions usually come out about annually, so we're giving client developers the choice between waiting up to a year, or using an IA.Private class that works right now but could break later. And for applications (or projects such as Phoenix) that need to support multiple versions of HBase, evolving interfaces in minor releases make compatibility really hard. > Expose some IA.LimitedPrivate interface in TestingHBaseCluster > -- > > Key: HBASE-26157 > URL: https://issues.apache.org/jira/browse/HBASE-26157 > Project: HBase > Issue Type: Sub-task > Components: API, test >Reporter: Duo Zhang >Priority: Major > > For example, the coprocessor related interfaces such as Region, Store, etc. > And for tags, since there is no way to get it at client side, we need to > expose some server side interfaces to allow users get them. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] taklwu merged pull request #3543: HBASE-26125 Backport HBASE-25401 "Add trace support for async call in…
taklwu merged pull request #3543: URL: https://github.com/apache/hbase/pull/3543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] taklwu commented on pull request #3529: HBASE-26124 Backport HBASE-25373 "Remove HTrace completely in code base and try to make use of OpenTelemetry" to branch-2
taklwu commented on pull request #3529: URL: https://github.com/apache/hbase/pull/3529#issuecomment-891242759 @Apache9 hey Duo, having your +1 is good and it's never late to comment!. I actually had done all 17 commits in a private repository, base on my journey merging all conflicts, I felt like this feature is just independent from others. IMO we can just keep rolling it directly into branch-2. so, what is your concern on other issues? can you share a bit more information on that ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26154) Provide exception metric for quota exceeded and throttling
[ https://issues.apache.org/jira/browse/HBASE-26154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17391762#comment-17391762 ] Bryan Beaudreault commented on HBASE-26154: --- [~PankajKumar] is there anything I should do here? To be honest, I've found the ci-hadoop builds to be very very flaky recently so I sort of doubt this is related to my change. Additionally, I see the nightly build has been failing for over a month: [https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/.|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/] Not sure if that's accurate. > Provide exception metric for quota exceeded and throttling > -- > > Key: HBASE-26154 > URL: https://issues.apache.org/jira/browse/HBASE-26154 > Project: HBase > Issue Type: Improvement >Reporter: Bryan Beaudreault >Assignee: Bryan Beaudreault >Priority: Minor > Fix For: 2.5.0, 3.0.0-alpha-2, 2.4.6 > > > We should add metrics for QuotaExceededException and RpcThrottlingException. > This is something we've found very useful to track as it helps us identify > bad access patterns in clients. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-26154) Provide exception metric for quota exceeded and throttling
[
https://issues.apache.org/jira/browse/HBASE-26154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17391752#comment-17391752
]
Hudson commented on HBASE-26154:
Results for branch branch-2
[build #312 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/312/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/312/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/312/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/312/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/312/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/312//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Provide exception metric for quota exceeded and throttling
> --
>
> Key: HBASE-26154
> URL: https://issues.apache.org/jira/browse/HBASE-26154
> Project: HBase
> Issue Type: Improvement
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Minor
> Fix For: 2.5.0, 3.0.0-alpha-2, 2.4.6
>
>
> We should add metrics for QuotaExceededException and RpcThrottlingException.
> This is something we've found very useful to track as it helps us identify
> bad access patterns in clients.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (HBASE-26162) Release 2.3.6
[ https://issues.apache.org/jira/browse/HBASE-26162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-26162. --- Fix Version/s: 2.3.7 Assignee: Michael Stack Resolution: Fixed Sent announcement email, ran all steps in above list. Downloads will update tonight. Resolving. > Release 2.3.6 > - > > Key: HBASE-26162 > URL: https://issues.apache.org/jira/browse/HBASE-26162 > Project: HBase > Issue Type: Task >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > Fix For: 2.3.7 > > Attachments: image-2021-08-02-09-54-56-469.png > > > 2.3.6RC3 was voted as 2.3.6 release. > Run the release steps listed here for 2.3.6 > !image-2021-08-02-09-54-56-469.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #3030: HBASE-25634 The client scan frequently exceeds the quota, which cause…
Apache-HBase commented on pull request #3030: URL: https://github.com/apache/hbase/pull/3030#issuecomment-891194179 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 17s | branch-2 passed | | +1 :green_heart: | compile | 0m 32s | branch-2 passed | | +1 :green_heart: | shadedjars | 7m 9s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 32s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 11s | the patch passed | | +1 :green_heart: | compile | 0m 32s | the patch passed | | +1 :green_heart: | javac | 0m 32s | the patch passed | | +1 :green_heart: | shadedjars | 7m 19s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 30s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 48s | hbase-client in the patch passed. | | | | 29m 30s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3030/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3030 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux b6cfb90cf8d1 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / da9bcb6099 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3030/1/testReport/ | | Max. process+thread count | 302 (vs. ulimit of 12500) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3030/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3030: HBASE-25634 The client scan frequently exceeds the quota, which cause…
Apache-HBase commented on pull request #3030: URL: https://github.com/apache/hbase/pull/3030#issuecomment-891190922 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 10s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 0s | branch-2 passed | | +1 :green_heart: | compile | 1m 5s | branch-2 passed | | +1 :green_heart: | checkstyle | 0m 34s | branch-2 passed | | +1 :green_heart: | spotbugs | 1m 13s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 41s | the patch passed | | +1 :green_heart: | compile | 1m 3s | the patch passed | | +1 :green_heart: | javac | 1m 3s | the patch passed | | +1 :green_heart: | checkstyle | 0m 34s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 13m 32s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 1m 28s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. | | | | 36m 53s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3030/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3030 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux a03ebfa62d01 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / da9bcb6099 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 86 (vs. ulimit of 12500) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3030/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3030: HBASE-25634 The client scan frequently exceeds the quota, which cause…
Apache-HBase commented on pull request #3030: URL: https://github.com/apache/hbase/pull/3030#issuecomment-891187622 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 17s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 6s | branch-2 passed | | +1 :green_heart: | compile | 0m 26s | branch-2 passed | | +1 :green_heart: | shadedjars | 7m 1s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 26s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 44s | the patch passed | | +1 :green_heart: | compile | 0m 26s | the patch passed | | +1 :green_heart: | javac | 0m 26s | the patch passed | | +1 :green_heart: | shadedjars | 7m 6s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 23s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 40s | hbase-client in the patch passed. | | | | 28m 43s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3030/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3030 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux a2eedb324b07 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / da9bcb6099 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3030/1/testReport/ | | Max. process+thread count | 233 (vs. ulimit of 12500) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3030/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26162) Release 2.3.6
[ https://issues.apache.org/jira/browse/HBASE-26162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17391704#comment-17391704 ] Michael Stack commented on HBASE-26162: --- Moved stable pointer from 2.3.5 to 2.3.6. > Release 2.3.6 > - > > Key: HBASE-26162 > URL: https://issues.apache.org/jira/browse/HBASE-26162 > Project: HBase > Issue Type: Task >Reporter: Michael Stack >Priority: Major > Attachments: image-2021-08-02-09-54-56-469.png > > > 2.3.6RC3 was voted as 2.3.6 release. > Run the release steps listed here for 2.3.6 > !image-2021-08-02-09-54-56-469.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #3550: HBASE-26150 Let region server also carry ClientMetaService
Apache-HBase commented on pull request #3550: URL: https://github.com/apache/hbase/pull/3550#issuecomment-891181797 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 20s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | prototool | 0m 0s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 26s | master passed | | +1 :green_heart: | compile | 6m 49s | master passed | | +1 :green_heart: | checkstyle | 2m 4s | master passed | | +1 :green_heart: | spotbugs | 7m 55s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 5s | the patch passed | | +1 :green_heart: | compile | 6m 26s | the patch passed | | +1 :green_heart: | cc | 6m 26s | the patch passed | | +1 :green_heart: | javac | 6m 26s | the patch passed | | -0 :warning: | checkstyle | 1m 11s | hbase-server: The patch generated 4 new + 172 unchanged - 7 fixed = 176 total (was 179) | | -0 :warning: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | +1 :green_heart: | hadoopcheck | 24m 37s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | +1 :green_heart: | hbaseprotoc | 3m 43s | the patch passed | | +1 :green_heart: | spotbugs | 14m 35s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 1m 30s | The patch does not generate ASF License warnings. | | | | 92m 53s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3550 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool | | uname | Linux 0e536760ff4a 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 2e9ab3ce94 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | whitespace | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/1/artifact/yetus-general-check/output/whitespace-eol.txt | | Max. process+thread count | 86 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-zookeeper hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-26162) Release 2.3.6
Michael Stack created HBASE-26162: - Summary: Release 2.3.6 Key: HBASE-26162 URL: https://issues.apache.org/jira/browse/HBASE-26162 Project: HBase Issue Type: Task Reporter: Michael Stack Attachments: image-2021-08-02-09-54-56-469.png 2.3.6RC3 was voted as 2.3.6 release. Run the release steps listed here for 2.3.6 !image-2021-08-02-09-54-56-469.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-26027) The calling of HTable.batch blocked at AsyncRequestFutureImpl.waitUntilDone caused by ArrayStoreException
[
https://issues.apache.org/jira/browse/HBASE-26027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Stack updated HBASE-26027:
--
Fix Version/s: (was: 2.3.6)
2.3.7
> The calling of HTable.batch blocked at AsyncRequestFutureImpl.waitUntilDone
> caused by ArrayStoreException
> -
>
> Key: HBASE-26027
> URL: https://issues.apache.org/jira/browse/HBASE-26027
> Project: HBase
> Issue Type: Bug
> Components: Client
>Affects Versions: 2.2.7, 2.3.5, 2.4.4
>Reporter: Zheng Wang
>Assignee: Zheng Wang
>Priority: Major
> Fix For: 2.5.0, 2.4.6, 2.3.7
>
>
> The batch api of HTable contains a param named results to store result or
> exception, its type is Object[].
> If user pass an array with other type, eg:
> org.apache.hadoop.hbase.client.Result, and if we need to put an exception
> into it by some reason, then the ArrayStoreException will occur in
> AsyncRequestFutureImpl.updateResult, then the
> AsyncRequestFutureImpl.decActionCounter will be skipped, then in the
> AsyncRequestFutureImpl.waitUntilDone we will stuck at here checking the
> actionsInProgress again and again, forever.
> It is better to add an cutoff calculated by operationTimeout, instead of only
> depend on the value of actionsInProgress.
> BTW, this issue only for 2.x, since 3.x the implement has refactored.
> How to reproduce:
> 1: add sleep in RSRpcServices.multi to mock slow response
> {code:java}
> try {
> Thread.sleep(2000);
> } catch (InterruptedException e) {
> e.printStackTrace();
> }
> {code}
> 2: set time out in config
> {code:java}
> conf.set("hbase.rpc.timeout","2000");
> conf.set("hbase.client.operation.timeout","6000");
> {code}
> 3: call batch api
> {code:java}
> Table table = HbaseUtil.getTable("test");
> byte[] cf = Bytes.toBytes("f");
> byte[] c = Bytes.toBytes("c1");
> List gets = new ArrayList<>();
> for (int i = 0; i < 10; i++) {
> byte[] rk = Bytes.toBytes("rk-" + i);
> Get get = new Get(rk);
> get.addColumn(cf, c);
> gets.add(get);
> }
> Result[] results = new Result[gets.size()];
> table.batch(gets, results);
> {code}
> The log will looks like below:
> {code:java}
> [ERROR] [2021/06/22 23:23:00,676] hconnection-0x6b927fb-shared-pool3-t1 -
> id=1 error for test processing localhost,16020,1624343786295
> java.lang.ArrayStoreException: org.apache.hadoop.hbase.DoNotRetryIOException
> at
> org.apache.hadoop.hbase.client.AsyncRequestFutureImpl.updateResult(AsyncRequestFutureImpl.java:1242)
> at
> org.apache.hadoop.hbase.client.AsyncRequestFutureImpl.trySetResultSimple(AsyncRequestFutureImpl.java:1087)
> at
> org.apache.hadoop.hbase.client.AsyncRequestFutureImpl.setError(AsyncRequestFutureImpl.java:1021)
> at
> org.apache.hadoop.hbase.client.AsyncRequestFutureImpl.manageError(AsyncRequestFutureImpl.java:683)
> at
> org.apache.hadoop.hbase.client.AsyncRequestFutureImpl.receiveGlobalFailure(AsyncRequestFutureImpl.java:716)
> at
> org.apache.hadoop.hbase.client.AsyncRequestFutureImpl.access$1500(AsyncRequestFutureImpl.java:69)
> at
> org.apache.hadoop.hbase.client.AsyncRequestFutureImpl$SingleServerRequestRunnable.run(AsyncRequestFutureImpl.java:219)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run$$$capture(FutureTask.java:266)
> at java.util.concurrent.FutureTask.run(FutureTask.java)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> [INFO ] [2021/06/22 23:23:10,375] main - #1, waiting for 10 actions to
> finish on table: test
> [INFO ] [2021/06/22 23:23:20,378] main - #1, waiting for 10 actions to
> finish on table: test
> [INFO ] [2021/06/22 23:23:30,384] main - #1, waiting for 10 actions to
> finish on table:
> [INFO ] [2021/06/22 23:23:40,387] main - #1, waiting for 10 actions to
> finish on table: test
> [INFO ] [2021/06/22 23:23:50,397] main - #1, waiting for 10 actions to
> finish on table: test
> [INFO ] [2021/06/22 23:24:00,400] main - #1, waiting for 10 actions to
> finish on table: test
> [INFO ] [2021/06/22 23:24:10,408] main - #1, waiting for 10 actions to
> finish on table: test
> [INFO ] [2021/06/22 23:24:20,413] main - #1, waiting for 10 actions to
> finish on table: test
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #3550: HBASE-26150 Let region server also carry ClientMetaService
Apache-HBase commented on pull request #3550: URL: https://github.com/apache/hbase/pull/3550#issuecomment-891160598 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 43s | master passed | | +1 :green_heart: | compile | 3m 14s | master passed | | +1 :green_heart: | shadedjars | 8m 41s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 46s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 28s | the patch passed | | +1 :green_heart: | compile | 3m 5s | the patch passed | | +1 :green_heart: | javac | 3m 5s | the patch passed | | +1 :green_heart: | shadedjars | 8m 32s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 27s | hbase-client generated 1 new + 55 unchanged - 0 fixed = 56 total (was 55) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 0s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 21s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 0m 46s | hbase-zookeeper in the patch passed. | | -1 :x: | unit | 8m 57s | hbase-server in the patch failed. | | | | 51m 36s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3550 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 328d8c697e89 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 2e9ab3ce94 | | Default Java | AdoptOpenJDK-11.0.10+9 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/1/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-client.txt | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/1/testReport/ | | Max. process+thread count | 1045 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-zookeeper hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-25975) Row commit sequencer
[ https://issues.apache.org/jira/browse/HBASE-25975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25975: Fix Version/s: (was: 3.0.0-alpha-2) (was: 2.5.0) > Row commit sequencer > > > Key: HBASE-25975 > URL: https://issues.apache.org/jira/browse/HBASE-25975 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Reporter: Andrew Kyle Purtell >Assignee: Andrew Kyle Purtell >Priority: Major > Attachments: jmh.txt, results.txt, results_baseline.txt > > > Use a row commit sequencer in HRegion to ensure that only the operations that > mutate disjoint sets of rows are able to commit within the same clock tick. > This maintains the invariant that more than one mutation to a given row will > never be committed in the same clock tick. > Callers will first acquire row locks for the row(s) the pending mutation will > mutate. Then they will use RowCommitSequencer.getRowSequence to ensure that > the set of rows about to be mutated do not overlap with those for any other > pending mutations in the current clock tick. If an overlap is identified, > getRowSequence will yield and loop until there is no longer an overlap and > the caller's pending mutation can succeed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24440) Prevent temporal misordering on timescales smaller than one clock tick
[ https://issues.apache.org/jira/browse/HBASE-24440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17391685#comment-17391685 ] Andrew Kyle Purtell commented on HBASE-24440: - I have HBASE-25975 working reasonably well in a test environment and unit tests are passing. Will collect macro benchmark results and report back. > Prevent temporal misordering on timescales smaller than one clock tick > -- > > Key: HBASE-24440 > URL: https://issues.apache.org/jira/browse/HBASE-24440 > Project: HBase > Issue Type: Brainstorming >Reporter: Andrew Kyle Purtell >Assignee: Andrew Kyle Purtell >Priority: Major > > When mutations are sent to the servers without a timestamp explicitly > assigned by the client the server will substitute the current wall clock > time. There are edge cases where it is at least theoretically possible for > more than one mutation to be committed to a given row within the same clock > tick. When this happens we have to track and preserve the ordering of these > mutations in some other way besides the timestamp component of the key. Let > me bypass most discussion here by noting that whether we do this or not, we > do not pass such ordering information in the cross cluster replication > protocol. We also have interesting edge cases regarding key type precedence > when mutations arrive "simultaneously": we sort deletes ahead of puts. This, > especially in the presence of replication, can lead to visible anomalies for > clients able to interact with both source and sink. > There is a simple solution that removes the possibility that these edge cases > can occur: > We can detect, when we are about to commit a mutation to a row, if we have > already committed a mutation to this same row in the current clock tick. > Occurrences of this condition will be rare. We are already tracking current > time. We have to know this in order to assign the timestamp. Where this > becomes interesting is how we might track the last commit time per row. > Making the detection of this case efficient for the normal code path is the > bulk of the challenge. One option is to keep track of the last locked time > for row locks. (Todo: How would we track and garbage collect this efficiently > and correctly. Not the ideal option.) We might also do this tracking somehow > via the memstore. (At least in this case the lifetime and distribution of in > memory row state, including the proposed timestamps, would align.) Assuming > we can efficiently know if we are about to commit twice to the same row > within a single clock tick, we would simply sleep/yield the current thread > until the clock ticks over, and then proceed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24440) Prevent temporal misordering on timescales smaller than one clock tick
[ https://issues.apache.org/jira/browse/HBASE-24440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-24440: Fix Version/s: (was: 3.0.0-alpha-2) (was: 2.5.0) > Prevent temporal misordering on timescales smaller than one clock tick > -- > > Key: HBASE-24440 > URL: https://issues.apache.org/jira/browse/HBASE-24440 > Project: HBase > Issue Type: Brainstorming >Reporter: Andrew Kyle Purtell >Assignee: Andrew Kyle Purtell >Priority: Major > > When mutations are sent to the servers without a timestamp explicitly > assigned by the client the server will substitute the current wall clock > time. There are edge cases where it is at least theoretically possible for > more than one mutation to be committed to a given row within the same clock > tick. When this happens we have to track and preserve the ordering of these > mutations in some other way besides the timestamp component of the key. Let > me bypass most discussion here by noting that whether we do this or not, we > do not pass such ordering information in the cross cluster replication > protocol. We also have interesting edge cases regarding key type precedence > when mutations arrive "simultaneously": we sort deletes ahead of puts. This, > especially in the presence of replication, can lead to visible anomalies for > clients able to interact with both source and sink. > There is a simple solution that removes the possibility that these edge cases > can occur: > We can detect, when we are about to commit a mutation to a row, if we have > already committed a mutation to this same row in the current clock tick. > Occurrences of this condition will be rare. We are already tracking current > time. We have to know this in order to assign the timestamp. Where this > becomes interesting is how we might track the last commit time per row. > Making the detection of this case efficient for the normal code path is the > bulk of the challenge. One option is to keep track of the last locked time > for row locks. (Todo: How would we track and garbage collect this efficiently > and correctly. Not the ideal option.) We might also do this tracking somehow > via the memstore. (At least in this case the lifetime and distribution of in > memory row state, including the proposed timestamps, would align.) Assuming > we can efficiently know if we are about to commit twice to the same row > within a single clock tick, we would simply sleep/yield the current thread > until the clock ticks over, and then proceed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-25913) Introduce EnvironmentEdge.currentTimeAdvancing
[
https://issues.apache.org/jira/browse/HBASE-25913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell updated HBASE-25913:
Fix Version/s: (was: 3.0.0-alpha-2)
(was: 2.5.0)
Resolution: Abandoned
Status: Resolved (was: Patch Available)
Row commit sequencer is the preferred approach, stashing this issue and its
findings.
> Introduce EnvironmentEdge.currentTimeAdvancing
> --
>
> Key: HBASE-25913
> URL: https://issues.apache.org/jira/browse/HBASE-25913
> Project: HBase
> Issue Type: Sub-task
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Attachments: HBASE-25913_Multithreaded_Benchmarks.pdf,
> JMH-HBASE-25913.pdf, jmh-HBASE-25913.tar.gz
>
>
> Introduce new {{EnvironmentEdge#currentTimeAdvancing}} which ensures that
> when the current time is returned, it is the current time in a different
> clock tick from the last time the {{EnvironmentEdge}} was used to get the
> current time.
> When processing mutations we substitute the {{Long.MAX_VALUE}} timestamp
> placeholder with a real placeholder just before committing the mutation. The
> current code gets the current time for timestamp substitution while under row
> lock and mvcc. We will simply use {{EnvironmentEdge#currentTimeAdvancing}}
> instead of {{EnvironmentEdge#currentTime}} at this point in the code to
> ensure we have seen the clock tick over. When processing a batch of mutations
> (doMiniBatchMutation etc) we will call {{currentTimeAdvancing}} only once.
> This means the client cannot bundle cells with wildcard timestamps into a
> batch where those cells must be committed with different timestamps. Clients
> must simply not submit mutations that must be committed with guaranteed
> distinct timestamps in the same batch. Easy to understand, easy to document,
> and it aligns with our design philosophy of the client knows best.
> It is not required to handle batches as proposed. We could guarantee a
> distinct timestamp for every mutation in a batch. Count the number of
> mutations, call this M. Acquire all row locks and get the current time. Then,
> wait for at least M milliseconds. Then, set the first mutation timestamp with
> this value and increment by 1 for all remaining. Then, do the rest of
> mutation processing as normal. I don't think this extra waiting to reserve
> the range of timestamps is necessary. See reasoning in above paragraph.
> Mentioned here for sake of discussion.
> It will be fine to continue to use {{EnvironmentEdge#currentTime}} everywhere
> else. In this way we will only potentially spin wait where it matters, and
> won't suffer serious overheads during batch processing.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #3550: HBASE-26150 Let region server also carry ClientMetaService
Apache-HBase commented on pull request #3550: URL: https://github.com/apache/hbase/pull/3550#issuecomment-891152474 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 53s | master passed | | +1 :green_heart: | compile | 2m 31s | master passed | | +1 :green_heart: | shadedjars | 8m 7s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 30s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 39s | the patch passed | | +1 :green_heart: | compile | 2m 33s | the patch passed | | +1 :green_heart: | javac | 2m 33s | the patch passed | | +1 :green_heart: | shadedjars | 8m 11s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 22s | hbase-client generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 46s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 1m 14s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 0m 46s | hbase-zookeeper in the patch passed. | | -1 :x: | unit | 7m 59s | hbase-server in the patch failed. | | | | 45m 51s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3550 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 0e9b08079cc5 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 2e9ab3ce94 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/1/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-client.txt | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/1/testReport/ | | Max. process+thread count | 1022 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-client hbase-zookeeper hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3550/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3549: HBASE-26160: Configurable disallowlist for live editing of loglevels
Apache-HBase commented on pull request #3549: URL: https://github.com/apache/hbase/pull/3549#issuecomment-891134387 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 8s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 9s | master passed | | +1 :green_heart: | compile | 0m 23s | master passed | | +1 :green_heart: | shadedjars | 9m 26s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 20s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 12s | the patch passed | | +1 :green_heart: | compile | 0m 22s | the patch passed | | +1 :green_heart: | javac | 0m 22s | the patch passed | | +1 :green_heart: | shadedjars | 9m 46s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 17s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 57s | hbase-http in the patch passed. | | | | 34m 16s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3549 | | JIRA Issue | HBASE-26160 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux d6578d49673b 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 2e9ab3ce94 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/2/testReport/ | | Max. process+thread count | 368 (vs. ulimit of 3) | | modules | C: hbase-http U: hbase-http | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3549: HBASE-26160: Configurable disallowlist for live editing of loglevels
Apache-HBase commented on pull request #3549: URL: https://github.com/apache/hbase/pull/3549#issuecomment-891122921 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 11s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 50s | master passed | | +1 :green_heart: | compile | 0m 33s | master passed | | +1 :green_heart: | checkstyle | 0m 15s | master passed | | +1 :green_heart: | spotbugs | 0m 37s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 15s | the patch passed | | +1 :green_heart: | compile | 0m 30s | the patch passed | | +1 :green_heart: | javac | 0m 30s | the patch passed | | +1 :green_heart: | checkstyle | 0m 13s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 20m 58s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | +1 :green_heart: | spotbugs | 0m 50s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 12s | The patch does not generate ASF License warnings. | | | | 45m 25s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3549 | | JIRA Issue | HBASE-26160 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 49f984669aef 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 2e9ab3ce94 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 86 (vs. ulimit of 3) | | modules | C: hbase-http U: hbase-http | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/2/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3549: HBASE-26160: Configurable disallowlist for live editing of loglevels
Apache-HBase commented on pull request #3549: URL: https://github.com/apache/hbase/pull/3549#issuecomment-891122477 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 6s | master passed | | +1 :green_heart: | compile | 0m 21s | master passed | | +1 :green_heart: | shadedjars | 8m 36s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 18s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 50s | the patch passed | | +1 :green_heart: | compile | 0m 20s | the patch passed | | +1 :green_heart: | javac | 0m 20s | the patch passed | | +1 :green_heart: | shadedjars | 8m 34s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 16s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 49s | hbase-http in the patch passed. | | | | 29m 2s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3549 | | JIRA Issue | HBASE-26160 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 74ee6fade39a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 2e9ab3ce94 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/2/testReport/ | | Max. process+thread count | 555 (vs. ulimit of 3) | | modules | C: hbase-http U: hbase-http | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3549/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] anoopsjohn commented on a change in pull request #3518: HBASE-25881: Create a chore to update age related metrics
anoopsjohn commented on a change in pull request #3518:
URL: https://github.com/apache/hbase/pull/3518#discussion_r680826000
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationSourceRefresherChore.java
##
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.replication.regionserver;
+
+import java.util.Map;
+import java.util.concurrent.PriorityBlockingQueue;
+
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hbase.ScheduledChore;
+import org.apache.hadoop.hbase.Stoppable;
+import org.apache.hadoop.hbase.util.EnvironmentEdgeManager;
+import org.apache.hadoop.hbase.wal.AbstractFSWALProvider;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.apache.yetus.audience.InterfaceStability;
+
+/**
+ * The Class MetricsReplicationSourceRefresherChore for refreshing age related
replication source
+ * metrics
+ */
+@InterfaceAudience.Private
+@InterfaceStability.Evolving
+public class MetricsReplicationSourceRefresherChore extends ScheduledChore {
Review comment:
ReplicationSourceMetricsRefresherChore a better name?
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationSourceRefresherChore.java
##
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.replication.regionserver;
+
+import java.util.Map;
+import java.util.concurrent.PriorityBlockingQueue;
+
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hbase.ScheduledChore;
+import org.apache.hadoop.hbase.Stoppable;
+import org.apache.hadoop.hbase.util.EnvironmentEdgeManager;
+import org.apache.hadoop.hbase.wal.AbstractFSWALProvider;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.apache.yetus.audience.InterfaceStability;
+
+/**
+ * The Class MetricsReplicationSourceRefresherChore for refreshing age related
replication source
+ * metrics
+ */
+@InterfaceAudience.Private
+@InterfaceStability.Evolving
+public class MetricsReplicationSourceRefresherChore extends ScheduledChore {
+
+ private ReplicationSource replicationSource;
+
+ private MetricsSource metrics;
+
+ public static final String DURATION =
"hbase.metrics.replication.source.refresher.duration";
+ public static final int DEFAULT_DURATION_MILLISECONDS = 6;
+
+ public MetricsReplicationSourceRefresherChore(Stoppable stopper,
+ ReplicationSource replicationSource) {
+this(DEFAULT_DURATION_MILLISECONDS, stopper, replicationSource);
+ }
+
+ public MetricsReplicationSourceRefresherChore(int duration, Stoppable
stopper,
+ ReplicationSource replicationSource) {
+super("MetricsSourceRefresherChore", stopper, duration);
+this.replicationSource = replicationSource;
+this.metrics = this.replicationSource.getSourceMetrics();
+ }
+
+ @Override
+ protected void chore() {
+this.metrics.setOldestWalAge(getOldestWalAge());
+ }
+
+ /*
+ * Returns the age of oldest wal.
+ */
+ long getOldestWalAge() {
+long now = EnvironmentEdgeManager.currentTime();
+long timestamp = getOldestWalTimestamp();
+if (timestamp == Long.MAX_VALUE) {
+ // If there are no wals in the queue then set the oldest wal timestamp
to current time
+ // so that the oldest wal age will be 0.
+ timestamp = now;
+}
+long age = now - timestamp;
+return age;
[jira] [Updated] (HBASE-26152) Exclude javax.servlet:servlet-api in hbase-shaded-testing-util
[
https://issues.apache.org/jira/browse/HBASE-26152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Somogyi updated HBASE-26152:
--
Resolution: Fixed
Status: Resolved (was: Patch Available)
Merged to branch-2 and branch-2.4. Thanks for the review [~apurtell].
> Exclude javax.servlet:servlet-api in hbase-shaded-testing-util
> --
>
> Key: HBASE-26152
> URL: https://issues.apache.org/jira/browse/HBASE-26152
> Project: HBase
> Issue Type: Task
>Affects Versions: 2.4.0, 2.4.1, 2.4.2, 2.4.3, 2.4.4, 2.4.5
>Reporter: Andrew Kyle Purtell
>Assignee: Peter Somogyi
>Priority: Major
> Fix For: 2.5.0, 2.4.6
>
>
> {noformat}
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> [INFO] Running org.apache.hbase.shaded.TestShadedHBaseTestingUtility
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> 19.515 s <<< FAILURE! - in
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility
> [ERROR] org.apache.hbase.shaded.TestShadedHBaseTestingUtility Time elapsed:
> 19.513 s <<< ERROR!
> java.io.IOException: Shutting down
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: java.lang.RuntimeException: Failed construction of Master: class
> org.apache.hadoop.hbase.master.HMasterMultiple exceptions
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: java.io.IOException: Problem starting http server
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: org.apache.hbase.thirdparty.org.eclipse.jetty.util.MultiException:
> Multiple exceptions
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> Caused by: java.lang.NoSuchMethodError:
> javax.servlet.ServletContext.createFilter(Ljava/lang/Class;)Ljavax/servlet/Filter;
> at
> org.apache.hbase.shaded.TestShadedHBaseTestingUtility.setUp(TestShadedHBaseTestingUtility.java:47)
> [INFO]
> [INFO] Results:
> [INFO]
> [ERROR] Errors:
> [ERROR] TestShadedHBaseTestingUtility.setUp:47 » IO Shutting down
> [INFO]
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0
> {noformat}
> The hadoop-common and hadoop-mapreduce-client-app dependencies are leaking
> javax.servlet:servlet-api:2.5.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] petersomogyi merged pull request #3547: HBASE-26152 Exclude javax.servlet:servlet-api in hbase-shaded-testing-util
petersomogyi merged pull request #3547: URL: https://github.com/apache/hbase/pull/3547 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bbeaudreault commented on a change in pull request #3549: HBASE-26160: Configurable disallowlist for live editing of loglevels
bbeaudreault commented on a change in pull request #3549:
URL: https://github.com/apache/hbase/pull/3549#discussion_r680902855
##
File path:
hbase-http/src/main/java/org/apache/hadoop/hbase/http/log/LogLevel.java
##
@@ -345,6 +347,12 @@ public void doGet(HttpServletRequest request,
HttpServletResponse response)
out.println(MARKER
+ "Log Class: " + log.getClass().getName() +"");
if (level != null) {
+ if (!isLogLevelChangeAllowed(logName, readOnlyLogLevels)) {
+response.sendError(HttpServletResponse.SC_PRECONDITION_FAILED,
Review comment:
@jojochuang I looked more closely, and there are at least 6 servlets
that use the current `sendError` behavior, as well as a couple filters and a
bunch of tests. It seems like we might want to leave this alone here and
instead create a jira to update all usages so that they are future proof. Or we
could fix those issues as part of a future "upgrade netty" jira.
Does that sound reasonable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] bbeaudreault commented on a change in pull request #3549: HBASE-26160: Configurable disallowlist for live editing of loglevels
bbeaudreault commented on a change in pull request #3549:
URL: https://github.com/apache/hbase/pull/3549#discussion_r680902855
##
File path:
hbase-http/src/main/java/org/apache/hadoop/hbase/http/log/LogLevel.java
##
@@ -345,6 +347,12 @@ public void doGet(HttpServletRequest request,
HttpServletResponse response)
out.println(MARKER
+ "Log Class: " + log.getClass().getName() +"");
if (level != null) {
+ if (!isLogLevelChangeAllowed(logName, readOnlyLogLevels)) {
+response.sendError(HttpServletResponse.SC_PRECONDITION_FAILED,
Review comment:
@jojochuang I looked more closely, and there are at least 6 servlets
that use the current `sendError` behavior, as well as a couple filters. It
seems like we might want to leave this alone here and instead create a jira to
update all usages so that they are future proof. Or we could fix those issues
as part of a future "upgrade netty" jira.
Does that sound reasonable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache9 opened a new pull request #3550: HBASE-26150 Let region server also carry ClientMetaService
Apache9 opened a new pull request #3550: URL: https://github.com/apache/hbase/pull/3550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3547: HBASE-26152 Exclude javax.servlet:servlet-api in hbase-shaded-testing-util
Apache-HBase commented on pull request #3547: URL: https://github.com/apache/hbase/pull/3547#issuecomment-890937207 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 44s | Docker mode activated. | | -0 :warning: | yetus | 0m 8s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 57s | branch-2 passed | | +1 :green_heart: | compile | 0m 30s | branch-2 passed | | +1 :green_heart: | shadedjars | 9m 31s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 15s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 29s | the patch passed | | +1 :green_heart: | compile | 0m 25s | the patch passed | | +1 :green_heart: | javac | 0m 25s | the patch passed | | +1 :green_heart: | shadedjars | 9m 34s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 17s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 27s | hbase-shaded-testing-util in the patch passed. | | | | 36m 43s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3547/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3547 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux f19ca6d03ba7 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / aa3b07f6bb | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3547/2/testReport/ | | Max. process+thread count | 85 (vs. ulimit of 12500) | | modules | C: hbase-shaded/hbase-shaded-testing-util U: hbase-shaded/hbase-shaded-testing-util | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3547/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26160) Configurable disallowlist for live editing of loglevels
[ https://issues.apache.org/jira/browse/HBASE-26160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17391513#comment-17391513 ] Bryan Beaudreault commented on HBASE-26160: --- Good point [~anoop.hbase]. I was thinking you'd have to explicitly reference each logger, but I just pushed a commit so that we do a startsWith check instead of equals. This should work more like how log4j log levels work. > Configurable disallowlist for live editing of loglevels > --- > > Key: HBASE-26160 > URL: https://issues.apache.org/jira/browse/HBASE-26160 > Project: HBase > Issue Type: Improvement >Reporter: Bryan Beaudreault >Assignee: Bryan Beaudreault >Priority: Minor > > We currently use log4j/slf4j for audit logging in AccessController. This is > convenient but presents a security/compliance risk because we allow > live-editing of logLevels via the UI. One can simply set the logger to OFF > and then perform actions un-audited. > We should add a configuration for setting certain log levels to read-only -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] bbeaudreault commented on a change in pull request #3549: HBASE-26160: Configurable disallowlist for live editing of loglevels
bbeaudreault commented on a change in pull request #3549:
URL: https://github.com/apache/hbase/pull/3549#discussion_r680877837
##
File path:
hbase-http/src/main/java/org/apache/hadoop/hbase/http/log/LogLevel.java
##
@@ -345,6 +347,12 @@ public void doGet(HttpServletRequest request,
HttpServletResponse response)
out.println(MARKER
+ "Log Class: " + log.getClass().getName() +"");
if (level != null) {
+ if (!isLogLevelChangeAllowed(logName, readOnlyLogLevels)) {
+response.sendError(HttpServletResponse.SC_PRECONDITION_FAILED,
Review comment:
Thanks for the pointer. It looks like hbase uses a shaded version of
netty, and further up in this class uses `sendError` to send an error response.
I could change this if I get another vote from an hbase committer, but I
probably should change both in that case. Seems out of scope for this jira, but
can do it if we think I should.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (HBASE-26154) Provide exception metric for quota exceeded and throttling
[ https://issues.apache.org/jira/browse/HBASE-26154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17391512#comment-17391512 ] Bryan Beaudreault commented on HBASE-26154: --- Thanks! > Provide exception metric for quota exceeded and throttling > -- > > Key: HBASE-26154 > URL: https://issues.apache.org/jira/browse/HBASE-26154 > Project: HBase > Issue Type: Improvement >Reporter: Bryan Beaudreault >Assignee: Bryan Beaudreault >Priority: Minor > Fix For: 2.5.0, 3.0.0-alpha-2, 2.4.6 > > > We should add metrics for QuotaExceededException and RpcThrottlingException. > This is something we've found very useful to track as it helps us identify > bad access patterns in clients. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #3547: HBASE-26152 Exclude javax.servlet:servlet-api in hbase-shaded-testing-util
Apache-HBase commented on pull request #3547: URL: https://github.com/apache/hbase/pull/3547#issuecomment-890920341 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 57s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 23s | branch-2 passed | | +1 :green_heart: | compile | 0m 27s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 55s | the patch passed | | +1 :green_heart: | compile | 0m 24s | the patch passed | | +1 :green_heart: | javac | 0m 24s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 18m 16s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 20s | The patch does not generate ASF License warnings. | | | | 43m 48s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3547/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3547 | | Optional Tests | dupname asflicense javac hadoopcheck xml compile | | uname | Linux bd9472167d69 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / aa3b07f6bb | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 69 (vs. ulimit of 12500) | | modules | C: hbase-shaded/hbase-shaded-testing-util U: hbase-shaded/hbase-shaded-testing-util | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3547/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3547: HBASE-26152 Exclude javax.servlet:servlet-api in hbase-shaded-testing-util
Apache-HBase commented on pull request #3547: URL: https://github.com/apache/hbase/pull/3547#issuecomment-890915446 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 36s | Docker mode activated. | | -0 :warning: | yetus | 0m 9s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 39s | branch-2 passed | | +1 :green_heart: | compile | 0m 22s | branch-2 passed | | +1 :green_heart: | shadedjars | 7m 41s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 15s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 23s | the patch passed | | +1 :green_heart: | compile | 0m 27s | the patch passed | | +1 :green_heart: | javac | 0m 27s | the patch passed | | +1 :green_heart: | shadedjars | 8m 49s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 17s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 24s | hbase-shaded-testing-util in the patch passed. | | | | 33m 36s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3547/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3547 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 8bfafa4dc796 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / aa3b07f6bb | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3547/2/testReport/ | | Max. process+thread count | 66 (vs. ulimit of 12500) | | modules | C: hbase-shaded/hbase-shaded-testing-util U: hbase-shaded/hbase-shaded-testing-util | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3547/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (HBASE-26154) Provide exception metric for quota exceeded and throttling
[ https://issues.apache.org/jira/browse/HBASE-26154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar resolved HBASE-26154. -- Resolution: Fixed > Provide exception metric for quota exceeded and throttling > -- > > Key: HBASE-26154 > URL: https://issues.apache.org/jira/browse/HBASE-26154 > Project: HBase > Issue Type: Improvement >Reporter: Bryan Beaudreault >Assignee: Bryan Beaudreault >Priority: Minor > Fix For: 2.5.0, 3.0.0-alpha-2, 2.4.6 > > > We should add metrics for QuotaExceededException and RpcThrottlingException. > This is something we've found very useful to track as it helps us identify > bad access patterns in clients. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-26154) Provide exception metric for quota exceeded and throttling
[ https://issues.apache.org/jira/browse/HBASE-26154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17391475#comment-17391475 ] Pankaj Kumar commented on HBASE-26154: -- Pushed to branch-2.4+. Thanks [~bbeaudreault] for the contribution and [~haxiaolin] for reviewing. > Provide exception metric for quota exceeded and throttling > -- > > Key: HBASE-26154 > URL: https://issues.apache.org/jira/browse/HBASE-26154 > Project: HBase > Issue Type: Improvement >Reporter: Bryan Beaudreault >Assignee: Bryan Beaudreault >Priority: Minor > Fix For: 2.5.0, 3.0.0-alpha-2, 2.4.6 > > > We should add metrics for QuotaExceededException and RpcThrottlingException. > This is something we've found very useful to track as it helps us identify > bad access patterns in clients. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] pankaj72981 merged pull request #3546: HBASE-26154: Adds exception metrics for QuotaExceededException and RpcThrottlingException
pankaj72981 merged pull request #3546: URL: https://github.com/apache/hbase/pull/3546 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-26155) JVM crash when rpc calls close scanner
[
https://issues.apache.org/jira/browse/HBASE-26155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiaolin Ha updated HBASE-26155:
---
Description:
There are scanner close caused regionserver JVM coredump problems on our
production clusters.
{code:java}
Stack: [0x7fca4b0cc000,0x7fca4b1cd000], sp=0x7fca4b1cb0d8, free
space=1020k
Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code)
V [libjvm.so+0x7fd314]
J 2810 sun.misc.Unsafe.copyMemory(Ljava/lang/Object;JLjava/lang/Object;JJ)V (0
bytes) @ 0x7fdae55a9e61 [0x7fdae55a9d80+0xe1]
j
org.apache.hadoop.hbase.util.UnsafeAccess.unsafeCopy(Ljava/lang/Object;JLjava/lang/Object;JJ)V+36
j
org.apache.hadoop.hbase.util.UnsafeAccess.copy(Ljava/nio/ByteBuffer;I[BII)V+69
j
org.apache.hadoop.hbase.util.ByteBufferUtils.copyFromBufferToArray([BLjava/nio/ByteBuffer;III)V+39
j
org.apache.hadoop.hbase.CellUtil.copyQualifierTo(Lorg/apache/hadoop/hbase/Cell;[BI)I+31
j
org.apache.hadoop.hbase.KeyValueUtil.appendKeyTo(Lorg/apache/hadoop/hbase/Cell;[BI)I+43
J 14724 C2 org.apache.hadoop.hbase.regionserver.StoreScanner.shipped()V (51
bytes) @ 0x7fdae6a298d0 [0x7fdae6a29780+0x150]
J 21387 C2
org.apache.hadoop.hbase.regionserver.RSRpcServices$RegionScannerShippedCallBack.run()V
(53 bytes) @ 0x7fdae622bab8 [0x7fdae622acc0+0xdf8]
J 26353 C2
org.apache.hadoop.hbase.ipc.ServerCall.setResponse(Lorg/apache/hbase/thirdparty/com/google/protobuf/Message;Lorg/apache/hadoop/hbase/CellScanner;Ljava/lang/Throwable;Ljava/lang/String;)V
(384 bytes) @ 0x7fdae7f139d8 [0x7fdae7f12980+0x1058]
J 26226 C2 org.apache.hadoop.hbase.ipc.CallRunner.run()V (1554 bytes) @
0x7fdae959f68c [0x7fdae959e400+0x128c]
J 19598% C2
org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(Ljava/util/concurrent/BlockingQueue;Ljava/util/concurrent/atomic/AtomicInteger;)V
(338 bytes) @ 0x7fdae81c54d4 [0x7fdae81c53e0+0xf4]
{code}
was:
There are scanner close caused regionserver JVM coredump problems on our
production clusters.
{code:java}
Stack: [0x7fca4b0cc000,0x7fca4b1cd000], sp=0x7fca4b1cb0d8, free
space=1020k
Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code)
V [libjvm.so+0x7fd314]
J 2810 sun.misc.Unsafe.copyMemory(Ljava/lang/Object;JLjava/lang/Object;JJ)V (0
bytes) @ 0x7fdae55a9e61 [0x7fdae55a9d80+0xe1]
j
org.apache.hadoop.hbase.util.UnsafeAccess.unsafeCopy(Ljava/lang/Object;JLjava/lang/Object;JJ)V+36
j
org.apache.hadoop.hbase.util.UnsafeAccess.copy(Ljava/nio/ByteBuffer;I[BII)V+69
j
org.apache.hadoop.hbase.util.ByteBufferUtils.copyFromBufferToArray([BLjava/nio/ByteBuffer;III)V+39
j
org.apache.hadoop.hbase.CellUtil.copyQualifierTo(Lorg/apache/hadoop/hbase/Cell;[BI)I+31
j
org.apache.hadoop.hbase.KeyValueUtil.appendKeyTo(Lorg/apache/hadoop/hbase/Cell;[BI)I+43
J 14724 C2 org.apache.hadoop.hbase.regionserver.StoreScanner.shipped()V (51
bytes) @ 0x7fdae6a298d0 [0x7fdae6a29780+0x150]
J 21387 C2
org.apache.hadoop.hbase.regionserver.RSRpcServices$RegionScannerShippedCallBack.run()V
(53 bytes) @ 0x7fdae622bab8 [0x7fdae622acc0+0xdf8]
J 26353 C2
org.apache.hadoop.hbase.ipc.ServerCall.setResponse(Lorg/apache/hbase/thirdparty/com/google/protobuf/Message;Lorg/apache/hadoop/hbase/CellScanner;Ljava/lang/Throwable;Ljava/lang/String;)V
(384 bytes) @ 0x7fdae7f139d8 [0x7fdae7f12980+0x1058]
J 26226 C2 org.apache.hadoop.hbase.ipc.CallRunner.run()V (1554 bytes) @
0x7fdae959f68c [0x7fdae959e400+0x128c]
J 19598% C2
org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(Ljava/util/concurrent/BlockingQueue;Ljava/util/concurrent/atomic/AtomicInteger;)V
(338 bytes) @ 0x7fdae81c54d4 [0x7fdae81c53e0+0xf4]
{code}
There is no guarantee for RPC calls to hold unique scanners, right?
For example, when there are client disconnect problems, RS may not terminate
the scanner nexts until it checks the `rpcCall.disconnectSince()` time. But
before this another scan RPC may also use the same scanner that holds in the RS
cache by RegionScannerHolder. Then they change the `previousCell` in the
scanner in different threads...
> JVM crash when rpc calls close scanner
> --
>
> Key: HBASE-26155
> URL: https://issues.apache.org/jira/browse/HBASE-26155
> Project: HBase
> Issue Type: Bug
> Components: Scanners
>Affects Versions: 3.0.0-alpha-1
>Reporter: Xiaolin Ha
>Priority: Major
>
> There are scanner close caused regionserver JVM coredump problems on our
> production clusters.
> {code:java}
> Stack: [0x7fca4b0cc000,0x7fca4b1cd000], sp=0x7fca4b1cb0d8, free
> space=1020k
> Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native
> code)
> V [libjvm.so+0x7fd314]
> J 2810
[GitHub] [hbase] Apache-HBase commented on pull request #3546: HBASE-26154: Adds exception metrics for QuotaExceededException and RpcThrottlingException
Apache-HBase commented on pull request #3546: URL: https://github.com/apache/hbase/pull/3546#issuecomment-890852087 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 16s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.4 Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 51s | branch-2.4 passed | | +1 :green_heart: | compile | 2m 28s | branch-2.4 passed | | +1 :green_heart: | shadedjars | 7m 27s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 12s | branch-2.4 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 31s | the patch passed | | +1 :green_heart: | compile | 2m 28s | the patch passed | | +1 :green_heart: | javac | 2m 28s | the patch passed | | +1 :green_heart: | shadedjars | 7m 27s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 10s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 27s | hbase-hadoop-compat in the patch passed. | | +1 :green_heart: | unit | 0m 33s | hbase-hadoop2-compat in the patch passed. | | +1 :green_heart: | unit | 208m 1s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 5m 31s | hbase-thrift in the patch passed. | | | | 252m 43s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3546/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3546 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 13f6cb3567e4 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.4 / cb1174e9e1 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3546/4/testReport/ | | Max. process+thread count | 2565 (vs. ulimit of 12500) | | modules | C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server hbase-thrift U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3546/4/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] petersomogyi commented on pull request #3547: HBASE-26152 Exclude javax.servlet:servlet-api in hbase-shaded-testing-util
petersomogyi commented on pull request #3547: URL: https://github.com/apache/hbase/pull/3547#issuecomment-890849506 > Should be fine to add the exclusions to all branches, or not, I have no strong opinion either way. Better to be consistent across all POMs in all branches if possible. This pom.xml is already different on the branches. The `hadoop-mapreduce-client-app` dependency does not require any exclusions on master branch while the shading rule also differs on branch-2.3. Based on this I'd prefer to commit this to branch-2 and branch-2.4 only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3546: HBASE-26154: Adds exception metrics for QuotaExceededException and RpcThrottlingException
Apache-HBase commented on pull request #3546: URL: https://github.com/apache/hbase/pull/3546#issuecomment-890834828 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 15s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.4 Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 4s | branch-2.4 passed | | +1 :green_heart: | compile | 2m 10s | branch-2.4 passed | | +1 :green_heart: | shadedjars | 6m 57s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 45s | branch-2.4 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 53s | the patch passed | | +1 :green_heart: | compile | 2m 8s | the patch passed | | +1 :green_heart: | javac | 2m 8s | the patch passed | | +1 :green_heart: | shadedjars | 6m 46s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 41s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 26s | hbase-hadoop-compat in the patch passed. | | +1 :green_heart: | unit | 0m 29s | hbase-hadoop2-compat in the patch passed. | | +1 :green_heart: | unit | 216m 5s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 5m 7s | hbase-thrift in the patch passed. | | | | 255m 51s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3546/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/3546 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 64443f5fb1b7 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.4 / cb1174e9e1 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3546/4/testReport/ | | Max. process+thread count | 2426 (vs. ulimit of 12500) | | modules | C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server hbase-thrift U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3546/4/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] comnetwork commented on a change in pull request #3531: HBASE-26142 NullPointerException when set 'hbase.hregion.memstore.msl…
comnetwork commented on a change in pull request #3531:
URL: https://github.com/apache/hbase/pull/3531#discussion_r680299130
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ChunkCreator.java
##
@@ -228,14 +236,15 @@ Chunk getChunk(CompactingMemStore.IndexType
chunkIndexType, int size) {
*/
Chunk getJumboChunk(int jumboSize) {
int allocSize = jumboSize + SIZEOF_CHUNK_HEADER;
-if (allocSize <= dataChunksPool.getChunkSize()) {
+
+if (allocSize <= this.getChunkSize()) {
Review comment:
OK, modified following your suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (HBASE-26161) SystemExitWhenAbortTimeout initialization exception when regionserver exits due to abort method
youhailang created HBASE-26161:
--
Summary: SystemExitWhenAbortTimeout initialization exception when
regionserver exits due to abort method
Key: HBASE-26161
URL: https://issues.apache.org/jira/browse/HBASE-26161
Project: HBase
Issue Type: Bug
Components: shutdown
Affects Versions: 2.1.4
Reporter: youhailang
Assignee: youhailang
We encountered a problem in the production environment. When the regionserver
was shut down due to abort, the SystemExitWhenAbortTimeout could not be created
correctly.
{noformat}
2021-07-31 10:14:36,792 WARN [regionserver/xxx-hbase48:16020]
regionserver.HRegionServer: Initialize abort timeout task failed
java.lang.IllegalAccessException: Class
org.apache.hadoop.hbase.regionserver.HRegionServer can not access a member of
class
org.apache.hadoop.hbase.regionserver.HRegionServer$SystemExitWhenAbortTimeout
with modifiers "private"
at sun.reflect.Reflection.ensureMemberAccess(Reflection.java:102)
at
java.lang.reflect.AccessibleObject.slowCheckMemberAccess(AccessibleObject.java:296)
at
java.lang.reflect.AccessibleObject.checkAccess(AccessibleObject.java:288)
at java.lang.reflect.Constructor.newInstance(Constructor.java:413)
at
org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:1046)
at java.lang.Thread.run(Thread.java:748){noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
