[GitHub] [hbase] Apache-HBase commented on pull request #4105: HBASE-26742 Comparator of NOT_EQUAL NULL is invalid for checkAndMutate
Apache-HBase commented on pull request #4105: URL: https://github.com/apache/hbase/pull/4105#issuecomment-1034562726 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 0s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 14s | master passed | | +1 :green_heart: | compile | 1m 4s | master passed | | +1 :green_heart: | shadedjars | 8m 18s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 59s | the patch passed | | +1 :green_heart: | compile | 1m 4s | the patch passed | | +1 :green_heart: | javac | 1m 4s | the patch passed | | +1 :green_heart: | shadedjars | 8m 18s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 153m 57s | hbase-server in the patch passed. | | | | 185m 18s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4105/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4105 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 9602ddbd8fd7 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6c3c53a81c | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4105/1/testReport/ | | Max. process+thread count | 3499 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4105/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4105: HBASE-26742 Comparator of NOT_EQUAL NULL is invalid for checkAndMutate
Apache-HBase commented on pull request #4105: URL: https://github.com/apache/hbase/pull/4105#issuecomment-1034556804 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 6s | master passed | | +1 :green_heart: | compile | 1m 20s | master passed | | +1 :green_heart: | shadedjars | 8m 23s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 44s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 32s | the patch passed | | +1 :green_heart: | compile | 1m 15s | the patch passed | | +1 :green_heart: | javac | 1m 15s | the patch passed | | +1 :green_heart: | shadedjars | 8m 19s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 42s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 143m 55s | hbase-server in the patch passed. | | | | 176m 53s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4105/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4105 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux e4d90022ff1c 4.15.0-161-generic #169-Ubuntu SMP Fri Oct 15 13:41:54 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6c3c53a81c | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4105/1/testReport/ | | Max. process+thread count | 3603 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4105/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (HBASE-23158) If KVs are in memstore, small batch get can come across MultiActionResultTooLarge
[ https://issues.apache.org/jira/browse/HBASE-23158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17489351#comment-17489351 ] Yutong Xiao edited comment on HBASE-23158 at 2/10/22, 6:00 AM: --- Encountered this problem also. For this problem, could we just use the number of cells times a predefined blocksize to approximate the total block size (one cell, one block)? For cells in memstore, they will be flushed in short time, so that we can just regard them as cells read from HFiles I think. This may solve this annoying exception. The problem is the approximation is rough (different table can have different blocksize). was (Author: xytss123): Encountered this problem also. For this problem, could we just use the number of cells times a predefined blocksize to approximate the total block size (one cell, one block)? For cells in memstore, they will be flushed in short time, so that we can just regard them as cells read from HFiles I think. This may solve this annoying exception. The problem is the approximation is rough granularity (different table can have different blocksize). What do you think? > If KVs are in memstore, small batch get can come across > MultiActionResultTooLarge > -- > > Key: HBASE-23158 > URL: https://issues.apache.org/jira/browse/HBASE-23158 > Project: HBase > Issue Type: Bug > Components: regionserver, rpc > Environment: [^TestMultiRespectsLimitsMemstore.patch] >Reporter: junfei liang >Priority: Minor > Attachments: TestMultiRespectsLimitsMemstore.patch > > > to protect against big scan, we set hbase.server.scanner.max.result.size = > 10MB in our customer hbase cluster, however our clients can meet > MultiActionResultTooLarge even in small batch get (for ex. 15 batch get, and > row size is about 5KB ) . > after [HBASE-14978|https://issues.apache.org/jira/browse/HBASE-14978] hbase > take the data block reference into consideration, but the block size is 64KB > (the default value ), even if all cells are from different block , the block > size retained is less than 1MB, so what's the problem ? > finally i found that HBASE-14978 also consider the cell in memstore, as > MSLAB is enabled default, so if the cell is from memstore, cell backend array > can be large (2MB as default), so even if a small batch can meet this error, > is this reasonable ? > plus: > when throw MultiActionResultTooLarge exception, hbase client should retry > ignore rpc retry num, however if set retry num to zero, client will fail > without retry in this case. > > see attachment TestMultiRespectsLimitsMemstore for details. > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [hbase] Apache-HBase commented on pull request #4105: HBASE-26742 Comparator of NOT_EQUAL NULL is invalid for checkAndMutate
Apache-HBase commented on pull request #4105: URL: https://github.com/apache/hbase/pull/4105#issuecomment-1034490941 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 36s | master passed | | +1 :green_heart: | compile | 3m 26s | master passed | | +1 :green_heart: | checkstyle | 1m 14s | master passed | | +1 :green_heart: | spotbugs | 2m 18s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 19s | the patch passed | | +1 :green_heart: | compile | 3m 23s | the patch passed | | +1 :green_heart: | javac | 3m 23s | the patch passed | | -0 :warning: | checkstyle | 1m 12s | hbase-server: The patch generated 4 new + 142 unchanged - 0 fixed = 146 total (was 142) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 21m 54s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. | | +1 :green_heart: | spotbugs | 2m 24s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. | | | | 54m 54s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4105/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4105 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux 04ae7c534bf1 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6c3c53a81c | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4105/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 86 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4105/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4104: Backport "HBASE-26521 Name RPC spans as `$package.$service/$method` (#4024)" to branch-2.5
Apache-HBase commented on pull request #4104: URL: https://github.com/apache/hbase/pull/4104#issuecomment-1034198366 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 8s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.5 Compile Tests _ | | +0 :ok: | mvndep | 0m 25s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 45s | branch-2.5 passed | | +1 :green_heart: | compile | 2m 25s | branch-2.5 passed | | +1 :green_heart: | shadedjars | 6m 30s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 38s | branch-2.5 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 29s | the patch passed | | +1 :green_heart: | compile | 2m 26s | the patch passed | | +1 :green_heart: | javac | 2m 26s | the patch passed | | +1 :green_heart: | shadedjars | 6m 30s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 43s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 355m 22s | root in the patch failed. | | | | 396m 3s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4104/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4104 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 12469baf639e 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.5 / 4e15101fa1 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4104/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4104/1/testReport/ | | Max. process+thread count | 4446 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-client hbase-server . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4104/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4101: HBASE-26741 Incorrect exception handling in shell
Apache-HBase commented on pull request #4101: URL: https://github.com/apache/hbase/pull/4101#issuecomment-1034194277 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m 47s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 17s | master passed | | +1 :green_heart: | javadoc | 2m 29s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 21s | the patch passed | | +1 :green_heart: | javadoc | 2m 31s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 428m 39s | root in the patch passed. | | | | 451m 57s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4101/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4101 | | Optional Tests | javac javadoc unit | | uname | Linux 6f6061783a3b 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0c19a5f1c8 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4101/3/testReport/ | | Max. process+thread count | 3768 (vs. ulimit of 3) | | modules | C: hbase-shell . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4101/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4103: Backport "HBASE-26521 Name RPC spans as `$package.$service/$method` (#4024)" to branch-2
Apache-HBase commented on pull request #4103: URL: https://github.com/apache/hbase/pull/4103#issuecomment-1034152647 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 38s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 27s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 56s | branch-2 passed | | +1 :green_heart: | compile | 2m 54s | branch-2 passed | | +1 :green_heart: | shadedjars | 7m 10s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 54s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 47s | the patch passed | | +1 :green_heart: | compile | 2m 46s | the patch passed | | +1 :green_heart: | javac | 2m 46s | the patch passed | | +1 :green_heart: | shadedjars | 6m 50s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 46s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 297m 4s | root in the patch failed. | | | | 337m 44s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4103/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4103 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux bb6e79cc5499 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / cbbb1a0542 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4103/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4103/1/testReport/ | | Max. process+thread count | 3241 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-client hbase-server . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4103/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4103: Backport "HBASE-26521 Name RPC spans as `$package.$service/$method` (#4024)" to branch-2
Apache-HBase commented on pull request #4103: URL: https://github.com/apache/hbase/pull/4103#issuecomment-1034062651 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 10s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 26s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 36s | branch-2 passed | | +1 :green_heart: | compile | 3m 5s | branch-2 passed | | +1 :green_heart: | shadedjars | 7m 26s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 4m 32s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 13s | the patch passed | | +1 :green_heart: | compile | 3m 1s | the patch passed | | +1 :green_heart: | javac | 3m 1s | the patch passed | | +1 :green_heart: | shadedjars | 7m 26s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 4m 24s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 181m 51s | root in the patch passed. | | | | 226m 23s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4103/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4103 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 80553cc47ca3 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / cbbb1a0542 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4103/1/testReport/ | | Max. process+thread count | 6578 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-client hbase-server . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4103/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4104: Backport "HBASE-26521 Name RPC spans as `$package.$service/$method` (#4024)" to branch-2.5
Apache-HBase commented on pull request #4104: URL: https://github.com/apache/hbase/pull/4104#issuecomment-1034055237 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.5 Compile Tests _ | | +0 :ok: | mvndep | 0m 27s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 51s | branch-2.5 passed | | +1 :green_heart: | compile | 3m 9s | branch-2.5 passed | | +1 :green_heart: | shadedjars | 7m 50s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 4m 30s | branch-2.5 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 14s | the patch passed | | +1 :green_heart: | compile | 3m 0s | the patch passed | | +1 :green_heart: | javac | 3m 0s | the patch passed | | +1 :green_heart: | shadedjars | 7m 17s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 4m 22s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 171m 23s | root in the patch passed. | | | | 215m 42s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4104/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4104 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 3eec805b4d52 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.5 / 4e15101fa1 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4104/1/testReport/ | | Max. process+thread count | 5915 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-client hbase-server . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4104/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26746) Update protobuf-java to 3.19.4
[ https://issues.apache.org/jira/browse/HBASE-26746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17489717#comment-17489717 ] Pankaj Kumar commented on HBASE-26746: -- Got it.. > Update protobuf-java to 3.19.4 > -- > > Key: HBASE-26746 > URL: https://issues.apache.org/jira/browse/HBASE-26746 > Project: HBase > Issue Type: Bug > Components: Protobufs, thirdparty >Reporter: Pankaj Kumar >Assignee: Sean Busbey >Priority: Minor > > Refer, > https://nvd.nist.gov/vuln/detail/CVE-2021-22569 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (HBASE-26709) Ban the usage of junit 3 TestCase
[ https://issues.apache.org/jira/browse/HBASE-26709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-26709. --- Fix Version/s: 2.5.0 Resolution: Fixed Pushed to branch-2.5+. > Ban the usage of junit 3 TestCase > - > > Key: HBASE-26709 > URL: https://issues.apache.org/jira/browse/HBASE-26709 > Project: HBase > Issue Type: Improvement > Components: test >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 2.5.0, 3.0.0-alpha-3 > > > We should move up all our UTs to junit 4 style. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [hbase] Apache-HBase commented on pull request #4101: HBASE-26741 Incorrect exception handling in shell
Apache-HBase commented on pull request #4101: URL: https://github.com/apache/hbase/pull/4101#issuecomment-1033991767 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 31s | master passed | | +1 :green_heart: | javadoc | 3m 8s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 29s | the patch passed | | +1 :green_heart: | javadoc | 3m 5s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 190m 26s | root in the patch passed. | | | | 210m 12s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4101/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4101 | | Optional Tests | javac javadoc unit | | uname | Linux 4143a0ad54a2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0c19a5f1c8 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4101/3/testReport/ | | Max. process+thread count | 6992 (vs. ulimit of 3) | | modules | C: hbase-shell . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4101/3/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (HBASE-26724) Backport the UT changes in HBASE-24510 to branch-2.x
[ https://issues.apache.org/jira/browse/HBASE-26724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-26724. --- Fix Version/s: 2.5.0 Hadoop Flags: Reviewed Resolution: Fixed Pushed to branch-2 & branch-2.5. Thanks [~sunxin] for reviewing! > Backport the UT changes in HBASE-24510 to branch-2.x > > > Key: HBASE-26724 > URL: https://issues.apache.org/jira/browse/HBASE-26724 > Project: HBase > Issue Type: Improvement > Components: test >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 2.5.0 > > > We could still keep HBaseTestCase but we can modify our own UTs to not rely > on it. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [hbase] Apache-HBase commented on pull request #4104: Backport "HBASE-26521 Name RPC spans as `$package.$service/$method` (#4024)" to branch-2.5
Apache-HBase commented on pull request #4104: URL: https://github.com/apache/hbase/pull/4104#issuecomment-1033932661 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 15s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2.5 Compile Tests _ | | +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 9s | branch-2.5 passed | | +1 :green_heart: | compile | 9m 52s | branch-2.5 passed | | +1 :green_heart: | checkstyle | 2m 27s | branch-2.5 passed | | +1 :green_heart: | spotbugs | 14m 6s | branch-2.5 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 55s | the patch passed | | +1 :green_heart: | compile | 9m 48s | the patch passed | | +1 :green_heart: | javac | 9m 48s | the patch passed | | +1 :green_heart: | checkstyle | 2m 26s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 20m 28s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 14m 59s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 49s | The patch does not generate ASF License warnings. | | | | 94m 45s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4104/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4104 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml | | uname | Linux 1b8832e1a2d2 4.15.0-162-generic #170-Ubuntu SMP Mon Oct 18 11:38:05 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.5 / 4e15101fa1 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 126 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-client hbase-server . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4104/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4103: Backport "HBASE-26521 Name RPC spans as `$package.$service/$method` (#4024)" to branch-2
Apache-HBase commented on pull request #4103: URL: https://github.com/apache/hbase/pull/4103#issuecomment-1033926719 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 34s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 26s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 55s | branch-2 passed | | +1 :green_heart: | compile | 9m 46s | branch-2 passed | | +1 :green_heart: | checkstyle | 2m 18s | branch-2 passed | | +1 :green_heart: | spotbugs | 13m 47s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 51s | the patch passed | | +1 :green_heart: | compile | 10m 30s | the patch passed | | +1 :green_heart: | javac | 10m 30s | the patch passed | | +1 :green_heart: | checkstyle | 2m 22s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 14m 41s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 16m 11s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 54s | The patch does not generate ASF License warnings. | | | | 91m 5s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4103/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4103 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml | | uname | Linux f6b667b2f3ca 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / cbbb1a0542 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Max. process+thread count | 141 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-client hbase-server . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4103/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26666) Address bearer token being sent over wire before RPC encryption is enabled
[ https://issues.apache.org/jira/browse/HBASE-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17489658#comment-17489658 ] Andor Molnar commented on HBASE-2: -- I suggest to implement Netty-based TLS encryption for this in Master and RS. Most of the implementation can be copied from the ZooKeeper project where it was implemented recently. > Address bearer token being sent over wire before RPC encryption is enabled > -- > > Key: HBASE-2 > URL: https://issues.apache.org/jira/browse/HBASE-2 > Project: HBase > Issue Type: Sub-task >Reporter: Josh Elser >Priority: Major > Fix For: HBASE-26553 > > > Today, HBase must complete the SASL handshake (saslClient.complete()) prior > to turning on any RPC encryption (hbase.rpc.protection=privacy, > sasl.QOP=auth-conf). > This is a problem because we have to transmit the bearer token to the server > before we can complete the sasl handshake. This would mean that we would > insecurely transmit the bearer token (which is equivalent to any other > password) which is a bad smell. > Ideally, if we can solve this problem for the oauth bearer mechanism, we > could also apply it to our delegation token interface for digest-md5 (which, > I believe, suffers the same problem). -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [hbase] petersomogyi commented on pull request #4101: HBASE-26741 Incorrect exception handling in shell
petersomogyi commented on pull request #4101: URL: https://github.com/apache/hbase/pull/4101#issuecomment-1033872009 > what happens to stuff that comes from stdin in non-interactive mode? (in 2.2 and with this patch) The behavior is identical. Both quits on exceptions with exit code 1. The formatting is different because on master we have the hbase shell prompt and the stack trace. ``` ➜ hbase-2.2.7 bin/hbase shell -n 2022-02-09 16:14:26,755 WARN [main] util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable scan 'foo' ROW COLUMN+CELL Took 0.3674 seconds ERROR RuntimeError: Unknown table foo! ➜ hbase-2.2.7 echo $? 1 ``` ``` ➜ hbase-upstream git:(HBASE-26741) ✗ bin/hbase shell -n 2022-02-09T16:13:30,894 WARN [main] util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable hbase:001:0> scan 'foo' ROWCOLUMN+CELL 2022-02-09T16:13:41,173 WARN [RPCClient-NioEventLoopGroup-1-2] client.AsyncNonMetaRegionLocator: Failed to locate region in 'foo', row='', locateType=CURRENT org.apache.hadoop.hbase.TableNotFoundException: foo at org.apache.hadoop.hbase.client.AsyncNonMetaRegionLocator$1.onComplete(AsyncNonMetaRegionLocator.java:503) ~[hbase-client-3.0.0-alpha-3-SNAPSHOT.jar:3.0.0-alpha-3-SNAPSHOT] [[[ LONG STACKTRACE ]]] at java.lang.Thread.run(Thread.java:748) [?:1.8.0_242] Took 0.1328 seconds RuntimeError: Unknown table foo! translate_hbase_exceptions at /Users/petersomogyi/projects/hbase-upstream/hbase-shell/src/main/ruby/shell/commands.rb:130 command_safe at /Users/petersomogyi/projects/hbase-upstream/hbase-shell/src/main/ruby/shell/commands.rb:49 internal_command at uri:classloader:/shell.rb:211 command at uri:classloader:/shell.rb:203 scan at uri:classloader:/shell.rb:166 evaluate at (hbase):1 eval at org/jruby/RubyKernel.java:1048 evaluate at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/irb/workspace.rb:85 evaluate at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/irb/context.rb:380 eval_input at /Users/petersomogyi/projects/hbase-upstream/hbase-shell/src/main/ruby/irb/hirb.rb:112 signal_status at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/irb.rb:623 eval_input at /Users/petersomogyi/projects/hbase-upstream/hbase-shell/src/main/ruby/irb/hirb.rb:109 each_top_level_statement at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/irb/ruby-lex.rb:246 loop at org/jruby/RubyKernel.java:1442 each_top_level_statement at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/irb/ruby-lex.rb:232 catch at org/jruby/RubyKernel.java:1189 each_top_level_statement at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/irb/ruby-lex.rb:231 eval_input at /Users/petersomogyi/projects/hbase-upstream/hbase-shell/src/main/ruby/irb/hirb.rb:108 run at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/irb.rb:428 catch at org/jruby/RubyKernel.java:1189 run at uri:classloader:/META-INF/jruby.home/lib/ruby/stdlib/irb.rb:427 at /Users/petersomogyi/projects/hbase-upstream/bin/../hbase-shell/src/main/ruby/jar-bootstrap.rb:223 ➜ hbase-upstream git:(HBASE-26741) ✗ echo $? 1 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] petersomogyi removed a comment on pull request #4101: HBASE-26741 Incorrect exception handling in shell
petersomogyi removed a comment on pull request #4101: URL: https://github.com/apache/hbase/pull/4101#issuecomment-1033865780 > what happens to stuff that comes from stdin in non-interactive mode? (in 2.2 and with this patch) Behaviour is identical. If a command throws an exception the shell does not quit and `exit` closes the shell. When `exit 2` is called the exit code is always 0 on 2.2 and with this patch. ``` ➜ hbase-2.2.7 bin/hbase shell 2022-02-09 16:06:25,663 WARN [main] util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable HBase Shell Use "help" to get list of supported commands. Use "exit" to quit this interactive shell. For Reference, please visit: http://hbase.apache.org/2.0/book.html#shell Version 2.2.7, r0fc18a9056e5eb3a80fdbde916865607946c5195, 2021年 04月 11日 星期日 19:24:57 CST Took 0.0022 seconds hbase(main):001:0> scan 'foo' ROW COLUMN+CELL ERROR: Unknown table foo! For usage try 'help "scan"' Took 0.2882 seconds hbase(main):002:0> exit ➜ hbase-2.2.7 echo $? 0 ``` ``` ➜ hbase-upstream git:(HBASE-26741) ✗ bin/hbase shell 2022-02-09T16:11:16,979 WARN [main] util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable HBase Shell Use "help" to get list of supported commands. Use "exit" to quit this interactive shell. For Reference, please visit: http://hbase.apache.org/book.html#shell Version 3.0.0-alpha-3-SNAPSHOT, r938144db0616f2008eb16c3653977dc6db1883fd, Wed Feb 9 14:05:48 CET 2022 Took 0.0012 seconds hbase:001:0> scan 'foo' ROWCOLUMN+CELL 2022-02-09T16:11:24,984 WARN [RPCClient-NioEventLoopGroup-1-2] client.AsyncNonMetaRegionLocator: Failed to locate region in 'foo', row='', locateType=CURRENT org.apache.hadoop.hbase.TableNotFoundException: foo at org.apache.hadoop.hbase.client.AsyncNonMetaRegionLocator$1.onComplete(AsyncNonMetaRegionLocator.java:503) ~[hbase-client-3.0.0-alpha-3-SNAPSHOT.jar:3.0.0-alpha-3-SNAPSHOT] [[[ LONG STACKTRACE ]]] at java.lang.Thread.run(Thread.java:748) [?:1.8.0_242] ERROR: Unknown table foo! For usage try 'help "scan"' Took 0.1283 seconds hbase:002:0> exit ➜ hbase-upstream git:(HBASE-26741) ✗ echo $? 0 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] petersomogyi commented on pull request #4101: HBASE-26741 Incorrect exception handling in shell
petersomogyi commented on pull request #4101: URL: https://github.com/apache/hbase/pull/4101#issuecomment-1033865780 > what happens to stuff that comes from stdin in non-interactive mode? (in 2.2 and with this patch) Behaviour is identical. If a command throws an exception the shell does not quit and `exit` closes the shell. When `exit 2` is called the exit code is always 0 on 2.2 and with this patch. ``` ➜ hbase-2.2.7 bin/hbase shell 2022-02-09 16:06:25,663 WARN [main] util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable HBase Shell Use "help" to get list of supported commands. Use "exit" to quit this interactive shell. For Reference, please visit: http://hbase.apache.org/2.0/book.html#shell Version 2.2.7, r0fc18a9056e5eb3a80fdbde916865607946c5195, 2021年 04月 11日 星期日 19:24:57 CST Took 0.0022 seconds hbase(main):001:0> scan 'foo' ROW COLUMN+CELL ERROR: Unknown table foo! For usage try 'help "scan"' Took 0.2882 seconds hbase(main):002:0> exit ➜ hbase-2.2.7 echo $? 0 ``` ``` ➜ hbase-upstream git:(HBASE-26741) ✗ bin/hbase shell 2022-02-09T16:11:16,979 WARN [main] util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable HBase Shell Use "help" to get list of supported commands. Use "exit" to quit this interactive shell. For Reference, please visit: http://hbase.apache.org/book.html#shell Version 3.0.0-alpha-3-SNAPSHOT, r938144db0616f2008eb16c3653977dc6db1883fd, Wed Feb 9 14:05:48 CET 2022 Took 0.0012 seconds hbase:001:0> scan 'foo' ROWCOLUMN+CELL 2022-02-09T16:11:24,984 WARN [RPCClient-NioEventLoopGroup-1-2] client.AsyncNonMetaRegionLocator: Failed to locate region in 'foo', row='', locateType=CURRENT org.apache.hadoop.hbase.TableNotFoundException: foo at org.apache.hadoop.hbase.client.AsyncNonMetaRegionLocator$1.onComplete(AsyncNonMetaRegionLocator.java:503) ~[hbase-client-3.0.0-alpha-3-SNAPSHOT.jar:3.0.0-alpha-3-SNAPSHOT] [[[ LONG STACKTRACE ]]] at java.lang.Thread.run(Thread.java:748) [?:1.8.0_242] ERROR: Unknown table foo! For usage try 'help "scan"' Took 0.1283 seconds hbase:002:0> exit ➜ hbase-upstream git:(HBASE-26741) ✗ echo $? 0 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] busbey commented on pull request #4101: HBASE-26741 Incorrect exception handling in shell
busbey commented on pull request #4101: URL: https://github.com/apache/hbase/pull/4101#issuecomment-1033857902 what happens to stuff that comes from stdin in non-interactive mode? (in 2.2 and with this patch) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26702) Make ageOfLastShip, ageOfLastApplied extend TimeHistogram instead of plain histogram.
[
https://issues.apache.org/jira/browse/HBASE-26702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17489610#comment-17489610
]
Rushabh Shah commented on HBASE-26702:
--
Thank you [~zhangduo] for the review and commit !
> Make ageOfLastShip, ageOfLastApplied extend TimeHistogram instead of plain
> histogram.
> --
>
> Key: HBASE-26702
> URL: https://issues.apache.org/jira/browse/HBASE-26702
> Project: HBase
> Issue Type: Improvement
> Components: metrics, Replication
>Affects Versions: 1.7.1, 2.3.7, 3.0.0-alpha-3
>Reporter: Rushabh Shah
>Assignee: Rushabh Shah
>Priority: Minor
> Fix For: 2.5.0, 1.7.2, 3.0.0-alpha-3, 2.4.10
>
>
> Currently age of last ship metric is an instance of an Histogram type.
> [Here|https://github.com/apache/hbase/blob/master/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationGlobalSourceSourceImpl.java#L58]
> {quote}
>ageOfLastShippedOpHist =
> rms.getMetricsRegistry().getHistogram(SOURCE_AGE_OF_LAST_SHIPPED_OP);
> {quote}
> We can change it to TimeHistogram so that we get the range information also.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (HBASE-26746) Update protobuf-java to 3.19.4
[ https://issues.apache.org/jira/browse/HBASE-26746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17489607#comment-17489607 ] Sean Busbey commented on HBASE-26746: - the external protobuf version is the one present for compatibility for e.g. deployed coprocessors. unless there's a fix in protobuf 2 we won't see that version get updated. > Update protobuf-java to 3.19.4 > -- > > Key: HBASE-26746 > URL: https://issues.apache.org/jira/browse/HBASE-26746 > Project: HBase > Issue Type: Bug > Components: Protobufs, thirdparty >Reporter: Pankaj Kumar >Assignee: Sean Busbey >Priority: Minor > > Refer, > https://nvd.nist.gov/vuln/detail/CVE-2021-22569 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [hbase] ndimiduk opened a new pull request #4104: HBASE-26521 Name RPC spans as `$package.$service/$method` (#4024)
ndimiduk opened a new pull request #4104: URL: https://github.com/apache/hbase/pull/4104 Signed-off-by: Duo Zhang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-26521) Name RPC spans as `$package.$service/$method`
[ https://issues.apache.org/jira/browse/HBASE-26521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-26521: - Fix Version/s: 3.0.0-alpha-3 > Name RPC spans as `$package.$service/$method` > - > > Key: HBASE-26521 > URL: https://issues.apache.org/jira/browse/HBASE-26521 > Project: HBase > Issue Type: Sub-task >Reporter: Nick Dimiduk >Assignee: Nick Dimiduk >Priority: Major > Fix For: 3.0.0-alpha-3 > > > As per > https://github.com/open-telemetry/opentelemetry-specification/blob/3e380e2/specification/trace/semantic_conventions/rpc.md#span-name -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [hbase] ndimiduk opened a new pull request #4103: HBASE-26521 Name RPC spans as `$package.$service/$method` (#4024)
ndimiduk opened a new pull request #4103: URL: https://github.com/apache/hbase/pull/4103 Signed-off-by: Duo Zhang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk merged pull request #4024: HBASE-26521 Name RPC spans as `$package.$service/$method`
ndimiduk merged pull request #4024: URL: https://github.com/apache/hbase/pull/4024 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #4024: HBASE-26521 Name RPC spans as `$package.$service/$method`
ndimiduk commented on pull request #4024: URL: https://github.com/apache/hbase/pull/4024#issuecomment-1033810534 And thank you @Apache9 for sticking with me through the reviews! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work started] (HBASE-26741) Incorrect exception handling in shell
[
https://issues.apache.org/jira/browse/HBASE-26741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-26741 started by Peter Somogyi.
-
> Incorrect exception handling in shell
> -
>
> Key: HBASE-26741
> URL: https://issues.apache.org/jira/browse/HBASE-26741
> Project: HBase
> Issue Type: Bug
> Components: shell
>Affects Versions: 2.5.0, 3.0.0-alpha-2, 2.4.10
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Critical
>
> The exception handling changed in the shell compared to 2.2.
> {noformat}
> ➜ hbase-upstream git:(branch-2.4) ✗ cat commands.txt
> scan 'foo'
> exit
> ➜ hbase-upstream git:(branch-2.4) ✗ bin/hbase shell -n commands.txt
> 2022-02-07 16:21:33,654 WARN [main] util.NativeCodeLoader: Unable to load
> native-hadoop library for your platform... using builtin-java classes where
> applicable
> hbase:001:0> scan 'foo'
> ROW COLUMN+CELL
> Took 0.3890 seconds
> Traceback (most
> recent call last):
> RuntimeError (Unknown table foo!)
> hbase:002:0> exit
> ➜ hbase-upstream git:(branch-2.4) ✗ echo $?
> 0 {noformat}
> The execution continues even after an exception is thrown. In 2.2.7 the
> execution stops when an exception is thrown and the shell exits with error
> code.
> {noformat}
> ➜ hbase-2.2.7 bin/hbase shell -n commands.txt
> 2022-02-07 16:33:54,930 WARN [main] util.NativeCodeLoader: Unable to load
> native-hadoop library for your platform... using builtin-java classes where
> applicable
> ROW COLUMN+CELL
> Took 0.3082 seconds
> RuntimeError:
> Unknown table foo!
> translate_hbase_exceptions at
> /Users/petersomogyi/tmp/hbase-2.2.7/lib/ruby/shell/commands.rb:130
> command_safe at
> /Users/petersomogyi/tmp/hbase-2.2.7/lib/ruby/shell/commands.rb:49
> internal_command at
> /Users/petersomogyi/tmp/hbase-2.2.7/lib/ruby/shell.rb:148
> command at
> /Users/petersomogyi/tmp/hbase-2.2.7/lib/ruby/shell.rb:140
> scan at (eval):2
> at commands.txt:1
> load at org/jruby/RubyKernel.java:973
> at
> /Users/petersomogyi/tmp/hbase-2.2.7/bin/../bin/hirb.rb:186
> ➜ hbase-2.2.7 echo $?
> 1 {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [hbase] Apache-HBase commented on pull request #4101: HBASE-26741 Incorrect exception handling in shell
Apache-HBase commented on pull request #4101: URL: https://github.com/apache/hbase/pull/4101#issuecomment-1033779901 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 14s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 1s | the patch passed | | -0 :warning: | rubocop | 0m 4s | The patch generated 39 new + 2 unchanged - 0 fixed = 41 total (was 2) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 29s | The patch does not generate ASF License warnings. | | | | 11m 36s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4101/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4101 | | Optional Tests | dupname asflicense javac rubocop | | uname | Linux 78ac4dfbb06d 4.15.0-161-generic #169-Ubuntu SMP Fri Oct 15 13:41:54 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0c19a5f1c8 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | rubocop | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4101/3/artifact/yetus-general-check/output/diff-patch-rubocop.txt | | Max. process+thread count | 78 (vs. ulimit of 3) | | modules | C: hbase-shell . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4101/3/console | | versions | git=2.17.1 maven=3.6.3 rubocop=0.80.0 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26644) Spurious compaction failures with file tracker
[
https://issues.apache.org/jira/browse/HBASE-26644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17489556#comment-17489556
]
Duo Zhang commented on HBASE-26644:
---
Ping [~elserj].
> Spurious compaction failures with file tracker
> --
>
> Key: HBASE-26644
> URL: https://issues.apache.org/jira/browse/HBASE-26644
> Project: HBase
> Issue Type: Sub-task
> Components: Compaction
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Major
>
> Noticed when running a basic {{{}hbase pe randomWrite{}}}, we'll see
> compactions failing at various points.
> One example:
> {noformat}
> 2022-01-03 17:41:18,319 ERROR
> [regionserver/localhost:16020-shortCompactions-0]
> regionserver.CompactSplit(670): Compaction failed
> region=TestTable,0004054490,1641249249856.2dc7251c6eceb660b9c7bb0b587db913.,
> storeName=2dc7251c6eceb660b9c7bb0b587db913/info0, priority=6,
> startTime=1641249666161
> java.io.IOException: Root-level entries already added in single-level mode
> at
> org.apache.hadoop.hbase.io.hfile.HFileBlockIndex$BlockIndexWriter.writeSingleLevelIndex(HFileBlockIndex.java:1136)
> at
> org.apache.hadoop.hbase.io.hfile.CompoundBloomFilterWriter$MetaWriter.write(CompoundBloomFilterWriter.java:279)
> at
> org.apache.hadoop.hbase.io.hfile.HFileWriterImpl$1.writeToBlock(HFileWriterImpl.java:713)
> at
> org.apache.hadoop.hbase.io.hfile.HFileBlock$Writer.writeBlock(HFileBlock.java:1205)
> at
> org.apache.hadoop.hbase.io.hfile.HFileWriterImpl.close(HFileWriterImpl.java:660)
> at
> org.apache.hadoop.hbase.regionserver.StoreFileWriter.close(StoreFileWriter.java:377)
> at
> org.apache.hadoop.hbase.regionserver.compactions.DefaultCompactor.commitWriter(DefaultCompactor.java:70)
> at
> org.apache.hadoop.hbase.regionserver.compactions.Compactor.compact(Compactor.java:386)
> at
> org.apache.hadoop.hbase.regionserver.compactions.DefaultCompactor.compact(DefaultCompactor.java:62)
> at
> org.apache.hadoop.hbase.regionserver.DefaultStoreEngine$DefaultCompactionContext.compact(DefaultStoreEngine.java:125)
> at org.apache.hadoop.hbase.regionserver.HStore.compact(HStore.java:1141)
> at org.apache.hadoop.hbase.regionserver.HRegion.compact(HRegion.java:2388)
> at
> org.apache.hadoop.hbase.regionserver.CompactSplit$CompactionRunner.doCompaction(CompactSplit.java:654)
> at
> org.apache.hadoop.hbase.regionserver.CompactSplit$CompactionRunner.run(CompactSplit.java:697)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748) {noformat}
> This isn't a super-critical issue because compactions will be retried
> automatically and they appear to eventually succeed. However, when the max
> storefiles limit is reaching, this does cause ingest to hang (as I was doing
> with my modest configuration).
> We had seen a similar kind of problem in our testing when backporting to
> HBase 2.4 (not upstream as the decision was to not do this) which we
> eventually tracked down to a bad merge-conflict resolution to the new HFile
> Cleaner. However, initial investigations don't have the same exact problem.
> It seems that we have some kind of generic race condition. Would be good to
> add more logging to catch this in the future (since we have two separate
> instances of this category of bug already).
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [hbase] Apache9 merged pull request #4081: HBASE-26724 Backport the UT changes in HBASE-24510 to branch-2.x
Apache9 merged pull request #4081: URL: https://github.com/apache/hbase/pull/4081 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] petersomogyi commented on pull request #4101: HBASE-26741 Incorrect exception handling in shell
petersomogyi commented on pull request #4101: URL: https://github.com/apache/hbase/pull/4101#issuecomment-1033776786 Manual testing shows these results, matching the behavior of HBase 2.2.7. | | commands.txt | commands-ok.txt | commands-ok-exit2.txt | | --- | | --- | - | | non-interactive | exception, 1 | 0 | 2 | | interactive | finish, 0| 0 | 2 | ``` $ cat commands.txt scan 'foo' exit $ cat commands-ok.txt scan 'hbase:meta' exit $ cat commands-ok-exit2.txt scan 'hbase:meta' exit 2 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26750) The branch-1 nightly jenkins job fails with "No such DSL method 'jiraComment' found"
[ https://issues.apache.org/jira/browse/HBASE-26750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17489554#comment-17489554 ] Duo Zhang commented on HBASE-26750: --- I installed jira plugin on ci-hbase. Let's wait to see the result. > The branch-1 nightly jenkins job fails with "No such DSL method 'jiraComment' > found" > > > Key: HBASE-26750 > URL: https://issues.apache.org/jira/browse/HBASE-26750 > Project: HBase > Issue Type: Sub-task > Components: jenkins >Reporter: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (HBASE-26750) The branch-1 nightly jenkins job fails with "No such DSL method 'jiraComment' found"
[ https://issues.apache.org/jira/browse/HBASE-26750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17489553#comment-17489553 ] Duo Zhang commented on HBASE-26750: --- I used to think this is branch-1 only but seems the other branches also have this step. The reason why they do not fail is because they are not finished yet... > The branch-1 nightly jenkins job fails with "No such DSL method 'jiraComment' > found" > > > Key: HBASE-26750 > URL: https://issues.apache.org/jira/browse/HBASE-26750 > Project: HBase > Issue Type: Sub-task > Components: jenkins >Reporter: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [hbase] petersomogyi commented on pull request #4101: HBASE-26741 Incorrect exception handling in shell
petersomogyi commented on pull request #4101: URL: https://github.com/apache/hbase/pull/4101#issuecomment-1033767721 > JRuby appears to be 2-clause bsd (assuming BSDL is not unique to the standard BSD license...) The irb.rb file (and the duplicated method) is originally from Ruby and not JRuby: https://github.com/ruby/irb/blob/9d7ba836eb1ec8ec71b6a24e9683ba96fe3fb72b/lib/irb.rb#L441-L537 This repository is using BSD 2-Clause which is a Category A license by ASF policies: https://www.apache.org/legal/resolved.html#category-a > unit test to cover this I'm not yet sure how to do that. We have [existing tests](https://github.com/apache/hbase/blob/master/hbase-shell/src/test/ruby/shell/noninteractive_test.rb#L26-L39) for shell command execution throwing exception in non-interactive mode but these tests don't use IRB.run underneath. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-26750) The branch-1 nightly jenkins job fails with "No such DSL method 'jiraComment' found"
[ https://issues.apache.org/jira/browse/HBASE-26750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26750: -- Component/s: jenkins > The branch-1 nightly jenkins job fails with "No such DSL method 'jiraComment' > found" > > > Key: HBASE-26750 > URL: https://issues.apache.org/jira/browse/HBASE-26750 > Project: HBase > Issue Type: Sub-task > Components: jenkins >Reporter: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (HBASE-26750) The branch-1 nightly jenkins job fails with "No such DSL method 'jiraComment' found"
Duo Zhang created HBASE-26750: - Summary: The branch-1 nightly jenkins job fails with "No such DSL method 'jiraComment' found" Key: HBASE-26750 URL: https://issues.apache.org/jira/browse/HBASE-26750 Project: HBase Issue Type: Sub-task Reporter: Duo Zhang -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (HBASE-26742) Comparator of NOT_EQUAL NULL is invalid for checkAndMutate
[
https://issues.apache.org/jira/browse/HBASE-26742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17489428#comment-17489428
]
Xiaolin Ha commented on HBASE-26742:
Yes, result is empty, just follows the tree conditions.
> Comparator of NOT_EQUAL NULL is invalid for checkAndMutate
> --
>
> Key: HBASE-26742
> URL: https://issues.apache.org/jira/browse/HBASE-26742
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0-alpha-1, 2.0.0
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
>
> In server side, checkAndMutate ignores CompareOperator for null or empty
> comparator value, but NOT_EQUAL should be treated specially.
> The check logic in HRegion#checkAndMutateInternal is as follows,
> {code:java}
> boolean valueIsNull =
> comparator.getValue() == null || comparator.getValue().length == 0;
> if (result.isEmpty() && valueIsNull) {
> matches = true;
> } else if (result.size() > 0 && result.get(0).getValueLength() == 0 &&
> valueIsNull) {
> matches = true;
> cellTs = result.get(0).getTimestamp();
> } else if (result.size() == 1 && !valueIsNull) {
> Cell kv = result.get(0);
> cellTs = kv.getTimestamp();
> int compareResult = PrivateCellUtil.compareValue(kv, comparator);
> matches = matches(op, compareResult);
> }{code}
> For current logics, here are some counter examples(Comparator value is set
> null),
> # result is null, operator is NOT_EQUAL, but matches is true;
> # result size >0, the value of the first cell is empty, operator is
> NOT_EQUAL, but matches is true;
> # result size is 1, operator is NOT_EQUAL, but matches is false;
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [hbase] Apache-HBase commented on pull request #4101: HBASE-26741 Incorrect exception handling in shell
Apache-HBase commented on pull request #4101: URL: https://github.com/apache/hbase/pull/4101#issuecomment-1033573969 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 16s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 31s | master passed | | +1 :green_heart: | javadoc | 0m 15s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 35s | the patch passed | | +1 :green_heart: | javadoc | 0m 15s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 6m 50s | hbase-shell in the patch passed. | | | | 21m 44s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4101/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4101 | | Optional Tests | javac javadoc unit | | uname | Linux 7381b0b44b38 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / fddfceef50 | | Default Java | AdoptOpenJDK-11.0.10+9 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4101/2/testReport/ | | Max. process+thread count | 2445 (vs. ulimit of 3) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4101/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4101: HBASE-26741 Incorrect exception handling in shell
Apache-HBase commented on pull request #4101: URL: https://github.com/apache/hbase/pull/4101#issuecomment-1033572002 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 58s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 34s | master passed | | +1 :green_heart: | javadoc | 0m 15s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 23s | the patch passed | | +1 :green_heart: | javadoc | 0m 12s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 8m 15s | hbase-shell in the patch passed. | | | | 19m 34s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4101/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4101 | | Optional Tests | javac javadoc unit | | uname | Linux 360f58a7b933 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / fddfceef50 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4101/2/testReport/ | | Max. process+thread count | 1616 (vs. ulimit of 3) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4101/2/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #4101: HBASE-26741 Incorrect exception handling in shell
Apache-HBase commented on pull request #4101: URL: https://github.com/apache/hbase/pull/4101#issuecomment-1033563275 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 50s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 51s | the patch passed | | -0 :warning: | rubocop | 0m 4s | The patch generated 39 new + 2 unchanged - 0 fixed = 41 total (was 2) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 12s | The patch does not generate ASF License warnings. | | | | 9m 56s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4101/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/4101 | | Optional Tests | dupname asflicense javac rubocop | | uname | Linux b98717caac9f 4.15.0-161-generic #169-Ubuntu SMP Fri Oct 15 13:41:54 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / fddfceef50 | | Default Java | AdoptOpenJDK-1.8.0_282-b08 | | rubocop | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4101/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt | | Max. process+thread count | 78 (vs. ulimit of 3) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4101/2/console | | versions | git=2.17.1 maven=3.6.3 rubocop=0.80.0 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26748) In the multi-instance deployment scenario, the specific instance that fails to synchronize cannot be queried
[ https://issues.apache.org/jira/browse/HBASE-26748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17489401#comment-17489401 ] chenhaosen commented on HBASE-26748: I am working on the PR and will raise it soon. > In the multi-instance deployment scenario, the specific instance that fails > to synchronize cannot be queried > - > > Key: HBASE-26748 > URL: https://issues.apache.org/jira/browse/HBASE-26748 > Project: HBase > Issue Type: Improvement > Components: shell >Reporter: chenhaosen >Priority: Minor > > In the multi-instance deployment scenario, the specific instance that fails > to synchronize cannot be queried since it only output the hostname of > RegionServer -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (HBASE-26748) In the multi-instance deployment scenario, the specific instance that fails to synchronize cannot be queried
[ https://issues.apache.org/jira/browse/HBASE-26748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenhaosen updated HBASE-26748: --- Component/s: shell (was: Client) > In the multi-instance deployment scenario, the specific instance that fails > to synchronize cannot be queried > - > > Key: HBASE-26748 > URL: https://issues.apache.org/jira/browse/HBASE-26748 > Project: HBase > Issue Type: Improvement > Components: shell >Reporter: chenhaosen >Priority: Minor > > In the multi-instance deployment scenario, the specific instance that fails > to synchronize cannot be queried since it only output the hostname of > RegionServer -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (HBASE-26748) In the multi-instance deployment scenario, the specific instance that fails to synchronize cannot be queried
[ https://issues.apache.org/jira/browse/HBASE-26748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenhaosen updated HBASE-26748: --- Priority: Minor (was: Trivial) > In the multi-instance deployment scenario, the specific instance that fails > to synchronize cannot be queried > - > > Key: HBASE-26748 > URL: https://issues.apache.org/jira/browse/HBASE-26748 > Project: HBase > Issue Type: Improvement > Components: Client >Affects Versions: 2.2.3 >Reporter: chenhaosen >Priority: Minor > Fix For: 2.2.3 > > > In the multi-instance deployment scenario, the specific instance that fails > to synchronize cannot be queried since it only output the hostname of > RegionServer -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (HBASE-26748) In the multi-instance deployment scenario, the specific instance that fails to synchronize cannot be queried
[ https://issues.apache.org/jira/browse/HBASE-26748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenhaosen updated HBASE-26748: --- Fix Version/s: (was: 2.2.3) > In the multi-instance deployment scenario, the specific instance that fails > to synchronize cannot be queried > - > > Key: HBASE-26748 > URL: https://issues.apache.org/jira/browse/HBASE-26748 > Project: HBase > Issue Type: Improvement > Components: Client >Affects Versions: 2.2.3 >Reporter: chenhaosen >Priority: Minor > > In the multi-instance deployment scenario, the specific instance that fails > to synchronize cannot be queried since it only output the hostname of > RegionServer -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (HBASE-26748) In the multi-instance deployment scenario, the specific instance that fails to synchronize cannot be queried
[ https://issues.apache.org/jira/browse/HBASE-26748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenhaosen updated HBASE-26748: --- Affects Version/s: (was: 2.2.3) > In the multi-instance deployment scenario, the specific instance that fails > to synchronize cannot be queried > - > > Key: HBASE-26748 > URL: https://issues.apache.org/jira/browse/HBASE-26748 > Project: HBase > Issue Type: Improvement > Components: Client >Reporter: chenhaosen >Priority: Minor > > In the multi-instance deployment scenario, the specific instance that fails > to synchronize cannot be queried since it only output the hostname of > RegionServer -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (HBASE-26749) Migrate HBase main pre commit job to ci-hbase
[ https://issues.apache.org/jira/browse/HBASE-26749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-26749: - Assignee: Duo Zhang > Migrate HBase main pre commit job to ci-hbase > - > > Key: HBASE-26749 > URL: https://issues.apache.org/jira/browse/HBASE-26749 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > We used to run this on the hadoop label so first we need to change the label > in jenkins file. > And before migration, we need to move the 10 hbase nodes from ci-hadoop to > ci-hbase as there are no jobs on them any more. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Work started] (HBASE-26749) Migrate HBase main pre commit job to ci-hbase
[ https://issues.apache.org/jira/browse/HBASE-26749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-26749 started by Duo Zhang. - > Migrate HBase main pre commit job to ci-hbase > - > > Key: HBASE-26749 > URL: https://issues.apache.org/jira/browse/HBASE-26749 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > We used to run this on the hadoop label so first we need to change the label > in jenkins file. > And before migration, we need to move the 10 hbase nodes from ci-hadoop to > ci-hbase as there are no jobs on them any more. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (HBASE-26749) Migrate HBase main pre commit job to ci-hbase
Duo Zhang created HBASE-26749: - Summary: Migrate HBase main pre commit job to ci-hbase Key: HBASE-26749 URL: https://issues.apache.org/jira/browse/HBASE-26749 Project: HBase Issue Type: Sub-task Reporter: Duo Zhang We used to run this on the hadoop label so first we need to change the label in jenkins file. And before migration, we need to move the 10 hbase nodes from ci-hadoop to ci-hbase as there are no jobs on them any more. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (HBASE-26748) In the multi-instance deployment scenario, the specific instance that fails to synchronize cannot be queried
[ https://issues.apache.org/jira/browse/HBASE-26748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenhaosen updated HBASE-26748: --- Priority: Trivial (was: Major) > In the multi-instance deployment scenario, the specific instance that fails > to synchronize cannot be queried > - > > Key: HBASE-26748 > URL: https://issues.apache.org/jira/browse/HBASE-26748 > Project: HBase > Issue Type: Improvement > Components: Client >Affects Versions: 2.2.3 >Reporter: chenhaosen >Priority: Trivial > Fix For: 2.2.3 > > > In the multi-instance deployment scenario, the specific instance that fails > to synchronize cannot be queried since it only output the hostname of > RegionServer -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (HBASE-26748) In the multi-instance deployment scenario, the specific instance that fails to synchronize cannot be queried
[ https://issues.apache.org/jira/browse/HBASE-26748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenhaosen updated HBASE-26748: --- Component/s: Client (was: shell) > In the multi-instance deployment scenario, the specific instance that fails > to synchronize cannot be queried > - > > Key: HBASE-26748 > URL: https://issues.apache.org/jira/browse/HBASE-26748 > Project: HBase > Issue Type: Improvement > Components: Client >Affects Versions: 2.2.3 >Reporter: chenhaosen >Priority: Major > Fix For: 2.2.3 > > > In the multi-instance deployment scenario, the specific instance that fails > to synchronize cannot be queried since it only output the hostname of > RegionServer -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (HBASE-26747) Use python2 instead of python in our python scripts
[ https://issues.apache.org/jira/browse/HBASE-26747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-26747. --- Fix Version/s: 2.5.0 1.7.2 3.0.0-alpha-3 2.4.10 Hadoop Flags: Reviewed Resolution: Fixed Pushed to all active branches. Thanks [~sunxin] for reviewing! > Use python2 instead of python in our python scripts > --- > > Key: HBASE-26747 > URL: https://issues.apache.org/jira/browse/HBASE-26747 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 2.5.0, 1.7.2, 3.0.0-alpha-3, 2.4.10 > > > According to the suggestion from INFRA team, let's specify python2 directly. > Later we could see if we can migrate to python3. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (HBASE-26748) In the multi-instance deployment scenario, the specific instance that fails to synchronize cannot be queried
chenhaosen created HBASE-26748: -- Summary: In the multi-instance deployment scenario, the specific instance that fails to synchronize cannot be queried Key: HBASE-26748 URL: https://issues.apache.org/jira/browse/HBASE-26748 Project: HBase Issue Type: Improvement Components: shell Affects Versions: 2.2.3 Reporter: chenhaosen Fix For: 2.2.3 In the multi-instance deployment scenario, the specific instance that fails to synchronize cannot be queried since it only output the hostname of RegionServer -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (HBASE-26742) Comparator of NOT_EQUAL NULL is invalid for checkAndMutate
[
https://issues.apache.org/jira/browse/HBASE-26742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17489354#comment-17489354
]
Zhuoyue Huang commented on HBASE-26742:
---
{quote}1. result is null, operator is NOT_EQUAL, but matches is true;
{quote}
I don't think you were trying to explain 'result is null' here. 'result'
couldn't be null because we have initialized it in advance.
{code:java}
List result = new ArrayList<>(1);{code}
Did you mean to say 'result is empty'?
[~Xiaolin Ha]
> Comparator of NOT_EQUAL NULL is invalid for checkAndMutate
> --
>
> Key: HBASE-26742
> URL: https://issues.apache.org/jira/browse/HBASE-26742
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0-alpha-1, 2.0.0
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
>
> In server side, checkAndMutate ignores CompareOperator for null or empty
> comparator value, but NOT_EQUAL should be treated specially.
> The check logic in HRegion#checkAndMutateInternal is as follows,
> {code:java}
> boolean valueIsNull =
> comparator.getValue() == null || comparator.getValue().length == 0;
> if (result.isEmpty() && valueIsNull) {
> matches = true;
> } else if (result.size() > 0 && result.get(0).getValueLength() == 0 &&
> valueIsNull) {
> matches = true;
> cellTs = result.get(0).getTimestamp();
> } else if (result.size() == 1 && !valueIsNull) {
> Cell kv = result.get(0);
> cellTs = kv.getTimestamp();
> int compareResult = PrivateCellUtil.compareValue(kv, comparator);
> matches = matches(op, compareResult);
> }{code}
> For current logics, here are some counter examples(Comparator value is set
> null),
> # result is null, operator is NOT_EQUAL, but matches is true;
> # result size >0, the value of the first cell is empty, operator is
> NOT_EQUAL, but matches is true;
> # result size is 1, operator is NOT_EQUAL, but matches is false;
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (HBASE-23158) If KVs are in memstore, small batch get can come across MultiActionResultTooLarge
[ https://issues.apache.org/jira/browse/HBASE-23158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17489351#comment-17489351 ] Yutong Xiao commented on HBASE-23158: - Encountered this problem also. For this problem, could we just use the number of cells times a predefined blocksize to approximate the total block size (one cell, one block)? For cells in memstore, they will be flushed in short time, so that we can just regard them as cells read from HFiles I think. This may solve this annoying exception. The problem is the approximation is rough granularity (different table can have different blocksize). What do you think? > If KVs are in memstore, small batch get can come across > MultiActionResultTooLarge > -- > > Key: HBASE-23158 > URL: https://issues.apache.org/jira/browse/HBASE-23158 > Project: HBase > Issue Type: Bug > Components: regionserver, rpc > Environment: [^TestMultiRespectsLimitsMemstore.patch] >Reporter: junfei liang >Priority: Minor > Attachments: TestMultiRespectsLimitsMemstore.patch > > > to protect against big scan, we set hbase.server.scanner.max.result.size = > 10MB in our customer hbase cluster, however our clients can meet > MultiActionResultTooLarge even in small batch get (for ex. 15 batch get, and > row size is about 5KB ) . > after [HBASE-14978|https://issues.apache.org/jira/browse/HBASE-14978] hbase > take the data block reference into consideration, but the block size is 64KB > (the default value ), even if all cells are from different block , the block > size retained is less than 1MB, so what's the problem ? > finally i found that HBASE-14978 also consider the cell in memstore, as > MSLAB is enabled default, so if the cell is from memstore, cell backend array > can be large (2MB as default), so even if a small batch can meet this error, > is this reasonable ? > plus: > when throw MultiActionResultTooLarge exception, hbase client should retry > ignore rpc retry num, however if set retry num to zero, client will fail > without retry in this case. > > see attachment TestMultiRespectsLimitsMemstore for details. > -- This message was sent by Atlassian Jira (v8.20.1#820001)
