Re: [PR] HBASE-28316 Add BootstrapNodeService handlers [hbase]
Apache-HBase commented on PR #5637: URL: https://github.com/apache/hbase/pull/5637#issuecomment-1897930351 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 21s | master passed | | +1 :green_heart: | compile | 0m 56s | master passed | | +1 :green_heart: | shadedjars | 5m 30s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 23s | the patch passed | | +1 :green_heart: | compile | 0m 54s | the patch passed | | +1 :green_heart: | javac | 0m 54s | the patch passed | | +1 :green_heart: | shadedjars | 5m 27s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 35s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 13s | hbase-client in the patch passed. | | -1 :x: | unit | 236m 53s | hbase-server in the patch failed. | | | | 261m 55s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5637/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5637 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 5e47101386d8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6b0ce08c82 | | Default Java | Temurin-1.8.0_352-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5637/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5637/2/testReport/ | | Max. process+thread count | 4515 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5637/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28316 Add BootstrapNodeService handlers [hbase]
Apache-HBase commented on PR #5637: URL: https://github.com/apache/hbase/pull/5637#issuecomment-1897914968 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 20s | master passed | | +1 :green_heart: | compile | 1m 1s | master passed | | +1 :green_heart: | shadedjars | 5m 32s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 50s | the patch passed | | +1 :green_heart: | compile | 1m 2s | the patch passed | | +1 :green_heart: | javac | 1m 2s | the patch passed | | +1 :green_heart: | shadedjars | 5m 30s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 33s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 218m 43s | hbase-server in the patch passed. | | | | 245m 46s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5637/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5637 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux f546f40811c8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6b0ce08c82 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5637/2/testReport/ | | Max. process+thread count | 4755 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5637/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28314 Enable maven-source-plugin for all modules [hbase]
Apache-HBase commented on PR #5636: URL: https://github.com/apache/hbase/pull/5636#issuecomment-1897897962 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 54s | master passed | | +1 :green_heart: | compile | 4m 55s | master passed | | +1 :green_heart: | checkstyle | 1m 5s | master passed | | +1 :green_heart: | spotless | 0m 44s | branch has no errors when running spotless:check. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 45s | the patch passed | | +1 :green_heart: | compile | 4m 53s | the patch passed | | +1 :green_heart: | javac | 4m 53s | the patch passed | | +1 :green_heart: | checkstyle | 1m 0s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 26s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 4m 53s | Patch does not cause any errors with Hadoop 3.3.6. | | +1 :green_heart: | spotless | 0m 41s | patch has no errors when running spotless:check. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 3m 58s | The patch does not generate ASF License warnings. | | | | 37m 32s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5636/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5636 | | Optional Tests | dupname asflicense javac hadoopcheck spotless xml compile checkstyle | | uname | Linux e902bf0d2f67 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6b0ce08c82 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 79 (vs. ulimit of 3) | | modules | C: hbase-checkstyle hbase-logging hbase-protocol-shaded hbase-metrics-api hbase-metrics hbase-hadoop-compat hbase-client hbase-replication hbase-balancer hbase-asyncfs hbase-procedure hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded hbase-extensions/hbase-openssl hbase-external-blockcache hbase-hbtop . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5636/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-28314) Enable maven-source-plugin for all modules
[ https://issues.apache.org/jira/browse/HBASE-28314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808026#comment-17808026 ] Istvan Toth commented on HBASE-28314: - I have also disabled the plugin for hbase-checkstyle and hbase-extensions. We still generate some empty test-sources jars, but I do not necessarily consider that a problem. We may also want to disable hbase-resource-bundle, as that one contains only an intermediate xml file used during the build process. > Enable maven-source-plugin for all modules > -- > > Key: HBASE-28314 > URL: https://issues.apache.org/jira/browse/HBASE-28314 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 2.6.0, 2.4.17, 3.0.0-beta-1, 4.0.0-alpha-1, 2.5.7 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > > There is no source jar generated for hbase-server. > Enabling maven-source-plugin seems to work fine, and Eclipse can use the > generated sources jar for debugging etc. > It seems that these source JARs are not generated at least since HBase 2.0.0, > but we did have source JARs sometime in the 1.x time frame. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-28314) Enable maven-source-plugin for all modules
[ https://issues.apache.org/jira/browse/HBASE-28314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808015#comment-17808015 ] Istvan Toth commented on HBASE-28314: - Thank you [~nihaljain.cs]. Based on that ticket creating dummy sources JARs (at least for the shaded artifacts) was considered a bug. I will update the patch to disable source jars at least for the shaded artifacts. > Enable maven-source-plugin for all modules > -- > > Key: HBASE-28314 > URL: https://issues.apache.org/jira/browse/HBASE-28314 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 2.6.0, 2.4.17, 3.0.0-beta-1, 4.0.0-alpha-1, 2.5.7 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > > There is no source jar generated for hbase-server. > Enabling maven-source-plugin seems to work fine, and Eclipse can use the > generated sources jar for debugging etc. > It seems that these source JARs are not generated at least since HBase 2.0.0, > but we did have source JARs sometime in the 1.x time frame. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-28305) Add "Uncompressed StoreFileSize" column to the table.jsp
[
https://issues.apache.org/jira/browse/HBASE-28305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807995#comment-17807995
]
Hudson commented on HBASE-28305:
Results for branch branch-2.6
[build #34 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/34/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/34/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/34/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/34/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/34/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add "Uncompressed StoreFileSize" column to the table.jsp
>
>
> Key: HBASE-28305
> URL: https://issues.apache.org/jira/browse/HBASE-28305
> Project: HBase
> Issue Type: Improvement
> Components: UI
>Reporter: haosen chen
>Assignee: haosen chen
>Priority: Minor
> Fix For: 2.6.0, 3.0.0-beta-2
>
> Attachments: HBASE-28305-2.png, HBASE-28305.png
>
>
> Currently, HBase Web UI can only see the uncompressed StoreFile size of each
> Region on the Region Server page, but sometimes we also hope to see this
> information on the table details page, which can help analyze the data
> distribution of each table.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-28306) Add property to customize Version information
[
https://issues.apache.org/jira/browse/HBASE-28306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807993#comment-17807993
]
Hudson commented on HBASE-28306:
Results for branch branch-2.6
[build #34 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/34/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/34/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/34/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/34/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/34/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add property to customize Version information
> -
>
> Key: HBASE-28306
> URL: https://issues.apache.org/jira/browse/HBASE-28306
> Project: HBase
> Issue Type: Improvement
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Major
> Fix For: 2.6.0, 2.5.8, 3.0.0-beta-2
>
>
> In hbase-common we generate Version.java using the ${project.version}
> property. In some custom builds, it may be necessary to override the project
> version. The custom version may not be compatible with how Version works, or
> the user may want to add extra metadata (like a build number). We can add a
> property which defaults to ${project.version} but allows the user to specify
> separately if desired.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-26268) Provide coprocessor hooks for updateConfiguration and clearRegionBlockCache
[
https://issues.apache.org/jira/browse/HBASE-26268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807996#comment-17807996
]
Hudson commented on HBASE-26268:
Results for branch branch-2.6
[build #34 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/34/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/34/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/34/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/34/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/34/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Provide coprocessor hooks for updateConfiguration and clearRegionBlockCache
> ---
>
> Key: HBASE-26268
> URL: https://issues.apache.org/jira/browse/HBASE-26268
> Project: HBase
> Issue Type: Bug
>Reporter: Bryan Beaudreault
>Assignee: Charles Connell
>Priority: Major
> Fix For: 2.6.0, 4.0.0-alpha-1, 3.0.0-beta-2
>
>
> Sorry for the vague title, not sure if it'd be better to create individual
> jiras. I discovered that the following two AdminService endpoints are not
> covered by AccessController:
>
> * updateConfiguration
> * clearRegionBlockCache
> There may be others, I haven't done a full audit. We should add coprocessor
> hooks for these and wrap with AccessController, especially since they can
> both have an affect on the cluster.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-28312) The bad auth exception can not be passed to client rpc calls properly
[
https://issues.apache.org/jira/browse/HBASE-28312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807994#comment-17807994
]
Hudson commented on HBASE-28312:
Results for branch branch-2.6
[build #34 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/34/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/34/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/34/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/34/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.6/34/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> The bad auth exception can not be passed to client rpc calls properly
> -
>
> Key: HBASE-28312
> URL: https://issues.apache.org/jira/browse/HBASE-28312
> Project: HBase
> Issue Type: Bug
> Components: Client, IPC/RPC
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 2.4.18, 2.5.8, 3.0.0-beta-2
>
>
> Found this when implementing HBASE-25051.
> Basically there are 2 problems:
> # IPCUtil.isFatalConnectionException only checks whether class name matches,
> so if we use a sub class for FatalConnectionException, it will return false
> which makes the logic incorrect.
> # In BlockingRpcConnection, we will first check whether there is a call with
> the id but since we will pass -1 as call id for bad preamble header, we will
> return earlier without actually checking the error response.
> This will not introduce big trouble in production as the call will still fail
> with connection closed exception, but still worth to fix, anyway.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-28321) RpcConnectionRegistry is broken when security is enabled and we use different principal for master and region server
[ https://issues.apache.org/jira/browse/HBASE-28321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807988#comment-17807988 ] Duo Zhang commented on HBASE-28321: --- [~bbeaudreault] FYI. > RpcConnectionRegistry is broken when security is enabled and we use different > principal for master and region server > > > Key: HBASE-28321 > URL: https://issues.apache.org/jira/browse/HBASE-28321 > Project: HBase > Issue Type: Sub-task > Components: Client, IPC/RPC, security >Reporter: Duo Zhang >Priority: Critical > > After introducing RpcConnectionRegistry, we let master and region server both > implement ClientMetaService. > In our current client architecture, when security is enabled, we rely on the > record in SecurityInfo to determine the server principal to use, > unfortunately there is only one principal can be specified, so if we use > different principal for master and region server, either we can not connect > to master, or we can not connect to region server. > And just changing the server principal field in SecurityInfo to an array can > not solve the problem, as when connecting, we do not know whether the remote > server is a master or region server, so we still can not determine which > principal to use... > Anyway, since this has been in our code base since 2.5.0, it is not a new > problem, so just set it as critical, not a blocker. But we should find out > the solution ASAP. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-28316 Add BootstrapNodeService handlers [hbase]
Apache-HBase commented on PR #5637: URL: https://github.com/apache/hbase/pull/5637#issuecomment-1897721867 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 13s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 45s | master passed | | +1 :green_heart: | compile | 3m 6s | master passed | | +1 :green_heart: | checkstyle | 0m 50s | master passed | | +1 :green_heart: | spotless | 0m 42s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 14s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 45s | the patch passed | | +1 :green_heart: | compile | 3m 9s | the patch passed | | +1 :green_heart: | javac | 3m 9s | the patch passed | | +1 :green_heart: | checkstyle | 0m 52s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 4m 41s | Patch does not cause any errors with Hadoop 3.3.6. | | +1 :green_heart: | spotless | 0m 41s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 33s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 19s | The patch does not generate ASF License warnings. | | | | 31m 19s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5637/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5637 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 86a09572f48c 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6b0ce08c82 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 80 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5637/2/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-28321) RpcConnectionRegistry is broken when security is enabled and we use different principal for master and region server
[ https://issues.apache.org/jira/browse/HBASE-28321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-28321: -- Description: After introducing RpcConnectionRegistry, we let master and region server both implement ClientMetaService. In our current client architecture, when security is enabled, we rely on the record in SecurityInfo to determine the server principal to use, unfortunately there is only one principal can be specified, so if we use different principal for master and region server, either we can not connect to master, or we can not connect to region server. And just changing the server principal field in SecurityInfo to an array can not solve the problem, as when connecting, we do not know whether the remote server is a master or region server, so we still can not determine which principal to use... Anyway, since this has been in our code base since 2.5.0, it is not a new problem, so just set it as critical, not a blocker. But we should find out the solution ASAP. > RpcConnectionRegistry is broken when security is enabled and we use different > principal for master and region server > > > Key: HBASE-28321 > URL: https://issues.apache.org/jira/browse/HBASE-28321 > Project: HBase > Issue Type: Sub-task > Components: Client, IPC/RPC, security >Reporter: Duo Zhang >Priority: Critical > > After introducing RpcConnectionRegistry, we let master and region server both > implement ClientMetaService. > In our current client architecture, when security is enabled, we rely on the > record in SecurityInfo to determine the server principal to use, > unfortunately there is only one principal can be specified, so if we use > different principal for master and region server, either we can not connect > to master, or we can not connect to region server. > And just changing the server principal field in SecurityInfo to an array can > not solve the problem, as when connecting, we do not know whether the remote > server is a master or region server, so we still can not determine which > principal to use... > Anyway, since this has been in our code base since 2.5.0, it is not a new > problem, so just set it as critical, not a blocker. But we should find out > the solution ASAP. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-28316 Add BootstrapNodeService handlers [hbase]
bbeaudreault commented on code in PR #5637:
URL: https://github.com/apache/hbase/pull/5637#discussion_r1456757793
##
hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBasePolicyProvider.java:
##
@@ -44,8 +46,11 @@ public class HBasePolicyProvider extends PolicyProvider {
new Service("security.client.protocol.acl",
RegistryProtos.ClientMetaService.BlockingInterface.class),
new Service("security.admin.protocol.acl",
MasterService.BlockingInterface.class),
+ new Service("security.admin.protocol.acl",
LockService.BlockingInterface.class),
Review Comment:
Sounds good, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] HBASE-28316 Add BootstrapNodeService handlers [hbase]
Apache9 commented on code in PR #5637:
URL: https://github.com/apache/hbase/pull/5637#discussion_r1456756258
##
hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBasePolicyProvider.java:
##
@@ -44,8 +46,11 @@ public class HBasePolicyProvider extends PolicyProvider {
new Service("security.client.protocol.acl",
RegistryProtos.ClientMetaService.BlockingInterface.class),
new Service("security.admin.protocol.acl",
MasterService.BlockingInterface.class),
+ new Service("security.admin.protocol.acl",
LockService.BlockingInterface.class),
Review Comment:
I added a UT in this PR to find out the inconsistency between
HBasePolicyProvider, SecurityInfo and the services deployed in our
MasterRpcServices and RSRpcServices, and then found out that LockService is
missing, so it should have been broken for a long time.
I searched the code base, had not found any references to this service,
maybe it is not exposed through our normal client API, but since it is exposed
as an rpc service, we should fix it anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (HBASE-28312) The bad auth exception can not be passed to client rpc calls properly
[ https://issues.apache.org/jira/browse/HBASE-28312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-28312: -- Component/s: IPC/RPC (was: rpc) > The bad auth exception can not be passed to client rpc calls properly > - > > Key: HBASE-28312 > URL: https://issues.apache.org/jira/browse/HBASE-28312 > Project: HBase > Issue Type: Bug > Components: Client, IPC/RPC >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 2.6.0, 2.4.18, 2.5.8, 3.0.0-beta-2 > > > Found this when implementing HBASE-25051. > Basically there are 2 problems: > # IPCUtil.isFatalConnectionException only checks whether class name matches, > so if we use a sub class for FatalConnectionException, it will return false > which makes the logic incorrect. > # In BlockingRpcConnection, we will first check whether there is a call with > the id but since we will pass -1 as call id for bad preamble header, we will > return earlier without actually checking the error response. > This will not introduce big trouble in production as the call will still fail > with connection closed exception, but still worth to fix, anyway. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (HBASE-28321) RpcConnectionRegistry is broken when security is enabled and we use different principal for master and region server
Duo Zhang created HBASE-28321: - Summary: RpcConnectionRegistry is broken when security is enabled and we use different principal for master and region server Key: HBASE-28321 URL: https://issues.apache.org/jira/browse/HBASE-28321 Project: HBase Issue Type: Sub-task Components: Client, IPC/RPC, security Reporter: Duo Zhang -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-28306) Add property to customize Version information
[
https://issues.apache.org/jira/browse/HBASE-28306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807950#comment-17807950
]
Hudson commented on HBASE-28306:
Results for branch master
[build #987 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/987/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/987/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/987/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/987/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 3. [see log for
details|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/987//artifact/output-integration/hadoop-3.log].
(note that this means we didn't check the Hadoop 3 shaded client)
> Add property to customize Version information
> -
>
> Key: HBASE-28306
> URL: https://issues.apache.org/jira/browse/HBASE-28306
> Project: HBase
> Issue Type: Improvement
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Major
> Fix For: 2.6.0, 2.5.8, 3.0.0-beta-2
>
>
> In hbase-common we generate Version.java using the ${project.version}
> property. In some custom builds, it may be necessary to override the project
> version. The custom version may not be compatible with how Version works, or
> the user may want to add extra metadata (like a build number). We can add a
> property which defaults to ${project.version} but allows the user to specify
> separately if desired.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-28312) The bad auth exception can not be passed to client rpc calls properly
[
https://issues.apache.org/jira/browse/HBASE-28312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807951#comment-17807951
]
Hudson commented on HBASE-28312:
Results for branch master
[build #987 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/987/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/987/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/987/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/987/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 3. [see log for
details|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/987//artifact/output-integration/hadoop-3.log].
(note that this means we didn't check the Hadoop 3 shaded client)
> The bad auth exception can not be passed to client rpc calls properly
> -
>
> Key: HBASE-28312
> URL: https://issues.apache.org/jira/browse/HBASE-28312
> Project: HBase
> Issue Type: Bug
> Components: Client, rpc
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 2.4.18, 2.5.8, 3.0.0-beta-2
>
>
> Found this when implementing HBASE-25051.
> Basically there are 2 problems:
> # IPCUtil.isFatalConnectionException only checks whether class name matches,
> so if we use a sub class for FatalConnectionException, it will return false
> which makes the logic incorrect.
> # In BlockingRpcConnection, we will first check whether there is a call with
> the id but since we will pass -1 as call id for bad preamble header, we will
> return earlier without actually checking the error response.
> This will not introduce big trouble in production as the call will still fail
> with connection closed exception, but still worth to fix, anyway.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-28256) Enhance ByteBufferUtils.readVLong to read more bytes at a time
[
https://issues.apache.org/jira/browse/HBASE-28256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807949#comment-17807949
]
Hudson commented on HBASE-28256:
Results for branch master
[build #987 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/987/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/987/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/987/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/987/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 3. [see log for
details|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/987//artifact/output-integration/hadoop-3.log].
(note that this means we didn't check the Hadoop 3 shaded client)
> Enhance ByteBufferUtils.readVLong to read more bytes at a time
> --
>
> Key: HBASE-28256
> URL: https://issues.apache.org/jira/browse/HBASE-28256
> Project: HBase
> Issue Type: Improvement
> Components: Performance
>Reporter: Becker Ewing
>Assignee: Becker Ewing
>Priority: Major
> Fix For: 2.6.0, 2.5.8, 3.0.0-beta-2
>
> Attachments: ReadVLongBenchmark.zip, async-prof-rs-cpu.html
>
>
> Currently, ByteBufferUtils.readVLong is used to decode rows in all data block
> encodings in order to read the memstoreTs field. For a data block encoding
> like prefix, ByteBufferUtils.readVLong can surprisingly occupy over 50% of
> the CPU time in BufferedEncodedSeeker.decodeNext (which can be quite a hot
> method in seek operations).
>
> Since memstoreTs will typically require at least 6 bytes to store, we could
> look to vectorize the read path for readVLong to read 8 bytes at a time
> instead of a single byte at a time (like in
> https://issues.apache.org/jira/browse/HBASE-28025) in order to increase
> performance.
>
> Attached is a CPU flamegraph of a region server process which shows that we
> spend a surprising amount of time in decoding rows from the DBE in
> ByteBufferUtils.readVLong.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] HBASE-28314 Enable maven-source-plugin for all modules [hbase]
Apache-HBase commented on PR #5636: URL: https://github.com/apache/hbase/pull/5636#issuecomment-1897190768 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 31s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 9s | master passed | | +1 :green_heart: | compile | 1m 48s | master passed | | +1 :green_heart: | shadedjars | 5m 25s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 4m 31s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 22s | the patch passed | | +1 :green_heart: | compile | 1m 35s | the patch passed | | +1 :green_heart: | javac | 1m 35s | the patch passed | | +1 :green_heart: | shadedjars | 5m 20s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 4m 35s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 390m 53s | root in the patch failed. | | | | 429m 30s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5636/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5636 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 77827cb14e68 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6b0ce08c82 | | Default Java | Temurin-1.8.0_352-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5636/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5636/1/testReport/ | | Max. process+thread count | 5154 (vs. ulimit of 3) | | modules | C: hbase-logging hbase-protocol-shaded hbase-metrics-api hbase-metrics hbase-hadoop-compat hbase-client hbase-replication hbase-balancer hbase-asyncfs hbase-procedure hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-external-blockcache hbase-hbtop . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5636/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28319 Expose DelegatingRpcScheduler as IA.LimitedPrivate [hbase]
Apache-HBase commented on PR #5638: URL: https://github.com/apache/hbase/pull/5638#issuecomment-1897161998 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 43s | master passed | | +1 :green_heart: | compile | 0m 43s | master passed | | +1 :green_heart: | shadedjars | 5m 4s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 25s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 27s | the patch passed | | +1 :green_heart: | compile | 0m 41s | the patch passed | | +1 :green_heart: | javac | 0m 41s | the patch passed | | +1 :green_heart: | shadedjars | 5m 2s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 236m 20s | hbase-server in the patch passed. | | | | 258m 48s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5638/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5638 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux bd87aa08b589 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6b0ce08c82 | | Default Java | Temurin-1.8.0_352-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5638/1/testReport/ | | Max. process+thread count | 5025 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5638/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28319 Expose DelegatingRpcScheduler as IA.LimitedPrivate [hbase]
Apache-HBase commented on PR #5638: URL: https://github.com/apache/hbase/pull/5638#issuecomment-1897146175 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 59s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 46s | master passed | | +1 :green_heart: | compile | 1m 1s | master passed | | +1 :green_heart: | shadedjars | 6m 44s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 41s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 58s | the patch passed | | +1 :green_heart: | compile | 0m 56s | the patch passed | | +1 :green_heart: | javac | 0m 56s | the patch passed | | +1 :green_heart: | shadedjars | 6m 22s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 25s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 225m 31s | hbase-server in the patch passed. | | | | 255m 33s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5638/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5638 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux c537b2b20770 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6b0ce08c82 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5638/1/testReport/ | | Max. process+thread count | 4698 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5638/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28314 Enable maven-source-plugin for all modules [hbase]
Apache-HBase commented on PR #5636: URL: https://github.com/apache/hbase/pull/5636#issuecomment-1896650460 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 13s | master passed | | +1 :green_heart: | compile | 2m 0s | master passed | | +1 :green_heart: | shadedjars | 5m 42s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 5m 33s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 57s | the patch passed | | +1 :green_heart: | compile | 1m 58s | the patch passed | | +1 :green_heart: | javac | 1m 58s | the patch passed | | +1 :green_heart: | shadedjars | 5m 43s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 5m 40s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 270m 26s | root in the patch passed. | | | | 311m 50s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5636/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5636 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux a0dc6aad97a9 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6b0ce08c82 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5636/1/testReport/ | | Max. process+thread count | 8046 (vs. ulimit of 3) | | modules | C: hbase-logging hbase-protocol-shaded hbase-metrics-api hbase-metrics hbase-hadoop-compat hbase-client hbase-replication hbase-balancer hbase-asyncfs hbase-procedure hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-external-blockcache hbase-hbtop . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5636/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28316 Add BootstrapNodeService handlers [hbase]
Apache-HBase commented on PR #5637: URL: https://github.com/apache/hbase/pull/5637#issuecomment-1896621039 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 35s | master passed | | +1 :green_heart: | compile | 0m 53s | master passed | | +1 :green_heart: | shadedjars | 5m 29s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 35s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 22s | the patch passed | | +1 :green_heart: | compile | 0m 54s | the patch passed | | +1 :green_heart: | javac | 0m 54s | the patch passed | | +1 :green_heart: | shadedjars | 5m 28s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 34s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 13s | hbase-client in the patch passed. | | -1 :x: | unit | 235m 3s | hbase-server in the patch failed. | | | | 259m 58s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5637/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5637 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux cffacb4fb256 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6b0ce08c82 | | Default Java | Temurin-1.8.0_352-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5637/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5637/1/testReport/ | | Max. process+thread count | 4904 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5637/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28316 Add BootstrapNodeService handlers [hbase]
Apache-HBase commented on PR #5637: URL: https://github.com/apache/hbase/pull/5637#issuecomment-1896613194 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 26s | master passed | | +1 :green_heart: | compile | 1m 38s | master passed | | +1 :green_heart: | shadedjars | 6m 42s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 48s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 19s | the patch passed | | +1 :green_heart: | compile | 1m 14s | the patch passed | | +1 :green_heart: | javac | 1m 14s | the patch passed | | +1 :green_heart: | shadedjars | 5m 50s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 36s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 223m 18s | hbase-server in the patch passed. | | | | 254m 44s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5637/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5637 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 0c4d14ca612b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6b0ce08c82 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5637/1/testReport/ | | Max. process+thread count | 4961 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5637/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Hbase 28314v2 [hbase]
Apache-HBase commented on PR #5635: URL: https://github.com/apache/hbase/pull/5635#issuecomment-1896599161 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 18s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 21s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 57s | master passed | | +1 :green_heart: | compile | 2m 20s | master passed | | +1 :green_heart: | shadedjars | 6m 13s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 8m 35s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 12s | the patch passed | | +1 :green_heart: | compile | 2m 23s | the patch passed | | +1 :green_heart: | javac | 2m 23s | the patch passed | | +1 :green_heart: | shadedjars | 6m 22s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 6m 58s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 331m 52s | root in the patch failed. | | | | 381m 35s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5635/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5635 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 655dbfae172b 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6b0ce08c82 | | Default Java | Temurin-1.8.0_352-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5635/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5635/1/testReport/ | | Max. process+thread count | 5079 (vs. ulimit of 3) | | modules | C: hbase-annotations hbase-logging hbase-protocol-shaded hbase-metrics-api hbase-metrics hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-external-blockcache hbase-hbtop hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-brotli hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5635/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-26268) Provide coprocessor hooks for updateConfiguration and clearRegionBlockCache
[ https://issues.apache.org/jira/browse/HBASE-26268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807863#comment-17807863 ] Charles Connell commented on HBASE-26268: - done! > Provide coprocessor hooks for updateConfiguration and clearRegionBlockCache > --- > > Key: HBASE-26268 > URL: https://issues.apache.org/jira/browse/HBASE-26268 > Project: HBase > Issue Type: Bug >Reporter: Bryan Beaudreault >Assignee: Charles Connell >Priority: Major > Fix For: 2.6.0, 4.0.0-alpha-1, 3.0.0-beta-2 > > > Sorry for the vague title, not sure if it'd be better to create individual > jiras. I discovered that the following two AdminService endpoints are not > covered by AccessController: > > * updateConfiguration > * clearRegionBlockCache > There may be others, I haven't done a full audit. We should add coprocessor > hooks for these and wrap with AccessController, especially since they can > both have an affect on the cluster. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-26268) Provide coprocessor hooks for updateConfiguration and clearRegionBlockCache
[ https://issues.apache.org/jira/browse/HBASE-26268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Charles Connell updated HBASE-26268: Release Note: - Added methods preUpdateMasterConfiguration and postUpdateMasterConfiguration to MasterObserver to allow coprocessors to hook into configuration reloads in HMasters. Runs when reload is triggered by RPC or by SIGHUP. - Added methods preUpdateRegionServerConfiguration and postUpdateRegionServerConfiguration to RegionServerObserver to do the same in RegionServers. - Added methods preClearRegionBlockCache and postClearRegionBlockCache to RegionServerObserver to allow coprocessors to hook into block cache clearing. > Provide coprocessor hooks for updateConfiguration and clearRegionBlockCache > --- > > Key: HBASE-26268 > URL: https://issues.apache.org/jira/browse/HBASE-26268 > Project: HBase > Issue Type: Bug >Reporter: Bryan Beaudreault >Assignee: Charles Connell >Priority: Major > Fix For: 2.6.0, 4.0.0-alpha-1, 3.0.0-beta-2 > > > Sorry for the vague title, not sure if it'd be better to create individual > jiras. I discovered that the following two AdminService endpoints are not > covered by AccessController: > > * updateConfiguration > * clearRegionBlockCache > There may be others, I haven't done a full audit. We should add coprocessor > hooks for these and wrap with AccessController, especially since they can > both have an affect on the cluster. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-28319 Expose DelegatingRpcScheduler as IA.LimitedPrivate [hbase]
Apache-HBase commented on PR #5638: URL: https://github.com/apache/hbase/pull/5638#issuecomment-1896442164 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 50s | master passed | | +1 :green_heart: | compile | 3m 8s | master passed | | +1 :green_heart: | checkstyle | 0m 42s | master passed | | +1 :green_heart: | spotless | 0m 51s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 51s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 58s | the patch passed | | +1 :green_heart: | compile | 3m 9s | the patch passed | | +1 :green_heart: | javac | 3m 9s | the patch passed | | +1 :green_heart: | checkstyle | 0m 45s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 6m 14s | Patch does not cause any errors with Hadoop 3.3.6. | | +1 :green_heart: | spotless | 1m 17s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 48s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 20s | The patch does not generate ASF License warnings. | | | | 40m 34s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5638/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5638 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 80b15c8cc03e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6b0ce08c82 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 79 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5638/1/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Hbase 28314v2 [hbase]
Apache-HBase commented on PR #5635: URL: https://github.com/apache/hbase/pull/5635#issuecomment-1896411838 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 17s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 55s | master passed | | +1 :green_heart: | compile | 1m 58s | master passed | | +1 :green_heart: | shadedjars | 5m 5s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 8m 12s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 48s | the patch passed | | +1 :green_heart: | compile | 1m 59s | the patch passed | | +1 :green_heart: | javac | 1m 59s | the patch passed | | +1 :green_heart: | shadedjars | 5m 9s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 8m 14s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 247m 39s | root in the patch failed. | | | | 294m 38s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5635/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5635 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 8bbc28e21569 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6b0ce08c82 | | Default Java | Eclipse Adoptium-11.0.17+8 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5635/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5635/1/testReport/ | | Max. process+thread count | 5818 (vs. ulimit of 3) | | modules | C: hbase-annotations hbase-logging hbase-protocol-shaded hbase-metrics-api hbase-metrics hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-external-blockcache hbase-hbtop hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-brotli hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5635/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28311 Few ITs (using MiniMRYarnCluster on hadoop-2) are failing… [hbase]
Apache-HBase commented on PR #5625: URL: https://github.com/apache/hbase/pull/5625#issuecomment-1896381356 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 20s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 54s | branch-2 passed | | +1 :green_heart: | compile | 0m 38s | branch-2 passed | | +1 :green_heart: | shadedjars | 7m 39s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 18s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 22s | the patch passed | | +1 :green_heart: | compile | 0m 34s | the patch passed | | +1 :green_heart: | javac | 0m 34s | the patch passed | | +1 :green_heart: | shadedjars | 8m 28s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 21s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 27s | hbase-it in the patch passed. | | | | 28m 56s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5625/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5625 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 70508827dde7 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 6721863af1 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5625/2/testReport/ | | Max. process+thread count | 869 (vs. ulimit of 3) | | modules | C: hbase-it U: hbase-it | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5625/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28311 Few ITs (using MiniMRYarnCluster on hadoop-2) are failing… [hbase]
Apache-HBase commented on PR #5625: URL: https://github.com/apache/hbase/pull/5625#issuecomment-1896359262 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 48s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 5s | branch-2 passed | | +1 :green_heart: | compile | 0m 21s | branch-2 passed | | +1 :green_heart: | shadedjars | 6m 8s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 11s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 29s | the patch passed | | +1 :green_heart: | compile | 0m 15s | the patch passed | | +1 :green_heart: | javac | 0m 15s | the patch passed | | +1 :green_heart: | shadedjars | 5m 28s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 13s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 56s | hbase-it in the patch passed. | | | | 20m 51s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5625/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5625 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 3c70cf588fdb 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 6721863af1 | | Default Java | Temurin-1.8.0_352-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5625/2/testReport/ | | Max. process+thread count | 807 (vs. ulimit of 3) | | modules | C: hbase-it U: hbase-it | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5625/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28311 Few ITs (using MiniMRYarnCluster on hadoop-2) are failing… [hbase]
NihalJain commented on PR #5625: URL: https://github.com/apache/hbase/pull/5625#issuecomment-1896357054 Ran test `IntegrationTestImportTsv` locally again with hadoop 2 (default profile): PASS ``` mvn clean install -DskipTests mvn --no-snapshot-updates -Dtest=IntegrationTestImportTsv -pl hbase-it package ``` Output: ``` [INFO] --- [INFO] T E S T S [INFO] --- [INFO] Running org.apache.hadoop.hbase.mapreduce.IntegrationTestImportTsv [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 56.643 s - in org.apache.hadoop.hbase.mapreduce.IntegrationTestImportTsv [INFO] [INFO] Results: [INFO] [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 ``` Ran test `IntegrationTestImportTsv` locally again with hadoop 3: PASS ``` mvn clean install -DskipTests -Dhadoop.profile=3.0 mvn --no-snapshot-updates -Dtest=IntegrationTestImportTsv -pl hbase-it package -Dhadoop.profile=3.0 ``` Output: ``` [INFO] --- [INFO] T E S T S [INFO] --- [INFO] Running org.apache.hadoop.hbase.mapreduce.IntegrationTestImportTsv [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 82.893 s - in org.apache.hadoop.hbase.mapreduce.IntegrationTestImportTsv [INFO] [INFO] Results: [INFO] [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28184 Addendum PR [hbase]
shahrs87 commented on code in PR #5521:
URL: https://github.com/apache/hbase/pull/5521#discussion_r1456240779
##
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java:
##
@@ -259,10 +259,11 @@ private boolean readNextEntryAndRecordReaderPosition()
throws IOException {
Entry readEntry = reader.next();
long readerPos = reader.getPosition();
OptionalLong fileLength;
-if (logQueue.getQueueSize(walGroupId) > 1) {
+if (logQueue.getQueueSize(walGroupId) > 2) {
Review Comment:
> Any updates here?
@Apache9 Sorry couldn't update this thread in a long time. Got distracted
somewhere and it fell off my radar.
> Changing to greater than 2 can fix the failing tests? A bit strange, could
you please exlain more on this?
Actually changing to greater than 2 fixes the failing test but looks like it
is not the right fix.
The test is doing the following:
1. Creating WAL named wal1
2. Appending some entries to wal1
3. Calling entryStream.next to read from wal1
4. Roll the WAL to wal2
5. Append some entries to wal2
6. Call entryStream.next to read from wal2
7. Test that there are NO uncleanlyClosedLogs metric.
The test is failing at #6 above. When it is calling entryStream.next on
wal2, the replication code needs to switch the reader to the new WAL file.
During rollWriter, we add it to `AbstractFSWAL#inflightWALClosures` map and
close the old WAL file asynchronously
[here](https://github.com/apache/hbase/blob/branch-2.5/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java#L396-L407).
In closeWriter method, we append the trailer to the WAL and then close it.
During the closeWriter execution there will be 2 WALs in the logQueue.
Now in WALEntryStream#next method, after [this
change](https://github.com/apache/hbase/pull/5505/files), we don't read the
file length if logQueue size is greater than 1 and hence WALEntryStream is
unaware of the trailer bytes and while switching the wal from wal1 to wal2, it
gets the following exception:
```
2024-01-17T10:05:47,247 DEBUG [Listener at localhost/52964]
wal.ProtobufLogReader(447): Encountered a malformed edit, seeking back to last
good position in file, from 218 to 210
java.io.EOFException: Invalid PB, EOF? Ignoring; originalPosition=210,
currentPosition=218
at
org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader.readNext(ProtobufLogReader.java:376)
~[classes/:?]
at
org.apache.hadoop.hbase.regionserver.wal.ReaderBase.next(ReaderBase.java:104)
~[classes/:?]
at
org.apache.hadoop.hbase.regionserver.wal.ReaderBase.next(ReaderBase.java:92)
~[classes/:?]
at
org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.readNextEntryAndRecordReaderPosition(WALEntryStream.java:259)
~[classes/:?]
at
org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.tryAdvanceEntry(WALEntryStream.java:181)
~[classes/:?]
at
org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.hasNext(WALEntryStream.java:102)
~[classes/:?]
at
org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.peek(WALEntryStream.java:111)
~[classes/:?]
at
org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.next(WALEntryStream.java:118)
~[classes/:?]
at
org.apache.hadoop.hbase.replication.regionserver.WALEntryStreamTestBase$WALEntryStreamWithRetries.access$001(WALEntryStreamTestBase.java:82)
~[test-classes/:?]
at
org.apache.hadoop.hbase.replication.regionserver.WALEntryStreamTestBase$WALEntryStreamWithRetries.lambda$next$0(WALEntryStreamTestBase.java:95)
~[test-classes/:?]
at org.apache.hadoop.hbase.Waiter.waitFor(Waiter.java:184)
~[test-classes/:?]
at org.apache.hadoop.hbase.Waiter.waitFor(Waiter.java:135)
~[test-classes/:?]
at
org.apache.hadoop.hbase.replication.regionserver.WALEntryStreamTestBase$WALEntryStreamWithRetries.next(WALEntryStreamTestBase.java:94)
~[test-classes/:?]
at
org.apache.hadoop.hbase.replication.regionserver.TestBasicWALEntryStream.testCleanClosedWALs(TestBasicWALEntryStream.java:726)
~[test-classes/:?]
```
I think I know how to fix.
From [PR-5505](https://github.com/apache/hbase/pull/5505/files), we have the
below check
```
OptionalLong fileLength;
if (logQueue.getQueueSize(walGroupId) > 1) {
fileLength = OptionalLong.empty();
} else {
// if there is only one file in queue, check whether it is still being
written to
fileLength =
walFileLengthProvider.getLogFileSizeIfBeingWritten(currentPath);
}
```
Along with checking queue size, we also have to check if the currently
replicated WAL is not in AbstractFSWAL#inflightWALClosures map then it is safe
to not read the file size.
But currently there is NO way to access AbstractFSWAL object from
Re: [PR] HBASE-28311 Few ITs (using MiniMRYarnCluster on hadoop-2) are failing… [hbase]
Apache-HBase commented on PR #5625: URL: https://github.com/apache/hbase/pull/5625#issuecomment-1896354084 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 2s | branch-2 passed | | +1 :green_heart: | compile | 0m 30s | branch-2 passed | | -1 :x: | spotless | 0m 45s | branch has 1 errors when running spotless:check, run spotless:apply to fix. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 45s | the patch passed | | +1 :green_heart: | compile | 0m 30s | the patch passed | | +1 :green_heart: | javac | 0m 30s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 9m 7s | Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6. | | +1 :green_heart: | spotless | 0m 42s | patch has no errors when running spotless:check. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 12s | The patch does not generate ASF License warnings. | | | | 19m 18s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5625/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5625 | | Optional Tests | dupname asflicense javac hadoopcheck spotless xml compile | | uname | Linux 4238590fddfa 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / 6721863af1 | | Default Java | Eclipse Adoptium-11.0.17+8 | | spotless | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5625/2/artifact/yetus-general-check/output/branch-spotless.txt | | Max. process+thread count | 79 (vs. ulimit of 3) | | modules | C: hbase-it U: hbase-it | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5625/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28184 Addendum PR [hbase]
shahrs87 commented on code in PR #5521:
URL: https://github.com/apache/hbase/pull/5521#discussion_r1456240779
##
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java:
##
@@ -259,10 +259,11 @@ private boolean readNextEntryAndRecordReaderPosition()
throws IOException {
Entry readEntry = reader.next();
long readerPos = reader.getPosition();
OptionalLong fileLength;
-if (logQueue.getQueueSize(walGroupId) > 1) {
+if (logQueue.getQueueSize(walGroupId) > 2) {
Review Comment:
> Any updates here?
@Apache9 Sorry couldn't update this thread in a long time. Got distracted
somewhere and it fell off my radar.
> Changing to greater than 2 can fix the failing tests? A bit strange, could
you please exlain more on this?
Actually changing to greater than 2 fixes the failing test but looks like it
is not the right fix.
The test is doing the following:
1. Creating WAL named wal1
2. Appending some entries to wal1
3. Calling entryStream.next to read from wal1
4. Roll the WAL to wal2
5. Append some entries to wal2
6. Call entryStream.next to read from wal2
7. Test that there are NO uncleanlyClosedLogs metric.
The test is failing at #6 above. When it is calling entryStream.next on
wal2, the replication code needs to switch the reader to the new WAL file.
During rollWriter, we add it to `AbstractFSWAL#inflightWALClosures` map and
close the old WAL file asynchronously
[here](https://github.com/apache/hbase/blob/branch-2.5/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java#L396-L407).
In closeWriter method, we append the trailer to the WAL and then close it.
During the closeWriter execution there will be 2 WALs in the logQueue.
Now in WALEntryStream#next method, after [this
change](https://github.com/apache/hbase/pull/5505/files), we don't read the
file length if logQueue size is greater than 1 and hence WALEntryStream is
unaware of the trailer bytes and while switching the wal from wal1 to wal2, it
gets the following exception:
```
2024-01-17T10:05:47,247 DEBUG [Listener at localhost/52964]
wal.ProtobufLogReader(447): Encountered a malformed edit, seeking back to last
good position in file, from 218 to 210
java.io.EOFException: Invalid PB, EOF? Ignoring; originalPosition=210,
currentPosition=218
at
org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader.readNext(ProtobufLogReader.java:376)
~[classes/:?]
at
org.apache.hadoop.hbase.regionserver.wal.ReaderBase.next(ReaderBase.java:104)
~[classes/:?]
at
org.apache.hadoop.hbase.regionserver.wal.ReaderBase.next(ReaderBase.java:92)
~[classes/:?]
at
org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.readNextEntryAndRecordReaderPosition(WALEntryStream.java:259)
~[classes/:?]
at
org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.tryAdvanceEntry(WALEntryStream.java:181)
~[classes/:?]
at
org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.hasNext(WALEntryStream.java:102)
~[classes/:?]
at
org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.peek(WALEntryStream.java:111)
~[classes/:?]
at
org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.next(WALEntryStream.java:118)
~[classes/:?]
at
org.apache.hadoop.hbase.replication.regionserver.WALEntryStreamTestBase$WALEntryStreamWithRetries.access$001(WALEntryStreamTestBase.java:82)
~[test-classes/:?]
at
org.apache.hadoop.hbase.replication.regionserver.WALEntryStreamTestBase$WALEntryStreamWithRetries.lambda$next$0(WALEntryStreamTestBase.java:95)
~[test-classes/:?]
at org.apache.hadoop.hbase.Waiter.waitFor(Waiter.java:184)
~[test-classes/:?]
at org.apache.hadoop.hbase.Waiter.waitFor(Waiter.java:135)
~[test-classes/:?]
at
org.apache.hadoop.hbase.replication.regionserver.WALEntryStreamTestBase$WALEntryStreamWithRetries.next(WALEntryStreamTestBase.java:94)
~[test-classes/:?]
at
org.apache.hadoop.hbase.replication.regionserver.TestBasicWALEntryStream.testCleanClosedWALs(TestBasicWALEntryStream.java:726)
~[test-classes/:?]
```
I think I know how to fix.
From [PR-5505](https://github.com/apache/hbase/pull/5505/files), we have the
below check
```
OptionalLong fileLength;
if (logQueue.getQueueSize(walGroupId) > 1) {
fileLength = OptionalLong.empty();
} else {
// if there is only one file in queue, check whether it is still being
written to
fileLength =
walFileLengthProvider.getLogFileSizeIfBeingWritten(currentPath);
}
```
Along with checking queue size, we also have to check if the currently
replicated WAL is not in AbstractFSWAL#inflightWALClosures map then it is safe
to not read the file size.
But currently there is NO way to access AbstractFSWAL object from
[jira] [Updated] (HBASE-28319) Expose DelegatingRpcScheduler as IA.LimitedPrivate
[ https://issues.apache.org/jira/browse/HBASE-28319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault updated HBASE-28319: -- Labels: patch-available (was: ) Status: Patch Available (was: Open) > Expose DelegatingRpcScheduler as IA.LimitedPrivate > -- > > Key: HBASE-28319 > URL: https://issues.apache.org/jira/browse/HBASE-28319 > Project: HBase > Issue Type: Improvement >Reporter: Bryan Beaudreault >Assignee: Bryan Beaudreault >Priority: Major > Labels: patch-available > Fix For: 2.5.8, 3.0.0-beta-2 > > > We have DelegatingRpcScheduler in src/test of hbase-server. RpcScheduler > itself is IA.LimitedPrivate, and in 2.6.0 we are pushing an incompatible > change from HBASE-27144. > We can limit the impact of breaking changes like this by exposing > DelegatingRpcScheduler to users. Users can extend this class and only > override the pieces that they care about, thus reducing the surface area of > compatibility issues. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-28319 Expose DelegatingRpcScheduler as IA.LimitedPrivate [hbase]
bbeaudreault commented on code in PR #5638:
URL: https://github.com/apache/hbase/pull/5638#discussion_r1456206928
##
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/DelegatingRpcScheduler.java:
##
@@ -17,6 +17,17 @@
*/
package org.apache.hadoop.hbase.ipc;
+import org.apache.hadoop.hbase.HBaseInterfaceAudience;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.apache.yetus.audience.InterfaceStability;
+
+/**
+ * Users of the hbase.region.server.rpc.scheduler.factory.class customization
config can return an
+ * implementation which extends this class in order to minimize impact of
breaking interface
+ * changes.
+ */
+@InterfaceAudience.LimitedPrivate({ HBaseInterfaceAudience.COPROC,
HBaseInterfaceAudience.PHOENIX })
Review Comment:
These audiences are pulled from RpcScheduler's IA annotation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Resolved] (HBASE-28320) Expose DelegatingRpcScheduler as IA.LimitedPrivate
[ https://issues.apache.org/jira/browse/HBASE-28320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault resolved HBASE-28320. --- Resolution: Duplicate > Expose DelegatingRpcScheduler as IA.LimitedPrivate > -- > > Key: HBASE-28320 > URL: https://issues.apache.org/jira/browse/HBASE-28320 > Project: HBase > Issue Type: Improvement >Reporter: Bryan Beaudreault >Assignee: Bryan Beaudreault >Priority: Major > > We have DelegatingRpcScheduler in src/test of hbase-server. RpcScheduler > itself is IA.LimitedPrivate, and in 2.6.0 we are pushing an incompatible > change from HBASE-27144. > We can limit the impact of breaking changes like this by exposing > DelegatingRpcScheduler to users. Users can extend this class and only > override the pieces that they care about, thus reducing the surface area of > compatibility issues. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-28318) Expose DelegatingRpcScheduler as IA.LimitedPrivate
[ https://issues.apache.org/jira/browse/HBASE-28318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault updated HBASE-28318: -- Fix Version/s: (was: 2.5.8) (was: 3.0.0-beta-2) > Expose DelegatingRpcScheduler as IA.LimitedPrivate > -- > > Key: HBASE-28318 > URL: https://issues.apache.org/jira/browse/HBASE-28318 > Project: HBase > Issue Type: Improvement >Reporter: Bryan Beaudreault >Assignee: Bryan Beaudreault >Priority: Major > > We have DelegatingRpcScheduler in src/test of hbase-server. RpcScheduler > itself is IA.LimitedPrivate, and in 2.6.0 we are pushing an incompatible > change from HBASE-27144. > We can limit the impact of breaking changes like this by exposing > DelegatingRpcScheduler to users. Users can extend this class and only > override the pieces that they care about, thus reducing the surface area of > compatibility issues. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (HBASE-28318) Expose DelegatingRpcScheduler as IA.LimitedPrivate
[ https://issues.apache.org/jira/browse/HBASE-28318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault resolved HBASE-28318. --- Resolution: Duplicate > Expose DelegatingRpcScheduler as IA.LimitedPrivate > -- > > Key: HBASE-28318 > URL: https://issues.apache.org/jira/browse/HBASE-28318 > Project: HBase > Issue Type: Improvement >Reporter: Bryan Beaudreault >Assignee: Bryan Beaudreault >Priority: Major > > We have DelegatingRpcScheduler in src/test of hbase-server. RpcScheduler > itself is IA.LimitedPrivate, and in 2.6.0 we are pushing an incompatible > change from HBASE-27144. > We can limit the impact of breaking changes like this by exposing > DelegatingRpcScheduler to users. Users can extend this class and only > override the pieces that they care about, thus reducing the surface area of > compatibility issues. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HBASE-28320) Expose DelegatingRpcScheduler as IA.LimitedPrivate
[ https://issues.apache.org/jira/browse/HBASE-28320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault updated HBASE-28320: -- Fix Version/s: (was: 2.5.8) (was: 3.0.0-beta-2) > Expose DelegatingRpcScheduler as IA.LimitedPrivate > -- > > Key: HBASE-28320 > URL: https://issues.apache.org/jira/browse/HBASE-28320 > Project: HBase > Issue Type: Improvement >Reporter: Bryan Beaudreault >Assignee: Bryan Beaudreault >Priority: Major > > We have DelegatingRpcScheduler in src/test of hbase-server. RpcScheduler > itself is IA.LimitedPrivate, and in 2.6.0 we are pushing an incompatible > change from HBASE-27144. > We can limit the impact of breaking changes like this by exposing > DelegatingRpcScheduler to users. Users can extend this class and only > override the pieces that they care about, thus reducing the surface area of > compatibility issues. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] (HBASE-25402) HBase UI: sorting order by start key or end key is not considering empty start key/end key
[ https://issues.apache.org/jira/browse/HBASE-25402 ] Nihal Jain deleted comment on HBASE-25402: was (Author: nihaljain.cs): You may want to have a look at HBASE-14249 > HBase UI: sorting order by start key or end key is not considering empty > start key/end key > -- > > Key: HBASE-25402 > URL: https://issues.apache.org/jira/browse/HBASE-25402 > Project: HBase > Issue Type: Bug > Components: UI >Affects Versions: 2.2.3 >Reporter: Ajeet Rai >Assignee: Akshay Sudheer >Priority: Minor > Fix For: 3.0.0-alpha-1 > > Attachments: HBASE-25402 Fix.png, HBASE-25402 Issue.png > > > HBase UI: sorting order by start key or end key is not considering empty > start key/end key. > Steps: > 1: Open any table page having multiple regions > 2: click on sort button of start key/end key > 3: Observed that sorting doesn't consider start and end key. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-28314) Enable maven-source-plugin for all modules
[ https://issues.apache.org/jira/browse/HBASE-28314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807826#comment-17807826 ] Nihal Jain commented on HBASE-28314: You may want to have a look at HBASE-14249. Just recalled seeing HBASE-14249, so shared here. > Enable maven-source-plugin for all modules > -- > > Key: HBASE-28314 > URL: https://issues.apache.org/jira/browse/HBASE-28314 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 2.6.0, 2.4.17, 3.0.0-beta-1, 4.0.0-alpha-1, 2.5.7 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > > There is no source jar generated for hbase-server. > Enabling maven-source-plugin seems to work fine, and Eclipse can use the > generated sources jar for debugging etc. > It seems that these source JARs are not generated at least since HBase 2.0.0, > but we did have source JARs sometime in the 1.x time frame. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] (HBASE-25402) HBase UI: sorting order by start key or end key is not considering empty start key/end key
[ https://issues.apache.org/jira/browse/HBASE-25402 ] Nihal Jain deleted comment on HBASE-25402: was (Author: nihaljain.cs): Just recalled seeing HBASE-14249, so shared here. > HBase UI: sorting order by start key or end key is not considering empty > start key/end key > -- > > Key: HBASE-25402 > URL: https://issues.apache.org/jira/browse/HBASE-25402 > Project: HBase > Issue Type: Bug > Components: UI >Affects Versions: 2.2.3 >Reporter: Ajeet Rai >Assignee: Akshay Sudheer >Priority: Minor > Fix For: 3.0.0-alpha-1 > > Attachments: HBASE-25402 Fix.png, HBASE-25402 Issue.png > > > HBase UI: sorting order by start key or end key is not considering empty > start key/end key. > Steps: > 1: Open any table page having multiple regions > 2: click on sort button of start key/end key > 3: Observed that sorting doesn't consider start and end key. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-25402) HBase UI: sorting order by start key or end key is not considering empty start key/end key
[ https://issues.apache.org/jira/browse/HBASE-25402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807825#comment-17807825 ] Nihal Jain commented on HBASE-25402: Just recalled seeing HBASE-14249, so shared here. > HBase UI: sorting order by start key or end key is not considering empty > start key/end key > -- > > Key: HBASE-25402 > URL: https://issues.apache.org/jira/browse/HBASE-25402 > Project: HBase > Issue Type: Bug > Components: UI >Affects Versions: 2.2.3 >Reporter: Ajeet Rai >Assignee: Akshay Sudheer >Priority: Minor > Fix For: 3.0.0-alpha-1 > > Attachments: HBASE-25402 Fix.png, HBASE-25402 Issue.png > > > HBase UI: sorting order by start key or end key is not considering empty > start key/end key. > Steps: > 1: Open any table page having multiple regions > 2: click on sort button of start key/end key > 3: Observed that sorting doesn't consider start and end key. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-25402) HBase UI: sorting order by start key or end key is not considering empty start key/end key
[ https://issues.apache.org/jira/browse/HBASE-25402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807824#comment-17807824 ] Nihal Jain commented on HBASE-25402: You may want to have a look at HBASE-14249 > HBase UI: sorting order by start key or end key is not considering empty > start key/end key > -- > > Key: HBASE-25402 > URL: https://issues.apache.org/jira/browse/HBASE-25402 > Project: HBase > Issue Type: Bug > Components: UI >Affects Versions: 2.2.3 >Reporter: Ajeet Rai >Assignee: Akshay Sudheer >Priority: Minor > Fix For: 3.0.0-alpha-1 > > Attachments: HBASE-25402 Fix.png, HBASE-25402 Issue.png > > > HBase UI: sorting order by start key or end key is not considering empty > start key/end key. > Steps: > 1: Open any table page having multiple regions > 2: click on sort button of start key/end key > 3: Observed that sorting doesn't consider start and end key. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (HBASE-28318) Expose DelegatingRpcScheduler as IA.LimitedPrivate
Bryan Beaudreault created HBASE-28318: - Summary: Expose DelegatingRpcScheduler as IA.LimitedPrivate Key: HBASE-28318 URL: https://issues.apache.org/jira/browse/HBASE-28318 Project: HBase Issue Type: Improvement Reporter: Bryan Beaudreault Assignee: Bryan Beaudreault Fix For: 2.5.8, 3.0.0-beta-2 We have DelegatingRpcScheduler in src/test of hbase-server. RpcScheduler itself is IA.LimitedPrivate, and in 2.6.0 we are pushing an incompatible change from HBASE-27144. We can limit the impact of breaking changes like this by exposing DelegatingRpcScheduler to users. Users can extend this class and only override the pieces that they care about, thus reducing the surface area of compatibility issues. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (HBASE-28320) Expose DelegatingRpcScheduler as IA.LimitedPrivate
Bryan Beaudreault created HBASE-28320: - Summary: Expose DelegatingRpcScheduler as IA.LimitedPrivate Key: HBASE-28320 URL: https://issues.apache.org/jira/browse/HBASE-28320 Project: HBase Issue Type: Improvement Reporter: Bryan Beaudreault Assignee: Bryan Beaudreault Fix For: 2.5.8, 3.0.0-beta-2 We have DelegatingRpcScheduler in src/test of hbase-server. RpcScheduler itself is IA.LimitedPrivate, and in 2.6.0 we are pushing an incompatible change from HBASE-27144. We can limit the impact of breaking changes like this by exposing DelegatingRpcScheduler to users. Users can extend this class and only override the pieces that they care about, thus reducing the surface area of compatibility issues. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (HBASE-28319) Expose DelegatingRpcScheduler as IA.LimitedPrivate
Bryan Beaudreault created HBASE-28319: - Summary: Expose DelegatingRpcScheduler as IA.LimitedPrivate Key: HBASE-28319 URL: https://issues.apache.org/jira/browse/HBASE-28319 Project: HBase Issue Type: Improvement Reporter: Bryan Beaudreault Assignee: Bryan Beaudreault Fix For: 2.5.8, 3.0.0-beta-2 We have DelegatingRpcScheduler in src/test of hbase-server. RpcScheduler itself is IA.LimitedPrivate, and in 2.6.0 we are pushing an incompatible change from HBASE-27144. We can limit the impact of breaking changes like this by exposing DelegatingRpcScheduler to users. Users can extend this class and only override the pieces that they care about, thus reducing the surface area of compatibility issues. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-28271 Infinite waiting on lock acquisition by snapshot can result in unresponsive master [hbase]
Apache-HBase commented on PR #5603: URL: https://github.com/apache/hbase/pull/5603#issuecomment-1896264869 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 28s | master passed | | +1 :green_heart: | compile | 1m 3s | master passed | | +1 :green_heart: | shadedjars | 7m 15s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 34s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 42s | the patch passed | | +1 :green_heart: | compile | 0m 59s | the patch passed | | +1 :green_heart: | javac | 0m 58s | the patch passed | | +1 :green_heart: | shadedjars | 6m 42s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 32s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 285m 23s | hbase-server in the patch failed. | | | | 314m 23s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5603/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5603 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 25ae14bf6f00 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6b0ce08c82 | | Default Java | Temurin-1.8.0_352-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5603/6/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5603/6/testReport/ | | Max. process+thread count | 4422 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5603/6/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-28317) RpcCallContext should expose client's TLS certificate
[
https://issues.apache.org/jira/browse/HBASE-28317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807808#comment-17807808
]
Bryan Beaudreault commented on HBASE-28317:
---
This sounds ok, but one comment for your consideration – I know you plan to
inspect the certificate in the coprocessor. That might involve string
manipulation/comparisons (cert parsing, username comparisons, etc) and math
(for ip subnet checking). Since a certificate is tied to a connection and can't
change for the lifetime of the connection, it will be far preferable to do this
once per connection instead of for every request. A single client can send
many requests/sec, and a RegionServer in aggregate will serve thousands of
req/s or more. Doing this work on-connection instead of on-request would save a
lot of cpu time. Given that TLS is a new native feature of hbase, I think we
should consider this as a configurable auth plugin of some sort rather than
just expose it on RpcCallContext.
One good way to do that might be to add a pluggable interface for validating
the certificate. We currently have HBaseTrustManager which delegates to the
built-in X509ExtendedTrustManager and adds hostname verification via
HBaseHostnameVerifier. We could add something pluggable in there for inspecting
other fields. One problem with that approach is I'm not sure how we'd project
the resulting "auth info" on to the NettyServerRpcConnection for usage
elsewhere.
Another option is something I experimented with in a super old POC I did for
HBASE-27326:
[https://github.com/HubSpot/hbase/commit/17d2db2f8a8fabcda9e36ecea826374f798c67f5#diff-3af1e2a33ec4dc8117718cddc9eafe8f99843e275cec7d0aada0995bbf2d9effR37.]
This registers a listener to the SSL HandshakeFuture which allows us to fail
the handshake if a specific CN field doesn't exist. In the impl of the linked
class there, I have a comment about another approach we could take for
injecting AuthInfo onto the Connection, which is probably the better idea. I'm
imagining we have a pluggable interface (like other configuration-pluggable
interfaces, i.e. RpcScheduler, etc.) which would get called there and users can
return some sort of AuthInfo class or throw an auth exception. We could expose
the AuthInfo object on RpcCallContext and inspect that in our coprocessor. For
HubSpot's use-case we'd do something like the below, but this is flexible
enough for many use-cases:
{code:java}
if (context.getAuthInfo() instanceof HubSpotAuthInfo &&
!((HubSpotAuthInfo)context.getAuthInfo()).isTrusted()) {
AUDIT_LOG.log(request)
}{code}
A 3rd and final option I'd offer is if we can look into adding a preConnection
and postConnection coprocessor hook. I think this would be tricky (but not
impossible) to wire up because of how the RpcServer stuff is a step removed
from the HRegionServer/HMaster stuff. The way to access it might be through the
rpcServer.server field in NettyServerRpcConnection, which should be an
instanceof HMaster or HRegionServer.
> RpcCallContext should expose client's TLS certificate
> -
>
> Key: HBASE-28317
> URL: https://issues.apache.org/jira/browse/HBASE-28317
> Project: HBase
> Issue Type: Improvement
>Reporter: Charles Connell
>Assignee: Charles Connell
>Priority: Minor
>
> At my employer we plan on using a coprocessor to log information about some
> requests to HBase. For this to be useful to us, we need to know who each
> request is coming from. We use HBase's TLS support with mutual authentication
> to authenticate clients. I'd like a way to expose the client certificate used
> on a request to coprocessors. For setups using Kerberos authentication,
> RpcCall exposes the Kerberos principal shortname via {{getRequestUser()}}, so
> this would be the TLS equivalent to that.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] HBASE-28316 Add BootstrapNodeService handlers [hbase]
Apache-HBase commented on PR #5637: URL: https://github.com/apache/hbase/pull/5637#issuecomment-1896195428 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 16s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 37s | master passed | | +1 :green_heart: | compile | 4m 41s | master passed | | +1 :green_heart: | checkstyle | 1m 23s | master passed | | +1 :green_heart: | spotless | 1m 7s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 3m 28s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 29s | the patch passed | | +1 :green_heart: | compile | 4m 45s | the patch passed | | +1 :green_heart: | javac | 4m 45s | the patch passed | | -0 :warning: | checkstyle | 0m 51s | hbase-server: The patch generated 2 new + 10 unchanged - 0 fixed = 12 total (was 10) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 7m 24s | Patch does not cause any errors with Hadoop 3.3.6. | | +1 :green_heart: | spotless | 1m 3s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 4m 1s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 23s | The patch does not generate ASF License warnings. | | | | 48m 6s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5637/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5637 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 78029dce7c7b 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6b0ce08c82 | | Default Java | Eclipse Adoptium-11.0.17+8 | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5637/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 79 (vs. ulimit of 3) | | modules | C: hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5637/1/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28314 Generate source artifacts from mvn install for every module containing sources [hbase]
Apache-HBase commented on PR #5630: URL: https://github.com/apache/hbase/pull/5630#issuecomment-1896154761 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 42s | master passed | | +1 :green_heart: | compile | 2m 22s | master passed | | +1 :green_heart: | shadedjars | 5m 38s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 47s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 24s | the patch passed | | +1 :green_heart: | compile | 2m 27s | the patch passed | | +1 :green_heart: | javac | 2m 27s | the patch passed | | +1 :green_heart: | shadedjars | 5m 29s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 47s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 8s | hbase-annotations in the patch passed. | | +1 :green_heart: | unit | 0m 36s | hbase-zookeeper in the patch passed. | | +1 :green_heart: | unit | 236m 2s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 2m 45s | hbase-testing-util in the patch passed. | | +1 :green_heart: | unit | 1m 14s | hbase-compression-aircompressor in the patch passed. | | +1 :green_heart: | unit | 0m 50s | hbase-compression-brotli in the patch passed. | | +1 :green_heart: | unit | 0m 41s | hbase-compression-lz4 in the patch passed. | | +1 :green_heart: | unit | 0m 44s | hbase-compression-snappy in the patch passed. | | +1 :green_heart: | unit | 1m 27s | hbase-compression-xz in the patch passed. | | +1 :green_heart: | unit | 6m 54s | hbase-compression-zstd in the patch passed. | | | | 282m 5s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5630/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5630 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 30cbfe6fb29f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6b0ce08c82 | | Default Java | Temurin-1.8.0_352-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5630/3/testReport/ | | Max. process+thread count | 5424 (vs. ulimit of 3) | | modules | C: hbase-annotations hbase-zookeeper hbase-server hbase-testing-util hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-brotli hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5630/3/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28314 Generate source artifacts from mvn install for every module containing sources [hbase]
Apache-HBase commented on PR #5630: URL: https://github.com/apache/hbase/pull/5630#issuecomment-1896153277 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 47s | master passed | | +1 :green_heart: | compile | 3m 22s | master passed | | +1 :green_heart: | shadedjars | 5m 9s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 31s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 49s | the patch passed | | +1 :green_heart: | compile | 3m 21s | the patch passed | | +1 :green_heart: | javac | 3m 21s | the patch passed | | +1 :green_heart: | shadedjars | 5m 15s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 29s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 10s | hbase-annotations in the patch passed. | | +1 :green_heart: | unit | 0m 40s | hbase-zookeeper in the patch passed. | | -1 :x: | unit | 231m 23s | hbase-server in the patch failed. | | +1 :green_heart: | unit | 2m 16s | hbase-testing-util in the patch passed. | | +1 :green_heart: | unit | 0m 48s | hbase-it in the patch passed. | | +1 :green_heart: | unit | 1m 2s | hbase-compression-aircompressor in the patch passed. | | +1 :green_heart: | unit | 0m 50s | hbase-compression-brotli in the patch passed. | | +1 :green_heart: | unit | 0m 45s | hbase-compression-lz4 in the patch passed. | | +1 :green_heart: | unit | 0m 45s | hbase-compression-snappy in the patch passed. | | +1 :green_heart: | unit | 1m 12s | hbase-compression-xz in the patch passed. | | +1 :green_heart: | unit | 6m 7s | hbase-compression-zstd in the patch passed. | | | | 280m 41s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5630/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5630 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux b16e5cf26bd7 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6b0ce08c82 | | Default Java | Eclipse Adoptium-11.0.17+8 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5630/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5630/3/testReport/ | | Max. process+thread count | 5074 (vs. ulimit of 3) | | modules | C: hbase-annotations hbase-zookeeper hbase-server hbase-testing-util hbase-it hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-brotli hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5630/3/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix comment word spelling error in HRegionServer.java [hbase]
Apache-HBase commented on PR #5634: URL: https://github.com/apache/hbase/pull/5634#issuecomment-1896155711 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 39s | master passed | | +1 :green_heart: | compile | 0m 37s | master passed | | +1 :green_heart: | shadedjars | 5m 20s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 23s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 17s | the patch passed | | +1 :green_heart: | compile | 0m 37s | the patch passed | | +1 :green_heart: | javac | 0m 37s | the patch passed | | +1 :green_heart: | shadedjars | 5m 19s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 21s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 290m 3s | hbase-server in the patch failed. | | | | 312m 41s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5634/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5634 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 3d176451fb32 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6b0ce08c82 | | Default Java | Temurin-1.8.0_352-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5634/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5634/1/testReport/ | | Max. process+thread count | 4367 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5634/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28271 Infinite waiting on lock acquisition by snapshot can result in unresponsive master [hbase]
Apache-HBase commented on PR #5603: URL: https://github.com/apache/hbase/pull/5603#issuecomment-1896151837 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 26s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 27s | master passed | | +1 :green_heart: | compile | 1m 5s | master passed | | +1 :green_heart: | shadedjars | 6m 43s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 32s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 29s | the patch passed | | +1 :green_heart: | compile | 1m 1s | the patch passed | | +1 :green_heart: | javac | 1m 1s | the patch passed | | +1 :green_heart: | shadedjars | 6m 21s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 23s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 221m 2s | hbase-server in the patch passed. | | | | 251m 27s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5603/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5603 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 81664a6bd6fc 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6b0ce08c82 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5603/6/testReport/ | | Max. process+thread count | 4710 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5603/6/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28316 Add BootstrapNodeService handlers [hbase]
bbeaudreault commented on code in PR #5637:
URL: https://github.com/apache/hbase/pull/5637#discussion_r1455963559
##
hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBasePolicyProvider.java:
##
@@ -44,8 +46,11 @@ public class HBasePolicyProvider extends PolicyProvider {
new Service("security.client.protocol.acl",
RegistryProtos.ClientMetaService.BlockingInterface.class),
new Service("security.admin.protocol.acl",
MasterService.BlockingInterface.class),
+ new Service("security.admin.protocol.acl",
LockService.BlockingInterface.class),
Review Comment:
Is there a reason to add LockService in this PR? I suppose there's no reason
not to, just wondering (i presume LockService has been working as-is for
whatever reason)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (HBASE-28317) RpcCallContext should expose client's TLS certificate
Charles Connell created HBASE-28317:
---
Summary: RpcCallContext should expose client's TLS certificate
Key: HBASE-28317
URL: https://issues.apache.org/jira/browse/HBASE-28317
Project: HBase
Issue Type: Improvement
Reporter: Charles Connell
Assignee: Charles Connell
At my employer we plan on using a coprocessor to log information about some
requests to HBase. For this to be useful to us, we need to know who each
request is coming from. We use HBase's TLS support with mutual authentication
to authenticate clients. I'd like a way to expose the client certificate used
on a request to coprocessors. For setups using Kerberos authentication, RpcCall
exposes the Kerberos principal shortname via {{getRequestUser()}}, so this
would be the TLS equivalent to that.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] HBASE-28314 Enable maven-source-plugin for all modules [hbase]
Apache-HBase commented on PR #5636: URL: https://github.com/apache/hbase/pull/5636#issuecomment-1896118589 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 43s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 55s | master passed | | +1 :green_heart: | compile | 4m 53s | master passed | | +1 :green_heart: | spotless | 0m 43s | branch has no errors when running spotless:check. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 51s | the patch passed | | +1 :green_heart: | compile | 4m 51s | the patch passed | | +1 :green_heart: | javac | 4m 51s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 23s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 4m 54s | Patch does not cause any errors with Hadoop 3.3.6. | | +1 :green_heart: | spotless | 0m 41s | patch has no errors when running spotless:check. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 3m 29s | The patch does not generate ASF License warnings. | | | | 37m 58s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5636/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5636 | | Optional Tests | dupname asflicense javac hadoopcheck spotless xml compile | | uname | Linux f642cbba9539 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6b0ce08c82 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 76 (vs. ulimit of 3) | | modules | C: hbase-logging hbase-protocol-shaded hbase-metrics-api hbase-metrics hbase-hadoop-compat hbase-client hbase-replication hbase-balancer hbase-asyncfs hbase-procedure hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-external-blockcache hbase-hbtop . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5636/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28316 Add BootstrapNodeService handlers [hbase]
Apache9 commented on PR #5637: URL: https://github.com/apache/hbase/pull/5637#issuecomment-1896086352 Will open a PR against branch-2 if the approach is generally good, as the code on branch-2 is a bit different and we 'd better also get a pre commit run for branch-2. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] HBASE-28316 Add BootstrapNodeService handlers [hbase]
Apache9 opened a new pull request, #5637: URL: https://github.com/apache/hbase/pull/5637 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix comment word spelling error in HRegionServer.java [hbase]
Apache-HBase commented on PR #5634: URL: https://github.com/apache/hbase/pull/5634#issuecomment-1896052177 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 13s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 3s | master passed | | +1 :green_heart: | compile | 0m 50s | master passed | | +1 :green_heart: | shadedjars | 5m 8s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 27s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 43s | the patch passed | | +1 :green_heart: | compile | 0m 53s | the patch passed | | +1 :green_heart: | javac | 0m 53s | the patch passed | | +1 :green_heart: | shadedjars | 5m 6s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 25s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 231m 28s | hbase-server in the patch passed. | | | | 259m 31s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5634/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5634 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 451c5d18d947 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6b0ce08c82 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5634/1/testReport/ | | Max. process+thread count | 4647 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5634/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-28314) Enable maven-source-plugin for all modules
[ https://issues.apache.org/jira/browse/HBASE-28314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807766#comment-17807766 ] Istvan Toth commented on HBASE-28314: - This ended up as a new PR : https://github.com/apache/hbase/pull/5636 > Enable maven-source-plugin for all modules > -- > > Key: HBASE-28314 > URL: https://issues.apache.org/jira/browse/HBASE-28314 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 2.6.0, 2.4.17, 3.0.0-beta-1, 4.0.0-alpha-1, 2.5.7 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > > There is no source jar generated for hbase-server. > Enabling maven-source-plugin seems to work fine, and Eclipse can use the > generated sources jar for debugging etc. > It seems that these source JARs are not generated at least since HBase 2.0.0, > but we did have source JARs sometime in the 1.x time frame. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-28256) Enhance ByteBufferUtils.readVLong to read more bytes at a time
[ https://issues.apache.org/jira/browse/HBASE-28256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807765#comment-17807765 ] Becker Ewing commented on HBASE-28256: -- Thank you for the reviews and design help [~bbeaudreault], [~zhangduo], and [~wchevreuil]! > Enhance ByteBufferUtils.readVLong to read more bytes at a time > -- > > Key: HBASE-28256 > URL: https://issues.apache.org/jira/browse/HBASE-28256 > Project: HBase > Issue Type: Improvement > Components: Performance >Reporter: Becker Ewing >Assignee: Becker Ewing >Priority: Major > Fix For: 2.6.0, 2.5.8, 3.0.0-beta-2 > > Attachments: ReadVLongBenchmark.zip, async-prof-rs-cpu.html > > > Currently, ByteBufferUtils.readVLong is used to decode rows in all data block > encodings in order to read the memstoreTs field. For a data block encoding > like prefix, ByteBufferUtils.readVLong can surprisingly occupy over 50% of > the CPU time in BufferedEncodedSeeker.decodeNext (which can be quite a hot > method in seek operations). > > Since memstoreTs will typically require at least 6 bytes to store, we could > look to vectorize the read path for readVLong to read 8 bytes at a time > instead of a single byte at a time (like in > https://issues.apache.org/jira/browse/HBASE-28025) in order to increase > performance. > > Attached is a CPU flamegraph of a region server process which shows that we > spend a surprising amount of time in decoding rows from the DBE in > ByteBufferUtils.readVLong. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-28314) Enable maven-source-plugin for all modules
[ https://issues.apache.org/jira/browse/HBASE-28314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807764#comment-17807764 ] Istvan Toth commented on HBASE-28314: - I have updated the PR to implement #3, and also updated the commit message and JIRA id. PTAL [~zhangduo]. > Enable maven-source-plugin for all modules > -- > > Key: HBASE-28314 > URL: https://issues.apache.org/jira/browse/HBASE-28314 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 2.6.0, 2.4.17, 3.0.0-beta-1, 4.0.0-alpha-1, 2.5.7 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > > There is no source jar generated for hbase-server. > Enabling maven-source-plugin seems to work fine, and Eclipse can use the > generated sources jar for debugging etc. > It seems that these source JARs are not generated at least since HBase 2.0.0, > but we did have source JARs sometime in the 1.x time frame. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Hbase 28314v2 [hbase]
stoty closed pull request #5635: Hbase 28314v2 URL: https://github.com/apache/hbase/pull/5635 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-28314) Enable maven-source-plugin for all modules
[ https://issues.apache.org/jira/browse/HBASE-28314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Istvan Toth updated HBASE-28314: Summary: Enable maven-source-plugin for all modules (was: Generate source artifacts from mvn install for every module containing sources) > Enable maven-source-plugin for all modules > -- > > Key: HBASE-28314 > URL: https://issues.apache.org/jira/browse/HBASE-28314 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 2.6.0, 2.4.17, 3.0.0-beta-1, 4.0.0-alpha-1, 2.5.7 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > > There is no source jar generated for hbase-server. > Enabling maven-source-plugin seems to work fine, and Eclipse can use the > generated sources jar for debugging etc. > It seems that these source JARs are not generated at least since HBase 2.0.0, > but we did have source JARs sometime in the 1.x time frame. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-25051 DIGEST based auth broken for rpc based ConnectionRegistry [hbase]
Apache-HBase commented on PR #5631: URL: https://github.com/apache/hbase/pull/5631#issuecomment-1895968379 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 14s | master passed | | +1 :green_heart: | compile | 1m 57s | master passed | | +1 :green_heart: | shadedjars | 7m 31s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 30s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 10s | the patch passed | | +1 :green_heart: | compile | 2m 42s | the patch passed | | +1 :green_heart: | javac | 2m 42s | the patch passed | | +1 :green_heart: | shadedjars | 7m 46s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 50s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 45s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 3m 30s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 1m 53s | hbase-client in the patch passed. | | -1 :x: | unit | 250m 45s | hbase-server in the patch failed. | | | | 293m 57s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5631/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5631 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 01fe3423b920 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6b0ce08c82 | | Default Java | Temurin-1.8.0_352-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5631/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5631/2/testReport/ | | Max. process+thread count | 4459 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-common hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5631/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-26268) Provide coprocessor hooks for updateConfiguration and clearRegionBlockCache
[ https://issues.apache.org/jira/browse/HBASE-26268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-26268: - Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the fix [~charlesconnell]. Would you mind writing up a release note that summarizes the change? > Provide coprocessor hooks for updateConfiguration and clearRegionBlockCache > --- > > Key: HBASE-26268 > URL: https://issues.apache.org/jira/browse/HBASE-26268 > Project: HBase > Issue Type: Bug >Reporter: Bryan Beaudreault >Assignee: Charles Connell >Priority: Major > Fix For: 2.6.0, 4.0.0-alpha-1, 3.0.0-beta-2 > > > Sorry for the vague title, not sure if it'd be better to create individual > jiras. I discovered that the following two AdminService endpoints are not > covered by AccessController: > > * updateConfiguration > * clearRegionBlockCache > There may be others, I haven't done a full audit. We should add coprocessor > hooks for these and wrap with AccessController, especially since they can > both have an affect on the cluster. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Backport "HBASE-26268 Provide coprocessor hooks for updateConfiguration and clearRegionBlockCache (#5593)" to branch-2.6 [hbase]
ndimiduk merged PR #5633: URL: https://github.com/apache/hbase/pull/5633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Backport "HBASE-26268 Provide coprocessor hooks for updateConfiguration and clearRegionBlockCache (#5593)" to branch-2.6 [hbase]
Apache-HBase commented on PR #5633: URL: https://github.com/apache/hbase/pull/5633#issuecomment-1895919395 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 30s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.6 Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 12s | branch-2.6 passed | | +1 :green_heart: | compile | 0m 46s | branch-2.6 passed | | +1 :green_heart: | shadedjars | 5m 49s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | branch-2.6 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 53s | the patch passed | | +1 :green_heart: | compile | 0m 45s | the patch passed | | +1 :green_heart: | javac | 0m 45s | the patch passed | | +1 :green_heart: | shadedjars | 5m 41s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 23s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 212m 11s | hbase-server in the patch passed. | | | | 238m 43s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5633/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5633 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux a37e00571d77 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.6 / 9f40f71f55 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5633/1/testReport/ | | Max. process+thread count | 4459 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5633/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Backport "HBASE-26268 Provide coprocessor hooks for updateConfiguration and clearRegionBlockCache (#5593)" to branch-2.6 [hbase]
Apache-HBase commented on PR #5633: URL: https://github.com/apache/hbase/pull/5633#issuecomment-1895918050 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 16s | Docker mode activated. | | -0 :warning: | yetus | 0m 5s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.6 Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 28s | branch-2.6 passed | | +1 :green_heart: | compile | 0m 42s | branch-2.6 passed | | +1 :green_heart: | shadedjars | 4m 37s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 25s | branch-2.6 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 16s | the patch passed | | +1 :green_heart: | compile | 0m 42s | the patch passed | | +1 :green_heart: | javac | 0m 42s | the patch passed | | +1 :green_heart: | shadedjars | 4m 37s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 23s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 217m 4s | hbase-server in the patch passed. | | | | 238m 3s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5633/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5633 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux a8c53192ce64 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.6 / 9f40f71f55 | | Default Java | Temurin-1.8.0_352-b08 | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5633/1/testReport/ | | Max. process+thread count | 4202 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5633/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Hbase 28314v2 [hbase]
Apache-HBase commented on PR #5635: URL: https://github.com/apache/hbase/pull/5635#issuecomment-1895910043 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 58s | master passed | | +1 :green_heart: | compile | 4m 57s | master passed | | +1 :green_heart: | spotless | 0m 42s | branch has no errors when running spotless:check. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 46s | the patch passed | | +1 :green_heart: | compile | 4m 58s | the patch passed | | +1 :green_heart: | javac | 4m 58s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 34s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 5m 24s | Patch does not cause any errors with Hadoop 3.3.6. | | +1 :green_heart: | spotless | 0m 42s | patch has no errors when running spotless:check. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 4m 46s | The patch does not generate ASF License warnings. | | | | 38m 42s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5635/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5635 | | Optional Tests | dupname asflicense javac hadoopcheck spotless xml compile | | uname | Linux cc4055a3cafc 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6b0ce08c82 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 78 (vs. ulimit of 3) | | modules | C: hbase-annotations hbase-logging hbase-protocol-shaded hbase-metrics-api hbase-metrics hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-external-blockcache hbase-hbtop hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-brotli hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd . U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5635/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-25051 DIGEST based auth broken for rpc based ConnectionRegistry [hbase]
Apache-HBase commented on PR #5631: URL: https://github.com/apache/hbase/pull/5631#issuecomment-1895904261 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 56s | master passed | | +1 :green_heart: | compile | 2m 7s | master passed | | +1 :green_heart: | shadedjars | 5m 8s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 10s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 50s | the patch passed | | +1 :green_heart: | compile | 2m 5s | the patch passed | | +1 :green_heart: | javac | 2m 5s | the patch passed | | +1 :green_heart: | shadedjars | 5m 7s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 9s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 41s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 2m 18s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 1m 30s | hbase-client in the patch passed. | | -1 :x: | unit | 226m 58s | hbase-server in the patch failed. | | | | 260m 30s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5631/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5631 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 956e5db184d9 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6b0ce08c82 | | Default Java | Eclipse Adoptium-11.0.17+8 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5631/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5631/2/testReport/ | | Max. process+thread count | 5868 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-common hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5631/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-28314) Generate source artifacts from mvn install for every module containing sources
[ https://issues.apache.org/jira/browse/HBASE-28314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807735#comment-17807735 ] Duo Zhang commented on HBASE-28314: --- For me I think #3 is enough, since it does not break our build. > Generate source artifacts from mvn install for every module containing sources > -- > > Key: HBASE-28314 > URL: https://issues.apache.org/jira/browse/HBASE-28314 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 2.6.0, 2.4.17, 3.0.0-beta-1, 4.0.0-alpha-1, 2.5.7 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > > There is no source jar generated for hbase-server. > Enabling maven-source-plugin seems to work fine, and Eclipse can use the > generated sources jar for debugging etc. > It seems that these source JARs are not generated at least since HBase 2.0.0, > but we did have source JARs sometime in the 1.x time frame. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-28314) Generate source artifacts from mvn install for every module containing sources
[ https://issues.apache.org/jira/browse/HBASE-28314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807728#comment-17807728 ] Istvan Toth commented on HBASE-28314: - The original patch is https://github.com/apache/hbase/pull/5630 Compared to master, that one generates source jars in the following modules: hbase-annotations hbase-compression-* hbase-it hbase-server hbase-testing-util hbase-zookeeper These all have java sources. The centralized patch is https://github.com/apache/hbase/pull/5635 The centralized version also generates sources in the following modules: hbase-client-project hbase-shaded-* hbase-checkstyle hbase-openssl hbase-resource-bundle hbase-client-project SHOULD have sources, it's just missing from the current base patch. The rest don't have any java sources, and the source jars don't contain anything useful, only the pom, and some license files. I can see three options: - Use the base patch (fix it by adding teh plugin to the hbase-client-project) - Use the centralized patch, but define the maven-source-plugin in the modules without source code with the skip option - Use the centralized patch, and don't worry about the spurious source jars generated What's your take [~zhangduo] ? > Generate source artifacts from mvn install for every module containing sources > -- > > Key: HBASE-28314 > URL: https://issues.apache.org/jira/browse/HBASE-28314 > Project: HBase > Issue Type: Bug > Components: build >Affects Versions: 2.6.0, 2.4.17, 3.0.0-beta-1, 4.0.0-alpha-1, 2.5.7 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > > There is no source jar generated for hbase-server. > Enabling maven-source-plugin seems to work fine, and Eclipse can use the > generated sources jar for debugging etc. > It seems that these source JARs are not generated at least since HBase 2.0.0, > but we did have source JARs sometime in the 1.x time frame. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-28314 Generate source artifacts from mvn install for every module containing sources [hbase]
stoty closed pull request #5630: HBASE-28314 Generate source artifacts from mvn install for every module containing sources URL: https://github.com/apache/hbase/pull/5630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28314 Generate source artifacts from mvn install for every module containing sources [hbase]
stoty commented on PR #5630: URL: https://github.com/apache/hbase/pull/5630#issuecomment-1895838649 I can see three options: - Use the base patch (also adding hbase-client-project) - Use the centralized project, but define the maven-source-plugin in them with the skip option - Use the centralized project, and ignore the spurious source jars generated What is your take @ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28314 Generate source artifacts from mvn install for every module containing sources [hbase]
stoty commented on PR #5630: URL: https://github.com/apache/hbase/pull/5630#issuecomment-1895831022 I have also uploaded the centralized version as #5635 . The centralized version also generates sources in the following modules: hbase-client-project hbase-shaded-* hbase-checkstyle hbase-openssl hbase-resource-bundle hbase-client-project SHOULD have sources, it's just missing from the current base patch. The rest don't have any java sources, and the source jars don't contain anything useful, only the pom, and some license files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28314 Generate source artifacts from mvn install for every module containing sources [hbase]
stoty commented on PR #5630: URL: https://github.com/apache/hbase/pull/5630#issuecomment-1895814106 This is the original patch. Compared to master, this generates source jars in the following modules: hbase-annotations hbase-compression-* hbase-it hbase-server hbase-testing-util hbase-zookeeper These all have java sources. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-25051 test to reproduce the broken auth problem [hbase]
Apache-HBase commented on PR #5632: URL: https://github.com/apache/hbase/pull/5632#issuecomment-1895755021 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 4s | master passed | | +1 :green_heart: | compile | 1m 5s | master passed | | +1 :green_heart: | shadedjars | 6m 21s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 29s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 7s | the patch passed | | +1 :green_heart: | compile | 0m 55s | the patch passed | | +1 :green_heart: | javac | 0m 55s | the patch passed | | +1 :green_heart: | shadedjars | 6m 4s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 29s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 256m 53s | hbase-server in the patch failed. | | | | 284m 19s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5632/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5632 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 0a903665b433 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6b0ce08c82 | | Default Java | Eclipse Adoptium-11.0.17+8 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5632/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5632/1/testReport/ | | Max. process+thread count | 4500 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5632/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28271 Infinite waiting on lock acquisition by snapshot can result in unresponsive master [hbase]
Apache-HBase commented on PR #5603: URL: https://github.com/apache/hbase/pull/5603#issuecomment-1895748794 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 53s | master passed | | +1 :green_heart: | compile | 3m 52s | master passed | | +1 :green_heart: | checkstyle | 0m 59s | master passed | | +1 :green_heart: | spotless | 1m 12s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 17s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 4s | the patch passed | | +1 :green_heart: | compile | 3m 56s | the patch passed | | +1 :green_heart: | javac | 3m 56s | the patch passed | | +1 :green_heart: | checkstyle | 1m 5s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 6m 23s | Patch does not cause any errors with Hadoop 3.3.6. | | +1 :green_heart: | spotless | 1m 11s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 2m 33s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. | | | | 41m 38s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5603/6/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5603 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 8b30d908d4cf 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6b0ce08c82 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 79 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5603/6/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-25051 test to reproduce the broken auth problem [hbase]
Apache-HBase commented on PR #5632: URL: https://github.com/apache/hbase/pull/5632#issuecomment-1895709227 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 22s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 38s | master passed | | +1 :green_heart: | compile | 0m 40s | master passed | | +1 :green_heart: | shadedjars | 4m 59s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 26s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 25s | the patch passed | | +1 :green_heart: | compile | 0m 40s | the patch passed | | +1 :green_heart: | javac | 0m 40s | the patch passed | | +1 :green_heart: | shadedjars | 4m 57s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 231m 42s | hbase-server in the patch failed. | | | | 257m 2s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5632/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5632 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 4f3f4dbc14f2 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6b0ce08c82 | | Default Java | Temurin-1.8.0_352-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5632/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5632/1/testReport/ | | Max. process+thread count | 4378 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5632/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28314 Generate source artifacts from mvn install for every module containing sources [hbase]
Apache-HBase commented on PR #5630: URL: https://github.com/apache/hbase/pull/5630#issuecomment-1895691422 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 16s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 54s | master passed | | +1 :green_heart: | compile | 5m 20s | master passed | | +1 :green_heart: | spotless | 0m 43s | branch has no errors when running spotless:check. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 46s | the patch passed | | +1 :green_heart: | compile | 5m 17s | the patch passed | | +1 :green_heart: | javac | 5m 17s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 12s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 5m 36s | Patch does not cause any errors with Hadoop 3.3.6. | | -1 :x: | spotless | 0m 39s | patch has 22 errors when running spotless:check, run spotless:apply to fix. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 1m 43s | The patch does not generate ASF License warnings. | | | | 36m 19s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5630/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5630 | | Optional Tests | dupname asflicense javac hadoopcheck spotless xml compile | | uname | Linux b05b7999bdab 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6b0ce08c82 | | Default Java | Eclipse Adoptium-11.0.17+8 | | spotless | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5630/3/artifact/yetus-general-check/output/patch-spotless.txt | | Max. process+thread count | 79 (vs. ulimit of 3) | | modules | C: hbase-annotations hbase-zookeeper hbase-server hbase-testing-util hbase-it hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-brotli hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5630/3/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-28271 Infinite waiting on lock acquisition by snapshot can result in unresponsive master [hbase]
Apache-HBase commented on PR #5603: URL: https://github.com/apache/hbase/pull/5603#issuecomment-1895675359 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 16s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 41s | master passed | | +1 :green_heart: | compile | 0m 36s | master passed | | +1 :green_heart: | shadedjars | 5m 30s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 24s | the patch passed | | +1 :green_heart: | compile | 0m 38s | the patch passed | | +1 :green_heart: | javac | 0m 38s | the patch passed | | +1 :green_heart: | shadedjars | 5m 26s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 21s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 268m 5s | hbase-server in the patch failed. | | | | 293m 1s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5603/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5603 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux e4518696f598 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6b0ce08c82 | | Default Java | Temurin-1.8.0_352-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5603/5/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5603/5/testReport/ | | Max. process+thread count | 4404 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5603/5/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-28316) Add BootstrapNodeService handlers
[ https://issues.apache.org/jira/browse/HBASE-28316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807705#comment-17807705 ] Bryan Beaudreault commented on HBASE-28316: --- That’s actually a big regression. We fully migrated onto RpcConnectionRegistry and can’t really go back at this point. We do run Kerberos but don’t run hbase itself in secure mode , so maybe we are fine. But others might be in a similar issue. > Add BootstrapNodeService handlers > - > > Key: HBASE-28316 > URL: https://issues.apache.org/jira/browse/HBASE-28316 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.6.0, 3.0.0-beta-1 >Reporter: Bryan Beaudreault >Assignee: Duo Zhang >Priority: Blocker > > We added calls to a BootstrapNodeService, but the servers are not setup to > serve it. We need to add in two places: > * RSRPCServices list of services: > [https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java#L1447] > * HBasePolicyProvider mapping of acl to service: > [https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBasePolicyProvider.java#L40] > Without adding to these two places, you first see UnknownServiceExceptions > and then you see AccessDeniedExceptions > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] fix comment word spelling error in HRegionServer.java [hbase]
Apache-HBase commented on PR #5634: URL: https://github.com/apache/hbase/pull/5634#issuecomment-1895637281 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 27s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 3s | master passed | | +1 :green_heart: | compile | 2m 27s | master passed | | +1 :green_heart: | checkstyle | 0m 38s | master passed | | +1 :green_heart: | spotless | 0m 45s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 32s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 46s | the patch passed | | +1 :green_heart: | compile | 2m 26s | the patch passed | | +1 :green_heart: | javac | 2m 26s | the patch passed | | +1 :green_heart: | checkstyle | 0m 34s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 4m 55s | Patch does not cause any errors with Hadoop 3.3.6. | | +1 :green_heart: | spotless | 0m 42s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 47s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 9s | The patch does not generate ASF License warnings. | | | | 31m 28s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5634/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5634 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 72c565e17f2e 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6b0ce08c82 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 81 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5634/1/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-28316) Add BootstrapNodeService handlers
[ https://issues.apache.org/jira/browse/HBASE-28316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807698#comment-17807698 ] Duo Zhang commented on HBASE-28316: --- When implementing, I found a big problem that, in HBase, actually we do not allow master and region server uses different principal username if kerberos is enabled... The problem is that, we will register a service and its principla pattern in SecurityInfo, and when connecting, we will use the pattern to construct the server principal. So for a single service, we can only have one principal pattern, either 'hbase.master.kerberos.principal', or 'hbase.regionserver.kerberos.principal'. But for AdminService and ClientMetaService, both master and region server implement the interface, so if you use different principals for master and region server, then either the client can not connect to master, or the client can not connect to region server... For AdminService, seems it only affects MOB related features as we need to go to master for querying the region info. For ClientMetaService, we have already released HBASE-26150 in 2.5.0 and it is also very important to reduce the load for master, which is a bit troublesome... Anyway, let me fix the problem here first, and add a release note to document that if you enable kerberos and want to use different principals for master and region server, please use ZKConnectionRegistry for now... > Add BootstrapNodeService handlers > - > > Key: HBASE-28316 > URL: https://issues.apache.org/jira/browse/HBASE-28316 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.6.0, 3.0.0-beta-1 >Reporter: Bryan Beaudreault >Assignee: Duo Zhang >Priority: Blocker > > We added calls to a BootstrapNodeService, but the servers are not setup to > serve it. We need to add in two places: > * RSRPCServices list of services: > [https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java#L1447] > * HBasePolicyProvider mapping of acl to service: > [https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBasePolicyProvider.java#L40] > Without adding to these two places, you first see UnknownServiceExceptions > and then you see AccessDeniedExceptions > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] HBASE-28271 Infinite waiting on lock acquisition by snapshot can result in unresponsive master [hbase]
Apache-HBase commented on PR #5603: URL: https://github.com/apache/hbase/pull/5603#issuecomment-1895612347 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 6s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 12s | master passed | | +1 :green_heart: | compile | 0m 46s | master passed | | +1 :green_heart: | shadedjars | 5m 38s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 23s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 57s | the patch passed | | +1 :green_heart: | compile | 0m 47s | the patch passed | | +1 :green_heart: | javac | 0m 47s | the patch passed | | +1 :green_heart: | shadedjars | 5m 35s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 23s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 224m 43s | hbase-server in the patch failed. | | | | 250m 41s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5603/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5603 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 826d068d8fe4 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6b0ce08c82 | | Default Java | Eclipse Adoptium-11.0.17+8 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5603/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5603/5/testReport/ | | Max. process+thread count | 4702 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5603/5/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] fix comment word spelling error in HRegionServer.java [hbase]
ZhongJinHacker opened a new pull request, #5634: URL: https://github.com/apache/hbase/pull/5634 Hello, I found a word spelling error in HRegionServer . and this pr is used to fix it . please review it. thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Backport "HBASE-26268 Provide coprocessor hooks for updateConfiguration and clearRegionBlockCache (#5593)" to branch-2.6 [hbase]
Apache-HBase commented on PR #5633: URL: https://github.com/apache/hbase/pull/5633#issuecomment-1895568419 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 32s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2.6 Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 4s | branch-2.6 passed | | +1 :green_heart: | compile | 2m 25s | branch-2.6 passed | | +1 :green_heart: | checkstyle | 0m 34s | branch-2.6 passed | | +1 :green_heart: | spotless | 0m 42s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 25s | branch-2.6 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 39s | the patch passed | | +1 :green_heart: | compile | 2m 23s | the patch passed | | +1 :green_heart: | javac | 2m 23s | the patch passed | | +1 :green_heart: | checkstyle | 0m 32s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 9m 26s | Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6. | | +1 :green_heart: | spotless | 0m 40s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 30s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 10s | The patch does not generate ASF License warnings. | | | | 29m 42s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5633/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5633 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 40ea1bd65349 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.6 / 9f40f71f55 | | Default Java | Eclipse Adoptium-11.0.17+8 | | Max. process+thread count | 79 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5633/1/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-25051 DIGEST based auth broken for rpc based ConnectionRegistry [hbase]
Apache-HBase commented on PR #5631: URL: https://github.com/apache/hbase/pull/5631#issuecomment-1895537392 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 4s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | prototool | 0m 0s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 2m 54s | master passed | | +1 :green_heart: | compile | 3m 59s | master passed | | +1 :green_heart: | checkstyle | 1m 3s | master passed | | +1 :green_heart: | spotless | 0m 41s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 4m 36s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 37s | the patch passed | | +1 :green_heart: | compile | 3m 57s | the patch passed | | +1 :green_heart: | cc | 3m 57s | the patch passed | | -0 :warning: | javac | 0m 34s | hbase-client generated 2 new + 36 unchanged - 0 fixed = 38 total (was 36) | | +1 :green_heart: | checkstyle | 1m 2s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 4m 58s | Patch does not cause any errors with Hadoop 3.3.6. | | +1 :green_heart: | hbaseprotoc | 1m 27s | the patch passed | | +1 :green_heart: | spotless | 0m 38s | patch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 5m 7s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 29s | The patch does not generate ASF License warnings. | | | | 42m 47s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5631/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5631 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool | | uname | Linux fed032af8856 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6b0ce08c82 | | Default Java | Eclipse Adoptium-11.0.17+8 | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5631/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-client.txt | | Max. process+thread count | 81 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-common hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5631/2/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work started] (HBASE-28316) Add BootstrapNodeService handlers
[ https://issues.apache.org/jira/browse/HBASE-28316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-28316 started by Duo Zhang. - > Add BootstrapNodeService handlers > - > > Key: HBASE-28316 > URL: https://issues.apache.org/jira/browse/HBASE-28316 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.6.0, 3.0.0-beta-1 >Reporter: Bryan Beaudreault >Assignee: Duo Zhang >Priority: Blocker > > We added calls to a BootstrapNodeService, but the servers are not setup to > serve it. We need to add in two places: > * RSRPCServices list of services: > [https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java#L1447] > * HBasePolicyProvider mapping of acl to service: > [https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBasePolicyProvider.java#L40] > Without adding to these two places, you first see UnknownServiceExceptions > and then you see AccessDeniedExceptions > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (HBASE-28316) Add BootstrapNodeService handlers
[ https://issues.apache.org/jira/browse/HBASE-28316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-28316: - Assignee: Duo Zhang > Add BootstrapNodeService handlers > - > > Key: HBASE-28316 > URL: https://issues.apache.org/jira/browse/HBASE-28316 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.6.0, 3.0.0-beta-1 >Reporter: Bryan Beaudreault >Assignee: Duo Zhang >Priority: Blocker > > We added calls to a BootstrapNodeService, but the servers are not setup to > serve it. We need to add in two places: > * RSRPCServices list of services: > [https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java#L1447] > * HBasePolicyProvider mapping of acl to service: > [https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBasePolicyProvider.java#L40] > Without adding to these two places, you first see UnknownServiceExceptions > and then you see AccessDeniedExceptions > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] Backport "HBASE-26268 Provide coprocessor hooks for updateConfiguration and clearRegionBlockCache (#5593)" to branch-2.6 [hbase]
ndimiduk opened a new pull request, #5633: URL: https://github.com/apache/hbase/pull/5633 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Backport "HBASE-26268 Provide coprocessor hooks for updateConfiguration and clearRegionBlockCache (#5593)" to branch-2 [hbase]
ndimiduk merged PR #5628: URL: https://github.com/apache/hbase/pull/5628 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] StorefileRefresherChore should not refresh readonly table [hbase]
xxishu closed pull request #5627: StorefileRefresherChore should not refresh readonly table URL: https://github.com/apache/hbase/pull/5627 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-25051 DIGEST based auth broken for rpc based ConnectionRegistry [hbase]
Apache-HBase commented on PR #5631: URL: https://github.com/apache/hbase/pull/5631#issuecomment-1895354459 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 39s | master passed | | +1 :green_heart: | compile | 2m 13s | master passed | | +1 :green_heart: | shadedjars | 7m 34s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 16s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 36s | the patch passed | | +1 :green_heart: | compile | 2m 13s | the patch passed | | +1 :green_heart: | javac | 2m 13s | the patch passed | | +1 :green_heart: | shadedjars | 7m 48s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 19s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 36s | hbase-protocol-shaded in the patch passed. | | +1 :green_heart: | unit | 3m 15s | hbase-common in the patch passed. | | -1 :x: | unit | 1m 19s | hbase-client in the patch failed. | | -1 :x: | unit | 16m 25s | hbase-server in the patch failed. | | | | 55m 7s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5631/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5631 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux f990b87c4bd8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6b0ce08c82 | | Default Java | Temurin-1.8.0_352-b08 | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5631/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-client.txt | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5631/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5631/1/testReport/ | | Max. process+thread count | 1686 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-common hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5631/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-25051 DIGEST based auth broken for rpc based ConnectionRegistry [hbase]
Apache-HBase commented on PR #5631: URL: https://github.com/apache/hbase/pull/5631#issuecomment-1895348704 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | prototool | 0m 0s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 0s | master passed | | +1 :green_heart: | compile | 3m 59s | master passed | | +1 :green_heart: | checkstyle | 1m 5s | master passed | | +1 :green_heart: | spotless | 0m 43s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 4m 42s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 9s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 42s | the patch passed | | +1 :green_heart: | compile | 5m 7s | the patch passed | | +1 :green_heart: | cc | 5m 7s | the patch passed | | -0 :warning: | javac | 0m 46s | hbase-client generated 2 new + 36 unchanged - 0 fixed = 38 total (was 36) | | +1 :green_heart: | checkstyle | 1m 13s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 6m 1s | Patch does not cause any errors with Hadoop 3.3.6. | | +1 :green_heart: | hbaseprotoc | 1m 46s | the patch passed | | +1 :green_heart: | spotless | 1m 2s | patch has no errors when running spotless:check. | | -1 :x: | spotbugs | 1m 33s | hbase-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 58s | The patch does not generate ASF License warnings. | | | | 51m 38s | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-client | | | Nullcheck of md at line 425 of value previously dereferenced in org.apache.hadoop.hbase.ipc.AbstractRpcClient.callMethod(Descriptors$MethodDescriptor, HBaseRpcController, Message, Message, User, Address, RpcCallback) At AbstractRpcClient.java:425 of value previously dereferenced in org.apache.hadoop.hbase.ipc.AbstractRpcClient.callMethod(Descriptors$MethodDescriptor, HBaseRpcController, Message, Message, User, Address, RpcCallback) At AbstractRpcClient.java:[line 407] | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5631/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5631 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool | | uname | Linux a2ffe1f426b5 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 6b0ce08c82 | | Default Java | Eclipse Adoptium-11.0.17+8 | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5631/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-client.txt | | spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5631/1/artifact/yetus-general-check/output/new-spotbugs-hbase-client.html | | Max. process+thread count | 81 (vs. ulimit of 3) | | modules | C: hbase-protocol-shaded hbase-common hbase-client hbase-server U: . | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5631/1/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
