[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[ https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14909044#comment-14909044 ] Srikanth Srungarapu commented on HBASE-14394: - Thanks, Jerry! > Properly close the connection after reading records from table. > --- > > Key: HBASE-14394 > URL: https://issues.apache.org/jira/browse/HBASE-14394 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14394.patch, HBASE-14394_v2.patch, > HBASE-14394_v3.patch, HBASE-14394_v4.patch > > > This was brought to notice by one of our observant customers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[
https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14905996#comment-14905996
]
Srikanth Srungarapu commented on HBASE-14394:
-
Yeah, I can definitely provide doc comments. Reducing the visibility of the
method may not be feasible option, as we have to call {{trr.setConnection()}}
method from {{MultiTableInputFormatBase}}, and hence it can't be marked as
either protected or private. Please do let me know if you guys have any better
alternatives in mind.
> Properly close the connection after reading records from table.
> ---
>
> Key: HBASE-14394
> URL: https://issues.apache.org/jira/browse/HBASE-14394
> Project: HBase
> Issue Type: Bug
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
>Priority: Minor
> Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3
>
> Attachments: HBASE-14394.patch, HBASE-14394_v2.patch,
> HBASE-14394_v3.patch, HBASE-14394_v4.patch
>
>
> This was brought to notice by one of our observant customers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14205) RegionCoprocessorHost System.nanoTime() performance bottleneck
[ https://issues.apache.org/jira/browse/HBASE-14205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14905986#comment-14905986 ] Srikanth Srungarapu commented on HBASE-14205: - +1. Thanks for picking this up, [~apurtell]. > RegionCoprocessorHost System.nanoTime() performance bottleneck > -- > > Key: HBASE-14205 > URL: https://issues.apache.org/jira/browse/HBASE-14205 > Project: HBase > Issue Type: Bug >Reporter: Jan Van Besien >Assignee: Andrew Purtell >Priority: Critical > Fix For: 2.0.0, 1.2.0, 1.3.0 > > Attachments: HBASE-14205.patch > > > The tracking of execution time of coprocessor methods introduced in > HBASE-11516 introduces 2 calls to System.nanoTime() per coprocessor method > per coprocessor. This is resulting in a serious performance bottleneck in > certain scenarios. > For example consider the scenario where many rows are being ingested (PUT) in > a table which has multiple coprocessors (we have up to 20 coprocessors). This > results in 8 extra calls to System.nanoTime() per coprocessor (prePut, > postPut, postStartRegionOperation and postCloseRegionOperation) which has in > total (i.e. times 20) been seen to result in a 50% increase of execution time. > I think it is generally considered bad practice to measure execution times on > such a small scale (per single operation). Also note that measurements are > taken even for coprocessors that do not even have an actual implementation > for certain operations, making the problem worse. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[ https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14907353#comment-14907353 ] Srikanth Srungarapu commented on HBASE-14394: - [~jerryhe] Do you mind picking this up? I might not be able to attend to this anytime soon. > Properly close the connection after reading records from table. > --- > > Key: HBASE-14394 > URL: https://issues.apache.org/jira/browse/HBASE-14394 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14394.patch, HBASE-14394_v2.patch, > HBASE-14394_v3.patch, HBASE-14394_v4.patch > > > This was brought to notice by one of our observant customers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13116) Enhance the documentation for usage of "doAs" through REST and Thrift gateways
[ https://issues.apache.org/jira/browse/HBASE-13116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14746619#comment-14746619 ] Srikanth Srungarapu commented on HBASE-13116: - Thanks! > Enhance the documentation for usage of "doAs" through REST and Thrift gateways > -- > > Key: HBASE-13116 > URL: https://issues.apache.org/jira/browse/HBASE-13116 > Project: HBase > Issue Type: Sub-task > Components: documentation >Reporter: Srikanth Srungarapu >Assignee: Jerry He >Priority: Minor > > The existing documentation on the instructions to use "doAs" feature is a bit > misleading. A little more explanation about the overlapping configurations > for impersonation and doAs would make things smoother. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13116) Enhance the documentation for usage of "doAs" through REST and Thrift gateways
[ https://issues.apache.org/jira/browse/HBASE-13116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srikanth Srungarapu updated HBASE-13116: Assignee: (was: Srikanth Srungarapu) > Enhance the documentation for usage of "doAs" through REST and Thrift gateways > -- > > Key: HBASE-13116 > URL: https://issues.apache.org/jira/browse/HBASE-13116 > Project: HBase > Issue Type: Sub-task > Components: documentation >Reporter: Srikanth Srungarapu >Priority: Minor > > The existing documentation on the instructions to use "doAs" feature is a bit > misleading. A little more explanation about the overlapping configurations > for impersonation and doAs would make things smoother. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14394) Properly close the connection after reading records from table.
[ https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srikanth Srungarapu updated HBASE-14394: Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 1.1.3 1.0.3 1.3.0 1.2.0 2.0.0 Status: Resolved (was: Patch Available) Thanks folks for the reviews. Pushed the fix to all 1.0+ branches. > Properly close the connection after reading records from table. > --- > > Key: HBASE-14394 > URL: https://issues.apache.org/jira/browse/HBASE-14394 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14394.patch, HBASE-14394_v2.patch, > HBASE-14394_v3.patch, HBASE-14394_v4.patch > > > This was brought to notice by one of our observant customers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13116) Enhance the documentation for usage of "doAs" through REST and Thrift gateways
[ https://issues.apache.org/jira/browse/HBASE-13116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745829#comment-14745829 ] Srikanth Srungarapu commented on HBASE-13116: - Leaving this unassigned as I won't be working on this anytime soon. > Enhance the documentation for usage of "doAs" through REST and Thrift gateways > -- > > Key: HBASE-13116 > URL: https://issues.apache.org/jira/browse/HBASE-13116 > Project: HBase > Issue Type: Sub-task > Components: documentation >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > > The existing documentation on the instructions to use "doAs" feature is a bit > misleading. A little more explanation about the overlapping configurations > for impersonation and doAs would make things smoother. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (HBASE-14172) Upgrade existing thrift binding using thrift 0.9.2 compiler.
[ https://issues.apache.org/jira/browse/HBASE-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srikanth Srungarapu reassigned HBASE-14172: --- Assignee: (was: Srikanth Srungarapu) > Upgrade existing thrift binding using thrift 0.9.2 compiler. > > > Key: HBASE-14172 > URL: https://issues.apache.org/jira/browse/HBASE-14172 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Priority: Minor > Attachments: HBASE-14172-branch-1.patch, HBASE-14172.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[ https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14740287#comment-14740287 ] Srikanth Srungarapu commented on HBASE-14394: - Yeah, the table close method call is redundant. Uploaded new patch. > Properly close the connection after reading records from table. > --- > > Key: HBASE-14394 > URL: https://issues.apache.org/jira/browse/HBASE-14394 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Attachments: HBASE-14394.patch, HBASE-14394_v2.patch, > HBASE-14394_v3.patch > > > This was brought to notice by one of our observant customers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14394) Properly close the connection after reading records from table.
[ https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srikanth Srungarapu updated HBASE-14394: Attachment: HBASE-14394_v3.patch > Properly close the connection after reading records from table. > --- > > Key: HBASE-14394 > URL: https://issues.apache.org/jira/browse/HBASE-14394 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Attachments: HBASE-14394.patch, HBASE-14394_v2.patch, > HBASE-14394_v3.patch > > > This was brought to notice by one of our observant customers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14741372#comment-14741372 ] Srikanth Srungarapu commented on HBASE-14261: - Thanks! > Enhance Chaos Monkey framework by adding zookeeper and datanode fault > injections. > - > > Key: HBASE-14261 > URL: https://issues.apache.org/jira/browse/HBASE-14261 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu > Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.15, 1.0.3, 1.1.3 > > Attachments: HBASE-14261-addendum.patch, HBASE-14261-branch-1.patch, > HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch, > HBASE-14261.branch-1_v2.patch, HBASE-14261.patch > > > One of the shortcomings of existing ChaosMonkey framework is lack of fault > injections for hbase dependencies like zookeeper, hdfs etc. This patch > attempts to solve this problem partially by adding datanode and zk node fault > injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14394) Properly close the connection after reading records from table.
[ https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srikanth Srungarapu updated HBASE-14394: Attachment: HBASE-14394_v4.patch Adding null check before closing the connection. > Properly close the connection after reading records from table. > --- > > Key: HBASE-14394 > URL: https://issues.apache.org/jira/browse/HBASE-14394 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Attachments: HBASE-14394.patch, HBASE-14394_v2.patch, > HBASE-14394_v3.patch, HBASE-14394_v4.patch > > > This was brought to notice by one of our observant customers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[
https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Srikanth Srungarapu updated HBASE-14261:
Release Note:
This change augments existing chaos monkey framework with actions for
restarting underlying zookeeper quorum and hdfs nodes of distributed hbase
cluster. One assumption made while creating zk actions are that zookeper
ensemble is an independent external service and won't be managed by hbase
cluster. For these actions to work as expected, the following parameters need
to be configured appropriately.
{code}
hbase.it.clustermanager.hadoop.home
$HADOOP_HOME
hbase.it.clustermanager.zookeeper.home
$ZOOKEEPER_HOME
hbase.it.clustermanager.hbase.user
hbase
hbase.it.clustermanager.hadoop.hdfs.user
hdfs
hbase.it.clustermanager.zookeeper.user
zookeeper
{code}
The service user related configurations are newly introduced since in prod/test
environments each service is managed by different user. Once the above
parameters are configured properly, you can start using them as needed. An
example usage for invoking these new actions is:
{{./hbase org.apache.hadoop.hbase.IntegrationTestAcidGuarantees -m
serverAndDependenciesKilling}}
> Enhance Chaos Monkey framework by adding zookeeper and datanode fault
> injections.
> -
>
> Key: HBASE-14261
> URL: https://issues.apache.org/jira/browse/HBASE-14261
> Project: HBase
> Issue Type: Improvement
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
> Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.15, 1.0.3, 1.1.3
>
> Attachments: HBASE-14261-addendum.patch, HBASE-14261-branch-1.patch,
> HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch,
> HBASE-14261.branch-1_v2.patch, HBASE-14261.patch
>
>
> One of the shortcomings of existing ChaosMonkey framework is lack of fault
> injections for hbase dependencies like zookeeper, hdfs etc. This patch
> attempts to solve this problem partially by adding datanode and zk node fault
> injections.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14385) Close the sockets that is missing in connection closure.
[ https://issues.apache.org/jira/browse/HBASE-14385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srikanth Srungarapu updated HBASE-14385: Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 1.1.3 1.0.3 1.3.0 1.2.0 2.0.0 Status: Resolved (was: Patch Available) > Close the sockets that is missing in connection closure. > > > Key: HBASE-14385 > URL: https://issues.apache.org/jira/browse/HBASE-14385 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Fix For: 2.0.0, 1.2.0, 1.3.0, 1.0.3, 1.1.3 > > Attachments: HBASE-14385.patch, HBASE-14385_v2.patch > > > As per heading. Due credit to one of our awesome customers for digging into > this and helping me craft the unit test. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srikanth Srungarapu updated HBASE-14261: Fix Version/s: 1.1.3 1.0.3 0.98.15 1.2.0 > Enhance Chaos Monkey framework by adding zookeeper and datanode fault > injections. > - > > Key: HBASE-14261 > URL: https://issues.apache.org/jira/browse/HBASE-14261 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu > Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.15, 1.0.3, 1.1.3 > > Attachments: HBASE-14261-addendum.patch, HBASE-14261-branch-1.patch, > HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch, > HBASE-14261.branch-1_v2.patch, HBASE-14261.patch > > > One of the shortcomings of existing ChaosMonkey framework is lack of fault > injections for hbase dependencies like zookeeper, hdfs etc. This patch > attempts to solve this problem partially by adding datanode and zk node fault > injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14394) Properly close the connection after reading records from table.
[ https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srikanth Srungarapu updated HBASE-14394: Summary: Properly close the connection after reading records from table. (was: Properly close the connection while reading records from table.) > Properly close the connection after reading records from table. > --- > > Key: HBASE-14394 > URL: https://issues.apache.org/jira/browse/HBASE-14394 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Attachments: HBASE-14394.patch > > > This was brought to notice by one of our observant customers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14147) REST Support for Namespaces
[
https://issues.apache.org/jira/browse/HBASE-14147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14738281#comment-14738281
]
Srikanth Srungarapu commented on HBASE-14147:
-
On branch-1, I'm getting the following compilation error:
{code}
"[INFO] -
[ERROR] COMPILATION ERROR :
[INFO] -
[ERROR]
/Users/ssrungarapu/apache/hbase/hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestNamespacesInstanceResource.java:[50,49]
error: cannot find symbol
[ERROR] symbol: class RestTests
location: package org.apache.hadoop.hbase.testclassification
/Users/ssrungarapu/apache/hbase/hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/model/TestNamespacesInstanceModel.java:[25,49]
error: cannot find symbol
[ERROR] symbol: class RestTests
location: package org.apache.hadoop.hbase.testclassification
/Users/ssrungarapu/apache/hbase/hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/model/TestNamespacesModel.java:[25,49]
error: cannot find symbol
[ERROR] symbol: class RestTests
location: package org.apache.hadoop.hbase.testclassification
/Users/ssrungarapu/apache/hbase/hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestNamespacesResource.java:[37,49]
error: cannot find symbol
[ERROR] symbol: class RestTests
location: package org.apache.hadoop.hbase.testclassification
/Users/ssrungarapu/apache/hbase/hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestNamespacesInstanceResource.java:[61,11]
error: cannot find symbol
[ERROR] symbol: class RestTests
/Users/ssrungarapu/apache/hbase/hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/model/TestNamespacesInstanceModel.java:[30,11]
error: cannot find symbol
[ERROR] symbol: class RestTests
/Users/ssrungarapu/apache/hbase/hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/model/TestNamespacesModel.java:[31,11]
error: cannot find symbol
[ERROR] symbol: class RestTests
/Users/ssrungarapu/apache/hbase/hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestNamespacesResource.java:[47,11]
error: cannot find symbol
{code}
Is this related?
> REST Support for Namespaces
> ---
>
> Key: HBASE-14147
> URL: https://issues.apache.org/jira/browse/HBASE-14147
> Project: HBase
> Issue Type: Sub-task
> Components: REST
>Affects Versions: 1.1.1
>Reporter: Rick Kellogg
>Assignee: Matt Warhaftig
>Priority: Minor
> Fix For: 2.0.0, 1.2.0, 1.3.0
>
> Attachments: SuccessfulLocalBuild.txt, hbase-14147-v1.patch,
> hbase-14147-v1.patch, hbase-14147-v1.patch
>
>
> Expand REST services to include addition features:
> * Create namespace
> * Alter namespace
> * Describe namespace
> * Drop namespace
> * List tables in a specific namespace
> * List all namespaces.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13336) Consistent rules for security meta table protections
[ https://issues.apache.org/jira/browse/HBASE-13336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14739897#comment-14739897 ] Srikanth Srungarapu commented on HBASE-13336: - I won't be working on this anytime in the near future. Unassigning so that others can pick up if interested. > Consistent rules for security meta table protections > > > Key: HBASE-13336 > URL: https://issues.apache.org/jira/browse/HBASE-13336 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Srikanth Srungarapu > Fix For: 2.0.0, 1.3.0, 0.98.15 > > Attachments: HBASE-13336.patch, HBASE-13336_v2.patch > > > The AccessController and VisibilityController do different things regarding > protecting their meta tables. The AC allows schema changes and disable/enable > if the user has permission. The VC unconditionally disallows all admin > actions. Generally, bad things will happen if these meta tables are damaged, > disabled, or dropped. The likely outcome is random frequent (or constant) > server side op failures with nasty stack traces. On the other hand some > things like column family and table attribute changes can have valid use > cases. We should have consistent and sensible rules for protecting security > meta tables. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13538) Procedure v2 - client add/delete/modify column family sync (incompatible with branch-1.x)
[ https://issues.apache.org/jira/browse/HBASE-13538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14739895#comment-14739895 ] Srikanth Srungarapu commented on HBASE-13538: - I won't be working on this anytime in the near future. Unassigning so that others can pick up if interested. > Procedure v2 - client add/delete/modify column family sync (incompatible with > branch-1.x) > - > > Key: HBASE-13538 > URL: https://issues.apache.org/jira/browse/HBASE-13538 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Affects Versions: 2.0.0 >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu > > Client side part of HBASE-13209. > It uses the new procedure code to be know when the procedure is completed, > and have a proper sync/async behavior on add/modify/delete column family. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13538) Procedure v2 - client add/delete/modify column family sync (incompatible with branch-1.x)
[ https://issues.apache.org/jira/browse/HBASE-13538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srikanth Srungarapu updated HBASE-13538: Assignee: (was: Srikanth Srungarapu) > Procedure v2 - client add/delete/modify column family sync (incompatible with > branch-1.x) > - > > Key: HBASE-13538 > URL: https://issues.apache.org/jira/browse/HBASE-13538 > Project: HBase > Issue Type: Sub-task > Components: proc-v2 >Affects Versions: 2.0.0 >Reporter: Srikanth Srungarapu > > Client side part of HBASE-13209. > It uses the new procedure code to be know when the procedure is completed, > and have a proper sync/async behavior on add/modify/delete column family. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14394) Properly close the connection after reading records from table.
[
https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Srikanth Srungarapu updated HBASE-14394:
Attachment: HBASE-14394_v2.patch
Fixing the failed unit test {{TestMultiTableInputFormat}}.
> Properly close the connection after reading records from table.
> ---
>
> Key: HBASE-14394
> URL: https://issues.apache.org/jira/browse/HBASE-14394
> Project: HBase
> Issue Type: Bug
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
>Priority: Minor
> Attachments: HBASE-14394.patch, HBASE-14394_v2.patch
>
>
> This was brought to notice by one of our observant customers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-13336) Consistent rules for security meta table protections
[ https://issues.apache.org/jira/browse/HBASE-13336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srikanth Srungarapu updated HBASE-13336: Assignee: (was: Srikanth Srungarapu) > Consistent rules for security meta table protections > > > Key: HBASE-13336 > URL: https://issues.apache.org/jira/browse/HBASE-13336 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell > Fix For: 2.0.0, 1.3.0, 0.98.15 > > Attachments: HBASE-13336.patch, HBASE-13336_v2.patch > > > The AccessController and VisibilityController do different things regarding > protecting their meta tables. The AC allows schema changes and disable/enable > if the user has permission. The VC unconditionally disallows all admin > actions. Generally, bad things will happen if these meta tables are damaged, > disabled, or dropped. The likely outcome is random frequent (or constant) > server side op failures with nasty stack traces. On the other hand some > things like column family and table attribute changes can have valid use > cases. We should have consistent and sensible rules for protecting security > meta tables. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14394) Properly close the connection after reading records from table.
[
https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14740245#comment-14740245
]
Srikanth Srungarapu commented on HBASE-14394:
-
Currently, we are closing the resources only in case of exception i.e. in catch
block.
{code}
catch (IOException ioe) {
// If there is an exception make sure that all
// resources are closed and released.
- connection.close();
- table.close();
trr.close();
throw ioe;
{code}
This patch ensures resources get closed in _all_ cases.
> Properly close the connection after reading records from table.
> ---
>
> Key: HBASE-14394
> URL: https://issues.apache.org/jira/browse/HBASE-14394
> Project: HBase
> Issue Type: Bug
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
>Priority: Minor
> Attachments: HBASE-14394.patch, HBASE-14394_v2.patch
>
>
> This was brought to notice by one of our observant customers.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (HBASE-14394) Properly close the connection while reading records from table.
Srikanth Srungarapu created HBASE-14394: --- Summary: Properly close the connection while reading records from table. Key: HBASE-14394 URL: https://issues.apache.org/jira/browse/HBASE-14394 Project: HBase Issue Type: Bug Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Priority: Minor This was brought to notice by one of our observant customers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14394) Properly close the connection while reading records from table.
[ https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srikanth Srungarapu updated HBASE-14394: Status: Patch Available (was: Open) > Properly close the connection while reading records from table. > --- > > Key: HBASE-14394 > URL: https://issues.apache.org/jira/browse/HBASE-14394 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Attachments: HBASE-14394.patch > > > This was brought to notice by one of our observant customers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14394) Properly close the connection while reading records from table.
[ https://issues.apache.org/jira/browse/HBASE-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srikanth Srungarapu updated HBASE-14394: Attachment: HBASE-14394.patch > Properly close the connection while reading records from table. > --- > > Key: HBASE-14394 > URL: https://issues.apache.org/jira/browse/HBASE-14394 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Attachments: HBASE-14394.patch > > > This was brought to notice by one of our observant customers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14385) Close the sockets that is missing in connection closure.
[ https://issues.apache.org/jira/browse/HBASE-14385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srikanth Srungarapu updated HBASE-14385: Description: As per heading. Due credit to one of our awesome customers for digging into this and helping me craft the unit test. (was: As per heading.) > Close the sockets that is missing in connection closure. > > > Key: HBASE-14385 > URL: https://issues.apache.org/jira/browse/HBASE-14385 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Attachments: HBASE-14385.patch, HBASE-14385_v2.patch > > > As per heading. Due credit to one of our awesome customers for digging into > this and helping me craft the unit test. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14385) Close the sockets that is missing in connection closure.
[ https://issues.apache.org/jira/browse/HBASE-14385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srikanth Srungarapu updated HBASE-14385: Attachment: (was: HBASE-14385_v2.patch) > Close the sockets that is missing in connection closure. > > > Key: HBASE-14385 > URL: https://issues.apache.org/jira/browse/HBASE-14385 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Attachments: HBASE-14385.patch, HBASE-14385_v2.patch > > > As per heading. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14385) Close the sockets that is missing in connection closure.
[ https://issues.apache.org/jira/browse/HBASE-14385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srikanth Srungarapu updated HBASE-14385: Attachment: HBASE-14385_v2.patch > Close the sockets that is missing in connection closure. > > > Key: HBASE-14385 > URL: https://issues.apache.org/jira/browse/HBASE-14385 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Attachments: HBASE-14385.patch, HBASE-14385_v2.patch > > > As per heading. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14385) Close the sockets that is missing in connection closure.
[ https://issues.apache.org/jira/browse/HBASE-14385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srikanth Srungarapu updated HBASE-14385: Attachment: HBASE-14385_v2.patch Addressing the feedback and awaiting QA bot blessings. > Close the sockets that is missing in connection closure. > > > Key: HBASE-14385 > URL: https://issues.apache.org/jira/browse/HBASE-14385 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Attachments: HBASE-14385.patch, HBASE-14385_v2.patch > > > As per heading. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14385) Close the sockets that is missing in connection closure.
[ https://issues.apache.org/jira/browse/HBASE-14385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14737587#comment-14737587 ] Srikanth Srungarapu commented on HBASE-14385: - Test failures not related. Will push this tonight unless objection. > Close the sockets that is missing in connection closure. > > > Key: HBASE-14385 > URL: https://issues.apache.org/jira/browse/HBASE-14385 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Attachments: HBASE-14385.patch, HBASE-14385_v2.patch > > > As per heading. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-14385) Close the sockets that is missing in connection closure.
Srikanth Srungarapu created HBASE-14385: --- Summary: Close the sockets that is missing in connection closure. Key: HBASE-14385 URL: https://issues.apache.org/jira/browse/HBASE-14385 Project: HBase Issue Type: Bug Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Priority: Minor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14385) Close the sockets that is missing in connection closure.
[ https://issues.apache.org/jira/browse/HBASE-14385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srikanth Srungarapu updated HBASE-14385: Description: As per heading. > Close the sockets that is missing in connection closure. > > > Key: HBASE-14385 > URL: https://issues.apache.org/jira/browse/HBASE-14385 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Attachments: HBASE-14385.patch > > > As per heading. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14385) Close the sockets that is missing in connection closure.
[ https://issues.apache.org/jira/browse/HBASE-14385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srikanth Srungarapu updated HBASE-14385: Status: Patch Available (was: Open) > Close the sockets that is missing in connection closure. > > > Key: HBASE-14385 > URL: https://issues.apache.org/jira/browse/HBASE-14385 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Attachments: HBASE-14385.patch > > > As per heading. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14385) Close the sockets that is missing in connection closure.
[ https://issues.apache.org/jira/browse/HBASE-14385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srikanth Srungarapu updated HBASE-14385: Attachment: HBASE-14385.patch > Close the sockets that is missing in connection closure. > > > Key: HBASE-14385 > URL: https://issues.apache.org/jira/browse/HBASE-14385 > Project: HBase > Issue Type: Bug >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu >Priority: Minor > Attachments: HBASE-14385.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731284#comment-14731284 ] Srikanth Srungarapu commented on HBASE-14261: - Sure, this change warrants one. Will add it soon. Thanks for bringing this up. > Enhance Chaos Monkey framework by adding zookeeper and datanode fault > injections. > - > > Key: HBASE-14261 > URL: https://issues.apache.org/jira/browse/HBASE-14261 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-14261-branch-1.patch, > HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch, > HBASE-14261.branch-1_v2.patch, HBASE-14261.patch > > > One of the shortcomings of existing ChaosMonkey framework is lack of fault > injections for hbase dependencies like zookeeper, hdfs etc. This patch > attempts to solve this problem partially by adding datanode and zk node fault > injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[
https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Srikanth Srungarapu updated HBASE-14261:
Attachment: HBASE-14261-addendum.patch
The patch changed (accidentally) printing "Zk host" to "ZK host" in
{{ZkServerTool}}. The addendum should fix this.
Thanks [~mbertozzi] for noticing and bringing this to attention.
> Enhance Chaos Monkey framework by adding zookeeper and datanode fault
> injections.
> -
>
> Key: HBASE-14261
> URL: https://issues.apache.org/jira/browse/HBASE-14261
> Project: HBase
> Issue Type: Improvement
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
> Fix For: 2.0.0, 1.3.0
>
> Attachments: HBASE-14261-addendum.patch, HBASE-14261-branch-1.patch,
> HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch,
> HBASE-14261.branch-1_v2.patch, HBASE-14261.patch
>
>
> One of the shortcomings of existing ChaosMonkey framework is lack of fault
> injections for hbase dependencies like zookeeper, hdfs etc. This patch
> attempts to solve this problem partially by adding datanode and zk node fault
> injections.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srikanth Srungarapu updated HBASE-14261: Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 1.3.0 2.0.0 Status: Resolved (was: Patch Available) Thanks folks for the reviews. Pushed to 1.3+ branches. > Enhance Chaos Monkey framework by adding zookeeper and datanode fault > injections. > - > > Key: HBASE-14261 > URL: https://issues.apache.org/jira/browse/HBASE-14261 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-14261-branch-1.patch, > HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch, > HBASE-14261.branch-1_v2.patch, HBASE-14261.patch > > > One of the shortcomings of existing ChaosMonkey framework is lack of fault > injections for hbase dependencies like zookeeper, hdfs etc. This patch > attempts to solve this problem partially by adding datanode and zk node fault > injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14729978#comment-14729978 ] Srikanth Srungarapu commented on HBASE-14261: - Can I also backport this to other 1.x branches? > Enhance Chaos Monkey framework by adding zookeeper and datanode fault > injections. > - > > Key: HBASE-14261 > URL: https://issues.apache.org/jira/browse/HBASE-14261 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu > Fix For: 2.0.0, 1.3.0 > > Attachments: HBASE-14261-branch-1.patch, > HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch, > HBASE-14261.branch-1_v2.patch, HBASE-14261.patch > > > One of the shortcomings of existing ChaosMonkey framework is lack of fault > injections for hbase dependencies like zookeeper, hdfs etc. This patch > attempts to solve this problem partially by adding datanode and zk node fault > injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[
https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14726914#comment-14726914
]
Srikanth Srungarapu commented on HBASE-14261:
-
bq. Did you test the patch?
Yeah, I did today [~enis]. Had to tweak {{ZookeeperShellCommandProvider}} to
make things happen as expected.
> Enhance Chaos Monkey framework by adding zookeeper and datanode fault
> injections.
> -
>
> Key: HBASE-14261
> URL: https://issues.apache.org/jira/browse/HBASE-14261
> Project: HBase
> Issue Type: Improvement
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
> Attachments: HBASE-14261-branch-1.patch,
> HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch,
> HBASE-14261.branch-1_v2.patch
>
>
> One of the shortcomings of existing ChaosMonkey framework is lack of fault
> injections for hbase dependencies like zookeeper, hdfs etc. This patch
> attempts to solve this problem partially by adding datanode and zk node fault
> injections.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[
https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14726902#comment-14726902
]
Srikanth Srungarapu commented on HBASE-14261:
-
bq. Any reason that DistributedHBaseCluster (and HBaseCluster) now has
waitForZkNodeToStart and waitForDataNodeToStart? I see that there were
previously just wait... methods for stopping, so I'm wondering if the wait
shouldn't just be implicit for starts (i.e. do we ever envision wanting to not
wait for the service to be started before doing things?).
We do have {{waitForRegionServerToStart}} and {{waitForActiveAndReadyMaster}}.
So, I followed the same pattern here too.
bq. Just as a general best practices question, in HBaseClusterManager, you
throw an IOException if hbase.it.clustermanager. {zookeeper,hadoop}.home isn't
set. Does not passing a correct config qualify as an IOException, or should
this just be a more general Exception?
I agree that IOException is not the most appropriate object to use here.
Hopefully HBASE-13936 will help us in handling misappropriate configurations
more appropriately. In the meanwhile, if you have something else in mind, I'd
be happy to incorporate into the patch.
Addressed all other issues in the latest patch.
> Enhance Chaos Monkey framework by adding zookeeper and datanode fault
> injections.
> -
>
> Key: HBASE-14261
> URL: https://issues.apache.org/jira/browse/HBASE-14261
> Project: HBase
> Issue Type: Improvement
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
> Attachments: HBASE-14261-branch-1.patch,
> HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch,
> HBASE-14261.branch-1_v2.patch
>
>
> One of the shortcomings of existing ChaosMonkey framework is lack of fault
> injections for hbase dependencies like zookeeper, hdfs etc. This patch
> attempts to solve this problem partially by adding datanode and zk node fault
> injections.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srikanth Srungarapu updated HBASE-14261: Attachment: HBASE-14261-branch-1_v4.patch > Enhance Chaos Monkey framework by adding zookeeper and datanode fault > injections. > - > > Key: HBASE-14261 > URL: https://issues.apache.org/jira/browse/HBASE-14261 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu > Attachments: HBASE-14261-branch-1.patch, > HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch, > HBASE-14261.branch-1_v2.patch > > > One of the shortcomings of existing ChaosMonkey framework is lack of fault > injections for hbase dependencies like zookeeper, hdfs etc. This patch > attempts to solve this problem partially by adding datanode and zk node fault > injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14727794#comment-14727794 ] Srikanth Srungarapu commented on HBASE-14261: - Thanks, [~dimaspivak]. [~enis], you okay with the latest draft? > Enhance Chaos Monkey framework by adding zookeeper and datanode fault > injections. > - > > Key: HBASE-14261 > URL: https://issues.apache.org/jira/browse/HBASE-14261 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu > Attachments: HBASE-14261-branch-1.patch, > HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch, > HBASE-14261.branch-1_v2.patch > > > One of the shortcomings of existing ChaosMonkey framework is lack of fault > injections for hbase dependencies like zookeeper, hdfs etc. This patch > attempts to solve this problem partially by adding datanode and zk node fault > injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14728448#comment-14728448 ] Srikanth Srungarapu commented on HBASE-14261: - Attached the patch for master branch. > Enhance Chaos Monkey framework by adding zookeeper and datanode fault > injections. > - > > Key: HBASE-14261 > URL: https://issues.apache.org/jira/browse/HBASE-14261 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu > Attachments: HBASE-14261-branch-1.patch, > HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch, > HBASE-14261.branch-1_v2.patch, HBASE-14261.patch > > > One of the shortcomings of existing ChaosMonkey framework is lack of fault > injections for hbase dependencies like zookeeper, hdfs etc. This patch > attempts to solve this problem partially by adding datanode and zk node fault > injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srikanth Srungarapu updated HBASE-14261: Attachment: HBASE-14261.patch > Enhance Chaos Monkey framework by adding zookeeper and datanode fault > injections. > - > > Key: HBASE-14261 > URL: https://issues.apache.org/jira/browse/HBASE-14261 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu > Attachments: HBASE-14261-branch-1.patch, > HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch, > HBASE-14261.branch-1_v2.patch, HBASE-14261.patch > > > One of the shortcomings of existing ChaosMonkey framework is lack of fault > injections for hbase dependencies like zookeeper, hdfs etc. This patch > attempts to solve this problem partially by adding datanode and zk node fault > injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[
https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14727772#comment-14727772
]
Srikanth Srungarapu commented on HBASE-14261:
-
The test {{TestStochasticBalancerJmxMetrics}} is passing locally on my box.
> Enhance Chaos Monkey framework by adding zookeeper and datanode fault
> injections.
> -
>
> Key: HBASE-14261
> URL: https://issues.apache.org/jira/browse/HBASE-14261
> Project: HBase
> Issue Type: Improvement
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
> Attachments: HBASE-14261-branch-1.patch,
> HBASE-14261-branch-1_v3.patch, HBASE-14261-branch-1_v4.patch,
> HBASE-14261.branch-1_v2.patch
>
>
> One of the shortcomings of existing ChaosMonkey framework is lack of fault
> injections for hbase dependencies like zookeeper, hdfs etc. This patch
> attempts to solve this problem partially by adding datanode and zk node fault
> injections.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srikanth Srungarapu updated HBASE-14261: Attachment: HBASE-14261-branch-1_v3.patch > Enhance Chaos Monkey framework by adding zookeeper and datanode fault > injections. > - > > Key: HBASE-14261 > URL: https://issues.apache.org/jira/browse/HBASE-14261 > Project: HBase > Issue Type: Improvement >Reporter: Srikanth Srungarapu >Assignee: Srikanth Srungarapu > Attachments: HBASE-14261-branch-1.patch, > HBASE-14261-branch-1_v3.patch, HBASE-14261.branch-1_v2.patch > > > One of the shortcomings of existing ChaosMonkey framework is lack of fault > injections for hbase dependencies like zookeeper, hdfs etc. This patch > attempts to solve this problem partially by adding datanode and zk node fault > injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[
https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14724439#comment-14724439
]
Srikanth Srungarapu commented on HBASE-14261:
-
Attached patch which addresses the feedback.
Thanks [~mbertozzi] for helping with {{DFSClient}} related api discovery.
> Enhance Chaos Monkey framework by adding zookeeper and datanode fault
> injections.
> -
>
> Key: HBASE-14261
> URL: https://issues.apache.org/jira/browse/HBASE-14261
> Project: HBase
> Issue Type: Improvement
>Reporter: Srikanth Srungarapu
>Assignee: Srikanth Srungarapu
> Attachments: HBASE-14261-branch-1.patch,
> HBASE-14261-branch-1_v3.patch, HBASE-14261.branch-1_v2.patch
>
>
> One of the shortcomings of existing ChaosMonkey framework is lack of fault
> injections for hbase dependencies like zookeeper, hdfs etc. This patch
> attempts to solve this problem partially by adding datanode and zk node fault
> injections.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[
https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14718077#comment-14718077
]
Srikanth Srungarapu commented on HBASE-14261:
-
bq. Zookeeper is usually not started by the hbase scripts. At least in our
deployment and testing, it is always the zkServer that is starting the
zookeeper.
Addressed.
bq. I think we can add a concept of service user, and have it as the 6th
argument to the ssh.cmd so that, one can configure the service user per ssh
depending on the service type.
Done.
bq. We have to make killing of datanodes and zk servers optional. Not all
testing needs that.
Introduced {{ServerAndDependenciesKillingMonkeyFactory}} in case if you want to
include zk and datanode related faults.
bq. This assumes that the zookeeper cluster is on the same nodes as the hbase
cluster which won't work for cluster sizes 3.
Currently, zk nodes are being read using {{ZKServerTool}} and the actions get
triggered on those nodes pointed to by the output. Not sure what exactly was
being pointed to here.
Enhance Chaos Monkey framework by adding zookeeper and datanode fault
injections.
-
Key: HBASE-14261
URL: https://issues.apache.org/jira/browse/HBASE-14261
Project: HBase
Issue Type: Improvement
Reporter: Srikanth Srungarapu
Assignee: Srikanth Srungarapu
Attachments: HBASE-14261-branch-1.patch, HBASE-14261.branch-1_v2.patch
One of the shortcomings of existing ChaosMonkey framework is lack of fault
injections for hbase dependencies like zookeeper, hdfs etc. This patch
attempts to solve this problem partially by adding datanode and zk node fault
injections.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srikanth Srungarapu updated HBASE-14261: Attachment: HBASE-14261.branch-1_v2.patch Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections. - Key: HBASE-14261 URL: https://issues.apache.org/jira/browse/HBASE-14261 Project: HBase Issue Type: Improvement Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Attachments: HBASE-14261-branch-1.patch, HBASE-14261.branch-1_v2.patch One of the shortcomings of existing ChaosMonkey framework is lack of fault injections for hbase dependencies like zookeeper, hdfs etc. This patch attempts to solve this problem partially by adding datanode and zk node fault injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-13562) Rejigger AC tests and expand testing coverage for master/RS ops to include all scope and permissoin combinations.
[ https://issues.apache.org/jira/browse/HBASE-13562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srikanth Srungarapu updated HBASE-13562: Resolution: Later Status: Resolved (was: Patch Available) Rejigger AC tests and expand testing coverage for master/RS ops to include all scope and permissoin combinations. - Key: HBASE-13562 URL: https://issues.apache.org/jira/browse/HBASE-13562 Project: HBase Issue Type: Improvement Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Attachments: HBASE-13562-v1.patch, HBASE-13562-v2.patch, HBASE-13562.patch, HBASE-13562_v2.patch, sample.patch As of now, the tests in TestAccessController and TestAccessController2 doesn't cover all the combinations of Scope and Permissions. Ideally, we should have testing coverage for the entire [ACL matrix|https://hbase.apache.org/book/appendix_acl_matrix.html]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14705891#comment-14705891 ] Srikanth Srungarapu commented on HBASE-14261: - Thanks [~enis] for the review. I'll post the new patch soon. Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections. - Key: HBASE-14261 URL: https://issues.apache.org/jira/browse/HBASE-14261 Project: HBase Issue Type: Improvement Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Attachments: HBASE-14261-branch-1.patch One of the shortcomings of existing ChaosMonkey framework is lack of fault injections for hbase dependencies like zookeeper, hdfs etc. This patch attempts to solve this problem partially by adding datanode and zk node fault injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srikanth Srungarapu updated HBASE-14261: Status: Patch Available (was: Open) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections. - Key: HBASE-14261 URL: https://issues.apache.org/jira/browse/HBASE-14261 Project: HBase Issue Type: Improvement Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Attachments: HBASE-14261-branch-1.patch One of the shortcomings of existing ChaosMonkey framework is lack of fault injections for hbase dependencies like zookeeper, hdfs etc. This patch attempts to solve this problem partially by adding datanode and zk node fault injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
[ https://issues.apache.org/jira/browse/HBASE-14261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srikanth Srungarapu updated HBASE-14261: Attachment: HBASE-14261-branch-1.patch Tested the patch on 3 node cluster. Looks like fault injections are working as expected. Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections. - Key: HBASE-14261 URL: https://issues.apache.org/jira/browse/HBASE-14261 Project: HBase Issue Type: Improvement Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Attachments: HBASE-14261-branch-1.patch One of the shortcomings of existing ChaosMonkey framework is lack of fault injections for hbase dependencies like zookeeper, hdfs etc. This patch attempts to solve this problem partially by adding datanode and zk node fault injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-14261) Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections.
Srikanth Srungarapu created HBASE-14261: --- Summary: Enhance Chaos Monkey framework by adding zookeeper and datanode fault injections. Key: HBASE-14261 URL: https://issues.apache.org/jira/browse/HBASE-14261 Project: HBase Issue Type: Improvement Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu One of the shortcomings of existing ChaosMonkey framework is lack of fault injections for hbase dependencies like zookeeper, hdfs etc. This patch attempts to solve this problem partially by adding datanode and zk node fault injections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14210) Create test for cell level ACLs involving user group
[ https://issues.apache.org/jira/browse/HBASE-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700956#comment-14700956 ] Srikanth Srungarapu commented on HBASE-14210: - +1 lgtm. Thanks, Ashish! [~te...@apache.org] Are you planning to commit the patch? Create test for cell level ACLs involving user group Key: HBASE-14210 URL: https://issues.apache.org/jira/browse/HBASE-14210 Project: HBase Issue Type: Test Reporter: Ted Yu Assignee: Ashish Singhi Attachments: HBASE-14210-v1.patch, HBASE-14210-v2.patch, HBASE-14210-v3.patch, HBASE-14210.patch Currently we have TestCellACLs and TestCellACLWithMultipleVersions which exercise cell level ACLs for users. However, test for cell level ACLs involving user group is missing. This issue is to add such test(s) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14210) Create test for cell level ACLs involving user group
[ https://issues.apache.org/jira/browse/HBASE-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701983#comment-14701983 ] Srikanth Srungarapu commented on HBASE-14210: - Please go ahead. Thanks! Create test for cell level ACLs involving user group Key: HBASE-14210 URL: https://issues.apache.org/jira/browse/HBASE-14210 Project: HBase Issue Type: Test Reporter: Ted Yu Assignee: Ashish Singhi Attachments: HBASE-14210-0.98.patch, HBASE-14210-branch-1.patch, HBASE-14210-v1.patch, HBASE-14210-v2.patch, HBASE-14210-v3.patch, HBASE-14210.patch Currently we have TestCellACLs and TestCellACLWithMultipleVersions which exercise cell level ACLs for users. However, test for cell level ACLs involving user group is missing. This issue is to add such test(s) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14210) Create test for cell level ACLs involving user group
[
https://issues.apache.org/jira/browse/HBASE-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14699233#comment-14699233
]
Srikanth Srungarapu commented on HBASE-14210:
-
Patch lgtm overall. Some minor nits:
The name {{usersAndGroups}} is a bit misleading as it only covers {{USER_OTHER}}
May be, you can use {{user.getShortName}} in the fail message.
{code}
-fail(user2 can not do the delete);
+fail(user + can not do the delete);
{code}
Any chance of changing the variable name of {{permsU2_GUandOwner}}?
Create test for cell level ACLs involving user group
Key: HBASE-14210
URL: https://issues.apache.org/jira/browse/HBASE-14210
Project: HBase
Issue Type: Test
Reporter: Ted Yu
Assignee: Ashish Singhi
Attachments: HBASE-14210-v1.patch, HBASE-14210-v2.patch,
HBASE-14210.patch
Currently we have TestCellACLs and TestCellACLWithMultipleVersions which
exercise cell level ACLs for users.
However, test for cell level ACLs involving user group is missing.
This issue is to add such test(s)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13062) Add documentation coverage for configuring dns server with thrift and rest gateways
[ https://issues.apache.org/jira/browse/HBASE-13062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14681414#comment-14681414 ] Srikanth Srungarapu commented on HBASE-13062: - +1 Perfect. Add documentation coverage for configuring dns server with thrift and rest gateways --- Key: HBASE-13062 URL: https://issues.apache.org/jira/browse/HBASE-13062 Project: HBase Issue Type: Bug Components: documentation Reporter: Srikanth Srungarapu Assignee: Misty Stanley-Jones Priority: Minor Attachments: HBASE-13062-v1.patch, HBASE-13062.patch Currently, the documentation doesn't cover about configuring DNS with thrift or rest gateways, though code base does provide provision for doing so. The following parameters are being used for accomplishing the same. For REST: * hbase.rest.dns.interface * hbase.rest.dns.nameserver For Thrift: * hbase.thrift.dns.interface * hbase.thrift.dns.nameserver -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14205) RegionCoprocessorHost System.nanoTime() performance bottleneck
[ https://issues.apache.org/jira/browse/HBASE-14205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14682264#comment-14682264 ] Srikanth Srungarapu commented on HBASE-14205: - This concern was already brought up in [HBASE-13420|https://issues.apache.org/jira/browse/HBASE-13420]. We couldn't the this feature in 1.0 release line, as it breaks operational compatibility. cc: [~apurtell] RegionCoprocessorHost System.nanoTime() performance bottleneck -- Key: HBASE-14205 URL: https://issues.apache.org/jira/browse/HBASE-14205 Project: HBase Issue Type: Bug Reporter: Jan Van Besien Priority: Critical The tracking of execution time of coprocessor methods introduced in HBASE-11516 introduces 2 calls to System.nanoTime() per coprocessor method per coprocessor. This is resulting in a serious performance bottleneck in certain scenarios. For example consider the scenario where many rows are being ingested (PUT) in a table which has multiple coprocessors (we have up to 20 coprocessors). This results in 8 extra calls to System.nanoTime() per row (prePut, postPut, postStartRegionOperation and postCloseRegionOperation) which has been seen to result in a 50% increase of execution time. I think it is generally considered bad practice to measure execution times on such a small scale (per single operation). Also note that measurements are taken even for coprocessors that do not even have an actual implementation for certain operations, making the problem worse. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-14205) RegionCoprocessorHost System.nanoTime() performance bottleneck
[ https://issues.apache.org/jira/browse/HBASE-14205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14682329#comment-14682329 ] Srikanth Srungarapu commented on HBASE-14205: - bq. We could also turn it off with a config toggle I suppose and see if someone complains about a functional regression. We'd doc in release notes how to turn it back on. In any case, why not just remove this entirely from 1.2 and up? Both suggestions good to me. Just to be sure, for 1.2 and above, the plan is to remove this feature entirely. And for the earlier versions, it is to turn if off with the help of config switch. I'll put up a patch for the same unless anyone has concerns. RegionCoprocessorHost System.nanoTime() performance bottleneck -- Key: HBASE-14205 URL: https://issues.apache.org/jira/browse/HBASE-14205 Project: HBase Issue Type: Bug Reporter: Jan Van Besien Priority: Critical Fix For: 2.0.0, 1.2.0, 1.3.0 The tracking of execution time of coprocessor methods introduced in HBASE-11516 introduces 2 calls to System.nanoTime() per coprocessor method per coprocessor. This is resulting in a serious performance bottleneck in certain scenarios. For example consider the scenario where many rows are being ingested (PUT) in a table which has multiple coprocessors (we have up to 20 coprocessors). This results in 8 extra calls to System.nanoTime() per coprocessor (prePut, postPut, postStartRegionOperation and postCloseRegionOperation) which has in total (i.e. times 20) been seen to result in a 50% increase of execution time. I think it is generally considered bad practice to measure execution times on such a small scale (per single operation). Also note that measurements are taken even for coprocessors that do not even have an actual implementation for certain operations, making the problem worse. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13062) Add documentation coverage for configuring dns server with thrift and rest gateways
[ https://issues.apache.org/jira/browse/HBASE-13062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14681071#comment-14681071 ] Srikanth Srungarapu commented on HBASE-13062: - +1 lgtm. Just minor concern: Like we did in http://hbase.apache.org/book.html#_running_canary_in_a_kerberos_enabled_cluster, can we use default for value field? Add documentation coverage for configuring dns server with thrift and rest gateways --- Key: HBASE-13062 URL: https://issues.apache.org/jira/browse/HBASE-13062 Project: HBase Issue Type: Bug Components: documentation Reporter: Srikanth Srungarapu Assignee: Misty Stanley-Jones Priority: Minor Attachments: HBASE-13062.patch Currently, the documentation doesn't cover about configuring DNS with thrift or rest gateways, though code base does provide provision for doing so. The following parameters are being used for accomplishing the same. For REST: * hbase.rest.dns.interface * hbase.rest.dns.nameserver For Thrift: * hbase.thrift.dns.interface * hbase.thrift.dns.nameserver -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14162) Fixing maven target for regenerating thrift classes fails against 0.9.2
[
https://issues.apache.org/jira/browse/HBASE-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Srikanth Srungarapu updated HBASE-14162:
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Fixing maven target for regenerating thrift classes fails against 0.9.2
---
Key: HBASE-14162
URL: https://issues.apache.org/jira/browse/HBASE-14162
Project: HBase
Issue Type: Bug
Components: build, Thrift
Affects Versions: 2.0.0, 1.3.0
Reporter: Sean Busbey
Assignee: Srikanth Srungarapu
Priority: Blocker
Fix For: 2.0.0, 1.3.0
Attachments: HBASE-14162-branch-1.patch, HBASE-14162.patch,
HBASE-14162_v2.patch, HBASE-14162_v3.patch
HBASE-14045 updated the thrift version, but our enforcer rule is still
checking 0.9.0.
{code}
$ git checkout master
Switched to branch 'master'
Your branch is up-to-date with 'origin/master'.
$ mvn compile -Pcompile-thrift -DskipTests
[INFO] Scanning for projects...
... SNIP ...
[INFO]
[INFO] Building HBase - Thrift 2.0.0-SNAPSHOT
[INFO]
[INFO]
[INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce) @ hbase-thrift ---
[INFO]
[INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce-thrift-version) @
hbase-thrift ---
[WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireProperty failed
with message:
-
-
[FATAL]
==
[FATAL] HBase Thrift requires the thrift generator version 0.9.0.
[FATAL] Setting it to something else needs to be reviewed for wire and
behavior compatibility.
[FATAL]
==
-
-
[INFO]
[INFO] Reactor Summary:
[INFO]
[INFO] HBase .. SUCCESS [ 2.897
s]
[INFO] HBase - Checkstyle . SUCCESS [ 0.554
s]
[INFO] HBase - Annotations SUCCESS [ 0.940
s]
[INFO] HBase - Protocol ... SUCCESS [ 15.454
s]
[INFO] HBase - Common . SUCCESS [ 8.984
s]
[INFO] HBase - Procedure .. SUCCESS [ 1.982
s]
[INFO] HBase - Client . SUCCESS [ 6.805
s]
[INFO] HBase - Hadoop Compatibility ... SUCCESS [ 0.202
s]
[INFO] HBase - Hadoop Two Compatibility ... SUCCESS [ 1.393
s]
[INFO] HBase - Prefix Tree SUCCESS [ 1.233
s]
[INFO] HBase - Server . SUCCESS [ 13.841
s]
[INFO] HBase - Testing Util ... SUCCESS [ 2.979
s]
[INFO] HBase - Thrift . FAILURE [ 0.234
s]
[INFO] HBase - Shell .. SKIPPED
[INFO] HBase - Integration Tests .. SKIPPED
[INFO] HBase - Examples ... SKIPPED
[INFO] HBase - Rest ... SKIPPED
[INFO] HBase - Assembly ... SKIPPED
[INFO] HBase - Shaded . SKIPPED
[INFO] HBase - Shaded - Client SKIPPED
[INFO] HBase - Shaded - Server SKIPPED
[INFO] Apache HBase - Spark ... SKIPPED
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 01:00 min
[INFO] Finished at: 2015-07-28T12:36:15-05:00
[INFO] Final Memory: 84M/1038M
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-enforcer-plugin:1.3.1:enforce
(enforce-thrift-version) on project hbase-thrift: Some Enforcer rules have
failed. Look above for specific messages explaining why the rule failed. -
[Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR]
[ERROR] After correcting the
[jira] [Commented] (HBASE-14162) Fixing maven target for regenerating thrift classes fails against 0.9.2
[
https://issues.apache.org/jira/browse/HBASE-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14649907#comment-14649907
]
Srikanth Srungarapu commented on HBASE-14162:
-
Sure, let me push v2 changes.
Fixing maven target for regenerating thrift classes fails against 0.9.2
---
Key: HBASE-14162
URL: https://issues.apache.org/jira/browse/HBASE-14162
Project: HBase
Issue Type: Bug
Components: build, Thrift
Affects Versions: 2.0.0, 1.3.0
Reporter: Sean Busbey
Assignee: Srikanth Srungarapu
Priority: Blocker
Fix For: 2.0.0, 1.3.0
Attachments: HBASE-14162-branch-1.patch, HBASE-14162.patch,
HBASE-14162_v2.patch, HBASE-14162_v3.patch
HBASE-14045 updated the thrift version, but our enforcer rule is still
checking 0.9.0.
{code}
$ git checkout master
Switched to branch 'master'
Your branch is up-to-date with 'origin/master'.
$ mvn compile -Pcompile-thrift -DskipTests
[INFO] Scanning for projects...
... SNIP ...
[INFO]
[INFO] Building HBase - Thrift 2.0.0-SNAPSHOT
[INFO]
[INFO]
[INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce) @ hbase-thrift ---
[INFO]
[INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce-thrift-version) @
hbase-thrift ---
[WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireProperty failed
with message:
-
-
[FATAL]
==
[FATAL] HBase Thrift requires the thrift generator version 0.9.0.
[FATAL] Setting it to something else needs to be reviewed for wire and
behavior compatibility.
[FATAL]
==
-
-
[INFO]
[INFO] Reactor Summary:
[INFO]
[INFO] HBase .. SUCCESS [ 2.897
s]
[INFO] HBase - Checkstyle . SUCCESS [ 0.554
s]
[INFO] HBase - Annotations SUCCESS [ 0.940
s]
[INFO] HBase - Protocol ... SUCCESS [ 15.454
s]
[INFO] HBase - Common . SUCCESS [ 8.984
s]
[INFO] HBase - Procedure .. SUCCESS [ 1.982
s]
[INFO] HBase - Client . SUCCESS [ 6.805
s]
[INFO] HBase - Hadoop Compatibility ... SUCCESS [ 0.202
s]
[INFO] HBase - Hadoop Two Compatibility ... SUCCESS [ 1.393
s]
[INFO] HBase - Prefix Tree SUCCESS [ 1.233
s]
[INFO] HBase - Server . SUCCESS [ 13.841
s]
[INFO] HBase - Testing Util ... SUCCESS [ 2.979
s]
[INFO] HBase - Thrift . FAILURE [ 0.234
s]
[INFO] HBase - Shell .. SKIPPED
[INFO] HBase - Integration Tests .. SKIPPED
[INFO] HBase - Examples ... SKIPPED
[INFO] HBase - Rest ... SKIPPED
[INFO] HBase - Assembly ... SKIPPED
[INFO] HBase - Shaded . SKIPPED
[INFO] HBase - Shaded - Client SKIPPED
[INFO] HBase - Shaded - Server SKIPPED
[INFO] Apache HBase - Spark ... SKIPPED
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 01:00 min
[INFO] Finished at: 2015-07-28T12:36:15-05:00
[INFO] Final Memory: 84M/1038M
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-enforcer-plugin:1.3.1:enforce
(enforce-thrift-version) on project hbase-thrift: Some Enforcer rules have
failed. Look above for specific messages explaining why the rule failed. -
[Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR]
[ERROR] After correcting the problems, you can
[jira] [Updated] (HBASE-14162) Fixing maven target for regenerating thrift classes fails against 0.9.2
[
https://issues.apache.org/jira/browse/HBASE-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Srikanth Srungarapu updated HBASE-14162:
Attachment: HBASE-14162_v3.patch
Using the variable thrift.version instead of hard coding version 0.9.2 in v3.
Fixing maven target for regenerating thrift classes fails against 0.9.2
---
Key: HBASE-14162
URL: https://issues.apache.org/jira/browse/HBASE-14162
Project: HBase
Issue Type: Bug
Components: build, Thrift
Affects Versions: 2.0.0, 1.3.0
Reporter: Sean Busbey
Assignee: Srikanth Srungarapu
Priority: Blocker
Fix For: 2.0.0, 1.3.0
Attachments: HBASE-14162-branch-1.patch, HBASE-14162.patch,
HBASE-14162_v2.patch, HBASE-14162_v3.patch
HBASE-14045 updated the thrift version, but our enforcer rule is still
checking 0.9.0.
{code}
$ git checkout master
Switched to branch 'master'
Your branch is up-to-date with 'origin/master'.
$ mvn compile -Pcompile-thrift -DskipTests
[INFO] Scanning for projects...
... SNIP ...
[INFO]
[INFO] Building HBase - Thrift 2.0.0-SNAPSHOT
[INFO]
[INFO]
[INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce) @ hbase-thrift ---
[INFO]
[INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce-thrift-version) @
hbase-thrift ---
[WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireProperty failed
with message:
-
-
[FATAL]
==
[FATAL] HBase Thrift requires the thrift generator version 0.9.0.
[FATAL] Setting it to something else needs to be reviewed for wire and
behavior compatibility.
[FATAL]
==
-
-
[INFO]
[INFO] Reactor Summary:
[INFO]
[INFO] HBase .. SUCCESS [ 2.897
s]
[INFO] HBase - Checkstyle . SUCCESS [ 0.554
s]
[INFO] HBase - Annotations SUCCESS [ 0.940
s]
[INFO] HBase - Protocol ... SUCCESS [ 15.454
s]
[INFO] HBase - Common . SUCCESS [ 8.984
s]
[INFO] HBase - Procedure .. SUCCESS [ 1.982
s]
[INFO] HBase - Client . SUCCESS [ 6.805
s]
[INFO] HBase - Hadoop Compatibility ... SUCCESS [ 0.202
s]
[INFO] HBase - Hadoop Two Compatibility ... SUCCESS [ 1.393
s]
[INFO] HBase - Prefix Tree SUCCESS [ 1.233
s]
[INFO] HBase - Server . SUCCESS [ 13.841
s]
[INFO] HBase - Testing Util ... SUCCESS [ 2.979
s]
[INFO] HBase - Thrift . FAILURE [ 0.234
s]
[INFO] HBase - Shell .. SKIPPED
[INFO] HBase - Integration Tests .. SKIPPED
[INFO] HBase - Examples ... SKIPPED
[INFO] HBase - Rest ... SKIPPED
[INFO] HBase - Assembly ... SKIPPED
[INFO] HBase - Shaded . SKIPPED
[INFO] HBase - Shaded - Client SKIPPED
[INFO] HBase - Shaded - Server SKIPPED
[INFO] Apache HBase - Spark ... SKIPPED
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 01:00 min
[INFO] Finished at: 2015-07-28T12:36:15-05:00
[INFO] Final Memory: 84M/1038M
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-enforcer-plugin:1.3.1:enforce
(enforce-thrift-version) on project hbase-thrift: Some Enforcer rules have
failed. Look above for specific messages explaining why the rule failed. -
[Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR]
[ERROR] After
[jira] [Commented] (HBASE-14169) API to refreshSuperUserGroupsConfiguration
[
https://issues.apache.org/jira/browse/HBASE-14169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14648498#comment-14648498
]
Srikanth Srungarapu commented on HBASE-14169:
-
Agree with Matteo's point. And also, allowing global admin to refresh super
user groups can introduce vulnerability as it introduces the possibility for
global admin to gain super user privileges.
{code}
requirePermission(refreshSuperUserGroupsConf, Action.ADMIN);
{code}
Also, we have new class {{SuperUsers}} which encapsulates the code related to
super user configurations. You might want to move some changes over to there.
API to refreshSuperUserGroupsConfiguration
--
Key: HBASE-14169
URL: https://issues.apache.org/jira/browse/HBASE-14169
Project: HBase
Issue Type: New Feature
Reporter: Francis Liu
Assignee: Francis Liu
Attachments: HBASE-14169.patch
For deployments that use security. User impersonation (AKA doAs()) is needed
for some services (ie Stargate, thriftserver, Oozie, etc). Impersonation
definitions are defined in a xml config file and read and cached by the
ProxyUsers class. Calling this api will refresh cached information,
eliminating the need to restart the master/regionserver whenever the
configuration is changed.
Implementation just adds another method to AccessControlService.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (HBASE-14172) Upgrade existing thrift binding using thrift 0.9.2 compiler.
Srikanth Srungarapu created HBASE-14172: --- Summary: Upgrade existing thrift binding using thrift 0.9.2 compiler. Key: HBASE-14172 URL: https://issues.apache.org/jira/browse/HBASE-14172 Project: HBase Issue Type: Improvement Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Priority: Minor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14172) Upgrade existing thrift binding using thrift 0.9.2 compiler.
[ https://issues.apache.org/jira/browse/HBASE-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srikanth Srungarapu updated HBASE-14172: Attachment: HBASE-14172.patch Upgrade existing thrift binding using thrift 0.9.2 compiler. Key: HBASE-14172 URL: https://issues.apache.org/jira/browse/HBASE-14172 Project: HBase Issue Type: Improvement Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Priority: Minor Attachments: HBASE-14172.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14172) Upgrade existing thrift binding using thrift 0.9.2 compiler.
[ https://issues.apache.org/jira/browse/HBASE-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srikanth Srungarapu updated HBASE-14172: Status: Patch Available (was: Open) Upgrade existing thrift binding using thrift 0.9.2 compiler. Key: HBASE-14172 URL: https://issues.apache.org/jira/browse/HBASE-14172 Project: HBase Issue Type: Improvement Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Priority: Minor Attachments: HBASE-14172-branch-1.patch, HBASE-14172.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14172) Upgrade existing thrift binding using thrift 0.9.2 compiler.
[ https://issues.apache.org/jira/browse/HBASE-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srikanth Srungarapu updated HBASE-14172: Attachment: HBASE-14172-branch-1.patch Upgrade existing thrift binding using thrift 0.9.2 compiler. Key: HBASE-14172 URL: https://issues.apache.org/jira/browse/HBASE-14172 Project: HBase Issue Type: Improvement Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Priority: Minor Attachments: HBASE-14172-branch-1.patch, HBASE-14172.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14162) Fixing maven target for regenerating thrift classes fails against 0.9.2
[
https://issues.apache.org/jira/browse/HBASE-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Srikanth Srungarapu updated HBASE-14162:
Attachment: HBASE-14162_v2.patch
Attaching the patch for fixing only maven target. Will create a separate jira
for updating thrift bindings.
Fixing maven target for regenerating thrift classes fails against 0.9.2
---
Key: HBASE-14162
URL: https://issues.apache.org/jira/browse/HBASE-14162
Project: HBase
Issue Type: Bug
Components: build, Thrift
Affects Versions: 2.0.0, 1.3.0
Reporter: Sean Busbey
Assignee: Srikanth Srungarapu
Priority: Blocker
Fix For: 2.0.0, 1.3.0
Attachments: HBASE-14162-branch-1.patch, HBASE-14162.patch,
HBASE-14162_v2.patch
HBASE-14045 updated the thrift version, but our enforcer rule is still
checking 0.9.0.
{code}
$ git checkout master
Switched to branch 'master'
Your branch is up-to-date with 'origin/master'.
$ mvn compile -Pcompile-thrift -DskipTests
[INFO] Scanning for projects...
... SNIP ...
[INFO]
[INFO] Building HBase - Thrift 2.0.0-SNAPSHOT
[INFO]
[INFO]
[INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce) @ hbase-thrift ---
[INFO]
[INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce-thrift-version) @
hbase-thrift ---
[WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireProperty failed
with message:
-
-
[FATAL]
==
[FATAL] HBase Thrift requires the thrift generator version 0.9.0.
[FATAL] Setting it to something else needs to be reviewed for wire and
behavior compatibility.
[FATAL]
==
-
-
[INFO]
[INFO] Reactor Summary:
[INFO]
[INFO] HBase .. SUCCESS [ 2.897
s]
[INFO] HBase - Checkstyle . SUCCESS [ 0.554
s]
[INFO] HBase - Annotations SUCCESS [ 0.940
s]
[INFO] HBase - Protocol ... SUCCESS [ 15.454
s]
[INFO] HBase - Common . SUCCESS [ 8.984
s]
[INFO] HBase - Procedure .. SUCCESS [ 1.982
s]
[INFO] HBase - Client . SUCCESS [ 6.805
s]
[INFO] HBase - Hadoop Compatibility ... SUCCESS [ 0.202
s]
[INFO] HBase - Hadoop Two Compatibility ... SUCCESS [ 1.393
s]
[INFO] HBase - Prefix Tree SUCCESS [ 1.233
s]
[INFO] HBase - Server . SUCCESS [ 13.841
s]
[INFO] HBase - Testing Util ... SUCCESS [ 2.979
s]
[INFO] HBase - Thrift . FAILURE [ 0.234
s]
[INFO] HBase - Shell .. SKIPPED
[INFO] HBase - Integration Tests .. SKIPPED
[INFO] HBase - Examples ... SKIPPED
[INFO] HBase - Rest ... SKIPPED
[INFO] HBase - Assembly ... SKIPPED
[INFO] HBase - Shaded . SKIPPED
[INFO] HBase - Shaded - Client SKIPPED
[INFO] HBase - Shaded - Server SKIPPED
[INFO] Apache HBase - Spark ... SKIPPED
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 01:00 min
[INFO] Finished at: 2015-07-28T12:36:15-05:00
[INFO] Final Memory: 84M/1038M
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-enforcer-plugin:1.3.1:enforce
(enforce-thrift-version) on project hbase-thrift: Some Enforcer rules have
failed. Look above for specific messages explaining why the rule failed. -
[Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR]
[ERROR]
[jira] [Updated] (HBASE-14097) Log link to client scan troubleshooting section when scanner exceptions happen.
[ https://issues.apache.org/jira/browse/HBASE-14097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srikanth Srungarapu updated HBASE-14097: Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 1.3.0 2.0.0 Status: Resolved (was: Patch Available) Pushed to 1.3+ branches. Thanks for spending your valuable time in reviewing this minor issue, Matteo! Log link to client scan troubleshooting section when scanner exceptions happen. --- Key: HBASE-14097 URL: https://issues.apache.org/jira/browse/HBASE-14097 Project: HBase Issue Type: Improvement Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Priority: Trivial Fix For: 2.0.0, 1.3.0 Attachments: HBASE-14097.patch As per description. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14057) HBase shell user_permission should list super users defined on hbase-site.xml
[
https://issues.apache.org/jira/browse/HBASE-14057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Srikanth Srungarapu updated HBASE-14057:
Status: Patch Available (was: In Progress)
HBase shell user_permission should list super users defined on hbase-site.xml
-
Key: HBASE-14057
URL: https://issues.apache.org/jira/browse/HBASE-14057
Project: HBase
Issue Type: Task
Components: shell
Affects Versions: 1.0.1
Reporter: Wellington Chevreuil
Assignee: Srikanth Srungarapu
Priority: Minor
Attachments: HBASE-14057-branch-1.patch, HBASE-14057.patch
On HBase Shell, user_permission command without specifying any user lists all
users granted global permissions (grant 'user', 'RWXCA'):
{noformat}
hbase(main):008:0* user_permission
User
Namespace,Table,Family,Qualifier:Permission
@hbase-admin hbase,hbase:acl,,:
[Permission: actions=READ,WRITE,EXEC,CREATE,ADMIN]
1 row(s) in 3.1710 seconds
{noformat}
Users defined as super users on hbase-site.xml configuration file are not
listed by this same command, even though a super user has the same
permissions/privileges as those defined through grant 'user', 'RWXCA'
command on the shell:
{noformat}
property
namehbase.superuser/name
valuehbase-user/value
/property
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14157) Interfaces implemented by subclasses should be checked when registering CoprocessorService
[
https://issues.apache.org/jira/browse/HBASE-14157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14644781#comment-14644781
]
Srikanth Srungarapu commented on HBASE-14157:
-
+1 lgtm.
Interfaces implemented by subclasses should be checked when registering
CoprocessorService
--
Key: HBASE-14157
URL: https://issues.apache.org/jira/browse/HBASE-14157
Project: HBase
Issue Type: Bug
Reporter: Alok Lal
Assignee: Ted Yu
Fix For: 2.0.0, 1.2.0, 1.1.2, 1.3.0
Attachments: 14157-v1.txt, 14157-v2.txt, 14157-v2.txt, 14157-v3.txt,
14157-v4.txt
Alok reported seeing the following exception when subclass of class which
implements CoprocessorService is used for hbase.coprocessor.region.classes :
{code}
hbase(main):015:0 grant 'mktg1', 'RWC', 'iemployee'
ERROR: org.apache.hadoop.hbase.exceptions.UnknownProtocolException: No
registered coprocessor service found for name AccessControlService in region
hbase:acl,,1437137157604.2daf735ea38da95e9ba249db6b63b79c.
at
org.apache.hadoop.hbase.regionserver.HRegion.execService(HRegion.java:7367)
at
org.apache.hadoop.hbase.regionserver.RSRpcServices.execServiceOnRegion(RSRpcServices.java:1873)
at
org.apache.hadoop.hbase.regionserver.RSRpcServices.execService(RSRpcServices.java:1855)
at
org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:32209)
at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2112)
at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:101)
at
org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(RpcExecutor.java:130)
at org.apache.hadoop.hbase.ipc.RpcExecutor$1.run(RpcExecutor.java:107)
{code}
The root cause is in the following code of RegionCoprocessorHost:
{code}
for (Class? c : implClass.getInterfaces()) {
if (CoprocessorService.class.isAssignableFrom(c)) {
region.registerService( ((CoprocessorService)instance).getService() );
}
}
{code}
We currently only check the interfaces directly implemented by the underlying
class.
What should be done is to check all the interfaces implemented by class
itself and its superclasses.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14057) HBase shell user_permission should list super users defined on hbase-site.xml
[
https://issues.apache.org/jira/browse/HBASE-14057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Srikanth Srungarapu updated HBASE-14057:
Resolution: Fixed
Hadoop Flags: Reviewed
Fix Version/s: 1.3.0
2.0.0
Status: Resolved (was: Patch Available)
Committed to 1.3+ branches.
HBase shell user_permission should list super users defined on hbase-site.xml
-
Key: HBASE-14057
URL: https://issues.apache.org/jira/browse/HBASE-14057
Project: HBase
Issue Type: Task
Components: shell
Affects Versions: 1.0.1
Reporter: Wellington Chevreuil
Assignee: Srikanth Srungarapu
Priority: Minor
Fix For: 2.0.0, 1.3.0
Attachments: HBASE-14057-branch-1.patch, HBASE-14057.patch
On HBase Shell, user_permission command without specifying any user lists all
users granted global permissions (grant 'user', 'RWXCA'):
{noformat}
hbase(main):008:0* user_permission
User
Namespace,Table,Family,Qualifier:Permission
@hbase-admin hbase,hbase:acl,,:
[Permission: actions=READ,WRITE,EXEC,CREATE,ADMIN]
1 row(s) in 3.1710 seconds
{noformat}
Users defined as super users on hbase-site.xml configuration file are not
listed by this same command, even though a super user has the same
permissions/privileges as those defined through grant 'user', 'RWXCA'
command on the shell:
{noformat}
property
namehbase.superuser/name
valuehbase-user/value
/property
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14162) regenerating thrift classes fails against 0.9.2
[
https://issues.apache.org/jira/browse/HBASE-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Srikanth Srungarapu updated HBASE-14162:
Status: Patch Available (was: Open)
regenerating thrift classes fails against 0.9.2
---
Key: HBASE-14162
URL: https://issues.apache.org/jira/browse/HBASE-14162
Project: HBase
Issue Type: Bug
Components: build, Thrift
Affects Versions: 2.0.0, 1.3.0
Reporter: Sean Busbey
Assignee: Srikanth Srungarapu
Priority: Blocker
Fix For: 2.0.0, 1.3.0
Attachments: HBASE-14162.patch
HBASE-14045 updated the thrift version, but our enforcer rule is still
checking 0.9.0.
{code}
$ git checkout master
Switched to branch 'master'
Your branch is up-to-date with 'origin/master'.
$ mvn compile -Pcompile-thrift -DskipTests
[INFO] Scanning for projects...
... SNIP ...
[INFO]
[INFO] Building HBase - Thrift 2.0.0-SNAPSHOT
[INFO]
[INFO]
[INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce) @ hbase-thrift ---
[INFO]
[INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce-thrift-version) @
hbase-thrift ---
[WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireProperty failed
with message:
-
-
[FATAL]
==
[FATAL] HBase Thrift requires the thrift generator version 0.9.0.
[FATAL] Setting it to something else needs to be reviewed for wire and
behavior compatibility.
[FATAL]
==
-
-
[INFO]
[INFO] Reactor Summary:
[INFO]
[INFO] HBase .. SUCCESS [ 2.897
s]
[INFO] HBase - Checkstyle . SUCCESS [ 0.554
s]
[INFO] HBase - Annotations SUCCESS [ 0.940
s]
[INFO] HBase - Protocol ... SUCCESS [ 15.454
s]
[INFO] HBase - Common . SUCCESS [ 8.984
s]
[INFO] HBase - Procedure .. SUCCESS [ 1.982
s]
[INFO] HBase - Client . SUCCESS [ 6.805
s]
[INFO] HBase - Hadoop Compatibility ... SUCCESS [ 0.202
s]
[INFO] HBase - Hadoop Two Compatibility ... SUCCESS [ 1.393
s]
[INFO] HBase - Prefix Tree SUCCESS [ 1.233
s]
[INFO] HBase - Server . SUCCESS [ 13.841
s]
[INFO] HBase - Testing Util ... SUCCESS [ 2.979
s]
[INFO] HBase - Thrift . FAILURE [ 0.234
s]
[INFO] HBase - Shell .. SKIPPED
[INFO] HBase - Integration Tests .. SKIPPED
[INFO] HBase - Examples ... SKIPPED
[INFO] HBase - Rest ... SKIPPED
[INFO] HBase - Assembly ... SKIPPED
[INFO] HBase - Shaded . SKIPPED
[INFO] HBase - Shaded - Client SKIPPED
[INFO] HBase - Shaded - Server SKIPPED
[INFO] Apache HBase - Spark ... SKIPPED
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 01:00 min
[INFO] Finished at: 2015-07-28T12:36:15-05:00
[INFO] Final Memory: 84M/1038M
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-enforcer-plugin:1.3.1:enforce
(enforce-thrift-version) on project hbase-thrift: Some Enforcer rules have
failed. Look above for specific messages explaining why the rule failed. -
[Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the
command
[ERROR] mvn goals -rf :hbase-thrift
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14162) regenerating thrift classes fails against 0.9.2
[
https://issues.apache.org/jira/browse/HBASE-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Srikanth Srungarapu updated HBASE-14162:
Attachment: HBASE-14162.patch
The command I used for generating thrift bindings for 0.9.2 is:
{{mvn compile -Pcompile-thrift -Dthrift.path=/usr/local/bin/thrift}}
regenerating thrift classes fails against 0.9.2
---
Key: HBASE-14162
URL: https://issues.apache.org/jira/browse/HBASE-14162
Project: HBase
Issue Type: Bug
Components: build, Thrift
Affects Versions: 2.0.0, 1.3.0
Reporter: Sean Busbey
Assignee: Srikanth Srungarapu
Priority: Blocker
Fix For: 2.0.0, 1.3.0
Attachments: HBASE-14162.patch
HBASE-14045 updated the thrift version, but our enforcer rule is still
checking 0.9.0.
{code}
$ git checkout master
Switched to branch 'master'
Your branch is up-to-date with 'origin/master'.
$ mvn compile -Pcompile-thrift -DskipTests
[INFO] Scanning for projects...
... SNIP ...
[INFO]
[INFO] Building HBase - Thrift 2.0.0-SNAPSHOT
[INFO]
[INFO]
[INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce) @ hbase-thrift ---
[INFO]
[INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce-thrift-version) @
hbase-thrift ---
[WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireProperty failed
with message:
-
-
[FATAL]
==
[FATAL] HBase Thrift requires the thrift generator version 0.9.0.
[FATAL] Setting it to something else needs to be reviewed for wire and
behavior compatibility.
[FATAL]
==
-
-
[INFO]
[INFO] Reactor Summary:
[INFO]
[INFO] HBase .. SUCCESS [ 2.897
s]
[INFO] HBase - Checkstyle . SUCCESS [ 0.554
s]
[INFO] HBase - Annotations SUCCESS [ 0.940
s]
[INFO] HBase - Protocol ... SUCCESS [ 15.454
s]
[INFO] HBase - Common . SUCCESS [ 8.984
s]
[INFO] HBase - Procedure .. SUCCESS [ 1.982
s]
[INFO] HBase - Client . SUCCESS [ 6.805
s]
[INFO] HBase - Hadoop Compatibility ... SUCCESS [ 0.202
s]
[INFO] HBase - Hadoop Two Compatibility ... SUCCESS [ 1.393
s]
[INFO] HBase - Prefix Tree SUCCESS [ 1.233
s]
[INFO] HBase - Server . SUCCESS [ 13.841
s]
[INFO] HBase - Testing Util ... SUCCESS [ 2.979
s]
[INFO] HBase - Thrift . FAILURE [ 0.234
s]
[INFO] HBase - Shell .. SKIPPED
[INFO] HBase - Integration Tests .. SKIPPED
[INFO] HBase - Examples ... SKIPPED
[INFO] HBase - Rest ... SKIPPED
[INFO] HBase - Assembly ... SKIPPED
[INFO] HBase - Shaded . SKIPPED
[INFO] HBase - Shaded - Client SKIPPED
[INFO] HBase - Shaded - Server SKIPPED
[INFO] Apache HBase - Spark ... SKIPPED
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 01:00 min
[INFO] Finished at: 2015-07-28T12:36:15-05:00
[INFO] Final Memory: 84M/1038M
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-enforcer-plugin:1.3.1:enforce
(enforce-thrift-version) on project hbase-thrift: Some Enforcer rules have
failed. Look above for specific messages explaining why the rule failed. -
[Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the
command
[jira] [Updated] (HBASE-14162) regenerating thrift classes fails against 0.9.2
[
https://issues.apache.org/jira/browse/HBASE-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Srikanth Srungarapu updated HBASE-14162:
Attachment: HBASE-14162-branch-1.patch
regenerating thrift classes fails against 0.9.2
---
Key: HBASE-14162
URL: https://issues.apache.org/jira/browse/HBASE-14162
Project: HBase
Issue Type: Bug
Components: build, Thrift
Affects Versions: 2.0.0, 1.3.0
Reporter: Sean Busbey
Assignee: Srikanth Srungarapu
Priority: Blocker
Fix For: 2.0.0, 1.3.0
Attachments: HBASE-14162-branch-1.patch, HBASE-14162.patch
HBASE-14045 updated the thrift version, but our enforcer rule is still
checking 0.9.0.
{code}
$ git checkout master
Switched to branch 'master'
Your branch is up-to-date with 'origin/master'.
$ mvn compile -Pcompile-thrift -DskipTests
[INFO] Scanning for projects...
... SNIP ...
[INFO]
[INFO] Building HBase - Thrift 2.0.0-SNAPSHOT
[INFO]
[INFO]
[INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce) @ hbase-thrift ---
[INFO]
[INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce-thrift-version) @
hbase-thrift ---
[WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireProperty failed
with message:
-
-
[FATAL]
==
[FATAL] HBase Thrift requires the thrift generator version 0.9.0.
[FATAL] Setting it to something else needs to be reviewed for wire and
behavior compatibility.
[FATAL]
==
-
-
[INFO]
[INFO] Reactor Summary:
[INFO]
[INFO] HBase .. SUCCESS [ 2.897
s]
[INFO] HBase - Checkstyle . SUCCESS [ 0.554
s]
[INFO] HBase - Annotations SUCCESS [ 0.940
s]
[INFO] HBase - Protocol ... SUCCESS [ 15.454
s]
[INFO] HBase - Common . SUCCESS [ 8.984
s]
[INFO] HBase - Procedure .. SUCCESS [ 1.982
s]
[INFO] HBase - Client . SUCCESS [ 6.805
s]
[INFO] HBase - Hadoop Compatibility ... SUCCESS [ 0.202
s]
[INFO] HBase - Hadoop Two Compatibility ... SUCCESS [ 1.393
s]
[INFO] HBase - Prefix Tree SUCCESS [ 1.233
s]
[INFO] HBase - Server . SUCCESS [ 13.841
s]
[INFO] HBase - Testing Util ... SUCCESS [ 2.979
s]
[INFO] HBase - Thrift . FAILURE [ 0.234
s]
[INFO] HBase - Shell .. SKIPPED
[INFO] HBase - Integration Tests .. SKIPPED
[INFO] HBase - Examples ... SKIPPED
[INFO] HBase - Rest ... SKIPPED
[INFO] HBase - Assembly ... SKIPPED
[INFO] HBase - Shaded . SKIPPED
[INFO] HBase - Shaded - Client SKIPPED
[INFO] HBase - Shaded - Server SKIPPED
[INFO] Apache HBase - Spark ... SKIPPED
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 01:00 min
[INFO] Finished at: 2015-07-28T12:36:15-05:00
[INFO] Final Memory: 84M/1038M
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-enforcer-plugin:1.3.1:enforce
(enforce-thrift-version) on project hbase-thrift: Some Enforcer rules have
failed. Look above for specific messages explaining why the rule failed. -
[Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the
command
[ERROR] mvn goals -rf :hbase-thrift
{code}
--
This message was sent by Atlassian JIRA
[jira] [Commented] (HBASE-14157) Interfaces implemented by subclasses should be checked when registering CoprocessorService
[
https://issues.apache.org/jira/browse/HBASE-14157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14643896#comment-14643896
]
Srikanth Srungarapu commented on HBASE-14157:
-
bq. cpHost.createEnvironment() is not called in TestAccessController2. This is
why I used TestWithDisabledAuthorization
Agree. You can add the creation of environment steps to TestAccessController2.
Adding fail() method, makes the failures more easier to diagnose. I was looking
for something like this in {{TestAccessController2}}.
{code}
MasterCoprocessorHost cpHost =
TEST_UTIL.getMiniHBaseCluster().getMaster().getMasterCoprocessorHost();
cpHost.load(AccessController.class, Coprocessor.PRIORITY_HIGHEST, conf);
try {
ACCESS_CONTROLLER = (AccessController)
cpHost.findCoprocessor(MyAccessController.class.getName());
CP_ENV = cpHost.createEnvironment(AccessController.class,
ACCESS_CONTROLLER,
Coprocessor.PRIORITY_HIGHEST, 1, conf);
RegionServerCoprocessorHost rsHost =
TEST_UTIL.getMiniHBaseCluster().getRegionServer(0)
.getRegionServerCoprocessorHost();
RSCP_ENV = rsHost.createEnvironment(AccessController.class,
ACCESS_CONTROLLER,
Coprocessor.PRIORITY_HIGHEST, 1, conf);
} catch(Exception e) {
fail(Coprocessor service should have been loaded..);
}
{code}
Interfaces implemented by subclasses should be checked when registering
CoprocessorService
--
Key: HBASE-14157
URL: https://issues.apache.org/jira/browse/HBASE-14157
Project: HBase
Issue Type: Bug
Reporter: Alok Lal
Assignee: Ted Yu
Fix For: 2.0.0, 1.2.0, 1.1.2, 1.3.0
Attachments: 14157-v1.txt, 14157-v2.txt, 14157-v2.txt, 14157-v3.txt
Alok reported seeing the following exception when subclass of class which
implements CoprocessorService is used for hbase.coprocessor.region.classes :
{code}
hbase(main):015:0 grant 'mktg1', 'RWC', 'iemployee'
ERROR: org.apache.hadoop.hbase.exceptions.UnknownProtocolException: No
registered coprocessor service found for name AccessControlService in region
hbase:acl,,1437137157604.2daf735ea38da95e9ba249db6b63b79c.
at
org.apache.hadoop.hbase.regionserver.HRegion.execService(HRegion.java:7367)
at
org.apache.hadoop.hbase.regionserver.RSRpcServices.execServiceOnRegion(RSRpcServices.java:1873)
at
org.apache.hadoop.hbase.regionserver.RSRpcServices.execService(RSRpcServices.java:1855)
at
org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:32209)
at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2112)
at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:101)
at
org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(RpcExecutor.java:130)
at org.apache.hadoop.hbase.ipc.RpcExecutor$1.run(RpcExecutor.java:107)
{code}
The root cause is in the following code of RegionCoprocessorHost:
{code}
for (Class? c : implClass.getInterfaces()) {
if (CoprocessorService.class.isAssignableFrom(c)) {
region.registerService( ((CoprocessorService)instance).getService() );
}
}
{code}
We currently only check the interfaces directly implemented by the underlying
class.
What should be done is to check all the interfaces implemented by class
itself and its superclasses.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14162) regenerating thrift classes fails against 0.9.2
[
https://issues.apache.org/jira/browse/HBASE-14162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14645103#comment-14645103
]
Srikanth Srungarapu commented on HBASE-14162:
-
On second thoughts, should we open a new jira for updating generated thrift
bindings and push only pom related changes as part of this issue?
regenerating thrift classes fails against 0.9.2
---
Key: HBASE-14162
URL: https://issues.apache.org/jira/browse/HBASE-14162
Project: HBase
Issue Type: Bug
Components: build, Thrift
Affects Versions: 2.0.0, 1.3.0
Reporter: Sean Busbey
Assignee: Srikanth Srungarapu
Priority: Blocker
Fix For: 2.0.0, 1.3.0
Attachments: HBASE-14162-branch-1.patch, HBASE-14162.patch
HBASE-14045 updated the thrift version, but our enforcer rule is still
checking 0.9.0.
{code}
$ git checkout master
Switched to branch 'master'
Your branch is up-to-date with 'origin/master'.
$ mvn compile -Pcompile-thrift -DskipTests
[INFO] Scanning for projects...
... SNIP ...
[INFO]
[INFO] Building HBase - Thrift 2.0.0-SNAPSHOT
[INFO]
[INFO]
[INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce) @ hbase-thrift ---
[INFO]
[INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce-thrift-version) @
hbase-thrift ---
[WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireProperty failed
with message:
-
-
[FATAL]
==
[FATAL] HBase Thrift requires the thrift generator version 0.9.0.
[FATAL] Setting it to something else needs to be reviewed for wire and
behavior compatibility.
[FATAL]
==
-
-
[INFO]
[INFO] Reactor Summary:
[INFO]
[INFO] HBase .. SUCCESS [ 2.897
s]
[INFO] HBase - Checkstyle . SUCCESS [ 0.554
s]
[INFO] HBase - Annotations SUCCESS [ 0.940
s]
[INFO] HBase - Protocol ... SUCCESS [ 15.454
s]
[INFO] HBase - Common . SUCCESS [ 8.984
s]
[INFO] HBase - Procedure .. SUCCESS [ 1.982
s]
[INFO] HBase - Client . SUCCESS [ 6.805
s]
[INFO] HBase - Hadoop Compatibility ... SUCCESS [ 0.202
s]
[INFO] HBase - Hadoop Two Compatibility ... SUCCESS [ 1.393
s]
[INFO] HBase - Prefix Tree SUCCESS [ 1.233
s]
[INFO] HBase - Server . SUCCESS [ 13.841
s]
[INFO] HBase - Testing Util ... SUCCESS [ 2.979
s]
[INFO] HBase - Thrift . FAILURE [ 0.234
s]
[INFO] HBase - Shell .. SKIPPED
[INFO] HBase - Integration Tests .. SKIPPED
[INFO] HBase - Examples ... SKIPPED
[INFO] HBase - Rest ... SKIPPED
[INFO] HBase - Assembly ... SKIPPED
[INFO] HBase - Shaded . SKIPPED
[INFO] HBase - Shaded - Client SKIPPED
[INFO] HBase - Shaded - Server SKIPPED
[INFO] Apache HBase - Spark ... SKIPPED
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 01:00 min
[INFO] Finished at: 2015-07-28T12:36:15-05:00
[INFO] Final Memory: 84M/1038M
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-enforcer-plugin:1.3.1:enforce
(enforce-thrift-version) on project hbase-thrift: Some Enforcer rules have
failed. Look above for specific messages explaining why the rule failed. -
[Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR]
[ERROR] After correcting the
[jira] [Commented] (HBASE-14157) Interfaces implemented by subclasses should be checked when registering CoprocessorService
[
https://issues.apache.org/jira/browse/HBASE-14157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14643341#comment-14643341
]
Srikanth Srungarapu commented on HBASE-14157:
-
This looks good. Any chance of implementing unit test ?
Interfaces implemented by subclasses should be checked when registering
CoprocessorService
--
Key: HBASE-14157
URL: https://issues.apache.org/jira/browse/HBASE-14157
Project: HBase
Issue Type: Bug
Reporter: Alok Lal
Assignee: Ted Yu
Attachments: 14157-v1.txt, 14157-v2.txt
Alok reported seeing the following exception when subclass of class which
implements CoprocessorService is used for hbase.coprocessor.region.classes :
{code}
hbase(main):015:0 grant 'mktg1', 'RWC', 'iemployee'
ERROR: org.apache.hadoop.hbase.exceptions.UnknownProtocolException: No
registered coprocessor service found for name AccessControlService in region
hbase:acl,,1437137157604.2daf735ea38da95e9ba249db6b63b79c.
at
org.apache.hadoop.hbase.regionserver.HRegion.execService(HRegion.java:7367)
at
org.apache.hadoop.hbase.regionserver.RSRpcServices.execServiceOnRegion(RSRpcServices.java:1873)
at
org.apache.hadoop.hbase.regionserver.RSRpcServices.execService(RSRpcServices.java:1855)
at
org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:32209)
at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2112)
at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:101)
at
org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(RpcExecutor.java:130)
at org.apache.hadoop.hbase.ipc.RpcExecutor$1.run(RpcExecutor.java:107)
{code}
The root cause is in the following code of RegionCoprocessorHost:
{code}
for (Class? c : implClass.getInterfaces()) {
if (CoprocessorService.class.isAssignableFrom(c)) {
region.registerService( ((CoprocessorService)instance).getService() );
}
}
{code}
We currently only check the interfaces directly implemented by the underlying
class.
What should be done is to check all the interfaces implemented by class
itself and its superclasses.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14157) Interfaces implemented by subclasses should be checked when registering CoprocessorService
[
https://issues.apache.org/jira/browse/HBASE-14157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14643674#comment-14643674
]
Srikanth Srungarapu commented on HBASE-14157:
-
Minor nits:
- Instead of {{TestWithDisabledAuthorization}}, how about moving the checks to
{{TestAccessController2}} (AFAIK, this is where all misc tests go) ?
- And also, please add assertion for checking that no exception is being thrown
when using extended coprocessor.
Interfaces implemented by subclasses should be checked when registering
CoprocessorService
--
Key: HBASE-14157
URL: https://issues.apache.org/jira/browse/HBASE-14157
Project: HBase
Issue Type: Bug
Reporter: Alok Lal
Assignee: Ted Yu
Fix For: 2.0.0, 1.2.0, 1.1.2, 1.3.0
Attachments: 14157-v1.txt, 14157-v2.txt, 14157-v2.txt, 14157-v3.txt
Alok reported seeing the following exception when subclass of class which
implements CoprocessorService is used for hbase.coprocessor.region.classes :
{code}
hbase(main):015:0 grant 'mktg1', 'RWC', 'iemployee'
ERROR: org.apache.hadoop.hbase.exceptions.UnknownProtocolException: No
registered coprocessor service found for name AccessControlService in region
hbase:acl,,1437137157604.2daf735ea38da95e9ba249db6b63b79c.
at
org.apache.hadoop.hbase.regionserver.HRegion.execService(HRegion.java:7367)
at
org.apache.hadoop.hbase.regionserver.RSRpcServices.execServiceOnRegion(RSRpcServices.java:1873)
at
org.apache.hadoop.hbase.regionserver.RSRpcServices.execService(RSRpcServices.java:1855)
at
org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:32209)
at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2112)
at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:101)
at
org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(RpcExecutor.java:130)
at org.apache.hadoop.hbase.ipc.RpcExecutor$1.run(RpcExecutor.java:107)
{code}
The root cause is in the following code of RegionCoprocessorHost:
{code}
for (Class? c : implClass.getInterfaces()) {
if (CoprocessorService.class.isAssignableFrom(c)) {
region.registerService( ((CoprocessorService)instance).getService() );
}
}
{code}
We currently only check the interfaces directly implemented by the underlying
class.
What should be done is to check all the interfaces implemented by class
itself and its superclasses.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14057) HBase shell user_permission should list super users defined on hbase-site.xml
[
https://issues.apache.org/jira/browse/HBASE-14057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Srikanth Srungarapu updated HBASE-14057:
Attachment: HBASE-14057.patch
Attaching patch for master. Seeking blessings from Hadoop QA bot.
HBase shell user_permission should list super users defined on hbase-site.xml
-
Key: HBASE-14057
URL: https://issues.apache.org/jira/browse/HBASE-14057
Project: HBase
Issue Type: Task
Components: shell
Affects Versions: 1.0.1
Reporter: Wellington Chevreuil
Assignee: Srikanth Srungarapu
Priority: Minor
Attachments: HBASE-14057-branch-1.patch, HBASE-14057.patch
On HBase Shell, user_permission command without specifying any user lists all
users granted global permissions (grant 'user', 'RWXCA'):
{noformat}
hbase(main):008:0* user_permission
User
Namespace,Table,Family,Qualifier:Permission
@hbase-admin hbase,hbase:acl,,:
[Permission: actions=READ,WRITE,EXEC,CREATE,ADMIN]
1 row(s) in 3.1710 seconds
{noformat}
Users defined as super users on hbase-site.xml configuration file are not
listed by this same command, even though a super user has the same
permissions/privileges as those defined through grant 'user', 'RWXCA'
command on the shell:
{noformat}
property
namehbase.superuser/name
valuehbase-user/value
/property
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (HBASE-14057) HBase shell user_permission should list super users defined on hbase-site.xml
[
https://issues.apache.org/jira/browse/HBASE-14057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Srikanth Srungarapu reassigned HBASE-14057:
---
Assignee: Srikanth Srungarapu
HBase shell user_permission should list super users defined on hbase-site.xml
-
Key: HBASE-14057
URL: https://issues.apache.org/jira/browse/HBASE-14057
Project: HBase
Issue Type: Task
Components: shell
Affects Versions: 1.0.1
Reporter: Wellington Chevreuil
Assignee: Srikanth Srungarapu
Priority: Minor
Attachments: HBASE-14057.patch
On HBase Shell, user_permission command without specifying any user lists all
users granted global permissions (grant 'user', 'RWXCA'):
{noformat}
hbase(main):008:0* user_permission
User
Namespace,Table,Family,Qualifier:Permission
@hbase-admin hbase,hbase:acl,,:
[Permission: actions=READ,WRITE,EXEC,CREATE,ADMIN]
1 row(s) in 3.1710 seconds
{noformat}
Users defined as super users on hbase-site.xml configuration file are not
listed by this same command, even though a super user has the same
permissions/privileges as those defined through grant 'user', 'RWXCA'
command on the shell:
{noformat}
property
namehbase.superuser/name
valuehbase-user/value
/property
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14057) HBase shell user_permission should list super users defined on hbase-site.xml
[
https://issues.apache.org/jira/browse/HBASE-14057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Srikanth Srungarapu updated HBASE-14057:
Attachment: (was: HBASE-14057.patch)
HBase shell user_permission should list super users defined on hbase-site.xml
-
Key: HBASE-14057
URL: https://issues.apache.org/jira/browse/HBASE-14057
Project: HBase
Issue Type: Task
Components: shell
Affects Versions: 1.0.1
Reporter: Wellington Chevreuil
Assignee: Srikanth Srungarapu
Priority: Minor
Attachments: HBASE-14057-branch-1.patch
On HBase Shell, user_permission command without specifying any user lists all
users granted global permissions (grant 'user', 'RWXCA'):
{noformat}
hbase(main):008:0* user_permission
User
Namespace,Table,Family,Qualifier:Permission
@hbase-admin hbase,hbase:acl,,:
[Permission: actions=READ,WRITE,EXEC,CREATE,ADMIN]
1 row(s) in 3.1710 seconds
{noformat}
Users defined as super users on hbase-site.xml configuration file are not
listed by this same command, even though a super user has the same
permissions/privileges as those defined through grant 'user', 'RWXCA'
command on the shell:
{noformat}
property
namehbase.superuser/name
valuehbase-user/value
/property
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14057) HBase shell user_permission should list super users defined on hbase-site.xml
[
https://issues.apache.org/jira/browse/HBASE-14057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Srikanth Srungarapu updated HBASE-14057:
Attachment: HBASE-14057-branch-1.patch
HBase shell user_permission should list super users defined on hbase-site.xml
-
Key: HBASE-14057
URL: https://issues.apache.org/jira/browse/HBASE-14057
Project: HBase
Issue Type: Task
Components: shell
Affects Versions: 1.0.1
Reporter: Wellington Chevreuil
Assignee: Srikanth Srungarapu
Priority: Minor
Attachments: HBASE-14057-branch-1.patch
On HBase Shell, user_permission command without specifying any user lists all
users granted global permissions (grant 'user', 'RWXCA'):
{noformat}
hbase(main):008:0* user_permission
User
Namespace,Table,Family,Qualifier:Permission
@hbase-admin hbase,hbase:acl,,:
[Permission: actions=READ,WRITE,EXEC,CREATE,ADMIN]
1 row(s) in 3.1710 seconds
{noformat}
Users defined as super users on hbase-site.xml configuration file are not
listed by this same command, even though a super user has the same
permissions/privileges as those defined through grant 'user', 'RWXCA'
command on the shell:
{noformat}
property
namehbase.superuser/name
valuehbase-user/value
/property
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Work started] (HBASE-14057) HBase shell user_permission should list super users defined on hbase-site.xml
[
https://issues.apache.org/jira/browse/HBASE-14057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-14057 started by Srikanth Srungarapu.
---
HBase shell user_permission should list super users defined on hbase-site.xml
-
Key: HBASE-14057
URL: https://issues.apache.org/jira/browse/HBASE-14057
Project: HBase
Issue Type: Task
Components: shell
Affects Versions: 1.0.1
Reporter: Wellington Chevreuil
Assignee: Srikanth Srungarapu
Priority: Minor
Attachments: HBASE-14057-branch-1.patch
On HBase Shell, user_permission command without specifying any user lists all
users granted global permissions (grant 'user', 'RWXCA'):
{noformat}
hbase(main):008:0* user_permission
User
Namespace,Table,Family,Qualifier:Permission
@hbase-admin hbase,hbase:acl,,:
[Permission: actions=READ,WRITE,EXEC,CREATE,ADMIN]
1 row(s) in 3.1710 seconds
{noformat}
Users defined as super users on hbase-site.xml configuration file are not
listed by this same command, even though a super user has the same
permissions/privileges as those defined through grant 'user', 'RWXCA'
command on the shell:
{noformat}
property
namehbase.superuser/name
valuehbase-user/value
/property
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14057) HBase shell user_permission should list super users defined on hbase-site.xml
[
https://issues.apache.org/jira/browse/HBASE-14057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Srikanth Srungarapu updated HBASE-14057:
Attachment: HBASE-14057.patch
HBase shell user_permission should list super users defined on hbase-site.xml
-
Key: HBASE-14057
URL: https://issues.apache.org/jira/browse/HBASE-14057
Project: HBase
Issue Type: Task
Components: shell
Affects Versions: 1.0.1
Reporter: Wellington Chevreuil
Priority: Minor
Attachments: HBASE-14057.patch
On HBase Shell, user_permission command without specifying any user lists all
users granted global permissions (grant 'user', 'RWXCA'):
{noformat}
hbase(main):008:0* user_permission
User
Namespace,Table,Family,Qualifier:Permission
@hbase-admin hbase,hbase:acl,,:
[Permission: actions=READ,WRITE,EXEC,CREATE,ADMIN]
1 row(s) in 3.1710 seconds
{noformat}
Users defined as super users on hbase-site.xml configuration file are not
listed by this same command, even though a super user has the same
permissions/privileges as those defined through grant 'user', 'RWXCA'
command on the shell:
{noformat}
property
namehbase.superuser/name
valuehbase-user/value
/property
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14057) HBase shell user_permission should list super users defined on hbase-site.xml
[
https://issues.apache.org/jira/browse/HBASE-14057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14640030#comment-14640030
]
Srikanth Srungarapu commented on HBASE-14057:
-
Discussed this with [~mbertozzi] offline. The output will be like
{code}
hbase(main):008:0* user_permission
User Namespace,Table,Family,Qualifier:Permission
superuser1hbase,hbase:acl,,: [Permission:
actions=READ,WRITE,EXEC,CREATE]
superuser2hbase,hbase:acl,,: [Permission:
actions=READ,WRITE,EXEC,CREATE]
...
{code}
HBase shell user_permission should list super users defined on hbase-site.xml
-
Key: HBASE-14057
URL: https://issues.apache.org/jira/browse/HBASE-14057
Project: HBase
Issue Type: Task
Components: shell
Affects Versions: 1.0.1
Reporter: Wellington Chevreuil
Assignee: Srikanth Srungarapu
Priority: Minor
Attachments: HBASE-14057-branch-1.patch
On HBase Shell, user_permission command without specifying any user lists all
users granted global permissions (grant 'user', 'RWXCA'):
{noformat}
hbase(main):008:0* user_permission
User
Namespace,Table,Family,Qualifier:Permission
@hbase-admin hbase,hbase:acl,,:
[Permission: actions=READ,WRITE,EXEC,CREATE,ADMIN]
1 row(s) in 3.1710 seconds
{noformat}
Users defined as super users on hbase-site.xml configuration file are not
listed by this same command, even though a super user has the same
permissions/privileges as those defined through grant 'user', 'RWXCA'
command on the shell:
{noformat}
property
namehbase.superuser/name
valuehbase-user/value
/property
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14106) TestProcedureRecovery is flaky
[
https://issues.apache.org/jira/browse/HBASE-14106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14631598#comment-14631598
]
Srikanth Srungarapu commented on HBASE-14106:
-
+1 lgtm. The test errors are unrelated to the patch.
TestProcedureRecovery is flaky
--
Key: HBASE-14106
URL: https://issues.apache.org/jira/browse/HBASE-14106
Project: HBase
Issue Type: Bug
Components: proc-v2, test
Affects Versions: 2.0.0, 1.2.0, 1.1.0.1
Reporter: Andrew Purtell
Assignee: Matteo Bertozzi
Fix For: 2.0.0, 1.2.0, 1.1.2
Attachments: HBASE-14106-v0.patch
Encountered this when running master tests locally using 7u79:
{noformat}
Tests run: 8, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 12.28 sec
FAILURE! - in org.apache.hadoop.hbase.procedure2.TestProcedureRecovery
testRunningProcWithSameNonce(org.apache.hadoop.hbase.procedure2.TestProcedureRecovery)
Time elapsed: 0.318 sec ERROR!
java.lang.IllegalArgumentException: null
at
com.google.common.base.Preconditions.checkArgument(Preconditions.java:76)
at
org.apache.hadoop.hbase.procedure2.ProcedureExecutor.submitProcedure(ProcedureExecutor.java:595)
at
org.apache.hadoop.hbase.procedure2.ProcedureTestingUtility.submitAndWait(ProcedureTestingUtility.java:137)
at
org.apache.hadoop.hbase.procedure2.TestProcedureRecovery.testRunningProcWithSameNonce(TestProcedureRecovery.java:321)
{noformat}
{noformat}
Flaked tests:
org.apache.hadoop.hbase.procedure2.TestProcedureRecovery.testRunningProcWithSameNonce(org.apache.hadoop.hbase.procedure2.TestProcedureRecovery)
Run 1: TestProcedureRecovery.testRunningProcWithSameNonce:321 ยป
IllegalArgument
Run 2: PASS
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (HBASE-14097) Log link to client scan troubleshooting section when scanner exceptions happen.
Srikanth Srungarapu created HBASE-14097: --- Summary: Log link to client scan troubleshooting section when scanner exceptions happen. Key: HBASE-14097 URL: https://issues.apache.org/jira/browse/HBASE-14097 Project: HBase Issue Type: Improvement Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Priority: Trivial -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14097) Log link to client scan troubleshooting section when scanner exceptions happen.
[ https://issues.apache.org/jira/browse/HBASE-14097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srikanth Srungarapu updated HBASE-14097: Status: Patch Available (was: Open) Log link to client scan troubleshooting section when scanner exceptions happen. --- Key: HBASE-14097 URL: https://issues.apache.org/jira/browse/HBASE-14097 Project: HBase Issue Type: Improvement Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Priority: Trivial Attachments: HBASE-14097.patch As per description. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14097) Log link to client scan troubleshooting section when scanner exceptions happen.
[ https://issues.apache.org/jira/browse/HBASE-14097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srikanth Srungarapu updated HBASE-14097: Description: As per description. Log link to client scan troubleshooting section when scanner exceptions happen. --- Key: HBASE-14097 URL: https://issues.apache.org/jira/browse/HBASE-14097 Project: HBase Issue Type: Improvement Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Priority: Trivial As per description. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14097) Log link to client scan troubleshooting section when scanner exceptions happen.
[ https://issues.apache.org/jira/browse/HBASE-14097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Srikanth Srungarapu updated HBASE-14097: Attachment: HBASE-14097.patch Log link to client scan troubleshooting section when scanner exceptions happen. --- Key: HBASE-14097 URL: https://issues.apache.org/jira/browse/HBASE-14097 Project: HBase Issue Type: Improvement Reporter: Srikanth Srungarapu Assignee: Srikanth Srungarapu Priority: Trivial Attachments: HBASE-14097.patch As per description. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-14045) Bumping thrift version to 0.9.2.
[
https://issues.apache.org/jira/browse/HBASE-14045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Srikanth Srungarapu updated HBASE-14045:
Resolution: Fixed
Hadoop Flags: Reviewed
Release Note: This changes upgrades thrift dependency of HBase to 0.9.2.
Though this doesn't break any HBase compatibility promises, it might impact any
downstream projects that share thrift dependency with HBase.
Status: Resolved (was: Patch Available)
Bumping thrift version to 0.9.2.
Key: HBASE-14045
URL: https://issues.apache.org/jira/browse/HBASE-14045
Project: HBase
Issue Type: Improvement
Reporter: Srikanth Srungarapu
Assignee: Srikanth Srungarapu
Fix For: 2.0.0, 1.3.0
Attachments: HBASE-14045-branch-1.patch, HBASE-14045.patch,
compat_report.html
From mailing list conversation:
{quote}
Currently, HBase is using Thrift 0.9.0 version, with the latest version
being 0.9.2. Currently, the HBase Thrift gateway is vulnerable to crashes due
to THRIFT-2660 when used with default transport and the workaround for this
problem is switching to framed transport. Unfortunately, the recently added
impersonation support \[1\] doesn't work with framed transport leaving thrift
gateway using this feature susceptible to crashes. Updating thrift version
to 0.9.2 will help us in mitigating this problem. Given that security is one
of key requirements for the production clusters, it would be good to ensure
our users that security features in thrift gateway can be used without any
major concerns. Aside this, there are also some nice fixes pertaining to
leaky resources in 0.9.2 like \[2\] and \[3\].
As far compatibility guarantees are concerned, thrift assures 100% wire
compatibility. However, it is my understanding that there were some minor
additions (new API) in 0.9.2 \[4\] which won't work in 0.9.0, but that won't
affect us since we are not using those features. And I tried running test
suite and did manual testing with thrift version set to 0.9.2 and things are
running smoothly. If there are no objections to this change, I would be more
than happy to file a jira and follow this up.
\[1\] https://issues.apache.org/jira/browse/HBASE-11349
\[2\] https://issues.apache.org/jira/browse/THRIFT-2274
\[3\] https://issues.apache.org/jira/browse/THRIFT-2359
\[4\]
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310800version=12324954
{quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14045) Bumping thrift version to 0.9.2.
[
https://issues.apache.org/jira/browse/HBASE-14045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14628820#comment-14628820
]
Srikanth Srungarapu commented on HBASE-14045:
-
Added a courtesy release note. Thanks for the reviews!
Bumping thrift version to 0.9.2.
Key: HBASE-14045
URL: https://issues.apache.org/jira/browse/HBASE-14045
Project: HBase
Issue Type: Improvement
Reporter: Srikanth Srungarapu
Assignee: Srikanth Srungarapu
Fix For: 2.0.0, 1.3.0
Attachments: HBASE-14045-branch-1.patch, HBASE-14045.patch,
compat_report.html
From mailing list conversation:
{quote}
Currently, HBase is using Thrift 0.9.0 version, with the latest version
being 0.9.2. Currently, the HBase Thrift gateway is vulnerable to crashes due
to THRIFT-2660 when used with default transport and the workaround for this
problem is switching to framed transport. Unfortunately, the recently added
impersonation support \[1\] doesn't work with framed transport leaving thrift
gateway using this feature susceptible to crashes. Updating thrift version
to 0.9.2 will help us in mitigating this problem. Given that security is one
of key requirements for the production clusters, it would be good to ensure
our users that security features in thrift gateway can be used without any
major concerns. Aside this, there are also some nice fixes pertaining to
leaky resources in 0.9.2 like \[2\] and \[3\].
As far compatibility guarantees are concerned, thrift assures 100% wire
compatibility. However, it is my understanding that there were some minor
additions (new API) in 0.9.2 \[4\] which won't work in 0.9.0, but that won't
affect us since we are not using those features. And I tried running test
suite and did manual testing with thrift version set to 0.9.2 and things are
running smoothly. If there are no objections to this change, I would be more
than happy to file a jira and follow this up.
\[1\] https://issues.apache.org/jira/browse/HBASE-11349
\[2\] https://issues.apache.org/jira/browse/THRIFT-2274
\[3\] https://issues.apache.org/jira/browse/THRIFT-2359
\[4\]
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310800version=12324954
{quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14045) Bumping thrift version to 0.9.2.
[
https://issues.apache.org/jira/browse/HBASE-14045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Srikanth Srungarapu updated HBASE-14045:
Attachment: compat_report.html
Bumping thrift version to 0.9.2.
Key: HBASE-14045
URL: https://issues.apache.org/jira/browse/HBASE-14045
Project: HBase
Issue Type: Improvement
Reporter: Srikanth Srungarapu
Assignee: Srikanth Srungarapu
Fix For: 2.0.0, 1.3.0
Attachments: HBASE-14045-branch-1.patch, HBASE-14045.patch,
compat_report.html
From mailing list conversation:
{quote}
Currently, HBase is using Thrift 0.9.0 version, with the latest version
being 0.9.2. Currently, the HBase Thrift gateway is vulnerable to crashes due
to THRIFT-2660 when used with default transport and the workaround for this
problem is switching to framed transport. Unfortunately, the recently added
impersonation support \[1\] doesn't work with framed transport leaving thrift
gateway using this feature susceptible to crashes. Updating thrift version
to 0.9.2 will help us in mitigating this problem. Given that security is one
of key requirements for the production clusters, it would be good to ensure
our users that security features in thrift gateway can be used without any
major concerns. Aside this, there are also some nice fixes pertaining to
leaky resources in 0.9.2 like \[2\] and \[3\].
As far compatibility guarantees are concerned, thrift assures 100% wire
compatibility. However, it is my understanding that there were some minor
additions (new API) in 0.9.2 \[4\] which won't work in 0.9.0, but that won't
affect us since we are not using those features. And I tried running test
suite and did manual testing with thrift version set to 0.9.2 and things are
running smoothly. If there are no objections to this change, I would be more
than happy to file a jira and follow this up.
\[1\] https://issues.apache.org/jira/browse/HBASE-11349
\[2\] https://issues.apache.org/jira/browse/THRIFT-2274
\[3\] https://issues.apache.org/jira/browse/THRIFT-2359
\[4\]
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310800version=12324954
{quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14045) Bumping thrift version to 0.9.2.
[
https://issues.apache.org/jira/browse/HBASE-14045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Srikanth Srungarapu updated HBASE-14045:
Attachment: HBASE-14045.patch
Bumping thrift version to 0.9.2.
Key: HBASE-14045
URL: https://issues.apache.org/jira/browse/HBASE-14045
Project: HBase
Issue Type: Improvement
Reporter: Srikanth Srungarapu
Assignee: Srikanth Srungarapu
Fix For: 2.0.0, 1.3.0
Attachments: HBASE-14045-branch-1.patch, HBASE-14045.patch,
compat_report.html
From mailing list conversation:
{quote}
Currently, HBase is using Thrift 0.9.0 version, with the latest version
being 0.9.2. Currently, the HBase Thrift gateway is vulnerable to crashes due
to THRIFT-2660 when used with default transport and the workaround for this
problem is switching to framed transport. Unfortunately, the recently added
impersonation support \[1\] doesn't work with framed transport leaving thrift
gateway using this feature susceptible to crashes. Updating thrift version
to 0.9.2 will help us in mitigating this problem. Given that security is one
of key requirements for the production clusters, it would be good to ensure
our users that security features in thrift gateway can be used without any
major concerns. Aside this, there are also some nice fixes pertaining to
leaky resources in 0.9.2 like \[2\] and \[3\].
As far compatibility guarantees are concerned, thrift assures 100% wire
compatibility. However, it is my understanding that there were some minor
additions (new API) in 0.9.2 \[4\] which won't work in 0.9.0, but that won't
affect us since we are not using those features. And I tried running test
suite and did manual testing with thrift version set to 0.9.2 and things are
running smoothly. If there are no objections to this change, I would be more
than happy to file a jira and follow this up.
\[1\] https://issues.apache.org/jira/browse/HBASE-11349
\[2\] https://issues.apache.org/jira/browse/THRIFT-2274
\[3\] https://issues.apache.org/jira/browse/THRIFT-2359
\[4\]
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310800version=12324954
{quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-14045) Bumping thrift version to 0.9.2.
[
https://issues.apache.org/jira/browse/HBASE-14045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Srikanth Srungarapu updated HBASE-14045:
Attachment: (was: HBASE-14045.patch)
Bumping thrift version to 0.9.2.
Key: HBASE-14045
URL: https://issues.apache.org/jira/browse/HBASE-14045
Project: HBase
Issue Type: Improvement
Reporter: Srikanth Srungarapu
Assignee: Srikanth Srungarapu
Fix For: 2.0.0, 1.3.0
Attachments: HBASE-14045-branch-1.patch, HBASE-14045.patch,
compat_report.html
From mailing list conversation:
{quote}
Currently, HBase is using Thrift 0.9.0 version, with the latest version
being 0.9.2. Currently, the HBase Thrift gateway is vulnerable to crashes due
to THRIFT-2660 when used with default transport and the workaround for this
problem is switching to framed transport. Unfortunately, the recently added
impersonation support \[1\] doesn't work with framed transport leaving thrift
gateway using this feature susceptible to crashes. Updating thrift version
to 0.9.2 will help us in mitigating this problem. Given that security is one
of key requirements for the production clusters, it would be good to ensure
our users that security features in thrift gateway can be used without any
major concerns. Aside this, there are also some nice fixes pertaining to
leaky resources in 0.9.2 like \[2\] and \[3\].
As far compatibility guarantees are concerned, thrift assures 100% wire
compatibility. However, it is my understanding that there were some minor
additions (new API) in 0.9.2 \[4\] which won't work in 0.9.0, but that won't
affect us since we are not using those features. And I tried running test
suite and did manual testing with thrift version set to 0.9.2 and things are
running smoothly. If there are no objections to this change, I would be more
than happy to file a jira and follow this up.
\[1\] https://issues.apache.org/jira/browse/HBASE-11349
\[2\] https://issues.apache.org/jira/browse/THRIFT-2274
\[3\] https://issues.apache.org/jira/browse/THRIFT-2359
\[4\]
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310800version=12324954
{quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
