[jira] [Commented] (HBASE-10455) cleanup InterruptedException management
[ https://issues.apache.org/jira/browse/HBASE-10455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13890946#comment-13890946 ] Hudson commented on HBASE-10455: FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #78 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/78/]) HBASE-10455 cleanup InterruptedException management (nkeywal: rev 1564241) * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTableUtil.java * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCaller.java * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/BlockingRpcCallback.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleRpcScheduler.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableMapReduceUtil.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableMapReduceUtil.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/TableLockManager.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/TableNamespaceManager.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/MetaServerShutdownHandler.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SplitTransaction.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java > cleanup InterruptedException management > --- > > Key: HBASE-10455 > URL: https://issues.apache.org/jira/browse/HBASE-10455 > Project: HBase > Issue Type: Bug > Components: Client, master, regionserver >Affects Versions: 0.98.0, 0.99.0 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon > Fix For: 0.98.0, 0.99.0 > > Attachments: 10455.v1.patch > > > 4 changes in this code: > 1) When caught and rethrowed as a IOException we always rethrow > InterruptedIOException > 2) When we were both throwing an exception AND resetting the interrupt status > we only throw an exception now. > 3) When we were trying to reset the status by Thread.interrupted() (which > does not do that), we now do it for real with a > Thread.currentThread.interrupt(). > 4) Sometimes, we were rethrowing something else then InterruptedIOException, > while the contract would have allowed it. I've changed this as well. > This patch does not make means that we're fine when we're interrupted, but > we're globally cleaner at least. I will then create other patches specific to > some parts. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10455) cleanup InterruptedException management
[ https://issues.apache.org/jira/browse/HBASE-10455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13890796#comment-13890796 ] Hudson commented on HBASE-10455: FAILURE: Integrated in HBase-0.98 #126 (See [https://builds.apache.org/job/HBase-0.98/126/]) HBASE-10455 cleanup InterruptedException management (nkeywal: rev 1564248) * /hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java * /hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java * /hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java * /hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java * /hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java * /hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTableUtil.java * /hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCaller.java * /hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/BlockingRpcCallback.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleRpcScheduler.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableMapReduceUtil.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableMapReduceUtil.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/master/TableLockManager.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/master/TableNamespaceManager.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/MetaServerShutdownHandler.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SplitTransaction.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java > cleanup InterruptedException management > --- > > Key: HBASE-10455 > URL: https://issues.apache.org/jira/browse/HBASE-10455 > Project: HBase > Issue Type: Bug > Components: Client, master, regionserver >Affects Versions: 0.98.0, 0.99.0 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon > Fix For: 0.98.0, 0.99.0 > > Attachments: 10455.v1.patch > > > 4 changes in this code: > 1) When caught and rethrowed as a IOException we always rethrow > InterruptedIOException > 2) When we were both throwing an exception AND resetting the interrupt status > we only throw an exception now. > 3) When we were trying to reset the status by Thread.interrupted() (which > does not do that), we now do it for real with a > Thread.currentThread.interrupt(). > 4) Sometimes, we were rethrowing something else then InterruptedIOException, > while the contract would have allowed it. I've changed this as well. > This patch does not make means that we're fine when we're interrupted, but > we're globally cleaner at least. I will then create other patches specific to > some parts. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10455) cleanup InterruptedException management
[ https://issues.apache.org/jira/browse/HBASE-10455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13890781#comment-13890781 ] Hudson commented on HBASE-10455: SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #118 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/118/]) HBASE-10455 cleanup InterruptedException management (nkeywal: rev 1564248) * /hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java * /hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java * /hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java * /hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java * /hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java * /hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTableUtil.java * /hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCaller.java * /hbase/branches/0.98/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/BlockingRpcCallback.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleRpcScheduler.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableMapReduceUtil.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableMapReduceUtil.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/master/TableLockManager.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/master/TableNamespaceManager.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/MetaServerShutdownHandler.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SplitTransaction.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java * /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java > cleanup InterruptedException management > --- > > Key: HBASE-10455 > URL: https://issues.apache.org/jira/browse/HBASE-10455 > Project: HBase > Issue Type: Bug > Components: Client, master, regionserver >Affects Versions: 0.98.0, 0.99.0 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon > Fix For: 0.98.0, 0.99.0 > > Attachments: 10455.v1.patch > > > 4 changes in this code: > 1) When caught and rethrowed as a IOException we always rethrow > InterruptedIOException > 2) When we were both throwing an exception AND resetting the interrupt status > we only throw an exception now. > 3) When we were trying to reset the status by Thread.interrupted() (which > does not do that), we now do it for real with a > Thread.currentThread.interrupt(). > 4) Sometimes, we were rethrowing something else then InterruptedIOException, > while the contract would have allowed it. I've changed this as well. > This patch does not make means that we're fine when we're interrupted, but > we're globally cleaner at least. I will then create other patches specific to > some parts. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10455) cleanup InterruptedException management
[ https://issues.apache.org/jira/browse/HBASE-10455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13890722#comment-13890722 ] Hudson commented on HBASE-10455: SUCCESS: Integrated in HBase-TRUNK #4880 (See [https://builds.apache.org/job/HBase-TRUNK/4880/]) HBASE-10455 cleanup InterruptedException management (nkeywal: rev 1564241) * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTableUtil.java * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCaller.java * /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/BlockingRpcCallback.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleRpcScheduler.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableMapReduceUtil.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableMapReduceUtil.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/TableLockManager.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/TableNamespaceManager.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/MetaServerShutdownHandler.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SplitTransaction.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java > cleanup InterruptedException management > --- > > Key: HBASE-10455 > URL: https://issues.apache.org/jira/browse/HBASE-10455 > Project: HBase > Issue Type: Bug > Components: Client, master, regionserver >Affects Versions: 0.98.0, 0.99.0 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon > Fix For: 0.98.0, 0.99.0 > > Attachments: 10455.v1.patch > > > 4 changes in this code: > 1) When caught and rethrowed as a IOException we always rethrow > InterruptedIOException > 2) When we were both throwing an exception AND resetting the interrupt status > we only throw an exception now. > 3) When we were trying to reset the status by Thread.interrupted() (which > does not do that), we now do it for real with a > Thread.currentThread.interrupt(). > 4) Sometimes, we were rethrowing something else then InterruptedIOException, > while the contract would have allowed it. I've changed this as well. > This patch does not make means that we're fine when we're interrupted, but > we're globally cleaner at least. I will then create other patches specific to > some parts. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10455) cleanup InterruptedException management
[ https://issues.apache.org/jira/browse/HBASE-10455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13890528#comment-13890528 ] Nicolas Liochon commented on HBASE-10455: - bq. TestZKSecretWatcher may need fixing after this, if the precommit failure is not spurious I've ran the test 30 times locally, it works. bq. Is this the kind of thing we can catch with FindBugs? I don't know how to configure FindBugs for this. It could be a specific rule today. A long time ago, I've added some rules to PMD it was not difficult but not trivial either (a few hours of work). > cleanup InterruptedException management > --- > > Key: HBASE-10455 > URL: https://issues.apache.org/jira/browse/HBASE-10455 > Project: HBase > Issue Type: Bug > Components: Client, master, regionserver >Affects Versions: 0.98.0, 0.99.0 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon > Fix For: 0.98.0, 0.99.0 > > Attachments: 10455.v1.patch > > > 4 changes in this code: > 1) When caught and rethrowed as a IOException we always rethrow > InterruptedIOException > 2) When we were both throwing an exception AND resetting the interrupt status > we only throw an exception now. > 3) When we were trying to reset the status by Thread.interrupted() (which > does not do that), we now do it for real with a > Thread.currentThread.interrupt(). > 4) Sometimes, we were rethrowing something else then InterruptedIOException, > while the contract would have allowed it. I've changed this as well. > This patch does not make means that we're fine when we're interrupted, but > we're globally cleaner at least. I will then create other patches specific to > some parts. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10455) cleanup InterruptedException management
[ https://issues.apache.org/jira/browse/HBASE-10455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13889882#comment-13889882 ] Nick Dimiduk commented on HBASE-10455: -- Is this the kind of thing we can catch with FindBugs? > cleanup InterruptedException management > --- > > Key: HBASE-10455 > URL: https://issues.apache.org/jira/browse/HBASE-10455 > Project: HBase > Issue Type: Bug > Components: Client, master, regionserver >Affects Versions: 0.98.0, 0.99.0 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon > Fix For: 0.98.0, 0.99.0 > > Attachments: 10455.v1.patch > > > 4 changes in this code: > 1) When caught and rethrowed as a IOException we always rethrow > InterruptedIOException > 2) When we were both throwing an exception AND resetting the interrupt status > we only throw an exception now. > 3) When we were trying to reset the status by Thread.interrupted() (which > does not do that), we now do it for real with a > Thread.currentThread.interrupt(). > 4) Sometimes, we were rethrowing something else then InterruptedIOException, > while the contract would have allowed it. I've changed this as well. > This patch does not make means that we're fine when we're interrupted, but > we're globally cleaner at least. I will then create other patches specific to > some parts. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10455) cleanup InterruptedException management
[ https://issues.apache.org/jira/browse/HBASE-10455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13889796#comment-13889796 ] Andrew Purtell commented on HBASE-10455: TestZKSecretWatcher may need fixing after this, if the precommit failure is not spurious. This can be done as a follow up. Open an issue and assign it to me or I'll take care of it if I see it. > cleanup InterruptedException management > --- > > Key: HBASE-10455 > URL: https://issues.apache.org/jira/browse/HBASE-10455 > Project: HBase > Issue Type: Bug > Components: Client, master, regionserver >Affects Versions: 0.98.0, 0.99.0 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon > Fix For: 0.98.0, 0.99.0 > > Attachments: 10455.v1.patch > > > 4 changes in this code: > 1) When caught and rethrowed as a IOException we always rethrow > InterruptedIOException > 2) When we were both throwing an exception AND resetting the interrupt status > we only throw an exception now. > 3) When we were trying to reset the status by Thread.interrupted() (which > does not do that), we now do it for real with a > Thread.currentThread.interrupt(). > 4) Sometimes, we were rethrowing something else then InterruptedIOException, > while the contract would have allowed it. I've changed this as well. > This patch does not make means that we're fine when we're interrupted, but > we're globally cleaner at least. I will then create other patches specific to > some parts. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10455) cleanup InterruptedException management
[ https://issues.apache.org/jira/browse/HBASE-10455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13889793#comment-13889793 ] Andrew Purtell commented on HBASE-10455: +1 for trunk and 0.98 > cleanup InterruptedException management > --- > > Key: HBASE-10455 > URL: https://issues.apache.org/jira/browse/HBASE-10455 > Project: HBase > Issue Type: Bug > Components: Client, master, regionserver >Affects Versions: 0.98.0, 0.99.0 >Reporter: Nicolas Liochon >Assignee: Nicolas Liochon > Fix For: 0.98.0, 0.99.0 > > Attachments: 10455.v1.patch > > > 4 changes in this code: > 1) When caught and rethrowed as a IOException we always rethrow > InterruptedIOException > 2) When we were both throwing an exception AND resetting the interrupt status > we only throw an exception now. > 3) When we were trying to reset the status by Thread.interrupted() (which > does not do that), we now do it for real with a > Thread.currentThread.interrupt(). > 4) Sometimes, we were rethrowing something else then InterruptedIOException, > while the contract would have allowed it. I've changed this as well. > This patch does not make means that we're fine when we're interrupted, but > we're globally cleaner at least. I will then create other patches specific to > some parts. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HBASE-10455) cleanup InterruptedException management
[
https://issues.apache.org/jira/browse/HBASE-10455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13889716#comment-13889716
]
Hadoop QA commented on HBASE-10455:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12626680/10455.v1.patch
against trunk revision .
ATTACHMENT ID: 12626680
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.security.token.TestZKSecretWatcher
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8576//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8576//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8576//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8576//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8576//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8576//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8576//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8576//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8576//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8576//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8576//console
This message is automatically generated.
> cleanup InterruptedException management
> ---
>
> Key: HBASE-10455
> URL: https://issues.apache.org/jira/browse/HBASE-10455
> Project: HBase
> Issue Type: Bug
> Components: Client, master, regionserver
>Affects Versions: 0.98.0, 0.99.0
>Reporter: Nicolas Liochon
>Assignee: Nicolas Liochon
> Fix For: 0.98.0, 0.99.0
>
> Attachments: 10455.v1.patch
>
>
> 4 changes in this code:
> 1) When caught and rethrowed as a IOException we always rethrow
> InterruptedIOException
> 2) When we were both throwing an exception AND resetting the interrupt status
> we only throw an exception now.
> 3) When we were trying to reset the status by Thread.interrupted() (which
> does not do that), we now do it for real with a
> Thread.currentThread.interrupt().
> 4) Sometimes, we were rethrowing something else then InterruptedIOException,
> while the contract would have allowed it. I've changed this as well.
> This patch does not make means that we're fine when we're interrupted, but
> we're globally cleaner at least. I will then create other patches specific to
> some parts.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
