[jira] [Commented] (HBASE-11052) Sending random data crashes thrift service
[ https://issues.apache.org/jira/browse/HBASE-11052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14203411#comment-14203411 ] Harsh J commented on HBASE-11052: - THRIFT-2660 should also help such cases generally. Sending random data crashes thrift service -- Key: HBASE-11052 URL: https://issues.apache.org/jira/browse/HBASE-11052 Project: HBase Issue Type: Bug Components: Thrift Affects Versions: 0.98.1, 1.0.0, 0.94.18 Reporter: Adrian Muraru Assignee: Adrian Muraru Fix For: 0.99.0, 0.94.21, 0.98.4 Attachments: HBASE-11052_0.94_v2.patch, HBASE-11052_0.94_v4.patch, HBASE-11052_trunk_v1.patch, HBASE-11052_trunk_v3.patch, HBASE-11052_trunk_v4.patch Upstream thrift library has a know issue (THRIFT-601) causing the thrift server to crash with an Out-of-Memory Error when bogus requests are sent. This reproduces when a very large request size is sent in the request header, making the thrift server to allocate a large memory segment leading to OOM. LoadBalancer health checks are the first candidate for bogus requests Thrift developers admit this is a known issue with TBinaryProtocol and their recommandation is to use TCompactProtocol/TFramedTransport but this requires all thrift clients to be updated (might not be feasible atm) So we need a fix similar to CASSANDRA-475. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11052) Sending random data crashes thrift service
[ https://issues.apache.org/jira/browse/HBASE-11052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14067498#comment-14067498 ] Hudson commented on HBASE-11052: FAILURE: Integrated in hbase-0.96-hadoop2 #284 (See [https://builds.apache.org/job/hbase-0.96-hadoop2/284/]) HBASE-11547 Backport HBASE-11052 to 0.96 'Sending random data crashes thrift service' (Adrian) (tedyu: rev 7d782b6acc9b50c912fb6ae81c5f50acf2faebc0) * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java * hbase-common/src/main/resources/hbase-default.xml * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java Sending random data crashes thrift service -- Key: HBASE-11052 URL: https://issues.apache.org/jira/browse/HBASE-11052 Project: HBase Issue Type: Bug Components: Thrift Affects Versions: 0.98.1, 1.0.0, 0.94.18 Reporter: Adrian Muraru Assignee: Adrian Muraru Fix For: 0.99.0, 0.94.21, 0.98.4 Attachments: HBASE-11052_0.94_v2.patch, HBASE-11052_0.94_v4.patch, HBASE-11052_trunk_v1.patch, HBASE-11052_trunk_v3.patch, HBASE-11052_trunk_v4.patch Upstream thrift library has a know issue (THRIFT-601) causing the thrift server to crash with an Out-of-Memory Error when bogus requests are sent. This reproduces when a very large request size is sent in the request header, making the thrift server to allocate a large memory segment leading to OOM. LoadBalancer health checks are the first candidate for bogus requests Thrift developers admit this is a known issue with TBinaryProtocol and their recommandation is to use TCompactProtocol/TFramedTransport but this requires all thrift clients to be updated (might not be feasible atm) So we need a fix similar to CASSANDRA-475. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11052) Sending random data crashes thrift service
[ https://issues.apache.org/jira/browse/HBASE-11052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14067196#comment-14067196 ] Esteban Gutierrez commented on HBASE-11052: --- Hey [~te...@apache.org] seems that this was not integrated to 0.96 Sending random data crashes thrift service -- Key: HBASE-11052 URL: https://issues.apache.org/jira/browse/HBASE-11052 Project: HBase Issue Type: Bug Components: Thrift Affects Versions: 0.98.1, 1.0.0, 0.94.18 Reporter: Adrian Muraru Assignee: Adrian Muraru Fix For: 0.99.0, 0.94.21, 0.98.4 Attachments: HBASE-11052_0.94_v2.patch, HBASE-11052_0.94_v4.patch, HBASE-11052_trunk_v1.patch, HBASE-11052_trunk_v3.patch, HBASE-11052_trunk_v4.patch Upstream thrift library has a know issue (THRIFT-601) causing the thrift server to crash with an Out-of-Memory Error when bogus requests are sent. This reproduces when a very large request size is sent in the request header, making the thrift server to allocate a large memory segment leading to OOM. LoadBalancer health checks are the first candidate for bogus requests Thrift developers admit this is a known issue with TBinaryProtocol and their recommandation is to use TCompactProtocol/TFramedTransport but this requires all thrift clients to be updated (might not be feasible atm) So we need a fix similar to CASSANDRA-475. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11052) Sending random data crashes thrift service
[ https://issues.apache.org/jira/browse/HBASE-11052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14067248#comment-14067248 ] Ted Yu commented on HBASE-11052: Oops, you're right. This JIRA is in Closed state - let me open one for backporting. Sending random data crashes thrift service -- Key: HBASE-11052 URL: https://issues.apache.org/jira/browse/HBASE-11052 Project: HBase Issue Type: Bug Components: Thrift Affects Versions: 0.98.1, 1.0.0, 0.94.18 Reporter: Adrian Muraru Assignee: Adrian Muraru Fix For: 0.99.0, 0.94.21, 0.98.4 Attachments: HBASE-11052_0.94_v2.patch, HBASE-11052_0.94_v4.patch, HBASE-11052_trunk_v1.patch, HBASE-11052_trunk_v3.patch, HBASE-11052_trunk_v4.patch Upstream thrift library has a know issue (THRIFT-601) causing the thrift server to crash with an Out-of-Memory Error when bogus requests are sent. This reproduces when a very large request size is sent in the request header, making the thrift server to allocate a large memory segment leading to OOM. LoadBalancer health checks are the first candidate for bogus requests Thrift developers admit this is a known issue with TBinaryProtocol and their recommandation is to use TCompactProtocol/TFramedTransport but this requires all thrift clients to be updated (might not be feasible atm) So we need a fix similar to CASSANDRA-475. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11052) Sending random data crashes thrift service
[ https://issues.apache.org/jira/browse/HBASE-11052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14067267#comment-14067267 ] Ted Yu commented on HBASE-11052: Filed HBASE-11547 Sending random data crashes thrift service -- Key: HBASE-11052 URL: https://issues.apache.org/jira/browse/HBASE-11052 Project: HBase Issue Type: Bug Components: Thrift Affects Versions: 0.98.1, 1.0.0, 0.94.18 Reporter: Adrian Muraru Assignee: Adrian Muraru Fix For: 0.99.0, 0.94.21, 0.98.4 Attachments: HBASE-11052_0.94_v2.patch, HBASE-11052_0.94_v4.patch, HBASE-11052_trunk_v1.patch, HBASE-11052_trunk_v3.patch, HBASE-11052_trunk_v4.patch Upstream thrift library has a know issue (THRIFT-601) causing the thrift server to crash with an Out-of-Memory Error when bogus requests are sent. This reproduces when a very large request size is sent in the request header, making the thrift server to allocate a large memory segment leading to OOM. LoadBalancer health checks are the first candidate for bogus requests Thrift developers admit this is a known issue with TBinaryProtocol and their recommandation is to use TCompactProtocol/TFramedTransport but this requires all thrift clients to be updated (might not be feasible atm) So we need a fix similar to CASSANDRA-475. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11052) Sending random data crashes thrift service
[ https://issues.apache.org/jira/browse/HBASE-11052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14067398#comment-14067398 ] Hudson commented on HBASE-11052: FAILURE: Integrated in hbase-0.96 #410 (See [https://builds.apache.org/job/hbase-0.96/410/]) HBASE-11547 Backport HBASE-11052 to 0.96 'Sending random data crashes thrift service' (Adrian) (tedyu: rev 7d782b6acc9b50c912fb6ae81c5f50acf2faebc0) * hbase-common/src/main/resources/hbase-default.xml * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java Sending random data crashes thrift service -- Key: HBASE-11052 URL: https://issues.apache.org/jira/browse/HBASE-11052 Project: HBase Issue Type: Bug Components: Thrift Affects Versions: 0.98.1, 1.0.0, 0.94.18 Reporter: Adrian Muraru Assignee: Adrian Muraru Fix For: 0.99.0, 0.94.21, 0.98.4 Attachments: HBASE-11052_0.94_v2.patch, HBASE-11052_0.94_v4.patch, HBASE-11052_trunk_v1.patch, HBASE-11052_trunk_v3.patch, HBASE-11052_trunk_v4.patch Upstream thrift library has a know issue (THRIFT-601) causing the thrift server to crash with an Out-of-Memory Error when bogus requests are sent. This reproduces when a very large request size is sent in the request header, making the thrift server to allocate a large memory segment leading to OOM. LoadBalancer health checks are the first candidate for bogus requests Thrift developers admit this is a known issue with TBinaryProtocol and their recommandation is to use TCompactProtocol/TFramedTransport but this requires all thrift clients to be updated (might not be feasible atm) So we need a fix similar to CASSANDRA-475. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11052) Sending random data crashes thrift service
[ https://issues.apache.org/jira/browse/HBASE-11052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14035967#comment-14035967 ] Hudson commented on HBASE-11052: SUCCESS: Integrated in HBase-0.94-security #493 (See [https://builds.apache.org/job/HBase-0.94-security/493/]) HBASE-11052 Sending random data crashes thrift service (Adrian Muraru) (tedyu: rev ce722679a0a9096d253230ee0f61b9fff9c3638e) * src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java * src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java * src/main/java/org/apache/hadoop/hbase/thrift/TBoundedThreadPoolServer.java * src/main/resources/hbase-default.xml Sending random data crashes thrift service -- Key: HBASE-11052 URL: https://issues.apache.org/jira/browse/HBASE-11052 Project: HBase Issue Type: Bug Components: Thrift Affects Versions: 0.98.1, 1.0.0, 0.94.18 Reporter: Adrian Muraru Assignee: Adrian Muraru Fix For: 1.0.0, 0.94.21, 0.98.4 Attachments: HBASE-11052_0.94_v2.patch, HBASE-11052_0.94_v4.patch, HBASE-11052_trunk_v1.patch, HBASE-11052_trunk_v3.patch, HBASE-11052_trunk_v4.patch Upstream thrift library has a know issue (THRIFT-601) causing the thrift server to crash with an Out-of-Memory Error when bogus requests are sent. This reproduces when a very large request size is sent in the request header, making the thrift server to allocate a large memory segment leading to OOM. LoadBalancer health checks are the first candidate for bogus requests Thrift developers admit this is a known issue with TBinaryProtocol and their recommandation is to use TCompactProtocol/TFramedTransport but this requires all thrift clients to be updated (might not be feasible atm) So we need a fix similar to CASSANDRA-475. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11052) Sending random data crashes thrift service
[ https://issues.apache.org/jira/browse/HBASE-11052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14036073#comment-14036073 ] Hudson commented on HBASE-11052: FAILURE: Integrated in HBase-0.94-JDK7 #147 (See [https://builds.apache.org/job/HBase-0.94-JDK7/147/]) HBASE-11052 Sending random data crashes thrift service (Adrian Muraru) (tedyu: rev ce722679a0a9096d253230ee0f61b9fff9c3638e) * src/main/java/org/apache/hadoop/hbase/thrift/TBoundedThreadPoolServer.java * src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java * src/main/resources/hbase-default.xml * src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java Sending random data crashes thrift service -- Key: HBASE-11052 URL: https://issues.apache.org/jira/browse/HBASE-11052 Project: HBase Issue Type: Bug Components: Thrift Affects Versions: 0.98.1, 1.0.0, 0.94.18 Reporter: Adrian Muraru Assignee: Adrian Muraru Fix For: 1.0.0, 0.94.21, 0.98.4 Attachments: HBASE-11052_0.94_v2.patch, HBASE-11052_0.94_v4.patch, HBASE-11052_trunk_v1.patch, HBASE-11052_trunk_v3.patch, HBASE-11052_trunk_v4.patch Upstream thrift library has a know issue (THRIFT-601) causing the thrift server to crash with an Out-of-Memory Error when bogus requests are sent. This reproduces when a very large request size is sent in the request header, making the thrift server to allocate a large memory segment leading to OOM. LoadBalancer health checks are the first candidate for bogus requests Thrift developers admit this is a known issue with TBinaryProtocol and their recommandation is to use TCompactProtocol/TFramedTransport but this requires all thrift clients to be updated (might not be feasible atm) So we need a fix similar to CASSANDRA-475. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11052) Sending random data crashes thrift service
[ https://issues.apache.org/jira/browse/HBASE-11052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14036072#comment-14036072 ] Hudson commented on HBASE-11052: FAILURE: Integrated in HBase-0.94 #1379 (See [https://builds.apache.org/job/HBase-0.94/1379/]) HBASE-11052 Sending random data crashes thrift service (Adrian Muraru) (tedyu: rev ce722679a0a9096d253230ee0f61b9fff9c3638e) * src/main/resources/hbase-default.xml * src/main/java/org/apache/hadoop/hbase/thrift/TBoundedThreadPoolServer.java * src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java * src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java Sending random data crashes thrift service -- Key: HBASE-11052 URL: https://issues.apache.org/jira/browse/HBASE-11052 Project: HBase Issue Type: Bug Components: Thrift Affects Versions: 0.98.1, 1.0.0, 0.94.18 Reporter: Adrian Muraru Assignee: Adrian Muraru Fix For: 1.0.0, 0.94.21, 0.98.4 Attachments: HBASE-11052_0.94_v2.patch, HBASE-11052_0.94_v4.patch, HBASE-11052_trunk_v1.patch, HBASE-11052_trunk_v3.patch, HBASE-11052_trunk_v4.patch Upstream thrift library has a know issue (THRIFT-601) causing the thrift server to crash with an Out-of-Memory Error when bogus requests are sent. This reproduces when a very large request size is sent in the request header, making the thrift server to allocate a large memory segment leading to OOM. LoadBalancer health checks are the first candidate for bogus requests Thrift developers admit this is a known issue with TBinaryProtocol and their recommandation is to use TCompactProtocol/TFramedTransport but this requires all thrift clients to be updated (might not be feasible atm) So we need a fix similar to CASSANDRA-475. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11052) Sending random data crashes thrift service
[ https://issues.apache.org/jira/browse/HBASE-11052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14033954#comment-14033954 ] Ted Yu commented on HBASE-11052: Integrated to trunk. Thanks for the patch, Adrian. [~apurtell]: do you want this in 0.98 ? [~lhofhansl]: do you want this in 0.94 ? Sending random data crashes thrift service -- Key: HBASE-11052 URL: https://issues.apache.org/jira/browse/HBASE-11052 Project: HBase Issue Type: Bug Components: Thrift Affects Versions: 0.98.1, 1.0.0, 0.94.18 Reporter: Adrian Muraru Fix For: 1.0.0, 0.94.21, 0.98.4 Attachments: HBASE-11052_0.94_v2.patch, HBASE-11052_0.94_v4.patch, HBASE-11052_trunk_v1.patch, HBASE-11052_trunk_v3.patch, HBASE-11052_trunk_v4.patch Upstream thrift library has a know issue (THRIFT-601) causing the thrift server to crash with an Out-of-Memory Error when bogus requests are sent. This reproduces when a very large request size is sent in the request header, making the thrift server to allocate a large memory segment leading to OOM. LoadBalancer health checks are the first candidate for bogus requests Thrift developers admit this is a known issue with TBinaryProtocol and their recommandation is to use TCompactProtocol/TFramedTransport but this requires all thrift clients to be updated (might not be feasible atm) So we need a fix similar to CASSANDRA-475. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11052) Sending random data crashes thrift service
[ https://issues.apache.org/jira/browse/HBASE-11052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14034138#comment-14034138 ] Hudson commented on HBASE-11052: SUCCESS: Integrated in HBase-TRUNK #5214 (See [https://builds.apache.org/job/HBase-TRUNK/5214/]) HBASE-11052 Sending random data crashes thrift service (tedyu: rev 1324a3cb1807ee9eaa65deeefca5ee222045bdc3) * hbase-common/src/main/resources/hbase-default.xml * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java Sending random data crashes thrift service -- Key: HBASE-11052 URL: https://issues.apache.org/jira/browse/HBASE-11052 Project: HBase Issue Type: Bug Components: Thrift Affects Versions: 0.98.1, 1.0.0, 0.94.18 Reporter: Adrian Muraru Fix For: 1.0.0, 0.94.21, 0.98.4 Attachments: HBASE-11052_0.94_v2.patch, HBASE-11052_0.94_v4.patch, HBASE-11052_trunk_v1.patch, HBASE-11052_trunk_v3.patch, HBASE-11052_trunk_v4.patch Upstream thrift library has a know issue (THRIFT-601) causing the thrift server to crash with an Out-of-Memory Error when bogus requests are sent. This reproduces when a very large request size is sent in the request header, making the thrift server to allocate a large memory segment leading to OOM. LoadBalancer health checks are the first candidate for bogus requests Thrift developers admit this is a known issue with TBinaryProtocol and their recommandation is to use TCompactProtocol/TFramedTransport but this requires all thrift clients to be updated (might not be feasible atm) So we need a fix similar to CASSANDRA-475. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11052) Sending random data crashes thrift service
[ https://issues.apache.org/jira/browse/HBASE-11052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14034638#comment-14034638 ] Andrew Purtell commented on HBASE-11052: +1 for 0.98, hbase.regionserver.thrift.framed defaults to false. Sending random data crashes thrift service -- Key: HBASE-11052 URL: https://issues.apache.org/jira/browse/HBASE-11052 Project: HBase Issue Type: Bug Components: Thrift Affects Versions: 0.98.1, 1.0.0, 0.94.18 Reporter: Adrian Muraru Fix For: 1.0.0, 0.94.21, 0.98.4 Attachments: HBASE-11052_0.94_v2.patch, HBASE-11052_0.94_v4.patch, HBASE-11052_trunk_v1.patch, HBASE-11052_trunk_v3.patch, HBASE-11052_trunk_v4.patch Upstream thrift library has a know issue (THRIFT-601) causing the thrift server to crash with an Out-of-Memory Error when bogus requests are sent. This reproduces when a very large request size is sent in the request header, making the thrift server to allocate a large memory segment leading to OOM. LoadBalancer health checks are the first candidate for bogus requests Thrift developers admit this is a known issue with TBinaryProtocol and their recommandation is to use TCompactProtocol/TFramedTransport but this requires all thrift clients to be updated (might not be feasible atm) So we need a fix similar to CASSANDRA-475. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11052) Sending random data crashes thrift service
[ https://issues.apache.org/jira/browse/HBASE-11052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14034685#comment-14034685 ] Ted Yu commented on HBASE-11052: Integrated to 0.98 as well. Sending random data crashes thrift service -- Key: HBASE-11052 URL: https://issues.apache.org/jira/browse/HBASE-11052 Project: HBase Issue Type: Bug Components: Thrift Affects Versions: 0.98.1, 1.0.0, 0.94.18 Reporter: Adrian Muraru Assignee: Adrian Muraru Fix For: 1.0.0, 0.94.21, 0.98.4 Attachments: HBASE-11052_0.94_v2.patch, HBASE-11052_0.94_v4.patch, HBASE-11052_trunk_v1.patch, HBASE-11052_trunk_v3.patch, HBASE-11052_trunk_v4.patch Upstream thrift library has a know issue (THRIFT-601) causing the thrift server to crash with an Out-of-Memory Error when bogus requests are sent. This reproduces when a very large request size is sent in the request header, making the thrift server to allocate a large memory segment leading to OOM. LoadBalancer health checks are the first candidate for bogus requests Thrift developers admit this is a known issue with TBinaryProtocol and their recommandation is to use TCompactProtocol/TFramedTransport but this requires all thrift clients to be updated (might not be feasible atm) So we need a fix similar to CASSANDRA-475. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11052) Sending random data crashes thrift service
[ https://issues.apache.org/jira/browse/HBASE-11052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14034801#comment-14034801 ] Hudson commented on HBASE-11052: FAILURE: Integrated in HBase-0.98 #344 (See [https://builds.apache.org/job/HBase-0.98/344/]) HBASE-11052 Sending random data crashes thrift service (Adrian Muraru) (tedyu: rev 1c4cdefe21b5bf45aac223a359e807845670bed3) * hbase-common/src/main/resources/hbase-default.xml * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java Sending random data crashes thrift service -- Key: HBASE-11052 URL: https://issues.apache.org/jira/browse/HBASE-11052 Project: HBase Issue Type: Bug Components: Thrift Affects Versions: 0.98.1, 1.0.0, 0.94.18 Reporter: Adrian Muraru Assignee: Adrian Muraru Fix For: 1.0.0, 0.94.21, 0.98.4 Attachments: HBASE-11052_0.94_v2.patch, HBASE-11052_0.94_v4.patch, HBASE-11052_trunk_v1.patch, HBASE-11052_trunk_v3.patch, HBASE-11052_trunk_v4.patch Upstream thrift library has a know issue (THRIFT-601) causing the thrift server to crash with an Out-of-Memory Error when bogus requests are sent. This reproduces when a very large request size is sent in the request header, making the thrift server to allocate a large memory segment leading to OOM. LoadBalancer health checks are the first candidate for bogus requests Thrift developers admit this is a known issue with TBinaryProtocol and their recommandation is to use TCompactProtocol/TFramedTransport but this requires all thrift clients to be updated (might not be feasible atm) So we need a fix similar to CASSANDRA-475. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11052) Sending random data crashes thrift service
[ https://issues.apache.org/jira/browse/HBASE-11052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14034830#comment-14034830 ] Hudson commented on HBASE-11052: FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #325 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/325/]) HBASE-11052 Sending random data crashes thrift service (Adrian Muraru) (tedyu: rev 1c4cdefe21b5bf45aac223a359e807845670bed3) * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java * hbase-common/src/main/resources/hbase-default.xml * hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftServer.java Sending random data crashes thrift service -- Key: HBASE-11052 URL: https://issues.apache.org/jira/browse/HBASE-11052 Project: HBase Issue Type: Bug Components: Thrift Affects Versions: 0.98.1, 1.0.0, 0.94.18 Reporter: Adrian Muraru Assignee: Adrian Muraru Fix For: 1.0.0, 0.94.21, 0.98.4 Attachments: HBASE-11052_0.94_v2.patch, HBASE-11052_0.94_v4.patch, HBASE-11052_trunk_v1.patch, HBASE-11052_trunk_v3.patch, HBASE-11052_trunk_v4.patch Upstream thrift library has a know issue (THRIFT-601) causing the thrift server to crash with an Out-of-Memory Error when bogus requests are sent. This reproduces when a very large request size is sent in the request header, making the thrift server to allocate a large memory segment leading to OOM. LoadBalancer health checks are the first candidate for bogus requests Thrift developers admit this is a known issue with TBinaryProtocol and their recommandation is to use TCompactProtocol/TFramedTransport but this requires all thrift clients to be updated (might not be feasible atm) So we need a fix similar to CASSANDRA-475. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11052) Sending random data crashes thrift service
[ https://issues.apache.org/jira/browse/HBASE-11052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14033354#comment-14033354 ] Esteban Gutierrez commented on HBASE-11052: --- I'm +1 (non-binding) those OOMEs are really annoying. Sending random data crashes thrift service -- Key: HBASE-11052 URL: https://issues.apache.org/jira/browse/HBASE-11052 Project: HBase Issue Type: Bug Components: Thrift Affects Versions: 0.98.1, 1.0.0, 0.94.18 Reporter: Adrian Muraru Fix For: 1.0.0, 0.94.21, 0.98.4 Attachments: HBASE-11052_0.94_v2.patch, HBASE-11052_0.94_v4.patch, HBASE-11052_trunk_v1.patch, HBASE-11052_trunk_v3.patch, HBASE-11052_trunk_v4.patch Upstream thrift library has a know issue (THRIFT-601) causing the thrift server to crash with an Out-of-Memory Error when bogus requests are sent. This reproduces when a very large request size is sent in the request header, making the thrift server to allocate a large memory segment leading to OOM. LoadBalancer health checks are the first candidate for bogus requests Thrift developers admit this is a known issue with TBinaryProtocol and their recommandation is to use TCompactProtocol/TFramedTransport but this requires all thrift clients to be updated (might not be feasible atm) So we need a fix similar to CASSANDRA-475. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11052) Sending random data crashes thrift service
[ https://issues.apache.org/jira/browse/HBASE-11052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14031478#comment-14031478 ] Lars Hofhansl commented on HBASE-11052: --- Looks good to me. Sending random data crashes thrift service -- Key: HBASE-11052 URL: https://issues.apache.org/jira/browse/HBASE-11052 Project: HBase Issue Type: Bug Components: Thrift Affects Versions: 0.98.1, 1.0.0, 0.94.18 Reporter: Adrian Muraru Fix For: 1.0.0, 0.94.21, 0.98.4 Attachments: HBASE-11052_0.94_v2.patch, HBASE-11052_0.94_v4.patch, HBASE-11052_trunk_v1.patch, HBASE-11052_trunk_v3.patch, HBASE-11052_trunk_v4.patch Upstream thrift library has a know issue (THRIFT-601) causing the thrift server to crash with an Out-of-Memory Error when bogus requests are sent. This reproduces when a very large request size is sent in the request header, making the thrift server to allocate a large memory segment leading to OOM. LoadBalancer health checks are the first candidate for bogus requests Thrift developers admit this is a known issue with TBinaryProtocol and their recommandation is to use TCompactProtocol/TFramedTransport but this requires all thrift clients to be updated (might not be feasible atm) So we need a fix similar to CASSANDRA-475. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11052) Sending random data crashes thrift service
[ https://issues.apache.org/jira/browse/HBASE-11052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14026103#comment-14026103 ] stack commented on HBASE-11052: --- To be clear, we are not making the switch in the patch; framed/compact is false. On rolling upgrade old clients will still work? We just need to talk up need to switch? Thanks [~amuraru] Sending random data crashes thrift service -- Key: HBASE-11052 URL: https://issues.apache.org/jira/browse/HBASE-11052 Project: HBase Issue Type: Bug Components: Thrift Affects Versions: 0.98.1, 1.0.0, 0.94.18 Reporter: Adrian Muraru Fix For: 1.0.0, 0.94.21, 0.98.4 Attachments: HBASE-11052_0.94_v2.patch, HBASE-11052_0.94_v4.patch, HBASE-11052_trunk_v1.patch, HBASE-11052_trunk_v3.patch, HBASE-11052_trunk_v4.patch Upstream thrift library has a know issue (THRIFT-601) causing the thrift server to crash with an Out-of-Memory Error when bogus requests are sent. This reproduces when a very large request size is sent in the request header, making the thrift server to allocate a large memory segment leading to OOM. LoadBalancer health checks are the first candidate for bogus requests Thrift developers admit this is a known issue with TBinaryProtocol and their recommandation is to use TCompactProtocol/TFramedTransport but this requires all thrift clients to be updated (might not be feasible atm) So we need a fix similar to CASSANDRA-475. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11052) Sending random data crashes thrift service
[ https://issues.apache.org/jira/browse/HBASE-11052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020900#comment-14020900 ] Adrian Muraru commented on HBASE-11052: --- patch ver4 for trunk - reverting defaults in hbase-default.xml as they were making tests fail Sending random data crashes thrift service -- Key: HBASE-11052 URL: https://issues.apache.org/jira/browse/HBASE-11052 Project: HBase Issue Type: Bug Components: Thrift Affects Versions: 0.98.1, 1.0.0, 0.94.18 Reporter: Adrian Muraru Fix For: 1.0.0, 0.94.21, 0.98.4 Attachments: HBASE-11052_0.94_v2.patch, HBASE-11052_0.94_v4.patch, HBASE-11052_trunk_v1.patch, HBASE-11052_trunk_v3.patch, HBASE-11052_trunk_v4.patch Upstream thrift library has a know issue (THRIFT-601) causing the thrift server to crash with an Out-of-Memory Error when bogus requests are sent. This reproduces when a very large request size is sent in the request header, making the thrift server to allocate a large memory segment leading to OOM. LoadBalancer health checks are the first candidate for bogus requests Thrift developers admit this is a known issue with TBinaryProtocol and their recommandation is to use TCompactProtocol/TFramedTransport but this requires all thrift clients to be updated (might not be feasible atm) So we need a fix similar to CASSANDRA-475. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11052) Sending random data crashes thrift service
[
https://issues.apache.org/jira/browse/HBASE-11052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020949#comment-14020949
]
Hadoop QA commented on HBASE-11052:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12648824/HBASE-11052_trunk_v4.patch
against trunk revision .
ATTACHMENT ID: 12648824
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9717//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9717//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9717//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9717//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9717//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9717//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9717//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9717//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9717//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9717//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9717//console
This message is automatically generated.
Sending random data crashes thrift service
--
Key: HBASE-11052
URL: https://issues.apache.org/jira/browse/HBASE-11052
Project: HBase
Issue Type: Bug
Components: Thrift
Affects Versions: 0.98.1, 1.0.0, 0.94.18
Reporter: Adrian Muraru
Fix For: 1.0.0, 0.94.21, 0.98.4
Attachments: HBASE-11052_0.94_v2.patch, HBASE-11052_0.94_v4.patch,
HBASE-11052_trunk_v1.patch, HBASE-11052_trunk_v3.patch,
HBASE-11052_trunk_v4.patch
Upstream thrift library has a know issue (THRIFT-601) causing the thrift
server to crash with an Out-of-Memory Error when bogus requests are sent.
This reproduces when a very large request size is sent in the request header,
making the thrift server to allocate a large memory segment leading to OOM.
LoadBalancer health checks are the first candidate for bogus requests
Thrift developers admit this is a known issue with TBinaryProtocol and their
recommandation is to use TCompactProtocol/TFramedTransport but this requires
all thrift clients to be updated (might not be feasible atm)
So we need a fix similar to CASSANDRA-475.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11052) Sending random data crashes thrift service
[ https://issues.apache.org/jira/browse/HBASE-11052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020418#comment-14020418 ] Adrian Muraru commented on HBASE-11052: --- Patches updated based on [~apurtell] review Sending random data crashes thrift service -- Key: HBASE-11052 URL: https://issues.apache.org/jira/browse/HBASE-11052 Project: HBase Issue Type: Bug Components: Thrift Affects Versions: 0.98.1, 1.0.0, 0.94.18 Reporter: Adrian Muraru Attachments: HBASE-11052_0.94_v2.patch, HBASE-11052_0.94_v3.patch, HBASE-11052_trunk_v1.patch, HBASE-11052_trunk_v2.patch Upstream thrift library has a know issue (THRIFT-601) causing the thrift server to crash with an Out-of-Memory Error when bogus requests are sent. This reproduces when a very large request size is sent in the request header, making the thrift server to allocate a large memory segment leading to OOM. LoadBalancer health checks are the first candidate for bogus requests Thrift developers admit this is a known issue with TBinaryProtocol and their recommandation is to use TCompactProtocol/TFramedTransport but this requires all thrift clients to be updated (might not be feasible atm) So we need a fix similar to CASSANDRA-475. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11052) Sending random data crashes thrift service
[
https://issues.apache.org/jira/browse/HBASE-11052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020434#comment-14020434
]
Hadoop QA commented on HBASE-11052:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12648735/HBASE-11052_0.94_v3.patch
against trunk revision .
ATTACHMENT ID: 12648735
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9712//console
This message is automatically generated.
Sending random data crashes thrift service
--
Key: HBASE-11052
URL: https://issues.apache.org/jira/browse/HBASE-11052
Project: HBase
Issue Type: Bug
Components: Thrift
Affects Versions: 0.98.1, 1.0.0, 0.94.18
Reporter: Adrian Muraru
Fix For: 1.0.0, 0.94.21, 0.98.4
Attachments: HBASE-11052_0.94_v2.patch, HBASE-11052_0.94_v3.patch,
HBASE-11052_trunk_v1.patch, HBASE-11052_trunk_v2.patch
Upstream thrift library has a know issue (THRIFT-601) causing the thrift
server to crash with an Out-of-Memory Error when bogus requests are sent.
This reproduces when a very large request size is sent in the request header,
making the thrift server to allocate a large memory segment leading to OOM.
LoadBalancer health checks are the first candidate for bogus requests
Thrift developers admit this is a known issue with TBinaryProtocol and their
recommandation is to use TCompactProtocol/TFramedTransport but this requires
all thrift clients to be updated (might not be feasible atm)
So we need a fix similar to CASSANDRA-475.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11052) Sending random data crashes thrift service
[
https://issues.apache.org/jira/browse/HBASE-11052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020442#comment-14020442
]
Adrian Muraru commented on HBASE-11052:
---
Wrong patch format, resubmitted - jenkins is not happy with {{git
format-patch}}
Sending random data crashes thrift service
--
Key: HBASE-11052
URL: https://issues.apache.org/jira/browse/HBASE-11052
Project: HBase
Issue Type: Bug
Components: Thrift
Affects Versions: 0.98.1, 1.0.0, 0.94.18
Reporter: Adrian Muraru
Fix For: 1.0.0, 0.94.21, 0.98.4
Attachments: HBASE-11052_0.94_v2.patch, HBASE-11052_0.94_v4.patch,
HBASE-11052_trunk_v1.patch, HBASE-11052_trunk_v3.patch
Upstream thrift library has a know issue (THRIFT-601) causing the thrift
server to crash with an Out-of-Memory Error when bogus requests are sent.
This reproduces when a very large request size is sent in the request header,
making the thrift server to allocate a large memory segment leading to OOM.
LoadBalancer health checks are the first candidate for bogus requests
Thrift developers admit this is a known issue with TBinaryProtocol and their
recommandation is to use TCompactProtocol/TFramedTransport but this requires
all thrift clients to be updated (might not be feasible atm)
So we need a fix similar to CASSANDRA-475.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11052) Sending random data crashes thrift service
[
https://issues.apache.org/jira/browse/HBASE-11052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020546#comment-14020546
]
Hadoop QA commented on HBASE-11052:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12648744/HBASE-11052_trunk_v3.patch
against trunk revision .
ATTACHMENT ID: 12648744
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.thrift.TestThriftServerCmdLine
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9713//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9713//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9713//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9713//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9713//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9713//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9713//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9713//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9713//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9713//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9713//console
This message is automatically generated.
Sending random data crashes thrift service
--
Key: HBASE-11052
URL: https://issues.apache.org/jira/browse/HBASE-11052
Project: HBase
Issue Type: Bug
Components: Thrift
Affects Versions: 0.98.1, 1.0.0, 0.94.18
Reporter: Adrian Muraru
Fix For: 1.0.0, 0.94.21, 0.98.4
Attachments: HBASE-11052_0.94_v2.patch, HBASE-11052_0.94_v4.patch,
HBASE-11052_trunk_v1.patch, HBASE-11052_trunk_v3.patch
Upstream thrift library has a know issue (THRIFT-601) causing the thrift
server to crash with an Out-of-Memory Error when bogus requests are sent.
This reproduces when a very large request size is sent in the request header,
making the thrift server to allocate a large memory segment leading to OOM.
LoadBalancer health checks are the first candidate for bogus requests
Thrift developers admit this is a known issue with TBinaryProtocol and their
recommandation is to use TCompactProtocol/TFramedTransport but this requires
all thrift clients to be updated (might not be feasible atm)
So we need a fix similar to CASSANDRA-475.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11052) Sending random data crashes thrift service
[ https://issues.apache.org/jira/browse/HBASE-11052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13980121#comment-13980121 ] John Vines commented on HBASE-11052: We fixed this in Accumulo by setting the max frame size, fwiw- https://issues.apache.org/jira/browse/ACCUMULO-2360 Sending random data crashes thrift service -- Key: HBASE-11052 URL: https://issues.apache.org/jira/browse/HBASE-11052 Project: HBase Issue Type: Bug Components: Thrift Affects Versions: 0.98.1, 1.0.0, 0.94.18 Reporter: Adrian Muraru Attachments: HBASE-11052_0.94_v2.patch, HBASE-11052_trunk_v1.patch Upstream thrift library has a know issue (THRIFT-601) causing the thrift server to crash with an Out-of-Memory Error when bogus requests are sent. This reproduces when a very large request size is sent in the request header, making the thrift server to allocate a large memory segment leading to OOM. LoadBalancer health checks are the first candidate for bogus requests Thrift developers admit this is a known issue with TBinaryProtocol and their recommandation is to use TCompactProtocol/TFramedTransport but this requires all thrift clients to be updated (might not be feasible atm) So we need a fix similar to CASSANDRA-475. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11052) Sending random data crashes thrift service
[ https://issues.apache.org/jira/browse/HBASE-11052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13980124#comment-13980124 ] Andrew Purtell commented on HBASE-11052: Thanks [~vines], appreciated. Sending random data crashes thrift service -- Key: HBASE-11052 URL: https://issues.apache.org/jira/browse/HBASE-11052 Project: HBase Issue Type: Bug Components: Thrift Affects Versions: 0.98.1, 1.0.0, 0.94.18 Reporter: Adrian Muraru Attachments: HBASE-11052_0.94_v2.patch, HBASE-11052_trunk_v1.patch Upstream thrift library has a know issue (THRIFT-601) causing the thrift server to crash with an Out-of-Memory Error when bogus requests are sent. This reproduces when a very large request size is sent in the request header, making the thrift server to allocate a large memory segment leading to OOM. LoadBalancer health checks are the first candidate for bogus requests Thrift developers admit this is a known issue with TBinaryProtocol and their recommandation is to use TCompactProtocol/TFramedTransport but this requires all thrift clients to be updated (might not be feasible atm) So we need a fix similar to CASSANDRA-475. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11052) Sending random data crashes thrift service
[ https://issues.apache.org/jira/browse/HBASE-11052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13978941#comment-13978941 ] Adrian Muraru commented on HBASE-11052: --- Note that thrift 0.9.0 removes (weird!) the message limit support in TBinaryProtocol (THRIFT-820), so for 0.95 onwards we should consider configuring HThrift server to use compact/framed transport by default to avoid the OOM. Sending random data crashes thrift service -- Key: HBASE-11052 URL: https://issues.apache.org/jira/browse/HBASE-11052 Project: HBase Issue Type: Bug Components: Thrift Affects Versions: 0.98.1, 1.0.0, 0.94.18 Reporter: Adrian Muraru Attachments: HBASE-11052.v1.patch Upstream thrift library has a know issue (THRIFT-601) causing the thrift server to crash with an Out-of-Memory Error when bogus requests are sent. This reproduces when a very large request size is sent in the request header, making the thrift server to allocate a large memory segment leading to OOM. LoadBalancer health checks are the first candidate for bogus requests Thrift developers admit this is a known issue with TBinaryProtocol and their recommandation is to use TCompactProtocol/TFramedTransport but this requires all thrift clients to be updated (might not be feasible atm) So we need a fix similar to CASSANDRA-475. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11052) Sending random data crashes thrift service
[ https://issues.apache.org/jira/browse/HBASE-11052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13978965#comment-13978965 ] Andrew Purtell commented on HBASE-11052: bq. for 0.95 onwards we should consider configuring HThrift server to use compact/framed transport by default to avoid the OOM. Any chance for a patch against trunk [~amuraru]? Sending random data crashes thrift service -- Key: HBASE-11052 URL: https://issues.apache.org/jira/browse/HBASE-11052 Project: HBase Issue Type: Bug Components: Thrift Affects Versions: 0.98.1, 1.0.0, 0.94.18 Reporter: Adrian Muraru Attachments: HBASE-11052.v1.patch Upstream thrift library has a know issue (THRIFT-601) causing the thrift server to crash with an Out-of-Memory Error when bogus requests are sent. This reproduces when a very large request size is sent in the request header, making the thrift server to allocate a large memory segment leading to OOM. LoadBalancer health checks are the first candidate for bogus requests Thrift developers admit this is a known issue with TBinaryProtocol and their recommandation is to use TCompactProtocol/TFramedTransport but this requires all thrift clients to be updated (might not be feasible atm) So we need a fix similar to CASSANDRA-475. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11052) Sending random data crashes thrift service
[
https://issues.apache.org/jira/browse/HBASE-11052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13979092#comment-13979092
]
Ted Yu commented on HBASE-11052:
lgtm
{code}
+ transportFactory = new
TFramedTransport.Factory(conf.getInt(MAX_FRAME_SIZE_CONF_KEY, 2) * 1024 *
1024);
{code}
Long line.
Sending random data crashes thrift service
--
Key: HBASE-11052
URL: https://issues.apache.org/jira/browse/HBASE-11052
Project: HBase
Issue Type: Bug
Components: Thrift
Affects Versions: 0.98.1, 1.0.0, 0.94.18
Reporter: Adrian Muraru
Attachments: HBASE-11052_0.94_v2.patch, HBASE-11052_trunk_v1.patch
Upstream thrift library has a know issue (THRIFT-601) causing the thrift
server to crash with an Out-of-Memory Error when bogus requests are sent.
This reproduces when a very large request size is sent in the request header,
making the thrift server to allocate a large memory segment leading to OOM.
LoadBalancer health checks are the first candidate for bogus requests
Thrift developers admit this is a known issue with TBinaryProtocol and their
recommandation is to use TCompactProtocol/TFramedTransport but this requires
all thrift clients to be updated (might not be feasible atm)
So we need a fix similar to CASSANDRA-475.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11052) Sending random data crashes thrift service
[ https://issues.apache.org/jira/browse/HBASE-11052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13979099#comment-13979099 ] Andrew Purtell commented on HBASE-11052: Looks good to me. For 0.98 and 0.96 we could keep the default in the code for hbase.regionserver.thrift.compact and hbase.regionserver.thrift.framed as 'false' but add entries to hbase-default.xml for these as 'true' with a note in the description that changing it back to the old default exposes the service to DoS. Sending random data crashes thrift service -- Key: HBASE-11052 URL: https://issues.apache.org/jira/browse/HBASE-11052 Project: HBase Issue Type: Bug Components: Thrift Affects Versions: 0.98.1, 1.0.0, 0.94.18 Reporter: Adrian Muraru Attachments: HBASE-11052_0.94_v2.patch, HBASE-11052_trunk_v1.patch Upstream thrift library has a know issue (THRIFT-601) causing the thrift server to crash with an Out-of-Memory Error when bogus requests are sent. This reproduces when a very large request size is sent in the request header, making the thrift server to allocate a large memory segment leading to OOM. LoadBalancer health checks are the first candidate for bogus requests Thrift developers admit this is a known issue with TBinaryProtocol and their recommandation is to use TCompactProtocol/TFramedTransport but this requires all thrift clients to be updated (might not be feasible atm) So we need a fix similar to CASSANDRA-475. -- This message was sent by Atlassian JIRA (v6.2#6252)
