[jira] [Commented] (HBASE-11826) Split each tableOrRegionName admin methods into two targetted methods
[
https://issues.apache.org/jira/browse/HBASE-11826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14120341#comment-14120341
]
Hadoop QA commented on HBASE-11826:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12666279/hbase-11826_v3.patch
against trunk revision .
ATTACHMENT ID: 12666279
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 167
new or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/10697//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10697//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10697//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10697//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10697//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10697//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10697//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10697//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10697//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10697//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/10697//console
This message is automatically generated.
Split each tableOrRegionName admin methods into two targetted methods
-
Key: HBASE-11826
URL: https://issues.apache.org/jira/browse/HBASE-11826
Project: HBase
Issue Type: Improvement
Reporter: Carter
Assignee: Carter
Fix For: 0.99.0, 2.0.0
Attachments: HBASE_11826.patch, HBASE_11826_v2.patch,
HBASE_11826_v2.patch, hbase-11826_v3.patch, hbase-11826_v3.patch
Purpose of this is two implement [~enis]'s suggestion to strongly type the
methods that take tableOrRegionName as an argument.
For instance:
{code}
void compact(final String tableNameOrRegionName)
void compact(final byte[] tableNameOrRegionName)
{code}
becomes
{code}
@Deprecated
void compact(final String tableNameOrRegionName)
@Deprecated
void compact(final byte[] tableNameOrRegionName)
void compact(TableName table)
void compactRegion(final byte[] regionName)
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-11826) Split each tableOrRegionName admin methods into two targetted methods
[
https://issues.apache.org/jira/browse/HBASE-11826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14120508#comment-14120508
]
Enis Soztutar commented on HBASE-11826:
---
it seems that some of the tests got killed during the jenkins run. I've run
these tests, and they are passing with the test:
{code}
mvn clean test
-Dtest=TestIdLock,TestMiniClusterLoadSequential,TestMergeTool,TestRegionSplitter,TestCoprocessorScanPolicy,TestTableInputFormatScan1,TestHFileOutputFormat2,TestAcidGuarantees,TestMiniClusterLoadEncoded,TestFSHDFSUtils
{code}
Split each tableOrRegionName admin methods into two targetted methods
-
Key: HBASE-11826
URL: https://issues.apache.org/jira/browse/HBASE-11826
Project: HBase
Issue Type: Improvement
Reporter: Carter
Assignee: Carter
Fix For: 0.99.0, 2.0.0
Attachments: HBASE_11826.patch, HBASE_11826_v2.patch,
HBASE_11826_v2.patch, hbase-11826_v3.patch, hbase-11826_v3.patch
Purpose of this is two implement [~enis]'s suggestion to strongly type the
methods that take tableOrRegionName as an argument.
For instance:
{code}
void compact(final String tableNameOrRegionName)
void compact(final byte[] tableNameOrRegionName)
{code}
becomes
{code}
@Deprecated
void compact(final String tableNameOrRegionName)
@Deprecated
void compact(final byte[] tableNameOrRegionName)
void compact(TableName table)
void compactRegion(final byte[] regionName)
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-11826) Split each tableOrRegionName admin methods into two targetted methods
[ https://issues.apache.org/jira/browse/HBASE-11826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14120611#comment-14120611 ] Hudson commented on HBASE-11826: FAILURE: Integrated in HBase-TRUNK #5463 (See [https://builds.apache.org/job/HBase-TRUNK/5463/]) HBASE-11826 Split each tableOrRegionName admin methods into two targetted methods (Carter and Enis) (enis: rev 1a6eea335f16f92e24834369cd98ea01a60b2db7) * hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverInterface.java * hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TableSnapshotInputFormatTestBase.java * hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestWithCellVisibilityLoadAndVerify.java * hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestLoadAndVerify.java * hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestTablePermissions.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRolling.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMaster.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/MonkeyFactory.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/SnapshotTableAction.java * hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsckEncryption.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionMergeTransactionOnCluster.java * hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestIngestWithEncryption.java * hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestIngest.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/ChangeVersionsAction.java * hbase-server/src/test/java/org/apache/hadoop/hbase/rest/TestTableResource.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/MoveRegionsOfTableAction.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/ChangeBloomFilterAction.java * hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverScannerOpenHook.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestEncryptionKeyRotation.java * hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java * hbase-it/src/test/java/org/apache/hadoop/hbase/mttr/IntegrationTestMTTR.java * hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDeletes.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/MergeRandomAdjacentRegionsOfTableAction.java * hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestPrefixTree.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestReplicaWithCluster.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestEndToEndSplitTransaction.java * hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/CompactRandomRegionOfTableAction.java * hbase-server/src/test/java/org/apache/hadoop/hbase/TestNamespace.java * hbase-it/src/test/java/org/apache/hadoop/hbase/trace/IntegrationTestSendTraceRequests.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/SplitRandomRegionOfTableAction.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/ChangeCompressionAction.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/MoveRandomRegionOfTableAction.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestSnapshotCloneIndependence.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestTableLockManager.java * hbase-it/src/test/java/org/apache/hadoop/hbase/mapreduce/IntegrationTestTableSnapshotInputFormat.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/FlushRandomRegionOfTableAction.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/CompactTableAction.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestEncryptionRandomKeying.java * hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestBase.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/ChangeEncodingAction.java * hbase-it/src/test/java/org/apache/hadoop/hbase/mapreduce/IntegrationTestBulkLoad.java * hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestTimeBoundedRequestsWithRegionReplicas.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RemoveColumnAction.java * hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestRegionReplicaPerf.java *
[jira] [Commented] (HBASE-11826) Split each tableOrRegionName admin methods into two targetted methods
[ https://issues.apache.org/jira/browse/HBASE-11826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14120856#comment-14120856 ] Hudson commented on HBASE-11826: FAILURE: Integrated in HBase-1.0 #150 (See [https://builds.apache.org/job/HBase-1.0/150/]) HBASE-11826 Split each tableOrRegionName admin methods into two targetted methods (Carter and Enis) (enis: rev 0cbe0522eb3ccd721a1a9b76ad1d126a6368283e) * hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestIngestWithEncryption.java * hbase-it/src/test/java/org/apache/hadoop/hbase/mapreduce/IntegrationTestTableSnapshotInputFormat.java * hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsckEncryption.java * hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestTablePermissions.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/CompactRandomRegionOfTableAction.java * hbase-server/src/test/java/org/apache/hadoop/hbase/TestNamespace.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestTableLockManager.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionMergeTransactionOnCluster.java * hbase-it/src/test/java/org/apache/hadoop/hbase/trace/IntegrationTestSendTraceRequests.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestReplicaWithCluster.java * hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverScannerOpenHook.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/AddColumnAction.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/ChangeVersionsAction.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java * hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestLoadAndVerify.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestSnapshotCloneIndependence.java * hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestTags.java * hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestPrefixTree.java * hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestIngest.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/MoveRandomRegionOfTableAction.java * hbase-it/src/test/java/org/apache/hadoop/hbase/mttr/IntegrationTestMTTR.java * hbase-server/src/test/java/org/apache/hadoop/hbase/rest/TestTableResource.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestTableSnapshotScanner.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/MergeRandomAdjacentRegionsOfTableAction.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMaster.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java * hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRolling.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestEncryptionRandomKeying.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/ChangeBloomFilterAction.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/CompactTableAction.java * hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverInterface.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/SplitRandomRegionOfTableAction.java * hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityWithCheckAuths.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/ChangeCompressionAction.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestEndToEndSplitTransaction.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/FlushTableAction.java * hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDeletes.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestEncryptionKeyRotation.java * hbase-server/src/test/java/org/apache/hadoop/hbase/migration/TestNamespaceUpgrade.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RemoveColumnAction.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/SnapshotTableAction.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/MoveRegionsOfTableAction.java * hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/ChangeEncodingAction.java * hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TableSnapshotInputFormatTestBase.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerMetrics.java *
[jira] [Commented] (HBASE-11826) Split each tableOrRegionName admin methods into two targetted methods
[
https://issues.apache.org/jira/browse/HBASE-11826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14118240#comment-14118240
]
Carter commented on HBASE-11826:
[~stack] listed a preference above to keep the deprecated methods. Can the
crew please give me guidance, and I'll be happy to remove or leave in, as
desired. I can appreciate both sides of the argument, so I'm somewhat
ambivalent.
Split each tableOrRegionName admin methods into two targetted methods
-
Key: HBASE-11826
URL: https://issues.apache.org/jira/browse/HBASE-11826
Project: HBase
Issue Type: Improvement
Reporter: Carter
Assignee: Carter
Attachments: HBASE_11826.patch, HBASE_11826_v2.patch,
HBASE_11826_v2.patch
Purpose of this is two implement [~enis]'s suggestion to strongly type the
methods that take tableOrRegionName as an argument.
For instance:
{code}
void compact(final String tableNameOrRegionName)
void compact(final byte[] tableNameOrRegionName)
{code}
becomes
{code}
@Deprecated
void compact(final String tableNameOrRegionName)
@Deprecated
void compact(final byte[] tableNameOrRegionName)
void compact(TableName table)
void compactRegion(final byte[] regionName)
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-11826) Split each tableOrRegionName admin methods into two targetted methods
[
https://issues.apache.org/jira/browse/HBASE-11826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14118553#comment-14118553
]
stack commented on HBASE-11826:
---
[~carterpage] [~anoop.hbase] is just pointing out that after this patch goes
in, we can remove the deprecated methods (in new issue) in trunk. Makes sense
to me. Lets get this into branch-1 and master first. @enis and [~ndimiduk],
you fellas good w/ this? Will commit tomorrow unless objection.
Split each tableOrRegionName admin methods into two targetted methods
-
Key: HBASE-11826
URL: https://issues.apache.org/jira/browse/HBASE-11826
Project: HBase
Issue Type: Improvement
Reporter: Carter
Assignee: Carter
Attachments: HBASE_11826.patch, HBASE_11826_v2.patch,
HBASE_11826_v2.patch
Purpose of this is two implement [~enis]'s suggestion to strongly type the
methods that take tableOrRegionName as an argument.
For instance:
{code}
void compact(final String tableNameOrRegionName)
void compact(final byte[] tableNameOrRegionName)
{code}
becomes
{code}
@Deprecated
void compact(final String tableNameOrRegionName)
@Deprecated
void compact(final byte[] tableNameOrRegionName)
void compact(TableName table)
void compactRegion(final byte[] regionName)
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-11826) Split each tableOrRegionName admin methods into two targetted methods
[
https://issues.apache.org/jira/browse/HBASE-11826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14118688#comment-14118688
]
Enis Soztutar commented on HBASE-11826:
---
{{Admin}} is a new interface in 0.99+. Thus I think we do not want to include
methods with tableOrRegionName args there. Let's keep them in HBaseAdmin though
for BC. Agreed with Stack that we can focus on getting rid of all deprecated
stuff for 2.0 later. I'll upload a new patch shortly.
Split each tableOrRegionName admin methods into two targetted methods
-
Key: HBASE-11826
URL: https://issues.apache.org/jira/browse/HBASE-11826
Project: HBase
Issue Type: Improvement
Reporter: Carter
Assignee: Carter
Fix For: 0.99.0, 2.0.0
Attachments: HBASE_11826.patch, HBASE_11826_v2.patch,
HBASE_11826_v2.patch
Purpose of this is two implement [~enis]'s suggestion to strongly type the
methods that take tableOrRegionName as an argument.
For instance:
{code}
void compact(final String tableNameOrRegionName)
void compact(final byte[] tableNameOrRegionName)
{code}
becomes
{code}
@Deprecated
void compact(final String tableNameOrRegionName)
@Deprecated
void compact(final byte[] tableNameOrRegionName)
void compact(TableName table)
void compactRegion(final byte[] regionName)
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-11826) Split each tableOrRegionName admin methods into two targetted methods
[
https://issues.apache.org/jira/browse/HBASE-11826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14118702#comment-14118702
]
stack commented on HBASE-11826:
---
@enis I like that (not adding to the new Interface but leaving in HBA)
Split each tableOrRegionName admin methods into two targetted methods
-
Key: HBASE-11826
URL: https://issues.apache.org/jira/browse/HBASE-11826
Project: HBase
Issue Type: Improvement
Reporter: Carter
Assignee: Carter
Fix For: 0.99.0, 2.0.0
Attachments: HBASE_11826.patch, HBASE_11826_v2.patch,
HBASE_11826_v2.patch
Purpose of this is two implement [~enis]'s suggestion to strongly type the
methods that take tableOrRegionName as an argument.
For instance:
{code}
void compact(final String tableNameOrRegionName)
void compact(final byte[] tableNameOrRegionName)
{code}
becomes
{code}
@Deprecated
void compact(final String tableNameOrRegionName)
@Deprecated
void compact(final byte[] tableNameOrRegionName)
void compact(TableName table)
void compactRegion(final byte[] regionName)
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-11826) Split each tableOrRegionName admin methods into two targetted methods
[
https://issues.apache.org/jira/browse/HBASE-11826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14116479#comment-14116479
]
Anoop Sam John commented on HBASE-11826:
In branch-1 we keep the old methods deprecated. In trunk we can remove?
Split each tableOrRegionName admin methods into two targetted methods
-
Key: HBASE-11826
URL: https://issues.apache.org/jira/browse/HBASE-11826
Project: HBase
Issue Type: Improvement
Reporter: Carter
Assignee: Carter
Attachments: HBASE_11826.patch, HBASE_11826_v2.patch,
HBASE_11826_v2.patch
Purpose of this is two implement [~enis]'s suggestion to strongly type the
methods that take tableOrRegionName as an argument.
For instance:
{code}
void compact(final String tableNameOrRegionName)
void compact(final byte[] tableNameOrRegionName)
{code}
becomes
{code}
@Deprecated
void compact(final String tableNameOrRegionName)
@Deprecated
void compact(final byte[] tableNameOrRegionName)
void compact(TableName table)
void compactRegion(final byte[] regionName)
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11826) Split each tableOrRegionName admin methods into two targetted methods
[
https://issues.apache.org/jira/browse/HBASE-11826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14115737#comment-14115737
]
Hadoop QA commented on HBASE-11826:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12665382/HBASE_11826_v2.patch
against trunk revision .
ATTACHMENT ID: 12665382
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.TestRegionRebalancing
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/10647//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10647//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10647//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10647//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10647//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10647//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10647//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10647//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10647//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10647//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/10647//console
This message is automatically generated.
Split each tableOrRegionName admin methods into two targetted methods
-
Key: HBASE-11826
URL: https://issues.apache.org/jira/browse/HBASE-11826
Project: HBase
Issue Type: Improvement
Reporter: Carter
Assignee: Carter
Attachments: HBASE_11826.patch, HBASE_11826_v2.patch,
HBASE_11826_v2.patch
Purpose of this is two implement [~enis]'s suggestion to strongly type the
methods that take tableOrRegionName as an argument.
For instance:
{code}
void compact(final String tableNameOrRegionName)
void compact(final byte[] tableNameOrRegionName)
{code}
becomes
{code}
@Deprecated
void compact(final String tableNameOrRegionName)
@Deprecated
void compact(final byte[] tableNameOrRegionName)
void compact(TableName table)
void compactRegion(final byte[] regionName)
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11826) Split each tableOrRegionName admin methods into two targetted methods
[
https://issues.apache.org/jira/browse/HBASE-11826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114407#comment-14114407
]
Carter commented on HBASE-11826:
Patch added with deprecation annotations. Methods refactored to put the logic
in non-deprecated code paths.
Split each tableOrRegionName admin methods into two targetted methods
-
Key: HBASE-11826
URL: https://issues.apache.org/jira/browse/HBASE-11826
Project: HBase
Issue Type: Improvement
Reporter: Carter
Assignee: Carter
Attachments: HBASE_11826.patch, HBASE_11826_v2.patch
Purpose of this is two implement [~enis]'s suggestion to strongly type the
methods that take tableOrRegionName as an argument.
For instance:
{code}
void compact(final String tableNameOrRegionName)
void compact(final byte[] tableNameOrRegionName)
{code}
becomes
{code}
@Deprecated
void compact(final String tableNameOrRegionName)
@Deprecated
void compact(final byte[] tableNameOrRegionName)
void compact(TableName table)
void compactRegion(final byte[] regionName)
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11826) Split each tableOrRegionName admin methods into two targetted methods
[
https://issues.apache.org/jira/browse/HBASE-11826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14114558#comment-14114558
]
Hadoop QA commented on HBASE-11826:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12665088/HBASE_11826_v2.patch
against trunk revision .
ATTACHMENT ID: 12665088
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/10624//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10624//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10624//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10624//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10624//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10624//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10624//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10624//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10624//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10624//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/10624//console
This message is automatically generated.
Split each tableOrRegionName admin methods into two targetted methods
-
Key: HBASE-11826
URL: https://issues.apache.org/jira/browse/HBASE-11826
Project: HBase
Issue Type: Improvement
Reporter: Carter
Assignee: Carter
Attachments: HBASE_11826.patch, HBASE_11826_v2.patch
Purpose of this is two implement [~enis]'s suggestion to strongly type the
methods that take tableOrRegionName as an argument.
For instance:
{code}
void compact(final String tableNameOrRegionName)
void compact(final byte[] tableNameOrRegionName)
{code}
becomes
{code}
@Deprecated
void compact(final String tableNameOrRegionName)
@Deprecated
void compact(final byte[] tableNameOrRegionName)
void compact(TableName table)
void compactRegion(final byte[] regionName)
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11826) Split each tableOrRegionName admin methods into two targetted methods
[
https://issues.apache.org/jira/browse/HBASE-11826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14110748#comment-14110748
]
Carter commented on HBASE-11826:
First question about this refactor: _Deprecate the old methods or remove them
entirely?_
One the one hand, deprecating them makes it easier for someone to move
seamlessly to the new interface. On the other hand, this might muddy the new
interface on day one. If a user is already putting in the effort to move to
the new interface, shouldn't they just clean up these method calls at the same
time?
Thoughts?
Split each tableOrRegionName admin methods into two targetted methods
-
Key: HBASE-11826
URL: https://issues.apache.org/jira/browse/HBASE-11826
Project: HBase
Issue Type: Improvement
Reporter: Carter
Assignee: Carter
Purpose of this is two implement [~enis]'s suggestion to strongly type the
methods that take tableOrRegionName as an argument.
For instance:
{code}
void compact(final String tableNameOrRegionName)
void compact(final byte[] tableNameOrRegionName)
{code}
becomes
{code}
@Deprecated
void compact(final String tableNameOrRegionName)
@Deprecated
void compact(final byte[] tableNameOrRegionName)
void compact(TableName table)
void compactRegion(final byte[] regionName)
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11826) Split each tableOrRegionName admin methods into two targetted methods
[
https://issues.apache.org/jira/browse/HBASE-11826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14110791#comment-14110791
]
Carter commented on HBASE-11826:
This patch is ready to upload. Just need a decision on whether to include the
@Deprecated methods in the interface.
Split each tableOrRegionName admin methods into two targetted methods
-
Key: HBASE-11826
URL: https://issues.apache.org/jira/browse/HBASE-11826
Project: HBase
Issue Type: Improvement
Reporter: Carter
Assignee: Carter
Purpose of this is two implement [~enis]'s suggestion to strongly type the
methods that take tableOrRegionName as an argument.
For instance:
{code}
void compact(final String tableNameOrRegionName)
void compact(final byte[] tableNameOrRegionName)
{code}
becomes
{code}
@Deprecated
void compact(final String tableNameOrRegionName)
@Deprecated
void compact(final byte[] tableNameOrRegionName)
void compact(TableName table)
void compactRegion(final byte[] regionName)
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11826) Split each tableOrRegionName admin methods into two targetted methods
[
https://issues.apache.org/jira/browse/HBASE-11826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14110793#comment-14110793
]
stack commented on HBASE-11826:
---
IMO, need to keep the old stuff for 1.0. This stuff has been around a long time
so probably a few tools out there that rely on it. We want folks to be able to
go from 0.94 to 1.0 w/o too much hassle.
Split each tableOrRegionName admin methods into two targetted methods
-
Key: HBASE-11826
URL: https://issues.apache.org/jira/browse/HBASE-11826
Project: HBase
Issue Type: Improvement
Reporter: Carter
Assignee: Carter
Purpose of this is two implement [~enis]'s suggestion to strongly type the
methods that take tableOrRegionName as an argument.
For instance:
{code}
void compact(final String tableNameOrRegionName)
void compact(final byte[] tableNameOrRegionName)
{code}
becomes
{code}
@Deprecated
void compact(final String tableNameOrRegionName)
@Deprecated
void compact(final byte[] tableNameOrRegionName)
void compact(TableName table)
void compactRegion(final byte[] regionName)
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11826) Split each tableOrRegionName admin methods into two targetted methods
[
https://issues.apache.org/jira/browse/HBASE-11826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14111005#comment-14111005
]
Hadoop QA commented on HBASE-11826:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12664413/HBASE_11826.patch
against trunk revision .
ATTACHMENT ID: 12664413
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/10590//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10590//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10590//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10590//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10590//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10590//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10590//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10590//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10590//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10590//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/10590//console
This message is automatically generated.
Split each tableOrRegionName admin methods into two targetted methods
-
Key: HBASE-11826
URL: https://issues.apache.org/jira/browse/HBASE-11826
Project: HBase
Issue Type: Improvement
Reporter: Carter
Assignee: Carter
Attachments: HBASE_11826.patch
Purpose of this is two implement [~enis]'s suggestion to strongly type the
methods that take tableOrRegionName as an argument.
For instance:
{code}
void compact(final String tableNameOrRegionName)
void compact(final byte[] tableNameOrRegionName)
{code}
becomes
{code}
@Deprecated
void compact(final String tableNameOrRegionName)
@Deprecated
void compact(final byte[] tableNameOrRegionName)
void compact(TableName table)
void compactRegion(final byte[] regionName)
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11826) Split each tableOrRegionName admin methods into two targetted methods
[
https://issues.apache.org/jira/browse/HBASE-11826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1465#comment-1465
]
Nick Dimiduk commented on HBASE-11826:
--
Patch is looking good overall. A couple points of cleanup:
- include deprecation annotations on the implementation methods, not just at
the API layer.
- implementation itself should be moved to the non-deprecated method, and the
deprecated APIs should call to the new implementations when appropriate. For
instance {{flush(byte[] tableNameOrRegionName)}} should do any parsing it needs
to do and defer to {{flush(TableName)}} or {{flushRegion(byte[])}} as
appropriate.
Split each tableOrRegionName admin methods into two targetted methods
-
Key: HBASE-11826
URL: https://issues.apache.org/jira/browse/HBASE-11826
Project: HBase
Issue Type: Improvement
Reporter: Carter
Assignee: Carter
Attachments: HBASE_11826.patch
Purpose of this is two implement [~enis]'s suggestion to strongly type the
methods that take tableOrRegionName as an argument.
For instance:
{code}
void compact(final String tableNameOrRegionName)
void compact(final byte[] tableNameOrRegionName)
{code}
becomes
{code}
@Deprecated
void compact(final String tableNameOrRegionName)
@Deprecated
void compact(final byte[] tableNameOrRegionName)
void compact(TableName table)
void compactRegion(final byte[] regionName)
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
