[jira] [Commented] (HBASE-12279) Generated thrift files were generated with the wrong parameters
[
https://issues.apache.org/jira/browse/HBASE-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14209397#comment-14209397
]
Lars Hofhansl commented on HBASE-12279:
---
Thanks [~apurtell].
Generated thrift files were generated with the wrong parameters
---
Key: HBASE-12279
URL: https://issues.apache.org/jira/browse/HBASE-12279
Project: HBase
Issue Type: Bug
Affects Versions: 0.94.0, 0.98.0, 0.99.0
Reporter: Niels Basjes
Assignee: Niels Basjes
Fix For: 2.0.0, 0.98.8, 0.94.26, 0.99.2
Attachments: HBASE-12279-2014-10-16-v1.patch,
HBASE-12279-2014-11-07-v2.patch
It turns out that the java code generated from the thrift files have been
generated with the wrong settings.
Instead of the documented
([thrift|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift/package-summary.html],
[thrift2|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift2/package-summary.html])
{code}
thrift -strict --gen java:hashcode
{code}
the current files seem to be generated instead with
{code}
thrift -strict --gen java
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12279) Generated thrift files were generated with the wrong parameters
[
https://issues.apache.org/jira/browse/HBASE-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14207301#comment-14207301
]
stack commented on HBASE-12279:
---
[~apurtell] FYI, [~larsh] gives his blessing above -- you seem to have missed
his message.
Generated thrift files were generated with the wrong parameters
---
Key: HBASE-12279
URL: https://issues.apache.org/jira/browse/HBASE-12279
Project: HBase
Issue Type: Bug
Affects Versions: 0.94.0, 0.98.0, 0.99.0
Reporter: Niels Basjes
Assignee: Niels Basjes
Fix For: 2.0.0, 0.98.8, 0.94.26, 0.99.2
Attachments: HBASE-12279-2014-10-16-v1.patch,
HBASE-12279-2014-11-07-v2.patch
It turns out that the java code generated from the thrift files have been
generated with the wrong settings.
Instead of the documented
([thrift|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift/package-summary.html],
[thrift2|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift2/package-summary.html])
{code}
thrift -strict --gen java:hashcode
{code}
the current files seem to be generated instead with
{code}
thrift -strict --gen java
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12279) Generated thrift files were generated with the wrong parameters
[
https://issues.apache.org/jira/browse/HBASE-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14207394#comment-14207394
]
Hudson commented on HBASE-12279:
FAILURE: Integrated in HBase-0.94 #1440 (See
[https://builds.apache.org/job/HBase-0.94/1440/])
HBASE-12279 Generated thrift files were generated with the wrong parameters
(Niels Basjes) (apurtell: rev 7ddd9e4c45dadb788e1a8c6f5bb9f8e591ba9a73)
* src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java
* src/main/java/org/apache/hadoop/hbase/thrift/generated/ColumnDescriptor.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/TMutation.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/TGet.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/TIllegalArgument.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/TResult.java
* src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/TColumn.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/TColumnValue.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/TRowMutations.java
* src/main/java/org/apache/hadoop/hbase/thrift/generated/TCell.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/TDelete.java
* src/main/java/org/apache/hadoop/hbase/thrift/generated/IOError.java
* src/main/java/org/apache/hadoop/hbase/thrift/generated/AlreadyExists.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/TPut.java
* src/main/java/org/apache/hadoop/hbase/thrift/generated/TRegionInfo.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/TTimeRange.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/TIncrement.java
* src/main/java/org/apache/hadoop/hbase/thrift/generated/TIncrement.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/TIOError.java
* src/main/java/org/apache/hadoop/hbase/thrift/generated/TRowResult.java
* src/main/java/org/apache/hadoop/hbase/thrift/generated/IllegalArgument.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/TScan.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/TColumnIncrement.java
* src/main/java/org/apache/hadoop/hbase/thrift/generated/TScan.java
* src/main/java/org/apache/hadoop/hbase/thrift/generated/TColumn.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/THBaseService.java
* src/main/java/org/apache/hadoop/hbase/thrift/generated/BatchMutation.java
Generated thrift files were generated with the wrong parameters
---
Key: HBASE-12279
URL: https://issues.apache.org/jira/browse/HBASE-12279
Project: HBase
Issue Type: Bug
Affects Versions: 0.94.0, 0.98.0, 0.99.0
Reporter: Niels Basjes
Assignee: Niels Basjes
Fix For: 2.0.0, 0.98.8, 0.94.26, 0.99.2
Attachments: HBASE-12279-2014-10-16-v1.patch,
HBASE-12279-2014-11-07-v2.patch
It turns out that the java code generated from the thrift files have been
generated with the wrong settings.
Instead of the documented
([thrift|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift/package-summary.html],
[thrift2|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift2/package-summary.html])
{code}
thrift -strict --gen java:hashcode
{code}
the current files seem to be generated instead with
{code}
thrift -strict --gen java
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12279) Generated thrift files were generated with the wrong parameters
[
https://issues.apache.org/jira/browse/HBASE-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14207459#comment-14207459
]
Hudson commented on HBASE-12279:
SUCCESS: Integrated in HBase-0.94-security #554 (See
[https://builds.apache.org/job/HBase-0.94-security/554/])
HBASE-12279 Generated thrift files were generated with the wrong parameters
(Niels Basjes) (apurtell: rev 7ddd9e4c45dadb788e1a8c6f5bb9f8e591ba9a73)
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/TResult.java
* src/main/java/org/apache/hadoop/hbase/thrift/generated/TColumn.java
* src/main/java/org/apache/hadoop/hbase/thrift/generated/TIncrement.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/TPut.java
* src/main/java/org/apache/hadoop/hbase/thrift/generated/IOError.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/TMutation.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/TDelete.java
* src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java
* src/main/java/org/apache/hadoop/hbase/thrift/generated/BatchMutation.java
* src/main/java/org/apache/hadoop/hbase/thrift/generated/TScan.java
* src/main/java/org/apache/hadoop/hbase/thrift/generated/IllegalArgument.java
* src/main/java/org/apache/hadoop/hbase/thrift/generated/ColumnDescriptor.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/TIllegalArgument.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/TGet.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/THBaseService.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/TTimeRange.java
* src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/TColumnValue.java
* src/main/java/org/apache/hadoop/hbase/thrift/generated/AlreadyExists.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/TColumnIncrement.java
* src/main/java/org/apache/hadoop/hbase/thrift/generated/TCell.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/TIncrement.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/TScan.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/TRowMutations.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/TColumn.java
* src/main/java/org/apache/hadoop/hbase/thrift/generated/TRegionInfo.java
* src/main/java/org/apache/hadoop/hbase/thrift/generated/TRowResult.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/TIOError.java
Generated thrift files were generated with the wrong parameters
---
Key: HBASE-12279
URL: https://issues.apache.org/jira/browse/HBASE-12279
Project: HBase
Issue Type: Bug
Affects Versions: 0.94.0, 0.98.0, 0.99.0
Reporter: Niels Basjes
Assignee: Niels Basjes
Fix For: 2.0.0, 0.98.8, 0.94.26, 0.99.2
Attachments: HBASE-12279-2014-10-16-v1.patch,
HBASE-12279-2014-11-07-v2.patch
It turns out that the java code generated from the thrift files have been
generated with the wrong settings.
Instead of the documented
([thrift|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift/package-summary.html],
[thrift2|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift2/package-summary.html])
{code}
thrift -strict --gen java:hashcode
{code}
the current files seem to be generated instead with
{code}
thrift -strict --gen java
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12279) Generated thrift files were generated with the wrong parameters
[
https://issues.apache.org/jira/browse/HBASE-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14207479#comment-14207479
]
Hudson commented on HBASE-12279:
SUCCESS: Integrated in HBase-0.94-JDK7 #209 (See
[https://builds.apache.org/job/HBase-0.94-JDK7/209/])
HBASE-12279 Generated thrift files were generated with the wrong parameters
(Niels Basjes) (apurtell: rev 7ddd9e4c45dadb788e1a8c6f5bb9f8e591ba9a73)
* src/main/java/org/apache/hadoop/hbase/thrift/generated/IllegalArgument.java
* src/main/java/org/apache/hadoop/hbase/thrift/generated/TScan.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/TMutation.java
* src/main/java/org/apache/hadoop/hbase/thrift/generated/TCell.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/TPut.java
* src/main/java/org/apache/hadoop/hbase/thrift/generated/TRegionInfo.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/TResult.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/TScan.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/TColumn.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/TGet.java
* src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java
* src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/TRowMutations.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/TTimeRange.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/TDelete.java
* src/main/java/org/apache/hadoop/hbase/thrift/generated/BatchMutation.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/TColumnValue.java
* src/main/java/org/apache/hadoop/hbase/thrift/generated/TRowResult.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/TIllegalArgument.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/TIOError.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/TColumnIncrement.java
* src/main/java/org/apache/hadoop/hbase/thrift/generated/IOError.java
* src/main/java/org/apache/hadoop/hbase/thrift/generated/TColumn.java
* src/main/java/org/apache/hadoop/hbase/thrift/generated/AlreadyExists.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/TIncrement.java
* src/main/java/org/apache/hadoop/hbase/thrift2/generated/THBaseService.java
* src/main/java/org/apache/hadoop/hbase/thrift/generated/ColumnDescriptor.java
* src/main/java/org/apache/hadoop/hbase/thrift/generated/TIncrement.java
Generated thrift files were generated with the wrong parameters
---
Key: HBASE-12279
URL: https://issues.apache.org/jira/browse/HBASE-12279
Project: HBase
Issue Type: Bug
Affects Versions: 0.94.0, 0.98.0, 0.99.0
Reporter: Niels Basjes
Assignee: Niels Basjes
Fix For: 2.0.0, 0.98.8, 0.94.26, 0.99.2
Attachments: HBASE-12279-2014-10-16-v1.patch,
HBASE-12279-2014-11-07-v2.patch
It turns out that the java code generated from the thrift files have been
generated with the wrong settings.
Instead of the documented
([thrift|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift/package-summary.html],
[thrift2|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift2/package-summary.html])
{code}
thrift -strict --gen java:hashcode
{code}
the current files seem to be generated instead with
{code}
thrift -strict --gen java
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12279) Generated thrift files were generated with the wrong parameters
[
https://issues.apache.org/jira/browse/HBASE-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14205668#comment-14205668
]
Andrew Purtell commented on HBASE-12279:
Do you want this in 0.94 [~lhofhansl]?
Generated thrift files were generated with the wrong parameters
---
Key: HBASE-12279
URL: https://issues.apache.org/jira/browse/HBASE-12279
Project: HBase
Issue Type: Bug
Affects Versions: 0.94.0, 0.98.0, 0.99.0
Reporter: Niels Basjes
Assignee: Niels Basjes
Fix For: 2.0.0, 0.98.8, 0.94.26, 0.99.2
Attachments: HBASE-12279-2014-10-16-v1.patch,
HBASE-12279-2014-11-07-v2.patch
It turns out that the java code generated from the thrift files have been
generated with the wrong settings.
Instead of the documented
([thrift|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift/package-summary.html],
[thrift2|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift2/package-summary.html])
{code}
thrift -strict --gen java:hashcode
{code}
the current files seem to be generated instead with
{code}
thrift -strict --gen java
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12279) Generated thrift files were generated with the wrong parameters
[
https://issues.apache.org/jira/browse/HBASE-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14201905#comment-14201905
]
Hadoop QA commented on HBASE-12279:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12680115/HBASE-12279-2014-11-07-v2.patch
against trunk revision .
ATTACHMENT ID: 12680115
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 javac{color}. The applied patch generated 108 javac compiler
warnings (more than the trunk's current 102 warnings).
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+lastComparison =
Boolean.valueOf(isSetAuthorizations()).compareTo(typedOther.isSetAuthorizations());
+lastComparison =
Boolean.valueOf(isSetCellVisibility()).compareTo(typedOther.isSetCellVisibility());
+lastComparison =
Boolean.valueOf(isSetAuthorizations()).compareTo(typedOther.isSetAuthorizations());
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11613//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11613//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11613//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11613//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11613//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11613//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11613//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11613//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11613//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11613//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11613//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11613//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/11613//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11613//console
This message is automatically generated.
Generated thrift files were generated with the wrong parameters
---
Key: HBASE-12279
URL: https://issues.apache.org/jira/browse/HBASE-12279
Project: HBase
Issue Type: Bug
Affects Versions: 0.94.0, 0.98.0, 0.99.0
Reporter: Niels Basjes
Fix For: 2.0.0, 0.98.8, 0.94.26, 0.99.2
Attachments: HBASE-12279-2014-10-16-v1.patch,
HBASE-12279-2014-11-07-v2.patch
It turns out that the java code generated from the thrift files have been
generated with the wrong settings.
Instead of the documented
([thrift|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift/package-summary.html],
[thrift2|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift2/package-summary.html])
{code}
thrift -strict --gen java:hashcode
{code}
the
[jira] [Commented] (HBASE-12279) Generated thrift files were generated with the wrong parameters
[
https://issues.apache.org/jira/browse/HBASE-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14202825#comment-14202825
]
Niels Basjes commented on HBASE-12279:
--
Ehhh, does it or does it not increase the javac compiler warnings? Hickup in
Jenkins?
{code}-1 javac. The applied patch generated 108 javac compiler warnings (more
than the trunk's current 102 warnings).
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.{code}
Generated thrift files were generated with the wrong parameters
---
Key: HBASE-12279
URL: https://issues.apache.org/jira/browse/HBASE-12279
Project: HBase
Issue Type: Bug
Affects Versions: 0.94.0, 0.98.0, 0.99.0
Reporter: Niels Basjes
Fix For: 2.0.0, 0.98.8, 0.94.26, 0.99.2
Attachments: HBASE-12279-2014-10-16-v1.patch,
HBASE-12279-2014-11-07-v2.patch
It turns out that the java code generated from the thrift files have been
generated with the wrong settings.
Instead of the documented
([thrift|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift/package-summary.html],
[thrift2|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift2/package-summary.html])
{code}
thrift -strict --gen java:hashcode
{code}
the current files seem to be generated instead with
{code}
thrift -strict --gen java
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12279) Generated thrift files were generated with the wrong parameters
[
https://issues.apache.org/jira/browse/HBASE-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14202993#comment-14202993
]
Andrew Purtell commented on HBASE-12279:
Running the commands listed by [~nielsbasjes] above and committing to 0.98+ now.
Generated thrift files were generated with the wrong parameters
---
Key: HBASE-12279
URL: https://issues.apache.org/jira/browse/HBASE-12279
Project: HBase
Issue Type: Bug
Affects Versions: 0.94.0, 0.98.0, 0.99.0
Reporter: Niels Basjes
Fix For: 2.0.0, 0.98.8, 0.94.26, 0.99.2
Attachments: HBASE-12279-2014-10-16-v1.patch,
HBASE-12279-2014-11-07-v2.patch
It turns out that the java code generated from the thrift files have been
generated with the wrong settings.
Instead of the documented
([thrift|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift/package-summary.html],
[thrift2|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift2/package-summary.html])
{code}
thrift -strict --gen java:hashcode
{code}
the current files seem to be generated instead with
{code}
thrift -strict --gen java
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12279) Generated thrift files were generated with the wrong parameters
[
https://issues.apache.org/jira/browse/HBASE-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14203080#comment-14203080
]
Andrew Purtell commented on HBASE-12279:
'mvn generate-sources -Pcompile-thrift' works for 0.98 and higher. We are
missing this for 0.94. I regenerated files for 0.94 using version 0.8.0 of the
compiler by hand.
Regenerated Thrift for 0.98+ with compiler Thrift version 0.9.0
*0.98 tests*
{noformat}
Running org.apache.hadoop.hbase.thrift.TestThriftServerCmdLine
Tests run: 32, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 68.372 sec
Running org.apache.hadoop.hbase.thrift.TestThriftServer
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 58.219 sec
Running org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler
Tests run: 20, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 18.955 sec
Running org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandlerWithLabels
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 21.931 sec
Results :
Tests run: 59, Failures: 0, Errors: 0, Skipped: 0
{noformat}
*branch-1 tests*
{noformat}
Running org.apache.hadoop.hbase.thrift.TestThriftServerCmdLine
Tests run: 32, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 60.84 sec - in
org.apache.hadoop.hbase.thrift.TestThriftServerCmdLine
Running org.apache.hadoop.hbase.thrift.TestThriftServer
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 51.037 sec - in
org.apache.hadoop.hbase.thrift.TestThriftServer
Running org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler
Tests run: 21, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 13.799 sec -
in org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler
Running org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandlerWithLabels
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 12.776 sec - in
org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandlerWithLabels
Results :
Tests run: 60, Failures: 0, Errors: 0, Skipped: 0
{noformat}
*master tests*
{noformat}
Running org.apache.hadoop.hbase.thrift.TestThriftServerCmdLine
Tests run: 32, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 59.82 sec - in
org.apache.hadoop.hbase.thrift.TestThriftServerCmdLine
Running org.apache.hadoop.hbase.thrift.TestThriftServer
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 53.724 sec - in
org.apache.hadoop.hbase.thrift.TestThriftServer
Running org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler
Tests run: 21, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 13.98 sec - in
org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler
Running org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandlerWithLabels
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 15.261 sec - in
org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandlerWithLabels
Results :
Tests run: 60, Failures: 0, Errors: 0, Skipped: 0
{noformat}
Regenerated Thrift for 0.94 with compiler Thrift version 0.8.0. Built this
version of the compiler from the Thrift 0.8.0 distribution tarball downloaded
from archive.apache.org.
*0.94 tests*
{noformat}
Running org.apache.hadoop.hbase.thrift.TestThriftServerCmdLine
Tests run: 20, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 317.191 sec
Running org.apache.hadoop.hbase.thrift.TestThriftServer
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 40.331 sec
Running org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler
Tests run: 19, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 14.159 sec
Results :
Tests run: 40, Failures: 0, Errors: 0, Skipped: 0
{noformat}
Going to commit 0.98+ shortly unless objection.
Going to commit 0.94 over the weekend probably, ping [~lhofhansl]
Generated thrift files were generated with the wrong parameters
---
Key: HBASE-12279
URL: https://issues.apache.org/jira/browse/HBASE-12279
Project: HBase
Issue Type: Bug
Affects Versions: 0.94.0, 0.98.0, 0.99.0
Reporter: Niels Basjes
Assignee: Niels Basjes
Fix For: 2.0.0, 0.98.8, 0.94.26, 0.99.2
Attachments: HBASE-12279-2014-10-16-v1.patch,
HBASE-12279-2014-11-07-v2.patch
It turns out that the java code generated from the thrift files have been
generated with the wrong settings.
Instead of the documented
([thrift|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift/package-summary.html],
[thrift2|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift2/package-summary.html])
{code}
thrift -strict --gen java:hashcode
{code}
the current files seem to be generated instead with
{code}
thrift -strict --gen java
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12279) Generated thrift files were generated with the wrong parameters
[
https://issues.apache.org/jira/browse/HBASE-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14203156#comment-14203156
]
Andrew Purtell commented on HBASE-12279:
Pushed to 0.98+
Generated thrift files were generated with the wrong parameters
---
Key: HBASE-12279
URL: https://issues.apache.org/jira/browse/HBASE-12279
Project: HBase
Issue Type: Bug
Affects Versions: 0.94.0, 0.98.0, 0.99.0
Reporter: Niels Basjes
Assignee: Niels Basjes
Fix For: 2.0.0, 0.98.8, 0.94.26, 0.99.2
Attachments: HBASE-12279-2014-10-16-v1.patch,
HBASE-12279-2014-11-07-v2.patch
It turns out that the java code generated from the thrift files have been
generated with the wrong settings.
Instead of the documented
([thrift|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift/package-summary.html],
[thrift2|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift2/package-summary.html])
{code}
thrift -strict --gen java:hashcode
{code}
the current files seem to be generated instead with
{code}
thrift -strict --gen java
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12279) Generated thrift files were generated with the wrong parameters
[
https://issues.apache.org/jira/browse/HBASE-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14203182#comment-14203182
]
Hudson commented on HBASE-12279:
FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #633 (See
[https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/633/])
HBASE-12279 Generated thrift files were generated with the wrong parameters
(Niels Basjes) (apurtell: rev c526bf98c35f0418b5df6b4827e9681879eb5f04)
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TColumn.java
* hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TGet.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/IOError.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TColumnValue.java
* hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TCell.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/ColumnDescriptor.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TIllegalArgument.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TAppend.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TColumn.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TIOError.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TTimeRange.java
* hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TScan.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TColumnIncrement.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TRowMutations.java
* hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TRegionInfo.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/THBaseService.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/IllegalArgument.java
* hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TPut.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TIncrement.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TIncrement.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TScan.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TMutation.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TDelete.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TRowResult.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/AlreadyExists.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TResult.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/BatchMutation.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TCellVisibility.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TAuthorization.java
Generated thrift files were generated with the wrong parameters
---
Key: HBASE-12279
URL: https://issues.apache.org/jira/browse/HBASE-12279
Project: HBase
Issue Type: Bug
Affects Versions: 0.94.0, 0.98.0, 0.99.0
Reporter: Niels Basjes
Assignee: Niels Basjes
Fix For: 2.0.0, 0.98.8, 0.94.26, 0.99.2
Attachments: HBASE-12279-2014-10-16-v1.patch,
HBASE-12279-2014-11-07-v2.patch
It turns out that the java code generated from the thrift files have been
generated with the wrong settings.
Instead of the documented
([thrift|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift/package-summary.html],
[thrift2|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift2/package-summary.html])
{code}
thrift -strict --gen java:hashcode
{code}
the current files seem to be generated instead with
{code}
thrift -strict --gen java
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12279) Generated thrift files were generated with the wrong parameters
[
https://issues.apache.org/jira/browse/HBASE-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14203184#comment-14203184
]
Lars Hofhansl commented on HBASE-12279:
---
Feel free to commit to 0.94 and close.
If I spin a new RC I'll pull this into 0.94.25, otherwise it goes into 0.94.26.
Generated thrift files were generated with the wrong parameters
---
Key: HBASE-12279
URL: https://issues.apache.org/jira/browse/HBASE-12279
Project: HBase
Issue Type: Bug
Affects Versions: 0.94.0, 0.98.0, 0.99.0
Reporter: Niels Basjes
Assignee: Niels Basjes
Fix For: 2.0.0, 0.98.8, 0.94.26, 0.99.2
Attachments: HBASE-12279-2014-10-16-v1.patch,
HBASE-12279-2014-11-07-v2.patch
It turns out that the java code generated from the thrift files have been
generated with the wrong settings.
Instead of the documented
([thrift|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift/package-summary.html],
[thrift2|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift2/package-summary.html])
{code}
thrift -strict --gen java:hashcode
{code}
the current files seem to be generated instead with
{code}
thrift -strict --gen java
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12279) Generated thrift files were generated with the wrong parameters
[
https://issues.apache.org/jira/browse/HBASE-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14203201#comment-14203201
]
Hudson commented on HBASE-12279:
SUCCESS: Integrated in HBase-1.0 #447 (See
[https://builds.apache.org/job/HBase-1.0/447/])
HBASE-12279 Generated thrift files were generated with the wrong parameters
(Niels Basjes) (apurtell: rev a8734c3a4a38d5401f2f30dbde5e8165057f4f41)
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TRowMutations.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/ColumnDescriptor.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TAppend.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/BatchMutation.java
* hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TGet.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TColumnIncrement.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TIllegalArgument.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TTimeRange.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TAuthorization.java
* hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TIncrement.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/IllegalArgument.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TScan.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TColumn.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TColumn.java
* hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TCell.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TColumnValue.java
* hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TScan.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TDelete.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/THBaseService.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TRegionInfo.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TIOError.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/IOError.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TResult.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TAppend.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TIncrement.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TRowResult.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/AlreadyExists.java
* hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TPut.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TMutation.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TCellVisibility.java
Generated thrift files were generated with the wrong parameters
---
Key: HBASE-12279
URL: https://issues.apache.org/jira/browse/HBASE-12279
Project: HBase
Issue Type: Bug
Affects Versions: 0.94.0, 0.98.0, 0.99.0
Reporter: Niels Basjes
Assignee: Niels Basjes
Fix For: 2.0.0, 0.98.8, 0.94.26, 0.99.2
Attachments: HBASE-12279-2014-10-16-v1.patch,
HBASE-12279-2014-11-07-v2.patch
It turns out that the java code generated from the thrift files have been
generated with the wrong settings.
Instead of the documented
([thrift|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift/package-summary.html],
[thrift2|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift2/package-summary.html])
{code}
thrift -strict --gen java:hashcode
{code}
the current files seem to be generated instead with
{code}
thrift -strict --gen java
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12279) Generated thrift files were generated with the wrong parameters
[
https://issues.apache.org/jira/browse/HBASE-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14203208#comment-14203208
]
Hudson commented on HBASE-12279:
SUCCESS: Integrated in HBase-TRUNK #5755 (See
[https://builds.apache.org/job/HBase-TRUNK/5755/])
HBASE-12279 Generated thrift files were generated with the wrong parameters
(Niels Basjes) (apurtell: rev 5ffa457940bd7a299202469242478489b13ef1b9)
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TTimeRange.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TResult.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TColumn.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TRowResult.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TIllegalArgument.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/ColumnDescriptor.java
* hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TScan.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TColumnValue.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TAppend.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TRowMutations.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TAppend.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/AlreadyExists.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/IllegalArgument.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TColumn.java
* hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TColumnIncrement.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TIncrement.java
* hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TPut.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TScan.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TDelete.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TMutation.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/THBaseService.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TCellVisibility.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TAuthorization.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TIOError.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/BatchMutation.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/IOError.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TRegionInfo.java
* hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TCell.java
* hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TGet.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TIncrement.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java
Generated thrift files were generated with the wrong parameters
---
Key: HBASE-12279
URL: https://issues.apache.org/jira/browse/HBASE-12279
Project: HBase
Issue Type: Bug
Affects Versions: 0.94.0, 0.98.0, 0.99.0
Reporter: Niels Basjes
Assignee: Niels Basjes
Fix For: 2.0.0, 0.98.8, 0.94.26, 0.99.2
Attachments: HBASE-12279-2014-10-16-v1.patch,
HBASE-12279-2014-11-07-v2.patch
It turns out that the java code generated from the thrift files have been
generated with the wrong settings.
Instead of the documented
([thrift|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift/package-summary.html],
[thrift2|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift2/package-summary.html])
{code}
thrift -strict --gen java:hashcode
{code}
the current files seem to be generated instead with
{code}
thrift -strict --gen java
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12279) Generated thrift files were generated with the wrong parameters
[
https://issues.apache.org/jira/browse/HBASE-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14203227#comment-14203227
]
Hudson commented on HBASE-12279:
SUCCESS: Integrated in HBase-0.98 #664 (See
[https://builds.apache.org/job/HBase-0.98/664/])
HBASE-12279 Generated thrift files were generated with the wrong parameters
(Niels Basjes) (apurtell: rev c526bf98c35f0418b5df6b4827e9681879eb5f04)
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TIncrement.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/BatchMutation.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TAuthorization.java
* hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TCell.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TRowResult.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TAppend.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/IllegalArgument.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TColumn.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TMutation.java
* hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java
* hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TScan.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TCellVisibility.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TIOError.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TIncrement.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/THBaseService.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TRegionInfo.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TDelete.java
* hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TGet.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TRowMutations.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TTimeRange.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/AlreadyExists.java
* hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TPut.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/ColumnDescriptor.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TScan.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TColumnIncrement.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/IOError.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TColumn.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TIllegalArgument.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TColumnValue.java
*
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TResult.java
Generated thrift files were generated with the wrong parameters
---
Key: HBASE-12279
URL: https://issues.apache.org/jira/browse/HBASE-12279
Project: HBase
Issue Type: Bug
Affects Versions: 0.94.0, 0.98.0, 0.99.0
Reporter: Niels Basjes
Assignee: Niels Basjes
Fix For: 2.0.0, 0.98.8, 0.94.26, 0.99.2
Attachments: HBASE-12279-2014-10-16-v1.patch,
HBASE-12279-2014-11-07-v2.patch
It turns out that the java code generated from the thrift files have been
generated with the wrong settings.
Instead of the documented
([thrift|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift/package-summary.html],
[thrift2|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift2/package-summary.html])
{code}
thrift -strict --gen java:hashcode
{code}
the current files seem to be generated instead with
{code}
thrift -strict --gen java
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12279) Generated thrift files were generated with the wrong parameters
[
https://issues.apache.org/jira/browse/HBASE-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14188422#comment-14188422
]
Niels Basjes commented on HBASE-12279:
--
The patch I created for HBASE-12272 includes an explicit check that the
configured version is actually used.
So as long as the pom.xml says thrift.version0.9.0/thrift.version trying
it with 0.9.1 will fail, which is exactly the check we need here.
As far as I can tell the HBASE-12272 patch should also work quite nicely on the
older HBase where thrift 0.8.0 is still needed.
Generated thrift files were generated with the wrong parameters
---
Key: HBASE-12279
URL: https://issues.apache.org/jira/browse/HBASE-12279
Project: HBase
Issue Type: Bug
Affects Versions: 0.94.0, 0.98.0, 0.99.0
Reporter: Niels Basjes
Fix For: 2.0.0, 0.98.8, 0.94.25, 0.99.2
Attachments: HBASE-12279-2014-10-16-v1.patch
It turns out that the java code generated from the thrift files have been
generated with the wrong settings.
Instead of the documented
([thrift|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift/package-summary.html],
[thrift2|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift2/package-summary.html])
{code}
thrift -strict --gen java:hashcode
{code}
the current files seem to be generated instead with
{code}
thrift -strict --gen java
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12279) Generated thrift files were generated with the wrong parameters
[
https://issues.apache.org/jira/browse/HBASE-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14187989#comment-14187989
]
Lars Hofhansl commented on HBASE-12279:
---
Yeah... Just tried to generate the thrift files in 0.94 and I found other diffs
as well. Turns out that at least in 0.94 the files where generated with thrift
0.8.0 and I have 0.9.1.
Don't know much about thrift, is it OK to regenerate with 0.9.1, or will that
break existing clients?
Generated thrift files were generated with the wrong parameters
---
Key: HBASE-12279
URL: https://issues.apache.org/jira/browse/HBASE-12279
Project: HBase
Issue Type: Bug
Affects Versions: 0.94.0, 0.98.0, 0.99.0
Reporter: Niels Basjes
Fix For: 2.0.0, 0.98.8, 0.94.25, 0.99.2
Attachments: HBASE-12279-2014-10-16-v1.patch
It turns out that the java code generated from the thrift files have been
generated with the wrong settings.
Instead of the documented
([thrift|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift/package-summary.html],
[thrift2|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift2/package-summary.html])
{code}
thrift -strict --gen java:hashcode
{code}
the current files seem to be generated instead with
{code}
thrift -strict --gen java
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12279) Generated thrift files were generated with the wrong parameters
[
https://issues.apache.org/jira/browse/HBASE-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14187998#comment-14187998
]
Sean Busbey commented on HBASE-12279:
-
I'd bet on breaks existing clients.
Generated thrift files were generated with the wrong parameters
---
Key: HBASE-12279
URL: https://issues.apache.org/jira/browse/HBASE-12279
Project: HBase
Issue Type: Bug
Affects Versions: 0.94.0, 0.98.0, 0.99.0
Reporter: Niels Basjes
Fix For: 2.0.0, 0.98.8, 0.94.25, 0.99.2
Attachments: HBASE-12279-2014-10-16-v1.patch
It turns out that the java code generated from the thrift files have been
generated with the wrong settings.
Instead of the documented
([thrift|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift/package-summary.html],
[thrift2|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift2/package-summary.html])
{code}
thrift -strict --gen java:hashcode
{code}
the current files seem to be generated instead with
{code}
thrift -strict --gen java
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12279) Generated thrift files were generated with the wrong parameters
[
https://issues.apache.org/jira/browse/HBASE-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14188001#comment-14188001
]
Lars Hofhansl commented on HBASE-12279:
---
I new that would be the answer :(
Generated thrift files were generated with the wrong parameters
---
Key: HBASE-12279
URL: https://issues.apache.org/jira/browse/HBASE-12279
Project: HBase
Issue Type: Bug
Affects Versions: 0.94.0, 0.98.0, 0.99.0
Reporter: Niels Basjes
Fix For: 2.0.0, 0.98.8, 0.94.25, 0.99.2
Attachments: HBASE-12279-2014-10-16-v1.patch
It turns out that the java code generated from the thrift files have been
generated with the wrong settings.
Instead of the documented
([thrift|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift/package-summary.html],
[thrift2|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift2/package-summary.html])
{code}
thrift -strict --gen java:hashcode
{code}
the current files seem to be generated instead with
{code}
thrift -strict --gen java
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12279) Generated thrift files were generated with the wrong parameters
[
https://issues.apache.org/jira/browse/HBASE-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14188002#comment-14188002
]
Sean Busbey commented on HBASE-12279:
-
Also 0.9.1 changed the behavior in the face of runtime exceptions (see
ACCUMULO-2950 and THRIFT-1805) so I'd strongly recommend using only 0.9.0.
Generated thrift files were generated with the wrong parameters
---
Key: HBASE-12279
URL: https://issues.apache.org/jira/browse/HBASE-12279
Project: HBase
Issue Type: Bug
Affects Versions: 0.94.0, 0.98.0, 0.99.0
Reporter: Niels Basjes
Fix For: 2.0.0, 0.98.8, 0.94.25, 0.99.2
Attachments: HBASE-12279-2014-10-16-v1.patch
It turns out that the java code generated from the thrift files have been
generated with the wrong settings.
Instead of the documented
([thrift|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift/package-summary.html],
[thrift2|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift2/package-summary.html])
{code}
thrift -strict --gen java:hashcode
{code}
the current files seem to be generated instead with
{code}
thrift -strict --gen java
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12279) Generated thrift files were generated with the wrong parameters
[
https://issues.apache.org/jira/browse/HBASE-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14185014#comment-14185014
]
Niels Basjes commented on HBASE-12279:
--
Do I need to do anything else to get this committed?
Generated thrift files were generated with the wrong parameters
---
Key: HBASE-12279
URL: https://issues.apache.org/jira/browse/HBASE-12279
Project: HBase
Issue Type: Bug
Affects Versions: 0.94.0, 0.98.0, 0.99.0
Reporter: Niels Basjes
Fix For: 2.0.0, 0.98.8, 0.94.25, 0.99.2
Attachments: HBASE-12279-2014-10-16-v1.patch
It turns out that the java code generated from the thrift files have been
generated with the wrong settings.
Instead of the documented
([thrift|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift/package-summary.html],
[thrift2|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift2/package-summary.html])
{code}
thrift -strict --gen java:hashcode
{code}
the current files seem to be generated instead with
{code}
thrift -strict --gen java
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12279) Generated thrift files were generated with the wrong parameters
[
https://issues.apache.org/jira/browse/HBASE-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14185412#comment-14185412
]
Lars Hofhansl commented on HBASE-12279:
---
ltgm
What's the best way to commit this to all branches? Regenerate the files
locally and then commit?
Generated thrift files were generated with the wrong parameters
---
Key: HBASE-12279
URL: https://issues.apache.org/jira/browse/HBASE-12279
Project: HBase
Issue Type: Bug
Affects Versions: 0.94.0, 0.98.0, 0.99.0
Reporter: Niels Basjes
Fix For: 2.0.0, 0.98.8, 0.94.25, 0.99.2
Attachments: HBASE-12279-2014-10-16-v1.patch
It turns out that the java code generated from the thrift files have been
generated with the wrong settings.
Instead of the documented
([thrift|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift/package-summary.html],
[thrift2|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift2/package-summary.html])
{code}
thrift -strict --gen java:hashcode
{code}
the current files seem to be generated instead with
{code}
thrift -strict --gen java
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12279) Generated thrift files were generated with the wrong parameters
[
https://issues.apache.org/jira/browse/HBASE-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14185453#comment-14185453
]
Sean Busbey commented on HBASE-12279:
-
+1 lgtm.
[~lhofhansl] yeah, I think that makes sense. my suggestion would be to get
HBASE-12272 in place first so it's easier to do the regeneration per branch.
Generated thrift files were generated with the wrong parameters
---
Key: HBASE-12279
URL: https://issues.apache.org/jira/browse/HBASE-12279
Project: HBase
Issue Type: Bug
Affects Versions: 0.94.0, 0.98.0, 0.99.0
Reporter: Niels Basjes
Fix For: 2.0.0, 0.98.8, 0.94.25, 0.99.2
Attachments: HBASE-12279-2014-10-16-v1.patch
It turns out that the java code generated from the thrift files have been
generated with the wrong settings.
Instead of the documented
([thrift|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift/package-summary.html],
[thrift2|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift2/package-summary.html])
{code}
thrift -strict --gen java:hashcode
{code}
the current files seem to be generated instead with
{code}
thrift -strict --gen java
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12279) Generated thrift files were generated with the wrong parameters
[
https://issues.apache.org/jira/browse/HBASE-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14173597#comment-14173597
]
Hadoop QA commented on HBASE-12279:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12675246/HBASE-12279-2014-10-16-v1.patch
against trunk revision .
ATTACHMENT ID: 12675246
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+lastComparison =
Boolean.valueOf(isSetAuthorizations()).compareTo(typedOther.isSetAuthorizations());
+lastComparison =
Boolean.valueOf(isSetCellVisibility()).compareTo(typedOther.isSetCellVisibility());
+lastComparison =
Boolean.valueOf(isSetAuthorizations()).compareTo(typedOther.isSetAuthorizations());
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11373//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11373//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11373//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11373//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11373//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11373//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11373//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11373//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11373//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11373//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11373//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11373//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11373//console
This message is automatically generated.
Generated thrift files were generated with the wrong parameters
---
Key: HBASE-12279
URL: https://issues.apache.org/jira/browse/HBASE-12279
Project: HBase
Issue Type: Bug
Reporter: Niels Basjes
Attachments: HBASE-12279-2014-10-16-v1.patch
It turns out that the java code generated from the thrift files have been
generated with the wrong settings.
Instead of the documented
([thrift|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift/package-summary.html],
[thrift2|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift2/package-summary.html])
{code}
thrift -strict --gen java:hashcode
{code}
the current files seem to be generated instead with
{code}
thrift -strict --gen java
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12279) Generated thrift files were generated with the wrong parameters
[
https://issues.apache.org/jira/browse/HBASE-12279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14173940#comment-14173940
]
Ted Yu commented on HBASE-12279:
+1
Generated thrift files were generated with the wrong parameters
---
Key: HBASE-12279
URL: https://issues.apache.org/jira/browse/HBASE-12279
Project: HBase
Issue Type: Bug
Affects Versions: 0.94.0, 0.98.0, 0.99.0
Reporter: Niels Basjes
Fix For: 2.0.0, 0.98.8, 0.94.25, 0.99.2
Attachments: HBASE-12279-2014-10-16-v1.patch
It turns out that the java code generated from the thrift files have been
generated with the wrong settings.
Instead of the documented
([thrift|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift/package-summary.html],
[thrift2|http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/thrift2/package-summary.html])
{code}
thrift -strict --gen java:hashcode
{code}
the current files seem to be generated instead with
{code}
thrift -strict --gen java
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
