[jira] [Commented] (HBASE-12940) Expose listPeerConfigs and getPeerConfig to the HBase shell
[ https://issues.apache.org/jira/browse/HBASE-12940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15340613#comment-15340613 ] Hudson commented on HBASE-12940: SUCCESS: Integrated in HBase-1.3-IT #722 (See [https://builds.apache.org/job/HBase-1.3-IT/722/]) HBASE-12940 Expose listPeerConfigs and getPeerConfig to the HBase shell (antonov: rev 089494d837fcc3715eb27e0b3c0da9264979dae5) * hbase-shell/src/main/ruby/shell.rb * hbase-shell/src/main/ruby/hbase/replication_admin.rb * hbase-shell/src/test/ruby/hbase/replication_admin_test.rb * hbase-shell/src/main/ruby/shell/commands/list_peer_configs.rb * hbase-shell/src/main/ruby/shell/commands/get_peer_config.rb > Expose listPeerConfigs and getPeerConfig to the HBase shell > --- > > Key: HBASE-12940 > URL: https://issues.apache.org/jira/browse/HBASE-12940 > Project: HBase > Issue Type: Improvement > Components: shell >Reporter: Kevin Risden >Assignee: Geoffrey Jacoby > Fix For: 2.0.0, 1.3.0, 0.98.18, 1.4.0 > > Attachments: HBASE-12940-v1.patch, HBASE-12940.patch > > > In HBASE-12867 found that listPeerConfigs and getPeerConfig from > ReplicationAdmin are not exposed to the HBase shell. This makes looking at > details for custom replication endpoints and testing of add_peer from > HBASE-12867 impossible. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12940) Expose listPeerConfigs and getPeerConfig to the HBase shell
[ https://issues.apache.org/jira/browse/HBASE-12940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15340535#comment-15340535 ] Hudson commented on HBASE-12940: FAILURE: Integrated in HBase-1.3 #749 (See [https://builds.apache.org/job/HBase-1.3/749/]) HBASE-12940 Expose listPeerConfigs and getPeerConfig to the HBase shell (antonov: rev 089494d837fcc3715eb27e0b3c0da9264979dae5) * hbase-shell/src/main/ruby/shell/commands/list_peer_configs.rb * hbase-shell/src/main/ruby/hbase/replication_admin.rb * hbase-shell/src/test/ruby/hbase/replication_admin_test.rb * hbase-shell/src/main/ruby/shell/commands/get_peer_config.rb * hbase-shell/src/main/ruby/shell.rb > Expose listPeerConfigs and getPeerConfig to the HBase shell > --- > > Key: HBASE-12940 > URL: https://issues.apache.org/jira/browse/HBASE-12940 > Project: HBase > Issue Type: Improvement > Components: shell >Reporter: Kevin Risden >Assignee: Geoffrey Jacoby > Fix For: 2.0.0, 1.3.0, 0.98.18, 1.4.0 > > Attachments: HBASE-12940-v1.patch, HBASE-12940.patch > > > In HBASE-12867 found that listPeerConfigs and getPeerConfig from > ReplicationAdmin are not exposed to the HBase shell. This makes looking at > details for custom replication endpoints and testing of add_peer from > HBASE-12867 impossible. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12940) Expose listPeerConfigs and getPeerConfig to the HBase shell
[ https://issues.apache.org/jira/browse/HBASE-12940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15340156#comment-15340156 ] Mikhail Antonov commented on HBASE-12940: - pushed to 1.3 > Expose listPeerConfigs and getPeerConfig to the HBase shell > --- > > Key: HBASE-12940 > URL: https://issues.apache.org/jira/browse/HBASE-12940 > Project: HBase > Issue Type: Improvement > Components: shell >Reporter: Kevin Risden >Assignee: Geoffrey Jacoby > Fix For: 2.0.0, 1.3.0, 0.98.18, 1.4.0 > > Attachments: HBASE-12940-v1.patch, HBASE-12940.patch > > > In HBASE-12867 found that listPeerConfigs and getPeerConfig from > ReplicationAdmin are not exposed to the HBase shell. This makes looking at > details for custom replication endpoints and testing of add_peer from > HBASE-12867 impossible. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12940) Expose listPeerConfigs and getPeerConfig to the HBase shell
[ https://issues.apache.org/jira/browse/HBASE-12940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15340129#comment-15340129 ] Mikhail Antonov commented on HBASE-12940: - weird, git branch --contains shows that commit a06994bbc1d48f224319fe56aced5a8cc5d6699f is only present in branch-1 and not in branch-1.3, despite what Hudson bot says. Going to cherry-pick. [~te...@apache.org] > Expose listPeerConfigs and getPeerConfig to the HBase shell > --- > > Key: HBASE-12940 > URL: https://issues.apache.org/jira/browse/HBASE-12940 > Project: HBase > Issue Type: Improvement > Components: shell >Reporter: Kevin Risden >Assignee: Geoffrey Jacoby > Fix For: 2.0.0, 1.3.0, 0.98.18, 1.4.0 > > Attachments: HBASE-12940-v1.patch, HBASE-12940.patch > > > In HBASE-12867 found that listPeerConfigs and getPeerConfig from > ReplicationAdmin are not exposed to the HBase shell. This makes looking at > details for custom replication endpoints and testing of add_peer from > HBASE-12867 impossible. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12940) Expose listPeerConfigs and getPeerConfig to the HBase shell
[
https://issues.apache.org/jira/browse/HBASE-12940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15198391#comment-15198391
]
Ted Yu commented on HBASE-12940:
I was searching for individual test case names to see if they were run.
Have you noticed the following in test output ?
{code}
2016-03-16 15:22:40,098 INFO
[RpcServer.reader=0,bindAddress=10.22.16.220,port=61976]
ipc.RpcServer$Connection(1740): Connection from 10.22.16.220 port: 62069 with
version info: version: "2.0.0-SNAPSHOT" url:
"git://TYus-MacBook-Pro.local/Users/tyu/trunk" revision:
"3bf0945a1149e518a49d14d4cc930383a4f311da" user: "tyu" date: "Wed Mar 16
15:21:57 PDT 2016" src_checksum: "fed529d9fec612f1276ebb401ea46a06"
version_major: 2 version_minor: 0
2016-03-16 15:22:40,107 ERROR [main-EventThread]
regionserver.ReplicationSourceManager(596): Error while adding a new peer
org.apache.hadoop.hbase.replication.ReplicationException: Error adding peer
with id=1
at
org.apache.hadoop.hbase.replication.ReplicationPeersZKImpl.createAndAddPeer(ReplicationPeersZKImpl.java:425)
at
org.apache.hadoop.hbase.replication.ReplicationPeersZKImpl.peerAdded(ReplicationPeersZKImpl.java:397)
at
org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager.peerListChanged(ReplicationSourceManager.java:591)
at
org.apache.hadoop.hbase.replication.ReplicationTrackerZKImpl$PeersWatcher.nodeChildrenChanged(ReplicationTrackerZKImpl.java:187)
at
org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher.process(ZooKeeperWatcher.java:628)
at
org.apache.zookeeper.ClientCnxn$EventThread.processEvent(ClientCnxn.java:522)
at org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:498)
Caused by: org.apache.hadoop.hbase.replication.ReplicationException: Error
starting the peer state tracker for peerId=1
at
org.apache.hadoop.hbase.replication.ReplicationPeersZKImpl.createPeer(ReplicationPeersZKImpl.java:493)
at
org.apache.hadoop.hbase.replication.ReplicationPeersZKImpl.createAndAddPeer(ReplicationPeersZKImpl.java:423)
... 6 more
Caused by: org.apache.zookeeper.KeeperException$NoNodeException:
KeeperErrorCode = NoNode for /hbase/replication/peers/1/peer-state
at org.apache.zookeeper.KeeperException.create(KeeperException.java:111)
at org.apache.zookeeper.KeeperException.create(KeeperException.java:51)
at org.apache.zookeeper.ZooKeeper.create(ZooKeeper.java:783)
at
org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.createNonSequential(RecoverableZooKeeper.java:575)
at
org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.create(RecoverableZooKeeper.java:554)
at
org.apache.hadoop.hbase.zookeeper.ZKUtil.createNodeIfNotExistsAndWatch(ZKUtil.java:1009)
at
org.apache.hadoop.hbase.replication.ReplicationPeerZKImpl.ensurePeerEnabled(ReplicationPeerZKImpl.java:238)
at
org.apache.hadoop.hbase.replication.ReplicationPeerZKImpl.startStateTracker(ReplicationPeerZKImpl.java:96)
{code}
> Expose listPeerConfigs and getPeerConfig to the HBase shell
> ---
>
> Key: HBASE-12940
> URL: https://issues.apache.org/jira/browse/HBASE-12940
> Project: HBase
> Issue Type: Bug
> Components: shell
>Reporter: Kevin Risden
>Assignee: Geoffrey Jacoby
> Attachments: HBASE-12940-v1.patch, HBASE-12940.patch
>
>
> In HBASE-12867 found that listPeerConfigs and getPeerConfig from
> ReplicationAdmin are not exposed to the HBase shell. This makes looking at
> details for custom replication endpoints and testing of add_peer from
> HBASE-12867 impossible.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12940) Expose listPeerConfigs and getPeerConfig to the HBase shell
[ https://issues.apache.org/jira/browse/HBASE-12940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15198414#comment-15198414 ] Geoffrey Jacoby commented on HBASE-12940: - Yes, I noticed those, and they concerned me at first. On a deeper look though, these appear to be coming from HBase trying to actually set up replication with remote clusters that aren't actually there. ReplicationPeersZKImpl assumes that the remote ZooKeeper quorum it's given as the cluster key is a real thing that it can immediately go talk to. But none of the quorums mentioned in the tests exist, so the watcher threads on the minicluster are unhappy. But that doesn't stop us from verifying that the replication_admin wrapper and ReplicationAdmin class are successfully putting data into _our_ minicluster ZK instance, and able to get it back out again. There are also some exceptions related to an unneeded table the existing test setup creates, and I filed a separate JIRA, HBASE-15472, to take care of that one. > Expose listPeerConfigs and getPeerConfig to the HBase shell > --- > > Key: HBASE-12940 > URL: https://issues.apache.org/jira/browse/HBASE-12940 > Project: HBase > Issue Type: Bug > Components: shell >Reporter: Kevin Risden >Assignee: Geoffrey Jacoby > Attachments: HBASE-12940-v1.patch, HBASE-12940.patch > > > In HBASE-12867 found that listPeerConfigs and getPeerConfig from > ReplicationAdmin are not exposed to the HBase shell. This makes looking at > details for custom replication endpoints and testing of add_peer from > HBASE-12867 impossible. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12940) Expose listPeerConfigs and getPeerConfig to the HBase shell
[ https://issues.apache.org/jira/browse/HBASE-12940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201865#comment-15201865 ] Hudson commented on HBASE-12940: FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #1188 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/1188/]) HBASE-12940 Expose listPeerConfigs and getPeerConfig to the HBase shell (apurtell: rev deaf0f3d01cacb4917e67f0db726cd5a4194e3f0) * hbase-shell/src/main/ruby/shell/commands/get_peer_config.rb * hbase-shell/src/main/ruby/hbase/replication_admin.rb * hbase-shell/src/test/ruby/hbase/replication_admin_test.rb * hbase-shell/src/main/ruby/shell.rb * hbase-shell/src/main/ruby/shell/commands/list_peer_configs.rb > Expose listPeerConfigs and getPeerConfig to the HBase shell > --- > > Key: HBASE-12940 > URL: https://issues.apache.org/jira/browse/HBASE-12940 > Project: HBase > Issue Type: Improvement > Components: shell >Reporter: Kevin Risden >Assignee: Geoffrey Jacoby > Fix For: 2.0.0, 1.3.0, 0.98.18, 1.4.0 > > Attachments: HBASE-12940-v1.patch, HBASE-12940.patch > > > In HBASE-12867 found that listPeerConfigs and getPeerConfig from > ReplicationAdmin are not exposed to the HBase shell. This makes looking at > details for custom replication endpoints and testing of add_peer from > HBASE-12867 impossible. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12940) Expose listPeerConfigs and getPeerConfig to the HBase shell
[ https://issues.apache.org/jira/browse/HBASE-12940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15198501#comment-15198501 ] Geoffrey Jacoby commented on HBASE-12940: - Despite the name, none of the existing or new tests in TestReplicationShell actually test the replication _shell_. Instead they test the Ruby class, replication_admin.rb, that the replication shell commands call. The code you quote has no unit test associated with it (and neither do the other existing Ruby commands in ruby/shell/commands, unless I've missed something. There are just a few basic sanity checks in test/ruby/shell/) To verify the code I added in ruby/shell/commands, I built HBase, ran in local mode and manually used the hbase shell to add two different kinds of peers (a basic one with just a cluster key, and a more complicated one with a custom replication endpoint class and a config dictionary). Then I verified that get_peer_config and list_peer_configs, the two new methods worked as expected. > Expose listPeerConfigs and getPeerConfig to the HBase shell > --- > > Key: HBASE-12940 > URL: https://issues.apache.org/jira/browse/HBASE-12940 > Project: HBase > Issue Type: Bug > Components: shell >Reporter: Kevin Risden >Assignee: Geoffrey Jacoby > Attachments: HBASE-12940-v1.patch, HBASE-12940.patch > > > In HBASE-12867 found that listPeerConfigs and getPeerConfig from > ReplicationAdmin are not exposed to the HBase shell. This makes looking at > details for custom replication endpoints and testing of add_peer from > HBASE-12867 impossible. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12940) Expose listPeerConfigs and getPeerConfig to the HBase shell
[ https://issues.apache.org/jira/browse/HBASE-12940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201858#comment-15201858 ] Hudson commented on HBASE-12940: FAILURE: Integrated in HBase-0.98-matrix #315 (See [https://builds.apache.org/job/HBase-0.98-matrix/315/]) HBASE-12940 Expose listPeerConfigs and getPeerConfig to the HBase shell (apurtell: rev deaf0f3d01cacb4917e67f0db726cd5a4194e3f0) * hbase-shell/src/test/ruby/hbase/replication_admin_test.rb * hbase-shell/src/main/ruby/shell.rb * hbase-shell/src/main/ruby/shell/commands/list_peer_configs.rb * hbase-shell/src/main/ruby/shell/commands/get_peer_config.rb * hbase-shell/src/main/ruby/hbase/replication_admin.rb > Expose listPeerConfigs and getPeerConfig to the HBase shell > --- > > Key: HBASE-12940 > URL: https://issues.apache.org/jira/browse/HBASE-12940 > Project: HBase > Issue Type: Improvement > Components: shell >Reporter: Kevin Risden >Assignee: Geoffrey Jacoby > Fix For: 2.0.0, 1.3.0, 0.98.18, 1.4.0 > > Attachments: HBASE-12940-v1.patch, HBASE-12940.patch > > > In HBASE-12867 found that listPeerConfigs and getPeerConfig from > ReplicationAdmin are not exposed to the HBase shell. This makes looking at > details for custom replication endpoints and testing of add_peer from > HBASE-12867 impossible. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12940) Expose listPeerConfigs and getPeerConfig to the HBase shell
[ https://issues.apache.org/jira/browse/HBASE-12940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15199213#comment-15199213 ] Hudson commented on HBASE-12940: FAILURE: Integrated in HBase-Trunk_matrix #783 (See [https://builds.apache.org/job/HBase-Trunk_matrix/783/]) HBASE-12940 Expose listPeerConfigs and getPeerConfig to the HBase shell (tedyu: rev 448ac5b37c5430c12df722f06580d44f4dd89da5) * hbase-shell/src/test/ruby/hbase/replication_admin_test.rb * hbase-shell/src/main/ruby/shell/commands/list_peer_configs.rb * hbase-shell/src/main/ruby/shell.rb * hbase-shell/src/main/ruby/shell/commands/get_peer_config.rb * hbase-shell/src/main/ruby/hbase/replication_admin.rb > Expose listPeerConfigs and getPeerConfig to the HBase shell > --- > > Key: HBASE-12940 > URL: https://issues.apache.org/jira/browse/HBASE-12940 > Project: HBase > Issue Type: Improvement > Components: shell >Reporter: Kevin Risden >Assignee: Geoffrey Jacoby > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-12940-v1.patch, HBASE-12940.patch > > > In HBASE-12867 found that listPeerConfigs and getPeerConfig from > ReplicationAdmin are not exposed to the HBase shell. This makes looking at > details for custom replication endpoints and testing of add_peer from > HBASE-12867 impossible. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12940) Expose listPeerConfigs and getPeerConfig to the HBase shell
[
https://issues.apache.org/jira/browse/HBASE-12940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15198417#comment-15198417
]
Ted Yu commented on HBASE-12940:
I was looking for the following in test output:
{code}
+ formatter.row(["Cluster Key", cluster_key])
{code}
But didn't find any.
Do you know why ?
> Expose listPeerConfigs and getPeerConfig to the HBase shell
> ---
>
> Key: HBASE-12940
> URL: https://issues.apache.org/jira/browse/HBASE-12940
> Project: HBase
> Issue Type: Bug
> Components: shell
>Reporter: Kevin Risden
>Assignee: Geoffrey Jacoby
> Attachments: HBASE-12940-v1.patch, HBASE-12940.patch
>
>
> In HBASE-12867 found that listPeerConfigs and getPeerConfig from
> ReplicationAdmin are not exposed to the HBase shell. This makes looking at
> details for custom replication endpoints and testing of add_peer from
> HBASE-12867 impossible.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12940) Expose listPeerConfigs and getPeerConfig to the HBase shell
[ https://issues.apache.org/jira/browse/HBASE-12940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15199164#comment-15199164 ] Hudson commented on HBASE-12940: FAILURE: Integrated in HBase-1.3-IT #558 (See [https://builds.apache.org/job/HBase-1.3-IT/558/]) HBASE-12940 Expose listPeerConfigs and getPeerConfig to the HBase shell (tedyu: rev a06994bbc1d48f224319fe56aced5a8cc5d6699f) * hbase-shell/src/main/ruby/hbase/replication_admin.rb * hbase-shell/src/main/ruby/shell/commands/get_peer_config.rb * hbase-shell/src/main/ruby/shell.rb * hbase-shell/src/test/ruby/hbase/replication_admin_test.rb * hbase-shell/src/main/ruby/shell/commands/list_peer_configs.rb > Expose listPeerConfigs and getPeerConfig to the HBase shell > --- > > Key: HBASE-12940 > URL: https://issues.apache.org/jira/browse/HBASE-12940 > Project: HBase > Issue Type: Improvement > Components: shell >Reporter: Kevin Risden >Assignee: Geoffrey Jacoby > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-12940-v1.patch, HBASE-12940.patch > > > In HBASE-12867 found that listPeerConfigs and getPeerConfig from > ReplicationAdmin are not exposed to the HBase shell. This makes looking at > details for custom replication endpoints and testing of add_peer from > HBASE-12867 impossible. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12940) Expose listPeerConfigs and getPeerConfig to the HBase shell
[ https://issues.apache.org/jira/browse/HBASE-12940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15198306#comment-15198306 ] Geoffrey Jacoby commented on HBASE-12940: - TestReplicationShell, which runs the Ruby tests related to replication, are currently deactivated as a result of HBASE-14561 and HBASE-14678. I added several relevant test cases to replication_admin_test.rb anyway, and verified that they (and TestReplicationShell as a whole) passed when TestReplicatedShell was un-Ignored locally. However, they won't be run as part of the regular test suite until HBASE-14562, or some similar JIRA is worked. > Expose listPeerConfigs and getPeerConfig to the HBase shell > --- > > Key: HBASE-12940 > URL: https://issues.apache.org/jira/browse/HBASE-12940 > Project: HBase > Issue Type: Bug > Components: shell >Reporter: Kevin Risden >Assignee: Geoffrey Jacoby > Attachments: HBASE-12940-v1.patch, HBASE-12940.patch > > > In HBASE-12867 found that listPeerConfigs and getPeerConfig from > ReplicationAdmin are not exposed to the HBase shell. This makes looking at > details for custom replication endpoints and testing of add_peer from > HBASE-12867 impossible. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12940) Expose listPeerConfigs and getPeerConfig to the HBase shell
[ https://issues.apache.org/jira/browse/HBASE-12940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15198379#comment-15198379 ] Geoffrey Jacoby commented on HBASE-12940: - I made similar changes as you, then ran "mvn test -Dtest=TestReplicationShell -DfailIfNoTests=false" from the hbase directory Running org.apache.hadoop.hbase.client.TestReplicationShell Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 89.548 sec - in org.apache.hadoop.hbase.client.TestReplicationShell Results : Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 and from within hbase-shell/target/surefire-reports/org.apache.hadoop.hbase.client.TestReplicationShell-output.txt: Finished in 75.782 seconds. 14 tests, 61 assertions, 0 failures, 0 errors Done with tests! Shutting down the cluster... The above is also consistent with the earlier runs I did within an IDE before submitting. > Expose listPeerConfigs and getPeerConfig to the HBase shell > --- > > Key: HBASE-12940 > URL: https://issues.apache.org/jira/browse/HBASE-12940 > Project: HBase > Issue Type: Bug > Components: shell >Reporter: Kevin Risden >Assignee: Geoffrey Jacoby > Attachments: HBASE-12940-v1.patch, HBASE-12940.patch > > > In HBASE-12867 found that listPeerConfigs and getPeerConfig from > ReplicationAdmin are not exposed to the HBase shell. This makes looking at > details for custom replication endpoints and testing of add_peer from > HBASE-12867 impossible. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12940) Expose listPeerConfigs and getPeerConfig to the HBase shell
[ https://issues.apache.org/jira/browse/HBASE-12940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15198603#comment-15198603 ] Ted Yu commented on HBASE-12940: Geoffrey: I am satisfied with your responses. > Expose listPeerConfigs and getPeerConfig to the HBase shell > --- > > Key: HBASE-12940 > URL: https://issues.apache.org/jira/browse/HBASE-12940 > Project: HBase > Issue Type: Improvement > Components: shell >Reporter: Kevin Risden >Assignee: Geoffrey Jacoby > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-12940-v1.patch, HBASE-12940.patch > > > In HBASE-12867 found that listPeerConfigs and getPeerConfig from > ReplicationAdmin are not exposed to the HBase shell. This makes looking at > details for custom replication endpoints and testing of add_peer from > HBASE-12867 impossible. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12940) Expose listPeerConfigs and getPeerConfig to the HBase shell
[ https://issues.apache.org/jira/browse/HBASE-12940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15198315#comment-15198315 ] Ted Yu commented on HBASE-12940: Can you let me know you verified the test result ? For me the following search for test case yielded nothing: grep 'simple.\*clusterKey' hbase-shell/target/surefire-reports/org.apache.hadoop.hbase.client.TestReplicationShell-output.txt > Expose listPeerConfigs and getPeerConfig to the HBase shell > --- > > Key: HBASE-12940 > URL: https://issues.apache.org/jira/browse/HBASE-12940 > Project: HBase > Issue Type: Bug > Components: shell >Reporter: Kevin Risden >Assignee: Geoffrey Jacoby > Attachments: HBASE-12940-v1.patch, HBASE-12940.patch > > > In HBASE-12867 found that listPeerConfigs and getPeerConfig from > ReplicationAdmin are not exposed to the HBase shell. This makes looking at > details for custom replication endpoints and testing of add_peer from > HBASE-12867 impossible. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12940) Expose listPeerConfigs and getPeerConfig to the HBase shell
[ https://issues.apache.org/jira/browse/HBASE-12940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15199392#comment-15199392 ] Hudson commented on HBASE-12940: FAILURE: Integrated in HBase-1.4 #25 (See [https://builds.apache.org/job/HBase-1.4/25/]) HBASE-12940 Expose listPeerConfigs and getPeerConfig to the HBase shell (tedyu: rev a06994bbc1d48f224319fe56aced5a8cc5d6699f) * hbase-shell/src/main/ruby/shell/commands/list_peer_configs.rb * hbase-shell/src/main/ruby/hbase/replication_admin.rb * hbase-shell/src/main/ruby/shell.rb * hbase-shell/src/test/ruby/hbase/replication_admin_test.rb * hbase-shell/src/main/ruby/shell/commands/get_peer_config.rb > Expose listPeerConfigs and getPeerConfig to the HBase shell > --- > > Key: HBASE-12940 > URL: https://issues.apache.org/jira/browse/HBASE-12940 > Project: HBase > Issue Type: Improvement > Components: shell >Reporter: Kevin Risden >Assignee: Geoffrey Jacoby > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-12940-v1.patch, HBASE-12940.patch > > > In HBASE-12867 found that listPeerConfigs and getPeerConfig from > ReplicationAdmin are not exposed to the HBase shell. This makes looking at > details for custom replication endpoints and testing of add_peer from > HBASE-12867 impossible. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12940) Expose listPeerConfigs and getPeerConfig to the HBase shell
[ https://issues.apache.org/jira/browse/HBASE-12940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196670#comment-15196670 ] Geoffrey Jacoby commented on HBASE-12940: - In answer to the Hadoop QA -1: Didn't notice the replication_admin_test.rb in test/ruby/hbase, just the lack of individual command tests in test/ruby/shell. I'll add some test cases to replication_admin_test.rb tomorrow and resubmit the patch. I've also done a good bit of end-to-end manual testing using the shell. > Expose listPeerConfigs and getPeerConfig to the HBase shell > --- > > Key: HBASE-12940 > URL: https://issues.apache.org/jira/browse/HBASE-12940 > Project: HBase > Issue Type: Bug > Components: shell >Reporter: Kevin Risden >Assignee: Geoffrey Jacoby > Attachments: HBASE-12940.patch > > > In HBASE-12867 found that listPeerConfigs and getPeerConfig from > ReplicationAdmin are not exposed to the HBase shell. This makes looking at > details for custom replication endpoints and testing of add_peer from > HBASE-12867 impossible. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12940) Expose listPeerConfigs and getPeerConfig to the HBase shell
[ https://issues.apache.org/jira/browse/HBASE-12940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196659#comment-15196659 ] Geoffrey Jacoby commented on HBASE-12940: - Ruby's not my usual language, but lowercase_with_underscores seemed to be the convention, and JRuby was translating the calls to the appropriate camelCased Java methods automatically. > Expose listPeerConfigs and getPeerConfig to the HBase shell > --- > > Key: HBASE-12940 > URL: https://issues.apache.org/jira/browse/HBASE-12940 > Project: HBase > Issue Type: Bug > Components: shell >Reporter: Kevin Risden >Assignee: Geoffrey Jacoby > Attachments: HBASE-12940.patch > > > In HBASE-12867 found that listPeerConfigs and getPeerConfig from > ReplicationAdmin are not exposed to the HBase shell. This makes looking at > details for custom replication endpoints and testing of add_peer from > HBASE-12867 impossible. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12940) Expose listPeerConfigs and getPeerConfig to the HBase shell
[
https://issues.apache.org/jira/browse/HBASE-12940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196605#comment-15196605
]
Ted Yu commented on HBASE-12940:
{code}
174 def list_peer_configs
175 @replication_admin.list_peer_configs
176 end
177
178 def get_peer_config(id)
179 @replication_admin.get_peer_config(id)
{code}
Should @replication_admin.listPeerConfigs and
@replication_admin.getPeerConfig() be called, respectively ?
> Expose listPeerConfigs and getPeerConfig to the HBase shell
> ---
>
> Key: HBASE-12940
> URL: https://issues.apache.org/jira/browse/HBASE-12940
> Project: HBase
> Issue Type: Bug
> Components: shell
>Reporter: Kevin Risden
>Assignee: Geoffrey Jacoby
> Attachments: HBASE-12940.patch
>
>
> In HBASE-12867 found that listPeerConfigs and getPeerConfig from
> ReplicationAdmin are not exposed to the HBase shell. This makes looking at
> details for custom replication endpoints and testing of add_peer from
> HBASE-12867 impossible.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12940) Expose listPeerConfigs and getPeerConfig to the HBase shell
[
https://issues.apache.org/jira/browse/HBASE-12940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196589#comment-15196589
]
Hadoop QA commented on HBASE-12940:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} rubocop {color} | {color:blue} 0m 0s
{color} | {color:blue} rubocop was not available. {color} |
| {color:blue}0{color} | {color:blue} ruby-lint {color} | {color:blue} 0m 0s
{color} | {color:blue} Ruby-lint was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
35s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
30s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 27s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 19s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
27s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
29s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
49m 7s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 26s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 17s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 7m 56s
{color} | {color:green} hbase-shell in the patch passed with JDK v1.8.0.
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 7m 28s
{color} | {color:green} hbase-shell in the patch passed with JDK v1.7.0_79.
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 73m 38s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12793657/HBASE-12940.patch |
| JIRA Issue | HBASE-12940 |
| Optional Tests | asflicense javac javadoc unit rubocop ruby_lint |
| uname | Linux pomona.apache.org 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT
Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / f120602 |
| Default Java | 1.7.0_79 |
| Multi-JDK versions | /home/jenkins/tools/java/jdk1.8.0:1.8.0
/usr/local/jenkins/java/jdk1.7.0_79:1.7.0_79 |
| JDK v1.7.0_79 Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/1002/testReport/ |
| modules | C: hbase-shell U: hbase-shell |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/1002/console |
| Powered by | Apache Yetus 0.2.0 http://yetus.apache.org |
This message was automatically generated.
> Expose listPeerConfigs and getPeerConfig to the HBase shell
> ---
>
> Key: HBASE-12940
> URL: https://issues.apache.org/jira/browse/HBASE-12940
> Project: HBase
> Issue Type: Bug
> Components: shell
>Reporter: Kevin Risden
>Assignee: Geoffrey Jacoby
> Attachments: HBASE-12940.patch
>
>
> In HBASE-12867 found that listPeerConfigs and getPeerConfig from
> ReplicationAdmin are not exposed to the HBase shell. This makes looking at
> details for custom replication endpoints and testing of add_peer from
> HBASE-12867 impossible.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
