[jira] [Commented] (HBASE-14203) remove duplicate code getTableDescriptor in HTable
[
https://issues.apache.org/jira/browse/HBASE-14203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700989#comment-14700989
]
Hudson commented on HBASE-14203:
FAILURE: Integrated in HBase-1.3 #113 (See
[https://builds.apache.org/job/HBase-1.3/113/])
HBASE-14203 remove duplicate code getTableDescriptor in HTable (Heng Chen)
(enis: rev c9b3d837a0ca4677e9f86f35ef78b6cb4710527b)
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
remove duplicate code getTableDescriptor in HTable
--
Key: HBASE-14203
URL: https://issues.apache.org/jira/browse/HBASE-14203
Project: HBase
Issue Type: Improvement
Reporter: Heng Chen
Assignee: Heng Chen
Priority: Trivial
Fix For: 2.0.0, 1.2.0, 1.3.0
Attachments: HBASE-14203.patch, HBASE-14203_v2.patch,
HBASE-14203_v3.patch, HBASE-14203_v4.patch, HBASE-14203_v5.patch
As TODO in comment said,
{{HTable.getTableDescriptor}} is same as {{HAdmin.getTableDescriptor}}.
remove the duplicate code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14203) remove duplicate code getTableDescriptor in HTable
[
https://issues.apache.org/jira/browse/HBASE-14203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701258#comment-14701258
]
Hudson commented on HBASE-14203:
FAILURE: Integrated in HBase-1.2 #116 (See
[https://builds.apache.org/job/HBase-1.2/116/])
HBASE-14203 remove duplicate code getTableDescriptor in HTable (Heng Chen)
(enis: rev 158839552fb765e3e330a3a905511c22eec6b2ce)
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
remove duplicate code getTableDescriptor in HTable
--
Key: HBASE-14203
URL: https://issues.apache.org/jira/browse/HBASE-14203
Project: HBase
Issue Type: Improvement
Reporter: Heng Chen
Assignee: Heng Chen
Priority: Trivial
Fix For: 2.0.0, 1.2.0, 1.3.0
Attachments: HBASE-14203.patch, HBASE-14203_v2.patch,
HBASE-14203_v3.patch, HBASE-14203_v4.patch, HBASE-14203_v5.patch
As TODO in comment said,
{{HTable.getTableDescriptor}} is same as {{HAdmin.getTableDescriptor}}.
remove the duplicate code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14203) remove duplicate code getTableDescriptor in HTable
[
https://issues.apache.org/jira/browse/HBASE-14203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700729#comment-14700729
]
Hudson commented on HBASE-14203:
FAILURE: Integrated in HBase-1.3-IT #95 (See
[https://builds.apache.org/job/HBase-1.3-IT/95/])
HBASE-14203 remove duplicate code getTableDescriptor in HTable (Heng Chen)
(enis: rev c9b3d837a0ca4677e9f86f35ef78b6cb4710527b)
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
remove duplicate code getTableDescriptor in HTable
--
Key: HBASE-14203
URL: https://issues.apache.org/jira/browse/HBASE-14203
Project: HBase
Issue Type: Improvement
Reporter: Heng Chen
Assignee: Heng Chen
Priority: Trivial
Fix For: 2.0.0, 1.2.0, 1.3.0
Attachments: HBASE-14203.patch, HBASE-14203_v2.patch,
HBASE-14203_v3.patch, HBASE-14203_v4.patch, HBASE-14203_v5.patch
As TODO in comment said,
{{HTable.getTableDescriptor}} is same as {{HAdmin.getTableDescriptor}}.
remove the duplicate code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14203) remove duplicate code getTableDescriptor in HTable
[
https://issues.apache.org/jira/browse/HBASE-14203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700734#comment-14700734
]
Hudson commented on HBASE-14203:
FAILURE: Integrated in HBase-TRUNK #6733 (See
[https://builds.apache.org/job/HBase-TRUNK/6733/])
HBASE-14203 remove duplicate code getTableDescriptor in HTable (Heng Chen)
(enis: rev 395ec5a9bb48324a8b7dd61790a954a2998a8f80)
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
remove duplicate code getTableDescriptor in HTable
--
Key: HBASE-14203
URL: https://issues.apache.org/jira/browse/HBASE-14203
Project: HBase
Issue Type: Improvement
Reporter: Heng Chen
Assignee: Heng Chen
Priority: Trivial
Fix For: 2.0.0, 1.2.0, 1.3.0
Attachments: HBASE-14203.patch, HBASE-14203_v2.patch,
HBASE-14203_v3.patch, HBASE-14203_v4.patch, HBASE-14203_v5.patch
As TODO in comment said,
{{HTable.getTableDescriptor}} is same as {{HAdmin.getTableDescriptor}}.
remove the duplicate code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14203) remove duplicate code getTableDescriptor in HTable
[
https://issues.apache.org/jira/browse/HBASE-14203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700686#comment-14700686
]
Hudson commented on HBASE-14203:
SUCCESS: Integrated in HBase-1.2-IT #95 (See
[https://builds.apache.org/job/HBase-1.2-IT/95/])
HBASE-14203 remove duplicate code getTableDescriptor in HTable (Heng Chen)
(enis: rev 158839552fb765e3e330a3a905511c22eec6b2ce)
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
remove duplicate code getTableDescriptor in HTable
--
Key: HBASE-14203
URL: https://issues.apache.org/jira/browse/HBASE-14203
Project: HBase
Issue Type: Improvement
Reporter: Heng Chen
Assignee: Heng Chen
Priority: Trivial
Fix For: 2.0.0, 1.2.0, 1.3.0
Attachments: HBASE-14203.patch, HBASE-14203_v2.patch,
HBASE-14203_v3.patch, HBASE-14203_v4.patch, HBASE-14203_v5.patch
As TODO in comment said,
{{HTable.getTableDescriptor}} is same as {{HAdmin.getTableDescriptor}}.
remove the duplicate code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14203) remove duplicate code getTableDescriptor in HTable
[
https://issues.apache.org/jira/browse/HBASE-14203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14699091#comment-14699091
]
Heng Chen commented on HBASE-14203:
---
[~enis] any suggestions?
remove duplicate code getTableDescriptor in HTable
--
Key: HBASE-14203
URL: https://issues.apache.org/jira/browse/HBASE-14203
Project: HBase
Issue Type: Improvement
Reporter: Heng Chen
Priority: Trivial
Attachments: HBASE-14203.patch, HBASE-14203_v2.patch,
HBASE-14203_v3.patch, HBASE-14203_v4.patch, HBASE-14203_v5.patch
As TODO in comment said,
{{HTable.getTableDescriptor}} is same as {{HAdmin.getTableDescriptor}}.
remove the duplicate code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14203) remove duplicate code getTableDescriptor in HTable
[
https://issues.apache.org/jira/browse/HBASE-14203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14696905#comment-14696905
]
Enis Soztutar commented on HBASE-14203:
---
Thanks [~chenheng], patch looks good. Two more suggestions:
- lets make this package-protected. We do not want to expose it to users:
{code}
+ public static HTableDescriptor getTableDescriptor(final TableName tableName,
{code}
- It is not you, but we had recently changed the meta table descriptor so that
it is not hard coded anymore in HBaseAdmin. Let's also not return the hard
coded one in HTable and be consistent with the HBaseAdmin one:
{code}
+if (tableName != null tableName.equals(TableName.META_TABLE_NAME)) {
return HTableDescriptor.META_TABLEDESC;
}
{code}
remove duplicate code getTableDescriptor in HTable
--
Key: HBASE-14203
URL: https://issues.apache.org/jira/browse/HBASE-14203
Project: HBase
Issue Type: Improvement
Reporter: Heng Chen
Priority: Trivial
Attachments: HBASE-14203.patch, HBASE-14203_v2.patch,
HBASE-14203_v3.patch, HBASE-14203_v4.patch
As TODO in comment said,
{{HTable.getTableDescriptor}} is same as {{HAdmin.getTableDescriptor}}.
remove the duplicate code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14203) remove duplicate code getTableDescriptor in HTable
[
https://issues.apache.org/jira/browse/HBASE-14203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14697489#comment-14697489
]
Hadoop QA commented on HBASE-14203:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12750529/HBASE-14203_v5.patch
against master branch at commit f2a9dab30eb339c86222db47430f18f7abf405c2.
ATTACHMENT ID: 12750529
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
1860 checkstyle errors (more than the master's current 1856 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/15102//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15102//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/15102//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15102//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15102//console
This message is automatically generated.
remove duplicate code getTableDescriptor in HTable
--
Key: HBASE-14203
URL: https://issues.apache.org/jira/browse/HBASE-14203
Project: HBase
Issue Type: Improvement
Reporter: Heng Chen
Priority: Trivial
Attachments: HBASE-14203.patch, HBASE-14203_v2.patch,
HBASE-14203_v3.patch, HBASE-14203_v4.patch, HBASE-14203_v5.patch
As TODO in comment said,
{{HTable.getTableDescriptor}} is same as {{HAdmin.getTableDescriptor}}.
remove the duplicate code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14203) remove duplicate code getTableDescriptor in HTable
[
https://issues.apache.org/jira/browse/HBASE-14203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14694838#comment-14694838
]
Heng Chen commented on HBASE-14203:
---
[~enis] any suggestions?
remove duplicate code getTableDescriptor in HTable
--
Key: HBASE-14203
URL: https://issues.apache.org/jira/browse/HBASE-14203
Project: HBase
Issue Type: Improvement
Reporter: Heng Chen
Priority: Trivial
Attachments: HBASE-14203.patch, HBASE-14203_v2.patch,
HBASE-14203_v3.patch, HBASE-14203_v4.patch
As TODO in comment said,
{{HTable.getTableDescriptor}} is same as {{HAdmin.getTableDescriptor}}.
remove the duplicate code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14203) remove duplicate code getTableDescriptor in HTable
[
https://issues.apache.org/jira/browse/HBASE-14203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14693580#comment-14693580
]
Hadoop QA commented on HBASE-14203:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12750059/HBASE-14203_v4.patch
against master branch at commit aa3538f80278f5c0ba1bc8ca903066fa02ac79ec.
ATTACHMENT ID: 12750059
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
1861 checkstyle errors (more than the master's current 1857 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/15067//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15067//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/15067//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15067//console
This message is automatically generated.
remove duplicate code getTableDescriptor in HTable
--
Key: HBASE-14203
URL: https://issues.apache.org/jira/browse/HBASE-14203
Project: HBase
Issue Type: Improvement
Reporter: Heng Chen
Priority: Trivial
Attachments: HBASE-14203.patch, HBASE-14203_v2.patch,
HBASE-14203_v3.patch, HBASE-14203_v4.patch
As TODO in comment said,
{{HTable.getTableDescriptor}} is same as {{HAdmin.getTableDescriptor}}.
remove the duplicate code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14203) remove duplicate code getTableDescriptor in HTable
[
https://issues.apache.org/jira/browse/HBASE-14203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14694532#comment-14694532
]
Hadoop QA commented on HBASE-14203:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12750163/HBASE-14203_v4.patch
against master branch at commit beb1f1d358e7f786c510c988b09dab0f87945d1f.
ATTACHMENT ID: 12750163
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
1861 checkstyle errors (more than the master's current 1857 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.procedure.TestZKProcedureControllers
org.apache.hadoop.hbase.procedure.TestZKProcedure
org.apache.hadoop.hbase.mapreduce.TestImportExport
org.apache.hadoop.hbase.util.TestProcessBasedCluster
org.apache.hadoop.hbase.TestAcidGuarantees
{color:red}-1 core zombie tests{color}. There are 2 zombie test(s):
at
org.apache.phoenix.hbase.index.balancer.IndexLoadBalancerIT.testRoundRobinAssignmentDuringMasterStartUp(IndexLoadBalancerIT.java:420)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/15073//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15073//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/15073//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15073//console
This message is automatically generated.
remove duplicate code getTableDescriptor in HTable
--
Key: HBASE-14203
URL: https://issues.apache.org/jira/browse/HBASE-14203
Project: HBase
Issue Type: Improvement
Reporter: Heng Chen
Priority: Trivial
Attachments: HBASE-14203.patch, HBASE-14203_v2.patch,
HBASE-14203_v3.patch, HBASE-14203_v4.patch
As TODO in comment said,
{{HTable.getTableDescriptor}} is same as {{HAdmin.getTableDescriptor}}.
remove the duplicate code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14203) remove duplicate code getTableDescriptor in HTable
[
https://issues.apache.org/jira/browse/HBASE-14203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14694737#comment-14694737
]
Hadoop QA commented on HBASE-14203:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12750222/HBASE-14203_v4.patch
against master branch at commit d7178aa27c55ae06cfbd6db94d6839311dfb4089.
ATTACHMENT ID: 12750222
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
1863 checkstyle errors (more than the master's current 1859 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/15080//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15080//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/15080//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15080//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15080//console
This message is automatically generated.
remove duplicate code getTableDescriptor in HTable
--
Key: HBASE-14203
URL: https://issues.apache.org/jira/browse/HBASE-14203
Project: HBase
Issue Type: Improvement
Reporter: Heng Chen
Priority: Trivial
Attachments: HBASE-14203.patch, HBASE-14203_v2.patch,
HBASE-14203_v3.patch, HBASE-14203_v4.patch
As TODO in comment said,
{{HTable.getTableDescriptor}} is same as {{HAdmin.getTableDescriptor}}.
remove the duplicate code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14203) remove duplicate code getTableDescriptor in HTable
[
https://issues.apache.org/jira/browse/HBASE-14203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14693194#comment-14693194
]
Enis Soztutar commented on HBASE-14203:
---
Sorry this is not the right approach. We cannot have a singleton Admin returned
from Connection.getAdmin().
An Admin can be created in Connection impl, and maintained in the Connection
lifecycle, and this Admin can be passed to HTable on creation.
remove duplicate code getTableDescriptor in HTable
--
Key: HBASE-14203
URL: https://issues.apache.org/jira/browse/HBASE-14203
Project: HBase
Issue Type: Improvement
Reporter: Heng Chen
Priority: Trivial
Attachments: HBASE-14203.patch, HBASE-14203_v2.patch,
HBASE-14203_v3.patch
As TODO in comment said,
{{HTable.getTableDescriptor}} is same as {{HAdmin.getTableDescriptor}}.
remove the duplicate code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14203) remove duplicate code getTableDescriptor in HTable
[
https://issues.apache.org/jira/browse/HBASE-14203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14693243#comment-14693243
]
Enis Soztutar commented on HBASE-14203:
---
bq. Can i create HbaseAdmin instance in ConnectionImplementation constructor,
and return this instance when call Connection.getAdmin()
The contract for Connection.getAdmin() implies a new Admin is created which is
then closed by the caller.
I would pursue the static methods approach if you ask me.
remove duplicate code getTableDescriptor in HTable
--
Key: HBASE-14203
URL: https://issues.apache.org/jira/browse/HBASE-14203
Project: HBase
Issue Type: Improvement
Reporter: Heng Chen
Priority: Trivial
Attachments: HBASE-14203.patch, HBASE-14203_v2.patch,
HBASE-14203_v3.patch
As TODO in comment said,
{{HTable.getTableDescriptor}} is same as {{HAdmin.getTableDescriptor}}.
remove the duplicate code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14203) remove duplicate code getTableDescriptor in HTable
[
https://issues.apache.org/jira/browse/HBASE-14203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14693225#comment-14693225
]
Heng Chen commented on HBASE-14203:
---
{quote}
An Admin can be created in Connection impl, and maintained in the Connection
lifecycle, and this Admin can be passed to HTable on creation.
{quote}
Can i create {{HbaseAdmin}} instance in {{ConnectionImplementation}}
constructor, and return this instance when call {{Connection.getAdmin()}}
remove duplicate code getTableDescriptor in HTable
--
Key: HBASE-14203
URL: https://issues.apache.org/jira/browse/HBASE-14203
Project: HBase
Issue Type: Improvement
Reporter: Heng Chen
Priority: Trivial
Attachments: HBASE-14203.patch, HBASE-14203_v2.patch,
HBASE-14203_v3.patch
As TODO in comment said,
{{HTable.getTableDescriptor}} is same as {{HAdmin.getTableDescriptor}}.
remove the duplicate code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14203) remove duplicate code getTableDescriptor in HTable
[
https://issues.apache.org/jira/browse/HBASE-14203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14693180#comment-14693180
]
Hadoop QA commented on HBASE-14203:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12750017/HBASE-14203_v3.patch
against master branch at commit aa3538f80278f5c0ba1bc8ca903066fa02ac79ec.
ATTACHMENT ID: 12750017
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
1860 checkstyle errors (more than the master's current 1857 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/15066//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15066//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/15066//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15066//console
This message is automatically generated.
remove duplicate code getTableDescriptor in HTable
--
Key: HBASE-14203
URL: https://issues.apache.org/jira/browse/HBASE-14203
Project: HBase
Issue Type: Improvement
Reporter: Heng Chen
Priority: Trivial
Attachments: HBASE-14203.patch, HBASE-14203_v2.patch,
HBASE-14203_v3.patch
As TODO in comment said,
{{HTable.getTableDescriptor}} is same as {{HAdmin.getTableDescriptor}}.
remove the duplicate code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14203) remove duplicate code getTableDescriptor in HTable
[
https://issues.apache.org/jira/browse/HBASE-14203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14681412#comment-14681412
]
Hadoop QA commented on HBASE-14203:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12749760/HBASE-14203.patch
against master branch at commit 3d5801602da7cde1f20bdd4b898e8b3cac77f2a3.
ATTACHMENT ID: 12749760
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
1861 checkstyle errors (more than the master's current 1858 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.TestAcidGuarantees
org.apache.hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.hadoop.hbase.mob.mapreduce.TestMobSweeper.testSweeper(TestMobSweeper.java:195)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/15040//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15040//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/15040//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15040//console
This message is automatically generated.
remove duplicate code getTableDescriptor in HTable
--
Key: HBASE-14203
URL: https://issues.apache.org/jira/browse/HBASE-14203
Project: HBase
Issue Type: Improvement
Reporter: Heng Chen
Priority: Trivial
Attachments: HBASE-14203.patch
As TODO in comment said,
{{HTable.getTableDescriptor}} is same as {{HAdmin.getTableDescriptor}}.
remove the duplicate code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14203) remove duplicate code getTableDescriptor in HTable
[
https://issues.apache.org/jira/browse/HBASE-14203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14681616#comment-14681616
]
Enis Soztutar commented on HBASE-14203:
---
Creating an Admin is a costly operation. Maybe we can extract the method to be
a static one.
{code}
+HTableDescriptor htd =
this.connection.getAdmin().getTableDescriptor(tableName);
{code}
remove duplicate code getTableDescriptor in HTable
--
Key: HBASE-14203
URL: https://issues.apache.org/jira/browse/HBASE-14203
Project: HBase
Issue Type: Improvement
Reporter: Heng Chen
Priority: Trivial
Attachments: HBASE-14203.patch
As TODO in comment said,
{{HTable.getTableDescriptor}} is same as {{HAdmin.getTableDescriptor}}.
remove the duplicate code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14203) remove duplicate code getTableDescriptor in HTable
[
https://issues.apache.org/jira/browse/HBASE-14203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14681891#comment-14681891
]
Heng Chen commented on HBASE-14203:
---
{quote}
Creating an Admin is a costly operation. Maybe we can extract the method to be
a static one.
{quote}
Thanks for your reply!
I check the code, it has some difficulty to extract {{getTableDescriptor}} to
be a static one. Because in this function it calls non-static function. To
avoid create {{Admin}} every time when call {{Connection.getAdmin()}}, we can
use Singleton instance.
I update the patch.
remove duplicate code getTableDescriptor in HTable
--
Key: HBASE-14203
URL: https://issues.apache.org/jira/browse/HBASE-14203
Project: HBase
Issue Type: Improvement
Reporter: Heng Chen
Priority: Trivial
Attachments: HBASE-14203.patch, HBASE-14203_v2.patch
As TODO in comment said,
{{HTable.getTableDescriptor}} is same as {{HAdmin.getTableDescriptor}}.
remove the duplicate code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14203) remove duplicate code getTableDescriptor in HTable
[
https://issues.apache.org/jira/browse/HBASE-14203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14681840#comment-14681840
]
Hadoop QA commented on HBASE-14203:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12749795/HBASE-14203.patch
against master branch at commit 3d5801602da7cde1f20bdd4b898e8b3cac77f2a3.
ATTACHMENT ID: 12749795
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
1861 checkstyle errors (more than the master's current 1858 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/15041//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15041//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/15041//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15041//console
This message is automatically generated.
remove duplicate code getTableDescriptor in HTable
--
Key: HBASE-14203
URL: https://issues.apache.org/jira/browse/HBASE-14203
Project: HBase
Issue Type: Improvement
Reporter: Heng Chen
Priority: Trivial
Attachments: HBASE-14203.patch
As TODO in comment said,
{{HTable.getTableDescriptor}} is same as {{HAdmin.getTableDescriptor}}.
remove the duplicate code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-14203) remove duplicate code getTableDescriptor in HTable
[
https://issues.apache.org/jira/browse/HBASE-14203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14682138#comment-14682138
]
Hadoop QA commented on HBASE-14203:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12749858/HBASE-14203_v2.patch
against master branch at commit 7d4de20cafd6b765bd5f33df72fc0e630d1731f7.
ATTACHMENT ID: 12749858
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
1861 checkstyle errors (more than the master's current 1858 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestPerColumnFamilyFlush
org.apache.hadoop.hbase.client.TestSnapshotMetadata
org.apache.hadoop.hbase.replication.TestReplicationKillMasterRS
org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor
org.apache.hadoop.hbase.replication.TestReplicationDisableInactivePeer
org.apache.hadoop.hbase.mapreduce.TestTableInputFormatScan1
org.apache.hadoop.hbase.regionserver.TestEncryptionKeyRotation
org.apache.hadoop.hbase.client.TestMetaWithReplicas
org.apache.hadoop.hbase.mapreduce.TestImportTSVWithVisibilityLabels
org.apache.hadoop.hbase.coprocessor.TestRegionObserverInterface
org.apache.hadoop.hbase.client.TestFromClientSide3
org.apache.hadoop.hbase.mapreduce.TestHashTable
org.apache.hadoop.hbase.replication.TestReplicationKillMasterRSCompressed
org.apache.hadoop.hbase.client.TestCheckAndMutate
org.apache.hadoop.hbase.coprocessor.TestHTableWrapper
org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFiles
org.apache.hadoop.hbase.regionserver.TestHRegionOnCluster
org.apache.hadoop.hbase.regionserver.TestSplitWalDataLoss
org.apache.hadoop.hbase.util.TestHBaseFsck
org.apache.hadoop.hbase.client.TestMobCloneSnapshotFromClient
org.apache.hadoop.hbase.mapreduce.TestImportTSVWithTTLs
org.apache.hadoop.hbase.client.TestSnapshotCloneIndependence
org.apache.hadoop.hbase.replication.TestReplicationWithTags
org.apache.hadoop.hbase.mapreduce.TestCellCounter
org.apache.hadoop.hbase.security.access.TestNamespaceCommands
org.apache.hadoop.hbase.master.TestMasterShutdown
org.apache.hadoop.hbase.util.TestRegionSplitter
org.apache.hadoop.hbase.master.TestRestartCluster
org.apache.hadoop.hbase.master.normalizer.TestSimpleRegionNormalizerOnCluster
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
org.apache.hadoop.hbase.mapreduce.TestCopyTable
org.apache.hadoop.hbase.mapreduce.TestMultithreadedTableMapper
org.apache.hadoop.hbase.snapshot.TestMobSecureExportSnapshot
org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildOverlap
org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery
org.apache.hadoop.hbase.mob.compactions.TestMobCompactor
org.apache.hadoop.hbase.client.TestPutWithDelete
org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient
org.apache.hadoop.hbase.quotas.TestQuotaTableUtil
[jira] [Commented] (HBASE-14203) remove duplicate code getTableDescriptor in HTable
[
https://issues.apache.org/jira/browse/HBASE-14203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14682169#comment-14682169
]
Elliott Clark commented on HBASE-14203:
---
Don't synchronize on a non-final field.
remove duplicate code getTableDescriptor in HTable
--
Key: HBASE-14203
URL: https://issues.apache.org/jira/browse/HBASE-14203
Project: HBase
Issue Type: Improvement
Reporter: Heng Chen
Priority: Trivial
Attachments: HBASE-14203.patch, HBASE-14203_v2.patch
As TODO in comment said,
{{HTable.getTableDescriptor}} is same as {{HAdmin.getTableDescriptor}}.
remove the duplicate code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
