[jira] [Commented] (HBASE-16530) Reduce DBE code duplication
[ https://issues.apache.org/jira/browse/HBASE-16530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15477429#comment-15477429 ] Hudson commented on HBASE-16530: FAILURE: Integrated in Jenkins build HBase-1.4 #405 (See [https://builds.apache.org/job/HBase-1.4/405/]) HBASE-16530 Reduce DBE code duplication (liyu: rev ad67fd0816bde63ad3bf9ec13b7bb12ecd833c92) * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/BufferedDataBlockEncoder.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/CopyKeyDataBlockEncoder.java * (add) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/AbstractDataBlockEncoder.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/RowIndexSeekerV1.java * (add) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/NoneEncoder.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/RowIndexEncoderV1.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/NoOpDataBlockEncoder.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/RowIndexCodecV1.java > Reduce DBE code duplication > --- > > Key: HBASE-16530 > URL: https://issues.apache.org/jira/browse/HBASE-16530 > Project: HBase > Issue Type: Sub-task > Components: Performance >Reporter: binlijin >Assignee: binlijin > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-16530-master_V1.patch, > HBASE-16530-master_V2.patch, HBASE-16530-master_V3.patch, > HBASE-16530-master_V4.patch, HBASE-16530-master_V4.patch, > HBASE-16530.branch-1.v1.patch, HBASE-16530.branch-1.v1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16530) Reduce DBE code duplication
[ https://issues.apache.org/jira/browse/HBASE-16530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15476321#comment-15476321 ] Yu Li commented on HBASE-16530: --- My pleasure, thanks for the review again [~ram_krish] :-) > Reduce DBE code duplication > --- > > Key: HBASE-16530 > URL: https://issues.apache.org/jira/browse/HBASE-16530 > Project: HBase > Issue Type: Sub-task > Components: Performance >Reporter: binlijin >Assignee: binlijin > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-16530-master_V1.patch, > HBASE-16530-master_V2.patch, HBASE-16530-master_V3.patch, > HBASE-16530-master_V4.patch, HBASE-16530-master_V4.patch, > HBASE-16530.branch-1.v1.patch, HBASE-16530.branch-1.v1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16530) Reduce DBE code duplication
[ https://issues.apache.org/jira/browse/HBASE-16530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15475969#comment-15475969 ] ramkrishna.s.vasudevan commented on HBASE-16530: Thanks for committing this [~carp84]. > Reduce DBE code duplication > --- > > Key: HBASE-16530 > URL: https://issues.apache.org/jira/browse/HBASE-16530 > Project: HBase > Issue Type: Sub-task > Components: Performance >Reporter: binlijin >Assignee: binlijin > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-16530-master_V1.patch, > HBASE-16530-master_V2.patch, HBASE-16530-master_V3.patch, > HBASE-16530-master_V4.patch, HBASE-16530-master_V4.patch, > HBASE-16530.branch-1.v1.patch, HBASE-16530.branch-1.v1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16530) Reduce DBE code duplication
[
https://issues.apache.org/jira/browse/HBASE-16530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15475795#comment-15475795
]
Hadoop QA commented on HBASE-16530:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 18s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 22s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
20s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 55s
{color} | {color:green} branch-1 passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 56s
{color} | {color:green} branch-1 passed with JDK v1.7.0_111 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
47s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
31s {color} | {color:green} branch-1 passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 3s
{color} | {color:red} hbase-server in branch-1 has 1 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 50s
{color} | {color:green} branch-1 passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 58s
{color} | {color:green} branch-1 passed with JDK v1.7.0_111 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 12s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
12s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 55s
{color} | {color:green} the patch passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 55s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 50s
{color} | {color:green} the patch passed with JDK v1.7.0_111 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 50s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
44s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
26s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
15m 46s {color} | {color:green} The patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m
26s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
59s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 38s
{color} | {color:green} the patch passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 50s
{color} | {color:green} the patch passed with JDK v1.7.0_111 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 45s
{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 85m 15s {color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
30s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 124m 6s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.regionserver.TestHRegion |
\\
\\
|| Subsystem || Report/Notes ||
| Docker
[jira] [Commented] (HBASE-16530) Reduce DBE code duplication
[ https://issues.apache.org/jira/browse/HBASE-16530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15475566#comment-15475566 ] Yu Li commented on HBASE-16530: --- Could see UT runs normally for post-commit now, thanks for the quick response and actions [~stack] [~appy] [~busbey] > Reduce DBE code duplication > --- > > Key: HBASE-16530 > URL: https://issues.apache.org/jira/browse/HBASE-16530 > Project: HBase > Issue Type: Sub-task > Components: Performance >Reporter: binlijin >Assignee: binlijin > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-16530-master_V1.patch, > HBASE-16530-master_V2.patch, HBASE-16530-master_V3.patch, > HBASE-16530-master_V4.patch, HBASE-16530-master_V4.patch, > HBASE-16530.branch-1.v1.patch, HBASE-16530.branch-1.v1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16530) Reduce DBE code duplication
[ https://issues.apache.org/jira/browse/HBASE-16530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15474573#comment-15474573 ] Sean Busbey commented on HBASE-16530: - the solution is the same as the rest of our build infra headache work arounds: redo the jenkins job as a series of jobs instead of a multi-configuration job. it's ugly and it's unmaintainable but it will work for now. > Reduce DBE code duplication > --- > > Key: HBASE-16530 > URL: https://issues.apache.org/jira/browse/HBASE-16530 > Project: HBase > Issue Type: Sub-task > Components: Performance >Reporter: binlijin >Assignee: binlijin > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-16530-master_V1.patch, > HBASE-16530-master_V2.patch, HBASE-16530-master_V3.patch, > HBASE-16530-master_V4.patch, HBASE-16530-master_V4.patch, > HBASE-16530.branch-1.v1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16530) Reduce DBE code duplication
[ https://issues.apache.org/jira/browse/HBASE-16530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15474443#comment-15474443 ] Appy commented on HBASE-16530: -- This seems like one of the solutions to our problem or spaces. hudson.matrix.MatrixConfiguration.useShortWorkspaceName But it's global configuration, so not in our hands, and doesn't look like ASF would do such a think for all projects. > Reduce DBE code duplication > --- > > Key: HBASE-16530 > URL: https://issues.apache.org/jira/browse/HBASE-16530 > Project: HBase > Issue Type: Sub-task > Components: Performance >Reporter: binlijin >Assignee: binlijin > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-16530-master_V1.patch, > HBASE-16530-master_V2.patch, HBASE-16530-master_V3.patch, > HBASE-16530-master_V4.patch, HBASE-16530-master_V4.patch, > HBASE-16530.branch-1.v1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16530) Reduce DBE code duplication
[
https://issues.apache.org/jira/browse/HBASE-16530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15474412#comment-15474412
]
Appy commented on HBASE-16530:
--
So i found the issue, don't know the fix though.
Version.java is generated by saveVersion.sh which is run by maven-antrun-plugin
during generate-sources phase of hbase-common.
In trunk, that phase is failing.
{noformat}
[INFO] --- maven-antrun-plugin:1.8:run (generate) @ hbase-common ---
[INFO] Executing tasks
main:
[exec] bash:
/home/jenkins/jenkins-slave/workspace/HBase-Trunk_matrix/jdk/JDK: No such file
or directory
[exec] Result: 127
[INFO] Executed tasks
{noformat}
The culprit is spaces in JDK version name. :(
> Reduce DBE code duplication
> ---
>
> Key: HBASE-16530
> URL: https://issues.apache.org/jira/browse/HBASE-16530
> Project: HBase
> Issue Type: Sub-task
> Components: Performance
>Reporter: binlijin
>Assignee: binlijin
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-16530-master_V1.patch,
> HBASE-16530-master_V2.patch, HBASE-16530-master_V3.patch,
> HBASE-16530-master_V4.patch, HBASE-16530-master_V4.patch,
> HBASE-16530.branch-1.v1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16530) Reduce DBE code duplication
[
https://issues.apache.org/jira/browse/HBASE-16530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15474279#comment-15474279
]
Hadoop QA commented on HBASE-16530:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 17s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 16s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
56s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 44s
{color} | {color:green} branch-1 passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 51s
{color} | {color:green} branch-1 passed with JDK v1.7.0_111 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
44s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
27s {color} | {color:green} branch-1 passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 50s
{color} | {color:red} hbase-server in branch-1 has 1 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 39s
{color} | {color:green} branch-1 passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 51s
{color} | {color:green} branch-1 passed with JDK v1.7.0_111 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
3s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 45s
{color} | {color:green} the patch passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 45s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 51s
{color} | {color:green} the patch passed with JDK v1.7.0_111 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 51s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
42s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
28s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
16m 8s {color} | {color:green} The patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m
26s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
59s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 38s
{color} | {color:green} the patch passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 52s
{color} | {color:green} the patch passed with JDK v1.7.0_111 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 46s
{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 83m 31s {color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
31s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 120m 55s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.mapreduce.TestMultiTableSnapshotInputFormat
|
| |
[jira] [Commented] (HBASE-16530) Reduce DBE code duplication
[ https://issues.apache.org/jira/browse/HBASE-16530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15474251#comment-15474251 ] stack commented on HBASE-16530: --- Can you look at the above failure? I tried running it locally and seems to pass. > Reduce DBE code duplication > --- > > Key: HBASE-16530 > URL: https://issues.apache.org/jira/browse/HBASE-16530 > Project: HBase > Issue Type: Sub-task > Components: Performance >Reporter: binlijin >Assignee: binlijin > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-16530-master_V1.patch, > HBASE-16530-master_V2.patch, HBASE-16530-master_V3.patch, > HBASE-16530-master_V4.patch, HBASE-16530-master_V4.patch, > HBASE-16530.branch-1.v1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16530) Reduce DBE code duplication
[ https://issues.apache.org/jira/browse/HBASE-16530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15474154#comment-15474154 ] stack commented on HBASE-16530: --- [~appy]! > Reduce DBE code duplication > --- > > Key: HBASE-16530 > URL: https://issues.apache.org/jira/browse/HBASE-16530 > Project: HBase > Issue Type: Sub-task > Components: Performance >Reporter: binlijin >Assignee: binlijin > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-16530-master_V1.patch, > HBASE-16530-master_V2.patch, HBASE-16530-master_V3.patch, > HBASE-16530-master_V4.patch, HBASE-16530-master_V4.patch, > HBASE-16530.branch-1.v1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16530) Reduce DBE code duplication
[ https://issues.apache.org/jira/browse/HBASE-16530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15473489#comment-15473489 ] binlijin commented on HBASE-16530: -- ok > Reduce DBE code duplication > --- > > Key: HBASE-16530 > URL: https://issues.apache.org/jira/browse/HBASE-16530 > Project: HBase > Issue Type: Sub-task > Components: Performance >Reporter: binlijin >Assignee: binlijin > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-16530-master_V1.patch, > HBASE-16530-master_V2.patch, HBASE-16530-master_V3.patch, > HBASE-16530-master_V4.patch, HBASE-16530-master_V4.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16530) Reduce DBE code duplication
[ https://issues.apache.org/jira/browse/HBASE-16530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15473490#comment-15473490 ] binlijin commented on HBASE-16530: -- ok > Reduce DBE code duplication > --- > > Key: HBASE-16530 > URL: https://issues.apache.org/jira/browse/HBASE-16530 > Project: HBase > Issue Type: Sub-task > Components: Performance >Reporter: binlijin >Assignee: binlijin > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-16530-master_V1.patch, > HBASE-16530-master_V2.patch, HBASE-16530-master_V3.patch, > HBASE-16530-master_V4.patch, HBASE-16530-master_V4.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16530) Reduce DBE code duplication
[
https://issues.apache.org/jira/browse/HBASE-16530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15473445#comment-15473445
]
Yu Li commented on HBASE-16530:
---
It seems the post-commit check failed because of below compilation error since
Sep. 5th, mind take a look here Boss? [~busbey] [~stack]
{noformat}
[ERROR] COMPILATION ERROR :
[INFO] -
[ERROR] /home/jenkins/jenkins-slave/workspace/HBase-Trunk_matrix/jdk/JDK 1.8
(latest)/label/yahoo-not-h2/hbase-common/src/main/java/org/apache/hadoop/hbase/util/VersionInfo.java:[26,31]
cannot find symbol
symbol: class Version
location: package org.apache.hadoop.hbase
[ERROR] /home/jenkins/jenkins-slave/workspace/HBase-Trunk_matrix/jdk/JDK 1.8
(latest)/label/yahoo-not-h2/hbase-common/src/main/java/org/apache/hadoop/hbase/util/VersionInfo.java:[43,12]
cannot find symbol
symbol: variable Version
location: class org.apache.hadoop.hbase.util.VersionInfo
{noformat}
> Reduce DBE code duplication
> ---
>
> Key: HBASE-16530
> URL: https://issues.apache.org/jira/browse/HBASE-16530
> Project: HBase
> Issue Type: Sub-task
> Components: Performance
>Reporter: binlijin
>Assignee: binlijin
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-16530-master_V1.patch,
> HBASE-16530-master_V2.patch, HBASE-16530-master_V3.patch,
> HBASE-16530-master_V4.patch, HBASE-16530-master_V4.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16530) Reduce DBE code duplication
[ https://issues.apache.org/jira/browse/HBASE-16530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472886#comment-15472886 ] Yu Li commented on HBASE-16530: --- Pushed to master branch, thanks all for review [~ram_krish] [~anoop.hbase] For branch-1, current patch cannot be applied directly. Please supply the branch-1 patch [~aoxiang], thanks. > Reduce DBE code duplication > --- > > Key: HBASE-16530 > URL: https://issues.apache.org/jira/browse/HBASE-16530 > Project: HBase > Issue Type: Sub-task > Components: Performance >Reporter: binlijin >Assignee: binlijin > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-16530-master_V1.patch, > HBASE-16530-master_V2.patch, HBASE-16530-master_V3.patch, > HBASE-16530-master_V4.patch, HBASE-16530-master_V4.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16530) Reduce DBE code duplication
[ https://issues.apache.org/jira/browse/HBASE-16530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472699#comment-15472699 ] Yu Li commented on HBASE-16530: --- +1 on patch v4, checked the failed UT TestDispatchMergingRegionsProcedure on local and it passed, should be irrelative to the changes here. > Reduce DBE code duplication > --- > > Key: HBASE-16530 > URL: https://issues.apache.org/jira/browse/HBASE-16530 > Project: HBase > Issue Type: Sub-task > Components: Performance >Reporter: binlijin >Assignee: binlijin > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-16530-master_V1.patch, > HBASE-16530-master_V2.patch, HBASE-16530-master_V3.patch, > HBASE-16530-master_V4.patch, HBASE-16530-master_V4.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16530) Reduce DBE code duplication
[
https://issues.apache.org/jira/browse/HBASE-16530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15469941#comment-15469941
]
Hadoop QA commented on HBASE-16530:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 17s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 11s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
46s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 0s
{color} | {color:green} master passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 9s
{color} | {color:green} master passed with JDK v1.7.0_111 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
54s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
29s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 0s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 46s
{color} | {color:green} master passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 56s
{color} | {color:green} master passed with JDK v1.7.0_111 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 12s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
9s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 53s
{color} | {color:green} the patch passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 53s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 58s
{color} | {color:green} the patch passed with JDK v1.7.0_111 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 58s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
44s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
28s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
30m 44s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m
31s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
30s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 45s
{color} | {color:green} the patch passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 58s
{color} | {color:green} the patch passed with JDK v1.7.0_111 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 55s
{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 98m 14s {color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
31s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 154m 45s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hbase.master.procedure.TestDispatchMergingRegionsProcedure |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2
[jira] [Commented] (HBASE-16530) Reduce DBE code duplication
[ https://issues.apache.org/jira/browse/HBASE-16530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15469593#comment-15469593 ] ramkrishna.s.vasudevan commented on HBASE-16530: I think this unification is great. +1 on V4. Will commit this later today unless objections. > Reduce DBE code duplication > --- > > Key: HBASE-16530 > URL: https://issues.apache.org/jira/browse/HBASE-16530 > Project: HBase > Issue Type: Sub-task > Components: Performance >Reporter: binlijin > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-16530-master_V1.patch, > HBASE-16530-master_V2.patch, HBASE-16530-master_V3.patch, > HBASE-16530-master_V4.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16530) Reduce DBE code duplication
[ https://issues.apache.org/jira/browse/HBASE-16530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15469256#comment-15469256 ] binlijin commented on HBASE-16530: -- How about now? > Reduce DBE code duplication > --- > > Key: HBASE-16530 > URL: https://issues.apache.org/jira/browse/HBASE-16530 > Project: HBase > Issue Type: Sub-task > Components: Performance >Reporter: binlijin > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-16530-master_V1.patch, > HBASE-16530-master_V2.patch, HBASE-16530-master_V3.patch, > HBASE-16530-master_V4.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16530) Reduce DBE code duplication
[ https://issues.apache.org/jira/browse/HBASE-16530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15467506#comment-15467506 ] binlijin commented on HBASE-16530: -- OK, let me try it. > Reduce DBE code duplication > --- > > Key: HBASE-16530 > URL: https://issues.apache.org/jira/browse/HBASE-16530 > Project: HBase > Issue Type: Sub-task > Components: Performance >Reporter: binlijin > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-16530-master_V1.patch, > HBASE-16530-master_V2.patch, HBASE-16530-master_V3.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16530) Reduce DBE code duplication
[ https://issues.apache.org/jira/browse/HBASE-16530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15466424#comment-15466424 ] ramkrishna.s.vasudevan commented on HBASE-16530: Thanks for the patch. I went thro the code and I think instead of this new Util method can we check if we can allow the NoopDataBlockEncoder to be used for this CopyKeyDataBlockEncoder and the new ones? The encoding code wil not be repeated and can be unified. Any thoughts!!! > Reduce DBE code duplication > --- > > Key: HBASE-16530 > URL: https://issues.apache.org/jira/browse/HBASE-16530 > Project: HBase > Issue Type: Sub-task > Components: Performance >Reporter: binlijin > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-16530-master_V1.patch, > HBASE-16530-master_V2.patch, HBASE-16530-master_V3.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16530) Reduce DBE code duplication
[ https://issues.apache.org/jira/browse/HBASE-16530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15451737#comment-15451737 ] binlijin commented on HBASE-16530: -- ok > Reduce DBE code duplication > --- > > Key: HBASE-16530 > URL: https://issues.apache.org/jira/browse/HBASE-16530 > Project: HBase > Issue Type: Sub-task > Components: Performance >Reporter: binlijin > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-16530-master_V1.patch, HBASE-16530-master_V2.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16530) Reduce DBE code duplication
[ https://issues.apache.org/jira/browse/HBASE-16530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15451710#comment-15451710 ] ramkrishna.s.vasudevan commented on HBASE-16530: Oh sorry for adding ByteBufferedDataEncoder it is BufferedDataBlockEncoder and AbstractDataBlockEncoder > Reduce DBE code duplication > --- > > Key: HBASE-16530 > URL: https://issues.apache.org/jira/browse/HBASE-16530 > Project: HBase > Issue Type: Sub-task > Components: Performance >Reporter: binlijin > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-16530-master_V1.patch, HBASE-16530-master_V2.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16530) Reduce DBE code duplication
[
https://issues.apache.org/jira/browse/HBASE-16530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15451636#comment-15451636
]
binlijin commented on HBASE-16530:
--
{quote}
Mark IA.Private for this AbstractDataBlockEncoder .
{quote}
Ok, miss it.
{quote}
Do we need this 'NoDataBlockEncoderUtil'? It is also missing IA.Private
annotation.
{quote}
I do not know where to put, so add a new class.
{quote}
Can we add a static method in
ByteBufferedDataEncoder/AbstractByteBufferedDataEncoder itself and call that
from the 3 algo implementations?
{quote}
Sorry i do not find ByteBufferedDataEncoder/AbstractByteBufferedDataEncoder.
{quote}
Some more code duplicates were there reg the tag compression and tag encoding
and decoding? I remember seeing that. May be it is corrected now in the last
commits?
{quote}
ROW_INDEX_V1 do not have tag compression now.
> Reduce DBE code duplication
> ---
>
> Key: HBASE-16530
> URL: https://issues.apache.org/jira/browse/HBASE-16530
> Project: HBase
> Issue Type: Sub-task
> Components: Performance
>Reporter: binlijin
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-16530-master_V1.patch, HBASE-16530-master_V2.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-16530) Reduce DBE code duplication
[ https://issues.apache.org/jira/browse/HBASE-16530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15451605#comment-15451605 ] ramkrishna.s.vasudevan commented on HBASE-16530: Mark IA.Private for this AbstractDataBlockEncoder . Do we need this 'NoDataBlockEncoderUtil'? It is also missing IA.Private annotation. Can we add a static method in ByteBufferedDataEncoder/AbstractByteBufferedDataEncoder itself and call that from the 3 algo implementations? Some more code duplicates were there reg the tag compression and tag encoding and decoding? I remember seeing that. May be it is corrected now in the last commits? > Reduce DBE code duplication > --- > > Key: HBASE-16530 > URL: https://issues.apache.org/jira/browse/HBASE-16530 > Project: HBase > Issue Type: Sub-task > Components: Performance >Reporter: binlijin > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-16530-master_V1.patch, HBASE-16530-master_V2.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16530) Reduce DBE code duplication
[ https://issues.apache.org/jira/browse/HBASE-16530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15451557#comment-15451557 ] binlijin commented on HBASE-16530: -- Oh, very sorry for it. > Reduce DBE code duplication > --- > > Key: HBASE-16530 > URL: https://issues.apache.org/jira/browse/HBASE-16530 > Project: HBase > Issue Type: Sub-task > Components: Performance >Reporter: binlijin > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-16530-master_V1.patch, HBASE-16530-master_V2.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16530) Reduce DBE code duplication
[ https://issues.apache.org/jira/browse/HBASE-16530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15451548#comment-15451548 ] Anoop Sam John commented on HBASE-16530: Where are the new Abstract classes? Missing in the patch! > Reduce DBE code duplication > --- > > Key: HBASE-16530 > URL: https://issues.apache.org/jira/browse/HBASE-16530 > Project: HBase > Issue Type: Sub-task > Components: Performance >Reporter: binlijin > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-16530-master_V1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-16530) Reduce DBE code duplication
[ https://issues.apache.org/jira/browse/HBASE-16530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15451487#comment-15451487 ] binlijin commented on HBASE-16530: -- [~anoop.hbase] mind to take a look and give some advice? > Reduce DBE code duplication > --- > > Key: HBASE-16530 > URL: https://issues.apache.org/jira/browse/HBASE-16530 > Project: HBase > Issue Type: Sub-task > Components: Performance >Reporter: binlijin > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-16530-master_V1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
