[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[ https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16192708#comment-16192708 ] Hudson commented on HBASE-17614: FAILURE: Integrated in Jenkins build HBase-2.0 #629 (See [https://builds.apache.org/job/HBase-2.0/629/]) HBASE-17614 (addendum) Remove extraneous .DS_Store file. (busbey: rev e4d03d0001e1f9a51abfcb161c7d11912d179220) * (delete) hbase-backup/.DS_Store > Move Backup/Restore into separate module > - > > Key: HBASE-17614 > URL: https://issues.apache.org/jira/browse/HBASE-17614 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch, > HBASE-17614-v3.patch, HBASE-17614-v4.patch, HBASE-17614-v5.patch, > HBASE-17614-v5.patch > > > Move all the backup code into separate hbase-backup module. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[ https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16139368#comment-16139368 ] Hudson commented on HBASE-17614: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3585 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3585/]) HBASE-17614 (addendum) Remove extraneous .DS_Store file. (appy: rev ae052e454029ed4963707112f3897b919d43596f) * (delete) hbase-backup/.DS_Store > Move Backup/Restore into separate module > - > > Key: HBASE-17614 > URL: https://issues.apache.org/jira/browse/HBASE-17614 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch, > HBASE-17614-v3.patch, HBASE-17614-v4.patch, HBASE-17614-v5.patch, > HBASE-17614-v5.patch > > > Move all the backup code into separate hbase-backup module. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[ https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16139162#comment-16139162 ] Hudson commented on HBASE-17614: FAILURE: Integrated in Jenkins build HBase-2.0 #383 (See [https://builds.apache.org/job/HBase-2.0/383/]) HBASE-17614: Move Backup/Restore into separate module (Vladimir (elserj: rev 37c65946274c6acdb8650fc91f889b61f95b3a64) * (delete) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/HBackupFileSystem.java * (delete) hbase-server/src/test/java/org/apache/hadoop/hbase/backup/TestFullBackupWithFailures.java * (delete) hbase-server/src/test/java/org/apache/hadoop/hbase/backup/TestBackupHFileCleaner.java * (delete) hbase-server/src/test/java/org/apache/hadoop/hbase/backup/TestBackupSystemTable.java * (delete) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/BackupRestoreFactory.java * (edit) hbase-it/pom.xml * (delete) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/RestoreRequest.java * (add) hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupBoundaryTests.java * (add) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/mapreduce/MapReduceBackupCopyJob.java * (add) hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestIncrementalBackupWithBulkLoad.java * (delete) hbase-server/src/test/java/org/apache/hadoop/hbase/backup/master/TestBackupLogCleaner.java * (add) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/BackupInfo.java * (add) hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestRestoreBoundaryTests.java * (add) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/TableBackupClient.java * (delete) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/BackupRequest.java * (add) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/util/BackupUtils.java * (add) hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestSystemTableSnapshot.java * (add) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/util/RestoreTool.java * (add) hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupSystemTable.java * (add) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManifest.java * (delete) hbase-server/src/test/java/org/apache/hadoop/hbase/backup/TestRestoreBoundaryTests.java * (add) hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupCommandLineTool.java * (add) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/master/BackupLogCleaner.java * (add) hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestFullBackupSet.java * (delete) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/impl/IncrementalBackupManager.java * (delete) hbase-server/src/test/java/org/apache/hadoop/hbase/backup/TestFullRestore.java * (add) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/IncrementalTableBackupClient.java * (add) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/regionserver/LogRollRegionServerProcedureManager.java * (add) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/BackupAdmin.java * (add) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/RestoreJob.java * (add) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java * (add) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/BackupHFileCleaner.java * (add) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupException.java * (add) hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestFullRestore.java * (add) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupAdminImpl.java * (delete) hbase-server/src/test/java/org/apache/hadoop/hbase/backup/TestFullBackup.java * (add) hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestFullBackupSetRestoreSet.java * (delete) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/BackupObserver.java * (delete) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManifest.java * (add) hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupStatusProgress.java * (delete) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/BackupRestoreConstants.java * (add) hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupDescribe.java * (add) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/BackupRestoreFactory.java * (add) hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestRepairAfterFailedDelete.java * (delete) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/BackupClientFactory.java * (add) hbase-backup/src/test/resources/log4j.properties * (add) hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestRemoteBackup.java * (add) hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestIncrementalBackupWithFailures.java * (delete) hbase-server/src/main/java/org/apache/hadoop/hbase/
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[ https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16138813#comment-16138813 ] Appy commented on HBASE-17614: -- Removed the .DS_Store file. > Move Backup/Restore into separate module > - > > Key: HBASE-17614 > URL: https://issues.apache.org/jira/browse/HBASE-17614 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch, > HBASE-17614-v3.patch, HBASE-17614-v4.patch, HBASE-17614-v5.patch, > HBASE-17614-v5.patch > > > Move all the backup code into separate hbase-backup module. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[ https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16138810#comment-16138810 ] Josh Elser commented on HBASE-17614: bq. We committed a useless file "hbase-backup/.DS_Store". Josh Elser Would you please remove it ? Sorry about that! Just noticed [~appy] already removed it. Thanks! > Move Backup/Restore into separate module > - > > Key: HBASE-17614 > URL: https://issues.apache.org/jira/browse/HBASE-17614 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch, > HBASE-17614-v3.patch, HBASE-17614-v4.patch, HBASE-17614-v5.patch, > HBASE-17614-v5.patch > > > Move all the backup code into separate hbase-backup module. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[ https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16138792#comment-16138792 ] Hudson commented on HBASE-17614: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3584 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3584/]) HBASE-17614: Move Backup/Restore into separate module (Vladimir (elserj: rev 2dda371209b2e810fa76034b8fa8dcf47140e265) * (add) hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestFullBackup.java * (delete) hbase-server/src/test/java/org/apache/hadoop/hbase/backup/TestBackupBoundaryTests.java * (delete) hbase-server/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRepair.java * (add) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/BackupHFileCleaner.java * (delete) hbase-server/src/test/java/org/apache/hadoop/hbase/backup/TestFullRestore.java * (delete) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/master/BackupLogCleaner.java * (delete) hbase-server/src/test/java/org/apache/hadoop/hbase/backup/TestBackupShowHistory.java * (delete) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/RestoreJob.java * (delete) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/BackupMergeJob.java * (delete) hbase-server/src/test/java/org/apache/hadoop/hbase/backup/TestBackupMultipleDeletes.java * (delete) hbase-server/src/test/java/org/apache/hadoop/hbase/backup/TestBackupSystemTable.java * (delete) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/HBackupFileSystem.java * (add) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/IncrementalBackupManager.java * (delete) hbase-server/src/test/java/org/apache/hadoop/hbase/backup/master/TestBackupLogCleaner.java * (add) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/regionserver/LogRollRegionServerProcedureManager.java * (add) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/BackupTableInfo.java * (delete) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/BackupHFileCleaner.java * (add) hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestRepairAfterFailedDelete.java * (add) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/BackupDriver.java * (add) hbase-backup/.DS_Store * (add) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupException.java * (add) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/TableBackupClient.java * (delete) hbase-server/src/test/java/org/apache/hadoop/hbase/backup/TestBackupDeleteWithFailures.java * (edit) hbase-it/pom.xml * (delete) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/util/BackupSet.java * (delete) hbase-server/src/test/java/org/apache/hadoop/hbase/backup/TestFullBackupSetRestoreSet.java * (add) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/RestoreRequest.java * (add) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/RestoreJob.java * (add) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/mapreduce/MapReduceBackupMergeJob.java * (delete) hbase-server/src/test/java/org/apache/hadoop/hbase/backup/TestSystemTableSnapshot.java * (add) hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupBoundaryTests.java * (delete) hbase-server/src/test/java/org/apache/hadoop/hbase/backup/TestBackupDeleteRestore.java * (delete) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/BackupDriver.java * (add) hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestIncrementalBackupMergeWithFailures.java * (add) hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestFullBackupSet.java * (edit) hbase-assembly/src/main/assembly/hadoop-two-compat.xml * (delete) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/util/BackupUtils.java * (add) hbase-backup/pom.xml * (add) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/BackupObserver.java * (add) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupAdminImpl.java * (add) hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupDelete.java * (delete) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/impl/IncrementalBackupManager.java * (delete) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/impl/IncrementalTableBackupClient.java * (delete) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/LogUtils.java * (add) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/BackupClientFactory.java * (add) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupSystemTable.java * (delete) hbase-server/src/main/java/org/apache/hadoop/hbase/backup/BackupObserver.java * (add) hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupDescribe.java * (add) hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestFullBackupWithFailures.java * (add) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/BackupR
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[ https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16138769#comment-16138769 ] Chia-Ping Tsai commented on HBASE-17614: We committed a useless file "hbase-backup/.DS_Store". [~elserj] Would you please remove it ? > Move Backup/Restore into separate module > - > > Key: HBASE-17614 > URL: https://issues.apache.org/jira/browse/HBASE-17614 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch, > HBASE-17614-v3.patch, HBASE-17614-v4.patch, HBASE-17614-v5.patch, > HBASE-17614-v5.patch > > > Move all the backup code into separate hbase-backup module. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[ https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16138583#comment-16138583 ] Josh Elser commented on HBASE-17614: Hahha, yup, I'm on it ;) > Move Backup/Restore into separate module > - > > Key: HBASE-17614 > URL: https://issues.apache.org/jira/browse/HBASE-17614 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch, > HBASE-17614-v3.patch, HBASE-17614-v4.patch, HBASE-17614-v5.patch, > HBASE-17614-v5.patch > > > Move all the backup code into separate hbase-backup module. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[ https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16138562#comment-16138562 ] stack commented on HBASE-17614: --- Commit quick. The failed test was fixed last night in another issue. > Move Backup/Restore into separate module > - > > Key: HBASE-17614 > URL: https://issues.apache.org/jira/browse/HBASE-17614 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch, > HBASE-17614-v3.patch, HBASE-17614-v4.patch, HBASE-17614-v5.patch, > HBASE-17614-v5.patch > > > Move all the backup code into separate hbase-backup module. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[
https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16138173#comment-16138173
]
Hadoop QA commented on HBASE-17614:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
18s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 59 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
31s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
44s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hbase-assembly . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
57s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
19s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 5m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 3m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
8s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
39m 31s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: .
hbase-assembly {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m
38s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}112m 16s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 8m
31s{color} | {color:green} hbase-backup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
26s{color} | {color:green} hbase-it in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}156m
4s{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
24s{color} | {color:green} hbase-assembly in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
18s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}370m 38s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests |
org.apache.hadoop.hbase.client.TestAsyncClusterAdminApi2 |
\\
\\
|| Subsystem || Report/Notes ||
| Docke
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[
https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137948#comment-16137948
]
Hadoop QA commented on HBASE-17614:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
19s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 59 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
33s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
43s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hbase-assembly . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
30s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 5m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
7s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
34m 28s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: .
hbase-assembly {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 99m
55s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 8m
29s{color} | {color:green} hbase-backup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
25s{color} | {color:green} hbase-it in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}151m
41s{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
33s{color} | {color:green} hbase-assembly in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
27s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}344m 17s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-17614 |
| JIRA Patch UR
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[ https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137838#comment-16137838 ] Josh Elser commented on HBASE-17614: bq. Edit: Basically, copy the block out of hbase-server/pom.xml in both cases, and you'll be good to go. Thanks for the tl;dr ;) bq. Suggest getting a clean run on jenkins and then commit. Thanks, Stack. I'll pick this up tmrw morning and do whatever is needed from your last re-attach. > Move Backup/Restore into separate module > - > > Key: HBASE-17614 > URL: https://issues.apache.org/jira/browse/HBASE-17614 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch, > HBASE-17614-v3.patch, HBASE-17614-v4.patch, HBASE-17614-v5.patch, > HBASE-17614-v5.patch > > > Move all the backup code into separate hbase-backup module. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[ https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137829#comment-16137829 ] stack commented on HBASE-17614: --- Where: stack@ve0524:~/hbase.git/hbase-backup$ uname -a Linux ve0524 3.13.0-83-generic #127-Ubuntu SMP Fri Mar 11 00:25:37 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux stack@ve0524:~/hbase.git/hbase-backup$ more /etc/issue Ubuntu 14.04.4 LTS \n \l How: 2709 mvn clean install -DskipTests 2710 cd hbase-backup/ 2712 mvn test -PrunAllTests We haven't purge the timeouts from build box yet but I do notice that in the set of failures there are these: TestBackupLogCleaner ... distinct from the Timedout tests. Let me retry. > Move Backup/Restore into separate module > - > > Key: HBASE-17614 > URL: https://issues.apache.org/jira/browse/HBASE-17614 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch, > HBASE-17614-v3.patch, HBASE-17614-v4.patch, HBASE-17614-v5.patch, > HBASE-17614-v5.patch > > > Move all the backup code into separate hbase-backup module. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[
https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137771#comment-16137771
]
Hadoop QA commented on HBASE-17614:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
31s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 58 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
35s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m
23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 3m
24s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hbase-assembly . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 5m
9s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
19s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 7m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 5m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 4m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
13s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
52m 39s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: .
hbase-assembly {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}177m
25s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 20m 15s{color}
| {color:red} hbase-backup in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
39s{color} | {color:green} hbase-it in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}101m 6s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
49s{color} | {color:green} hbase-assembly in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 2m
53s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}426m 25s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.backup.master.TestBackupLogCleaner |
| | hadoop.hbase.backup.master.TestBackupLogCleaner |
| Timed ou
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[
https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137705#comment-16137705
]
Vladimir Rodionov commented on HBASE-17614:
---
[~stack], how do you run tests? and where?
All test pass locally on my MBP.
The command I ran:
{code}
time mvn clean package -Dtest=org.apache.hadoop.hbase.backup.*
{code}
> Move Backup/Restore into separate module
> -
>
> Key: HBASE-17614
> URL: https://issues.apache.org/jira/browse/HBASE-17614
> Project: HBase
> Issue Type: Task
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
>Priority: Blocker
> Labels: backup
> Fix For: 2.0.0
>
> Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch,
> HBASE-17614-v3.patch, HBASE-17614-v4.patch, HBASE-17614-v5.patch
>
>
> Move all the backup code into separate hbase-backup module.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[
https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137703#comment-16137703
]
Mike Drob commented on HBASE-17614:
---
bq. Mike Drob, you all-clear now? Or should I still tread lightly on branch-2
to avoid smacking you?
Nah, do whatever. Master you'll want parent to be {{hbase-build-configuration}}
and branch-2 you'll want {{hbase}}, but you will need to adjust for version in
the pom.xml anyway, so it's not like you were getting a clean backport. If
error-prone ends up getting backported to branch-2 (I keep waffling back and
forth on this) then I'll deal with the conflicts then, you shouldn't have to
worry about making less work for me at this point.
> Move Backup/Restore into separate module
> -
>
> Key: HBASE-17614
> URL: https://issues.apache.org/jira/browse/HBASE-17614
> Project: HBase
> Issue Type: Task
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
>Priority: Blocker
> Labels: backup
> Fix For: 2.0.0
>
> Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch,
> HBASE-17614-v3.patch, HBASE-17614-v4.patch, HBASE-17614-v5.patch
>
>
> Move all the backup code into separate hbase-backup module.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[
https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137654#comment-16137654
]
stack commented on HBASE-17614:
---
Ran again:
{code}
---
T E S T S
---
Running org.apache.hadoop.hbase.backup.TestBackupHFileCleaner
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 49.127 sec - in
org.apache.hadoop.hbase.backup.TestBackupHFileCleaner
Running org.apache.hadoop.hbase.backup.TestBackupCommandLineTool
Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.743 sec - in
org.apache.hadoop.hbase.backup.TestBackupCommandLineTool
Results :
Tests run: 17, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] --- maven-surefire-plugin:2.19.1:test (secondPartTestsExecution) @
hbase-backup ---
---
T E S T S
---
Running org.apache.hadoop.hbase.backup.TestIncrementalBackupDeleteTable
Running org.apache.hadoop.hbase.backup.TestBackupDescribe
Running org.apache.hadoop.hbase.backup.TestIncrementalBackupMergeWithFailures
Running org.apache.hadoop.hbase.backup.TestFullBackupSet
Running org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 518.986 sec <<<
FAILURE! - in org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner
testBackupLogCleaner(org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner)
Time elapsed: 516.534 sec <<< FAILURE!
java.lang.AssertionError
at
org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner.testBackupLogCleaner(TestBackupLogCleaner.java:93)
Running org.apache.hadoop.hbase.backup.TestBackupRepair
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 553.194 sec -
in org.apache.hadoop.hbase.backup.TestBackupDescribe
Running org.apache.hadoop.hbase.backup.TestRemoteRestore
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 602.338 sec -
in org.apache.hadoop.hbase.backup.TestFullBackupSet
Running org.apache.hadoop.hbase.backup.TestBackupShowHistory
Running org.apache.hadoop.hbase.backup.TestFullBackup
Running org.apache.hadoop.hbase.backup.TestRemoteBackup
Running org.apache.hadoop.hbase.backup.TestBackupStatusProgress
Running org.apache.hadoop.hbase.backup.TestIncrementalBackup
Running org.apache.hadoop.hbase.backup.TestBackupMultipleDeletes
Running org.apache.hadoop.hbase.backup.TestBackupBoundaryTests
Running org.apache.hadoop.hbase.backup.TestFullRestore
Running org.apache.hadoop.hbase.backup.TestRepairAfterFailedDelete
Running org.apache.hadoop.hbase.backup.TestBackupDeleteRestore
Running org.apache.hadoop.hbase.backup.TestIncrementalBackupWithBulkLoad
Running org.apache.hadoop.hbase.backup.TestRestoreBoundaryTests
Running org.apache.hadoop.hbase.backup.TestBackupDeleteWithFailures
Running org.apache.hadoop.hbase.backup.TestBackupDelete
Running org.apache.hadoop.hbase.backup.TestIncrementalBackupWithFailures
Running org.apache.hadoop.hbase.backup.TestFullBackupSetRestoreSet
Running org.apache.hadoop.hbase.backup.TestFullBackupWithFailures
Results :
Failed tests:
TestBackupLogCleaner.testBackupLogCleaner:93
Tests run: 6, Failures: 1, Errors: 0, Skipped: 0
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 20:08.911s
[INFO] Finished at: Tue Aug 22 17:09:44 PDT 2017
[INFO] Final Memory: 43M/1779M
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test
(secondPartTestsExecution) on project hbase-backup: ExecutionException The
forked VM terminated without properly saying goodbye. VM crash or System.exit
called?
[ERROR] Command was /bin/sh -c cd /home/stack/hbase.git/hbase-backup &&
/home/stack/bin/jdk1.8.0_101/jre/bin/java -enableassertions
-Dhbase.build.id=2017-08-22T16:49:35Z -Xmx2800m
-Djava.security.egd=file:/dev/./urandom -Djava.net.preferIPv4Stack=true
-Djava.awt.headless=true -jar
/home/stack/hbase.git/hbase-backup/target/surefire/surefirebooter3260628695888461598.jar
/home/stack/hbase.git/hbase-backup/target/surefire/surefire6421378557322491102tmp
/home/stack/hbase.git/hbase-backup/target/surefire/surefire_326873114336621816595tmp
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
{code}
> Move Backup/Resto
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[ https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137625#comment-16137625 ] stack commented on HBASE-17614: --- It just failed for me: --- T E S T S --- Running org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 428.16 sec <<< FAILURE! - in org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner testBackupLogCleaner(org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner) Time elapsed: 425.234 sec <<< FAILURE! java.lang.AssertionError at org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner.testBackupLogCleaner(TestBackupLogCleaner.java:93) Results : Failed tests: TestBackupLogCleaner.testBackupLogCleaner:93 Tests run: 1, Failures: 1, Errors: 0, Skipped: 0 [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 7:14.154s [INFO] Finished at: Tue Aug 22 16:45:37 PDT 2017 [INFO] Final Memory: 54M/2040M [INFO] > Move Backup/Restore into separate module > - > > Key: HBASE-17614 > URL: https://issues.apache.org/jira/browse/HBASE-17614 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch, > HBASE-17614-v3.patch, HBASE-17614-v4.patch > > > Move all the backup code into separate hbase-backup module. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[ https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137622#comment-16137622 ] stack commented on HBASE-17614: --- It gets stuck if I look at logs. Suggest getting a clean run on jenkins and then commit. > Move Backup/Restore into separate module > - > > Key: HBASE-17614 > URL: https://issues.apache.org/jira/browse/HBASE-17614 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch, > HBASE-17614-v3.patch, HBASE-17614-v4.patch > > > Move all the backup code into separate hbase-backup module. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[ https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137579#comment-16137579 ] Vladimir Rodionov commented on HBASE-17614: --- On my MBP 2014 test takes 105 sec to finish OK, this looks weird. When I tried what [~elserj] runs : *mvn clean package -Dtest=.. * - it failed with the same error. I usually run tests using : *mvn test -Dtest=... * - this runs OK for the test. [~elserj], can you try *mvn test*? > Move Backup/Restore into separate module > - > > Key: HBASE-17614 > URL: https://issues.apache.org/jira/browse/HBASE-17614 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch, > HBASE-17614-v3.patch, HBASE-17614-v4.patch > > > Move all the backup code into separate hbase-backup module. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[
https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137572#comment-16137572
]
Josh Elser commented on HBASE-17614:
{noformat}
Running org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 83.801 sec - in
org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner
Results :
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
{noformat}
/me groans. This passed after I added log4j.properties to
hbase-backup/src/test/resources.
[~stack], curious it takes so much longer for you. Busy/slow disk? Something
else?
At this point, I think it would be best to commit (I also see some commented
out stuff in hbase-backup/pom.xml that I would delete before commit) and deal
with problematic tests on the asf infra. Any objections? I'm +1 at this point.
[~mdrob], you all-clear now? Or should I still tread lightly on branch-2 to
avoid smacking you?
> Move Backup/Restore into separate module
> -
>
> Key: HBASE-17614
> URL: https://issues.apache.org/jira/browse/HBASE-17614
> Project: HBase
> Issue Type: Task
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
>Priority: Blocker
> Labels: backup
> Fix For: 2.0.0
>
> Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch,
> HBASE-17614-v3.patch, HBASE-17614-v4.patch
>
>
> Move all the backup code into separate hbase-backup module.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[ https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137560#comment-16137560 ] stack commented on HBASE-17614: --- Test passed for me but it runs for too long; its a ten minute test. Does it have to be this long? > Move Backup/Restore into separate module > - > > Key: HBASE-17614 > URL: https://issues.apache.org/jira/browse/HBASE-17614 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch, > HBASE-17614-v3.patch, HBASE-17614-v4.patch > > > Move all the backup code into separate hbase-backup module. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[
https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137559#comment-16137559
]
Josh Elser commented on HBASE-17614:
Fails in the exact same spot for me on my linux box too:
{noformat}
Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-10T16:41:47+00:00)
Maven home: /usr/share/maven-bin-3.3
Java version: 1.8.0_131, vendor: Oracle Corporation
Java home: /opt/oracle-jdk-bin-1.8.0.131/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.5.5-x86_64-linode69", arch: "amd64", family:
"unix"
{noformat}
> Move Backup/Restore into separate module
> -
>
> Key: HBASE-17614
> URL: https://issues.apache.org/jira/browse/HBASE-17614
> Project: HBase
> Issue Type: Task
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
>Priority: Blocker
> Labels: backup
> Fix For: 2.0.0
>
> Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch,
> HBASE-17614-v3.patch, HBASE-17614-v4.patch
>
>
> Move all the backup code into separate hbase-backup module.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[ https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137534#comment-16137534 ] Ted Yu commented on HBASE-17614: I ran TestBackupLogCleaner with patch v4 which passed. > Move Backup/Restore into separate module > - > > Key: HBASE-17614 > URL: https://issues.apache.org/jira/browse/HBASE-17614 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch, > HBASE-17614-v3.patch, HBASE-17614-v4.patch > > > Move all the backup code into separate hbase-backup module. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[
https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137469#comment-16137469
]
Josh Elser commented on HBASE-17614:
{noformat}
Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426;
2017-04-03T15:39:06-04:00)
Maven home: /usr/local/Cellar/maven/3.5.0/libexec
Java version: 1.8.0_131, vendor: Oracle Corporation
Java home: /Library/Java/JavaVirtualMachines/jdk1.8.0_131.jdk/Contents/Home/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.11.6", arch: "x86_64", family: "mac"
{noformat}
Seems to failing all the time for me using {{mvn clean package
-Dtest='org.apache.hadoop.hbase.backup.master.*'}} with your patch on top of
5b42d8195017d21b4343964d14db3deea15d1474 (HEAD of master, as of a short while
ago). It is the only one which failed for me.
I can also try to dig into it some more once I finish up the other thing I'm
debugging at the moment :P
> Move Backup/Restore into separate module
> -
>
> Key: HBASE-17614
> URL: https://issues.apache.org/jira/browse/HBASE-17614
> Project: HBase
> Issue Type: Task
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
>Priority: Blocker
> Labels: backup
> Fix For: 2.0.0
>
> Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch,
> HBASE-17614-v3.patch, HBASE-17614-v4.patch
>
>
> Move all the backup code into separate hbase-backup module.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[ https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137453#comment-16137453 ] Vladimir Rodionov commented on HBASE-17614: --- [~elserj], I can not reproduce it locally. How do you run the test? Is it the only one which fails? > Move Backup/Restore into separate module > - > > Key: HBASE-17614 > URL: https://issues.apache.org/jira/browse/HBASE-17614 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch, > HBASE-17614-v3.patch, HBASE-17614-v4.patch > > > Move all the backup code into separate hbase-backup module. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[
https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137441#comment-16137441
]
Josh Elser commented on HBASE-17614:
{noformat}
Running org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 56.919 sec <<<
FAILURE! - in org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner
testBackupLogCleaner(org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner)
Time elapsed: 54.294 sec <<< FAILURE!
java.lang.AssertionError: expected:<0> but was:<1>
at
org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner.testBackupLogCleaner(TestBackupLogCleaner.java:94)
{noformat}
> Move Backup/Restore into separate module
> -
>
> Key: HBASE-17614
> URL: https://issues.apache.org/jira/browse/HBASE-17614
> Project: HBase
> Issue Type: Task
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
>Priority: Blocker
> Labels: backup
> Fix For: 2.0.0
>
> Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch,
> HBASE-17614-v3.patch, HBASE-17614-v4.patch
>
>
> Move all the backup code into separate hbase-backup module.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[ https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137436#comment-16137436 ] Vladimir Rodionov commented on HBASE-17614: --- Looking into this. > Move Backup/Restore into separate module > - > > Key: HBASE-17614 > URL: https://issues.apache.org/jira/browse/HBASE-17614 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch, > HBASE-17614-v3.patch, HBASE-17614-v4.patch > > > Move all the backup code into separate hbase-backup module. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[
https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137413#comment-16137413
]
Josh Elser commented on HBASE-17614:
[~vrodionov], TestBackupLogCleaner seems to be failing reliably for me:
{noformat}
Running org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 56.117 sec <<<
FAILURE! - in org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner
testBackupLogCleaner(org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner)
Time elapsed: 53.557 sec <<< FAILURE!
java.lang.AssertionError
at
org.apache.hadoop.hbase.backup.master.TestBackupLogCleaner.testBackupLogCleaner(TestBackupLogCleaner.java:93)
{noformat}
Currently tweaking the test so I can get an actual failure message out of it
(the downside of using {{assertTrue}} like this).
> Move Backup/Restore into separate module
> -
>
> Key: HBASE-17614
> URL: https://issues.apache.org/jira/browse/HBASE-17614
> Project: HBase
> Issue Type: Task
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
>Priority: Blocker
> Labels: backup
> Fix For: 2.0.0
>
> Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch,
> HBASE-17614-v3.patch, HBASE-17614-v4.patch
>
>
> Move all the backup code into separate hbase-backup module.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[ https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137247#comment-16137247 ] Josh Elser commented on HBASE-17614: ACK [~mdrob]. Will reach out via chat before I do anything. > Move Backup/Restore into separate module > - > > Key: HBASE-17614 > URL: https://issues.apache.org/jira/browse/HBASE-17614 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch, > HBASE-17614-v3.patch, HBASE-17614-v4.patch > > > Move all the backup code into separate hbase-backup module. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[ https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137238#comment-16137238 ] Josh Elser commented on HBASE-17614: Thanks [~vrodionov]! Taking a look. > Move Backup/Restore into separate module > - > > Key: HBASE-17614 > URL: https://issues.apache.org/jira/browse/HBASE-17614 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch, > HBASE-17614-v3.patch, HBASE-17614-v4.patch > > > Move all the backup code into separate hbase-backup module. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[ https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137240#comment-16137240 ] Mike Drob commented on HBASE-17614: --- [~elserj], [~stack] - please coordinate with me while committing, I plan to push HBASE-12349 soon and this will conflict with that. > Move Backup/Restore into separate module > - > > Key: HBASE-17614 > URL: https://issues.apache.org/jira/browse/HBASE-17614 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch, > HBASE-17614-v3.patch, HBASE-17614-v4.patch > > > Move all the backup code into separate hbase-backup module. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[
https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137223#comment-16137223
]
Vladimir Rodionov commented on HBASE-17614:
---
{quote}
downloaded the patch and tried running the tests locally
{quote}
Verified locally. All test pass. TestHFileArchiving is not backup test and is
not part of this feature (but it runs OK as well). I accidentally moved it to
backup module. v4 reverts this move.
[~elserj], the patch is ready and wants to be committed :)
> Move Backup/Restore into separate module
> -
>
> Key: HBASE-17614
> URL: https://issues.apache.org/jira/browse/HBASE-17614
> Project: HBase
> Issue Type: Task
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
>Priority: Blocker
> Labels: backup
> Fix For: 2.0.0
>
> Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch,
> HBASE-17614-v3.patch, HBASE-17614-v4.patch
>
>
> Move all the backup code into separate hbase-backup module.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[
https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136235#comment-16136235
]
stack commented on HBASE-17614:
---
I downloaded the patch and tried running the tests locally to see if it was
just our infra. This is what I got when I tried to run them:
{code}
---
T E S T S
---
Running org.apache.hadoop.hbase.backup.TestBackupDeleteRestore
Running org.apache.hadoop.hbase.backup.TestBackupSystemTable
Tests run: 15, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 21.485 sec -
in org.apache.hadoop.hbase.backup.TestBackupSystemTable
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 41.663 sec - in
org.apache.hadoop.hbase.backup.TestBackupDeleteRestore
Running org.apache.hadoop.hbase.backup.TestHFileArchiving
Tests run: 5, Failures: 0, Errors: 4, Skipped: 0, Time elapsed: 20.586 sec <<<
FAILURE! - in org.apache.hadoop.hbase.backup.TestHFileArchiving
testDeleteRegionWithNoStoreFiles(org.apache.hadoop.hbase.backup.TestHFileArchiving)
Time elapsed: 0.06 sec <<< ERROR!
org.apache.hadoop.hbase.DoNotRetryIOException:
org.apache.hadoop.hbase.DoNotRetryIOException: MEMSTORE_FLUSHSIZE for table
descriptor or "hbase.hregion.memstore.flush.size" (25000) is too small, which
might cause very frequent flushing. Set hbase.table.sanity.checks to false at
conf or table descriptor if you want to bypass sanity checks
at
org.apache.hadoop.hbase.master.HMaster.warnOrThrowExceptionForFailure(HMaster.java:1970)
at
org.apache.hadoop.hbase.master.HMaster.sanityCheckTableDescriptor(HMaster.java:1816)
at org.apache.hadoop.hbase.master.HMaster.createTable(HMaster.java:1725)
at
org.apache.hadoop.hbase.master.MasterRpcServices.createTable(MasterRpcServices.java:446)
at
org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:406)
at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133)
at
org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:278)
at
org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:258)
at
org.apache.hadoop.hbase.backup.TestHFileArchiving.testDeleteRegionWithNoStoreFiles(TestHFileArchiving.java:180)
Caused by: org.apache.hadoop.hbase.ipc.RemoteWithExtrasException:
org.apache.hadoop.hbase.DoNotRetryIOException: MEMSTORE_FLUSHSIZE for table
descriptor or "hbase.hregion.memstore.flush.size" (25000) is too small, which
might cause very frequent flushing. Set hbase.table.sanity.checks to false at
conf or table descriptor if you want to bypass sanity checks
at
org.apache.hadoop.hbase.master.HMaster.warnOrThrowExceptionForFailure(HMaster.java:1970)
at
org.apache.hadoop.hbase.master.HMaster.sanityCheckTableDescriptor(HMaster.java:1816)
at org.apache.hadoop.hbase.master.HMaster.createTable(HMaster.java:1725)
at
org.apache.hadoop.hbase.master.MasterRpcServices.createTable(MasterRpcServices.java:446)
at
org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:406)
at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133)
at
org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:278)
at
org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:258)
testRemovesRegionDirOnArchive(org.apache.hadoop.hbase.backup.TestHFileArchiving)
Time elapsed: 0.007 sec <<< ERROR!
org.apache.hadoop.hbase.DoNotRetryIOException:
org.apache.hadoop.hbase.DoNotRetryIOException: MEMSTORE_FLUSHSIZE for table
descriptor or "hbase.hregion.memstore.flush.size" (25000) is too small, which
might cause very frequent flushing. Set hbase.table.sanity.checks to false at
conf or table descriptor if you want to bypass sanity checks
at
org.apache.hadoop.hbase.master.HMaster.warnOrThrowExceptionForFailure(HMaster.java:1970)
at
org.apache.hadoop.hbase.master.HMaster.sanityCheckTableDescriptor(HMaster.java:1816)
at org.apache.hadoop.hbase.master.HMaster.createTable(HMaster.java:1725)
at
org.apache.hadoop.hbase.master.MasterRpcServices.createTable(MasterRpcServices.java:446)
at
org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:406)
at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133)
at
org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:278)
at
org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecut
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[
https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136205#comment-16136205
]
Hadoop QA commented on HBASE-17614:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 60 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
43s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
32s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hbase-assembly . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
21s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 5m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
8s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
32m 49s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: .
hbase-assembly {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}111m
34s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 16m 36s{color}
| {color:red} hbase-backup in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
30s{color} | {color:green} hbase-it in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}162m
56s{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
51s{color} | {color:green} hbase-assembly in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
37s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}375m 5s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-17614 |
| JIRA Patch URL |
https
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[ https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135962#comment-16135962 ] stack commented on HBASE-17614: --- Otherwise, +1 from me. Something up w/ build box these times causing loads of tests to fail. > Move Backup/Restore into separate module > - > > Key: HBASE-17614 > URL: https://issues.apache.org/jira/browse/HBASE-17614 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch, > HBASE-17614-v3.patch > > > Move all the backup code into separate hbase-backup module. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[
https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135867#comment-16135867
]
Appy commented on HBASE-17614:
--
nit: will be better to move the version to dependencyManagement of root pom
rather than in modules' pom (currently in hbase-it).
{noformat}
org.apache.hbase
hbase-backup
${project.version}
{noformat}
> Move Backup/Restore into separate module
> -
>
> Key: HBASE-17614
> URL: https://issues.apache.org/jira/browse/HBASE-17614
> Project: HBase
> Issue Type: Task
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
>Priority: Blocker
> Labels: backup
> Fix For: 2.0.0
>
> Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch,
> HBASE-17614-v3.patch
>
>
> Move all the backup code into separate hbase-backup module.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[
https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16129867#comment-16129867
]
Hadoop QA commented on HBASE-17614:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 60 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
47s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
33s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hbase-assembly . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
29s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 5m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
8s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
35m 22s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: .
hbase-assembly {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
36s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 99m 46s{color}
| {color:red} hbase-server in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 3m 42s{color}
| {color:red} hbase-backup in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
24s{color} | {color:green} hbase-it in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}119m 34s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
33s{color} | {color:green} hbase-assembly in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
22s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}310m 44s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.regionserver.TestSplitTransactionOnCluster |
| | hadoop.hbase.regionserver.TestCompactionInDeadRegionServer |
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[
https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16129826#comment-16129826
]
Hadoop QA commented on HBASE-17614:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
23s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 60 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
35s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
37s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hbase-assembly . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
48s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
24s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 5m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
9s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
34m 46s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: .
hbase-assembly {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
52s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}133m 54s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 4m 10s{color}
| {color:red} hbase-backup in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
29s{color} | {color:green} hbase-it in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}150m 42s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
34s{color} | {color:green} hbase-assembly in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
18s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}374m 35s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hbase.regionserver.TestRegionServerReadRequestMetrics |
| | hadoop.hbase.backup.master.TestBackupLogCleaner |
|
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[ https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16129569#comment-16129569 ] Vladimir Rodionov commented on HBASE-17614: --- Patch v3 addresses [~mdrob] comments > Move Backup/Restore into separate module > - > > Key: HBASE-17614 > URL: https://issues.apache.org/jira/browse/HBASE-17614 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch, > HBASE-17614-v3.patch > > > Move all the backup code into separate hbase-backup module. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[
https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16129418#comment-16129418
]
Mike Drob commented on HBASE-17614:
---
extra whitespace changes in {{hbase-assembly/src/main/assembly/components.xml}}
(not enough by itself to warrant a v3 patch)
are the exclusions from hadoop-common necessary? seems like that should be in
the top level if it's needed, not buried in a module.
> Move Backup/Restore into separate module
> -
>
> Key: HBASE-17614
> URL: https://issues.apache.org/jira/browse/HBASE-17614
> Project: HBase
> Issue Type: Task
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
>Priority: Blocker
> Labels: backup
> Fix For: 2.0.0
>
> Attachments: HBASE-17614-v1.patch, HBASE-17614-v2.patch
>
>
> Move all the backup code into separate hbase-backup module.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[ https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16129013#comment-16129013 ] Josh Elser commented on HBASE-17614: bq. Otherwise looking good... Failures related? We seem to fail alot and then the rerun passes. Infra? Yeah, I think they're infra related but haven't made the time to dig into "why" yet. > Move Backup/Restore into separate module > - > > Key: HBASE-17614 > URL: https://issues.apache.org/jira/browse/HBASE-17614 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Labels: backup > Fix For: 2.0.0 > > Attachments: HBASE-17614-v1.patch > > > Move all the backup code into separate hbase-backup module. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[
https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16129005#comment-16129005
]
stack commented on HBASE-17614:
---
Should hbase-backup be dependent on hbase-protocol-shaded rather than
hbase-protocol (it is using internals, not coprocessor endpoints):
${basedir}/../hbase-protocol/src/main/protobuf
Related, does this new module need this dependency:
132
133 org.apache.hbase
134 hbase-protocol
135
Can we purge this:
166
167 com.google.protobuf
168 protobuf-java
169
and depend on the internal protobuf at hbase-shaded-protobuf... from
thirdparty.
Otherwise looking good... Failures related? We seem to fail alot and then the
rerun passes. Infra?
> Move Backup/Restore into separate module
> -
>
> Key: HBASE-17614
> URL: https://issues.apache.org/jira/browse/HBASE-17614
> Project: HBase
> Issue Type: Task
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
>Priority: Blocker
> Labels: backup
> Fix For: 2.0.0
>
> Attachments: HBASE-17614-v1.patch
>
>
> Move all the backup code into separate hbase-backup module.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[
https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16128473#comment-16128473
]
Hadoop QA commented on HBASE-17614:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
19s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 60 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
34s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
25s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hbase-assembly . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
54s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 5m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 3m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
11s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
37m 8s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: .
hbase-assembly {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}103m
38s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 21m 51s{color}
| {color:red} hbase-backup in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
24s{color} | {color:green} hbase-it in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}113m 14s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
30s{color} | {color:green} hbase-assembly in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
29s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}328m 34s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.backup.master.TestBackupLogCleaner |
| | hadoop.hbase.backup.TestHFileArchiving |
| | hadoop.hbase.
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[
https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16128227#comment-16128227
]
Josh Elser commented on HBASE-17614:
Thanks for the quick turnaround, Vlad! Looks pretty good overall.
Looks like you have some unnecessary dependencies in hbase-backup. I believe
all of the following can be dropped (a trivial build passed locally):
* org.apache.hbase:hbase-protocol
* org.apache.htrace:htrace-core
* org.codehaus.jackson:jackson-mapper-asl
* org.jruby.jcodings:jcodings
* org.jruby.joni:joni
* io.dropwizard.metrics:metrics-core
You can drop {{protobuf-maven-plugin}} from hbase-backup/pom.xml completely. I
don't think this is actually doing anything (but could be mistaken).
Please make the module name in the hbase-backup/pom.xml {{Apache HBase -
Backup}} for consistency with the other modules.
Note to self: Make sure to get the right parent-pom version in
hbase-backup/pom.xml for master and branch-2 (they differ).
> Move Backup/Restore into separate module
> -
>
> Key: HBASE-17614
> URL: https://issues.apache.org/jira/browse/HBASE-17614
> Project: HBase
> Issue Type: Task
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
>Priority: Blocker
> Labels: backup
> Fix For: 2.0.0
>
> Attachments: HBASE-17614-v1.patch
>
>
> Move all the backup code into separate hbase-backup module.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[ https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16126434#comment-16126434 ] Josh Elser commented on HBASE-17614: Just had a chat with Vlad offline. He already has this one on his plate for this week so I assigned it accordingly. > Move Backup/Restore into separate module > - > > Key: HBASE-17614 > URL: https://issues.apache.org/jira/browse/HBASE-17614 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Blocker > Fix For: 2.0.0, HBASE-7912 > > > Move all the backup code into separate hbase-backup module. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
[ https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16106665#comment-16106665 ] stack commented on HBASE-17614: --- This issue is a blocker for 2.0.0. We can't ship a 2.0.0 w/ hbase-server bulked up w/ backup classes. > Move Backup/Restore into separate module > - > > Key: HBASE-17614 > URL: https://issues.apache.org/jira/browse/HBASE-17614 > Project: HBase > Issue Type: Task >Reporter: Vladimir Rodionov >Priority: Blocker > Fix For: 2.0.0, HBASE-7912 > > > Move all the backup code into separate hbase-backup module. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
