[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16090279#comment-16090279 ] Hudson commented on HBASE-18268: FAILURE: Integrated in Jenkins build HBASE-14070.HLC #69 (See [https://builds.apache.org/job/HBASE-14070.HLC/69/]) HBASE-18268 Eliminate the findbugs warnings for hbase-client (chia7712: rev cc4301ca0842d9c3f66dfa39c5627744f5f91a8c) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/ColumnFamilyDescriptorBuilder.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AbstractRpcClient.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/util/PoolMap.java > Eliminate the findbugs warnings for hbase-client > > > Key: HBASE-18268 > URL: https://issues.apache.org/jira/browse/HBASE-18268 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-2 > > Attachments: HBASE-18268.branch-1.2.v0.patch, > HBASE-18268.branch-1.3.v0.patch, HBASE-18268.branch-1.3.v0.patch, > HBASE-18268.branch-1.v0.patch, HBASE-18268.branch-1.v0.patch, > HBASE-18268.v0.patch, HBASE-18268.v1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083304#comment-16083304 ] Hudson commented on HBASE-18268: SUCCESS: Integrated in Jenkins build HBase-1.3-JDK7 #196 (See [https://builds.apache.org/job/HBase-1.3-JDK7/196/]) HBASE-18268 Eliminate the findbugs warnings for hbase-client (chia7712: rev a84de33129054685c3b6c138bae79ea0e52f9479) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/util/PoolMap.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClientImpl.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AsyncRpcChannel.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslUtil.java > Eliminate the findbugs warnings for hbase-client > > > Key: HBASE-18268 > URL: https://issues.apache.org/jira/browse/HBASE-18268 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-2 > > Attachments: HBASE-18268.branch-1.2.v0.patch, > HBASE-18268.branch-1.3.v0.patch, HBASE-18268.branch-1.3.v0.patch, > HBASE-18268.branch-1.v0.patch, HBASE-18268.branch-1.v0.patch, > HBASE-18268.v0.patch, HBASE-18268.v1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083279#comment-16083279 ] Chia-Ping Tsai commented on HBASE-18268: TestReplicator pass on my machine..Will keep an eye on it. > Eliminate the findbugs warnings for hbase-client > > > Key: HBASE-18268 > URL: https://issues.apache.org/jira/browse/HBASE-18268 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-2 > > Attachments: HBASE-18268.branch-1.2.v0.patch, > HBASE-18268.branch-1.3.v0.patch, HBASE-18268.branch-1.3.v0.patch, > HBASE-18268.branch-1.v0.patch, HBASE-18268.branch-1.v0.patch, > HBASE-18268.v0.patch, HBASE-18268.v1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083244#comment-16083244 ] Hudson commented on HBASE-18268: FAILURE: Integrated in Jenkins build HBase-1.3-JDK8 #210 (See [https://builds.apache.org/job/HBase-1.3-JDK8/210/]) HBASE-18268 Eliminate the findbugs warnings for hbase-client (chia7712: rev a84de33129054685c3b6c138bae79ea0e52f9479) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AsyncRpcChannel.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/util/PoolMap.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslUtil.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClientImpl.java > Eliminate the findbugs warnings for hbase-client > > > Key: HBASE-18268 > URL: https://issues.apache.org/jira/browse/HBASE-18268 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-2 > > Attachments: HBASE-18268.branch-1.2.v0.patch, > HBASE-18268.branch-1.3.v0.patch, HBASE-18268.branch-1.3.v0.patch, > HBASE-18268.branch-1.v0.patch, HBASE-18268.branch-1.v0.patch, > HBASE-18268.v0.patch, HBASE-18268.v1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083182#comment-16083182 ] Hudson commented on HBASE-18268: FAILURE: Integrated in Jenkins build HBase-2.0 #156 (See [https://builds.apache.org/job/HBase-2.0/156/]) HBASE-18268 Eliminate the findbugs warnings for hbase-client (chia7712: rev ca5d8c40b7e39260f919cb6205acc2a875a1f118) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AbstractRpcClient.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/ColumnFamilyDescriptorBuilder.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/util/PoolMap.java > Eliminate the findbugs warnings for hbase-client > > > Key: HBASE-18268 > URL: https://issues.apache.org/jira/browse/HBASE-18268 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-2 > > Attachments: HBASE-18268.branch-1.2.v0.patch, > HBASE-18268.branch-1.3.v0.patch, HBASE-18268.branch-1.3.v0.patch, > HBASE-18268.branch-1.v0.patch, HBASE-18268.branch-1.v0.patch, > HBASE-18268.v0.patch, HBASE-18268.v1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083221#comment-16083221 ] Hudson commented on HBASE-18268: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3358 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3358/]) HBASE-18268 Eliminate the findbugs warnings for hbase-client (chia7712: rev cc4301ca0842d9c3f66dfa39c5627744f5f91a8c) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AbstractRpcClient.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/ColumnFamilyDescriptorBuilder.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/util/PoolMap.java > Eliminate the findbugs warnings for hbase-client > > > Key: HBASE-18268 > URL: https://issues.apache.org/jira/browse/HBASE-18268 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-2 > > Attachments: HBASE-18268.branch-1.2.v0.patch, > HBASE-18268.branch-1.3.v0.patch, HBASE-18268.branch-1.3.v0.patch, > HBASE-18268.branch-1.v0.patch, HBASE-18268.branch-1.v0.patch, > HBASE-18268.v0.patch, HBASE-18268.v1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083160#comment-16083160 ] Hudson commented on HBASE-18268: FAILURE: Integrated in Jenkins build HBase-1.4 #806 (See [https://builds.apache.org/job/HBase-1.4/806/]) HBASE-18268 Eliminate the findbugs warnings for hbase-client (chia7712: rev 8eaad678662d4c26ea90cdfe7a1d89c832da354c) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/util/PoolMap.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AbstractRpcClient.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java > Eliminate the findbugs warnings for hbase-client > > > Key: HBASE-18268 > URL: https://issues.apache.org/jira/browse/HBASE-18268 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-2 > > Attachments: HBASE-18268.branch-1.2.v0.patch, > HBASE-18268.branch-1.3.v0.patch, HBASE-18268.branch-1.3.v0.patch, > HBASE-18268.branch-1.v0.patch, HBASE-18268.branch-1.v0.patch, > HBASE-18268.v0.patch, HBASE-18268.v1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083095#comment-16083095 ] Hudson commented on HBASE-18268: SUCCESS: Integrated in Jenkins build HBase-1.2-JDK7 #162 (See [https://builds.apache.org/job/HBase-1.2-JDK7/162/]) HBASE-18268 Eliminate the findbugs warnings for hbase-client (chia7712: rev d11b5d1fd54a71cbd58ab616ffe73c106fa0b9f2) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslUtil.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/util/PoolMap.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClientImpl.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AsyncRpcChannel.java > Eliminate the findbugs warnings for hbase-client > > > Key: HBASE-18268 > URL: https://issues.apache.org/jira/browse/HBASE-18268 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-2 > > Attachments: HBASE-18268.branch-1.2.v0.patch, > HBASE-18268.branch-1.3.v0.patch, HBASE-18268.branch-1.3.v0.patch, > HBASE-18268.branch-1.v0.patch, HBASE-18268.branch-1.v0.patch, > HBASE-18268.v0.patch, HBASE-18268.v1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083070#comment-16083070 ] Hudson commented on HBASE-18268: SUCCESS: Integrated in Jenkins build HBase-1.2-JDK8 #158 (See [https://builds.apache.org/job/HBase-1.2-JDK8/158/]) HBASE-18268 Eliminate the findbugs warnings for hbase-client (chia7712: rev d11b5d1fd54a71cbd58ab616ffe73c106fa0b9f2) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslUtil.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AsyncRpcChannel.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/util/PoolMap.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClientImpl.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java > Eliminate the findbugs warnings for hbase-client > > > Key: HBASE-18268 > URL: https://issues.apache.org/jira/browse/HBASE-18268 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-2 > > Attachments: HBASE-18268.branch-1.2.v0.patch, > HBASE-18268.branch-1.3.v0.patch, HBASE-18268.branch-1.3.v0.patch, > HBASE-18268.branch-1.v0.patch, HBASE-18268.branch-1.v0.patch, > HBASE-18268.v0.patch, HBASE-18268.v1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16082845#comment-16082845 ] Hudson commented on HBASE-18268: SUCCESS: Integrated in Jenkins build HBase-1.2-IT #895 (See [https://builds.apache.org/job/HBase-1.2-IT/895/]) HBASE-18268 Eliminate the findbugs warnings for hbase-client (chia7712: rev d11b5d1fd54a71cbd58ab616ffe73c106fa0b9f2) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslUtil.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AsyncRpcChannel.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/util/PoolMap.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClientImpl.java > Eliminate the findbugs warnings for hbase-client > > > Key: HBASE-18268 > URL: https://issues.apache.org/jira/browse/HBASE-18268 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-2 > > Attachments: HBASE-18268.branch-1.2.v0.patch, > HBASE-18268.branch-1.3.v0.patch, HBASE-18268.branch-1.3.v0.patch, > HBASE-18268.branch-1.v0.patch, HBASE-18268.branch-1.v0.patch, > HBASE-18268.v0.patch, HBASE-18268.v1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16082818#comment-16082818 ] Hudson commented on HBASE-18268: SUCCESS: Integrated in Jenkins build HBase-1.3-IT #135 (See [https://builds.apache.org/job/HBase-1.3-IT/135/]) HBASE-18268 Eliminate the findbugs warnings for hbase-client (chia7712: rev a84de33129054685c3b6c138bae79ea0e52f9479) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClientImpl.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslUtil.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AsyncRpcChannel.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/util/PoolMap.java > Eliminate the findbugs warnings for hbase-client > > > Key: HBASE-18268 > URL: https://issues.apache.org/jira/browse/HBASE-18268 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-2 > > Attachments: HBASE-18268.branch-1.2.v0.patch, > HBASE-18268.branch-1.3.v0.patch, HBASE-18268.branch-1.3.v0.patch, > HBASE-18268.branch-1.v0.patch, HBASE-18268.branch-1.v0.patch, > HBASE-18268.v0.patch, HBASE-18268.v1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081774#comment-16081774 ] Chia-Ping Tsai commented on HBASE-18268: [~zghaobac] Thanks for the reviews. Will commit it tomorrow. > Eliminate the findbugs warnings for hbase-client > > > Key: HBASE-18268 > URL: https://issues.apache.org/jira/browse/HBASE-18268 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-2 > > Attachments: HBASE-18268.branch-1.2.v0.patch, > HBASE-18268.branch-1.3.v0.patch, HBASE-18268.branch-1.3.v0.patch, > HBASE-18268.branch-1.v0.patch, HBASE-18268.branch-1.v0.patch, > HBASE-18268.v0.patch, HBASE-18268.v1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081693#comment-16081693 ] Guanghao Zhang commented on HBASE-18268: +1. > Eliminate the findbugs warnings for hbase-client > > > Key: HBASE-18268 > URL: https://issues.apache.org/jira/browse/HBASE-18268 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-2 > > Attachments: HBASE-18268.branch-1.2.v0.patch, > HBASE-18268.branch-1.3.v0.patch, HBASE-18268.branch-1.3.v0.patch, > HBASE-18268.branch-1.v0.patch, HBASE-18268.branch-1.v0.patch, > HBASE-18268.v0.patch, HBASE-18268.v1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16073293#comment-16073293 ] Chia-Ping Tsai commented on HBASE-18268: Ping for reviews. [~busbey] > Eliminate the findbugs warnings for hbase-client > > > Key: HBASE-18268 > URL: https://issues.apache.org/jira/browse/HBASE-18268 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-2 > > Attachments: HBASE-18268.branch-1.2.v0.patch, > HBASE-18268.branch-1.3.v0.patch, HBASE-18268.branch-1.3.v0.patch, > HBASE-18268.branch-1.v0.patch, HBASE-18268.branch-1.v0.patch, > HBASE-18268.v0.patch, HBASE-18268.v1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client
[
https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16073281#comment-16073281
]
Hadoop QA commented on HBASE-18268:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
15s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
34s{color} | {color:green} branch-1.2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
12s{color} | {color:green} branch-1.2 passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
16s{color} | {color:green} branch-1.2 passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
37s{color} | {color:green} branch-1.2 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
23s{color} | {color:green} branch-1.2 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
54s{color} | {color:green} branch-1.2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
18s{color} | {color:green} branch-1.2 passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
18s{color} | {color:green} branch-1.2 passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
13s{color} | {color:green} the patch passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
16s{color} | {color:green} the patch passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
11m 23s{color} | {color:green} The patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
14s{color} | {color:green} the patch passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
18s{color} | {color:green} the patch passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
41s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
10s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 27m 29s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:2fc26cc |
| JIRA Issue | HBASE-18268 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12875579/HBASE-18268.branch-1.2.v0.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 68addf7ecf54 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client
[
https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16073206#comment-16073206
]
Hadoop QA commented on HBASE-18268:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
29s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
1s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
31s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
22s{color} | {color:green} branch-1.3 passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
22s{color} | {color:green} branch-1.3 passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
29s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
12s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
4s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
19s{color} | {color:green} branch-1.3 passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
21s{color} | {color:green} branch-1.3 passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
17s{color} | {color:green} the patch passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
18s{color} | {color:green} the patch passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
21m 33s{color} | {color:green} The patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
21s{color} | {color:green} the patch passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
24s{color} | {color:green} the patch passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
2s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
10s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 34m 12s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.10.1 Server=1.10.1 Image:yetus/hbase:9ba21e3 |
| JIRA Issue | HBASE-18268 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12875574/HBASE-18268.branch-1.3.v0.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux d064223039f9 3.19.0-25-generic #26~14.04.1-Ubuntu SMP Fri Jul
24 21:16:20 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16073148#comment-16073148 ] Chia-Ping Tsai commented on HBASE-18268: We don't commit the HBASE-18293 to branch-1.3. Will fix it. > Eliminate the findbugs warnings for hbase-client > > > Key: HBASE-18268 > URL: https://issues.apache.org/jira/browse/HBASE-18268 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.2.7, 2.0.0-alpha-2 > > Attachments: HBASE-18268.branch-1.3.v0.patch, > HBASE-18268.branch-1.v0.patch, HBASE-18268.branch-1.v0.patch, > HBASE-18268.v0.patch, HBASE-18268.v1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client
[
https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16073111#comment-16073111
]
Hadoop QA commented on HBASE-18268:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
26s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
40s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
20s{color} | {color:green} branch-1.3 passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
18s{color} | {color:green} branch-1.3 passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
37s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
23s{color} | {color:green} branch-1.3 passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
12s{color} | {color:red} hbase-client in branch-1.3 failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
22s{color} | {color:green} branch-1.3 passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
20s{color} | {color:green} branch-1.3 passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
15s{color} | {color:green} the patch passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
17s{color} | {color:green} the patch passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
16m 59s{color} | {color:green} The patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
12s{color} | {color:red} hbase-client in the patch failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
16s{color} | {color:green} the patch passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
19s{color} | {color:green} the patch passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
38s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
10s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 32m 0s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.03.0-ce Server=17.03.0-ce Image:yetus/hbase:9ba21e3 |
| JIRA Issue | HBASE-18268 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12875569/HBASE-18268.branch-1.3.v0.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 34b1bbcb0733 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31
14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client
[
https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16072236#comment-16072236
]
Hadoop QA commented on HBASE-18268:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 15m
7s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
59s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
23s{color} | {color:green} branch-1 passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
24s{color} | {color:green} branch-1 passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
38s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
11s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
19s{color} | {color:green} branch-1 passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} branch-1 passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
16s{color} | {color:green} the patch passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
24s{color} | {color:green} the patch passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
20m 52s{color} | {color:green} The patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
18s{color} | {color:green} the patch passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
23s{color} | {color:green} the patch passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
19s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
10s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 49m 57s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.10.1 Server=1.10.1 Image:yetus/hbase:395d9a0 |
| JIRA Issue | HBASE-18268 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12875469/HBASE-18268.branch-1.v0.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux f284e87a4a29 3.19.0-25-generic #26~14.04.1-Ubuntu SMP Fri Jul
24 21:16:20 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16072176#comment-16072176 ] Chia-Ping Tsai commented on HBASE-18268: Oh...The default jdk for branch-1.2+ may be different sometimes in running QA. Let me fix all warnings in this jira. > Eliminate the findbugs warnings for hbase-client > > > Key: HBASE-18268 > URL: https://issues.apache.org/jira/browse/HBASE-18268 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.2.7, 2.0.0-alpha-2, 1.1.12 > > Attachments: HBASE-18268.branch-1.v0.patch, > HBASE-18268.branch-1.v0.patch, HBASE-18268.v0.patch, HBASE-18268.v1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16070975#comment-16070975 ] Chia-Ping Tsai commented on HBASE-18268: After HBASE-18293, there is no findbugs warnings in branch-1. Also, the PoolMap will be handled by HBASE-18270. We don't need to worry about the findbugs warnings for branch-1 so it is time to commit the v1 patch. [~busbey] any suggestions? Thanks. > Eliminate the findbugs warnings for hbase-client > > > Key: HBASE-18268 > URL: https://issues.apache.org/jira/browse/HBASE-18268 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.2.7, 2.0.0-alpha-2, 1.1.12 > > Attachments: HBASE-18268.branch-1.v0.patch, HBASE-18268.v0.patch, > HBASE-18268.v1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067749#comment-16067749 ] Chia-Ping Tsai commented on HBASE-18268: see HBASE-18293 > Eliminate the findbugs warnings for hbase-client > > > Key: HBASE-18268 > URL: https://issues.apache.org/jira/browse/HBASE-18268 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.2.7, 2.0.0-alpha-2, 1.1.12 > > Attachments: HBASE-18268.branch-1.v0.patch, HBASE-18268.v0.patch, > HBASE-18268.v1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067017#comment-16067017 ] Sean Busbey commented on HBASE-18268: - we support both jdk-7 and jdk-8 on branch-1.2+. We generally should be running unit tests under both jdks, so the idea here is that we'd either run findbugs against both or just under jdk-8. > Eliminate the findbugs warnings for hbase-client > > > Key: HBASE-18268 > URL: https://issues.apache.org/jira/browse/HBASE-18268 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.2.7, 2.0.0-alpha-2, 1.1.12 > > Attachments: HBASE-18268.branch-1.v0.patch, HBASE-18268.v0.patch, > HBASE-18268.v1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065816#comment-16065816 ] Chia-Ping Tsai commented on HBASE-18268: bq. Can we only add the spotbugs dependency when jdk8 is active? Do we plan to upgrade the java for branch-1? If not, IMHO we shouldn't add the spotbugs which may be never used. > Eliminate the findbugs warnings for hbase-client > > > Key: HBASE-18268 > URL: https://issues.apache.org/jira/browse/HBASE-18268 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.2.7, 2.0.0-alpha-2, 1.1.12 > > Attachments: HBASE-18268.branch-1.v0.patch, HBASE-18268.v0.patch, > HBASE-18268.v1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065070#comment-16065070 ] Sean Busbey commented on HBASE-18268: - oh poop. Can we only add the spotbugs dependency when jdk8 is active? I think we have some examples of jdk-version-activated profiles elsewhere. Then we can work out picking jdk7 or jdk8 for that particular test later. > Eliminate the findbugs warnings for hbase-client > > > Key: HBASE-18268 > URL: https://issues.apache.org/jira/browse/HBASE-18268 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.2.7, 2.0.0-alpha-2, 1.1.12 > > Attachments: HBASE-18268.branch-1.v0.patch, HBASE-18268.v0.patch, > HBASE-18268.v1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client
[
https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064298#comment-16064298
]
Chia-Ping Tsai commented on HBASE-18268:
{noformat}
[INFO] Fork Value is true
[java] Exception in thread "main" java.lang.UnsupportedClassVersionError:
edu/umd/cs/findbugs/FindBugs2 : Unsupported major.minor version 52.0
[java] at java.lang.ClassLoader.defineClass1(Native Method)
[java] at java.lang.ClassLoader.defineClass(ClassLoader.java:803)
[java] at
java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
[java] at java.net.URLClassLoader.defineClass(URLClassLoader.java:442)
[java] at java.net.URLClassLoader.access$100(URLClassLoader.java:64)
[java] at java.net.URLClassLoader$1.run(URLClassLoader.java:354)
[java] at java.net.URLClassLoader$1.run(URLClassLoader.java:348)
[java] at java.security.AccessController.doPrivileged(Native Method)
[java] at java.net.URLClassLoader.findClass(URLClassLoader.java:347)
[java] at java.lang.ClassLoader.loadClass(ClassLoader.java:425)
[java] at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:312)
[java] at java.lang.ClassLoader.loadClass(ClassLoader.java:358)
[java] at
sun.launcher.LauncherHelper.checkAndLoadMain(LauncherHelper.java:482)
{noformat}
>From this [docs|https://spotbugs.github.io], the spotbugs requires the java 8.
>[~busbey] What do u think about the error message? Should we revert
>HBASE-17954 for branch-1?
> Eliminate the findbugs warnings for hbase-client
>
>
> Key: HBASE-18268
> URL: https://issues.apache.org/jira/browse/HBASE-18268
> Project: HBase
> Issue Type: Sub-task
> Components: Client
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.2.7, 2.0.0-alpha-2, 1.1.12
>
> Attachments: HBASE-18268.branch-1.v0.patch, HBASE-18268.v0.patch,
> HBASE-18268.v1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client
[
https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064231#comment-16064231
]
Hadoop QA commented on HBASE-18268:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 12m 36s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
1s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 14s
{color} | {color:green} branch-1 passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 19s
{color} | {color:green} branch-1 passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
27s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
12s {color} | {color:green} branch-1 passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 12s
{color} | {color:red} hbase-client in branch-1 failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 15s
{color} | {color:green} branch-1 passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 20s
{color} | {color:green} branch-1 passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
19s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 15s
{color} | {color:green} the patch passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 15s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 17s
{color} | {color:green} the patch passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 17s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
26s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
12s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
16m 26s {color} | {color:green} The patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:red}-1{color} | {color:red} hbaseprotoc {color} | {color:red} 0m 10s
{color} | {color:red} Patch generated 4 new protoc errors in hbase-client.
{color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 13s
{color} | {color:red} hbase-client in the patch failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 16s
{color} | {color:green} the patch passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 21s
{color} | {color:green} the patch passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 57s
{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
7s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 37m 49s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:395d9a0 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12874609/HBASE-18268.branch-1.v0.patch
|
| JIRA Issue | HBASE-18268 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux fe170698e77c 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064190#comment-16064190 ] Guanghao Zhang commented on HBASE-18268: Got it. +1 for v1 patch. Thanks. > Eliminate the findbugs warnings for hbase-client > > > Key: HBASE-18268 > URL: https://issues.apache.org/jira/browse/HBASE-18268 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.2.7, 2.0.0-alpha-2, 1.1.12 > > Attachments: HBASE-18268.v0.patch, HBASE-18268.v1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064187#comment-16064187 ] Mike Drob commented on HBASE-18268: --- bq. We should have another jira to discuss it. The fix may be beyond this jira. Agree. HBASE-18270 > Eliminate the findbugs warnings for hbase-client > > > Key: HBASE-18268 > URL: https://issues.apache.org/jira/browse/HBASE-18268 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.2.7, 2.0.0-alpha-2, 1.1.12 > > Attachments: HBASE-18268.v0.patch, HBASE-18268.v1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client
[
https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064185#comment-16064185
]
Hadoop QA commented on HBASE-18268:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 7s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
10s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 16s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
23s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
10s {color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 49s
{color} | {color:red} hbase-client in master has 4 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 16s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
18s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 17s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 17s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
23s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
10s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
28m 27s {color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha3. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
58s {color} | {color:green} hbase-client generated 0 new + 0 unchanged - 4
fixed = 0 total (was 4) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 16s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 28s
{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
7s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 38m 50s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:757bf37 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12874601/HBASE-18268.v1.patch |
| JIRA Issue | HBASE-18268 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 5842ea9c0b5f 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 35693f0 |
| Default Java | 1.8.0_131 |
| findbugs | v3.1.0-RC1 |
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/7348/artifact/patchprocess/branch-findbugs-hbase-client-warnings.html
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/7348/testReport/ |
| modules | C: hbase-client U: hbase-client |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/7348/console |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
This message was automatically generated.
> Eliminate the findbugs warnings for hbase-client
>
>
> Key:
[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client
[
https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064182#comment-16064182
]
Chia-Ping Tsai commented on HBASE-18268:
bq. Why the previous findbug result still show these warnings?
The first findbugs detection is executed without patch. See the console output.
{noformat}
findbugs detection: master
cd /testptch/hbase/hbase-client
mvn -Dmaven.repo.local=/home/jenkins/yetus-m2/hbase-master-patch-1
-DHBasePatchProcess test-compile findbugs:findbugs -DskipTests=true >
/testptch/patchprocess/branch-findbugs-hbase-client.txt 2>&1
Elapsed: 0m 44s
hbase-client in master has 4 extant Findbugs warnings.
{noformat}
We have another findbugs detection which runs with patch.
{noformat}
findbugs detection: patch
cd /testptch/hbase/hbase-client
mvn -Dmaven.repo.local=/home/jenkins/yetus-m2/hbase-master-patch-1
-DHBasePatchProcess test-compile findbugs:findbugs -DskipTests=true >
/testptch/patchprocess/patch-findbugs-hbase-client.txt 2>&1
Elapsed: 0m 43s
Starting with /testptch/patchprocess/branch-findbugs-hbase-client-warnings.xml
Merging /testptch/patchprocess/patch-findbugs-hbase-client-warnings.xml
Writing /testptch/patchprocess/combined-findbugs-hbase-client.xml
hbase-client generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4)
{noformat}
> Eliminate the findbugs warnings for hbase-client
>
>
> Key: HBASE-18268
> URL: https://issues.apache.org/jira/browse/HBASE-18268
> Project: HBase
> Issue Type: Sub-task
> Components: Client
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.2.7, 2.0.0-alpha-2, 1.1.12
>
> Attachments: HBASE-18268.v0.patch, HBASE-18268.v1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064175#comment-16064175 ] Guanghao Zhang commented on HBASE-18268: Why the previous findbug result still show these warnings? https://builds.apache.org/job/PreCommit-HBASE-Build/7328/artifact/patchprocess/branch-findbugs-hbase-client-warnings.html > Eliminate the findbugs warnings for hbase-client > > > Key: HBASE-18268 > URL: https://issues.apache.org/jira/browse/HBASE-18268 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.2.7, 2.0.0-alpha-2, 1.1.12 > > Attachments: HBASE-18268.v0.patch, HBASE-18268.v1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064171#comment-16064171 ] Chia-Ping Tsai commented on HBASE-18268: bq. it breaks the Map API contract in so many ways, maybe it shouldn't even implement the interface We should have another jira to discuss it. The fix may be beyond this jira. > Eliminate the findbugs warnings for hbase-client > > > Key: HBASE-18268 > URL: https://issues.apache.org/jira/browse/HBASE-18268 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.2.7, 2.0.0-alpha-2, 1.1.12 > > Attachments: HBASE-18268.v0.patch, HBASE-18268.v1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client
[
https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064168#comment-16064168
]
Mike Drob commented on HBASE-18268:
---
Yes, also {{PoolMap::entrySet}}.
Reading this class again, it breaks the Map API contract in so many ways, maybe
it shouldn't even implement the interface
> Eliminate the findbugs warnings for hbase-client
>
>
> Key: HBASE-18268
> URL: https://issues.apache.org/jira/browse/HBASE-18268
> Project: HBase
> Issue Type: Sub-task
> Components: Client
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.2.7, 2.0.0-alpha-2, 1.1.12
>
> Attachments: HBASE-18268.v0.patch, HBASE-18268.v1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client
[
https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064159#comment-16064159
]
Chia-Ping Tsai commented on HBASE-18268:
bq. Not sure if it's in scope here or not, but some of the other PoolMap
methods also look suspect regarding return values.
Do you mean that some methods always return the null? For example:
{code}
@Override
public R put(R resource) {
if (super.size() < maxSize) {
add(resource);
}
return null;
}
{code}
{code}
@SuppressWarnings("unchecked")
@Override
public V remove(Object key) {
Pool pool = pools.remove(key);
if (pool != null) {
removeValue((K) key, pool.get());
}
return null;
}
{code}
> Eliminate the findbugs warnings for hbase-client
>
>
> Key: HBASE-18268
> URL: https://issues.apache.org/jira/browse/HBASE-18268
> Project: HBase
> Issue Type: Sub-task
> Components: Client
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.2.7, 2.0.0-alpha-2, 1.1.12
>
> Attachments: HBASE-18268.v0.patch, HBASE-18268.v1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064148#comment-16064148 ] Mike Drob commented on HBASE-18268: --- Not sure if it's in scope here or not, but some of the other PoolMap methods also look suspect regarding return values. > Eliminate the findbugs warnings for hbase-client > > > Key: HBASE-18268 > URL: https://issues.apache.org/jira/browse/HBASE-18268 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.2.7, 2.0.0-alpha-2, 1.1.12 > > Attachments: HBASE-18268.v0.patch, HBASE-18268.v1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client
[
https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16063143#comment-16063143
]
Sean Busbey commented on HBASE-18268:
-
{code}
diff --git
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AbstractRpcClient.java
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AbstractRpcClient.java
index d414f7036b..a41fdff3e5 100644
---
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AbstractRpcClient.java
+++
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AbstractRpcClient.java
@@ -101,7 +101,7 @@ public abstract class AbstractRpcClient implements RpcC
private static final ScheduledExecutorService IDLE_CONN_SWEEPER = Executors
.newScheduledThreadPool(1,
Threads.newDaemonThreadFactory("Idle-Rpc-Conn-Sweeper"));
- protected final static Map
TOKEN_HANDLERS = new HashMap<>();
+ final static Map
TOKEN_HANDLERS = new HashMap<>();
static {
TOKEN_HANDLERS.put(Kind.HBASE_AUTH_TOKEN, new
AuthenticationTokenSelector());
{code}
This one I think we should add a javadoc comment and disable the findbugs
complaint. It looks like we mean for this to be a point where RPC
implementations on top of AbstractRpcClient can add additional TOKEN_HANDLERS
that the rest of the system can then use. I'd rather not put a strong
requirement on having those implementations live in the same package.
But AbstractRpcClient is IA.Private so we could always update this later I
suppose. I'll leave if to your judgement.
I'm +1 with or without the suggested change to handling the TOKEN_HANDLERS
warning.
> Eliminate the findbugs warnings for hbase-client
>
>
> Key: HBASE-18268
> URL: https://issues.apache.org/jira/browse/HBASE-18268
> Project: HBase
> Issue Type: Sub-task
> Components: Client
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.2.7, 2.0.0-alpha-2, 1.1.12
>
> Attachments: HBASE-18268.v0.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client
[
https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16063128#comment-16063128
]
Hadoop QA commented on HBASE-18268:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 16s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
25s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 17s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
22s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
9s {color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 46s
{color} | {color:red} hbase-client in master has 4 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 15s
{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
19s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 17s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 17s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
23s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
10s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
28m 7s {color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha3. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
53s {color} | {color:green} hbase-client generated 0 new + 0 unchanged - 4
fixed = 0 total (was 4) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 17s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 39s
{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
9s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 39m 2s {color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:757bf37 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12874498/HBASE-18268.v0.patch |
| JIRA Issue | HBASE-18268 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux b0e7726556e7 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 2d781aa |
| Default Java | 1.8.0_131 |
| findbugs | v3.1.0-RC1 |
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/7328/artifact/patchprocess/branch-findbugs-hbase-client-warnings.html
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/7328/testReport/ |
| modules | C: hbase-client U: hbase-client |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/7328/console |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
This message was automatically generated.
> Eliminate the findbugs warnings for hbase-client
>
>
> Key: HBASE-18268
>
[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client
[ https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16063114#comment-16063114 ] Chia-Ping Tsai commented on HBASE-18268: Indeed, that is a bad bug. I guess the method is never used so that it survive until now. > Eliminate the findbugs warnings for hbase-client > > > Key: HBASE-18268 > URL: https://issues.apache.org/jira/browse/HBASE-18268 > Project: HBase > Issue Type: Sub-task > Components: Client >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.2.7, 2.0.0-alpha-2, 1.1.12 > > Attachments: HBASE-18268.v0.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18268) Eliminate the findbugs warnings for hbase-client
[
https://issues.apache.org/jira/browse/HBASE-18268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16063097#comment-16063097
]
Sean Busbey commented on HBASE-18268:
-
{code}
diff --git hbase-client/src/main/java/org/apache/hadoop/hbase/util/PoolMap.java
hbase-client/src/main/java/org/apache/hadoop/hbase/util/PoolMap.java
index 2131db359f..40c6b55e53 100644
--- hbase-client/src/main/java/org/apache/hadoop/hbase/util/PoolMap.java
+++ hbase-client/src/main/java/org/apache/hadoop/hbase/util/PoolMap.java
@@ -210,7 +210,7 @@ public class PoolMap implements Map {
}
}
}
-return null;
+return entries;
}
protected interface Pool {
{code}
oof. That's a pretty bad bug. Curious that this hasn't caused PoolMap to
explode anywhere.
> Eliminate the findbugs warnings for hbase-client
>
>
> Key: HBASE-18268
> URL: https://issues.apache.org/jira/browse/HBASE-18268
> Project: HBase
> Issue Type: Sub-task
> Components: Client
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.2.7, 2.0.0-alpha-2, 1.1.12
>
> Attachments: HBASE-18268.v0.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
