[jira] [Commented] (HBASE-18617) FuzzyRowKeyFilter should not modify the filter pairs
[ https://issues.apache.org/jira/browse/HBASE-18617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137330#comment-16137330 ] Hudson commented on HBASE-18617: FAILURE: Integrated in Jenkins build HBASE-14070.HLC #263 (See [https://builds.apache.org/job/HBASE-14070.HLC/263/]) HBASE-18617 FuzzyRowKeyFilter should not modify the filter pairs (tedyu: rev e2532ecd1e6093f9c56b16e2e8e6865bd0ad1cb7) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFuzzyRowFilterEndToEnd.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java > FuzzyRowKeyFilter should not modify the filter pairs > > > Key: HBASE-18617 > URL: https://issues.apache.org/jira/browse/HBASE-18617 > Project: HBase > Issue Type: Bug >Affects Versions: 1.1.2 >Reporter: vinisha >Assignee: vinisha >Priority: Minor > Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-alpha-3 > > Attachments: 18617.branch-1.patch, > FuzzyRowFilter_HBASE_18617_1.patch, FuzzyRowFilter_HBASE_18617-branch-1.patch > > > Current implementation of FuzzyRowKeyFilter modifies the provided filter > pairs: > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java#L89-L90 > Filter should not change the filter pair. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18617) FuzzyRowKeyFilter should not modify the filter pairs
[ https://issues.apache.org/jira/browse/HBASE-18617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133597#comment-16133597 ] Hudson commented on HBASE-18617: FAILURE: Integrated in Jenkins build HBase-2.0 #353 (See [https://builds.apache.org/job/HBase-2.0/353/]) HBASE-18617 FuzzyRowKeyFilter should not modify the filter pairs (tedyu: rev 22ecb7a7b5da72e86951e88510f53efd19a503a0) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFuzzyRowFilterEndToEnd.java > FuzzyRowKeyFilter should not modify the filter pairs > > > Key: HBASE-18617 > URL: https://issues.apache.org/jira/browse/HBASE-18617 > Project: HBase > Issue Type: Bug >Affects Versions: 1.1.2 >Reporter: vinisha >Assignee: vinisha >Priority: Minor > Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-alpha-3 > > Attachments: 18617.branch-1.patch, > FuzzyRowFilter_HBASE_18617_1.patch, FuzzyRowFilter_HBASE_18617-branch-1.patch > > > Current implementation of FuzzyRowKeyFilter modifies the provided filter > pairs: > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java#L89-L90 > Filter should not change the filter pair. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18617) FuzzyRowKeyFilter should not modify the filter pairs
[ https://issues.apache.org/jira/browse/HBASE-18617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133548#comment-16133548 ] Hudson commented on HBASE-18617: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3556 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3556/]) HBASE-18617 FuzzyRowKeyFilter should not modify the filter pairs (tedyu: rev e2532ecd1e6093f9c56b16e2e8e6865bd0ad1cb7) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFuzzyRowFilterEndToEnd.java > FuzzyRowKeyFilter should not modify the filter pairs > > > Key: HBASE-18617 > URL: https://issues.apache.org/jira/browse/HBASE-18617 > Project: HBase > Issue Type: Bug >Affects Versions: 1.1.2 >Reporter: vinisha >Assignee: vinisha >Priority: Minor > Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-alpha-3 > > Attachments: 18617.branch-1.patch, > FuzzyRowFilter_HBASE_18617_1.patch, FuzzyRowFilter_HBASE_18617-branch-1.patch > > > Current implementation of FuzzyRowKeyFilter modifies the provided filter > pairs: > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java#L89-L90 > Filter should not change the filter pair. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18617) FuzzyRowKeyFilter should not modify the filter pairs
[ https://issues.apache.org/jira/browse/HBASE-18617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133539#comment-16133539 ] Hudson commented on HBASE-18617: FAILURE: Integrated in Jenkins build HBase-1.4 #869 (See [https://builds.apache.org/job/HBase-1.4/869/]) HBASE-18617 FuzzyRowKeyFilter should not modify the filter pairs (tedyu: rev a78aba2df91cc3c8c2705209131425695a85fcd5) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFuzzyRowFilterEndToEnd.java > FuzzyRowKeyFilter should not modify the filter pairs > > > Key: HBASE-18617 > URL: https://issues.apache.org/jira/browse/HBASE-18617 > Project: HBase > Issue Type: Bug >Affects Versions: 1.1.2 >Reporter: vinisha >Assignee: vinisha >Priority: Minor > Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-alpha-3 > > Attachments: 18617.branch-1.patch, > FuzzyRowFilter_HBASE_18617_1.patch, FuzzyRowFilter_HBASE_18617-branch-1.patch > > > Current implementation of FuzzyRowKeyFilter modifies the provided filter > pairs: > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java#L89-L90 > Filter should not change the filter pair. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18617) FuzzyRowKeyFilter should not modify the filter pairs
[ https://issues.apache.org/jira/browse/HBASE-18617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133527#comment-16133527 ] Hudson commented on HBASE-18617: FAILURE: Integrated in Jenkins build HBase-1.5 #16 (See [https://builds.apache.org/job/HBase-1.5/16/]) HBASE-18617 FuzzyRowKeyFilter should not modify the filter pairs (tedyu: rev 64bef67558244d459661a3da312a747d100ea788) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFuzzyRowFilterEndToEnd.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java > FuzzyRowKeyFilter should not modify the filter pairs > > > Key: HBASE-18617 > URL: https://issues.apache.org/jira/browse/HBASE-18617 > Project: HBase > Issue Type: Bug >Affects Versions: 1.1.2 >Reporter: vinisha >Assignee: vinisha >Priority: Minor > Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-alpha-3 > > Attachments: 18617.branch-1.patch, > FuzzyRowFilter_HBASE_18617_1.patch, FuzzyRowFilter_HBASE_18617-branch-1.patch > > > Current implementation of FuzzyRowKeyFilter modifies the provided filter > pairs: > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java#L89-L90 > Filter should not change the filter pair. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18617) FuzzyRowKeyFilter should not modify the filter pairs
[ https://issues.apache.org/jira/browse/HBASE-18617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133315#comment-16133315 ] vinisha commented on HBASE-18617: - Sure, fixed. > FuzzyRowKeyFilter should not modify the filter pairs > > > Key: HBASE-18617 > URL: https://issues.apache.org/jira/browse/HBASE-18617 > Project: HBase > Issue Type: Bug >Affects Versions: 1.1.2 >Reporter: vinisha >Assignee: vinisha >Priority: Minor > Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-alpha-3 > > Attachments: 18617.branch-1.patch, > FuzzyRowFilter_HBASE_18617_1.patch, FuzzyRowFilter_HBASE_18617-branch-1.patch > > > Current implementation of FuzzyRowKeyFilter modifies the provided filter > pairs: > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java#L89-L90 > Filter should not change the filter pair. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18617) FuzzyRowKeyFilter should not modify the filter pairs
[
https://issues.apache.org/jira/browse/HBASE-18617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133254#comment-16133254
]
Hadoop QA commented on HBASE-18617:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 5s{color}
| {color:red} HBASE-18617 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.4.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-18617 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12882615/FuzzyRowFilter_HBASE_18617-branch-1.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8156/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> FuzzyRowKeyFilter should not modify the filter pairs
>
>
> Key: HBASE-18617
> URL: https://issues.apache.org/jira/browse/HBASE-18617
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.1.2
>Reporter: vinisha
>Assignee: vinisha
>Priority: Minor
> Fix For: 3.0.0, 2.0.0-alpha-3
>
> Attachments: FuzzyRowFilter_HBASE_18617_1.patch,
> FuzzyRowFilter_HBASE_18617-branch-1.patch
>
>
> Current implementation of FuzzyRowKeyFilter modifies the provided filter
> pairs:
> https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java#L89-L90
> Filter should not change the filter pair.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18617) FuzzyRowKeyFilter should not modify the filter pairs
[ https://issues.apache.org/jira/browse/HBASE-18617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133125#comment-16133125 ] Chia-Ping Tsai commented on HBASE-18617: +1 > FuzzyRowKeyFilter should not modify the filter pairs > > > Key: HBASE-18617 > URL: https://issues.apache.org/jira/browse/HBASE-18617 > Project: HBase > Issue Type: Bug >Affects Versions: 1.1.2 >Reporter: vinisha >Assignee: vinisha >Priority: Minor > Attachments: FuzzyRowFilter_HBASE_18617_1.patch > > > Current implementation of FuzzyRowKeyFilter modifies the provided filter > pairs: > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java#L89-L90 > Filter should not change the filter pair. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18617) FuzzyRowKeyFilter should not modify the filter pairs
[ https://issues.apache.org/jira/browse/HBASE-18617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133114#comment-16133114 ] Ted Yu commented on HBASE-18617: [~chia7712]: What do you think of the patch ? > FuzzyRowKeyFilter should not modify the filter pairs > > > Key: HBASE-18617 > URL: https://issues.apache.org/jira/browse/HBASE-18617 > Project: HBase > Issue Type: Bug >Affects Versions: 1.1.2 >Reporter: vinisha >Assignee: vinisha >Priority: Minor > Attachments: FuzzyRowFilter_HBASE_18617_1.patch > > > Current implementation of FuzzyRowKeyFilter modifies the provided filter > pairs: > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java#L89-L90 > Filter should not change the filter pair. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18617) FuzzyRowKeyFilter should not modify the filter pairs
[
https://issues.apache.org/jira/browse/HBASE-18617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131611#comment-16131611
]
Hadoop QA commented on HBASE-18617:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
38s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
30s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
7s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
21s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
32m 57s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
33s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}149m 22s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
31s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}210m 28s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hbase.security.access.TestCoprocessorWhitelistMasterObserver |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18617 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12882455/FuzzyRowFilter_HBASE_18617_1.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux a8657783e993 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31
14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 75a6b36 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/8140/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8140/testReport/ |
| modules | C: hbas
[jira] [Commented] (HBASE-18617) FuzzyRowKeyFilter should not modify the filter pairs
[
https://issues.apache.org/jira/browse/HBASE-18617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131378#comment-16131378
]
vinisha commented on HBASE-18617:
-
The test is failing with:
{noformat}
Error Message
expected: but was:
Stacktrace
java.lang.AssertionError: expected: but was:
at
org.apache.hadoop.hbase.filter.TestFuzzyRowFilterEndToEnd.testAllFixedBits(TestFuzzyRowFilterEndToEnd.java:162)
{noformat}
It looks like my patch in `FuzzyRowFilter` is not used because the same test
passes locally. Could anyone let me know how can I make sure whether all the
patch files were used by the build?
> FuzzyRowKeyFilter should not modify the filter pairs
>
>
> Key: HBASE-18617
> URL: https://issues.apache.org/jira/browse/HBASE-18617
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.1.2
>Reporter: vinisha
>Assignee: vinisha
>Priority: Minor
> Attachments: FuzzyRowFilter_HBASE_18617.patch,
> TestFuzzyRowFilterEndToEnd_HBASE_18617.patch
>
>
> Current implementation of FuzzyRowKeyFilter modifies the provided filter
> pairs:
> https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java#L89-L90
> Filter should not change the filter pair.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18617) FuzzyRowKeyFilter should not modify the filter pairs
[
https://issues.apache.org/jira/browse/HBASE-18617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131369#comment-16131369
]
Hadoop QA commented on HBASE-18617:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
21s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
32m 37s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
37s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}114m 26s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
17s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}163m 44s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.filter.TestFuzzyRowFilterEndToEnd |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18617 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12882419/TestFuzzyRowFilterEndToEnd_HBASE_18617.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 1fa9857b0c52 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 75a6b36 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/8136/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8136/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8136/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> FuzzyRowKeyFilter should not modify the filter pairs
>
>
> Key: HBASE-18617
> URL: https://issues.apache.org/jira/browse/HBASE-18617
> P
[jira] [Commented] (HBASE-18617) FuzzyRowKeyFilter should not modify the filter pairs
[ https://issues.apache.org/jira/browse/HBASE-18617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131031#comment-16131031 ] vinisha commented on HBASE-18617: - [~chia7712] I see. Since it was raised that the fix has been added in HBASE-17890, I was wondering why we dont need to copy bytes for `parseFrom()` method. [~tedyu] I have addressed the comments and added a new patch. I have also added a patch which covers this scenario in test. Could you please take another pass? Thanks. > FuzzyRowKeyFilter should not modify the filter pairs > > > Key: HBASE-18617 > URL: https://issues.apache.org/jira/browse/HBASE-18617 > Project: HBase > Issue Type: Bug >Affects Versions: 1.1.2 >Reporter: vinisha >Assignee: vinisha >Priority: Minor > Attachments: FuzzyRowFilter_HBASE_18617.patch, > TestFuzzyRowFilterEndToEnd_HBASE_18617.patch > > > Current implementation of FuzzyRowKeyFilter modifies the provided filter > pairs: > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java#L89-L90 > Filter should not change the filter pair. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18617) FuzzyRowKeyFilter should not modify the filter pairs
[ https://issues.apache.org/jira/browse/HBASE-18617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130998#comment-16130998 ] Chia-Ping Tsai commented on HBASE-18617: bq. Why don't we want to copy bytes for `parseFrom()` method? The Filter could modify `keyBytes` and `keyMeta` right? Are you asking about the patch in HBASE-17890? If so, the patch try to handle a problem that client and server use different format of mask/key for fuzzy. The patch unifies the format of mask/key for safe/unsafe. Also, the key/mask from public construction of FuzzyFilter must be processed, so server won't process the key/mask again when rebuilding the filter by parseFrom(). That is to say, we don't need to copy the key/mask because FuzzyFilter won't modify them. The aim of HBASE-17890 is unrelated to this issue. Just a reference. :) > FuzzyRowKeyFilter should not modify the filter pairs > > > Key: HBASE-18617 > URL: https://issues.apache.org/jira/browse/HBASE-18617 > Project: HBase > Issue Type: Bug >Affects Versions: 1.1.2 >Reporter: vinisha >Assignee: vinisha >Priority: Minor > Attachments: FuzzyRowFilter_HBASE_18617.patch > > > Current implementation of FuzzyRowKeyFilter modifies the provided filter > pairs: > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java#L89-L90 > Filter should not change the filter pair. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18617) FuzzyRowKeyFilter should not modify the filter pairs
[ https://issues.apache.org/jira/browse/HBASE-18617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130947#comment-16130947 ] vinisha commented on HBASE-18617: - [~tedyu] Thanks for the feedback. I will make suggested changes. [~chia7712] Why don't we want to copy bytes for `parseFrom()` method? The Filter could modify `keyBytes` and `keyMeta` right? > FuzzyRowKeyFilter should not modify the filter pairs > > > Key: HBASE-18617 > URL: https://issues.apache.org/jira/browse/HBASE-18617 > Project: HBase > Issue Type: Bug >Affects Versions: 1.1.2 >Reporter: vinisha >Assignee: vinisha >Priority: Minor > Attachments: FuzzyRowFilter_HBASE_18617.patch > > > Current implementation of FuzzyRowKeyFilter modifies the provided filter > pairs: > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java#L89-L90 > Filter should not change the filter pair. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18617) FuzzyRowKeyFilter should not modify the filter pairs
[
https://issues.apache.org/jira/browse/HBASE-18617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130241#comment-16130241
]
Chia-Ping Tsai commented on HBASE-18617:
{quote}
+ Pair p = new Pair<>();
+ // create a copy of pair bytes so that they are not modified by the
filter
+ p.setFirst(Arrays.copyOf(aFuzzyKeysData.getFirst(),
aFuzzyKeysData.getFirst().length));
+ p.setSecond(Arrays.copyOf(aFuzzyKeysData.getSecond(),
aFuzzyKeysData.getSecond().length));
+
if (p.getFirst().length != p.getSecond().length) {
Pair readable =
-new Pair<>(Bytes.toStringBinary(p.getFirst()),
Bytes.toStringBinary(p
{quote}
Consider coping the pair after the length check. If the check fails, it is a
waste of time to copy input data.
HBASE-17890 covers this issue but it has not be reviewed. It clone the input
data in preprocessSearchKey/preprocessMask.
> FuzzyRowKeyFilter should not modify the filter pairs
>
>
> Key: HBASE-18617
> URL: https://issues.apache.org/jira/browse/HBASE-18617
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.1.2
>Reporter: vinisha
>Priority: Minor
> Attachments: FuzzyRowFilter_HBASE_18617.patch
>
>
> Current implementation of FuzzyRowKeyFilter modifies the provided filter
> pairs:
> https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java#L89-L90
> Filter should not change the filter pair.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18617) FuzzyRowKeyFilter should not modify the filter pairs
[
https://issues.apache.org/jira/browse/HBASE-18617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130120#comment-16130120
]
Ted Yu commented on HBASE-18617:
{code}
87if (p.getFirst().length != p.getSecond().length) {
{code}
Exception would be thrown in the above case. We only need to clone Pair after
we get past the above if, right ?
There're tests under hbase-server module:
hbase-server/src/test//java/org/apache/hadoop/hbase/filter/TestFuzzyRowAndColumnRangeFilter.java
hbase-server/src/test//java/org/apache/hadoop/hbase/filter/TestFuzzyRowFilter.java
hbase-server/src/test//java/org/apache/hadoop/hbase/filter/TestFuzzyRowFilterEndToEnd.java
In your next patch, introduce trivial change in one of the tests above to
trigger QA run.
> FuzzyRowKeyFilter should not modify the filter pairs
>
>
> Key: HBASE-18617
> URL: https://issues.apache.org/jira/browse/HBASE-18617
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.1.2
>Reporter: vinisha
> Attachments: FuzzyRowFilter_HBASE_18617.patch
>
>
> Current implementation of FuzzyRowKeyFilter modifies the provided filter
> pairs:
> https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java#L89-L90
> Filter should not change the filter pair.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18617) FuzzyRowKeyFilter should not modify the filter pairs
[
https://issues.apache.org/jira/browse/HBASE-18617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130072#comment-16130072
]
Hadoop QA commented on HBASE-18617:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
21s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
6s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
33m 9s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
36s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
7s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 45m 28s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18617 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12882280/FuzzyRowFilter_HBASE_18617.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux c65490910637 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 092dc6d |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8128/testReport/ |
| modules | C: hbase-client U: hbase-client |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8128/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> FuzzyRowKeyFilter should not modify the filter pairs
>
>
> Key: HBASE-18617
> URL: https://issues.apache.org/jira/browse/HBASE-18617
> Project: HBase
> Issue Type: Bug
>Affects Versions: 1.1.2
>Reporter: vin
