[jira] [Commented] (HBASE-18911) Unify Admin and AsyncAdmin's methods name
[ https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256605#comment-16256605 ] Hudson commented on HBASE-18911: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4066 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4066/]) HBASE-18911 Unify Admin and AsyncAdmin's methods name (zghao: rev 52273aa8f3221e11489004bacba4f4b6eb05f5c3) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncDecommissionAdminApi.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncRegionAdminApi.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncTableAdminApi.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncAdmin.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncToolAdminApi.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncHBaseAdmin.java * (add) hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestInterfaceAlign.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncClusterAdminApi.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcedureAdminApi.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncReplicationAdminApiWithClusters.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java > Unify Admin and AsyncAdmin's methods name > - > > Key: HBASE-18911 > URL: https://issues.apache.org/jira/browse/HBASE-18911 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18911.master.001.patch, > HBASE-18911.master.002.patch, HBASE-18911.master.003.patch, > HBASE-18911.master.004.patch > > > Different Methods > || AsyncAdmin || Admin || unified name || > | listTables | listTableDescriptors | listTableDescriptors | > | getOnlineRegions | getRegions | getRegions | > | getTableRegions | getRegions | getRegions | > | getTableDescriptor | getDescriptor | getDescriptor | > | getRegionLoads | getRegionLoad | getRegionLoads | > | execProcedureWithRet | execProcedureWithReturn | execProcedureWithReturn | > | setNormalizerOn | normalizerSwitch | normalizerSwitch | > | isNormalizerOn | isNormalizerEnabled | isNormalizerEnabled | > | setBalancerOn | balancerSwitch | balancerSwitch | > | isBalancerOn | isBalancerEnabled | isBalancerEnabled | > | setCleanerChoreOn | cleanerChoreSwitch | cleanerChoreSwitch | > | isCleanerChoreOn | isCleanerChoreEnabled | isCleanerChoreEnabled | > | setCatalogJanitorOn | catalogJanitorSwitch | catalogJanitorSwitch | > | isCatalogJanitorOn | isCatalogJanitorEnabled | isCatalogJanitorEnabled | > | setSplitOn/setMergeOn | splitOrMergeEnabledSwitch | splitSwitch/mergeSwitch > | > | isSplitOn/isMergeOn| isSplitOrMergeEnabled | isSplitEnabled/isMergeEnabled | > Methods only in AsyncAdmin > || AsyncAdmin || > | majorCompactRegionServer | > | getMaster | > | getBackupMasters | > | getRegionServers | > Methods only in Admin > || Admin || > | listTableDescriptorsByNamespace | > | listTableNamesByNamespace | > | modifyTable | > | getMasterCoprocessors | -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18911) Unify Admin and AsyncAdmin's methods name
[ https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256532#comment-16256532 ] Hudson commented on HBASE-18911: FAILURE: Integrated in Jenkins build HBase-2.0 #865 (See [https://builds.apache.org/job/HBase-2.0/865/]) HBASE-18911 Unify Admin and AsyncAdmin's methods name (zghao: rev 8b30adb834c22a491b1899233b55219befa87167) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncToolAdminApi.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncTableAdminApi.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncClusterAdminApi.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncDecommissionAdminApi.java * (add) hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestInterfaceAlign.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncAdmin.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcedureAdminApi.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncReplicationAdminApiWithClusters.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncRegionAdminApi.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncHBaseAdmin.java > Unify Admin and AsyncAdmin's methods name > - > > Key: HBASE-18911 > URL: https://issues.apache.org/jira/browse/HBASE-18911 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18911.master.001.patch, > HBASE-18911.master.002.patch, HBASE-18911.master.003.patch, > HBASE-18911.master.004.patch > > > Different Methods > || AsyncAdmin || Admin || unified name || > | listTables | listTableDescriptors | listTableDescriptors | > | getOnlineRegions | getRegions | getRegions | > | getTableRegions | getRegions | getRegions | > | getTableDescriptor | getDescriptor | getDescriptor | > | getRegionLoads | getRegionLoad | getRegionLoads | > | execProcedureWithRet | execProcedureWithReturn | execProcedureWithReturn | > | setNormalizerOn | normalizerSwitch | normalizerSwitch | > | isNormalizerOn | isNormalizerEnabled | isNormalizerEnabled | > | setBalancerOn | balancerSwitch | balancerSwitch | > | isBalancerOn | isBalancerEnabled | isBalancerEnabled | > | setCleanerChoreOn | cleanerChoreSwitch | cleanerChoreSwitch | > | isCleanerChoreOn | isCleanerChoreEnabled | isCleanerChoreEnabled | > | setCatalogJanitorOn | catalogJanitorSwitch | catalogJanitorSwitch | > | isCatalogJanitorOn | isCatalogJanitorEnabled | isCatalogJanitorEnabled | > | setSplitOn/setMergeOn | splitOrMergeEnabledSwitch | splitSwitch/mergeSwitch > | > | isSplitOn/isMergeOn| isSplitOrMergeEnabled | isSplitEnabled/isMergeEnabled | > Methods only in AsyncAdmin > || AsyncAdmin || > | majorCompactRegionServer | > | getMaster | > | getBackupMasters | > | getRegionServers | > Methods only in Admin > || Admin || > | listTableDescriptorsByNamespace | > | listTableNamesByNamespace | > | modifyTable | > | getMasterCoprocessors | -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18911) Unify Admin and AsyncAdmin's methods name
[ https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255458#comment-16255458 ] Peter Somogyi commented on HBASE-18911: --- +1 from my side, good patch! > Unify Admin and AsyncAdmin's methods name > - > > Key: HBASE-18911 > URL: https://issues.apache.org/jira/browse/HBASE-18911 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18911.master.001.patch, > HBASE-18911.master.002.patch, HBASE-18911.master.003.patch, > HBASE-18911.master.004.patch > > > Different Methods > || AsyncAdmin || Admin || unified name || > | listTables | listTableDescriptors | listTableDescriptors | > | getOnlineRegions | getRegions | getRegions | > | getTableRegions | getRegions | getRegions | > | getTableDescriptor | getDescriptor | getDescriptor | > | getRegionLoads | getRegionLoad | getRegionLoads | > | execProcedureWithRet | execProcedureWithReturn | execProcedureWithReturn | > | setNormalizerOn | normalizerSwitch | normalizerSwitch | > | isNormalizerOn | isNormalizerEnabled | isNormalizerEnabled | > | setBalancerOn | balancerSwitch | balancerSwitch | > | isBalancerOn | isBalancerEnabled | isBalancerEnabled | > | setCleanerChoreOn | cleanerChoreSwitch | cleanerChoreSwitch | > | isCleanerChoreOn | isCleanerChoreEnabled | isCleanerChoreEnabled | > | setCatalogJanitorOn | catalogJanitorSwitch | catalogJanitorSwitch | > | isCatalogJanitorOn | isCatalogJanitorEnabled | isCatalogJanitorEnabled | > | setSplitOn/setMergeOn | splitOrMergeEnabledSwitch | splitSwitch/mergeSwitch > | > | isSplitOn/isMergeOn| isSplitOrMergeEnabled | isSplitEnabled/isMergeEnabled | > Methods only in AsyncAdmin > || AsyncAdmin || > | majorCompactRegionServer | > | getMaster | > | getBackupMasters | > | getRegionServers | > Methods only in Admin > || Admin || > | listTableDescriptorsByNamespace | > | listTableNamesByNamespace | > | modifyTable | > | getMasterCoprocessors | -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18911) Unify Admin and AsyncAdmin's methods name
[
https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255452#comment-16255452
]
Hadoop QA commented on HBASE-18911:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
12s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
1s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 8 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 7m
35s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
7s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
43s{color} | {color:green} hbase-client: The patch generated 0 new + 532
unchanged - 4 fixed = 532 total (was 536) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
15s{color} | {color:green} The patch hbase-server passed checkstyle {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
53s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
82m 39s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
37s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
37s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 91m
37s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
30s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}206m 27s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-18911 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12897970/HBASE-18911.master.004.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux a1779d4ecd36 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git
[jira] [Commented] (HBASE-18911) Unify Admin and AsyncAdmin's methods name
[
https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255342#comment-16255342
]
Hadoop QA commented on HBASE-18911:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
10s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 8 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
21s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
48s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
35s{color} | {color:red} hbase-client: The patch generated 14 new + 535
unchanged - 1 fixed = 549 total (was 536) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
40s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
58m 57s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
27s{color} | {color:red} hbase-client generated 1 new + 3 unchanged - 0 fixed =
4 total (was 3) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
13s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 94m
36s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
33s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}179m 40s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-18911 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12897962/HBASE-18911.master.003.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 595ca24210b5 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / d8fb10c832 |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d;
[jira] [Commented] (HBASE-18911) Unify Admin and AsyncAdmin's methods name
[ https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255132#comment-16255132 ] Guanghao Zhang commented on HBASE-18911: Add to review board: https://reviews.apache.org/r/63873/ > Unify Admin and AsyncAdmin's methods name > - > > Key: HBASE-18911 > URL: https://issues.apache.org/jira/browse/HBASE-18911 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18911.master.001.patch, > HBASE-18911.master.002.patch, HBASE-18911.master.003.patch > > > Different Methods > || AsyncAdmin || Admin || unified name || > | listTables | listTableDescriptors | listTableDescriptors | > | getOnlineRegions | getRegions | getRegions | > | getTableRegions | getRegions | getRegions | > | getTableDescriptor | getDescriptor | getDescriptor | > | getRegionLoads | getRegionLoad | getRegionLoads | > | execProcedureWithRet | execProcedureWithReturn | execProcedureWithReturn | > | setNormalizerOn | normalizerSwitch | normalizerSwitch | > | isNormalizerOn | isNormalizerEnabled | isNormalizerEnabled | > | setBalancerOn | balancerSwitch | balancerSwitch | > | isBalancerOn | isBalancerEnabled | isBalancerEnabled | > | setCleanerChoreOn | cleanerChoreSwitch | cleanerChoreSwitch | > | isCleanerChoreOn | isCleanerChoreEnabled | isCleanerChoreEnabled | > | setCatalogJanitorOn | catalogJanitorSwitch | catalogJanitorSwitch | > | isCatalogJanitorOn | isCatalogJanitorEnabled | isCatalogJanitorEnabled | > | setSplitOn/setMergeOn | splitOrMergeEnabledSwitch | splitSwitch/mergeSwitch > | > | isSplitOn/isMergeOn| isSplitOrMergeEnabled | isSplitEnabled/isMergeEnabled | > Methods only in AsyncAdmin > || AsyncAdmin || > | majorCompactRegionServer | > | getMaster | > | getBackupMasters | > | getRegionServers | > Methods only in Admin > || Admin || > | listTableDescriptorsByNamespace | > | listTableNamesByNamespace | > | modifyTable | > | getMasterCoprocessors | -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18911) Unify Admin and AsyncAdmin's methods name
[ https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255101#comment-16255101 ] Peter Somogyi commented on HBASE-18911: --- [~zghaobac], could you upload it to ReviewBoard? > Unify Admin and AsyncAdmin's methods name > - > > Key: HBASE-18911 > URL: https://issues.apache.org/jira/browse/HBASE-18911 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18911.master.001.patch, > HBASE-18911.master.002.patch > > > Different Methods > || AsyncAdmin || Admin || unified name || > | listTables | listTableDescriptors | listTableDescriptors | > | getOnlineRegions | getRegions | getRegions | > | getTableRegions | getRegions | getRegions | > | getTableDescriptor | getDescriptor | getDescriptor | > | getRegionLoads | getRegionLoad | getRegionLoads | > | execProcedureWithRet | execProcedureWithReturn | execProcedureWithReturn | > | setNormalizerOn | normalizerSwitch | normalizerSwitch | > | isNormalizerOn | isNormalizerEnabled | isNormalizerEnabled | > | setBalancerOn | balancerSwitch | balancerSwitch | > | isBalancerOn | isBalancerEnabled | isBalancerEnabled | > | setCleanerChoreOn | cleanerChoreSwitch | cleanerChoreSwitch | > | isCleanerChoreOn | isCleanerChoreEnabled | isCleanerChoreEnabled | > | setCatalogJanitorOn | catalogJanitorSwitch | catalogJanitorSwitch | > | isCatalogJanitorOn | isCatalogJanitorEnabled | isCatalogJanitorEnabled | > | setSplitOn/setMergeOn | splitOrMergeEnabledSwitch | splitSwitch/mergeSwitch > | > | isSplitOn/isMergeOn| isSplitOrMergeEnabled | isSplitEnabled/isMergeEnabled | > Methods only in AsyncAdmin > || AsyncAdmin || > | majorCompactRegionServer | > | getMaster | > | getBackupMasters | > | getRegionServers | > Methods only in Admin > || Admin || > | listTableDescriptorsByNamespace | > | listTableNamesByNamespace | > | modifyTable | > | getMasterCoprocessors | -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18911) Unify Admin and AsyncAdmin's methods name
[
https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255086#comment-16255086
]
Hadoop QA commented on HBASE-18911:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
14s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 8 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
19s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
46s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
0s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
19s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
37s{color} | {color:red} hbase-client: The patch generated 14 new + 535
unchanged - 1 fixed = 549 total (was 536) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
4s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
71m 49s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 2.7.4 or 3.0.0-alpha4. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
30s{color} | {color:red} hbase-client generated 1 new + 3 unchanged - 0 fixed =
4 total (was 3) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
34s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}106m
54s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
35s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}210m 6s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-18911 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12897930/HBASE-18911.master.002.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux c8fd6a1ac608 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / 54827cf613 |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d;
[jira] [Commented] (HBASE-18911) Unify Admin and AsyncAdmin's methods name
[ https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245663#comment-16245663 ] Peter Somogyi commented on HBASE-18911: --- Javadoc for Admin#setSplitOrMergeEnabled links to splitOrMergeEnabledSwitch which you removed, modify it to splitSwitch and mergeSwitch. Admin#isSplitOrMergeEnabled typo: Unsupport -> Unsupported splitOrMergeEnabledSwitch replaced without deprecation, was added recently (2.0.0) so should be fine? RawAsyncHBaseAdmin wildcard imports Good that you added TestInterfaceAlign! TestInterfaceAlign's license text is not well formed. > Unify Admin and AsyncAdmin's methods name > - > > Key: HBASE-18911 > URL: https://issues.apache.org/jira/browse/HBASE-18911 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18911.master.001.patch > > > Different Methods > || AsyncAdmin || Admin || unified name || > | listTables | listTableDescriptors | listTableDescriptors | > | getOnlineRegions | getRegions | getRegions | > | getTableRegions | getRegions | getRegions | > | getTableDescriptor | getDescriptor | getDescriptor | > | getRegionLoads | getRegionLoad | getRegionLoads | > | execProcedureWithRet | execProcedureWithReturn | execProcedureWithReturn | > | setNormalizerOn | normalizerSwitch | normalizerSwitch | > | isNormalizerOn | isNormalizerEnabled | isNormalizerEnabled | > | setBalancerOn | balancerSwitch | balancerSwitch | > | isBalancerOn | isBalancerEnabled | isBalancerEnabled | > | setCleanerChoreOn | cleanerChoreSwitch | cleanerChoreSwitch | > | isCleanerChoreOn | isCleanerChoreEnabled | isCleanerChoreEnabled | > | setCatalogJanitorOn | catalogJanitorSwitch | catalogJanitorSwitch | > | isCatalogJanitorOn | isCatalogJanitorEnabled | isCatalogJanitorEnabled | > | setSplitOn/setMergeOn | splitOrMergeEnabledSwitch | splitSwitch/mergeSwitch > | > | isSplitOn/isMergeOn| isSplitOrMergeEnabled | isSplitEnabled/isMergeEnabled | > Methods only in AsyncAdmin > || AsyncAdmin || > | majorCompactRegionServer | > | getMaster | > | getBackupMasters | > | getRegionServers | > Methods only in Admin > || Admin || > | listTableDescriptorsByNamespace | > | listTableNamesByNamespace | > | modifyTable | > | getMasterCoprocessors | -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18911) Unify Admin and AsyncAdmin's methods name
[ https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245205#comment-16245205 ] stack commented on HBASE-18911: --- What you think of this mighty [~psomogyi] sir? > Unify Admin and AsyncAdmin's methods name > - > > Key: HBASE-18911 > URL: https://issues.apache.org/jira/browse/HBASE-18911 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18911.master.001.patch > > > Different Methods > || AsyncAdmin || Admin || unified name || > | listTables | listTableDescriptors | listTableDescriptors | > | getOnlineRegions | getRegions | getRegions | > | getTableRegions | getRegions | getRegions | > | getTableDescriptor | getDescriptor | getDescriptor | > | getRegionLoads | getRegionLoad | getRegionLoads | > | execProcedureWithRet | execProcedureWithReturn | execProcedureWithReturn | > | setNormalizerOn | normalizerSwitch | normalizerSwitch | > | isNormalizerOn | isNormalizerEnabled | isNormalizerEnabled | > | setBalancerOn | balancerSwitch | balancerSwitch | > | isBalancerOn | isBalancerEnabled | isBalancerEnabled | > | setCleanerChoreOn | cleanerChoreSwitch | cleanerChoreSwitch | > | isCleanerChoreOn | isCleanerChoreEnabled | isCleanerChoreEnabled | > | setCatalogJanitorOn | catalogJanitorSwitch | catalogJanitorSwitch | > | isCatalogJanitorOn | isCatalogJanitorEnabled | isCatalogJanitorEnabled | > | setSplitOn/setMergeOn | splitOrMergeEnabledSwitch | splitSwitch/mergeSwitch > | > | isSplitOn/isMergeOn| isSplitOrMergeEnabled | isSplitEnabled/isMergeEnabled | > Methods only in AsyncAdmin > || AsyncAdmin || > | majorCompactRegionServer | > | getMaster | > | getBackupMasters | > | getRegionServers | > Methods only in Admin > || Admin || > | listTableDescriptorsByNamespace | > | listTableNamesByNamespace | > | modifyTable | > | getMasterCoprocessors | -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18911) Unify Admin and AsyncAdmin's methods name
[
https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204772#comment-16204772
]
Hadoop QA commented on HBASE-18911:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 12m
30s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 6 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
18s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
54s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
11s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
46s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
18s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
57s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
37m 39s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
54s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
21s{color} | {color:red} hbase-client generated 1 new + 2 unchanged - 0 fixed =
3 total (was 2) {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
53s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}102m 28s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
32s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}178m 57s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-18911 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12892217/HBASE-18911.master.001.patch
|
| Optional Tests | asflicense shadedjars javac javadoc unit findbugs
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 7d938ad26b37 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 5d9b7a9
[jira] [Commented] (HBASE-18911) Unify Admin and AsyncAdmin's methods name
[ https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204678#comment-16204678 ] Guanghao Zhang commented on HBASE-18911: Attach a 001 patch which unified the methods names by the issue description. bq. How many deprecated APIs will be added in this issue? 4 methods: getRegionLoads/compactRegionServer/getQuotaRetriever. For deleteTables/enableTables/disableTables, I prefer to deprecated them in AsyncAdmin, too. Then we can remove them. For enable/disableTableReplication methods, open HBASE-19009 to track it. For getMasterInfoPort, current implementation is not good. Open HBASE-19009 to track it. This patch added a new ut to check the methods name match between Admin and AsyncAdmin. The ut only check the method names. This will only make sure all Admin methods can be found same method in AsyncAdmin. But the return type or parameter type may be different. So user have to change code from Admin to AsyncAdmin. Meanwhile, we can easily reimplement Admin by AsyncAdmin in hbase 3.0. > Unify Admin and AsyncAdmin's methods name > - > > Key: HBASE-18911 > URL: https://issues.apache.org/jira/browse/HBASE-18911 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18911.master.001.patch > > > Different Methods > || AsyncAdmin || Admin || unified name || > | listTables | listTableDescriptors | listTableDescriptors | > | getOnlineRegions | getRegions | getRegions | > | getTableRegions | getRegions | getRegions | > | getTableDescriptor | getDescriptor | getDescriptor | > | getRegionLoads | getRegionLoad | getRegionLoads | > | execProcedureWithRet | execProcedureWithReturn | execProcedureWithReturn | > | setNormalizerOn | normalizerSwitch | normalizerSwitch | > | isNormalizerOn | isNormalizerEnabled | isNormalizerEnabled | > | setBalancerOn | balancerSwitch | balancerSwitch | > | isBalancerOn | isBalancerEnabled | isBalancerEnabled | > | setCleanerChoreOn | cleanerChoreSwitch | cleanerChoreSwitch | > | isCleanerChoreOn | isCleanerChoreEnabled | isCleanerChoreEnabled | > | setCatalogJanitorOn | catalogJanitorSwitch | catalogJanitorSwitch | > | isCatalogJanitorOn | isCatalogJanitorEnabled | isCatalogJanitorEnabled | > | setSplitOn/setMergeOn | splitOrMergeEnabledSwitch | splitSwitch/mergeSwitch > | > | isSplitOn/isMergeOn| isSplitOrMergeEnabled | isSplitEnabled/isMergeEnabled | > Methods only in AsyncAdmin > || AsyncAdmin || > | majorCompactRegionServer | > | getMaster | > | getBackupMasters | > | getRegionServers | > Methods only in Admin > || Admin || > | listTableDescriptorsByNamespace | > | listTableNamesByNamespace | > | modifyTable | > | getMasterCoprocessors | -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18911) Unify Admin and AsyncAdmin's methods name
[ https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202254#comment-16202254 ] Chia-Ping Tsai commented on HBASE-18911: How many deprecated APIs will be added in this issue? The Admin has 50 deprecated methods now...It may be one of the richest interface in our code base. :) > Unify Admin and AsyncAdmin's methods name > - > > Key: HBASE-18911 > URL: https://issues.apache.org/jira/browse/HBASE-18911 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 2.0.0-beta-1 > > > Different Methods > || AsyncAdmin || Admin || unified name || > | listTables | listTableDescriptors | listTableDescriptors | > | getOnlineRegions | getRegions | getRegions | > | getTableRegions | getRegions | getRegions | > | getTableDescriptor | getDescriptor | getDescriptor | > | getRegionLoads | getRegionLoad | getRegionLoads | > | execProcedureWithRet | execProcedureWithReturn | execProcedureWithReturn | > | setNormalizerOn | normalizerSwitch | setNormalizerOn | > | isNormalizerOn | isNormalizerEnabled | isNormalizerOn | > | setBalancerOn | balancerSwitch | setBalancerOn | > | isBalancerOn | isBalancerEnabled | isBalancerOn | > | setCleanerChoreOn | cleanerChoreSwitch | setCleanerChoreOn | > | isCleanerChoreOn | isCleanerChoreEnabled | isCleanerChoreOn | > | setSplitOn/setMergeOn | splitOrMergeEnabledSwitch | setSplitOn/setMergeOn | > Methods only in AsyncAdmin > || AsyncAdmin || > | isSplitOn | > | isMergeOn | > | majorCompactRegionServer | > | stopRegionServer | -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18911) Unify Admin and AsyncAdmin's methods name
[ https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16201615#comment-16201615 ] Guanghao Zhang commented on HBASE-18911: Take a look about the methods names about Normalizer/Balancer/Cleaner. There are different name patterns in different class.. And We already use set*On method in RegionNormalizerTracker. || AsyncAdmin || Admin || MasterRpcServers || RegionNormalizerTracker/HMaster/CleanerChore || | setNormalizerOn | normalizerSwitch | setNormalizerRunning | setNormalizerOn | | isNormalizerOn | isNormalizerEnabled | isNormalizerEnabled | isNormalizerOn | | setBalancerOn | balancerSwitch | setBalancerRunning | balanceSwitch | | isBalancerOn | isBalancerEnabled | isBalancerEnabled | isBalancerOn | | setCleanerChoreOn | cleanerChoreSwitch | setCleanerChoreRunning | setEnabled | | isCleanerChoreOn | isCleanerChoreEnabled | isCleanerChoreEnabled | getEnabled | > Unify Admin and AsyncAdmin's methods name > - > > Key: HBASE-18911 > URL: https://issues.apache.org/jira/browse/HBASE-18911 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 2.0.0-beta-1 > > > Different Methods > || AsyncAdmin || Admin || unified name || > | listTables | listTableDescriptors | listTableDescriptors | > | getOnlineRegions | getRegions | getRegions | > | getTableRegions | getRegions | getRegions | > | getTableDescriptor | getDescriptor | getDescriptor | > | getRegionLoads | getRegionLoad | getRegionLoads | > | execProcedureWithRet | execProcedureWithReturn | execProcedureWithReturn | > | setNormalizerOn | normalizerSwitch | setNormalizerOn | > | isNormalizerOn | isNormalizerEnabled | isNormalizerOn | > | setBalancerOn | balancerSwitch | setBalancerOn | > | isBalancerOn | isBalancerEnabled | isBalancerOn | > | setCleanerChoreOn | cleanerChoreSwitch | setCleanerChoreOn | > | isCleanerChoreOn | isCleanerChoreEnabled | isCleanerChoreOn | > | setSplitOn/setMergeOn | splitOrMergeEnabledSwitch | setSplitOn/setMergeOn | > Methods only in AsyncAdmin > || AsyncAdmin || > | isSplitOn | > | isMergeOn | > | majorCompactRegionServer | > | stopRegionServer | -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18911) Unify Admin and AsyncAdmin's methods name
[
https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196070#comment-16196070
]
Chia-Ping Tsai commented on HBASE-18911:
bq. Keep these methods in AsyncAdmin?
It is ok if these helper methods are useful for users. Also the deprecated APIs
in {{Admin}} have alternative ways.
But AsyncAdmin may have more methods which not in Admin?
It seem to me that unifying all method names in 2.0 is aesthetic problems, but
the lack of methods is usability problems. It will be better that {{Admin}}
have all functions which {{AsyncAdmin}} have.
> Unify Admin and AsyncAdmin's methods name
> -
>
> Key: HBASE-18911
> URL: https://issues.apache.org/jira/browse/HBASE-18911
> Project: HBase
> Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
> Fix For: 2.0.0-beta-1
>
>
> Different Methods
> || AsyncAdmin || Admin || unified name ||
> | listTables | listTableDescriptors | listTableDescriptors |
> | getOnlineRegions | getRegions | getRegions |
> | getTableRegions | getRegions | getRegions |
> | getTableDescriptor | getDescriptor | getDescriptor |
> | getRegionLoads | getRegionLoad | getRegionLoads |
> | execProcedureWithRet | execProcedureWithReturn | execProcedureWithReturn |
> | setNormalizerOn | normalizerSwitch | setNormalizerOn |
> | isNormalizerOn | isNormalizerEnabled | isNormalizerOn |
> | setBalancerOn | balancerSwitch | setBalancerOn |
> | isBalancerOn | isBalancerEnabled | isBalancerOn |
> | setCleanerChoreOn | cleanerChoreSwitch | setCleanerChoreOn |
> | isCleanerChoreOn | isCleanerChoreEnabled | isCleanerChoreOn |
> | setSplitOn/setMergeOn | splitOrMergeEnabledSwitch | setSplitOn/setMergeOn |
> Methods only in AsyncAdmin
> || AsyncAdmin ||
> | isSplitOn |
> | isMergeOn |
> | majorCompactRegionServer |
> | stopRegionServer |
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18911) Unify Admin and AsyncAdmin's methods name
[ https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196025#comment-16196025 ] Guanghao Zhang commented on HBASE-18911: For deleteTables/enableTables/disableTables methods, how about we only keep these methods in AsyncAdmin? For hbase 3.0, we can implement the blocking client by async client. So AsyncAdmin should have all same methods with Admin. But AsyncAdmin may have more methods which not in Admin? > Unify Admin and AsyncAdmin's methods name > - > > Key: HBASE-18911 > URL: https://issues.apache.org/jira/browse/HBASE-18911 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 2.0.0-beta-1 > > > Different Methods > || AsyncAdmin || Admin || unified name || > | listTables | listTableDescriptors | listTableDescriptors | > | getOnlineRegions | getRegions | getRegions | > | getTableRegions | getRegions | getRegions | > | getTableDescriptor | getDescriptor | getDescriptor | > | getRegionLoads | getRegionLoad | getRegionLoads | > | execProcedureWithRet | execProcedureWithReturn | execProcedureWithReturn | > | setNormalizerOn | normalizerSwitch | setNormalizerOn | > | isNormalizerOn | isNormalizerEnabled | isNormalizerOn | > | setBalancerOn | balancerSwitch | setBalancerOn | > | isBalancerOn | isBalancerEnabled | isBalancerOn | > | setCleanerChoreOn | cleanerChoreSwitch | setCleanerChoreOn | > | isCleanerChoreOn | isCleanerChoreEnabled | isCleanerChoreOn | > | setSplitOn/setMergeOn | splitOrMergeEnabledSwitch | setSplitOn/setMergeOn | > Methods only in AsyncAdmin > || AsyncAdmin || > | isSplitOn | > | isMergeOn | > | majorCompactRegionServer | > | stopRegionServer | -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18911) Unify Admin and AsyncAdmin's methods name
[ https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195806#comment-16195806 ] stack commented on HBASE-18911: --- This is a great issue [~zghaobac] Thanks for starting it. Related, over in HBASE-12260, I added getServers to return list of Region Servers. In AsyncAdmin it is getRegionServers. I made it getServers because that is name of the ClusterStatus method and the name of the method used elsewhere getting list of region servers. On you general list, I think you have to favor the Admin names unless good reason because it is a pain deprecating the old to put in place the new (We have lots of deprecation already in Admin...). I'm not mad about setNormalizerOn because you can use the method to set the normalizer off too. If you have a better name than normalizerSwitch for the method, lets do it... As you say they are new additions not yet in a release so we can change them. execProcedureWithRet is bad. As you suggest, execProcedureWithReturn is better. +1 on the getRegions instead of getOnlineRegions. > Unify Admin and AsyncAdmin's methods name > - > > Key: HBASE-18911 > URL: https://issues.apache.org/jira/browse/HBASE-18911 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 2.0.0-beta-1 > > > Different Methods > || AsyncAdmin || Admin || unified name || > | listTables | listTableDescriptors | listTableDescriptors | > | getOnlineRegions | getRegions | getRegions | > | getTableRegions | getRegions | getRegions | > | getTableDescriptor | getDescriptor | getDescriptor | > | getRegionLoads | getRegionLoad | getRegionLoads | > | execProcedureWithRet | execProcedureWithReturn | execProcedureWithReturn | > | setNormalizerOn | normalizerSwitch | setNormalizerOn | > | isNormalizerOn | isNormalizerEnabled | isNormalizerOn | > | setBalancerOn | balancerSwitch | setBalancerOn | > | isBalancerOn | isBalancerEnabled | isBalancerOn | > | setCleanerChoreOn | cleanerChoreSwitch | setCleanerChoreOn | > | isCleanerChoreOn | isCleanerChoreEnabled | isCleanerChoreOn | > | setSplitOn/setMergeOn | splitOrMergeEnabledSwitch | setSplitOn/setMergeOn | > Methods only in AsyncAdmin > || AsyncAdmin || > | isSplitOn | > | isMergeOn | > | majorCompactRegionServer | > | stopRegionServer | -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18911) Unify Admin and AsyncAdmin's methods name
[
https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195719#comment-16195719
]
Chia-Ping Tsai commented on HBASE-18911:
Let us carry over the discussion in HBASE-18914 now.
{code}
HTableDescriptor[] deleteTables(Pattern)
HTableDescriptor[] enableTables(Pattern)
HTableDescriptor[] disableTables(Pattern)
{code}
If they are useful to user, we must have them new name as they return the
deprecated HTD. The candidate are shown below.
# enableTables/disableTables -> setTablesOn(Pattern, Boolean)
# deleteTables -> dropTables
There are many of methods called xxxOn, hence the {{setTablesOn}} should be
fine.Reflecting this philosophy, the {{isTableEnabled}} can be renamed
{{isTableOn}}. The {{dropTables}} references to our shell command.
> Unify Admin and AsyncAdmin's methods name
> -
>
> Key: HBASE-18911
> URL: https://issues.apache.org/jira/browse/HBASE-18911
> Project: HBase
> Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
> Fix For: 2.0.0-beta-1
>
>
> Different Methods
> || AsyncAdmin || Admin || unified name ||
> | listTables | listTableDescriptors | listTableDescriptors |
> | getOnlineRegions | getRegions | getRegions |
> | getTableRegions | getRegions | getRegions |
> | getTableDescriptor | getDescriptor | getDescriptor |
> | getRegionLoads | getRegionLoad | getRegionLoads |
> | execProcedureWithRet | execProcedureWithReturn | execProcedureWithReturn |
> | setNormalizerOn | normalizerSwitch | setNormalizerOn |
> | isNormalizerOn | isNormalizerEnabled | isNormalizerOn |
> | setBalancerOn | balancerSwitch | setBalancerOn |
> | isBalancerOn | isBalancerEnabled | isBalancerOn |
> | setCleanerChoreOn | cleanerChoreSwitch | setCleanerChoreOn |
> | isCleanerChoreOn | isCleanerChoreEnabled | isCleanerChoreOn |
> | setSplitOn/setMergeOn | splitOrMergeEnabledSwitch | setSplitOn/setMergeOn |
> Methods only in AsyncAdmin
> || AsyncAdmin ||
> | isSplitOn |
> | isMergeOn |
> | majorCompactRegionServer |
> | stopRegionServer |
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18911) Unify Admin and AsyncAdmin's methods name
[ https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194070#comment-16194070 ] Chia-Ping Tsai commented on HBASE-18911: Personally, I prefer the get/set/is pattern. > Unify Admin and AsyncAdmin's methods name > - > > Key: HBASE-18911 > URL: https://issues.apache.org/jira/browse/HBASE-18911 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 2.0.0-beta-1 > > > Different Methods > || AsyncAdmin || Admin || unified name || > | listTables | listTableDescriptors | listTableDescriptors | > | getOnlineRegions | getRegions | getRegions | > | getTableRegions | getRegions | getRegions | > | getTableDescriptor | getDescriptor | getDescriptor | > | getRegionLoads | getRegionLoad | getRegionLoads | > | execProcedureWithRet | execProcedureWithReturn | execProcedureWithReturn | > | setNormalizerOn | normalizerSwitch | setNormalizerOn | > | isNormalizerOn | isNormalizerEnabled | isNormalizerOn | > | setBalancerOn | balancerSwitch | setBalancerOn | > | isBalancerOn | isBalancerEnabled | isBalancerOn | > | setCleanerChoreOn | cleanerChoreSwitch | setCleanerChoreOn | > | isCleanerChoreOn | isCleanerChoreEnabled | isCleanerChoreOn | > | setSplitOn/setMergeOn | splitOrMergeEnabledSwitch | setSplitOn/setMergeOn | > Methods only in AsyncAdmin > || AsyncAdmin || > | isSplitOn | > | isMergeOn | > | majorCompactRegionServer | > | stopRegionServer | -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18911) Unify Admin and AsyncAdmin's methods name
[ https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191221#comment-16191221 ] Guanghao Zhang commented on HBASE-18911: Seems the *Switch methods were introduced by HBASE-14998. I thought we need unify the methods name for AsyncAdmin and Admin. [~stack] Any ideas about this issue? > Unify Admin and AsyncAdmin's methods name > - > > Key: HBASE-18911 > URL: https://issues.apache.org/jira/browse/HBASE-18911 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 2.0.0-beta-1 > > > Different Methods > || AsyncAdmin || Admin || unified name || > | listTables | listTableDescriptors | listTableDescriptors | > | getTableDescriptor | getDescriptor | getDescriptor | > | getRegionLoads | getRegionLoad | getRegionLoads | > | setNormalizerOn | normalizerSwitch | setNormalizerOn | > | isNormalizerOn | isNormalizerEnabled | isNormalizerOn | > | setBalancerOn | balancerSwitch | setBalancerOn | > | isBalancerOn | isBalancerEnabled | isBalancerOn | > | setCleanerChoreOn | cleanerChoreSwitch | setCleanerChoreOn | > | isCleanerChoreOn | isCleanerChoreEnabled | isCleanerChoreOn | > | setSplitOn/setMergeOn | splitOrMergeEnabledSwitch | setSplitOn/setMergeOn | > Methods only in AsyncAdmin > || AsyncAdmin || > | isSplitOn | > | isMergeOn | > | majorCompactRegionServer | > | stopRegionServer | -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18911) Unify Admin and AsyncAdmin's methods name
[ https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187245#comment-16187245 ] Guanghao Zhang commented on HBASE-18911: [~chia7712] Got it. Update the unified name to description. > Unify Admin and AsyncAdmin's methods name > - > > Key: HBASE-18911 > URL: https://issues.apache.org/jira/browse/HBASE-18911 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 2.0.0-beta-1 > > > Different Methods > || AsyncAdmin || Admin || unified name || > | listTables | listTableDescriptors | listTableDescriptors | > | getTableDescriptor | getDescriptor | getDescriptor | > | getRegionLoads | getRegionLoad | | > | setNormalizerOn | normalizerSwitch | | > | isNormalizerOn | isNormalizerEnabled | | > | setBalancerOn | balancerSwitch | | > | isBalancerOn | isBalancerEnabled | | > | setCleanerChoreOn | cleanerChoreSwitch | | > | isCleanerChoreOn | isCleanerChoreEnabled | | > | setSplitOn/setMergeOn | splitOrMergeEnabledSwitch | | > Methods only in AsyncAdmin > || AsyncAdmin || > | isSplitOn | > | isMergeOn | > | majorCompactRegionServer | > | stopRegionServer | -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18911) Unify Admin and AsyncAdmin's methods name
[
https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187092#comment-16187092
]
Chia-Ping Tsai commented on HBASE-18911:
bq. getTableDescriptor is better than getDescriptor?
Yep. However, {{Admin#getTableDescriptor}} return the deprecated class
{{HTableDescriptor}}, so we deprecate it and substitute {{Admin#getDescriptor}}
for it.
> Unify Admin and AsyncAdmin's methods name
> -
>
> Key: HBASE-18911
> URL: https://issues.apache.org/jira/browse/HBASE-18911
> Project: HBase
> Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
> Fix For: 2.0.0-beta-1
>
>
> Different Methods
> || AsyncAdmin || Admin ||
> | listTables | listTableDescriptors |
> | getTableDescriptor | getDescriptor |
> | getRegionLoads | getRegionLoad |
> | getMaster | getMasterInfoPort |
> | setNormalizerOn | normalizerSwitch |
> | isNormalizerOn | isNormalizerEnabled |
> | setBalancerOn | balancerSwitch |
> | isBalancerOn | isBalancerEnabled |
> | setCleanerChoreOn | cleanerChoreSwitch |
> | isCleanerChoreOn | isCleanerChoreEnabled |
> | setSplitOn/setMergeOn | splitOrMergeEnabledSwitch |
> Methods only in AsyncAdmin
> || AsyncAdmin ||
> | isSplitOn |
> | isMergeOn |
> | majorCompactRegionServer |
> | stopRegionServer |
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18911) Unify Admin and AsyncAdmin's methods name
[ https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187080#comment-16187080 ] Guanghao Zhang commented on HBASE-18911: bq. should we add the methods which only exist in AsyncAdmin to Admin I thought we should unify them for hbase 2.0. For hbase 3.0, it may be not needed? bq. Admin#getTableDescriptor are in deprecated cycle getTableDescriptor is better than getDescriptor? > Unify Admin and AsyncAdmin's methods name > - > > Key: HBASE-18911 > URL: https://issues.apache.org/jira/browse/HBASE-18911 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 2.0.0-beta-1 > > > Different Methods > || AsyncAdmin || Admin || > | listTables | listTableDescriptors | > | getTableDescriptor | getDescriptor | > | getRegionLoads | getRegionLoad | > | getMaster | getMasterInfoPort | > | setNormalizerOn | normalizerSwitch | > | isNormalizerOn | isNormalizerEnabled | > | setBalancerOn | balancerSwitch | > | isBalancerOn | isBalancerEnabled | > | setCleanerChoreOn | cleanerChoreSwitch | > | isCleanerChoreOn | isCleanerChoreEnabled | > | setSplitOn/setMergeOn | splitOrMergeEnabledSwitch | > Methods only in AsyncAdmin > || AsyncAdmin || > | isSplitOn | > | isMergeOn | > | majorCompactRegionServer | > | stopRegionServer | -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18911) Unify Admin and AsyncAdmin's methods name
[
https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187015#comment-16187015
]
Chia-Ping Tsai commented on HBASE-18911:
{{Admin#listTables}} and {{Admin#getTableDescriptor}} are in deprecated cycle,
hence we must have the alternative names for both of methods.
{{Admin#getMasterInfoPort}} returns only the port, so I think the method name
is suitable. Perhaps we can add {{getMaster}} to Admin? BTW, should we add the
methods which only exist in {{AsyncAdmin}} to {{Admin}}?
> Unify Admin and AsyncAdmin's methods name
> -
>
> Key: HBASE-18911
> URL: https://issues.apache.org/jira/browse/HBASE-18911
> Project: HBase
> Issue Type: Sub-task
>Reporter: Guanghao Zhang
>Assignee: Guanghao Zhang
> Fix For: 2.0.0-beta-1
>
>
> Different Methods
> || AsyncAdmin || Admin ||
> | listTables | listTableDescriptors |
> | getTableDescriptor | getDescriptor |
> | getRegionLoads | getRegionLoad |
> | getMaster | getMasterInfoPort |
> | setNormalizerOn | normalizerSwitch |
> | isNormalizerOn | isNormalizerEnabled |
> | setBalancerOn | balancerSwitch |
> | isBalancerOn | isBalancerEnabled |
> | setCleanerChoreOn | cleanerChoreSwitch |
> | isCleanerChoreOn | isCleanerChoreEnabled |
> | setSplitOn/setMergeOn | splitOrMergeEnabledSwitch |
> Methods only in AsyncAdmin
> || AsyncAdmin ||
> | isSplitOn |
> | isMergeOn |
> | majorCompactRegionServer |
> | stopRegionServer |
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18911) Unify Admin and AsyncAdmin's methods name
[ https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187009#comment-16187009 ] Guanghao Zhang commented on HBASE-18911: IMO I suggest to use the method names in AsyncAdmin. Any ideas about this? [~stack] [~Apache9] [~anoop.hbase] [~ramkrishna.s.vasude...@gmail.com] [~chia7712] > Unify Admin and AsyncAdmin's methods name > - > > Key: HBASE-18911 > URL: https://issues.apache.org/jira/browse/HBASE-18911 > Project: HBase > Issue Type: Sub-task >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang > Fix For: 2.0.0-beta-1 > > > Different Methods > || AsyncAdmin || Admin || > | listTables | listTableDescriptors | > | getTableDescriptor | getDescriptor | > | getRegionLoads | getRegionLoad | > | getMaster | getMasterInfoPort | > | setNormalizerOn | normalizerSwitch | > | isNormalizerOn | isNormalizerEnabled | > | setBalancerOn | balancerSwitch | > | isBalancerOn | isBalancerEnabled | > | setCleanerChoreOn | cleanerChoreSwitch | > | isCleanerChoreOn | isCleanerChoreEnabled | > | setSplitOn/setMergeOn | splitOrMergeEnabledSwitch | > Methods only in AsyncAdmin > || AsyncAdmin || > | isSplitOn | > | isMergeOn | > | majorCompactRegionServer | > | stopRegionServer | -- This message was sent by Atlassian JIRA (v6.4.14#64029)
