[jira] [Commented] (HBASE-20683) Incorrect return value for PreUpgradeValidator
[
https://issues.apache.org/jira/browse/HBASE-20683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504691#comment-16504691
]
Hudson commented on HBASE-20683:
Results for branch master
[build #358 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/358/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/358//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/358//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/358//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Incorrect return value for PreUpgradeValidator
> --
>
> Key: HBASE-20683
> URL: https://issues.apache.org/jira/browse/HBASE-20683
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0, 2.1.0, 2.0.1
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Critical
> Fix For: 3.0.0, 2.1.0, 2.0.1
>
> Attachments: HBASE-20683.master.001.patch,
> HBASE-20683.master.002.patch
>
>
> PreUpgradeValidator currently returns 1 when there is no incompatibilities.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20683) Incorrect return value for PreUpgradeValidator
[
https://issues.apache.org/jira/browse/HBASE-20683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503773#comment-16503773
]
Hudson commented on HBASE-20683:
Results for branch branch-2
[build #831 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/831/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/831//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/831//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/831//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Incorrect return value for PreUpgradeValidator
> --
>
> Key: HBASE-20683
> URL: https://issues.apache.org/jira/browse/HBASE-20683
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0, 2.1.0, 2.0.1
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Critical
> Fix For: 3.0.0, 2.1.0, 2.0.1
>
> Attachments: HBASE-20683.master.001.patch,
> HBASE-20683.master.002.patch
>
>
> PreUpgradeValidator currently returns 1 when there is no incompatibilities.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20683) Incorrect return value for PreUpgradeValidator
[
https://issues.apache.org/jira/browse/HBASE-20683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503762#comment-16503762
]
Hudson commented on HBASE-20683:
Results for branch branch-2.0
[build #396 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/396/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/396//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/396//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/396//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Incorrect return value for PreUpgradeValidator
> --
>
> Key: HBASE-20683
> URL: https://issues.apache.org/jira/browse/HBASE-20683
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0, 2.1.0, 2.0.1
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Critical
> Fix For: 3.0.0, 2.1.0, 2.0.1
>
> Attachments: HBASE-20683.master.001.patch,
> HBASE-20683.master.002.patch
>
>
> PreUpgradeValidator currently returns 1 when there is no incompatibilities.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20683) Incorrect return value for PreUpgradeValidator
[
https://issues.apache.org/jira/browse/HBASE-20683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503598#comment-16503598
]
Hadoop QA commented on HBASE-20683:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
36s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
25s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
14m 19s{color} | {color:green} Patch does not cause any errors with Hadoop
2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
7s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}129m
40s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}176m 27s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-20683 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12926715/HBASE-20683.master.002.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux asf902.gq1.ygridcore.net 3.13.0-139-generic #188-Ubuntu SMP Tue
Jan 9 14:43:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 7d3750b |
| maven | version: Apache Maven 3.0.5
(r01de14724cdef164cd33c7c8c2fe155faf9602da; 2013-02-19 13:51:28+) |
| Default Java | 1.8.0_172 |
| findbugs | v3.1.0-RC3 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/13108/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/13108/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Incorrect return value for PreUpgradeValidator
> --
>
> Key: HBASE
[jira] [Commented] (HBASE-20683) Incorrect return value for PreUpgradeValidator
[ https://issues.apache.org/jira/browse/HBASE-20683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503353#comment-16503353 ] Ted Yu commented on HBASE-20683: Triggered https://builds.apache.org/job/PreCommit-HBASE-Build/13108/ where docker is not used. > Incorrect return value for PreUpgradeValidator > -- > > Key: HBASE-20683 > URL: https://issues.apache.org/jira/browse/HBASE-20683 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0, 2.1.0, 2.0.1 >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Critical > Attachments: HBASE-20683.master.001.patch, > HBASE-20683.master.002.patch > > > PreUpgradeValidator currently returns 1 when there is no incompatibilities. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20683) Incorrect return value for PreUpgradeValidator
[
https://issues.apache.org/jira/browse/HBASE-20683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503348#comment-16503348
]
Chia-Ping Tsai commented on HBASE-20683:
{quote}Do you think it is not a good idea to return the number of incompatible
column families?
{quote}
Returning the number of incompatible column families makes sense to me. I
didn't review the patch by the IDE so I misunderstand the purpose of the patch.
(I assumed the patch is used to the enhance or fix the tool...)
{quote}Currently we don't use the value just to check if it is zero or not, but
later on we could build a report of all the pre-upgrade validations where this
number could be useful.
{quote}
+1 on your idea and patch.
> Incorrect return value for PreUpgradeValidator
> --
>
> Key: HBASE-20683
> URL: https://issues.apache.org/jira/browse/HBASE-20683
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0, 2.1.0, 2.0.1
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Critical
> Attachments: HBASE-20683.master.001.patch,
> HBASE-20683.master.002.patch
>
>
> PreUpgradeValidator currently returns 1 when there is no incompatibilities.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20683) Incorrect return value for PreUpgradeValidator
[ https://issues.apache.org/jira/browse/HBASE-20683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503336#comment-16503336 ] Peter Somogyi commented on HBASE-20683: --- Yes, tool's behavior is not changed, works as before. Do you think it is not a good idea to return the number of incompatible column families? Currently we don't use the value just to check if it is zero or not, but later on we could build a report of all the pre-upgrade validations where this number could be useful. > Incorrect return value for PreUpgradeValidator > -- > > Key: HBASE-20683 > URL: https://issues.apache.org/jira/browse/HBASE-20683 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0, 2.1.0, 2.0.1 >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Critical > Attachments: HBASE-20683.master.001.patch, > HBASE-20683.master.002.patch > > > PreUpgradeValidator currently returns 1 when there is no incompatibilities. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20683) Incorrect return value for PreUpgradeValidator
[ https://issues.apache.org/jira/browse/HBASE-20683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503301#comment-16503301 ] Chia-Ping Tsai commented on HBASE-20683: Pardon me. I don't catch the point about the benefit of changing the return type from boolean to int. seems the behavior of this tool is not modified? > Incorrect return value for PreUpgradeValidator > -- > > Key: HBASE-20683 > URL: https://issues.apache.org/jira/browse/HBASE-20683 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0, 2.1.0, 2.0.1 >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Critical > Attachments: HBASE-20683.master.001.patch, > HBASE-20683.master.002.patch > > > PreUpgradeValidator currently returns 1 when there is no incompatibilities. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20683) Incorrect return value for PreUpgradeValidator
[ https://issues.apache.org/jira/browse/HBASE-20683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503241#comment-16503241 ] Peter Somogyi commented on HBASE-20683: --- Thanks for reviewing [~yuzhih...@gmail.com]. I'm checking why the docker image build is failing, although it shouldn't be related to the change. > Incorrect return value for PreUpgradeValidator > -- > > Key: HBASE-20683 > URL: https://issues.apache.org/jira/browse/HBASE-20683 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0, 2.1.0, 2.0.1 >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Critical > Attachments: HBASE-20683.master.001.patch, > HBASE-20683.master.002.patch > > > PreUpgradeValidator currently returns 1 when there is no incompatibilities. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20683) Incorrect return value for PreUpgradeValidator
[
https://issues.apache.org/jira/browse/HBASE-20683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503235#comment-16503235
]
Hadoop QA commented on HBASE-20683:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} docker {color} | {color:red} 1m
28s{color} | {color:red} Docker failed to build yetus/hbase:d8b550f. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-20683 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12926715/HBASE-20683.master.002.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/13107/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Incorrect return value for PreUpgradeValidator
> --
>
> Key: HBASE-20683
> URL: https://issues.apache.org/jira/browse/HBASE-20683
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0, 2.1.0, 2.0.1
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Critical
> Attachments: HBASE-20683.master.001.patch,
> HBASE-20683.master.002.patch
>
>
> PreUpgradeValidator currently returns 1 when there is no incompatibilities.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20683) Incorrect return value for PreUpgradeValidator
[ https://issues.apache.org/jira/browse/HBASE-20683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503229#comment-16503229 ] Ted Yu commented on HBASE-20683: +1 > Incorrect return value for PreUpgradeValidator > -- > > Key: HBASE-20683 > URL: https://issues.apache.org/jira/browse/HBASE-20683 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0, 2.1.0, 2.0.1 >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Critical > Attachments: HBASE-20683.master.001.patch, > HBASE-20683.master.002.patch > > > PreUpgradeValidator currently returns 1 when there is no incompatibilities. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20683) Incorrect return value for PreUpgradeValidator
[
https://issues.apache.org/jira/browse/HBASE-20683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503159#comment-16503159
]
Hadoop QA commented on HBASE-20683:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} docker {color} | {color:red} 1m
20s{color} | {color:red} Docker failed to build yetus/hbase:d8b550f. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-20683 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12926715/HBASE-20683.master.002.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/13106/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Incorrect return value for PreUpgradeValidator
> --
>
> Key: HBASE-20683
> URL: https://issues.apache.org/jira/browse/HBASE-20683
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0, 2.1.0, 2.0.1
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Critical
> Attachments: HBASE-20683.master.001.patch,
> HBASE-20683.master.002.patch
>
>
> PreUpgradeValidator currently returns 1 when there is no incompatibilities.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20683) Incorrect return value for PreUpgradeValidator
[
https://issues.apache.org/jira/browse/HBASE-20683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503154#comment-16503154
]
Hadoop QA commented on HBASE-20683:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} docker {color} | {color:red} 1m
23s{color} | {color:red} Docker failed to build yetus/hbase:d8b550f. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-20683 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12926715/HBASE-20683.master.002.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/13105/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Incorrect return value for PreUpgradeValidator
> --
>
> Key: HBASE-20683
> URL: https://issues.apache.org/jira/browse/HBASE-20683
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0, 2.1.0, 2.0.1
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Critical
> Attachments: HBASE-20683.master.001.patch,
> HBASE-20683.master.002.patch
>
>
> PreUpgradeValidator currently returns 1 when there is no incompatibilities.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20683) Incorrect return value for PreUpgradeValidator
[ https://issues.apache.org/jira/browse/HBASE-20683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503100#comment-16503100 ] Peter Somogyi commented on HBASE-20683: --- bq. I wonder if the return value should be int: the number of incompatibilities (0 means pass). It doesn't make much difference and the value might be useful later on. I'll make this change. > Incorrect return value for PreUpgradeValidator > -- > > Key: HBASE-20683 > URL: https://issues.apache.org/jira/browse/HBASE-20683 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0, 2.1.0, 2.0.1 >Reporter: Peter Somogyi >Assignee: Peter Somogyi >Priority: Critical > Attachments: HBASE-20683.master.001.patch > > > PreUpgradeValidator currently returns 1 when there is no incompatibilities. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20683) Incorrect return value for PreUpgradeValidator
[
https://issues.apache.org/jira/browse/HBASE-20683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16502562#comment-16502562
]
Ted Yu commented on HBASE-20683:
lgtm
{code}
* @return DataBlockEncoding compatible with HBase 2
* @throws IOException if a remote or network exception occurs
*/
private boolean validateDBE() throws IOException {
{code}
I wonder if the return value should be int: the number of incompatibilities (0
means pass).
> Incorrect return value for PreUpgradeValidator
> --
>
> Key: HBASE-20683
> URL: https://issues.apache.org/jira/browse/HBASE-20683
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0, 2.1.0, 2.0.1
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Critical
> Attachments: HBASE-20683.master.001.patch
>
>
> PreUpgradeValidator currently returns 1 when there is no incompatibilities.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20683) Incorrect return value for PreUpgradeValidator
[
https://issues.apache.org/jira/browse/HBASE-20683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501727#comment-16501727
]
Hadoop QA commented on HBASE-20683:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
16s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
54s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
31s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
49s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
9m 53s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}109m
23s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}150m 21s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8b550f |
| JIRA Issue | HBASE-20683 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12926539/HBASE-20683.master.001.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 19aefbe50275 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9
14:43:09 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 57c8671728 |
| maven | version: Apache Maven 3.5.3
(3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) |
| Default Java | 1.8.0_171 |
| findbugs | v3.1.0-RC3 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/13087/testReport/ |
| Max. process+thread count | 4447 (vs. ulimit of 1) |
| modules | C: hbase-server U: hbase-server |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/13087/console |
