[jira] [Commented] (HBASE-22100) False positive for error prone warnings in pre commit job
[
https://issues.apache.org/jira/browse/HBASE-22100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804260#comment-16804260
]
Hudson commented on HBASE-22100:
Results for branch branch-2
[build #1782 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1782/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1782//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1782//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1782//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> False positive for error prone warnings in pre commit job
> -
>
> Key: HBASE-22100
> URL: https://issues.apache.org/jira/browse/HBASE-22100
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Minor
> Fix For: 3.0.0, 2.2.0, 2.3.0, 2.0.6, 2.1.5
>
> Attachments: HBASE-22100-test.patch, HBASE-22100.patch
>
>
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/branch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> {noformat}
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/patch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> And the output is 1 new and 1 fixed, the new one is
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> I think here we should report nothing, as it is just an order change...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22100) False positive for error prone warnings in pre commit job
[
https://issues.apache.org/jira/browse/HBASE-22100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804241#comment-16804241
]
Hudson commented on HBASE-22100:
Results for branch branch-2.2
[build #139 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/139/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/139//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/139//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/139//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> False positive for error prone warnings in pre commit job
> -
>
> Key: HBASE-22100
> URL: https://issues.apache.org/jira/browse/HBASE-22100
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Minor
> Fix For: 3.0.0, 2.2.0, 2.3.0, 2.0.6, 2.1.5
>
> Attachments: HBASE-22100-test.patch, HBASE-22100.patch
>
>
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/branch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> {noformat}
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/patch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> And the output is 1 new and 1 fixed, the new one is
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> I think here we should report nothing, as it is just an order change...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22100) False positive for error prone warnings in pre commit job
[
https://issues.apache.org/jira/browse/HBASE-22100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804111#comment-16804111
]
Hudson commented on HBASE-22100:
Results for branch branch-2.1
[build #1002 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1002/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1002//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1002//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1002//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> False positive for error prone warnings in pre commit job
> -
>
> Key: HBASE-22100
> URL: https://issues.apache.org/jira/browse/HBASE-22100
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Minor
> Fix For: 3.0.0, 2.2.0, 2.3.0, 2.0.6, 2.1.5
>
> Attachments: HBASE-22100-test.patch, HBASE-22100.patch
>
>
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/branch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> {noformat}
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/patch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> And the output is 1 new and 1 fixed, the new one is
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> I think here we should report nothing, as it is just an order change...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22100) False positive for error prone warnings in pre commit job
[
https://issues.apache.org/jira/browse/HBASE-22100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804050#comment-16804050
]
Hudson commented on HBASE-22100:
Results for branch branch-2.0
[build #1472 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1472/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1472//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1472//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1472//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> False positive for error prone warnings in pre commit job
> -
>
> Key: HBASE-22100
> URL: https://issues.apache.org/jira/browse/HBASE-22100
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Minor
> Fix For: 3.0.0, 2.2.0, 2.3.0, 2.0.6, 2.1.5
>
> Attachments: HBASE-22100-test.patch, HBASE-22100.patch
>
>
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/branch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> {noformat}
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/patch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> And the output is 1 new and 1 fixed, the new one is
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> I think here we should report nothing, as it is just an order change...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22100) False positive for error prone warnings in pre commit job
[
https://issues.apache.org/jira/browse/HBASE-22100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803891#comment-16803891
]
Hudson commented on HBASE-22100:
Results for branch master
[build #892 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/892/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/892//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/892//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/892//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> False positive for error prone warnings in pre commit job
> -
>
> Key: HBASE-22100
> URL: https://issues.apache.org/jira/browse/HBASE-22100
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Minor
> Fix For: 3.0.0, 2.2.0, 2.3.0, 2.0.6, 2.1.5
>
> Attachments: HBASE-22100-test.patch, HBASE-22100.patch
>
>
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/branch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> {noformat}
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/patch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> And the output is 1 new and 1 fixed, the new one is
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> I think here we should report nothing, as it is just an order change...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22100) False positive for error prone warnings in pre commit job
[
https://issues.apache.org/jira/browse/HBASE-22100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803588#comment-16803588
]
Duo Zhang commented on HBASE-22100:
---
Seems worked.
https://builds.apache.org/job/PreCommit-HBASE-Build/16557/artifact/patchprocess/patch-compile-javac-root.txt
The file is sorted, as you can see that less leading digit will placed first.
Let me commit, Thanks [~busbey] for reivewing.
> False positive for error prone warnings in pre commit job
> -
>
> Key: HBASE-22100
> URL: https://issues.apache.org/jira/browse/HBASE-22100
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-22100-test.patch, HBASE-22100.patch
>
>
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/branch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> {noformat}
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/patch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> And the output is 1 new and 1 fixed, the new one is
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> I think here we should report nothing, as it is just an order change...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22100) False positive for error prone warnings in pre commit job
[
https://issues.apache.org/jira/browse/HBASE-22100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16802902#comment-16802902
]
Sean Busbey commented on HBASE-22100:
-
+1
nit: the description above the function definition is good, but it should start
with a {{@description}} one line summary. we don't have the shelldocs
executable available so it didn't flag this. we don't actually generate
shelldocs, so I don't feel strongly.
> False positive for error prone warnings in pre commit job
> -
>
> Key: HBASE-22100
> URL: https://issues.apache.org/jira/browse/HBASE-22100
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-22100-test.patch, HBASE-22100.patch
>
>
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/branch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> {noformat}
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/patch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> And the output is 1 new and 1 fixed, the new one is
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> I think here we should report nothing, as it is just an order change...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22100) False positive for error prone warnings in pre commit job
[
https://issues.apache.org/jira/browse/HBASE-22100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16802893#comment-16802893
]
Hadoop QA commented on HBASE-22100:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
20s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m
0s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
20s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 10m
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
11s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
59s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 10m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 10m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
0s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
3s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
8m 6s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
2s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}278m 30s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
38s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}332m 16s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas |
| |
hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleWAL |
| | hadoop.hbase.quotas.TestSpaceQuotas |
| | hadoop.hbase.master.procedure.TestSCPWithReplicas |
| | hadoop.hbase.master.TestSplitWALManager |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-22100 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12963853/HBASE-22100-test.patch
|
| Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc
unit shadedjars hadoopcheck xml compile |
| uname | Linux 284ae2f0a51e 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 7b3ff56202 |
| maven | version: Apache Maven 3.5.4
[jira] [Commented] (HBASE-22100) False positive for error prone warnings in pre commit job
[
https://issues.apache.org/jira/browse/HBASE-22100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16802593#comment-16802593
]
Hadoop QA commented on HBASE-22100:
---
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at
https://builds.apache.org/job/PreCommit-HBASE-Build/16557/console in case of
problems.
> False positive for error prone warnings in pre commit job
> -
>
> Key: HBASE-22100
> URL: https://issues.apache.org/jira/browse/HBASE-22100
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-22100-test.patch, HBASE-22100.patch
>
>
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/branch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> {noformat}
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/patch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> And the output is 1 new and 1 fixed, the new one is
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> I think here we should report nothing, as it is just an order change...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22100) False positive for error prone warnings in pre commit job
[
https://issues.apache.org/jira/browse/HBASE-22100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16802577#comment-16802577
]
Duo Zhang commented on HBASE-22100:
---
Oh it will not execute the javac if we do not touch java files...
Let me add a simple modification in hbase-client module to see if the sort
works...
> False positive for error prone warnings in pre commit job
> -
>
> Key: HBASE-22100
> URL: https://issues.apache.org/jira/browse/HBASE-22100
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-22100.patch
>
>
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/branch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> {noformat}
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/patch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> And the output is 1 new and 1 fixed, the new one is
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> I think here we should report nothing, as it is just an order change...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22100) False positive for error prone warnings in pre commit job
[
https://issues.apache.org/jira/browse/HBASE-22100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16802568#comment-16802568
]
Hadoop QA commented on HBASE-22100:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m
0s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
1s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
10s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 0m 36s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-22100 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12963848/HBASE-22100.patch |
| Optional Tests | dupname asflicense shellcheck shelldocs |
| uname | Linux c522cde2bee6 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed Oct
31 10:55:11 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 7b3ff56202 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| shellcheck | v0.4.4 |
| Max. process+thread count | 43 (vs. ulimit of 1) |
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/16555/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> False positive for error prone warnings in pre commit job
> -
>
> Key: HBASE-22100
> URL: https://issues.apache.org/jira/browse/HBASE-22100
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-22100.patch
>
>
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/branch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> {noformat}
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/patch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> And the output is 1 new and 1 fixed, the new one is
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> I think here we should report nothing, as it is just an order change...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22100) False positive for error prone warnings in pre commit job
[
https://issues.apache.org/jira/browse/HBASE-22100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16802567#comment-16802567
]
Hadoop QA commented on HBASE-22100:
---
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at
https://builds.apache.org/job/PreCommit-HBASE-Build/16555/console in case of
problems.
> False positive for error prone warnings in pre commit job
> -
>
> Key: HBASE-22100
> URL: https://issues.apache.org/jira/browse/HBASE-22100
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-22100.patch
>
>
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/branch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> {noformat}
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/patch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> And the output is 1 new and 1 fixed, the new one is
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> I think here we should report nothing, as it is just an order change...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22100) False positive for error prone warnings in pre commit job
[
https://issues.apache.org/jira/browse/HBASE-22100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16802479#comment-16802479
]
Sean Busbey commented on HBASE-22100:
-
yep! yetus looks for how to do log filtering and diff calculations in a certain
order. the simplified ordering is:
# project specific
# build tool specific
# plugin specific
> False positive for error prone warnings in pre commit job
> -
>
> Key: HBASE-22100
> URL: https://issues.apache.org/jira/browse/HBASE-22100
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Duo Zhang
>Priority: Major
>
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/branch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> {noformat}
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/patch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> And the output is 1 new and 1 fixed, the new one is
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> I think here we should report nothing, as it is just an order change...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22100) False positive for error prone warnings in pre commit job
[
https://issues.apache.org/jira/browse/HBASE-22100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16802475#comment-16802475
]
Duo Zhang commented on HBASE-22100:
---
Yetus will search the function automatically? Good, let me try.
> False positive for error prone warnings in pre commit job
> -
>
> Key: HBASE-22100
> URL: https://issues.apache.org/jira/browse/HBASE-22100
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Duo Zhang
>Priority: Major
>
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/branch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> {noformat}
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/patch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> And the output is 1 new and 1 fixed, the new one is
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> I think here we should report nothing, as it is just an order change...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22100) False positive for error prone warnings in pre commit job
[
https://issues.apache.org/jira/browse/HBASE-22100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16802473#comment-16802473
]
Sean Busbey commented on HBASE-22100:
-
in our {{dev-support/hbase-personality.sh}} you just define a function with
that name.
> False positive for error prone warnings in pre commit job
> -
>
> Key: HBASE-22100
> URL: https://issues.apache.org/jira/browse/HBASE-22100
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Duo Zhang
>Priority: Major
>
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/branch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> {noformat}
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/patch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> And the output is 1 new and 1 fixed, the new one is
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> I think here we should report nothing, as it is just an order change...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22100) False positive for error prone warnings in pre commit job
[
https://issues.apache.org/jira/browse/HBASE-22100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16802462#comment-16802462
]
Duo Zhang commented on HBASE-22100:
---
{quote}
if we define hbase_javac_logfilter or hbase_javac_calcdiffs respectively that
should take precedence over the ones provided by the maven plugin.
{quote}
How to do this? I think this will be better as error prone check is just part
of the compile and the output is like the javac warnings and errors...
> False positive for error prone warnings in pre commit job
> -
>
> Key: HBASE-22100
> URL: https://issues.apache.org/jira/browse/HBASE-22100
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Duo Zhang
>Priority: Major
>
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/branch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> {noformat}
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/patch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> And the output is 1 new and 1 fixed, the new one is
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> I think here we should report nothing, as it is just an order change...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22100) False positive for error prone warnings in pre commit job
[
https://issues.apache.org/jira/browse/HBASE-22100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16802460#comment-16802460
]
Sean Busbey commented on HBASE-22100:
-
if we define {{hbase_javac_logfilter}} or {{hbase_javac_calcdiffs}}
respectively that should take precedence over the ones provided by the maven
plugin.
alternatively we could define a new test plugin for running with the error
prone profile, similar to how we have one defined for running the shaded jar
verification.
> False positive for error prone warnings in pre commit job
> -
>
> Key: HBASE-22100
> URL: https://issues.apache.org/jira/browse/HBASE-22100
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Duo Zhang
>Priority: Major
>
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/branch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> {noformat}
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/patch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> And the output is 1 new and 1 fixed, the new one is
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> I think here we should report nothing, as it is just an order change...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22100) False positive for error prone warnings in pre commit job
[
https://issues.apache.org/jira/browse/HBASE-22100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16802319#comment-16802319
]
Duo Zhang commented on HBASE-22100:
---
[~busbey] How do you think we should do to fix this issue?
Thanks.
> False positive for error prone warnings in pre commit job
> -
>
> Key: HBASE-22100
> URL: https://issues.apache.org/jira/browse/HBASE-22100
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Duo Zhang
>Priority: Major
>
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/branch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> {noformat}
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/patch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> And the output is 1 new and 1 fixed, the new one is
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> I think here we should report nothing, as it is just an order change...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22100) False positive for error prone warnings in pre commit job
[
https://issues.apache.org/jira/browse/HBASE-22100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801297#comment-16801297
]
Duo Zhang commented on HBASE-22100:
---
{quote}
If you think this is a thing we can fix by updating the default javac output
diff set up in yetus, then yeah a yetus jira makes sense.
{quote}
No sure how yetus works but I found something maybe related in yetus
{code:maven.sh}
## @description process javac output from maven
## @audience private
## @stabilityevolving
function maven_javac_logfilter
{
declare input=$1
declare output=$2
${GREP} -E '\[(ERROR|WARNING)\] /.*\.java:' "${input}" > "${output}"
}
## @description handle diffing maven javac errors
## @audience private
## @stabilityevolving
## @replaceable no
## @parambranchlog
## @parampatchlog
## @return differences
function maven_javac_calcdiffs
{
declare orig=$1
declare new=$2
declare tmp=${PATCH_DIR}/pl.$$.${RANDOM}
# first, strip :[line
# this keeps file,column in an attempt to increase
# accuracy in case of multiple, repeated errors
# since the column number shouldn't change
# if the line of code hasn't been touched
"${SED}" -e 's#:\[[0-9]*,#:#' "${orig}" > "${tmp}.branch"
"${SED}" -e 's#:\[[0-9]*,#:#' "${new}" > "${tmp}.patch"
# compare the errors, generating a string of line
# numbers. Sorry portability: GNU diff makes this too easy
${DIFF} --unchanged-line-format="" \
--old-line-format="" \
--new-line-format="%dn " \
"${tmp}.branch" \
"${tmp}.patch" > "${tmp}.lined"
# now, pull out those lines of the raw output
# shellcheck disable=SC2013
for j in $(cat "${tmp}.lined"); do
head -"${j}" "${new}" | tail -1
done
rm "${tmp}.branch" "${tmp}.patch" "${tmp}.lined" 2>/dev/null
}
{code}
Is it possible to customize these two functions? Maybe just add a sort on the
output...
> False positive for error prone warnings in pre commit job
> -
>
> Key: HBASE-22100
> URL: https://issues.apache.org/jira/browse/HBASE-22100
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Duo Zhang
>Priority: Major
>
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/branch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> {noformat}
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/patch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> And the output is 1 new and 1 fixed, the new one is
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> I think here we should report nothing, as it is just an order change...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22100) False positive for error prone warnings in pre commit job
[
https://issues.apache.org/jira/browse/HBASE-22100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16800894#comment-16800894
]
Sean Busbey commented on HBASE-22100:
-
fyi, I think I went over how to change the diff parsing in HBASE-21895.
> False positive for error prone warnings in pre commit job
> -
>
> Key: HBASE-22100
> URL: https://issues.apache.org/jira/browse/HBASE-22100
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Duo Zhang
>Priority: Major
>
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/branch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> {noformat}
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/patch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> And the output is 1 new and 1 fixed, the new one is
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> I think here we should report nothing, as it is just an order change...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22100) False positive for error prone warnings in pre commit job
[
https://issues.apache.org/jira/browse/HBASE-22100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16800892#comment-16800892
]
Sean Busbey commented on HBASE-22100:
-
If you think this is a thing we can fix by updating the default javac output
diff set up in yetus, then yeah a yetus jira makes sense.
Personally, I'd try to fix this in our personality first by customizing how the
javac output is diffed specifically for our build. Knowing what the fix looks
like should make it more obvious if this is a problem with how we do things or
a general weakness in yetus's default plugin.
> False positive for error prone warnings in pre commit job
> -
>
> Key: HBASE-22100
> URL: https://issues.apache.org/jira/browse/HBASE-22100
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Duo Zhang
>Priority: Major
>
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/branch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> {noformat}
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/patch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> And the output is 1 new and 1 fixed, the new one is
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> I think here we should report nothing, as it is just an order change...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22100) False positive for error prone warnings in pre commit job
[
https://issues.apache.org/jira/browse/HBASE-22100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16800032#comment-16800032
]
Duo Zhang commented on HBASE-22100:
---
[~busbey] I checked the hbase-personality.sh, it seems that the compile output
is generated by yetus by default? So how should we fix this problem? File an
issue for yetus?
Thanks.
> False positive for error prone warnings in pre commit job
> -
>
> Key: HBASE-22100
> URL: https://issues.apache.org/jira/browse/HBASE-22100
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Duo Zhang
>Priority: Major
>
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/branch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> {noformat}
> https://builds.apache.org/job/PreCommit-HBASE-Build/16516/artifact/patchprocess/patch-compile-javac-hbase-client.txt
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,42]
> [UnusedVariable] The parameter 'error' is never read.
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> And the output is 1 new and 1 fixed, the new one is
> {noformat}
> [WARNING]
> /testptch/hbase/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRpcRetryingCaller.java:[125,69]
> [UnusedVariable] The parameter 'updateCachedLocation' is never read.
> {noformat}
> I think here we should report nothing, as it is just an order change...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
