[jira] [Commented] (HBASE-22561) modify HFilePrettyPrinter to accept non-hbase.rootdir directories
[
https://issues.apache.org/jira/browse/HBASE-22561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163371#comment-17163371
]
gurmukh singh commented on HBASE-22561:
---
Thanks [~wchevreuil] , I am on 2.1.0. Will upgrade in the coming nothing.
> modify HFilePrettyPrinter to accept non-hbase.rootdir directories
> -
>
> Key: HBASE-22561
> URL: https://issues.apache.org/jira/browse/HBASE-22561
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0-alpha-1, 2.2.0, 2.3.0, 2.1.5
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: HBASE-22561.v06.patch, HBASE-22561.v07.patch,
> HBASE-22561.v11.patch, HBASE-22561.v12.patch, non_root_dir.png, root_dir.png
>
>
> Today {{hbase hfile}} utility accepts only _hbase.rootDir_ directory. It is
> more useful to pass other locations with HFile as well.
> {code:java}
> hbase org.apache.hadoop.hbase.io.hfile.HFilePrettyPrinter hfileoutput
> ...
> ERROR, file (hfileoutput) is not in HBase's root directory
> (hdfs://hadoop.example.com:9000/apps/hbase/)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-22561) modify HFilePrettyPrinter to accept non-hbase.rootdir directories
[
https://issues.apache.org/jira/browse/HBASE-22561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159851#comment-17159851
]
Wellington Chevreuil commented on HBASE-22561:
--
{quote}see that hbase-1.2 is looking for a different hbase.rootdir despite
configured as /hbase{quote}
As pointed out on "fix versions", this patch was never applied to any base 1
branches.
{quote}Same for hbase 2.1{quote}
Which specific minor version of 2.1? This fix is present from 2.1.6 onwards
only.
> modify HFilePrettyPrinter to accept non-hbase.rootdir directories
> -
>
> Key: HBASE-22561
> URL: https://issues.apache.org/jira/browse/HBASE-22561
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0-alpha-1, 2.2.0, 2.3.0, 2.1.5
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: HBASE-22561.v06.patch, HBASE-22561.v07.patch,
> HBASE-22561.v11.patch, HBASE-22561.v12.patch, non_root_dir.png, root_dir.png
>
>
> Today {{hbase hfile}} utility accepts only _hbase.rootDir_ directory. It is
> more useful to pass other locations with HFile as well.
> {code:java}
> hbase org.apache.hadoop.hbase.io.hfile.HFilePrettyPrinter hfileoutput
> ...
> ERROR, file (hfileoutput) is not in HBase's root directory
> (hdfs://hadoop.example.com:9000/apps/hbase/)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-22561) modify HFilePrettyPrinter to accept non-hbase.rootdir directories
[
https://issues.apache.org/jira/browse/HBASE-22561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159842#comment-17159842
]
gurmukh singh commented on HBASE-22561:
---
Same for hbase 2.1
sudo -u hbase hbase org.apache.hadoop.hbase.io.hfile.HFile -s hbase
org.apache.hadoop.hbase.io.hfile.HFile -f
/hbase/data/default/class/73c16f8deb54c967a2b5f58e2f2370b2/cf/b647dfb79d5f45ebba0ca17ba9c07740
-m -v
20/07/17 10:06:56 WARN impl.MetricsConfig: Cannot locate configuration: tried
hadoop-metrics2-hbase.properties,hadoop-metrics2.properties
20/07/17 10:06:56 INFO impl.MetricsSystemImpl: Scheduled Metric snapshot period
at 10 second(s).
20/07/17 10:06:56 INFO impl.MetricsSystemImpl: HBase metrics system started
20/07/17 10:06:56 INFO metrics.MetricRegistries: Loaded MetricRegistries class
org.apache.hadoop.hbase.metrics.impl.MetricRegistriesImpl
Scanning ->
/hbase/data/default/class/73c16f8deb54c967a2b5f58e2f2370b2/cf/b647dfb79d5f45ebba0ca17ba9c07740
ERROR, file
(/hbase/data/default/class/73c16f8deb54c967a2b5f58e2f2370b2/cf/b647dfb79d5f45ebba0ca17ba9c07740)
is not in HBase's root directory
(hdfs://m1.aus.cloudera.site:8020/tmp/hbase-hbase/hbase/)
> modify HFilePrettyPrinter to accept non-hbase.rootdir directories
> -
>
> Key: HBASE-22561
> URL: https://issues.apache.org/jira/browse/HBASE-22561
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0-alpha-1, 2.2.0, 2.3.0, 2.1.5
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: HBASE-22561.v06.patch, HBASE-22561.v07.patch,
> HBASE-22561.v11.patch, HBASE-22561.v12.patch, non_root_dir.png, root_dir.png
>
>
> Today {{hbase hfile}} utility accepts only _hbase.rootDir_ directory. It is
> more useful to pass other locations with HFile as well.
> {code:java}
> hbase org.apache.hadoop.hbase.io.hfile.HFilePrettyPrinter hfileoutput
> ...
> ERROR, file (hfileoutput) is not in HBase's root directory
> (hdfs://hadoop.example.com:9000/apps/hbase/)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-22561) modify HFilePrettyPrinter to accept non-hbase.rootdir directories
[
https://issues.apache.org/jira/browse/HBASE-22561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159792#comment-17159792
]
gurmukh singh commented on HBASE-22561:
---
see that hbase-1.2 is looking of a different hbase.rootdir despite configured
as /hbase
[hdfs@cm ~]$ hbase org.apache.hadoop.hbase.io.hfile.HFile -f
hdfs://m1.aus.cloudera.site:8020/hbase/data/default/class/df1cb243981d6d3d7c87538efd645baa/cf/12ca2549ec614460b034739a6063c3e7
-m -v
2020-07-17 09:04:25,456 INFO [main] Configuration.deprecation:
hadoop.native.lib is deprecated. Instead, use io.native.lib.available
2020-07-17 09:04:26,542 INFO [main] Configuration.deprecation: fs.default.name
is deprecated. Instead, use fs.defaultFS
Scanning ->
hdfs://m1.example.site:8020/hbase/data/default/class/df1cb243981d6d3d7c87538efd645baa/cf/12ca2549ec614460b034739a6063c3e7
ERROR, file
(hdfs://m1.example.site:8020/hbase/data/default/class/df1cb243981d6d3d7c87538efd645baa/cf/12ca2549ec614460b034739a6063c3e7)
is not in HBase's root directory
(hdfs://m1.example.site:8020/tmp/hbase-hdfs/hbase/)
$ hbase version
HBase 1.2.0-cdh5.16.2
Source code repository
file:///data/jenkins/workspace/generic-package-centos64-7-0/topdir/BUILD/hbase-1.2.0-cdh5.16.2
revision=Unknown
Compiled by jenkins on Mon Jun 3 03:50:03 PDT 2019
>From source with checksum 612ba4e905fe89f5a8d8a9fa74843ef5
The hbase cluster is working fine, only while invoking the Hfile reader, it is
looking for a path not set as root.
hdfs://m1.example.site:8020/tmp/hbase-hdfs/hbase/
> modify HFilePrettyPrinter to accept non-hbase.rootdir directories
> -
>
> Key: HBASE-22561
> URL: https://issues.apache.org/jira/browse/HBASE-22561
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0-alpha-1, 2.2.0, 2.3.0, 2.1.5
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: HBASE-22561.v06.patch, HBASE-22561.v07.patch,
> HBASE-22561.v11.patch, HBASE-22561.v12.patch, non_root_dir.png, root_dir.png
>
>
> Today {{hbase hfile}} utility accepts only _hbase.rootDir_ directory. It is
> more useful to pass other locations with HFile as well.
> {code:java}
> hbase org.apache.hadoop.hbase.io.hfile.HFilePrettyPrinter hfileoutput
> ...
> ERROR, file (hfileoutput) is not in HBase's root directory
> (hdfs://hadoop.example.com:9000/apps/hbase/)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-22561) modify HFilePrettyPrinter to accept non-hbase.rootdir directories
[
https://issues.apache.org/jira/browse/HBASE-22561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16867752#comment-16867752
]
Hudson commented on HBASE-22561:
Results for branch branch-2.2
[build #376 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/376/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/376//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/376//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/376//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> modify HFilePrettyPrinter to accept non-hbase.rootdir directories
> -
>
> Key: HBASE-22561
> URL: https://issues.apache.org/jira/browse/HBASE-22561
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.2.0, 2.3.0, 2.1.5
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: HBASE-22561.v06.patch, HBASE-22561.v07.patch,
> HBASE-22561.v11.patch, HBASE-22561.v12.patch, non_root_dir.png, root_dir.png
>
>
> Today {{hbase hfile}} utility accepts only _hbase.rootDir_ directory. It is
> more useful to pass other locations with HFile as well.
> {code:java}
> hbase org.apache.hadoop.hbase.io.hfile.HFilePrettyPrinter hfileoutput
> ...
> ERROR, file (hfileoutput) is not in HBase's root directory
> (hdfs://hadoop.example.com:9000/apps/hbase/)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22561) modify HFilePrettyPrinter to accept non-hbase.rootdir directories
[
https://issues.apache.org/jira/browse/HBASE-22561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16867729#comment-16867729
]
Hudson commented on HBASE-22561:
Results for branch branch-2
[build #2008 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2008/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2008//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2008//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2008//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> modify HFilePrettyPrinter to accept non-hbase.rootdir directories
> -
>
> Key: HBASE-22561
> URL: https://issues.apache.org/jira/browse/HBASE-22561
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.2.0, 2.3.0, 2.1.5
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: HBASE-22561.v06.patch, HBASE-22561.v07.patch,
> HBASE-22561.v11.patch, HBASE-22561.v12.patch, non_root_dir.png, root_dir.png
>
>
> Today {{hbase hfile}} utility accepts only _hbase.rootDir_ directory. It is
> more useful to pass other locations with HFile as well.
> {code:java}
> hbase org.apache.hadoop.hbase.io.hfile.HFilePrettyPrinter hfileoutput
> ...
> ERROR, file (hfileoutput) is not in HBase's root directory
> (hdfs://hadoop.example.com:9000/apps/hbase/)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22561) modify HFilePrettyPrinter to accept non-hbase.rootdir directories
[
https://issues.apache.org/jira/browse/HBASE-22561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16867627#comment-16867627
]
Hudson commented on HBASE-22561:
Results for branch master
[build #1155 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1155/]: (/)
*{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1155//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1155//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1155//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> modify HFilePrettyPrinter to accept non-hbase.rootdir directories
> -
>
> Key: HBASE-22561
> URL: https://issues.apache.org/jira/browse/HBASE-22561
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.2.0, 2.3.0, 2.1.5
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: HBASE-22561.v06.patch, HBASE-22561.v07.patch,
> HBASE-22561.v11.patch, HBASE-22561.v12.patch, non_root_dir.png, root_dir.png
>
>
> Today {{hbase hfile}} utility accepts only _hbase.rootDir_ directory. It is
> more useful to pass other locations with HFile as well.
> {code:java}
> hbase org.apache.hadoop.hbase.io.hfile.HFilePrettyPrinter hfileoutput
> ...
> ERROR, file (hfileoutput) is not in HBase's root directory
> (hdfs://hadoop.example.com:9000/apps/hbase/)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22561) modify HFilePrettyPrinter to accept non-hbase.rootdir directories
[
https://issues.apache.org/jira/browse/HBASE-22561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16867588#comment-16867588
]
Hudson commented on HBASE-22561:
Results for branch branch-2.1
[build #1283 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1283/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1283//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1283//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1283//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> modify HFilePrettyPrinter to accept non-hbase.rootdir directories
> -
>
> Key: HBASE-22561
> URL: https://issues.apache.org/jira/browse/HBASE-22561
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.2.0, 2.3.0, 2.1.5
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: HBASE-22561.v06.patch, HBASE-22561.v07.patch,
> HBASE-22561.v11.patch, HBASE-22561.v12.patch, non_root_dir.png, root_dir.png
>
>
> Today {{hbase hfile}} utility accepts only _hbase.rootDir_ directory. It is
> more useful to pass other locations with HFile as well.
> {code:java}
> hbase org.apache.hadoop.hbase.io.hfile.HFilePrettyPrinter hfileoutput
> ...
> ERROR, file (hfileoutput) is not in HBase's root directory
> (hdfs://hadoop.example.com:9000/apps/hbase/)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22561) modify HFilePrettyPrinter to accept non-hbase.rootdir directories
[
https://issues.apache.org/jira/browse/HBASE-22561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16867503#comment-16867503
]
Hudson commented on HBASE-22561:
Results for branch branch-2.0
[build #1684 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1684/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1684//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1684//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1684//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> modify HFilePrettyPrinter to accept non-hbase.rootdir directories
> -
>
> Key: HBASE-22561
> URL: https://issues.apache.org/jira/browse/HBASE-22561
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.2.0, 2.3.0, 2.1.5
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: HBASE-22561.v06.patch, HBASE-22561.v07.patch,
> HBASE-22561.v11.patch, HBASE-22561.v12.patch, non_root_dir.png, root_dir.png
>
>
> Today {{hbase hfile}} utility accepts only _hbase.rootDir_ directory. It is
> more useful to pass other locations with HFile as well.
> {code:java}
> hbase org.apache.hadoop.hbase.io.hfile.HFilePrettyPrinter hfileoutput
> ...
> ERROR, file (hfileoutput) is not in HBase's root directory
> (hdfs://hadoop.example.com:9000/apps/hbase/)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22561) modify HFilePrettyPrinter to accept non-hbase.rootdir directories
[
https://issues.apache.org/jira/browse/HBASE-22561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16867309#comment-16867309
]
Zheng Hu commented on HBASE-22561:
--
Pushed to all branches, Thanks [~dbist13] for contributing.
> modify HFilePrettyPrinter to accept non-hbase.rootdir directories
> -
>
> Key: HBASE-22561
> URL: https://issues.apache.org/jira/browse/HBASE-22561
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.2.0, 2.3.0, 2.1.5
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6
>
> Attachments: HBASE-22561.v06.patch, HBASE-22561.v07.patch,
> HBASE-22561.v11.patch, HBASE-22561.v12.patch, non_root_dir.png, root_dir.png
>
>
> Today {{hbase hfile}} utility accepts only _hbase.rootDir_ directory. It is
> more useful to pass other locations with HFile as well.
> {code:java}
> hbase org.apache.hadoop.hbase.io.hfile.HFilePrettyPrinter hfileoutput
> ...
> ERROR, file (hfileoutput) is not in HBase's root directory
> (hdfs://hadoop.example.com:9000/apps/hbase/)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22561) modify HFilePrettyPrinter to accept non-hbase.rootdir directories
[
https://issues.apache.org/jira/browse/HBASE-22561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16867267#comment-16867267
]
Zheng Hu commented on HBASE-22561:
--
Patch.v12 looks good to me now, +1. Let me commit ( will fix the checksytle )
, Thanks.
> modify HFilePrettyPrinter to accept non-hbase.rootdir directories
> -
>
> Key: HBASE-22561
> URL: https://issues.apache.org/jira/browse/HBASE-22561
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.2.0, 2.3.0, 2.1.5
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
> Attachments: HBASE-22561.v06.patch, HBASE-22561.v07.patch,
> HBASE-22561.v11.patch, HBASE-22561.v12.patch, non_root_dir.png, root_dir.png
>
>
> Today {{hbase hfile}} utility accepts only _hbase.rootDir_ directory. It is
> more useful to pass other locations with HFile as well.
> {code:java}
> hbase org.apache.hadoop.hbase.io.hfile.HFilePrettyPrinter hfileoutput
> ...
> ERROR, file (hfileoutput) is not in HBase's root directory
> (hdfs://hadoop.example.com:9000/apps/hbase/)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22561) modify HFilePrettyPrinter to accept non-hbase.rootdir directories
[
https://issues.apache.org/jira/browse/HBASE-22561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16867010#comment-16867010
]
HBase QA commented on HBASE-22561:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
13s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
35s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
14s{color} | {color:red} hbase-server: The patch generated 1 new + 13 unchanged
- 1 fixed = 14 total (was 14) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
37s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
13m 2s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}215m
45s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
24s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}266m 23s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HBASE-Build/552/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22561 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12972111/HBASE-22561.v12.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 77abaab6a97c 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb
13 15:00:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / ac3d09e7fd |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/552/artifact/patchprocess/diff-checkstyle-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/552/testReport/ |
| Max. process+thread count | 4917 (vs. ulimit of 1) |
| modules | C: hbase-server U: hbase-server |
| Console output |
[jira] [Commented] (HBASE-22561) modify HFilePrettyPrinter to accept non-hbase.rootdir directories
[
https://issues.apache.org/jira/browse/HBASE-22561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866778#comment-16866778
]
Artem Ervits commented on HBASE-22561:
--
I'll work on PRs going forward, I attached .v12 for your review, thanks
[~openinx].
> modify HFilePrettyPrinter to accept non-hbase.rootdir directories
> -
>
> Key: HBASE-22561
> URL: https://issues.apache.org/jira/browse/HBASE-22561
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.2.0, 2.3.0, 2.1.5
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
> Attachments: HBASE-22561.v06.patch, HBASE-22561.v07.patch,
> HBASE-22561.v11.patch, HBASE-22561.v12.patch, non_root_dir.png, root_dir.png
>
>
> Today {{hbase hfile}} utility accepts only _hbase.rootDir_ directory. It is
> more useful to pass other locations with HFile as well.
> {code:java}
> hbase org.apache.hadoop.hbase.io.hfile.HFilePrettyPrinter hfileoutput
> ...
> ERROR, file (hfileoutput) is not in HBase's root directory
> (hdfs://hadoop.example.com:9000/apps/hbase/)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22561) modify HFilePrettyPrinter to accept non-hbase.rootdir directories
[
https://issues.apache.org/jira/browse/HBASE-22561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866137#comment-16866137
]
Zheng Hu commented on HBASE-22561:
--
For HFilePrettyPrinter, seems no need to add the -u option, also the webUI no
need the -u option ?
{code}
+options.addOption("u", "checkRootDir", false,
+"optional check for rootDir in case of webUI mode");
{code}
I mean, would we just call the processFile(file, false）for shell and
processFile(file, true) for webUI without adding any new command option ?
BTW, will be very gratefull if create a github PR for reviewing :-)
> modify HFilePrettyPrinter to accept non-hbase.rootdir directories
> -
>
> Key: HBASE-22561
> URL: https://issues.apache.org/jira/browse/HBASE-22561
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.2.0, 2.3.0, 2.1.5
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
> Attachments: HBASE-22561.v06.patch, HBASE-22561.v07.patch,
> HBASE-22561.v11.patch, non_root_dir.png, root_dir.png
>
>
> Today {{hbase hfile}} utility accepts only _hbase.rootDir_ directory. It is
> more useful to pass other locations with HFile as well.
> {code:java}
> hbase org.apache.hadoop.hbase.io.hfile.HFilePrettyPrinter hfileoutput
> ...
> ERROR, file (hfileoutput) is not in HBase's root directory
> (hdfs://hadoop.example.com:9000/apps/hbase/)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22561) modify HFilePrettyPrinter to accept non-hbase.rootdir directories
[
https://issues.apache.org/jira/browse/HBASE-22561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866099#comment-16866099
]
HBase QA commented on HBASE-22561:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
23s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
33s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
29s{color} | {color:red} hbase-server: The patch generated 1 new + 13 unchanged
- 1 fixed = 14 total (was 14) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
36s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
13m 9s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}151m
20s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
27s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}205m 14s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HBASE-Build/550/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22561 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12972013/HBASE-22561.v11.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 57c5930f8f5c 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb
13 15:00:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 5da5deb59d |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/550/artifact/patchprocess/diff-checkstyle-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/550/testReport/ |
| Max. process+thread count | 5175 (vs. ulimit of 1) |
| modules | C: hbase-server U: hbase-server |
| Console output |
[jira] [Commented] (HBASE-22561) modify HFilePrettyPrinter to accept non-hbase.rootdir directories
[
https://issues.apache.org/jira/browse/HBASE-22561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865950#comment-16865950
]
Artem Ervits commented on HBASE-22561:
--
[~openinx] added patch .v11 to address your comments. I was trying to add a
test case for not having a rootdir path and passing _-u_ flag to check for
rootdir but I can't get to grep the error to compare against. Let me know if
that's a valuable test? Thanks
> modify HFilePrettyPrinter to accept non-hbase.rootdir directories
> -
>
> Key: HBASE-22561
> URL: https://issues.apache.org/jira/browse/HBASE-22561
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.2.0, 2.3.0, 2.1.5
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
> Attachments: HBASE-22561.v06.patch, HBASE-22561.v07.patch,
> HBASE-22561.v11.patch, non_root_dir.png, root_dir.png
>
>
> Today {{hbase hfile}} utility accepts only _hbase.rootDir_ directory. It is
> more useful to pass other locations with HFile as well.
> {code:java}
> hbase org.apache.hadoop.hbase.io.hfile.HFilePrettyPrinter hfileoutput
> ...
> ERROR, file (hfileoutput) is not in HBase's root directory
> (hdfs://hadoop.example.com:9000/apps/hbase/)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22561) modify HFilePrettyPrinter to accept non-hbase.rootdir directories
[
https://issues.apache.org/jira/browse/HBASE-22561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865391#comment-16865391
]
Zheng Hu commented on HBASE-22561:
--
The patch.v7 Looks good to me now. It may be better if moving the sanity
check to processFile method, and provide a flag argument , such as:
{code}
public int processFile(Path file, boolean checkRootDir) throws IOException
{code}
For the shell, use the processFile(file, false), for the JSP use the
processFile(file, true), Then we can have a ut to cover the web UI path also.
Anyway, It's good enough to commit now, just a suggestion.
> modify HFilePrettyPrinter to accept non-hbase.rootdir directories
> -
>
> Key: HBASE-22561
> URL: https://issues.apache.org/jira/browse/HBASE-22561
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.2.0, 2.3.0, 2.1.5
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
> Attachments: HBASE-22561.v06.patch, HBASE-22561.v07.patch,
> non_root_dir.png, root_dir.png
>
>
> Today {{hbase hfile}} utility accepts only _hbase.rootDir_ directory. It is
> more useful to pass other locations with HFile as well.
> {code:java}
> hbase org.apache.hadoop.hbase.io.hfile.HFilePrettyPrinter hfileoutput
> ...
> ERROR, file (hfileoutput) is not in HBase's root directory
> (hdfs://hadoop.example.com:9000/apps/hbase/)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22561) modify HFilePrettyPrinter to accept non-hbase.rootdir directories
[
https://issues.apache.org/jira/browse/HBASE-22561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864434#comment-16864434
]
Artem Ervits commented on HBASE-22561:
--
[~openinx] spoke with [~elserj] and tend to agree that check for rootDir needs
to happen in the jsp not in the utility. Moved that code block to
storeFile.jsp, attaching images for validation. I will work on a test case for
the webpage and attaching .v07 patch for posterity as well as anything I've
missed.
> modify HFilePrettyPrinter to accept non-hbase.rootdir directories
> -
>
> Key: HBASE-22561
> URL: https://issues.apache.org/jira/browse/HBASE-22561
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.2.0, 2.3.0, 2.1.5
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
> Attachments: HBASE-22561.v06.patch, HBASE-22561.v07.patch
>
>
> Today {{hbase hfile}} utility accepts only _hbase.rootDir_ directory. It is
> more useful to pass other locations with HFile as well.
> {code:java}
> hbase org.apache.hadoop.hbase.io.hfile.HFilePrettyPrinter hfileoutput
> ...
> ERROR, file (hfileoutput) is not in HBase's root directory
> (hdfs://hadoop.example.com:9000/apps/hbase/)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22561) modify HFilePrettyPrinter to accept non-hbase.rootdir directories
[
https://issues.apache.org/jira/browse/HBASE-22561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864103#comment-16864103
]
Sean Mackrory commented on HBASE-22561:
---
I think you meant to tag [~busbey] instead of myself.
> modify HFilePrettyPrinter to accept non-hbase.rootdir directories
> -
>
> Key: HBASE-22561
> URL: https://issues.apache.org/jira/browse/HBASE-22561
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.2.0, 2.3.0, 2.1.5
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
> Attachments: HBASE-22561.v06.patch
>
>
> Today {{hbase hfile}} utility accepts only _hbase.rootDir_ directory. It is
> more useful to pass other locations with HFile as well.
> {code:java}
> hbase org.apache.hadoop.hbase.io.hfile.HFilePrettyPrinter hfileoutput
> ...
> ERROR, file (hfileoutput) is not in HBase's root directory
> (hdfs://hadoop.example.com:9000/apps/hbase/)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22561) modify HFilePrettyPrinter to accept non-hbase.rootdir directories
[
https://issues.apache.org/jira/browse/HBASE-22561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863987#comment-16863987
]
Zheng Hu commented on HBASE-22561:
--
FYI [~mackrorysd] & [~mantonov]
> modify HFilePrettyPrinter to accept non-hbase.rootdir directories
> -
>
> Key: HBASE-22561
> URL: https://issues.apache.org/jira/browse/HBASE-22561
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.2.0, 2.3.0, 2.1.5
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
> Attachments: HBASE-22561.v06.patch
>
>
> Today {{hbase hfile}} utility accepts only _hbase.rootDir_ directory. It is
> more useful to pass other locations with HFile as well.
> {code:java}
> hbase org.apache.hadoop.hbase.io.hfile.HFilePrettyPrinter hfileoutput
> ...
> ERROR, file (hfileoutput) is not in HBase's root directory
> (hdfs://hadoop.example.com:9000/apps/hbase/)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22561) modify HFilePrettyPrinter to accept non-hbase.rootdir directories
[
https://issues.apache.org/jira/browse/HBASE-22561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863980#comment-16863980
]
Zheng Hu commented on HBASE-22561:
--
Thanks for your patch, [~dbist13]. Seems the santiy check was added for
protecting the arbitrary injection from webUI in HBASE-15946, seems our webUI
need the sanity check while for shell, we can remove the santiy check ?
So we better to introduce a flag, if webUI then will do the sanity check,
while if shell then won't do the sanity check .
> modify HFilePrettyPrinter to accept non-hbase.rootdir directories
> -
>
> Key: HBASE-22561
> URL: https://issues.apache.org/jira/browse/HBASE-22561
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.2.0, 2.3.0, 2.1.5
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
> Attachments: HBASE-22561.v06.patch
>
>
> Today {{hbase hfile}} utility accepts only _hbase.rootDir_ directory. It is
> more useful to pass other locations with HFile as well.
> {code:java}
> hbase org.apache.hadoop.hbase.io.hfile.HFilePrettyPrinter hfileoutput
> ...
> ERROR, file (hfileoutput) is not in HBase's root directory
> (hdfs://hadoop.example.com:9000/apps/hbase/)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22561) modify HFilePrettyPrinter to accept non-hbase.rootdir directories
[
https://issues.apache.org/jira/browse/HBASE-22561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863682#comment-16863682
]
HBase QA commented on HBASE-22561:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
49s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
7s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
55s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
40s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
24s{color} | {color:red} hbase-server: The patch generated 2 new + 14 unchanged
- 0 fixed = 16 total (was 14) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
42s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
16m 53s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}294m 12s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
32s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}356m 43s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.client.TestSnapshotTemporaryDirectory |
| | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas |
| | hadoop.hbase.client.TestFromClientSideWithCoprocessor |
| | hadoop.hbase.client.TestFromClientSide |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HBASE-Build/536/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22561 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12971734/HBASE-22561.v06.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 54a239f8be91 4.4.0-143-generic #169-Ubuntu SMP Thu Feb 7
07:56:38 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 9ba7651889 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| checkstyle |
[jira] [Commented] (HBASE-22561) modify HFilePrettyPrinter to accept non-hbase.rootdir directories
[
https://issues.apache.org/jira/browse/HBASE-22561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862113#comment-16862113
]
Artem Ervits commented on HBASE-22561:
--
[~openinx] thank you for ping, I am working on this. Will ping for review.
> modify HFilePrettyPrinter to accept non-hbase.rootdir directories
> -
>
> Key: HBASE-22561
> URL: https://issues.apache.org/jira/browse/HBASE-22561
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.2.0, 2.3.0, 2.1.5
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
>
> Today {{hbase hfile}} utility accepts only _hbase.rootDir_ directory. It is
> more useful to pass other locations with HFile as well.
> {code:java}
> hbase org.apache.hadoop.hbase.io.hfile.HFilePrettyPrinter hfileoutput
> ...
> ERROR, file (hfileoutput) is not in HBase's root directory
> (hdfs://hadoop.example.com:9000/apps/hbase/)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22561) modify HFilePrettyPrinter to accept non-hbase.rootdir directories
[
https://issues.apache.org/jira/browse/HBASE-22561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861678#comment-16861678
]
Zheng Hu commented on HBASE-22561:
--
Mind you prepare a patch for this ? [~dbist13].
> modify HFilePrettyPrinter to accept non-hbase.rootdir directories
> -
>
> Key: HBASE-22561
> URL: https://issues.apache.org/jira/browse/HBASE-22561
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0, 2.2.0, 2.3.0, 2.1.5
>Reporter: Artem Ervits
>Assignee: Artem Ervits
>Priority: Minor
>
> Today {{hbase hfile}} utility accepts only _hbase.rootDir_ directory. It is
> more useful to pass other locations with HFile as well.
> {code:java}
> hbase org.apache.hadoop.hbase.io.hfile.HFilePrettyPrinter hfileoutput
> ...
> ERROR, file (hfileoutput) is not in HBase's root directory
> (hdfs://hadoop.example.com:9000/apps/hbase/)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
