[jira] [Commented] (HBASE-5070) Constraints implementation and javadoc changes
[ https://issues.apache.org/jira/browse/HBASE-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13175695#comment-13175695 ] Hadoop QA commented on HBASE-5070: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12508587/java_HBASE-5070-v3.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 javadoc. The javadoc tool appears to have generated -152 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 77 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.wal.TestLogRolling org.apache.hadoop.hbase.replication.TestReplication org.apache.hadoop.hbase.mapred.TestTableMapReduce org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/593//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/593//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/593//console This message is automatically generated. Constraints implementation and javadoc changes -- Key: HBASE-5070 URL: https://issues.apache.org/jira/browse/HBASE-5070 Project: HBase Issue Type: Task Reporter: Zhihong Yu Attachments: java_HBASE-5070-v2.patch, java_HBASE-5070-v3.patch This is continuation of HBASE-4605 See Stack's comments https://reviews.apache.org/r/2579/#review3980 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5070) Constraints implementation and javadoc changes
[ https://issues.apache.org/jira/browse/HBASE-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13175743#comment-13175743 ] Zhihong Yu commented on HBASE-5070: --- @Jesse: Are you Okay with the changes I proposed @ 23/Dec/11 19:21 ? If so, I can apply them at time of integration. Otherwise please upload a new patch. Thanks Constraints implementation and javadoc changes -- Key: HBASE-5070 URL: https://issues.apache.org/jira/browse/HBASE-5070 Project: HBase Issue Type: Task Reporter: Zhihong Yu Attachments: java_HBASE-5070-v2.patch, java_HBASE-5070-v3.patch This is continuation of HBASE-4605 See Stack's comments https://reviews.apache.org/r/2579/#review3980 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5070) Constraints implementation and javadoc changes
[ https://issues.apache.org/jira/browse/HBASE-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13175755#comment-13175755 ] Jesse Yates commented on HBASE-5070: Yeah, those changes are fine - I totally missed that email otherwise would have rolled them in myself. Thanks for doing the update! Constraints implementation and javadoc changes -- Key: HBASE-5070 URL: https://issues.apache.org/jira/browse/HBASE-5070 Project: HBase Issue Type: Task Reporter: Zhihong Yu Attachments: java_HBASE-5070-v2.patch, java_HBASE-5070-v3.patch This is continuation of HBASE-4605 See Stack's comments https://reviews.apache.org/r/2579/#review3980 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5070) Constraints implementation and javadoc changes
[ https://issues.apache.org/jira/browse/HBASE-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13175773#comment-13175773 ] Zhihong Yu commented on HBASE-5070: --- Integrated to TRUNK. Thanks for the patch Jesse. Thanks for the review Michael. Constraints implementation and javadoc changes -- Key: HBASE-5070 URL: https://issues.apache.org/jira/browse/HBASE-5070 Project: HBase Issue Type: Task Reporter: Zhihong Yu Assignee: Jesse Yates Attachments: java_HBASE-5070-v2.patch, java_HBASE-5070-v3.patch This is continuation of HBASE-4605 See Stack's comments https://reviews.apache.org/r/2579/#review3980 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5070) Constraints implementation and javadoc changes
[ https://issues.apache.org/jira/browse/HBASE-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13175785#comment-13175785 ] Hudson commented on HBASE-5070: --- Integrated in HBase-TRUNK #2574 (See [https://builds.apache.org/job/HBase-TRUNK/2574/]) HBASE-5070 Constraints implementation and javadoc changes (Jesse Yates) tedyu : Files : * /hbase/trunk/src/docbkx/book.xml * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/constraint/BaseConstraint.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/constraint/Constraint.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/constraint/Constraints.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/constraint/package-info.java * /hbase/trunk/src/test/java/org/apache/hadoop/hbase/constraint/CheckConfigurationConstraint.java Constraints implementation and javadoc changes -- Key: HBASE-5070 URL: https://issues.apache.org/jira/browse/HBASE-5070 Project: HBase Issue Type: Task Reporter: Zhihong Yu Assignee: Jesse Yates Attachments: java_HBASE-5070-v2.patch, java_HBASE-5070-v3.patch This is continuation of HBASE-4605 See Stack's comments https://reviews.apache.org/r/2579/#review3980 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5070) Constraints implementation and javadoc changes
[ https://issues.apache.org/jira/browse/HBASE-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13175795#comment-13175795 ] Hudson commented on HBASE-5070: --- Integrated in HBase-TRUNK-security #47 (See [https://builds.apache.org/job/HBase-TRUNK-security/47/]) HBASE-5070 Constraints implementation and javadoc changes (Jesse Yates) tedyu : Files : * /hbase/trunk/src/docbkx/book.xml * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/constraint/BaseConstraint.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/constraint/Constraint.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/constraint/Constraints.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/constraint/package-info.java * /hbase/trunk/src/test/java/org/apache/hadoop/hbase/constraint/CheckConfigurationConstraint.java Constraints implementation and javadoc changes -- Key: HBASE-5070 URL: https://issues.apache.org/jira/browse/HBASE-5070 Project: HBase Issue Type: Task Reporter: Zhihong Yu Assignee: Jesse Yates Attachments: java_HBASE-5070-v2.patch, java_HBASE-5070-v3.patch This is continuation of HBASE-4605 See Stack's comments https://reviews.apache.org/r/2579/#review3980 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5070) Constraints implementation and javadoc changes
[ https://issues.apache.org/jira/browse/HBASE-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13175547#comment-13175547 ] Hadoop QA commented on HBASE-5070: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12508560/java_HBASE-5070-v2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/590//console This message is automatically generated. Constraints implementation and javadoc changes -- Key: HBASE-5070 URL: https://issues.apache.org/jira/browse/HBASE-5070 Project: HBase Issue Type: Task Reporter: Zhihong Yu Attachments: java_HBASE-5070-v2.patch This is continuation of HBASE-4605 See Stack's comments https://reviews.apache.org/r/2579/#review3980 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5070) Constraints implementation and javadoc changes
[ https://issues.apache.org/jira/browse/HBASE-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13175016#comment-13175016 ] jirapos...@reviews.apache.org commented on HBASE-5070: -- --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3273/ --- (Updated 2011-12-22 19:59:47.762581) Review request for hbase, Gary Helmling, Ted Yu, and Michael Stack. Changes --- Fixing documentation as per comments. Remaining concerns: 1) handling configuration storage in HTD (seems ok, but see comments on stack's comments on previous patch) 2) Configured has a default constructor which does setConf(null). Do we want to enforce this behavior? Or just let it be null? Or create our own BaseConfigured class that extends from Configurable? Summary --- Follow-up on changes to constraint as per stack's comments on HBASE-4605. This addresses bug HBASE-5070. https://issues.apache.org/jira/browse/HBASE-5070 Diffs (updated) - src/main/java/org/apache/hadoop/hbase/constraint/BaseConstraint.java 7ce6d45 src/main/java/org/apache/hadoop/hbase/constraint/Constraint.java 2d8b4d7 src/main/java/org/apache/hadoop/hbase/constraint/Constraints.java 7825466 src/docbkx/book.xml bd3f881 src/main/java/org/apache/hadoop/hbase/constraint/package-info.java 6145ed5 src/test/java/org/apache/hadoop/hbase/constraint/CheckConfigurationConstraint.java c49098d Diff: https://reviews.apache.org/r/3273/diff Testing --- mvn clean test -P localTests -Dest=*Constraint* - all tests pass. Thanks, Jesse Constraints implementation and javadoc changes -- Key: HBASE-5070 URL: https://issues.apache.org/jira/browse/HBASE-5070 Project: HBase Issue Type: Task Reporter: Zhihong Yu This is continuation of HBASE-4605 See Stack's comments https://reviews.apache.org/r/2579/#review3980 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5070) Constraints implementation and javadoc changes
[ https://issues.apache.org/jira/browse/HBASE-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13175024#comment-13175024 ] Zhihong Yu commented on HBASE-5070: --- For concern #1, how about creating helper method to remove entries from Configuration which have same values as those in hbase-default.xml ? This should be done in another JIRA. Constraints implementation and javadoc changes -- Key: HBASE-5070 URL: https://issues.apache.org/jira/browse/HBASE-5070 Project: HBase Issue Type: Task Reporter: Zhihong Yu This is continuation of HBASE-4605 See Stack's comments https://reviews.apache.org/r/2579/#review3980 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5070) Constraints implementation and javadoc changes
[ https://issues.apache.org/jira/browse/HBASE-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13175032#comment-13175032 ] Jesse Yates commented on HBASE-5070: bq. For concern #1, how about creating helper method to remove entries from Configuration which have same values as those in hbase-default.xml ? I think that is a little bit overkill - what if you happen to want those just a couple of those values? Creating a starting configuration feels cleaner than a remove util. Why not just add the commenting in that you should use new Configuration(false) to avoid adding a ton of values? (I know, I'm kinda flip-flopping here, but trying to reason out the best soln.) Constraints implementation and javadoc changes -- Key: HBASE-5070 URL: https://issues.apache.org/jira/browse/HBASE-5070 Project: HBase Issue Type: Task Reporter: Zhihong Yu This is continuation of HBASE-4605 See Stack's comments https://reviews.apache.org/r/2579/#review3980 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5070) Constraints implementation and javadoc changes
[ https://issues.apache.org/jira/browse/HBASE-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13174339#comment-13174339 ] jirapos...@reviews.apache.org commented on HBASE-5070: -- bq. On 2011-12-21 06:09:56, Michael Stack wrote: bq. This patch should go in. Good improvements. Doesn't address the bigger issues of Configuration inline w/ HTD -- have you tried it, I mean, IIRC, though you might have one custom config only, the whole Configuration will be output per Constraint? -- and adding support to shell. Those are in different issues? I'm going to try checking out the conf stuff for the Constraints today in the shell. Keep in mind that the conf stored per Constraint should just be configuration info for the Constraint, as opposed to the entire hbase conf (so we don't see all the values from hbase-site.xml, etc), but by default only see the enabled and priority configuration values. I'm expecting that to be pretty small, but I'll let you know. Also, there is HBASE-4879 to add shell support to Constraints as the original was already pretty massive (and taking a while) and the shell stuff could be cleanly separated out. I was working on it, but have temporarily diverted from it to work on the maven modularization (4336) as per Ted's request. - Jesse --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3273/#review4034 --- On 2011-12-20 19:14:46, Jesse Yates wrote: bq. bq. --- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/3273/ bq. --- bq. bq. (Updated 2011-12-20 19:14:46) bq. bq. bq. Review request for hbase, Gary Helmling, Ted Yu, and Michael Stack. bq. bq. bq. Summary bq. --- bq. bq. Follow-up on changes to constraint as per stack's comments on HBASE-4605. bq. bq. bq. This addresses bug HBASE-5070. bq. https://issues.apache.org/jira/browse/HBASE-5070 bq. bq. bq. Diffs bq. - bq. bq.src/docbkx/book.xml bd3f881 bq.src/main/java/org/apache/hadoop/hbase/constraint/BaseConstraint.java 7ce6d45 bq.src/main/java/org/apache/hadoop/hbase/constraint/Constraint.java 2d8b4d7 bq.src/main/java/org/apache/hadoop/hbase/constraint/Constraints.java 7825466 bq.src/main/java/org/apache/hadoop/hbase/constraint/package-info.java 6145ed5 bq. src/test/java/org/apache/hadoop/hbase/constraint/CheckConfigurationConstraint.java c49098d bq. bq. Diff: https://reviews.apache.org/r/3273/diff bq. bq. bq. Testing bq. --- bq. bq. mvn clean test -P localTests -Dest=*Constraint* - all tests pass. bq. bq. bq. Thanks, bq. bq. Jesse bq. bq. Constraints implementation and javadoc changes -- Key: HBASE-5070 URL: https://issues.apache.org/jira/browse/HBASE-5070 Project: HBase Issue Type: Task Reporter: Zhihong Yu This is continuation of HBASE-4605 See Stack's comments https://reviews.apache.org/r/2579/#review3980 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5070) Constraints implementation and javadoc changes
[
https://issues.apache.org/jira/browse/HBASE-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13174648#comment-13174648
]
jirapos...@reviews.apache.org commented on HBASE-5070:
--
bq. On 2011-12-21 06:09:56, Michael Stack wrote:
bq. This patch should go in. Good improvements. Doesn't address the bigger
issues of Configuration inline w/ HTD -- have you tried it, I mean, IIRC,
though you might have one custom config only, the whole Configuration will be
output per Constraint? -- and adding support to shell. Those are in different
issues?
bq.
bq. Jesse Yates wrote:
bq. I'm going to try checking out the conf stuff for the Constraints today
in the shell. Keep in mind that the conf stored per Constraint should just be
configuration info for the Constraint, as opposed to the entire hbase conf (so
we don't see all the values from hbase-site.xml, etc), but by default only see
the enabled and priority configuration values. I'm expecting that to be pretty
small, but I'll let you know.
bq.
bq. Also, there is HBASE-4879 to add shell support to Constraints as the
original was already pretty massive (and taking a while) and the shell stuff
could be cleanly separated out. I was working on it, but have temporarily
diverted from it to work on the maven modularization (4336) as per Ted's
request.
So looking at in the shell isn't all that bad, assuming people create their
configurations 'properly' - new Configuration(false) - and avoid loading the
default values into the configuration. If you forget to do that, describe is
going to be massive (10s of parameters scrolling by). However, I did a test
adding 3 random configuration values, and if you do it 'correctly', its just
looks like:
hbase(main):008:0 describe 'testTable'
DESCRIPTION
ENABLED
{NAME = 'testTable', constraint
$org.apache.hadoop.hbase.constraint.AllPassConstraint = '?xml version=1.0
encoding=UTF-8 s true
tandalone=no?configuration
propertynameanotherKey/namevalueanotherValue/value/property
propertyname_PRIORITY
/namevalue0/value/property
propertynamethird key/namevaluethirdvalue/value/property
propertyname_ENABLED
/namevaluetrue/value/property
propertynamesomeKey/namevaluesomeValue/value/property
/configuration', coproce
ssor$1 =
'|org.apache.hadoop.hbase.constraint.ConstraintProcessor|1073741823|',
hbase.constraint.counter = '1', FAMILIES = []}
1 row(s) in 0.0340 seconds
Not that bad, IMO. There are some problems with ENABLED overlapping with the
actual values, but that should be sorted when I get around to fixing the shell
(not just 4879, but as we talked about on dev@ and then nothing happened.).
The only question that I have is then, how do we want to make people use
configurations? I'm thinking:
1) add Constraints.baseConfiguration(){ return new Configuration(false)}
2) Add information in the javadocs that you should create an empty configuration
3) Both
I'm pertinent to just (2), to save on what is really extraneous coding. Only
problem with that is, if you don't realize what you are doing (and there are a
lot of docs to read), then you could easily forget that boolean and create a
ton of massive configurations. But rtfm, right?
We could also leverage (1) to make sure that all the configurations we use have
a base set of properties (for now that would just be enabled and priority) and
then tell people to pull the configuration from that static method.
Thoughts?
- Jesse
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3273/#review4034
---
On 2011-12-20 19:14:46, Jesse Yates wrote:
bq.
bq. ---
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3273/
bq. ---
bq.
bq. (Updated 2011-12-20 19:14:46)
bq.
bq.
bq. Review request for hbase, Gary Helmling, Ted Yu, and Michael Stack.
bq.
bq.
bq. Summary
bq. ---
bq.
bq. Follow-up on changes to constraint as per stack's comments on HBASE-4605.
bq.
bq.
bq. This addresses bug HBASE-5070.
bq. https://issues.apache.org/jira/browse/HBASE-5070
bq.
bq.
bq. Diffs
[jira] [Commented] (HBASE-5070) Constraints implementation and javadoc changes
[ https://issues.apache.org/jira/browse/HBASE-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13173439#comment-13173439 ] jirapos...@reviews.apache.org commented on HBASE-5070: -- --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3273/ --- Review request for hbase, Gary Helmling, Ted Yu, and Michael Stack. Summary --- Follow-up on changes to constraint as per stack's comments on HBASE-4605. This addresses bug HBASE-5070. https://issues.apache.org/jira/browse/HBASE-5070 Diffs - src/docbkx/book.xml bd3f881 src/main/java/org/apache/hadoop/hbase/constraint/BaseConstraint.java 7ce6d45 src/main/java/org/apache/hadoop/hbase/constraint/Constraint.java 2d8b4d7 src/main/java/org/apache/hadoop/hbase/constraint/Constraints.java 7825466 src/main/java/org/apache/hadoop/hbase/constraint/package-info.java 6145ed5 src/test/java/org/apache/hadoop/hbase/constraint/CheckConfigurationConstraint.java c49098d Diff: https://reviews.apache.org/r/3273/diff Testing --- mvn clean test -P localTests -Dest=*Constraint* - all tests pass. Thanks, Jesse Constraints implementation and javadoc changes -- Key: HBASE-5070 URL: https://issues.apache.org/jira/browse/HBASE-5070 Project: HBase Issue Type: Task Reporter: Zhihong Yu This is continuation of HBASE-4605 See Stack's comments https://reviews.apache.org/r/2579/#review3980 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5070) Constraints implementation and javadoc changes
[ https://issues.apache.org/jira/browse/HBASE-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13173466#comment-13173466 ] jirapos...@reviews.apache.org commented on HBASE-5070: -- --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3273/#review4022 --- src/docbkx/book.xml https://reviews.apache.org/r/3273/#comment9121 Should read 'checking is enabled' src/docbkx/book.xml https://reviews.apache.org/r/3273/#comment9122 When would the URL be active ? It is not available now. src/main/java/org/apache/hadoop/hbase/constraint/Constraint.java https://reviews.apache.org/r/3273/#comment9123 Whitespace should be removed. src/main/java/org/apache/hadoop/hbase/constraint/Constraints.java https://reviews.apache.org/r/3273/#comment9124 I think this should start with 'Constraint Class ' - Ted On 2011-12-20 19:14:46, Jesse Yates wrote: bq. bq. --- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/3273/ bq. --- bq. bq. (Updated 2011-12-20 19:14:46) bq. bq. bq. Review request for hbase, Gary Helmling, Ted Yu, and Michael Stack. bq. bq. bq. Summary bq. --- bq. bq. Follow-up on changes to constraint as per stack's comments on HBASE-4605. bq. bq. bq. This addresses bug HBASE-5070. bq. https://issues.apache.org/jira/browse/HBASE-5070 bq. bq. bq. Diffs bq. - bq. bq.src/docbkx/book.xml bd3f881 bq.src/main/java/org/apache/hadoop/hbase/constraint/BaseConstraint.java 7ce6d45 bq.src/main/java/org/apache/hadoop/hbase/constraint/Constraint.java 2d8b4d7 bq.src/main/java/org/apache/hadoop/hbase/constraint/Constraints.java 7825466 bq.src/main/java/org/apache/hadoop/hbase/constraint/package-info.java 6145ed5 bq. src/test/java/org/apache/hadoop/hbase/constraint/CheckConfigurationConstraint.java c49098d bq. bq. Diff: https://reviews.apache.org/r/3273/diff bq. bq. bq. Testing bq. --- bq. bq. mvn clean test -P localTests -Dest=*Constraint* - all tests pass. bq. bq. bq. Thanks, bq. bq. Jesse bq. bq. Constraints implementation and javadoc changes -- Key: HBASE-5070 URL: https://issues.apache.org/jira/browse/HBASE-5070 Project: HBase Issue Type: Task Reporter: Zhihong Yu This is continuation of HBASE-4605 See Stack's comments https://reviews.apache.org/r/2579/#review3980 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5070) Constraints implementation and javadoc changes
[ https://issues.apache.org/jira/browse/HBASE-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13173890#comment-13173890 ] jirapos...@reviews.apache.org commented on HBASE-5070: -- --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3273/#review4034 --- Ship it! This patch should go in. Good improvements. Doesn't address the bigger issues of Configuration inline w/ HTD -- have you tried it, I mean, IIRC, though you might have one custom config only, the whole Configuration will be output per Constraint? -- and adding support to shell. Those are in different issues? src/docbkx/book.xml https://reviews.apache.org/r/3273/#comment9139 Only thing missing is since 0.94 which is when constraints will show up. src/main/java/org/apache/hadoop/hbase/constraint/BaseConstraint.java https://reviews.apache.org/r/3273/#comment9140 Better - Michael On 2011-12-20 19:14:46, Jesse Yates wrote: bq. bq. --- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/3273/ bq. --- bq. bq. (Updated 2011-12-20 19:14:46) bq. bq. bq. Review request for hbase, Gary Helmling, Ted Yu, and Michael Stack. bq. bq. bq. Summary bq. --- bq. bq. Follow-up on changes to constraint as per stack's comments on HBASE-4605. bq. bq. bq. This addresses bug HBASE-5070. bq. https://issues.apache.org/jira/browse/HBASE-5070 bq. bq. bq. Diffs bq. - bq. bq.src/docbkx/book.xml bd3f881 bq.src/main/java/org/apache/hadoop/hbase/constraint/BaseConstraint.java 7ce6d45 bq.src/main/java/org/apache/hadoop/hbase/constraint/Constraint.java 2d8b4d7 bq.src/main/java/org/apache/hadoop/hbase/constraint/Constraints.java 7825466 bq.src/main/java/org/apache/hadoop/hbase/constraint/package-info.java 6145ed5 bq. src/test/java/org/apache/hadoop/hbase/constraint/CheckConfigurationConstraint.java c49098d bq. bq. Diff: https://reviews.apache.org/r/3273/diff bq. bq. bq. Testing bq. --- bq. bq. mvn clean test -P localTests -Dest=*Constraint* - all tests pass. bq. bq. bq. Thanks, bq. bq. Jesse bq. bq. Constraints implementation and javadoc changes -- Key: HBASE-5070 URL: https://issues.apache.org/jira/browse/HBASE-5070 Project: HBase Issue Type: Task Reporter: Zhihong Yu This is continuation of HBASE-4605 See Stack's comments https://reviews.apache.org/r/2579/#review3980 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5070) Constraints implementation and javadoc changes
[ https://issues.apache.org/jira/browse/HBASE-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13172788#comment-13172788 ] Zhihong Yu commented on HBASE-5070: --- w.r.t. whether HTableDescriptor is a good placeholder for serialized Constraint configuration, I think option 2 by Gary is more enticing. i.e. creating a central repo for holding serialized configuration information. Constraints implementation and javadoc changes -- Key: HBASE-5070 URL: https://issues.apache.org/jira/browse/HBASE-5070 Project: HBase Issue Type: Task Reporter: Zhihong Yu This is continuation of HBASE-4605 See Stack's comments https://reviews.apache.org/r/2579/#review3980 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
