subject:"\[jira\] \[Commented\] \(HBASE\-6858\) Fix the incorrect BADVERSION checking in the recoverable zookeeper"


[ 
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13475142#comment-13475142
 ] 

Jimmy Xiang commented on HBASE-6858:


Good point.  I will replace it will SecureRandom.

If a BADVERSION, and we are not retrying, we should throw the exception, in 
case other thread/caller set the same data the same version already.
I think we should check the data only if it is a retry after a connection issue.

I think the patch doesn't break rolling upgrade because, in retrieving data, we 
use the dynamical id length from the data, not the static copy.

 Fix the incorrect BADVERSION checking in the recoverable zookeeper
 --

 Key: HBASE-6858
 URL: https://issues.apache.org/jira/browse/HBASE-6858
 Project: HBase
  Issue Type: Bug
  Components: Zookeeper
Reporter: Liyin Tang
Assignee: Liyin Tang
Priority: Critical
 Fix For: 0.96.0

 Attachments: HBASE-6858.patch, HBASE-6858_v2.patch, 
 HBASE-6858_v3.patch, trunk-6858.patch


 Thanks for Stack and Kaka's reporting that there is a bug in the recoverable 
 zookeeper when handling BADVERSION exception for setData(). It shall compare 
 the ID payload of the data in zk with its own identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper


[ 
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13475145#comment-13475145
 ] 

Jimmy Xiang commented on HBASE-6858:


In addition to the random number, I can append an atomic long (static, keep 
incrementing).

 Fix the incorrect BADVERSION checking in the recoverable zookeeper
 --

 Key: HBASE-6858
 URL: https://issues.apache.org/jira/browse/HBASE-6858
 Project: HBase
  Issue Type: Bug
  Components: Zookeeper
Reporter: Liyin Tang
Assignee: Liyin Tang
Priority: Critical
 Fix For: 0.96.0

 Attachments: HBASE-6858.patch, HBASE-6858_v2.patch, 
 HBASE-6858_v3.patch, trunk-6858.patch


 Thanks for Stack and Kaka's reporting that there is a bug in the recoverable 
 zookeeper when handling BADVERSION exception for setData(). It shall compare 
 the ID payload of the data in zk with its own identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper


[ 
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13475164#comment-13475164
 ] 

stack commented on HBASE-6858:
--

bq. I think the patch doesn't break rolling upgrade because, in retrieving 
data, we use the dynamical id length from the data, not the static copy.

I thought you were writing the seed into znode?

 Fix the incorrect BADVERSION checking in the recoverable zookeeper
 --

 Key: HBASE-6858
 URL: https://issues.apache.org/jira/browse/HBASE-6858
 Project: HBase
  Issue Type: Bug
  Components: Zookeeper
Reporter: Liyin Tang
Assignee: Liyin Tang
Priority: Critical
 Fix For: 0.96.0

 Attachments: HBASE-6858.patch, HBASE-6858_v2.patch, 
 HBASE-6858_v3.patch, trunk-6858.patch


 Thanks for Stack and Kaka's reporting that there is a bug in the recoverable 
 zookeeper when handling BADVERSION exception for setData(). It shall compare 
 the ID payload of the data in zk with its own identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper


[ 
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13475172#comment-13475172
 ] 

Jimmy Xiang commented on HBASE-6858:


Yes, it is written into znode.  But it is not used in getting the original data 
back.

 Fix the incorrect BADVERSION checking in the recoverable zookeeper
 --

 Key: HBASE-6858
 URL: https://issues.apache.org/jira/browse/HBASE-6858
 Project: HBase
  Issue Type: Bug
  Components: Zookeeper
Reporter: Liyin Tang
Assignee: Liyin Tang
Priority: Critical
 Fix For: 0.96.0

 Attachments: HBASE-6858.patch, HBASE-6858_v2.patch, 
 HBASE-6858_v3.patch, trunk-6858.patch


 Thanks for Stack and Kaka's reporting that there is a bug in the recoverable 
 zookeeper when handling BADVERSION exception for setData(). It shall compare 
 the ID payload of the data in zk with its own identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper


[ 
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13475205#comment-13475205
 ] 

stack commented on HBASE-6858:
--

Will an older client be able to make sense of data written by a newer one, one 
w/ this extra salt in it?

 Fix the incorrect BADVERSION checking in the recoverable zookeeper
 --

 Key: HBASE-6858
 URL: https://issues.apache.org/jira/browse/HBASE-6858
 Project: HBase
  Issue Type: Bug
  Components: Zookeeper
Reporter: Liyin Tang
Assignee: Liyin Tang
Priority: Critical
 Fix For: 0.96.0

 Attachments: HBASE-6858.patch, HBASE-6858_v2.patch, 
 HBASE-6858_v3.patch, trunk-6858.patch


 Thanks for Stack and Kaka's reporting that there is a bug in the recoverable 
 zookeeper when handling BADVERSION exception for setData(). It shall compare 
 the ID payload of the data in zk with its own identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper


[ 
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13475235#comment-13475235
 ] 

Jimmy Xiang commented on HBASE-6858:


I think so.  I didn't touch the read part which still can read the old data.
It can't make sense the identifier though, which is fine, right? To clients,
it is just a salt.

 Fix the incorrect BADVERSION checking in the recoverable zookeeper
 --

 Key: HBASE-6858
 URL: https://issues.apache.org/jira/browse/HBASE-6858
 Project: HBase
  Issue Type: Bug
  Components: Zookeeper
Reporter: Liyin Tang
Assignee: Liyin Tang
Priority: Critical
 Fix For: 0.96.0

 Attachments: HBASE-6858.patch, HBASE-6858_v2.patch, 
 HBASE-6858_v3.patch, trunk-6858.patch


 Thanks for Stack and Kaka's reporting that there is a bug in the recoverable 
 zookeeper when handling BADVERSION exception for setData(). It shall compare 
 the ID payload of the data in zk with its own identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper


[ 
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13475266#comment-13475266
 ] 

stack commented on HBASE-6858:
--

[~jxiang] Yeah, should be fine.  We write the salt into the znode data but the 
length is appropriately adjusted.  Reading the data out, we get the length from 
the znode data, not via some hardcoding so should work (we don't even look at 
the id when we are removing it).  If a problem, we'll catch it when we try old 
client against new cluster testing an RC. 

 Fix the incorrect BADVERSION checking in the recoverable zookeeper
 --

 Key: HBASE-6858
 URL: https://issues.apache.org/jira/browse/HBASE-6858
 Project: HBase
  Issue Type: Bug
  Components: Zookeeper
Reporter: Liyin Tang
Assignee: Liyin Tang
Priority: Critical
 Fix For: 0.96.0

 Attachments: HBASE-6858.patch, HBASE-6858_v2.patch, 
 HBASE-6858_v3.patch, trunk-6858.patch


 Thanks for Stack and Kaka's reporting that there is a bug in the recoverable 
 zookeeper when handling BADVERSION exception for setData(). It shall compare 
 the ID payload of the data in zk with its own identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper

2012-10-12 Thread Hadoop QA (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13475403#comment-13475403
]

Hadoop QA commented on HBASE-6858:
--

{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12548958/trunk-6858_v2.patch
against trunk revision .

{color:green}+1 @author{color}. The patch does not contain any @author
tags.

{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.

{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.

{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
81 warning messages.

{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.

{color:red}-1 findbugs{color}. The patch appears to introduce 5 new
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.

{color:red}-1 core tests{color}. The patch failed these unit tests:

org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks

org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient

Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3047//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3047//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3047//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3047//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3047//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3047//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3047//console

This message is automatically generated.

Fix the incorrect BADVERSION checking in the recoverable zookeeper
--

Key: HBASE-6858
URL: https://issues.apache.org/jira/browse/HBASE-6858
Project: HBase
Issue Type: Bug
Components: Zookeeper
Reporter: Liyin Tang
Assignee: Liyin Tang
Priority: Critical
Fix For: 0.96.0

Attachments: HBASE-6858.patch, HBASE-6858_v2.patch,
HBASE-6858_v3.patch, trunk-6858.patch, trunk-6858_v2.patch

Thanks for Stack and Kaka's reporting that there is a bug in the recoverable
zookeeper when handling BADVERSION exception for setData(). It shall compare
the ID payload of the data in zk with its own identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper


[ 
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13475412#comment-13475412
 ] 

stack commented on HBASE-6858:
--

The addition of integer seems over the top to me.  You are trying to prevent 
what?  That two clients both writing exactly same data at about the same time 
both retry then both happen to get same exact number out of the random number 
generator?

 Fix the incorrect BADVERSION checking in the recoverable zookeeper
 --

 Key: HBASE-6858
 URL: https://issues.apache.org/jira/browse/HBASE-6858
 Project: HBase
  Issue Type: Bug
  Components: Zookeeper
Reporter: Liyin Tang
Assignee: Liyin Tang
Priority: Critical
 Fix For: 0.96.0

 Attachments: HBASE-6858.patch, HBASE-6858_v2.patch, 
 HBASE-6858_v3.patch, trunk-6858.patch, trunk-6858_v2.patch


 Thanks for Stack and Kaka's reporting that there is a bug in the recoverable 
 zookeeper when handling BADVERSION exception for setData(). It shall compare 
 the ID payload of the data in zk with its own identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper


[ 
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13475421#comment-13475421
 ] 

Jimmy Xiang commented on HBASE-6858:


It may not happen at the same time.  Suppose one client writes the data.  Quite 
some time later, another client can try to write the same data same version 
again.  That's what I'd like to prevent.  I am ok not to have the extra one, 
just want to be cautious. :)

 Fix the incorrect BADVERSION checking in the recoverable zookeeper
 --

 Key: HBASE-6858
 URL: https://issues.apache.org/jira/browse/HBASE-6858
 Project: HBase
  Issue Type: Bug
  Components: Zookeeper
Reporter: Liyin Tang
Assignee: Liyin Tang
Priority: Critical
 Fix For: 0.96.0

 Attachments: HBASE-6858.patch, HBASE-6858_v2.patch, 
 HBASE-6858_v3.patch, trunk-6858.patch, trunk-6858_v2.patch


 Thanks for Stack and Kaka's reporting that there is a bug in the recoverable 
 zookeeper when handling BADVERSION exception for setData(). It shall compare 
 the ID payload of the data in zk with its own identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper


[ 
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13475431#comment-13475431
 ] 

stack commented on HBASE-6858:
--

bq write the same data same version again.

Same znode id, same seed (generated by different SecureRandom instances), 
around same time, and same data... seems highly unlikely?  The extra integer 
seems too much to me.

 Fix the incorrect BADVERSION checking in the recoverable zookeeper
 --

 Key: HBASE-6858
 URL: https://issues.apache.org/jira/browse/HBASE-6858
 Project: HBase
  Issue Type: Bug
  Components: Zookeeper
Reporter: Liyin Tang
Assignee: Liyin Tang
Priority: Critical
 Fix For: 0.96.0

 Attachments: HBASE-6858.patch, HBASE-6858_v2.patch, 
 HBASE-6858_v3.patch, trunk-6858.patch, trunk-6858_v2.patch


 Thanks for Stack and Kaka's reporting that there is a bug in the recoverable 
 zookeeper when handling BADVERSION exception for setData(). It shall compare 
 the ID payload of the data in zk with its own identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper


[ 
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13475446#comment-13475446
 ] 

Jimmy Xiang commented on HBASE-6858:


Ok, changed it back.  Uploaded trunk-6858_v3.patch.

 Fix the incorrect BADVERSION checking in the recoverable zookeeper
 --

 Key: HBASE-6858
 URL: https://issues.apache.org/jira/browse/HBASE-6858
 Project: HBase
  Issue Type: Bug
  Components: Zookeeper
Reporter: Liyin Tang
Assignee: Liyin Tang
Priority: Critical
 Fix For: 0.96.0

 Attachments: HBASE-6858.patch, HBASE-6858_v2.patch, 
 HBASE-6858_v3.patch, trunk-6858.patch, trunk-6858_v2.patch, 
 trunk-6858_v3.patch


 Thanks for Stack and Kaka's reporting that there is a bug in the recoverable 
 zookeeper when handling BADVERSION exception for setData(). It shall compare 
 the ID payload of the data in zk with its own identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper

2012-10-12 Thread Gregory Chanan (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13475448#comment-13475448
 ] 

Gregory Chanan commented on HBASE-6858:
---

Another potentially silly question...

We are trying to prevent all these cases where a client is writing the same 
data.  There are a couple of variables here:
- Same vs different client
- Same vs different time

Do either of these matter?  Why do we care if we try to do the same write?

 Fix the incorrect BADVERSION checking in the recoverable zookeeper
 --

 Key: HBASE-6858
 URL: https://issues.apache.org/jira/browse/HBASE-6858
 Project: HBase
  Issue Type: Bug
  Components: Zookeeper
Reporter: Liyin Tang
Assignee: Liyin Tang
Priority: Critical
 Fix For: 0.96.0

 Attachments: HBASE-6858.patch, HBASE-6858_v2.patch, 
 HBASE-6858_v3.patch, trunk-6858.patch, trunk-6858_v2.patch, 
 trunk-6858_v3.patch


 Thanks for Stack and Kaka's reporting that there is a bug in the recoverable 
 zookeeper when handling BADVERSION exception for setData(). It shall compare 
 the ID payload of the data in zk with its own identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper


[ 
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13475451#comment-13475451
 ] 

Jimmy Xiang commented on HBASE-6858:


It should throw a BADVERSION exception, as expected, in this case.  We can't 
violate the semantics.

Very likely, the client(s) is trying to doing something it thinks only it's 
doing.  It could be done many times, which is ok.
If it should be done only once, then it is a problem.

 Fix the incorrect BADVERSION checking in the recoverable zookeeper
 --

 Key: HBASE-6858
 URL: https://issues.apache.org/jira/browse/HBASE-6858
 Project: HBase
  Issue Type: Bug
  Components: Zookeeper
Reporter: Liyin Tang
Assignee: Liyin Tang
Priority: Critical
 Fix For: 0.96.0

 Attachments: HBASE-6858.patch, HBASE-6858_v2.patch, 
 HBASE-6858_v3.patch, trunk-6858.patch, trunk-6858_v2.patch, 
 trunk-6858_v3.patch


 Thanks for Stack and Kaka's reporting that there is a bug in the recoverable 
 zookeeper when handling BADVERSION exception for setData(). It shall compare 
 the ID payload of the data in zk with its own identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper

2012-10-12 Thread Gregory Chanan (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13475453#comment-13475453
]

Gregory Chanan commented on HBASE-6858:
---

Whose semantics are we talking about? I assume you mean ZK. We can have our
own semantics for what repeated writes to ZK mean and handle it at this layer.
That doesn't necessarily mean ignore BADVERSIONS if the data is the same, it
could mean rethrowing the BADVERSION.

bq. Very likely, the client(s) is trying to doing something it thinks only it's
doing. It could be done many times, which is ok.
bq. If it should be done only once, then it is a problem.

Where would this cause a problem? If the data is different, we'll throw an
error. Will we miss an expected zk dataChanged call or something?

Fix the incorrect BADVERSION checking in the recoverable zookeeper
--

Key: HBASE-6858
URL: https://issues.apache.org/jira/browse/HBASE-6858
Project: HBase
Issue Type: Bug
Components: Zookeeper
Reporter: Liyin Tang
Assignee: Liyin Tang
Priority: Critical
Fix For: 0.96.0

Attachments: HBASE-6858.patch, HBASE-6858_v2.patch,
HBASE-6858_v3.patch, trunk-6858.patch, trunk-6858_v2.patch,
trunk-6858_v3.patch

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper

2012-10-12 Thread Hadoop QA (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13475456#comment-13475456
]

Hadoop QA commented on HBASE-6858:
--

{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12548988/trunk-6858_v3.patch
against trunk revision .

{color:green}+1 @author{color}. The patch does not contain any @author
tags.

{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.

{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
81 warning messages.

{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.

{color:red}-1 findbugs{color}. The patch appears to introduce 5 new
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.

{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestSplitTransaction

Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3048//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3048//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3048//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3048//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3048//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3048//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3048//console

This message is automatically generated.

Fix the incorrect BADVERSION checking in the recoverable zookeeper
--

Key: HBASE-6858
URL: https://issues.apache.org/jira/browse/HBASE-6858
Project: HBase
Issue Type: Bug
Components: Zookeeper
Reporter: Liyin Tang
Assignee: Liyin Tang
Priority: Critical
Fix For: 0.96.0

Attachments: HBASE-6858.patch, HBASE-6858_v2.patch,
HBASE-6858_v3.patch, trunk-6858.patch, trunk-6858_v2.patch,
trunk-6858_v3.patch

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper


[ 
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13475504#comment-13475504
 ] 

Jimmy Xiang commented on HBASE-6858:


That's an interesting idea.  Probably it is out of scope of this jira.  For 
this jira, I think we should make sure recoverable zk behaves the same way as 
the previous zk: if the version is not expected, throws badversion exception, 
no matter the data is the same or not.

 Fix the incorrect BADVERSION checking in the recoverable zookeeper
 --

 Key: HBASE-6858
 URL: https://issues.apache.org/jira/browse/HBASE-6858
 Project: HBase
  Issue Type: Bug
  Components: Zookeeper
Reporter: Liyin Tang
Assignee: Liyin Tang
Priority: Critical
 Fix For: 0.96.0

 Attachments: HBASE-6858.patch, HBASE-6858_v2.patch, 
 HBASE-6858_v3.patch, trunk-6858.patch, trunk-6858_v2.patch, 
 trunk-6858_v3.patch


 Thanks for Stack and Kaka's reporting that there is a bug in the recoverable 
 zookeeper when handling BADVERSION exception for setData(). It shall compare 
 the ID payload of the data in zk with its own identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper

2012-10-11 Thread Hadoop QA (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13474762#comment-13474762
]

Hadoop QA commented on HBASE-6858:
--

{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12548850/trunk-6858.patch
against trunk revision .

{color:green}+1 @author{color}. The patch does not contain any @author
tags.

{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.

{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
81 warning messages.

{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.

{color:red}-1 findbugs{color}. The patch appears to introduce 5 new
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.

{color:green}+1 core tests{color}. The patch passed unit tests in .

Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3040//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3040//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3040//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3040//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3040//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3040//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3040//console

This message is automatically generated.

Fix the incorrect BADVERSION checking in the recoverable zookeeper
--

Key: HBASE-6858
URL: https://issues.apache.org/jira/browse/HBASE-6858
Project: HBase
Issue Type: Bug
Components: Zookeeper
Reporter: Liyin Tang
Assignee: Liyin Tang
Priority: Critical
Fix For: 0.96.0

Attachments: HBASE-6858.patch, HBASE-6858_v2.patch,
HBASE-6858_v3.patch, trunk-6858.patch

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper

2012-10-11 Thread stack (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13474777#comment-13474777
]

stack commented on HBASE-6858:
--

If a BADVERSION, we first retry? Then if we get it again, then we fall into
the getData check? That seems good.

This is a random page,
http://www.javamex.com/tutorials/cryptography/pbe_salt.shtml, but its explicit
about one thing, something that seems right: Never use a weak random number
generator such as java.util.Random to generate salt bytes! It is probably
fine in this context but perhaps salt the call to new Random at least? What
can you stuff in there? Hash of the quorumServers passed in plus the hash of
the current instance?

This patch is only for trunk? Insertion of salt means that we won't be able to
do rolling upgrade? Not unless there are no regions in transition at the time?
Is that right?

Fix the incorrect BADVERSION checking in the recoverable zookeeper
--

Key: HBASE-6858
URL: https://issues.apache.org/jira/browse/HBASE-6858
Project: HBase
Issue Type: Bug
Components: Zookeeper
Reporter: Liyin Tang
Assignee: Liyin Tang
Priority: Critical
Fix For: 0.96.0

Attachments: HBASE-6858.patch, HBASE-6858_v2.patch,
HBASE-6858_v3.patch, trunk-6858.patch

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper

2012-10-11 Thread Ted Yu (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13474790#comment-13474790
 ] 

Ted Yu commented on HBASE-6858:
---

From http://www.javamex.com/tutorials/random_numbers/generators_overview.shtml 
, a replacement for Random would be java.security.SecureRandom 

 Fix the incorrect BADVERSION checking in the recoverable zookeeper
 --

 Key: HBASE-6858
 URL: https://issues.apache.org/jira/browse/HBASE-6858
 Project: HBase
  Issue Type: Bug
  Components: Zookeeper
Reporter: Liyin Tang
Assignee: Liyin Tang
Priority: Critical
 Fix For: 0.96.0

 Attachments: HBASE-6858.patch, HBASE-6858_v2.patch, 
 HBASE-6858_v3.patch, trunk-6858.patch


 Thanks for Stack and Kaka's reporting that there is a bug in the recoverable 
 zookeeper when handling BADVERSION exception for setData(). It shall compare 
 the ID payload of the data in zk with its own identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper

2012-10-04 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13469900#comment-13469900
 ] 

Hudson commented on HBASE-6858:
---

Integrated in HBase-0.94-security-on-Hadoop-23 #8 (See 
[https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/8/])
HBASE-6858 Fix the incorrect BADVERSION checking in the recoverable 
zookeeper; REVERT BROKE (Revision 1388704)
HBASE-6858 Fix the incorrect BADVERSION checking in the recoverable zookeeper 
(Revision 1388700)

 Result = FAILURE
stack : 
Files : 
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java

stack : 
Files : 
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java


 Fix the incorrect BADVERSION checking in the recoverable zookeeper
 --

 Key: HBASE-6858
 URL: https://issues.apache.org/jira/browse/HBASE-6858
 Project: HBase
  Issue Type: Bug
  Components: Zookeeper
Reporter: Liyin Tang
Assignee: Liyin Tang
Priority: Critical
 Fix For: 0.96.0

 Attachments: HBASE-6858.patch, HBASE-6858_v2.patch, 
 HBASE-6858_v3.patch


 Thanks for Stack and Kaka's reporting that there is a bug in the recoverable 
 zookeeper when handling BADVERSION exception for setData(). It shall compare 
 the ID payload of the data in zk with its own identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper

2012-09-22 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13461126#comment-13461126
 ] 

Hudson commented on HBASE-6858:
---

Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #187 (See 
[https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/187/])
HBASE-6858 Fix the incorrect BADVERSION checking in the recoverable 
zookeeper; REVERT BROKE (Revision 1388725)

 Result = FAILURE
stack : 
Files : 
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java


 Fix the incorrect BADVERSION checking in the recoverable zookeeper
 --

 Key: HBASE-6858
 URL: https://issues.apache.org/jira/browse/HBASE-6858
 Project: HBase
  Issue Type: Bug
  Components: Zookeeper
Reporter: Liyin Tang
Assignee: Liyin Tang
 Fix For: 0.96.0

 Attachments: HBASE-6858.patch, HBASE-6858_v2.patch, 
 HBASE-6858_v3.patch


 Thanks for Stack and Kaka's reporting that there is a bug in the recoverable 
 zookeeper when handling BADVERSION exception for setData(). It shall compare 
 the ID payload of the data in zk with its own identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper

2012-09-21 Thread stack (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13460823#comment-13460823
 ] 

stack commented on HBASE-6858:
--

+1 on patch.

 Fix the incorrect BADVERSION checking in the recoverable zookeeper
 --

 Key: HBASE-6858
 URL: https://issues.apache.org/jira/browse/HBASE-6858
 Project: HBase
  Issue Type: Bug
Reporter: Liyin Tang
Assignee: Liyin Tang
 Attachments: HBASE-6858.patch


 Thanks for Stack and Kaka's reporting that there is a bug in the recoverable 
 zookeeper when handling BADVERSION exception for setData(). It shall compare 
 the ID payload of the data in zk with its own identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper


[ 
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13460825#comment-13460825
 ] 

Jimmy Xiang commented on HBASE-6858:


We should add the MAGIC_OFFSET and ID_OFFSET.  ID_OFFSET is one byte off.

 Fix the incorrect BADVERSION checking in the recoverable zookeeper
 --

 Key: HBASE-6858
 URL: https://issues.apache.org/jira/browse/HBASE-6858
 Project: HBase
  Issue Type: Bug
Reporter: Liyin Tang
Assignee: Liyin Tang
 Attachments: HBASE-6858.patch


 Thanks for Stack and Kaka's reporting that there is a bug in the recoverable 
 zookeeper when handling BADVERSION exception for setData(). It shall compare 
 the ID payload of the data in zk with its own identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper


[ 
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13460837#comment-13460837
 ] 

Lars Hofhansl commented on HBASE-6858:
--

Is that a 0.96 only issue?

 Fix the incorrect BADVERSION checking in the recoverable zookeeper
 --

 Key: HBASE-6858
 URL: https://issues.apache.org/jira/browse/HBASE-6858
 Project: HBase
  Issue Type: Bug
Reporter: Liyin Tang
Assignee: Liyin Tang
 Attachments: HBASE-6858.patch


 Thanks for Stack and Kaka's reporting that there is a bug in the recoverable 
 zookeeper when handling BADVERSION exception for setData(). It shall compare 
 the ID payload of the data in zk with its own identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper

2012-09-21 Thread stack (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13460838#comment-13460838
 ] 

stack commented on HBASE-6858:
--

[~lhofhansl] No


 Fix the incorrect BADVERSION checking in the recoverable zookeeper
 --

 Key: HBASE-6858
 URL: https://issues.apache.org/jira/browse/HBASE-6858
 Project: HBase
  Issue Type: Bug
Reporter: Liyin Tang
Assignee: Liyin Tang
 Attachments: HBASE-6858.patch


 Thanks for Stack and Kaka's reporting that there is a bug in the recoverable 
 zookeeper when handling BADVERSION exception for setData(). It shall compare 
 the ID payload of the data in zk with its own identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper


[ 
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13460855#comment-13460855
 ] 

Liyin Tang commented on HBASE-6858:
---

Addressed Jimmy's comments!  Thanks Jimmy !

 Fix the incorrect BADVERSION checking in the recoverable zookeeper
 --

 Key: HBASE-6858
 URL: https://issues.apache.org/jira/browse/HBASE-6858
 Project: HBase
  Issue Type: Bug
Reporter: Liyin Tang
Assignee: Liyin Tang
 Fix For: 0.94.2, 0.96.0

 Attachments: HBASE-6858.patch


 Thanks for Stack and Kaka's reporting that there is a bug in the recoverable 
 zookeeper when handling BADVERSION exception for setData(). It shall compare 
 the ID payload of the data in zk with its own identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper


[ 
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13460857#comment-13460857
 ] 

Jimmy Xiang commented on HBASE-6858:


+1

 Fix the incorrect BADVERSION checking in the recoverable zookeeper
 --

 Key: HBASE-6858
 URL: https://issues.apache.org/jira/browse/HBASE-6858
 Project: HBase
  Issue Type: Bug
Reporter: Liyin Tang
Assignee: Liyin Tang
 Fix For: 0.94.2, 0.96.0

 Attachments: HBASE-6858.patch


 Thanks for Stack and Kaka's reporting that there is a bug in the recoverable 
 zookeeper when handling BADVERSION exception for setData(). It shall compare 
 the ID payload of the data in zk with its own identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper


[ 
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13460859#comment-13460859
 ] 

Lars Hofhansl commented on HBASE-6858:
--

@Liyin: I think it would be better to version the attachments (_v1, _v2, etc) 
instead of replacing them (I frequently find it useful to look through the 
attachments, and see the differences between them).

 Fix the incorrect BADVERSION checking in the recoverable zookeeper
 --

 Key: HBASE-6858
 URL: https://issues.apache.org/jira/browse/HBASE-6858
 Project: HBase
  Issue Type: Bug
Reporter: Liyin Tang
Assignee: Liyin Tang
 Fix For: 0.94.2, 0.96.0

 Attachments: HBASE-6858.patch


 Thanks for Stack and Kaka's reporting that there is a bug in the recoverable 
 zookeeper when handling BADVERSION exception for setData(). It shall compare 
 the ID payload of the data in zk with its own identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper


[ 
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13460868#comment-13460868
 ] 

Hudson commented on HBASE-6858:
---

Integrated in HBase-0.94-security #55 (See 
[https://builds.apache.org/job/HBase-0.94-security/55/])
HBASE-6858 Fix the incorrect BADVERSION checking in the recoverable 
zookeeper (Revision 1388700)

 Result = FAILURE
stack : 
Files : 
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java


 Fix the incorrect BADVERSION checking in the recoverable zookeeper
 --

 Key: HBASE-6858
 URL: https://issues.apache.org/jira/browse/HBASE-6858
 Project: HBase
  Issue Type: Bug
  Components: Zookeeper
Reporter: Liyin Tang
Assignee: Liyin Tang
 Fix For: 0.94.2, 0.96.0

 Attachments: HBASE-6858.patch


 Thanks for Stack and Kaka's reporting that there is a bug in the recoverable 
 zookeeper when handling BADVERSION exception for setData(). It shall compare 
 the ID payload of the data in zk with its own identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper


[ 
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13460872#comment-13460872
 ] 

Liyin Tang commented on HBASE-6858:
---

The code is difference between 89 and trunk. Some variable has been renamed. 
Let me re-submit the patch !

 Fix the incorrect BADVERSION checking in the recoverable zookeeper
 --

 Key: HBASE-6858
 URL: https://issues.apache.org/jira/browse/HBASE-6858
 Project: HBase
  Issue Type: Bug
  Components: Zookeeper
Reporter: Liyin Tang
Assignee: Liyin Tang
 Fix For: 0.94.2, 0.96.0

 Attachments: HBASE-6858.patch


 Thanks for Stack and Kaka's reporting that there is a bug in the recoverable 
 zookeeper when handling BADVERSION exception for setData(). It shall compare 
 the ID payload of the data in zk with its own identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper


[ 
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13460877#comment-13460877
 ] 

Hudson commented on HBASE-6858:
---

Integrated in HBase-TRUNK #3368 (See 
[https://builds.apache.org/job/HBase-TRUNK/3368/])
HBASE-6858 Fix the incorrect BADVERSION checking in the recoverable 
zookeeper (Revision 1388699)

 Result = FAILURE
stack : 
Files : 
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java


 Fix the incorrect BADVERSION checking in the recoverable zookeeper
 --

 Key: HBASE-6858
 URL: https://issues.apache.org/jira/browse/HBASE-6858
 Project: HBase
  Issue Type: Bug
  Components: Zookeeper
Reporter: Liyin Tang
Assignee: Liyin Tang
 Fix For: 0.96.0

 Attachments: HBASE-6858.patch


 Thanks for Stack and Kaka's reporting that there is a bug in the recoverable 
 zookeeper when handling BADVERSION exception for setData(). It shall compare 
 the ID payload of the data in zk with its own identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper


[ 
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13460892#comment-13460892
 ] 

Lars Hofhansl commented on HBASE-6858:
--

He, just noticed. Should I make a working 0.94 patch? I'm not sure when this 
bug is triggered and whether it is important to fix it.

 Fix the incorrect BADVERSION checking in the recoverable zookeeper
 --

 Key: HBASE-6858
 URL: https://issues.apache.org/jira/browse/HBASE-6858
 Project: HBase
  Issue Type: Bug
  Components: Zookeeper
Reporter: Liyin Tang
Assignee: Liyin Tang
 Fix For: 0.96.0

 Attachments: HBASE-6858.patch


 Thanks for Stack and Kaka's reporting that there is a bug in the recoverable 
 zookeeper when handling BADVERSION exception for setData(). It shall compare 
 the ID payload of the data in zk with its own identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper


[ 
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13460896#comment-13460896
 ] 

Lars Hofhansl commented on HBASE-6858:
--

Let's leave it out of 0.94 for now. Can always pull into 0.94.3 if needed.

 Fix the incorrect BADVERSION checking in the recoverable zookeeper
 --

 Key: HBASE-6858
 URL: https://issues.apache.org/jira/browse/HBASE-6858
 Project: HBase
  Issue Type: Bug
  Components: Zookeeper
Reporter: Liyin Tang
Assignee: Liyin Tang
 Fix For: 0.96.0

 Attachments: HBASE-6858.patch


 Thanks for Stack and Kaka's reporting that there is a bug in the recoverable 
 zookeeper when handling BADVERSION exception for setData(). It shall compare 
 the ID payload of the data in zk with its own identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper


[ 
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13460898#comment-13460898
 ] 

Hudson commented on HBASE-6858:
---

Integrated in HBase-0.94 #482 (See 
[https://builds.apache.org/job/HBase-0.94/482/])
HBASE-6858 Fix the incorrect BADVERSION checking in the recoverable 
zookeeper; REVERT BROKE (Revision 1388704)

 Result = ABORTED
stack : 
Files : 
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java


 Fix the incorrect BADVERSION checking in the recoverable zookeeper
 --

 Key: HBASE-6858
 URL: https://issues.apache.org/jira/browse/HBASE-6858
 Project: HBase
  Issue Type: Bug
  Components: Zookeeper
Reporter: Liyin Tang
Assignee: Liyin Tang
 Fix For: 0.96.0

 Attachments: HBASE-6858.patch


 Thanks for Stack and Kaka's reporting that there is a bug in the recoverable 
 zookeeper when handling BADVERSION exception for setData(). It shall compare 
 the ID payload of the data in zk with its own identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper

2012-09-21 Thread Gregory Chanan (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13460908#comment-13460908
 ] 

Gregory Chanan commented on HBASE-6858:
---

Let me ask a potentially silly question here...

Why do we just check that the id is the same?  This basically says that the 
version of the data in ZK was set by the current recoverable ZooKeeper, but 
what if the data is different?  This seems like an error to me?  I.e. if I 
called setData with a certain version/data and I didn't get an error, I'd 
expect that at least for that version, the data is what I requested.  But this 
would swallow that error.

 Fix the incorrect BADVERSION checking in the recoverable zookeeper
 --

 Key: HBASE-6858
 URL: https://issues.apache.org/jira/browse/HBASE-6858
 Project: HBase
  Issue Type: Bug
  Components: Zookeeper
Reporter: Liyin Tang
Assignee: Liyin Tang
 Fix For: 0.96.0

 Attachments: HBASE-6858.patch, HBASE-6858_v2.patch


 Thanks for Stack and Kaka's reporting that there is a bug in the recoverable 
 zookeeper when handling BADVERSION exception for setData(). It shall compare 
 the ID payload of the data in zk with its own identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper


[ 
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13460912#comment-13460912
 ] 

Jimmy Xiang commented on HBASE-6858:


Agree with Gregory.  Should we check the whole thing instead?

 Fix the incorrect BADVERSION checking in the recoverable zookeeper
 --

 Key: HBASE-6858
 URL: https://issues.apache.org/jira/browse/HBASE-6858
 Project: HBase
  Issue Type: Bug
  Components: Zookeeper
Reporter: Liyin Tang
Assignee: Liyin Tang
 Fix For: 0.96.0

 Attachments: HBASE-6858.patch, HBASE-6858_v2.patch


 Thanks for Stack and Kaka's reporting that there is a bug in the recoverable 
 zookeeper when handling BADVERSION exception for setData(). It shall compare 
 the ID payload of the data in zk with its own identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper


[ 
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13460920#comment-13460920
 ] 

Hudson commented on HBASE-6858:
---

Integrated in HBase-0.94-security #56 (See 
[https://builds.apache.org/job/HBase-0.94-security/56/])
HBASE-6858 Fix the incorrect BADVERSION checking in the recoverable 
zookeeper; REVERT BROKE (Revision 1388704)

 Result = SUCCESS
stack : 
Files : 
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java


 Fix the incorrect BADVERSION checking in the recoverable zookeeper
 --

 Key: HBASE-6858
 URL: https://issues.apache.org/jira/browse/HBASE-6858
 Project: HBase
  Issue Type: Bug
  Components: Zookeeper
Reporter: Liyin Tang
Assignee: Liyin Tang
 Fix For: 0.96.0

 Attachments: HBASE-6858.patch, HBASE-6858_v2.patch


 Thanks for Stack and Kaka's reporting that there is a bug in the recoverable 
 zookeeper when handling BADVERSION exception for setData(). It shall compare 
 the ID payload of the data in zk with its own identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper


[ 
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13460926#comment-13460926
 ] 

Hudson commented on HBASE-6858:
---

Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #186 (See 
[https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/186/])
HBASE-6858 Fix the incorrect BADVERSION checking in the recoverable 
zookeeper (Revision 1388699)

 Result = FAILURE
stack : 
Files : 
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java


 Fix the incorrect BADVERSION checking in the recoverable zookeeper
 --

 Key: HBASE-6858
 URL: https://issues.apache.org/jira/browse/HBASE-6858
 Project: HBase
  Issue Type: Bug
  Components: Zookeeper
Reporter: Liyin Tang
Assignee: Liyin Tang
 Fix For: 0.96.0

 Attachments: HBASE-6858.patch, HBASE-6858_v2.patch


 Thanks for Stack and Kaka's reporting that there is a bug in the recoverable 
 zookeeper when handling BADVERSION exception for setData(). It shall compare 
 the ID payload of the data in zk with its own identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper


[ 
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13460934#comment-13460934
 ] 

Liyin Tang commented on HBASE-6858:
---

I agree that this is not a very general solution and may introduce race 
condition if multiple threads in one zk client try to update the same znode 
with different version number, then current code will hide the BADVERSION 
exception. We didn't find this use case in HBase at that time, roughly 1.5 
years ago and it is cheaper to compare the identifier than comparing the data 
payload. 
I also believe leaving this kind of assumption in the system may introduce or 
has introduced some uncertainty or bugs and it is definitely worth improving.

 Fix the incorrect BADVERSION checking in the recoverable zookeeper
 --

 Key: HBASE-6858
 URL: https://issues.apache.org/jira/browse/HBASE-6858
 Project: HBase
  Issue Type: Bug
  Components: Zookeeper
Reporter: Liyin Tang
Assignee: Liyin Tang
 Fix For: 0.96.0

 Attachments: HBASE-6858.patch, HBASE-6858_v2.patch


 Thanks for Stack and Kaka's reporting that there is a bug in the recoverable 
 zookeeper when handling BADVERSION exception for setData(). It shall compare 
 the ID payload of the data in zk with its own identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper


[ 
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13460938#comment-13460938
 ] 

Liyin Tang commented on HBASE-6858:
---

@stack, the latest Hudson doesn't look like building with the latest patch 
(HBASE-6858_v2.patch). 

 Fix the incorrect BADVERSION checking in the recoverable zookeeper
 --

 Key: HBASE-6858
 URL: https://issues.apache.org/jira/browse/HBASE-6858
 Project: HBase
  Issue Type: Bug
  Components: Zookeeper
Reporter: Liyin Tang
Assignee: Liyin Tang
 Fix For: 0.96.0

 Attachments: HBASE-6858.patch, HBASE-6858_v2.patch


 Thanks for Stack and Kaka's reporting that there is a bug in the recoverable 
 zookeeper when handling BADVERSION exception for setData(). It shall compare 
 the ID payload of the data in zk with its own identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper


[ 
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13460945#comment-13460945
 ] 

Jimmy Xiang commented on HBASE-6858:


We have at least two options: 1. Instead of using a fixed identifier, probably 
we should use a kind-of unique id per call.
2. Compare the whole data. I noticed that in the create() method, the whole 
data is compared, not just the id.

I assume this won't happen frequently. Then, comparing the whole data should 
not have too much overhead.

 Fix the incorrect BADVERSION checking in the recoverable zookeeper
 --

 Key: HBASE-6858
 URL: https://issues.apache.org/jira/browse/HBASE-6858
 Project: HBase
  Issue Type: Bug
  Components: Zookeeper
Reporter: Liyin Tang
Assignee: Liyin Tang
 Fix For: 0.96.0

 Attachments: HBASE-6858.patch, HBASE-6858_v2.patch


 Thanks for Stack and Kaka's reporting that there is a bug in the recoverable 
 zookeeper when handling BADVERSION exception for setData(). It shall compare 
 the ID payload of the data in zk with its own identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper


[ 
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13460947#comment-13460947
 ] 

Liyin Tang commented on HBASE-6858:
---

The recoverable zk tried to recover from the connection less exception 
gracefully at beginning and I still believe this problem shall be solved by the 
zookeeper client library instead of the application such as HBase. The third 
option shall be check whether the latest zookeeper has supported to be 
recovered by the connection loss exception gracefully. In that case, we just 
need to totally remove the recoverable zk !



 Fix the incorrect BADVERSION checking in the recoverable zookeeper
 --

 Key: HBASE-6858
 URL: https://issues.apache.org/jira/browse/HBASE-6858
 Project: HBase
  Issue Type: Bug
  Components: Zookeeper
Reporter: Liyin Tang
Assignee: Liyin Tang
 Fix For: 0.96.0

 Attachments: HBASE-6858.patch, HBASE-6858_v2.patch


 Thanks for Stack and Kaka's reporting that there is a bug in the recoverable 
 zookeeper when handling BADVERSION exception for setData(). It shall compare 
 the ID payload of the data in zk with its own identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper

2012-09-21 Thread Gregory Chanan (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13460951#comment-13460951
 ] 

Gregory Chanan commented on HBASE-6858:
---

+1 on Jimmy's suggestion #2.  I don't see any reason to make create and setData 
different, and this probably happens infrequently (considering previous code 
was broken and we didn't notice).

 Fix the incorrect BADVERSION checking in the recoverable zookeeper
 --

 Key: HBASE-6858
 URL: https://issues.apache.org/jira/browse/HBASE-6858
 Project: HBase
  Issue Type: Bug
  Components: Zookeeper
Reporter: Liyin Tang
Assignee: Liyin Tang
 Fix For: 0.96.0

 Attachments: HBASE-6858.patch, HBASE-6858_v2.patch


 Thanks for Stack and Kaka's reporting that there is a bug in the recoverable 
 zookeeper when handling BADVERSION exception for setData(). It shall compare 
 the ID payload of the data in zk with its own identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper


[ 
https://issues.apache.org/jira/browse/HBASE-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13460989#comment-13460989
 ] 

Hudson commented on HBASE-6858:
---

Integrated in HBase-TRUNK #3369 (See 
[https://builds.apache.org/job/HBase-TRUNK/3369/])
HBASE-6858 Fix the incorrect BADVERSION checking in the recoverable 
zookeeper; REVERT BROKE (Revision 1388725)

 Result = FAILURE
stack : 
Files : 
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java


 Fix the incorrect BADVERSION checking in the recoverable zookeeper
 --

 Key: HBASE-6858
 URL: https://issues.apache.org/jira/browse/HBASE-6858
 Project: HBase
  Issue Type: Bug
  Components: Zookeeper
Reporter: Liyin Tang
Assignee: Liyin Tang
 Fix For: 0.96.0

 Attachments: HBASE-6858.patch, HBASE-6858_v2.patch, 
 HBASE-6858_v3.patch


 Thanks for Stack and Kaka's reporting that there is a bug in the recoverable 
 zookeeper when handling BADVERSION exception for setData(). It shall compare 
 the ID payload of the data in zk with its own identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6858) Fix the incorrect BADVERSION checking in the recoverable zookeeper