[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[ https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13773089#comment-13773089 ] Hudson commented on HBASE-7462: --- FAILURE: Integrated in hbase-0.96 #75 (See [https://builds.apache.org/job/hbase-0.96/75/]) HBASE-7462 TestDrainingServer is an integration test. It should be a unit test instead (Gustavo Anatoly) (nkeywal: rev 1524996) * /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/TestDrainingServer.java TestDrainingServer is an integration test. It should be a unit test instead --- Key: HBASE-7462 URL: https://issues.apache.org/jira/browse/HBASE-7462 Project: HBase Issue Type: Wish Components: test Affects Versions: 0.95.2 Reporter: Nicolas Liochon Assignee: Gustavo Anatoly Priority: Trivial Labels: noob Fix For: 0.98.0, 0.96.1 Attachments: 7462.v3.patch, HBASE-7462-v2.patch TestDrainingServer tests the function that allows to say that a regionserver should not get new regions. As it is written today, it's an integration test: it starts stops a cluster. The test would be more efficient if it would just check that the AssignmentManager does not use the drained region server; whatever the circumstances (bulk assign or not for example). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[ https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13773081#comment-13773081 ] Hudson commented on HBASE-7462: --- FAILURE: Integrated in HBase-TRUNK #4539 (See [https://builds.apache.org/job/HBase-TRUNK/4539/]) HBASE-7462 TestDrainingServer is an integration test. It should be a unit test instead (Gustavo Anatoly) (nkeywal: rev 1524995) * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestDrainingServer.java TestDrainingServer is an integration test. It should be a unit test instead --- Key: HBASE-7462 URL: https://issues.apache.org/jira/browse/HBASE-7462 Project: HBase Issue Type: Wish Components: test Affects Versions: 0.95.2 Reporter: Nicolas Liochon Assignee: Gustavo Anatoly Priority: Trivial Labels: noob Fix For: 0.98.0, 0.96.1 Attachments: 7462.v3.patch, HBASE-7462-v2.patch TestDrainingServer tests the function that allows to say that a regionserver should not get new regions. As it is written today, it's an integration test: it starts stops a cluster. The test would be more efficient if it would just check that the AssignmentManager does not use the drained region server; whatever the circumstances (bulk assign or not for example). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[ https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13773136#comment-13773136 ] Hudson commented on HBASE-7462: --- FAILURE: Integrated in hbase-0.96-hadoop2 #42 (See [https://builds.apache.org/job/hbase-0.96-hadoop2/42/]) HBASE-7462 TestDrainingServer is an integration test. It should be a unit test instead (Gustavo Anatoly) (nkeywal: rev 1524996) * /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/TestDrainingServer.java TestDrainingServer is an integration test. It should be a unit test instead --- Key: HBASE-7462 URL: https://issues.apache.org/jira/browse/HBASE-7462 Project: HBase Issue Type: Wish Components: test Affects Versions: 0.95.2 Reporter: Nicolas Liochon Assignee: Gustavo Anatoly Priority: Trivial Labels: noob Fix For: 0.98.0, 0.96.1 Attachments: 7462.v3.patch, HBASE-7462-v2.patch TestDrainingServer tests the function that allows to say that a regionserver should not get new regions. As it is written today, it's an integration test: it starts stops a cluster. The test would be more efficient if it would just check that the AssignmentManager does not use the drained region server; whatever the circumstances (bulk assign or not for example). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[ https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13773188#comment-13773188 ] Hudson commented on HBASE-7462: --- FAILURE: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #746 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/746/]) HBASE-7462 TestDrainingServer is an integration test. It should be a unit test instead (Gustavo Anatoly) (nkeywal: rev 1524995) * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestDrainingServer.java TestDrainingServer is an integration test. It should be a unit test instead --- Key: HBASE-7462 URL: https://issues.apache.org/jira/browse/HBASE-7462 Project: HBase Issue Type: Wish Components: test Affects Versions: 0.95.2 Reporter: Nicolas Liochon Assignee: Gustavo Anatoly Priority: Trivial Labels: noob Fix For: 0.98.0, 0.96.1 Attachments: 7462.v3.patch, HBASE-7462-v2.patch TestDrainingServer tests the function that allows to say that a regionserver should not get new regions. As it is written today, it's an integration test: it starts stops a cluster. The test would be more efficient if it would just check that the AssignmentManager does not use the drained region server; whatever the circumstances (bulk assign or not for example). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[ https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13769592#comment-13769592 ] Nicolas Liochon commented on HBASE-7462: The patch is ok. I've done some changes, all minor except one. See v3. I plan to commit it tomorrow. The test now takes 2 seconds instead of 38 seconds to run. Nice. Thanks Gustavo. TestDrainingServer is an integration test. It should be a unit test instead --- Key: HBASE-7462 URL: https://issues.apache.org/jira/browse/HBASE-7462 Project: HBase Issue Type: Wish Components: test Affects Versions: 0.95.2 Reporter: Nicolas Liochon Assignee: Gustavo Anatoly Priority: Trivial Labels: noob Attachments: 7462.v3.patch, HBASE-7462-v2.patch TestDrainingServer tests the function that allows to say that a regionserver should not get new regions. As it is written today, it's an integration test: it starts stops a cluster. The test would be more efficient if it would just check that the AssignmentManager does not use the drained region server; whatever the circumstances (bulk assign or not for example). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[ https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13769724#comment-13769724 ] Gustavo Anatoly commented on HBASE-7462: Thanks (Nicolas and Stack) for review the patch, for the patience and changes that you did. I hope has helped a little bit. TestDrainingServer is an integration test. It should be a unit test instead --- Key: HBASE-7462 URL: https://issues.apache.org/jira/browse/HBASE-7462 Project: HBase Issue Type: Wish Components: test Affects Versions: 0.95.2 Reporter: Nicolas Liochon Assignee: Gustavo Anatoly Priority: Trivial Labels: noob Attachments: 7462.v3.patch, HBASE-7462-v2.patch TestDrainingServer tests the function that allows to say that a regionserver should not get new regions. As it is written today, it's an integration test: it starts stops a cluster. The test would be more efficient if it would just check that the AssignmentManager does not use the drained region server; whatever the circumstances (bulk assign or not for example). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[ https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13750513#comment-13750513 ] Nicolas Liochon commented on HBASE-7462: Still in my todo list. Sorry for the delay. TestDrainingServer is an integration test. It should be a unit test instead --- Key: HBASE-7462 URL: https://issues.apache.org/jira/browse/HBASE-7462 Project: HBase Issue Type: Wish Components: test Affects Versions: 0.95.2 Reporter: Nicolas Liochon Assignee: Gustavo Anatoly Priority: Trivial Labels: noob Attachments: HBASE-7462-v2.patch TestDrainingServer tests the function that allows to say that a regionserver should not get new regions. As it is written today, it's an integration test: it starts stops a cluster. The test would be more efficient if it would just check that the AssignmentManager does not use the drained region server; whatever the circumstances (bulk assign or not for example). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[ https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13750686#comment-13750686 ] Gustavo Anatoly commented on HBASE-7462: Ok Nicolas :) don't worry. TestDrainingServer is an integration test. It should be a unit test instead --- Key: HBASE-7462 URL: https://issues.apache.org/jira/browse/HBASE-7462 Project: HBase Issue Type: Wish Components: test Affects Versions: 0.95.2 Reporter: Nicolas Liochon Assignee: Gustavo Anatoly Priority: Trivial Labels: noob Attachments: HBASE-7462-v2.patch TestDrainingServer tests the function that allows to say that a regionserver should not get new regions. As it is written today, it's an integration test: it starts stops a cluster. The test would be more efficient if it would just check that the AssignmentManager does not use the drained region server; whatever the circumstances (bulk assign or not for example). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[
https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13749705#comment-13749705
]
Hadoop QA commented on HBASE-7462:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12598658/HBASE-7462-v2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:red}-1 release audit{color}. The applied patch generated 2 release
audit warnings (more than the trunk's current 0 warnings).
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/6885//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6885//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6885//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6885//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6885//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6885//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6885//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6885//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6885//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6885//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/6885//console
This message is automatically generated.
TestDrainingServer is an integration test. It should be a unit test instead
---
Key: HBASE-7462
URL: https://issues.apache.org/jira/browse/HBASE-7462
Project: HBase
Issue Type: Wish
Components: test
Affects Versions: 0.95.2
Reporter: Nicolas Liochon
Assignee: Gustavo Anatoly
Priority: Trivial
Labels: noob
Attachments: HBASE-7462-v2.patch
TestDrainingServer tests the function that allows to say that a regionserver
should not get new regions.
As it is written today, it's an integration test: it starts stops a cluster.
The test would be more efficient if it would just check that the
AssignmentManager does not use the drained region server; whatever the
circumstances (bulk assign or not for example).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[
https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13748458#comment-13748458
]
Hadoop QA commented on HBASE-7462:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12598658/HBASE-7462-v2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.migration.TestNamespaceUpgrade
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/6857//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6857//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6857//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6857//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6857//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6857//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6857//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6857//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6857//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/6857//console
This message is automatically generated.
TestDrainingServer is an integration test. It should be a unit test instead
---
Key: HBASE-7462
URL: https://issues.apache.org/jira/browse/HBASE-7462
Project: HBase
Issue Type: Wish
Components: test
Affects Versions: 0.95.2
Reporter: Nicolas Liochon
Assignee: Gustavo Anatoly
Priority: Trivial
Labels: noob
Attachments: HBASE-7462-v2.patch
TestDrainingServer tests the function that allows to say that a regionserver
should not get new regions.
As it is written today, it's an integration test: it starts stops a cluster.
The test would be more efficient if it would just check that the
AssignmentManager does not use the drained region server; whatever the
circumstances (bulk assign or not for example).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[ https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13743197#comment-13743197 ] Gustavo Anatoly commented on HBASE-7462: Hi, Nicolas. Thanks for your comments, I fixed the code :). Therefore could you please review the patch? Thankful. TestDrainingServer is an integration test. It should be a unit test instead --- Key: HBASE-7462 URL: https://issues.apache.org/jira/browse/HBASE-7462 Project: HBase Issue Type: Wish Components: test Affects Versions: 0.95.2 Reporter: Nicolas Liochon Assignee: Gustavo Anatoly Priority: Trivial Labels: noob Attachments: HBASE-7462-v2.patch TestDrainingServer tests the function that allows to say that a regionserver should not get new regions. As it is written today, it's an integration test: it starts stops a cluster. The test would be more efficient if it would just check that the AssignmentManager does not use the drained region server; whatever the circumstances (bulk assign or not for example). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[
https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13738741#comment-13738741
]
Nicolas Liochon commented on HBASE-7462:
I haven't run it, but it seems ok. Here are some comments:
import with starts
= should be replaced by all imports (simplifie backports)
public void testAssignmentManagerDoesntUseDrainedServerWithBulkAssign() throws
ServiceException,
InterruptedException, IOException, KeeperException, NoSuchFieldException,
IllegalAccessException {
= Can be simplified by throwing Exception only
/**
* Put region opened on ZooKeeper
*
* @param zkWatcher
* @param serverName
* @param hregionInfo
* @throws KeeperException
* @throws InterruptedException
*/
= you can remove the @params here, as there is no documentation
As well, line length should be less than 100 chars. I'm not sure it's always
the case.
TestDrainingServer is an integration test. It should be a unit test instead
---
Key: HBASE-7462
URL: https://issues.apache.org/jira/browse/HBASE-7462
Project: HBase
Issue Type: Wish
Components: test
Affects Versions: 0.95.2
Reporter: Nicolas Liochon
Assignee: Gustavo Anatoly
Priority: Trivial
Labels: noob
Attachments: HBASE-7462-v1.patch
TestDrainingServer tests the function that allows to say that a regionserver
should not get new regions.
As it is written today, it's an integration test: it starts stops a cluster.
The test would be more efficient if it would just check that the
AssignmentManager does not use the drained region server; whatever the
circumstances (bulk assign or not for example).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[ https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13737613#comment-13737613 ] Gustavo Anatoly commented on HBASE-7462: Hi, Nicolas and Stack. Firstly sorry for delay, to submit a solution. My proposal is: http://goo.gl/CK4dLY and I could substitute the old tests on TestDrainingServer for the test above? TestDrainingServer is an integration test. It should be a unit test instead --- Key: HBASE-7462 URL: https://issues.apache.org/jira/browse/HBASE-7462 Project: HBase Issue Type: Wish Components: test Affects Versions: 0.95.2 Reporter: Nicolas Liochon Assignee: Gustavo Anatoly Priority: Trivial Labels: noob Attachments: HBASE-7462-v1.patch TestDrainingServer tests the function that allows to say that a regionserver should not get new regions. As it is written today, it's an integration test: it starts stops a cluster. The test would be more efficient if it would just check that the AssignmentManager does not use the drained region server; whatever the circumstances (bulk assign or not for example). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[ https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13685468#comment-13685468 ] Gustavo Anatoly commented on HBASE-7462: Hi, Nicolas. I understand the reasons, you are right. Yesterday after read the commentaries, I tried to use only startMiniZKCluster() instead cluster, but when assigned the region the path (NoNodeException) /hbase/region-in-trasition/encoded_region not founded error is throwed, with this error I found some example to create a node using RecoverableZooKeeper#create but without success, I'm yet working to fix it. This task it's interesting, cause I'm learning a lot. TestDrainingServer is an integration test. It should be a unit test instead --- Key: HBASE-7462 URL: https://issues.apache.org/jira/browse/HBASE-7462 Project: HBase Issue Type: Wish Components: test Affects Versions: 0.95.2 Reporter: Nicolas Liochon Assignee: Gustavo Anatoly Priority: Trivial Labels: noob Attachments: HBASE-7462-v1.patch TestDrainingServer tests the function that allows to say that a regionserver should not get new regions. As it is written today, it's an integration test: it starts stops a cluster. The test would be more efficient if it would just check that the AssignmentManager does not use the drained region server; whatever the circumstances (bulk assign or not for example). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[ https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13684722#comment-13684722 ] Gustavo Anatoly commented on HBASE-7462: Thanks Stack and Thanks Nicolas, I understand that both are busy, don't worry about the delay to review. :) Stack, I will fix it putting the Mockito declaration after instantiate the AM, but I don't understand the reason to remove old tests (forgive if my doubts is much primary) and about the cluster I tried mock it, but without success. Nicolas, unfortunately the test depends the something on the boot :/ . I will work to run tests without the cluster. Thankful for the patience. TestDrainingServer is an integration test. It should be a unit test instead --- Key: HBASE-7462 URL: https://issues.apache.org/jira/browse/HBASE-7462 Project: HBase Issue Type: Wish Components: test Affects Versions: 0.95.2 Reporter: Nicolas Liochon Assignee: Gustavo Anatoly Priority: Trivial Labels: noob Attachments: HBASE-7462-v1.patch TestDrainingServer tests the function that allows to say that a regionserver should not get new regions. As it is written today, it's an integration test: it starts stops a cluster. The test would be more efficient if it would just check that the AssignmentManager does not use the drained region server; whatever the circumstances (bulk assign or not for example). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[ https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13684928#comment-13684928 ] Nicolas Liochon commented on HBASE-7462: For removing the cluster, it's the whole point. There are two reasons why it's better not to have the cluster: - it makes the tests faster, and as HBase grows the tests takes longer, so anything that lower the test time is great. - it makes the tests simpler. For example, when you debug a test with the cluster you have to manage zookeeper timeouts, find your way around 200 threads, etc. Thanks for spending time on this, if you make it work it will help up. TestDrainingServer is an integration test. It should be a unit test instead --- Key: HBASE-7462 URL: https://issues.apache.org/jira/browse/HBASE-7462 Project: HBase Issue Type: Wish Components: test Affects Versions: 0.95.2 Reporter: Nicolas Liochon Assignee: Gustavo Anatoly Priority: Trivial Labels: noob Attachments: HBASE-7462-v1.patch TestDrainingServer tests the function that allows to say that a regionserver should not get new regions. As it is written today, it's an integration test: it starts stops a cluster. The test would be more efficient if it would just check that the AssignmentManager does not use the drained region server; whatever the circumstances (bulk assign or not for example). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[ https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13683658#comment-13683658 ] Gustavo Anatoly commented on HBASE-7462: Hi, Nicolas. Could you please review the patch? Thankful. TestDrainingServer is an integration test. It should be a unit test instead --- Key: HBASE-7462 URL: https://issues.apache.org/jira/browse/HBASE-7462 Project: HBase Issue Type: Wish Components: test Affects Versions: 0.95.2 Reporter: Nicolas Liochon Assignee: Gustavo Anatoly Priority: Trivial Labels: noob Attachments: HBASE-7462-v1.patch TestDrainingServer tests the function that allows to say that a regionserver should not get new regions. As it is written today, it's an integration test: it starts stops a cluster. The test would be more efficient if it would just check that the AssignmentManager does not use the drained region server; whatever the circumstances (bulk assign or not for example). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[ https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13684059#comment-13684059 ] stack commented on HBASE-7462: -- This looks good [~gustavoanatoly] Is this ok? +Mockito.when(master.getAssignmentManager()).thenReturn(am); + +am = new AssignmentManager(server, serverManager, catalogTracker, +balancer, startupMasterExecutor(mockExecutorService), null, null); In other words adding the am to the mock but only in the line after actually creating the AssignmentManager? Should the order be swapped? Do you have to remove the old TestDrainingServer tests? The ones that spin up a cluster? TestDrainingServer is an integration test. It should be a unit test instead --- Key: HBASE-7462 URL: https://issues.apache.org/jira/browse/HBASE-7462 Project: HBase Issue Type: Wish Components: test Affects Versions: 0.95.2 Reporter: Nicolas Liochon Assignee: Gustavo Anatoly Priority: Trivial Labels: noob Attachments: HBASE-7462-v1.patch TestDrainingServer tests the function that allows to say that a regionserver should not get new regions. As it is written today, it's an integration test: it starts stops a cluster. The test would be more efficient if it would just check that the AssignmentManager does not use the drained region server; whatever the circumstances (bulk assign or not for example). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[ https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13684071#comment-13684071 ] Nicolas Liochon commented on HBASE-7462: Thanks Stack for the review. Sorry Gustavo for the delay, but your patch is in good hands now. I think we should remove the test that depends on the cluster if we have the right coverage: this will make our tests suite better. TestDrainingServer is an integration test. It should be a unit test instead --- Key: HBASE-7462 URL: https://issues.apache.org/jira/browse/HBASE-7462 Project: HBase Issue Type: Wish Components: test Affects Versions: 0.95.2 Reporter: Nicolas Liochon Assignee: Gustavo Anatoly Priority: Trivial Labels: noob Attachments: HBASE-7462-v1.patch TestDrainingServer tests the function that allows to say that a regionserver should not get new regions. As it is written today, it's an integration test: it starts stops a cluster. The test would be more efficient if it would just check that the AssignmentManager does not use the drained region server; whatever the circumstances (bulk assign or not for example). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[
https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13682067#comment-13682067
]
Hadoop QA commented on HBASE-7462:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12587514/HBASE-7462-v1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/6025//console
This message is automatically generated.
TestDrainingServer is an integration test. It should be a unit test instead
---
Key: HBASE-7462
URL: https://issues.apache.org/jira/browse/HBASE-7462
Project: HBase
Issue Type: Wish
Components: test
Affects Versions: 0.95.2
Reporter: Nicolas Liochon
Priority: Trivial
Labels: noob
Attachments: HBASE-7462-v1.patch
TestDrainingServer tests the function that allows to say that a regionserver
should not get new regions.
As it is written today, it's an integration test: it starts stops a cluster.
The test would be more efficient if it would just check that the
AssignmentManager does not use the drained region server; whatever the
circumstances (bulk assign or not for example).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[ https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13672484#comment-13672484 ] Gustavo Anatoly commented on HBASE-7462: Hi, Nicolas. After long time, I have some code. Could you please review the test? http://goo.gl/1WVj3 Thankful. TestDrainingServer is an integration test. It should be a unit test instead --- Key: HBASE-7462 URL: https://issues.apache.org/jira/browse/HBASE-7462 Project: HBase Issue Type: Wish Components: test Affects Versions: 0.95.2 Reporter: Nicolas Liochon Priority: Trivial Labels: noob TestDrainingServer tests the function that allows to say that a regionserver should not get new regions. As it is written today, it's an integration test: it starts stops a cluster. The test would be more efficient if it would just check that the AssignmentManager does not use the drained region server; whatever the circumstances (bulk assign or not for example). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[ https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13621893#comment-13621893 ] Nicolas Liochon commented on HBASE-7462: Yep, in many cases we do a mock for the master the regionservers, but not for ZooKeeper. As ZooKeeper starts/stops quickly it's not a big issue. TestDrainingServer is an integration test. It should be a unit test instead --- Key: HBASE-7462 URL: https://issues.apache.org/jira/browse/HBASE-7462 Project: HBase Issue Type: Wish Components: test Affects Versions: 0.96.0 Reporter: Nicolas Liochon Priority: Trivial Labels: noob TestDrainingServer tests the function that allows to say that a regionserver should not get new regions. As it is written today, it's an integration test: it starts stops a cluster. The test would be more efficient if it would just check that the AssignmentManager does not use the drained region server; whatever the circumstances (bulk assign or not for example). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[ https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13620718#comment-13620718 ] Nicolas Liochon commented on HBASE-7462: The stask seems to say that ZK is not started? I would expect this to be an error, as it's likely to need a starter mini cluster to work HMaster hMaster = TEST_UTIL.getMiniHBaseCluster().getMaster(); CollectionServerName servers = TEST_UTIL.getMiniHBaseCluster().getInitialClusterStatus().getServers(); Long sizeServedRegions = TEST_UTIL.getMiniHBaseCluster().countServedRegions(); TestDrainingServer is an integration test. It should be a unit test instead --- Key: HBASE-7462 URL: https://issues.apache.org/jira/browse/HBASE-7462 Project: HBase Issue Type: Wish Components: test Affects Versions: 0.96.0 Reporter: Nicolas Liochon Priority: Trivial Labels: noob TestDrainingServer tests the function that allows to say that a regionserver should not get new regions. As it is written today, it's an integration test: it starts stops a cluster. The test would be more efficient if it would just check that the AssignmentManager does not use the drained region server; whatever the circumstances (bulk assign or not for example). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[ https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13621667#comment-13621667 ] Gustavo Anatoly commented on HBASE-7462: Hi, Nicolas. I was thinking on the same way to use this, but I thought this stuff cannot be used, I did try mocking all HMaster and ZK, but the ZK constructor is inside HMaster, becoming hard to mocking and throwing connection loss. Ok, I will continue implementing adding this fragment of code to the test. Grateful for your pacience. TestDrainingServer is an integration test. It should be a unit test instead --- Key: HBASE-7462 URL: https://issues.apache.org/jira/browse/HBASE-7462 Project: HBase Issue Type: Wish Components: test Affects Versions: 0.96.0 Reporter: Nicolas Liochon Priority: Trivial Labels: noob TestDrainingServer tests the function that allows to say that a regionserver should not get new regions. As it is written today, it's an integration test: it starts stops a cluster. The test would be more efficient if it would just check that the AssignmentManager does not use the drained region server; whatever the circumstances (bulk assign or not for example). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[ https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13619603#comment-13619603 ] Nicolas Liochon commented on HBASE-7462: It's difficult to help without knowing the problem/error, the github comment just says This test doesn't work yet. TestDrainingServer is an integration test. It should be a unit test instead --- Key: HBASE-7462 URL: https://issues.apache.org/jira/browse/HBASE-7462 Project: HBase Issue Type: Wish Components: test Affects Versions: 0.96.0 Reporter: Nicolas Liochon Priority: Trivial Labels: noob TestDrainingServer tests the function that allows to say that a regionserver should not get new regions. As it is written today, it's an integration test: it starts stops a cluster. The test would be more efficient if it would just check that the AssignmentManager does not use the drained region server; whatever the circumstances (bulk assign or not for example). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[ https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13619985#comment-13619985 ] Gustavo Anatoly commented on HBASE-7462: Sorry... :/ The gist has been updated with the stack trace:[https://gist.github.com/gustavoanatoly/5282781] And first method without mocked class ([https://gist.github.com/gustavoanatoly/5282776]) it's ok? Thanks. TestDrainingServer is an integration test. It should be a unit test instead --- Key: HBASE-7462 URL: https://issues.apache.org/jira/browse/HBASE-7462 Project: HBase Issue Type: Wish Components: test Affects Versions: 0.96.0 Reporter: Nicolas Liochon Priority: Trivial Labels: noob TestDrainingServer tests the function that allows to say that a regionserver should not get new regions. As it is written today, it's an integration test: it starts stops a cluster. The test would be more efficient if it would just check that the AssignmentManager does not use the drained region server; whatever the circumstances (bulk assign or not for example). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[ https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618555#comment-13618555 ] Gustavo Anatoly commented on HBASE-7462: Hi, Nicolas. After a long time... I was able to get back. Could you please verify this unit test: [https://gist.github.com/gustavoanatoly/5282776] this approach it works, but mocking I'm facing some problems to finalize: [https://gist.github.com/gustavoanatoly/5282781] if you have a tip with this mocking test, I would be greatful. TestDrainingServer is an integration test. It should be a unit test instead --- Key: HBASE-7462 URL: https://issues.apache.org/jira/browse/HBASE-7462 Project: HBase Issue Type: Wish Components: test Affects Versions: 0.96.0 Reporter: Nicolas Liochon Priority: Trivial Labels: noob TestDrainingServer tests the function that allows to say that a regionserver should not get new regions. As it is written today, it's an integration test: it starts stops a cluster. The test would be more efficient if it would just check that the AssignmentManager does not use the drained region server; whatever the circumstances (bulk assign or not for example). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[ https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13590921#comment-13590921 ] Gustavo Anatoly commented on HBASE-7462: Hi, Nicolas. Could you help me with a doubt? Why AM#RegionStates#regionOnline doesn't verify destination server list on serverManager? My question is because, after put SERVERNAME_A on drained server list and call AM#RegionStates#regionOnLine(SERVERNAME_A, REGION_INFO), this region become onlined. Thanks. TestDrainingServer is an integration test. It should be a unit test instead --- Key: HBASE-7462 URL: https://issues.apache.org/jira/browse/HBASE-7462 Project: HBase Issue Type: Wish Components: test Affects Versions: 0.96.0 Reporter: nkeywal Priority: Trivial Labels: noob TestDrainingServer tests the function that allows to say that a regionserver should not get new regions. As it is written today, it's an integration test: it starts stops a cluster. The test would be more efficient if it would just check that the AssignmentManager does not use the drained region server; whatever the circumstances (bulk assign or not for example). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[ https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13590954#comment-13590954 ] stack commented on HBASE-7462: -- [~gustavoanatoly] When you say this, Could you help me with a doubt? Why AM#RegionStates#regionOnline doesn't verify destination server list on serverManager?, what are you thinking regionOnline should be doing? I am not clear. Thanks. TestDrainingServer is an integration test. It should be a unit test instead --- Key: HBASE-7462 URL: https://issues.apache.org/jira/browse/HBASE-7462 Project: HBase Issue Type: Wish Components: test Affects Versions: 0.96.0 Reporter: nkeywal Priority: Trivial Labels: noob TestDrainingServer tests the function that allows to say that a regionserver should not get new regions. As it is written today, it's an integration test: it starts stops a cluster. The test would be more efficient if it would just check that the AssignmentManager does not use the drained region server; whatever the circumstances (bulk assign or not for example). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[
https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13591197#comment-13591197
]
Gustavo Anatoly commented on HBASE-7462:
Hi, Stack.
Let me try explain better, when
serverManager.addServerToDrainList(SERVERNAME_A) is called this server cannot
be used to compose a region plan, my doubt is: When called
AM#RegionStates#regionOnline(SERVERNAME_A, REGION_INFO), I was thinking that
SERVERNAME_A should not be allowed, in this process to put this region online.
{code}
serverManager.addServerToDrainList(SERVERNAME_A);
am.assign(REGION_INFO, false);
am.getRegionStates().regionOnline(REGION_INFO);
am.getRegionStates().isRegionAssigned(REGION_INFO); // Should be false here?
{code}
Sorry, if my previous question did not have sense, I have a lot to learn, and
correct me if I wrong.
Thanks, for help.
TestDrainingServer is an integration test. It should be a unit test instead
---
Key: HBASE-7462
URL: https://issues.apache.org/jira/browse/HBASE-7462
Project: HBase
Issue Type: Wish
Components: test
Affects Versions: 0.96.0
Reporter: nkeywal
Priority: Trivial
Labels: noob
TestDrainingServer tests the function that allows to say that a regionserver
should not get new regions.
As it is written today, it's an integration test: it starts stops a cluster.
The test would be more efficient if it would just check that the
AssignmentManager does not use the drained region server; whatever the
circumstances (bulk assign or not for example).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[
https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13591201#comment-13591201
]
Gustavo Anatoly commented on HBASE-7462:
Please, consider {code}am.getRegionStates().regionOnline(REGION_INFO);{code} as
{code}am.getRegionStates().regionOnline(REGION_INFO, SERVERNAME_A){code}
TestDrainingServer is an integration test. It should be a unit test instead
---
Key: HBASE-7462
URL: https://issues.apache.org/jira/browse/HBASE-7462
Project: HBase
Issue Type: Wish
Components: test
Affects Versions: 0.96.0
Reporter: nkeywal
Priority: Trivial
Labels: noob
TestDrainingServer tests the function that allows to say that a regionserver
should not get new regions.
As it is written today, it's an integration test: it starts stops a cluster.
The test would be more efficient if it would just check that the
AssignmentManager does not use the drained region server; whatever the
circumstances (bulk assign or not for example).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[ https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13581902#comment-13581902 ] Gustavo Anatoly commented on HBASE-7462: Hi, Nicolas. The task didn't finished yet, because I'm trying fix interrupted exception when call AssignmentManager#assign(MapHRegionInfo, ServerName) and the other point is my delay to submit a patch, caused by learning curve to understand AM and ZK interaction. TestDrainingServer is an integration test. It should be a unit test instead --- Key: HBASE-7462 URL: https://issues.apache.org/jira/browse/HBASE-7462 Project: HBase Issue Type: Wish Components: test Affects Versions: 0.96.0 Reporter: nkeywal Priority: Trivial Labels: noob TestDrainingServer tests the function that allows to say that a regionserver should not get new regions. As it is written today, it's an integration test: it starts stops a cluster. The test would be more efficient if it would just check that the AssignmentManager does not use the drained region server; whatever the circumstances (bulk assign or not for example). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[ https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13575694#comment-13575694 ] nkeywal commented on HBASE-7462: We should not mock up the ZK itself, just the calls to ZK for this scenario. Ideally again, as it easier to say that to do :-) TestDrainingServer is an integration test. It should be a unit test instead --- Key: HBASE-7462 URL: https://issues.apache.org/jira/browse/HBASE-7462 Project: HBase Issue Type: Wish Components: test Affects Versions: 0.96.0 Reporter: nkeywal Priority: Trivial Labels: noob TestDrainingServer tests the function that allows to say that a regionserver should not get new regions. As it is written today, it's an integration test: it starts stops a cluster. The test would be more efficient if it would just check that the AssignmentManager does not use the drained region server; whatever the circumstances (bulk assign or not for example). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[ https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13573321#comment-13573321 ] nkeywal commented on HBASE-7462: It's likely better not to mock zookeeper. The best solution would be not to to depend on ZK at all, if it's possible. TestDrainingServer is an integration test. It should be a unit test instead --- Key: HBASE-7462 URL: https://issues.apache.org/jira/browse/HBASE-7462 Project: HBase Issue Type: Wish Components: test Affects Versions: 0.96.0 Reporter: nkeywal Priority: Trivial Labels: noob TestDrainingServer tests the function that allows to say that a regionserver should not get new regions. As it is written today, it's an integration test: it starts stops a cluster. The test would be more efficient if it would just check that the AssignmentManager does not use the drained region server; whatever the circumstances (bulk assign or not for example). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[ https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13573404#comment-13573404 ] Gustavo Anatoly commented on HBASE-7462: Ok Nicolas,I will follow your suggestion. But the reasons do not use all ZK mocked, it's because test focus is the AssignmentManager, call only especific pieces of codes of ZK? Therefore only mock ZK needed by AssignmentManager. Is correct? Thanks for help. TestDrainingServer is an integration test. It should be a unit test instead --- Key: HBASE-7462 URL: https://issues.apache.org/jira/browse/HBASE-7462 Project: HBase Issue Type: Wish Components: test Affects Versions: 0.96.0 Reporter: nkeywal Priority: Trivial Labels: noob TestDrainingServer tests the function that allows to say that a regionserver should not get new regions. As it is written today, it's an integration test: it starts stops a cluster. The test would be more efficient if it would just check that the AssignmentManager does not use the drained region server; whatever the circumstances (bulk assign or not for example). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[
https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13573007#comment-13573007
]
Gustavo Anatoly commented on HBASE-7462:
Hi, Nicolas.
I tried mock a cluster, but my knowledge is limited yet I had some exceptions,
so studying the TestAssigmentManager class I found this code:
{code}
@BeforeClass
public static void beforeClass() throws Exception {
HTU.startMiniZKCluster();
}
@AfterClass
public static void afterClass() throws IOException {
HTU.shutdownMiniZKCluster();
}
{code}
Can I use this stuff? Or I should mock ZooKeeper?
Thanks.
TestDrainingServer is an integration test. It should be a unit test instead
---
Key: HBASE-7462
URL: https://issues.apache.org/jira/browse/HBASE-7462
Project: HBase
Issue Type: Wish
Components: test
Affects Versions: 0.96.0
Reporter: nkeywal
Priority: Trivial
Labels: noob
TestDrainingServer tests the function that allows to say that a regionserver
should not get new regions.
As it is written today, it's an integration test: it starts stops a cluster.
The test would be more efficient if it would just check that the
AssignmentManager does not use the drained region server; whatever the
circumstances (bulk assign or not for example).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[ https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13565178#comment-13565178 ] nkeywal commented on HBASE-7462: Hi Gustavo, Yes. IIRC, TestAssignment is a good example. Then, the issue is tagged noob, but it's not that easy :-) TestDrainingServer is an integration test. It should be a unit test instead --- Key: HBASE-7462 URL: https://issues.apache.org/jira/browse/HBASE-7462 Project: HBase Issue Type: Wish Components: test Affects Versions: 0.96.0 Reporter: nkeywal Priority: Trivial Labels: noob TestDrainingServer tests the function that allows to say that a regionserver should not get new regions. As it is written today, it's an integration test: it starts stops a cluster. The test would be more efficient if it would just check that the AssignmentManager does not use the drained region server; whatever the circumstances (bulk assign or not for example). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[ https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13565287#comment-13565287 ] Gustavo Anatoly commented on HBASE-7462: Hi Nicolas, :) Great, I was studying the TestAssignmentManager, to try rewrite the test. About the issue tag, I'm noob here, but was feeling worse than the noob :), for don't understand completely this issue. I have to study more the HBase source. Thanks for help me. TestDrainingServer is an integration test. It should be a unit test instead --- Key: HBASE-7462 URL: https://issues.apache.org/jira/browse/HBASE-7462 Project: HBase Issue Type: Wish Components: test Affects Versions: 0.96.0 Reporter: nkeywal Priority: Trivial Labels: noob TestDrainingServer tests the function that allows to say that a regionserver should not get new regions. As it is written today, it's an integration test: it starts stops a cluster. The test would be more efficient if it would just check that the AssignmentManager does not use the drained region server; whatever the circumstances (bulk assign or not for example). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[ https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13564294#comment-13564294 ] Gustavo Anatoly commented on HBASE-7462: Hi, Nicolas. Could you please, check if the test is correct? https://gist.github.com/4655579 Thanks. TestDrainingServer is an integration test. It should be a unit test instead --- Key: HBASE-7462 URL: https://issues.apache.org/jira/browse/HBASE-7462 Project: HBase Issue Type: Wish Components: test Affects Versions: 0.96.0 Reporter: nkeywal Priority: Trivial Labels: noob TestDrainingServer tests the function that allows to say that a regionserver should not get new regions. As it is written today, it's an integration test: it starts stops a cluster. The test would be more efficient if it would just check that the AssignmentManager does not use the drained region server; whatever the circumstances (bulk assign or not for example). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[ https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13564297#comment-13564297 ] nkeywal commented on HBASE-7462: The idea of the JIRA is to not create a cluster; but mocking it: this saves the burden of starting / stopping a server. So you can't use stuff like HMaster master = TEST_UTIL.getHBaseCluster().getMaster(); TestDrainingServer is an integration test. It should be a unit test instead --- Key: HBASE-7462 URL: https://issues.apache.org/jira/browse/HBASE-7462 Project: HBase Issue Type: Wish Components: test Affects Versions: 0.96.0 Reporter: nkeywal Priority: Trivial Labels: noob TestDrainingServer tests the function that allows to say that a regionserver should not get new regions. As it is written today, it's an integration test: it starts stops a cluster. The test would be more efficient if it would just check that the AssignmentManager does not use the drained region server; whatever the circumstances (bulk assign or not for example). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[
https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13564316#comment-13564316
]
Gustavo Anatoly commented on HBASE-7462:
Hi, Nicolas.
Ok understood. I should use MockServer class? To do this?
{code} Server server = new MockServer(hut); {code}
I was thinking in this steps:
* Start mocking server;
* Save Region Servers on start;
* Add RS to drained server list;
* Save Region Servers on stop;
* Test if AssignmentManager it's using some drained server;
Thanks.
TestDrainingServer is an integration test. It should be a unit test instead
---
Key: HBASE-7462
URL: https://issues.apache.org/jira/browse/HBASE-7462
Project: HBase
Issue Type: Wish
Components: test
Affects Versions: 0.96.0
Reporter: nkeywal
Priority: Trivial
Labels: noob
TestDrainingServer tests the function that allows to say that a regionserver
should not get new regions.
As it is written today, it's an integration test: it starts stops a cluster.
The test would be more efficient if it would just check that the
AssignmentManager does not use the drained region server; whatever the
circumstances (bulk assign or not for example).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7462) TestDrainingServer is an integration test. It should be a unit test instead
[
https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13565030#comment-13565030
]
Gustavo Anatoly commented on HBASE-7462:
Hi, Nicolas.
I was searching on test source, and I found this way to mocking server:
{code} MasterServices ms = Mockito.mock(MasterService.class); {code}
I was thinking to use MasterServices, because it has the methods to get
instance of AssignmentManager and ServerManager, that is everything what the
tests need. That is correct?
Thanks.
TestDrainingServer is an integration test. It should be a unit test instead
---
Key: HBASE-7462
URL: https://issues.apache.org/jira/browse/HBASE-7462
Project: HBase
Issue Type: Wish
Components: test
Affects Versions: 0.96.0
Reporter: nkeywal
Priority: Trivial
Labels: noob
TestDrainingServer tests the function that allows to say that a regionserver
should not get new regions.
As it is written today, it's an integration test: it starts stops a cluster.
The test would be more efficient if it would just check that the
AssignmentManager does not use the drained region server; whatever the
circumstances (bulk assign or not for example).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
