[jira] [Updated] (HIVE-15900) Beeline prints tez job progress in stdout instead of stderr
[ https://issues.apache.org/jira/browse/HIVE-15900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thejas M Nair updated HIVE-15900: - Resolution: Fixed Fix Version/s: 2.2.0 Status: Resolved (was: Patch Available) Thanks for the review [~daijy] [~anishek] > Beeline prints tez job progress in stdout instead of stderr > --- > > Key: HIVE-15900 > URL: https://issues.apache.org/jira/browse/HIVE-15900 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Affects Versions: 2.2.0 >Reporter: Aswathy Chellammal Sreekumar >Assignee: Thejas M Nair > Fix For: 2.2.0 > > Attachments: HIVE-15900.1.patch, HIVE-15900.2.patch, > HIVE-15900.3.patch, HIVE-15900.3.patch, std_out > > > Tez job progress messages are getting updated to stdout instead of stderr > Attaching output file for below command, with the tez job status printed > $HIVE_HOME/bin/beeline -n -p -u "--outputformat=tsv -e "analyze table studenttab10k compute statistics;" > > stdout -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15917) incorrect error handling from BackgroundWork can cause beeline query to hang
[ https://issues.apache.org/jira/browse/HIVE-15917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870557#comment-15870557 ] Thejas M Nair commented on HIVE-15917: -- cc [~anishek] > incorrect error handling from BackgroundWork can cause beeline query to hang > > > Key: HIVE-15917 > URL: https://issues.apache.org/jira/browse/HIVE-15917 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Attachments: HIVE-15917.01.patch, HIVE-15917.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15910) Improvements in Hive Unit Test by using In-memory Derby DB
[ https://issues.apache.org/jira/browse/HIVE-15910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870399#comment-15870399 ] Thejas M Nair commented on HIVE-15910: -- In addition, I think we should look at the methods called in CompactorTest constructor. CompactorTest constructor would be called for every test function. Ie it is equivalent of '@Before' and not '@BeforeClass' . It seems like some what is done there makes more sense in a '@BeforeClass' , so that its just done once. But I haven't taken a very close look at the tests, so I am not sure. Maybe this should be addressed in a follow up jira, and not this one. cc [~ekoifman] [~wzheng] [~alangates] {code} ms = new HiveMetaStoreClient(conf); txnHandler = TxnUtils.getTxnStore(conf); tmpdir = new File(System.getProperty("java.io.tmpdir") + System.getProperty("file.separator") + "compactor_test_tables"); tmpdir.mkdir(); tmpdir.deleteOnExit(); {code} > Improvements in Hive Unit Test by using In-memory Derby DB > -- > > Key: HIVE-15910 > URL: https://issues.apache.org/jira/browse/HIVE-15910 > Project: Hive > Issue Type: Test > Components: Tests >Reporter: Sankar Hariappan >Assignee: Wei Zheng > Attachments: HIVE-15910.01.patch, HIVE-15910.05.patch, > HIVE-15910.2.patch, HIVE-15910.3.patch, HIVE-15910.4.patch > > > Hive UT currently uses Derby DB with storage on disk which have some > practical problems. > 1. The run-time of Hive unit tests are high as need to operate on the disk > quite often. > 2. It can cause conflict if multiple test cases operates on the same table > name (such as table being created already exist). > To solve these problems, we shall use an in-memory storage option of Derby DB > which can be even persisted if the test case demands that. > https://db.apache.org/derby/docs/10.8/devguide/cdevdvlpinmemdb.html -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15910) Improvements in Hive Unit Test by using In-memory Derby DB
[ https://issues.apache.org/jira/browse/HIVE-15910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870372#comment-15870372 ] Thejas M Nair commented on HIVE-15910: -- Added a comment in github pull request. Its simpler to just delete the temp dir where all tables are being created. Also realized, that tmpdir.deleteOnExit() doesn't work unless the dir is empty. That call would be useless. > Improvements in Hive Unit Test by using In-memory Derby DB > -- > > Key: HIVE-15910 > URL: https://issues.apache.org/jira/browse/HIVE-15910 > Project: Hive > Issue Type: Test > Components: Tests >Reporter: Sankar Hariappan >Assignee: Wei Zheng > Attachments: HIVE-15910.01.patch, HIVE-15910.05.patch, > HIVE-15910.2.patch, HIVE-15910.3.patch, HIVE-15910.4.patch > > > Hive UT currently uses Derby DB with storage on disk which have some > practical problems. > 1. The run-time of Hive unit tests are high as need to operate on the disk > quite often. > 2. It can cause conflict if multiple test cases operates on the same table > name (such as table being created already exist). > To solve these problems, we shall use an in-memory storage option of Derby DB > which can be even persisted if the test case demands that. > https://db.apache.org/derby/docs/10.8/devguide/cdevdvlpinmemdb.html -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-10562) Add versioning/format mechanism to NOTIFICATION_LOG entries, expand MESSAGE size
[ https://issues.apache.org/jira/browse/HIVE-10562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869171#comment-15869171 ] Thejas M Nair commented on HIVE-10562: -- [~spena] For some reason the tests for metastore schema upgrade in HIVE-9800 didn't get kicked off in this case. Any idea why ? > Add versioning/format mechanism to NOTIFICATION_LOG entries, expand MESSAGE > size > > > Key: HIVE-10562 > URL: https://issues.apache.org/jira/browse/HIVE-10562 > Project: Hive > Issue Type: Sub-task > Components: Import/Export >Affects Versions: 1.2.0 >Reporter: Sushanth Sowmyan >Assignee: Sushanth Sowmyan > Fix For: 2.2.0 > > Attachments: HIVE-10562.2.patch, HIVE-10562.3.patch, > HIVE-10562.4.patch, HIVE-10562.5.patch, HIVE-10562.patch > > > Currently, we have a JSON encoded message being stored in the > NOTIFICATION_LOG table. > If we want to be future proof, we need to allow for versioning of this > message, since we might change what gets stored in the message. A prime > example of what we'd want to change is as in HIVE-10393. > MessageFactory already has stubs to allow for versioning of messages, and we > could expand on this further in the future. NotificationListener currently > encodes the message version into the header for the JMS message it sends, > which seems to be the right place for a message version (instead of being > contained in the message, for eg.). > So, we should have a similar ability for DbEventListener as well, and the > place this makes the most sense is to and add a version column to the > NOTIFICATION_LOG table. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15846) Relocate more dependencies (e.g. org.apache.zookeeper) for JDBC uber jar
[ https://issues.apache.org/jira/browse/HIVE-15846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869159#comment-15869159 ] Thejas M Nair commented on HIVE-15846: -- [~taoli-hwx] The patch isn't applying on master anymore. Can you please take a look ? > Relocate more dependencies (e.g. org.apache.zookeeper) for JDBC uber jar > > > Key: HIVE-15846 > URL: https://issues.apache.org/jira/browse/HIVE-15846 > Project: Hive > Issue Type: Bug >Reporter: Tao Li >Assignee: Tao Li > Attachments: HIVE-15846.1.patch, HIVE-15846.2.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15931) JDBC: Improve logging when using ZooKeeper
[ https://issues.apache.org/jira/browse/HIVE-15931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869156#comment-15869156 ] Thejas M Nair commented on HIVE-15931: -- [~vgumashta] Can you please include a reviewboard link or github pull request ? > JDBC: Improve logging when using ZooKeeper > -- > > Key: HIVE-15931 > URL: https://issues.apache.org/jira/browse/HIVE-15931 > Project: Hive > Issue Type: Bug > Components: JDBC >Affects Versions: 2.2.0 >Reporter: Vaibhav Gumashta >Assignee: Vaibhav Gumashta > Attachments: HIVE-15931.1.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15900) Beeline prints tez job progress in stdout instead of stderr
[ https://issues.apache.org/jira/browse/HIVE-15900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869119#comment-15869119 ] Thejas M Nair commented on HIVE-15900: -- Attaching same file again, many of the failed test pass locally. > Beeline prints tez job progress in stdout instead of stderr > --- > > Key: HIVE-15900 > URL: https://issues.apache.org/jira/browse/HIVE-15900 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Affects Versions: 2.2.0 >Reporter: Aswathy Chellammal Sreekumar >Assignee: Thejas M Nair > Attachments: HIVE-15900.1.patch, HIVE-15900.2.patch, > HIVE-15900.3.patch, HIVE-15900.3.patch, std_out > > > Tez job progress messages are getting updated to stdout instead of stderr > Attaching output file for below command, with the tez job status printed > $HIVE_HOME/bin/beeline -n -p -u "--outputformat=tsv -e "analyze table studenttab10k compute statistics;" > > stdout -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15900) Beeline prints tez job progress in stdout instead of stderr
[ https://issues.apache.org/jira/browse/HIVE-15900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thejas M Nair updated HIVE-15900: - Attachment: HIVE-15900.3.patch > Beeline prints tez job progress in stdout instead of stderr > --- > > Key: HIVE-15900 > URL: https://issues.apache.org/jira/browse/HIVE-15900 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Affects Versions: 2.2.0 >Reporter: Aswathy Chellammal Sreekumar >Assignee: Thejas M Nair > Attachments: HIVE-15900.1.patch, HIVE-15900.2.patch, > HIVE-15900.3.patch, HIVE-15900.3.patch, std_out > > > Tez job progress messages are getting updated to stdout instead of stderr > Attaching output file for below command, with the tez job status printed > $HIVE_HOME/bin/beeline -n -p -u "--outputformat=tsv -e "analyze table studenttab10k compute statistics;" > > stdout -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15900) Beeline prints tez job progress in stdout instead of stderr
[ https://issues.apache.org/jira/browse/HIVE-15900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868477#comment-15868477 ] Thejas M Nair commented on HIVE-15900: -- Attached 3.patch addressing review comments and fixing a test case (testShowDbInPrompt). > Beeline prints tez job progress in stdout instead of stderr > --- > > Key: HIVE-15900 > URL: https://issues.apache.org/jira/browse/HIVE-15900 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Affects Versions: 2.2.0 >Reporter: Aswathy Chellammal Sreekumar >Assignee: Thejas M Nair > Attachments: HIVE-15900.1.patch, HIVE-15900.2.patch, > HIVE-15900.3.patch, std_out > > > Tez job progress messages are getting updated to stdout instead of stderr > Attaching output file for below command, with the tez job status printed > $HIVE_HOME/bin/beeline -n -p -u "--outputformat=tsv -e "analyze table studenttab10k compute statistics;" > > stdout -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15900) Beeline prints tez job progress in stdout instead of stderr
[ https://issues.apache.org/jira/browse/HIVE-15900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thejas M Nair updated HIVE-15900: - Attachment: HIVE-15900.3.patch > Beeline prints tez job progress in stdout instead of stderr > --- > > Key: HIVE-15900 > URL: https://issues.apache.org/jira/browse/HIVE-15900 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Affects Versions: 2.2.0 >Reporter: Aswathy Chellammal Sreekumar >Assignee: Thejas M Nair > Attachments: HIVE-15900.1.patch, HIVE-15900.2.patch, > HIVE-15900.3.patch, std_out > > > Tez job progress messages are getting updated to stdout instead of stderr > Attaching output file for below command, with the tez job status printed > $HIVE_HOME/bin/beeline -n -p -u "--outputformat=tsv -e "analyze table studenttab10k compute statistics;" > > stdout -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15900) Beeline prints tez job progress in stdout instead of stderr
[ https://issues.apache.org/jira/browse/HIVE-15900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thejas M Nair updated HIVE-15900: - Affects Version/s: (was: 2.1.0) 2.2.0 > Beeline prints tez job progress in stdout instead of stderr > --- > > Key: HIVE-15900 > URL: https://issues.apache.org/jira/browse/HIVE-15900 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Affects Versions: 2.2.0 >Reporter: Aswathy Chellammal Sreekumar >Assignee: Thejas M Nair > Attachments: HIVE-15900.1.patch, HIVE-15900.2.patch, std_out > > > Tez job progress messages are getting updated to stdout instead of stderr > Attaching output file for below command, with the tez job status printed > $HIVE_HOME/bin/beeline -n -p -u "--outputformat=tsv -e "analyze table studenttab10k compute statistics;" > > stdout -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15900) Beeline prints tez job progress in stdout instead of stderr
[ https://issues.apache.org/jira/browse/HIVE-15900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thejas M Nair updated HIVE-15900: - Status: Patch Available (was: Open) > Beeline prints tez job progress in stdout instead of stderr > --- > > Key: HIVE-15900 > URL: https://issues.apache.org/jira/browse/HIVE-15900 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Affects Versions: 2.1.0 >Reporter: Aswathy Chellammal Sreekumar >Assignee: Thejas M Nair > Attachments: HIVE-15900.1.patch, HIVE-15900.2.patch, std_out > > > Tez job progress messages are getting updated to stdout instead of stderr > Attaching output file for below command, with the tez job status printed > $HIVE_HOME/bin/beeline -n -p -u "--outputformat=tsv -e "analyze table studenttab10k compute statistics;" > > stdout -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15900) Beeline prints tez job progress in stdout instead of stderr
[ https://issues.apache.org/jira/browse/HIVE-15900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thejas M Nair updated HIVE-15900: - Attachment: HIVE-15900.2.patch Updated patch to address review comments > Beeline prints tez job progress in stdout instead of stderr > --- > > Key: HIVE-15900 > URL: https://issues.apache.org/jira/browse/HIVE-15900 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Affects Versions: 2.1.0 >Reporter: Aswathy Chellammal Sreekumar >Assignee: Thejas M Nair > Attachments: HIVE-15900.1.patch, HIVE-15900.2.patch, std_out > > > Tez job progress messages are getting updated to stdout instead of stderr > Attaching output file for below command, with the tez job status printed > $HIVE_HOME/bin/beeline -n -p -u "--outputformat=tsv -e "analyze table studenttab10k compute statistics;" > > stdout -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15900) Beeline prints tez job progress in stdout instead of stderr
[ https://issues.apache.org/jira/browse/HIVE-15900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15867165#comment-15867165 ] Thejas M Nair commented on HIVE-15900: -- As part of the adding test for the fix, I also refactored TestBeeLineWithArgs.java so that it checks for the expected strings in a specific output stream (stdout vs stderr). > Beeline prints tez job progress in stdout instead of stderr > --- > > Key: HIVE-15900 > URL: https://issues.apache.org/jira/browse/HIVE-15900 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Affects Versions: 2.1.0 >Reporter: Aswathy Chellammal Sreekumar >Assignee: Thejas M Nair > Attachments: HIVE-15900.1.patch, std_out > > > Tez job progress messages are getting updated to stdout instead of stderr > Attaching output file for below command, with the tez job status printed > $HIVE_HOME/bin/beeline -n -p -u "--outputformat=tsv -e "analyze table studenttab10k compute statistics;" > > stdout -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15900) Beeline prints tez job progress in stdout instead of stderr
[ https://issues.apache.org/jira/browse/HIVE-15900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thejas M Nair updated HIVE-15900: - Attachment: HIVE-15900.1.patch > Beeline prints tez job progress in stdout instead of stderr > --- > > Key: HIVE-15900 > URL: https://issues.apache.org/jira/browse/HIVE-15900 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Affects Versions: 2.1.0 >Reporter: Aswathy Chellammal Sreekumar >Assignee: Thejas M Nair > Attachments: HIVE-15900.1.patch, std_out > > > Tez job progress messages are getting updated to stdout instead of stderr > Attaching output file for below command, with the tez job status printed > $HIVE_HOME/bin/beeline -n -p -u "--outputformat=tsv -e "analyze table studenttab10k compute statistics;" > > stdout -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (HIVE-15900) Beeline prints tez job progress in stdout instead of stderr
[ https://issues.apache.org/jira/browse/HIVE-15900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thejas M Nair reassigned HIVE-15900: Assignee: Thejas M Nair > Beeline prints tez job progress in stdout instead of stderr > --- > > Key: HIVE-15900 > URL: https://issues.apache.org/jira/browse/HIVE-15900 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Affects Versions: 2.1.0 >Reporter: Aswathy Chellammal Sreekumar >Assignee: Thejas M Nair > Attachments: std_out > > > Tez job progress messages are getting updated to stdout instead of stderr > Attaching output file for below command, with the tez job status printed > $HIVE_HOME/bin/beeline -n -p -u "--outputformat=tsv -e "analyze table studenttab10k compute statistics;" > > stdout -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15900) Beeline prints tez job progress in stdout instead of stderr
[ https://issues.apache.org/jira/browse/HIVE-15900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15867159#comment-15867159 ] Thejas M Nair commented on HIVE-15900: -- [~daijy] [~anishek] Can you please review ? > Beeline prints tez job progress in stdout instead of stderr > --- > > Key: HIVE-15900 > URL: https://issues.apache.org/jira/browse/HIVE-15900 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Affects Versions: 2.1.0 >Reporter: Aswathy Chellammal Sreekumar > Attachments: std_out > > > Tez job progress messages are getting updated to stdout instead of stderr > Attaching output file for below command, with the tez job status printed > $HIVE_HOME/bin/beeline -n -p -u "--outputformat=tsv -e "analyze table studenttab10k compute statistics;" > > stdout -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15910) Improvements in Hive Unit Test by using In-memory Derby DB
[ https://issues.apache.org/jira/browse/HIVE-15910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15866271#comment-15866271 ] Thejas M Nair commented on HIVE-15910: -- [~wzheng] [~sankarh] TestWorker failures seem to be new and likely related to this change. Wei, any thoughts on why it cause those to fail ? Are we spawning another process from those ? We could change the config for those tests if necessary. > Improvements in Hive Unit Test by using In-memory Derby DB > -- > > Key: HIVE-15910 > URL: https://issues.apache.org/jira/browse/HIVE-15910 > Project: Hive > Issue Type: Test > Components: Tests >Reporter: Sankar Hariappan >Assignee: Sankar Hariappan > Attachments: HIVE-15910.01.patch > > > Hive UT currently uses Derby DB with storage on disk which have some > practical problems. > 1. The run-time of Hive unit tests are high as need to operate on the disk > quite often. > 2. It can cause conflict if multiple test cases operates on the same table > name (such as table being created already exist). > To solve these problems, we shall use an in-memory storage option of Derby DB > which can be even persisted if the test case demands that. > https://db.apache.org/derby/docs/10.8/devguide/cdevdvlpinmemdb.html -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15906) thrift code regeneration to include new protocol version
[ https://issues.apache.org/jira/browse/HIVE-15906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thejas M Nair updated HIVE-15906: - Resolution: Fixed Status: Resolved (was: Patch Available) Patch committed to master branch. Thanks [~anishek] > thrift code regeneration to include new protocol version > > > Key: HIVE-15906 > URL: https://issues.apache.org/jira/browse/HIVE-15906 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Affects Versions: 2.2.0 >Reporter: anishek >Assignee: anishek >Priority: Critical > Fix For: 2.2.0 > > Attachments: HIVE-15906.1.patch, HIVE-15906.2.patch > > > HIVE-15473 changed the protocol version in thrift file. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15889) LLAP: Some tasks still run after hive cli is shutdown
[ https://issues.apache.org/jira/browse/HIVE-15889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865108#comment-15865108 ] Thejas M Nair commented on HIVE-15889: -- Why are we having to use reflection here ? (I could be missing something that should be obvious, looks like was introduced long ago in HIVE-8393) > LLAP: Some tasks still run after hive cli is shutdown > - > > Key: HIVE-15889 > URL: https://issues.apache.org/jira/browse/HIVE-15889 > Project: Hive > Issue Type: Bug >Reporter: Rajesh Balamohan >Assignee: Rajesh Balamohan > Fix For: 2.2.0 > > Attachments: HIVE-15889.1.patch, HIVE-15889.2.patch, > HIVE-15889.3.patch > > > E.g: In cross product case, the tight loop in merge join operator ignores any > interrupt or abort flag checks, causing the tasks to be in running state even > when the client cli is quit. > intensionally written cross product query to simulate this. > {noformat} > hive> select count(1) from lineitem, orders;; > {noformat} > Even when the cli is quit, LLAP would continue executing the task for quite > sometime. E.g stack trace > {noformat} > "TezTaskRunner" #1945 daemon prio=5 os_prio=0 tid=0x7fe9e43a5000 > nid=0x4c8 runnable [0x7fc8d881b000] >java.lang.Thread.State: RUNNABLE > at > org.apache.hadoop.hive.serde2.objectinspector.ObjectInspectorUtils.copyToStandardObject(ObjectInspectorUtils.java:453) > at > org.apache.hadoop.hive.ql.exec.CommonMergeJoinOperator.mergeJoinComputeKeys(CommonMergeJoinOperator.java:603) > at > org.apache.hadoop.hive.ql.exec.CommonMergeJoinOperator.process(CommonMergeJoinOperator.java:207) > at > org.apache.hadoop.hive.ql.exec.tez.ReduceRecordSource$GroupIterator.next(ReduceRecordSource.java:351) > at > org.apache.hadoop.hive.ql.exec.tez.ReduceRecordSource.pushRecord(ReduceRecordSource.java:282) > at > org.apache.hadoop.hive.ql.exec.CommonMergeJoinOperator.fetchOneRow(CommonMergeJoinOperator.java:410) > at > org.apache.hadoop.hive.ql.exec.CommonMergeJoinOperator.fetchNextGroup(CommonMergeJoinOperator.java:381) > at > org.apache.hadoop.hive.ql.exec.CommonMergeJoinOperator.doFirstFetchIfNeeded(CommonMergeJoinOperator.java:491) > at > org.apache.hadoop.hive.ql.exec.CommonMergeJoinOperator.process(CommonMergeJoinOperator.java:209) > at > org.apache.hadoop.hive.ql.exec.tez.ReduceRecordSource$GroupIterator.next(ReduceRecordSource.java:351) > at > org.apache.hadoop.hive.ql.exec.tez.ReduceRecordSource.pushRecord(ReduceRecordSource.java:282) > at > org.apache.hadoop.hive.ql.exec.tez.ReduceRecordProcessor.run(ReduceRecordProcessor.java:319) > at > org.apache.hadoop.hive.ql.exec.tez.TezProcessor.initializeAndRunProcessor(TezProcessor.java:185) > at > org.apache.hadoop.hive.ql.exec.tez.TezProcessor.run(TezProcessor.java:168) > at > org.apache.tez.runtime.LogicalIOProcessorRuntimeTask.run(LogicalIOProcessorRuntimeTask.java:370) > at > org.apache.tez.runtime.task.TaskRunner2Callable$1.run(TaskRunner2Callable.java:73) > at > org.apache.tez.runtime.task.TaskRunner2Callable$1.run(TaskRunner2Callable.java:61) > at java.security.AccessController.doPrivileged(Native Method) > at javax.security.auth.Subject.doAs(Subject.java:422) > {noformat} -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15906) thrift code regeneration to include new protocol version
[ https://issues.apache.org/jira/browse/HIVE-15906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865093#comment-15865093 ] Thejas M Nair commented on HIVE-15906: -- +1 Pending tests > thrift code regeneration to include new protocol version > > > Key: HIVE-15906 > URL: https://issues.apache.org/jira/browse/HIVE-15906 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Affects Versions: 2.2.0 >Reporter: anishek >Assignee: anishek >Priority: Critical > Fix For: 2.2.0 > > Attachments: HIVE-15906.1.patch > > > HIVE-15473 changed the protocol version in thrift file. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15900) Beeline prints tez job progress in stdout instead of stderr
[ https://issues.apache.org/jira/browse/HIVE-15900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thejas M Nair updated HIVE-15900: - Summary: Beeline prints tez job progress in stdout instead of stderr (was: Tez job progress included in stdout instead of stderr) > Beeline prints tez job progress in stdout instead of stderr > --- > > Key: HIVE-15900 > URL: https://issues.apache.org/jira/browse/HIVE-15900 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Affects Versions: 2.1.0 >Reporter: Aswathy Chellammal Sreekumar > Attachments: std_out > > > Tez job progress messages are getting updated to stdout instead of stderr > Attaching output file for below command, with the tez job status printed > $HIVE_HOME/bin/beeline -n -p -u "--outputformat=tsv -e "analyze table studenttab10k compute statistics;" > > stdout -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15473) Progress Bar on Beeline client
[ https://issues.apache.org/jira/browse/HIVE-15473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864842#comment-15864842 ] Thejas M Nair commented on HIVE-15473: -- [~anishek] It seems like the thrift file wasn't regenerated after the version change - {code} 34134[hive17:07]$ git grep HIVE_CLI_SERVICE_PROTOCOL_V10 service-rpc/if/TCLIService.thrift: HIVE_CLI_SERVICE_PROTOCOL_V10 service-rpc/if/TCLIService.thrift: 1: required TProtocolVersion client_protocol = TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V10 service-rpc/if/TCLIService.thrift: 2: required TProtocolVersion serverProtocolVersion = TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V10 134134[hive17:27]$ 134134[hive17:27]$ 134134[hive17:27]$ git grep HIVE_CLI_SERVICE_PROTOCOL_V9 jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java: supportedProtocols.add(TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V9); service-rpc/if/TCLIService.thrift: HIVE_CLI_SERVICE_PROTOCOL_V9 service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp: TProtocolVersion::HIVE_CLI_SERVICE_PROTOCOL_V9 service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp: "HIVE_CLI_SERVICE_PROTOCOL_V9" service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h: HIVE_CLI_SERVICE_PROTOCOL_V9 = 8 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TOpenSessionReq.java: this.client_protocol = org.apache.hive.service.rpc.thrift.TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V9; service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TOpenSessionReq.java: this.client_protocol = org.apache.hive.service.rpc.thrift.TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V9; service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TOpenSessionResp.java: this.serverProtocolVersion = org.apache.hive.service.rpc.thrift.TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V9; service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TOpenSessionResp.java: this.serverProtocolVersion = org.apache.hive.service.rpc.thrift.TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V9; service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TProtocolVersion.java: HIVE_CLI_SERVICE_PROTOCOL_V9(8); service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TProtocolVersion.java: return HIVE_CLI_SERVICE_PROTOCOL_V9; service-rpc/src/gen/thrift/gen-php/Types.php: const HIVE_CLI_SERVICE_PROTOCOL_V9 = 8; service-rpc/src/gen/thrift/gen-php/Types.php:8 => 'HIVE_CLI_SERVICE_PROTOCOL_V9', service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py: HIVE_CLI_SERVICE_PROTOCOL_V9 = 8 service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py:8: "HIVE_CLI_SERVICE_PROTOCOL_V9", service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py: "HIVE_CLI_SERVICE_PROTOCOL_V9": 8, service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb: HIVE_CLI_SERVICE_PROTOCOL_V9 = 8 service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb: VALUE_MAP = {0 => "HIVE_CLI_SERVICE_PROTOCOL_V1", 1 => "HIVE_CLI_SERVICE_PROTOCOL_V2", 2 => "HIVE_CLI_SERVICE_PROTOCOL_V3", 3 => "HIVE_CLI_SERVICE_PROTOCOL_V4", 4 => "HIVE_CLI_SERVICE_PROTOCOL_V5", 5 => "HIVE_CLI_SERVICE_PROTOCOL_V6", 6 => "HIVE_CLI_SERVICE_PROTOCOL_V7", 7 => "HIVE_CLI_SERVICE_PROTOCOL_V8", 8 => "HIVE_CLI_SERVICE_PROTOCOL_V9"} service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb: VALID_VALUES = Set.new([HIVE_CLI_SERVICE_PROTOCOL_V1, HIVE_CLI_SERVICE_PROTOCOL_V2, HIVE_CLI_SERVICE_PROTOCOL_V3, HIVE_CLI_SERVICE_PROTOCOL_V4, HIVE_CLI_SERVICE_PROTOCOL_V5, HIVE_CLI_SERVICE_PROTOCOL_V6, HIVE_CLI_SERVICE_PROTOCOL_V7, HIVE_CLI_SERVICE_PROTOCOL_V8, HIVE_CLI_SERVICE_PROTOCOL_V9]).freeze service/src/test/org/apache/hive/service/cli/session/TestSessionManagerMetrics.java: sm.openSession(TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V9, "user", "passw", "127.0.0.1", service/src/test/org/apache/hive/service/cli/session/TestSessionManagerMetrics.java: sm.openSession(TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V9, "user", "passw", "127.0.0.1", service/src/test/org/apache/hive/service/cli/session/TestSessionManagerMetrics.java: sm.openSession(TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V9, "user", "passw", "127.0.0.1", service/src/test/org/apache/hive/service/cli/session/TestSessionManagerMetrics.java: sm.openSession(TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V9, "user", "passw", "127.0.0.1", service/src/test/org/apache/hive/service/cli/session/TestSessionManagerMetrics.java: sm.openSession(TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V9, "user", "passw", "127.0.0.1", service/src/test/org/apache/hive/service/cli/session/TestSessionManagerMetrics.java: sm.openSession(TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V9, "user", "passw", "127.0.0.1", service/src/test/org/apache/hive/service/cli/session/TestSessionManagerMetrics.java:
[jira] [Commented] (HIVE-15894) Add logical semijoin config in sqlstd safe list
[ https://issues.apache.org/jira/browse/HIVE-15894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864695#comment-15864695 ] Thejas M Nair commented on HIVE-15894: -- +1 pending tests > Add logical semijoin config in sqlstd safe list > > > Key: HIVE-15894 > URL: https://issues.apache.org/jira/browse/HIVE-15894 > Project: Hive > Issue Type: Improvement > Components: Configuration >Reporter: Ashutosh Chauhan >Assignee: Ashutosh Chauhan > Attachments: HIVE-15894.2.patch, HIVE-15894.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15894) Add logical semijoin config in sqlstd safe list
[ https://issues.apache.org/jira/browse/HIVE-15894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864520#comment-15864520 ] Thejas M Nair commented on HIVE-15894: -- It would be better to rename this variable with a "hive.optimize." prefix . That would be following existing naming convention for this property more closely. It would also automatically get included in the safe variable list as that prefix is included in HiveConf.sqlStdAuthSafeVarNameRegexes > Add logical semijoin config in sqlstd safe list > > > Key: HIVE-15894 > URL: https://issues.apache.org/jira/browse/HIVE-15894 > Project: Hive > Issue Type: Improvement > Components: Configuration >Reporter: Ashutosh Chauhan >Assignee: Ashutosh Chauhan > Attachments: HIVE-15894.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15858) Beeline ^C doesn't close the session in HTTP mode
[ https://issues.apache.org/jira/browse/HIVE-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thejas M Nair updated HIVE-15858: - Resolution: Fixed Fix Version/s: 2.2.0 Status: Resolved (was: Patch Available) Patch committed to trunk. Thanks [~sankarh]! > Beeline ^C doesn't close the session in HTTP mode > - > > Key: HIVE-15858 > URL: https://issues.apache.org/jira/browse/HIVE-15858 > Project: Hive > Issue Type: Bug > Components: Beeline >Reporter: Sankar Hariappan >Assignee: Sankar Hariappan > Fix For: 2.2.0 > > Attachments: HIVE-15858.01.patch, HIVE-15858.02.patch > > > When open multiple connections through Beeline to Hiveserver2 and if tries to > close the client using !quit or ^C command, it looks like all the > connections/sessions are not getting closed. > !quit seems to close the current active connection but fails to close other > open sessions. > ^C doesn't close any session. > This behaviour is noticed only with the HTTP mode of transport > (hive.server2.transport.mode=http). In case of BINARY mode, server triggers > the close session when a tcp connection is closed by peer. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15858) Beeline ^C doesn't close the session in HTTP mode
[ https://issues.apache.org/jira/browse/HIVE-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thejas M Nair updated HIVE-15858: - Summary: Beeline ^C doesn't close the session in HTTP mode (was: Beeline ^C doesn't close the session) > Beeline ^C doesn't close the session in HTTP mode > - > > Key: HIVE-15858 > URL: https://issues.apache.org/jira/browse/HIVE-15858 > Project: Hive > Issue Type: Bug > Components: Beeline >Reporter: Sankar Hariappan >Assignee: Sankar Hariappan > Attachments: HIVE-15858.01.patch, HIVE-15858.02.patch > > > When open multiple connections through Beeline to Hiveserver2 and if tries to > close the client using !quit or ^C command, it looks like all the > connections/sessions are not getting closed. > !quit seems to close the current active connection but fails to close other > open sessions. > ^C doesn't close any session. > This behaviour is noticed only with the HTTP mode of transport > (hive.server2.transport.mode=http). In case of BINARY mode, server triggers > the close session when a tcp connection is closed by peer. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (HIVE-14764) Enabling "hive.metastore.metrics.enabled" throws OOM in HiveMetastore
[ https://issues.apache.org/jira/browse/HIVE-14764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thejas M Nair reassigned HIVE-14764: Assignee: Rajesh Balamohan (was: Carl Steinbach) > Enabling "hive.metastore.metrics.enabled" throws OOM in HiveMetastore > - > > Key: HIVE-14764 > URL: https://issues.apache.org/jira/browse/HIVE-14764 > Project: Hive > Issue Type: Bug > Components: Metastore >Reporter: Rajesh Balamohan >Assignee: Rajesh Balamohan >Priority: Minor > Labels: JMX, Metrics, Monitoring > Fix For: 2.2.0, 2.1.1 > > Attachments: hd_1.png, hd_2.png, HIVE-14764.1.patch > > > After running some queries with metrics enabled, metastore starts throwing > the following messages. > {noformat} > Caused by: java.sql.SQLException: java.lang.OutOfMemoryError: GC overhead > limit exceeded > at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:1075) > at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:989) > at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:984) > at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:929) > at com.mysql.jdbc.Util.handleNewInstance(Util.java:433) > at > com.mysql.jdbc.PreparedStatement.getInstance(PreparedStatement.java:877) > at > com.mysql.jdbc.ConnectionImpl.clientPrepareStatement(ConnectionImpl.java:1489) > at > com.mysql.jdbc.ConnectionImpl.prepareStatement(ConnectionImpl.java:4343) > at > com.mysql.jdbc.ConnectionImpl.prepareStatement(ConnectionImpl.java:4242) > at > com.jolbox.bonecp.ConnectionHandle.prepareStatement(ConnectionHandle.java:1024) > at > org.datanucleus.store.rdbms.SQLController.getStatementForQuery(SQLController.java:350) > at > org.datanucleus.store.rdbms.SQLController.getStatementForQuery(SQLController.java:295) > at > org.datanucleus.store.rdbms.scostore.JoinListStore.listIterator(JoinListStore.java:761) > ... 36 more > Nested Throwables StackTrace: > java.sql.SQLException: java.lang.OutOfMemoryError: GC overhead limit exceeded > at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:1075) > at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:989) > at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:984) > at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:929) > at com.mysql.jdbc.Util.handleNewInstance(Util.java:433) > at > com.mysql.jdbc.PreparedStatement.getInstance(PreparedStatement.java:877) > at > com.mysql.jdbc.ConnectionImpl.clientPrepareStatement(ConnectionImpl.java:1489) > at > com.mysql.jdbc.ConnectionImpl.prepareStatement(ConnectionImpl.java:4343) > at > com.mysql.jdbc.ConnectionImpl.prepareStatement(ConnectionImpl.java:4242) > at > com.jolbox.bonecp.ConnectionHandle.prepareStatement(ConnectionHandle.java:1024) > at > org.datanucleus.store.rdbms.SQLController.getStatementForQuery(SQLController.java:350) > at > org.datanucleus.store.rdbms.SQLController.getStatementForQuery(SQLController.java:295) > at > org.datanucleus.store.rdbms.scostore.JoinListStore.listIterator(JoinListStore.java:761) > at > org.datanucleus.store.rdbms.scostore.AbstractListStore.listIterator(AbstractListStore.java:93) > at > org.datanucleus.store.rdbms.scostore.AbstractListStore.iterator(AbstractListStore.java:83) > at > org.datanucleus.store.types.wrappers.backed.List.loadFromStore(List.java:264) > at > org.datanucleus.store.types.wrappers.backed.List.iterator(List.java:492) > at > org.apache.hadoop.hive.metastore.ObjectStore.convertToFieldSchemas(ObjectStore.java:1199) > at > org.apache.hadoop.hive.metastore.ObjectStore.convertToStorageDescriptor(ObjectStore.java:1266) > at > org.apache.hadoop.hive.metastore.ObjectStore.convertToStorageDescriptor(ObjectStore.java:1281) > at > org.apache.hadoop.hive.metastore.ObjectStore.convertToTable(ObjectStore.java:1138) > at > org.apache.hadoop.hive.metastore.ObjectStore.ensureGetTable(ObjectStore.java:2651) > at > org.apache.hadoop.hive.metastore.ObjectStore.updatePartitionColumnStatistics(ObjectStore.java:6141) > {noformat} > HiveMetastore uses start/end functions for starting/ending the scope in > MetricsFactory. In some places in HiveMetastore the function names are not > matching causing gradual memory leak in metastore with metrics enabled. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15858) Beeline ^C doesn't close the session
[ https://issues.apache.org/jira/browse/HIVE-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863258#comment-15863258 ] Thejas M Nair commented on HIVE-15858: -- +1 Thanks for also adding the test. > Beeline ^C doesn't close the session > > > Key: HIVE-15858 > URL: https://issues.apache.org/jira/browse/HIVE-15858 > Project: Hive > Issue Type: Bug > Components: Beeline >Reporter: Sankar Hariappan >Assignee: Sankar Hariappan > Attachments: HIVE-15858.01.patch, HIVE-15858.02.patch > > > When open multiple connections through Beeline to Hiveserver2 and if tries to > close the client using !quit or ^C command, it looks like all the > connections/sessions are not getting closed. > !quit seems to close the current active connection but fails to close other > open sessions. > ^C doesn't close any session. > This behaviour is noticed only with the HTTP mode of transport > (hive.server2.transport.mode=http). In case of BINARY mode, server triggers > the close session when a tcp connection is closed by peer. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15858) Beeline ^C doesn't close the session
[ https://issues.apache.org/jira/browse/HIVE-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862561#comment-15862561 ] Thejas M Nair commented on HIVE-15858: -- [~sankarh] Added a comment in github pull request. Can you also add a unit test case for this ? Doing it for shutdown hook might not be feasible, so maybe create a separate runnable object in Beeline which shutdownhook would invoke, and also that can be accessed from test case. Add a mocked connetion object to Beeline.connections and verify that when this runnable is invoked there are no more connections ? (or something else you can think of) > Beeline ^C doesn't close the session > > > Key: HIVE-15858 > URL: https://issues.apache.org/jira/browse/HIVE-15858 > Project: Hive > Issue Type: Bug > Components: Beeline >Reporter: Sankar Hariappan >Assignee: Sankar Hariappan > Attachments: HIVE-15858.01.patch > > > When open multiple connections through Beeline to Hiveserver2 and if tries to > close the client using !quit or ^C command, it looks like all the > connections/sessions are not getting closed. > !quit seems to close the current active connection but fails to close other > open sessions. > ^C doesn't close any session. > This behaviour is noticed only with the HTTP mode of transport > (hive.server2.transport.mode=http). In case of BINARY mode, server triggers > the close session when a tcp connection is closed by peer. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15858) Beeline ^C doesn't close the session
[ https://issues.apache.org/jira/browse/HIVE-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15860814#comment-15860814 ] Thejas M Nair commented on HIVE-15858: -- bq. It looks like we have two places in Beeline code to handles signals like Ctrl^C. 1. SunSignalHandler and the code section which is modified by the patch. Do you think it would be a good idea modify the code so that they are all handled at the same place? While the description talks about ^C, I think this closing of session is something we should be doing on any reason for exit. So the shutdownhook is the better place for that in my opinion. For the desired behavior described in HIVE-15626 for ^C, that would need to be dealt with in signalhandler. So I think it makes sense to handle this two different requirements in two different places. > Beeline ^C doesn't close the session > > > Key: HIVE-15858 > URL: https://issues.apache.org/jira/browse/HIVE-15858 > Project: Hive > Issue Type: Bug > Components: Beeline >Reporter: Sankar Hariappan >Assignee: Sankar Hariappan > Attachments: HIVE-15858.01.patch > > > When open multiple connections through Beeline to Hiveserver2 and if tries to > close the client using !quit or ^C command, it looks like all the > connections/sessions are not getting closed. > !quit seems to close the current active connection but fails to close other > open sessions. > ^C doesn't close any session. > This behaviour is noticed only with the HTTP mode of transport > (hive.server2.transport.mode=http). In case of BINARY mode, server triggers > the close session when a tcp connection is closed by peer. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15626) beeline should not exit after canceling the query on ctrl-c
[ https://issues.apache.org/jira/browse/HIVE-15626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15860796#comment-15860796 ] Thejas M Nair commented on HIVE-15626: -- [~vihangk1] Branch 1.2 is for maintenance releases of 1.2.x release, so it should be used only for critical bug fixes. Branch-1 is where improvements/features like this one would go, so that it can be part of a 1.3.0 release. However, the state of unit tests seemed quite bad last I saw. I think that would need a cleanup before we can add patches there. > beeline should not exit after canceling the query on ctrl-c > --- > > Key: HIVE-15626 > URL: https://issues.apache.org/jira/browse/HIVE-15626 > Project: Hive > Issue Type: Bug >Affects Versions: 1.2.1 >Reporter: Sergey Shelukhin >Assignee: Vihang Karajgaonkar > Fix For: 2.2.0 > > Attachments: HIVE-15626.01.patch > > > I am seeing this in 1.2 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Comment Edited] (HIVE-15626) beeline should not exit after canceling the query on ctrl-c
[ https://issues.apache.org/jira/browse/HIVE-15626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15860796#comment-15860796 ] Thejas M Nair edited comment on HIVE-15626 at 2/10/17 6:08 AM: --- [~vihangk1] Branch 1.2 is for maintenance releases of 1.2.x release, so it should be used only for critical bug fixes. Branch-1 is where improvements/features like this one would go, so that it can be part of a 1.3.0 release. However, the state of unit tests in branch-1 seemed quite bad last I saw. I think that would need a cleanup before we can add patches there. Without that, its hard to say if new patches are breaking something. was (Author: thejas): [~vihangk1] Branch 1.2 is for maintenance releases of 1.2.x release, so it should be used only for critical bug fixes. Branch-1 is where improvements/features like this one would go, so that it can be part of a 1.3.0 release. However, the state of unit tests seemed quite bad last I saw. I think that would need a cleanup before we can add patches there. > beeline should not exit after canceling the query on ctrl-c > --- > > Key: HIVE-15626 > URL: https://issues.apache.org/jira/browse/HIVE-15626 > Project: Hive > Issue Type: Bug >Affects Versions: 1.2.1 >Reporter: Sergey Shelukhin >Assignee: Vihang Karajgaonkar > Fix For: 2.2.0 > > Attachments: HIVE-15626.01.patch > > > I am seeing this in 1.2 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15550) fix arglist logging in schematool
[ https://issues.apache.org/jira/browse/HIVE-15550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15860423#comment-15860423 ] Thejas M Nair commented on HIVE-15550: -- [~mcsanady] Thanks for pointing that out. I have now added that file to master. > fix arglist logging in schematool > - > > Key: HIVE-15550 > URL: https://issues.apache.org/jira/browse/HIVE-15550 > Project: Hive > Issue Type: Improvement > Components: Beeline >Affects Versions: 2.1.1 >Reporter: anishek >Assignee: anishek >Priority: Minor > Fix For: 2.2.0 > > Attachments: HIVE-15550.1.patch, HIVE-15550.1.patch > > > In DEBUG mode schemaTool prints the password to log file. > This is also seen if the user includes --verbose option. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15846) Relocate more dependencies (e.g. org.apache.zookeeper) for JDBC uber jar
[ https://issues.apache.org/jira/browse/HIVE-15846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859703#comment-15859703 ] Thejas M Nair commented on HIVE-15846: -- [~taoli-hwx] Can you please verify it works with this change with following configs enabled as well ? - zookeeper, kerberos and http mode ? > Relocate more dependencies (e.g. org.apache.zookeeper) for JDBC uber jar > > > Key: HIVE-15846 > URL: https://issues.apache.org/jira/browse/HIVE-15846 > Project: Hive > Issue Type: Bug >Reporter: Tao Li >Assignee: Tao Li > Attachments: HIVE-15846.1.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15792) Hive should raise SemanticException when LPAD/RPAD pad character's length is 0
[ https://issues.apache.org/jira/browse/HIVE-15792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15858977#comment-15858977 ] Thejas M Nair commented on HIVE-15792: -- [~nandakumar131] Can you also please update the information in the wiki ? cc [~leftylev] > Hive should raise SemanticException when LPAD/RPAD pad character's length is 0 > -- > > Key: HIVE-15792 > URL: https://issues.apache.org/jira/browse/HIVE-15792 > Project: Hive > Issue Type: Improvement >Reporter: Zoltan Chovan >Assignee: Nandakumar >Priority: Minor > Fix For: 2.2.0 > > Attachments: HIVE-15792.000.patch, HIVE-15792.001.patch, > HIVE-15792.002.patch > > > For example SELECT LPAD('A', 2, ''); will cause an infinite loop and the > running query will hang without any error. > It would be great if this could be prevented by checking the pad character's > length and if it's 0 then throw a SemanticException. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15792) Hive should raise SemanticException when LPAD/RPAD pad character's length is 0
[ https://issues.apache.org/jira/browse/HIVE-15792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thejas M Nair updated HIVE-15792: - Resolution: Fixed Fix Version/s: 2.2.0 Status: Resolved (was: Patch Available) Patch committed to trunk. Thanks [~nandakumar131]! > Hive should raise SemanticException when LPAD/RPAD pad character's length is 0 > -- > > Key: HIVE-15792 > URL: https://issues.apache.org/jira/browse/HIVE-15792 > Project: Hive > Issue Type: Improvement >Reporter: Zoltan Chovan >Assignee: Nandakumar >Priority: Minor > Fix For: 2.2.0 > > Attachments: HIVE-15792.000.patch, HIVE-15792.001.patch, > HIVE-15792.002.patch > > > For example SELECT LPAD('A', 2, ''); will cause an infinite loop and the > running query will hang without any error. > It would be great if this could be prevented by checking the pad character's > length and if it's 0 then throw a SemanticException. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15792) Hive should raise SemanticException when LPAD/RPAD pad character's length is 0
[ https://issues.apache.org/jira/browse/HIVE-15792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15858949#comment-15858949 ] Thejas M Nair commented on HIVE-15792: -- +1 to updated patch. The failed tests are tracked under HIVE-15058 > Hive should raise SemanticException when LPAD/RPAD pad character's length is 0 > -- > > Key: HIVE-15792 > URL: https://issues.apache.org/jira/browse/HIVE-15792 > Project: Hive > Issue Type: Improvement >Reporter: Zoltan Chovan >Assignee: Nandakumar >Priority: Minor > Attachments: HIVE-15792.000.patch, HIVE-15792.001.patch, > HIVE-15792.002.patch > > > For example SELECT LPAD('A', 2, ''); will cause an infinite loop and the > running query will hang without any error. > It would be great if this could be prevented by checking the pad character's > length and if it's 0 then throw a SemanticException. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15792) Hive should raise SemanticException when LPAD/RPAD pad character's length is 0
[ https://issues.apache.org/jira/browse/HIVE-15792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15858417#comment-15858417 ] Thejas M Nair commented on HIVE-15792: -- Looks like tests need to be updated as well. > Hive should raise SemanticException when LPAD/RPAD pad character's length is 0 > -- > > Key: HIVE-15792 > URL: https://issues.apache.org/jira/browse/HIVE-15792 > Project: Hive > Issue Type: Improvement >Reporter: Zoltan Chovan >Assignee: Nandakumar >Priority: Minor > Attachments: HIVE-15792.000.patch, HIVE-15792.001.patch > > > For example SELECT LPAD('A', 2, ''); will cause an infinite loop and the > running query will hang without any error. > It would be great if this could be prevented by checking the pad character's > length and if it's 0 then throw a SemanticException. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15792) Hive should raise SemanticException when LPAD/RPAD pad character's length is 0
[ https://issues.apache.org/jira/browse/HIVE-15792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15858303#comment-15858303 ] Thejas M Nair commented on HIVE-15792: -- Thanks for the update. +1 > Hive should raise SemanticException when LPAD/RPAD pad character's length is 0 > -- > > Key: HIVE-15792 > URL: https://issues.apache.org/jira/browse/HIVE-15792 > Project: Hive > Issue Type: Improvement >Reporter: Zoltan Chovan >Assignee: Nandakumar >Priority: Minor > Attachments: HIVE-15792.000.patch, HIVE-15792.001.patch > > > For example SELECT LPAD('A', 2, ''); will cause an infinite loop and the > running query will hang without any error. > It would be great if this could be prevented by checking the pad character's > length and if it's 0 then throw a SemanticException. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15792) Hive should raise SemanticException when LPAD/RPAD pad character's length is 0
[ https://issues.apache.org/jira/browse/HIVE-15792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15858225#comment-15858225 ] Thejas M Nair commented on HIVE-15792: -- [~nandakumar131] can you also update the description (the extended part) of these functions (the @Description tag) to talk about the behavior on getting empty pad string ? > Hive should raise SemanticException when LPAD/RPAD pad character's length is 0 > -- > > Key: HIVE-15792 > URL: https://issues.apache.org/jira/browse/HIVE-15792 > Project: Hive > Issue Type: Improvement >Reporter: Zoltan Chovan >Assignee: Nandakumar >Priority: Minor > Attachments: HIVE-15792.000.patch > > > For example SELECT LPAD('A', 2, ''); will cause an infinite loop and the > running query will hang without any error. > It would be great if this could be prevented by checking the pad character's > length and if it's 0 then throw a SemanticException. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15792) Hive should raise SemanticException when LPAD/RPAD pad character's length is 0
[ https://issues.apache.org/jira/browse/HIVE-15792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15858220#comment-15858220 ] Thejas M Nair commented on HIVE-15792: -- +1 > Hive should raise SemanticException when LPAD/RPAD pad character's length is 0 > -- > > Key: HIVE-15792 > URL: https://issues.apache.org/jira/browse/HIVE-15792 > Project: Hive > Issue Type: Improvement >Reporter: Zoltan Chovan >Assignee: Nandakumar >Priority: Minor > Attachments: HIVE-15792.000.patch > > > For example SELECT LPAD('A', 2, ''); will cause an infinite loop and the > running query will hang without any error. > It would be great if this could be prevented by checking the pad character's > length and if it's 0 then throw a SemanticException. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15473) Progress Bar on Beeline client
[ https://issues.apache.org/jira/browse/HIVE-15473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15857132#comment-15857132 ] Thejas M Nair commented on HIVE-15473: -- [~anishek] Can you please create a follow up jira to address these concerns ? > Progress Bar on Beeline client > -- > > Key: HIVE-15473 > URL: https://issues.apache.org/jira/browse/HIVE-15473 > Project: Hive > Issue Type: Improvement > Components: Beeline, HiveServer2 >Affects Versions: 2.1.1 >Reporter: anishek >Assignee: anishek >Priority: Minor > Fix For: 2.2.0 > > Attachments: HIVE-15473.10.patch, HIVE-15473.11.patch, > HIVE-15473.2.patch, HIVE-15473.3.patch, HIVE-15473.4.patch, > HIVE-15473.5.patch, HIVE-15473.6.patch, HIVE-15473.7.patch, > HIVE-15473.8.patch, HIVE-15473.9.patch, io_summary_after_patch.png, > io_summary_before_patch.png, screen_shot_beeline.jpg, status_after_patch.png, > status_before_patch.png, summary_after_patch.png, summary_before_patch.png > > > Hive Cli allows showing progress bar for tez execution engine as shown in > https://issues.apache.org/jira/secure/attachment/12678767/ux-demo.gif > it would be great to have similar progress bar displayed when user is > connecting via beeline command line client as well. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15840) Webhcat test TestPig_5 failing with Pig on Tez at check for percent complete of job
[ https://issues.apache.org/jira/browse/HIVE-15840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15857030#comment-15857030 ] Thejas M Nair commented on HIVE-15840: -- +1 > Webhcat test TestPig_5 failing with Pig on Tez at check for percent complete > of job > --- > > Key: HIVE-15840 > URL: https://issues.apache.org/jira/browse/HIVE-15840 > Project: Hive > Issue Type: Bug > Components: HCatalog >Reporter: Daniel Dai >Assignee: Daniel Dai > Attachments: HIVE-15840.1.patch > > > TestPig_5 is failing at percentage check if the job is Pig on Tez: > check_job_percent_complete failed. got percentComplete , expected 100% > complete > Test command: > curl -d user.name=daijy -d arg=-p -d arg=INPDIR=/tmp/templeton_test_data -d > arg=-p -d arg=OUTDIR=/tmp/output -d file=loadstore.pig -X POST > http://localhost:50111/templeton/v1/pig > curl > http://localhost:50111/templeton/v1/jobs/job_1486502484681_0003?user.name=daijy > This is similar to HIVE-9351, which fixes Hive on Tez. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15473) Progress Bar on Beeline client
[ https://issues.apache.org/jira/browse/HIVE-15473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thejas M Nair updated HIVE-15473: - Resolution: Fixed Fix Version/s: 2.2.0 Status: Resolved (was: Patch Available) Patch committed to master. Thanks for the contribution [~anishek]! > Progress Bar on Beeline client > -- > > Key: HIVE-15473 > URL: https://issues.apache.org/jira/browse/HIVE-15473 > Project: Hive > Issue Type: Improvement > Components: Beeline, HiveServer2 >Affects Versions: 2.1.1 >Reporter: anishek >Assignee: anishek >Priority: Minor > Fix For: 2.2.0 > > Attachments: HIVE-15473.10.patch, HIVE-15473.11.patch, > HIVE-15473.2.patch, HIVE-15473.3.patch, HIVE-15473.4.patch, > HIVE-15473.5.patch, HIVE-15473.6.patch, HIVE-15473.7.patch, > HIVE-15473.8.patch, HIVE-15473.9.patch, screen_shot_beeline.jpg > > > Hive Cli allows showing progress bar for tez execution engine as shown in > https://issues.apache.org/jira/secure/attachment/12678767/ux-demo.gif > it would be great to have similar progress bar displayed when user is > connecting via beeline command line client as well. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15473) Progress Bar on Beeline client
[ https://issues.apache.org/jira/browse/HIVE-15473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15855537#comment-15855537 ] Thejas M Nair commented on HIVE-15473: -- +1 pending some minor comments in pull request > Progress Bar on Beeline client > -- > > Key: HIVE-15473 > URL: https://issues.apache.org/jira/browse/HIVE-15473 > Project: Hive > Issue Type: Improvement > Components: Beeline, HiveServer2 >Affects Versions: 2.1.1 >Reporter: anishek >Assignee: anishek >Priority: Minor > Attachments: HIVE-15473.10.patch, HIVE-15473.2.patch, > HIVE-15473.3.patch, HIVE-15473.4.patch, HIVE-15473.5.patch, > HIVE-15473.6.patch, HIVE-15473.7.patch, HIVE-15473.8.patch, > HIVE-15473.9.patch, screen_shot_beeline.jpg > > > Hive Cli allows showing progress bar for tez execution engine as shown in > https://issues.apache.org/jira/secure/attachment/12678767/ux-demo.gif > it would be great to have similar progress bar displayed when user is > connecting via beeline command line client as well. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15766) DBNotificationlistener leaks JDOPersistenceManager
[ https://issues.apache.org/jira/browse/HIVE-15766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15854557#comment-15854557 ] Thejas M Nair commented on HIVE-15766: -- Are the TestReplicationScenarios failures related ? > DBNotificationlistener leaks JDOPersistenceManager > -- > > Key: HIVE-15766 > URL: https://issues.apache.org/jira/browse/HIVE-15766 > Project: Hive > Issue Type: Bug > Components: Metastore >Reporter: Vaibhav Gumashta >Assignee: Vaibhav Gumashta > Attachments: HIVE-15766.1.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15792) Hive should raise SemanticException when LPAD/RPAD pad character's length is 0
[ https://issues.apache.org/jira/browse/HIVE-15792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15851800#comment-15851800 ] Thejas M Nair commented on HIVE-15792: -- Thanks [~nandakumar131] I think NULL is the better choice, that way we don't return unpadded data. NULL makes sense with invalid input. > Hive should raise SemanticException when LPAD/RPAD pad character's length is 0 > -- > > Key: HIVE-15792 > URL: https://issues.apache.org/jira/browse/HIVE-15792 > Project: Hive > Issue Type: Improvement >Reporter: Zoltan Chovan >Assignee: Nandakumar >Priority: Minor > > For example SELECT LPAD('A', 2, ''); will cause an infinite loop and the > running query will hang without any error. > It would be great if this could be prevented by checking the pad character's > length and if it's 0 then throw a SemanticException. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15792) Hive should raise SemanticException when LPAD/RPAD pad character's length is 0
[ https://issues.apache.org/jira/browse/HIVE-15792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15850232#comment-15850232 ] Thejas M Nair commented on HIVE-15792: -- There are couple of options here. It would be better to follow the convention followed by some of the other databases, like postgres and mysql with this regard. Can you take a look at what they do ? Its cleaner to have this check in the UDF itself rather than in semantic analyzer. > Hive should raise SemanticException when LPAD/RPAD pad character's length is 0 > -- > > Key: HIVE-15792 > URL: https://issues.apache.org/jira/browse/HIVE-15792 > Project: Hive > Issue Type: Improvement >Reporter: Zoltan Chovan >Assignee: Nandakumar >Priority: Minor > > For example SELECT LPAD('A', 2, ''); will cause an infinite loop and the > running query will hang without any error. > It would be great if this could be prevented by checking the pad character's > length and if it's 0 then throw a SemanticException. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15730) JDBC should use SQLFeatureNotSupportedException where appropriate instead of SQLException
[ https://issues.apache.org/jira/browse/HIVE-15730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15849182#comment-15849182 ] Thejas M Nair commented on HIVE-15730: -- [~vgumashta] Can you please review this patch ? > JDBC should use SQLFeatureNotSupportedException where appropriate instead of > SQLException > -- > > Key: HIVE-15730 > URL: https://issues.apache.org/jira/browse/HIVE-15730 > Project: Hive > Issue Type: Bug > Components: JDBC >Reporter: Thejas M Nair >Assignee: Sankar Hariappan > Attachments: HIVE_15730_1.patch > > > An example is HiveBaseResultSet.rowDeleted. It throws SQLException("Method > not supported") instead of SQLFeatureNotSupportedException. > For that optional method, the use of SQLFeatureNotSupportedException is more > appropriate. > See > http://docs.oracle.com/javase/7/docs/api/java/sql/ResultSet.html#rowDeleted() > http://docs.oracle.com/javase/7/docs/api/java/sql/SQLFeatureNotSupportedException.html -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15766) DBNotificationlistener leaks JDOPersistenceManager
[ https://issues.apache.org/jira/browse/HIVE-15766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848849#comment-15848849 ] Thejas M Nair commented on HIVE-15766: -- Moved this to a top level issue as this is seen independent of the replication v2 work. > DBNotificationlistener leaks JDOPersistenceManager > -- > > Key: HIVE-15766 > URL: https://issues.apache.org/jira/browse/HIVE-15766 > Project: Hive > Issue Type: Bug > Components: Metastore >Reporter: Vaibhav Gumashta >Assignee: Vaibhav Gumashta > Attachments: HIVE-15766.1.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15766) DBNotificationlistener leaks JDOPersistenceManager
[ https://issues.apache.org/jira/browse/HIVE-15766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848847#comment-15848847 ] Thejas M Nair commented on HIVE-15766: -- +1 Thanks for adding the test case as well. > DBNotificationlistener leaks JDOPersistenceManager > -- > > Key: HIVE-15766 > URL: https://issues.apache.org/jira/browse/HIVE-15766 > Project: Hive > Issue Type: Sub-task > Components: Metastore >Reporter: Vaibhav Gumashta >Assignee: Vaibhav Gumashta > Attachments: HIVE-15766.1.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15766) DBNotificationlistener leaks JDOPersistenceManager
[ https://issues.apache.org/jira/browse/HIVE-15766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thejas M Nair updated HIVE-15766: - Issue Type: Bug (was: Sub-task) Parent: (was: HIVE-14841) > DBNotificationlistener leaks JDOPersistenceManager > -- > > Key: HIVE-15766 > URL: https://issues.apache.org/jira/browse/HIVE-15766 > Project: Hive > Issue Type: Bug > Components: Metastore >Reporter: Vaibhav Gumashta >Assignee: Vaibhav Gumashta > Attachments: HIVE-15766.1.patch > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (HIVE-15752) MSCK should add output WriteEntity for table in semantic analysis
[ https://issues.apache.org/jira/browse/HIVE-15752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thejas M Nair updated HIVE-15752: - Resolution: Fixed Fix Version/s: 2.2.0 Status: Resolved (was: Patch Available) Patch committed to master. Thanks for review [~sushanth] > MSCK should add output WriteEntity for table in semantic analysis > - > > Key: HIVE-15752 > URL: https://issues.apache.org/jira/browse/HIVE-15752 > Project: Hive > Issue Type: Bug >Affects Versions: 1.2.0, 1.2.1, 2.0.0, 2.1.0, 2.1.1 >Reporter: Thejas M Nair >Assignee: Thejas M Nair > Fix For: 2.2.0 > > Attachments: HIVE-15752.1.patch, HIVE-15752.2.patch > > > MSCK should add table WriteEntity in query to outputs WriteEntity list of the > query -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15776) Flaky test: TestMiniLlapLocalCliDriver vector_if_expr
[ https://issues.apache.org/jira/browse/HIVE-15776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847790#comment-15847790 ] Thejas M Nair commented on HIVE-15776: -- hive.log had - {code} 2017-01-30T23:40:38,754 ERROR [TezTaskRunner] tez.ReduceRecordSource: java.lang.AssertionError at org.apache.hadoop.hive.ql.exec.vector.VectorizedBatchUtil.setBatchSize(VectorizedBatchUtil.java:125) at org.apache.hadoop.hive.ql.exec.tez.ReduceRecordSource.processVectorGroup(ReduceRecordSource.java:448) at org.apache.hadoop.hive.ql.exec.tez.ReduceRecordSource.pushRecordVector(ReduceRecordSource.java:388) at org.apache.hadoop.hive.ql.exec.tez.ReduceRecordSource.pushRecord(ReduceRecordSource.java:239) at org.apache.hadoop.hive.ql.exec.tez.ReduceRecordProcessor.run(ReduceRecordProcessor.java:319) at org.apache.hadoop.hive.ql.exec.tez.TezProcessor.initializeAndRunProcessor(TezProcessor.java:185) at org.apache.hadoop.hive.ql.exec.tez.TezProcessor.run(TezProcessor.java:168) at org.apache.tez.runtime.LogicalIOProcessorRuntimeTask.run(LogicalIOProcessorRuntimeTask.java:370) at org.apache.tez.runtime.task.TaskRunner2Callable$1.run(TaskRunner2Callable.java:73) at org.apache.tez.runtime.task.TaskRunner2Callable$1.run(TaskRunner2Callable.java:61) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:422) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1657) at org.apache.tez.runtime.task.TaskRunner2Callable.callInternal(TaskRunner2Callable.java:61) at org.apache.tez.runtime.task.TaskRunner2Callable.callInternal(TaskRunner2Callable.java:37) at org.apache.tez.common.CallableWithNdc.call(CallableWithNdc.java:36) at org.apache.hadoop.hive.llap.daemon.impl.StatsRecordingThreadPool$WrappedCallable.call(StatsRecordingThreadPool.java:110) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745) {code} > Flaky test: TestMiniLlapLocalCliDriver vector_if_expr > - > > Key: HIVE-15776 > URL: https://issues.apache.org/jira/browse/HIVE-15776 > Project: Hive > Issue Type: Sub-task >Affects Versions: 2.2.0 >Reporter: Thejas M Nair >Priority: Critical > > Failed in https://builds.apache.org/job/PreCommit-HIVE-Build/3274/ with > following error in test log - > java.lang.AssertionError: > Unexpected exception java.lang.AssertionError: Client execution failed with > error code = 2 running -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] (HIVE-15717) JDBC: Implement rowDeleted, rowInserted and rowUpdated to return false
[ https://issues.apache.org/jira/browse/HIVE-15717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thejas M Nair updated HIVE-15717: - Resolution: Fixed Fix Version/s: 2.2.0 Status: Resolved (was: Patch Available) Test failures are accounted for under the umbrella jira for test failures. Committed patch to master. > JDBC: Implement rowDeleted, rowInserted and rowUpdated to return false > -- > > Key: HIVE-15717 > URL: https://issues.apache.org/jira/browse/HIVE-15717 > Project: Hive > Issue Type: Improvement >Reporter: Tao Li >Assignee: Tao Li > Fix For: 2.2.0 > > Attachments: HIVE-15717.1.patch, HIVE-15717.2.patch, Screen Shot > 2017-01-24 at 3.11.09 PM.png, Screen Shot 2017-01-24 at 3.15.14 PM.png > > > In performance profile of beeline with hive jdbc driver, it is seen that lot > of time is spent in Class "org.apache.hive.beeline.Rows.Row" constructor, due > to exception handling. > The exception handling from the 3 methods calls (rowDeleted, rowInserted and > rowUpdated). The implementation of these methods in > org.apache.hive.jdbc.HiveBaseResultSet class is just throwing > SQLException("Method not supported”), i.e. no real implementations. > Implementing these methods to return false instead of throwing exception will > help improve the performance. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] (HIVE-15717) Class "org.apache.hive.beeline.Rows.Row" constructor is CPU consuming due to exception handling
[ https://issues.apache.org/jira/browse/HIVE-15717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thejas M Nair updated HIVE-15717: - Description: In performance profile of beeline with hive jdbc driver, it is seen that lot of time is spent in Class "org.apache.hive.beeline.Rows.Row" constructor, due to exception handling. The exception handling from the 3 methods calls (rowDeleted, rowInserted and rowUpdated). The implementation of these methods in org.apache.hive.jdbc.HiveBaseResultSet class is just throwing SQLException("Method not supported”), i.e. no real implementations. Implementing these methods to return false instead of throwing exception will help improve the performance. was:The exception handling from the 3 methods calls (rowDeleted, rowInserted and rowUpdated). The implementation of these methods in org.apache.hive.jdbc.HiveBaseResultSet class is just throwing SQLException("Method not supported”), i.e. no real implementations. > Class "org.apache.hive.beeline.Rows.Row" constructor is CPU consuming due to > exception handling > --- > > Key: HIVE-15717 > URL: https://issues.apache.org/jira/browse/HIVE-15717 > Project: Hive > Issue Type: Improvement >Reporter: Tao Li >Assignee: Tao Li > Attachments: HIVE-15717.1.patch, HIVE-15717.2.patch, Screen Shot > 2017-01-24 at 3.11.09 PM.png, Screen Shot 2017-01-24 at 3.15.14 PM.png > > > In performance profile of beeline with hive jdbc driver, it is seen that lot > of time is spent in Class "org.apache.hive.beeline.Rows.Row" constructor, due > to exception handling. > The exception handling from the 3 methods calls (rowDeleted, rowInserted and > rowUpdated). The implementation of these methods in > org.apache.hive.jdbc.HiveBaseResultSet class is just throwing > SQLException("Method not supported”), i.e. no real implementations. > Implementing these methods to return false instead of throwing exception will > help improve the performance. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] (HIVE-15717) JDBC: Implement rowDeleted, rowInserted and rowUpdated to return false
[ https://issues.apache.org/jira/browse/HIVE-15717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thejas M Nair updated HIVE-15717: - Summary: JDBC: Implement rowDeleted, rowInserted and rowUpdated to return false (was: Class "org.apache.hive.beeline.Rows.Row" constructor is CPU consuming due to exception handling) > JDBC: Implement rowDeleted, rowInserted and rowUpdated to return false > -- > > Key: HIVE-15717 > URL: https://issues.apache.org/jira/browse/HIVE-15717 > Project: Hive > Issue Type: Improvement >Reporter: Tao Li >Assignee: Tao Li > Attachments: HIVE-15717.1.patch, HIVE-15717.2.patch, Screen Shot > 2017-01-24 at 3.11.09 PM.png, Screen Shot 2017-01-24 at 3.15.14 PM.png > > > In performance profile of beeline with hive jdbc driver, it is seen that lot > of time is spent in Class "org.apache.hive.beeline.Rows.Row" constructor, due > to exception handling. > The exception handling from the 3 methods calls (rowDeleted, rowInserted and > rowUpdated). The implementation of these methods in > org.apache.hive.jdbc.HiveBaseResultSet class is just throwing > SQLException("Method not supported”), i.e. no real implementations. > Implementing these methods to return false instead of throwing exception will > help improve the performance. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] (HIVE-15717) Class "org.apache.hive.beeline.Rows.Row" constructor is CPU consuming due to exception handling
[ https://issues.apache.org/jira/browse/HIVE-15717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847334#comment-15847334 ] Thejas M Nair commented on HIVE-15717: -- +1 > Class "org.apache.hive.beeline.Rows.Row" constructor is CPU consuming due to > exception handling > --- > > Key: HIVE-15717 > URL: https://issues.apache.org/jira/browse/HIVE-15717 > Project: Hive > Issue Type: Improvement >Reporter: Tao Li >Assignee: Tao Li > Attachments: HIVE-15717.1.patch, HIVE-15717.2.patch, Screen Shot > 2017-01-24 at 3.11.09 PM.png, Screen Shot 2017-01-24 at 3.15.14 PM.png > > > The exception handling from the 3 methods calls (rowDeleted, rowInserted and > rowUpdated). The implementation of these methods in > org.apache.hive.jdbc.HiveBaseResultSet class is just throwing > SQLException("Method not supported”), i.e. no real implementations. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] (HIVE-15764) Tez session doesn't get released TezSessionPool on query cancellation
[ https://issues.apache.org/jira/browse/HIVE-15764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847306#comment-15847306 ] Thejas M Nair commented on HIVE-15764: -- Verified that changes in HIVE-14111 already fix it for this case in 2.1.1 . It has a new mechanism for reclaiming the Tez session. [~sershe] Do you think this change still makes sense ? > Tez session doesn't get released TezSessionPool on query cancellation > - > > Key: HIVE-15764 > URL: https://issues.apache.org/jira/browse/HIVE-15764 > Project: Hive > Issue Type: Bug > Components: Tez >Affects Versions: 1.2.1, 2.1.1 >Reporter: Thejas M Nair >Assignee: Thejas M Nair > Attachments: HIVE-15764.1.patch > > > With HiveServer2, tez execution engine, and > hive.server2.tez.initialize.default.sessions=true, if a query is cancelled > via jdbc, the tez session doesn't get released back to the session pool. > This can cause the query processing of new queries to get stuck, waiting for > a tez session to be available. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] (HIVE-15764) Tez session doesn't get released TezSessionPool on query cancellation
Title: Message Title Thejas M Nair updated an issue Hive / HIVE-15764 Tez session doesn't get released TezSessionPool on query cancellation Change By: Thejas M Nair Attachment: HIVE-15764.1.patch Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)
[jira] (HIVE-15764) Tez session doesn't get released TezSessionPool on query cancellation
Title: Message Title Thejas M Nair assigned an issue to Thejas M Nair Hive / HIVE-15764 Tez session doesn't get released TezSessionPool on query cancellation Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)
[jira] (HIVE-15752) MSCK should add output WriteEntity for table in semantic analysis
Title: Message Title Thejas M Nair updated an issue Hive / HIVE-15752 MSCK should add output WriteEntity for table in semantic analysis Change By: Thejas M Nair Attachment: HIVE-15752.2.patch Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)
[jira] (HIVE-15740) Include hive-hcatalog-core.jar and hive-hcatalog-server-extensions.jar in binary distribution
Title: Message Title Thejas M Nair commented on HIVE-15740 Re: Include hive-hcatalog-core.jar and hive-hcatalog-server-extensions.jar in binary distribution +1 We should move these two jars out of separate hcatalog dir after the next+next release, to give time for other tools to change to use the new location. Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)
[jira] (HIVE-15752) MSCK should add output WriteEntity for table in semantic analysis
Title: Message Title Thejas M Nair commented on HIVE-15752 Re: MSCK should add output WriteEntity for table in semantic analysis Sushanth Sowmyan Can you please review this patch ? Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)
[jira] (HIVE-15752) MSCK should add output WriteEntity for table in semantic analysis
Title: Message Title Thejas M Nair updated HIVE-15752 Hive / HIVE-15752 MSCK should add output WriteEntity for table in semantic analysis Change By: Thejas M Nair Affects Version/s: 1.2.0 Affects Version/s: 1.2.1 Affects Version/s: 2.0.0 Affects Version/s: 2.1.0 Affects Version/s: 2.1.1 Status: Open Patch Available Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)
[jira] (HIVE-15752) MSCK should add output WriteEntity for table in semantic analysis
Title: Message Title Thejas M Nair updated an issue Hive / HIVE-15752 MSCK should add output WriteEntity for table in semantic analysis Change By: Thejas M Nair Attachment: HIVE-15752.1.patch Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)
[jira] (HIVE-15752) MSCK should add output WriteEntity for table in semantic analysis
Title: Message Title Thejas M Nair assigned an issue to Thejas M Nair Hive / HIVE-15752 MSCK should add output WriteEntity for table in semantic analysis Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)
[jira] (HIVE-15745) TestMiniLlapLocalCliDriver. vector_varchar_simple,vector_char_simple
Title: Message Title Thejas M Nair commented on HIVE-15745 Re: TestMiniLlapLocalCliDriver. vector_varchar_simple,vector_char_simple FYI Matt McCline Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)
[jira] [Comment Edited] (HIVE-15473) Progress Bar on Beeline client
[ https://issues.apache.org/jira/browse/HIVE-15473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15843689#comment-15843689 ] Thejas M Nair edited comment on HIVE-15473 at 1/28/17 12:35 AM: This sounds good. Some minor comments - bq. not sure why the step function is used – to prevent server from wasting CPU resources on non-critical operations ? Yes, too many RPC calls would mean wasted CPU resources (and also bit of network bandwitdh). For queries that complete in a few seconds, it makes sense to update progress more frequently. But if it is a very large query taking minutes, then update of log/progress every 5 seconds is reasonable. bq. Merge QueryLog and ProgressBarLog request / response as part of GetOperationStatus. I think this makes sense, however I think we can move the QueryLog functionality as a follow up task in another jira to keep the jira smaller and easier to review. In first patch we could add the ProgressBarLog functionality as part of GeOperationStatus, instead of introducing a new function. bq. There will be additional function signature for GetOperationStatus that we might need to create to allow for backward compatibility reasons. If we add the new request and response objects as optional in the thrift api, we can keep it backward compatible without adding a new function. was (Author: thejas): bq. not sure why the step function is used – to prevent server from wasting CPU resources on non-critical operations ? Yes, too many RPC calls would mean wasted CPU resources (and also bit of network bandwitdh). For queries that complete in a few seconds, it makes sense to update progress more frequently. But if it is a very large query taking minutes, then update of log/progress every 5 seconds is reasonable. bq. Merge QueryLog and ProgressBarLog request / response as part of GetOperationStatus. I think this makes sense, however I think we can move the QueryLog functionality as a follow up task in another jira to keep the jira smaller and easier to review. In first patch we could add the ProgressBarLog functionality as part of GeOperationStatus, instead of introducing a new function. bq. There will be additional function signature for GetOperationStatus that we might need to create to allow for backward compatibility reasons. If we add the new request and response objects as optional in the thrift api, we can keep it backward compatible without adding a new function. > Progress Bar on Beeline client > -- > > Key: HIVE-15473 > URL: https://issues.apache.org/jira/browse/HIVE-15473 > Project: Hive > Issue Type: Improvement > Components: Beeline, HiveServer2 >Affects Versions: 2.1.1 >Reporter: anishek >Assignee: anishek >Priority: Minor > Attachments: HIVE-15473.2.patch, HIVE-15473.3.patch, > HIVE-15473.4.patch, HIVE-15473.5.patch, screen_shot_beeline.jpg > > > Hive Cli allows showing progress bar for tez execution engine as shown in > https://issues.apache.org/jira/secure/attachment/12678767/ux-demo.gif > it would be great to have similar progress bar displayed when user is > connecting via beeline command line client as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-15473) Progress Bar on Beeline client
[ https://issues.apache.org/jira/browse/HIVE-15473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15843689#comment-15843689 ] Thejas M Nair commented on HIVE-15473: -- bq. not sure why the step function is used – to prevent server from wasting CPU resources on non-critical operations ? Yes, too many RPC calls would mean wasted CPU resources (and also bit of network bandwitdh). For queries that complete in a few seconds, it makes sense to update progress more frequently. But if it is a very large query taking minutes, then update of log/progress every 5 seconds is reasonable. bq. Merge QueryLog and ProgressBarLog request / response as part of GetOperationStatus. I think this makes sense, however I think we can move the QueryLog functionality as a follow up task in another jira to keep the jira smaller and easier to review. In first patch we could add the ProgressBarLog functionality as part of GeOperationStatus, instead of introducing a new function. bq. There will be additional function signature for GetOperationStatus that we might need to create to allow for backward compatibility reasons. If we add the new request and response objects as optional in the thrift api, we can keep it backward compatible without adding a new function. > Progress Bar on Beeline client > -- > > Key: HIVE-15473 > URL: https://issues.apache.org/jira/browse/HIVE-15473 > Project: Hive > Issue Type: Improvement > Components: Beeline, HiveServer2 >Affects Versions: 2.1.1 >Reporter: anishek >Assignee: anishek >Priority: Minor > Attachments: HIVE-15473.2.patch, HIVE-15473.3.patch, > HIVE-15473.4.patch, HIVE-15473.5.patch, screen_shot_beeline.jpg > > > Hive Cli allows showing progress bar for tez execution engine as shown in > https://issues.apache.org/jira/secure/attachment/12678767/ux-demo.gif > it would be great to have similar progress bar displayed when user is > connecting via beeline command line client as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-15550) fix arglist logging in schematool
[ https://issues.apache.org/jira/browse/HIVE-15550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thejas M Nair updated HIVE-15550: - Resolution: Fixed Status: Resolved (was: Patch Available) > fix arglist logging in schematool > - > > Key: HIVE-15550 > URL: https://issues.apache.org/jira/browse/HIVE-15550 > Project: Hive > Issue Type: Improvement > Components: Beeline >Affects Versions: 2.1.1 >Reporter: anishek >Assignee: anishek >Priority: Minor > Fix For: 2.2.0 > > Attachments: HIVE-15550.1.patch, HIVE-15550.1.patch > > > In DEBUG mode schemaTool prints the password to log file. > This is also seen if the user includes --verbose option. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-15550) fix arglist logging in schematool
[ https://issues.apache.org/jira/browse/HIVE-15550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15842300#comment-15842300 ] Thejas M Nair commented on HIVE-15550: -- The test failures are unrelated (there were previous runs with same patch to compare) and failed tests are either tracked in umbrella jira or cleared up. Patch committed to master. Thanks Anishek! > fix arglist logging in schematool > - > > Key: HIVE-15550 > URL: https://issues.apache.org/jira/browse/HIVE-15550 > Project: Hive > Issue Type: Improvement > Components: Beeline >Affects Versions: 2.1.1 >Reporter: anishek >Assignee: anishek >Priority: Minor > Fix For: 2.2.0 > > Attachments: HIVE-15550.1.patch, HIVE-15550.1.patch > > > In DEBUG mode schemaTool prints the password to log file. > This is also seen if the user includes --verbose option. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-15711) Flaky TestEmbeddedThriftBinaryCLIService.testTaskStatus
[ https://issues.apache.org/jira/browse/HIVE-15711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thejas M Nair updated HIVE-15711: - Resolution: Fixed Status: Resolved (was: Patch Available) The change is test and the changed tests are passing. The other unrelated failures have cleared up in recent runs and others are tracked in umbrella jira. Committed to master. Thanks Anishek! > Flaky TestEmbeddedThriftBinaryCLIService.testTaskStatus > --- > > Key: HIVE-15711 > URL: https://issues.apache.org/jira/browse/HIVE-15711 > Project: Hive > Issue Type: Test > Components: Hive >Affects Versions: 2.1.1 >Reporter: anishek >Assignee: anishek >Priority: Minor > Fix For: 2.2.0 > > Attachments: HIVE-15711.1.patch > > > the above test is flaky and on the local build environments it keeps failing. > Fix to prevent it from failing intermittently. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-15712) new HiveConf in SQLOperation.getSerDe() impacts CPU on hiveserver2
[ https://issues.apache.org/jira/browse/HIVE-15712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thejas M Nair updated HIVE-15712: - Resolution: Fixed Status: Resolved (was: Patch Available) The failure in TestSparkCliDriver setup are unrelated, verified by running locally. Thanks for the patch [~anishek]! > new HiveConf in SQLOperation.getSerDe() impacts CPU on hiveserver2 > -- > > Key: HIVE-15712 > URL: https://issues.apache.org/jira/browse/HIVE-15712 > Project: Hive > Issue Type: Improvement > Components: HiveServer2 >Affects Versions: 2.1.1 >Reporter: anishek >Assignee: anishek > Fix For: 2.2.0 > > Attachments: HIVE-15712.1.patch, HIVE-15712.1.patch > > > On doing internal performance test, with about 10 concurrent users we found > that about 18% of CPU on hiveserver2 is spent in creation of new HiveConf() > in SQLOperation.getSerDe(). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-15713) add ldap authentication related configuration to restricted list
[ https://issues.apache.org/jira/browse/HIVE-15713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thejas M Nair updated HIVE-15713: - Resolution: Fixed Status: Resolved (was: Patch Available) Patch committed to master. Thanks for the patch [~anishek] > add ldap authentication related configuration to restricted list > > > Key: HIVE-15713 > URL: https://issues.apache.org/jira/browse/HIVE-15713 > Project: Hive > Issue Type: Improvement > Components: HiveServer2 >Affects Versions: 2.1.1 >Reporter: anishek >Assignee: anishek >Priority: Minor > Fix For: 2.2.0 > > Attachments: HIVE-15713.1.patch, HIVE-15713.1.patch > > > Various ldap configuration parameters as below should be added to the > restricted list of configuration parameters such that users cant change them > per session. > hive.server2.authentication.ldap.baseDN > hive.server2.authentication.ldap.url > hive.server2.authentication.ldap.Domain > hive.server2.authentication.ldap.groupDNPattern > hive.server2.authentication.ldap.groupFilter > hive.server2.authentication.ldap.userDNPattern > hive.server2.authentication.ldap.userFilter > hive.server2.authentication.ldap.groupMembershipKey > hive.server2.authentication.ldap.userMembershipKey > hive.server2.authentication.ldap.groupClassKey > hive.server2.authentication.ldap.customLDAPQuery -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-15712) new HiveConf in SQLOperation.getSerDe() impacts CPU on hiveserver2
[ https://issues.apache.org/jira/browse/HIVE-15712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15841008#comment-15841008 ] Thejas M Nair commented on HIVE-15712: -- Verifying the TestSparkCliDriver failures. Rest of them are now accounted for in HIVE-15058 > new HiveConf in SQLOperation.getSerDe() impacts CPU on hiveserver2 > -- > > Key: HIVE-15712 > URL: https://issues.apache.org/jira/browse/HIVE-15712 > Project: Hive > Issue Type: Improvement > Components: HiveServer2 >Affects Versions: 2.1.1 >Reporter: anishek >Assignee: anishek > Fix For: 2.2.0 > > Attachments: HIVE-15712.1.patch, HIVE-15712.1.patch > > > On doing internal performance test, with about 10 concurrent users we found > that about 18% of CPU on hiveserver2 is spent in creation of new HiveConf() > in SQLOperation.getSerDe(). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-15288) Flaky test: TestMiniTezCliDriver.testCliDriver[explainuser_3]
[ https://issues.apache.org/jira/browse/HIVE-15288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15840966#comment-15840966 ] Thejas M Nair commented on HIVE-15288: -- This is still failing - {code} Running: diff -a /home/hiveptest/104.154.128.167-hiveptest-1/apache-github-source-source/itests/qtest/target/qfile-results/clientpositive/explainuser_3.q.out /home/hiveptest/104.154.128.167-hiveptest-1/apache-github-source-source/ql/src/test/results/clientpositive/tez/explainuser_3.q.out 34c34 < Select Operator [SEL_7] (rows=16 width=107) --- > Select Operator [SEL_7] (rows=16 width=106) 38c38 < Select Operator [SEL_5] (rows=16 width=107) --- > Select Operator [SEL_5] (rows=16 width=106) 40c40 < TableScan [TS_0] (rows=16 width=107) --- > TableScan [TS_0] (rows=16 width=106) {code} > Flaky test: TestMiniTezCliDriver.testCliDriver[explainuser_3] > - > > Key: HIVE-15288 > URL: https://issues.apache.org/jira/browse/HIVE-15288 > Project: Hive > Issue Type: Sub-task >Reporter: Anthony Hsu >Assignee: Pengcheng Xiong > > explainuser_3.q sometimes fails with the following diff: > {noformat} > 34c34 > < Select Operator [SEL_7] (rows=16 width=106) > --- > > Select Operator [SEL_7] (rows=16 width=107) > 38c38 > < Select Operator [SEL_5] (rows=16 width=106) > --- > > Select Operator [SEL_5] (rows=16 width=107) > 40c40 > < TableScan [TS_0] (rows=16 width=106) > --- > > TableScan [TS_0] (rows=16 width=107) > {noformat} > It was also previously reported as flaky in HIVE-14689. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Reopened] (HIVE-15288) Flaky test: TestMiniTezCliDriver.testCliDriver[explainuser_3]
[ https://issues.apache.org/jira/browse/HIVE-15288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thejas M Nair reopened HIVE-15288: -- > Flaky test: TestMiniTezCliDriver.testCliDriver[explainuser_3] > - > > Key: HIVE-15288 > URL: https://issues.apache.org/jira/browse/HIVE-15288 > Project: Hive > Issue Type: Sub-task >Reporter: Anthony Hsu >Assignee: Pengcheng Xiong > > explainuser_3.q sometimes fails with the following diff: > {noformat} > 34c34 > < Select Operator [SEL_7] (rows=16 width=106) > --- > > Select Operator [SEL_7] (rows=16 width=107) > 38c38 > < Select Operator [SEL_5] (rows=16 width=106) > --- > > Select Operator [SEL_5] (rows=16 width=107) > 40c40 > < TableScan [TS_0] (rows=16 width=106) > --- > > TableScan [TS_0] (rows=16 width=107) > {noformat} > It was also previously reported as flaky in HIVE-14689. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-15699) Failing tests : encryption_join_with_different_encryption_keys, generatehfiles_require_family_path
[ https://issues.apache.org/jira/browse/HIVE-15699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15840962#comment-15840962 ] Thejas M Nair commented on HIVE-15699: -- [~pxiong] testCliDriver_encryption_join_with_different_encryption_keys is still failing. Can you please take a look ? Looks like the golden file hasn't been updated. https://builds.apache.org/job/PreCommit-HIVE-Build/3204/testReport/org.apache.hadoop.hive.cli/TestEncryptedHDFSCliDriver/testCliDriver_encryption_join_with_different_encryption_keys_/ > Failing tests : encryption_join_with_different_encryption_keys, > generatehfiles_require_family_path > -- > > Key: HIVE-15699 > URL: https://issues.apache.org/jira/browse/HIVE-15699 > Project: Hive > Issue Type: Sub-task >Reporter: Thejas M Nair >Assignee: Pengcheng Xiong > > Failing for 84 test runs as of > https://builds.apache.org/job/PreCommit-HIVE-Build/3108/testReport/ > > org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_join_with_different_encryption_keys] > > > org.apache.hadoop.hive.cli.TestHBaseNegativeCliDriver.testCliDriver[generatehfiles_require_family_path] > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Reopened] (HIVE-15699) Failing tests : encryption_join_with_different_encryption_keys, generatehfiles_require_family_path
[ https://issues.apache.org/jira/browse/HIVE-15699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thejas M Nair reopened HIVE-15699: -- > Failing tests : encryption_join_with_different_encryption_keys, > generatehfiles_require_family_path > -- > > Key: HIVE-15699 > URL: https://issues.apache.org/jira/browse/HIVE-15699 > Project: Hive > Issue Type: Sub-task >Reporter: Thejas M Nair >Assignee: Pengcheng Xiong > > Failing for 84 test runs as of > https://builds.apache.org/job/PreCommit-HIVE-Build/3108/testReport/ > > org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_join_with_different_encryption_keys] > > > org.apache.hadoop.hive.cli.TestHBaseNegativeCliDriver.testCliDriver[generatehfiles_require_family_path] > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-15744) Flaky test: TestPerfCliDriver.query23, query14
[ https://issues.apache.org/jira/browse/HIVE-15744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15840947#comment-15840947 ] Thejas M Nair commented on HIVE-15744: -- It looks like the line where these warnings are being printed is moving around. > Flaky test: TestPerfCliDriver.query23, query14 > -- > > Key: HIVE-15744 > URL: https://issues.apache.org/jira/browse/HIVE-15744 > Project: Hive > Issue Type: Sub-task >Affects Versions: 2.2.0 >Reporter: Thejas M Nair > > There is some flakiness in these tests - > https://builds.apache.org/job/PreCommit-HIVE-Build/3206/testReport/org.apache.hadoop.hive.cli/TestPerfCliDriver/testCliDriver_query23_/ > https://builds.apache.org/job/PreCommit-HIVE-Build/3204/testReport/org.apache.hadoop.hive.cli/TestPerfCliDriver/testCliDriver_query14_/ > The diff looks like this - > {code} > Running: diff -a > /home/hiveptest/130.211.230.155-hiveptest-1/apache-github-source-source/itests/qtest/target/qfile-results/clientpositive/query14.q.out > > /home/hiveptest/130.211.230.155-hiveptest-1/apache-github-source-source/ql/src/test/results/clientpositive/perf/query14.q.out > 0a1,2 > > Warning: Shuffle Join MERGEJOIN[916][tables = [$hdt$_1, $hdt$_2]] in Stage > > 'Reducer 114' is a cross product > > Warning: Shuffle Join MERGEJOIN[917][tables = [$hdt$_1, $hdt$_2, $hdt$_0]] > > in Stage 'Reducer 115' is a cross product > 5,6d6 > < Warning: Shuffle Join MERGEJOIN[916][tables = [$hdt$_1, $hdt$_2]] in Stage > 'Reducer 114' is a cross product > < Warning: Shuffle Join MERGEJOIN[917][tables = [$hdt$_1, $hdt$_2, $hdt$_0]] > in Stage 'Reducer 115' is a cross product > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-15734) LazySimpleDeserializeRead.readField needs to catch IllegalArgumentException
[ https://issues.apache.org/jira/browse/HIVE-15734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15840935#comment-15840935 ] Thejas M Nair commented on HIVE-15734: -- As agreed in the dev mailing list and documented in the wiki, please follow this process if there are failed tests - https://cwiki.apache.org/confluence/display/Hive/HowToCommit#HowToCommit-PreCommitruns,andcommittingpatches Specifically - Test runs may not be clean due to issues in the patch itself, or due to flaky tests. If the failure is identified to be a flaky test, before committing, cite the JIRA which covers the flaky test (tracked under HIVE-15058). Create a new one if a JIRA does not already exist. > LazySimpleDeserializeRead.readField needs to catch IllegalArgumentException > --- > > Key: HIVE-15734 > URL: https://issues.apache.org/jira/browse/HIVE-15734 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: Matt McCline >Assignee: Matt McCline >Priority: Critical > Fix For: 2.2.0 > > Attachments: HIVE-15734.01.patch > > > E.g. java.sql.Date.valueOf can throw that exception if it encounters a parse > error for a date. > With changes to CHAR padding, I think this may be why > schema_evol_text_vec_part.q is failing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-15546) Optimize Utilities.getInputPaths() so each listStatus of a partition is done in parallel
[ https://issues.apache.org/jira/browse/HIVE-15546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15840934#comment-15840934 ] Thejas M Nair commented on HIVE-15546: -- As agreed in the dev mailing list and documented in the wiki, please follow this process if there are failed tests - https://cwiki.apache.org/confluence/display/Hive/HowToCommit#HowToCommit-PreCommitruns,andcommittingpatches Specifically - Test runs may not be clean due to issues in the patch itself, or due to flaky tests. If the failure is identified to be a flaky test, before committing, cite the JIRA which covers the flaky test (tracked under HIVE-15058). Create a new one if a JIRA does not already exist. > Optimize Utilities.getInputPaths() so each listStatus of a partition is done > in parallel > > > Key: HIVE-15546 > URL: https://issues.apache.org/jira/browse/HIVE-15546 > Project: Hive > Issue Type: Sub-task > Components: Hive >Reporter: Sahil Takiar >Assignee: Sahil Takiar > Fix For: 2.2.0 > > Attachments: HIVE-15546.1.patch, HIVE-15546.2.patch, > HIVE-15546.3.patch, HIVE-15546.4.patch, HIVE-15546.5.patch, HIVE-15546.6.patch > > > When running on blobstores (like S3) where metadata operations (like > listStatus) are costly, Utilities.getInputPaths() can add significant > overhead when setting up the input paths for an MR / Spark / Tez job. > The method performs a listStatus on all input paths in order to check if the > path is empty. If the path is empty, a dummy file is created for the given > partition. This is all done sequentially. This can be really slow when there > are a lot of empty partitions. Even when all partitions have input data, this > can take a long time. > We should either: > (1) Just remove the logic to check if each input path is empty, and handle > any edge cases accordingly. > (2) Multi-thread the listStatus calls -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-15629) Set DDLTask’s exception with its subtask’s exception
[ https://issues.apache.org/jira/browse/HIVE-15629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15840932#comment-15840932 ] Thejas M Nair commented on HIVE-15629: -- As agreed in the dev mailing list and documented in the wiki, please follow this process if there are failed tests - https://cwiki.apache.org/confluence/display/Hive/HowToCommit#HowToCommit-PreCommitruns,andcommittingpatches Specifically - Test runs may not be clean due to issues in the patch itself, or due to flaky tests. If the failure is identified to be a flaky test, before committing, cite the JIRA which covers the flaky test (tracked under HIVE-15058). Create a new one if a JIRA does not already exist. > Set DDLTask’s exception with its subtask’s exception > > > Key: HIVE-15629 > URL: https://issues.apache.org/jira/browse/HIVE-15629 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 2.2.0 >Reporter: zhihai xu >Assignee: zhihai xu >Priority: Minor > Fix For: 2.2.0 > > Attachments: HIVE-15629.000.patch > > > Set DDLTask’s exception with its subtask’s exception, So the exception from > subtask in DDLTask can be propagated to TaskRunner. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-15472) JDBC: Standalone jar is missing ZK dependencies
[ https://issues.apache.org/jira/browse/HIVE-15472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15840762#comment-15840762 ] Thejas M Nair commented on HIVE-15472: -- I think master is fine. Most development is happening there. > JDBC: Standalone jar is missing ZK dependencies > --- > > Key: HIVE-15472 > URL: https://issues.apache.org/jira/browse/HIVE-15472 > Project: Hive > Issue Type: Bug > Components: JDBC >Affects Versions: 2.2.0 >Reporter: Gopal V >Assignee: Tao Li > Fix For: 2.2.0 > > Attachments: HIVE-15472.1.patch, HIVE-15472.2.patch > > > {code} > Exception in thread "main" java.lang.NoClassDefFoundError: > org/apache/curator/RetryPolicy > at org.apache.hive.jdbc.Utils.configureConnParams(Utils.java:514) > at org.apache.hive.jdbc.Utils.parseURL(Utils.java:434) > at org.apache.hive.jdbc.HiveConnection.(HiveConnection.java:132) > at org.apache.hive.jdbc.HiveDriver.connect(HiveDriver.java:107) > at java.sql.DriverManager.getConnection(DriverManager.java:664) > at java.sql.DriverManager.getConnection(DriverManager.java:247) > at JDBCExecutor.getConnection(JDBCExecutor.java:65) > at JDBCExecutor.executeStatement(JDBCExecutor.java:104) > at JDBCExecutor.executeSQLFile(JDBCExecutor.java:81) > at JDBCExecutor.main(JDBCExecutor.java:183) > Caused by: java.lang.ClassNotFoundException: org.apache.curator.RetryPolicy > at java.net.URLClassLoader.findClass(URLClassLoader.java:381) > at java.lang.ClassLoader.loadClass(ClassLoader.java:424) > at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331) > at java.lang.ClassLoader.loadClass(ClassLoader.java:357) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-15711) Flaky TestEmbeddedThriftBinaryCLIService.testTaskStatus
[ https://issues.apache.org/jira/browse/HIVE-15711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15840398#comment-15840398 ] Thejas M Nair commented on HIVE-15711: -- +1 > Flaky TestEmbeddedThriftBinaryCLIService.testTaskStatus > --- > > Key: HIVE-15711 > URL: https://issues.apache.org/jira/browse/HIVE-15711 > Project: Hive > Issue Type: Test > Components: Hive >Affects Versions: 2.1.1 >Reporter: anishek >Assignee: anishek >Priority: Minor > Fix For: 2.2.0 > > Attachments: HIVE-15711.1.patch > > > the above test is flaky and on the local build environments it keeps failing. > Fix to prevent it from failing intermittently. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-15713) add ldap authentication related configuration to restricted list
[ https://issues.apache.org/jira/browse/HIVE-15713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thejas M Nair updated HIVE-15713: - Assignee: anishek (was: Thejas M Nair) > add ldap authentication related configuration to restricted list > > > Key: HIVE-15713 > URL: https://issues.apache.org/jira/browse/HIVE-15713 > Project: Hive > Issue Type: Improvement > Components: HiveServer2 >Affects Versions: 2.1.1 >Reporter: anishek >Assignee: anishek >Priority: Minor > Fix For: 2.2.0 > > Attachments: HIVE-15713.1.patch, HIVE-15713.1.patch > > > Various ldap configuration parameters as below should be added to the > restricted list of configuration parameters such that users cant change them > per session. > hive.server2.authentication.ldap.baseDN > hive.server2.authentication.ldap.url > hive.server2.authentication.ldap.Domain > hive.server2.authentication.ldap.groupDNPattern > hive.server2.authentication.ldap.groupFilter > hive.server2.authentication.ldap.userDNPattern > hive.server2.authentication.ldap.userFilter > hive.server2.authentication.ldap.groupMembershipKey > hive.server2.authentication.ldap.userMembershipKey > hive.server2.authentication.ldap.groupClassKey > hive.server2.authentication.ldap.customLDAPQuery -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-15713) add ldap authentication related configuration to restricted list
[ https://issues.apache.org/jira/browse/HIVE-15713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15840383#comment-15840383 ] Thejas M Nair commented on HIVE-15713: -- +1 reattaching file to kick of tests once again. build #3202 > add ldap authentication related configuration to restricted list > > > Key: HIVE-15713 > URL: https://issues.apache.org/jira/browse/HIVE-15713 > Project: Hive > Issue Type: Improvement > Components: HiveServer2 >Affects Versions: 2.1.1 >Reporter: anishek >Assignee: anishek >Priority: Minor > Fix For: 2.2.0 > > Attachments: HIVE-15713.1.patch, HIVE-15713.1.patch > > > Various ldap configuration parameters as below should be added to the > restricted list of configuration parameters such that users cant change them > per session. > hive.server2.authentication.ldap.baseDN > hive.server2.authentication.ldap.url > hive.server2.authentication.ldap.Domain > hive.server2.authentication.ldap.groupDNPattern > hive.server2.authentication.ldap.groupFilter > hive.server2.authentication.ldap.userDNPattern > hive.server2.authentication.ldap.userFilter > hive.server2.authentication.ldap.groupMembershipKey > hive.server2.authentication.ldap.userMembershipKey > hive.server2.authentication.ldap.groupClassKey > hive.server2.authentication.ldap.customLDAPQuery -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-15712) new HiveConf in SQLOperation.getSerDe() impacts CPU on hiveserver2
[ https://issues.apache.org/jira/browse/HIVE-15712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thejas M Nair updated HIVE-15712: - Assignee: anishek (was: Thejas M Nair) > new HiveConf in SQLOperation.getSerDe() impacts CPU on hiveserver2 > -- > > Key: HIVE-15712 > URL: https://issues.apache.org/jira/browse/HIVE-15712 > Project: Hive > Issue Type: Improvement > Components: HiveServer2 >Affects Versions: 2.1.1 >Reporter: anishek >Assignee: anishek > Fix For: 2.2.0 > > Attachments: HIVE-15712.1.patch, HIVE-15712.1.patch > > > On doing internal performance test, with about 10 concurrent users we found > that about 18% of CPU on hiveserver2 is spent in creation of new HiveConf() > in SQLOperation.getSerDe(). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-15713) add ldap authentication related configuration to restricted list
[ https://issues.apache.org/jira/browse/HIVE-15713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thejas M Nair updated HIVE-15713: - Attachment: HIVE-15713.1.patch > add ldap authentication related configuration to restricted list > > > Key: HIVE-15713 > URL: https://issues.apache.org/jira/browse/HIVE-15713 > Project: Hive > Issue Type: Improvement > Components: HiveServer2 >Affects Versions: 2.1.1 >Reporter: anishek >Assignee: Thejas M Nair >Priority: Minor > Fix For: 2.2.0 > > Attachments: HIVE-15713.1.patch, HIVE-15713.1.patch > > > Various ldap configuration parameters as below should be added to the > restricted list of configuration parameters such that users cant change them > per session. > hive.server2.authentication.ldap.baseDN > hive.server2.authentication.ldap.url > hive.server2.authentication.ldap.Domain > hive.server2.authentication.ldap.groupDNPattern > hive.server2.authentication.ldap.groupFilter > hive.server2.authentication.ldap.userDNPattern > hive.server2.authentication.ldap.userFilter > hive.server2.authentication.ldap.groupMembershipKey > hive.server2.authentication.ldap.userMembershipKey > hive.server2.authentication.ldap.groupClassKey > hive.server2.authentication.ldap.customLDAPQuery -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (HIVE-15713) add ldap authentication related configuration to restricted list
[ https://issues.apache.org/jira/browse/HIVE-15713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thejas M Nair reassigned HIVE-15713: Assignee: Thejas M Nair (was: anishek) > add ldap authentication related configuration to restricted list > > > Key: HIVE-15713 > URL: https://issues.apache.org/jira/browse/HIVE-15713 > Project: Hive > Issue Type: Improvement > Components: HiveServer2 >Affects Versions: 2.1.1 >Reporter: anishek >Assignee: Thejas M Nair >Priority: Minor > Fix For: 2.2.0 > > Attachments: HIVE-15713.1.patch, HIVE-15713.1.patch > > > Various ldap configuration parameters as below should be added to the > restricted list of configuration parameters such that users cant change them > per session. > hive.server2.authentication.ldap.baseDN > hive.server2.authentication.ldap.url > hive.server2.authentication.ldap.Domain > hive.server2.authentication.ldap.groupDNPattern > hive.server2.authentication.ldap.groupFilter > hive.server2.authentication.ldap.userDNPattern > hive.server2.authentication.ldap.userFilter > hive.server2.authentication.ldap.groupMembershipKey > hive.server2.authentication.ldap.userMembershipKey > hive.server2.authentication.ldap.groupClassKey > hive.server2.authentication.ldap.customLDAPQuery -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-15712) new HiveConf in SQLOperation.getSerDe() impacts CPU on hiveserver2
[ https://issues.apache.org/jira/browse/HIVE-15712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15840374#comment-15840374 ] Thejas M Nair commented on HIVE-15712: -- +1 to the changes. Attaching file again to kick off the tests. > new HiveConf in SQLOperation.getSerDe() impacts CPU on hiveserver2 > -- > > Key: HIVE-15712 > URL: https://issues.apache.org/jira/browse/HIVE-15712 > Project: Hive > Issue Type: Improvement > Components: HiveServer2 >Affects Versions: 2.1.1 >Reporter: anishek >Assignee: Thejas M Nair > Fix For: 2.2.0 > > Attachments: HIVE-15712.1.patch, HIVE-15712.1.patch > > > On doing internal performance test, with about 10 concurrent users we found > that about 18% of CPU on hiveserver2 is spent in creation of new HiveConf() > in SQLOperation.getSerDe(). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-15712) new HiveConf in SQLOperation.getSerDe() impacts CPU on hiveserver2
[ https://issues.apache.org/jira/browse/HIVE-15712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15840377#comment-15840377 ] Thejas M Nair commented on HIVE-15712: -- Kicked off build 3201 > new HiveConf in SQLOperation.getSerDe() impacts CPU on hiveserver2 > -- > > Key: HIVE-15712 > URL: https://issues.apache.org/jira/browse/HIVE-15712 > Project: Hive > Issue Type: Improvement > Components: HiveServer2 >Affects Versions: 2.1.1 >Reporter: anishek >Assignee: Thejas M Nair > Fix For: 2.2.0 > > Attachments: HIVE-15712.1.patch, HIVE-15712.1.patch > > > On doing internal performance test, with about 10 concurrent users we found > that about 18% of CPU on hiveserver2 is spent in creation of new HiveConf() > in SQLOperation.getSerDe(). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-15712) new HiveConf in SQLOperation.getSerDe() impacts CPU on hiveserver2
[ https://issues.apache.org/jira/browse/HIVE-15712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thejas M Nair updated HIVE-15712: - Attachment: HIVE-15712.1.patch > new HiveConf in SQLOperation.getSerDe() impacts CPU on hiveserver2 > -- > > Key: HIVE-15712 > URL: https://issues.apache.org/jira/browse/HIVE-15712 > Project: Hive > Issue Type: Improvement > Components: HiveServer2 >Affects Versions: 2.1.1 >Reporter: anishek >Assignee: Thejas M Nair > Fix For: 2.2.0 > > Attachments: HIVE-15712.1.patch, HIVE-15712.1.patch > > > On doing internal performance test, with about 10 concurrent users we found > that about 18% of CPU on hiveserver2 is spent in creation of new HiveConf() > in SQLOperation.getSerDe(). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (HIVE-15712) new HiveConf in SQLOperation.getSerDe() impacts CPU on hiveserver2
[ https://issues.apache.org/jira/browse/HIVE-15712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thejas M Nair reassigned HIVE-15712: Assignee: Thejas M Nair (was: anishek) > new HiveConf in SQLOperation.getSerDe() impacts CPU on hiveserver2 > -- > > Key: HIVE-15712 > URL: https://issues.apache.org/jira/browse/HIVE-15712 > Project: Hive > Issue Type: Improvement > Components: HiveServer2 >Affects Versions: 2.1.1 >Reporter: anishek >Assignee: Thejas M Nair > Fix For: 2.2.0 > > Attachments: HIVE-15712.1.patch, HIVE-15712.1.patch > > > On doing internal performance test, with about 10 concurrent users we found > that about 18% of CPU on hiveserver2 is spent in creation of new HiveConf() > in SQLOperation.getSerDe(). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-15569) failures in RetryingHMSHandler. do not get retried
[ https://issues.apache.org/jira/browse/HIVE-15569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15840176#comment-15840176 ] Thejas M Nair commented on HIVE-15569: -- [~vihangk1] Thanks for the patch and the good set of tests with comments! I am sorry, didn't get to review it in time earlier. > failures in RetryingHMSHandler. do not get retried > > > Key: HIVE-15569 > URL: https://issues.apache.org/jira/browse/HIVE-15569 > Project: Hive > Issue Type: Bug >Reporter: Thejas M Nair >Assignee: Vihang Karajgaonkar > Fix For: 2.2.0 > > Attachments: HIVE-15569.01.patch, HIVE-15569.02.patch > > > RetryingHMSHandler. is called during Hive metastore startup, and any > transient db failures during that call are not retried. This can result in > failure for HiveMetastore startup. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-15717) Class "org.apache.hive.beeline.Rows.Row" constructor is CPU consuming due to exception handling
[ https://issues.apache.org/jira/browse/HIVE-15717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15840057#comment-15840057 ] Thejas M Nair commented on HIVE-15717: -- [~taoli-hwx] can you also add a simple unit test ? > Class "org.apache.hive.beeline.Rows.Row" constructor is CPU consuming due to > exception handling > --- > > Key: HIVE-15717 > URL: https://issues.apache.org/jira/browse/HIVE-15717 > Project: Hive > Issue Type: Improvement >Reporter: Tao Li >Assignee: Tao Li > Attachments: HIVE-15717.1.patch, Screen Shot 2017-01-24 at 3.11.09 > PM.png, Screen Shot 2017-01-24 at 3.15.14 PM.png > > > The exception handling from the 3 methods calls (rowDeleted, rowInserted and > rowUpdated). The implementation of these methods in > org.apache.hive.jdbc.HiveBaseResultSet class is just throwing > SQLException("Method not supported”), i.e. no real implementations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-15717) Class "org.apache.hive.beeline.Rows.Row" constructor is CPU consuming due to exception handling
[ https://issues.apache.org/jira/browse/HIVE-15717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15838798#comment-15838798 ] Thejas M Nair commented on HIVE-15717: -- [~taoli-hwx] Returning false looks appropriate in this case. We don't support delete/insert/update in HiveBaseResultSet. A possible future optimization for beeline would be to recognize 'SQLFeatureNotSupportedException' exception and not make further calls to it. Created a related jira around use of 'SQLFeatureNotSupportedException' - HIVE-15730 > Class "org.apache.hive.beeline.Rows.Row" constructor is CPU consuming due to > exception handling > --- > > Key: HIVE-15717 > URL: https://issues.apache.org/jira/browse/HIVE-15717 > Project: Hive > Issue Type: Improvement >Reporter: Tao Li >Assignee: Tao Li > Attachments: Screen Shot 2017-01-24 at 3.11.09 PM.png, Screen Shot > 2017-01-24 at 3.15.14 PM.png > > > The exception handling from the 3 methods calls (rowDeleted, rowInserted and > rowUpdated). The implementation of these methods in > org.apache.hive.jdbc.HiveBaseResultSet class is just throwing > SQLException("Method not supported”), i.e. no real implementations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)