[jira] [Commented] (KYLIN-3698) check-env.sh should print more details about checking items
[
https://issues.apache.org/jira/browse/KYLIN-3698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142646#comment-17142646
]
ASF GitHub Bot commented on KYLIN-3698:
---
zhangayqian commented on a change in pull request #1222:
URL: https://github.com/apache/kylin/pull/1222#discussion_r443982825
##
File path: build/bin/kylin.sh
##
@@ -40,16 +40,10 @@ function retrieveDependency() {
source ${dir}/cached-hive-dependency.sh
source ${dir}/cached-hbase-dependency.sh
source ${dir}/cached-hadoop-conf-dir.sh
-source ${dir}/cached-kafka-dependency.sh
Review comment:
Because these three checks are put in check-env.sh, there is no need to
check them again here.
But now it is found that some tool commands, such as `bin/kylin.sh
org.apache.kylin.source.kafka.util.KafkaSampleProducer`, require Kafka's
dependency. However, the check-env.sh is not executed when using this command,
which makes it unable to load Kafka's dependency.
This is my negligence. It should not be removed here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> check-env.sh should print more details about checking items
> ---
>
> Key: KYLIN-3698
> URL: https://issues.apache.org/jira/browse/KYLIN-3698
> Project: Kylin
> Issue Type: Improvement
> Components: Tools, Build and Test
>Affects Versions: v2.5.1
>Reporter: May Zhou
>Assignee: Yaqian Zhang
>Priority: Minor
> Fix For: v3.1.0
>
> Original Estimate: 8h
> Remaining Estimate: 8h
>
> In the current version, when users run _check-env.sh_, if there's no error
> message, it means everything is OK.
> From my perspective, adding more details about the checking items when
> executing check-env.sh is better.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (KYLIN-3698) check-env.sh should print more details about checking items
[
https://issues.apache.org/jira/browse/KYLIN-3698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142636#comment-17142636
]
ASF GitHub Bot commented on KYLIN-3698:
---
hit-lacus commented on a change in pull request #1222:
URL: https://github.com/apache/kylin/pull/1222#discussion_r443964079
##
File path: build/bin/kylin.sh
##
@@ -40,16 +40,10 @@ function retrieveDependency() {
source ${dir}/cached-hive-dependency.sh
source ${dir}/cached-hbase-dependency.sh
source ${dir}/cached-hadoop-conf-dir.sh
-source ${dir}/cached-kafka-dependency.sh
Review comment:
Why should remove these lines?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> check-env.sh should print more details about checking items
> ---
>
> Key: KYLIN-3698
> URL: https://issues.apache.org/jira/browse/KYLIN-3698
> Project: Kylin
> Issue Type: Improvement
> Components: Tools, Build and Test
>Affects Versions: v2.5.1
>Reporter: May Zhou
>Assignee: Yaqian Zhang
>Priority: Minor
> Fix For: v3.1.0
>
> Original Estimate: 8h
> Remaining Estimate: 8h
>
> In the current version, when users run _check-env.sh_, if there's no error
> message, it means everything is OK.
> From my perspective, adding more details about the checking items when
> executing check-env.sh is better.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (KYLIN-3698) check-env.sh should print more details about checking items
[ https://issues.apache.org/jira/browse/KYLIN-3698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126264#comment-17126264 ] nichunen commented on KYLIN-3698: - Verified. > check-env.sh should print more details about checking items > --- > > Key: KYLIN-3698 > URL: https://issues.apache.org/jira/browse/KYLIN-3698 > Project: Kylin > Issue Type: Improvement > Components: Tools, Build and Test >Affects Versions: v2.5.1 >Reporter: May Zhou >Assignee: Yaqian Zhang >Priority: Minor > Fix For: v3.1.0 > > Original Estimate: 8h > Remaining Estimate: 8h > > In the current version, when users run _check-env.sh_, if there's no error > message, it means everything is OK. > From my perspective, adding more details about the checking items when > executing check-env.sh is better. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-3698) check-env.sh should print more details about checking items
[ https://issues.apache.org/jira/browse/KYLIN-3698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114664#comment-17114664 ] ASF subversion and git services commented on KYLIN-3698: Commit 178c7377d39b004144e54b1c931c92be82fe76de in kylin's branch refs/heads/master from yaqian.zhang [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=178c737 ] KYLIN-3698 Fix kylin.sh can't export spark/flink/kafka dependency > check-env.sh should print more details about checking items > --- > > Key: KYLIN-3698 > URL: https://issues.apache.org/jira/browse/KYLIN-3698 > Project: Kylin > Issue Type: Improvement > Components: Tools, Build and Test >Affects Versions: v2.5.1 >Reporter: May Zhou >Assignee: Yaqian Zhang >Priority: Minor > Fix For: v3.1.0 > > Original Estimate: 8h > Remaining Estimate: 8h > > In the current version, when users run _check-env.sh_, if there's no error > message, it means everything is OK. > From my perspective, adding more details about the checking items when > executing check-env.sh is better. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-3698) check-env.sh should print more details about checking items
[ https://issues.apache.org/jira/browse/KYLIN-3698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114665#comment-17114665 ] ASF GitHub Bot commented on KYLIN-3698: --- nichunen merged pull request #1227: URL: https://github.com/apache/kylin/pull/1227 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > check-env.sh should print more details about checking items > --- > > Key: KYLIN-3698 > URL: https://issues.apache.org/jira/browse/KYLIN-3698 > Project: Kylin > Issue Type: Improvement > Components: Tools, Build and Test >Affects Versions: v2.5.1 >Reporter: May Zhou >Assignee: Yaqian Zhang >Priority: Minor > Fix For: v3.1.0 > > Original Estimate: 8h > Remaining Estimate: 8h > > In the current version, when users run _check-env.sh_, if there's no error > message, it means everything is OK. > From my perspective, adding more details about the checking items when > executing check-env.sh is better. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-3698) check-env.sh should print more details about checking items
[ https://issues.apache.org/jira/browse/KYLIN-3698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113780#comment-17113780 ] ASF GitHub Bot commented on KYLIN-3698: --- codecov-commenter commented on pull request #1227: URL: https://github.com/apache/kylin/pull/1227#issuecomment-632504460 # [Codecov](https://codecov.io/gh/apache/kylin/pull/1227?src=pr=h1) Report > Merging [#1227](https://codecov.io/gh/apache/kylin/pull/1227?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/e7ab5dfd4431a5b410813311fa5e5a983e9aa4f2=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `0.71%`. [](https://codecov.io/gh/apache/kylin/pull/1227?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1227 +/- ## - Coverage 24.87% 24.84% -0.04% - Complexity 6264 6265 +1 Files 1453 1453 Lines 8912589225 +100 Branches 1244012456 +16 - Hits 2217422171 -3 - Misses6477464877 +103 Partials 2177 2177 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1227?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/1227/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `12.12% <0.00%> (-0.04%)` | `44.00 <0.00> (ø)` | | | [...ache/kylin/engine/mr/common/AbstractHadoopJob.java](https://codecov.io/gh/apache/kylin/pull/1227/diff?src=pr=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL0Fic3RyYWN0SGFkb29wSm9iLmphdmE=) | `15.44% <0.00%> (+0.23%)` | `2.00 <0.00> (ø)` | | | [...engine/mr/steps/ConvergeCuboidDataPartitioner.java](https://codecov.io/gh/apache/kylin/pull/1227/diff?src=pr=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvc3RlcHMvQ29udmVyZ2VDdWJvaWREYXRhUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...lin/engine/mr/steps/FactDistinctColumnsMapper.java](https://codecov.io/gh/apache/kylin/pull/1227/diff?src=pr=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvc3RlcHMvRmFjdERpc3RpbmN0Q29sdW1uc01hcHBlci5qYXZh) | `5.17% <0.00%> (-0.05%)` | `0.00 <0.00> (ø)` | | | [...che/kylin/storage/hbase/steps/CreateHTableJob.java](https://codecov.io/gh/apache/kylin/pull/1227/diff?src=pr=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9zdGVwcy9DcmVhdGVIVGFibGVKb2IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...apache/kylin/storage/hbase/steps/CubeHFileJob.java](https://codecov.io/gh/apache/kylin/pull/1227/diff?src=pr=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9zdGVwcy9DdWJlSEZpbGVKb2IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ache/kylin/storage/hbase/steps/CubeHTableUtil.java](https://codecov.io/gh/apache/kylin/pull/1227/diff?src=pr=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9zdGVwcy9DdWJlSFRhYmxlVXRpbC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [.../kylin/storage/hbase/steps/HFileOutputFormat3.java](https://codecov.io/gh/apache/kylin/pull/1227/diff?src=pr=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9zdGVwcy9IRmlsZU91dHB1dEZvcm1hdDMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...in/storage/hbase/lookup/HBaseLookupRowEncoder.java](https://codecov.io/gh/apache/kylin/pull/1227/diff?src=pr=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9sb29rdXAvSEJhc2VMb29rdXBSb3dFbmNvZGVyLmphdmE=) | `92.59% <100.00%> (ø)` | `11.00 <0.00> (ø)` | | | [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1227/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `52.27% <0.00%> (-3.41%)` | `8.00% <0.00%> (ø%)` | | | ... and [2 more](https://codecov.io/gh/apache/kylin/pull/1227/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1227?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not
[jira] [Commented] (KYLIN-3698) check-env.sh should print more details about checking items
[ https://issues.apache.org/jira/browse/KYLIN-3698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113770#comment-17113770 ] ASF GitHub Bot commented on KYLIN-3698: --- zhangayqian opened a new pull request #1227: URL: https://github.com/apache/kylin/pull/1227 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If this change need a document change, I will prepare another pr against the `document` branch - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > check-env.sh should print more details about checking items > --- > > Key: KYLIN-3698 > URL: https://issues.apache.org/jira/browse/KYLIN-3698 > Project: Kylin > Issue Type: Improvement > Components: Tools, Build and Test >Affects Versions: v2.5.1 >Reporter: May Zhou >Assignee: Yaqian Zhang >Priority: Minor > Fix For: v3.1.0 > > Original Estimate: 8h > Remaining Estimate: 8h > > In the current version, when users run _check-env.sh_, if there's no error > message, it means everything is OK. > From my perspective, adding more details about the checking items when > executing check-env.sh is better. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-3698) check-env.sh should print more details about checking items
[ https://issues.apache.org/jira/browse/KYLIN-3698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113703#comment-17113703 ] ASF subversion and git services commented on KYLIN-3698: Commit a471808626ee9349173255d329673c509b5f4037 in kylin's branch refs/heads/master from yaqian.zhang [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=a471808 ] KYLIN-3698 some enhancement for check-env.sh > check-env.sh should print more details about checking items > --- > > Key: KYLIN-3698 > URL: https://issues.apache.org/jira/browse/KYLIN-3698 > Project: Kylin > Issue Type: Improvement > Components: Tools, Build and Test >Affects Versions: v2.5.1 >Reporter: May Zhou >Assignee: Yaqian Zhang >Priority: Minor > Fix For: v3.1.0 > > Original Estimate: 8h > Remaining Estimate: 8h > > In the current version, when users run _check-env.sh_, if there's no error > message, it means everything is OK. > From my perspective, adding more details about the checking items when > executing check-env.sh is better. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-3698) check-env.sh should print more details about checking items
[ https://issues.apache.org/jira/browse/KYLIN-3698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113704#comment-17113704 ] ASF GitHub Bot commented on KYLIN-3698: --- nichunen merged pull request #1222: URL: https://github.com/apache/kylin/pull/1222 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > check-env.sh should print more details about checking items > --- > > Key: KYLIN-3698 > URL: https://issues.apache.org/jira/browse/KYLIN-3698 > Project: Kylin > Issue Type: Improvement > Components: Tools, Build and Test >Affects Versions: v2.5.1 >Reporter: May Zhou >Assignee: Yaqian Zhang >Priority: Minor > Fix For: v3.1.0 > > Original Estimate: 8h > Remaining Estimate: 8h > > In the current version, when users run _check-env.sh_, if there's no error > message, it means everything is OK. > From my perspective, adding more details about the checking items when > executing check-env.sh is better. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-3698) check-env.sh should print more details about checking items
[ https://issues.apache.org/jira/browse/KYLIN-3698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112066#comment-17112066 ] ASF GitHub Bot commented on KYLIN-3698: --- coveralls commented on pull request #1222: URL: https://github.com/apache/kylin/pull/1222#issuecomment-631408827 ## Pull Request Test Coverage Report for [Build 5921](https://coveralls.io/builds/30915293) * **0** of **0** changed or added relevant lines in **0** files are covered. * **6** unchanged lines in **3** files lost coverage. * Overall coverage decreased (**-0.001%**) to **27.293%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java](https://coveralls.io/builds/30915293/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarStoreCache.java#L146) | 1 | 56.82% | | [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/30915293/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124) | 2 | 68.46% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/30915293/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449) | 3 | 78.42% | | Totals | [](https://coveralls.io/builds/30915293) | | :-- | --: | | Change from base [Build 5911](https://coveralls.io/builds/30861301): | -0.001% | | Covered Lines: | 24352 | | Relevant Lines: | 89225 | --- # - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > check-env.sh should print more details about checking items > --- > > Key: KYLIN-3698 > URL: https://issues.apache.org/jira/browse/KYLIN-3698 > Project: Kylin > Issue Type: Improvement > Components: Tools, Build and Test >Affects Versions: v2.5.1 >Reporter: May Zhou >Assignee: Yaqian Zhang >Priority: Minor > Fix For: v3.1.0 > > Original Estimate: 8h > Remaining Estimate: 8h > > In the current version, when users run _check-env.sh_, if there's no error > message, it means everything is OK. > From my perspective, adding more details about the checking items when > executing check-env.sh is better. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-3698) check-env.sh should print more details about checking items
[ https://issues.apache.org/jira/browse/KYLIN-3698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112064#comment-17112064 ] ASF GitHub Bot commented on KYLIN-3698: --- codecov-commenter commented on pull request #1222: URL: https://github.com/apache/kylin/pull/1222#issuecomment-631407258 # [Codecov](https://codecov.io/gh/apache/kylin/pull/1222?src=pr=h1) Report > Merging [#1222](https://codecov.io/gh/apache/kylin/pull/1222?src=pr=desc) into [master](https://codecov.io/gh/apache/kylin/commit/7886a2498178ded085497d6204b4b367f56ce0c8=desc) will **decrease** coverage by `0.00%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/kylin/pull/1222?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1222 +/- ## - Coverage 24.85% 24.84% -0.01% + Complexity 6266 6264 -2 Files 1453 1453 Lines 8922589225 Branches 1245612456 - Hits 2217522171 -4 - Misses6487464876 +2 - Partials 2176 2178 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1222?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/1222/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==) | `35.71% <0.00%> (-4.77%)` | `5.00% <0.00%> (-1.00%)` | | | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/1222/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0.00%> (-2.31%)` | `0.00% <0.00%> (ø%)` | | | [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1222/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `50.00% <0.00%> (-2.28%)` | `7.00% <0.00%> (-1.00%)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1222/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `70.21% <0.00%> (+0.91%)` | `7.00% <0.00%> (ø%)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1222?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1222?src=pr=footer). Last update [7886a24...e2e51bb](https://codecov.io/gh/apache/kylin/pull/1222?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > check-env.sh should print more details about checking items > --- > > Key: KYLIN-3698 > URL: https://issues.apache.org/jira/browse/KYLIN-3698 > Project: Kylin > Issue Type: Improvement > Components: Tools, Build and Test >Affects Versions: v2.5.1 >Reporter: May Zhou >Assignee: Yaqian Zhang >Priority: Minor > Fix For: v3.1.0 > > Original Estimate: 8h > Remaining Estimate: 8h > > In the current version, when users run _check-env.sh_, if there's no error > message, it means everything is OK. > From my perspective, adding more details about the checking items when > executing check-env.sh is better. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-3698) check-env.sh should print more details about checking items
[ https://issues.apache.org/jira/browse/KYLIN-3698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112044#comment-17112044 ] ASF GitHub Bot commented on KYLIN-3698: --- zhangayqian commented on pull request #1222: URL: https://github.com/apache/kylin/pull/1222#issuecomment-631397290 Evidence:    This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > check-env.sh should print more details about checking items > --- > > Key: KYLIN-3698 > URL: https://issues.apache.org/jira/browse/KYLIN-3698 > Project: Kylin > Issue Type: Improvement > Components: Tools, Build and Test >Affects Versions: v2.5.1 >Reporter: May Zhou >Assignee: Yaqian Zhang >Priority: Minor > Fix For: v3.1.0 > > Original Estimate: 8h > Remaining Estimate: 8h > > In the current version, when users run _check-env.sh_, if there's no error > message, it means everything is OK. > From my perspective, adding more details about the checking items when > executing check-env.sh is better. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-3698) check-env.sh should print more details about checking items
[ https://issues.apache.org/jira/browse/KYLIN-3698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112037#comment-17112037 ] ASF GitHub Bot commented on KYLIN-3698: --- zhangayqian opened a new pull request #1222: URL: https://github.com/apache/kylin/pull/1222 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If this change need a document change, I will prepare another pr against the `document` branch - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > check-env.sh should print more details about checking items > --- > > Key: KYLIN-3698 > URL: https://issues.apache.org/jira/browse/KYLIN-3698 > Project: Kylin > Issue Type: Improvement > Components: Tools, Build and Test >Affects Versions: v2.5.1 >Reporter: May Zhou >Assignee: Yaqian Zhang >Priority: Minor > Fix For: v3.1.0 > > Original Estimate: 8h > Remaining Estimate: 8h > > In the current version, when users run _check-env.sh_, if there's no error > message, it means everything is OK. > From my perspective, adding more details about the checking items when > executing check-env.sh is better. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-3698) check-env.sh should print more details about checking items
[ https://issues.apache.org/jira/browse/KYLIN-3698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106965#comment-17106965 ] ASF GitHub Bot commented on KYLIN-3698: --- shaofengshi merged pull request #1202: URL: https://github.com/apache/kylin/pull/1202 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > check-env.sh should print more details about checking items > --- > > Key: KYLIN-3698 > URL: https://issues.apache.org/jira/browse/KYLIN-3698 > Project: Kylin > Issue Type: Improvement > Components: Tools, Build and Test >Affects Versions: v2.5.1 >Reporter: May Zhou >Assignee: Yaqian Zhang >Priority: Minor > Fix For: v3.1.0 > > Original Estimate: 8h > Remaining Estimate: 8h > > In the current version, when users run _check-env.sh_, if there's no error > message, it means everything is OK. > From my perspective, adding more details about the checking items when > executing check-env.sh is better. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-3698) check-env.sh should print more details about checking items
[ https://issues.apache.org/jira/browse/KYLIN-3698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106966#comment-17106966 ] ASF subversion and git services commented on KYLIN-3698: Commit 3774cae5efe318c20bbe2f80c20c74c5d0532b49 in kylin's branch refs/heads/master from yaqian.zhang [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=3774cae ] KYLIN-3698 check-env.sh should print more details about checking items > check-env.sh should print more details about checking items > --- > > Key: KYLIN-3698 > URL: https://issues.apache.org/jira/browse/KYLIN-3698 > Project: Kylin > Issue Type: Improvement > Components: Tools, Build and Test >Affects Versions: v2.5.1 >Reporter: May Zhou >Assignee: Yaqian Zhang >Priority: Minor > Fix For: v3.1.0 > > Original Estimate: 8h > Remaining Estimate: 8h > > In the current version, when users run _check-env.sh_, if there's no error > message, it means everything is OK. > From my perspective, adding more details about the checking items when > executing check-env.sh is better. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-3698) check-env.sh should print more details about checking items
[ https://issues.apache.org/jira/browse/KYLIN-3698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102410#comment-17102410 ] ASF GitHub Bot commented on KYLIN-3698: --- zhangayqian opened a new pull request #1202: URL: https://github.com/apache/kylin/pull/1202 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN- Make Kylin project open-source" - [ ] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If this change need a document change, I will prepare another pr against the `document` branch - [ ] Any dependent changes have been merged ## Further comments If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > check-env.sh should print more details about checking items > --- > > Key: KYLIN-3698 > URL: https://issues.apache.org/jira/browse/KYLIN-3698 > Project: Kylin > Issue Type: Improvement > Components: Tools, Build and Test >Affects Versions: v2.5.1 >Reporter: May Zhou >Assignee: Yaqian Zhang >Priority: Minor > Fix For: v3.1.0 > > Original Estimate: 8h > Remaining Estimate: 8h > > In the current version, when users run _check-env.sh_, if there's no error > message, it means everything is OK. > From my perspective, adding more details about the checking items when > executing check-env.sh is better. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KYLIN-3698) check-env.sh should print more details about checking items
[ https://issues.apache.org/jira/browse/KYLIN-3698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728279#comment-16728279 ] Zhong Yanghong commented on KYLIN-3698: --- Hi [~DDDQ], what's the status of this? Can we move this to the next release? > check-env.sh should print more details about checking items > --- > > Key: KYLIN-3698 > URL: https://issues.apache.org/jira/browse/KYLIN-3698 > Project: Kylin > Issue Type: Improvement >Affects Versions: v2.5.1 >Reporter: May Zhou >Assignee: May Zhou >Priority: Minor > Fix For: v2.6.0 > > > In the current version, when users run _check-env.sh_, if there's no error > message, it means everything is OK. > From my perspective, adding more details about the checking items when > executing check-env.sh is better. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KYLIN-3698) check-env.sh should print more details about checking items
[ https://issues.apache.org/jira/browse/KYLIN-3698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693325#comment-16693325 ] May Zhou commented on KYLIN-3698: - As this issue is not that urgent, I would like to contribute a patch myself. :) > check-env.sh should print more details about checking items > --- > > Key: KYLIN-3698 > URL: https://issues.apache.org/jira/browse/KYLIN-3698 > Project: Kylin > Issue Type: Improvement >Affects Versions: v2.5.1 >Reporter: May Zhou >Priority: Minor > > In the current version, when users run _check-env.sh_, if there's no error > message, it means everything is OK. > From my perspective, adding more details about the checking items when > executing check-env.sh is better. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
